#10 Add the X-WR-CALNAME property to the ICS

Merged
rsd merged 1 commits from mmu_man/calname into rsd/master 6 years ago
mmu_man commented 6 years ago

Giggity doesn't like when it's missing.

[Giggity](https://github.com/Wilm0r/giggity) doesn't like when it's missing.

@mmu_man, Thanks for the PR!

The patch looks good except for two minor nits:

  • To maintain uniformity with the rest of the self.cal.add calls in __init__, it would be nice to make X-WR-CALNAME lowercase (x-wr-calname).
  • Instead of the lp_year, it would be nice to use self.lp_year.
@mmu_man, Thanks for the PR! The patch looks good except for two minor nits: * To maintain uniformity with the rest of the `self.cal.add` calls in `__init__`, it would be nice to make `X-WR-CALNAME` lowercase (`x-wr-calname`). * Instead of the `lp_year`, it would be nice to use `self.lp_year`.
mmu_man commented 6 years ago
Poster

Oh right, the lib upcases the keys by itself.

Oh right, the lib upcases the keys by itself.
mmu_man commented 6 years ago
Poster

There you go :)

There you go :)

Thank you @mmu_man!

Thank you @mmu_man!
This pull request has been merged successfully!
Sign in to join this conversation.
No Milestone
2 Participants
Loading...
Cancel
Save
There is no content yet.