To maintain uniformity with the rest of the self.cal.add calls in __init__, it would be nice to make X-WR-CALNAME lowercase (x-wr-calname).
Instead of the lp_year, it would be nice to use self.lp_year.
@mmu_man, Thanks for the PR!
The patch looks good except for two minor nits:
* To maintain uniformity with the rest of the `self.cal.add` calls in `__init__`, it would be nice to make `X-WR-CALNAME` lowercase (`x-wr-calname`).
* Instead of the `lp_year`, it would be nice to use `self.lp_year`.
siddharth ravikumar
Giggity doesn't like when it's missing.
@mmu_man, Thanks for the PR!
The patch looks good except for two minor nits:
self.cal.addcalls in__init__, it would be nice to makeX-WR-CALNAMElowercase (x-wr-calname).lp_year, it would be nice to useself.lp_year.Oh right, the lib upcases the keys by itself.
There you go :)
Thank you @mmu_man!