#24 Starting french translation (faq.fr.md)

Closed
Ghost wants to merge 0 commits from deleted into libreboot/master
Ghost commented 1 year ago

Hi,

Im starting the french translation, so I created the lang folder and all that's needed according to Untitled documentation. Started translating the FAQ (faq.md), more updates to come.

Thanks you, randomomumu

Hi, Im starting the french translation, so I created the lang folder and all that's needed according to Untitled documentation. Started translating the FAQ (faq.md), more updates to come. Thanks you, randomomumu

Merci!

Merci!
Leah Rowe commented 1 year ago
Owner

hey, sorry for not seeing this sooner. can you rebase this on the latest version of the libreboot site?

a lot has changed

hey, sorry for not seeing this sooner. can you rebase this on the latest version of the libreboot site? a lot has changed
Leah Rowe commented 1 year ago
Owner

the best way to get my attention is on irc when you need me to do something. i'm leah on libera irc, in the libreboot channel

the best way to get my attention is on irc when you need me to do something. i'm `leah` on libera irc, in the libreboot channel
Leah Rowe commented 1 year ago
Owner

hi, thanks for rebasing. just one thing:

so far, I notice that the FAQ page is not translated at all; not only this but it is also the old FAQ page, prior to the osboot merge. the political tone and overall substance of the FAQ is quite different, on post-merge libreboot

can you delete faq.fr.md in your pull request? (alternatively, re-do it based upon the current faq.md page)

i'm looking through the files. i'll report on any other issues i find

hi, thanks for rebasing. just one thing: so far, I notice that the FAQ page is not translated at all; not only this but it is also the old FAQ page, prior to the osboot merge. the political tone and overall substance of the FAQ is quite different, on post-merge libreboot can you delete `faq.fr.md` in your pull request? (alternatively, re-do it based upon the current `faq.md` page) i'm looking through the files. i'll report on any other issues i find
Leah Rowe commented 1 year ago
Owner

another problem: site/contact.fr.md is also the old one, translated. however, the only recent change has been that i no longer link to twitter (i've stopped using twitter)

another problem: `site/contact.fr.md` is also the old one, translated. however, the only recent change has been that i no longer link to twitter (i've stopped using twitter)
Leah Rowe commented 1 year ago
Owner

ok, i've finished my review:

I will not merge this, in its current form.

I want a French translation merged, but your commits basically have this problem:

They are translations of the old Libreboot site, from before Libreboot merged with osboot.

I would suggest that you start from scratch. The libreboot website is very different, since November 2022 when the merge occured. Context:

https://libreboot.org/news/merge.html

I'm closing the pull request; new work can be issued via new pull request.

ok, i've finished my review: I will not merge this, in its current form. I want a French translation merged, but your commits basically have this problem: They are translations of the old Libreboot site, from before Libreboot merged with osboot. I would suggest that you start from scratch. The libreboot website is very different, since November 2022 when the merge occured. Context: <https://libreboot.org/news/merge.html> I'm closing the pull request; new work can be issued via new pull request.
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
3 Participants
Loading...
Cancel
Save
There is no content yet.