Home Explore Help
Register Sign In
libreboot
/
lbmk
Watch 8
Star 12
Fork 18
Files Issues 61 Pull Requests 0
Labels Milestones
New Pull Request

#169 Hardened build system for releases with blobs

Closed
shmalebx9 wants to merge 2 commits from shmalebx9/blobrelease into libreboot/master
Conversation 1 Commits 2 Files changed 2
shmalebx9 commented 1 year ago

The release script now adds a blobhashes file to the release archive which contains the hash for each rom with blobs included.

The inject script can now take the path to a release archive as an argument. When that is done, it will check to make sure that the hash of each rom matches the expected hash.

The two additions are:

  • A release archive can be given to the inject script directly; which makes it easier on the user
  • The release roms will always be identical to locally compiled ones after running the inject script.

I will add this new feature to the docs if the PR is accepted. I plan to make it the default way, since it is easier on the user and prevents issues with blobs.

The release script now adds a `blobhashes` file to the release archive which contains the hash for each rom *with blobs included.* The inject script can now take the path to a release archive as an argument. When that is done, it will check to make sure that the hash of each rom matches the expected hash. The two additions are: - A release archive can be given to the inject script directly; which makes it easier on the user - The release roms will always be identical to locally compiled ones after running the inject script. I will add this new feature to the docs if the PR is accepted. I plan to make it the *default* way, since it is easier on the user and prevents issues with blobs.
Leah Rowe commented 1 year ago
Owner

closing, because i merged this manually. the code is perfect, but you used "lbmkplaceholder" as author. i changed it for you, to the author name you normally use (shmalebx9, and then your email address). see:

https://codeberg.org/libreboot/lbmk/commit/4719d733efd4a66063a667b816d62d178194f1c3

https://codeberg.org/libreboot/lbmk/commit/257ca17b349afbb502c609f361969b0be1f865d6

will do the lbwww PR next

closing, because i merged this manually. the code is perfect, but you used "lbmkplaceholder" as author. i changed it for you, to the author name you normally use (shmalebx9, and then your email address). see: https://codeberg.org/libreboot/lbmk/commit/4719d733efd4a66063a667b816d62d178194f1c3 https://codeberg.org/libreboot/lbmk/commit/257ca17b349afbb502c609f361969b0be1f865d6 will do the lbwww PR next
vimuser closed 1 year ago
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
Labels
Clear labels
No Label
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
2 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.