#104 Entering an URL with special chars searches for it, instead of selecting it

Closed
opened 3 years ago by adnan360 · 5 comments
adnan360 commented 3 years ago

In most cases when I enter an Odysee URL it shows info about it and the publication gets selected as expected. But when some Odysee.com URL with special chars is entered, it runs a search instead. (screenshot attached)

e.g. Entering https://odysee.com/@JakeTran:3/nestl%C3%A9-the-most-evil-business-in-the:5 will trigger a search.

Issue is present with localized titles as well, like https://odysee.com/@xiangcunlaoxi:2/%E7%9B%86%E6%A0%BD%E7%A7%8D%E6%A4%8D%E5%B0%8F%E8%90%9D%E5%8D%9C%E6%8A%80%E5%B7%A7%EF%BC%8C%E5%BE%88%E5%A4%9A%E4%BA%BA%E5%96%9C%E6%AC%A2%E7%94%A8%E3%80%82:5

I'm at 6531cad6. At the time of writing this, it's the latest.

Steps to reproduce:

  • Run it with python3 run.py
  • connect
  • Enter URL with a special char or non-latin chars, like https://odysee.com/@JakeTran:3/nestl%C3%A9-the-most-evil-business-in-the:5

Current outcome:

Runs a search with lbry:// version of url

Expected outcome:

Show publication information and select it like every other publication

In most cases when I enter an Odysee URL it shows info about it and the publication gets selected as expected. But when some Odysee.com URL with special chars is entered, it runs a search instead. (screenshot attached) e.g. Entering `https://odysee.com/@JakeTran:3/nestl%C3%A9-the-most-evil-business-in-the:5` will trigger a search. Issue is present with localized titles as well, like `https://odysee.com/@xiangcunlaoxi:2/%E7%9B%86%E6%A0%BD%E7%A7%8D%E6%A4%8D%E5%B0%8F%E8%90%9D%E5%8D%9C%E6%8A%80%E5%B7%A7%EF%BC%8C%E5%BE%88%E5%A4%9A%E4%BA%BA%E5%96%9C%E6%AC%A2%E7%94%A8%E3%80%82:5` I'm at `6531cad6`. At the time of writing this, it's the latest. **Steps to reproduce:** - Run it with `python3 run.py` - `connect` - Enter URL with a special char or non-latin chars, like `https://odysee.com/@JakeTran:3/nestl%C3%A9-the-most-evil-business-in-the:5` **Current outcome:** Runs a search with lbry:// version of url **Expected outcome:** Show publication information and select it like every other publication
adnan360 commented 3 years ago
Poster

Just wanted to add a workaround I found.

If I go to the video with a web browser, click Share and get the lbry:// url (lbry://@JakeTran#3/nestlé-the-most-evil-business-in-the#5) and paste it in, it seems to work fine.

Just wanted to add a workaround I found. If I go to the video with a web browser, click Share and get the lbry:// url (`lbry://@JakeTran#3/nestlé-the-most-evil-business-in-the#5`) and paste it in, it seems to work fine.
vertbyqb commented 3 years ago
Collaborator

This should be an easy fix. I'm pretty sure there's a Python module specifically for decoding urls.

On another note, this is a really good issue! Having information about the version you're on and how to reproduce can be very helpful. Maybe we should think of making an issue template based on this.

This should be an easy fix. I'm pretty sure there's a Python module specifically for decoding urls. On another note, this is a really good issue! Having information about the version you're on and how to reproduce can be very helpful. Maybe we should think of making an issue template based on this.

I think urllib has this functionality. I'm not sure.

I think urllib has this functionality. I'm not sure.

Fixed with PR #106

Fixed with [PR #106](https://notabug.org/jyamihud/FastLBRY-terminal/pulls/106)
adnan360 commented 3 years ago
Poster

@vertbyqb

On another note, this is a really good issue! Having information about the version you're on and how to reproduce can be very helpful. Maybe we should think of making an issue template based on this.

Go ahead! This format might be useful for bug reports. But for feature requests LibreLingo's format might be better.

@vertbyqb > On another note, this is a really good issue! Having information about the version you're on and how to reproduce can be very helpful. Maybe we should think of making an issue template based on this. Go ahead! This format might be useful for bug reports. But for feature requests [LibreLingo](https://raw.githubusercontent.com/kantord/LibreLingo/main/.github/ISSUE_TEMPLATE/feature_request.md)'s format might be better.
Sign in to join this conversation.
No Milestone
No assignee
3 Participants
Loading...
Cancel
Save
There is no content yet.