#1 config.scm.in: no need to distinguish guile 3

已关闭
aconchillo 请求将 1 次代码提交从 aconchillo/config-scm-in-guile-3 合并至 guile-zstd/master

This was not working for me in macOS.

So I just followed what's done in other libraries (like gcrypt or chickadee) where there's no Guile 3 version check. It now works fine with Guile 3.0.4 in macOS.

I'm wondering why this was added in the first place.

This was not working for me in macOS. So I just followed what's done in other libraries (like gcrypt or chickadee) where there's no Guile 3 version check. It now works fine with Guile 3.0.4 in macOS. I'm wondering why this was added in the first place.
civodul 评论于 4 年之前
所有者

Hola Aleix!

You're right that the .so.1 extension is not strictly needed. I added it because (1) it clarifies which SONAME we're targeting, and (2) many distros ship .so as part of their -devel packages whereas .so.N is part of the regular package.

So my choice would be to keep it, except on macOS. We can do that by checking %host-type.

WDYT?

Thanks, Ludo'.

Hola Aleix! You're right that the `.so.1` extension is not strictly needed. I added it because (1) it clarifies which `SONAME` we're targeting, and (2) many distros ship `.so` as part of their `-devel` packages whereas `.so.N` is part of the regular package. So my choice would be to keep it, except on macOS. We can do that by checking `%host-type`. WDYT? Thanks, Ludo'.
aconchillo 评论于 4 年之前
发布者

Sounds good. Just made a change. Note sure if that's what you had in mind. We are now specific as well with the dylib file name.

Sounds good. Just made a change. Note sure if that's what you had in mind. We are now specific as well with the dylib file name.
civodul 评论于 4 年之前
所有者

Applied, thank you!

Applied, thank you!
civodul4 年之前 关闭
请重新开启合并请求来完成合并操作。
登录 并参与到对话中。
未选择标签
未选择里程碑
未指派成员
2 名参与者
正在加载...
取消
保存
这个人很懒,什么都没留下。