#1 config.scm.in: no need to distinguish guile 3

Closed
aconchillo wants to merge 1 commits from aconchillo/config-scm-in-guile-3 into guile-zstd/master

This was not working for me in macOS.

So I just followed what's done in other libraries (like gcrypt or chickadee) where there's no Guile 3 version check. It now works fine with Guile 3.0.4 in macOS.

I'm wondering why this was added in the first place.

This was not working for me in macOS. So I just followed what's done in other libraries (like gcrypt or chickadee) where there's no Guile 3 version check. It now works fine with Guile 3.0.4 in macOS. I'm wondering why this was added in the first place.
civodul commented 8 months ago
Owner

Hola Aleix!

You're right that the .so.1 extension is not strictly needed. I added it because (1) it clarifies which SONAME we're targeting, and (2) many distros ship .so as part of their -devel packages whereas .so.N is part of the regular package.

So my choice would be to keep it, except on macOS. We can do that by checking %host-type.

WDYT?

Thanks, Ludo'.

Hola Aleix! You're right that the `.so.1` extension is not strictly needed. I added it because (1) it clarifies which `SONAME` we're targeting, and (2) many distros ship `.so` as part of their `-devel` packages whereas `.so.N` is part of the regular package. So my choice would be to keep it, except on macOS. We can do that by checking `%host-type`. WDYT? Thanks, Ludo'.
aconchillo commented 8 months ago
Poster

Sounds good. Just made a change. Note sure if that's what you had in mind. We are now specific as well with the dylib file name.

Sounds good. Just made a change. Note sure if that's what you had in mind. We are now specific as well with the dylib file name.
civodul commented 8 months ago
Owner

Applied, thank you!

Applied, thank you!
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.