#293 Fix conflicting with standard PEAR on installation on #254

Open
senooken wants to merge 1 commits from senooken/fix-conflicting-with-standard-PEAR into diogo/master
senooken commented 1 year ago

When I install GNU social, following #254 error was occurred.

Install GNU social Page notice Initializing...

Fatal error: Cannot redeclare _PEAR_call_destructors() (previously
  declared in /home/fuccom/public_html/social/extlib/PEAR.php:774) in
/opt/cpanel/ea-php73/root/usr/share/pear/PEAR.php on line 834

It seems GNU social have many standard PEAR related trouble (lib/util/framework.php).

So I prior extlib/PEAR.php to standard PEAR in this file.

When I install GNU social, following #254 error was occurred. ``` Install GNU social Page notice Initializing... Fatal error: Cannot redeclare _PEAR_call_destructors() (previously declared in /home/fuccom/public_html/social/extlib/PEAR.php:774) in /opt/cpanel/ea-php73/root/usr/share/pear/PEAR.php on line 834 ``` It seems GNU social have many standard PEAR related trouble (lib/util/framework.php). So I prior extlib/PEAR.php to standard PEAR in this file.
someonewithpc commented 1 year ago
Collaborator

While development of version 2 is mostly frozen, this seems like an simple change. This shouldn't merge directly to master before other people have a chance to test it, but to nightly.

It is weird that it's conflicting with a cpanel file, not standard PEAR, which implies it's a problem with PHP's configuration on your machine. I'm a bit worried it might break something and I think the include path should be, if anything, set to the project root.

P.S. I saw your Fediverse comment and it was unnecessarily aggressive. We're doing what we can and I was personally on vacation and didn't receive any notification. We'd love to see more PRs from you, though, you're more then welcome to join the development team. Let us know if you'd like to help with v3 (our focus now)

While development of version 2 is mostly frozen, this seems like an simple change. This shouldn't merge directly to `master` before other people have a chance to test it, but to `nightly`. It is weird that it's conflicting with a `cpanel` file, not standard PEAR, which implies it's a problem with PHP's configuration on your machine. I'm a bit worried it might break something and I think the include path should be, if anything, set to the project root. P.S. I saw your Fediverse comment and it was unnecessarily aggressive. We're doing what we can and I was personally on vacation and didn't receive any notification. We'd love to see more PRs from you, though, you're more then welcome to join the development team. Let us know if you'd like to help with v3 (our focus now)
senooken commented 1 year ago
Poster

Thanks for reply. I already applied this commit to my server (gnusocial.jp). And this issue also occurred clean Ubuntu 22.04 on Docker (I will create PR for docker support on v2 later). So I think this issue does not depend on cpanel.

I will create another PR later. But I needed developers reaction for next PR my judge.

It seems we cannot running v3 on production environment yet. v2 has some bugs. I need stable v2 for new user/admin and my operation. So I will fix v2 bugs for a while. We can create new feature by plugins by self, so I prior stable v2 than v3.

Where developers do talk? I cannot find you on fediverse or xmpp or mailing list.

Thanks for reply. I already applied this commit to my server (gnusocial.jp). And this issue also occurred clean Ubuntu 22.04 on Docker (I will create PR for docker support on v2 later). So I think this issue does not depend on cpanel. I will create another PR later. But I needed developers reaction for next PR my judge. It seems we cannot running v3 on production environment yet. v2 has some bugs. I need stable v2 for new user/admin and my operation. So I will fix v2 bugs for a while. We can create new feature by plugins by self, so I prior stable v2 than v3. Where developers do talk? I cannot find you on fediverse or xmpp or mailing list.
someonewithpc commented 1 year ago
Collaborator

There's already a branch with docker support for v2 (on my fork, probably, don't remember), but it's with Alpine, not Ubuntu.

V3 is not production ready, that's true.

We were working in person for a while, but now we haven't been able to focus on it much. I'll ask Diogo, but we can either try to use XMPP more or use telegram

There's already a branch with docker support for v2 (on my fork, probably, don't remember), but it's with Alpine, not Ubuntu. V3 is not production ready, that's true. We were working in person for a while, but now we haven't been able to focus on it much. I'll ask Diogo, but we can either try to use XMPP more or use telegram
senooken commented 1 year ago
Poster

There's already a branch with docker support for v2 (on my fork, probably, don't remember), but it's with Alpine, not Ubuntu.

Why do not you create PR? I checked your docker support. But it is too complex for me. My working branch is here https://notabug.org/senooken/gnu-social/src/docker-support/, too simple for local development. Sorry Ubuntu→Debian 11. Surely, I do not consider let's encrypt and so on because working branch for development.

If you have docker, do you reproduce this issue and my fix?

Docker is standardization for development environment for me, bug reproducing and so on.

GS can run same as WordPress (web shared hosting). I think this is important advantage from other distributed SNS. It has cost and ease advantage. So I am not attractive for GS on VPS.

We were working in person for a while, but now we haven't been able to focus on it much. I'll ask Diogo, but we can either try to use XMPP more or use telegram

XMPP (xmpp:gnusocial@conference.bka.li or IRC) is OK. 2 years ago, I chatted on XMPP, diogo and Alexei answered quickly. I chatted also last Sunday and watch everyday about this issue, but they have no reaction. It seems developers do not check XMPP now.

If main chat is telegram, please notice that GS official site https://www.gnusocial.rocks/. I found that first time.

> There's already a branch with docker support for v2 (on my fork, probably, don't remember), but it's with Alpine, not Ubuntu. Why do not you create PR? I checked your docker support. But it is too complex for me. My working branch is here <https://notabug.org/senooken/gnu-social/src/docker-support/>, too simple for local development. Sorry Ubuntu→Debian 11. Surely, I do not consider let's encrypt and so on because working branch for development. If you have docker, do you reproduce this issue and my fix? Docker is standardization for development environment for me, bug reproducing and so on. GS can run same as WordPress (web shared hosting). I think this is important advantage from other distributed SNS. It has cost and ease advantage. So I am not attractive for GS on VPS. > We were working in person for a while, but now we haven't been able to focus on it much. I'll ask Diogo, but we can either try to use XMPP more or use telegram XMPP (xmpp:gnusocial@conference.bka.li or IRC) is OK. 2 years ago, I chatted on XMPP, diogo and Alexei answered quickly. I chatted also last Sunday and watch everyday about this issue, but they have no reaction. It seems developers do not check XMPP now. If main chat is telegram, please notice that GS official site <https://www.gnusocial.rocks/>. I found that first time.
Diogo Cordeiro commented 1 year ago
Owner

Hi,

I think this fix should instead be done in lib/util/framework.php, because, as stated in extlib/README.md, "Most of this directory contents are patched PEAR libraries (necessary as PEAR packages are no longer maintained)".

I noticed that Pear Core has accepted some MRs recently, so it would be a good idea to retry and push our patches to PEAR and get rid of the extlib hack.

Where developers do talk? I cannot find you onXMPPiverse or xmpp or mailing list.

We are in XMPP/IRC and on the Mailing list, just not with the availability we would like :/

If main chat is telegram

Telegram is used between me, @spookie, and @someonewithpc, but it is not the official means... We just used to live in the same city and go to the same university, and use telegram, thus we created a group. (@spookie is now in Sweden and @someonewithpc moved to another city.) What @someonewithpc was suggesting is that, if you'd prefer, we are also available on Telegram. But XMPP is just as fine.

Hi, I think this fix should instead be done in [`lib/util/framework.php`](https://notabug.org/diogo/gnu-social/src/master/lib/util/framework.php#L87-L88), because, as stated in [extlib/README.md](https://notabug.org/diogo/gnu-social/src/master/extlib/README.md), "Most of this directory contents are patched PEAR libraries (necessary as PEAR packages are no longer maintained)". I noticed that Pear Core has accepted some MRs recently, so it would be a good idea to retry and push our patches to PEAR and get rid of the extlib hack. > Where developers do talk? I cannot find you onXMPPiverse or xmpp or mailing list. We are in XMPP/IRC and on the Mailing list, just not with the availability we would like :/ > If main chat is telegram Telegram is used between me, @spookie, and @someonewithpc, but it is not the official means... We just used to live in the same city and go to the same university, and use telegram, thus we created a group. (@spookie is now in Sweden and @someonewithpc moved to another city.) What @someonewithpc was suggesting is that, if you'd prefer, we are also available on Telegram. But XMPP is just as fine.
senooken commented 1 year ago
Poster

@diogo Thanks. OK. I will check standard PEAR and GS PEAR.

I understood we should get rid of extlib hack, before you pointed out.

In actual, if it is enough for applying my commit to lib/util/framework.php, I want not to do that. Because checking PEAR will be challenging/difficult....

We are in XMPP/IRC and on the Mailing list, just not with the availability we would like :/

You are back XMPP/IRC now. It is OK. I also will be checking XMPP/IRC everyday.

@diogo Thanks. OK. I will check standard PEAR and GS PEAR. I understood we should get rid of extlib hack, before you pointed out. In actual, if it is enough for applying my commit to lib/util/framework.php, I want not to do that. Because checking PEAR will be challenging/difficult.... > >We are in XMPP/IRC and on the Mailing list, just not with the availability we would like :/ You are back XMPP/IRC now. It is OK. I also will be checking XMPP/IRC everyday.
senooken commented 1 year ago
Poster

@diogo Thanks for review. You are right. lib/framework.php had almost same hack. I missed it. So I changed that order in this commit.

I want to fix this issue for new admin/user early.

I think discarding extlib may be difficult or challenging. If we need that, I want to separate another issue for discarding extlib.

@diogo Thanks for review. You are right. lib/framework.php had almost same hack. I missed it. So I changed that order in this commit. I want to fix this issue for new admin/user early. I think discarding extlib may be difficult or challenging. If we need that, I want to separate another issue for discarding extlib.
Diogo Cordeiro commented 1 year ago
Owner

yup, this is good now.

yup, this is good now.
This pull request can be merged automatically.
Sign in to join this conversation.
No Milestone
No assignee
3 Participants
Loading...
Cancel
Save
There is no content yet.