In some situations, the lobby's average player count exceeds the maximum player count. The change provides some tests to simulate a few sample play sessions and proposes a solution for the stats calculation.
In some situations, the lobby's average player count exceeds the maximum player count. The change provides some tests to simulate a few sample play sessions and proposes a solution for the stats calculation.
I don't know anything about the tests so I'll assume they're good. I am curious if the change in the mode does anything. It looks like you just moved the block of code a few lines down. Am I missing something there? It shouldn't make any difference where that code is, I just put the if's in order of the variables that the function expects.
I don't know anything about the tests so I'll assume they're good. I am curious if the change in the mode does anything. It looks like you just moved the block of code a few lines down. Am I missing something there? It shouldn't make any difference where that code is, I just put the if's in order of the variables that the function expects.
Wait, I see that does effect it. Good catch. I'll likely put in an extra bit of code to make the average player count always be lower than the max player count, as it shouldn't be possible for that to ever not be the case.
Wait, I see that does effect it. Good catch. I'll likely put in an extra bit of code to make the average player count always be lower than the max player count, as it shouldn't be possible for that to ever not be the case.
I've updated that stats retrieval so that the average player count is never greater than the max player count. It doesn't actually change the stats at all, but after enough plays of a level it should work itself right.
I've updated that stats retrieval so that the average player count is never greater than the max player count. It doesn't actually change the stats at all, but after enough plays of a level it should work itself right.
In some situations, the lobby's average player count exceeds the maximum player count. The change provides some tests to simulate a few sample play sessions and proposes a solution for the stats calculation.
I don't know anything about the tests so I'll assume they're good. I am curious if the change in the mode does anything. It looks like you just moved the block of code a few lines down. Am I missing something there? It shouldn't make any difference where that code is, I just put the if's in order of the variables that the function expects.
Wait, I see that does effect it. Good catch. I'll likely put in an extra bit of code to make the average player count always be lower than the max player count, as it shouldn't be possible for that to ever not be the case.
Awesome, thanks for merging!
I've updated that stats retrieval so that the average player count is never greater than the max player count. It doesn't actually change the stats at all, but after enough plays of a level it should work itself right.