#51 Fix lobby stats counter

Обединени
NathanS21 обедини 1 ревизии от whats_his_face/master във NathanS21/master преди 2 години

In some situations, the lobby's average player count exceeds the maximum player count. The change provides some tests to simulate a few sample play sessions and proposes a solution for the stats calculation.

In some situations, the lobby's average player count exceeds the maximum player count. The change provides some tests to simulate a few sample play sessions and proposes a solution for the stats calculation.
NathanS21 коментира преди 2 години
Притежател

I don't know anything about the tests so I'll assume they're good. I am curious if the change in the mode does anything. It looks like you just moved the block of code a few lines down. Am I missing something there? It shouldn't make any difference where that code is, I just put the if's in order of the variables that the function expects.

I don't know anything about the tests so I'll assume they're good. I am curious if the change in the mode does anything. It looks like you just moved the block of code a few lines down. Am I missing something there? It shouldn't make any difference where that code is, I just put the if's in order of the variables that the function expects.
NathanS21 коментира преди 2 години
Притежател

Wait, I see that does effect it. Good catch. I'll likely put in an extra bit of code to make the average player count always be lower than the max player count, as it shouldn't be possible for that to ever not be the case.

Wait, I see that does effect it. Good catch. I'll likely put in an extra bit of code to make the average player count always be lower than the max player count, as it shouldn't be possible for that to ever not be the case.
whats_his_face коментира преди 2 години
Участник

Awesome, thanks for merging!

Awesome, thanks for merging!
NathanS21 коментира преди 2 години
Притежател

I've updated that stats retrieval so that the average player count is never greater than the max player count. It doesn't actually change the stats at all, but after enough plays of a level it should work itself right.

I've updated that stats retrieval so that the average player count is never greater than the max player count. It doesn't actually change the stats at all, but after enough plays of a level it should work itself right.
Тази заявка за сливане е обединена успешно!
Впишете се за да се присъедините към разговора.
Няма етап
Няма изпълнител
2 участника
Зареждане...
Отказ
Запис
Все още няма съдържание.