Home Explore Help
Register Sign In
shine
Repositories Public Activity

shine opened issue nipos/cloud-firewall#27

[dark mode] Copy as buttons not visible in released version

3 years ago

shine pushed to options-ui at shine/cloud-firewall

3 years ago

shine created pull request nipos/cloud-firewall#26

move `options_ui` into extension page

3 years ago

shine pushed to options-ui at shine/cloud-firewall

3 years ago

shine created new branch options-ui at shine/cloud-firewall

3 years ago

shine commented on issue nipos/cloud-firewall#25

remove bootstrap dependency

I do not want to hinder the release of pending features. I was only asking if these dependency removals were the only things going into the release. But I already got the answer when you responded in #19. And with your last comment, there are more unreleased features. Then, of course, a release is due.

3 years ago

shine commented on issue nipos/cloud-firewall#25

remove bootstrap dependency

that was so fast :o did you really review the extension / code that fast?

3 years ago

shine commented on issue nipos/cloud-firewall#19

Can't copy URLs in TOML

I see that this issue is not reproducible in the extension when run from source. But it is reproducible in the latest version of the extension that is installed from addons.mozilla.org.

3 years ago

shine created pull request nipos/cloud-firewall#25

remove bootstrap dependency

3 years ago

shine pushed to eliminate-bootstrap at shine/cloud-firewall

  • bef4183ea8 bye bootstrap
  • e25c653957 rules: use custom CSS and remove bootstrap
  • 249d528565 blocklist: use custom CSS and remove bootstrap
  • 505c57274b settings: remove bootstrap dependency The 'help' button had some rules that it used implicitly. But most of the styles were already duplicated / over-ridden in `settings.css`. The remaining styles that were still being inherited from bootstrap were copied over to make the button look and feel exactly the same as earlier.
  • 3c1a981d8d privacy: remove unused bootstrap dependency
  • View comparison for these 15 commits »

3 years ago

shine pushed to eliminate-bootstrap at shine/cloud-firewall

  • dbb9ee88b0 bye bootstrap
  • 81dfaf2cc6 rules: use custom CSS and remove bootstrap
  • 232039ef8b blocklist: use custom CSS and remove bootstrap
  • ec80c08408 settings: remove bootstrap dependency The 'help' button had some rules that it used implicitly. But most of the styles were already duplicated / over-ridden in `settings.css`. The remaining styles that were still being inherited from bootstrap were copied over to make the button look and feel exactly the same as earlier.
  • cc1c9df5c1 privacy: remove unused bootstrap dependency

3 years ago

shine created new branch eliminate-bootstrap at shine/cloud-firewall

3 years ago

shine commented on issue nipos/cloud-firewall#24

remove jQuery dependency

Bootstrap was my next target. I wanted to put out smaller chunks of changes so that could be easily reviewed. Can you point me in the direction of the previous development so that I can help there? Has there been significant progress there? Or if that developer does not have the time, I could continue from where they left off.

3 years ago

shine created pull request nipos/cloud-firewall#24

remove jQuery dependency

3 years ago

shine pushed to eliminate-jquery at shine/cloud-firewall

  • fe4e033a3b bye jQuery
  • d7b2ef0c8a remove jQuery dependency in update.html This file has some accordion functionality that displays content from the help file. We might as well simply link directly to the help file and not have to maintain duplicate content in multiple places. For now, the accordion collapse has been removed so that the content is not lost under some ( now ) non-functional buttons and the jQuery dependency could be removed. The link to the help file can be moved at a later.
  • 01bd3522d8 remove jQuery from files that did not use it - blocklist.html - help.{de,en,fr}.html - settings.html
  • 3df64b28b0 rules: migrate jQuery elements to plain javascript
  • a7635b9439 bye jQuery
  • View comparison for these 8 commits »

3 years ago

shine pushed to eliminate-jquery at shine/cloud-firewall

  • a7635b9439 bye jQuery
  • 92095c811f remove jQuery dependency in update.html This file has some accordion functionality that displays content from the help file. We might as well simply link directly to the help file and not have to maintain duplicate content in multiple places. For now, the accordion collapse has been removed so that the content is not lost under some ( now ) non-functional buttons and the jQuery dependency could be removed. The link to the help file can be moved at a later.
  • f818eb1a7c remove jQuery from files that did not use it - blocklist.html - help.{de,en,fr}.html - settings.html
  • 424af6d3fb rules: migrate jQuery elements to plain javascript
  • 6dc9227803 popup: migrate jQuery elements to plain javascript

3 years ago

shine created new branch eliminate-jquery at shine/cloud-firewall

3 years ago

shine forked a repository to shine/cloud-firewall

3 years ago