reepca

reepca commented on issue guile-sqlite3/guile-sqlite3#14

Repeated statement finalization no longer works

Actually reason 1 for it slipping past the tests isn't quite right - the problem only exists when going through the finalize branch twice, so even if `sqlite-prepare-with-caching` invoked `sqlite-finalize` explicitly, the first one would go through the reset branch, and the one on database close would go through the finalize branch, and there still wouldn't be any error until the guardian was run.

3 years ago

reepca opened issue guile-sqlite3/guile-sqlite3#14

Repeated statement finalization no longer works

3 years ago

reepca closed issue guile-sqlite3/guile-sqlite3#12

sqlite-finalize doesn't finish cached statements

3 years ago

reepca commented on issue guile-sqlite3/guile-sqlite3#12

sqlite-finalize doesn't finish cached statements

Fixed by https://notabug.org/guile-sqlite3/guile-sqlite3/pulls/13

3 years ago

reepca created pull request guile-sqlite3/guile-sqlite3#13

Finish cached statements when sqlite-finalize is called on them

3 years ago

reepca opened issue guile-sqlite3/guile-sqlite3#12

sqlite-finalize doesn't finish cached statements

3 years ago

reepca pushed to master at reepca/guile-sqlite3

c59db66f9a Reset statement when sqlite-finalize is called on cached statement Automatically-started transactions only end when a statement finishes, which is normally either when sqlite-reset or sqlite-finalize is called for that statement. Consequently, transactions automatically started by cached statements won't end until the statement is next reused by sqlite-prepare or sqlite-reset is called on it. This changes sqlite-finalize so that it preserves the statement-finishing (and thus transaction-finishing) behavior of sqlite_finalize.

3 years ago

reepca forked a repository to reepca/guile-sqlite3

3 years ago