#46 Fix hiding tabs bug

Merged
nvb merged 1 commits from wwwutz/fix-getcorpos into nvb/master 7 years ago

When hiding Movies and Series via settings as a result Saved was shown twice. The culprit was the logic hidden in switch/case/fallthough which didn't catch all possible cases.

Since there are only 4 booleans which can be represented in 16 states we set up an array of all possible return codes and just index into that map.

The app still has to be restarted when these settings change

When hiding `Movies` and `Series` via settings as a result `Saved` was shown twice. The culprit was the logic hidden in switch/case/fallthough which didn't catch all possible cases. Since there are only 4 booleans which can be represented in 16 states we set up an array of all possible return codes and just index into that map. The app still has to be restarted when these settings change
nvb commented 7 years ago
Owner

The app still has to be restarted when these settings change

I see no way around this yet. So this is no problem.

In any case, this PR is much appreciated. I was aware of the bug, but didn't have the time to fix it. So many thanks to you! :)

> The app still has to be restarted when these settings change I see no way around this yet. So this is no problem. In any case, this PR is much appreciated. I was aware of the bug, but didn't have the time to fix it. So many thanks to you! :)
This pull request has been merged successfully!
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.