#8 Fix region parsing

已關閉
Ghost 請求將 0 次代碼提交從 deleted 合併至 necklace/master
Ghost commented 3 年之前

As listed on PS3DevWiki, the int32 at the start of the first sector is actually the number of unencrypted regions, not the total regions divided by 2. Also, the region ends are inclusive (e.g. the sector region 0-5151 is actually the byte range 0-10551296 rather than 0-10549248).

This PR changes the read_regions function to fix both of those issues, as they led to the last sector of each unencrypted region being encrypted/decrypted when it shouldn't have been.

[As listed on PS3DevWiki](https://www.psdevwiki.com/ps3/Bluray_disc#Encryption), the int32 at the start of the first sector is actually the number of unencrypted regions, not the total regions divided by 2. Also, the region ends are inclusive (e.g. the sector region 0-5151 is actually the byte range 0-10551296 rather than 0-10549248). This PR changes the read_regions function to fix both of those issues, as they led to the last sector of each unencrypted region being encrypted/decrypted when it shouldn't have been.
Nichlas Severinsen commented 3 年之前
所有者

It is imperative that all code contributed be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted.

Personally I don't see the point in sending anonymous PRs. Why bother fixing the code if you're not going to take credit for it? Next time just make issues. Thanks.

It is imperative that all code contributed be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted. Personally I don't see the point in sending anonymous PRs. Why bother fixing the code if you're not going to take credit for it? Next time just make issues. Thanks.
請重新開啟合併請求來完成合併操作。
Sign in to join this conversation.
未選擇里程碑
未指派成員
2 參與者
正在加載...
取消
保存
尚未有任何內容