#8 Fix region parsing

Uzavrená
Ghost chce zlúčiť 0 revíziu z vetvy deleted do vetvy necklace/master
Ghost okomentoval 3 rokov pred

As listed on PS3DevWiki, the int32 at the start of the first sector is actually the number of unencrypted regions, not the total regions divided by 2. Also, the region ends are inclusive (e.g. the sector region 0-5151 is actually the byte range 0-10551296 rather than 0-10549248).

This PR changes the read_regions function to fix both of those issues, as they led to the last sector of each unencrypted region being encrypted/decrypted when it shouldn't have been.

[As listed on PS3DevWiki](https://www.psdevwiki.com/ps3/Bluray_disc#Encryption), the int32 at the start of the first sector is actually the number of unencrypted regions, not the total regions divided by 2. Also, the region ends are inclusive (e.g. the sector region 0-5151 is actually the byte range 0-10551296 rather than 0-10549248). This PR changes the read_regions function to fix both of those issues, as they led to the last sector of each unencrypted region being encrypted/decrypted when it shouldn't have been.
Nichlas Severinsen okomentoval 3 rokov pred
Vlastník

It is imperative that all code contributed be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted.

Personally I don't see the point in sending anonymous PRs. Why bother fixing the code if you're not going to take credit for it? Next time just make issues. Thanks.

It is imperative that all code contributed be legitimately free software. For that reason, code from anonymous (or pseudonymous) contributors will not be accepted. Personally I don't see the point in sending anonymous PRs. Why bother fixing the code if you're not going to take credit for it? Next time just make issues. Thanks.
Pre realizáciu operácie zlúčenia znovu otvorte tento pull request prosím.
Prihláste sa pre zapojenie do konverzácie.
Žiadny míľnik
Žiadny priradený
2 účastníkov
Načítavanie...
Zrušiť
Uložiť
Zatiaľ neexistuje žiadny obsah.