#117 [RFC] for enabling users (or other projects) to reuse libreboot and include extra scripts

Closed
GNUtoo wants to merge 2 commits from GNUtoo/master into libreboot/master
GNUtoo commented 1 year ago

Hi,

The Libreboot and the osboot project's code is quite similar and having two similar code base instead of one increase maintenance costs.

It would be nice to have osboot be able to reuse libreboot and also enable users to add their own scripts as well (for instance to handle their custom configs).

Personally I've not been able to use Libreboot yet because of that, so I mostly reused the deblobbing and did my own build scripts instead.

The advantage of this approach are that:

  • It can be done incrementally
  • It can keep existing Libreboot and osboot policies (and so not drive away users and contributors because of that)
  • It can bring in new users and use cases as users will be able to use their own scripts

It is also not transparent, so users will be aware that they are including extra scripts (because they need to use --include-extra-dir), so they cannot be triggered to unpack a tarball and have code executing automatically without their knowledge.

I've also some osboot patches that make use of that to reuse Libreboot's code for the download script. These patches will be sent to osboot project instead.

Note that I've not tested builds with or without --include-extra-dir yet: while I've done basic testing and taken care of not introducing bugs, these patch sets are also for discussing if this approach is good.

So if they should work fine they could even be merged as-is (as I've taken care to not break anything) they were only made for the download script.

So if this approach is approved by the Libreboot and Osboot projects, we would still need to convert the rest of the code base to really reduce maintenance cost (though half-converted code base would still work fine).

Denis.

Hi, The Libreboot and the osboot project's code is quite similar and having two similar code base instead of one increase maintenance costs. It would be nice to have osboot be able to reuse libreboot and also enable users to add their own scripts as well (for instance to handle their custom configs). Personally I've not been able to use Libreboot yet because of that, so I mostly reused the deblobbing and did my own build scripts instead. The advantage of this approach are that: * It can be done incrementally * It can keep existing Libreboot and osboot policies (and so not drive away users and contributors because of that) * It can bring in new users and use cases as users will be able to use their own scripts It is also not transparent, so users will be aware that they are including extra scripts (because they need to use --include-extra-dir), so they cannot be triggered to unpack a tarball and have code executing automatically without their knowledge. I've also some osboot patches that make use of that to reuse Libreboot's code for the download script. These patches will be sent to osboot project instead. Note that I've not tested builds with or without --include-extra-dir yet: while I've done basic testing and taken care of not introducing bugs, these patch sets are also for discussing if this approach is good. So if they should work fine they could even be merged as-is (as I've taken care to not break anything) they were only made for the download script. So if this approach is approved by the Libreboot and Osboot projects, we would still need to convert the rest of the code base to really reduce maintenance cost (though half-converted code base would still work fine). Denis.
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Label
No Milestone
No assignee
1 Participants
Loading...
Cancel
Save
There is no content yet.