#1 A small improvement

Closed
opened 8 years ago by muja · 1 comments
muja commented 8 years ago

I like this a lot. I used a bad JavaScript solution that was very much less "random", using the Math.random() function. The length was good enough, though.

This is a lot better.

I made a small change for my convenience. A bit more secure, I think.

xsel is a tool to manipulate the X selection. In this usage it copies the password to the clipboard.

echo $password | xsel -ib
done
echo "Your password was copied to your clipboard."

Commit

Any thoughts?

I like this a lot. I used a bad JavaScript solution that was very much less "random", using the `Math.random()` function. The length was good enough, though. This is a lot better. I made a small change for my convenience. A bit more secure, I think. xsel is a tool to *manipulate the X selection*. In this usage it copies the password to the clipboard. ```bash echo $password | xsel -ib done echo "Your password was copied to your clipboard." ``` [Commit](https://notabug.org/muja/quickpass/commit/045a93646a8db0e9c83c91d39ed68cd8c769243f) Any thoughts?
kzimmermann commented 8 years ago
Owner

Lovely! I did not know about xsel before and this looks like the last piece that was missing on another project of mine, strong-passgen. Here, I wasn't too much worried about displaying the password in the clear because you could always generate a list of, say, 40 passwords and select one at random yourself. But I like this usage too: here you don't even have to know what the password looks like!

Thank you for the tip, muja! I definitely agreee that it makes it more secure, and I will merge this commit with my repo as well!

Lovely! I did not know about `xsel` before and this looks like the last piece that was missing on another project of mine, [strong-passgen](https://notabug.org/kzimmermann/strong-passgen). Here, I wasn't too much worried about displaying the password in the clear because you could always generate a list of, say, 40 passwords and select one at random yourself. But I like this usage too: here you don't even have to know what the password looks like! Thank you for the tip, muja! I definitely agreee that it makes it more secure, and I will merge this commit with my repo as well!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.