#26 Cache data validator functions (globally)

開啟中
towerofnix2 年之前創建 · 0 條評論

According to decorateTime results, the validator returned by validateArrayItems gets called just short of 40,000 times, coming to a total of 2340 ms(!) purely in post-processing (linking wiki data arrays). We can avoid just about all of that, and probably gain performance elsewhere, by caching validator functions.

Note that we might want to do this on a per-validator basis, since it's probably actually faster to just do typeof value === 'number' in primitive checks like isNumber (for example), and it'll be easier to implement per-validator anyway.

According to `decorateTime` results, the validator returned by `validateArrayItems` gets called just short of 40,000 times, coming to a total of 2340 ms(!) purely in post-processing (linking wiki data arrays). We can avoid just about all of that, and probably gain performance elsewhere, by caching validator functions. Note that we might want to do this on a per-validator basis, since it's probably actually faster to just do `typeof value === 'number'` in primitive checks like `isNumber` (for example), and it'll be easier to implement per-validator anyway.
登入 才能加入這對話。
未選擇里程碑
未指派成員
1 參與者
正在加載...
取消
保存
尚未有任何內容