#26 Cache data validator functions (globally)

Отворено
отворено пре 2 година од towerofnix · 0 коментара
(quasar) nebula коментирира пре 2 година

According to decorateTime results, the validator returned by validateArrayItems gets called just short of 40,000 times, coming to a total of 2340 ms(!) purely in post-processing (linking wiki data arrays). We can avoid just about all of that, and probably gain performance elsewhere, by caching validator functions.

Note that we might want to do this on a per-validator basis, since it's probably actually faster to just do typeof value === 'number' in primitive checks like isNumber (for example), and it'll be easier to implement per-validator anyway.

According to `decorateTime` results, the validator returned by `validateArrayItems` gets called just short of 40,000 times, coming to a total of 2340 ms(!) purely in post-processing (linking wiki data arrays). We can avoid just about all of that, and probably gain performance elsewhere, by caching validator functions. Note that we might want to do this on a per-validator basis, since it's probably actually faster to just do `typeof value === 'number'` in primitive checks like `isNumber` (for example), and it'll be easier to implement per-validator anyway.
Пријавите се да се прикључе у овом разговору.
Нема фазе
Нема одговорних
1 учесника
Учитавање...
Откажи
Сачувај
Још нема садржаја.