dm9pZCAq/aslstatus

it works for a sec when launched then outputs then unknow_str var 'n/a'

used to work fine before i updated yesterday ( i was running pre pulseaudio update version not sure what version number)
OS: ArchLinux 5.13.13-arch1-1
CPU: Intel i5-8250U (8) @ 3.400GHz
config of cpu_perc: { cpu_perc, "-[%s%%  ]", NULL, 1 SEC, END },
compilation output: http://ix.io/3yGf
aslstatus launching strace: http://ix.io/3yGe

1c7a5809aa this commit have breaking changes to config.h

please change this defines and accordingly interval column in args array

and sorry for this

and btw there is "stable" releases

i'm refactoring some components and therefor master may be quiet unstable now

I did notice the vars changes and renamed them (forgot to mention it) but that hasn't fixed it , however now that i have tried the latest stable release 0.1.3 it is working. Thanks

I did notice the vars changes and renamed them but that hasn't fixed it

can you show compilation errors or warnings?

hasn't fixed it

still outputs unknow_str?

yes it still outputs that while using the master branch

commands i just ran:

git clone https://notabug.org/dm9pZCAq/aslstatus.git && cd aslstatus
make clean install XKB=0 AUDIO=PULSE
aslstatus

compilation output: http://ix.io/3yGY

my testing config.h

/* ... */

static struct arg_t args[] = {
{ cpu_perc,		"%3s%%",	NULL,		 1 _SEC,	END },
};

./aslstatus -s output:

n/a%
  5%
  3%
  6%
  5%
...

can you test it with same config and command?

aslstatus -s outputs using the config above

n/a%
  3%
n/a%

then it just hangs no more output or errors

then it just hangs

it's outputs only when status changes, but in your case there are constantly outputs unknow_str, so it waits for changes

can you apply this and test again?

diff --git a/components/cpu/linux.c b/components/cpu/linux.c
index 0d77927..5000f33 100644
--- a/components/cpu/linux.c
+++ b/components/cpu/linux.c
@@ -54,8 +54,10 @@ cpu_perc(char *      out,
           &data->states[6])
        != LEN(data->states))
        ERRRET(out);
+   warnx("fscanf ok");
 
    if (!old_states[0]) ERRRET(out);
+   warnx("old_states ok");
 
 #define SUM7(X)          (X[0] + X[1] + X[2] + X[3] + X[4] + X[5] + X[6])
 #define ABS_DEC(A, B) (MAX((A), (B)) - MIN((A), (B)))
@@ -66,6 +68,7 @@ cpu_perc(char *       out,
 
    if (!(sum = ABS_DEC(SUM7(old_states), SUM7(data->states))))
        ERRRET(out);
+   warnx("sum = %d", sum);
 
 #define SUM01256(X) (X[0] + X[1] + X[2] + X[5] + X[6])
    bprintf(

after applying the patch:

aslstatus: fscanf ok
n/a%
aslstatus: fscanf ok
aslstatus: old_states ok
aslstatus: sum = 805
  3%
aslstatus: fscanf ok
aslstatus: old_states ok
n/a%
aslstatus: fscanf ok
aslstatus: old_states ok
aslstatus: fscanf ok
aslstatus: old_states ok
aslstatus: fscanf ok
aslstatus: old_states ok
aslstatus: fscanf ok
aslstatus: old_states ok
aslstatus: fscanf ok
aslstatus: old_states ok
aslstatus: fscanf ok
aslstatus: old_states ok
aslstatus: fscanf ok
aslstatus: old_states ok
...

ok, i think i found the problem

will fix soon

cool, thanks

and thank you very much, for helping with resolving this issue

apply this with latest master commit and try it

diff --git a/components/cpu/linux.c b/components/cpu/linux.c
index e85200c..a55c774 100644
--- a/components/cpu/linux.c
+++ b/components/cpu/linux.c
@@ -36,7 +36,7 @@ cpu_perc(char *	    out,
 {
 	struct cpu_data_t *data = static_ptr;
 
-	__typeof__(*data->states) old_states[7], sum;
+	__typeof__(*data->states) old_states[7], sum, tmp_sum, old_sum;
 
 	memcpy(old_states, data->states, sizeof(old_states));
 
@@ -59,20 +59,18 @@ cpu_perc(char *	    out,
 	if (!old_states[0]) ERRRET(out);
 
 #define SUM7(X)	      (X[0] + X[1] + X[2] + X[3] + X[4] + X[5] + X[6])
-#define ABS_DEC(A, B) (MAX((A), (B)) - MIN((A), (B)))
-	/*
-	 * preprocessor will generate scary code, but it will be very good
-	 * optimized by compiler with any number of optimization, except -O0
-	 */
+#define ABS_DEC(A, B) ((A) > (B) ? ((A) - (B)) : ((B) - (A)))
 
-	if (!(sum = ABS_DEC(SUM7(old_states), SUM7(data->states))))
-		ERRRET(out);
+	tmp_sum = SUM7(data->states);
+	old_sum = SUM7(old_states);
+
+	if (!(sum = ABS_DEC(tmp_sum, old_sum))) ERRRET(out);
 
+/* see /proc/stat in `man 5 proc` */
 #define SUM01256(X) (X[0] + X[1] + X[2] + X[5] + X[6])
-	bprintf(
-	    out,
-	    "%hhu",
-	    (uint8_t)(100
-		      * ABS_DEC(SUM01256(old_states), SUM01256(data->states))
-		      / sum));
+
+	tmp_sum = SUM01256(data->states);
+	old_sum = SUM01256(old_states);
+
+	bprintf(out, "%hhu", (uint8_t)(100 * ABS_DEC(tmp_sum, old_sum) / sum));
 }

hope this will help

(edit: formatting here should be fixed too (or not))

running git apply patch.diff errors out mind sharing what command you used

error: patch failed: components/cpu/linux.c:36

seems that wrong formatting in my comment

try this: https://0x0.st/-x2J.diff

it is still not fixed ( i recloned and patched )

ohh, lets "debug" it some more

same as previous (with previous patch) and https://0x0.st/-x2x.diff

n/a%
aslstatus: SUM7: tmp = 24605774; old = 24604974
aslstatus: SUM01256: tmp = 925909; old = 925883
  3%
aslstatus: SUM7: tmp = 24605774; old = 24605774
n/a%
aslstatus: SUM7: tmp = 24605774; old = 24605774
aslstatus: SUM7: tmp = 24605774; old = 24605774
aslstatus: SUM7: tmp = 24605774; old = 24605774

dm9pZCAq referenced this issue from a commit 3 years ago

refactor `cpu_perc`, fix #3

dm9pZCAq closed 3 years ago

please check if it's really fixed :)

dm9pZCAq reopened 3 years ago

Hi, it is still not working aslstatus -s

-[ n/a%]
-[   1%]
-[ n/a%]

then hangs like usual

ohh, try to replace cpu_perc with this:

void
cpu_perc(char *     out,
     const char __unused * _a,
     unsigned int __unused _i,
     void *            static_ptr)
{
    struct cpu_data_t *data = static_ptr;

    __typeof__(*data->states) old_states[LEN(data->states)], sum;

    memcpy(old_states, data->states, sizeof(data->states));

    /* or not only sysfs :) */
    if (sysfs_fptr(&data->fptr, "/", "proc", "stat")) ERRRET(out);

    /* cpu user nice system idle iowait irq softirq */
    if (fscanf(data->fptr,
           "%*s %Lf %Lf %Lf %Lf %Lf %Lf %Lf",
           &data->states[0],
           &data->states[1],
           &data->states[2],
           &data->states[3],
           &data->states[4],
           &data->states[5],
           &data->states[6])
        != 7) {
        ERRRET(out);
    }
    if (!old_states[0]) { ERRRET(out); }

    sum = (old_states[0] + old_states[1] + old_states[2] + old_states[3]
           + old_states[4] + old_states[5] + old_states[6])
        - (data->states[0] + data->states[1] + data->states[2]
           + data->states[3] + data->states[4] + data->states[5]
           + data->states[6]);

    if (!sum) ERRRET(out);

    bprintf(out,
        "%.2Lf",
        (100.0
              * ((old_states[0] + old_states[1] + old_states[2]
              + old_states[5] + old_states[6])
             - (data->states[0] + data->states[1] + data->states[2]
                + data->states[5] + data->states[6]))
              / sum));
}

it's just like old version, but with changed variable names and using fscanf instead of pscanf

same issue

-[ n/a%]
-[ 1.13%]
-[ n/a%]

add this at the top of function

void
cpu_perc(char *     out,
     const char __unused *_a,
     unsigned int         interval,
     void *           static_ptr)
{
    warnx("interval: %u", interval);

/* ... */

void
cpu_perc(char *     out,
     const char __unused *_a,
     unsigned int         interval, /* it is here */
     void *           static_ptr)

yeah just noticed xd

aslstatus: interval: 1000
-[ n/a%]
aslstatus: interval: 1000
-[ 1.75%]
aslstatus: interval: 1000
-[ n/a%]
aslstatus: interval: 1000
aslstatus: interval: 1000
aslstatus: interval: 1000

ok, lets try some shell script...

for _ in $(seq 10); do sed 1q </proc/stat && sleep 1; done

cpu  123558 43 55364 9873269 8884 14477 7602 0 1041 0
cpu  123564 43 55369 9874056 8884 14479 7603 0 1041 0
cpu  123573 43 55371 9874841 8884 14480 7604 0 1041 0
cpu  123579 43 55378 9875626 8884 14482 7605 0 1041 0
cpu  123583 43 55384 9876415 8884 14484 7605 0 1041 0
cpu  123587 43 55388 9877203 8884 14485 7606 0 1041 0
cpu  123603 43 55391 9877981 8884 14487 7607 0 1041 0
cpu  123617 43 55401 9878756 8884 14489 7608 0 1041 0

yet another debug patch https://0x0.st/-xJU.diff

aslstatus: old_states[CPU_STATE_USER], 0.000000
aslstatus: old_states[CPU_STATE_NICE], 0.000000
aslstatus: old_states[CPU_STATE_SYSTEM], 0.000000
aslstatus: old_states[CPU_STATE_IDLE], 0.000000
aslstatus: old_states[CPU_STATE_IOWAIT], 0.000000
aslstatus: old_states[CPU_STATE_IRQ], 0.000000
aslstatus: old_states[CPU_STATE_SOFTIRQ], 0.000000
aslstatus: old_states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(old_states), 0.000000
aslstatus: data->states[CPU_STATE_USER], 175789.000000
aslstatus: data->states[CPU_STATE_NICE], 43.000000
aslstatus: data->states[CPU_STATE_SYSTEM], 79492.000000
aslstatus: data->states[CPU_STATE_IDLE], 12199390.000000
aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: data->states[CPU_STATE_IRQ], 20902.000000
aslstatus: data->states[CPU_STATE_SOFTIRQ], 11415.000000
aslstatus: data->states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(data->states), 12510206.000000
aslstatus: ==================
-[ n/a%]
aslstatus: old_states[CPU_STATE_USER], 175789.000000
aslstatus: old_states[CPU_STATE_NICE], 43.000000
aslstatus: old_states[CPU_STATE_SYSTEM], 79492.000000
aslstatus: old_states[CPU_STATE_IDLE], 12199390.000000
aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: old_states[CPU_STATE_IRQ], 20902.000000
aslstatus: old_states[CPU_STATE_SOFTIRQ], 11415.000000
aslstatus: old_states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(old_states), 12510206.000000
aslstatus: data->states[CPU_STATE_USER], 175794.000000
aslstatus: data->states[CPU_STATE_NICE], 43.000000
aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000
aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000
aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: data->states[CPU_STATE_IRQ], 20904.000000
aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000
aslstatus: data->states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(data->states), 12511004.000000
aslstatus: ==================
-[   1%]
aslstatus: old_states[CPU_STATE_USER], 175794.000000
aslstatus: old_states[CPU_STATE_NICE], 43.000000
aslstatus: old_states[CPU_STATE_SYSTEM], 79496.000000
aslstatus: old_states[CPU_STATE_IDLE], 12200176.000000
aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: old_states[CPU_STATE_IRQ], 20904.000000
aslstatus: old_states[CPU_STATE_SOFTIRQ], 11416.000000
aslstatus: old_states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(old_states), 12511004.000000
aslstatus: data->states[CPU_STATE_USER], 175794.000000
aslstatus: data->states[CPU_STATE_NICE], 43.000000
aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000
aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000
aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: data->states[CPU_STATE_IRQ], 20904.000000
aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000
aslstatus: data->states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(data->states), 12511004.000000
aslstatus: ==================
-[ n/a%]
aslstatus: old_states[CPU_STATE_USER], 175794.000000
aslstatus: old_states[CPU_STATE_NICE], 43.000000
aslstatus: old_states[CPU_STATE_SYSTEM], 79496.000000
aslstatus: old_states[CPU_STATE_IDLE], 12200176.000000
aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: old_states[CPU_STATE_IRQ], 20904.000000
aslstatus: old_states[CPU_STATE_SOFTIRQ], 11416.000000
aslstatus: old_states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(old_states), 12511004.000000
aslstatus: data->states[CPU_STATE_USER], 175794.000000
aslstatus: data->states[CPU_STATE_NICE], 43.000000
aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000
aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000
aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: data->states[CPU_STATE_IRQ], 20904.000000
aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000
aslstatus: data->states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(data->states), 12511004.000000
aslstatus: ==================
aslstatus: old_states[CPU_STATE_USER], 175794.000000
aslstatus: old_states[CPU_STATE_NICE], 43.000000
aslstatus: old_states[CPU_STATE_SYSTEM], 79496.000000
aslstatus: old_states[CPU_STATE_IDLE], 12200176.000000
aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: old_states[CPU_STATE_IRQ], 20904.000000
aslstatus: old_states[CPU_STATE_SOFTIRQ], 11416.000000
aslstatus: old_states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(old_states), 12511004.000000
aslstatus: data->states[CPU_STATE_USER], 175794.000000
aslstatus: data->states[CPU_STATE_NICE], 43.000000
aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000
aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000
aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000
aslstatus: data->states[CPU_STATE_IRQ], 20904.000000
aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000
aslstatus: data->states[CPU_STATE_STEAL], 0.000000
aslstatus: CPU_SUM(data->states), 12511004.000000
aslstatus: ==================
...

``` aslstatus: old_states[CPU_STATE_USER], 0.000000 aslstatus: old_states[CPU_STATE_NICE], 0.000000 aslstatus: old_states[CPU_STATE_SYSTEM], 0.000000 aslstatus: old_states[CPU_STATE_IDLE], 0.000000 aslstatus: old_states[CPU_STATE_IOWAIT], 0.000000 aslstatus: old_states[CPU_STATE_IRQ], 0.000000 aslstatus: old_states[CPU_STATE_SOFTIRQ], 0.000000 aslstatus: old_states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(old_states), 0.000000 aslstatus: data->states[CPU_STATE_USER], 175789.000000 aslstatus: data->states[CPU_STATE_NICE], 43.000000 aslstatus: data->states[CPU_STATE_SYSTEM], 79492.000000 aslstatus: data->states[CPU_STATE_IDLE], 12199390.000000 aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: data->states[CPU_STATE_IRQ], 20902.000000 aslstatus: data->states[CPU_STATE_SOFTIRQ], 11415.000000 aslstatus: data->states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(data->states), 12510206.000000 aslstatus: ================== -[ n/a%] aslstatus: old_states[CPU_STATE_USER], 175789.000000 aslstatus: old_states[CPU_STATE_NICE], 43.000000 aslstatus: old_states[CPU_STATE_SYSTEM], 79492.000000 aslstatus: old_states[CPU_STATE_IDLE], 12199390.000000 aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: old_states[CPU_STATE_IRQ], 20902.000000 aslstatus: old_states[CPU_STATE_SOFTIRQ], 11415.000000 aslstatus: old_states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(old_states), 12510206.000000 aslstatus: data->states[CPU_STATE_USER], 175794.000000 aslstatus: data->states[CPU_STATE_NICE], 43.000000 aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000 aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000 aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: data->states[CPU_STATE_IRQ], 20904.000000 aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000 aslstatus: data->states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(data->states), 12511004.000000 aslstatus: ================== -[ 1%] aslstatus: old_states[CPU_STATE_USER], 175794.000000 aslstatus: old_states[CPU_STATE_NICE], 43.000000 aslstatus: old_states[CPU_STATE_SYSTEM], 79496.000000 aslstatus: old_states[CPU_STATE_IDLE], 12200176.000000 aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: old_states[CPU_STATE_IRQ], 20904.000000 aslstatus: old_states[CPU_STATE_SOFTIRQ], 11416.000000 aslstatus: old_states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(old_states), 12511004.000000 aslstatus: data->states[CPU_STATE_USER], 175794.000000 aslstatus: data->states[CPU_STATE_NICE], 43.000000 aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000 aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000 aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: data->states[CPU_STATE_IRQ], 20904.000000 aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000 aslstatus: data->states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(data->states), 12511004.000000 aslstatus: ================== -[ n/a%] aslstatus: old_states[CPU_STATE_USER], 175794.000000 aslstatus: old_states[CPU_STATE_NICE], 43.000000 aslstatus: old_states[CPU_STATE_SYSTEM], 79496.000000 aslstatus: old_states[CPU_STATE_IDLE], 12200176.000000 aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: old_states[CPU_STATE_IRQ], 20904.000000 aslstatus: old_states[CPU_STATE_SOFTIRQ], 11416.000000 aslstatus: old_states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(old_states), 12511004.000000 aslstatus: data->states[CPU_STATE_USER], 175794.000000 aslstatus: data->states[CPU_STATE_NICE], 43.000000 aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000 aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000 aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: data->states[CPU_STATE_IRQ], 20904.000000 aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000 aslstatus: data->states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(data->states), 12511004.000000 aslstatus: ================== aslstatus: old_states[CPU_STATE_USER], 175794.000000 aslstatus: old_states[CPU_STATE_NICE], 43.000000 aslstatus: old_states[CPU_STATE_SYSTEM], 79496.000000 aslstatus: old_states[CPU_STATE_IDLE], 12200176.000000 aslstatus: old_states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: old_states[CPU_STATE_IRQ], 20904.000000 aslstatus: old_states[CPU_STATE_SOFTIRQ], 11416.000000 aslstatus: old_states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(old_states), 12511004.000000 aslstatus: data->states[CPU_STATE_USER], 175794.000000 aslstatus: data->states[CPU_STATE_NICE], 43.000000 aslstatus: data->states[CPU_STATE_SYSTEM], 79496.000000 aslstatus: data->states[CPU_STATE_IDLE], 12200176.000000 aslstatus: data->states[CPU_STATE_IOWAIT], 23175.000000 aslstatus: data->states[CPU_STATE_IRQ], 20904.000000 aslstatus: data->states[CPU_STATE_SOFTIRQ], 11416.000000 aslstatus: data->states[CPU_STATE_STEAL], 0.000000 aslstatus: CPU_SUM(data->states), 12511004.000000 aslstatus: ================== ... ```

ok, i finally found error after testing on glibc server

there are very strange error in reading and seeking files

this should fix cpu component

sync with master and apply https://0x0.st/-xxD.diff

if it's still not fixed then send strace -ff ./aslstatus -s (but i hope it's finally fixed)

Yes it is fixed

Thank you

and thank you for helping with it ;)

dm9pZCAq referenced this issue from a commit 3 years ago

refactor work with files...

dm9pZCAq closed 3 years ago

#3 undefined behaviour of `FILE *` on /sys and /proc