#287 `[{"error":"Invalid actor."}]` when sending `like` for https://gnusocial.net/notice/11921862

Open
opened 2 years ago by mro · 17 comments

The actor https://demo.mro.name/seppo/activitypub/ is modeled after https://gnusocial.net/user/1 but sending a like gives above error.

The request details are

(request-target): post /user/1/inbox.json
host: gnusocial.net
date: Thu, 21 Jul 2022 10:19:19 GMT
digest: SHA-256=olrkFelf87xqs/N2gg2Vlmd3s0ns7l47tPSQipyrYxs=
content-type: application/activity+json
signature: keyId="https://demo.mro.name/seppo/activitypub/#main-key",algorithm="rsa-sha256",headers="(request-target) host date digest content-type",signature="gGbfGZqVMT/Md8ix3/25l+jULXps2PfRQtr7S+t4QyV0Ubi6JBk+qHgej0GOJ0R/5jAWy0hRA7jmF0g/VIvCcWf9TdnSNFXmDc7q5dkzl7wwaRm+ER8UkiqC+y4f80RNa8Xer/cPD2z0zMe7bg8xSTTSwZOq3jf/N1y1VjaysRlcX+qgBTjNEzGy5RLetaeibxg+80LcioVPfu9QL5lHw2U+959wXxzqZx3r8Tv1ggqOGi2+WuFC6X4fTdh49+KdCw7tyHpKnIyzQ19WehqFvLQqesKS/T0OCiRmgKOsemwfIzLTU91W94pcPJnY3fJ2zjySpqj17TbUdLp3JoTwyw=="
Accept: application/activity+json
User-Agent: Seppo/0.1

{"type":"Like","@context":"https://www.w3.org/ns/activitystreams","id":"https://demo.mro.name/seppo/activitypub/likes.json#https://gnusocial.net/notice/11921862","summary":"That's the way, aha, aha, I Like it.","published":"2022-07-21T10:19:19-00:00","actor":"https://demo.mro.name/seppo/activitypub/","to":["https://gnusocial.net/index.php/user/1"],"cc":["https://www.w3.org/ns/activitystreams#Public"],"object":"https://gnusocial.net/notice/11921862"}

Code is https://notabug.org/mro/seppo/src/d125fd5ca36364a64f195246a392260f280bda50/lib/as2.ml#L494

The actor <https://demo.mro.name/seppo/activitypub/> is modeled after <https://gnusocial.net/user/1> but sending a like gives above error. The request details are ``` (request-target): post /user/1/inbox.json host: gnusocial.net date: Thu, 21 Jul 2022 10:19:19 GMT digest: SHA-256=olrkFelf87xqs/N2gg2Vlmd3s0ns7l47tPSQipyrYxs= content-type: application/activity+json signature: keyId="https://demo.mro.name/seppo/activitypub/#main-key",algorithm="rsa-sha256",headers="(request-target) host date digest content-type",signature="gGbfGZqVMT/Md8ix3/25l+jULXps2PfRQtr7S+t4QyV0Ubi6JBk+qHgej0GOJ0R/5jAWy0hRA7jmF0g/VIvCcWf9TdnSNFXmDc7q5dkzl7wwaRm+ER8UkiqC+y4f80RNa8Xer/cPD2z0zMe7bg8xSTTSwZOq3jf/N1y1VjaysRlcX+qgBTjNEzGy5RLetaeibxg+80LcioVPfu9QL5lHw2U+959wXxzqZx3r8Tv1ggqOGi2+WuFC6X4fTdh49+KdCw7tyHpKnIyzQ19WehqFvLQqesKS/T0OCiRmgKOsemwfIzLTU91W94pcPJnY3fJ2zjySpqj17TbUdLp3JoTwyw==" Accept: application/activity+json User-Agent: Seppo/0.1 {"type":"Like","@context":"https://www.w3.org/ns/activitystreams","id":"https://demo.mro.name/seppo/activitypub/likes.json#https://gnusocial.net/notice/11921862","summary":"That's the way, aha, aha, I Like it.","published":"2022-07-21T10:19:19-00:00","actor":"https://demo.mro.name/seppo/activitypub/","to":["https://gnusocial.net/index.php/user/1"],"cc":["https://www.w3.org/ns/activitystreams#Public"],"object":"https://gnusocial.net/notice/11921862"} ``` Code is https://notabug.org/mro/seppo/src/d125fd5ca36364a64f195246a392260f280bda50/lib/as2.ml#L494
Marcus Rohrmoser commented 2 years ago
Poster
I am surprised, because the validity check <https://notabug.org/diogo/gnu-social/src/8edd975b1109ff1bcda0d618da404a2f82e8c2a3/plugins/ActivityPub/lib/explorer.php#L302> seems quite forgiving.
Marcus Rohrmoser commented 2 years ago
Poster
I guess we see <https://notabug.org/diogo/gnu-social/src/8edd975b1109ff1bcda0d618da404a2f82e8c2a3/plugins/ActivityPub/actions/apinbox.php#L78> but why?
Marcus Rohrmoser commented 2 years ago
Poster
fixed a case typo, works now. <https://codeberg.org/mro/seppo/commit/16ae3eba7aa6650573bb8f915528432d8b107df7>
mro reopened 2 years ago
Marcus Rohrmoser commented 2 years ago
Poster

…in peertube, but not so in gnu social :-(

…in peertube, but not so in gnu social :-(
Marcus Rohrmoser commented 2 years ago
Poster

@diogo just a friendly reminder.

@diogo just a friendly reminder.
Marcus Rohrmoser commented 1 year ago
Poster

@diogo just another friendly reminder.

@diogo just another friendly reminder.
Marcus Rohrmoser commented 1 year ago
Poster

@diogo hope you are you doing well.

@diogo hope you are you doing well.
Marcus Rohrmoser commented 1 year ago
Poster

ping @diogo

ping @diogo
Marcus Rohrmoser commented 1 year ago
Poster

@diogo espero que esteja a ir bem.

@diogo espero que esteja a ir bem.
Marcus Rohrmoser commented 1 year ago
Poster

just a friendly reminder @diogo

just a friendly reminder @diogo
Marcus Rohrmoser commented 1 year ago
Poster

just a friendly reminder @diogo

just a friendly reminder @diogo
Marcus Rohrmoser commented 1 year ago
Poster

just a friendly reminder @diogo

just a friendly reminder @diogo
Marcus Rohrmoser commented 1 year ago
Poster

just a friendly reminder @diogo

just a friendly reminder @diogo
Diogo Cordeiro commented 1 year ago
Owner

Hi Marcus, sorry about keeping you waiting. I'm fine, I started my DPhil this year and it has filled my free time quite rapidly. I think it will be easier if we discuss this issue via IM:

Hi Marcus, sorry about keeping you waiting. I'm fine, I started my DPhil this year and it has filled my free time quite rapidly. I think it will be easier if we discuss this issue via IM: - XMPP: diogo@im.undefinedhackers.net - Telegram: @kaneblueriver - Matrix: @diogomatrix:matrix.org
Marcus Rohrmoser commented 1 year ago
Poster

Hi @diogo,

good to hear of you. If you insist on IM, I have to revive my XMPP account as I won't sign up to telegram and can't get my matrix account @mro:riotchat.de to work reliably – the server may be fucked up or is it the client? After all it's gibberish error messages I can't do anything about.

May take a week to fix xmpp.

Can't we investigate the issue here? Or is there somebody else who could help?

Hi @diogo, good to hear of you. If you insist on IM, I have to revive my XMPP account as I won't sign up to telegram and can't get my matrix account @mro:riotchat.de to work reliably – the server may be fucked up or is it the client? After all it's gibberish error messages I can't do anything about. May take a week to fix xmpp. Can't we investigate the issue here? Or is there somebody else who could help?
Diogo Cordeiro commented 1 year ago
Owner

Hi, I was revisiting this and, if you really want to make it compatible with version 2, we can try to debug and figure out why it's not working. But I can tell you that your software's actors are already valid to GNU social v3's ActivityPub. Therefore, this must be something wrong or a limitation in v2. You can check GS v3's ActivityPub plugin at https://codeberg.org/GNUsocial/gnu-social/src/branch/v3/plugins/ActivityPub .

Hi, I was revisiting this and, if you really want to make it compatible with version 2, we can try to debug and figure out why it's not working. But I can tell you that [your software's actors are already valid to GNU social v3's ActivityPub](https://socialhub.activitypub.rocks/t/help-needed-actor-validity/2460/16?u=diogo). Therefore, this must be something wrong or a limitation in v2. You can check GS v3's ActivityPub plugin at https://codeberg.org/GNUsocial/gnu-social/src/branch/v3/plugins/ActivityPub .
Marcus Rohrmoser commented 1 year ago
Poster

nice to hear @diogo - do you have an estimate how many installations (v2 as well as v3) are out there?

nice to hear @diogo - do you have an estimate how many installations (v2 as well as v3) are out there?
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.