#7 show also page name in the title bar

Fusionado
SylvieLorxu fusionados 1 commits de jorgesumle/master en SylvieLorxu/master hace 8 años

I don't know why all env variables start with var, but I tried to follow the same naming convention. I've named the index.html page "Home". The rest of the pages will have the name of their filename without the extension.

If we have a blog named MyBlog:

  • index.html title bar will read Home - MyBlog
  • pages/Contact.html title bar will read Contact - MyBlog
  • pages/About.html title bar will read About - MyBlog
  • posts/myPost.html title bar will read myPost - MyBlog

I didn't write export var_page="Home" to variables file, because it changes a lot.

I don't know why all env variables start with var, but I tried to follow the same naming convention. I've named the index.html page "Home". The rest of the pages will have the name of their filename without the extension. If we have a blog named __MyBlog__: * `index.html` title bar will read __Home - MyBlog__ * `pages/Contact.html` title bar will read __Contact - MyBlog__ * `pages/About.html` title bar will read __About - MyBlog__ * `posts/myPost.html` title bar will read __myPost - MyBlog__ I didn't write `export var_page="Home"` to `variables` file, because it changes a lot.
Sylvia van Os comentado hace 8 años
Propietario

Thanks for this. According to the documentation though, you're supposed to name posts like 2016-02-04--Untimed article.md or 2016-02-04-17:00-Hello, world!.md and I feel it probably displays titles like these very ugly. You probably want to use doctitle, see line 288: doctitle=${docbasename#*-*-*-*-}

Thanks for this. According to the documentation though, you're supposed to name posts like ```2016-02-04--Untimed article.md``` or ```2016-02-04-17:00-Hello, world!.md``` and I feel it probably displays titles like these very ugly. You probably want to use doctitle, see line 288: ```doctitle=${docbasename#*-*-*-*-}```
Jorge Maldonado Ventura comentado hace 8 años
Colaborador

Fixed it!

Fixed it!
Sylvia van Os comentado hace 8 años
Propietario

Any chance you could quickly squash this into a single commit? After that I'll hit merge :)

Any chance you could quickly squash this into a single commit? After that I'll hit merge :)
Jorge Maldonado Ventura comentado hace 8 años
Colaborador

Done, thanks for the feedback!

Done, thanks for the feedback!
Sylvia van Os comentado hace 8 años
Propietario

Thanks again for the contribution!

Thanks again for the contribution!
¡Este Pull Request se ha completado con éxito!
Inicie sesión para unirse a esta conversación.
Sin etiquetas
Sin Milestone
Sin asignado
2 participantes
Cargando...
Cancelar
Guardar
Aún no existe contenido.