#7 show also page name in the title bar

Merged
SylvieLorxu merged 1 commits from jorgesumle/master into SylvieLorxu/master 8 years ago

I don't know why all env variables start with var, but I tried to follow the same naming convention. I've named the index.html page "Home". The rest of the pages will have the name of their filename without the extension.

If we have a blog named MyBlog:

  • index.html title bar will read Home - MyBlog
  • pages/Contact.html title bar will read Contact - MyBlog
  • pages/About.html title bar will read About - MyBlog
  • posts/myPost.html title bar will read myPost - MyBlog

I didn't write export var_page="Home" to variables file, because it changes a lot.

I don't know why all env variables start with var, but I tried to follow the same naming convention. I've named the index.html page "Home". The rest of the pages will have the name of their filename without the extension. If we have a blog named __MyBlog__: * `index.html` title bar will read __Home - MyBlog__ * `pages/Contact.html` title bar will read __Contact - MyBlog__ * `pages/About.html` title bar will read __About - MyBlog__ * `posts/myPost.html` title bar will read __myPost - MyBlog__ I didn't write `export var_page="Home"` to `variables` file, because it changes a lot.
Sylvia van Os commented 8 years ago
Owner

Thanks for this. According to the documentation though, you're supposed to name posts like 2016-02-04--Untimed article.md or 2016-02-04-17:00-Hello, world!.md and I feel it probably displays titles like these very ugly. You probably want to use doctitle, see line 288: doctitle=${docbasename#*-*-*-*-}

Thanks for this. According to the documentation though, you're supposed to name posts like ```2016-02-04--Untimed article.md``` or ```2016-02-04-17:00-Hello, world!.md``` and I feel it probably displays titles like these very ugly. You probably want to use doctitle, see line 288: ```doctitle=${docbasename#*-*-*-*-}```
Jorge Maldonado Ventura commented 8 years ago
Collaborator

Fixed it!

Fixed it!
Sylvia van Os commented 8 years ago
Owner

Any chance you could quickly squash this into a single commit? After that I'll hit merge :)

Any chance you could quickly squash this into a single commit? After that I'll hit merge :)
Jorge Maldonado Ventura commented 8 years ago
Collaborator

Done, thanks for the feedback!

Done, thanks for the feedback!
Sylvia van Os commented 8 years ago
Owner

Thanks again for the contribution!

Thanks again for the contribution!
This pull request has been merged successfully!
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.