From what I can tell you will need the ethereal mod in order to get banana and orange trees. This will come with some other items too. We may need to see if we want all those items in the game. Ill add a pull request for it.
From what I can tell you will need the ethereal mod in order to get banana and orange trees. This will come with some other items too. We may need to see if we want all those items in the game. Ill add a pull request for it.
As discussed here in my pull request to add the ethereal mod https://notabug.org/NathanS21/Epic/pulls/46 the code can be found in the ethereal mod however we should take the necessary code out and put that in some other mod to allow banana and orange trees to exist.
@NathanS21 Where do we want banana trees and orange trees to grow? Currently in the mod they grow on ethereal:grove_dirt and ethereal:prairie_dirt. Since we arnt going to carry over the mod we will need some suitable soil for them to grow on.
As discussed here in my pull request to add the ethereal mod https://notabug.org/NathanS21/Epic/pulls/46 the code can be found in the ethereal mod however we should take the necessary code out and put that in some other mod to allow banana and orange trees to exist.
@NathanS21 Where do we want banana trees and orange trees to grow? Currently in the mod they grow on ethereal:grove_dirt and ethereal:prairie_dirt. Since we arnt going to carry over the mod we will need some suitable soil for them to grow on.
Now lumberjack mod does not work with the trees yet. And leaves are not decaying.
Ok here is what I got so far.
https://notabug.org/Xachman/Epic/src/add_banana_orange_trees/mods/epic_trees
Now lumberjack mod does not work with the trees yet. And leaves are not decaying.
Can you also add compatibility with bonemeal for the saplings? (I can add it after merging if you don't know how)
Trees should probably spawn on default:sand and default:drit_with_grass for right now, in the grassland and grassland_dunes biomes. (This can always be changed in the future when I create some other biomes.)
The code looks alright currently, although obviously the oranges aren't added yet.
Can you also add compatibility with bonemeal for the saplings? (I can add it after merging if you don't know how)
Trees should probably spawn on default:sand and default:drit_with_grass for right now, in the grassland and grassland_dunes biomes. (This can always be changed in the future when I create some other biomes.)
The code looks alright currently, although obviously the oranges aren't added yet.
@NathanS21 Awesome! Yes ill make sure bonemeal works. I have an odd issue if you know how to solve it. Seems like the marram_grass is spawning after or something and taking out a block on the banana trees sometimes.
@NathanS21 Awesome! Yes ill make sure bonemeal works. I have an odd issue if you know how to solve it. Seems like the marram_grass is spawning after or something and taking out a block on the banana trees sometimes.
Maybe try adding default as a dependency to the mod. That will force Default to load before the trees mod. Not sure if that will make the default mapgen decorations run first, but maybe.
Maybe try adding default as a dependency to the mod. That will force Default to load before the trees mod. Not sure if that will make the default mapgen decorations run first, but maybe.
I tested with grassland now too and none placed on the marram_grass. Only seems to happen when I'm flying with fast on. Ill try out adding the default dependency as well. Probably need to cut back on how many we are spawning here but its working.
I tested with grassland now too and none placed on the marram_grass. Only seems to happen when I'm flying with fast on. Ill try out adding the default dependency as well. Probably need to cut back on how many we are spawning here but its working.
From what I can tell you will need the ethereal mod in order to get banana and orange trees. This will come with some other items too. We may need to see if we want all those items in the game. Ill add a pull request for it.
As discussed here in my pull request to add the ethereal mod https://notabug.org/NathanS21/Epic/pulls/46 the code can be found in the ethereal mod however we should take the necessary code out and put that in some other mod to allow banana and orange trees to exist.
@NathanS21 Where do we want banana trees and orange trees to grow? Currently in the mod they grow on ethereal:grove_dirt and ethereal:prairie_dirt. Since we arnt going to carry over the mod we will need some suitable soil for them to grow on.
Ok here is what I got so far.
https://notabug.org/Xachman/Epic/src/add_banana_orange_trees/mods/epic_trees
Now lumberjack mod does not work with the trees yet. And leaves are not decaying.
Lumberjack and leaf decay are working now.
Can you also add compatibility with bonemeal for the saplings? (I can add it after merging if you don't know how) Trees should probably spawn on default:sand and default:drit_with_grass for right now, in the grassland and grassland_dunes biomes. (This can always be changed in the future when I create some other biomes.)
The code looks alright currently, although obviously the oranges aren't added yet.
@NathanS21 Awesome! Yes ill make sure bonemeal works. I have an odd issue if you know how to solve it. Seems like the marram_grass is spawning after or something and taking out a block on the banana trees sometimes.
Maybe try adding default as a dependency to the mod. That will force Default to load before the trees mod. Not sure if that will make the default mapgen decorations run first, but maybe.
I tested with grassland now too and none placed on the marram_grass. Only seems to happen when I'm flying with fast on. Ill try out adding the default dependency as well. Probably need to cut back on how many we are spawning here but its working.
bonemeal is added for banana trees.
Pull request created https://notabug.org/NathanS21/Epic/pulls/57
Pull request merged! Thanks.