review-1.1.txt 1.5 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748
  1. Review Alexandru 05-11-2008
  2. ---------------------------
  3. [x] Wrong headers in some files ("File containing the XXX class", "Base class...").
  4. [x] Wrong package names (Table, PageBreak, etc) (see issue #13829).
  5. [ ] rst2xhtml conversion does not work for all ezc tutorials (some
  6. elements are not supported, like replace).
  7. kn: Those are just not implemented yet. But the errors are ignorable now.
  8. [ ] Linux-style path separator used in some files.
  9. kn: PHP should handle this just fine.
  10. [ ] Some functions which return bool are documented with '@return void'.
  11. - Some typos in the code and comments:
  12. [x] /src/exceptions/errnous_xml.php
  13. Errnous -> Erroneous
  14. [x] /src/document/xml/xhtml/filter/element/base.php
  15. boolena -> bool
  16. Review Toby 2008-11-21
  17. ----------------------
  18. [x] Missing tutorial for new formats.
  19. [x] Wierd @apichange tag in Document/src/options/document_rst.php.
  20. [x] I'd suggest to have a wrapper class for each Wiki format, to allow
  21. creation of Wiki documents in the same way as for other documents. For
  22. example ezcDocumentWikiCreole to create a wiki document with the creole
  23. tokenizer.
  24. [x] It sounds like a good idea to register a default directive for all
  25. directives mentioned in the RST specification. Otherwise people get an
  26. error, if the try to convert documents containing such directives.
  27. kn: As discussed: Changed to an error of level "Warning", which can
  28. easily be ignored.
  29. [x] The docanalysis tool throws an exception because a class used in a type
  30. hint does not exist.