#3 If a notice has a missing file it will prompt not found and break parts of the current page markup

Ouvert
Créé il y a 7 ans par vaeringjar · 7 commentaires

I have a treatment for this, but not a prevention.

I have a treatment for this, but not a prevention.
vaeringjar a commenté il y a 7 ans
Propriétaire

Looks like the treatment didn't fix all of them either; I found some old notices with missing files:

https://gnusocial.no/conversation/817418#notice-1127252

Looks like the treatment didn't fix all of them either; I found some old notices with missing files: https://gnusocial.no/conversation/817418#notice-1127252
vaeringjar a commenté il y a 7 ans
Propriétaire

I found an example on another instance where it does not break the rest of the markup on the page:

Origin has the file:
https://quitter.no/notice/5450192

Remote hasn't:
https://quitter.is/conversation/2991210#notice-4893515

I found an example on another instance where it does not break the rest of the markup on the page: Origin has the file: https://quitter.no/notice/5450192 Remote hasn't: https://quitter.is/conversation/2991210#notice-4893515
vaeringjar a commenté il y a 7 ans
Propriétaire

Maybe a bug with the current theme. I will try others later.

See here, for example, the error does not happen on quitter.es:
https://quitter.es/conversation/2935768#notice-4140994

Maybe a bug with the current theme. I will try others later. See here, for example, the error does not happen on quitter.es: https://quitter.es/conversation/2935768#notice-4140994
vaeringjar a commenté il y a 7 ans
Propriétaire

https://gnusocial.no/conversation/2986647#notice-3202026

Second day in a row. Something to do with safebot?

https://gnusocial.no/conversation/2986647#notice-3202026 Second day in a row. Something to do with safebot?
vaeringjar a commenté il y a 6 ans
Propriétaire

I disabled StoreRemoteMedia, though I haven't seen this in a while. Either way, logging it here...

I disabled StoreRemoteMedia, though I haven't seen this in a while. Either way, logging it here...
vaeringjar a commenté il y a 6 ans
Propriétaire

I feel confident that this happens more frequently when using StoreRemoteMedia. I can't say it's fixed, though, since clearly something attempts to load a null then breaks.

I feel confident that this happens more frequently when using StoreRemoteMedia. I can't say it's fixed, though, since clearly something attempts to load a null then breaks.
vaeringjar a commenté il y a 6 ans
Propriétaire

So finally getting back to this one. Disabling StoreRemoteMedia helped reduce the fail cases, but it still happens.

$ grep -irn "error showing notice" .
./lib/activityhandlerplugin.php:583:            common_log(LOG_ERR, 'Error showing notice '.$nli->getNotice()->getID().': ' . $e->getMessage());
./lib/activityhandlerplugin.php:584:            $nli->out->element('p', 'error', sprintf(_('Error showing notice: %s'), $e->getMessage()));

So basically LOC 584 sometimes breaks the markup. At this point, I've run this skip for long enough I should just fork my own copy of gnusocial and merge these changes in.

So finally getting back to this one. Disabling StoreRemoteMedia helped reduce the fail cases, but it still happens. $ grep -irn "error showing notice" . ./lib/activityhandlerplugin.php:583: common_log(LOG_ERR, 'Error showing notice '.$nli->getNotice()->getID().': ' . $e->getMessage()); ./lib/activityhandlerplugin.php:584: $nli->out->element('p', 'error', sprintf(_('Error showing notice: %s'), $e->getMessage())); So basically LOC 584 sometimes breaks the markup. At this point, I've run this skip for long enough I should just fork my own copy of gnusocial and merge these changes in.
Connectez-vous pour rejoindre cette conversation.
Aucun jalon
Pas d'assignataire
1 Participants
Chargement…
Annuler
Enregistrer
Il n'existe pas encore de contenu.