ChangeLog 1.3 MB

1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446244724482449245024512452245324542455245624572458245924602461246224632464246524662467246824692470247124722473247424752476247724782479248024812482248324842485248624872488248924902491249224932494249524962497249824992500250125022503250425052506250725082509251025112512251325142515251625172518251925202521252225232524252525262527252825292530253125322533253425352536253725382539254025412542254325442545254625472548254925502551255225532554255525562557255825592560256125622563256425652566256725682569257025712572257325742575257625772578257925802581258225832584258525862587258825892590259125922593259425952596259725982599260026012602260326042605260626072608260926102611261226132614261526162617261826192620262126222623262426252626262726282629263026312632263326342635263626372638263926402641264226432644264526462647264826492650265126522653265426552656265726582659266026612662266326642665266626672668266926702671267226732674267526762677267826792680268126822683268426852686268726882689269026912692269326942695269626972698269927002701270227032704270527062707270827092710271127122713271427152716271727182719272027212722272327242725272627272728272927302731273227332734273527362737273827392740274127422743274427452746274727482749275027512752275327542755275627572758275927602761276227632764276527662767276827692770277127722773277427752776277727782779278027812782278327842785278627872788278927902791279227932794279527962797279827992800280128022803280428052806280728082809281028112812281328142815281628172818281928202821282228232824282528262827282828292830283128322833283428352836283728382839284028412842284328442845284628472848284928502851285228532854285528562857285828592860286128622863286428652866286728682869287028712872287328742875287628772878287928802881288228832884288528862887288828892890289128922893289428952896289728982899290029012902290329042905290629072908290929102911291229132914291529162917291829192920292129222923292429252926292729282929293029312932293329342935293629372938293929402941294229432944294529462947294829492950295129522953295429552956295729582959296029612962296329642965296629672968296929702971297229732974297529762977297829792980298129822983298429852986298729882989299029912992299329942995299629972998299930003001300230033004300530063007300830093010301130123013301430153016301730183019302030213022302330243025302630273028302930303031303230333034303530363037303830393040304130423043304430453046304730483049305030513052305330543055305630573058305930603061306230633064306530663067306830693070307130723073307430753076307730783079308030813082308330843085308630873088308930903091309230933094309530963097309830993100310131023103310431053106310731083109311031113112311331143115311631173118311931203121312231233124312531263127312831293130313131323133313431353136313731383139314031413142314331443145314631473148314931503151315231533154315531563157315831593160316131623163316431653166316731683169317031713172317331743175317631773178317931803181318231833184318531863187318831893190319131923193319431953196319731983199320032013202320332043205320632073208320932103211321232133214321532163217321832193220322132223223322432253226322732283229323032313232323332343235323632373238323932403241324232433244324532463247324832493250325132523253325432553256325732583259326032613262326332643265326632673268326932703271327232733274327532763277327832793280328132823283328432853286328732883289329032913292329332943295329632973298329933003301330233033304330533063307330833093310331133123313331433153316331733183319332033213322332333243325332633273328332933303331333233333334333533363337333833393340334133423343334433453346334733483349335033513352335333543355335633573358335933603361336233633364336533663367336833693370337133723373337433753376337733783379338033813382338333843385338633873388338933903391339233933394339533963397339833993400340134023403340434053406340734083409341034113412341334143415341634173418341934203421342234233424342534263427342834293430343134323433343434353436343734383439344034413442344334443445344634473448344934503451345234533454345534563457345834593460346134623463346434653466346734683469347034713472347334743475347634773478347934803481348234833484348534863487348834893490349134923493349434953496349734983499350035013502350335043505350635073508350935103511351235133514351535163517351835193520352135223523352435253526352735283529353035313532353335343535353635373538353935403541354235433544354535463547354835493550355135523553355435553556355735583559356035613562356335643565356635673568356935703571357235733574357535763577357835793580358135823583358435853586358735883589359035913592359335943595359635973598359936003601360236033604360536063607360836093610361136123613361436153616361736183619362036213622362336243625362636273628362936303631363236333634363536363637363836393640364136423643364436453646364736483649365036513652365336543655365636573658365936603661366236633664366536663667366836693670367136723673367436753676367736783679368036813682368336843685368636873688368936903691369236933694369536963697369836993700370137023703370437053706370737083709371037113712371337143715371637173718371937203721372237233724372537263727372837293730373137323733373437353736373737383739374037413742374337443745374637473748374937503751375237533754375537563757375837593760376137623763376437653766376737683769377037713772377337743775377637773778377937803781378237833784378537863787378837893790379137923793379437953796379737983799380038013802380338043805380638073808380938103811381238133814381538163817381838193820382138223823382438253826382738283829383038313832383338343835383638373838383938403841384238433844384538463847384838493850385138523853385438553856385738583859386038613862386338643865386638673868386938703871387238733874387538763877387838793880388138823883388438853886388738883889389038913892389338943895389638973898389939003901390239033904390539063907390839093910391139123913391439153916391739183919392039213922392339243925392639273928392939303931393239333934393539363937393839393940394139423943394439453946394739483949395039513952395339543955395639573958395939603961396239633964396539663967396839693970397139723973397439753976397739783979398039813982398339843985398639873988398939903991399239933994399539963997399839994000400140024003400440054006400740084009401040114012401340144015401640174018401940204021402240234024402540264027402840294030403140324033403440354036403740384039404040414042404340444045404640474048404940504051405240534054405540564057405840594060406140624063406440654066406740684069407040714072407340744075407640774078407940804081408240834084408540864087408840894090409140924093409440954096409740984099410041014102410341044105410641074108410941104111411241134114411541164117411841194120412141224123412441254126412741284129413041314132413341344135413641374138413941404141414241434144414541464147414841494150415141524153415441554156415741584159416041614162416341644165416641674168416941704171417241734174417541764177417841794180418141824183418441854186418741884189419041914192419341944195419641974198419942004201420242034204420542064207420842094210421142124213421442154216421742184219422042214222422342244225422642274228422942304231423242334234423542364237423842394240424142424243424442454246424742484249425042514252425342544255425642574258425942604261426242634264426542664267426842694270427142724273427442754276427742784279428042814282428342844285428642874288428942904291429242934294429542964297429842994300430143024303430443054306430743084309431043114312431343144315431643174318431943204321432243234324432543264327432843294330433143324333433443354336433743384339434043414342434343444345434643474348434943504351435243534354435543564357435843594360436143624363436443654366436743684369437043714372437343744375437643774378437943804381438243834384438543864387438843894390439143924393439443954396439743984399440044014402440344044405440644074408440944104411441244134414441544164417441844194420442144224423442444254426442744284429443044314432443344344435443644374438443944404441444244434444444544464447444844494450445144524453445444554456445744584459446044614462446344644465446644674468446944704471447244734474447544764477447844794480448144824483448444854486448744884489449044914492449344944495449644974498449945004501450245034504450545064507450845094510451145124513451445154516451745184519452045214522452345244525452645274528452945304531453245334534453545364537453845394540454145424543454445454546454745484549455045514552455345544555455645574558455945604561456245634564456545664567456845694570457145724573457445754576457745784579458045814582458345844585458645874588458945904591459245934594459545964597459845994600460146024603460446054606460746084609461046114612461346144615461646174618461946204621462246234624462546264627462846294630463146324633463446354636463746384639464046414642464346444645464646474648464946504651465246534654465546564657465846594660466146624663466446654666466746684669467046714672467346744675467646774678467946804681468246834684468546864687468846894690469146924693469446954696469746984699470047014702470347044705470647074708470947104711471247134714471547164717471847194720472147224723472447254726472747284729473047314732473347344735473647374738473947404741474247434744474547464747474847494750475147524753475447554756475747584759476047614762476347644765476647674768476947704771477247734774477547764777477847794780478147824783478447854786478747884789479047914792479347944795479647974798479948004801480248034804480548064807480848094810481148124813481448154816481748184819482048214822482348244825482648274828482948304831483248334834483548364837483848394840484148424843484448454846484748484849485048514852485348544855485648574858485948604861486248634864486548664867486848694870487148724873487448754876487748784879488048814882488348844885488648874888488948904891489248934894489548964897489848994900490149024903490449054906490749084909491049114912491349144915491649174918491949204921492249234924492549264927492849294930493149324933493449354936493749384939494049414942494349444945494649474948494949504951495249534954495549564957495849594960496149624963496449654966496749684969497049714972497349744975497649774978497949804981498249834984498549864987498849894990499149924993499449954996499749984999500050015002500350045005500650075008500950105011501250135014501550165017501850195020502150225023502450255026502750285029503050315032503350345035503650375038503950405041504250435044504550465047504850495050505150525053505450555056505750585059506050615062506350645065506650675068506950705071507250735074507550765077507850795080508150825083508450855086508750885089509050915092509350945095509650975098509951005101510251035104510551065107510851095110511151125113511451155116511751185119512051215122512351245125512651275128512951305131513251335134513551365137513851395140514151425143514451455146514751485149515051515152515351545155515651575158515951605161516251635164516551665167516851695170517151725173517451755176517751785179518051815182518351845185518651875188518951905191519251935194519551965197519851995200520152025203520452055206520752085209521052115212521352145215521652175218521952205221522252235224522552265227522852295230523152325233523452355236523752385239524052415242524352445245524652475248524952505251525252535254525552565257525852595260526152625263526452655266526752685269527052715272527352745275527652775278527952805281528252835284528552865287528852895290529152925293529452955296529752985299530053015302530353045305530653075308530953105311531253135314531553165317531853195320532153225323532453255326532753285329533053315332533353345335533653375338533953405341534253435344534553465347534853495350535153525353535453555356535753585359536053615362536353645365536653675368536953705371537253735374537553765377537853795380538153825383538453855386538753885389539053915392539353945395539653975398539954005401540254035404540554065407540854095410541154125413541454155416541754185419542054215422542354245425542654275428542954305431543254335434543554365437543854395440544154425443544454455446544754485449545054515452545354545455545654575458545954605461546254635464546554665467546854695470547154725473547454755476547754785479548054815482548354845485548654875488548954905491549254935494549554965497549854995500550155025503550455055506550755085509551055115512551355145515551655175518551955205521552255235524552555265527552855295530553155325533553455355536553755385539554055415542554355445545554655475548554955505551555255535554555555565557555855595560556155625563556455655566556755685569557055715572557355745575557655775578557955805581558255835584558555865587558855895590559155925593559455955596559755985599560056015602560356045605560656075608560956105611561256135614561556165617561856195620562156225623562456255626562756285629563056315632563356345635563656375638563956405641564256435644564556465647564856495650565156525653565456555656565756585659566056615662566356645665566656675668566956705671567256735674567556765677567856795680568156825683568456855686568756885689569056915692569356945695569656975698569957005701570257035704570557065707570857095710571157125713571457155716571757185719572057215722572357245725572657275728572957305731573257335734573557365737573857395740574157425743574457455746574757485749575057515752575357545755575657575758575957605761576257635764576557665767576857695770577157725773577457755776577757785779578057815782578357845785578657875788578957905791579257935794579557965797579857995800580158025803580458055806580758085809581058115812581358145815581658175818581958205821582258235824582558265827582858295830583158325833583458355836583758385839584058415842584358445845584658475848584958505851585258535854585558565857585858595860586158625863586458655866586758685869587058715872587358745875587658775878587958805881588258835884588558865887588858895890589158925893589458955896589758985899590059015902590359045905590659075908590959105911591259135914591559165917591859195920592159225923592459255926592759285929593059315932593359345935593659375938593959405941594259435944594559465947594859495950595159525953595459555956595759585959596059615962596359645965596659675968596959705971597259735974597559765977597859795980598159825983598459855986598759885989599059915992599359945995599659975998599960006001600260036004600560066007600860096010601160126013601460156016601760186019602060216022602360246025602660276028602960306031603260336034603560366037603860396040604160426043604460456046604760486049605060516052605360546055605660576058605960606061606260636064606560666067606860696070607160726073607460756076607760786079608060816082608360846085608660876088608960906091609260936094609560966097609860996100610161026103610461056106610761086109611061116112611361146115611661176118611961206121612261236124612561266127612861296130613161326133613461356136613761386139614061416142614361446145614661476148614961506151615261536154615561566157615861596160616161626163616461656166616761686169617061716172617361746175617661776178617961806181618261836184618561866187618861896190619161926193619461956196619761986199620062016202620362046205620662076208620962106211621262136214621562166217621862196220622162226223622462256226622762286229623062316232623362346235623662376238623962406241624262436244624562466247624862496250625162526253625462556256625762586259626062616262626362646265626662676268626962706271627262736274627562766277627862796280628162826283628462856286628762886289629062916292629362946295629662976298629963006301630263036304630563066307630863096310631163126313631463156316631763186319632063216322632363246325632663276328632963306331633263336334633563366337633863396340634163426343634463456346634763486349635063516352635363546355635663576358635963606361636263636364636563666367636863696370637163726373637463756376637763786379638063816382638363846385638663876388638963906391639263936394639563966397639863996400640164026403640464056406640764086409641064116412641364146415641664176418641964206421642264236424642564266427642864296430643164326433643464356436643764386439644064416442644364446445644664476448644964506451645264536454645564566457645864596460646164626463646464656466646764686469647064716472647364746475647664776478647964806481648264836484648564866487648864896490649164926493649464956496649764986499650065016502650365046505650665076508650965106511651265136514651565166517651865196520652165226523652465256526652765286529653065316532653365346535653665376538653965406541654265436544654565466547654865496550655165526553655465556556655765586559656065616562656365646565656665676568656965706571657265736574657565766577657865796580658165826583658465856586658765886589659065916592659365946595659665976598659966006601660266036604660566066607660866096610661166126613661466156616661766186619662066216622662366246625662666276628662966306631663266336634663566366637663866396640664166426643664466456646664766486649665066516652665366546655665666576658665966606661666266636664666566666667666866696670667166726673667466756676667766786679668066816682668366846685668666876688668966906691669266936694669566966697669866996700670167026703670467056706670767086709671067116712671367146715671667176718671967206721672267236724672567266727672867296730673167326733673467356736673767386739674067416742674367446745674667476748674967506751675267536754675567566757675867596760676167626763676467656766676767686769677067716772677367746775677667776778677967806781678267836784678567866787678867896790679167926793679467956796679767986799680068016802680368046805680668076808680968106811681268136814681568166817681868196820682168226823682468256826682768286829683068316832683368346835683668376838683968406841684268436844684568466847684868496850685168526853685468556856685768586859686068616862686368646865686668676868686968706871687268736874687568766877687868796880688168826883688468856886688768886889689068916892689368946895689668976898689969006901690269036904690569066907690869096910691169126913691469156916691769186919692069216922692369246925692669276928692969306931693269336934693569366937693869396940694169426943694469456946694769486949695069516952695369546955695669576958695969606961696269636964696569666967696869696970697169726973697469756976697769786979698069816982698369846985698669876988698969906991699269936994699569966997699869997000700170027003700470057006700770087009701070117012701370147015701670177018701970207021702270237024702570267027702870297030703170327033703470357036703770387039704070417042704370447045704670477048704970507051705270537054705570567057705870597060706170627063706470657066706770687069707070717072707370747075707670777078707970807081708270837084708570867087708870897090709170927093709470957096709770987099710071017102710371047105710671077108710971107111711271137114711571167117711871197120712171227123712471257126712771287129713071317132713371347135713671377138713971407141714271437144714571467147714871497150715171527153715471557156715771587159716071617162716371647165716671677168716971707171717271737174717571767177717871797180718171827183718471857186718771887189719071917192719371947195719671977198719972007201720272037204720572067207720872097210721172127213721472157216721772187219722072217222722372247225722672277228722972307231723272337234723572367237723872397240724172427243724472457246724772487249725072517252725372547255725672577258725972607261726272637264726572667267726872697270727172727273727472757276727772787279728072817282728372847285728672877288728972907291729272937294729572967297729872997300730173027303730473057306730773087309731073117312731373147315731673177318731973207321732273237324732573267327732873297330733173327333733473357336733773387339734073417342734373447345734673477348734973507351735273537354735573567357735873597360736173627363736473657366736773687369737073717372737373747375737673777378737973807381738273837384738573867387738873897390739173927393739473957396739773987399740074017402740374047405740674077408740974107411741274137414741574167417741874197420742174227423742474257426742774287429743074317432743374347435743674377438743974407441744274437444744574467447744874497450745174527453745474557456745774587459746074617462746374647465746674677468746974707471747274737474747574767477747874797480748174827483748474857486748774887489749074917492749374947495749674977498749975007501750275037504750575067507750875097510751175127513751475157516751775187519752075217522752375247525752675277528752975307531753275337534753575367537753875397540754175427543754475457546754775487549755075517552755375547555755675577558755975607561756275637564756575667567756875697570757175727573757475757576757775787579758075817582758375847585758675877588758975907591759275937594759575967597759875997600760176027603760476057606760776087609761076117612761376147615761676177618761976207621762276237624762576267627762876297630763176327633763476357636763776387639764076417642764376447645764676477648764976507651765276537654765576567657765876597660766176627663766476657666766776687669767076717672767376747675767676777678767976807681768276837684768576867687768876897690769176927693769476957696769776987699770077017702770377047705770677077708770977107711771277137714771577167717771877197720772177227723772477257726772777287729773077317732773377347735773677377738773977407741774277437744774577467747774877497750775177527753775477557756775777587759776077617762776377647765776677677768776977707771777277737774777577767777777877797780778177827783778477857786778777887789779077917792779377947795779677977798779978007801780278037804780578067807780878097810781178127813781478157816781778187819782078217822782378247825782678277828782978307831783278337834783578367837783878397840784178427843784478457846784778487849785078517852785378547855785678577858785978607861786278637864786578667867786878697870787178727873787478757876787778787879788078817882788378847885788678877888788978907891789278937894789578967897789878997900790179027903790479057906790779087909791079117912791379147915791679177918791979207921792279237924792579267927792879297930793179327933793479357936793779387939794079417942794379447945794679477948794979507951795279537954795579567957795879597960796179627963796479657966796779687969797079717972797379747975797679777978797979807981798279837984798579867987798879897990799179927993799479957996799779987999800080018002800380048005800680078008800980108011801280138014801580168017801880198020802180228023802480258026802780288029803080318032803380348035803680378038803980408041804280438044804580468047804880498050805180528053805480558056805780588059806080618062806380648065806680678068806980708071807280738074807580768077807880798080808180828083808480858086808780888089809080918092809380948095809680978098809981008101810281038104810581068107810881098110811181128113811481158116811781188119812081218122812381248125812681278128812981308131813281338134813581368137813881398140814181428143814481458146814781488149815081518152815381548155815681578158815981608161816281638164816581668167816881698170817181728173817481758176817781788179818081818182818381848185818681878188818981908191819281938194819581968197819881998200820182028203820482058206820782088209821082118212821382148215821682178218821982208221822282238224822582268227822882298230823182328233823482358236823782388239824082418242824382448245824682478248824982508251825282538254825582568257825882598260826182628263826482658266826782688269827082718272827382748275827682778278827982808281828282838284828582868287828882898290829182928293829482958296829782988299830083018302830383048305830683078308830983108311831283138314831583168317831883198320832183228323832483258326832783288329833083318332833383348335833683378338833983408341834283438344834583468347834883498350835183528353835483558356835783588359836083618362836383648365836683678368836983708371837283738374837583768377837883798380838183828383838483858386838783888389839083918392839383948395839683978398839984008401840284038404840584068407840884098410841184128413841484158416841784188419842084218422842384248425842684278428842984308431843284338434843584368437843884398440844184428443844484458446844784488449845084518452845384548455845684578458845984608461846284638464846584668467846884698470847184728473847484758476847784788479848084818482848384848485848684878488848984908491849284938494849584968497849884998500850185028503850485058506850785088509851085118512851385148515851685178518851985208521852285238524852585268527852885298530853185328533853485358536853785388539854085418542854385448545854685478548854985508551855285538554855585568557855885598560856185628563856485658566856785688569857085718572857385748575857685778578857985808581858285838584858585868587858885898590859185928593859485958596859785988599860086018602860386048605860686078608860986108611861286138614861586168617861886198620862186228623862486258626862786288629863086318632863386348635863686378638863986408641864286438644864586468647864886498650865186528653865486558656865786588659866086618662866386648665866686678668866986708671867286738674867586768677867886798680868186828683868486858686868786888689869086918692869386948695869686978698869987008701870287038704870587068707870887098710871187128713871487158716871787188719872087218722872387248725872687278728872987308731873287338734873587368737873887398740874187428743874487458746874787488749875087518752875387548755875687578758875987608761876287638764876587668767876887698770877187728773877487758776877787788779878087818782878387848785878687878788878987908791879287938794879587968797879887998800880188028803880488058806880788088809881088118812881388148815881688178818881988208821882288238824882588268827882888298830883188328833883488358836883788388839884088418842884388448845884688478848884988508851885288538854885588568857885888598860886188628863886488658866886788688869887088718872887388748875887688778878887988808881888288838884888588868887888888898890889188928893889488958896889788988899890089018902890389048905890689078908890989108911891289138914891589168917891889198920892189228923892489258926892789288929893089318932893389348935893689378938893989408941894289438944894589468947894889498950895189528953895489558956895789588959896089618962896389648965896689678968896989708971897289738974897589768977897889798980898189828983898489858986898789888989899089918992899389948995899689978998899990009001900290039004900590069007900890099010901190129013901490159016901790189019902090219022902390249025902690279028902990309031903290339034903590369037903890399040904190429043904490459046904790489049905090519052905390549055905690579058905990609061906290639064906590669067906890699070907190729073907490759076907790789079908090819082908390849085908690879088908990909091909290939094909590969097909890999100910191029103910491059106910791089109911091119112911391149115911691179118911991209121912291239124912591269127912891299130913191329133913491359136913791389139914091419142914391449145914691479148914991509151915291539154915591569157915891599160916191629163916491659166916791689169917091719172917391749175917691779178917991809181918291839184918591869187918891899190919191929193919491959196919791989199920092019202920392049205920692079208920992109211921292139214921592169217921892199220922192229223922492259226922792289229923092319232923392349235923692379238923992409241924292439244924592469247924892499250925192529253925492559256925792589259926092619262926392649265926692679268926992709271927292739274927592769277927892799280928192829283928492859286928792889289929092919292929392949295929692979298929993009301930293039304930593069307930893099310931193129313931493159316931793189319932093219322932393249325932693279328932993309331933293339334933593369337933893399340934193429343934493459346934793489349935093519352935393549355935693579358935993609361936293639364936593669367936893699370937193729373937493759376937793789379938093819382938393849385938693879388938993909391939293939394939593969397939893999400940194029403940494059406940794089409941094119412941394149415941694179418941994209421942294239424942594269427942894299430943194329433943494359436943794389439944094419442944394449445944694479448944994509451945294539454945594569457945894599460946194629463946494659466946794689469947094719472947394749475947694779478947994809481948294839484948594869487948894899490949194929493949494959496949794989499950095019502950395049505950695079508950995109511951295139514951595169517951895199520952195229523952495259526952795289529953095319532953395349535953695379538953995409541954295439544954595469547954895499550955195529553955495559556955795589559956095619562956395649565956695679568956995709571957295739574957595769577957895799580958195829583958495859586958795889589959095919592959395949595959695979598959996009601960296039604960596069607960896099610961196129613961496159616961796189619962096219622962396249625962696279628962996309631963296339634963596369637963896399640964196429643964496459646964796489649965096519652965396549655965696579658965996609661966296639664966596669667966896699670967196729673967496759676967796789679968096819682968396849685968696879688968996909691969296939694969596969697969896999700970197029703970497059706970797089709971097119712971397149715971697179718971997209721972297239724972597269727972897299730973197329733973497359736973797389739974097419742974397449745974697479748974997509751975297539754975597569757975897599760976197629763976497659766976797689769977097719772977397749775977697779778977997809781978297839784978597869787978897899790979197929793979497959796979797989799980098019802980398049805980698079808980998109811981298139814981598169817981898199820982198229823982498259826982798289829983098319832983398349835983698379838983998409841984298439844984598469847984898499850985198529853985498559856985798589859986098619862986398649865986698679868986998709871987298739874987598769877987898799880988198829883988498859886988798889889989098919892989398949895989698979898989999009901990299039904990599069907990899099910991199129913991499159916991799189919992099219922992399249925992699279928992999309931993299339934993599369937993899399940994199429943994499459946994799489949995099519952995399549955995699579958995999609961996299639964996599669967996899699970997199729973997499759976997799789979998099819982998399849985998699879988998999909991999299939994999599969997999899991000010001100021000310004100051000610007100081000910010100111001210013100141001510016100171001810019100201002110022100231002410025100261002710028100291003010031100321003310034100351003610037100381003910040100411004210043100441004510046100471004810049100501005110052100531005410055100561005710058100591006010061100621006310064100651006610067100681006910070100711007210073100741007510076100771007810079100801008110082100831008410085100861008710088100891009010091100921009310094100951009610097100981009910100101011010210103101041010510106101071010810109101101011110112101131011410115101161011710118101191012010121101221012310124101251012610127101281012910130101311013210133101341013510136101371013810139101401014110142101431014410145101461014710148101491015010151101521015310154101551015610157101581015910160101611016210163101641016510166101671016810169101701017110172101731017410175101761017710178101791018010181101821018310184101851018610187101881018910190101911019210193101941019510196101971019810199102001020110202102031020410205102061020710208102091021010211102121021310214102151021610217102181021910220102211022210223102241022510226102271022810229102301023110232102331023410235102361023710238102391024010241102421024310244102451024610247102481024910250102511025210253102541025510256102571025810259102601026110262102631026410265102661026710268102691027010271102721027310274102751027610277102781027910280102811028210283102841028510286102871028810289102901029110292102931029410295102961029710298102991030010301103021030310304103051030610307103081030910310103111031210313103141031510316103171031810319103201032110322103231032410325103261032710328103291033010331103321033310334103351033610337103381033910340103411034210343103441034510346103471034810349103501035110352103531035410355103561035710358103591036010361103621036310364103651036610367103681036910370103711037210373103741037510376103771037810379103801038110382103831038410385103861038710388103891039010391103921039310394103951039610397103981039910400104011040210403104041040510406104071040810409104101041110412104131041410415104161041710418104191042010421104221042310424104251042610427104281042910430104311043210433104341043510436104371043810439104401044110442104431044410445104461044710448104491045010451104521045310454104551045610457104581045910460104611046210463104641046510466104671046810469104701047110472104731047410475104761047710478104791048010481104821048310484104851048610487104881048910490104911049210493104941049510496104971049810499105001050110502105031050410505105061050710508105091051010511105121051310514105151051610517105181051910520105211052210523105241052510526105271052810529105301053110532105331053410535105361053710538105391054010541105421054310544105451054610547105481054910550105511055210553105541055510556105571055810559105601056110562105631056410565105661056710568105691057010571105721057310574105751057610577105781057910580105811058210583105841058510586105871058810589105901059110592105931059410595105961059710598105991060010601106021060310604106051060610607106081060910610106111061210613106141061510616106171061810619106201062110622106231062410625106261062710628106291063010631106321063310634106351063610637106381063910640106411064210643106441064510646106471064810649106501065110652106531065410655106561065710658106591066010661106621066310664106651066610667106681066910670106711067210673106741067510676106771067810679106801068110682106831068410685106861068710688106891069010691106921069310694106951069610697106981069910700107011070210703107041070510706107071070810709107101071110712107131071410715107161071710718107191072010721107221072310724107251072610727107281072910730107311073210733107341073510736107371073810739107401074110742107431074410745107461074710748107491075010751107521075310754107551075610757107581075910760107611076210763107641076510766107671076810769107701077110772107731077410775107761077710778107791078010781107821078310784107851078610787107881078910790107911079210793107941079510796107971079810799108001080110802108031080410805108061080710808108091081010811108121081310814108151081610817108181081910820108211082210823108241082510826108271082810829108301083110832108331083410835108361083710838108391084010841108421084310844108451084610847108481084910850108511085210853108541085510856108571085810859108601086110862108631086410865108661086710868108691087010871108721087310874108751087610877108781087910880108811088210883108841088510886108871088810889108901089110892108931089410895108961089710898108991090010901109021090310904109051090610907109081090910910109111091210913109141091510916109171091810919109201092110922109231092410925109261092710928109291093010931109321093310934109351093610937109381093910940109411094210943109441094510946109471094810949109501095110952109531095410955109561095710958109591096010961109621096310964109651096610967109681096910970109711097210973109741097510976109771097810979109801098110982109831098410985109861098710988109891099010991109921099310994109951099610997109981099911000110011100211003110041100511006110071100811009110101101111012110131101411015110161101711018110191102011021110221102311024110251102611027110281102911030110311103211033110341103511036110371103811039110401104111042110431104411045110461104711048110491105011051110521105311054110551105611057110581105911060110611106211063110641106511066110671106811069110701107111072110731107411075110761107711078110791108011081110821108311084110851108611087110881108911090110911109211093110941109511096110971109811099111001110111102111031110411105111061110711108111091111011111111121111311114111151111611117111181111911120111211112211123111241112511126111271112811129111301113111132111331113411135111361113711138111391114011141111421114311144111451114611147111481114911150111511115211153111541115511156111571115811159111601116111162111631116411165111661116711168111691117011171111721117311174111751117611177111781117911180111811118211183111841118511186111871118811189111901119111192111931119411195111961119711198111991120011201112021120311204112051120611207112081120911210112111121211213112141121511216112171121811219112201122111222112231122411225112261122711228112291123011231112321123311234112351123611237112381123911240112411124211243112441124511246112471124811249112501125111252112531125411255112561125711258112591126011261112621126311264112651126611267112681126911270112711127211273112741127511276112771127811279112801128111282112831128411285112861128711288112891129011291112921129311294112951129611297112981129911300113011130211303113041130511306113071130811309113101131111312113131131411315113161131711318113191132011321113221132311324113251132611327113281132911330113311133211333113341133511336113371133811339113401134111342113431134411345113461134711348113491135011351113521135311354113551135611357113581135911360113611136211363113641136511366113671136811369113701137111372113731137411375113761137711378113791138011381113821138311384113851138611387113881138911390113911139211393113941139511396113971139811399114001140111402114031140411405114061140711408114091141011411114121141311414114151141611417114181141911420114211142211423114241142511426114271142811429114301143111432114331143411435114361143711438114391144011441114421144311444114451144611447114481144911450114511145211453114541145511456114571145811459114601146111462114631146411465114661146711468114691147011471114721147311474114751147611477114781147911480114811148211483114841148511486114871148811489114901149111492114931149411495114961149711498114991150011501115021150311504115051150611507115081150911510115111151211513115141151511516115171151811519115201152111522115231152411525115261152711528115291153011531115321153311534115351153611537115381153911540115411154211543115441154511546115471154811549115501155111552115531155411555115561155711558115591156011561115621156311564115651156611567115681156911570115711157211573115741157511576115771157811579115801158111582115831158411585115861158711588115891159011591115921159311594115951159611597115981159911600116011160211603116041160511606116071160811609116101161111612116131161411615116161161711618116191162011621116221162311624116251162611627116281162911630116311163211633116341163511636116371163811639116401164111642116431164411645116461164711648116491165011651116521165311654116551165611657116581165911660116611166211663116641166511666116671166811669116701167111672116731167411675116761167711678116791168011681116821168311684116851168611687116881168911690116911169211693116941169511696116971169811699117001170111702117031170411705117061170711708117091171011711117121171311714117151171611717117181171911720117211172211723117241172511726117271172811729117301173111732117331173411735117361173711738117391174011741117421174311744117451174611747117481174911750117511175211753117541175511756117571175811759117601176111762117631176411765117661176711768117691177011771117721177311774117751177611777117781177911780117811178211783117841178511786117871178811789117901179111792117931179411795117961179711798117991180011801118021180311804118051180611807118081180911810118111181211813118141181511816118171181811819118201182111822118231182411825118261182711828118291183011831118321183311834118351183611837118381183911840118411184211843118441184511846118471184811849118501185111852118531185411855118561185711858118591186011861118621186311864118651186611867118681186911870118711187211873118741187511876118771187811879118801188111882118831188411885118861188711888118891189011891118921189311894118951189611897118981189911900119011190211903119041190511906119071190811909119101191111912119131191411915119161191711918119191192011921119221192311924119251192611927119281192911930119311193211933119341193511936119371193811939119401194111942119431194411945119461194711948119491195011951119521195311954119551195611957119581195911960119611196211963119641196511966119671196811969119701197111972119731197411975119761197711978119791198011981119821198311984119851198611987119881198911990119911199211993119941199511996119971199811999120001200112002120031200412005120061200712008120091201012011120121201312014120151201612017120181201912020120211202212023120241202512026120271202812029120301203112032120331203412035120361203712038120391204012041120421204312044120451204612047120481204912050120511205212053120541205512056120571205812059120601206112062120631206412065120661206712068120691207012071120721207312074120751207612077120781207912080120811208212083120841208512086120871208812089120901209112092120931209412095120961209712098120991210012101121021210312104121051210612107121081210912110121111211212113121141211512116121171211812119121201212112122121231212412125121261212712128121291213012131121321213312134121351213612137121381213912140121411214212143121441214512146121471214812149121501215112152121531215412155121561215712158121591216012161121621216312164121651216612167121681216912170121711217212173121741217512176121771217812179121801218112182121831218412185121861218712188121891219012191121921219312194121951219612197121981219912200122011220212203122041220512206122071220812209122101221112212122131221412215122161221712218122191222012221122221222312224122251222612227122281222912230122311223212233122341223512236122371223812239122401224112242122431224412245122461224712248122491225012251122521225312254122551225612257122581225912260122611226212263122641226512266122671226812269122701227112272122731227412275122761227712278122791228012281122821228312284122851228612287122881228912290122911229212293122941229512296122971229812299123001230112302123031230412305123061230712308123091231012311123121231312314123151231612317123181231912320123211232212323123241232512326123271232812329123301233112332123331233412335123361233712338123391234012341123421234312344123451234612347123481234912350123511235212353123541235512356123571235812359123601236112362123631236412365123661236712368123691237012371123721237312374123751237612377123781237912380123811238212383123841238512386123871238812389123901239112392123931239412395123961239712398123991240012401124021240312404124051240612407124081240912410124111241212413124141241512416124171241812419124201242112422124231242412425124261242712428124291243012431124321243312434124351243612437124381243912440124411244212443124441244512446124471244812449124501245112452124531245412455124561245712458124591246012461124621246312464124651246612467124681246912470124711247212473124741247512476124771247812479124801248112482124831248412485124861248712488124891249012491124921249312494124951249612497124981249912500125011250212503125041250512506125071250812509125101251112512125131251412515125161251712518125191252012521125221252312524125251252612527125281252912530125311253212533125341253512536125371253812539125401254112542125431254412545125461254712548125491255012551125521255312554125551255612557125581255912560125611256212563125641256512566125671256812569125701257112572125731257412575125761257712578125791258012581125821258312584125851258612587125881258912590125911259212593125941259512596125971259812599126001260112602126031260412605126061260712608126091261012611126121261312614126151261612617126181261912620126211262212623126241262512626126271262812629126301263112632126331263412635126361263712638126391264012641126421264312644126451264612647126481264912650126511265212653126541265512656126571265812659126601266112662126631266412665126661266712668126691267012671126721267312674126751267612677126781267912680126811268212683126841268512686126871268812689126901269112692126931269412695126961269712698126991270012701127021270312704127051270612707127081270912710127111271212713127141271512716127171271812719127201272112722127231272412725127261272712728127291273012731127321273312734127351273612737127381273912740127411274212743127441274512746127471274812749127501275112752127531275412755127561275712758127591276012761127621276312764127651276612767127681276912770127711277212773127741277512776127771277812779127801278112782127831278412785127861278712788127891279012791127921279312794127951279612797127981279912800128011280212803128041280512806128071280812809128101281112812128131281412815128161281712818128191282012821128221282312824128251282612827128281282912830128311283212833128341283512836128371283812839128401284112842128431284412845128461284712848128491285012851128521285312854128551285612857128581285912860128611286212863128641286512866128671286812869128701287112872128731287412875128761287712878128791288012881128821288312884128851288612887128881288912890128911289212893128941289512896128971289812899129001290112902129031290412905129061290712908129091291012911129121291312914129151291612917129181291912920129211292212923129241292512926129271292812929129301293112932129331293412935129361293712938129391294012941129421294312944129451294612947129481294912950129511295212953129541295512956129571295812959129601296112962129631296412965129661296712968129691297012971129721297312974129751297612977129781297912980129811298212983129841298512986129871298812989129901299112992129931299412995129961299712998129991300013001130021300313004130051300613007130081300913010130111301213013130141301513016130171301813019130201302113022130231302413025130261302713028130291303013031130321303313034130351303613037130381303913040130411304213043130441304513046130471304813049130501305113052130531305413055130561305713058130591306013061130621306313064130651306613067130681306913070130711307213073130741307513076130771307813079130801308113082130831308413085130861308713088130891309013091130921309313094130951309613097130981309913100131011310213103131041310513106131071310813109131101311113112131131311413115131161311713118131191312013121131221312313124131251312613127131281312913130131311313213133131341313513136131371313813139131401314113142131431314413145131461314713148131491315013151131521315313154131551315613157131581315913160131611316213163131641316513166131671316813169131701317113172131731317413175131761317713178131791318013181131821318313184131851318613187131881318913190131911319213193131941319513196131971319813199132001320113202132031320413205132061320713208132091321013211132121321313214132151321613217132181321913220132211322213223132241322513226132271322813229132301323113232132331323413235132361323713238132391324013241132421324313244132451324613247132481324913250132511325213253132541325513256132571325813259132601326113262132631326413265132661326713268132691327013271132721327313274132751327613277132781327913280132811328213283132841328513286132871328813289132901329113292132931329413295132961329713298132991330013301133021330313304133051330613307133081330913310133111331213313133141331513316133171331813319133201332113322133231332413325133261332713328133291333013331133321333313334133351333613337133381333913340133411334213343133441334513346133471334813349133501335113352133531335413355133561335713358133591336013361133621336313364133651336613367133681336913370133711337213373133741337513376133771337813379133801338113382133831338413385133861338713388133891339013391133921339313394133951339613397133981339913400134011340213403134041340513406134071340813409134101341113412134131341413415134161341713418134191342013421134221342313424134251342613427134281342913430134311343213433134341343513436134371343813439134401344113442134431344413445134461344713448134491345013451134521345313454134551345613457134581345913460134611346213463134641346513466134671346813469134701347113472134731347413475134761347713478134791348013481134821348313484134851348613487134881348913490134911349213493134941349513496134971349813499135001350113502135031350413505135061350713508135091351013511135121351313514135151351613517135181351913520135211352213523135241352513526135271352813529135301353113532135331353413535135361353713538135391354013541135421354313544135451354613547135481354913550135511355213553135541355513556135571355813559135601356113562135631356413565135661356713568135691357013571135721357313574135751357613577135781357913580135811358213583135841358513586135871358813589135901359113592135931359413595135961359713598135991360013601136021360313604136051360613607136081360913610136111361213613136141361513616136171361813619136201362113622136231362413625136261362713628136291363013631136321363313634136351363613637136381363913640136411364213643136441364513646136471364813649136501365113652136531365413655136561365713658136591366013661136621366313664136651366613667136681366913670136711367213673136741367513676136771367813679136801368113682136831368413685136861368713688136891369013691136921369313694136951369613697136981369913700137011370213703137041370513706137071370813709137101371113712137131371413715137161371713718137191372013721137221372313724137251372613727137281372913730137311373213733137341373513736137371373813739137401374113742137431374413745137461374713748137491375013751137521375313754137551375613757137581375913760137611376213763137641376513766137671376813769137701377113772137731377413775137761377713778137791378013781137821378313784137851378613787137881378913790137911379213793137941379513796137971379813799138001380113802138031380413805138061380713808138091381013811138121381313814138151381613817138181381913820138211382213823138241382513826138271382813829138301383113832138331383413835138361383713838138391384013841138421384313844138451384613847138481384913850138511385213853138541385513856138571385813859138601386113862138631386413865138661386713868138691387013871138721387313874138751387613877138781387913880138811388213883138841388513886138871388813889138901389113892138931389413895138961389713898138991390013901139021390313904139051390613907139081390913910139111391213913139141391513916139171391813919139201392113922139231392413925139261392713928139291393013931139321393313934139351393613937139381393913940139411394213943139441394513946139471394813949139501395113952139531395413955139561395713958139591396013961139621396313964139651396613967139681396913970139711397213973139741397513976139771397813979139801398113982139831398413985139861398713988139891399013991139921399313994139951399613997139981399914000140011400214003140041400514006140071400814009140101401114012140131401414015140161401714018140191402014021140221402314024140251402614027140281402914030140311403214033140341403514036140371403814039140401404114042140431404414045140461404714048140491405014051140521405314054140551405614057140581405914060140611406214063140641406514066140671406814069140701407114072140731407414075140761407714078140791408014081140821408314084140851408614087140881408914090140911409214093140941409514096140971409814099141001410114102141031410414105141061410714108141091411014111141121411314114141151411614117141181411914120141211412214123141241412514126141271412814129141301413114132141331413414135141361413714138141391414014141141421414314144141451414614147141481414914150141511415214153141541415514156141571415814159141601416114162141631416414165141661416714168141691417014171141721417314174141751417614177141781417914180141811418214183141841418514186141871418814189141901419114192141931419414195141961419714198141991420014201142021420314204142051420614207142081420914210142111421214213142141421514216142171421814219142201422114222142231422414225142261422714228142291423014231142321423314234142351423614237142381423914240142411424214243142441424514246142471424814249142501425114252142531425414255142561425714258142591426014261142621426314264142651426614267142681426914270142711427214273142741427514276142771427814279142801428114282142831428414285142861428714288142891429014291142921429314294142951429614297142981429914300143011430214303143041430514306143071430814309143101431114312143131431414315143161431714318143191432014321143221432314324143251432614327143281432914330143311433214333143341433514336143371433814339143401434114342143431434414345143461434714348143491435014351143521435314354143551435614357143581435914360143611436214363143641436514366143671436814369143701437114372143731437414375143761437714378143791438014381143821438314384143851438614387143881438914390143911439214393143941439514396143971439814399144001440114402144031440414405144061440714408144091441014411144121441314414144151441614417144181441914420144211442214423144241442514426144271442814429144301443114432144331443414435144361443714438144391444014441144421444314444144451444614447144481444914450144511445214453144541445514456144571445814459144601446114462144631446414465144661446714468144691447014471144721447314474144751447614477144781447914480144811448214483144841448514486144871448814489144901449114492144931449414495144961449714498144991450014501145021450314504145051450614507145081450914510145111451214513145141451514516145171451814519145201452114522145231452414525145261452714528145291453014531145321453314534145351453614537145381453914540145411454214543145441454514546145471454814549145501455114552145531455414555145561455714558145591456014561145621456314564145651456614567145681456914570145711457214573145741457514576145771457814579145801458114582145831458414585145861458714588145891459014591145921459314594145951459614597145981459914600146011460214603146041460514606146071460814609146101461114612146131461414615146161461714618146191462014621146221462314624146251462614627146281462914630146311463214633146341463514636146371463814639146401464114642146431464414645146461464714648146491465014651146521465314654146551465614657146581465914660146611466214663146641466514666146671466814669146701467114672146731467414675146761467714678146791468014681146821468314684146851468614687146881468914690146911469214693146941469514696146971469814699147001470114702147031470414705147061470714708147091471014711147121471314714147151471614717147181471914720147211472214723147241472514726147271472814729147301473114732147331473414735147361473714738147391474014741147421474314744147451474614747147481474914750147511475214753147541475514756147571475814759147601476114762147631476414765147661476714768147691477014771147721477314774147751477614777147781477914780147811478214783147841478514786147871478814789147901479114792147931479414795147961479714798147991480014801148021480314804148051480614807148081480914810148111481214813148141481514816148171481814819148201482114822148231482414825148261482714828148291483014831148321483314834148351483614837148381483914840148411484214843148441484514846148471484814849148501485114852148531485414855148561485714858148591486014861148621486314864148651486614867148681486914870148711487214873148741487514876148771487814879148801488114882148831488414885148861488714888148891489014891148921489314894148951489614897148981489914900149011490214903149041490514906149071490814909149101491114912149131491414915149161491714918149191492014921149221492314924149251492614927149281492914930149311493214933149341493514936149371493814939149401494114942149431494414945149461494714948149491495014951149521495314954149551495614957149581495914960149611496214963149641496514966149671496814969149701497114972149731497414975149761497714978149791498014981149821498314984149851498614987149881498914990149911499214993149941499514996149971499814999150001500115002150031500415005150061500715008150091501015011150121501315014150151501615017150181501915020150211502215023150241502515026150271502815029150301503115032150331503415035150361503715038150391504015041150421504315044150451504615047150481504915050150511505215053150541505515056150571505815059150601506115062150631506415065150661506715068150691507015071150721507315074150751507615077150781507915080150811508215083150841508515086150871508815089150901509115092150931509415095150961509715098150991510015101151021510315104151051510615107151081510915110151111511215113151141511515116151171511815119151201512115122151231512415125151261512715128151291513015131151321513315134151351513615137151381513915140151411514215143151441514515146151471514815149151501515115152151531515415155151561515715158151591516015161151621516315164151651516615167151681516915170151711517215173151741517515176151771517815179151801518115182151831518415185151861518715188151891519015191151921519315194151951519615197151981519915200152011520215203152041520515206152071520815209152101521115212152131521415215152161521715218152191522015221152221522315224152251522615227152281522915230152311523215233152341523515236152371523815239152401524115242152431524415245152461524715248152491525015251152521525315254152551525615257152581525915260152611526215263152641526515266152671526815269152701527115272152731527415275152761527715278152791528015281152821528315284152851528615287152881528915290152911529215293152941529515296152971529815299153001530115302153031530415305153061530715308153091531015311153121531315314153151531615317153181531915320153211532215323153241532515326153271532815329153301533115332153331533415335153361533715338153391534015341153421534315344153451534615347153481534915350153511535215353153541535515356153571535815359153601536115362153631536415365153661536715368153691537015371153721537315374153751537615377153781537915380153811538215383153841538515386153871538815389153901539115392153931539415395153961539715398153991540015401154021540315404154051540615407154081540915410154111541215413154141541515416154171541815419154201542115422154231542415425154261542715428154291543015431154321543315434154351543615437154381543915440154411544215443154441544515446154471544815449154501545115452154531545415455154561545715458154591546015461154621546315464154651546615467154681546915470154711547215473154741547515476154771547815479154801548115482154831548415485154861548715488154891549015491154921549315494154951549615497154981549915500155011550215503155041550515506155071550815509155101551115512155131551415515155161551715518155191552015521155221552315524155251552615527155281552915530155311553215533155341553515536155371553815539155401554115542155431554415545155461554715548155491555015551155521555315554155551555615557155581555915560155611556215563155641556515566155671556815569155701557115572155731557415575155761557715578155791558015581155821558315584155851558615587155881558915590155911559215593155941559515596155971559815599156001560115602156031560415605156061560715608156091561015611156121561315614156151561615617156181561915620156211562215623156241562515626156271562815629156301563115632156331563415635156361563715638156391564015641156421564315644156451564615647156481564915650156511565215653156541565515656156571565815659156601566115662156631566415665156661566715668156691567015671156721567315674156751567615677156781567915680156811568215683156841568515686156871568815689156901569115692156931569415695156961569715698156991570015701157021570315704157051570615707157081570915710157111571215713157141571515716157171571815719157201572115722157231572415725157261572715728157291573015731157321573315734157351573615737157381573915740157411574215743157441574515746157471574815749157501575115752157531575415755157561575715758157591576015761157621576315764157651576615767157681576915770157711577215773157741577515776157771577815779157801578115782157831578415785157861578715788157891579015791157921579315794157951579615797157981579915800158011580215803158041580515806158071580815809158101581115812158131581415815158161581715818158191582015821158221582315824158251582615827158281582915830158311583215833158341583515836158371583815839158401584115842158431584415845158461584715848158491585015851158521585315854158551585615857158581585915860158611586215863158641586515866158671586815869158701587115872158731587415875158761587715878158791588015881158821588315884158851588615887158881588915890158911589215893158941589515896158971589815899159001590115902159031590415905159061590715908159091591015911159121591315914159151591615917159181591915920159211592215923159241592515926159271592815929159301593115932159331593415935159361593715938159391594015941159421594315944159451594615947159481594915950159511595215953159541595515956159571595815959159601596115962159631596415965159661596715968159691597015971159721597315974159751597615977159781597915980159811598215983159841598515986159871598815989159901599115992159931599415995159961599715998159991600016001160021600316004160051600616007160081600916010160111601216013160141601516016160171601816019160201602116022160231602416025160261602716028160291603016031160321603316034160351603616037160381603916040160411604216043160441604516046160471604816049160501605116052160531605416055160561605716058160591606016061160621606316064160651606616067160681606916070160711607216073160741607516076160771607816079160801608116082160831608416085160861608716088160891609016091160921609316094160951609616097160981609916100161011610216103161041610516106161071610816109161101611116112161131611416115161161611716118161191612016121161221612316124161251612616127161281612916130161311613216133161341613516136161371613816139161401614116142161431614416145161461614716148161491615016151161521615316154161551615616157161581615916160161611616216163161641616516166161671616816169161701617116172161731617416175161761617716178161791618016181161821618316184161851618616187161881618916190161911619216193161941619516196161971619816199162001620116202162031620416205162061620716208162091621016211162121621316214162151621616217162181621916220162211622216223162241622516226162271622816229162301623116232162331623416235162361623716238162391624016241162421624316244162451624616247162481624916250162511625216253162541625516256162571625816259162601626116262162631626416265162661626716268162691627016271162721627316274162751627616277162781627916280162811628216283162841628516286162871628816289162901629116292162931629416295162961629716298162991630016301163021630316304163051630616307163081630916310163111631216313163141631516316163171631816319163201632116322163231632416325163261632716328163291633016331163321633316334163351633616337163381633916340163411634216343163441634516346163471634816349163501635116352163531635416355163561635716358163591636016361163621636316364163651636616367163681636916370163711637216373163741637516376163771637816379163801638116382163831638416385163861638716388163891639016391163921639316394163951639616397163981639916400164011640216403164041640516406164071640816409164101641116412164131641416415164161641716418164191642016421164221642316424164251642616427164281642916430164311643216433164341643516436164371643816439164401644116442164431644416445164461644716448164491645016451164521645316454164551645616457164581645916460164611646216463164641646516466164671646816469164701647116472164731647416475164761647716478164791648016481164821648316484164851648616487164881648916490164911649216493164941649516496164971649816499165001650116502165031650416505165061650716508165091651016511165121651316514165151651616517165181651916520165211652216523165241652516526165271652816529165301653116532165331653416535165361653716538165391654016541165421654316544165451654616547165481654916550165511655216553165541655516556165571655816559165601656116562165631656416565165661656716568165691657016571165721657316574165751657616577165781657916580165811658216583165841658516586165871658816589165901659116592165931659416595165961659716598165991660016601166021660316604166051660616607166081660916610166111661216613166141661516616166171661816619166201662116622166231662416625166261662716628166291663016631166321663316634166351663616637166381663916640166411664216643166441664516646166471664816649166501665116652166531665416655166561665716658166591666016661166621666316664166651666616667166681666916670166711667216673166741667516676166771667816679166801668116682166831668416685166861668716688166891669016691166921669316694166951669616697166981669916700167011670216703167041670516706167071670816709167101671116712167131671416715167161671716718167191672016721167221672316724167251672616727167281672916730167311673216733167341673516736167371673816739167401674116742167431674416745167461674716748167491675016751167521675316754167551675616757167581675916760167611676216763167641676516766167671676816769167701677116772167731677416775167761677716778167791678016781167821678316784167851678616787167881678916790167911679216793167941679516796167971679816799168001680116802168031680416805168061680716808168091681016811168121681316814168151681616817168181681916820168211682216823168241682516826168271682816829168301683116832168331683416835168361683716838168391684016841168421684316844168451684616847168481684916850168511685216853168541685516856168571685816859168601686116862168631686416865168661686716868168691687016871168721687316874168751687616877168781687916880168811688216883168841688516886168871688816889168901689116892168931689416895168961689716898168991690016901169021690316904169051690616907169081690916910169111691216913169141691516916169171691816919169201692116922169231692416925169261692716928169291693016931169321693316934169351693616937169381693916940169411694216943169441694516946169471694816949169501695116952169531695416955169561695716958169591696016961169621696316964169651696616967169681696916970169711697216973169741697516976169771697816979169801698116982169831698416985169861698716988169891699016991169921699316994169951699616997169981699917000170011700217003170041700517006170071700817009170101701117012170131701417015170161701717018170191702017021170221702317024170251702617027170281702917030170311703217033170341703517036170371703817039170401704117042170431704417045170461704717048170491705017051170521705317054170551705617057170581705917060170611706217063170641706517066170671706817069170701707117072170731707417075170761707717078170791708017081170821708317084170851708617087170881708917090170911709217093170941709517096170971709817099171001710117102171031710417105171061710717108171091711017111171121711317114171151711617117171181711917120171211712217123171241712517126171271712817129171301713117132171331713417135171361713717138171391714017141171421714317144171451714617147171481714917150171511715217153171541715517156171571715817159171601716117162171631716417165171661716717168171691717017171171721717317174171751717617177171781717917180171811718217183171841718517186171871718817189171901719117192171931719417195171961719717198171991720017201172021720317204172051720617207172081720917210172111721217213172141721517216172171721817219172201722117222172231722417225172261722717228172291723017231172321723317234172351723617237172381723917240172411724217243172441724517246172471724817249172501725117252172531725417255172561725717258172591726017261172621726317264172651726617267172681726917270172711727217273172741727517276172771727817279172801728117282172831728417285172861728717288172891729017291172921729317294172951729617297172981729917300173011730217303173041730517306173071730817309173101731117312173131731417315173161731717318173191732017321173221732317324173251732617327173281732917330173311733217333173341733517336173371733817339173401734117342173431734417345173461734717348173491735017351173521735317354173551735617357173581735917360173611736217363173641736517366173671736817369173701737117372173731737417375173761737717378173791738017381173821738317384173851738617387173881738917390173911739217393173941739517396173971739817399174001740117402174031740417405174061740717408174091741017411174121741317414174151741617417174181741917420174211742217423174241742517426174271742817429174301743117432174331743417435174361743717438174391744017441174421744317444174451744617447174481744917450174511745217453174541745517456174571745817459174601746117462174631746417465174661746717468174691747017471174721747317474174751747617477174781747917480174811748217483174841748517486174871748817489174901749117492174931749417495174961749717498174991750017501175021750317504175051750617507175081750917510175111751217513175141751517516175171751817519175201752117522175231752417525175261752717528175291753017531175321753317534175351753617537175381753917540175411754217543175441754517546175471754817549175501755117552175531755417555175561755717558175591756017561175621756317564175651756617567175681756917570175711757217573175741757517576175771757817579175801758117582175831758417585175861758717588175891759017591175921759317594175951759617597175981759917600176011760217603176041760517606176071760817609176101761117612176131761417615176161761717618176191762017621176221762317624176251762617627176281762917630176311763217633176341763517636176371763817639176401764117642176431764417645176461764717648176491765017651176521765317654176551765617657176581765917660176611766217663176641766517666176671766817669176701767117672176731767417675176761767717678176791768017681176821768317684176851768617687176881768917690176911769217693176941769517696176971769817699177001770117702177031770417705177061770717708177091771017711177121771317714177151771617717177181771917720177211772217723177241772517726177271772817729177301773117732177331773417735177361773717738177391774017741177421774317744177451774617747177481774917750177511775217753177541775517756177571775817759177601776117762177631776417765177661776717768177691777017771177721777317774177751777617777177781777917780177811778217783177841778517786177871778817789177901779117792177931779417795177961779717798177991780017801178021780317804178051780617807178081780917810178111781217813178141781517816178171781817819178201782117822178231782417825178261782717828178291783017831178321783317834178351783617837178381783917840178411784217843178441784517846178471784817849178501785117852178531785417855178561785717858178591786017861178621786317864178651786617867178681786917870178711787217873178741787517876178771787817879178801788117882178831788417885178861788717888178891789017891178921789317894178951789617897178981789917900179011790217903179041790517906179071790817909179101791117912179131791417915179161791717918179191792017921179221792317924179251792617927179281792917930179311793217933179341793517936179371793817939179401794117942179431794417945179461794717948179491795017951179521795317954179551795617957179581795917960179611796217963179641796517966179671796817969179701797117972179731797417975179761797717978179791798017981179821798317984179851798617987179881798917990179911799217993179941799517996179971799817999180001800118002180031800418005180061800718008180091801018011180121801318014180151801618017180181801918020180211802218023180241802518026180271802818029180301803118032180331803418035180361803718038180391804018041180421804318044180451804618047180481804918050180511805218053180541805518056180571805818059180601806118062180631806418065180661806718068180691807018071180721807318074180751807618077180781807918080180811808218083180841808518086180871808818089180901809118092180931809418095180961809718098180991810018101181021810318104181051810618107181081810918110181111811218113181141811518116181171811818119181201812118122181231812418125181261812718128181291813018131181321813318134181351813618137181381813918140181411814218143181441814518146181471814818149181501815118152181531815418155181561815718158181591816018161181621816318164181651816618167181681816918170181711817218173181741817518176181771817818179181801818118182181831818418185181861818718188181891819018191181921819318194181951819618197181981819918200182011820218203182041820518206182071820818209182101821118212182131821418215182161821718218182191822018221182221822318224182251822618227182281822918230182311823218233182341823518236182371823818239182401824118242182431824418245182461824718248182491825018251182521825318254182551825618257182581825918260182611826218263182641826518266182671826818269182701827118272182731827418275182761827718278182791828018281182821828318284182851828618287182881828918290182911829218293182941829518296182971829818299183001830118302183031830418305183061830718308183091831018311183121831318314183151831618317183181831918320183211832218323183241832518326183271832818329183301833118332183331833418335183361833718338183391834018341183421834318344183451834618347183481834918350183511835218353183541835518356183571835818359183601836118362183631836418365183661836718368183691837018371183721837318374183751837618377183781837918380183811838218383183841838518386183871838818389183901839118392183931839418395183961839718398183991840018401184021840318404184051840618407184081840918410184111841218413184141841518416184171841818419184201842118422184231842418425184261842718428184291843018431184321843318434184351843618437184381843918440184411844218443184441844518446184471844818449184501845118452184531845418455184561845718458184591846018461184621846318464184651846618467184681846918470184711847218473184741847518476184771847818479184801848118482184831848418485184861848718488184891849018491184921849318494184951849618497184981849918500185011850218503185041850518506185071850818509185101851118512185131851418515185161851718518185191852018521185221852318524185251852618527185281852918530185311853218533185341853518536185371853818539185401854118542185431854418545185461854718548185491855018551185521855318554185551855618557185581855918560185611856218563185641856518566185671856818569185701857118572185731857418575185761857718578185791858018581185821858318584185851858618587185881858918590185911859218593185941859518596185971859818599186001860118602186031860418605186061860718608186091861018611186121861318614186151861618617186181861918620186211862218623186241862518626186271862818629186301863118632186331863418635186361863718638186391864018641186421864318644186451864618647186481864918650186511865218653186541865518656186571865818659186601866118662186631866418665186661866718668186691867018671186721867318674186751867618677186781867918680186811868218683186841868518686186871868818689186901869118692186931869418695186961869718698186991870018701187021870318704187051870618707187081870918710187111871218713187141871518716187171871818719187201872118722187231872418725187261872718728187291873018731187321873318734187351873618737187381873918740187411874218743187441874518746187471874818749187501875118752187531875418755187561875718758187591876018761187621876318764187651876618767187681876918770187711877218773187741877518776187771877818779187801878118782187831878418785187861878718788187891879018791187921879318794187951879618797187981879918800188011880218803188041880518806188071880818809188101881118812188131881418815188161881718818188191882018821188221882318824188251882618827188281882918830188311883218833188341883518836188371883818839188401884118842188431884418845188461884718848188491885018851188521885318854188551885618857188581885918860188611886218863188641886518866188671886818869188701887118872188731887418875188761887718878188791888018881188821888318884188851888618887188881888918890188911889218893188941889518896188971889818899189001890118902189031890418905189061890718908189091891018911189121891318914189151891618917189181891918920189211892218923189241892518926189271892818929189301893118932189331893418935189361893718938189391894018941189421894318944189451894618947189481894918950189511895218953189541895518956189571895818959189601896118962189631896418965189661896718968189691897018971189721897318974189751897618977189781897918980189811898218983189841898518986189871898818989189901899118992189931899418995189961899718998189991900019001190021900319004190051900619007190081900919010190111901219013190141901519016190171901819019190201902119022190231902419025190261902719028190291903019031190321903319034190351903619037190381903919040190411904219043190441904519046190471904819049190501905119052190531905419055190561905719058190591906019061190621906319064190651906619067190681906919070190711907219073190741907519076190771907819079190801908119082190831908419085190861908719088190891909019091190921909319094190951909619097190981909919100191011910219103191041910519106191071910819109191101911119112191131911419115191161911719118191191912019121191221912319124191251912619127191281912919130191311913219133191341913519136191371913819139191401914119142191431914419145191461914719148191491915019151191521915319154191551915619157191581915919160191611916219163191641916519166191671916819169191701917119172191731917419175191761917719178191791918019181191821918319184191851918619187191881918919190191911919219193191941919519196191971919819199192001920119202192031920419205192061920719208192091921019211192121921319214192151921619217192181921919220192211922219223192241922519226192271922819229192301923119232192331923419235192361923719238192391924019241192421924319244192451924619247192481924919250192511925219253192541925519256192571925819259192601926119262192631926419265192661926719268192691927019271192721927319274192751927619277192781927919280192811928219283192841928519286192871928819289192901929119292192931929419295192961929719298192991930019301193021930319304193051930619307193081930919310193111931219313193141931519316193171931819319193201932119322193231932419325193261932719328193291933019331193321933319334193351933619337193381933919340193411934219343193441934519346193471934819349193501935119352193531935419355193561935719358193591936019361193621936319364193651936619367193681936919370193711937219373193741937519376193771937819379193801938119382193831938419385193861938719388193891939019391193921939319394193951939619397193981939919400194011940219403194041940519406194071940819409194101941119412194131941419415194161941719418194191942019421194221942319424194251942619427194281942919430194311943219433194341943519436194371943819439194401944119442194431944419445194461944719448194491945019451194521945319454194551945619457194581945919460194611946219463194641946519466194671946819469194701947119472194731947419475194761947719478194791948019481194821948319484194851948619487194881948919490194911949219493194941949519496194971949819499195001950119502195031950419505195061950719508195091951019511195121951319514195151951619517195181951919520195211952219523195241952519526195271952819529195301953119532195331953419535195361953719538195391954019541195421954319544195451954619547195481954919550195511955219553195541955519556195571955819559195601956119562195631956419565195661956719568195691957019571195721957319574195751957619577195781957919580195811958219583195841958519586195871958819589195901959119592195931959419595195961959719598195991960019601196021960319604196051960619607196081960919610196111961219613196141961519616196171961819619196201962119622196231962419625196261962719628196291963019631196321963319634196351963619637196381963919640196411964219643196441964519646196471964819649196501965119652196531965419655196561965719658196591966019661196621966319664196651966619667196681966919670196711967219673196741967519676196771967819679196801968119682196831968419685196861968719688196891969019691196921969319694196951969619697196981969919700197011970219703197041970519706197071970819709197101971119712197131971419715197161971719718197191972019721197221972319724197251972619727197281972919730197311973219733197341973519736197371973819739197401974119742197431974419745197461974719748197491975019751197521975319754197551975619757197581975919760197611976219763197641976519766197671976819769197701977119772197731977419775197761977719778197791978019781197821978319784197851978619787197881978919790197911979219793197941979519796197971979819799198001980119802198031980419805198061980719808198091981019811198121981319814198151981619817198181981919820198211982219823198241982519826198271982819829198301983119832198331983419835198361983719838198391984019841198421984319844198451984619847198481984919850198511985219853198541985519856198571985819859198601986119862198631986419865198661986719868198691987019871198721987319874198751987619877198781987919880198811988219883198841988519886198871988819889198901989119892198931989419895198961989719898198991990019901199021990319904199051990619907199081990919910199111991219913199141991519916199171991819919199201992119922199231992419925199261992719928199291993019931199321993319934199351993619937199381993919940199411994219943199441994519946199471994819949199501995119952199531995419955199561995719958199591996019961199621996319964199651996619967199681996919970199711997219973199741997519976199771997819979199801998119982199831998419985199861998719988199891999019991199921999319994199951999619997199981999920000200012000220003200042000520006200072000820009200102001120012200132001420015200162001720018200192002020021200222002320024200252002620027200282002920030200312003220033200342003520036200372003820039200402004120042200432004420045200462004720048200492005020051200522005320054200552005620057200582005920060200612006220063200642006520066200672006820069200702007120072200732007420075200762007720078200792008020081200822008320084200852008620087200882008920090200912009220093200942009520096200972009820099201002010120102201032010420105201062010720108201092011020111201122011320114201152011620117201182011920120201212012220123201242012520126201272012820129201302013120132201332013420135201362013720138201392014020141201422014320144201452014620147201482014920150201512015220153201542015520156201572015820159201602016120162201632016420165201662016720168201692017020171201722017320174201752017620177201782017920180201812018220183201842018520186201872018820189201902019120192201932019420195201962019720198201992020020201202022020320204202052020620207202082020920210202112021220213202142021520216202172021820219202202022120222202232022420225202262022720228202292023020231202322023320234202352023620237202382023920240202412024220243202442024520246202472024820249202502025120252202532025420255202562025720258202592026020261202622026320264202652026620267202682026920270202712027220273202742027520276202772027820279202802028120282202832028420285202862028720288202892029020291202922029320294202952029620297202982029920300203012030220303203042030520306203072030820309203102031120312203132031420315203162031720318203192032020321203222032320324203252032620327203282032920330203312033220333203342033520336203372033820339203402034120342203432034420345203462034720348203492035020351203522035320354203552035620357203582035920360203612036220363203642036520366203672036820369203702037120372203732037420375203762037720378203792038020381203822038320384203852038620387203882038920390203912039220393203942039520396203972039820399204002040120402204032040420405204062040720408204092041020411204122041320414204152041620417204182041920420204212042220423204242042520426204272042820429204302043120432204332043420435204362043720438204392044020441204422044320444204452044620447204482044920450204512045220453204542045520456204572045820459204602046120462204632046420465204662046720468204692047020471204722047320474204752047620477204782047920480204812048220483204842048520486204872048820489204902049120492204932049420495204962049720498204992050020501205022050320504205052050620507205082050920510205112051220513205142051520516205172051820519205202052120522205232052420525205262052720528205292053020531205322053320534205352053620537205382053920540205412054220543205442054520546205472054820549205502055120552205532055420555205562055720558205592056020561205622056320564205652056620567205682056920570205712057220573205742057520576205772057820579205802058120582205832058420585205862058720588205892059020591205922059320594205952059620597205982059920600206012060220603206042060520606206072060820609206102061120612206132061420615206162061720618206192062020621206222062320624206252062620627206282062920630206312063220633206342063520636206372063820639206402064120642206432064420645206462064720648206492065020651206522065320654206552065620657206582065920660206612066220663206642066520666206672066820669206702067120672206732067420675206762067720678206792068020681206822068320684206852068620687206882068920690206912069220693206942069520696206972069820699207002070120702207032070420705207062070720708207092071020711207122071320714207152071620717207182071920720207212072220723207242072520726207272072820729207302073120732207332073420735207362073720738207392074020741207422074320744207452074620747207482074920750207512075220753207542075520756207572075820759207602076120762207632076420765207662076720768207692077020771207722077320774207752077620777207782077920780207812078220783207842078520786207872078820789207902079120792207932079420795207962079720798207992080020801208022080320804208052080620807208082080920810208112081220813208142081520816208172081820819208202082120822208232082420825208262082720828208292083020831208322083320834208352083620837208382083920840208412084220843208442084520846208472084820849208502085120852208532085420855208562085720858208592086020861208622086320864208652086620867208682086920870208712087220873208742087520876208772087820879208802088120882208832088420885208862088720888208892089020891208922089320894208952089620897208982089920900209012090220903209042090520906209072090820909209102091120912209132091420915209162091720918209192092020921209222092320924209252092620927209282092920930209312093220933209342093520936209372093820939209402094120942209432094420945209462094720948209492095020951209522095320954209552095620957209582095920960209612096220963209642096520966209672096820969209702097120972209732097420975209762097720978209792098020981209822098320984209852098620987209882098920990209912099220993209942099520996209972099820999210002100121002210032100421005210062100721008210092101021011210122101321014210152101621017210182101921020210212102221023210242102521026210272102821029210302103121032210332103421035210362103721038210392104021041210422104321044210452104621047210482104921050210512105221053210542105521056210572105821059210602106121062210632106421065210662106721068210692107021071210722107321074210752107621077210782107921080210812108221083210842108521086210872108821089210902109121092210932109421095210962109721098210992110021101211022110321104211052110621107211082110921110211112111221113211142111521116211172111821119211202112121122211232112421125211262112721128211292113021131211322113321134211352113621137211382113921140211412114221143211442114521146211472114821149211502115121152211532115421155211562115721158211592116021161211622116321164211652116621167211682116921170211712117221173211742117521176211772117821179211802118121182211832118421185211862118721188211892119021191211922119321194211952119621197211982119921200212012120221203212042120521206212072120821209212102121121212212132121421215212162121721218212192122021221212222122321224212252122621227212282122921230212312123221233212342123521236212372123821239212402124121242212432124421245212462124721248212492125021251212522125321254212552125621257212582125921260212612126221263212642126521266212672126821269212702127121272212732127421275212762127721278212792128021281212822128321284212852128621287212882128921290212912129221293212942129521296212972129821299213002130121302213032130421305213062130721308213092131021311213122131321314213152131621317213182131921320213212132221323213242132521326213272132821329213302133121332213332133421335213362133721338213392134021341213422134321344213452134621347213482134921350213512135221353213542135521356213572135821359213602136121362213632136421365213662136721368213692137021371213722137321374213752137621377213782137921380213812138221383213842138521386213872138821389213902139121392213932139421395213962139721398213992140021401214022140321404214052140621407214082140921410214112141221413214142141521416214172141821419214202142121422214232142421425214262142721428214292143021431214322143321434214352143621437214382143921440214412144221443214442144521446214472144821449214502145121452214532145421455214562145721458214592146021461214622146321464214652146621467214682146921470214712147221473214742147521476214772147821479214802148121482214832148421485214862148721488214892149021491214922149321494214952149621497214982149921500215012150221503215042150521506215072150821509215102151121512215132151421515215162151721518215192152021521215222152321524215252152621527215282152921530215312153221533215342153521536215372153821539215402154121542215432154421545215462154721548215492155021551215522155321554215552155621557215582155921560215612156221563215642156521566215672156821569215702157121572215732157421575215762157721578215792158021581215822158321584215852158621587215882158921590215912159221593215942159521596215972159821599216002160121602216032160421605216062160721608216092161021611216122161321614216152161621617216182161921620216212162221623216242162521626216272162821629216302163121632216332163421635216362163721638216392164021641216422164321644216452164621647216482164921650216512165221653216542165521656216572165821659216602166121662216632166421665216662166721668216692167021671216722167321674216752167621677216782167921680216812168221683216842168521686216872168821689216902169121692216932169421695216962169721698216992170021701217022170321704217052170621707217082170921710217112171221713217142171521716217172171821719217202172121722217232172421725217262172721728217292173021731217322173321734217352173621737217382173921740217412174221743217442174521746217472174821749217502175121752217532175421755217562175721758217592176021761217622176321764217652176621767217682176921770217712177221773217742177521776217772177821779217802178121782217832178421785217862178721788217892179021791217922179321794217952179621797217982179921800218012180221803218042180521806218072180821809218102181121812218132181421815218162181721818218192182021821218222182321824218252182621827218282182921830218312183221833218342183521836218372183821839218402184121842218432184421845218462184721848218492185021851218522185321854218552185621857218582185921860218612186221863218642186521866218672186821869218702187121872218732187421875218762187721878218792188021881218822188321884218852188621887218882188921890218912189221893218942189521896218972189821899219002190121902219032190421905219062190721908219092191021911219122191321914219152191621917219182191921920219212192221923219242192521926219272192821929219302193121932219332193421935219362193721938219392194021941219422194321944219452194621947219482194921950219512195221953219542195521956219572195821959219602196121962219632196421965219662196721968219692197021971219722197321974219752197621977219782197921980219812198221983219842198521986219872198821989219902199121992219932199421995219962199721998219992200022001220022200322004220052200622007220082200922010220112201222013220142201522016220172201822019220202202122022220232202422025220262202722028220292203022031220322203322034220352203622037220382203922040220412204222043220442204522046220472204822049220502205122052220532205422055220562205722058220592206022061220622206322064220652206622067220682206922070220712207222073220742207522076220772207822079220802208122082220832208422085220862208722088220892209022091220922209322094220952209622097220982209922100221012210222103221042210522106221072210822109221102211122112221132211422115221162211722118221192212022121221222212322124221252212622127221282212922130221312213222133221342213522136221372213822139221402214122142221432214422145221462214722148221492215022151221522215322154221552215622157221582215922160221612216222163221642216522166221672216822169221702217122172221732217422175221762217722178221792218022181221822218322184221852218622187221882218922190221912219222193221942219522196221972219822199222002220122202222032220422205222062220722208222092221022211222122221322214222152221622217222182221922220222212222222223222242222522226222272222822229222302223122232222332223422235222362223722238222392224022241222422224322244222452224622247222482224922250222512225222253222542225522256222572225822259222602226122262222632226422265222662226722268222692227022271222722227322274222752227622277222782227922280222812228222283222842228522286222872228822289222902229122292222932229422295222962229722298222992230022301223022230322304223052230622307223082230922310223112231222313223142231522316223172231822319223202232122322223232232422325223262232722328223292233022331223322233322334223352233622337223382233922340223412234222343223442234522346223472234822349223502235122352223532235422355223562235722358223592236022361223622236322364223652236622367223682236922370223712237222373223742237522376223772237822379223802238122382223832238422385223862238722388223892239022391223922239322394223952239622397223982239922400224012240222403224042240522406224072240822409224102241122412224132241422415224162241722418224192242022421224222242322424224252242622427224282242922430224312243222433224342243522436224372243822439224402244122442224432244422445224462244722448224492245022451224522245322454224552245622457224582245922460224612246222463224642246522466224672246822469224702247122472224732247422475224762247722478224792248022481224822248322484224852248622487224882248922490224912249222493224942249522496224972249822499225002250122502225032250422505225062250722508225092251022511225122251322514225152251622517225182251922520225212252222523225242252522526225272252822529225302253122532225332253422535225362253722538225392254022541225422254322544225452254622547225482254922550225512255222553225542255522556225572255822559225602256122562225632256422565225662256722568225692257022571225722257322574225752257622577225782257922580225812258222583225842258522586225872258822589225902259122592225932259422595225962259722598225992260022601226022260322604226052260622607226082260922610226112261222613226142261522616226172261822619226202262122622226232262422625226262262722628226292263022631226322263322634226352263622637226382263922640226412264222643226442264522646226472264822649226502265122652226532265422655226562265722658226592266022661226622266322664226652266622667226682266922670226712267222673226742267522676226772267822679226802268122682226832268422685226862268722688226892269022691226922269322694226952269622697226982269922700227012270222703227042270522706227072270822709227102271122712227132271422715227162271722718227192272022721227222272322724227252272622727227282272922730227312273222733227342273522736227372273822739227402274122742227432274422745227462274722748227492275022751227522275322754227552275622757227582275922760227612276222763227642276522766227672276822769227702277122772227732277422775227762277722778227792278022781227822278322784227852278622787227882278922790227912279222793227942279522796227972279822799228002280122802228032280422805228062280722808228092281022811228122281322814228152281622817228182281922820228212282222823228242282522826228272282822829228302283122832228332283422835228362283722838228392284022841228422284322844228452284622847228482284922850228512285222853228542285522856228572285822859228602286122862228632286422865228662286722868228692287022871228722287322874228752287622877228782287922880228812288222883228842288522886228872288822889228902289122892228932289422895228962289722898228992290022901229022290322904229052290622907229082290922910229112291222913229142291522916229172291822919229202292122922229232292422925229262292722928229292293022931229322293322934229352293622937229382293922940229412294222943229442294522946229472294822949229502295122952229532295422955229562295722958229592296022961229622296322964229652296622967229682296922970229712297222973229742297522976229772297822979229802298122982229832298422985229862298722988229892299022991229922299322994229952299622997229982299923000230012300223003230042300523006230072300823009230102301123012230132301423015230162301723018230192302023021230222302323024230252302623027230282302923030230312303223033230342303523036230372303823039230402304123042230432304423045230462304723048230492305023051230522305323054230552305623057230582305923060230612306223063230642306523066230672306823069230702307123072230732307423075230762307723078230792308023081230822308323084230852308623087230882308923090230912309223093230942309523096230972309823099231002310123102231032310423105231062310723108231092311023111231122311323114231152311623117231182311923120231212312223123231242312523126231272312823129231302313123132231332313423135231362313723138231392314023141231422314323144231452314623147231482314923150231512315223153231542315523156231572315823159231602316123162231632316423165231662316723168231692317023171231722317323174231752317623177231782317923180231812318223183231842318523186231872318823189231902319123192231932319423195231962319723198231992320023201232022320323204232052320623207232082320923210232112321223213232142321523216232172321823219232202322123222232232322423225232262322723228232292323023231232322323323234232352323623237232382323923240232412324223243232442324523246232472324823249232502325123252232532325423255232562325723258232592326023261232622326323264232652326623267232682326923270232712327223273232742327523276232772327823279232802328123282232832328423285232862328723288232892329023291232922329323294232952329623297232982329923300233012330223303233042330523306233072330823309233102331123312233132331423315233162331723318233192332023321233222332323324233252332623327233282332923330233312333223333233342333523336233372333823339233402334123342233432334423345233462334723348233492335023351233522335323354233552335623357233582335923360233612336223363233642336523366233672336823369233702337123372233732337423375233762337723378233792338023381233822338323384233852338623387233882338923390233912339223393233942339523396233972339823399234002340123402234032340423405234062340723408234092341023411234122341323414234152341623417234182341923420234212342223423234242342523426234272342823429234302343123432234332343423435234362343723438234392344023441234422344323444234452344623447234482344923450234512345223453234542345523456234572345823459234602346123462234632346423465234662346723468234692347023471234722347323474234752347623477234782347923480234812348223483234842348523486234872348823489234902349123492234932349423495234962349723498234992350023501235022350323504235052350623507235082350923510235112351223513235142351523516235172351823519235202352123522235232352423525235262352723528235292353023531235322353323534235352353623537235382353923540235412354223543235442354523546235472354823549235502355123552235532355423555235562355723558235592356023561235622356323564235652356623567235682356923570235712357223573235742357523576235772357823579235802358123582235832358423585235862358723588235892359023591235922359323594235952359623597235982359923600236012360223603236042360523606236072360823609236102361123612236132361423615236162361723618236192362023621236222362323624236252362623627236282362923630236312363223633236342363523636236372363823639236402364123642236432364423645236462364723648236492365023651236522365323654236552365623657236582365923660236612366223663236642366523666236672366823669236702367123672236732367423675236762367723678236792368023681236822368323684236852368623687236882368923690236912369223693236942369523696236972369823699237002370123702237032370423705237062370723708237092371023711237122371323714237152371623717237182371923720237212372223723237242372523726237272372823729237302373123732237332373423735237362373723738237392374023741237422374323744237452374623747237482374923750237512375223753237542375523756237572375823759237602376123762237632376423765237662376723768237692377023771237722377323774237752377623777237782377923780237812378223783237842378523786237872378823789237902379123792237932379423795237962379723798237992380023801238022380323804238052380623807238082380923810238112381223813238142381523816238172381823819238202382123822238232382423825238262382723828238292383023831238322383323834238352383623837238382383923840238412384223843238442384523846238472384823849238502385123852238532385423855238562385723858238592386023861238622386323864238652386623867238682386923870238712387223873238742387523876238772387823879238802388123882238832388423885238862388723888238892389023891238922389323894238952389623897238982389923900239012390223903239042390523906239072390823909239102391123912239132391423915239162391723918239192392023921239222392323924239252392623927239282392923930239312393223933239342393523936239372393823939239402394123942239432394423945239462394723948239492395023951239522395323954239552395623957239582395923960239612396223963239642396523966239672396823969239702397123972239732397423975239762397723978239792398023981239822398323984239852398623987239882398923990239912399223993239942399523996239972399823999240002400124002240032400424005240062400724008240092401024011240122401324014240152401624017240182401924020240212402224023240242402524026240272402824029240302403124032240332403424035240362403724038240392404024041240422404324044240452404624047240482404924050240512405224053240542405524056240572405824059240602406124062240632406424065240662406724068240692407024071240722407324074240752407624077240782407924080240812408224083240842408524086240872408824089240902409124092240932409424095240962409724098240992410024101241022410324104241052410624107241082410924110241112411224113241142411524116241172411824119241202412124122241232412424125241262412724128241292413024131241322413324134241352413624137241382413924140241412414224143241442414524146241472414824149241502415124152241532415424155241562415724158241592416024161241622416324164241652416624167241682416924170241712417224173241742417524176241772417824179241802418124182241832418424185241862418724188241892419024191241922419324194241952419624197241982419924200242012420224203242042420524206242072420824209242102421124212242132421424215242162421724218242192422024221242222422324224242252422624227242282422924230242312423224233242342423524236242372423824239242402424124242242432424424245242462424724248242492425024251242522425324254242552425624257242582425924260242612426224263242642426524266242672426824269242702427124272242732427424275242762427724278242792428024281242822428324284242852428624287242882428924290242912429224293242942429524296242972429824299243002430124302243032430424305243062430724308243092431024311243122431324314243152431624317243182431924320243212432224323243242432524326243272432824329243302433124332243332433424335243362433724338243392434024341243422434324344243452434624347243482434924350243512435224353243542435524356243572435824359243602436124362243632436424365243662436724368243692437024371243722437324374243752437624377243782437924380243812438224383243842438524386243872438824389243902439124392243932439424395243962439724398243992440024401244022440324404244052440624407244082440924410244112441224413244142441524416244172441824419244202442124422244232442424425244262442724428244292443024431244322443324434244352443624437244382443924440244412444224443244442444524446244472444824449244502445124452244532445424455244562445724458244592446024461244622446324464244652446624467244682446924470244712447224473244742447524476244772447824479244802448124482244832448424485244862448724488244892449024491244922449324494244952449624497244982449924500245012450224503245042450524506245072450824509245102451124512245132451424515245162451724518245192452024521245222452324524245252452624527245282452924530245312453224533245342453524536245372453824539245402454124542245432454424545245462454724548245492455024551245522455324554245552455624557245582455924560245612456224563245642456524566245672456824569245702457124572245732457424575245762457724578245792458024581245822458324584245852458624587245882458924590245912459224593245942459524596245972459824599246002460124602246032460424605246062460724608246092461024611246122461324614246152461624617246182461924620246212462224623246242462524626246272462824629246302463124632246332463424635246362463724638246392464024641246422464324644246452464624647246482464924650246512465224653246542465524656246572465824659246602466124662246632466424665246662466724668246692467024671246722467324674246752467624677246782467924680246812468224683246842468524686246872468824689246902469124692246932469424695246962469724698246992470024701247022470324704247052470624707247082470924710247112471224713247142471524716247172471824719247202472124722247232472424725247262472724728247292473024731247322473324734247352473624737247382473924740247412474224743247442474524746247472474824749247502475124752247532475424755247562475724758247592476024761247622476324764247652476624767247682476924770247712477224773247742477524776247772477824779247802478124782247832478424785247862478724788247892479024791247922479324794247952479624797247982479924800248012480224803248042480524806248072480824809248102481124812248132481424815248162481724818248192482024821248222482324824248252482624827248282482924830248312483224833248342483524836248372483824839248402484124842248432484424845248462484724848248492485024851248522485324854248552485624857248582485924860248612486224863248642486524866248672486824869248702487124872248732487424875248762487724878248792488024881248822488324884248852488624887248882488924890248912489224893248942489524896248972489824899249002490124902249032490424905249062490724908249092491024911249122491324914249152491624917249182491924920249212492224923249242492524926249272492824929249302493124932249332493424935249362493724938249392494024941249422494324944249452494624947249482494924950249512495224953249542495524956249572495824959249602496124962249632496424965249662496724968249692497024971249722497324974249752497624977249782497924980249812498224983249842498524986249872498824989249902499124992249932499424995249962499724998249992500025001250022500325004250052500625007250082500925010250112501225013250142501525016250172501825019250202502125022250232502425025250262502725028250292503025031250322503325034250352503625037250382503925040250412504225043250442504525046250472504825049250502505125052250532505425055250562505725058250592506025061250622506325064250652506625067250682506925070250712507225073250742507525076250772507825079250802508125082250832508425085250862508725088250892509025091250922509325094250952509625097250982509925100251012510225103251042510525106251072510825109251102511125112251132511425115251162511725118251192512025121251222512325124251252512625127251282512925130251312513225133251342513525136251372513825139251402514125142251432514425145251462514725148251492515025151251522515325154251552515625157251582515925160251612516225163251642516525166251672516825169251702517125172251732517425175251762517725178251792518025181251822518325184251852518625187251882518925190251912519225193251942519525196251972519825199252002520125202252032520425205252062520725208252092521025211252122521325214252152521625217252182521925220252212522225223252242522525226252272522825229252302523125232252332523425235252362523725238252392524025241252422524325244252452524625247252482524925250252512525225253252542525525256252572525825259252602526125262252632526425265252662526725268252692527025271252722527325274252752527625277252782527925280252812528225283252842528525286252872528825289252902529125292252932529425295252962529725298252992530025301253022530325304253052530625307253082530925310253112531225313253142531525316253172531825319253202532125322253232532425325253262532725328253292533025331253322533325334253352533625337253382533925340253412534225343253442534525346253472534825349253502535125352253532535425355253562535725358253592536025361253622536325364253652536625367253682536925370253712537225373253742537525376253772537825379253802538125382253832538425385253862538725388253892539025391253922539325394253952539625397253982539925400254012540225403254042540525406254072540825409254102541125412254132541425415254162541725418254192542025421254222542325424254252542625427254282542925430254312543225433254342543525436254372543825439254402544125442254432544425445254462544725448254492545025451254522545325454254552545625457254582545925460254612546225463254642546525466254672546825469254702547125472254732547425475254762547725478254792548025481254822548325484254852548625487254882548925490254912549225493254942549525496254972549825499255002550125502255032550425505255062550725508255092551025511255122551325514255152551625517255182551925520255212552225523255242552525526255272552825529255302553125532255332553425535255362553725538255392554025541255422554325544255452554625547255482554925550255512555225553255542555525556255572555825559255602556125562255632556425565255662556725568255692557025571255722557325574255752557625577255782557925580255812558225583255842558525586255872558825589255902559125592255932559425595255962559725598255992560025601256022560325604256052560625607256082560925610256112561225613256142561525616256172561825619256202562125622256232562425625256262562725628256292563025631256322563325634256352563625637256382563925640256412564225643256442564525646256472564825649256502565125652256532565425655256562565725658256592566025661256622566325664256652566625667256682566925670256712567225673256742567525676256772567825679256802568125682256832568425685256862568725688256892569025691256922569325694256952569625697256982569925700257012570225703257042570525706257072570825709257102571125712257132571425715257162571725718257192572025721257222572325724257252572625727257282572925730257312573225733257342573525736257372573825739257402574125742257432574425745257462574725748257492575025751257522575325754257552575625757257582575925760257612576225763257642576525766257672576825769257702577125772257732577425775257762577725778257792578025781257822578325784257852578625787257882578925790257912579225793257942579525796257972579825799258002580125802258032580425805258062580725808258092581025811258122581325814258152581625817258182581925820258212582225823258242582525826258272582825829258302583125832258332583425835258362583725838258392584025841258422584325844258452584625847258482584925850258512585225853258542585525856258572585825859258602586125862258632586425865258662586725868258692587025871258722587325874258752587625877258782587925880258812588225883258842588525886258872588825889258902589125892258932589425895258962589725898258992590025901259022590325904259052590625907259082590925910259112591225913259142591525916259172591825919259202592125922259232592425925259262592725928259292593025931259322593325934259352593625937259382593925940259412594225943259442594525946259472594825949259502595125952259532595425955259562595725958259592596025961259622596325964259652596625967259682596925970259712597225973259742597525976259772597825979259802598125982259832598425985259862598725988259892599025991259922599325994259952599625997259982599926000260012600226003260042600526006260072600826009260102601126012260132601426015260162601726018260192602026021
  1. 2014-04-14 Asterisk Development Team <asteriskteam@digium.com>
  2. * Asterisk 12.2.0-rc2 Released.
  3. * autoservice: fix reference leak of logger callid.
  4. autoservice acquires a local reference to the logger callid of each
  5. channel in a loop. This local reference was not released, causing the
  6. callid of every channel in autoservice to leak. This change moves the
  7. callid unref inside the loop.
  8. ASTERISK-23616 #close
  9. Reported by: ibercom
  10. * res_hep_pjsip: Use the channel name instead of the call ID when it is
  11. available
  12. During discussions with Alexandr Dubovikov at Kamailio World, it
  13. became apparent that while the SIP call ID is a useful identifier
  14. prior to an Asterisk channel being created, it is far more preferable
  15. to use the channel name (or some channel based identifier) when the
  16. channel is available. Homer is smart enough to tie the various
  17. messages together. This patch opts to use the channel name when it
  18. is available, falling back to the call ID otherwise.
  19. * res_pjsip_pubsub: Set the body generation result to 0 for a valid
  20. path
  21. The result of the "ast_sip_pubsub_generate_body_content" was not
  22. set/initialized. Consequently, the nominal path potentially returned
  23. an invalid value, thus not sending mwi notifications.
  24. * Stasis: Fix Stasis() bridge refcount issue
  25. The Stasis() dialplan application monitors what bridge a channel is
  26. in and so necessarily holds on to a bridge pointer. This change
  27. ensures that it also holds on to a reference for that bridge to
  28. prevent the bridge pointer from becoming a dangling pointer.
  29. * http: Fix spurious ERROR message in responses with no content
  30. When a response has a content length of 0, fwrite would be called
  31. to write a buffer with no data in it. This resulted in the following
  32. classic error message:
  33. [Apr 3 11:49:17] ERROR[26421] http.c: fwrite() failed: Success
  34. This patch makes it so that we only attempt to write out the content
  35. if the calculated content_length is non-zero.
  36. * res_hep: Fix crash when hep.conf not available
  37. Parts of res_hep properly checked for a valid configuration object
  38. before attempting to access the configuration. A check, however,
  39. was missed when a packet is sent. This patch fixes the crash caused
  40. by not checking if the configuration object is valid.
  41. 2014-03-28 Asterisk Development Team <asteriskteam@digium.com>
  42. * Asterisk 12.2.0-rc1 Released.
  43. 2014-03-28 18:09 +0000 [r411534] Matthew Jordan <mjordan@digium.com>
  44. * include/asterisk/res_hep.h (added), res/res_hep_pjsip.c (added),
  45. res/res_hep.exports.in (added), CHANGES, configs/hep.conf.sample
  46. (added), res/res_hep.c (added): res_hep/res_hep_pjsip: Add a
  47. HEPv3 capture agent module and a logger for PJSIP This patch adds
  48. the following: (1) A new module, res_hep, which implements a
  49. generic packet capture agent for the Homer Encapsulation Protocol
  50. (HEP) version 3. Note that this code is based on a patch provided
  51. by Alexandr Dubovikov; I basically just wrapped it up, added
  52. configuration via the configuration framework, and threw in a
  53. taskprocessor. (2) A new module, res_hep_pjsip, which forwards
  54. all SIP message traffic that passes through the res_pjsip stack
  55. over to res_hep for encapsulation and transmission to a HEPv3
  56. capture server. Much thanks to Alexandr for his Asterisk patch
  57. for this code and for a *lot* of patience waiting for me to port
  58. it to 12/trunk. Due to some dithering on my part, this has taken
  59. the better part of a year to port forward (I still blame CDRs for
  60. the delay). ASTERISK-23557 #close Review:
  61. https://reviewboard.asterisk.org/r/3207/
  62. 2014-03-28 17:52 +0000 [r411532] Alexandr Anikin <may@telecom-service.ru>
  63. * addons/ooh323c/src/oochannels.c,
  64. addons/ooh323c/src/ooCmdChannel.c, addons/ooh323c/src/ooq931.c,
  65. addons/ooh323c/src/ooh323.c, addons/ooh323c/src/ooGkClient.c,
  66. addons/chan_ooh323.c, /: process stack command even if gatekeeper
  67. client isn't register don't destroy gatekeeper client if it is
  68. not started don't destroy gatekeeper client in some sort of
  69. gatekeeper errors signal rtp create condition when call cleared
  70. before rtp structure created (closes issue ASTERISK-23460)
  71. Reported by: Dmitry Melekhov Patches: ASTERISK-23460-2.patch
  72. Tested by: Dmitry Melekhov ........ Merged revisions 411531 from
  73. http://svn.asterisk.org/svn/asterisk/branches/11
  74. 2014-03-28 17:35 +0000 [r411529] Matthew Jordan <mjordan@digium.com>
  75. * rest-api/api-docs/applications.json,
  76. rest-api/api-docs/playbacks.json, UPGRADE.txt,
  77. rest-api/api-docs/channels.json, rest-api/api-docs/sounds.json,
  78. rest-api/resources.json, CHANGES, include/asterisk/manager.h,
  79. rest-api/api-docs/bridges.json,
  80. rest-api/api-docs/recordings.json,
  81. rest-api/api-docs/deviceStates.json,
  82. rest-api/api-docs/endpoints.json,
  83. rest-api/api-docs/mailboxes.json, rest-api/api-docs/events.json,
  84. rest-api/api-docs/asterisk.json: Update API versions and
  85. UPGRADE/CHANGES for 12.2.0 This patch does the following: * It
  86. updates the AMI version to 2.2.0 to indicate backwards compatible
  87. changes have been made since the last release * It updates the
  88. ARI version to 1.2.0 to indicate backwards compatible changes
  89. have been made since the last release * It updates the
  90. UPGRADE/CHANGES files with changes that were not mentioned
  91. 2014-03-28 17:08 +0000 [r411514] Mark Michelson <mmichelson@digium.com>
  92. * contrib/ast-db-manage/config/versions/3855ee4e5f85_add_missing_pjsip_options.py
  93. (added): Add alembic script that adds contact user_agent and
  94. endpoint message_context.
  95. 2014-03-28 16:48 +0000 [r411512] Matthew Jordan <mjordan@digium.com>
  96. * /, res/res_odbc.exports.in, UPGRADE.txt, res/res_odbc.c,
  97. configs/res_odbc.conf.sample, include/asterisk/res_odbc.h,
  98. res/res_config_odbc.c: res_config_odbc/res_odbc: Fix handling of
  99. non-text columns updates with empty values. This patch fixes
  100. setting nullable integer columns to NULL instead of an empty
  101. string, which fails for PostgreSQL, for example. The current code
  102. is supposed to do so, but the check is broken. The patch also
  103. allows the first column in the list to be a nullable integer.
  104. This patch also adds a compatibility setting in res_odbc.conf,
  105. allow_empty_string_in_nontext. It is enabled by default. It
  106. should be disabled for database backends (such as PostgreSQL)
  107. that require NULL instead of an empty string for Integer columns.
  108. Review: https://reviewboard.asterisk.org/r/3375 (issue
  109. ASTERISK-23459) Reported by: zvision patches:
  110. res_config_odbc.diff uploaded by zvision (License 5755) ........
  111. Merged revisions 411399 from
  112. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  113. revisions 411408 from
  114. http://svn.asterisk.org/svn/asterisk/branches/11
  115. 2014-03-28 16:17 +0000 [r411465] Scott Griepentrog <sgriepentrog@digium.com>
  116. * main/tcptls.c, main/manager.c, /, main/http.c: http: response
  117. body often missing after specific request This patch works around
  118. a problem with the HTTP body being dropped from the response to a
  119. specific client and under specific circumstances: a) Client
  120. request comes from node.js user agent "Shred" via use of
  121. swagger-client library. b) Asterisk and Client are *not* on the
  122. same host or TCP/IP stack In testing this problem, it has been
  123. determined that the write of the HTTP body is lost, even if the
  124. data is written using low level write function. The only solution
  125. found is to instruct the TCP stack with the shutdown function to
  126. flush the last write and finish the transmission. See review for
  127. more details. ASTERISK-23548 #close (closes issue ASTERISK-23548)
  128. Reported by: Sam Galarneau Review:
  129. https://reviewboard.asterisk.org/r/3402/ ........ Merged
  130. revisions 411462 from
  131. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  132. revisions 411463 from
  133. http://svn.asterisk.org/svn/asterisk/branches/11
  134. 2014-03-28 16:00 +0000 [r411374-411461] Matthew Jordan <mjordan@digium.com>
  135. * /: Remove block on 411408
  136. * /, UPGRADE.txt: UPGRADE: Note IAX2 compatibility issue between
  137. 1.4 and 1.8+ systems. ........ Merged revisions 411457 from
  138. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  139. revisions 411458 from
  140. http://svn.asterisk.org/svn/asterisk/branches/11
  141. * contrib/realtime/mysql/voicemail_messages.sql (removed),
  142. contrib/realtime/postgresql/realtime.sql (removed),
  143. contrib/realtime/mysql/voicemail_data.sql (removed),
  144. contrib/realtime/mysql/musiconhold.sql (removed),
  145. contrib/realtime/mysql/queue_log.sql (removed),
  146. contrib/realtime/mysql/voicemail.sql (removed),
  147. contrib/realtime/mysql/sippeers.sql (removed),
  148. contrib/realtime/mysql/iaxfriends.sql (removed),
  149. contrib/realtime/mysql/meetme.sql (removed): contrib/realtime:
  150. Remove empty SQL script files Since the relatime scripts are now
  151. managed by Alembic, the previous realtime scripts were previously
  152. removed. However, the removal process messed up, as the files
  153. were still in the repository. The contents were just empty. This
  154. removes the files from the tree.
  155. * channels/sip/include/sip.h, /: chan_sip: Add MESSAGE request to
  156. allowed methods The allowed methods advertised by chan_sip did
  157. not previously note the MESSAGE request. Even in Asterisk 1.8, we
  158. do accept in-dialog MESSAGE requests; we should advertise that we
  159. support MESSAGE requests. ASTERISK-23504 #close ASTERISK-23504
  160. #comment Reported by: Martin Kontsek ASTERISK-23504 #comment
  161. Patch sip.h_patch.diff uploaded by Martin Kontsek (license 6587)
  162. Review: https://reviewboard.asterisk.org/r/3396/ ........ Merged
  163. revisions 411372 from
  164. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  165. revisions 411373 from
  166. http://svn.asterisk.org/svn/asterisk/branches/11
  167. 2014-03-27 19:15 +0000 [r411311-411315] Corey Farrell <git@cfware.com>
  168. * main/message.c, apps/app_jack.c, funcs/func_dialplan.c,
  169. channels/chan_sip.c, funcs/func_math.c,
  170. funcs/func_jitterbuffer.c, res/res_mutestream.c,
  171. funcs/func_global.c, apps/app_speech_utils.c,
  172. res/res_pjsip_header_funcs.c, funcs/func_callcompletion.c,
  173. funcs/func_blacklist.c, funcs/func_cdr.c, funcs/func_channel.c,
  174. apps/app_stack.c, funcs/func_callerid.c, res/res_calendar.c,
  175. apps/app_voicemail.c, funcs/func_speex.c, /,
  176. funcs/func_strings.c, res/res_xmpp.c, res/res_jabber.c,
  177. main/features_config.c, channels/chan_iax2.c,
  178. apps/confbridge/conf_config_parser.c,
  179. channels/pjsip/dialplan_functions.c, funcs/func_groupcount.c,
  180. funcs/func_pitchshift.c, funcs/func_odbc.c, funcs/func_volume.c,
  181. funcs/func_frame_trace.c: Fix dialplan function NULL channel
  182. safety issues (closes issue ASTERISK-23391) Reported by: Corey
  183. Farrell Review: https://reviewboard.asterisk.org/r/3386/ ........
  184. Merged revisions 411313 from
  185. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  186. revisions 411314 from
  187. http://svn.asterisk.org/svn/asterisk/branches/11
  188. * include/asterisk.h, /, main/format.c: main/formats: Fix crash in
  189. ast_format_cmp during non-clean shutdown. * Update asterisk.h to
  190. reflect availability of ast_register_cleanup in 11.9. * Use
  191. ast_register_cleanup for format_attr_shutdown. (closes issue
  192. ASTERISK-23103) Reported by: JoshE ........ Merged revisions
  193. 411310 from http://svn.asterisk.org/svn/asterisk/branches/11
  194. 2014-03-27 14:20 +0000 [r411295] Mark Michelson <mmichelson@digium.com>
  195. * main/sorcery.c: Give sorcery instances a reference to their
  196. wizards. On graceful shutdown, sorcery wizards are all killed
  197. off, but it is possible for sorcery instances to still have
  198. dangling pointers after this, possibly causing a crash. Giving
  199. the sorcery instances a reference to their wizards ensures that
  200. the wizard reference will remain valid for the lifetime of the
  201. sorcery instance. Review: https://reviewboard.asterisk.org/r/3401
  202. 2014-03-26 22:44 +0000 [r411245] Joshua Colp <jcolp@digium.com>
  203. * /, main/say.c: say: Fix a bug where SayNumber in Polish tries to
  204. play incorrect sound. This change fixes a bug where calling
  205. SayNumber with a number divisible by 100 using the Polish
  206. language would cause the code to attempt to play a sound file
  207. with an empty name. (closes issue ASTERISK-23509) Reported by:
  208. zvision Review: https://reviewboard.asterisk.org/r/3378/ ........
  209. Merged revisions 411243 from
  210. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  211. revisions 411244 from
  212. http://svn.asterisk.org/svn/asterisk/branches/11
  213. 2014-03-26 16:07 +0000 [r411193] Jonathan Rose <jrose@digium.com>
  214. * configs/sip.conf.sample, /, channels/chan_sip.c: chan_sip: Send
  215. real CallerID information with P-Assserted-Identity (RFC-3325)
  216. Prior too this patch, the P-Asserted-Identity header would
  217. include anonymous caller id information which seems to go against
  218. the point of the P-Asserted-Identity header. Now the real caller
  219. ID information will be included in this header. Also, no privacy
  220. header would be included. This patch adds 'Privacy: id' to
  221. outgoing SIP messages that include the P-Asserted-Identity
  222. header. (closes issue AST-1301) ........ Merged revisions 411189
  223. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  224. Merged revisions 411190 from
  225. http://svn.asterisk.org/svn/asterisk/branches/11
  226. 2014-03-26 16:03 +0000 [r411191] Richard Mudgett <rmudgett@digium.com>
  227. * contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py:
  228. Fix 'alembic branches' merge conflict as described by the web
  229. page.
  230. 2014-03-25 18:43 +0000 [r411173] Sean Bright <sean@malleable.com>
  231. * res/ari/config.c: ARI: Don't complain about missing ARI users
  232. when we aren't enabled Currently, if ARI is not enabled it will
  233. still complain that there are no configured users. This patch
  234. checks to see if ARI is enabled before logging and error or
  235. iterating the container to validate the users. Review:
  236. https://reviewboard.asterisk.org/r/3391/
  237. 2014-03-25 17:52 +0000 [r411157-411159] Mark Michelson <mmichelson@digium.com>
  238. * tests/test_sorcery.c, tests/test_sorcery_realtime.c,
  239. main/sorcery.c, res/res_mwi_external.c,
  240. res/res_pjsip/config_system.c, configs/sorcery.conf.sample,
  241. main/bucket.c, include/asterisk/sorcery.h,
  242. res/res_pjsip/pjsip_configuration.c, tests/test_sorcery_astdb.c:
  243. Prevent duplicate sorcery wizards from being applied to sorcery
  244. object types. This commit contains several changes to sorcery: 1)
  245. Application of sorcery configuration based on module name is
  246. automatically performed when sorcery is opened for a module. 2)
  247. Sorcery will not attempt to apply the same wizard to an object
  248. type more than once. 3) Sorcery gives more exact results when
  249. attempting to apply a wizard, whether as the default or based on
  250. configuration. Sorcery unit tests still pass for me after making
  251. these changes. Review: https://reviewboard.asterisk.org/r/3326
  252. * res/res_pjsip/pjsip_configuration.c, UPGRADE.txt,
  253. res/res_pjsip_messaging.c, res/res_pjsip.c,
  254. include/asterisk/res_pjsip.h: Add a "message_context" option for
  255. PJSIP endpoints.
  256. 2014-03-25 16:55 +0000 [r411141] Richard Mudgett <rmudgett@digium.com>
  257. * include/asterisk/res_pjsip.h, res/res_pjsip/pjsip_options.c,
  258. res/res_pjsip.c: res_pjsip: Fix contact authenticate_qualify
  259. endpoint lookup when qualifing a contact. * Fixed bad use of
  260. ao2_find() in on_endpoint(). * Replaced use of find_endpoints()
  261. with find_an_endpoint() since only the first found endpoint is
  262. ever needed. * Fixed qualify_contact_cb() to update the contact
  263. with the aor authenticate_qualify setting. Otherwise, permanent
  264. contacts in the aor type sections would have a config line order
  265. dependancy. * Fixed off nominal path contact ref leak in
  266. qualify_contact(). The comment saying the unref is not needed was
  267. wrong. * Fixed off nominal path use of the endpoint parameter if
  268. it is NULL in send_out_of_dialog_request(). * Added missing off
  269. nominal path unref of pjsip tdata in
  270. send_out_of_dialog_request(). * Fixed off nominal path failing to
  271. call the callback in send_request_cb() when the request is
  272. challenged for authentication. * Eliminated silly RAII_VAR() use
  273. in qualify_contact_cb(). * Updated ast_sip_send_request() doxygen
  274. to better reflect reality. (closes issue ASTERISK-23254) Reported
  275. by: rmudgett Review: https://reviewboard.asterisk.org/r/3381/
  276. 2014-03-25 16:04 +0000 [r411091] Kinsey Moore <kmoore@digium.com>
  277. * /, channels/chan_sip.c: chan_sip: Fix incorrect use of timers If
  278. update_provisional_keepalive() is called while
  279. send_provisional_keepalive_full() is waiting on the PVT lock,
  280. then pvt->provisional_keepalive_sched_id will be changed to a new
  281. sched_id value by update_provisional_keepalive(), but that new
  282. sched_id then may be overwritten with -1 by
  283. send_provisional_keepalive_full(), killing the pvt's reference to
  284. a schedule and "leaking" the reference. (closes issue
  285. ASTERISK-22079) Review: https://reviewboard.asterisk.org/r/3368/
  286. Reported by: Jamuel Starkey, Matteo, Leif Madsen, Steve Davies
  287. Patches: provisional_keepalive_fix.diff uploaded by Steve Davies
  288. (license 5012) ........ Merged revisions 411088 from
  289. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  290. revisions 411089 from
  291. http://svn.asterisk.org/svn/asterisk/branches/11
  292. 2014-03-25 15:44 +0000 [r411086] Jonathan Rose <jrose@digium.com>
  293. * res/res_stasis.c: ARI: Resolve a subscription leak against
  294. implicit bridge subscriptions When a channel in a stasis
  295. application is joined to a bridge, a subscription for that bridge
  296. is created implicitly for the stasis application serving the
  297. channel. Prior to this patch, subsequent removals of the channel
  298. from the bridge would leave the subscription open. Review:
  299. https://reviewboard.asterisk.org/r/3380/
  300. 2014-03-24 21:38 +0000 [r411023] Joshua Colp <jcolp@digium.com>
  301. * /, channels/chan_sip.c: chan_sip: Always use fromdomain if set
  302. for domain, even if callerid is set to restricted. (closes issue
  303. ASTERISK-20841) Reported by: Kelly Goedert ........ Merged
  304. revisions 411021 from
  305. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  306. revisions 411022 from
  307. http://svn.asterisk.org/svn/asterisk/branches/11
  308. 2014-03-21 16:01 +0000 [r410995] Richard Mudgett <rmudgett@digium.com>
  309. * res/res_pjsip_registrar.c: res_pjsip_registrar.c: Miscellaneous
  310. cleanup in rx_task(). * Fix variable shadowing of 'updated' by
  311. renaming it to 'contact_update'. * Checked 'contact_update' for
  312. ast_sorcery_copy() failure. * Removed silly use of RAII_VAR() for
  313. 'contact_update'.
  314. 2014-03-20 22:54 +0000 [r410966] Jonathan Rose <jrose@digium.com>
  315. * /, apps/app_confbridge.c: app_confbridge: Fix bug - users with
  316. startmuted set don't start muted (closes issue ASTERISK-23461)
  317. Reported by: Chico Manobela Review:
  318. https://reviewboard.asterisk.org/r/3373/ ........ Merged
  319. revisions 410965 from
  320. http://svn.asterisk.org/svn/asterisk/branches/11
  321. 2014-03-20 16:27 +0000 [r410949] Richard Mudgett <rmudgett@digium.com>
  322. * include/asterisk/channel.h, res/ari/resource_channels.c,
  323. res/res_stasis_snoop.c, include/asterisk/rtp_engine.h,
  324. main/dial.c, main/manager.c, main/channel_internal_api.c,
  325. main/core_unreal.c: assigned-uniqueids: Miscellaneous cleanup and
  326. fixes. * Fix memory leak in ast_unreal_new_channels(). Made it
  327. generate the ;2 uniqueid on a stack variable instead of mallocing
  328. it. * Made send error response to ARI and AMI requests instead of
  329. just logging excessive uniqueid length and allowing truncation.
  330. action_originate() and ari_channels_handle_originate_with_id(). *
  331. Fixed minor truncating uniqueid hole when generating the ;2
  332. uniqueid string length. Created public and internal lengths of
  333. uniqueid. The internal length can handle a max public uniqueid
  334. plus an appended ;2. * free() and ast_free() are NULL tolerant so
  335. they don't need a NULL test before calling. * Made use better
  336. struct initialization format instead of the position dependent
  337. initialization format. Also anything not explicitly initialized
  338. in the struct is initialized to zero by the compiler. * Made
  339. ast_channel_internal_set_fake_ids() use the safer
  340. ast_copy_string() instead of strncpy(). Review:
  341. https://reviewboard.asterisk.org/r/3371/
  342. 2014-03-19 17:26 +0000 [r410933] Mark Michelson <mmichelson@digium.com>
  343. * res/res_pjsip_endpoint_identifier_ip.c: PJSIP: Allow for identify
  344. sections to be specified in sorcery.conf. "identify" is a special
  345. type of configuration object in PJSIP because unlike the other
  346. objects, it is not provided by the base res_pjsip module.
  347. Instead, it is provided by the res_pjsip_endpoint_identifier_ip
  348. module. If using the default sorcery wizard
  349. (config,criteria=type=identify) then things work because the
  350. module that applies the default wizard is the correct module.
  351. However, if attempting to use sorcery.conf to apply an alternate
  352. wizard, it was not possible. If you attempted to specify the
  353. identify object type in the res_pjsip section, then the object
  354. could not be registered since the object was undocumented for the
  355. res_pjsip module. There was no alternate configuration section
  356. defined for it, so you were out of luck if you wanted to override
  357. the default wizard. With this change, the identify section will
  358. properly have a sorcery.conf-based wizard applied when the
  359. identify definition is within the
  360. res_pjsip_endpoint_identifier_ip section.
  361. 2014-03-19 14:24 +0000 [r410904-410918] Joshua Colp <jcolp@digium.com>
  362. * res/res_stasis.c: res_stasis: Fix a bug where the default bridge
  363. type was not set.
  364. * CHANGES, res/res_stasis.c, rest-api/api-docs/bridges.json,
  365. res/ari/resource_bridges.h: res_stasis: Extend bridge type to be
  366. a comma separated list of bridge attributes. This change turns
  367. the bridge type field into a comma separated list of attributes.
  368. These attributes include: mixing, holding, dtmf_events, and
  369. proxy_media. By setting the various attributes a user can control
  370. the type of bridge created with the behavior they need for their
  371. application. (closes issue ASTERISK-23437) Reported by: Matt
  372. Jordan Review: https://reviewboard.asterisk.org/r/3359/
  373. 2014-03-19 02:29 +0000 [r410890] Matthew Jordan <mjordan@digium.com>
  374. * res/res_ari.c: res_ari: Fix documentation schema error
  375. 2014-03-18 23:31 +0000 [r410876] Rusty Newton <rnewton@digium.com>
  376. * res/res_ari.c: res_ari: Add notes about Asterisk HTTP server to
  377. the "enabled" config option for the res_ari general section Added
  378. note and see-also reminding user to enable the HTTP server.
  379. (closes issue ASTERISK-22499) Reported by: Rusty Newton
  380. 2014-03-18 15:28 +0000 [r410861] Matthew Jordan <mjordan@digium.com>
  381. * main/cdr.c: cdr: Add asserts for when we don't know about a CDR
  382. for a channel In the CDR core, every channel should either be
  383. filtered out (due to being an 'internal' channel used as an
  384. implementation detail, such as playing media back into a bridge)
  385. or it should get a CDR. Even if that CDR ends up being discarded,
  386. we still give the channel a CDR in case we end up needing it. If
  387. we hit a situation where a channel does not have a CDR, we should
  388. blow up in -dev-mode. Asserts are appropriate for that. This
  389. patch adds those asserts, as they would have quickly caught the
  390. error fixed by r410814.
  391. 2014-03-18 14:51 +0000 [r410858] Scott Griepentrog <sgriepentrog@digium.com>
  392. * main/http.c: ARI: allow json content type with zero length body
  393. When a request was received with a Content-type of json, the body
  394. was sent for json parsing - even if it was zero length. This
  395. resulted in ARI requests failing that were valid, such as a
  396. channel DELETE with no parameters. The code has now been changed
  397. to skip json parsing with zero content length. (closes issue
  398. SWP-6748) Reported by: Samuel Galarneau Review:
  399. https://reviewboard.asterisk.org/r/3360/
  400. 2014-03-18 12:45 +0000 [r410844] Joshua Colp <jcolp@digium.com>
  401. * res/res_pjsip/config_system.c: res_pjsip: Fix memory leak of
  402. nameservers in off-nominal resolver creation failure. Thanks
  403. Walter Doekes!
  404. 2014-03-18 11:51 +0000 [r410830] Sean Bright <sean@malleable.com>
  405. * res/res_fax_spandsp.c, /: res_fax_spandsp: Use g711_free() when
  406. available. Per Johann Steinwendtner on the asterisk-dev mailing
  407. list:
  408. http://lists.digium.com/pipermail/asterisk-dev/2014-March/066102.html
  409. g711_free() was introduced in spandsp 0.0.6pre4 and
  410. g711_release() became a noop. I opted not to remove the call to
  411. g711_release() since it is harmless and to call g711_free() if we
  412. have a sufficiently recent version of spandsp. (issue
  413. ASTERISK-20149) Reported by: Alexandr Gordeev ........ Merged
  414. revisions 410829 from
  415. http://svn.asterisk.org/svn/asterisk/branches/11
  416. 2014-03-18 02:02 +0000 [r410813] Richard Mudgett <rmudgett@digium.com>
  417. * main/stasis_cache.c: stasis_cache: Use the right variable in the
  418. cache entry ao2 cmp function.
  419. 2014-03-17 22:53 +0000 [r410793-410795] Joshua Colp <jcolp@digium.com>
  420. * CHANGES, res/res_pjsip/include/res_pjsip_private.h,
  421. res/res_pjsip.c, main/dns.c, res/res_pjsip/config_system.c,
  422. include/asterisk/dns.h: res_pjsip: Enable PJSIP DNS client
  423. support. This change enables DNS client support within PJSIP.
  424. System nameservers are automatically discovered using res_init or
  425. res_ninit. If this fails then PJSIP will resort to using
  426. gethostbyname for resolution. By enabling this support we gain
  427. SRV support, failover, and weight support. (closes issue
  428. ASTERISK-23435) Reported by: Matt Jordan Review:
  429. https://reviewboard.asterisk.org/r/3343/
  430. * res/res_pjsip_multihomed.c: res_pjsip_multihomed: Make address
  431. replacement less aggressive. This change makes the
  432. res_pjsip_multihomed module less aggressive when changing the
  433. address in messages. It will now only occur if the transport in
  434. use is bound to the any address OR if the system determined
  435. source address matches the bound address of the transport in use.
  436. Review: https://reviewboard.asterisk.org/r/3369/
  437. 2014-03-17 21:56 +0000 [r410747-410750] Russ Meyerriecks <rmeyerreicks@digium.com>
  438. * /, main/callerid.c: !fixup: callerid: Logic error in checksum
  439. processing Fixes syntax error in previous commit :-( ........
  440. Merged revisions 410748 from
  441. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  442. revisions 410749 from
  443. http://svn.asterisk.org/svn/asterisk/branches/11
  444. * main/callerid.c, /: callerid: Logic error in checksum processing
  445. Callerid checksum-ing was being handled incorrectly here. When
  446. the checksum is calculated to be 0x00, it will perform 0x100-0x00
  447. which results in 0x100. This value will then fail the otherwise
  448. correct callerid message. This patch changes the logic to simply
  449. add the calculated checksum to the transmitted 2's compliment
  450. checksum. Review: https://reviewboard.asterisk.org/r/3356/
  451. (closes issue ASTERISK-23488) ........ Merged revisions 410710
  452. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  453. Merged revisions 410717 from
  454. http://svn.asterisk.org/svn/asterisk/branches/11
  455. 2014-03-17 18:36 +0000 [r410673-410696] Mark Michelson <mmichelson@digium.com>
  456. * res/res_mwi_external.c, res/res_pjsip/config_system.c,
  457. configs/sorcery.conf.sample, include/asterisk/sorcery.h,
  458. res/res_pjsip/pjsip_configuration.c, tests/test_sorcery_astdb.c,
  459. tests/test_sorcery.c, tests/test_sorcery_realtime.c,
  460. main/sorcery.c: Revert changes to sorcery that accidentally got
  461. committed. These changes were still up for review and have not
  462. been approved yet. I must have had the changes in my working copy
  463. when making a different change.
  464. * tests/test_sorcery.c, main/channel.c,
  465. res/res_pjsip/config_system.c, res/res_mwi_external.c,
  466. include/asterisk/bridge_channel.h, funcs/func_frame_trace.c,
  467. configs/sorcery.conf.sample, res/res_pjsip/pjsip_configuration.c,
  468. include/asterisk/sorcery.h, tests/test_sorcery_astdb.c,
  469. include/asterisk/frame.h, main/bridge_channel.c,
  470. tests/test_sorcery_realtime.c, main/sorcery.c,
  471. res/res_stasis_playback.c, main/frame.c,
  472. bridges/bridge_softmix.c: Fix stuck channel in ARI through the
  473. introduction of synchronous bridge actions. Playing back a file
  474. to a channel in an ARI bridge would attempt to wait until the
  475. playback concluded before returning. The method used involved
  476. signaling the waiting thread in the ARI custom playback function.
  477. The problem with this is that there were some corner cases that
  478. were not accounted for: * If a bridge channel could not be found,
  479. then we never would attempt the playback but would still attempt
  480. to wait for the playback to complete. * If the bridge playfile
  481. action failed to queue, we would still attempt to wait for the
  482. playback to complete. * If the bridge playfile action were queued
  483. but some circumstance caused the playback not to occur (the
  484. bridge dies, the channel is removed from the bridge), then we
  485. would never be notified. The solution to this is to move the
  486. waiting logic into the bridge code. A new bridge API function is
  487. added to queue a synchronous action on a bridge. The waiting
  488. thread is notified when the queued frame has been freed, either
  489. due to an error occurring or due to successful playback. As a
  490. failsafe, the waiting thread has a 10 minute timeout just in case
  491. there is a frame leak somewhere. Review:
  492. https://reviewboard.asterisk.org/r/3338
  493. 2014-03-17 16:42 +0000 [r410671] Richard Mudgett <rmudgett@digium.com>
  494. * apps/confbridge/conf_chan_announce.c: app_confbridge: Add missing
  495. destructor call to announcer channel destructor.
  496. 2014-03-16 20:20 +0000 [r410650] Matthew Jordan <mjordan@digium.com>
  497. * res/stasis/app.c: stasis/app.c: Add some extra debugging for
  498. subscription counts Events are sent to a connected ARI
  499. application based on the things that ARI application cares about.
  500. These subscriptions can be set up implicitly - such as when that
  501. ARI application creates a new object - or explicitly, via the
  502. application resource's subscription operations. Debugging *why*
  503. something was being sent to an application - or why something was
  504. not being sent to an application - was a bit tricky, as there was
  505. no debug information for the subscriptions. This patch adds some
  506. debug level 3 statements that show the subscription counts for
  507. applications. (Level 3 was chosen as it matches the verbose level
  508. 3 statements elsewhere)
  509. 2014-03-14 21:55 +0000 [r410625] Mark Michelson <mmichelson@digium.com>
  510. * tests/test_sorcery_realtime.c: Fix failing realtime sorcery
  511. tests. The store realtime callback needs to return a positive
  512. value for sorcery to treat the store as a success.
  513. 2014-03-14 21:28 +0000 [r410623] Jonathan Rose <jrose@digium.com>
  514. * main/manager.c, /: manager: fix memory leak in manager_add_filter
  515. function (closes issue ASTERISK-23420) Reported by: Etienne
  516. Lessard Patches: manager_eventfilter_leak uploaded by Etienne
  517. Lessard (license 6394) ........ Merged revisions 410609 from
  518. http://svn.asterisk.org/svn/asterisk/branches/11
  519. 2014-03-14 20:53 +0000 [r410590-410607] Mark Michelson <mmichelson@digium.com>
  520. * main/db.c, /: Remove an extra ast_cond_wait() that slipped
  521. through the patch. ........ Merged revisions 410606 from
  522. http://svn.asterisk.org/svn/asterisk/branches/11
  523. * main/config.c, res/res_sorcery_realtime.c: Handle the return
  524. values of realtime updates and stores more accurately. Realtime
  525. backends' update and store callbacks return the number of rows
  526. affected, or -1 if there was a failure. There were a couple of
  527. issues: * The config API was treating 0 as a successful return,
  528. and positive values as a failure. Now the config API treats
  529. anything >= 0 as a success. * res_sorcery_realtime was treating 0
  530. as a successful return from the store procedure, and any positive
  531. values as a failure. Now sorcery treats anything > 0 as a
  532. success. It still considers 0 a "failure" since there is no
  533. change to report to observers. Review:
  534. https://reviewboard.asterisk.org/r/3341
  535. * res/res_pjsip_mwi.c: Prevent conflicts regarding unsolicited and
  536. solicited MWI to an endpoint. If an endpoint is receiving
  537. unsolicited MWI for a mailbox and then attempts to subscribe to
  538. an AOR that provides MWI for the same mailbox, then the SUBSCRIBE
  539. is rejected with a 500 response. Review:
  540. https://reviewboard.asterisk.org/r/3345
  541. 2014-03-14 17:56 +0000 [r410588] Scott Griepentrog <sgriepentrog@digium.com>
  542. * CHANGES: uniqueid: Update CHANGES to reflect new features Note
  543. the new features provided by uniqueid in the CHANGES file. (issue
  544. ASTERISK-23120) Review: https://reviewboard.asterisk.org/r/3316/
  545. 2014-03-14 16:26 +0000 [r410574] Jonathan Rose <jrose@digium.com>
  546. * CHANGES, res/res_pjsip/config_transport.c,
  547. include/asterisk/acl.h, main/acl.c,
  548. res/res_pjsip/pjsip_configuration.c: PJSIP: TOS values should be
  549. represented as decimals in sorcery objects (closes issue
  550. ASTERISK-23235) Reported by: George Joseph Review:
  551. https://reviewboard.asterisk.org/r/3324/
  552. 2014-03-14 16:11 +0000 [r410559] Mark Michelson <mmichelson@digium.com>
  553. * main/db.c, /: Prevent delayed astdb syncs. The syncing thread
  554. sleeps for a second before waiting to be told to attempt to sync
  555. again. If a signal were sent during this sleeping period, we
  556. would end up having to wait until the next sync signal occurred
  557. in order to sync up the astdb. This code rearrangement also
  558. ensures that any pending transactions will be synced prior to
  559. Asterisk shutting down. Patches: db_sync.patch by John Hardin
  560. (License #6512) ........ Merged revisions 410556 from
  561. http://svn.asterisk.org/svn/asterisk/branches/11
  562. 2014-03-14 16:05 +0000 [r410558] Jonathan Rose <jrose@digium.com>
  563. * res/ari/resource_bridges.c: ARI/bridges: Forward
  564. Playback/Recording Started/Finished to bridge topic (closes issue
  565. ASTERISK-23444) Reported by: Ben Merrills Review:
  566. https://reviewboard.asterisk.org/r/3340/
  567. 2014-03-14 15:55 +0000 [r410541-410555] Richard Mudgett <rmudgett@digium.com>
  568. * include/asterisk/app.h, res/res_mwi_external.c, main/app.c:
  569. res_mwi_external: Clear the stasis cache entry when the external
  570. MWI is deleted. One of the things missing when external MWI
  571. support was added was the ability to clear the stasis cache entry
  572. of deleted external MWI mailboxes. Review:
  573. https://reviewboard.asterisk.org/r/3325/
  574. * main/cdr.c: cdr.c: Add missing aow_unlock(cdr) in off nominal
  575. path of handle_dial_message(). * Trivial common code hoisting in
  576. handle_bridge_leave_message(). * Some whitespace fixing.
  577. 2014-03-13 19:30 +0000 [r410527] Kinsey Moore <kmoore@digium.com>
  578. * res/stasis/control.c, res/stasis/control.h, res/res_stasis.c:
  579. ARI: Ensure managing application receives ChannelEnteredBridge
  580. messages This fixes an issue where a Stasis application running
  581. over ARI and subscribed to ari/events could miss the
  582. ChannelEnteredBridge event because it did not subscribe to the
  583. new bridge fast enough. To accomplish this, it subscribes the
  584. application controlling the channel to the new bridge before
  585. adding it to that bridge which required the stasis_app_control
  586. structure to maintain a reference to the stasis_app. (closes
  587. issue ASTERISK-23295) Review:
  588. https://reviewboard.asterisk.org/r/3336/
  589. 2014-03-13 13:24 +0000 [r410509-410510] Joshua Colp <jcolp@digium.com>
  590. * res/res_pjsip_multihomed.c: res_pjsip_multihomed: Remove change
  591. for testing fix.
  592. * res/res_pjsip_multihomed.c: res_pjsip_multihomed: Fix a bug where
  593. the 200 OK for a REGISTER would contain the wrong contact.
  594. 2014-03-12 19:05 +0000 [r410491-410493] Richard Mudgett <rmudgett@digium.com>
  595. * res/res_musiconhold.c, main/channel.c: res_musiconhold.c:
  596. Generate MOH start/stop events whenever the MOH stream is
  597. started/stopped. * Made res_musiconhold.c always post the
  598. MusicOnHoldStart/MusicOnHoldStop events when it actually
  599. starts/stops the music streams. This allows the events to always
  600. happen when MOH starts/stops. The event posting code was moved to
  601. the MOH alloc/release routines. * Made channel_do_masquerade()
  602. stop any MOH on the original channel before masquerading so the
  603. original channel will get a stop event with correct information.
  604. * Cleaned up a couple odd codings in moh_files_alloc() and
  605. moh_alloc() dealing with the music state variable. (issue
  606. ASTERISK-23311) Reported by: Benjamin Keith Ford Review:
  607. https://reviewboard.asterisk.org/r/3306/
  608. * apps/confbridge/conf_state.c,
  609. apps/confbridge/conf_state_single.c,
  610. apps/confbridge/conf_state_inactive.c,
  611. apps/confbridge/conf_state_single_marked.c, /: app_confbridge:
  612. Make explicitly stop MOH if a user is kicked or hangs up while
  613. MOH is playing. When MOH is playing to a user in a conference and
  614. the user is kicked or hangs up from the conference then the AMI
  615. MusicOnHoldStop events didn't happen. (Asterisk v11 AMI event:
  616. MusicOnHold, state:Stop) (closes issue ASTERISK-23311) Reported
  617. by: Benjamin Keith Ford Review:
  618. https://reviewboard.asterisk.org/r/3306/ ........ Merged
  619. revisions 410490 from
  620. http://svn.asterisk.org/svn/asterisk/branches/11
  621. 2014-03-12 12:50 +0000 [r410451-410471] Joshua Colp <jcolp@digium.com>
  622. * res/res_pjsip_multihomed.c: res_pjsip_multihomed: Fix a bug where
  623. outgoing messages for TCP would go out using UDP. This change
  624. fixes a bug where the code which changes the transport did not
  625. check whether the message is going out over UDP or not before
  626. changing it. For TCP and TLS transports we don't need to change
  627. the transport as the correct one is already chosen.
  628. * res/res_pjsip_multihomed.c (added): res_pjsip_multihomed: Add
  629. module which places the correct address within messages. Due to
  630. how messages are handled within PJSIP it is not until a message
  631. is actually sent that the destination is reliably known. This
  632. means that the addresses placed within the message may not be of
  633. the interface the message is being sent out on. This module
  634. determines what interface a message is being sent on and updates
  635. the message to contain the correct address if applicable. This
  636. module was tested by myself in a virtualized environment with
  637. multiple interfaces and also by Kinsey Moore in the following
  638. configuration: Networks: * 10.24.16.0/21 ** hard phone ** default
  639. gateway * 10.24.64.0/21 ** softphone with pjsip-based stack
  640. Transport details: bind address: 0.0.0.0 protocol: UDP All
  641. endpoints were tested with explicitly configured transports and
  642. unconfigured transports. This was tested with inbound and
  643. outbound calls, both of which were experiencing detrimental
  644. effects from incorrect IP addresses in SIP messages. These
  645. effects were only experienced by the soft phone on the 10.24.64.0
  646. network since the messages to the hard phone on the 10.24.16.0
  647. network had the correct IP address. (closes issue ASTERISK-23020)
  648. Reported by: xrobau Review:
  649. https://reviewboard.asterisk.org/r/3102/
  650. 2014-03-10 17:16 +0000 [r410383] Richard Mudgett <rmudgett@digium.com>
  651. * main/http.c, /: AST-2014-001: Stack overflow in HTTP processing
  652. of Cookie headers. Sending a HTTP request that is handled by
  653. Asterisk with a large number of Cookie headers could overflow the
  654. stack. Another vulnerability along similar lines is any HTTP
  655. request with a ridiculous number of headers in the request could
  656. exhaust system memory. (closes issue ASTERISK-23340) Reported by:
  657. Lucas Molas, researcher at Programa STIC, Fundacion; and Dr.
  658. Manuel Sadosky, Buenos Aires, Argentina ........ Merged revisions
  659. 410380 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  660. ........ Merged revisions 410381 from
  661. http://svn.asterisk.org/svn/asterisk/branches/11
  662. 2014-03-10 16:32 +0000 [r410368] Scott Griepentrog <sgriepentrog@digium.com>
  663. * main/manager.c, res/ari/resource_channels.c: unqiueid: correct
  664. max uniqueid length test This patch adds null string test prior
  665. to checking for a max uniqueid value that was added in r410157.
  666. 2014-03-10 13:25 +0000 [r410329] Kinsey Moore <kmoore@digium.com>
  667. * /, channels/chan_sip.c: AST-2014-002: chan_sip: Exit early on bad
  668. session timers request This change allows chan_sip to avoid
  669. creation of the channel and consumption of associated file
  670. descriptors altogether if the inbound request is going to be
  671. rejected anyway. (closes issue ASTERISK-23373) Reported by: Corey
  672. Farrell Patches: chan_sip-earlier-st-1.8.patch uploaded by Corey
  673. Farrell (license 5909) chan_sip-earlier-st-11.patch uploaded by
  674. Corey Farrell (license 5909) ........ Merged revisions 410308
  675. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  676. Merged revisions 410311 from
  677. http://svn.asterisk.org/svn/asterisk/branches/11
  678. 2014-03-10 12:52 +0000 [r410306] Joshua Colp <jcolp@digium.com>
  679. * res/res_pjsip/pjsip_options.c, res/res_pjsip.c: AST-2014-003:
  680. res_pjsip: When handling 401/407 responses don't assume a request
  681. will have an endpoint. This change removes the assumption that an
  682. outgoing request will always have an endpoint and makes the
  683. authenticate_qualify option work once again. (closes issue
  684. ASTERISK-23210) Reported by: Joshua Colp
  685. 2014-03-08 16:41 +0000 [r410287] George Joseph <george.joseph@fairview5.com>
  686. * res/res_pjsip/config_transport.c, main/sorcery.c,
  687. include/asterisk/res_pjsip.h, res/res_pjsip/config_auth.c,
  688. res/res_pjsip/location.c, res/res_pjsip_outbound_registration.c,
  689. res/res_pjsip_endpoint_identifier_ip.c,
  690. include/asterisk/res_pjsip_cli.h, include/asterisk/sorcery.h,
  691. res/res_pjsip/pjsip_cli.c, res/res_pjsip/pjsip_configuration.c:
  692. pjsip_cli: Create pjsip show channel and contact, and general cli
  693. code cleanup. Created the 'pjsip show channel' and 'pjsip show
  694. contact' commands. Refactored out the hated ast_hashtab. Replaced
  695. with ao2_container. Cleaned up function naming. Internal only, no
  696. public name changes. Cleaned up whitespace and brace formatting
  697. in cli code. Changed some NULL checking from "if"s to
  698. ast_asserts. Fixed some register/unregister ordering to reduce
  699. deadlock potential. Fixed ast_sip_location_add_contact where the
  700. 'name' buffer was too short. Fixed some self-assignment issues in
  701. res_pjsip_outbound_registration. (closes issue ASTERISK-23276)
  702. Review: http://reviewboard.asterisk.org/r/3283/
  703. 2014-03-08 15:43 +0000 [r410274] Matthew Jordan <mjordan@digium.com>
  704. * res/ari/resource_channels.c: resource_channels: Check if a passed
  705. in ID is NULL before checking its length Calling strlen on a NULL
  706. string is explosive. This patch checks whether or not the passed
  707. in string is NULL or zero length before checking to see if the
  708. string is too long.
  709. 2014-03-07 22:53 +0000 [r410226] Corey Farrell <git@cfware.com>
  710. * /, channels/chan_sip.c: chan_sip: Fix deadlock of monlock between
  711. unload_module and do_monitor Release monlock before calling
  712. pthread_join. This ensures do_monitor cannot freeze by locking
  713. monlock during module unload. (closes issue ASTERISK-21406)
  714. Reported by: Corey Farrell Review:
  715. https://reviewboard.asterisk.org/r/3284/ ........ Merged
  716. revisions 410224 from
  717. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  718. revisions 410225 from
  719. http://svn.asterisk.org/svn/asterisk/branches/11
  720. 2014-03-07 22:07 +0000 [r410211] Scott Griepentrog <sgriepentrog@digium.com>
  721. * include/asterisk/sorcery.h: sorcery: correct field register
  722. argument list This fixes mistakes I previously made in merging
  723. gtjoseph's changes with mine.
  724. 2014-03-07 21:53 +0000 [r410194-410209] Matthew Jordan <mjordan@digium.com>
  725. * main/config_options.c: config_options: Display the see-also
  726. information for CLI config option help The config option help
  727. information has always parsed the <see-also> tags in the XML
  728. documentation. Unfortunately, it just never bothered displaying
  729. them on the CLI. With this patch, when you execute 'config show
  730. help [module] [obj] [option]', it will display what other options
  731. are useful to you. (closes issue ASTERISK-22008) Reported by:
  732. Richard Mudgett
  733. * res/res_pjsip.c: res_pjsip: Fix documentation for one touch
  734. recording see-also links The one touch recording options have
  735. several see-also links between the various configuration options.
  736. These were 'broken' by the snake casing of those options. This
  737. patch corrects the see-also links such that they reference the
  738. correct option names.
  739. 2014-03-07 21:10 +0000 [r410190] Scott Griepentrog <sgriepentrog@digium.com>
  740. * main/sorcery.c, include/asterisk/sorcery.h,
  741. res/res_pjsip/pjsip_configuration.c: pjsip: allow and disallow
  742. show same codecs In order to prevent confusion over the allow and
  743. disallow list of codecs being the same an option for registering
  744. a field as an alias is added. The alias field will be read from
  745. the configuration file, but afterwards is not listed as a known
  746. field. With disallow set as an alias, the CLI command pjsip show
  747. endpoint # will list the allow= field, but not the disallow
  748. field. (closes issue ASTERISK-23092) Review:
  749. https://reviewboard.asterisk.org/r/3193/
  750. 2014-03-07 21:03 +0000 [r410187] Mark Michelson <mmichelson@digium.com>
  751. * tests/test_sorcery_realtime.c, main/sorcery.c,
  752. res/res_sorcery_realtime.c, include/asterisk/sorcery.h: Make
  753. res_sorcery_realtime filter unknown retrieved results. When
  754. retrieving data from a database or other realtime backend, it's
  755. quite possible to retrieve variables that Asterisk does not care
  756. about but that are legitimate to exist. Asterisk does not need to
  757. throw a hissy fit when these variables are encountered but rather
  758. just filter them out. Review:
  759. https://reviewboard.asterisk.org/r/3305
  760. 2014-03-07 20:28 +0000 [r410171-410184] Richard Mudgett <rmudgett@digium.com>
  761. * include/asterisk/devicestate.h, main/stasis_cache.c,
  762. main/stasis_message.c, tests/test_devicestate.c,
  763. include/asterisk/stasis.h, main/app.c, main/devicestate.c,
  764. tests/test_stasis.c: stasis cache: Enhance to keep track of an
  765. item from different entities. A stasis cache entry now contains
  766. more than a single message/snapshot. It contains
  767. messages/snapshots for the local entity as well as any remote
  768. entities that post to the cached item. In addition callbacks can
  769. be supplied when the cache is created to compute and post the
  770. aggregate message/snapshot representing all entities stored in
  771. the cache entry. * All stasis messages now have an eid to
  772. indicate what entity posted it. * The stasis cache enhancements
  773. allow device state to cache and aggregate the device states from
  774. local and remote entities in a single operation. The cached
  775. aggregate device state is available immediately after it is
  776. posted to the stasis bus. This improves performance by
  777. eliminating a cache dump and associated ao2 container traversals
  778. to calculate the aggregate state. (closes issue ASTERISK-23204)
  779. Reported by: Mark Michelson Review:
  780. https://reviewboard.asterisk.org/r/3281/
  781. * tests/test_cel.c, channels/sig_pri.c, channels/sig_ss7.c,
  782. include/asterisk/bridge.h, tests/test_cdr.c, channels/sig_pri.h,
  783. channels/chan_dahdi.c, channels/sig_ss7.h: uniqueid: Fix
  784. chan_dahdi, sig_pri, sig_ss7, test_cdr, and test_cel compiler
  785. errors. (issue ASTERISK-23120)
  786. 2014-03-07 15:46 +0000 [r410157] Scott Griepentrog <sgriepentrog@digium.com>
  787. * addons/chan_mobile.c, main/bridge_channel.c,
  788. channels/chan_pjsip.c, channels/chan_mgcp.c,
  789. channels/chan_unistim.c, res/res_calendar_icalendar.c,
  790. main/pbx.c, channels/chan_bridge_media.c, main/ccss.c,
  791. main/bridge.c, tests/test_stasis_channels.c,
  792. apps/app_originate.c, apps/app_bridgewait.c,
  793. res/parking/parking_applications.c, include/asterisk/channel.h,
  794. res/res_calendar_caldav.c, apps/app_queue.c, apps/app_followme.c,
  795. main/cel.c, res/res_ari_channels.c,
  796. rest-api/api-docs/bridges.json, res/res_calendar_ews.c,
  797. main/dial.c, channels/chan_dahdi.c, channels/chan_h323.c,
  798. tests/test_cel.c, rest-api/api-docs/channels.json,
  799. include/asterisk/bridge_internal.h,
  800. apps/confbridge/conf_chan_announce.c,
  801. include/asterisk/core_unreal.h, res/res_calendar.c,
  802. addons/chan_ooh323.c, channels/chan_sip.c, res/stasis/control.c,
  803. main/channel_internal_api.c, include/asterisk/stasis_app.h,
  804. channels/chan_console.c, res/res_stasis_snoop.c,
  805. channels/chan_iax2.c, channels/chan_oss.c, apps/app_agent_pool.c,
  806. main/channel.c, main/manager.c, channels/chan_misdn.c,
  807. tests/test_voicemail_api.c, channels/chan_alsa.c,
  808. channels/chan_nbs.c, main/message.c, tests/test_cdr.c,
  809. res/res_clioriginate.c, res/res_ari_bridges.c,
  810. tests/test_substitution.c, channels/chan_multicast_rtp.c,
  811. res/res_stasis_playback.c, apps/app_meetme.c,
  812. apps/confbridge/conf_chan_record.c, tests/test_app.c,
  813. include/asterisk/channel_internal.h, main/bridge_basic.c,
  814. main/core_unreal.c, channels/chan_gtalk.c,
  815. include/asterisk/stasis_app_playback.h,
  816. res/ari/resource_bridges.c, channels/chan_jingle.c,
  817. channels/chan_phone.c, pbx/pbx_spool.c,
  818. res/ari/resource_bridges.h, res/parking/parking_tests.c,
  819. channels/chan_motif.c, apps/app_confbridge.c,
  820. include/asterisk/pbx.h, res/ari/resource_channels.c,
  821. res/res_stasis.c, include/asterisk/bridge.h,
  822. res/ari/resource_channels.h, apps/app_voicemail.c,
  823. apps/app_dial.c, res/res_calendar_exchange.c,
  824. channels/chan_vpb.cc, apps/app_page.c, apps/app_chanisavail.c,
  825. main/core_local.c, include/asterisk/dial.h,
  826. res/parking/parking_bridge_features.c,
  827. tests/test_stasis_endpoints.c, res/parking/parking_bridge.c,
  828. channels/chan_skinny.c, include/asterisk/stasis_app_snoop.h:
  829. uniqueid: channel linkedid, ami, ari object creation with id's
  830. Much needed was a way to assign id to objects on creation, and
  831. much change was necessary to accomplish it. Channel uniqueids and
  832. linkedids are split into separate string and creation time
  833. components without breaking linkedid propgation. This allowed the
  834. uniqueid to be specified by the user interface - and those values
  835. are now carried through to channel creation, adding the
  836. assignedids value to every function in the chain including the
  837. channel drivers. For local channels, the second channel can be
  838. specified or left to default to a ;2 suffix of first. In ARI,
  839. bridge, playback, and snoop objects can also be created with a
  840. specified uniqueid. Along the way, the args order to allocating
  841. channels was fixed in chan_mgcp and chan_gtalk, and linkedid is
  842. no longer lost as masquerade occurs. (closes issue
  843. ASTERISK-23120) Review: https://reviewboard.asterisk.org/r/3191/
  844. 2014-03-07 04:51 +0000 [r410107] Matthew Jordan <mjordan@digium.com>
  845. * /, channels/chan_sip.c: chan_sip: Allow static realtime members
  846. to be qualified during module load. When a static realtime peer
  847. with qualify=yes is loaded, Asterisk will fail to send an OPTIONS
  848. request due to the lastms being equal to 0. This results in the
  849. peer being unable to receive calls from Asterisk because the
  850. status is permanently UNKNOWN. This patch allows an OPTIONS
  851. request to be sent during module load by ignoring the lastms
  852. value on startup only. Review:
  853. https://reviewboard.asterisk.org/r/3294/ (closes issue
  854. ASTERISK-17523) Reported by: Maciej Krajewski Tested by:
  855. wushumasters patches: realtime_fix_11.7.0.txt uploaded by Trevor
  856. Peirce (license 6112) ........ Merged revisions 410105 from
  857. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  858. revisions 410106 from
  859. http://svn.asterisk.org/svn/asterisk/branches/11
  860. 2014-03-06 23:40 +0000 [r410090] Russell Bryant <russell@russellbryant.com>
  861. * res/res_musiconhold.c, /: moh: fix a refcount error with realtime
  862. MOH I observed a crash in res_musiconhold on an Asterisk 11
  863. system using realtime MOH. Investigation of the backtrace showed
  864. a corrupt mohclass, implying that it got destroyed before the
  865. code expected it to. I went looking for reference counting errors
  866. that could have caused this crash and this patch this result. It
  867. contains 2 changes. 1) Remove a usless block of code that was
  868. impossible to reach. There was even a comment indicating that it
  869. was impossible to reach. The conditional includes
  870. "!ast_test_flag(global_flags, MOH_CACHERTCLASSES)" and it's
  871. inside of an if block with the opposite check
  872. "ast_test_flag(global_flags, MOH_CACHERTCLASSES)". There's no
  873. good reason to keep it around. 2) A similar block to #1 contained
  874. a reference counting error. It stores state->class in the local
  875. variable mohclass without increasing its reference count. The
  876. reference count on mohclass is decremented at the end of the
  877. function. This block of code probably very rarely runs, which
  878. would help explain why this system was working fine for many
  879. months before experiencing a crash. Review:
  880. https://reviewboard.asterisk.org/r/3282/ ........ Merged
  881. revisions 410043 from
  882. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  883. revisions 410044 from
  884. http://svn.asterisk.org/svn/asterisk/branches/11
  885. 2014-03-06 23:35 +0000 [r410089] Richard Mudgett <rmudgett@digium.com>
  886. * main/sorcery.c: sorcery.c: Fix off-nominal path ref and memory
  887. leak in ast_sorcery_objectset_json_create(). * Made exit a loop
  888. early on error in ast_sorcery_objectset_json_create(). * Removed
  889. some dead code in ast_sorcery_objectset_create2().
  890. 2014-03-06 18:50 +0000 [r410028] Jonathan Rose <jrose@digium.com>
  891. * main/acl.c, res/res_pjsip/pjsip_configuration.c, UPGRADE.txt,
  892. contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py
  893. (added), res/res_pjsip/config_transport.c,
  894. include/asterisk/acl.h: pjsip configuration: Make transport TOS
  895. values consistent with endpoints Transport TOS values were
  896. interpreted as DSCP values without being documented as such.
  897. Endpoint TOS values (tos_audio/tos_video) behaved normally as TOS
  898. values have historically. This patch makes the transport TOS
  899. values behave as TOS values and makes all TOS values readable as
  900. string values (e.g. AF11). In addition, alembic scripts have been
  901. updated to use the proper field types for all TOS/COS values.
  902. (issue ASTERISK-23235) Reported by: George Joseph Review:
  903. https://reviewboard.asterisk.org/r/3304/
  904. 2014-03-06 18:18 +0000 [r410025] Joshua Colp <jcolp@digium.com>
  905. * res/res_stasis_recording.c, res/ari/resource_channels.c, CHANGES,
  906. res/ari/ari_model_validators.c,
  907. rest-api/api-docs/recordings.json, res/ari/resource_bridges.c,
  908. res/ari/ari_model_validators.h,
  909. include/asterisk/stasis_app_recording.h: res_stasis_recording:
  910. Add a "target_uri" field to recording events. This change adds a
  911. target_uri field to the live recording object. It contains the
  912. URI of what is being recorded. (closes issue ASTERISK-23258)
  913. Reported by: Ben Merrills Review:
  914. https://reviewboard.asterisk.org/r/3299/
  915. 2014-03-06 15:43 +0000 [r410011] Mark Michelson <mmichelson@digium.com>
  916. * res/res_pjsip_mwi.c: Don't attempt to link in an aggregate MWI
  917. subscription if an endpoint does not aggregate MWI. Attempting to
  918. link a NULL object into an ao2 container had been benign
  919. previously, but since enabling DO_CRASH in the testsuite, this is
  920. now causing a crash. It's better to be right here anyway.
  921. 2014-03-06 15:13 +0000 [r410006] George Joseph <george.joseph@fairview5.com>
  922. * res/res_pjsip_outbound_registration.c, main/bucket.c,
  923. res/res_pjsip_endpoint_identifier_ip.c,
  924. include/asterisk/config.h, include/asterisk/sorcery.h,
  925. res/res_pjsip/pjsip_configuration.c, res/res_pjsip_acl.c,
  926. CHANGES, tests/test_sorcery.c, res/res_pjsip/config_transport.c,
  927. main/config.c, main/sorcery.c, res/res_pjsip/config_auth.c,
  928. funcs/func_sorcery.c (added), res/res_pjsip/location.c: sorcery:
  929. Create AST_SORCERY dialplan function. This patch creates the
  930. AST_SORCERY dialplan function which allows someone to retrieve
  931. any value from a sorcery-based config file. It's similar to
  932. AST_CONFIG. The creation of the function itself was fairly
  933. straightforward but it required changes to the underlying sorcery
  934. infrastructure that rippled into individual sorcery objects. The
  935. changes stemmed from inconsistencies in how sorcery created
  936. ast_variable objectsets from sorcery objects and the
  937. inconsistency in how individual objects used that feature
  938. especially when it came to parameters that can be specified
  939. multiple times like contact in aor and match in identify. You can
  940. read more here...
  941. http://lists.digium.com/pipermail/asterisk-dev/2014-February/065202.html
  942. So, what this patch does, besides actually creating the
  943. AST_SORCERY function, is the following... * Creates
  944. ast_variable_list_append which is a helper to append one
  945. ast_variable list to another. * Modifies the
  946. ast_sorcery_object_field_register functions to accept the
  947. already-defined sorcery_fields_handler callback. * Modifies
  948. ast_sorcery_objectset_create to accept a parameter indicating
  949. return type preference...a single ast_variable with all values
  950. concatenated or an ast_variable list with multiple entries. Also
  951. fixed a few bugs. * Modifies individual sorcery object
  952. implementations to use the new function definition of the
  953. ast_sorcery_object_field_register functions. * Modifies
  954. location.c and res_pjsip_endpoint_identifier_ip.c to implement
  955. sorcery_fields_handler handlers so they return multiple
  956. occurrences as an ast_variable_list. * Added a whole bunch of
  957. tests to test_sorcery. (closes issue ASTERISK-22537) Review:
  958. http://reviewboard.asterisk.org/r/3254/
  959. 2014-03-06 02:05 +0000 [r409991] Matthew Jordan <mjordan@digium.com>
  960. * res/res_fax_spandsp.c, /: res_fax_spandsp: Fix crash when passing
  961. ulaw/alaw data to spandsp When acting as a T.38 fax gateway,
  962. res_fax_spandsp would at times cause a crash in libspandsp. This
  963. would occur when, during fax tone detection, a ulaw/alaw frame
  964. would be passed to modem_connect_tones_rx. That particular
  965. routine expects the data to be in slin format. This patch looks
  966. at the frame type and, if the data is ulaw/alaw, converts the
  967. format to slin before passing it to modem_connect_tones_rx.
  968. Review: https://reviewboard.asterisk.org/r/3296 (closes issue
  969. ASTERISK-20149) Reported by: Alexandr Gordeev Tested by: Michal
  970. Rybarik patches: spandsp_g711decode.diff uploaded by Michal
  971. Rybarik (license 6578) ........ Merged revisions 409990 from
  972. http://svn.asterisk.org/svn/asterisk/branches/11
  973. 2014-03-06 00:32 +0000 [r409967-409976] Richard Mudgett <rmudgett@digium.com>
  974. * apps/confbridge/conf_state_inactive.c,
  975. apps/confbridge/conf_state_multi.c: app_confbridge: Remove some
  976. noop code.
  977. * res/res_musiconhold.c: res_musiconhold.c: Remove some unnecessary
  978. RAII_VAR() usage. * Made the moh_register() define use useful
  979. parameter names.
  980. 2014-03-05 20:40 +0000 [r409900-409918] Kinsey Moore <kmoore@digium.com>
  981. * main/config.c, /: config: Fix inverted test The test of the
  982. result of the stat() call was inverted such that its output was
  983. only used if the call failed. This inverts the test so that the
  984. output of stat() is used correctly. This was causing full reloads
  985. on unchanged files. (closes issue ASTERISK-23383) Reported by:
  986. David Woolley ........ Merged revisions 409916 from
  987. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  988. revisions 409917 from
  989. http://svn.asterisk.org/svn/asterisk/branches/11
  990. * bridges/bridge_native_rtp.c: bridge_native_rtp: Fix crash
  991. involving masquerade It is possible for a channel to be
  992. masqueraded out of a bridge which means it may no longer have RTP
  993. glue to check upon leaving said bridge. If this situation
  994. occurred (it's possible at least during dial and call pickup)
  995. then Asterisk would crash. This change makes sure the glue is
  996. checked before use. (closes issue AST-1290) Reported by: John
  997. Bigelow
  998. 2014-03-05 18:46 +0000 [r409887] Mark Michelson <mmichelson@digium.com>
  999. * funcs/func_presencestate.c, /: Fix documentation for
  1000. PRESENCE_STATE to properly illustrate how to create a presence
  1001. hint. There was a missing comma. This was discovered by Dan
  1002. Kaplan. ........ Merged revisions 409886 from
  1003. http://svn.asterisk.org/svn/asterisk/branches/11
  1004. 2014-03-05 18:40 +0000 [r409885] Richard Mudgett <rmudgett@digium.com>
  1005. * contrib/ast-db-manage/cdr/versions (added),
  1006. contrib/ast-db-manage/cdr/versions/210693f3123d_create_cdr_table.py
  1007. (added),
  1008. contrib/ast-db-manage/config/versions/28887f25a46f_create_queue_tables.py
  1009. (added), contrib/ast-db-manage/cdr.ini.sample (added),
  1010. contrib/ast-db-manage/cdr/env.py (added),
  1011. contrib/ast-db-manage/cdr (added),
  1012. contrib/ast-db-manage/cdr/script.py.mako (added): alembic: Add
  1013. missing queue and CDR table creation scripts. * Added the queues
  1014. and queue_members tables to the config alembic scripts. * Added
  1015. the CDR table alembic creation script. The CDR table is more of
  1016. an example for new setups since the actual table can be fully
  1017. customized in cdr_adaptive_odbc.conf. (closes issue
  1018. ASTERISK-23233) Reported by: jmls Review:
  1019. https://reviewboard.asterisk.org/r/3227/
  1020. 2014-03-05 16:57 +0000 [r409835] David M. Lee <dlee@digium.com>
  1021. * /, configure, include/asterisk/autoconfig.h.in, configure.ac,
  1022. main/config.c: Corrected cross-platform stat nanosecond code When
  1023. nanosecond time resolution was added for identifying config file
  1024. changes, it didn't cover all of the myriad of ways that one might
  1025. obtain nanosecond time resolution off of struct stat. Rather than
  1026. complicate the #if even further figuring out one system from the
  1027. next, this patch directly tests for the three struct members I
  1028. know about today, and #ifdef's accordingly. Review:
  1029. https://reviewboard.asterisk.org/r/3273/ ........ Merged
  1030. revisions 409833 from
  1031. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1032. revisions 409834 from
  1033. http://svn.asterisk.org/svn/asterisk/branches/11
  1034. 2014-03-05 12:05 +0000 [r409779] Sean Bright <sean@malleable.com>
  1035. * /, contrib/scripts/astgenkey, contrib/scripts/astgenkey.8: Fix
  1036. references to 'keys' CLI commands in astgenkey ........ Merged
  1037. revisions 409777 from
  1038. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1039. revisions 409778 from
  1040. http://svn.asterisk.org/svn/asterisk/branches/11
  1041. 2014-03-05 06:30 +0000 [r409746-409762] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  1042. * channels/chan_unistim.c, /: Correct RTP handling in chan_unistim
  1043. and fix transfer process broken in previous fix: - Fixed too
  1044. early RTP setup with phone, that cause no ringback tone on caller
  1045. side - Handle call transfer cancel only in STATE_CALL case
  1046. (related to ASTERISK-23073) (Reported by: Németh Tamás, niurkin
  1047. sil) ........ Merged revisions 409761 from
  1048. http://svn.asterisk.org/svn/asterisk/branches/11
  1049. * channels/chan_unistim.c, /: Add update_peer function to
  1050. unistim_rtp_glue, improve other unistim_rtp_glue functions
  1051. conforming to other channel drivers. Do not forget auto-detected
  1052. and user-selected phone settings on 'unistim reload' ........
  1053. Merged revisions 409705 from
  1054. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1055. revisions 409745 from
  1056. http://svn.asterisk.org/svn/asterisk/branches/11
  1057. 2014-03-05 04:59 +0000 [r409697-409704] Moises Silva <moises.silva@gmail.com>
  1058. * /, res/res_http_websocket.c: Fix res/res_http_websocket.c build
  1059. failure in 32bit due to incorrect print format for uint64_t
  1060. ........ Merged revisions 409703 from
  1061. http://svn.asterisk.org/svn/asterisk/branches/11
  1062. * res/res_http_websocket.c, /: Fix WebRTC over WSS not working
  1063. Several fixes for the WebSockets implementation in
  1064. res/res_http_websocket.c * Flush the websocket session FILE* as
  1065. fwrite() may not actually guarantee sending the data to the
  1066. network. If we do not flush, it seems that buffering on the SSL
  1067. socket for outbound messages causes issues * Refactored
  1068. ast_websocket_read to take into account that SSL file descriptors
  1069. may be ready to read via fread() but poll() will not actually say
  1070. so because the data was already read from the network buffers and
  1071. is now in the libc buffers (closes issue ASTERISK-23099) (closes
  1072. issue ASTERISK-21930) Review:
  1073. https://reviewboard.asterisk.org/r/3248/ ........ Merged
  1074. revisions 409681 from
  1075. http://svn.asterisk.org/svn/asterisk/branches/11
  1076. 2014-03-05 00:55 +0000 [r409682] Richard Mudgett <rmudgett@digium.com>
  1077. * include/asterisk/stasis_internal.h: stasis: Made
  1078. internal_stasis_subscribe() prototype and definition match
  1079. exactly.
  1080. 2014-03-04 19:34 +0000 [r409626] Michael L. Young <elgueromexicano@gmail.com>
  1081. * funcs/func_audiohookinherit.c, /: func_audiohookinheritance:
  1082. Check If A Channel Was Specified This patch prevents a crash when
  1083. using the function audiohookinheritance without setting the
  1084. channel. (closes issue ASTERISK-23104) Reported by: Joel Vandal
  1085. Tested by: Joel Vandal Patches:
  1086. asterisk-23104_audiohook_inherit_no_channel-11.diff uploaded by
  1087. Michael L. Young (license 5026) Review:
  1088. https://reviewboard.asterisk.org/r/3272/ ........ Merged
  1089. revisions 409623 from
  1090. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1091. revisions 409625 from
  1092. http://svn.asterisk.org/svn/asterisk/branches/11
  1093. 2014-03-04 17:07 +0000 [r409570] Jonathan Rose <jrose@digium.com>
  1094. * /, res/res_rtp_asterisk.c: res_rtp_asterisk: Fix one way audio
  1095. problems with hold/unhold when using ICE ICE sessions will now be
  1096. restarted if sessions are changed to use new sets of remote
  1097. candidates. (closes issue ASTERISK-22911) Reported by: Vytis
  1098. Valentinavičius Review: https://reviewboard.asterisk.org/r/3275/
  1099. ........ Merged revisions 409565 from
  1100. http://svn.asterisk.org/svn/asterisk/branches/11
  1101. 2014-03-04 16:53 +0000 [r409568] Kinsey Moore <kmoore@digium.com>
  1102. * /, main/astobj2.c: AO2: Add an assert for bad objects This adds
  1103. an assert that will only be active if Asterisk is compiled with
  1104. DO_CRASH and allows the testsuite to fail tests that would
  1105. otherwise require log file parsing. ........ Merged revisions
  1106. 409566 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  1107. ........ Merged revisions 409567 from
  1108. http://svn.asterisk.org/svn/asterisk/branches/11
  1109. 2014-03-04 14:54 +0000 [r409474] Sean Bright <sean@malleable.com>
  1110. * /, channels/chan_sip.c: Minor whitespace change to 'sip show
  1111. peers' output. (closes issue ASTERISK-23406) Reported by: ibercom
  1112. Tested by: ibercom Patches: asterisk-11.patch uploaded by ibercom
  1113. ........ Merged revisions 409472 from
  1114. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1115. revisions 409473 from
  1116. http://svn.asterisk.org/svn/asterisk/branches/11
  1117. 2014-03-03 19:44 +0000 [r409422] Joshua Colp <jcolp@digium.com>
  1118. * res/res_stasis_recording.c: res_stasis_recording: Fix memory leak
  1119. of the absolute name.
  1120. 2014-03-03 02:08 +0000 [r409363] Matthew Jordan <mjordan@digium.com>
  1121. * main/asterisk.c, /: doxygen: Tweak the link back to ye olde
  1122. Digium website ........ Merged revisions 409361 from
  1123. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1124. revisions 409362 from
  1125. http://svn.asterisk.org/svn/asterisk/branches/11
  1126. 2014-03-02 15:14 +0000 [r409346] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  1127. * /, Makefile.rules: Makefile: replace -O6 with -O3 -O6 is not a
  1128. legal option of gcc. Unofficially gcc considers it to be
  1129. equivalent of -O3. clang chalks on it, though. This commit sets
  1130. the default optimization flag to be -O3, like gcc actually
  1131. considered it. Review: https://reviewboard.asterisk.org/r/3280/
  1132. ........ Merged revisions 409308 from
  1133. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1134. revisions 409344 from
  1135. http://svn.asterisk.org/svn/asterisk/branches/11
  1136. 2014-03-01 20:27 +0000 [r409287] Joshua Colp <jcolp@digium.com>
  1137. * res/res_pjsip_session.c: res_pjsip_session: Set options (100rel,
  1138. timers) on incoming sessions. This change passes options to the
  1139. UAS creation function. This in turn sets up 100rel and session
  1140. timer properties on the incoming session. Reported by Julian
  1141. Russell on asterisk-users mailing list.
  1142. 2014-03-01 00:04 +0000 [r409256-409274] Richard Mudgett <rmudgett@digium.com>
  1143. * main/devicestate.c: devicestate.c: Simplified some logic in
  1144. _ast_device_state().
  1145. * main/stasis_cache.c: stasis_cache.c: Remove some unnecessary
  1146. RAII_VAR() usage.
  1147. * main/stasis.c: stasis.c: Misc code cleanups. * Remove some
  1148. unnecessary RAII_VAR() usage. * Made the struct
  1149. stasis_subscription ao2 object use the ao2 lock instead of a
  1150. redundant join_lock in the struct for ast_cond_wait(). * Removed
  1151. locks on some ao2 objects that don't need the lock. * Made the
  1152. topic pool entries container use the ao2 template functions. *
  1153. Add some missing allocation failure checks. * Add missing cleanup
  1154. in off nominal path of dispatch_message().
  1155. * /, channels/chan_sip.c: chan_sip: Add precautionary p->owner
  1156. checks. * Add precautionary p->owner checks in sip_hangup(),
  1157. get_refer_info(), get_also_info(), and
  1158. interpret_t38_parameters(). * Simplify some tangled logic in
  1159. get_refer_info(), get_also_info(), and add_rpid(). * Removed some
  1160. dead code in handle_request_invite(). (closes issue
  1161. ASTERISK-23323) Reported by: Walter Doekes Patches:
  1162. issueA23323-more_p_owner_checks-1.8.x.patch (license #5674)
  1163. uploaded by wdoekes (modified)
  1164. issueA23323-more_p_owner_checks-11.x.patch (license #5674)
  1165. uploaded by wdoekes (modified)
  1166. issueA23323-more_p_owner_checks-12.x.patch (license #5674)
  1167. uploaded by wdoekes (modified)
  1168. issueA23323-more_p_owner_checks-trunk.patch (license #5674)
  1169. uploaded by wdoekes (modified) ........ Merged revisions 409207
  1170. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  1171. Merged revisions 409255 from
  1172. http://svn.asterisk.org/svn/asterisk/branches/11
  1173. 2014-02-28 21:24 +0000 [r409234] Kinsey Moore <kmoore@digium.com>
  1174. * apps/app_queue.c: app_queue: Fix documented AMI event name During
  1175. the rewrite of AMI events to use the Stasis bus, the name of the
  1176. QueueMemberPaused event was changed to QueueMemberPause. This
  1177. corrects documentation to reflect that.
  1178. 2014-02-28 18:02 +0000 [r409158] Richard Mudgett <rmudgett@digium.com>
  1179. * /, channels/chan_sip.c: chan_sip: Fix crash in
  1180. ast_channel_hangupcause_set(). * Fix crash in
  1181. ast_channel_hangupcause_set() because p->owner not checked before
  1182. calling. Regression introduced by the fix for ASTERISK-22621.
  1183. (closes issue ASTERISK-23135) Reported by: OK (issue
  1184. ASTERISK-23323) Reported by: Walter Doekes ........ Merged
  1185. revisions 409156 from
  1186. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1187. revisions 409157 from
  1188. http://svn.asterisk.org/svn/asterisk/branches/11
  1189. 2014-02-27 19:42 +0000 [r409131] Jonathan Rose <jrose@digium.com>
  1190. * /, res/res_rtp_asterisk.c: Multiple revisions 409129-409130
  1191. ........ r409129 | jrose | 2014-02-27 13:19:02 -0600 (Thu, 27 Feb
  1192. 2014) | 15 lines res_rtp_asterisk: Fix checklist creating
  1193. problems in ICE sessions Prior to this patch, local candidate
  1194. lists including SRFLX would fail to start properly when building
  1195. ICE candidate check lists. This patch fixes that problem by
  1196. making sure that each SRFLX candidate is associated with the
  1197. proper base address so that the check list can create matches
  1198. properly. This patch was written by jcolp. The issue will be left
  1199. open to await testing by the issue participants. (issue
  1200. ASTERISK-23213) Reported by: Andrea Suisani Review:
  1201. https://reviewboard.asterisk.org/r/3256/ ........ r409130 | jrose
  1202. | 2014-02-27 13:38:10 -0600 (Thu, 27 Feb 2014) | 8 lines
  1203. res_rtp_asterisk: correct build error from r409129 Accidentally
  1204. placed a declaration below functional code (issue ASTERISK-23213)
  1205. Reported by: Andrea Suisani Review:
  1206. https://reviewboard.asterisk.org/r/3256/ ........ Merged
  1207. revisions 409129-409130 from
  1208. http://svn.asterisk.org/svn/asterisk/branches/11
  1209. 2014-02-27 16:25 +0000 [r409087] David M. Lee <dlee@digium.com>
  1210. * /, utils/astman.c: Fix memory stomping bug in astman. This memset
  1211. complained in dev mod on my Ubuntu box. The memset is both
  1212. unnecessary and dangerous. At this point, m hasn't been
  1213. initialized yet, so the memset will write off to whatever address
  1214. happens to be on the stack at the time. ........ Merged revisions
  1215. 409077 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  1216. ........ Merged revisions 409083 from
  1217. http://svn.asterisk.org/svn/asterisk/branches/11
  1218. 2014-02-27 16:05 +0000 [r409054] Corey Farrell <git@cfware.com>
  1219. * res/res_fax.c, configs/res_fax.conf.sample, /: res_fax: Warn that
  1220. minrate=2400 is not valid for V.27 instead of failing load.
  1221. Change minrate from 2400 to 4800 on config reload in response to
  1222. changes from ASTERISK-22790 only. Any config with minrate of 2400
  1223. that would fail before r405693 will still fail. Comment out many
  1224. settings in res_fax.conf.sample. The defaults are set in
  1225. res_fax.c, so setting the same value in sample config does
  1226. nothing but make the sample config more fragile. (closes issue
  1227. ASTERISK-23231) Reported by: David Brillert Review:
  1228. https://reviewboard.asterisk.org/r/3261/ ........ Merged
  1229. revisions 409052 from
  1230. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1231. revisions 409053 from
  1232. http://svn.asterisk.org/svn/asterisk/branches/11
  1233. 2014-02-27 12:28 +0000 [r408999] Matthew Jordan <mjordan@digium.com>
  1234. * res/res_pjsip_sdp_rtp.c: res_pjsip_sdp_rtp: Apply packetization
  1235. rules on inbound SDP handling The setting 'use_ptime' is supposed
  1236. to tell Asterisk to honour the ptime attribute in an offer,
  1237. preferring it to whatever packetization preferences have been set
  1238. internally. Currently, however, something rather quirky will
  1239. happen: (1) The SDP answer will be constructed in
  1240. create_outgoing_sdp_stream. This will use the preferences from
  1241. the endpoint, such that the 200 OK response will add the
  1242. packetization preferences from the endpoint, and not what was
  1243. offered. (2) When the 200 response is issued,
  1244. apply_negotiated_sdp_stream is called. This will call
  1245. apply_packetization, which will use the ptime attribute from the
  1246. offer internally. We end up telling the offerer to use the
  1247. internal ptime attribute, but we end up using the offered ptime
  1248. attribute. Hilarity ensues. This patch modifies the behaviour by
  1249. calling apply_packetization from negotiate_incoming_sdp_stream,
  1250. which is called prior to create_outgoing_sdp_stream. This causes
  1251. the format preferences on the session's media object to be set to
  1252. the inbound ptime value (if 'use_ptime' is enabled), such that
  1253. the construction of the answer gets the right value immediately.
  1254. Review: https://reviewboard.asterisk.org/r/3244/
  1255. 2014-02-26 23:33 +0000 [r408983] Richard Mudgett <rmudgett@digium.com>
  1256. * tests/test_stasis.c: test_stasis.c: Misc cleanups. * Make the
  1257. consumer ao2 object use the ao2 lock instead of a redundant lock
  1258. in the struct for ast_cond_wait(). * Fixed some curly brace
  1259. placements. * Fixed use of malloc(0). malloc(0) has variant
  1260. behavior. It is up to the implementation to determine if it
  1261. returns NULL or a valid pointer that can be later passed to
  1262. free().
  1263. 2014-02-26 19:00 +0000 [r408970] Scott Griepentrog <sgriepentrog@digium.com>
  1264. * channels/chan_pjsip.c: pjsip: avoid edge case potential crash in
  1265. answer() When accidentally compiling against a wrong version of
  1266. pjsip headers with a different pjsip_inv_session size, the
  1267. invite_tsx structure could be null in the answer() function. This
  1268. led to a crash because it attempted to send the session response
  1269. with an uninitialized packet pointer. This patch presets packet
  1270. to null and adds a diagnostic log message to explain why the call
  1271. fails. Review: https://reviewboard.asterisk.org/r/3267/
  1272. 2014-02-26 17:03 +0000 [r408957] Joshua Colp <jcolp@digium.com>
  1273. * res/res_ari.c: res_ari: Make some additional error responses
  1274. consistent with the rest of the system. This change makes some
  1275. error cases use ast_ari_response_error to construct their error
  1276. responses instead of manually doing it. This ensures they are
  1277. consistent with the other error responses. Based on the original
  1278. patch as done by Paul Belanger on the associated review. Review:
  1279. https://reviewboard.asterisk.org/r/2904/
  1280. 2014-02-26 13:46 +0000 [r408941-408943] Kinsey Moore <kmoore@digium.com>
  1281. * include/asterisk/res_pjsip_session.h: PJSIP: Fix some bad spacing
  1282. * res/res_pjsip_refer.c: PJSIP: Prevent crash if channel has gone
  1283. away It is currently possible for an ast_sip_session to exist
  1284. without an associated channel as is the case when a new invite is
  1285. coming in or just after a hangup is issued on a chan_pjsip
  1286. channel. Part of the attended transfer code assumed the channel
  1287. would be non-NULL and used it as such causing a crash. This bug
  1288. was exposed thanks to the attended transfer ARI test in the test
  1289. suite. (closes issue ASTERISK-23287) Reported by: Matt Jordan
  1290. 2014-02-25 17:50 +0000 [r408880-408882] Kevin Harwell <kharwell@digium.com>
  1291. * res/res_pjsip_exten_state.c,
  1292. res/res_pjsip_pidf_digium_body_supplement.c (added),
  1293. include/asterisk/res_pjsip_body_generator_types.h:
  1294. res_pjsip_exten_state: Presence for digium phones Added presence
  1295. support for digium phones. Review:
  1296. https://reviewboard.asterisk.org/r/3239/
  1297. * res/res_pjsip_send_to_voicemail.c (added),
  1298. res/res_pjsip_header_funcs.c: res_pjsip_send_to_voicemail:
  1299. transferring to voicemail for digium phones Added the ability for
  1300. transferring directly to voicemail on digium phones. Added a new
  1301. module that checks for the presence of a custom header and/or
  1302. diversion header within a sip REFER. If either is found and they
  1303. specify a sending to voicemail action then variables are added to
  1304. the channel allowing the user access to them in the dialplan.
  1305. Dialplan can then be written that branches based upon these
  1306. values allowing, for instace, for a single number to be used for
  1307. dialing and/or accessing voicemail directly. Also fixed a problem
  1308. where the PJSIP_HEADER function was allowing non pjsip channels
  1309. through (checked to make sure it has the correct channel type
  1310. before proceeding). Review:
  1311. https://reviewboard.asterisk.org/r/3245/
  1312. 2014-02-25 17:43 +0000 [r408878] Rusty Newton <rnewton@digium.com>
  1313. * configs/voicemail.conf.sample, /: configs/voicemail.conf.sample -
  1314. Make mailcmd sample text more explicit Made the wording a bit
  1315. more explicit. Didn't really change the meaning. ........ Merged
  1316. revisions 408876 from
  1317. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1318. revisions 408877 from
  1319. http://svn.asterisk.org/svn/asterisk/branches/11
  1320. 2014-02-22 19:56 +0000 [r408855] Matthew Jordan <mjordan@digium.com>
  1321. * main/asterisk.c: main: Initialize dialplan providing core
  1322. components prior to module pre-load It is possible to pre-load
  1323. pbx_config. As a result, pbx_config - which will load and parse
  1324. the dialplan - will attempt to use various dialplan components,
  1325. such as device state providers and presence state providers,
  1326. prior to them being initialized by the core. This would lead to a
  1327. crash, as the components had not created their Stasis cache
  1328. entries. This patch moves a number of core component
  1329. initializations before the module pre-load. This guarantees that
  1330. if someone does pre-load pbx_config - or other pbx modules - that
  1331. the Stasis caches for the various core components are created.
  1332. (closes issue ASTERISK-23320) Reported by: xrobau (closes issue
  1333. ASTERISK-23265) Reported by: Andrew Nagy Tested by: Andrew Nagy,
  1334. Rusty Newton
  1335. 2014-02-22 17:57 +0000 [r408839] Alexandr Anikin <may@telecom-service.ru>
  1336. * addons/chan_ooh323.c, /: ignore AST_CONTROL_PVT_CAUSE_CODE
  1337. without any messages (closes issue ASTERISK-23336) Reported by:
  1338. Alexander Semych ........ Merged revisions 408838 from
  1339. http://svn.asterisk.org/svn/asterisk/branches/11
  1340. 2014-02-22 02:29 +0000 [r408787] Corey Farrell <git@cfware.com>
  1341. * /, utils/extconf.c, utils/conf2ael.c, res/ael/pval.c, main/pbx.c:
  1342. Remove extra defines of AST_PBX_MAX_STACK. * Ensure
  1343. AST_PBX_MAX_STACK is only defined in extconf.h and pbx.h. * Fix
  1344. incorrect function parameters in utils/extconf.c. (closes issue
  1345. ASTERISK-23141) Reported by: Maxim Review:
  1346. https://reviewboard.asterisk.org/r/3241/ ........ Merged
  1347. revisions 408785 from
  1348. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1349. revisions 408786 from
  1350. http://svn.asterisk.org/svn/asterisk/branches/11
  1351. 2014-02-21 18:34 +0000 [r408730] Kevin Harwell <kharwell@digium.com>
  1352. * main/rtp_engine.c, /: rtp_engine: Dynamic payload change in rtp
  1353. mapping not supported Asterisk didn't support the dynamic payload
  1354. change in rtp mapping in the 200 OK response. Scenario: Asterisk
  1355. sends the INVITE proposing alaw and telephone-event, it proposes
  1356. rtpmap:101 for telephone-event. Peer responds with 2xx, it
  1357. answers with alaw and telephone-event also, but it proposes a
  1358. different rtpmap number (rtpmap:103) for telephone-event.
  1359. Expected Behaviour: Asterisk should honour the rtpmapping in the
  1360. response and send DTMF packets using 103 as payload type for
  1361. DTMF. Actual Behaviour: Asterisk sends DTMF packets using payload
  1362. type 101. With this patch asterisk now supports changes that can
  1363. occur in the rtp mapping in the response. (closes issue
  1364. ASTERISK-23279) Reported by: NITESH BANSAL Review:
  1365. https://reviewboard.asterisk.org/r/3225/ Patches:
  1366. dynamic_payload_change.patch uploaded by nbansal (license 6418)
  1367. ........ Merged revisions 408729 from
  1368. http://svn.asterisk.org/svn/asterisk/branches/11
  1369. 2014-02-21 18:17 +0000 [r408711-408715] Richard Mudgett <rmudgett@digium.com>
  1370. * main/manager.c: manager: Fix AMI Status action of a single
  1371. channel. Fixed use of uninitialized ao2 container iterator in an
  1372. off-nominal condition. Either a memory allocation error or the
  1373. requested channel is an internal channel not exposed to the
  1374. outside.
  1375. * res/res_stasis_recording.c, main/stasis_channels.c,
  1376. res/res_sorcery_astdb.c, include/asterisk/json.h, main/sorcery.c,
  1377. res/ari/resource_endpoints.c, apps/app_meetme.c, res/res_fax.c:
  1378. json: Fix off-nominal json ref counting issues. * Fixed
  1379. off-nominal json ref counting issue with using the following API
  1380. calls: ast_json_object_set() and ast_json_array_append(). * Fixed
  1381. off-nominal error reporting in ast_ari_endpoints_list(). * Fixed
  1382. some miscellaneous off-nominal json ref counting issues in
  1383. report_receive_fax_status() and dial_to_json().
  1384. * main/json.c: json: Fix json API wrapper code for json library
  1385. versions earlier than 2.3.0. * Fixed json ref counting issue with
  1386. json API wrapper code for ast_json_object_update_existing() and
  1387. ast_json_object_update_missing() when the json library is earlier
  1388. than version 2.3.0.
  1389. 2014-02-21 16:20 +0000 [r408644-408649] Kevin Harwell <kharwell@digium.com>
  1390. * main/rtp_engine.c, /: rtp_engine: Output mixup in
  1391. ${CHANNEL(rtpqos,audio,all)} Fixed the output of
  1392. CHANNEL(rtpqos,audio,all) to use txjitter instead of rxjitter.
  1393. (closes issue ASTERISK-23261) Reported by: rsw686 Patches:
  1394. rtpqos.patch uploaded by rsw686 (license 5887) ........ Merged
  1395. revisions 408646 from
  1396. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1397. revisions 408647 from
  1398. http://svn.asterisk.org/svn/asterisk/branches/11
  1399. * main/channel.c, /: channel.c: MOH is not working for transferee
  1400. after attended transfer Updated the code to check to see if MOH
  1401. is playing on the transferor and if so then start it on the
  1402. channel that replaces it during a masquerade. Example scenario of
  1403. the problem: Alice calls Bob and then Bob begins the attended
  1404. transfer process into a queue. Upon going on hold Alice hears
  1405. music and so does Bob once he is in the queue. Bob then transfers
  1406. Alice into the queue and then music for Alice stops even though
  1407. she should be hearing it since has now replaced Bob in the queue.
  1408. The problem that was occurring is that once the channel was
  1409. masqueraded the app (queues, confbridge, etc...) had no way of
  1410. knowing that the channel had just been swapped out thus it did
  1411. not start music for the present channel. Credit to Olle Johansson
  1412. for pointing me in the right direction on this issue. (closes
  1413. issue ASTERISK-19499) Reported by: Timo Teräs Review:
  1414. https://reviewboard.asterisk.org/r/3226/ ........ Merged
  1415. revisions 408642 from
  1416. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1417. revisions 408643 from
  1418. http://svn.asterisk.org/svn/asterisk/branches/11
  1419. 2014-02-21 10:42 +0000 [r408591] Alexandr Anikin <may@telecom-service.ru>
  1420. * /, addons/ooh323c/src/ooCalls.h: Fix type of roundTripDelay
  1421. variables ........ Merged revisions 408589 from
  1422. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1423. revisions 408590 from
  1424. http://svn.asterisk.org/svn/asterisk/branches/11
  1425. 2014-02-21 00:49 +0000 [r408538] Michael L. Young <elgueromexicano@gmail.com>
  1426. * /, apps/app_chanspy.c: app_chanspy: Documentation Update To
  1427. Clarify "x" Option When using the "x" option (specify a DTMF
  1428. digit to exit the application), it is not obvious in the
  1429. documentation that this only works when spying on a channel. If a
  1430. channel being used to spy on other channels is waiting to connect
  1431. to a channel or is no longer attached to a channel, the DTMF is
  1432. ignored. As noted on the issue tracker, since there are
  1433. workarounds available and this is a rarely used option we are
  1434. opting for a documentation change here. (closes issue
  1435. ASTERISK-22661) Reported by: Chris Hillman Patches:
  1436. asterisk-22661-doc-clarify-chan_spy.diff uploaded by Michael L.
  1437. Young (license 5026) Review:
  1438. https://reviewboard.asterisk.org/r/2990/ ........ Merged
  1439. revisions 408536 from
  1440. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1441. revisions 408537 from
  1442. http://svn.asterisk.org/svn/asterisk/branches/11
  1443. 2014-02-20 21:09 +0000 [r408518-408522] George Joseph <george.joseph@fairview5.com>
  1444. * res/res_pjsip/location.c, res/res_pjsip_outbound_registration.c:
  1445. pjsip_cli: Add pjsip commands 'show registrations' and 'show
  1446. contacts'. Added 'show registrations' and 'show contacts' to
  1447. pjsip cli to make things a little more consistent. The output is
  1448. exactly the same as the list command. Just needed to add entries
  1449. to their respective ast_cli_entry structures. (closes issue
  1450. ASTERISK-23275) Review: http://reviewboard.asterisk.org/r/3210/
  1451. * res/res_pjsip/pjsip_cli.c, main/config.c: pjsip_cli: Fix memory
  1452. leak in ast_sip_cli_print_sorcery_objectset. Fixed memory leaks
  1453. in ast_sip_cli_print_sorcery_objectset and
  1454. ast_variable_list_sort. (closes issue ASTERISK-23266) Review:
  1455. http://reviewboard.asterisk.org/r/3200/
  1456. * res/res_pjsip/include/res_pjsip_private.h, res/res_pjsip.c,
  1457. tests/test_sorcery.c, main/sorcery.c,
  1458. res/res_pjsip/config_system.c, include/asterisk/sorcery.h:
  1459. sorcery: Create sorcery instance registry. In order to retrieve
  1460. an arbitrary sorcery instance from a dialplan function (or any
  1461. place else) there needs to be a registry of sorcery instances.
  1462. ast_sorcery_init now creates a hashtab as a registry.
  1463. ast_sorcery_open now checks the hashtab for an existing sorcery
  1464. instance matching the caller's module name. If it finds one, it
  1465. bumps the refcount and returns it. If not, it creates a new
  1466. sorcery instance, adds it to the hashtab, then returns it.
  1467. ast_sorcery_retrieve_by_module_name is a new function that does a
  1468. hashtab lookup by module name. It can be called by the future
  1469. dialplan function. res_pjsip/config_system needed a small change
  1470. to share the main res_pjsip sorcery instance. tests/test_sorcery
  1471. was updated to include a test for the registry. (closes issue
  1472. ASTERISK-22537) Review: http://reviewboard.asterisk.org/r/3184/
  1473. 2014-02-20 19:02 +0000 [r408502] Matthew Jordan <mjordan@digium.com>
  1474. * res/res_pjsip.c: res_pjsip: Update documentation for 'use_avpf'
  1475. option When 'use_avpf' is set to True, inbound offers must use
  1476. the AVPF/SAVPF RTP profile. However, when 'use_avpf' is set to
  1477. False, Asterisk will accept both AVP/SAVP or AVPF/SAVPF RTP
  1478. profiles in inbound offers. The documentation previously implied
  1479. that Asterisk would reject AVPF/SAVPF if 'use_avpf' was set to
  1480. False and a UA offered said profile in an INVITE request.
  1481. 2014-02-20 02:43 +0000 [r408449] Rusty Newton <rnewton@digium.com>
  1482. * apps/app_queue.c, /: apps/app_queue - Fix incorrect Macro
  1483. parameter documentation Macro is executed on the called channel,
  1484. not the calling channel. (closes issue ASTERISK-23069) Reported
  1485. By: Bryan Anderson ........ Merged revisions 408447 from
  1486. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1487. revisions 408448 from
  1488. http://svn.asterisk.org/svn/asterisk/branches/11
  1489. 2014-02-19 19:07 +0000 [r408385-408389] Richard Mudgett <rmudgett@digium.com>
  1490. * /, main/config.c: config: Add file size and nanosecond resolution
  1491. fields to the cached modified config file information. Repeatedly
  1492. modifying config files and reloading too fast sometimes fails to
  1493. reload the configuration because the cached modification
  1494. timestamp has one second resolution. * Added file size and
  1495. nanosecond resolution fields to the cached config file
  1496. modification timestamp information. Now if the file size changes
  1497. or the file system supports nanosecond resolution the modified
  1498. file has a better chance of being detected for reload. * Added a
  1499. missing unlock in an off-nominal code path. (closes issue
  1500. AST-1303) Review: https://reviewboard.asterisk.org/r/3235/
  1501. ........ Merged revisions 408387 from
  1502. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1503. revisions 408388 from
  1504. http://svn.asterisk.org/svn/asterisk/branches/11
  1505. * res/res_sorcery_astdb.c: res_sorcery_astdb.c: Fix regex handling
  1506. and keep simple prefix matching performance. The sorcery astDB
  1507. wizzard does not handle regex correctly if the pattern begins
  1508. with an anchor character. This patch attempts to convert the
  1509. anchored regex pattern to a prefix pattern supported by astDB for
  1510. performance reasons. If it is not able to convert the pattern it
  1511. falls back to getting all astDB members of the family and doing a
  1512. normal regex pattern matching on the retrieved records. Review:
  1513. https://reviewboard.asterisk.org/r/3161/
  1514. 2014-02-19 12:00 +0000 [r408314-408331] Alexandr Anikin <may@telecom-service.ru>
  1515. * addons/ooh323c/src/ooCapability.c, /,
  1516. addons/ooh323c/src/ooh245.c: process receiveAndTransmit user
  1517. input remote caps instead of receive only send receiveAndTransmit
  1518. user input our caps instead of receive only ........ Merged
  1519. revisions 408328 from
  1520. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1521. revisions 408330 from
  1522. http://svn.asterisk.org/svn/asterisk/branches/11
  1523. * addons/ooh323c/src/ooh323.c, /: Allow different socket and
  1524. signalling ip on h.323 connection if gk mode is active Reported
  1525. by: Gabriele Odone Patches: ASTERISK-22738-1.patch Tested by:
  1526. Gabriele Odone (closes issue ASTERISK-22738) ........ Merged
  1527. revisions 408312 from
  1528. http://svn.asterisk.org/svn/asterisk/branches/11
  1529. 2014-02-18 19:18 +0000 [r408297] Richard Mudgett <rmudgett@digium.com>
  1530. * contrib/ast-db-manage/config/versions/21e526ad3040_add_pjsip_debug_option.py,
  1531. contrib/ast-db-manage/voicemail/versions/a2e9769475e_create_tables.py,
  1532. contrib/ast-db-manage/voicemail/versions, contrib/ast-db-manage,
  1533. contrib/ast-db-manage/config/env.py,
  1534. contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py,
  1535. contrib/ast-db-manage/config,
  1536. contrib/ast-db-manage/voicemail/env.py,
  1537. contrib/ast-db-manage/voicemail,
  1538. contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py,
  1539. contrib/ast-db-manage/config/versions: alembic: Add svn:ignore
  1540. *.pyc to directories and svn:executable to *.py files.
  1541. 2014-02-17 15:21 +0000 [r408270] Mark Michelson <mmichelson@digium.com>
  1542. * res/res_pjsip/location.c, UPGRADE.txt, res/res_pjsip.c,
  1543. res/res_pjsip_registrar.c, include/asterisk/res_pjsip.h: Store
  1544. SIP User-Agent information in contacts. When an endpoint sends a
  1545. REGISTER request to Asterisk, we now will associate the
  1546. User-Agent header with all contacts that were bound in that
  1547. REGISTER request.
  1548. 2014-02-16 03:23 +0000 [r408194-408220] Matthew Jordan <mjordan@digium.com>
  1549. * main/pbx.c, /: pbx: Handle a completely empty dialplan during a
  1550. context merge It is highly unlikely, but - at least in Asterisk
  1551. 12 - theoretically possible to load Asterisk with no dialplan
  1552. whatsoever. If that occurs, and some other module (that is not a
  1553. pbx module) attempts to merge its contexts into the dialplan, the
  1554. existing merge routine will crash. This is because it is not
  1555. insane, and rightly believes that you provided some sort of
  1556. dialplan, somewhere. This patch will gracefully merge the
  1557. contexts in such a case. Note that this is highly unlikely to
  1558. occur in 1.8/11, as features will most likely provide some
  1559. dialplan via parking. However, in Asterisk 12, parking is now
  1560. provided by res_parking, and hence may create its dialplan later.
  1561. (closes issue ASTERISK-23297) Reported by: CJ Oster Review:
  1562. https://reviewboard.asterisk.org/r/3222 ........ Merged revisions
  1563. 408200 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  1564. ........ Merged revisions 408201 from
  1565. http://svn.asterisk.org/svn/asterisk/branches/11
  1566. * Makefile, /: buildsystem: Unbreak the build (infloop) on Asterisk
  1567. 11+ Apparently r408084 ( https://reviewboard.asterisk.org/r/3212/
  1568. ) broke the build. This patch fixes it by ignoring the .lastclean
  1569. dependencies if the MENUSELECT_EMBED variable is not defined.
  1570. patches: tmp.diff uploaded by wdoekes (License 5674) Review:
  1571. https://reviewboard.asterisk.org/r/3228/ ........ Merged
  1572. revisions 408193 from
  1573. http://svn.asterisk.org/svn/asterisk/branches/11
  1574. 2014-02-14 21:44 +0000 [r408138-408140] Scott Griepentrog <sgriepentrog@digium.com>
  1575. * main/stasis_endpoints.c: ARI: correct upper/lower case URI
  1576. discrepancies URI's are supposed to be case sensitive and all
  1577. lower case. In practice some portions of URI's in ARI are case
  1578. insensitive and others are not, such as TECH, which in one
  1579. instance would match a lower case name and in another would not.
  1580. In this patch, the ast_endpoint_lastest_snapshot() function is
  1581. modified to change the TECH portion to full upper case before
  1582. lookup. This resolves the discrepancy noted by the reporter.
  1583. However I chose to avoid forcing the /ari prefix of the URI's to
  1584. be lower case for now. Except for the two cases here, all URI's
  1585. should be lower case, unless they are part of a resource name or
  1586. id. Review: https://reviewboard.asterisk.org/r/3211/ Reported by:
  1587. Zane Conkle (closes issue ASTERISK-23125)
  1588. * main/format.c, /: format.c: correct possible null pointer
  1589. dereference In ast_format_sdp_parse and ast_format_sdp_generate
  1590. the check checks for a valid interface and function were
  1591. potentially confusing, and hid an error in the test of the
  1592. presence of the function that is called later. This patch clears
  1593. up and corrects the test. Review:
  1594. https://reviewboard.asterisk.org/r/3208/ (closes issue
  1595. ASTERISK-23098) Reported by: marcelloceschia Patches:
  1596. main_format.patch uploaded by marcelloceschia (license 6036)
  1597. ASTERISK-23098.patch uploaded by coreyfarrell (license 5909)
  1598. ........ Merged revisions 408137 from
  1599. http://svn.asterisk.org/svn/asterisk/branches/11
  1600. 2014-02-14 13:29 +0000 [r408085] Walter Doekes <walter+asterisk@wjd.nu>
  1601. * Makefile, /: buildsystem: Don't force main to depend on
  1602. everything else. Directory 'main' only needs to depend on
  1603. embedded modules. If no module embedding is selected, the
  1604. dependency is dropped. Review:
  1605. https://reviewboard.asterisk.org/r/3212/ ........ Merged
  1606. revisions 408083 from
  1607. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1608. revisions 408084 from
  1609. http://svn.asterisk.org/svn/asterisk/branches/11
  1610. 2014-02-14 12:39 +0000 [r408069] Matthew Jordan <mjordan@digium.com>
  1611. * channels/chan_sip.c: chnan_sip: Set SIP_DEFER_BYE_ON_TRANSFER
  1612. prior to calling bridge blind transfer This patch moves setting
  1613. SIP_DEFER_BY_ON_TRANSFER prior to calling
  1614. ast_bridge_transfer_blind. This prevents a BYE from being sent
  1615. prior to the NOTIFY request that informs the transferor if the
  1616. transfer succeeded or failed. This patch also clears said flag
  1617. from the off nominal NOTIFY paths in the local_attended_transfer
  1618. code, as once we've sent the NOTIFY request it is safe to send by
  1619. the BYE request. This was caught by the
  1620. blind-transfer-accountcode test in the Asterisk Test Suite.
  1621. (closes issue ASTERISK-23290) Reported by: Matt Jordan Review:
  1622. https://reviewboard.asterisk.org/r/3214/
  1623. 2014-02-13 18:50 +0000 [r407988-408005] Mark Michelson <mmichelson@digium.com>
  1624. * res/res_pjsip_mwi.c, res/res_pjsip_pubsub.c: Remove all PJSIP
  1625. MWI-specific use from our MWI code. PJSIP has built-in MWI code
  1626. that could be useful to some degree, but our utilization of the
  1627. API actually made our code a bit more cluttered since we had to
  1628. have special cases peppered throughout. With this change, we move
  1629. to using the pjsip_evsub API instead, which streamlines the code
  1630. by removing special cases. Review:
  1631. https://reviewboard.asterisk.org/r/3205
  1632. * res/res_pjsip/location.c: Fix crash in AMI PJSIPShowEndpoint
  1633. action. If an AOR has no permanent contacts, then the
  1634. permanent_contacts container is never allocated. This makes the
  1635. code safe in the face of NULLs. I also changed the variable that
  1636. counts contacts from "num" to "total_contacts" since there are
  1637. now two variables that are indicate numbers of things.
  1638. 2014-02-12 08:18 +0000 [r407968] Walter Doekes <walter+asterisk@wjd.nu>
  1639. * main/config.c: realtime: Fix ast_update2_realtime() on raspberry
  1640. pi. The old code depended on undefined va_arg behaviour: calling
  1641. a function twice with the same va_list parameter and expecting it
  1642. to continue where it left off. The changed code behaves like the
  1643. manpage says it should. Also added a bunch of early returns to
  1644. trap errors (e.g. OOM) instead of crashing. The problem was found
  1645. by Julian Lyndon-Smith. The deviant behaviour on the raspberry PI
  1646. also uncovered another bug (fixed in r407875) in the
  1647. res_config_pgsql.so driver. Reported by: jmls Tested by: jmls
  1648. Review: https://reviewboard.asterisk.org/r/3201/
  1649. 2014-02-11 03:16 +0000 [r407937] Matthew Jordan <mjordan@digium.com>
  1650. * res/ari/resource_channels.c: ari/resource_channels: Add channel
  1651. variables earlier in the creation process This patch tweaks the
  1652. behaviour of POST /channels with channel variables such that the
  1653. variables are passed into the pbx.c routines that perform the
  1654. origination. This allows the variables to be assigned to the
  1655. newly created channels immediately upon their construction, as
  1656. opposed to be assigned after the originate has completed. The
  1657. upshot of this is that the variables are available on the
  1658. channels if they execute in the dialplan, as opposed to only
  1659. being available once the channels are answered. Review:
  1660. https://reviewboard.asterisk.org/r/3183/
  1661. 2014-02-10 16:43 +0000 [r407875] Walter Doekes <walter+asterisk@wjd.nu>
  1662. * res/res_config_pgsql.c, /: res_config_pgsql: Fix
  1663. ast_update2_realtime calls. Fix so multiple updates from a single
  1664. call works (add missing ','). Remove bogus ast_free's that
  1665. weren't supposed to be there. Moved a few spaces for readability.
  1666. Review: https://reviewboard.asterisk.org/r/3194/ ........ Merged
  1667. revisions 407873 from
  1668. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1669. revisions 407874 from
  1670. http://svn.asterisk.org/svn/asterisk/branches/11
  1671. 2014-02-10 15:54 +0000 [r407858] Kinsey Moore <kmoore@digium.com>
  1672. * apps/confbridge/conf_state_multi_marked.c,
  1673. apps/confbridge/conf_state_empty.c,
  1674. apps/confbridge/conf_config_parser.c,
  1675. configs/confbridge.conf.sample, /,
  1676. apps/confbridge/include/confbridge.h, UPGRADE.txt,
  1677. apps/app_confbridge.c: ConfBridge: Correct prompt playback target
  1678. Currently, when the first marked user enters the conference that
  1679. contains waitmarked users, a prompt is played indicating that the
  1680. user is being placed into the conference. Unfortunately, this
  1681. prompt is played to the marked user and not the waitmarked users
  1682. which is not very helpful. This patch changes that behavior to
  1683. play a prompt stating "The conference will now begin" to the
  1684. entire conference after adding and unmuting the waitmarked users
  1685. since the design of confbridge is not conducive to playing a
  1686. prompt to a subset of users in a conference in an asynchronous
  1687. manner. (closes issue PQ-1396) Review:
  1688. https://reviewboard.asterisk.org/r/3155/ Reported by: Steve Pitts
  1689. ........ Merged revisions 407857 from
  1690. http://svn.asterisk.org/svn/asterisk/branches/11
  1691. 2014-02-07 20:48 +0000 [r407766] Richard Mudgett <rmudgett@digium.com>
  1692. * /, channels/chan_iax2.c: chan_iax2: Add some more iaxs[] NULL
  1693. checks to a routine already full of them. ........ Merged
  1694. revisions 407764 from
  1695. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1696. revisions 407765 from
  1697. http://svn.asterisk.org/svn/asterisk/branches/11
  1698. 2014-02-07 20:09 +0000 [r407747-407750] Matthew Jordan <mjordan@digium.com>
  1699. * main/security_events.c: security_events: Fix assertion failure in
  1700. dev-mode on optional IE parsing When formatting an optional IE,
  1701. the value is, of course, optional. As such, it is entirely
  1702. appropriate for ast_json_object_get to return NULL. If that
  1703. occurs, we now simply skip the IE that was requested, as it was
  1704. not provided by the entity that raised the event. Thanks to
  1705. George Joseph (gtjoseph) for catching this and reporting it in
  1706. #asterisk-dev
  1707. * funcs/func_cdr.c: funcs/func_cdr: Handle empty time values when
  1708. extracting parsed values When extracting timestamps that are
  1709. parsed, time stamp values that are not set (time values of
  1710. 0.000000) should not actually result in a parsed string. The
  1711. value should be skipped, and the result of the CDR function
  1712. should be an empty string. Prior to this patch, the result was
  1713. fed to the time formatting, which would result in an output of a
  1714. date/time in 1969.
  1715. 2014-02-07 18:18 +0000 [r407729] Richard Mudgett <rmudgett@digium.com>
  1716. * configs/iax.conf.sample, /, channels/chan_iax2.c,
  1717. include/asterisk/frame.h: chan_iax2: Block unnecessary control
  1718. frames to/from the wire. Establishing an IAX2 call between
  1719. Asterisk v1.4 and v1.8 (or later) results in an unexpected call
  1720. disconnect. The problem happens because newer values in the enum
  1721. ast_control_frame_type are not consistent between the branch
  1722. versions of Asterisk. For example: 1) v1.4 calls v1.8 (or later)
  1723. using IAX2 2) v1.8 answers and sends a connected line update
  1724. control frame. (on v1.8 AST_CONTROL_CONNECTED_LINE = 22) 3) v1.4
  1725. receives the control frame as an end-of-q (on v1.4
  1726. AST_CONTROL_END_OF_Q = 22) 4) v1.4 disconnects the call once the
  1727. receive queue becomes empty. Several things are done by this
  1728. patch to fix the problem and attempt to prevent it from happening
  1729. again in the future: * Added a warning at the definition of enum
  1730. ast_control_frame_type about how to add new control frame values.
  1731. * Made block sending and receiving control frames that have no
  1732. reason to go over the wire. * Extended the connectedline iax.conf
  1733. parameter to also include the redirecting information updates. *
  1734. Updated the connectedline iax.conf parameter documentation to
  1735. include a notice that the parameter must be "no" when the peer is
  1736. an Asterisk v1.4 instance. (closes issue AST-1302) Review:
  1737. https://reviewboard.asterisk.org/r/3174/ ........ Merged
  1738. revisions 407678 from
  1739. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1740. revisions 407727 from
  1741. http://svn.asterisk.org/svn/asterisk/branches/11
  1742. 2014-02-07 16:46 +0000 [r407676] Matthew Jordan <mjordan@digium.com>
  1743. * main/security_events.c: security_events: Fix error caused by DTD
  1744. validation error The appdocsxml.dtd specifies that a "required"
  1745. attribute in a parameter may have a value of yes, no, true, or
  1746. false. On some systems, specifying "False" instead of "false"
  1747. would cause a validation error. This patch fixes the casing to
  1748. explicitly match the DTD.
  1749. 2014-02-07 13:13 +0000 [r407624] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  1750. * /, configs/indications.conf.sample: indications.conf: add stutter
  1751. tone; end properly * If the "stutter" (voicemail indication) tone
  1752. is indeed a stutter tone, and it ends with a constant tone, make
  1753. sure that it is the dial tone. This was done for India (in),
  1754. Mexico (mx) and the Philippines (ph). * If no "stutter" tone
  1755. exists for a country, provide one. This was done for Spain (es),
  1756. Malaysia (my) and Venezuela (ve). Review:
  1757. https://reviewboard.asterisk.org/r/3158/ ........ Merged
  1758. revisions 407622 from
  1759. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1760. revisions 407623 from
  1761. http://svn.asterisk.org/svn/asterisk/branches/11
  1762. 2014-03-03 Asterisk Development Team <asteriskteam@digium.com>
  1763. * Asterisk 12.1.0 Released.
  1764. 2014-03-01 Asterisk Development Team <asteriskteam@digium.com>
  1765. * Asterisk 12.1.0-rc3 Released.
  1766. * chan_sip: Fix crash in ast_channel_hangupcause_set().
  1767. Fix crash in ast_channel_hangupcause_set() because p->owner not
  1768. checked before calling. Regression introduced by the fix for
  1769. ASTERISK-22621.
  1770. (closes issue ASTERISK-23135)
  1771. Reported by: OK
  1772. (issue ASTERISK-23323)
  1773. Reported by: Walter Doekes
  1774. 2013-02-27 Asterisk Development Team <asteriskteam@digium.com>
  1775. * Asterisk 12.1.0-rc2 Released.
  1776. * res_rtp_asterisk: Fix checklist creating problems in ICE sessions
  1777. Prior to this patch, local candidate lists including SRFLX would
  1778. fail to start properly when building ICE candidate check lists. This
  1779. patch fixes that problem by making sure that each SRFLX candidate is
  1780. associated with the proper base address so that the check list can
  1781. create matches properly.
  1782. This patch was written by jcolp. The issue will be left open to await
  1783. testing by the issue participants.
  1784. (issue ASTERISK-23213)
  1785. Reported by: Andrea Suisani
  1786. Review: https://reviewboard.asterisk.org/r/3256/
  1787. * res_fax: Warn that minrate=2400 is not valid for V.27 instead of
  1788. failing load.
  1789. Change minrate from 2400 to 4800 on config reload in response to
  1790. changes from ASTERISK-22790 only. Any config with minrate of
  1791. 2400 that would fail before r405693 will still fail.
  1792. Comment out many settings in res_fax.conf.sample. The defaults are
  1793. set in res_fax.c, so setting the same value in sample config does
  1794. nothing but make the sample config more fragile.
  1795. (closes issue ASTERISK-23231)
  1796. Reported by: David Brillert
  1797. Review: https://reviewboard.asterisk.org/r/3261/
  1798. * main: Initialize dialplan providing core components prior to module
  1799. pre-load
  1800. It is possible to pre-load pbx_config. As a result, pbx_config -
  1801. which will load and parse the dialplan - will attempt to use various
  1802. dialplan components, such as device state providers and presence
  1803. state providers, prior to them being initialized by the core. This
  1804. would lead to a crash, as the components had not created their Stasis
  1805. cache entries.
  1806. This patch moves a number of core component initializations before
  1807. the module pre-load. This guarantees that if someone does pre-load
  1808. pbx_config - or other pbx modules - that the Stasis caches for the
  1809. various core components are created.
  1810. (closes issue ASTERISK-23320)
  1811. Reported by: xrobau
  1812. (closes issue ASTERISK-23265)
  1813. Reported by: Andrew Nagy
  1814. Tested by: Andrew Nagy, Rusty Newton
  1815. * ari/resource_channels: Add channel variables earlier in the creation
  1816. process
  1817. This patch tweaks the behaviour of POST /channels with channel
  1818. variables such that the variables are passed into the pbx.c routines
  1819. that perform the origination. This allows the variables to be
  1820. assigned to the newly created channels immediately upon their
  1821. construction, as opposed to be assigned after the originate has
  1822. completed.
  1823. The upshot of this is that the variables are available on the
  1824. channels if they execute in the dialplan, as opposed to only being
  1825. available once the channels are answered.
  1826. * security_events: Fix assertion failure in dev-mode on optional IE
  1827. parsing
  1828. When formatting an optional IE, the value is, of course, optional. As
  1829. such, it is entirely appropriate for ast_json_object_get to return
  1830. NULL. If that occurs, we now simply skip the IE that was requested,
  1831. as it was not provided by the entity that raised the event.
  1832. Thanks to George Joseph (gtjoseph) for catching this and reporting it
  1833. in #asterisk-dev
  1834. * funcs/func_cdr: Handle empty time values when extracting parsed
  1835. values
  1836. When extracting timestamps that are parsed, time stamp values that
  1837. are not set (time values of 0.000000) should not actually result in
  1838. a parsed string. The value should be skipped, and the result of the
  1839. CDR function should be an empty string.
  1840. Prior to this patch, the result was fed to the time formatting, which
  1841. would result in an output of a date/time in 1969.
  1842. * security_events: Fix error caused by DTD validation error
  1843. The appdocsxml.dtd specifies that a "required" attribute in a
  1844. parameter may have a value of yes, no, true, or false. On some
  1845. systems, specifying "False" instead of "false" would cause a
  1846. validation error. This patch fixes the casing to explicitly match
  1847. the DTD.
  1848. 2013-02-06 Asterisk Development Team <asteriskteam@digium.com>
  1849. * Asterisk 12.1.0-rc1 Released.
  1850. 2014-02-06 20:06 +0000 [r407589] Matthew Jordan <mjordan@digium.com>
  1851. * main/security_events.c, UPGRADE.txt, CHANGES: security_events:
  1852. Add AMI documentation; output optional fields This patch adds
  1853. documentation for the Security Events that are emited over AMI.
  1854. It also notes these events in the UPGRADE/CHANGES file.
  1855. 2014-02-06 19:57 +0000 [r407587] Rusty Newton <rnewton@digium.com>
  1856. * configs/pjsip.conf.sample: configs/pjsip.conf.sample:
  1857. Configuration section naming in pjsip.conf.sample needs a little
  1858. clarification There is a bit of nuance to how you name things in
  1859. pjsip.conf. This is a documentation patch to at least clear it up
  1860. a little for users. Review:
  1861. https://reviewboard.asterisk.org/r/3180/
  1862. 2014-02-06 17:54 +0000 [r407572] Kevin Harwell <kharwell@digium.com>
  1863. * contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py:
  1864. pjsip realtime: already created enum failure for postgresql If an
  1865. enum had been previously created the alembic script would attempt
  1866. to re-create it and an error would be generated while running
  1867. migrations for a postgresql server. The work around for this is
  1868. to use the ENUM object type for postgres as opposed to the
  1869. generic enum type used by sqlalchemy. Using this type in the
  1870. script seems to work properly for both postgres and mysql.
  1871. 2014-02-06 17:06 +0000 [r407568] Richard Mudgett <rmudgett@digium.com>
  1872. * res/res_pjsip_logger.c,
  1873. res/res_pjsip/include/res_pjsip_private.h,
  1874. res/res_pjsip/pjsip_options.c, res/res_pjsip/config_transport.c,
  1875. include/asterisk/res_pjsip.h, res/res_pjsip/config_global.c,
  1876. res/res_pjsip/config_auth.c, res/res_pjsip/location.c,
  1877. res/res_pjsip_outbound_registration.c,
  1878. res/res_pjsip_endpoint_identifier_ip.c,
  1879. include/asterisk/res_pjsip_cli.h, res/res_pjsip/pjsip_cli.c,
  1880. res/res_pjsip/pjsip_configuration.c,
  1881. res/res_pjsip/config_domain_aliases.c: res_pjsip: Updates and
  1882. adds more PJSIP CLI commands. * Adds identify, transport, and
  1883. registration support to the PJSIP CLI. * Creates three additional
  1884. callbacks, one for an iterator, one for a comparator, and one for
  1885. a container. This eliminates the link dependency from higher
  1886. level modules to lower level ones. * Eliminates duplicate sorting
  1887. in PJSIP CLI commands. * Cleans up PJSIP CLI output formatting. *
  1888. Pushes CLI command registration down to the implementing source
  1889. file. * Adds several ast_sip_destroy_sorcery functions to
  1890. complement existing ast_sip_sorcery_initialize functions. The
  1891. destroy functions unregister PJSIP CLI commands and PJSIP CLI
  1892. formatters. Reported by: George Joseph Review:
  1893. https://reviewboard.asterisk.org/r/3104/
  1894. 2014-02-06 16:53 +0000 [r407567] Mark Michelson <mmichelson@digium.com>
  1895. * contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py:
  1896. Fix alembic script to work properly in offline mode. When run in
  1897. offline mode, this would attempt to check the database for the
  1898. presence of a type it was going to try to create. I now check the
  1899. context to see if we're running in offline mode and change a
  1900. parameter accordingly.
  1901. 2014-02-05 23:03 +0000 [r407513] Rusty Newton <rnewton@digium.com>
  1902. * /, formats/format_wav.c: formats/format_wav: enhancing log
  1903. message "Not a wav file" to be clear on what is supported
  1904. Modifying the log message to be more specific as to what is
  1905. supported. Specifically it seems format_wav supports only PCM
  1906. encoded versions with a lower-case '.wav' extension. (closes
  1907. issues ASTERISK-22310) Reported by: Jim Credland Review:
  1908. https://reviewboard.asterisk.org/r/3188/ ........ Merged
  1909. revisions 407511 from
  1910. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1911. revisions 407512 from
  1912. http://svn.asterisk.org/svn/asterisk/branches/11
  1913. 2014-02-05 20:55 +0000 [r407461] Jonathan Rose <jrose@digium.com>
  1914. * CHANGES: CHANGES: Improved description of Name/Creator changes to
  1915. bridge ARI, adds AMI The changes log was written with language
  1916. that was a little too internal Asterisk specific, so it's been
  1917. changed to be more in the frame of reference of an ARI user.
  1918. Also, previously the AMI event changes were omitted from the
  1919. change log as well as the ability to include a bridge name in the
  1920. ARI post bridges command.
  1921. 2014-02-05 20:43 +0000 [r407458] Kinsey Moore <kmoore@digium.com>
  1922. * main/logger.c, /: Logger: Fix handling of absolute paths This
  1923. fixes path handling for log files so that an extra / is not
  1924. appended to the file path when the path is absolute (begins with
  1925. /). This would previously result in different but functionally
  1926. equivalent paths in the output of 'logger show channels'.
  1927. ........ Merged revisions 407455 from
  1928. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1929. revisions 407456 from
  1930. http://svn.asterisk.org/svn/asterisk/branches/11
  1931. 2014-02-05 19:41 +0000 [r407442] Kevin Harwell <kharwell@digium.com>
  1932. * res/res_pjsip/config_global.c: res_pjsip: When no global type the
  1933. debug option defaults to "yes" If the global section was not
  1934. specified in pjsip.conf then the configuration object does not
  1935. exist in sorcery so when retrieving "debug" option it would
  1936. return NULL. Then the NULL result was passed to ast_false utils
  1937. function which would return false because it wasn't set to some
  1938. representation of false, thus enabling sip debug logging. Made it
  1939. so if the global config object does not exist then it will return
  1940. a default of "no" for sip debugging. (issue ASTERISK-23038)
  1941. Reported by: Rusty Newton
  1942. 2014-02-05 17:27 +0000 [r407423] Kinsey Moore <kmoore@digium.com>
  1943. * UPGRADE.txt: UPGRADE: Note change in behavior for device state
  1944. subscriptions
  1945. 2014-02-05 17:12 +0000 [r407419] Jonathan Rose <jrose@digium.com>
  1946. * CHANGES: CHANGES: Update changes log to include new bridge fields
  1947. added in r404042
  1948. 2014-02-05 14:22 +0000 [r407389-407402] Matthew Jordan <mjordan@digium.com>
  1949. * UPGRADE.txt, rest-api/api-docs/channels.json,
  1950. rest-api/api-docs/sounds.json, rest-api/resources.json, CHANGES,
  1951. include/asterisk/manager.h, rest-api/api-docs/bridges.json,
  1952. rest-api/api-docs/recordings.json,
  1953. rest-api/api-docs/deviceStates.json,
  1954. rest-api/api-docs/endpoints.json,
  1955. rest-api/api-docs/mailboxes.json, rest-api/api-docs/events.json,
  1956. rest-api/api-docs/asterisk.json,
  1957. rest-api/api-docs/applications.json,
  1958. rest-api/api-docs/playbacks.json: ARI/AMI: Update versions;
  1959. update UPGRADE/CHANGES notes for 12.1.0 changes Due to backwards
  1960. compatible changes made to AMI/ARI, the version needs to be
  1961. bumped to 1.1.0/2.1.0, respectively.
  1962. * rest-api-templates/api.wiki.mustache,
  1963. rest-api-templates/swagger_model.py: api.wiki.mustache: Update
  1964. wiki template to support body parameters This patch updates the
  1965. api.wiki.mustache template and the swagger_model python script to
  1966. understand if an operation has a body parameter. If an operation
  1967. does have a body parameter, it will now be displayed in the
  1968. corresponding wiki entry.
  1969. 2014-02-04 20:08 +0000 [r407274-407339] Richard Mudgett <rmudgett@digium.com>
  1970. * include/asterisk/devicestate.h, /, main/devicestate.c:
  1971. devicestate: Make ast_devstate_changed_literal() return value and
  1972. doxygen consistent. Nothing actually cares about the value
  1973. anyway. (closes issue ASTERISK-23178) Reported by: Jonathan Rose
  1974. ........ Merged revisions 407337 from
  1975. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1976. revisions 407338 from
  1977. http://svn.asterisk.org/svn/asterisk/branches/11
  1978. * res/res_pjsip/pjsip_configuration.c: res_pjsip: Fix assertion for
  1979. pjsip.conf authorization list options. (closes issue
  1980. ASTERISK-23168) Reported by: George Joseph Review:
  1981. https://reviewboard.asterisk.org/r/3143/
  1982. * configs/sip.conf.sample, main/tcptls.c, /: tcptls.c: Made TLS
  1983. handle a certificate chain file. Thanks to Guillaume Martres for
  1984. doing the necessary research to validate the change. (closes
  1985. issue ASTERISK-17727) Reported by: LN Patches:
  1986. use_certificate_chain.patch (license #5864) patch uploaded by st
  1987. documente_certificate_chain.patch (license #6576) patch uploaded
  1988. by Guillaume Martres ........ Merged revisions 407272 from
  1989. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1990. revisions 407273 from
  1991. http://svn.asterisk.org/svn/asterisk/branches/11
  1992. 2014-02-04 16:54 +0000 [r407259] Matthew Jordan <mjordan@digium.com>
  1993. * funcs/func_cdr.c: funcs/func_cdr: Fix non-epoch timestamps broken
  1994. by improper char array deref Thanks to snuffy for pointing this
  1995. issue out and fixing it. (closes issue ASTERISK-23250) Reported
  1996. by: snuffy patches: func_cdr-fix.diff uploaded by snuffy (License
  1997. 5024)
  1998. 2014-02-04 02:21 +0000 [r407213] Joshua Colp <jcolp@digium.com>
  1999. * /, res/res_clialiases.c: res_clialiases: Fix crash when reloading
  2000. and re-aliasing an alias that is in use. The code assumed that
  2001. unregistering the alias would always succeed while in practice
  2002. this is not actually true. A common case is the "reload" command
  2003. itself. If the cli_aliases.conf configuration file was changed
  2004. and reload executed the command would fail to unregister and
  2005. ultimately point to freed memory. The reload process now checks
  2006. whether unregistering succeeded or not and if not the old CLI
  2007. alias is retained. (closes issue ASTERISK-19773) Reported by:
  2008. Joel Vandal (closes issue ASTERISK-22757) Reported by: Gareth
  2009. Blades ........ Merged revisions 407205 from
  2010. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2011. revisions 407210 from
  2012. http://svn.asterisk.org/svn/asterisk/branches/11
  2013. 2014-02-04 02:04 +0000 [r407197] Damien Wedhorn <voip@facts.com.au>
  2014. * channels/chan_skinny.c: Skinny - Fix deadlock when pickup of no
  2015. call. Locking issues in skinny when picking up a call that
  2016. doesn't exist. Cleaned up sub locking by fully removing and using
  2017. the chan lock instead. Also changed ast_call_pickup to check
  2018. whether chan was masq'd. (closes issue ASTERISK-23249) Reported
  2019. by: wedhorn Tested by: snuffy, myself Patches:
  2020. skinny-locking01.diff uploaded by wedhorn (license 5019)
  2021. 2014-02-03 01:14 +0000 [r407166] Matthew Jordan <mjordan@digium.com>
  2022. * main/cdr.c: cdrs: Check for applications to lock onto during dial
  2023. begin handling This patch brings CDR processing further in line
  2024. with r407085. During some dial operations, the application would
  2025. not be locked to the Dial application and would instead continue
  2026. to show the previously known application. In particular, this
  2027. would occur when a Parked call would time out. This was due to a
  2028. previous snapshot already locking the application to Park -
  2029. processing this in a Dial Begin allows the Dial application to
  2030. reassert its rightful place. (CDRs. Ugh.) But hooray for the
  2031. Parked Call tests for catching this in the Asterisk Test Suite.
  2032. 2014-02-01 16:23 +0000 [r407153] Joshua Colp <jcolp@digium.com>
  2033. * res/ari/ari_model_validators.c, res/res_stasis.c,
  2034. main/stasis_bridges.c, res/ari/ari_model_validators.h,
  2035. rest-api/api-docs/events.json, res/stasis/app.c: res_stasis:
  2036. Enable transfers and provide events when they occur. This change
  2037. enables transfers within ARI created bridges and adds events for
  2038. when they occur. Unlike other events these will be received if
  2039. *any* subscribed object is involved in the transfer. (closes
  2040. issue ASTERISK-22984) Reported by: David M. Lee Review:
  2041. https://reviewboard.asterisk.org/r/3120/
  2042. 2014-02-01 00:24 +0000 [r407104] coreyfarrell <coreyfarrell@localhost>:
  2043. * /, apps/app_stack.c: app_stack: protect against missing
  2044. parameters to STACK_PEEK and LOCAL_PEEK STACK_PEEK requires 2
  2045. parameters and LOCAL_PEEK requires 1 parameter. This protects
  2046. against situations where those parameters are blank or missing by
  2047. logging an error and returning. (closes issue ASTERISK-23220)
  2048. Reported by: James Sharp ........ Merged revisions 407100 from
  2049. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2050. revisions 407103 from
  2051. http://svn.asterisk.org/svn/asterisk/branches/11
  2052. 2014-01-31 23:40 +0000 [r407082-407084] Matthew Jordan <mjordan@digium.com>
  2053. * main/manager_channels.c, apps/app_dial.c, main/cdr.c, main/pbx.c,
  2054. main/bridge_after.c, UPGRADE.txt: CDRs: fix a variety of dial
  2055. status problems, h/hangup handler creating CDRs This patch fixes
  2056. a number of small-ish problems that were noticed when witnessing
  2057. the records that the FreePBX dialplan produces: (1) Mid-call
  2058. events (as well as privacy options) have the ability to change
  2059. the overall state of the Dial operation after the called party
  2060. answers. This means that publishing the DialEnd event when the
  2061. called party is premature; we have to wait for the execution of
  2062. these subroutines to complete before we can signal the overall
  2063. status of the DialEnd. This patch moves that publication and adds
  2064. handlers for the mid-call events. (2) The AST_FLAG_OUTGOING
  2065. channel flag is cleared if an after bridge goto datastore is
  2066. detected. This flag was preventing CDRs from being recorded for
  2067. all outbound channels that had a 'continue' option enabled on
  2068. them by the Dial application. (3) The CDR engine now locks the
  2069. 'Dial' application as being the CDR application if it detects
  2070. that the current CDR has entered that app. This is similar to the
  2071. logic that is done for Parking. In general, if we entered into
  2072. Dial, then we want that CDR to record the application as such -
  2073. this prevents pre-dial handlers, mid-call handlers, and other
  2074. shenaniganry from changing the application value. (4) The CDR
  2075. engine now checks for the AST_SOFTHANGUP_HANGUP_EXEC in more
  2076. places to determine if the channel is in hangup logic or dead. In
  2077. either case, we don't want to record changes in the channel. (5)
  2078. The default option for "endbeforehexten" has been changed to
  2079. "yes". In general, you don't want to see CDRs in the 'h' exten or
  2080. in hangup logic. Since the semantics of that option changed in
  2081. 12, it made sense to update the default value as well. (6)
  2082. Finally, because we now have the ability to synchronize on the
  2083. messages published to the CDR topic, on shutdown the CDR engine
  2084. will now synchronize to the messages currently in flight. This
  2085. helps to ensure that all in-flight CDRs are written before
  2086. shutting down. (closes issue ASTERISK-23164) Reported by: Matt
  2087. Jordan Review: https://reviewboard.asterisk.org/r/3154
  2088. * apps/app_dial.c, /: app_dial: Allow macro/gosub pre-bridge
  2089. execution to occur on priorities The parsing for the destination
  2090. of the macro/gosub uses the '^' character to separate out
  2091. context, extension, and priority. However, the logic for the
  2092. macro/gosub execution was written such that it would only do the
  2093. actual macro/gosub jump if a '^' character existed. This doesn't
  2094. apply when the macro/gosub jump occurs in a priority/priority
  2095. label. This patch changes the logic so that the parsing still
  2096. occurs, but the jump will occur even for priorities/priority
  2097. labels. (issue ASTERISK-23164) Review:
  2098. https://reviewboard.asterisk.org/r/3154 ........ Merged revisions
  2099. 407041 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  2100. ........ Merged revisions 407074 from
  2101. http://svn.asterisk.org/svn/asterisk/branches/11
  2102. 2014-01-31 23:14 +0000 [r407034-407036] Kevin Harwell <kharwell@digium.com>
  2103. * contrib/ast-db-manage/config/versions/21e526ad3040_add_pjsip_debug_option.py
  2104. (added), configs/pjsip.conf.sample, UPGRADE.txt,
  2105. res/res_pjsip_logger.c, CHANGES, res/res_pjsip.c,
  2106. include/asterisk/res_pjsip.h, res/res_pjsip/config_global.c:
  2107. res_pjsip: Config option to enable PJSIP logger at load time.
  2108. Added a "debug" configuration option for res_pjsip that when set
  2109. to "yes" enables SIP messages to be logged. It is specified under
  2110. the "system" type. Also added an alembic script to add the option
  2111. to realtime. (closes issue ASTERISK-23038) Reported by: Rusty
  2112. Newton Review: https://reviewboard.asterisk.org/r/3148/
  2113. * res/res_pjsip_exten_state.c: res_pjsip_exten_state: Exporting
  2114. global symbols caused load order issues Removed the exportation
  2115. of global symbols from the module as it is no longer needed and
  2116. it could potentially cause load problems as on some systems it
  2117. would try to load before res_pjsip_pubsub
  2118. 2014-01-31 22:38 +0000 [r407031] Mark Michelson <mmichelson@digium.com>
  2119. * include/asterisk/res_pjsip_presence_xml.h (added): Add file that
  2120. apparently got missed in the merge.
  2121. 2014-01-31 22:17 +0000 [r407019] Kevin Harwell <kharwell@digium.com>
  2122. * UPGRADE.txt,
  2123. contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py,
  2124. contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py:
  2125. alembic: script modifications due to errors A couple of the
  2126. scripts had errors that would not allow a full migration to take
  2127. place. The extensions table needed to make its 'id' column a
  2128. primary key in order to work with mysql. The other script
  2129. ...add_endpoints... was missing tables that it was trying to add
  2130. columns to. Added the primary key on id for extensions and added
  2131. the tables in for the missing pjsip configuration options. While
  2132. it is not ideal to modify already released scripts this was a
  2133. case where it had to be done due to errors in the script and
  2134. lacking a better alternative. Review:
  2135. https://reviewboard.asterisk.org/r/3167/
  2136. 2014-01-31 22:11 +0000 [r407016] Mark Michelson <mmichelson@digium.com>
  2137. * res/res_pjsip_xpidf_body_generator.c (added),
  2138. res/res_pjsip_mwi_body_generator.c (added),
  2139. res/res_pjsip_pubsub.c, res/res_pjsip_pidf.c (removed),
  2140. res/res_pjsip_pidf_eyebeam_body_supplement.c (added),
  2141. res/res_pjsip_exten_state.c, res/res_pjsip/presence_xml.c
  2142. (added), include/asterisk/res_pjsip_pubsub.h,
  2143. res/res_pjsip_pidf_body_generator.c (added),
  2144. include/asterisk/res_pjsip_exten_state.h (removed),
  2145. res/res_pjsip_pubsub.exports.in,
  2146. include/asterisk/res_pjsip_body_generator_types.h (added),
  2147. res/res_pjsip_mwi.c: Decouple subscription handling from
  2148. NOTIFY/PUBLISH body generation. When the PJSIP pubsub framework
  2149. was created, subscription handlers were required to state what
  2150. event they handled along with what body types they knew how to
  2151. generate. While this serves well when implementing a base RFC, it
  2152. has problems when trying to extend the body to support
  2153. non-standard or proprietary body elements. The code also was
  2154. NOTIFY-specific, meaning that when the time comes that we start
  2155. writing code to send out PUBLISH requests with MWI or presence
  2156. bodies, we would likely find ourselves duplicating code that had
  2157. previously been written. This changeset introduces the concept of
  2158. body generators and body supplements. A body generator is
  2159. responsible for allocating a native structure for a given body
  2160. type, providing the primary body content, converting the native
  2161. structure to a string, and deallocating resources. A body
  2162. supplement takes the primary body content (the native structure,
  2163. not a string) generated by the body generator and adds
  2164. nonstandard elements to the body. With these elements living in
  2165. their own module, it becomes easy to extend our support for body
  2166. types and to re-use resources when sending a PUBLISH request.
  2167. Body generators and body supplements register themselves with the
  2168. pubsub core, similar to how subscription and publish handlers had
  2169. done. Now, subscription handlers do not need to know what type of
  2170. body content they generate, but they still need to inform the
  2171. pubsub core about what the default body type for a given event
  2172. package is. The pubsub core keeps track of what body generators
  2173. and body supplements have been registered. When a SUBSCRIBE
  2174. arrives, the pubsub core will check that there is a subscription
  2175. handler for the event in the SUBSCRIBE, then it will check that
  2176. there is a body generator that can provide the content specified
  2177. in the Accept header(s). Because of the nature of body generators
  2178. and supplements, it means res_pjsip_exten_state and res_pjsip_mwi
  2179. have been completely gutted. They no longer worry about body
  2180. types, instead calling ast_sip_pubsub_generate_body_content()
  2181. when they need to generate a NOTIFY body. Review:
  2182. https://reviewboard.asterisk.org/r/3150
  2183. 2014-01-31 22:05 +0000 [r407014] Kevin Harwell <kharwell@digium.com>
  2184. * res/res_pjsip_mwi.c: res_pjsip_mwi: Subscribe fails when missing
  2185. aor name When subscribing to MWI (res_pjsip_mwi) and the sip uri
  2186. did not contain a name (ex: sip:<ip address>) then the
  2187. subscription would fail since it would be unable to locate an
  2188. associated aor. This patch makes it so that when a subscribe
  2189. comes with no aor name then it will subscribe to all aors on the
  2190. located endpoint. (closes issue ASTERISK-23072) Reported by: Bob
  2191. M Review: https://reviewboard.asterisk.org/r/3164/
  2192. 2014-01-31 15:01 +0000 [r407000] Kinsey Moore <kmoore@digium.com>
  2193. * res/res_pjsip_nat.c: PJSIP: Fix address for ACK in NAT situations
  2194. In NAT scenarios where a call is placed to a Grandstream phone,
  2195. res_pjsip will sometimes send the ACK to a 200 OK to the private
  2196. address of the device behind the NAT instead of the address of
  2197. the NAT device. This corrects that behavior by rewriting the
  2198. address in the Contact header in the incoming 200 OK and the
  2199. dialog's target address if necessary (since it has already been
  2200. rewritten to the incorrect private address). (closes issue
  2201. ASTERISK-23106) Review: https://reviewboard.asterisk.org/r/3168/
  2202. Reported by: Matt Jordan
  2203. 2014-01-31 05:28 +0000 [r406987] Damien Wedhorn <voip@facts.com.au>
  2204. * channels/chan_skinny.c: Skinny: fix up possible double unlock of
  2205. chan. Return before chan is possibly unlocked a second time when
  2206. hanging up a channel in SUBSTATE_OFFHOOK.
  2207. 2014-01-30 20:34 +0000 [r406935] coreyfarrell <coreyfarrell@localhost>:
  2208. * main/udptl.c, res/res_rtp_asterisk.c, /: res_rtp_asterisk &
  2209. udptl: fix port selection to work with SELinux restrictions
  2210. ast_bind to a port reserved for another program by SELinux causes
  2211. errno == EACCES. This caused random failures when binding rtp or
  2212. udptl sockets. Treat EACCES as a non-fatal error, try next port.
  2213. (closes issue ASTERISK-23134) Reported by: Corey Farrell ........
  2214. Merged revisions 406933 from
  2215. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2216. revisions 406934 from
  2217. http://svn.asterisk.org/svn/asterisk/branches/11
  2218. 2014-01-30 17:33 +0000 [r406919] Sean Bright <sean@malleable.com>
  2219. * main/manager.c, /: Make a NOTICE about an invalid channel name
  2220. more useful. ........ Merged revisions 406918 from
  2221. http://svn.asterisk.org/svn/asterisk/branches/11
  2222. 2014-01-29 00:42 +0000 [r406862] Russell Bryant <russell@russellbryant.com>
  2223. * /, configs/queues.conf.sample: queues.conf.sample Fix documented
  2224. default for persistentmembers Closes issue ASTERISK-22662
  2225. ........ Merged revisions 406860 from
  2226. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2227. revisions 406861 from
  2228. http://svn.asterisk.org/svn/asterisk/branches/11
  2229. 2014-01-28 23:35 +0000 [r406788-406847] Kevin Harwell <kharwell@digium.com>
  2230. * res/res_pjsip_pubsub.c: res_pjsip_pubsub: potential crash on
  2231. timeout What seems to be happening is if a subscription has been
  2232. terminated and the subscription timeout/expires is less than the
  2233. time it takes for all pending transactions (currently on the
  2234. subscription) to end then the subscription timer will not have
  2235. been canceled yet and sub will be null. Since the subscription
  2236. has already been canceled nothing needs to be done so a null
  2237. check in the asterisk code is sufficient in working around this
  2238. problem. (closes issue ASTERISK-23129) Reported by: Dan Jenkins
  2239. * cdr/cdr_radius.c, cel/cel_radius.c, /, configure,
  2240. include/asterisk/autoconfig.h.in, configure.ac: cdr_radius,
  2241. cel_radius: build agains libfreeradius-client Asterisk's RADIUS
  2242. module currently build against libradiusclient-ng, but this
  2243. project has been superseeded by libfreeradius-client. The API is
  2244. 99% compatible except that the header name has changed, the
  2245. library name has changed, and the configuration file location has
  2246. changed. (closes issue ASTERISK-22980) Reported by: Jeremy Lainé
  2247. Patches: freeradius-client.patch uploaded by sharky (license
  2248. 6561) ........ Merged revisions 406801 from
  2249. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2250. revisions 406802 from
  2251. http://svn.asterisk.org/svn/asterisk/branches/11
  2252. * res/res_pjsip/include/res_pjsip_private.h,
  2253. include/asterisk/compat.h: res_pjsip,compat: INFINITY and NAN
  2254. undefined On some systems the values for INFINITY and NAN are not
  2255. defined thus causing a build error on those systems. Added
  2256. definitions for those if they had not previously been defined.
  2257. (closes issue ASTERISK-23056) Reported by: capouch Patches:
  2258. inf-nan-patch.txt uploaded by capouch (license 6564)
  2259. 2014-01-28 19:13 +0000 [r406775] Kinsey Moore <kmoore@digium.com>
  2260. * res/res_stasis_device_state.c: ARI: Make double subscribe respond
  2261. with success Currently, attempting to subscribe an application to
  2262. a device state that it has already subscribed to will generate a
  2263. 500 error response. This will now be treated as a subscription
  2264. refresh even though ARI subscriptions don't currently support
  2265. lifetimes and will respond with the normal response for a
  2266. successful subscription (200 OK). (closes issue ASTERISK-23143)
  2267. Reported by: Matt Jordan
  2268. 2014-01-28 16:41 +0000 [r406723] Scott Griepentrog <sgriepentrog@digium.com>
  2269. * main/rtp_engine.c, /: rtp_engine: improved handling of
  2270. get_rtp_info failure In ast_rtp_instance_make_compatible(), after
  2271. a failure of channel tech call get_rtp_info() to return
  2272. peer_instance, the null pointer would be passed to ao2_ref,
  2273. producing an error that looked like a refernce counting problem
  2274. but is not. This patch corrects that and adds helpful LOG_ERROR
  2275. messages to indicate which failure path occurred. (issue
  2276. AST-1276) Review: https://reviewboard.asterisk.org/r/3156/
  2277. ........ Merged revisions 406721 from
  2278. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2279. revisions 406722 from
  2280. http://svn.asterisk.org/svn/asterisk/branches/11
  2281. 2014-01-28 00:11 +0000 [r406707] Richard Mudgett <rmudgett@digium.com>
  2282. * tests/test_cel.c, tests/test_cdr.c: test_cdr.c, test_cel.c:
  2283. Correctly destroy created bridges. * Fixed the
  2284. test_cel_attended_transfer_bridges_link unit test to also account
  2285. for the local channel link being destroyed now that the bridges
  2286. are actually destroyed. * Made CDR unit test use its own version
  2287. of do_sleep() from the CEL unit tests.
  2288. 2014-01-27 20:36 +0000 [r406574-406645] Russell Bryant <russell@russellbryant.com>
  2289. * /, main/config.c: Allow nested #includes in extconfig.conf
  2290. extconfig.conf was hard-coded to not allow nested includes for
  2291. some reason. The code has been this way since a patch was merged
  2292. for ASTERISK-3333 (revision 4889), which was a significant update
  2293. to this code ("Merge config updates"). I can't figure out any
  2294. good reason why this should be limited. This patch just removes
  2295. the limit and uses the default nesting depth limit. Closes issue
  2296. ASTERISK-17837 Review: https://reviewboard.asterisk.org/r/3159/
  2297. ........ Merged revisions 406643 from
  2298. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2299. revisions 406644 from
  2300. http://svn.asterisk.org/svn/asterisk/branches/11
  2301. * main/channel.c, /, main/file.c, include/asterisk/channel.h:
  2302. Protect ast_filestream object when on a channel The
  2303. ast_filestream object gets tacked on to a channel via
  2304. chan->timingdata. It's a reference counted object, but the
  2305. reference count isn't used when putting it on a channel. It's
  2306. theoretically possible for another thread to interfere with the
  2307. channel while it's unlocked and cause the filestream to get
  2308. destroyed. Use the astobj2 reference count to make sure that as
  2309. long as this code path is holding on the ast_filestream and
  2310. passing it into the file.c playback code, that it knows it's
  2311. valid. Bug reported by Leif Madsen. Review:
  2312. https://reviewboard.asterisk.org/r/3135/ ........ Merged
  2313. revisions 406566 from
  2314. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2315. revisions 406567 from
  2316. http://svn.asterisk.org/svn/asterisk/branches/11
  2317. 2014-01-26 23:03 +0000 [r406516] Richard Mudgett <rmudgett@digium.com>
  2318. * main/tcptls.c, /: tcptls.c: Add missing cleanup on off nominal
  2319. path. ........ Merged revisions 406514 from
  2320. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2321. revisions 406515 from
  2322. http://svn.asterisk.org/svn/asterisk/branches/11
  2323. 2014-01-26 02:10 +0000 [r406489] Joshua Colp <jcolp@digium.com>
  2324. * res/res_pjsip_session.c: res_pjsip_session: Be less strict with
  2325. core requested outgoing capabilities. The core may (depending on
  2326. circumstances) request a single codec on outgoing calls. Many
  2327. channel drivers ignore or treat this as a suggestion while still
  2328. including configured codecs. The res_pjsip_session logic treated
  2329. this as an explicit request, leaving out other configured codecs.
  2330. This change makes res_pjsip_session behave like other channel
  2331. driver and simply adds the requested codec to the list. (closes
  2332. issue ASTERISK-23082) Reported by: xrobau Review:
  2333. https://reviewboard.asterisk.org/r/3140/
  2334. 2014-01-24 23:29 +0000 [r406401-406465] Richard Mudgett <rmudgett@digium.com>
  2335. * main/cel.c, /: CEL: Protect data structures during reload and
  2336. shutdown. The CEL data structures need to be protected during a
  2337. configuration reload and shutdown. Asterisk crashed during a
  2338. shutdown because CEL events were still in flight and the CEL data
  2339. structures were already destroyed. * Protected the cel_backends,
  2340. cel_dialstatus_store, and cel_linkedids ao2 containers with a
  2341. global ao2 object wrapper. * Added NULL checks before use of the
  2342. cel_backends, cel_dialstatus_store, and cel_linkedids ao2
  2343. containers in case the CEL module is already shutdown. * Fixed
  2344. overloading of the cel_linkedids held objects reference count.
  2345. During shutdown any held objects would be leaked. * Fixed memory
  2346. leak of cel_linkedids held objects if the LINKEDID_END is not
  2347. being tracked. The objects in the cel_linkedids container were
  2348. not removed if the LINKEDID_END event is not used. * Added access
  2349. protection to the cel_backends container during the CLI "cel show
  2350. status" command. * Made cel_backends, cel_dialstatus_store, and
  2351. cel_linkedids use the standard ao2 callback templates for the
  2352. hash and cmp functions. * Eliminated unnecessary uses of
  2353. RAII_VAR(). * Made ast_cel_engine_init() cleanup alocated
  2354. resources on failure. (closes issue AST-1253) Reported by:
  2355. Guenther Kelleter Review:
  2356. https://reviewboard.asterisk.org/r/3128/ ........ Merged
  2357. revisions 406417 from
  2358. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2359. revisions 406418 from
  2360. http://svn.asterisk.org/svn/asterisk/branches/11
  2361. * main/manager.c, /: manager: Register atexit shutdown routine only
  2362. once. * Made register atexit shutdown routine only once in
  2363. __init_manager(). * Fixed some initial load failure conditions in
  2364. __init_manager(). * Made reset options to defaults on reload when
  2365. the reload will actually happen. * Removed unnecessary container
  2366. traversals of the white/black filters during manager_free_user().
  2367. * ast_free() does not need a NULL check before calling. ........
  2368. Merged revisions 406359 from
  2369. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2370. revisions 406400 from
  2371. http://svn.asterisk.org/svn/asterisk/branches/11
  2372. 2014-01-24 21:25 +0000 [r406389] Jonathan Rose <jrose@digium.com>
  2373. * res/res_config_pgsql.c, /: res_config_pgsql: Fix a memory leak
  2374. and use RAII_VAR for cleanup when practical Review:
  2375. https://reviewboard.asterisk.org/r/3141/ ........ Merged
  2376. revisions 406360 from
  2377. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2378. revisions 406361 from
  2379. http://svn.asterisk.org/svn/asterisk/branches/11
  2380. 2014-01-24 18:04 +0000 [r406342] Richard Mudgett <rmudgett@digium.com>
  2381. * main/manager.c, /: manager: Protect data structures during
  2382. shutdown. Occasionally, the manager module would get an
  2383. "INTERNAL_OBJ: bad magic number" error on a "core restart
  2384. gracefully" command if an AMI connection is established. * Added
  2385. ao2_global_obj protection to the sessions global container. *
  2386. Fixed the order of unreferencing a session object in
  2387. session_destroy(). * Removed unnecessary container traversals of
  2388. the white/black filters during session_destructor(). (closes
  2389. issue AST-1242) Reported by: Guenther Kelleter Review:
  2390. https://reviewboard.asterisk.org/r/3144/ ........ Merged
  2391. revisions 406341 from
  2392. http://svn.asterisk.org/svn/asterisk/branches/11
  2393. 2014-01-23 23:41 +0000 [r406327] Mark Michelson <mmichelson@digium.com>
  2394. * res/res_pjsip_pidf.c: Today is not my day for writing code that
  2395. compiles.
  2396. 2014-01-23 22:54 +0000 [r406311] Michael L. Young <elgueromexicano@gmail.com>
  2397. * addons/res_config_mysql.c: res_config_mysql: Fix Setting The
  2398. Column Name Incorrectly When support for a realtime sorcery
  2399. module was added in revision 386731, the wrong property was
  2400. accidentally used for setting the column name to be updated in
  2401. the database table. This patch fixes the typo. (closes issue
  2402. ASTERISK-23177) Reported by: Denis Tested by: Denis Patches:
  2403. asterisk-23177-use-field-name.diff by Michael L. Young (license
  2404. 5026)
  2405. 2014-01-23 21:09 +0000 [r406294-406295] Mark Michelson <mmichelson@digium.com>
  2406. * res/res_pjsip_pidf.c: Fix presence body errors found during
  2407. testing: * PIDF bodies were reporting an "open" state in many
  2408. cases where it should have been reporting "closed" * XPIDF bodies
  2409. had XML nodes placed incorrectly within the hierarchy. * SIP URIs
  2410. in XPIDF bodies did not go through XML sanitization * XML
  2411. sanitization had some errors: * Right angle bracket was being
  2412. replaced with "&rt;" instead of "&gt;" * Double quote,
  2413. apostrophe, and ampersand were not being escaped.
  2414. * res/res_pjsip_pidf.c: Fix presence body errors found during
  2415. testing: * PIDF bodies were reporting an "open" state in many
  2416. cases where it should have been reporting "closed" * XPIDF bodies
  2417. had XML nodes placed incorrectly within the hierarchy. * SIP URIs
  2418. in XPIDF bodies did not go through XML sanitization * XML
  2419. sanitization had some errors: * Right angle bracket was being
  2420. replaced with "&rt;" instead of "&gt;" * Double quote,
  2421. apostrophe, and ampersand were not being escaped.
  2422. 2014-01-22 22:23 +0000 [r406264] Scott Griepentrog <sgriepentrog@digium.com>
  2423. * utils/extconf.c, main/pbx.c, /: pbx.c: Pre-initialize timezone to
  2424. avoid crash on destroy In ast_build_timing, initialize the
  2425. timezone value to NULL in order to avoid deferencing an
  2426. uninitialized value later when calling ast_destroy_timing. The
  2427. timezone value could be uninitialized if ast_build_timing were to
  2428. fail due to a zero length time string. (closes issue
  2429. ASTERISK-22861) Reported by: Sebastian Murray-Roberts Review:
  2430. https://reviewboard.asterisk.org/r/3134/ Patches:
  2431. ast_build_timing-initialize-timezone.patch uploaded by
  2432. coreyfarrell (license 5909) ........ Merged revisions 406241 from
  2433. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2434. revisions 406245 from
  2435. http://svn.asterisk.org/svn/asterisk/branches/11
  2436. 2014-01-22 19:34 +0000 [r406152-406223] Kinsey Moore <kmoore@digium.com>
  2437. * apps/app_confbridge.c, /: ConfBridge: Fix channel parameter
  2438. documentation Confbridge AMI and CLI commands for mute, unmute,
  2439. and setting the single video source can accept channel prefixes
  2440. in lieu of a full channel name, but documentation states only
  2441. that it is required and is a channel name. This corrects the
  2442. documentation. (closes issue PQ-1397) Reported by: Steve Pitts
  2443. ........ Merged revisions 406217 from
  2444. http://svn.asterisk.org/svn/asterisk/branches/11
  2445. * /, channels/chan_sip.c: chan_sip: Decline image streams on
  2446. unsupported transports This change allows chan_sip to decline
  2447. individual image streams over unsupported transports in the SDP
  2448. of the 200 response. Previously, an image stream offer with
  2449. RTP/AVP as the transport would cause chan_sip to respond with a
  2450. 488. (closes issue ASTERISK-22988) Reported by: adomjan Original
  2451. patch by: adomjan ........ Merged revisions 406170 from
  2452. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2453. revisions 406171 from
  2454. http://svn.asterisk.org/svn/asterisk/branches/11
  2455. * res/res_stasis_playback.c: res_stasis_playback: Correct error
  2456. argument order Several of the playback error messages for invalid
  2457. media input in res_stasis_playback.c had the media name and
  2458. channel name reversed. They now correctly identify the channel
  2459. name and media name. Reported by: skrusty
  2460. 2014-01-21 21:47 +0000 [r406133] Rusty Newton <rnewton@digium.com>
  2461. * res/res_pjsip.c: res_pjsip: Documentation improvement for
  2462. Endpoint and AOR mailbox options. Making the help text for both
  2463. more explicit regarding the format of mailbox identifiers. i.e.
  2464. clarifying the format for app_voicemail mailboxes vs mailboxes
  2465. from external MWI sources through modules such as
  2466. res_external_mwi.
  2467. 2014-01-21 21:06 +0000 [r406081] Walter Doekes <walter+asterisk@wjd.nu>
  2468. * configs/manager.conf.sample, main/manager.c, /: manager: Clarify
  2469. eventfilter documentation. Textual changes only. Review:
  2470. https://reviewboard.asterisk.org/r/3133/ ........ Merged
  2471. revisions 406079 from
  2472. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2473. revisions 406080 from
  2474. http://svn.asterisk.org/svn/asterisk/branches/11
  2475. 2014-01-21 20:20 +0000 [r406003-406049] Kinsey Moore <kmoore@digium.com>
  2476. * /, channels/chan_mgcp.c: chan_mgcp: Enforce locking for oseq This
  2477. restricts direct usage of global oseq so that all accesses are
  2478. locked and threads are not racing to get oseq values that they
  2479. did not claim. This also fixes a build error in res_pktccops
  2480. under dev mode. (closes issue ASTERISK-23100) Reported by:
  2481. adomjan Patch by: adomjan ........ Merged revisions 406037 from
  2482. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2483. revisions 406038 from
  2484. http://svn.asterisk.org/svn/asterisk/branches/11
  2485. * res/res_pjsip_outbound_registration.c, res/res_pjsip.c: PJSIP:
  2486. Handle headers in a list appropriately The PJSIP header parsing
  2487. function (pjsip_parse_hdr) can generate more than one header
  2488. instance from a single header field. These header instances exist
  2489. as a list attached to the returned header and must be handled
  2490. appropriately when they are added to a message or else only the
  2491. first header instance will be used. This changes the linked list
  2492. functions used in outbound proxy code to merge the lists
  2493. properly.
  2494. * rest-api-templates/ari_resource.h.mustache,
  2495. res/res_ari_device_states.c, res/res_ari_mailboxes.c,
  2496. res/res_ari_asterisk.c,
  2497. rest-api-templates/res_ari_resource.c.mustache,
  2498. res/res_ari_applications.c,
  2499. rest-api-templates/body_parsing.mustache (added),
  2500. res/res_ari_channels.c, res/ari/resource_playbacks.h,
  2501. rest-api-templates/param_parsing.mustache,
  2502. res/ari/resource_sounds.h, res/ari/resource_bridges.h,
  2503. res/ari/resource_device_states.h, res/ari/resource_mailboxes.h,
  2504. rest-api/api-docs/channels.json, res/ari/resource_asterisk.h,
  2505. res/ari/resource_applications.h, res/ari/resource_channels.c,
  2506. res/res_ari_playbacks.c, res/res_ari_sounds.c,
  2507. rest-api-templates/asterisk_processor.py,
  2508. res/ari/resource_channels.h, res/res_ari_bridges.c: ARI: Support
  2509. channel variables in originate This adds back in support for
  2510. specifying channel variables during an originate without
  2511. compromising the ability to specify query parameters in the JSON
  2512. body. This was accomplished by generating the body-parsing code
  2513. in a separate function instead of being integrated with the URI
  2514. query parameter parsing code such that it could be called by
  2515. paths with body parameters. This is transparent to the user of
  2516. the API and prevents manual duplication of code or data
  2517. structures. (closes issue ASTERISK-23051) Review:
  2518. https://reviewboard.asterisk.org/r/3122/ Reported by: Matt Jordan
  2519. 2014-01-20 23:18 +0000 [r405982] Damien Wedhorn <voip@facts.com.au>
  2520. * channels/chan_skinny.c: Skinny: fix up handling of fragmented
  2521. packets. Bad offset in reading second or more fragment of skinny
  2522. packets. Fixed to offset by char (single byte) rather than size
  2523. of req.
  2524. 2014-01-20 22:15 +0000 [r405928] Richard Mudgett <rmudgett@digium.com>
  2525. * /, channels/sig_pri.c: chan_dahdi/PRI: Suppress CONNECTED_LINE
  2526. updates when nothing in the udpate is valid. * Also simplified
  2527. some subddress handling code. (closes issue ASTERISK-23008)
  2528. Reported by: Michael Cargile ........ Merged revisions 405926
  2529. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  2530. Merged revisions 405927 from
  2531. http://svn.asterisk.org/svn/asterisk/branches/11
  2532. 2014-01-20 21:53 +0000 [r405924] Damien Wedhorn <voip@facts.com.au>
  2533. * channels/chan_skinny.c: Skinny: fix up session logging. Logging
  2534. from the skinny session loop was providing some incorrect reasons
  2535. for exiting the loop. Cleaned up messages and handling so correct
  2536. reason displayed.
  2537. 2014-01-20 18:07 +0000 [r405908] Jonathan Rose <jrose@digium.com>
  2538. * channels/chan_pjsip.c: chan_pjsip: Provide a means for tracking
  2539. device state when holding/unholding Previously PJSIP did not
  2540. track hold/unhold and it would always simply be 'inuse'. This
  2541. patch fixes that. review:
  2542. https://reviewboard.asterisk.org/r/3129/
  2543. 2014-01-18 23:57 +0000 [r405893] Damien Wedhorn <voip@facts.com.au>
  2544. * channels/chan_skinny.c: Skinny: fix reversed device reset from
  2545. CLI. Existing code would do a full device restart when "skinny
  2546. reset device" was entered at the CLI and do a reset when "skinny
  2547. reset device restart" entered.
  2548. 2014-01-17 22:05 +0000 [r405877] Sean Bright <sean@malleable.com>
  2549. * channels/chan_sip.c: Make sure the maxptime attribute is added to
  2550. the correct offers.
  2551. 2014-01-17 21:32 +0000 [r405861-405875] Scott Griepentrog <sgriepentrog@digium.com>
  2552. * main/frame.c, include/asterisk/format_pref.h,
  2553. res/res_pjsip_sdp_rtp.c, main/format_pref.c, main/sorcery.c:
  2554. pjsip: fix support for allow=all This change adds improvements to
  2555. support for allow=all in pjsip.conf so that it functions as
  2556. intended. Previously, the allow/disallow socery configuration
  2557. would set & clear codecs from the media.codecs and media.prefs
  2558. list, but if all was specified the prefs list was not updated.
  2559. Then a call would fail when create_outgoing_sdp_stream() created
  2560. an SDP with no audio codecs. A new function
  2561. ast_codec_pref_append_all() is provided to add all codecs to the
  2562. prefs list - only those not already on the list. This enables the
  2563. configuration to specify a codec preference, but still add all
  2564. codecs, and even then remove some codecs, as shown in this
  2565. example: allow = ulaw, alaw, all, !g729, !g723 Also, the display
  2566. order of allow in cli output is updated to match the
  2567. configuration by using prefs instead of caps when generating a
  2568. human readable string. Finally, a change to
  2569. create_outgoing_sdp_stream() skips a codec when it does not have
  2570. a payload code instead of the call failing. (closes issue
  2571. ASTERISK-23018) Reported by: xrobau Review:
  2572. https://reviewboard.asterisk.org/r/3131/
  2573. * main/http.c: http: supported chunked Transfer-Encoding This
  2574. change implements support for HTTP Transfer-Encoding chunked in
  2575. both JSON and Form (post vars) body content. A new function
  2576. ast_http_get_contents() handles both regular and chunked mode
  2577. body, returning after the entire body is received. (closes issue
  2578. ASTERISK-23068) Reported by: Matt Jordan Review:
  2579. https://reviewboard.asterisk.org/r/3125/
  2580. 2014-01-17 18:54 +0000 [r405777-405843] Rusty Newton <rnewton@digium.com>
  2581. * res/res_pjsip.c: Fixing some XML syntax issues with my previous
  2582. commit at r405777 for ASTERISK-23071
  2583. * /, channels/chan_sip.c, doc/asterisk.8, main/features.c,
  2584. configs/sip.conf.sample, apps/app_queue.c, apps/app_transfer.c,
  2585. channels/chan_iax2.c: Documentation: doc fixes across various
  2586. parts of the code for ASTERISK issues 23061,23028,23046,23027
  2587. Fixes typos of "transfered" instead of "transferred" in various
  2588. code. Fixes incorrect gosub param help text for app_queue. Fixes
  2589. Asterisk man pages containing unquoted minus signs. Adds note
  2590. about the "textsupport" option in sip.conf.sample. (issue
  2591. ASTERISK-23061) (issue ASTERISK-23028) (issue ASTERISK-23046)
  2592. (issue ASTERISK-23027) (closes issue ASTERISK-23061) (closes
  2593. issue ASTERISK-23028) (closes issue ASTERISK-23046) (closes issue
  2594. ASTERISK-23027) Reported by: Eugene, Jeremy Laine, Denis
  2595. Pantsyrev Patches: transferred.patch uploaded by Jeremy Laine
  2596. (license 6561) hyphen.patch uploaded by Jeremy Laine (license
  2597. 6561) sip.conf.sample.patch uploaded by Eugene (license 6360)
  2598. ........ Merged revisions 405791 from
  2599. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2600. revisions 405792 from
  2601. http://svn.asterisk.org/svn/asterisk/branches/11
  2602. * res/res_pjsip.c: res_pjsip: enhance documentation for mailboxes
  2603. options, for both endpoints and aors Made documentation more
  2604. explicit as to the use of the both options. (issue
  2605. ASTERISK-23071) (closes issue ASTERISK-23071) Reported by: Matt
  2606. Jordan
  2607. 2014-01-16 20:05 +0000 [r405746-405748] Kevin Harwell <kharwell@digium.com>
  2608. * res/res_pjsip/pjsip_options.c: res_pjsip: AOR option
  2609. qualify_frequency not respected on startup If an endpoint had
  2610. previously dynamically registered a contact and the contact
  2611. information was successfully stored in astdb then upon restart
  2612. the qualify notifications would not be sent out if the
  2613. qualify_frequency was set. This was due to the fact that only
  2614. permanent contacts were being checked and scheduled for qualifies
  2615. on startup. Modified the code to check and schedule all
  2616. registered contacts at startup. (closes issue ASTERISK-23062)
  2617. Reported by: Rusty Newton Review:
  2618. https://reviewboard.asterisk.org/r/3124/
  2619. * main/manager.c, /: manager: Originate doesn't abort on failed
  2620. format_cap allocation action_originate responds to the remote
  2621. system with an error when cap==NULL, but doesn't return (abort
  2622. the originate). Patched to return. (closes issue ASTERISK-23034)
  2623. Reported by: Corey Farrell Patches: ASTERISK-23034.patch uploaded
  2624. by coreyfarrell (license 5909) ........ Merged revisions 405745
  2625. from http://svn.asterisk.org/svn/asterisk/branches/11
  2626. 2014-01-16 19:32 +0000 [r405743] Kinsey Moore <kmoore@digium.com>
  2627. * res/res_pjsip.c: PJSIP: Fix outbound OPTIONS support When path
  2628. support was added and contacts were made available during request
  2629. creation and transmission, the code path used by outbound qualify
  2630. support was not modified correctly and was causing request
  2631. creation to fail. This ensures that outbound request creation
  2632. with only a contact and no dialog, endpoint, or uri can succeed
  2633. which restores qualify support. Reported by: gtjoseph Reported
  2634. by: kharwell
  2635. 2014-01-16 19:06 +0000 [r405643-405694] Kevin Harwell <kharwell@digium.com>
  2636. * /, res/res_fax.c, configs/res_fax.conf.sample, UPGRADE.txt:
  2637. res_fax: check_modem_rate() returned incorrect rate for V.27
  2638. According to the new standard for V.27 and V.32 they are able to
  2639. transmit at a bit rate of 4,800 or 9,600. The check_mode_rate
  2640. function needed to be updated to reflect this. Also, because of
  2641. this change the default 'minrate' value was updated to be 4800.
  2642. (closes issue ASTERISK-22790) Reported by: Paolo Compagnini
  2643. Patches: res_fax.txt uploaded by looserouting (license 6548)
  2644. ........ Merged revisions 405656 from
  2645. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2646. revisions 405693 from
  2647. http://svn.asterisk.org/svn/asterisk/branches/11
  2648. * channels/chan_pjsip.c: chan_pjsip: initial device state on
  2649. endpoints is INVALID When endpoints get loaded their device state
  2650. gets set to 'INVALID' because the channel driver has not been
  2651. loaded yet. Fixed by updating the device state for every endpoint
  2652. upon load of the channel driver. (closes issue ASTERISK-23065)
  2653. Reported by: Rusty Newton Review:
  2654. https://reviewboard.asterisk.org/r/3123/
  2655. 2014-01-15 16:48 +0000 [r405585-405587] Jonathan Rose <jrose@digium.com>
  2656. * CHANGES: Remove subversion conflict tag accidentally left in
  2657. CHANGES
  2658. * CHANGES: Include CHANGES info for r405553
  2659. 2014-01-15 16:36 +0000 [r405583] Joshua Colp <jcolp@digium.com>
  2660. * /, cel/cel_manager.c: cel_manager: Don't crash if configuration
  2661. file is invalid. The cel_manager module did not properly handle
  2662. the case where the configuration file was invalid. The module
  2663. will now output a warning message and disable itself if this
  2664. occurs. Reported by: Bryan Walters ........ Merged revisions
  2665. 405581 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  2666. ........ Merged revisions 405582 from
  2667. http://svn.asterisk.org/svn/asterisk/branches/11
  2668. 2014-01-15 13:14 +0000 [r405565] Kinsey Moore <kmoore@digium.com>
  2669. * res/res_pjsip_messaging.c, UPGRADE.txt, res/res_pjsip_t38.c,
  2670. res/res_pjsip_caller_id.c, CHANGES,
  2671. res/res_pjsip/pjsip_options.c, res/res_pjsip.c,
  2672. res/res_pjsip_nat.c, res/res_pjsip_session.c,
  2673. contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py
  2674. (added), res/res_pjsip_header_funcs.c, res/res_pjsip/location.c,
  2675. res/res_pjsip_outbound_registration.c, res/res_pjsip_path.c
  2676. (added), res/res_pjsip_mwi.c, res/res_pjsip/pjsip_distributor.c,
  2677. res/res_pjsip_diversion.c, channels/chan_pjsip.c,
  2678. res/res_pjsip_registrar.c, res/res_pjsip_refer.c,
  2679. include/asterisk/res_pjsip.h,
  2680. include/asterisk/res_pjsip_session.h, res/res_pjsip_notify.c:
  2681. PJSIP: Add Path header support This adds Path support to
  2682. chan_pjsip in res_pjsip_path.c with minimal additions in
  2683. res_pjsip_registrar.c to store the path and additions in
  2684. res_pjsip_outbound_registration.c to enable advertisement of path
  2685. support to registrars and intervening proxies. Path information
  2686. is stored on contacts and is enabled via Address of Record (AoRs)
  2687. and Registration configuration sections. While adding path
  2688. support, it became necessary to be able to add SIP supplements
  2689. that handled messages outside of sessions, so a framework for
  2690. handling these types of hooks was added in parallel to the
  2691. already-existing session supplements and several senders of
  2692. out-of-dialog requests were refactored as a result. (closes issue
  2693. ASTERISK-21084) Review: https://reviewboard.asterisk.org/r/3050/
  2694. 2014-01-14 23:26 +0000 [r405553] Jonathan Rose <jrose@digium.com>
  2695. * rest-api/resources.json, res/ari/ari_model_validators.c,
  2696. res/res_stasis_mailbox.exports.in (added),
  2697. res/ari/ari_model_validators.h, rest-api/api-docs/mailboxes.json
  2698. (added), include/asterisk/stasis_app_mailbox.h (added),
  2699. res/ari/resource_mailboxes.c (added), res/ari.make,
  2700. res/res_ari_mailboxes.c (added), res/ari/resource_mailboxes.h
  2701. (added), res/res_stasis_mailbox.c (added): ARI: Add mailboxes
  2702. resource for controlling and polling external MWI Adds the
  2703. following AMI commands: PUT mailboxes/mailboxName modifies
  2704. mailbox state and implicitly creates new mailboxes GET
  2705. mailboxes/mailboxName retrieves a JSON representation of a single
  2706. mailbox if it exists GET mailboxes retrieves a JSON array of all
  2707. mailboxes DELETE mailbox/mailboxName deletes a mailbox Note that
  2708. res_mwi_external must be loaded for these functions to actually
  2709. do anything. Review: https://reviewboard.asterisk.org/r/3117/
  2710. 2014-01-14 21:44 +0000 [r405541] Richard Mudgett <rmudgett@digium.com>
  2711. * main/strings.c: string container: Remove unnecessary RAII_VAR
  2712. usage and string object lock.
  2713. 2014-01-14 18:13 +0000 [r405435] Scott Griepentrog <sgriepentrog@digium.com>
  2714. * /, channels/chan_sip.c: chan_sip: fix Local From tag on outbound
  2715. register regression In ASTERISK-12117, an improvement to insure
  2716. consistant local from tags on outbound registrations resulted in
  2717. an undesirable behavior - caused by leftover unexpired sip_pvt
  2718. dialogs (with the previous cseq number), resulting in many
  2719. uncessary REGISTER requests. Instead of significant rework of
  2720. transmit_register(), this change deletes the dialogs after a 200
  2721. OK response indiciating a successful registration, keeping the
  2722. old dialogs from interfering with normal operation. (closes issue
  2723. ASTERISK-22946) Reported by: Stephan Eisvogel Review:
  2724. https://reviewboard.asterisk.org/r/3109/ ........ Merged
  2725. revisions 405433 from
  2726. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2727. revisions 405434 from
  2728. http://svn.asterisk.org/svn/asterisk/branches/11
  2729. 2014-01-14 18:03 +0000 [r405432] Richard Mudgett <rmudgett@digium.com>
  2730. * include/asterisk/logger.h, main/pbx.c, main/manager.c, /,
  2731. funcs/func_timeout.c, apps/app_dumpchan.c, main/logger.c,
  2732. UPGRADE.txt, apps/app_verbose.c, main/asterisk.c,
  2733. configs/logger.conf.sample, main/cli.c: verbosity: Fix
  2734. performance of console verbose messages. The per console verbose
  2735. level feature as previously implemented caused a large
  2736. performance penalty. The fix required some minor
  2737. incompatibilities if the new rasterisk is used to connect to an
  2738. earlier version. If the new rasterisk connects to an older
  2739. Asterisk version then the root console verbose level is always
  2740. affected by the "core set verbose" command of the remote console
  2741. even though it may appear to only affect the current console. If
  2742. an older version of rasterisk connects to the new version then
  2743. the "core set verbose" command will have no effect. * Fixed the
  2744. verbose performance by not generating a verbose message if
  2745. nothing is going to use it and then filtered any generated
  2746. verbose messages before actually sending them to the remote
  2747. consoles. * Split the "core set debug" and "core set verbose" CLI
  2748. commands to remove the per module verbose support that cannot
  2749. work with the per console verbose level. * Added a silent option
  2750. to the "core set verbose" command. * Fixed "core set debug off"
  2751. tab completion. * Made "core show settings" list the current
  2752. console verbosity in addition to the root console verbosity. *
  2753. Changed the default verbose level of the 'verbose' setting in the
  2754. logger.conf [logfiles] section. The default is now to once again
  2755. follow the current root console level. As a result, using the AMI
  2756. Command action with "core set verbose" could again set the root
  2757. console verbose level and affect the verbose level logged.
  2758. (closes issue AST-1252) Reported by: Guenther Kelleter Review:
  2759. https://reviewboard.asterisk.org/r/3114/ ........ Merged
  2760. revisions 405431 from
  2761. http://svn.asterisk.org/svn/asterisk/branches/11
  2762. 2014-01-14 03:12 +0000 [r405367] Damien Wedhorn <voip@facts.com.au>
  2763. * channels/chan_skinny.c: Skinny: do not add call to missed calls
  2764. list if answered elsewhere. Patch updates skinny devices with a
  2765. SKINNY_CONNECTED callstate if an inbound ringing or callwaiting
  2766. call is answered elsewhere.
  2767. 2014-01-13 17:09 +0000 [r405350] Jonathan Rose <jrose@digium.com>
  2768. * res/res_pjsip_session.c: PJSIP: Backport r405270 - Unhold on
  2769. reinvite without SDP Adds behavior to unhold on a reinvite
  2770. without an SDP section Review:
  2771. https://reviewboard.asterisk.org/r/3106/
  2772. 2014-01-13 13:28 +0000 [r405338] Kinsey Moore <kmoore@digium.com>
  2773. * res/res_pjsip/pjsip_cli.c: res_pjsip: Fix CLI tab completion
  2774. issues This fixes several issues with the new res_pjsip CLI tab
  2775. completion such as output of headers during tab completion and
  2776. being able to tab-complete more items than the code actually
  2777. handled (further items would simply be ignored). (closes issue
  2778. ASTERISK-23081) Review: https://reviewboard.asterisk.org/r/3115/
  2779. Reported by: xrobau
  2780. 2014-01-12 22:23 +0000 [r405325] Joshua Colp <jcolp@digium.com>
  2781. * res/ari/resource_playbacks.c, res/ari/resource_channels.c,
  2782. include/asterisk/ari.h, res/ari/resource_bridges.c,
  2783. res/ari/resource_recordings.c, res/ari/resource_device_states.c,
  2784. res/res_ari.c, res/ari/resource_endpoints.c,
  2785. res/ari/resource_applications.c: res_ari: Fix various memory
  2786. leaks. This change fixes a few memory leaks that were found based
  2787. on a mailing list post. 1. Some JSON response messages were never
  2788. freed. This was caused by the documentation stating that message
  2789. references were stolen when in reality they were not. The code
  2790. now follows the documentation and usage has been updated. 2. HTTP
  2791. response headers were never freed. 3. The variable list for
  2792. wildcards paths was never freed. (closes issue ASTERISK-23128)
  2793. Reported by: Kenneth Watson (on list) Review:
  2794. https://reviewboard.asterisk.org/r/3119/
  2795. 2014-01-12 21:58 +0000 [r405311-405312] Matthew Jordan <mjordan@digium.com>
  2796. * funcs/func_cdr.c, include/asterisk/cdr.h, apps/app_cdr.c,
  2797. main/cdr.c, apps/app_forkcdr.c: CDRs: Synchronize dialplan
  2798. applications that manipulate CDRs with the engine In
  2799. https://reviewboard.asterisk.org/r/3057/, applications and
  2800. functions that manipulate CDRs were made to interact over Stasis.
  2801. This was done to synchronize manipulations of CDRs from the
  2802. dialplan with the updates the engine itself receives over the
  2803. message bus. This change rested on a faulty premise: that
  2804. messages published to the CDR topic or to a topic that forwards
  2805. to the CDR topic are synchronized with the messages handled by
  2806. the CDR topic subscription in the CDR engine. This is not the
  2807. case. There is no ordering guaranteed for two messages published
  2808. to the same topic; ordering is only guaranteed if a message is
  2809. published to the same subscriber. Stasis was modified in r405311
  2810. to allow a publisher to synchronize on the subscriber. This patch
  2811. uses that API to synchronize the CDR publishers with the CDR
  2812. engine message router, which maintains the overall topic
  2813. subscription. (closes issue ASTERISK-22884) Reported by: Matt
  2814. Jordan Review: https://reviewboard.asterisk.org/r/3099/
  2815. * main/stasis.c, main/stasis_message_router.c,
  2816. include/asterisk/stasis.h,
  2817. include/asterisk/stasis_message_router.h, tests/test_stasis.c:
  2818. stasis: Add methods to allow for synchronous publishing to
  2819. subscriber This patch adds an API call to Stasis that allows a
  2820. publisher to publish a stasis message that will not return until
  2821. a specific subscriber handles the message. Since a subscriber can
  2822. have their own forwarding topic which orders messages from many
  2823. topics, this allows a publisher who knows of that subscriber to
  2824. synchronize to that subscriber regardless of the forwarding
  2825. relationships between topics. This is of particular use for
  2826. dialplan applications that need to synchronize on a particular
  2827. subscriber's handling of a message. (issue ASTERISK-22884)
  2828. Reported by: Matt Jordan Review:
  2829. https://reviewboard.asterisk.org/r/3099/
  2830. 2014-01-10 19:39 +0000 [r405298] Mark Michelson <mmichelson@digium.com>
  2831. * res/res_pjsip/security_events.c: Print "<unknown>" for artificial
  2832. endpoint in PJSIP security events. Previously, this printed a
  2833. UUID, which was not very clear when dealing with an artificial
  2834. endpoint. Review: https://reviewboard.asterisk.org/r/3113
  2835. 2014-01-10 18:00 +0000 [r405282] Richard Mudgett <rmudgett@digium.com>
  2836. * main/logger.c, /: Logging callid: Fix some sizeof() references
  2837. per coding guidelines. ........ Merged revisions 405281 from
  2838. http://svn.asterisk.org/svn/asterisk/branches/11
  2839. 2014-01-09 23:45 +0000 [r405268] Damien Wedhorn <voip@facts.com.au>
  2840. * channels/chan_dahdi.c: Fix chan_dahdi copile issue in dev-mode.
  2841. Error "unused variable i in dahdi_create_channel_range" when
  2842. compiling in dev-mode. Small restructure to
  2843. dahdi_create_channel_range to move the for(x) loop and int i,x to
  2844. a block within the IFDEF.
  2845. 2014-01-09 23:36 +0000 [r405266] Kevin Harwell <kharwell@digium.com>
  2846. * res/res_pjsip_messaging.c, res/res_pjsip.c: res_pjsip_messaging:
  2847. potential for field values in from/to headers to be missing Added
  2848. in ability to specify display name format ("name"
  2849. <sip:name@ipaddr:port>) for a given URI and made sure it was
  2850. fully propagated to the outgoing message. Also made it so outoing
  2851. messages in res_pjsip always send as "sip:". (closes issue
  2852. ASTERISK-22924) Reported by: Anthony Messina Review:
  2853. https://reviewboard.asterisk.org/r/3094/
  2854. 2014-01-09 20:25 +0000 [r405253] Kinsey Moore <kmoore@digium.com>
  2855. * main/astobj2.c, res/res_pjsip_session.c,
  2856. include/asterisk/astobj2.h: astobj2: Correct ao2_iterator opacity
  2857. violations This corrects the ao2_iterator opacity violations in
  2858. res_pjsip_session.c by adding a global function to get the number
  2859. of elements inside the container hidden behind the iterator.
  2860. (closes issue ASTERISK-23053) Review:
  2861. https://reviewboard.asterisk.org/r/3111/ Reported by: Richard
  2862. Mudgett
  2863. 2014-01-09 16:51 +0000 [r405235] Kevin Harwell <kharwell@digium.com>
  2864. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fails to resume
  2865. WebRTC call from hold In ast_rtp_ice_start if the ice session
  2866. create check list failed, start check was never initiated and
  2867. ice_started was never set to true. Upon re-entering the function
  2868. (for instance, [un]hold) it would try to create the check list
  2869. again with duplicate remote candidates. Fixed so that if the
  2870. create check list fails the necessary data structures are
  2871. properly re-initialized for any subsequent retries. Note, it was
  2872. decided to not stop ice support (by calling ast_rtp_ice_stop) on
  2873. a check list failure because it possible things might still work.
  2874. However, a debug message was added to help with any future
  2875. troubleshooting. (closes issue ASTERISK-22911) Reported by: Vytis
  2876. Valentinavičius Patches: works_on_my_machine.patch uploaded by
  2877. xytis (license 6558) ........ Merged revisions 405234 from
  2878. http://svn.asterisk.org/svn/asterisk/branches/11
  2879. 2014-01-09 15:49 +0000 [r405216] Matthew Jordan <mjordan@digium.com>
  2880. * apps/app_confbridge.c, apps/confbridge/conf_state_multi_marked.c,
  2881. /: app_confbridge: Fix crash caused when waitmarked/marked users
  2882. leave together When waitmarked users join a ConfBridge, the
  2883. conference state is transitioned from EMPTY -> INACTIVE. In this
  2884. state, the users are maintined in a waiting users list. When a
  2885. marked user joins, the ConfBridge conference transitions from
  2886. INACTIVE -> MULTI_MARKED, and all users are put onto the active
  2887. list of users. This process works correctly. When the marked user
  2888. leaves, if they are the last marked user, the MULTI_MARKED state
  2889. does the following: (1) It plays back a message to the bridge
  2890. stating that the leader has left the conference. This requires an
  2891. unlocking of the bridge. (2) It moves waitmarked users back to
  2892. the waiting list (3) It transitions to the appropriate state: in
  2893. this case, INACTIVE However, because it plays the prompt back to
  2894. the bridge before moving the users and before finishing the state
  2895. transition, this creates a race condition: with the bridge
  2896. unlocked, waitmarked users who leave the conference (or are
  2897. kicked from it) can cause a state transition of the bridge to
  2898. another state before the conference is transitioned to the
  2899. INACTIVE state. This causes the state machine to get a bit wonky,
  2900. often leading to a crash when the MULTI_MARKED state attempts to
  2901. conclude its processing. This patch fixes this problem: (1) It
  2902. prevents kicked users from being kicked again. That's just a
  2903. nicety. (2) More importantly, it fixes the race condition by only
  2904. playing the prompt once the state has transitioned correctly to
  2905. INACTIVE. If waitmarked users sneak out during the prompt being
  2906. played, no harm no foul. Review:
  2907. https://reviewboard.asterisk.org/r/3108/ (closes issue AST-1258)
  2908. Reported by: Steve Pitts ........ Merged revisions 405215 from
  2909. http://svn.asterisk.org/svn/asterisk/branches/11
  2910. 2014-01-09 14:14 +0000 [r405162] Walter Doekes <walter+asterisk@wjd.nu>
  2911. * /, apps/app_dumpchan.c: "Minimun" typo. ........ Merged revisions
  2912. 405160 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  2913. ........ Merged revisions 405161 from
  2914. http://svn.asterisk.org/svn/asterisk/branches/11
  2915. 2014-01-08 16:48 +0000 [r405131] Mark Michelson <mmichelson@digium.com>
  2916. * res/res_pjsip/security_events.c: Use proper case for checking if
  2917. digest authentication is used.
  2918. 2014-01-08 16:28 +0000 [r405083-405124] Kinsey Moore <kmoore@digium.com>
  2919. * /, configure, configure.ac, pbx/pbx_lua.c: pbx_lua: Add support
  2920. for Lua 5.2 This adds support for Lua 5.2 in pbx_lua which is
  2921. available on newer operating systems. (closes issue
  2922. ASTERISK-23011) Review: https://reviewboard.asterisk.org/r/3075/
  2923. Reported by: George Joseph Patch by: George Joseph ........
  2924. Merged revisions 405090 from
  2925. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2926. revisions 405091 from
  2927. http://svn.asterisk.org/svn/asterisk/branches/11
  2928. * /, channels/chan_sip.c: Add the missing part of r400140 When the
  2929. patch to add retry-on-forbidden-response was committed, part of
  2930. the patch for chan_sip was not committed which caused the feature
  2931. to be entirely nonfunctional. This corrects the code in question.
  2932. (closes issue ASTERISK-17138) Review:
  2933. https://reviewboard.asterisk.org/r/2874 ........ Merged revisions
  2934. 405033 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  2935. ........ Merged revisions 405081 from
  2936. http://svn.asterisk.org/svn/asterisk/branches/11
  2937. 2014-01-07 19:55 +0000 [r405019-405034] Joshua Colp <jcolp@digium.com>
  2938. * res/res_pjsip_acl.c: res_pjsip_acl: Fix another case of assuming
  2939. a contact will always contain a URI.
  2940. * res/res_pjsip_nat.c: res_pjsip_nat: Don't assume a Contact header
  2941. will always contain a URI. If the 'rewrite_contact' option was
  2942. enabled and a Contact header was received which contained a '*' a
  2943. crash would occur. This change makes the res_pjsip_nat module
  2944. ignore the Contact header if it contains only a '*'. (closes
  2945. issue ASTERISK-23101) Reported by: Matt Jordan
  2946. 2014-01-06 21:54 +0000 [r404952-405006] Richard Mudgett <rmudgett@digium.com>
  2947. * apps/app_voicemail.c: app_voicemail: Explicitly set
  2948. defaultenabled=yes
  2949. * res/res_mwi_external_ami.c (added): External MWI AMI support. The
  2950. external MWI AMI interface provides a thin wrapper around the
  2951. core external MWI resource. The resource adds the following AMI
  2952. actions: MWIGet, MWIDelete, and MWIUpdate. (closes issue AFS-46)
  2953. Review: https://reviewboard.asterisk.org/r/3061/
  2954. * apps/app_voicemail.c, res/res_mwi_external.c (added),
  2955. configs/sorcery.conf.sample, include/asterisk/res_mwi_external.h
  2956. (added), res/res_mwi_external.exports.in (added): External MWI
  2957. core support. * The core external MWI resource provides for MWI
  2958. message counts persistence using sorcery. With sorcery, the user
  2959. is able to configure which sorcery wizzard backend to use if the
  2960. default astdb is not desired. * The core external MWI resoruce
  2961. provides some debugging CLI commands enabled by defining
  2962. MWI_DEBUG_CLI. The debugging CLI commands are: "mwi delete all",
  2963. "mwi delete like <regex>", "mwi delete mailbox <mailbox>", "mwi
  2964. list all", "mwi list like <regex>", "mwi show mailbox <mailbox>",
  2965. and "mwi update mailbox <mailbox> [<new> [<old>]]". (closes issue
  2966. AFS-43) Review: https://reviewboard.asterisk.org/r/3061/
  2967. 2014-01-05 16:00 +0000 [r404923-404935] Joshua Colp <jcolp@digium.com>
  2968. * res/res_pjsip_outbound_registration.c:
  2969. res_pjsip_outbound_registration: Don't assume that a registration
  2970. client will always exist.
  2971. * res/res_pjsip_outbound_registration.c:
  2972. res_pjsip_outbound_registration: Create registration client in pj
  2973. thread. Depending on which threading was loading the outbound
  2974. registration it was possible for the registration client to be
  2975. allocated outside of a pj thread. This change moves the creation
  2976. inside the synchronous task where it is guaranteed it will occur
  2977. in a pj thread. Reported by: Rob Thomas
  2978. 2014-01-04 10:42 +0000 [r404911] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  2979. * main/asterisk.c, /: asterisk.c: suppress live_dangerously warning
  2980. on rasterisk Even since the fixes of AST-2013-007, Asterisk
  2981. prints the following warning on startup if the user decided to
  2982. live dangerously: Privilege escalation protection disabled! See
  2983. https://wiki.asterisk.org/wiki/x/1gKfAQ for more details. This
  2984. message is intended for the logs and interactive startup. No need
  2985. for it to appear on a remote console. This commit removes it from
  2986. there. (closes issue ASTERISK-23084) Review:
  2987. https://reviewboard.asterisk.org/r/3101/ ........ Merged
  2988. revisions 404861 from
  2989. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2990. revisions 404888 from
  2991. http://svn.asterisk.org/svn/asterisk/branches/11
  2992. 2014-01-03 21:59 +0000 [r404859] Kevin Harwell <kharwell@digium.com>
  2993. * /, cel/cel_pgsql.c: cel_pgsql: module not correctly reloading
  2994. Upon reload the module unconditionally "unloaded" the module
  2995. (freeing memory and setting pointers to NULL) and then when
  2996. attempting a "load" if the config file had not changed then
  2997. nothing would be reinitialized. By moving the "unload" to occur
  2998. conditionally (reload only) after an attempted configuration
  2999. load, but before module "loading" alleviates the issue. The
  3000. module now loads/unloads/reloads correctly. (closes issue
  3001. ASTERISK-22871) Reported by: Matteo ........ Merged revisions
  3002. 404857 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  3003. ........ Merged revisions 404858 from
  3004. http://svn.asterisk.org/svn/asterisk/branches/11
  3005. 2014-01-03 21:45 +0000 [r404843-404855] Matthew Jordan <mjordan@digium.com>
  3006. * res/res_pjsip_logger.c: res_pjsip_logger: Add the
  3007. ASTERISK_FILE_VERSION macro Registering yourself with the
  3008. Asterisk core is the nice thing to do, even when you're a logging
  3009. module.
  3010. * res/res_pjsip_authenticator_digest.c, tests/test_utils.c:
  3011. res_pjsip_authenticator_digest: Fix md5 hash buffer An md5 hash
  3012. is 32 bytes long. The char buffer must be at least 33 bytes to
  3013. avoid clobbering of the stack. This patch also fixes a potential
  3014. clobbering in test_utils.c. Thanks to Andrew Nagy for reporting
  3015. and testing this out in #asterisk-dev Reported by: Andrew Nagy
  3016. Tested by: Andrew Nagy
  3017. 2014-01-03 19:00 +0000 [r404781-404786] Kevin Harwell <kharwell@digium.com>
  3018. * channels/chan_dahdi.c, /: chan_dahdi: dahdi show channels slices
  3019. PRI channel dnid on output dahdi show channels output slices the
  3020. callerid (which is dnid copied over on PRI channels). If the
  3021. channel naming structures look like: 'DAHDI/i1/1408409XXXX-6'
  3022. then the output slices 1408409XXXX down to 1408409XXX. This patch
  3023. just opens it up to 15 chars so you can see the whole thing.
  3024. (closes issue ASTERISK-22918) Reported by: outtolunc Patches:
  3025. svn_chan_dahdi.c.format12_15.diff.txt uploaded by outtolunc
  3026. (license 5198) ........ Merged revisions 404784 from
  3027. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3028. revisions 404785 from
  3029. http://svn.asterisk.org/svn/asterisk/branches/11
  3030. * /, apps/app_meetme.c: app_meetme: compiler warning Fixed a
  3031. compiler warning (errors in 'dev-mode') given by gcc version
  3032. 4.8.1. The one in app_meetme involved the
  3033. 'sizeof-pointer-memaccess' (see:
  3034. http://gcc.gnu.org/gcc-4.8/porting_to.html) warning. Fixed so it
  3035. would no longer issue a warning and can compile again in
  3036. 'dev-mode'. Review: https://reviewboard.asterisk.org/r/3098/
  3037. ........ Merged revisions 404742 from
  3038. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3039. revisions 404773 from
  3040. http://svn.asterisk.org/svn/asterisk/branches/11
  3041. 2014-01-03 18:24 +0000 [r404764] Richard Mudgett <rmudgett@digium.com>
  3042. * tests/test_stasis.c: test_stasis.c: Fix ref leak in normal
  3043. execution path.
  3044. 2014-01-03 17:25 +0000 [r404725-404737] Joshua Colp <jcolp@digium.com>
  3045. * res/res_pjsip/pjsip_configuration.c, res/res_pjsip/location.c:
  3046. res_pjsip: Ensure more URI validation happens in pj threads.
  3047. * res/res_pjsip_outbound_registration.c:
  3048. res_pjsip_outbound_registration: Ensure URI validation happens in
  3049. a pjlib thread. This change moves outbound registration URI
  3050. validation into the task executed within a pjlib thread. Reported
  3051. by: Andrew Nagy
  3052. 2014-01-02 19:37 +0000 [r404676] Scott Griepentrog <sgriepentrog@digium.com>
  3053. * /, funcs/func_strings.c: func_strings: use memmove to prevent
  3054. overlapping memory on strcpy When calling REPLACE() with an empty
  3055. replace-char argument, strcpy is used to overwrite the the
  3056. matching <find-char>. However as the src and dest arguments to
  3057. strcpy must not overlap, it causes other parts of the string to
  3058. be overwritten with adjacent characters and the result is
  3059. mangled. Patch replaces call to strcpy with memmove and adds a
  3060. test suite case for REPLACE. (closes issue ASTERISK-22910)
  3061. Reported by: Gareth Palmer Review:
  3062. https://reviewboard.asterisk.org/r/3083/ Patches:
  3063. func_strings.patch uploaded by Gareth Palmer (license 5169)
  3064. ........ Merged revisions 404674 from
  3065. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3066. revisions 404675 from
  3067. http://svn.asterisk.org/svn/asterisk/branches/11
  3068. 2014-01-02 19:06 +0000 [r404663] Kevin Harwell <kharwell@digium.com>
  3069. * channels/chan_pjsip.c, include/asterisk/res_pjsip.h,
  3070. configs/pjsip.conf.sample, res/res_pjsip/pjsip_configuration.c,
  3071. CHANGES, res/res_pjsip.c: res_pjsip: add 'set_var' support on
  3072. endpoints Added a new 'set_var' option for ast_sip_endpoint(s).
  3073. For each variable specified that variable gets set upon creation
  3074. of a pjsip channel involving the endpoint. (closes issue
  3075. ASTERISK-22868) Reported by: Joshua Colp Review:
  3076. https://reviewboard.asterisk.org/r/3095/
  3077. 2013-12-31 22:49 +0000 [r404613-404652] Joshua Colp <jcolp@digium.com>
  3078. * channels/chan_pjsip.c, res/res_pjsip_session.c: chan_pjsip:
  3079. Handle hanging up before calling. Channel creation in Asterisk is
  3080. broken up into two steps: requesting and calling. In some cases a
  3081. channel may be requested but never called. This happens in the
  3082. ChanIsAvail dialplan application for determining if something is
  3083. reachable or not. The PJSIP channel driver did not take this
  3084. situation into account and attempted to end a session that was
  3085. never called out on. The code now checks the session state to
  3086. determine if the session has been called out on and if not
  3087. terminates it instead of ending it. (closes issue ASTERISK-23074)
  3088. Reported by: Kilburn
  3089. * res/res_pjsip_endpoint_identifier_ip.c:
  3090. res_pjsip_endpoint_identifier_ip: Accept hostnames in the 'match'
  3091. field. Hostnames specified in the 'match' field will be resolved
  3092. and all addresses returned. Each address will be added to the
  3093. endpoint identifier for the matching process. Reported by: Rob
  3094. Thomas
  3095. 2013-12-31 21:38 +0000 [r404605] Kevin Harwell <kharwell@digium.com>
  3096. * /, cel/cel_pgsql.c: cel_pgsql: deadlock on unload and
  3097. core_event_dispatcher A deadlock can happen between a thread
  3098. unloading or reloading the cel_pgsql module and the
  3099. core_event_dispatcher taskprocessor thread. Description of what
  3100. is happening: Thread 1 (for example, a netconsole thread): a
  3101. "module reload cel_pgsql" is launched the thread enter the
  3102. "my_unload_module" function (cel_pgsql.c) the thread acquire the
  3103. write lock on psql_columns the thread enter the
  3104. "ast_event_unsubscribe" function (event.c) the thread try to
  3105. acquire the write lock on ast_event_subs[sub->type] Thread 2
  3106. (core_event_dispatcher taskprocessor thread): the taskprocessor
  3107. pop a CEL event the thread enter the "handle_event" function
  3108. (event.c) the thread acquire the read lock on
  3109. ast_event_subs[sub->type] the thread callback the "pgsql_log"
  3110. function (cel_pgsql.c), since it's a subscriber of CEL events the
  3111. thread try to acquire a read lock on psql_columns (closes issue
  3112. ASTERISK-22854) Reported by: Etienne Lessard Patches:
  3113. cel_pgsql_fix_deadlock_event.patch uploaded by hexanol (license
  3114. 6394) ........ Merged revisions 404603 from
  3115. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3116. revisions 404604 from
  3117. http://svn.asterisk.org/svn/asterisk/branches/11
  3118. 2013-12-31 20:26 +0000 [r404592] Joshua Colp <jcolp@digium.com>
  3119. * res/res_pjsip_outbound_registration.c:
  3120. res_pjsip_outbound_registration: Add validation for 'server_uri'
  3121. and 'client_uri'. When applying configuration for outbound
  3122. registrations the 'server_uri' and 'client_uri' fields were not
  3123. validated. The code will now confirm that they exist and that
  3124. they contain parseable SIP URIs. Reported by: Andrew Nagy
  3125. 2013-12-30 23:21 +0000 [r404581] Kevin Harwell <kharwell@digium.com>
  3126. * main/channel.c, /: channels.c: core show channeltypes slicing
  3127. 'core show channeltypes' type column is being sliced, resulting
  3128. in incomplete type names. (closes issue ASTERISK-22919) Reported
  3129. by: outtolunc Patches: svn_channel.c.format_15.diff.txt uploaded
  3130. by outtolunc (license 5198) ........ Merged revisions 404579 from
  3131. http://svn.asterisk.org/svn/asterisk/branches/11
  3132. 2013-12-24 17:10 +0000 [r404565-404568] David M. Lee <dlee@digium.com>
  3133. * UPGRADE.txt: Added note to UPGRADE.txt about the default value of
  3134. live_dangerously changing
  3135. * main/http.c: http: Properly reject requests with
  3136. Transfer-Encoding set Asterisk does not support any of the
  3137. transfer encodings specified in HTTP/1.1, other than the default
  3138. "identity" encoding. According to RFC 2616: A server which
  3139. receives an entity-body with a transfer-coding it does not
  3140. understand SHOULD return 501 (Unimplemented), and close the
  3141. connection. A server MUST NOT send transfer-codings to an
  3142. HTTP/1.0 client. This patch adds the 501 Unimplemented response,
  3143. instead of the hard work of actually implementing other
  3144. recordings. This behavior is especially problematic for Node.js
  3145. clients, which use chunked encoding by default. (closes issue
  3146. ASTERISK-22486) Review: https://reviewboard.asterisk.org/r/3092/
  3147. 2013-12-24 02:19 +0000 [r404553] Joshua Colp <jcolp@digium.com>
  3148. * res/res_pjsip_pubsub.c: res_pjsip_pubsub: Ensure dialog
  3149. manipulation happens on proper thread. When destroying a
  3150. subscription we remove the serializer from its dialog and
  3151. decrease its reference count. Depending on which thread dropped
  3152. the subscription reference count to 0 it was possible for this to
  3153. occur in a thread where it is not possible. (closes issue
  3154. ASTERISK-22952) Reported by: Matt Jordan
  3155. 2013-12-21 03:34 +0000 [r404531] Matthew Jordan <mjordan@digium.com>
  3156. * res/res_pjsip/pjsip_cli.c: res_pjsip/pjsip_cli: fix compilation
  3157. error caused by passing ast_free When wanting to pass *free as a
  3158. function pointer, ast_free_ptr has to be used instead of
  3159. ast_free. This allows it to be compiled with MALLOC_DEBUG
  3160. enabled.
  3161. 2013-12-20 22:02 +0000 [r404509] David M. Lee <dlee@digium.com>
  3162. * res/ari/resource_channels.h, rest-api/api-docs/applications.json,
  3163. rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  3164. res/res_ari_channels.c: ari: Remove support for specifying
  3165. channel vars during origination. When we added support for
  3166. specifying channel variables for an origination, we didn't
  3167. consider how that would interact with another feature, namely
  3168. specifying request parameters in a JSON request body. The method
  3169. of specifying channel variables (as a flat JSON object passed in
  3170. the JSON body) interferes with parsing parameters out of the
  3171. request body. Unfortunately, fixing this would be a backward
  3172. incompatible change. In the interest of keeping the API sane and
  3173. keeping our release schedule, we're dropping the feature for
  3174. specifying channel variables in the origination request. We will
  3175. bring the feature back soon, as a backward compatible addition to
  3176. the API. (closes issue ASTERISK-23051) Review:
  3177. https://reviewboard.asterisk.org/r/3088
  3178. 2013-12-20 Asterisk Development Team <asteriskteam@digium.com>
  3179. * Asterisk 12.0.0 Released.
  3180. 2013-12-20 22:02 +0000 [r404509] David M. Lee <dlee@digium.com>
  3181. * rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  3182. res/res_ari_channels.c, res/ari/resource_channels.h,
  3183. rest-api/api-docs/applications.json: ari: Remove support for
  3184. specifying channel vars during origination. When we added support
  3185. for specifying channel variables for an origination, we didn't
  3186. consider how that would interact with another feature, namely
  3187. specifying request parameters in a JSON request body. The method
  3188. of specifying channel variables (as a flat JSON object passed in
  3189. the JSON body) interferes with parsing parameters out of the
  3190. request body. Unfortunately, fixing this would be a backward
  3191. incompatible change. In the interest of keeping the API sane and
  3192. keeping our release schedule, we're dropping the feature for
  3193. specifying channel variables in the origination request. We will
  3194. bring the feature back soon, as a backward compatible addition to
  3195. the API. (closes issue ASTERISK-23051) Review:
  3196. https://reviewboard.asterisk.org/r/3088
  3197. 2013-12-20 21:25 +0000 [r404480-404488] Matthew Jordan <mjordan@digium.com>
  3198. * /: Remove automerge properties
  3199. * res/res_pjsip/pjsip_cli.c (added), include/asterisk/sorcery.h,
  3200. res/res_pjsip/pjsip_configuration.c,
  3201. res/res_pjsip/include/res_pjsip_private.h,
  3202. res/res_pjsip_registrar.c, main/sorcery.c,
  3203. include/asterisk/res_pjsip.h, CREDITS,
  3204. res/res_pjsip/config_auth.c, /,
  3205. res/res_pjsip_endpoint_identifier_ip.c,
  3206. include/asterisk/config.h, main/config.c, main/channel.c,
  3207. res/res_pjsip/location.c, include/asterisk/res_pjsip_cli.h
  3208. (added): res_pjsip: Add PJSIP CLI commands Implements the
  3209. following cli commands: pjsip list aors pjsip list auths pjsip
  3210. list channels pjsip list contacts pjsip list endpoints pjsip show
  3211. aor(s) pjsip show auth(s) pjsip show channels pjsip show
  3212. endpoint(s) Also... Minor modifications made to the AMI command
  3213. implementations to facilitate reuse. New function
  3214. ast_variable_list_sort added to config.c and config.h to
  3215. implement variable list sorting. (issue ASTERISK-22610) patches:
  3216. pjsip_cli_v2.patch uploaded by george.joseph (License 6322)
  3217. 2013-12-20 21:16 +0000 [r404458] Scott Griepentrog <sgriepentrog@digium.com>
  3218. * /, main/say.c: say.c: correct time for polish In
  3219. ast_say_date_with_format_pl(), change ast_say_number() to use
  3220. tm_sec instead of tm_mn. (closes issue ASTERISK-22856) Reported
  3221. by: Robert Mordec Review:
  3222. https://reviewboard.asterisk.org/r/3082/ Patches: say.c.patch
  3223. uploaded by veilen (license 6555) ........ Merged revisions
  3224. 404456 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  3225. ........ Merged revisions 404457 from
  3226. http://svn.asterisk.org/svn/asterisk/branches/11
  3227. 2013-12-20 20:11 +0000 [r404439] Mark Michelson <mmichelson@digium.com>
  3228. * res/res_pjsip_refer.c: Fix issue where PJSIP blind transferer
  3229. dialog may not complete as planned. When transferring to a
  3230. dialplan extension that will not place any outbound calls, the
  3231. only control frames that the PJSIP REFER framehook will receive
  3232. are inconsequential (such as unhold or srcchange). As such, we
  3233. shouldn't allow for the reception of those types of frames
  3234. prevent us from signaling to the transferring party that the
  3235. transfer has completed successfully once voice frames are read.
  3236. Thanks to Jonathan Rose for pointing this out.
  3237. 2013-12-20 20:04 +0000 [r404437] Matthew Jordan <mjordan@digium.com>
  3238. * res/ari/resource_applications.h, res/res_stasis_device_state.c:
  3239. res_stasis_device_state: Set resource type for subscriptions to
  3240. deviceState The documentation for ARI already specifies that the
  3241. device state resource when used for subscribing for events is
  3242. "deviceState", not "device_state". The code, however, used
  3243. "device_state"; although this was inconsistent as well in doxygen
  3244. comments in resource_applications. Because the actual resource
  3245. being subscribed to is /deviceStates/{device}/, it makes sense
  3246. for the resource type specifier to be deviceState. Note that the
  3247. key value in the events is still "device_state".
  3248. 2013-12-20 19:52 +0000 [r404434] Richard Mudgett <rmudgett@digium.com>
  3249. * res/res_pjsip/location.c, tests/test_cel.c,
  3250. res/ari/resource_channels.c, tests/test_scoped_lock.c,
  3251. tests/test_stasis.c, res/parking/parking_manager.c,
  3252. res/ari/resource_bridges.c, res/ari/resource_endpoints.c:
  3253. ao2_iterator: Mini-audit of the ao2_iterator loops in the new
  3254. code files. * Fixed several places where ao2_iterator_destroy()
  3255. was not called. * Fixed several iterator loop object variable
  3256. reference problems. * Fixed res_parking AMI actions returning
  3257. non-zero. Only the AMI logoff action can return non-zero. Review:
  3258. https://reviewboard.asterisk.org/r/3087/
  3259. 2013-12-20 19:17 +0000 [r404421] Matthew Jordan <mjordan@digium.com>
  3260. * include/asterisk/manager.h: manager: bump version to 2.0.0 AMI
  3261. has received substantial updates over the past year. Not only has
  3262. the syntax been vastly improved and made consistent (which
  3263. entails many event changes), but the underlying things that those
  3264. events convey have changed substantially as well. After some
  3265. conversation in #asterisk-dev, it was agreed that this is a good
  3266. time to jump to 2. At the same time, since ARI will most likely
  3267. use semantic versioning, we might as well use that for AMI as
  3268. well. That also affords us greater meaning for the AMI version.
  3269. 2013-12-20 19:06 +0000 [r404419] Richard Mudgett <rmudgett@digium.com>
  3270. * main/sounds_index.c: Whitespace fixes.
  3271. 2013-12-20 17:21 +0000 [r404405] Rusty Newton <rnewton@digium.com>
  3272. * configs/pjsip.conf.sample: Documentation: Updates for info about
  3273. NAT-related settings and fixes for pjsip.conf.sample Added
  3274. another NAT example to pjsip.conf.sample. We had a few mentions
  3275. of NAT configuration throughout the sample, but I added another
  3276. for a little bit more clarity. Additionally many pjsip options
  3277. were affected by the change to snake case, so I fixed any
  3278. instances of those options in pjsip.conf. I regenerated the
  3279. config option list (at the bottom of the file) from a new xml
  3280. config doc dump, so all the snake case changes should be
  3281. reflected there, as well as any other changes to those options.
  3282. (issue ASTERISK-23004) (closes issue ASTERISK-23004) Reported by:
  3283. Matt Jordan Review: https://reviewboard.asterisk.org/r/3086/
  3284. 2013-12-19 18:15 +0000 [r404375] Richard Mudgett <rmudgett@digium.com>
  3285. * CHANGES: Put notice in CHANGES as well as UPGRADE.txt.
  3286. 2013-12-19 17:58 +0000 [r404369-404371] Joshua Colp <jcolp@digium.com>
  3287. * res/res_pjsip/pjsip_outbound_auth.c: res_pjsip: Ignore 401/407
  3288. responses for transactions and dialogs we don't know about. Under
  3289. normal conditions it is unlikely we will ever receive a response
  3290. for a transaction or dialog we don't know about but if any are
  3291. received ignore them.
  3292. * res/res_pjsip_session.c: res_pjsip_session: Fix SDP negotiation
  3293. when resending an INVITE with authentication. The process for
  3294. resending an INVITE with authentication involves restarting the
  3295. UAC session. We were incorrectly passing in that a new offer is
  3296. being sent, causing the SDP negotiation to get into a
  3297. (technically speaking) funky state.
  3298. 2013-12-19 17:15 +0000 [r404356] Mark Michelson <mmichelson@digium.com>
  3299. * include/asterisk/channel.h, res/res_pjsip.c, main/channel.c,
  3300. include/asterisk/autochan.h: Fix a deadlock that occurred due to
  3301. a conflict of masquerades. For the explanation, here is a
  3302. copy-paste of the review board explanation: Initially, it was
  3303. discovered that performing an attended transfer of a multiparty
  3304. bridge with a PJSIP channel would cause a deadlock. A PBX thread
  3305. started a masquerade and reached the point where it was calling
  3306. the fixup() callback on the "original" channel. For chan_pjsip,
  3307. this involves pushing a synchronous task to the session's
  3308. serializer. The problem was that a task ahead of the fixup task
  3309. was also attempting to perform a channel masquerade. However,
  3310. since masquerades are designed in a way to only allow for one to
  3311. occur at a time, the task ahead of the fixup could not continue
  3312. until the masquerade already in progress had completed. And of
  3313. course, the masquerade in progress could not complete until the
  3314. task ahead of the fixup task had completed. Deadlock. The initial
  3315. fix was to change the fixup task to be asynchronous. While this
  3316. prevented the deadlock from occurring, it had the frightful side
  3317. effect of potentially allowing for tasks in the session's
  3318. serializer to operate on a zombie channel. Taking a step back
  3319. from this particular deadlock, it became clear that the problem
  3320. was not really this one particular issue but that masquerades
  3321. themselves needed to be addressed. A PJSIP attended transfer
  3322. operation calls ast_channel_move(), which attempts to both set up
  3323. and execute a masquerade. The problem was that after it had set
  3324. up the masquerade, the PBX thread had swooped in and tried to
  3325. actually perform the masquerade. Looking at changes that had been
  3326. made to Asterisk 12, it became clear that there never is any time
  3327. now that anyone ever wants to set up a masquerade and allow for
  3328. the channel thread to actually perform the masquerade. Everyone
  3329. always is calling ast_channel_move(), performs the masquerade
  3330. itself before returning. In this patch, I have removed all blocks
  3331. of code from channel.c that will attempt to perform a masquerade
  3332. if ast_channel_masq() returns true. Now, there is no distinction
  3333. between setting up a masquerade and performing the masquerade. It
  3334. is one operation. The only remaining checks for
  3335. ast_channel_masq() and ast_channel_masqr() are in ast_hangup()
  3336. since we do not want to interrupt a masquerade by hanging up the
  3337. channel. Instead, now ast_hangup() will wait for a masquerade to
  3338. complete before moving forward with its operation. The
  3339. ast_channel_move() function has been modified to basically
  3340. in-line the logic that used to be in ast_channel_masquerade().
  3341. ast_channel_masquerade() has been killed off for real.
  3342. ast_channel_move() now has a lock associated with it that is used
  3343. to prevent any simultaneous moves from occurring at once. This
  3344. means there is no need to make sure that ast_channel_masq() or
  3345. ast_channel_masqr() are already set on a channel when
  3346. ast_channel_move() is called. It also means the channel container
  3347. lock is not pulling double duty by both keeping the container
  3348. locked and preventing multiple masquerades from occurring
  3349. simultaneously. The ast_do_masquerade() function has been renamed
  3350. to do_channel_masquerade() and is now internal to channel.c. The
  3351. function now takes explicit arguments of which channels are
  3352. involved in the masquerade instead of a single channel. While it
  3353. probably is possible to do some further refactoring of this
  3354. method, I feel that I would be treading dangerously. Instead, all
  3355. I did was change some comments that no longer are true after this
  3356. changeset. The other more minor change introduced in this patch
  3357. is to res_pjsip.c to make ast_sip_push_task_synchronous() run the
  3358. task in-place if we are already a SIP servant thread. This is
  3359. related to this patch because even when we isolate the channel
  3360. masquerade to only running in the SIP servant thread, we would
  3361. still deadlock when the fixup() callback is reached since we
  3362. would essentially be waiting forever for ourselves to finish
  3363. before actually running the fixup. This makes it so the fixup is
  3364. run without having to push a task into a serializer at all.
  3365. (closes issue ASTERISK-22936) Reported by Jonathan Rose Review:
  3366. https://reviewboard.asterisk.org/r/3069
  3367. 2013-12-19 17:03 +0000 [r404354] Richard Mudgett <rmudgett@digium.com>
  3368. * main/udptl.c, addons/chan_ooh323.c, channels/chan_sip.c,
  3369. include/asterisk/udptl.h: udptl: Dead code elimination.
  3370. ast_udptl_bridge was not used. Removing dead code starting with
  3371. ast_udptl_bridge() eliminated the code in this change. Note: This
  3372. code has actually been dead since Asterisk v1.4 when it was first
  3373. put in. Review: https://reviewboard.asterisk.org/r/3079/
  3374. 2013-12-19 17:02 +0000 [r404352] Scott Griepentrog <sgriepentrog@digium.com>
  3375. * /, res/res_fax.c: res_fax.c: crash on framehook with no dsp in
  3376. fax detect In fax_detect_framehook() a null pointer reference can
  3377. occur where a voice frame is processed but no dsp is attached to
  3378. the fax detection structure. The code block that rejects frames
  3379. that detection cannot be processed on is checking for dsp but
  3380. falls through when it should instead return, as this change
  3381. implements. (closes issue ASTERISK-22942) Reported by: adomjan
  3382. Review: https://reviewboard.asterisk.org/r/3076/ ........ Merged
  3383. revisions 404351 from
  3384. http://svn.asterisk.org/svn/asterisk/branches/11
  3385. 2013-12-19 16:37 +0000 [r404348] Richard Mudgett <rmudgett@digium.com>
  3386. * channels/chan_dahdi.h, channels/chan_h323.c, main/app.c,
  3387. configs/sip.conf.sample, channels/sip/include/sip.h,
  3388. channels/chan_mgcp.c, apps/app_voicemail.c,
  3389. channels/chan_unistim.c, configs/chan_dahdi.conf.sample,
  3390. channels/chan_sip.c, configs/voicemail.conf.sample,
  3391. funcs/func_vmcount.c, UPGRADE.txt, res/res_xmpp.c,
  3392. configs/skinny.conf.sample, res/res_jabber.c, CHANGES,
  3393. channels/chan_iax2.c, channels/h323/chan_h323.h,
  3394. channels/sig_pri.c, configs/iax.conf.sample, channels/sig_pri.h,
  3395. include/asterisk/app.h, channels/chan_dahdi.c,
  3396. channels/chan_skinny.c: Voicemail: Remove mailbox identifier
  3397. format (box@context) assumptions in the system. This change is in
  3398. preparation for external MWI support. Removed code from the
  3399. system for normal mailbox handling that appends @default to the
  3400. mailbox identifier if it does not have a context. The only
  3401. exception is the legacy hasvoicemail users.conf option. The
  3402. legacy option will only work for app_voicemail mailboxes. The
  3403. system cannot make any assumptions about the format of the
  3404. mailbox identifer used by app_voicemail. chan_sip and
  3405. chan_dahdi/sig_pri had the most changes because they both tried
  3406. to interpret the mailbox identifier. chan_sip just stored and
  3407. compared the two components. chan_dahdi actually used the box
  3408. information. The ISDN MWI support configuration options had to be
  3409. reworked because chan_dahdi was parsing the box@context format to
  3410. get the box number. As a result the mwi_vm_boxes chan_dahdi.conf
  3411. option was added and is documented in the chan_dahdi.conf.sample
  3412. file. Review: https://reviewboard.asterisk.org/r/3072/
  3413. 2013-12-19 16:31 +0000 [r404345] Scott Griepentrog <sgriepentrog@digium.com>
  3414. * /, main/db.c: astdb: crash in sqlite3 during shutdown When
  3415. Asterisk is shut down, the astdb_atexit() function releases
  3416. (finalize) the previously initiated (prepared) SQL statements in
  3417. sqlite3. Another thread making a subsequent request can cause a
  3418. crash in sqlite3. This patch eliminates that issue by resetting
  3419. the statement pointer after it is released/cleared. The sqlite3
  3420. code detects the null pointer, and aborts the operation cleanly.
  3421. (closes issue AST-1265) Reported by: Alexander Hömig (closes
  3422. issue ASTERISK-22350) Reported by: Birger "WIMPy" Harzenetter
  3423. Review: https://reviewboard.asterisk.org/r/3078/ ........ Merged
  3424. revisions 404344 from
  3425. http://svn.asterisk.org/svn/asterisk/branches/11
  3426. 2013-12-19 12:17 +0000 [r404332] Joshua Colp <jcolp@digium.com>
  3427. * main/channel.c: channel: Add a missing ast_channel_unlock when
  3428. allocating a Surrogate channel.
  3429. 2013-12-19 08:19 +0000 [r404320] Alexandr Anikin <may@telecom-service.ru>
  3430. * addons/ooh323c/src/oochannels.c, addons/ooh323c/src/ooGkClient.c,
  3431. addons/chan_ooh323.c, /, addons/ooh323c/src/ooGkClient.h: Handle
  3432. temporary failures on gk registration Introduce new 'stopped'
  3433. state for gk client and restart gk client on failures Remove
  3434. ooh323 stack command lock as it is not need now. (closes issue
  3435. ASTERISK-21960) Reported by: Dmitry Melekhov Patches:
  3436. ASTERISK-21960.patch ASTERISK-21960-stacklockup-2.patch Tested
  3437. by: Dmitry Melekhov ........ Merged revisions 404318 from
  3438. http://svn.asterisk.org/svn/asterisk/branches/11
  3439. 2013-12-19 02:53 +0000 [r404306] Damien Wedhorn <voip@facts.com.au>
  3440. * channels/chan_skinny.c: Fixup some skinny bugs causing Fracks and
  3441. ao2 cleanup issues. Moved channel locking into setsubstate so
  3442. that a process can complete working on a sub before another
  3443. starts changing it. The existing code was causing some Fracks
  3444. with schedule deletion. Removed multiple rtp cleanup. Now only
  3445. cleansup up once, fixing ao2 object cleanup issues.
  3446. 2013-12-19 00:47 +0000 [r404294] Matthew Jordan <mjordan@digium.com>
  3447. * apps/app_cdr.c, main/cdr.c, apps/app_forkcdr.c, main/pbx.c,
  3448. funcs/func_cdr.c, apps/app_disa.c, UPGRADE.txt,
  3449. include/asterisk/cdr.h, CHANGES: app_cdr,app_forkcdr,func_cdr:
  3450. Synchronize with engine when manipulating state When doing the
  3451. rework of the CDR engine that pushed all of the logic into cdr.c
  3452. and made it respond to changes in channel state over Stasis, we
  3453. knew that accessing the CDR engine from the dialplan would be
  3454. "slightly" non-deterministic. Dialplan threads would be accessing
  3455. CDRs while Stasis threads would be updating the state of said
  3456. CDRs - whereas in the past, everything happened on the dialplan
  3457. threads. Tests have shown that "slightly" is in reality "very".
  3458. This patch synchronizes things by making the dialplan
  3459. applications/functions that manipulate CDRs do so over Stasis.
  3460. ForkCDR, NoCDR, ResetCDR, CDR, and CDR_PROP now all use Stasis to
  3461. send their requests over to the CDR engine, and synchronize on
  3462. the channel Stasis topic via a subscription so that they return
  3463. their values/control to the dialplan at the appropriate time.
  3464. While going through this, the following changes were also made: *
  3465. DISA, which can reset the CDR when a user successfully
  3466. authenticates, now just uses the ResetCDR app to do this. This
  3467. prevents having to duplicate the same Stasis synchronization
  3468. logic in that application. * Answer no longer disables CDRs. It
  3469. actually didn't work anyway - calling DISABLE on the channel's
  3470. CDR doesn't stop the CDR from getting the Answer time - it just
  3471. kills all CDRs on that channel, which isn't what the caller would
  3472. intend. (closes issue ASTERISK-22884) (closes issue
  3473. ASTERISK-22886) Review: https://reviewboard.asterisk.org/r/3057/
  3474. 2013-12-19 00:29 +0000 [r404292] Damien Wedhorn <voip@facts.com.au>
  3475. * channels/chan_skinny.c: Fixup skinny registration following
  3476. network issues. On session registration, if device is already
  3477. reporting that it is connected to a device, an innocuous packet
  3478. (update time) is sent to the already connected device. If the tcp
  3479. connection is down, the device will be unregistered and the new
  3480. connection allowed. Without this patch, network issues can see a
  3481. situation where a device can not reregister until after
  3482. 3*timeout.
  3483. 2013-12-18 22:50 +0000 [r404279] Jason Parker <jparker@digium.com>
  3484. * main/manager.c, /: Add AMI event for presence state. Review:
  3485. https://reviewboard.asterisk.org/r/3039/ ........ Merged
  3486. revisions 404275 from
  3487. http://svn.asterisk.org/svn/asterisk/branches/11
  3488. 2013-12-18 20:57 +0000 [r404263] Richard Mudgett <rmudgett@digium.com>
  3489. * addons/ooh323c/src/ooTimer.c, /: ooh323c: Fix gcc 4.6.3 compiler
  3490. warnings. ........ Merged revisions 404212 from
  3491. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3492. revisions 404219 from
  3493. http://svn.asterisk.org/svn/asterisk/branches/11
  3494. 2013-12-18 20:46 +0000 [r404237-404261] Kevin Harwell <kharwell@digium.com>
  3495. * channels/chan_oss.c: chan_oss.c: channel being locked twice and
  3496. unlocked once Removed channel lock as it is now being down in
  3497. ast_channel_alloc
  3498. * main/pickup.c, include/asterisk/aoc.h,
  3499. include/asterisk/stasis_bridges.h, apps/app_disa.c,
  3500. apps/app_userevent.c, include/asterisk/channelstate.h,
  3501. channels/chan_console.c, main/core_local.c, channels/chan_iax2.c,
  3502. main/endpoints.c, channels/chan_oss.c,
  3503. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  3504. main/channel.c, channels/chan_misdn.c, channels/chan_skinny.c,
  3505. pbx/pbx_realtime.c, channels/chan_alsa.c, main/stasis_channels.c,
  3506. main/bridge_channel.c, addons/chan_mobile.c,
  3507. res/parking/parking_manager.c, channels/chan_pjsip.c,
  3508. tests/test_cdr.c, channels/chan_mgcp.c, channels/chan_unistim.c,
  3509. main/pbx.c, funcs/func_timeout.c, apps/app_meetme.c,
  3510. main/bridge.c, tests/test_stasis_channels.c,
  3511. include/asterisk/channel.h, channels/chan_gtalk.c, main/cel.c,
  3512. apps/app_queue.c, channels/sig_pri.c, main/stasis_bridges.c,
  3513. channels/chan_jingle.c, main/dial.c, channels/chan_dahdi.c,
  3514. channels/chan_phone.c, include/asterisk/stasis_channels.h,
  3515. channels/sig_analog.c, res/res_agi.c, channels/chan_motif.c,
  3516. tests/test_cel.c, apps/app_confbridge.c, res/res_stasis.c,
  3517. res/res_pjsip_refer.c, apps/app_voicemail.c, apps/app_dial.c,
  3518. channels/chan_vpb.cc, addons/chan_ooh323.c: channel locking: Add
  3519. locking for channel snapshot creation Original commit message by
  3520. mmichelson (asterisk 12 r403311): "This adds channel locks around
  3521. calls to create channel snapshots as well as other functions
  3522. which operate on a channel and then end up creating a channel
  3523. snapshot. Functions that expect the channel to be locked prior to
  3524. being called have had their documentation updated to indicate
  3525. such." The above was initially committed and then reverted at
  3526. r403398. The problem was found to be in core_local.c in the
  3527. publish_local_bridge_message function. The ast_unreal_lock_all
  3528. function locks and adds a reference to the returned channels and
  3529. while they were being unlocked they were not being unreffed when
  3530. no longer needed. Fixed by unreffing the channels. Also in
  3531. bridge.c a lock was obtained on "other->chan", but then an
  3532. attempt was made to unlock "other" and not the previously locked
  3533. channel. Fixed by unlocking "other->chan" (closes issue
  3534. ASTERISK-22709) Reported by: John Bigelow
  3535. 2013-12-18 19:20 +0000 [r404204] Joshua Colp <jcolp@digium.com>
  3536. * main/channel.c, channels/chan_dahdi.c, channels/chan_phone.c,
  3537. channels/chan_skinny.c, res/parking/parking_tests.c,
  3538. tests/test_voicemail_api.c, channels/chan_motif.c,
  3539. channels/chan_alsa.c, main/message.c, addons/chan_mobile.c,
  3540. tests/test_cdr.c, channels/chan_mgcp.c, main/pbx.c,
  3541. channels/chan_sip.c, tests/test_app.c,
  3542. apps/confbridge/conf_chan_record.c, tests/test_stasis_channels.c,
  3543. main/core_unreal.c, include/asterisk/channel.h,
  3544. channels/chan_console.c, channels/chan_oss.c,
  3545. channels/chan_jingle.c, channels/chan_misdn.c,
  3546. channels/chan_h323.c, tests/test_cel.c, channels/chan_nbs.c,
  3547. channels/chan_pjsip.c, apps/app_voicemail.c, res/res_calendar.c,
  3548. channels/chan_unistim.c, tests/test_substitution.c,
  3549. addons/chan_ooh323.c, channels/chan_vpb.cc,
  3550. channels/chan_multicast_rtp.c, apps/app_meetme.c,
  3551. res/res_stasis_snoop.c, channels/chan_gtalk.c,
  3552. channels/chan_iax2.c: channels: Return allocated channels locked.
  3553. This change makes ast_channel_alloc return allocated channels
  3554. locked. By doing so no other thread can acquire, lock, and
  3555. manipulate the channel before it is completely set up. (closes
  3556. issue AST-1256) Review: https://reviewboard.asterisk.org/r/3067/
  3557. 2013-12-18 12:36 +0000 [r404184] Matthew Jordan <mjordan@digium.com>
  3558. * rest-api/api-docs/bridges.json,
  3559. rest-api/api-docs/recordings.json,
  3560. rest-api/api-docs/deviceStates.json,
  3561. rest-api/api-docs/endpoints.json, rest-api/api-docs/events.json,
  3562. rest-api/api-docs/asterisk.json,
  3563. rest-api/api-docs/applications.json,
  3564. rest-api/api-docs/playbacks.json,
  3565. rest-api/api-docs/channels.json, rest-api/api-docs/sounds.json,
  3566. rest-api/resources.json: ari: Bump the version of ARI to 1.0.0
  3567. (closes issue ASTERISK-23007)
  3568. 2013-12-18 12:00 +0000 [r404137] Joshua Colp <jcolp@digium.com>
  3569. * res/res_calendar.c, /: res_calendar: Protect channel when adding
  3570. datastore. This change adds a missing channel lock when adding a
  3571. datastore to a channel. ........ Merged revisions 404135 from
  3572. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3573. revisions 404136 from
  3574. http://svn.asterisk.org/svn/asterisk/branches/11
  3575. 2013-12-18 00:35 +0000 [r404099] Rusty Newton <rnewton@digium.com>
  3576. * /, funcs/func_strings.c: func_strings: Documentation fix for
  3577. QUOTE() Example output was inaccurate. (issue ASTERISK-22970)
  3578. (closes issue ASTERISK-22970) Reported by: Gareth Palmer Patches:
  3579. func_strings.patch uploaded by Gareth Palmer (license 5169)
  3580. ........ Merged revisions 404081 from
  3581. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3582. revisions 404087 from
  3583. http://svn.asterisk.org/svn/asterisk/branches/11
  3584. 2013-12-18 00:16 +0000 [r404050] Matthew Jordan <mjordan@digium.com>
  3585. * LICENSE: LICENSE: Update language to include ARI
  3586. 2013-12-17 23:50 +0000 [r404048] Jonathan Rose <jrose@digium.com>
  3587. * tests/test_cel.c, tests/test_cdr.c: tests: fix
  3588. ast_bridge_base_new calls not using the additional arguments
  3589. r404042 gave ast_bridge_base_new two new arguments for setting a
  3590. bridge creator and name. Unfortunately since a couple test
  3591. modules aren't compiled by default, I missed the fact that this
  3592. change impacted those tests and caused compilation failures
  3593. against them.
  3594. 2013-12-17 23:36 +0000 [r404046] Rusty Newton <rnewton@digium.com>
  3595. * include/asterisk/test.h, main/channel.c, main/rtp_engine.c,
  3596. channels/chan_iax2.c, apps/app_chanspy.c, apps/app_mixmonitor.c:
  3597. Several components: fixing Typos in comments and code,
  3598. "avaliable" instead of "available" (issue ASTERISK-23021) (closes
  3599. issue ASTERISK-23021) Reported by: Jeremy Lainé Tested by: Rusty
  3600. Newton Patches: available.patch uploaded by Jeremy Lainé (license
  3601. 6561)
  3602. 2013-12-17 23:17 +0000 [r404042] Jonathan Rose <jrose@digium.com>
  3603. * include/asterisk/bridge_internal.h, apps/app_confbridge.c,
  3604. res/res_stasis.c, include/asterisk/bridge.h,
  3605. res/res_ari_bridges.c, main/bridge.c, main/bridge_basic.c,
  3606. include/asterisk/stasis_bridges.h, include/asterisk/stasis_app.h,
  3607. apps/app_bridgewait.c, res/ari/ari_model_validators.c,
  3608. doc/appdocsxml.xslt, main/stasis_bridges.c,
  3609. rest-api/api-docs/bridges.json, res/ari/resource_bridges.c,
  3610. apps/app_agent_pool.c, res/parking/parking_bridge.c,
  3611. res/ari/ari_model_validators.h, main/manager_bridges.c,
  3612. res/ari/resource_bridges.h: bridging: Give bridges a name and a
  3613. known creator Bridges have two new optional properties, a creator
  3614. and a name. Certain consumers of bridges will automatically
  3615. provide bridges that they create with these properties. Examples
  3616. include app_bridgewait, res_parking, app_confbridge, and
  3617. app_agent_pool. In addition, a name may now be provided as an
  3618. argument to the POST function for creating new bridges via ARI.
  3619. (closes issue AFS-47) Review:
  3620. https://reviewboard.asterisk.org/r/3070/
  3621. 2013-12-17 18:34 +0000 [r404027-404029] Joshua Colp <jcolp@digium.com>
  3622. * res/res_sorcery_config.c: res_sorcery_config: Output an error
  3623. message when an object can't be created. If object creation fails
  3624. an error message will now be output with the id, type, and
  3625. configuration file.
  3626. * main/framehook.c: framehooks: Re-iterate if framehook provides
  3627. different frame. Framehooks can be used in a reactive manner to
  3628. execute specific logic when a frame is received with a certain
  3629. type and payload. Since it is possible for framehooks to provide
  3630. frames it was possible for this reactive framehook to be unaware
  3631. of frames it is looking for. This change makes it so that when
  3632. framehooks return a modified frame the code will now re-iterate
  3633. (from the beginning) and call any previous framehooks that have
  3634. not provided a modified frame themselves. Review:
  3635. https://reviewboard.asterisk.org/r/3046/
  3636. 2013-12-17 14:33 +0000 [r404006] David M. Lee <dlee@digium.com>
  3637. * configs/asterisk.conf.sample, main/asterisk.c: Changed the
  3638. default for live_dangerously to no
  3639. 2013-12-17 12:51 +0000 [r403993] Matthew Jordan <mjordan@digium.com>
  3640. * res/ari/resource_channels.c: ari/resource_channels: When creating
  3641. a channel, specify a default format (SLIN) When creating channels
  3642. via ARI, the current code fails to provide any default format
  3643. capabilities. For non-virtual channels this isn't really a
  3644. problem - the channels typically receive their capabilities as a
  3645. result of the underlying channel driver configuration. For
  3646. virtual channels (such as Local channels), the lack of any format
  3647. capabilities causes the Asterisk core to make some 'odd' choices
  3648. with respect to the translation paths. The issue reporter had
  3649. some paths that had 3 hops on each channel leg, causing multiple
  3650. transcodings and some really crappy audio/performance. By
  3651. specifying a baseline of SLIN, we prevent that from occurring.
  3652. Note that this is what AMI does when it performs an Originate, as
  3653. does res_clioriginate. Review:
  3654. https://reviewboard.asterisk.org/r/3068/ (issue ASTERISK-22962)
  3655. Reported by: Matt DiMeo
  3656. 2013-12-16 18:31 +0000 [r403959] David M. Lee <dlee@digium.com>
  3657. * UPGRADE.txt, include/asterisk/pbx.h, main/asterisk.c,
  3658. funcs/func_realtime.c, main/pbx.c, main/tcptls.c,
  3659. funcs/func_db.c, /, README-SERIOUSLY.bestpractices.txt,
  3660. configs/asterisk.conf.sample, funcs/func_shell.c,
  3661. funcs/func_env.c, funcs/func_lock.c: security: Inhibit execution
  3662. of privilege escalating functions This patch allows individual
  3663. dialplan functions to be marked as 'dangerous', to inhibit their
  3664. execution from external sources. A 'dangerous' function is one
  3665. which results in a privilege escalation. For example, if one were
  3666. to read the channel variable SHELL(rm -rf /) Bad Things(TM) could
  3667. happen; even if the external source has only read permissions.
  3668. Execution from external sources may be enabled by setting
  3669. 'live_dangerously' to 'yes' in the [options] section of
  3670. asterisk.conf. Although doing so is not recommended. Also, the
  3671. ABI was changed to something more reasonable, since Asterisk 12
  3672. does not yet have a public release. (closes issue ASTERISK-22905)
  3673. Review: http://reviewboard.digium.internal/r/432/ ........ Merged
  3674. revisions 403913 from
  3675. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3676. revisions 403917 from
  3677. http://svn.asterisk.org/svn/asterisk/branches/11
  3678. 2013-12-16 18:22 +0000 [r403957] Jonathan Rose <jrose@digium.com>
  3679. * main/bridge.c: transfers: Fix bug setting both BLINDTRANSFER and
  3680. ATTENDEDTRANSFER The ast_bridge_set_transfer_variables function
  3681. is supposed to wipe whichever variable isn't being set. Instead
  3682. it was setting both to the new value. Oops. (issue AFS-24)
  3683. 2013-12-16 16:11 +0000 [r403856-403864] Scott Griepentrog <sgriepentrog@digium.com>
  3684. * main/pbx.c, /: pbx.c: put copy of ast_exten.data on stack to
  3685. prevent memory corruption During dialplan execution in
  3686. pbx_extension_helper(), the contexts global read lock prevents
  3687. link list corruption, but was released with a pointer to the
  3688. ast_exten and data later used in variable substitution. Instead,
  3689. this patch removes pbx_substitute_variables() and locates a copy
  3690. of the ast_exten data on the stack before releasing the lock,
  3691. where ast_exten could get free'd by another thread performing a
  3692. module reload. (issue AST-1179) Reported by: Thomas Arimont
  3693. (issue AST-1246) Reported by: Alexander Hömig Review:
  3694. https://reviewboard.asterisk.org/r/3055/ ........ Merged
  3695. revisions 403862 from
  3696. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3697. revisions 403863 from
  3698. http://svn.asterisk.org/svn/asterisk/branches/11
  3699. * apps/app_sms.c: app_sms: BufferOverflow when receiving odd length
  3700. 16 bit message This patch prevents an infinite loop overwriting
  3701. memory when a message is received into the unpacksms16()
  3702. function, where the length of the message is an odd number of
  3703. bytes. (closes issue ASTERISK-22590) Reported by: Jan Juergens
  3704. Tested by: Jan Juergens
  3705. 2013-12-15 01:38 +0000 [r403823] Matthew Jordan <mjordan@digium.com>
  3706. * channels/pjsip/dialplan_functions.c: pjsip/dialplan_functions:
  3707. Use the right buffer length when printing URIs While
  3708. entertaining, sizeof(buflen) is not the same as buflen. Doh.
  3709. 2013-12-14 17:25 +0000 [r403808-403811] Joshua Colp <jcolp@digium.com>
  3710. * include/asterisk/res_pjsip.h, res/res_pjsip/location.c,
  3711. res/res_pjsip/pjsip_options.c, res/res_pjsip.c: res_pjsip: Apply
  3712. outbound proxy to all SIP requests. Objects which are involved in
  3713. SIP request creation and sending now allow an outbound proxy to
  3714. be specified. For cases where an endpoint is used the outbound
  3715. proxy specified there will be applied. (closes issue
  3716. ASTERISK-22673) Reported by: Antti Yrjola Review:
  3717. https://reviewboard.asterisk.org/r/3022/
  3718. * main/stasis_channels.c, apps/app_queue.c,
  3719. res/ari/ari_model_validators.c, apps/app_dial.c,
  3720. res/ari/ari_model_validators.h, main/dial.c,
  3721. include/asterisk/stasis_channels.h,
  3722. rest-api/api-docs/events.json, res/stasis/app.c: res_stasis:
  3723. Expose event for call forwarding and follow forwarded channel.
  3724. This change adds an event for when an originated call is
  3725. redirected to another target. This event contains the original
  3726. channel and the newly created channel. If a stasis subscription
  3727. exists on the original originated channel for a stasis
  3728. application then a new subscription will also be created on the
  3729. stasis application to the redirected channel. This allows the
  3730. application to follow the call path completely. (closes issue
  3731. ASTERISK-22719) Reported by: Joshua Colp Review:
  3732. https://reviewboard.asterisk.org/r/3054/
  3733. 2013-12-13 21:24 +0000 [r403796] Jonathan Rose <jrose@digium.com>
  3734. * res/res_pjsip_messaging.c, main/message.c: documentation: Add
  3735. PJSIP technology to messaging documentation
  3736. 2013-12-13 20:06 +0000 [r403782] Richard Mudgett <rmudgett@digium.com>
  3737. * main/test.c: test.c: Fix too sticky unit test failed status.
  3738. Rerunning a failed unit test after loading any required modules
  3739. should allow the test to report a pass status if it now passes.
  3740. 2013-12-13 20:04 +0000 [r403781] Jonathan Rose <jrose@digium.com>
  3741. * include/asterisk/bridge.h, res/parking/parking_bridge_features.c,
  3742. res/parking/parking_manager.c, main/bridge.c,
  3743. main/bridge_basic.c: Transfers: Make Asterisk set
  3744. ATTENDEDTRANSFER/BLINDTRANSFER more reliably There were still a
  3745. few cases in which ATTENDEDTRANSFER and BLINDTRANSFER wouldn't be
  3746. set on channels involved with blind and attended transfers. This
  3747. would happen with features that were initialized by channel
  3748. driver specific mechanisms in multiparty calls. This patch
  3749. resolves those cases while attempted to keep the behavior for
  3750. setting those variables as consistent as possible. (closes issue
  3751. AFS-24) Review: https://reviewboard.asterisk.org/r/3040/
  3752. 2013-12-13 19:55 +0000 [r403779-403780] Richard Mudgett <rmudgett@digium.com>
  3753. * include/asterisk/app.h, tests/test_voicemail_api.c, main/app.c:
  3754. test_voicemail_api: Add check for a registered voicemail provider
  3755. before tests. It is much nicer diagnosing a test failure if
  3756. app_voicemail is actually loaded. ........ Merged revisions
  3757. 403726 from http://svn.asterisk.org/svn/asterisk/trunk
  3758. * main/app.c, apps/app_voicemail.c, include/asterisk/app.h,
  3759. include/asterisk/doxyref.h: app_voicemail: Voicemail callback
  3760. registration/unregistration function improvements. * The
  3761. voicemail registration/unregistration functions now take a struct
  3762. of callbacks instead of a lengthy parameter list of callbacks. *
  3763. The voicemail registration/unregistration functions now prevent a
  3764. competing module from interfering with an already registered
  3765. callback supplying module. ........ Merged revisions 403643 from
  3766. http://svn.asterisk.org/svn/asterisk/trunk
  3767. 2013-12-13 18:24 +0000 [r403749-403767] Kevin Harwell <kharwell@digium.com>
  3768. * channels/chan_sip.c, include/asterisk/channel.h,
  3769. bridges/bridge_native_rtp.c, channels/chan_pjsip.c,
  3770. main/channel.c: bridge_native_rtp: Deadlock during 4-way
  3771. conference creation The change contains a slightly adjusted patch
  3772. that was on the issue (submitted by kmoore). A fix was made by
  3773. adding in a bridge lock while calling bridge_start/stop from the
  3774. framehook callback. Since the framehook callback is not called
  3775. from the bridging core the bridge is not locked, but needs to be
  3776. before calling bridge_start. (closes issue ASTERISK-22749)
  3777. Reported by: Kinsey Moore Review:
  3778. https://reviewboard.asterisk.org/r/3066/ Patches:
  3779. lock_inversion.diff uploaded by kmoore (license 6273)
  3780. * main/http.c, rest-api/api-docs/channels.json,
  3781. res/ari/resource_channels.c, res/res_ari_channels.c,
  3782. res/ari/resource_channels.h: ARI: Allow specifying channel
  3783. variables during a POST /channels Added the ability to specify
  3784. channel variables when creating/originating a channel in ARI. The
  3785. variables are sent in the body of the request and should be
  3786. formatted as a single level JSON object. No nested objects
  3787. allowed. For example: {"variable1": "foo", "variable2": "bar"}.
  3788. (closes issue ASTERISK-22872) Reported by: Matt Jordan Review:
  3789. https://reviewboard.asterisk.org/r/3052/
  3790. * res/res_ari_bridges.c, res/stasis/command.c,
  3791. res/res_stasis_playback.c, res/stasis/control.c,
  3792. res/stasis/command.h, include/asterisk/stasis_app.h,
  3793. include/asterisk/stasis_app_impl.h, res/res_stasis_recording.c,
  3794. res/res_stasis_answer.c, rest-api/api-docs/bridges.json,
  3795. res/ari/resource_bridges.c: ARI: Adding a channel to a bridge
  3796. while a live recording is active blocks Added the ability to have
  3797. rules that are checked when adding and/or removing channels
  3798. to/from a bridge. In this case, if a channel is currently
  3799. recording and someone attempts to add it to a bridge an "is
  3800. recording" rule is checked, fails, and a 409 conflict is
  3801. returned. Also command functions now return an integer value that
  3802. can be descriptive of what kind of problems, if any, occurred
  3803. before or during execution. (closes issue ASTERISK-22624)
  3804. Reported by: Joshua Colp Review:
  3805. https://reviewboard.asterisk.org/r/2947/
  3806. 2013-12-13 16:27 +0000 [r403748] David M. Lee <dlee@digium.com>
  3807. * channels/pjsip: Setting svn:ignore
  3808. 2013-12-13 05:00 +0000 [r403736] Matthew Jordan <mjordan@digium.com>
  3809. * channels/Makefile: channels/Makefile: clean pjsip directory
  3810. 2013-12-12 19:44 +0000 [r403713] Scott Griepentrog <sgriepentrog@digium.com>
  3811. * contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py
  3812. (added): realtime: Create extensions in alembic ast-db-manage
  3813. contribution When the alembic scripts were written for creating
  3814. Asterisk realtime databases the extensions table for dialplan
  3815. wasn't included. This update creates the extensions table.
  3816. (closes issue ASTERISK-22815) Reported by: Zone Conkle Review:
  3817. https://reviewboard.asterisk.org/r/3064/
  3818. 2013-12-12 19:12 +0000 [r403705] Jonathan Rose <jrose@digium.com>
  3819. * channels/chan_pjsip.c: chan_pjsip: Revert r403587 This patch was
  3820. intended to eliminate a deadlock that occurs when masquerades
  3821. occur in pjsip channels, but has some potential side effects.
  3822. Mark Michelson is currently working on addressing this problem
  3823. from another angle. (issue ASTERISK-22936) Reported by: Jonathan
  3824. Rose
  3825. 2013-12-11 20:11 +0000 [r403680] Kevin Harwell <kharwell@digium.com>
  3826. * res/res_pjsip/pjsip_configuration.c, res/res_pjsip_messaging.c,
  3827. res/res_pjsip/include/res_pjsip_private.h, res/res_pjsip.c,
  3828. include/asterisk/res_pjsip.h, res/res_pjsip/config_global.c,
  3829. configs/pjsip.conf.sample: res_pjsip_messaging: send message to a
  3830. default outbound endpoint In some cases messages need to be sent
  3831. to a direct URI (sip:<ip address>). This patch adds in that
  3832. support by using a default outbound endpoint. When sending
  3833. messages, if no endpoint can be found then the default one is
  3834. used. To facilitate this a new default_outbound_endpoint option
  3835. was added to the globals section for pjsip.conf. Review:
  3836. https://reviewboard.asterisk.org/r/2944/
  3837. 2013-12-11 19:18 +0000 [r403639] Russell Bryant <russell@russellbryant.com>
  3838. * /, channels/chan_sip.c: Reset peer outboundproxy on sip.conf
  3839. reload If you set a peer's outboundproxy and then removed it from
  3840. the config, this would not get picked up in a config reload. This
  3841. patch fixes that by resetting it in set_peer_defaults(). Closes
  3842. ASTERISK-19454 Review: https://reviewboard.asterisk.org/r/3065/
  3843. ........ Merged revisions 403634 from
  3844. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3845. revisions 403635 from
  3846. http://svn.asterisk.org/svn/asterisk/branches/11
  3847. 2013-12-11 13:05 +0000 [r403616-403618] Matthew Jordan <mjordan@digium.com>
  3848. * funcs/func_channel.c, channels/pjsip/include (added),
  3849. channels/pjsip/include/dialplan_functions.h (added),
  3850. res/res_pjsip_t38.c, channels/pjsip/include/chan_pjsip.h (added),
  3851. channels/Makefile, channels/chan_pjsip.c, main/xmldoc.c,
  3852. channels/pjsip/dialplan_functions.c (added),
  3853. include/asterisk/res_pjsip_session.h, channels/pjsip (added):
  3854. func_channel, chan_pjsip: Add CHANNEL read function support for
  3855. chan_pjsip This patch adds CHANNEL read support for chan_pjsip.
  3856. This allows the dialplan to use the CHANNEL function on a
  3857. chan_pjsip channel to obtain run-time information about the
  3858. channel from the PJSIP channel driver and the PJSIP stack. This
  3859. includes: * RTP information, including source/destination media
  3860. addresses, whether or not the media is secure, held, and other
  3861. properties. * RTCP information. This includes sets of parseable
  3862. information, as well as individual statistic attriutes. * PJSIP
  3863. information. This includes URIs, local/remote signalling
  3864. addresses, whether or not the signalling is secure, and other
  3865. properties. * The endpoint name. This can be used in conjunction
  3866. with the PJSIP_ENDPOINT function to obtain more detailed endpoint
  3867. information. Review: https://reviewboard.asterisk.org/r/3038/
  3868. * Makefile, funcs/func_pjsip_endpoint.c (added), doc/snapshots.xslt
  3869. (removed), doc/appdocsxml.xslt (added), doc/appdocsxml.dtd,
  3870. main/sorcery.c: func_pjsip_endpoint: Add PJSIP_ENDPOINT function
  3871. for querying endpoint details This patch adds a new function,
  3872. PJSIP_ENDPOINT, which lets the dialplan query, for any endpoint,
  3873. any property configured on an endpoint. This function is a
  3874. companion to the CHANNEL function, which can be used to extract
  3875. the endpoint name for a channel. Review:
  3876. https://reviewboard.asterisk.org/r/3035
  3877. 2013-12-09 22:47 +0000 [r403587] Jonathan Rose <jrose@digium.com>
  3878. * channels/chan_pjsip.c: chan_pjsip: Fix a sticking channel lock
  3879. caused by channel masquerades (closes issue ASTERISK-22936)
  3880. Reported by: Jonathan Rose Review:
  3881. https://reviewboard.asterisk.org/r/3042/
  3882. 2013-12-09 19:23 +0000 [r403545-403559] Richard Mudgett <rmudgett@digium.com>
  3883. * res/res_sorcery_astdb.c: Reverting regex part of -r403545 at
  3884. request of file. res_sorcery_astdb.c: Fix get multiple records by
  3885. regex. * Fix sorcery_astdb_retrieve_regex() pattern matching. Let
  3886. the regexec() function match the stored key values instead of
  3887. having astdb prefilter them. Previoiusly you could only use a
  3888. simple regex pattern when the pattern began with '^'.
  3889. * res/res_sorcery_astdb.c: res_sorcery_astdb.c: Fix get multiple
  3890. records by regex. * Fix sorcery_astdb_retrieve_regex() pattern
  3891. matching. Let the regexec() function match the stored key values
  3892. instead of having astdb prefilter them. Previoiusly you could
  3893. only use a simple regex pattern when the pattern began with '^'.
  3894. * Fix off nominal memory leak in sorcery_astdb_retrieve_regex().
  3895. 2013-12-09 18:31 +0000 [r403542] Joshua Colp <jcolp@digium.com>
  3896. * main/endpoints.c: endpoints: Keep a reference to channel ids when
  3897. creating snapshot. The snapshot process for endpoints uses the
  3898. channel ids present on the endpoint itself. Without keeping a
  3899. reference it was possible for the strings to be freed underneath
  3900. any consumer of an endpoint snapshot. A reference is now held by
  3901. the snapshot to the channel ids and released when the snapshot is
  3902. destroyed. (issue ASTERISK-22801) Reported by: Matt Jordan
  3903. 2013-12-09 18:31 +0000 [r403527-403541] Richard Mudgett <rmudgett@digium.com>
  3904. * main/sorcery.c: sorcery: Eliminate shadowing a varaible that
  3905. caused confusion. * Eliminated shadowing of the
  3906. __ast_sorcery_apply_config() name parameter causing confusion. *
  3907. Fix potential crash from sorcery.conf user input in
  3908. __ast_sorcery_apply_config() if the user supplied a malformed
  3909. config line that is missing the sorcery object type name. *
  3910. Remove redundant test in __ast_sorcery_apply_config(). !config
  3911. and config == CONFIGS_STATUS_FILEMISSING are identical.
  3912. * main/sorcery.c: sorcery: Whitespace You would think that a new
  3913. file would start off without any whitespace oddities.
  3914. 2013-12-09 16:40 +0000 [r403510] Joshua Colp <jcolp@digium.com>
  3915. * res/res_pjsip_nat.c: res_pjsip_nat: Add NAT module to session
  3916. dialogs. Due to the way pjproject internally works it was
  3917. possible for the NAT module to not be invoked on messages with-in
  3918. a session dialog. This means that the various parts of the
  3919. message would not get rewritten with the source IP address and
  3920. port. This change uses a session supplement to add the NAT module
  3921. to the dialog on the first incoming or outgoing INVITE. (closes
  3922. issue ASTERISK-22941) Reported by: Leif Madsen
  3923. 2013-12-09 03:19 +0000 [r403435-403458] Matthew Jordan <mjordan@digium.com>
  3924. * res/res_fax_spandsp.c, /: res_fax_spandsp: Always init T.38
  3925. session to avoid crashes during state change Prior to this patch,
  3926. res_fax_spandsp was conservative with how it initialized the
  3927. spandsp T.38 context. It would only initialize it if the driver
  3928. thought the current state was a T.38 fax. While this works fine
  3929. in nominal situations, in certain off nominal situations,
  3930. res_fax_spandsp can believe that a T.38 fax will not occur when
  3931. in fact one has started. In particular, this was discovered when
  3932. res_fax would fall back to audio after timing out on a T.38
  3933. upgrade. The SIP channel driver would continue to retry the
  3934. re-INVITE and - if the remote end responded after res_fax timed
  3935. out with a 200 OK - a T.38 frame would be delivered to the
  3936. res_fax stack when it no longer expected it. As it turns out,
  3937. there does not appear to be any downside to always initializing
  3938. the T.38 context, other than the actual memory allocation. Since
  3939. that avoids this off nominal situation (and others which are
  3940. equally likely hard to predict), this is the safest way to avoid
  3941. this problem. Much thanks to Torrey as well for providing a
  3942. scenario that reproduces this issue. (closes issue
  3943. ASTERISK-21242) Reported by: Ashley Winters Tested by: Torrey
  3944. Searle patches: always-init-t38.patch uploaded by awinters
  3945. (License 6477) A_PARTY.xml uploaded by tsearle (License 5334)
  3946. ........ Merged revisions 403449 from
  3947. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3948. revisions 403450 from
  3949. http://svn.asterisk.org/svn/asterisk/branches/11
  3950. * res/res_config_sqlite.c: res_config_sqlite: Check for CDR
  3951. unregistration failures If the CDR unregistration fails due to an
  3952. inflight CDR, the res_config_sqlite module needs to bail on
  3953. unloading itself. Otherwise, the config could be unloaded
  3954. (including the CDR table name) while the CDR engine posts a CDR
  3955. to the still registered backend, resulting in a crash.
  3956. 2013-12-05 20:49 +0000 [r403398] David M. Lee <dlee@digium.com>
  3957. * main/core_unreal.c, tests/test_stasis_channels.c,
  3958. include/asterisk/channel.h, channels/chan_gtalk.c,
  3959. channels/sig_pri.c, apps/app_queue.c, main/cel.c,
  3960. main/stasis_bridges.c, channels/chan_jingle.c,
  3961. channels/chan_phone.c, channels/chan_dahdi.c, main/dial.c,
  3962. include/asterisk/stasis_channels.h, channels/sig_analog.c,
  3963. channels/chan_motif.c, res/res_agi.c, channels/chan_h323.c,
  3964. tests/test_cel.c, apps/app_confbridge.c, res/res_stasis.c,
  3965. res/res_pjsip_refer.c, apps/app_voicemail.c, apps/app_dial.c,
  3966. channels/chan_vpb.cc, addons/chan_ooh323.c, channels/chan_sip.c,
  3967. main/pickup.c, include/asterisk/aoc.h,
  3968. include/asterisk/stasis_bridges.h, apps/app_disa.c,
  3969. apps/app_userevent.c, main/core_local.c, channels/chan_console.c,
  3970. include/asterisk/channelstate.h, channels/chan_iax2.c,
  3971. main/endpoints.c, channels/chan_oss.c,
  3972. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  3973. main/channel.c, channels/chan_misdn.c, channels/chan_skinny.c,
  3974. channels/chan_alsa.c, pbx/pbx_realtime.c, main/stasis_channels.c,
  3975. channels/chan_nbs.c, main/bridge_channel.c, addons/chan_mobile.c,
  3976. channels/chan_pjsip.c, tests/test_cdr.c,
  3977. res/parking/parking_manager.c, channels/chan_mgcp.c,
  3978. channels/chan_unistim.c, main/pbx.c, funcs/func_timeout.c,
  3979. apps/app_meetme.c, main/bridge.c: Reverting r403311. It's causing
  3980. ARI tests to hang.
  3981. 2013-12-04 21:41 +0000 [r403377] Kevin Harwell <kharwell@digium.com>
  3982. * res/res_pjsip_registrar.c: res_pjsip_registrar: undefined
  3983. function pointer symbol Used a static wrapper around the
  3984. offending function to alleviate the issue. Reported by: rmudgett
  3985. 2013-12-04 20:53 +0000 [r403364] Joshua Colp <jcolp@digium.com>
  3986. * res/res_pjsip_t38.c: res_pjsip_t38: Don't pass T.38 control
  3987. frames through to other hooks. This crept up during gateway
  3988. testing where the gateway would receive the request to negotiate
  3989. and assume it came from the remote side, causing the gateway
  3990. state machine to go a little, to a use a technical term, "wonky".
  3991. 2013-12-04 18:40 +0000 [r403349] Mark Michelson <mmichelson@digium.com>
  3992. * res/res_pjsip.c: Initialize the hash value argument to
  3993. pj_hash_get() to 0. Passing a non-zero value causes PJLIB to use
  3994. the given input as the hash value. Passing zero causes the
  3995. parameter to become an output parameter that receives the hash
  3996. value that was computed based on the given key. This change
  3997. essentially makes ast_sip_dict_get() properly retrieve the
  3998. desired value.
  3999. 2013-12-03 20:17 +0000 [r403342] David M. Lee <dlee@digium.com>
  4000. * res/stasis/control.c: ari: Fix deadlock problem with functions
  4001. that use autoservice. The code for getting channel variables from
  4002. ARI assumed that you needed to lock the channel in order to
  4003. properly execute functions and read channel variables.
  4004. Apparently, this is not the case, since any dialplan function
  4005. that puts the channel into autoservice deadlocks when attempting
  4006. to remove the channel from autoservice.
  4007. 2013-12-03 17:59 +0000 [r403329] Joshua Colp <jcolp@digium.com>
  4008. * res/res_pjsip_session.c, configure,
  4009. include/asterisk/autoconfig.h.in, configure.ac:
  4010. res_pjsip_session: Add support for
  4011. PJMEDIA_SDP_NEG_ALLOW_MEDIA_CHANGE flag. Newer versions of PJSIP
  4012. have changed to using a flag for the
  4013. PJMEDIA_SDP_NEG_ALLOW_MEDIA_CHANGE instead of a define. This adds
  4014. a configure check to detect the presence of the flag and use it
  4015. if found.
  4016. 2013-12-03 17:23 +0000 [r403324] Richard Mudgett <rmudgett@digium.com>
  4017. * main/bucket.c, include/asterisk/sorcery.h,
  4018. res/res_pjsip/pjsip_configuration.c,
  4019. res/res_pjsip_registrar_expire.c, res/res_pjsip/pjsip_options.c,
  4020. tests/test_sorcery.c, include/asterisk/bucket.h, main/sorcery.c:
  4021. sorcery, bucket: Change observer remove calls to take const
  4022. callbacks struct. * Make ast_sorcery_observer_remove() accept a
  4023. const callbacks struct. * Make ast_sorcery_observer_remove()
  4024. tolerant of the sorcery parameter being NULL. Now it can be
  4025. called within a module unload routine if the sorcery
  4026. initialization fails. * Fix ast_sorcery_observer_add() to fail if
  4027. the container link fails.
  4028. 2013-12-03 16:37 +0000 [r403312] Joshua Colp <jcolp@digium.com>
  4029. * main/media_index.c: media_index: Make media indexing tolerable of
  4030. bad symlinks. Media indexing will now skip over files and
  4031. directories that stat will not return information about. This can
  4032. occur under normal conditions when a symbolic link points to a
  4033. location that no longer exists.
  4034. 2013-12-03 16:33 +0000 [r403311] Mark Michelson <mmichelson@digium.com>
  4035. * include/asterisk/stasis_bridges.h, apps/app_disa.c,
  4036. apps/app_userevent.c, main/core_local.c,
  4037. include/asterisk/channelstate.h, channels/chan_console.c,
  4038. channels/chan_iax2.c, main/endpoints.c, channels/chan_oss.c,
  4039. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  4040. main/channel.c, channels/chan_misdn.c, channels/chan_skinny.c,
  4041. channels/chan_alsa.c, pbx/pbx_realtime.c, main/stasis_channels.c,
  4042. channels/chan_nbs.c, main/bridge_channel.c, addons/chan_mobile.c,
  4043. channels/chan_pjsip.c, tests/test_cdr.c,
  4044. res/parking/parking_manager.c, channels/chan_mgcp.c,
  4045. channels/chan_unistim.c, main/pbx.c, funcs/func_timeout.c,
  4046. apps/app_meetme.c, main/bridge.c, tests/test_stasis_channels.c,
  4047. main/core_unreal.c, include/asterisk/channel.h,
  4048. channels/chan_gtalk.c, channels/sig_pri.c, apps/app_queue.c,
  4049. main/cel.c, main/stasis_bridges.c, channels/chan_jingle.c,
  4050. channels/chan_phone.c, channels/chan_dahdi.c, main/dial.c,
  4051. include/asterisk/stasis_channels.h, channels/sig_analog.c,
  4052. channels/chan_motif.c, res/res_agi.c, channels/chan_h323.c,
  4053. tests/test_cel.c, apps/app_confbridge.c, res/res_stasis.c,
  4054. res/res_pjsip_refer.c, apps/app_voicemail.c, apps/app_dial.c,
  4055. channels/chan_vpb.cc, addons/chan_ooh323.c, main/pickup.c,
  4056. channels/chan_sip.c, include/asterisk/aoc.h: Add channel locking
  4057. for channel snapshot creation. This adds channel locks around
  4058. calls to create channel snapshots as well as other functions
  4059. which operate on a channel and then end up creating a channel
  4060. snapshot. Functions that expect the channel to be locked prior to
  4061. being called have had their documentation updated to indicate
  4062. such.
  4063. 2013-12-03 16:32 +0000 [r403310] Joshua Colp <jcolp@digium.com>
  4064. * res/res_ari.c: Revert revision 403304: Fixed the filename for the
  4065. ari.conf docs The changed value refers to the name of the module.
  4066. The name of the configuration file is specified in the configFile
  4067. section.
  4068. 2013-12-02 18:34 +0000 [r403304] David M. Lee <dlee@digium.com>
  4069. * res/res_ari.c: Fixed the filename for the ari.conf docs
  4070. 2013-12-02 18:03 +0000 [r403290-403291] Alexandr Anikin <may@telecom-service.ru>
  4071. * /: remove unwanted property svn:mergeinfo
  4072. * /, addons/chan_ooh323.c: Check and reject non-digits e164 values
  4073. on peers and general sections in ooh323.conf Regenerate e164
  4074. endpoint list on reload ooh323 (issue ASTERISK-22901) Reported
  4075. by: Cyril CONSTANTIN Patches: ASTERISK-22901.patch ........
  4076. Merged revisions 403288 from
  4077. http://svn.asterisk.org/svn/asterisk/branches/11
  4078. 2013-12-01 21:12 +0000 [r403256-403271] Joshua Colp <jcolp@digium.com>
  4079. * res/res_pjsip_session.c: res_pjsip_session: Apply fromuser and
  4080. fromdomain to all requests as documented.
  4081. * res/res_pjsip_t38.c: res_pjsip_t38: Add the framehook to the
  4082. channel only on first INVITE. The check for determining whether
  4083. the T.38 framehook should be added to the channel or not has now
  4084. been changed to guarantee adding only occurs on the first
  4085. incoming or outgoing INVITE.
  4086. * res/res_pjsip_transport_websocket.c,
  4087. include/asterisk/res_pjsip.h, res/res_pjsip/location.c,
  4088. res/res_pjsip/security_events.c, res/res_pjsip/pjsip_options.c,
  4089. res/res_pjsip.c: res_pjsip_transport_websocket: Fix security
  4090. events and simplify implementation. Transport type determination
  4091. for security events has been simplified to use the type present
  4092. on the message itself instead of searching through configured
  4093. transports to find the transport used. The actual WebSocket
  4094. transport has also been simplified. It now leverages the existing
  4095. PJSIP transport manager for finding the active WebSocket
  4096. transport for outgoing messages. This removes the need for
  4097. res_pjsip_transport_websocket to store a mapping itself. (closes
  4098. issue ASTERISK-22897) Reported by: Max E. Reyes Vera J. Review:
  4099. https://reviewboard.asterisk.org/r/3036/
  4100. 2013-11-30 14:11 +0000 [r403240] Joshua Colp <jcolp@digium.com>
  4101. * res/ari/ari_model_validators.c, res/ari/ari_model_validators.h,
  4102. rest-api/api-docs/events.json: res_ari: Add Recording events to
  4103. the validator.
  4104. 2013-11-28 02:12 +0000 [r403179-403223] Joshua Colp <jcolp@digium.com>
  4105. * res/res_pjsip_sdp_rtp.c: res_pjsip_sdp_rtp: Don't produce an
  4106. invalid media stream with no formats. Depending on configuration
  4107. it was possible for a media stream to be created without any
  4108. media formats. The produced SDP would fail internal validation
  4109. and cause a crash. The code will now no longer add media streams
  4110. with no formats to the SDP, allowing it to pass validation and
  4111. work. (closes issue ASTERISK-22858) Reported by: Anthony Messina
  4112. * res/res_pjsip_header_funcs.c: res_pjsip_header_funcs: Don't add
  4113. headers to re-INVITEs. When sending a re-INVITE to an endpoint it
  4114. was possible for received headers to be added as well (since they
  4115. are stored for retrieval using the PJSIP_HEADER dialplan
  4116. function). This caused a broken (and potentially large) SIP
  4117. INVITE to be produced and sent. This changes the module so it
  4118. will no longer add headers to re-INVITEs. (closes issue
  4119. ASTERISK-22882) Reported by: David M. Lee
  4120. * res/res_stasis_playback.c: res_stasis_playback: Add 'number',
  4121. 'digits', and 'characters' URI scheme implementations. This
  4122. change adds new URI scheme implementations for playing numbers,
  4123. digits, and characters. This is done as part of the normal
  4124. playback mechanism and can be used with queueing to create a
  4125. combined sentence. Review:
  4126. https://reviewboard.asterisk.org/r/3028/
  4127. * res/res_pjsip/pjsip_configuration.c, res/res_pjsip.c,
  4128. res/res_pjsip_session.c, include/asterisk/res_pjsip.h:
  4129. res_pjsip_session: Add configurable behavior for redirects. The
  4130. action taken when a redirect occurs is now configurable on a
  4131. per-endpoint basis. The redirect can either be treated as a
  4132. redirect to a local extension, to a URI that is dialed through
  4133. the Asterisk core, or to a URI that is dialed within PJSIP
  4134. itself. (closes issue ASTERISK-21710) Reported by: Matt Jordan
  4135. Review: https://reviewboard.asterisk.org/r/2963/
  4136. * res/res_pjsip/pjsip_configuration.c: res_pjsip: Fix crash when
  4137. reloading certain configurations. Certain options available that
  4138. specify a SIP URI perform validation on the provided URI using
  4139. the PJSIP URI parser. This operation requires that the thread
  4140. executing it be registered with the PJLIB library. During reloads
  4141. this was done on a thread which was NOT registered with it. This
  4142. fixes the problem by creating a task which reloads the
  4143. configuration on a PJSIP thread. (closes issue ASTERISK-22923)
  4144. Reported by: Anthony Messina
  4145. 2013-11-27 15:36 +0000 [r403175] David M. Lee <dlee@digium.com>
  4146. * res/res_ari_channels.c, include/asterisk/ari.h,
  4147. rest-api-templates/param_parsing.mustache,
  4148. include/asterisk/http.h, res/res_ari_recordings.c,
  4149. res/res_ari_endpoints.c, main/http.c,
  4150. rest-api-templates/swagger_model.py, res/res_ari_playbacks.c,
  4151. res/res_ari_sounds.c, rest-api-templates/asterisk_processor.py,
  4152. res/res_ari_bridges.c, tests/test_ari.c, res/res_ari.c,
  4153. res/res_ari_device_states.c, res/res_ari_asterisk.c,
  4154. rest-api-templates/res_ari_resource.c.mustache,
  4155. res/res_ari_applications.c: ari:Add application/json parameter
  4156. support The patch allows ARI to parse request parameters from an
  4157. incoming JSON request body, instead of requiring the request to
  4158. come in as query parameters (which is just weird for POST and
  4159. DELETE) or form parameters (which is okay, but a bit asymmetric
  4160. given that all of our responses are JSON). For any operation that
  4161. does _not_ have a parameter defined of type body (i.e.
  4162. "paramType": "body" in the API declaration), if a request
  4163. provides a request body with a Content type of
  4164. "application/json", the provided JSON document is parsed and
  4165. searched for parameters. The expected fields in the provided JSON
  4166. document should match the query parameters defined for the
  4167. operation. If the parameter has 'allowMultiple' set, then the
  4168. field in the JSON document may optionally be an array of values.
  4169. (closes issue ASTERISK-22685) Review:
  4170. https://reviewboard.asterisk.org/r/2994/
  4171. 2013-11-27 15:31 +0000 [r403160-403173] Joshua Colp <jcolp@digium.com>
  4172. * res/res_pjsip/pjsip_configuration.c: res_pjsip: Update handling
  4173. of some options to work with new option names. Some options (such
  4174. as call_group and pickup_group) share the same configuration
  4175. handler and decide what logic to use based on the name of the
  4176. option. These handlers were not updated to check for the new
  4177. option names and were treating the options as invalid. This
  4178. change simply updates the handlers with the proper names of the
  4179. options. (closes issue ASTERISK-22922) Reported by: Anthony
  4180. Messina
  4181. * configure, include/asterisk/autoconfig.h.in, configure.ac: Fix a
  4182. configure issue with PJSIP transaction group lock detection. The
  4183. configure check did not use the provided paths for pjproject if
  4184. provided when looking for transaction group lock support.
  4185. 2013-11-23 17:38 +0000 [r403131-403134] Kevin Harwell <kharwell@digium.com>
  4186. * include/asterisk/stasis_app.h, main/devicestate.c,
  4187. res/stasis/app.h, rest-api/resources.json,
  4188. res/res_stasis_device_state.c (added),
  4189. res/ari/ari_model_validators.c, res/ari/ari_model_validators.h,
  4190. res/ari/resource_device_states.c (added),
  4191. rest-api/api-docs/deviceStates.json (added),
  4192. rest-api-templates/ari.make.mustache, res/ari.make,
  4193. rest-api/api-docs/applications.json,
  4194. include/asterisk/stasis_app_device_state.h (added),
  4195. res/ari/resource_device_states.h (added),
  4196. res/ari/resource_applications.h, res/res_stasis.c,
  4197. include/asterisk/devicestate.h,
  4198. res/res_stasis_device_state.exports.in (added),
  4199. rest-api/api-docs/events.json, res/res_ari_device_states.c
  4200. (added), res/stasis/app.c: ARI: Implement device state API
  4201. Created a data model and implemented functionality for an ARI
  4202. device state resource. The following operations have been added
  4203. that allow a user to manipulate an ARI controlled device:
  4204. Create/Change the state of an ARI controlled device PUT
  4205. /deviceStates/{deviceName}&{deviceState} Retrieve all ARI
  4206. controlled devices GET /deviceStates Retrieve the current state
  4207. of a device GET /deviceStates/{deviceName} Destroy a device-state
  4208. controlled by ARI DELETE /deviceStates/{deviceName} The ARI
  4209. controlled device must begin with 'Stasis:'. An example
  4210. controlled device name would be Stasis:Example. A
  4211. 'DeviceStateChanged' event has also been added so that an
  4212. application can subscribe and receive device change events. Any
  4213. device state, ARI controlled or not, can be subscribed to. While
  4214. adding the event, the underlying subscription control mechanism
  4215. was refactored so that all current and future resource
  4216. subscriptions would be the same. Each event resource must now
  4217. register itself in order to be able to properly handle
  4218. [un]subscribes. (issue ASTERISK-22838) Reported by: Matt Jordan
  4219. Review: https://reviewboard.asterisk.org/r/3025/
  4220. * res/res_pjsip_exten_state.c, include/asterisk/res_pjsip_pubsub.h,
  4221. res/res_pjsip/location.c, res/res_pjsip_outbound_registration.c,
  4222. res/res_pjsip_mwi.c, include/asterisk/sorcery.h,
  4223. res/res_pjsip/pjsip_configuration.c, include/asterisk/strings.h,
  4224. res/res_pjsip_pubsub.c,
  4225. res/res_pjsip/include/res_pjsip_private.h,
  4226. res/res_pjsip/config_transport.c, res/res_pjsip_registrar.c,
  4227. main/sorcery.c, include/asterisk/res_pjsip.h,
  4228. include/asterisk/acl.h, res/res_pjsip/config_auth.c,
  4229. include/asterisk/utils.h, res/res_pjsip.exports.in,
  4230. res/res_pjsip_endpoint_identifier_ip.c, main/acl.c, main/utils.c,
  4231. res/res_pjsip.c: res_pjsip: AMI commands and events. Created the
  4232. following AMI commands and corresponding events for res_pjsip:
  4233. PJSIPShowEndpoints - Provides a listing of all pjsip endpoints
  4234. and a few select attributes on each. Events: EndpointList - for
  4235. each endpoint a few attributes. EndpointlistComplete - after all
  4236. endpoints have been listed. PJSIPShowEndpoint - Provides a detail
  4237. list of attributes for a specified endpoint. Events:
  4238. EndpointDetail - attributes on an endpoint. AorDetail - raised
  4239. for each AOR on an endpoint. AuthDetail - raised for each
  4240. associated inbound and outbound auth TransportDetail - transport
  4241. attributes. IdentifyDetail - attributes for the identify object
  4242. associated with the endpoint. EndpointDetailComplete - last event
  4243. raised after all detail events. PJSIPShowRegistrationsInbound -
  4244. Provides a detail listing of all inbound registrations. Events:
  4245. InboundRegistrationDetail - inbound registration attributes for
  4246. each registration. InboundRegistrationDetailComplete - raised
  4247. after all detail records have been listed.
  4248. PJSIPShowRegistrationsOutbound - Provides a detail listing of all
  4249. outbound registrations. Events: OutboundRegistrationDetail -
  4250. outbound registration attributes for each registration.
  4251. OutboundRegistrationDetailComplete - raised after all detail
  4252. records have been listed. PJSIPShowSubscriptionsInbound - A
  4253. detail listing of all inbound subscriptions and their attributes.
  4254. Events: SubscriptionDetail - on each subscription detailed
  4255. attributes SubscriptionDetailComplete - raised after all detail
  4256. records have been listed. PJSIPShowSubscriptionsOutbound - A
  4257. detail listing of all outboundbound subscriptions and their
  4258. attributes. Events: SubscriptionDetail - on each subscription
  4259. detailed attributes SubscriptionDetailComplete - raised after all
  4260. detail records have been listed. (issue ASTERISK-22609) Reported
  4261. by: Matt Jordan Review: https://reviewboard.asterisk.org/r/2959/
  4262. 2013-11-23 12:51 +0000 [r403117-403119] Joshua Colp <jcolp@digium.com>
  4263. * res/ari/ari_model_validators.h, res/res_stasis_playback.c,
  4264. rest-api/api-docs/events.json, res/res_stasis_recording.c,
  4265. res/ari/ari_model_validators.c,
  4266. rest-api/api-docs/recordings.json: ari: Add events for playback
  4267. and recording. While there were events defined for playback and
  4268. recording these were not actually sent. This change implements
  4269. the to_json handlers which produces them. (closes issue
  4270. ASTERISK-22710) Reported by: Jonathan Rose Review:
  4271. https://reviewboard.asterisk.org/r/3026/
  4272. * main/audiohook.c, res/ari/resource_channels.c,
  4273. res/res_stasis_snoop.c (added), res/res_ari_channels.c,
  4274. res/ari/resource_channels.h, res/res_stasis_snoop.exports.in
  4275. (added), include/asterisk/stasis_app_snoop.h (added),
  4276. rest-api/api-docs/channels.json: ari: Add Snoop operation for
  4277. spying/whispering on channels. The Snoop operation can be invoked
  4278. on a channel to spy or whisper on it. It returns a channel that
  4279. any channel operations can then be invoked on (such as record to
  4280. do monitoring). (closes issue ASTERISK-22780) Reported by: Matt
  4281. Jordan Review: https://reviewboard.asterisk.org/r/3003/
  4282. 2013-11-22 23:44 +0000 [r403094] Kinsey Moore <kmoore@digium.com>
  4283. * tests/test_stasis.c, tests/test_stasis_channels.c: Make sure unit
  4284. tests compile This fixes the unit tests that were broken by
  4285. r403069 and several functions requiring a new parameter for
  4286. sanitization of JSON messages generated from object snapshots.
  4287. 2013-11-22 22:24 +0000 [r403082] Kevin Harwell <kharwell@digium.com>
  4288. * contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py,
  4289. res/res_pjsip/pjsip_configuration.c: res_pjsip: convert
  4290. configuration settings names to snake case some more Updated the
  4291. alembic script for pjsip. Also, the dtls config parsing stuff was
  4292. expecting strings with no underscores, so removed the underscores
  4293. from the option name before passing it to the parser.
  4294. 2013-11-22 20:01 +0000 [r403069] Kinsey Moore <kmoore@digium.com>
  4295. * main/stasis_endpoints.c, res/ari/resource_endpoints.c,
  4296. main/rtp_engine.c, res/stasis/app.c,
  4297. include/asterisk/stasis_bridges.h, include/asterisk/stasis_app.h,
  4298. include/asterisk/stasis.h, main/stasis_bridges.c,
  4299. res/ari/resource_bridges.c, main/json.c, main/stasis_message.c,
  4300. include/asterisk/stasis_channels.h, main/stasis_channels.c,
  4301. res/ari/resource_channels.c, include/asterisk/stasis_endpoints.h,
  4302. res/res_stasis.c: ARI: Don't leak implementation details This
  4303. change prevents channels used as implementation details from
  4304. leaking out to ARI. It does this by preventing creation of JSON
  4305. blobs of channel snapshots created from those channels and
  4306. sanitizing JSON blobs of bridge snapshots as they are created.
  4307. This introduces a framework for excluding information from output
  4308. targeted at Stasis applications on a consumer-by-consumer basis
  4309. using channel sanitization callbacks which could be extended to
  4310. bridges or endpoints if necessary. This prevents unhelpful error
  4311. messages from being generated by ast_json_pack. This also
  4312. corrects a bug where BridgeCreated events would not be created.
  4313. (closes issue ASTERISK-22744) Review:
  4314. https://reviewboard.asterisk.org/r/2987/ Reported by: David M.
  4315. Lee
  4316. 2013-11-22 17:19 +0000 [r403022] Kevin Harwell <kharwell@digium.com>
  4317. * res/res_pjsip_acl.c, res/res_pjsip.c,
  4318. res/res_pjsip/config_transport.c, res/res_pjsip/config_global.c,
  4319. configs/pjsip.conf.sample, res/res_pjsip/config_system.c,
  4320. contrib/scripts/sip_to_pjsip/sip_to_pjsip.py,
  4321. res/res_pjsip/pjsip_configuration.c: res_pjsip: convert
  4322. configuration settings names to snake case Renamed, where
  4323. appropriate, the configuration options for chan/res_pjsip to use
  4324. snake case (compound words separated by an underscore). For
  4325. example, faxdetect will become fax_detect, recordofffeature will
  4326. become record_off_feature, etc... Review:
  4327. https://reviewboard.asterisk.org/r/3002/
  4328. 2013-11-22 17:11 +0000 [r403016] Joshua Colp <jcolp@digium.com>
  4329. * /, main/translate.c: translate: Move freeing of frame to after it
  4330. is used. When translating from one format to another it is
  4331. possible to inform the translation function that the source frame
  4332. should be freed. This was previously done immediately but shortly
  4333. afterwards the frame that was freed was accessed and used again.
  4334. This change moves code around a bit so that the frame is now
  4335. freed after it has been completely used. (closes issue
  4336. ASTERISK-22788) Reported by: Corey Farrell Patches:
  4337. translate-access-after-free-11up.patch uploaded by coreyfarrell
  4338. (license 5909) translate-access-after-free-1.8.patch uploaded by
  4339. coreyfarrell (license 5909) ........ Merged revisions 403014 from
  4340. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4341. revisions 403015 from
  4342. http://svn.asterisk.org/svn/asterisk/branches/11
  4343. 2013-11-21 22:35 +0000 [r402981-402993] David M. Lee <dlee@digium.com>
  4344. * rest-api-templates/ari_resource.c.mustache,
  4345. rest-api-templates/res_ari_resource.c.mustache: ari: Fix #include
  4346. to match generated headers for snakeCase resource files
  4347. * rest-api-templates/make_ari_stubs.py: ari: Fix generators for
  4348. resources with camelCase names. For the new deviceState resource,
  4349. we need to properly generate device_state.[ch] files.
  4350. 2013-11-21 19:21 +0000 [r402968] Matthew Jordan <mjordan@digium.com>
  4351. * res/res_pjsip_session.c: res_pjsip_session: Fix memory leak of
  4352. direct media format capabilities The direct media format
  4353. capabilities are always allocated in ast_sip_session_alloc and
  4354. were not freed in the session destructor. Whoops. (This being the
  4355. third whoops caught by Scott and Nitesh's valgrind work for the
  4356. Asterisk Test Suite. Nifty!)
  4357. 2013-11-21 19:08 +0000 [r402944-402956] Richard Mudgett <rmudgett@digium.com>
  4358. * include/asterisk/app.h: voicemail: Fixup some doxygen comments.
  4359. * main/bucket.c: bucket: Fix scheme ref leak in
  4360. __ast_bucket_scheme_register().
  4361. 2013-11-21 17:52 +0000 [r402940-402941] Matthew Jordan <mjordan@digium.com>
  4362. * res/res_pjsip_sdp_rtp.c: res_pjsip_sdp_rtp: Fix use of
  4363. uninitialized value in PJSIP In PJMEDIA,
  4364. pjmedia_sdp_rtpmap_to_attr will attempt to use the string
  4365. rtpmap.param regardless of its length value. Simply setting the
  4366. length to 0 does not prevent the garbage on the stack in
  4367. rtpmap.param.ptr from being formatted in a sprintf call. This
  4368. patch initializes the string to NULL so that at the very least,
  4369. something is provided to the function that is predictable.
  4370. * res/res_pjsip_mwi.c: res_pjsip_mwi: Fix memory leak of MWI
  4371. subscriptions container This patch fixes a reference counting
  4372. memory leak on the ao2_container created as part of
  4373. create_mwi_subscriptions. When we create the container in this
  4374. routine, the intent is to hand lifetime ownership over to the
  4375. global container unsolicited_mwi. When
  4376. ao2_global_obj_replace_unref is called, the reference count on
  4377. mwi_subscriptions (the container) will be bumped by 1; however,
  4378. the function does not decrement the reference count on
  4379. mwi_subscriptions when this occurs. This will prevent the
  4380. container from being fully disposed of when Asterisk exits (or on
  4381. any subsequent call to this operation, such as during a reload).
  4382. 2013-11-21 15:55 +0000 [r402926] David M. Lee <dlee@digium.com>
  4383. * res/stasis/control.c, include/asterisk/stasis_app.h,
  4384. rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  4385. res/res_ari_channels.c, res/ari/resource_channels.h: ari: Add
  4386. silence generator controls This patch adds the ability to start a
  4387. silence generator on a channel via ARI. This generator will play
  4388. silence on the channel (avoiding audio timeouts on the peer)
  4389. until it is stopped, or some other media operation is started
  4390. (like playing media, starting music on hold, etc.). (closes issue
  4391. ASTERISK-22514) Review: https://reviewboard.asterisk.org/r/3019/
  4392. 2013-11-19 23:17 +0000 [r402891] Joshua Colp <jcolp@digium.com>
  4393. * res/res_pjsip_caller_id.c: res_pjsip_caller_id: Don't overwrite
  4394. user portion of the From header when fromuser is set. The
  4395. fromuser option is used to explicitly set the user within the
  4396. From header. The res_pjsip_caller_id module did not take this
  4397. setting into account when determining if the From header could be
  4398. modified or not. (closes issue ASTERISK-22866) Reported by:
  4399. Anthony Messina
  4400. 2013-11-16 13:44 +0000 [r402864] Joshua Colp <jcolp@digium.com>
  4401. * res/res_pjsip/pjsip_distributor.c, configure,
  4402. include/asterisk/autoconfig.h.in, configure.ac: res_pjsip: Add
  4403. support for building against pjproject with SIP transaction group
  4404. lock support. SIP transaction group lock support has been
  4405. backported into our pjproject. Since the code now internally uses
  4406. a group lock the code is now changed to unlock it if present.
  4407. Note that the act of finding the transaction is what actually
  4408. returns it locked. For further information about group locks
  4409. check out the wiki page at:
  4410. http://trac.pjsip.org/repos/wiki/Group_Lock (issue
  4411. ASTERISK-22818) Reported by: Matt Jordan
  4412. 2013-11-15 14:35 +0000 [r402838] Kinsey Moore <kmoore@digium.com>
  4413. * main/cel.c: CEL: Fix crash when using CELGenUserEvent This fixes
  4414. a crash when CELGenUserEvent is called from the dialplan while
  4415. CEL is disabled. Currently, CEL does not create its topics and
  4416. forwards if it is not enabled and external entities may depend on
  4417. these topics blindly since they should always be available. This
  4418. patch breaks up route creation and topic/forward creation such
  4419. that the CEL topics and forwards will always exist while the
  4420. router and its associated routes will be torn down and recreated
  4421. as necessary. (closes issue ASTERISK-22799) Review:
  4422. https://reviewboard.asterisk.org/r/3010/ Reported by: Matt Jordan
  4423. 2013-11-14 15:01 +0000 [r402817] David M. Lee <dlee@digium.com>
  4424. * res/res_stasis.c: stasis: Fixed scoping problem with bridge
  4425. tracking.
  4426. 2013-11-13 23:09 +0000 [r402804] Joshua Colp <jcolp@digium.com>
  4427. * res/stasis/control.c, include/asterisk/stasis_app.h,
  4428. rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  4429. res/res_ari_channels.c, res/ari/resource_channels.h:
  4430. res_ari_channels: Add the ability to stop locally generated
  4431. ringing on a channel. Using the 'ring' operation it is possible
  4432. to start locally generated ringback if the channel is answered.
  4433. This change adds the ability to stop it by using DELETE.
  4434. 2013-11-12 23:16 +0000 [r402787-402793] Kevin Harwell <kharwell@digium.com>
  4435. * res/ari/resource_endpoints.c: ari endpoints: GET
  4436. /ari/endpoints/{invalid-tech} should return a 404 Was returning a
  4437. 404 on a valid technology with an empty list of endpoints. Now
  4438. checking against the channel tech to make sure the tech itself is
  4439. valid and not just an empty list of endpoints. (issue
  4440. ASTERISK-22803) Reported by: David M. Lee
  4441. * rest-api/api-docs/endpoints.json, res/ari/resource_endpoints.c,
  4442. res/res_ari_endpoints.c: ari endpoints: GET
  4443. /ari/endpoints/{invalid-tech} should return a 404 Implementation
  4444. listing endpoints by technology returned an empty array if no
  4445. matching endpoints were found. Fixed so a "404 Not Found" will be
  4446. returned instead. (closes issue ASTERISK-22803) Reported by:
  4447. David M. Lee
  4448. 2013-11-12 19:11 +0000 [r402767-402769] Mark Michelson <mmichelson@digium.com>
  4449. * main/channel.c: Switch to a scoped lock to avoid missing unlocks
  4450. in failure returns.
  4451. * main/channel.c: Move a NULL check to a place that makes more
  4452. sense. Two variables were being checked for NULLity immediately
  4453. after being declared NULL. I moved the NULL check until after the
  4454. variables are allocated. This allows for the "channelvars" option
  4455. in manager.conf to work as intended again.
  4456. 2013-11-12 16:45 +0000 [r402757] Kevin Harwell <kharwell@digium.com>
  4457. * res/res_pjsip_messaging.c, res/res_pjsip_header_funcs.c:
  4458. pjsip_messaging, pjsip_header_funcs: Crashes due to NULL pointer
  4459. dereferences Both res_pjsip_messaging and res_pjsip_header_funcs
  4460. were causing asterisk to crash because they were trying to
  4461. dereference a NULL pointer. In the case of res_pjsip_messaging it
  4462. was attempting to "print" a contact header that did not exist. In
  4463. fact contact headers should not be part of a SIP MESSAGE, so the
  4464. offending code was simply removed. In the case of
  4465. res_pjsip_header_funcs a null private channel tech was being
  4466. passed to the function and then later dereferenced. Added null
  4467. checks (and error logging) to the read/write function handlers to
  4468. guard against crashing. (closes issue ASTERISK-22821) Reported
  4469. by: Anthony Messina
  4470. 2013-11-12 16:33 +0000 [r402755] Kinsey Moore <kmoore@digium.com>
  4471. * apps/app_celgenuserevent.c: CELGenUserEvent: Fix error message
  4472. from ast_json_pack This prevents NULL from being passed into an
  4473. ast_json_pack call when no extra information is passed to the
  4474. application which prevents an error message about NULL arguments
  4475. from being generated.
  4476. 2013-11-12 15:26 +0000 [r402738] David M. Lee <dlee@digium.com>
  4477. * res/ari/ari_model_validators.h, rest-api/api-docs/events.json:
  4478. Fixed a typ.
  4479. 2013-11-12 15:02 +0000 [r402710] Kinsey Moore <kmoore@digium.com>
  4480. * channels/chan_dahdi.c, /: chan_dahdi: Fix crash during caller ID
  4481. read Asterisk will sometimes core dump during caller id read on
  4482. analog channels due to a negative return value from the read() in
  4483. my_get_callerid that slips through as a negative length argument
  4484. to callerid_feed() if the errno returned by DAHDI is ELAST. This
  4485. change ensures that the negative return is treated properly even
  4486. when it is ELAST. (closes issue ASTERISK-22746) Reported by:
  4487. Michael Walton Patches: chan_dahdi_cid_crash_fix.r401410.patch
  4488. uploaded by Michael Walton (License 6502) ........ Merged
  4489. revisions 402708 from
  4490. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4491. revisions 402709 from
  4492. http://svn.asterisk.org/svn/asterisk/branches/11
  4493. 2013-11-11 19:26 +0000 [r402687] Mark Michelson <mmichelson@digium.com>
  4494. * /, apps/app_confbridge.c: Get rid of some inaccurate comments.
  4495. I'm doing some unrelated work in app_confbridge and finding these
  4496. "invalid pin" comments to be annoying. Get out! ........ Merged
  4497. revisions 402686 from
  4498. http://svn.asterisk.org/svn/asterisk/branches/11
  4499. 2013-11-11 15:36 +0000 [r402647] Kinsey Moore <kmoore@digium.com>
  4500. * apps/app_queue.c, /: app_queue: Honor penalty limits of 0 In the
  4501. current app_queue code from 1.8 up to trunk the upper and lower
  4502. penalties can be set to 0 but the value is interpreted to be
  4503. disabled instead of actually setting limits. This is especially
  4504. evident if min and max limits are set to 0 and members with
  4505. penalties of 0 and 1 are in the queue since the member with
  4506. penalty 1 will still receive calls. This patch adjusts the
  4507. special disabled value to be INT_MAX instead of 0. (closes issue
  4508. ASTERISK-20862) Review: https://reviewboard.asterisk.org/r/2995/
  4509. Reported by: Schmooze Com ........ Merged revisions 402645 from
  4510. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4511. revisions 402646 from
  4512. http://svn.asterisk.org/svn/asterisk/branches/11
  4513. 2013-11-08 23:04 +0000 [r402606] Scott Griepentrog <sgriepentrog@digium.com>
  4514. * /, channels/chan_sip.c, channels/sip/include/sip.h: chan_sip:
  4515. keep same local (from) tag for outgoing register requests For
  4516. outbound register requests the tag on the From line was updated
  4517. every 20 seconds prior to a successful registration and also once
  4518. for each registration renewal. That behavior can possibly cause
  4519. the registration to be denied because of the different tag, and
  4520. is not aligned with the intention of RFC 3261 8.1.3.5 "...
  4521. request constitutes a new transaction and SHOULD have the same
  4522. value of the Call-ID, To, and From of the previous request...".
  4523. This updates chan_sip to have a field to keep the local tag in
  4524. the registration structure and use that tag for registration
  4525. requests where the callid is also unchanged. (closes issue
  4526. ASTERISK-12117) Reported by: Pawel Pierscionek Review:
  4527. https://reviewboard.asterisk.org/r/2988/ ........ Merged
  4528. revisions 402604 from
  4529. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4530. revisions 402605 from
  4531. http://svn.asterisk.org/svn/asterisk/branches/11
  4532. 2013-11-08 20:20 +0000 [r402593] Richard Mudgett <rmudgett@digium.com>
  4533. * res/res_stasis.c: res_stasis.c: Fix locking issues with the
  4534. app_bridge_moh container. * Fix unlinking from the
  4535. app_bridges_moh container in remove_bridge_moh() without a lock
  4536. under normal circumstances. * Made check
  4537. ast_bridge_set_after_callback() return value in
  4538. bridge_moh_create() to handle failure. * Fixed SCOPED_AO2LOCK()
  4539. locking over too much scope in stasis_app_bridge_moh_channel()
  4540. and stasis_app_bridge_moh_stop(). * Fixed unusual usage of
  4541. ao2_unlink_flag() in control_unlink(). * Fixed orphaned bridge
  4542. from off nominal path in stasis_app_bridge_create(). * Fixed
  4543. strange construct in stasis_app_unsubscribe(). From a bad merge?
  4544. * Made load_module() cleanup on failure. Review:
  4545. https://reviewboard.asterisk.org/r/2962/
  4546. 2013-11-08 19:28 +0000 [r402584] Jonathan Rose <jrose@digium.com>
  4547. * configs/manager.conf.sample, CHANGES, include/asterisk/manager.h,
  4548. main/manager.c, main/security_events.c: security_events: Push out
  4549. security events over AMI events Security Events will now be
  4550. written to any listener of the new 'security' class Review:
  4551. https://reviewboard.asterisk.org/r/2998/
  4552. 2013-11-08 19:22 +0000 [r402582] Mark Michelson <mmichelson@digium.com>
  4553. * res/res_pjsip.c: Clarify an ambiguous error message.
  4554. 2013-11-08 18:48 +0000 [r402561-402570] David M. Lee <dlee@digium.com>
  4555. * res/res_pjsip/config_system.c: res_pjsip: Print a helpful error
  4556. message if sorcery registration fails
  4557. * res/ari/resource_playbacks.h: Changes from make ari-stubs after
  4558. r402560
  4559. 2013-11-08 17:39 +0000 [r402560] Kevin Harwell <kharwell@digium.com>
  4560. * res/ari/resource_playbacks.h (added), res/ari.make,
  4561. rest-api/api-docs/playback.json (removed),
  4562. res/ari/resource_playback.c (removed), res/res_ari_playback.c
  4563. (removed), rest-api/api-docs/playbacks.json (added),
  4564. res/ari/resource_playbacks.c (added), rest-api/resources.json,
  4565. res/ari/resource_playback.h (removed), res/res_ari_playbacks.c
  4566. (added): ARI playback: Rename ARI Playback to Playbacks Before
  4567. playback was the only non plural resource. It has been renamed to
  4568. playbacks for consistency. (closes issue ASTERISK-22737) Reported
  4569. by: Paul Belanger
  4570. 2013-11-08 17:28 +0000 [r402555] David M. Lee <dlee@digium.com>
  4571. * res/res_ari.c, main/manager.c, main/http.c: ari: Add
  4572. application/x-www-form-urlencoded parameter support ARI POST
  4573. calls only accept parameters via the URL's query string. While
  4574. this works, it's atypical for HTTP API's in general, and
  4575. specifically frowned upon with RESTful API's. This patch adds
  4576. parsing for application/x-www-form-urlencoded request bodies if
  4577. they are sent in with the request. Any variables parsed this way
  4578. are prepended to the variable list supplied by the query string.
  4579. (closes issue ASTERISK-22743) Review:
  4580. https://reviewboard.asterisk.org/r/2986/
  4581. 2013-11-07 23:16 +0000 [r402537] Jonathan Rose <jrose@digium.com>
  4582. * res/res_pjsip_authenticator_digest.c: PJSIP: Improve error
  4583. handling in digest authenticator Previously, regardless of
  4584. whether failure to authenticate was due to lacking any
  4585. authentication or actually failing authentication, the Digest
  4586. Authenticator would simply return that a challenge was still
  4587. needed. It will continue to do that when no authentication
  4588. information is in the received SIP digest, but when
  4589. authentication information is present and does not pass
  4590. authentication, that will be treated as an authentication error.
  4591. This is to ensure that PJSIP will issue security events indicated
  4592. failed auths.
  4593. 2013-11-07 21:09 +0000 [r402528] David M. Lee <dlee@digium.com>
  4594. * rest-api-templates/swagger_model.py, res/ari/resource_asterisk.h,
  4595. rest-api-templates/ari_resource.c.mustache,
  4596. rest-api-templates/asterisk_processor.py, res/res_ari_bridges.c,
  4597. rest-api/api-docs/endpoints.json, res/ari/resource_endpoints.c,
  4598. res/ari/resource_endpoints.h, res/res_ari_applications.c,
  4599. res/res_ari_playback.c, res/res_ari_channels.c,
  4600. rest-api/api-docs/bridges.json, res/ari/resource_bridges.c,
  4601. res/res_ari_recordings.c, res/ari/resource_bridges.h,
  4602. res/res_ari_events.c, res/ari/resource_applications.c,
  4603. res/ari/resource_playback.c, rest-api/api-docs/channels.json,
  4604. res/ari/resource_applications.h, res/ari/resource_channels.c,
  4605. res/ari/resource_playback.h, res/res_ari_sounds.c,
  4606. rest-api/api-docs/recordings.json, res/ari/resource_recordings.c,
  4607. res/ari/resource_channels.h,
  4608. rest-api-templates/ari_resource.h.mustache,
  4609. res/ari/resource_events.c, res/ari/resource_recordings.h,
  4610. rest-api-templates/rest_handler.mustache, res/res_ari_asterisk.c,
  4611. rest-api-templates/res_ari_resource.c.mustache,
  4612. res/ari/resource_events.h, rest-api/api-docs/sounds.json,
  4613. res/ari/resource_sounds.c, res/ari/resource_sounds.h,
  4614. rest-api/api-docs/asterisk.json,
  4615. rest-api/api-docs/applications.json, res/res_ari_endpoints.c,
  4616. res/ari/resource_asterisk.c, rest-api/api-docs/playback.json:
  4617. ari: User better nicknames for ARI operations While working on
  4618. building client libraries from the Swagger API, I noticed a
  4619. problem with the nicknames. channel.deleteChannel()
  4620. channel.answerChannel() channel.muteChannel() Etc. We put the
  4621. object name in the nickname (since we were generating C code),
  4622. but it makes OO generators redundant. This patch makes the
  4623. nicknames more OO friendly. This resulted in a lot of name
  4624. changing within the res_ari_*.so modules, but not much else.
  4625. There were a couple of other fixed I made in the process. * When
  4626. reversible operations (POST /hold, POST /unhold) were made more
  4627. RESTful (POST /hold, DELETE /unhold), the path for the second
  4628. operation was left in the API declaration. This worked, but
  4629. really the two operations should have been on the same API. * The
  4630. POST /unmute operation had still not been REST-ified. Review:
  4631. https://reviewboard.asterisk.org/r/2940/
  4632. 2013-11-06 21:57 +0000 [r402517] Kevin Harwell <kharwell@digium.com>
  4633. * apps/app_queue.c: app_queue: crash if first agent is "busy" If
  4634. the first agent/member (via CLI "queue show") in a queue is
  4635. "busy" (dnd, circuit busy, etc...) and no agents answered then
  4636. app_queue would crash. This occurred because while the calling of
  4637. agent(s) remained valid the channel on "busy" agent would be set
  4638. to NULL and then later dereferenced upon a second "rna" function
  4639. call. The original intention of the code is to have only valid
  4640. "call attempt" objects (channels != NULL) checked while
  4641. attempting to call agent(s). It does this by building a
  4642. "call_next" list of valid "call attempt" objects. In the case of
  4643. the "busy" agent subsequent builds of the valid "call attempt"
  4644. list would sometimes include (the case mentioned above) an
  4645. invalid "call attempt" object. The fix was to make sure the "call
  4646. attempt" list was appropriately built on every iteration. A NULL
  4647. sanity check was also added at the original offending spot of the
  4648. crash just in case another one slipped by somehow. (closes issue
  4649. ASTERISK-22644) Reported by: Marco Signorini Review:
  4650. https://reviewboard.asterisk.org/r/2983/
  4651. 2013-11-05 21:16 +0000 [r402501-402507] Matthew Jordan <mjordan@digium.com>
  4652. * channels/chan_sip.c: chan_sip: Use AST_AF* defined constant when
  4653. calling ast_get_ip While the structure passed to ast_get_ip
  4654. should be set memset to 0, thus initializing the ss_family member
  4655. to 0, explicitly setting it to AST_AF_UNSPEC is more portable.
  4656. * channels/chan_iax2.c: chan_iax2: Fix incorrect usage of
  4657. ast_get_ip involving uninitialized struct This started off as a
  4658. fix for the failing IAX2 acl_call test in the Asterisk Test
  4659. Suite. When inspecting why that test was failing, it became clear
  4660. that all attempts to bind to any local loopback address was
  4661. failing: [Nov 2 15:56:28] VERBOSE[15787] chan_iax2.c: == Binding
  4662. IAX2 to address 127.0.0.1:4569 [Nov 2 15:56:28] DEBUG[15787]
  4663. netsock2.c: Splitting '127.0.0.1' into... [Nov 2 15:56:28]
  4664. DEBUG[15787] netsock2.c: ...host '127.0.0.1' and port ''. [Nov 2
  4665. 15:56:28] ERROR[15787] netsock2.c: getaddrinfo("127.0.0.1",
  4666. "(null)", ...): ai_family not supported [Nov 2 15:56:28]
  4667. WARNING[15787] acl.c: Unable to lookup '127.0.0.1' While there's
  4668. conceivably other ways for getaddrino to return EAI_FAMILY, the
  4669. most common way is if AF_INET, AF_INET6, or AF_UNSPEC is not
  4670. provided as the desired family. The culprit was the call to
  4671. ast_get_ip, defined in acl.h. This function uses the family from
  4672. the passed in addr object (which it will also populate when it
  4673. returns!) when it eventually calls getaddrinfo. This patch fixes
  4674. the use of ast_get_ip that were not specifying the family in
  4675. chan_iax2. This prevents uninitialized use of the structure, so
  4676. that the addresses resolve correctly. Review:
  4677. https://reviewboard.asterisk.org/r/2991
  4678. * include/asterisk/netsock2.h, include/asterisk/acl.h: netsock2:
  4679. Define AST_AF_* enum constants to their AF_* equivalents This
  4680. patch explicitly defines AST_AF_* enum constants to their
  4681. sys/socket.h defined equivalents. It is certainly unclear why
  4682. these constants actually have to exist, given that netsock2.h
  4683. includes sys/socket.h; however, since the code base is already
  4684. liberally sprinkled with the usage of AST_AF_* (as well as with
  4685. direct calls to AF_*), this will at least keep the semantics
  4686. consistent between their usage across systems.
  4687. * main/stasis_channels.c: stasis_channels: Don't give preference to
  4688. ANI info in channel snapshots When publishing channel snapshots,
  4689. we currently compute the caller ID name and number by giving
  4690. preference first to ani.{name|number}, then to id.{name|number}.
  4691. However, when a channel driver (such as chan_sip) updates the
  4692. caller ID, it typically only updates the caller ID stored in
  4693. id.{name|number}. This means that we are currently giving
  4694. preference to stale information. When looking at the rest of the
  4695. code base, the only other place where we appear to use this same
  4696. logic is in app_amd. Everywhere else, we treat the party
  4697. information in ani as being separate to the party information in
  4698. id. This patch publishes only the caller ID name and number in
  4699. the snapshot field for caller_name and caller_num. Note that the
  4700. information in ANI is still available in caller_ani. Review:
  4701. https://reviewboard.asterisk.org/r/2992/
  4702. 2013-11-04 20:56 +0000 [r402452] Kevin Harwell <kharwell@digium.com>
  4703. * /, channels/chan_sip.c: chan_sip: notify dialog info ignores
  4704. presentation indicator in callerid The presentation indicator in
  4705. a callerid (e.g. set by dialplan function
  4706. Set(CALLERID(name-pres)= ...)) is not checked when SIP Dialog
  4707. Info Notifies are generated during extension monitoring. Added a
  4708. check to make sure the name and/or number presentations on the
  4709. callee (remote identity) are set to allow. If they are restricted
  4710. then "anonymous" is used instead. (closes issue AST-1175)
  4711. Reported by: Thomas Arimont Review:
  4712. https://reviewboard.asterisk.org/r/2976/ ........ Merged
  4713. revisions 402450 from
  4714. http://svn.asterisk.org/svn/asterisk/branches/11
  4715. 2013-11-02 04:30 +0000 [r402398-402438] Richard Mudgett <rmudgett@digium.com>
  4716. * main/stasis.c, main/stasis_message_router.c,
  4717. include/asterisk/vector.h: vector: Uppercase API to follow C
  4718. convention. C does not support templates like C++.
  4719. * main/stasis.c, main/stasis_message_router.c,
  4720. include/asterisk/vector.h, include/asterisk/lock.h: vector:
  4721. Update API to be more flexible. Made the vector macro API be more
  4722. like linked lists. 1) Added a name parameter to ast_vector() to
  4723. name the vector struct. 2) Made the API take a pointer to the
  4724. vector struct instead of the struct itself. 3) Added an element
  4725. cleanup macro/function parameter when removing an element from
  4726. the vector for ast_vector_remove_cmp_unordered() and
  4727. ast_vector_remove_elem_unordered(). 4) Added
  4728. ast_vector_get_addr() in case the vector element is not a simple
  4729. pointer. * Converted an inline vector usage in
  4730. stasis_message_router to use the vector API. It needed the API
  4731. improvements so it could be converted. * Fixed topic reference
  4732. leak in router_dtor() when the stasis_message_router is
  4733. destroyed. * Fixed deadlock potential in stasis_forward_all() and
  4734. stasis_forward_cancel(). Locking two topics at the same time
  4735. requires deadlock avoidance. * Made internal_stasis_subscribe()
  4736. tolerant of a NULL topic. * Made stasis_message_router_add(),
  4737. stasis_message_router_add_cache_update(),
  4738. stasis_message_router_remove(), and
  4739. stasis_message_router_remove_cache_update() tolerant of a NULL
  4740. message_type. * Promoted a LOG_DEBUG message to LOG_ERROR as
  4741. intended in dispatch_message(). Review:
  4742. https://reviewboard.asterisk.org/r/2903/
  4743. * apps/confbridge/conf_state_single.c,
  4744. apps/confbridge/conf_state_inactive.c,
  4745. apps/confbridge/conf_state_single_marked.c, /,
  4746. apps/confbridge/include/confbridge.h,
  4747. apps/confbridge/conf_state_multi.c, apps/app_confbridge.c,
  4748. apps/confbridge/conf_state_multi_marked.c,
  4749. apps/confbridge/conf_state.c: confbridge: Separate user muting
  4750. from system muting overrides. The system overrides the user
  4751. muting requests when MOH is playing or a waitmarked user is
  4752. waiting for a marked user to join. System muting overrides
  4753. interfere with what the user may wish the muting to be when the
  4754. system override ends. * User muting requests are now independent
  4755. of the system muting overrides. The effective muting is now the
  4756. logical or of the user request and system override. * Added a
  4757. Muted flag to the CLI "confbridge list <conference>" command. *
  4758. Added a Muted header to the AMI ConfbridgeList action
  4759. ConfbridgeList event. (closes issue AST-1102) Reported by: John
  4760. Bigelow Review: https://reviewboard.asterisk.org/r/2960/ ........
  4761. Merged revisions 402425 from
  4762. http://svn.asterisk.org/svn/asterisk/branches/11
  4763. * /, main/config.c, apps/confbridge/conf_config_parser.c,
  4764. configs/confbridge.conf.sample: config: Allow ConfBridge DTMF
  4765. menus to have '#' as the first digit. ConfBridge allows custom
  4766. DTMF menus to be created in the confbridge.conf file by assigning
  4767. a DTMF key sequence to a sequence of actions as follows:
  4768. DTMF-sequence = action,action... Unfortunately, the normal config
  4769. file processing code interprets an initial '#' character as
  4770. starting a directive such as #include. * Add the ability to
  4771. escape the first non-blank character in a config line so the '#'
  4772. character can be used without triggering the directive processing
  4773. code. (closes issue AFS-2) (closes issue ASTERISK-22478) Reported
  4774. by: Nicolas Tanski Patches: jira_asterisk_22478_v11.patch
  4775. (license #5621) patch uploaded by rmudgett (modified) Review:
  4776. https://reviewboard.asterisk.org/r/2969/ ........ Merged
  4777. revisions 402407 from
  4778. http://svn.asterisk.org/svn/asterisk/branches/11
  4779. * main/app.c, include/asterisk/app.h: voicemail: Simplify callback
  4780. pointer declarations and add doxygen. * Typedefed and added
  4781. doxegen for the voicemail callback functions. * Simplified the
  4782. prototypes for ast_install_vm_functions() and
  4783. ast_install_vm_test_functions() to use the new function typedefs.
  4784. * Simplified the voicemail callback function pointer variable
  4785. declarations to use the new function typedefs.
  4786. 2013-11-01 21:49 +0000 [r402387] Scott Griepentrog <sgriepentrog@digium.com>
  4787. * main/bridge.c, include/asterisk/bridge.h, main/manager_bridges.c:
  4788. Manager: Add equivalent AMI actions for the bridge CLI commands.
  4789. Adds the following AMI events, closely following their CLI
  4790. counterparts: BridgeDestroy BridgeKick BridgeTechnologyList
  4791. BridgeTechnologySuspend BridgeTechnologyUnsuspend BridgeDestroy
  4792. kicks an entire bridge, where BridgeKick kicks just one channel
  4793. off the bridge. When kicking a channel, specifying the bridge
  4794. also (optional) insures it is not removed from the wrong bridge.
  4795. The BridgeTechnology events allow viewing and changing suspension
  4796. status, which affects only subsequent not active bridging.
  4797. (closes ASTERISK-22356) Reported by: Richard Mudgett Review:
  4798. https://reviewboard.asterisk.org/r/2973/
  4799. 2013-11-01 16:31 +0000 [r402367] David M. Lee <dlee@digium.com>
  4800. * rest-api-templates/api.wiki.mustache: ari wiki docs: add notes
  4801. about allowMultiple parameters. This patch adds a note to any
  4802. parameter that has 'allowMultiple' set in the Swagger
  4803. documentation. (closes issue ASTERISK-22704)
  4804. 2013-11-01 14:37 +0000 [r402358] Joshua Colp <jcolp@digium.com>
  4805. * include/asterisk/stasis_app.h, rest-api/api-docs/channels.json,
  4806. res/ari/resource_channels.c, res/res_ari_channels.c,
  4807. res/ari/resource_channels.h, res/res_stasis_playback.c,
  4808. res/stasis/control.c: res_ari_channels: Add ring operation, dtmf
  4809. operation, hangup reasons, and tweak early media. The ring
  4810. operation sends ringing to the specified channel it is invoked
  4811. on. The dtmf operation can be used to send DTMF digits to the
  4812. specified channel of a specific length with a wait time in
  4813. between. Finally hangup reasons allow you to specify why a
  4814. channel is being hung up (busy, congestion). Early media behavior
  4815. has also been tweaked slightly. When playing media to a channel
  4816. it will no longer automatically answer. If it has not been
  4817. answered a progress indication is sent instead. (closes issue
  4818. ASTERISK-22701) Reported by: Matt Jordan Review:
  4819. https://reviewboard.asterisk.org/r/2916/
  4820. 2013-11-01 12:38 +0000 [r402348] Kinsey Moore <kmoore@digium.com>
  4821. * include/asterisk/rtp_engine.h, res/res_rtp_asterisk.c, /,
  4822. channels/chan_sip.c: chan_sip: Fix RTCP port for SRFLX ICE
  4823. candidates This corrects one-way audio between Asterisk and
  4824. Chrome/jssip as a result of Asterisk inserting the incorrect RTCP
  4825. port into RTCP SRFLX ICE candidates. This also exposes an ICE
  4826. component enumeration to extract further details from candidates.
  4827. (closes issue ASTERISK-21383) Reported by: Shaun Clark Review:
  4828. https://reviewboard.asterisk.org/r/2967/ ........ Merged
  4829. revisions 402345 from
  4830. http://svn.asterisk.org/svn/asterisk/branches/11
  4831. 2013-11-01 12:31 +0000 [r402336-402346] Joshua Colp <jcolp@digium.com>
  4832. * include/asterisk/stasis_app.h, res/ari/resource_channels.c:
  4833. res_ari_channels: Fix a deadlock when originating multiple
  4834. channels close to eachother. If a Stasis application is specified
  4835. an implicit subscription is done on the originated channel. This
  4836. was previously done with the channel lock held which is dangerous
  4837. as the underlying code locks the container and iterates items.
  4838. This change releases the lock on the originated channel before
  4839. subscribing occurs. (closes issue ASTERISK-22768) Reported by:
  4840. Matt Jordan Review: https://reviewboard.asterisk.org/r/2979/
  4841. * res/stasis/control.c: res_stasis: Ensure the channel is always
  4842. departed from the bridge when it leaves. This change adds a
  4843. command to the command queue to explicitly depart the channel
  4844. from the bridge when it is told it has left. If the channel has
  4845. already been departed or has entered a different bridge this
  4846. command will become a no-op. (closes issue ASTERISK-22703)
  4847. Reported by: John Bigelow (closes issue ASTERISK-22634) Reported
  4848. by: Kevin Harwell Review:
  4849. https://reviewboard.asterisk.org/r/2965/
  4850. 2013-10-31 22:08 +0000 [r402327] Mark Michelson <mmichelson@digium.com>
  4851. * contrib/scripts/sip_to_res_sip (removed),
  4852. contrib/scripts/sip_to_pjsip (added),
  4853. contrib/scripts/sip_to_pjsip/astconfigparser.py,
  4854. contrib/scripts/sip_to_pjsip/astdicts.py,
  4855. contrib/scripts/sip_to_pjsip/sip_to_pjsip.py: Update the
  4856. conversion script from sip.conf to pjsip.conf (closes issue
  4857. ASTERISK-22374) Reported by Matt Jordan Review:
  4858. https://reviewboard.asterisk.org/r/2846
  4859. 2013-10-31 16:04 +0000 [r402285-402289] Matthew Jordan <mjordan@digium.com>
  4860. * main/loader.c, /: core/loader: Don't call dlclose in a while loop
  4861. For awhile now, we've noticed continuous integration builds
  4862. hanging on CentOS 6 64-bit build agents. After resolving a number
  4863. of problems with symbols, strange locks, and other shenanigans,
  4864. the problem has persisted. In all cases, gdb shows the Asterisk
  4865. process stuck in loader.c on one of the infinite while loops that
  4866. calls dlclose repeatedly until success. The documentation of
  4867. dlclose states that it returns 0 on success; any other value on
  4868. error. It does not state that repeatedly calling it will
  4869. eventually clear those errors. Most likely, the repeated calls to
  4870. dlclose was to force a close by exhausting the references on the
  4871. library; however, that will never succeed if: (a) There is some
  4872. fundamental error at work in the loaded library that precludes
  4873. unloading it (b) Some other loaded module is referencing a symbol
  4874. in the currently loaded module This results in Asterisk sitting
  4875. forever. Since we have matching pairs of dlopen/dlclose, this
  4876. patch opts to only call dlclose once, and log out as an ERROR if
  4877. dlclose fails to return success. If nothing else, this might help
  4878. to determine why on the CentOS 6 64-bit build agent things are
  4879. not closing successfully. Review:
  4880. https://reviewboard.asterisk.org/r/2970 ........ Merged revisions
  4881. 402287 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  4882. ........ Merged revisions 402288 from
  4883. http://svn.asterisk.org/svn/asterisk/branches/11
  4884. * main/media_index.c: medix_index: Display errors when library
  4885. calls fail Based on feedback from ipengineer in #asterisk, when
  4886. the media indexer cannot access a sound file on the system (or
  4887. otherwise fails) Asterisk displays a "Cannot frob file" error but
  4888. fails to tell you why. This is especially problematic as the
  4889. media_indexer failing will rpevent Asterisk from starting, as it
  4890. is in the core. We now display the errno error messages so folks
  4891. can figure out what they've done wrong.
  4892. 2013-10-31 14:43 +0000 [r402276] David M. Lee <dlee@digium.com>
  4893. * res/stasis/app.c: stasis: add functions embarrassingly missing
  4894. from r400522 I neglected to implement two of the endpoint
  4895. subscription functions when I did the work. Normally, you'll only
  4896. hit that when you unsubscribe from a specific endpoint.
  4897. 2013-10-30 17:52 +0000 [r402265] Kevin Harwell <kharwell@digium.com>
  4898. * res/res_pjsip_messaging.c, channels/chan_pjsip.c:
  4899. pjsip_messaging: Added debug for in dialog messaging (issue
  4900. ASTERISK-22777) Reported by: Matt Jordan
  4901. 2013-10-29 23:43 +0000 [r402226] Rusty Newton <rnewton@digium.com>
  4902. * sounds/Makefile, /: Updates for 1.4.25 core sounds and 1.4.14
  4903. extra sounds, plus new en_GB language set The new sound packages
  4904. relate to issues: ASTERISK-22544, ASTERISK-22411, ASTERISK-21413,
  4905. ASTERISK-20782 Modified sounds/Makefile for the new sound
  4906. versions and to account for the new en_GB language set. (issue
  4907. ASTERISK-22659) (closes issue ASTERISK-22659) (closes issue
  4908. ASTERISK-22411) (closes issue ASTERISK-22544) ........ Merged
  4909. revisions 402224 from
  4910. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4911. revisions 402225 from
  4912. http://svn.asterisk.org/svn/asterisk/branches/11
  4913. 2013-10-29 12:53 +0000 [r402154] Matthew Jordan <mjordan@digium.com>
  4914. * /, main/translate.c, main/xmldoc.c, main/channel.c, main/pbx.c:
  4915. Remove some spammy debug messages; improve clarity of others
  4916. Debug messages aren't free. Even when the debug level is
  4917. sufficiently low such that the messages are never evaluated,
  4918. there is a cost to having to parse Asterisk logs that contain
  4919. debug messages that (a) fail to convey sufficient information or
  4920. (b) occur so frequently as to be next to meaningless. Based on
  4921. having to stare at lots of DEBUG messages, this patch makes the
  4922. following changes: * channel.c: When copying variables from a
  4923. parent channel to a child channel, specify the channels involved.
  4924. Do not log anything for a variable that is not inherited; the
  4925. fact that it doesn't have an _ or __ already signifies that it
  4926. won't be inherited. * pbx.c: Specify what function evaluation has
  4927. occurred that created the result. * translate.c: Bump up the
  4928. translator path messages to 10. I've never once had to use these
  4929. debug messages, and for each format that is registered (on
  4930. startup) and unregistered (on shutdown) the entire f^2 matrix is
  4931. logged out. For short tests in the Asterisk Test Suite, this
  4932. should make finding the actual test much easier. * xmldoc.c: The
  4933. debug message that 'blah' is not found in the tree is expected.
  4934. Often, description elements - which are not required - are not
  4935. provided. This debug message adds no additional value, as it is
  4936. not indicative of an error or helpful in debugging which element
  4937. did not contain a 'blah' element as a child. If an element is
  4938. supposed to contain a child element, then that XML tree should
  4939. have failed validation in the first place. Review:
  4940. https://reviewboard.asterisk.org/r/2966/ ........ Merged
  4941. revisions 402150 from
  4942. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4943. revisions 402151 from
  4944. http://svn.asterisk.org/svn/asterisk/branches/11
  4945. 2013-10-29 12:51 +0000 [r402148-402152] Kinsey Moore <kmoore@digium.com>
  4946. * res/ari/resource_channels.h, rest-api/api-docs/channels.json,
  4947. res/ari/resource_channels.c, res/res_ari_channels.c: ARI: Remove
  4948. channels/{channelId}/dial This removes the
  4949. /ari/channels/{channelId}/dial URI since it is redundant, overly
  4950. complex, is likely to become more externally complex over time,
  4951. and is too high-level compared with other ARI operations. See the
  4952. following for further information:
  4953. http://lists.digium.com/pipermail/asterisk-app-dev/2013-October/000002.html
  4954. (closes issue ASTERISK-22784) Reported by: Matt Jordan Review:
  4955. https://reviewboard.asterisk.org/r/2968/
  4956. * bridges/bridge_native_rtp.c: bridge_native_rtp: Ensure bridge is
  4957. torn down When a bridge transitions away from one tech to
  4958. another, the tech going away is provided a dummy bridge with no
  4959. channels in it to tear down. Currently this means that the
  4960. teardown code exits prematurely and does not tear anything down.
  4961. This change tears down RTP bridging for the channel provided in
  4962. the leave bridge tech callback. This also reverts the majority of
  4963. r400403 since it is now redundant. (closes issue ASTERISK-22628)
  4964. (closes issue ASTERISK-22676) Reported by: John Bigelow Reported
  4965. by: Kevin Harwell Tested by: John Bigelow Review:
  4966. https://reviewboard.asterisk.org/r/2905/ Patches:
  4967. native_rtp_fix.diff uploaded by Kinsey Moore (License 6273)
  4968. 2013-10-29 11:15 +0000 [r402139] Joshua Colp <jcolp@digium.com>
  4969. * res/res_ari_playback.c, rest-api/api-docs/playback.json:
  4970. res_ari_playback: Add missing 404 error response for GET and
  4971. DELETE. (closes issue ASTERISK-22722) Reported by: Richard
  4972. Mudgett
  4973. 2013-10-28 21:30 +0000 [r402127] David M. Lee <dlee@digium.com>
  4974. * doc: Ignore full docs
  4975. 2013-10-28 15:05 +0000 [r402112-402115] Michael L. Young <elgueromexicano@gmail.com>
  4976. * UPGRADE-11.txt, UPGRADE.txt: Fix UPGRADE.txt Due To Merging From
  4977. Branch 11 When merging in the patch for ASTERISK-22728, the
  4978. UPGRADE.txt file was changed incorrectly. That change should have
  4979. gone into ASTERISK-11.txt. This commit is to fix that. Also,
  4980. another comment in the UPGRADE-11.txt was missing and this commit
  4981. adds that as well.
  4982. * UPGRADE.txt, /, channels/chan_sip.c: chan_sip: Clarify
  4983. 'Forcerport' Setting Displayed When Running "sip show peers"
  4984. While looking at ASTERISK-22236, Walter Doekes pointed out that
  4985. when running "sip show peers", the setting being displayed can be
  4986. confusing. The display of "N" used to mean NAT (i.e. yes). The
  4987. NAT setting has gone through many different changes resulting in
  4988. the display of different characters to try and convey what the
  4989. current setting is for 'Forcerport' (A for Auto and Forcerport is
  4990. currently on, a for Auto but Forcerport is off, Y for yes, and N
  4991. for no). During the initial code review to try and clarify these
  4992. settings (especially since "N" no longer meant what it used to
  4993. mean in prior versions of Asterisk), Mark Michelson suggested
  4994. using the full space available to display the settings which
  4995. helped to make the settings very clear. That was a great
  4996. suggestion. Therefore, this patch does the following: * The
  4997. column for 'Forcerport' now will show: Auto (Yes), Auto (No),
  4998. Yes, or No. * A column for the 'Comedia' setting has been added.
  4999. It too will display the setting in a non-cryptic way: Auto (Yes),
  5000. Auto (No), Yes, or No. * UPGRADE.txt has been updated to document
  5001. this change. (closes issue ASTERISK-22728) Reported by: Walter
  5002. Doekes Tested by: Michael L. Young Patches:
  5003. asterisk-forcerport-display-clarification_v3.diff uploaded by
  5004. Michael L. Young (license 5026) Review:
  5005. https://reviewboard.asterisk.org/r/2941 ........ Merged revisions
  5006. 402111 from http://svn.asterisk.org/svn/asterisk/branches/11
  5007. 2013-10-27 23:22 +0000 [r402081-402090] Matthew Jordan <mjordan@digium.com>
  5008. * main/cdr.c: Filter out internal channels from dial message
  5009. handling Surrogate channels would pop up from time to time in
  5010. dial message handling. This would cause a WARNING message to
  5011. appear, indicating that the Surrogate channel had no CDR. This
  5012. patch filters out those channels that have the internal
  5013. implementation flag set, such that the WARNING message isn't
  5014. displayed.
  5015. * main/cdr.c, cdr/cdr_sqlite3_custom.c, cdr/cdr_syslog.c,
  5016. cdr/cdr_sqlite.c, UPGRADE.txt, cdr/cdr_adaptive_odbc.c,
  5017. addons/cdr_mysql.c, include/asterisk/cdr.h, cdr/cdr_pgsql.c,
  5018. cdr/cdr_odbc.c, cdr/cdr_radius.c, cdr/cdr_custom.c,
  5019. cdr/cdr_manager.c, cdr/cdr_tds.c, cdr/cdr_csv.c: Prevent CDR
  5020. backends from unregistering while billing data is in flight This
  5021. patch makes it so that CDR backends cannot be unregistered while
  5022. active CDR records exist. This helps to prevent billing data from
  5023. being lost during restarts and shutdowns. Review:
  5024. https://reviewboard.asterisk.org/r/2880/
  5025. 2013-10-26 12:55 +0000 [r402064] Joshua Colp <jcolp@digium.com>
  5026. * include/asterisk/res_pjsip_session.h, channels/chan_pjsip.c:
  5027. chan_pjsip: Fix a crash when direct media is enabled and an ACK
  5028. is received after the channel is hung up. (closes issue
  5029. ASTERISK-22731) Reported by: Kinsey Moore
  5030. 2013-10-26 00:34 +0000 [r402044-402055] Richard Mudgett <rmudgett@digium.com>
  5031. * res/res_stasis.c: res_stasis.c: Made use the ao2_container
  5032. callback templates. * Made res_stasis.c use the OBJ_SEARCH_XXX
  5033. defines.
  5034. * main/taskprocessor.c: taskprocessor: Made use pthread_equal() to
  5035. compare thread ids. * Removed another silly use of RAII_VAR().
  5036. RAII_VAR() and SCOPED_LOCK() are not silver bullets that allow
  5037. you to turn off your brain.
  5038. 2013-10-25 23:48 +0000 [r402043] Scott Griepentrog <sgriepentrog@digium.com>
  5039. * include/asterisk/rtp_engine.h, main/rtp_engine.c, /: rtp_engine:
  5040. fix rtp payloads copy and improve argument names In function
  5041. ast_rtp_instance_early _bridge_make_compatible the use of
  5042. instance 0/1 as arguments doesn't clearly communicate a direction
  5043. that the copying of payloads from the source channel to the
  5044. destination channel will occur, making it more probable to have
  5045. the arguments to ast_rtp_codecs_payloads_copy() put in the
  5046. reverse order. This patch renames the arguments with _dst and
  5047. _src suffixes and corrects the copy direction. (closes issue
  5048. ASTERISK-21464) Reported by: Kevin Stewart Review:
  5049. https://reviewboard.asterisk.org/r/2894/ ........ Merged
  5050. revisions 402000 from
  5051. http://svn.asterisk.org/svn/asterisk/branches/1.8 Test shows
  5052. rtpmap:119 being copied per this change, but is not in sip invite
  5053. ........ Merged revisions 402042 from
  5054. http://svn.asterisk.org/svn/asterisk/branches/11
  5055. 2013-10-25 22:02 +0000 [r402003] Richard Mudgett <rmudgett@digium.com>
  5056. * res/stasis/app.c: You'd think that new files would be free of
  5057. whitespace issues. But you would be wrong.
  5058. 2013-10-25 21:53 +0000 [r401973-402001] Jonathan Rose <jrose@digium.com>
  5059. * rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  5060. res/res_ari_channels.c, rest-api/api-docs/bridges.json,
  5061. res/ari/resource_bridges.c, res/res_ari_bridges.c: ARI:
  5062. channel/bridge recording errors when invalid format specified
  5063. Asterisk will now issue 422 if recording is requested against
  5064. channels or bridges with an unknown format (closes issue
  5065. ASTERISK-22626) Reported by: Joshua Colp Review:
  5066. https://reviewboard.asterisk.org/r/2939/
  5067. * res/res_ari_channels.c, rest-api/api-docs/bridges.json,
  5068. rest-api/api-docs/recordings.json, res/ari/resource_bridges.c,
  5069. res/ari/ari_model_validators.h, res/res_ari_bridges.c,
  5070. rest-api/api-docs/events.json, res/res_stasis_recording.c,
  5071. rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  5072. res/ari/ari_model_validators.c: ARI recordings: Issue HTTP
  5073. failures for recording requests with file conflicts If a file
  5074. already exists in the recordings directory with the same name as
  5075. what we would record, issue a 422 instead of relying on the
  5076. internal failure and issuing success. (closes issue
  5077. ASTERISK-22623) Reported by: Joshua Colp Review:
  5078. https://reviewboard.asterisk.org/r/2922/
  5079. 2013-10-25 20:47 +0000 [r401961] Scott Griepentrog <sgriepentrog@digium.com>
  5080. * include/asterisk/pbx.h, main/pbx.c, /: pbx.c: fix confused match
  5081. caller id that deleted exten still in hash This fixes a bug where
  5082. a zero length callerid match adjacent to a no match callerid
  5083. extension entry would be deleted together, which then resulted in
  5084. hashtable references to free'd memory. A third state of the
  5085. matchcid value has been added to indicate match to any extension
  5086. which allows enforcing comparison of matchcid on/off without
  5087. errors. (closes issue AST-1235) Reported by: Guenther Kelleter
  5088. Review: https://reviewboard.asterisk.org/r/2930/ ........ Merged
  5089. revisions 401959 from
  5090. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5091. revisions 401960 from
  5092. http://svn.asterisk.org/svn/asterisk/branches/11
  5093. 2013-10-25 17:34 +0000 [r401897-401938] Jonathan Rose <jrose@digium.com>
  5094. * res/res_pjsip/pjsip_distributor.c,
  5095. res/res_pjsip_endpoint_identifier_user.c: PJSIP: Add log messages
  5096. when requests are received for non-existent endpoints (closes
  5097. issue ASTERISK-22552) Reported by: Rusty Newton Review:
  5098. https://reviewboard.asterisk.org/r/2934/
  5099. * utils/clicompat.c, utils/refcounter.c, /: Put clicompat-r2.patch
  5100. back in We've figured out how to resolve the problems this was
  5101. causing in 12/trunk, so this can go back in now. (issue
  5102. ASTERISK-22467) Reported by: Corey Farrell Patches:
  5103. clicompat-r2.patch uploaded by coreyfarrell (license 5909)
  5104. ........ Merged revisions 401914 from
  5105. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5106. revisions 401935 from
  5107. http://svn.asterisk.org/svn/asterisk/branches/11
  5108. * /, utils/clicompat.c: revert clicompat-r2.patch from r401704
  5109. Patch caused the following build errors against testsuite
  5110. https://bamboo.asterisk.org/bamboo/browse/AST-ATRUNKBUILD4-244
  5111. (issue ASTERISK-22467) Reported by: Corey Farrell ........ Merged
  5112. revisions 401895 from
  5113. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5114. revisions 401896 from
  5115. http://svn.asterisk.org/svn/asterisk/branches/11
  5116. 2013-10-25 16:07 +0000 [r401885] Kevin Harwell <kharwell@digium.com>
  5117. * /, channels/chan_sip.c: chan_sip: Allow a sip peer to accept both
  5118. AVP and AVPF calls Adapts the behaviour of avpf to only impact
  5119. the format of outgoing calls. For inbound calls, both AVP and
  5120. AVPF calls will be accepted regardless of the value of avpf in
  5121. the configuration. (closes issue ASTERISK-22005) Reported by:
  5122. Torrey Searle Patches: optional_avpf_trunk.patch uploaded by
  5123. tsearle (license 5334) ........ Merged revisions 401884 from
  5124. http://svn.asterisk.org/svn/asterisk/branches/11
  5125. 2013-10-25 13:48 +0000 [r401872] David M. Lee <dlee@digium.com>
  5126. * tests/test_json.c: test_json: Fix deprecation warnings After a
  5127. series of upgrades over recent weeks, I've discovered that
  5128. test_json.c won't compile in dev mode any more for me. One of
  5129. gcc-4.8.2, OS X Mavericks or Xcode 5 has decided to deprecate
  5130. tempnam. Which, in general, is a good thing. But for test code
  5131. that just needs a temporary file, it's just annoying. This patch
  5132. replaces usage of tempname with mkstemp, avoiding the deprecation
  5133. warning. It also removes the temporary files when the test is
  5134. complete, which apparently we weren't doing before (oops).
  5135. Review: https://reviewboard.asterisk.org/r/2957/
  5136. 2013-10-24 20:56 +0000 [r401835] Kevin Harwell <kharwell@digium.com>
  5137. * /, main/logger.c: Logging: Logging types ignored after specifying
  5138. a verbose level If one specified a verbose level within a logging
  5139. facility in logger.conf then any component after it was ignored.
  5140. Fixed so all values are correctly read. (closes issue
  5141. ASTERISK-22456) Reported by: Kevin Harwell ........ Merged
  5142. revisions 401833 from
  5143. http://svn.asterisk.org/svn/asterisk/branches/11
  5144. 2013-10-24 20:34 +0000 [r401706-401831] Jonathan Rose <jrose@digium.com>
  5145. * main/utils.c, /: utils: Fix memory leaks and missed
  5146. unregistration of CLI commands on shutdown Final set of patches
  5147. in a series of memory leak/cleanup patches by Corey Farrell
  5148. (closes issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  5149. main-utils-1.8.patch uploaded by coreyfarrell (license 5909)
  5150. main-utils-11.patch uploaded by coreyfarrell (license 5909)
  5151. main-utils-12up.patch uploaded by coreyfarrell (license 5909)
  5152. ........ Merged revisions 401829 from
  5153. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5154. revisions 401830 from
  5155. http://svn.asterisk.org/svn/asterisk/branches/11
  5156. * tests/test_linkedlists.c, /: test_linkedlists: Fix memory leak
  5157. (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  5158. test_linkedlists-1.8.patch uploaded by coreyfarrell (license
  5159. 5909) test_linkedlists-11up.patch uploaded by coreyfarrell
  5160. (license 5909) ........ Merged revisions 401790 from
  5161. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5162. revisions 401791 from
  5163. http://svn.asterisk.org/svn/asterisk/branches/11
  5164. * /, main/jitterbuf.c: jitterbuf: Fix memory leak on jitter buffer
  5165. reset (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  5166. jitterbuf-jb_reset-leak-1.8.patch
  5167. jitterbuf-jb_reset-leak-11up.patch ........ Merged revisions
  5168. 401786 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  5169. ........ Merged revisions 401787 from
  5170. http://svn.asterisk.org/svn/asterisk/branches/11
  5171. * /, main/astobj2.c: astobj2: Unregister debug CLI commands at exit
  5172. (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  5173. astobj2-clean-debug-cli-1.8-11.patch uploaded by coreyfarrell
  5174. (license 5909) astobj2-clean-debug-cli-12up.patch uploaded by
  5175. coreyfarrell (license 5909) ........ Merged revisions 401781 from
  5176. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5177. revisions 401783 from
  5178. http://svn.asterisk.org/svn/asterisk/branches/11
  5179. * apps/app_voicemail.c, /: app_voicemail: Memory Leaks against
  5180. tests (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  5181. app_voicemail-1.8.patch uploaded by coreyfarrell (license 5909)
  5182. app_voicemail-11up.patch uploaded by coreyfarrell (license 5909)
  5183. ........ Merged revisions 401743 from
  5184. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5185. revisions 401744 from
  5186. http://svn.asterisk.org/svn/asterisk/branches/11
  5187. * main/app.c, main/asterisk.c, utils/clicompat.c,
  5188. channels/chan_dahdi.c, codecs/ilbc/doCPLC.c, main/data.c, /:
  5189. memory leaks: Memory leak cleanup patch by Corey Farrell (second
  5190. set) Also covers ast_app_parse_timelen-fail-zero-length.patch,
  5191. but the patch was replaced with one of my own. (issue
  5192. ASTERISK-22467) Reported by: Corey Farrell Patches:
  5193. chan_dahdi-cleanup_push.patch uploaded by coreyfarrell (license
  5194. 5909) clicompat-r2.patch uploaded by coreyfarrell (license 5909)
  5195. codecs-ilbc-doCPLC.patch uploaded by coreyfarrell (license 5909)
  5196. data-cleanup-test-registration.patch uploaded by coreyfarrell
  5197. (license 5909) main-asterisk-kill-listener.patch uploaded by
  5198. coreyfarrell (license 5909) ........ Merged revisions 401704 from
  5199. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5200. revisions 401705 from
  5201. http://svn.asterisk.org/svn/asterisk/branches/11
  5202. 2013-10-24 03:12 +0000 [r401701] David M. Lee <dlee@digium.com>
  5203. * rest-api-templates/ari_model_validators.c.mustache,
  5204. rest-api-templates/models.wiki.mustache,
  5205. rest-api/api-docs/events.json,
  5206. rest-api-templates/swagger_model.py: The Swagger 1.2
  5207. specification for type extension ended up being slightly
  5208. different than my proposal. Instead of putting an 'extends' field
  5209. on the subtype, the base type has a 'subTypes' field, which is a
  5210. list of the subTypes. Given that its a messaging model and not an
  5211. object model, kinda makes sense. This patch changes the
  5212. events.json api-doc, and the python translators to take the new
  5213. format into account. Other changes that are in Swagger 1.2 were
  5214. not adopted, since the spec is still in flux, and could change
  5215. before it's finalized. A summary of changes to the Swagger-1.2
  5216. spec can be found at
  5217. https://github.com/wordnik/swagger-core/wiki/1.2-transition.
  5218. (closes issue ASTERISK-22440) Review:
  5219. https://reviewboard.asterisk.org/r/2909/
  5220. 2013-10-23 20:02 +0000 [r401621-401662] Jonathan Rose <jrose@digium.com>
  5221. * /, tests/test_dlinklists.c, funcs/func_math.c,
  5222. channels/sip/reqresp_parser.c, main/test.c,
  5223. main/editline/readline.c: memory leaks: Memory leak cleanup patch
  5224. by Corey Farrell (first set) (issue ASTERSIK-22467) Reported by:
  5225. Corey Farrell Patches:
  5226. chan_sip-parse_contact_header_test-free-contacts.patch uploaded
  5227. by coreyfarrell (license 5909) cli-filename-completion-leak.patch
  5228. uploaded by coreyfarrell (license 5909) func_math.patch uploaded
  5229. by corefarrell (license 5909) main-test-cleanup.patch uploaded by
  5230. coreyfarrell (license 5909) test_dlinklists.patch uploaded by
  5231. coreyfarrell (license 5909) ........ Merged revisions 401660 from
  5232. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5233. revisions 401661 from
  5234. http://svn.asterisk.org/svn/asterisk/branches/11
  5235. * res/res_rtp_asterisk.c, /, main/translate.c: res_rtp_asterisk:
  5236. Address jittery DTMF events in RTP streams (closes issue
  5237. ASTERISK-21170) Reported by: NITESH BANSAL Patches:
  5238. dtmf-timestamp.patch uploaded by NITESH BANSAL (license 6418)
  5239. Review: https://reviewboard.asterisk.org/r/2938/ ........ Merged
  5240. revisions 401619 from
  5241. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5242. revisions 401620 from
  5243. http://svn.asterisk.org/svn/asterisk/branches/11
  5244. 2013-10-23 16:49 +0000 [r401581] Richard Mudgett <rmudgett@digium.com>
  5245. * cdr/cdr_adaptive_odbc.c, /: cdr_adaptive_odbc: Also apply a
  5246. filter when the CDR value is empty. Extra CDR records are written
  5247. if a filtered CDR value is empty because the filter is not
  5248. checked. (closes issue ASTERISK-22272) Reported by: Jordi Llull
  5249. Chavarria ........ Merged revisions 401577 from
  5250. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5251. revisions 401579 from
  5252. http://svn.asterisk.org/svn/asterisk/branches/11
  5253. 2013-10-23 16:37 +0000 [r401578] John Bigelow <jbigelow@digium.com>
  5254. * main/bridge_channel.c: Add a test suite event to indicate when
  5255. the atxfer 3-way feature is detected This adds a test suite event
  5256. that indicates to tests when the attended transfer three-way call
  5257. feature is detected. Review:
  5258. https://reviewboard.asterisk.org/r/2912/
  5259. 2013-10-23 15:23 +0000 [r401539] Kinsey Moore <kmoore@digium.com>
  5260. * channels/chan_mgcp.c, /: chan_mgcp: Properly handle malformed
  5261. media lines This corrects a situation in which a media line was
  5262. not parsed properly and resulted in a crash. (closes issue
  5263. ASTERISK-21190) Reported by: adomjan Patches:
  5264. chan_mgcp.c-sscnaf_fix uploaded by adomjan (License 5448)
  5265. ........ Merged revisions 401537 from
  5266. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5267. revisions 401538 from
  5268. http://svn.asterisk.org/svn/asterisk/branches/11
  5269. 2013-10-23 11:14 +0000 [r401499] Joshua Colp <jcolp@digium.com>
  5270. * /, channels/chan_sip.c: chan_sip: Fix an issue where an
  5271. incompatible audio format may be added to SDP. If preferred
  5272. codecs included any non-audio format the code would mistakenly
  5273. add the audio format, even if it was not a joint capability with
  5274. the remote side. (closes issue ASTERISK-21131) Reported by:
  5275. nbougues Patches: patch_unsupported_codec_1.8.patch uploaded by
  5276. nbougues (license 6470) ........ Merged revisions 401497 from
  5277. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5278. revisions 401498 from
  5279. http://svn.asterisk.org/svn/asterisk/branches/11
  5280. 2013-10-23 02:31 +0000 [r401488] Michael L. Young <elgueromexicano@gmail.com>
  5281. * channels/chan_iax2.c, configs/iax.conf.sample: chan_iax2: Fix
  5282. Binding To Multiple Addresses Again When reworking chan_iax2 for
  5283. IPv6, the ability to bind to multiple addresses was removed by
  5284. mistake. This patch restores this functionality and adds notes
  5285. about IPv6 addresses in the sample config. (closes issue
  5286. ASTERISK-22741) Reported by: Joshua Colp Tested by: Michael L.
  5287. Young Patches: asterisk-22741-fix-binding-multiple-addr.diff
  5288. uploaded by Michael L. Young (license 5026) Review:
  5289. https://reviewboard.asterisk.org/r/2945/
  5290. 2013-10-22 22:50 +0000 [r401447] Matthew Jordan <mjordan@digium.com>
  5291. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fix crash when RTCP
  5292. is not available during SSRC change In r400089, a patch was put
  5293. in to correct erroneous RTCP statistic resets. Unfortunately,
  5294. ast_rtp_read can be called on an RTP instance that does not have
  5295. RTCP information. This patch prevents that crash by only
  5296. resetting the statistics if we do actually have an RTCP instance.
  5297. (issue AST-1174) (closes issue ASTERISK-22667) Reported by: John
  5298. Bigelow ........ Merged revisions 401445 from
  5299. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5300. revisions 401446 from
  5301. http://svn.asterisk.org/svn/asterisk/branches/11
  5302. 2013-10-22 19:03 +0000 [r401420-401434] Richard Mudgett <rmudgett@digium.com>
  5303. * apps/app_queue.c, /: app_queue: Fix CLI "queue remove member"
  5304. queue_log entry. The queue_log entry resulting from CLI "queue
  5305. remove member" when log_membername_as_agent is enabled is wrong.
  5306. It always uses the interface name instead of the member name in
  5307. the queue_log entry. * Get the queue member before removing it
  5308. from the queue so the member name is available for the queue_log
  5309. entry. (closes issue ASTERISK-21826) Reported by: Oscar Esteve
  5310. Patches: fix_membername.diff (license #6505) patch uploaded by
  5311. Oscar Esteve (modified to fix potential ref leak) ........ Merged
  5312. revisions 401433 from
  5313. http://svn.asterisk.org/svn/asterisk/branches/11
  5314. * main/bridge_channel.c,
  5315. include/asterisk/bridge_channel_internal.h, main/bridge.c:
  5316. Bridging: Fix orphaned bridge if neither of the joining channels
  5317. can join. The original issue noted that the bridge is orphaned
  5318. when res_parking.so is not loaded and a call uses the dial kK
  5319. flags. A similar issue happens when only one of the park flags is
  5320. used. In this case you have the bridge with one or the other
  5321. channel left in it. The channel and bridge will stay around until
  5322. the channel hangs up. * Fixed the initial bridge channel push
  5323. failure to act as if the channel were kicked out of the bridge.
  5324. The bridge then decides if it needs to be dissolved. (closes
  5325. issue ASTERISK-22629) Reported by: Kevin Harwell Review:
  5326. https://reviewboard.asterisk.org/r/2928/
  5327. * res/parking/parking_bridge_features.c,
  5328. res/parking/parking_bridge.c: res_parking: Give parking timeout
  5329. comebacktoorigin channel DTMF features. Parking timeouts did not
  5330. set any DTMF features for the channel calling the parker back. *
  5331. Added code to set the parkedcalltransfers, parkedcallreparking,
  5332. parkedcallhangup, and parkedcallrecording options appropriately
  5333. for the channels when a parking timeout occurs. The recall
  5334. channel DTMF options are set using the BRIDGE_FEATURES channel
  5335. variable to allow the other timeout options to have the DTMF
  5336. features available. (closes issue ASTERISK-22630) Reported by:
  5337. Kevin Harwell Review: https://reviewboard.asterisk.org/r/2942/
  5338. * res/res_parking.c: res_parking: Update XML documention for DTMF
  5339. features after parking timeout. * Updated the XML documentation
  5340. to indicate that the parkedcalltransfers, parkedcallreparking,
  5341. parkedcallhangup, and parkedcallrecording configuration options
  5342. also apply to parking timeouts. (issue ASTERISK-22630) Reported
  5343. by: Kevin Harwell Review:
  5344. https://reviewboard.asterisk.org/r/2942/
  5345. 2013-10-21 21:05 +0000 [r401364] Mark Michelson <mmichelson@digium.com>
  5346. * main/bridge_channel.c: Remove a noisy debug message from bridging
  5347. code. This particular debug message, during a stress test, was
  5348. logged so often that it appeared that there may be a memory leak
  5349. in the logger code. In actuality, there was no memory leak, but
  5350. the logger thread was having a hard time keeping up with the
  5351. demands of the rest of the system. Since this debug message has
  5352. no value at all, the best way to fix the problem was to just
  5353. remove the message. (closes issue AST-1225) reported by John
  5354. Bigelow Patches: spammy_log.diff uploaded by Mark Michelson
  5355. (License #5049)
  5356. 2013-10-21 19:48 +0000 [r401327] Kevin Harwell <kharwell@digium.com>
  5357. * main/editline/term.c, /: Segfault in LIBEDIT_INTERNAL after
  5358. tgetstr(), when libncurses5-dev isn't installed Include the
  5359. appropriate declarations when not using termcap, but term+curses
  5360. and [n]curses do not exist. (closes issue ASTERISK-22351)
  5361. Reported by: A. Iglesias Patches:
  5362. issueA22351_libedit_internal_without_ncurses_dev.patch uploaded
  5363. by wdoekes (license 5674) ........ Merged revisions 401325 from
  5364. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5365. revisions 401326 from
  5366. http://svn.asterisk.org/svn/asterisk/branches/11
  5367. 2013-10-21 18:58 +0000 [r401315] David M. Lee <dlee@digium.com>
  5368. * rest-api/api-docs/channels.json: Fixing r401281; the model name
  5369. is Channel, with a capital C
  5370. 2013-10-19 21:53 +0000 [r401291] Kinsey Moore <kmoore@digium.com>
  5371. * channels/chan_iax2.c: Fix IAX2 incoming call address lookups This
  5372. fixes address lookup for incoming calls without a peer
  5373. definition. The address family was unset instead of being set to
  5374. AST_AF_UNSPEC which was causing lookup failures on "127.0.0.1".
  5375. This is one of the causes of the current failure of the app_page
  5376. integration test. Review:
  5377. https://reviewboard.asterisk.org/r/2933/
  5378. 2013-10-19 14:43 +0000 [r401281] Joshua Colp <jcolp@digium.com>
  5379. * res/res_ari_channels.c, res/ari/resource_channels.h, main/pbx.c,
  5380. rest-api/api-docs/channels.json, res/ari/resource_channels.c:
  5381. Return a channel snapshot when originating using ARI, and
  5382. subscribe the Stasis application to it. This change allows a user
  5383. of ARI to know what channel it has originated and also follow any
  5384. progress. If a Stasis application is provided it will be
  5385. automatically subscribed to the originated channel immediately.
  5386. (closes issue ASTERISK-22485) Reported by: David Lee Review:
  5387. https://reviewboard.asterisk.org/r/2910/
  5388. 2013-10-18 22:51 +0000 [r401271] Richard Mudgett <rmudgett@digium.com>
  5389. * res/parking/parking_controller.c: res_parking: Remove setting
  5390. useless flag.
  5391. 2013-10-18 21:49 +0000 [r401261] David M. Lee <dlee@digium.com>
  5392. * contrib/scripts/get_swagger_ui.sh (added), Makefile, static-http:
  5393. This is just a quick script for dumping swagger-ui into
  5394. static-http, so that it can be served by the Asterisk web server.
  5395. I had to change the Makefile in order to recursively install
  5396. content from the static-http directory, hence the code review
  5397. instead of just putting it in. Review:
  5398. https://reviewboard.asterisk.org/r/2924/
  5399. 2013-10-18 18:33 +0000 [r401248] Mark Michelson <mmichelson@digium.com>
  5400. * main/manager.c, main/bridge.c, main/bucket.c, main/sorcery.c,
  5401. main/cli.c: Resolve some memory leaks due to incorrect for loop /
  5402. ao2 ref usage. A common idiom in Asterisk is to due something
  5403. like: for (ao2_obj = list_beginning; ao2_obj = next_item;
  5404. ao2_ref(ao2_obj, -1)) { ...do stuff... } This is nice because it
  5405. automatically takes care of the object references for you.
  5406. However, there is a pitfall here. If a break statement is in the
  5407. for loop, then the current reference is not cleaned up. In some
  5408. cases, this is on purpose, but in others there is a leak. This
  5409. commit fixes the leak cases.
  5410. 2013-10-18 16:52 +0000 [r401232-401239] Richard Mudgett <rmudgett@digium.com>
  5411. * apps/app_dial.c, main/channel.c, res/res_fax.c,
  5412. include/asterisk/channel.h: Add channel lock protection around
  5413. translation path setup. Most callers of
  5414. ast_channel_make_compatible() happen before the channels enter a
  5415. two party bridge. With the new bridging framework, two party
  5416. bridging technologies may also call ast_channel_make_compatible()
  5417. when there is more than one thread involved with the two
  5418. channels. * Added channel lock protection in set_format() and
  5419. ast_channel_make_compatible_helper() when dealing with the
  5420. channel's native formats while setting up a translation path. *
  5421. Fixed best_src_fmt and best_dst_fmt usage consistency in
  5422. ast_channel_make_compatible_helper(). The call to
  5423. ast_translator_best_choice() got them backwards. * Updated some
  5424. callers of ast_channel_make_compatible() and the function
  5425. documentation. There is actually a difference between the two
  5426. channels passed in. * Fixed the deadlock potential in res_fax.c
  5427. dealing with ast_channel_make_compatible(). The deadlock
  5428. potential was already there anyway because res_fax called
  5429. ast_channel_make_compatible() with chan locked. (closes issue
  5430. ASTERISK-22542) Reported by: Matt Jordan Review:
  5431. https://reviewboard.asterisk.org/r/2915/
  5432. * include/asterisk/bridge.h: Tweak ast_bridge_depart() doxygen.
  5433. 2013-10-18 16:05 +0000 [r401212-401223] Mark Michelson <mmichelson@digium.com>
  5434. * include/asterisk/bridge.h: Remove the bit about requiring
  5435. ast_bridge_depart() to be called before ast_bridge_destroy().
  5436. * include/asterisk/bridge.h: Clarify in ast_bridge_destroy() about
  5437. how departable channels must be handled.
  5438. 2013-10-18 15:13 +0000 [r401183] Michael L. Young <elgueromexicano@gmail.com>
  5439. * /, channels/chan_sip.c: Remove Port Restriction When Checking For
  5440. NAT When trying to determine if a peer is behind NAT, we should
  5441. not be using the ports when comparing addresses. This patch
  5442. removes the port from being checked and just useds the addresses
  5443. now. (closes issue ASTERISK-22729) Reported by: Michael L. Young
  5444. Tested by: Michael L. Young Patches:
  5445. asterisk-remove-using-port-for-nat-check.diff uploaded by Michael
  5446. L. Young (license 5026) Review:
  5447. https://reviewboard.asterisk.org/r/2927/ ........ Merged
  5448. revisions 401182 from
  5449. http://svn.asterisk.org/svn/asterisk/branches/11
  5450. 2013-10-18 14:47 +0000 [r401180] Walter Doekes <walter+asterisk@wjd.nu>
  5451. * main/channel.c, /: Properly copy/remove the device state cache
  5452. flag over a masquerade. In r378303 the
  5453. AST_FLAG_DISABLE_DEVSTATE_CACHE flag was added that tells the
  5454. devstate system to not cache states for non-real devices.
  5455. However, when optimizing away channels (ast_do_masquerade), that
  5456. flag wasn't copied. In my case, using Local devices as queue
  5457. members created a situation where the endpoint was considered in
  5458. use, but the state change of the device being available again was
  5459. ignored (not cached). The endpoint channel was optimized into the
  5460. (previously) Local channel, but kept the do-not-cache flag. The
  5461. end result being that the queue member apparently stayed in use
  5462. forever. (closes issue ASTERISK-22718) Reported by: Walter Doekes
  5463. Review: https://reviewboard.asterisk.org/r/2925/ ........ Merged
  5464. revisions 401178 from
  5465. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5466. revisions 401179 from
  5467. http://svn.asterisk.org/svn/asterisk/branches/11
  5468. 2013-10-17 20:37 +0000 [r401168] Michael L. Young <elgueromexicano@gmail.com>
  5469. * /, channels/chan_sip.c: Fix Setting A chan_sip Dialog's
  5470. SIP_NAT_FORCE_RPORT Flag A condition was added in a commit to fix
  5471. ASTERISK-21374, that, if the SIP_PAGE3_NAT_AUTO_RPORT flag was
  5472. set, to then copy a peer's SIP_NAT_FORCE_RPORT flag to the
  5473. dialog. This condition should not have been there since it
  5474. assumed that if Asterisk is in an environment where NAT is
  5475. involved, that the auto_* nat settings or force_rport setting
  5476. would be on in the global settings. If the nat setting in the
  5477. global setting is set to 'nat=no' and then turned on for peers
  5478. (which is not quite the recommended way, although it is allowed)
  5479. this flag is never copied to the dialog resulting in problems
  5480. like, REGISTER replies going to the wrong port. This patch
  5481. removes this conditional check and will now always use the peer's
  5482. flag which by this point in the code the checks on whether the
  5483. peer is behind NAT or not (if using auto_force_rport) have
  5484. already been run. (closes issue ASTERISK-22236) Reported by:
  5485. Filip Frank Tested by: Michael L. Young Patches:
  5486. asterisk-2236-always-set-rport.diff uploaded by Michael L. Young
  5487. (license 5026) Review: https://reviewboard.asterisk.org/r/2919/
  5488. ........ Merged revisions 401167 from
  5489. http://svn.asterisk.org/svn/asterisk/branches/11
  5490. 2013-10-17 18:16 +0000 [r401158] Jonathan Rose <jrose@digium.com>
  5491. * res/res_parking.c: res_parking: Fix bug where reloading
  5492. immediately wipes new parkpos extensions (closes issue
  5493. ASTERISK-22631) Reported by: Kevin Harwell
  5494. 2013-10-17 15:40 +0000 [r401121] Kinsey Moore <kmoore@digium.com>
  5495. * /, res/res_xmpp.c, res/res_jabber.c: Reduce log level of a
  5496. non-pubsub error message Drop an error log message to debug level
  5497. 1 since distributed device state functions correctly when
  5498. receiving this message and it spams the logs. (closes issue
  5499. ASTERISK-22410) Reported by: abelbeck Patches:
  5500. asterisk-1.8-res_jabber-log-nonpubsub-error-to-debug.patch
  5501. uploaded by abelbeck (License 5903)
  5502. asterisk-11-res_xmpp-log-nonpubsub-error-to-debug.patch uploaded
  5503. by abelbeck (License 5903) ........ Merged revisions 401119 from
  5504. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5505. revisions 401120 from
  5506. http://svn.asterisk.org/svn/asterisk/branches/11
  5507. 2013-10-16 21:20 +0000 [r401107] Richard Mudgett <rmudgett@digium.com>
  5508. * res/ari/resource_playback.c: ARI: Fix crash when POST
  5509. /playback/{id}/control does not have an operation parameter.
  5510. (closes issue ASTERISK-22680) Reported by: John Bigelow
  5511. 2013-10-16 21:17 +0000 [r401096-401106] David M. Lee <dlee@digium.com>
  5512. * res/res_ari.c: Fixed malformed Access-Control-Allow-Methods
  5513. header. Was causing Safari to barf on POST and DELETE.
  5514. * rest-api/resources.json: Oops. Leftover /stasis reference
  5515. 2013-10-16 14:01 +0000 [r401087] Kinsey Moore <kmoore@digium.com>
  5516. * res/ari/resource_bridges.h, rest-api/api-docs/channels.json,
  5517. rest-api/api-docs/bridges.json, res/ari/resource_channels.h:
  5518. Clarify documentation for channel and bridge list This makes it
  5519. clear that the ARI API calls for listing channels and bridges
  5520. will list all channels or bridges in the system and not just
  5521. those that are in or are controlled by a Stasis application.
  5522. (closes issue ASTERISK-22635) Reported by: Kevin Harwell
  5523. 2013-10-16 12:12 +0000 [r401077] Walter Doekes <walter+asterisk@wjd.nu>
  5524. * apps/app_queue.c, /: Don't check all realtime queues when doing
  5525. "queue show some_queue". When using realtime queues, queues have
  5526. to be fetched from the database every now and then to see if any
  5527. info has been changed or to see if the queue has been removed.
  5528. When fetching info for an individual queue, the pruning of other
  5529. queues is unnecessarily costly. Review:
  5530. https://reviewboard.asterisk.org/r/2907/ ........ Merged
  5531. revisions 401049 from
  5532. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5533. revisions 401076 from
  5534. http://svn.asterisk.org/svn/asterisk/branches/11
  5535. 2013-10-16 00:02 +0000 [r401040] Paul Belanger <paul.belanger@polybeacon.com>
  5536. * res/res_ari_bridges.c, rest-api/api-docs/bridges.json: Use POST /
  5537. DELETE to toggle ARI bridge moh Review:
  5538. https://reviewboard.asterisk.org/r/2911/
  5539. 2013-10-15 20:25 +0000 [r401030] Richard Mudgett <rmudgett@digium.com>
  5540. * channels/dahdi/bridge_native_dahdi.c: bridge_native_dahdi: Return
  5541. channel join failure if could not make the channels compatible.
  5542. 2013-10-15 20:02 +0000 [r401018] Kinsey Moore <kmoore@digium.com>
  5543. * rest-api/api-docs/bridges.json, res/res_ari_bridges.c: Ensure
  5544. bridge record error responses validate This adds the list of
  5545. expected errors to the /bridges/{bridgeId}/record ARI
  5546. documentation so that outbound 4xx errors validate properly.
  5547. Previously, this would result in a response validation failure.
  5548. (closes issue ASTERISK-22627) Reported by: Joshua Colp
  5549. 2013-10-15 20:01 +0000 [r401017] Richard Mudgett <rmudgett@digium.com>
  5550. * /, channels/chan_iax2.c: chan_iax2: Fix channel left locked in
  5551. off nominal code path. ........ Merged revisions 401016 from
  5552. http://svn.asterisk.org/svn/asterisk/branches/11
  5553. 2013-10-15 15:26 +0000 [r400999] Paul Belanger <paul.belanger@polybeacon.com>
  5554. * rest-api/api-docs/channels.json, res/res_ari_channels.c: Use POST
  5555. / DELETE to toggle hold / moh for ARI channels This change
  5556. updates how we handle toggle events, rather then create two
  5557. different function names, we'll just use POST / DELETE from HTTP
  5558. to handle it. Review: https://reviewboard.asterisk.org/r/2906/
  5559. 2013-10-15 15:21 +0000 [r400984] Mark Michelson <mmichelson@digium.com>
  5560. * /, channels/chan_sip.c: Prevent chan_sip from sending duplicate
  5561. BYEs. When a 200 OK for an initial INVITE is received, we were
  5562. doing the right thing by ACKing and sending an immediate BYE.
  5563. However, we also were doing the wrong thing and queuing an answer
  5564. frame, thus causing the call to be answered. This would cause the
  5565. call to be hung up by the channel thread, thus resulting in a
  5566. second BYE being sent out. In this fix, I also have set the
  5567. hangupcause to be correct since the initial BYE being sent by
  5568. Asterisk had an unknown hangup cause. I have changed to using
  5569. "Bearer capabilty not available" since the call was hung up due
  5570. to an SDP offer/answer error. (closes issue ASTERISK-22621)
  5571. reported by Kinsey Moore ........ Merged revisions 400970 from
  5572. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5573. revisions 400971 from
  5574. http://svn.asterisk.org/svn/asterisk/branches/11
  5575. 2013-10-15 13:43 +0000 [r400958] David M. Lee <dlee@digium.com>
  5576. * rest-api-templates/asterisk_processor.py: My doc correction in
  5577. r400842 had a silly bug. Because I added a wiki_description to
  5578. models and not their properties, the rendered wiki page had the
  5579. model description instead of the property descriptions, which
  5580. looks very silly indeed. (closes issue ASTERISK-22705)
  5581. 2013-10-14 21:55 +0000 [r400911] Richard Mudgett <rmudgett@digium.com>
  5582. * /, channels/chan_dahdi.h, channels/chan_dahdi.c: chan_dahdi:
  5583. Reflect the set software gain in the CLI "dahdi show channel"
  5584. output. * Remember the swgain setting from CLI "dahdi set swgain"
  5585. command so the CLI "dahdi show channel" output will reflect the
  5586. current setting. * Updated CLI "dahdi set hwgain" and "dahdi set
  5587. swgain" documentation. (issue ASTERISK-22429) Reported by: Jaco
  5588. Kroon Patches: jira_asterisk_22429_v1.8_v2.patch (license #5621)
  5589. patch uploaded by rmudgett ........ Merged revisions 400907 from
  5590. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5591. revisions 400909 from
  5592. http://svn.asterisk.org/svn/asterisk/branches/11
  5593. 2013-10-14 21:52 +0000 [r400910] Mark Michelson <mmichelson@digium.com>
  5594. * /, channels/chan_sip.c: chan_sip: Do not increment the SDP
  5595. version between 183 and 200 responses. Bumping the SDP version
  5596. number can cause interoperability problems since receivers of the
  5597. responses will expect that a 200 SDP will be identical to a
  5598. previous 183 SDP. (closes issue ASTERISK-21204) reported by
  5599. NITESH BANSAL Patches:
  5600. dont-increment-session-version-in-2xx-after-183.patch uploaded by
  5601. NITESH BANSAL (License #6418) ........ Merged revisions 400906
  5602. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  5603. Merged revisions 400908 from
  5604. http://svn.asterisk.org/svn/asterisk/branches/11
  5605. 2013-10-14 15:52 +0000 [r400890] Kevin Harwell <kharwell@digium.com>
  5606. * res/res_pjsip_outbound_registration.c: pjsip outbound
  5607. registration: Log message says received a 408 when we didn't If
  5608. the server didn't exist that we are trying to register to the log
  5609. message would say that a 408 was received from that server when
  5610. in reality one wasn't. Added log messages stating no response was
  5611. received if the response does not exist. (closes issue
  5612. ASTERISK-22554) Reported by: Rusty Newton Review:
  5613. https://reviewboard.asterisk.org/r/2893/
  5614. 2013-10-14 14:57 +0000 [r400881] Matthew Jordan <mjordan@digium.com>
  5615. * res/res_pjsip_mwi.c: Remove duplicate module info block The
  5616. module info block was repeated twice. Once is sufficient.
  5617. 2013-10-13 15:41 +0000 [r400872] Joshua Colp <jcolp@digium.com>
  5618. * res/res_pjsip_session.c: Fix a race condition in
  5619. res_pjsip_session with rapidly terminating the session. The
  5620. INVITE session state callback wrongly assumes that a session will
  5621. always exist, but when rapidly terminating the session this
  5622. assumption goes out the window. As all handler code for the
  5623. INVITE session state callback requires the session it will now
  5624. just exit immediately if no session exists. (closes issue
  5625. ASTERISK-22668) Reported by: John Bigelow
  5626. 2013-10-12 16:49 +0000 [r400863] Kinsey Moore <kmoore@digium.com>
  5627. * res/res_pjsip_outbound_authenticator_digest.c: Fix realm
  5628. comparison for outbound auth When generating the list of
  5629. authentication credentials to pass to PJSIP, Asterisk was using
  5630. the raw pointer of a pj_str_t which is not always
  5631. NULL-terminated. This sometimes resulted in incorrect text for
  5632. the realm and a failure to match the realm for authentication
  5633. purposes which was causing the outbound nominal auth pjsip basic
  5634. call test to bounce. This now uses the pj_str_t that contains the
  5635. realm instead of generating a new one. Thanks to John Bigelow for
  5636. helping to narrow this down.
  5637. 2013-10-11 16:53 +0000 [r400849-400854] Richard Mudgett <rmudgett@digium.com>
  5638. * include/asterisk/channel.h: channel.h: whitespace changes.
  5639. * bridges/bridge_softmix.c: Softmix: Fix crash when switching from
  5640. softmix to another bridge technology. The crash is caused by a
  5641. race condition when switching between native RTP and softmix
  5642. bridging technologies. In this situation, the bridging technology
  5643. is switched from native RTP to softmix, and then back to native
  5644. RTP fast enough that the softmix private data gets destroyed
  5645. before the softmix mixing thread gets started. Thanks to Kinsey
  5646. Moore for the crash analysis. * Fix race condition when starting
  5647. the softmix mixing thread and switching to another bridge
  5648. technology. (closes issue ASTERISK-22678) Reported by: John
  5649. Bigelow Patches: jira_asterisk_22678_v12.patch (license #5621)
  5650. patch uploaded by rmudgett Tested by: John Bigelow
  5651. 2013-10-11 16:18 +0000 [r400842-400848] David M. Lee <dlee@digium.com>
  5652. * res/ari/resource_playback.h, rest-api/api-docs/playback.json: Fix
  5653. a stupid copy/paste error in ARI docs. Patches: ari-doc-patch.txt
  5654. uploaded by jbigelow (license 5091)
  5655. * res/ari/resource_bridges.h, rest-api/api-docs/channels.json,
  5656. rest-api/api-docs/bridges.json, res/ari/resource_channels.h:
  5657. Updated /play resource docs. The playback of http: resources
  5658. isn't implemented... yet
  5659. * rest-api-templates/models.wiki.mustache,
  5660. rest-api-templates/api.wiki.mustache,
  5661. rest-api-templates/asterisk_processor.py: Correct some ARI wiki
  5662. rendering errors
  5663. 2013-10-10 18:21 +0000 [r400824-400833] Joshua Colp <jcolp@digium.com>
  5664. * res/res_pjsip/location.c: Perform validation of permanent
  5665. contacts on AORs in res_pjsip.
  5666. * res/res_pjsip/pjsip_configuration.c, res/res_pjsip.c: Fix an
  5667. assertion in res_pjsip when specifying an invalid outbound proxy.
  5668. This change fixes two issues when setting an outbound proxy: 1.
  5669. The outbound proxy URI was not parsed and validated during
  5670. configuration. 2. If an outgoing dialog was created and the
  5671. outbound proxy could not be set an assertion would occur because
  5672. the usage count on the dialog was not decremented. The
  5673. documentation has also been updated to specify that a full URI
  5674. must be specified for the outbound proxy. (closes issue
  5675. ASTERISK-22672) Reported by: Antti Yrjola
  5676. 2013-10-09 11:00 +0000 [r400771-400812] Matthew Jordan <mjordan@digium.com>
  5677. * res/res_pjsip_header_funcs.c: Use 'z' as the format specifier for
  5678. size_t Using 'lu' will produce a compiler warning for some
  5679. versions of gcc and on some architectures. 'z' should be portable
  5680. as a format specifier for size_t.
  5681. * res/res_pjsip_header_funcs.c (added): Add PJSIP_HEADER function
  5682. for manipulation of SIP headers in the PJSIP stack This patch
  5683. adds support to the PJSIP stack in Asterisk for SIP header
  5684. manipulation. Note that this is analagous to
  5685. SIPAddHeader/SIPRemoveHeader. For PJSIP_HEADER, an incoming
  5686. supplemental session callback is registered that takes the
  5687. pjsip_hdrs from the incoming session and stores them in a linked
  5688. list in the session datastore. Calls to PJSIP_HEADER traverse
  5689. over the list and return the nth matching header where 'n' is the
  5690. 'number' argument to the function. When adding a header, the
  5691. first call creates a datastore and linked list and adds the
  5692. datastore to the session. The header is then created as a
  5693. pjsip_hdr and added to the list. An outgoing supplemental session
  5694. callback then traverses the list and adds the headers to the
  5695. outgoing pjsip_msg. When removing a header, the list created with
  5696. PJSIP_HEADER(add,...) is traversed and all matching entries are
  5697. removed. (closes issue ASTERISK-22498) Reported by: George Joseph
  5698. patch: res_pjsip_header_funcs_v1.patch uploaded by george.joseph
  5699. (License 6322)
  5700. 2013-10-08 22:30 +0000 [r400769] Kinsey Moore <kmoore@digium.com>
  5701. * /, configure, configure.ac: Add warning when compiling with iODBC
  5702. support When running configure, libiodbc2 development headers
  5703. will fulfill the requirement for ODBC development headers, but
  5704. will not function properly. This adds a warning when libiodbc2
  5705. development headers are detected instead of unixodbc development
  5706. headers. (closes issue ASTERISK-22459) Reported by: Patrick
  5707. Maille Tested by: Walter Doekes Patches:
  5708. issueA22459_warn_when_using_iodbc.patch uploaded by Walter Doekes
  5709. (License 5674) ........ Merged revisions 400767 from
  5710. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5711. revisions 400768 from
  5712. http://svn.asterisk.org/svn/asterisk/branches/11
  5713. 2013-10-08 21:19 +0000 [r400754] Richard Mudgett <rmudgett@digium.com>
  5714. * apps/app_agent_pool.c: app_agent_pool: Fix AMI/CLI AgentLogoff
  5715. soft preventing agents from logging back in. * Clear the
  5716. deferred_logoff flag when an agent logs in. (closes issue
  5717. ASTERISK-22669) Reported by: John Bigelow
  5718. 2013-10-08 20:51 +0000 [r400749] Mark Michelson <mmichelson@digium.com>
  5719. * res/res_pjsip.c, res/res_pjsip/config_transport.c: Switch from
  5720. using pjsip_strerror to pj_strerror. pjsip_strerror is only aware
  5721. of PJSIP-specific error codes. pj_strerror() is aware of all
  5722. PJProject error codes and OS-specific error codes. This
  5723. specifically fixes an oft-seen error in transport configuration
  5724. code where EADDRINUSE would result in "Unknown PJSIP error
  5725. 120098" instead of a useful message.
  5726. 2013-10-08 20:16 +0000 [r400724-400742] Richard Mudgett <rmudgett@digium.com>
  5727. * apps/app_confbridge.c, CHANGES,
  5728. apps/confbridge/conf_config_parser.c,
  5729. configs/confbridge.conf.sample, /,
  5730. apps/confbridge/include/confbridge.h: app_confbridge: Can now set
  5731. the language used for announcements to the conference. ConfBridge
  5732. now has the ability to set the language of announcements to the
  5733. conference. The language can be set on a bridge profile in
  5734. confbridge.conf or by the dialplan function
  5735. CONFBRIDGE(bridge,language)=en. (closes issue ASTERISK-19983)
  5736. Reported by: Jonathan White Patches: M19983_rev2.diff (license
  5737. #5138) patch uploaded by junky (modified) Tested by: rmudgett
  5738. ........ Merged revisions 400741 from
  5739. http://svn.asterisk.org/svn/asterisk/branches/11
  5740. * apps/confbridge/conf_config_parser.c, /: app_confbridge: Fix
  5741. duplicate default_user profile. * Fixed looking in the wrong
  5742. profiles container to see if the default_user profile is already
  5743. created in verify_default_profiles(). The bridge profile
  5744. container is never going to hold user profiles. :) ........
  5745. Merged revisions 400723 from
  5746. http://svn.asterisk.org/svn/asterisk/branches/11
  5747. 2013-10-08 18:19 +0000 [r400682-400701] Kinsey Moore <kmoore@digium.com>
  5748. * funcs/func_config.c, /: Fix func_config list entry allocation The
  5749. AST_CONFIG dialplan function defined in func_config.c allocates
  5750. its config file list entries using ast_malloc. List entry
  5751. allocations destined for use with Asterisk's linked list API must
  5752. be ast_calloc()d or otherwise initialized so that list pointers
  5753. are set to NULL. These uses of ast_malloc have been replaced by
  5754. ast_calloc to prevent dereferencing of uninitialized pointer
  5755. values when traversing the list. (closes issue ASTERISK-22483)
  5756. Reported by: Brian Scott ........ Merged revisions 400694 from
  5757. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5758. revisions 400697 from
  5759. http://svn.asterisk.org/svn/asterisk/branches/11
  5760. * res/res_rtp_asterisk.c, /: Fix STUN crash when using IPv6 any
  5761. address Ensure that when chan_sip binds to the IPv6 any address
  5762. ([::]), IPv4 candidates are also added. (closes issue
  5763. ASTERISK-21917) Reported by: Torrey Searle Patches:
  5764. 0023_ipv6_stun_crash.patch uploaded by Torrey Searle (License
  5765. 5334) ........ Merged revisions 400681 from
  5766. http://svn.asterisk.org/svn/asterisk/branches/11
  5767. 2013-10-08 15:36 +0000 [r400680] Mark Michelson <mmichelson@digium.com>
  5768. * res/res_pjsip/pjsip_options.c: Push CLI qualify into the
  5769. threadpool. If you run Asterisk in the background and then
  5770. connect to it through a separate console, the thread that runs
  5771. CLI commands is not registered with PJLIB. Thus PJLIB does not
  5772. like it when you attempt to send OPTIONS requests from that
  5773. thread. So now we push the task into the threadpool, which we
  5774. know to be registered with PJLIB. Thanks to Antti Yrjola for
  5775. reporting this.
  5776. 2013-10-08 15:11 +0000 [r400661-400671] Richard Mudgett <rmudgett@digium.com>
  5777. * res/res_agi.c, apps/app_queue.c: Make app_queue and res_agi
  5778. independent of AMI being enabled. The
  5779. https://reviewboard.asterisk.org/r/2888/ review changes manager
  5780. to not subscribe to stasis when it is disabled for performance
  5781. reasons. When manager is disabled app_queue and res_agi decline
  5782. to load and fail to clean up what they have already allocated. *
  5783. Made app_queue and res_agi clean up allocated resources when they
  5784. decline to load. * Made app_queue and res_agi use their own
  5785. subscriptions to the stasis topics instead of borrowing manager's
  5786. message router structure inappropriately. (closes issue
  5787. ASTERISK-22604) Reported by: rmudgett Review:
  5788. https://reviewboard.asterisk.org/r/2902/
  5789. * include/asterisk/stasis.h, apps/app_queue.c,
  5790. include/asterisk/manager.h: Miscellaneous stand alone comment
  5791. cleanups.
  5792. 2013-10-06 17:11 +0000 [r400624] Michael L. Young <elgueromexicano@gmail.com>
  5793. * apps/app_queue.c, /: app_queue: Fix Queuelog EXITWITHKEY only
  5794. logging two of four fields Commit r62462 added two extra fields
  5795. for logging "the original position the caller entered the queue
  5796. at, and the amount of time the caller was waiting in the queue."
  5797. But when r75969 was merged from 1.4 into trunk (r75977), these
  5798. two fields disappeared. Those two extra fields were not logged in
  5799. 1.4 and when the patch was merged, those fields went away.
  5800. Therefore, this is a regression and was caught by the reporter
  5801. because he was reading the awesome "Asterisk: The Definitive
  5802. Guide" book. (closes issue ASTERISK-22197) Reported by: Dalius M.
  5803. Tested by: Dalius M. Patches:
  5804. asterisk-22197-q-log-exitwithkey.diff uploaded by Michael L.
  5805. Young (license 5026) Review:
  5806. https://reviewboard.asterisk.org/r/2901/ ........ Merged
  5807. revisions 400622 from
  5808. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5809. revisions 400623 from
  5810. http://svn.asterisk.org/svn/asterisk/branches/11
  5811. 2013-10-05 00:41 +0000 [r400588] Richard Mudgett <rmudgett@digium.com>
  5812. * channels/iax2/include/parser.h: chan_iax2: Fix compile error.
  5813. 2013-10-04 21:40 +0000 [r400567] Michael L. Young <elgueromexicano@gmail.com>
  5814. * channels/iax2/include/parser.h, main/acl.c,
  5815. include/asterisk/netsock2.h, CHANGES, channels/chan_iax2.c,
  5816. channels/iax2/parser.c, main/netsock.c, main/netsock2.c: Add IPv6
  5817. Support To chan_iax2 This patch adds IPv6 support to chan_iax2.
  5818. Yay! (closes issue ASTERISK-22025) Patches:
  5819. iax2-ipv6-v5-reviewboard.diff by Michael L. Young (license 5026)
  5820. Review: https://reviewboard.asterisk.org/r/2660/
  5821. 2013-10-04 19:31 +0000 [r400552] David M. Lee <dlee@digium.com>
  5822. * rest-api/api-docs/applications.json (added): Added missing file
  5823. from r400522
  5824. 2013-10-04 18:42 +0000 [r400532-400542] Jonathan Rose <jrose@digium.com>
  5825. * res/res_pjsip_logger.c: chan_pjsip: Make logger togglable without
  5826. loading/unloading This patch makes the res_pjsip_logger do a few
  5827. things... First, it will be built and installed by default now,
  5828. so end users won't need to enable it in menuselect. Second, while
  5829. it is loaded, it no longer will immediately issue log messages.
  5830. Upon loading, it is in the disabled state and must be turned on
  5831. with the new CLI command. The CLI command 'pjsip set logger
  5832. <on/off/host> has been added and can be used to do the following:
  5833. pjsip set logger on: Enables logger for all PJSIP traffic pjsip
  5834. set logger off: Disables logger for all PJSIP traffic pjsip set
  5835. logger host <host>: Enables logger for the specific host Review:
  5836. https://reviewboard.asterisk.org/r/2900/
  5837. * contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py,
  5838. configs/extconfig.conf.sample, configs/sorcery.conf.sample,
  5839. contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py
  5840. (added): chan_pjsip: Add alembic scripts for generating db tables
  5841. for PJSIP Also updates sample configurations for sorcery and
  5842. extconfig to demonstrate how to use databases created by that
  5843. alembic script. (closes issue ASTERISK-22133) Reported by: Matt
  5844. Jordan Review: https://reviewboard.asterisk.org/r/2892/
  5845. 2013-10-04 15:54 +0000 [r400522] Matthew Jordan <mjordan@digium.com>
  5846. * res/stasis/app.h, rest-api/resources.json,
  5847. include/asterisk/_private.h, main/endpoints.c,
  5848. res/ari/ari_model_validators.c, res/ari/ari_model_validators.h,
  5849. res/res_ari_model.c, main/json.c, res/ari.make,
  5850. res/ari/resource_applications.c (added),
  5851. res/ari/resource_applications.h (added), res/res_stasis.c,
  5852. main/asterisk.c, rest-api/api-docs/endpoints.json,
  5853. rest-api/api-docs/events.json, res/stasis/app.c,
  5854. include/asterisk/endpoints.h,
  5855. rest-api-templates/ari_model_validators.h.mustache,
  5856. res/res_ari_applications.c (added), res/ari/resource_endpoints.h,
  5857. include/asterisk/stasis_app.h: ARI: Add subscription support This
  5858. patch adds an /applications API to ARI, allowing explicit
  5859. management of Stasis applications. * GET /applications - list
  5860. current applications * GET /applications/{applicationName} - get
  5861. details of a specific application * POST
  5862. /applications/{applicationName}/subscription - explicitly
  5863. subscribe to a channel, bridge or endpoint * DELETE
  5864. /applications/{applicationName}/subscription - explicitly
  5865. unsubscribe from a channel, bridge or endpoint Subscriptions work
  5866. by a reference counting mechanism: if you subscript to an event
  5867. source X number of times, you must unsubscribe X number of times
  5868. to stop receiveing events for that event source. Review:
  5869. https://reviewboard.asterisk.org/r/2862 (issue ASTERISK-22451)
  5870. Reported by: Matt Jordan
  5871. 2013-10-04 15:48 +0000 [r400510-400520] Joshua Colp <jcolp@digium.com>
  5872. * res/res_pjsip.c: Enclose the To URI and update its user portion
  5873. if a request user has been specified.
  5874. * res/res_pjsip_session.c: Replace the connection address at the
  5875. SDP level if altering the SDP with the external media address.
  5876. 2013-10-04 04:54 +0000 [r400508] David M. Lee <dlee@digium.com>
  5877. * rest-api/api-docs/playback.json, res/res_ari_playback.c:
  5878. Corrected response class for stopPlayback
  5879. 2013-10-03 23:11 +0000 [r400471] Jonathan Rose <jrose@digium.com>
  5880. * /, channels/chan_sip.c: chan_sip: Don't ignore expires value in
  5881. contact header if it lacks semicolon (closes issue
  5882. ASTERISK-22574) Reported by: Filip Jenicek Patches:
  5883. chan_sip_expires.patch uploaded by Filip Jenicek (license 6277)
  5884. ........ Merged revisions 400469 from
  5885. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5886. revisions 400470 from
  5887. http://svn.asterisk.org/svn/asterisk/branches/11
  5888. 2013-10-03 21:40 +0000 [r400460] Matthew Jordan <mjordan@digium.com>
  5889. * main/channel_internal_api.c: Remove publication of a channel
  5890. snapshot when the technology is set This patch removes said
  5891. publication for a few reasons: (1) It is unnecessary. Association
  5892. of the channel technology with a specific channel is an
  5893. implementation detail that should be assumed to "just happen",
  5894. and consumers of Stasis don't need to be informed about it. (2)
  5895. Publication of said message can now cause crashes, as the actual
  5896. creation of a channel in normal locations now stages its
  5897. messages. As a result, things that create dummy channels (such as
  5898. the SIP RTP QOS unit test) and associate them with a channel
  5899. technology were now crashing, as the channel itself was not known
  5900. by Stasis.
  5901. 2013-10-03 19:31 +0000 [r400442] Joshua Colp <jcolp@digium.com>
  5902. * main/cdr.c: When serializing CDR variables (like for "core show
  5903. channels") don't output an error if CDRs aren't enabled.
  5904. 2013-10-03 19:29 +0000 [r400440] Kinsey Moore <kmoore@digium.com>
  5905. * /, main/security_events.c: Fix security events for AMI invalid
  5906. password In r337595, additional security events were added for
  5907. chan_sip authentication failures. The new IEs added to the
  5908. existing invalid password event were defined as required IEs, but
  5909. existing users of the event did not set the new IEs and could not
  5910. since they didn't apply to existing uses. They are now marked as
  5911. optional IEs. (closes issue ASTERISK-22578) Reported by: Matt
  5912. Jordan ........ Merged revisions 400421 from
  5913. http://svn.asterisk.org/svn/asterisk/branches/11
  5914. 2013-10-03 19:11 +0000 [r400403] Mark Michelson <mmichelson@digium.com>
  5915. * include/asterisk/bridge_technology.h,
  5916. bridges/bridge_native_rtp.c: Fix assumption in
  5917. bridge_native_rtp.c regarding number of participants in a bridge.
  5918. When a party leaves a bridge, there may be more participants in
  5919. the bridge than expected. As such, it is important not to make
  5920. assumptions regarding the list of channels in a bridge. This
  5921. change makes it so that when a party leaves a native RTP bridge,
  5922. we unbridge it and the party it was bridged with. Previously, the
  5923. first and last channels in the list were unbridged since it was
  5924. assumed that these were the two channels that had been bridged.
  5925. As previously stated, a new party had been inserted into the
  5926. bridge, so this logic did not work properly. (closes issue
  5927. ASTERISK-22615) reported by Matt Jordan (closes issue
  5928. ASTERISK-22532) reported by Matt Jordan Review:
  5929. https://reviewboard.asterisk.org/r/2899
  5930. 2013-10-03 19:05 +0000 [r400401] Joshua Colp <jcolp@digium.com>
  5931. * res/ari/resource_channels.c: Fix a crash caused by muting and
  5932. unmuting a channel in ARI without specifying a direction. (closes
  5933. issue ASTERISK-22637) Reported by: Scott Griepentrog Patch by
  5934. Matt Jordan, whose office I have taken over in the name of
  5935. Canada.
  5936. 2013-10-03 18:44 +0000 [r400398] Richard Mudgett <rmudgett@digium.com>
  5937. * main/cel.c: cel: Some whitespace cleanups
  5938. 2013-10-03 18:28 +0000 [r400384-400395] Kinsey Moore <kmoore@digium.com>
  5939. * res/res_rtp_multicast.c, /: res_rtp_multicast: Ensure SSRC is set
  5940. properly This fixes a bug where the SSRC field on multicast RTP
  5941. can be stuck at 0 which can cause problems for endpoints trying
  5942. to make sense of incoming streams. (closes issue ASTERISK-22567)
  5943. Reported by: Simone Camporeale Patches:
  5944. 22567_res_mulitcast_ssrc.patch uploaded by Simone Camporeale
  5945. (License 6536) ........ Merged revisions 400393 from
  5946. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5947. revisions 400394 from
  5948. http://svn.asterisk.org/svn/asterisk/branches/11
  5949. * configure, include/asterisk/autoconfig.h.in, configure.ac,
  5950. main/xml.c: Detect and use xsltCleanupGlobals when available This
  5951. introduces usage of an additional libxslt cleanup function,
  5952. xsltCleanupGlobals, when the configure script detects that it is
  5953. available. Early versions of the library did not include this
  5954. function. (closes issue ASTERISK-22570) Reported by: Corey
  5955. Farrell Patches: xsltCleanupGlobals.patch uploaded by Corey
  5956. Farrell (License 5909)
  5957. 2013-10-03 17:55 +0000 [r400383] Matthew Jordan <mjordan@digium.com>
  5958. * contrib/ast-db-manage/config/env.py,
  5959. contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py,
  5960. contrib/ast-db-manage/voicemail/env.py: Update Alembic database
  5961. scripts for external scripting and PostgreSQL, Oracle This patch
  5962. does the following: 1) The env scripts have been updated to be
  5963. tolerant of a NULL configuration file. This occurs when
  5964. configuration is provided by an external script, such that the
  5965. actual config.ini file is not used. 2) Enum types have all been
  5966. given names. This is needed for PostgreSQL script generation. 3)
  5967. The identifier meetme_confno_starttime_endtime is greater than 30
  5968. characters, and hence invalid for Oracle databases. This has been
  5969. truncated down to meetme_confno_start_end.
  5970. 2013-10-03 16:22 +0000 [r400373] Richard Mudgett <rmudgett@digium.com>
  5971. * channels/chan_vpb.cc: chan_vpb: Make compile again.
  5972. 2013-10-03 14:56 +0000 [r400362] Mark Michelson <mmichelson@digium.com>
  5973. * tests/test_cel.c: Get rid of uses of stasis_topic_wait()
  5974. 2013-10-03 14:51 +0000 [r400360] Joshua Colp <jcolp@digium.com>
  5975. * res/res_pjsip_sdp_rtp.c, res/res_pjsip_t38.c: Fix crashes in
  5976. res_pjsip_sdp_rtp and res_pjsip_t38 when a stream is rejected and
  5977. external_media_address is set. The callback function for changing
  5978. the media address in streams wrongly assumes that a connection
  5979. line will always be present. This is false as no line is present
  5980. if a stream has been rejected. (closes issue ASTERISK-22645)
  5981. Reported by: Rusty Newton
  5982. 2013-10-02 22:34 +0000 [r400318-400356] Mark Michelson <mmichelson@digium.com>
  5983. * main/rtp_engine.c, addons/chan_ooh323.c,
  5984. channels/chan_multicast_rtp.c, main/ccss.c, apps/app_meetme.c,
  5985. bridges/bridge_holding.c, main/bridge_basic.c,
  5986. bridges/bridge_softmix.c, channels/chan_gtalk.c,
  5987. channels/chan_iax2.c, main/media_index.c, main/channel.c,
  5988. channels/chan_phone.c, channels/chan_dahdi.c, main/dial.c,
  5989. main/manager.c, pbx/pbx_spool.c, channels/chan_skinny.c,
  5990. main/format_cap.c, channels/chan_motif.c, res/res_agi.c,
  5991. channels/chan_alsa.c, apps/app_confbridge.c,
  5992. addons/chan_mobile.c, channels/chan_mgcp.c,
  5993. res/res_clioriginate.c, channels/chan_sip.c,
  5994. channels/chan_bridge_media.c, res/res_pjsip_sdp_rtp.c,
  5995. tests/test_format_api.c, bridges/bridge_simple.c,
  5996. apps/app_originate.c, res/parking/parking_applications.c,
  5997. main/core_local.c, channels/chan_console.c, channels/chan_oss.c,
  5998. include/asterisk/format_cap.h, res/res_pjsip_session.c,
  5999. res/ari/resource_bridges.c, channels/chan_jingle.c,
  6000. channels/chan_misdn.c, channels/dahdi/bridge_native_dahdi.c,
  6001. channels/chan_h323.c, main/file.c,
  6002. res/res_pjsip/pjsip_configuration.c, tests/test_config.c,
  6003. channels/chan_nbs.c, bridges/bridge_native_rtp.c,
  6004. res/res_stasis.c, channels/chan_pjsip.c, channels/chan_unistim.c:
  6005. Cache string values of formats on ast_format_cap() to save
  6006. processing. Channel snapshots have string representations of the
  6007. channel's native formats. Prior to this change, the format
  6008. strings were re-created on ever channel snapshot creation. Since
  6009. channel native formats rarely change, this was very wasteful.
  6010. Now, string representations of formats may optionally be stored
  6011. on the ast_format_cap for cases where string representations may
  6012. be requested frequently. When formats are altered, the string
  6013. cache is marked as invalid. When strings are requested, the cache
  6014. validity is checked. If the cache is valid, then the cached
  6015. strings are copied. If the cache is invalid, then the string
  6016. cache is rebuilt and copied, and the cache is marked as being
  6017. valid again. Review: https://reviewboard.asterisk.org/r/2879
  6018. * /: Remove svn:mergeinfo property.
  6019. * main/stasis_endpoints.c, main/stasis_wait.c (removed),
  6020. res/ari/resource_endpoints.c, /, include/asterisk/stasis.h,
  6021. tests/test_cel.c, include/asterisk/stasis_endpoints.h,
  6022. channels/chan_pjsip.c, main/stasis.c: Remove unnecessary waits
  6023. from stasis. Since caches are updated on publisher threads, there
  6024. is no need to wait for the cache updates to occur after a stasis
  6025. message is published. In the case of chan_pjsip device state
  6026. changes, this set of changes caused an improvement to
  6027. performance. Review: https://reviewboard.asterisk.org/r/2890
  6028. 2013-10-02 21:32 +0000 [r400316] Michael L. Young <elgueromexicano@gmail.com>
  6029. * /, channels/chan_iax2.c: Cast Integer Argument To Unsigned Char
  6030. The member reg in the peercnt structure is an unsigned char and
  6031. peercnt_modify() is expecting an unsigned char argument which
  6032. gets assigned to peercnt->reg. This patch fixes that by casting
  6033. the integer argument being passed to peercnt_modify to unsigned
  6034. char. ........ Merged revisions 400314 from
  6035. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6036. revisions 400315 from
  6037. http://svn.asterisk.org/svn/asterisk/branches/11
  6038. 2013-10-02 21:25 +0000 [r400312] Matthew Jordan <mjordan@digium.com>
  6039. * main/cel.c, main/cdr.c, main/manager.c: Only create Stasis
  6040. subscriptions when enabled Subscribing to Stasis isn't free. As
  6041. such, this patch makes AMI, CDR, and CEL - the "big 3" - only
  6042. subscribe when enabled. Toggling their availability via a .conf
  6043. file will unsubscribe/subscribe as appropriate. Review:
  6044. https://reviewboard.asterisk.org/r/2888/
  6045. 2013-10-02 20:30 +0000 [r400303] Richard Mudgett <rmudgett@digium.com>
  6046. * main/pbx.c: Originate: Make setting caller id on outgoing call
  6047. use either name or number. Previous code was requiring both name
  6048. and number to be available. Also restored a comment block on why
  6049. caller id is also set on an outgoing call leg in addition to
  6050. connected line from earlier versions of Asterisk.
  6051. 2013-10-02 19:19 +0000 [r400291] Kinsey Moore <kmoore@digium.com>
  6052. * rest-api/api-docs/asterisk.json: Correct allowable values for ARI
  6053. general information filter
  6054. 2013-10-02 18:57 +0000 [r400286] Matthew Jordan <mjordan@digium.com>
  6055. * main/cdr.c: Fix the CDR CLI command 'cdr show active {channel}'
  6056. When the switch from channel names to channel unique IDs
  6057. happened, the poor CLI command got left in the dust. This fixes
  6058. the command so that users can once again see how Asterisk is
  6059. messing up your billing information.
  6060. 2013-10-02 18:42 +0000 [r400284] Joshua Colp <jcolp@digium.com>
  6061. * res/res_pjsip_t38.c: Fix a crash in res_pjsip_t38 caused by the
  6062. wrong assumption that a session will always have a channel. When
  6063. starting up or shutting down this assumption is false.
  6064. 2013-10-02 18:25 +0000 [r400281] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  6065. * Makefile, doc/astdb2sqlite3.8 (added), /, doc/astdb2bdb.8
  6066. (added): man pages for astdb2bdb and astdb2sqlite3 Review:
  6067. https://reviewboard.asterisk.org/r/2898/ ........ Merged
  6068. revisions 400279 from
  6069. http://svn.asterisk.org/svn/asterisk/branches/11
  6070. 2013-10-02 17:11 +0000 [r400268-400270] Richard Mudgett <rmudgett@digium.com>
  6071. * main/utils.c, apps/app_stack.c, res/stasis_recording/stored.c,
  6072. main/json.c, main/stasis_cache.c, res/res_ari.c: MALLOC_DEBUG:
  6073. Fix some misuses of free() when MALLOC_DEBUG is enabled. * There
  6074. were several places in ARI where an external library was
  6075. mallocing memory that must always be released with free(). When
  6076. MALLOC_DEBUG is enabled, free() is redirected to the MALLOC_DEBUG
  6077. version. Since the external library call still uses the normal
  6078. malloc(), MALLOC_DEBUG complains that the freed memory block is
  6079. not registered and will not free it. These cases must use
  6080. ast_std_free(). * Changed calls to asprintf() and vasprintf() to
  6081. the equivalent ast_asprintf() and ast_vasprintf() versions
  6082. respectively.
  6083. * channels/sig_ss7.c: sig_ss7: Fix compiler warnings.
  6084. 2013-10-02 16:20 +0000 [r400245-400265] Joshua Colp <jcolp@digium.com>
  6085. * channels/chan_jingle.c, main/channel.c, main/dial.c,
  6086. channels/chan_dahdi.c, include/asterisk/stasis_channels.h,
  6087. channels/chan_skinny.c, channels/chan_motif.c,
  6088. channels/chan_alsa.c, main/stasis_channels.c,
  6089. channels/chan_pjsip.c, channels/sig_ss7.c, channels/chan_mgcp.c,
  6090. channels/chan_unistim.c, apps/app_dial.c, main/pbx.c,
  6091. channels/chan_sip.c, main/bridge.c, include/asterisk/channel.h,
  6092. channels/chan_gtalk.c, channels/chan_console.c,
  6093. channels/sig_pri.c, channels/chan_iax2.c: Reduce channel snapshot
  6094. creation and publishing by up to 50%. This change introduces the
  6095. ability to stage channel snapshot creation and publishing by
  6096. suppressing the implicit creation and publishing that some
  6097. functions have. Once all operations are executed the staging is
  6098. marked as done and a single snapshot is created and published.
  6099. Review: https://reviewboard.asterisk.org/r/2889/
  6100. * res/res_pjsip_session.c: Fix a random one way audio issue in
  6101. PJSIP. Due to the asynchronous design of the PJMEDIA SDP
  6102. negotiator it was possible for the SDP to be negotiated *after* a
  6103. channel was created and after it was being wait on by an
  6104. application. It is only after negotiation occurs that the file
  6105. descriptors for RTP are placed on the channel. Since the channel
  6106. was already being waited on these file descriptors were not
  6107. monitored, causing incoming media to never be read. This change
  6108. wakes up any application waiting on the channel so that added
  6109. file descriptors end up being monitored. (closes issue AST-1227)
  6110. Reported by: John Bigelow
  6111. * res/stasis/control.c, include/asterisk/stasis_app.h,
  6112. res/ari/resource_channels.c: Allow specifying a channel to dial
  6113. an extension and context in an ARI dial operation. (issue
  6114. ASTERISK-22625) Reported by: Scott Griepentrog
  6115. * res/res_pjsip_session.c: Retrieve and store the hostname only
  6116. once so multiple threads do not potentially initialize it at the
  6117. same time.
  6118. 2013-10-01 21:17 +0000 [r400227-400236] Richard Mudgett <rmudgett@digium.com>
  6119. * channels/chan_dahdi.c, channels/sig_analog.c: chan_dahdi: Fix
  6120. analog parking using flash-hook. Transferring an analog call
  6121. using a flash-hook to parking would fail to park the call and
  6122. result in an invalid ao2 object unref. * Park the correct bridged
  6123. channel.
  6124. * main/features_config.c: Features: Rearm the parking config
  6125. options have moved warning for each reload.
  6126. 2013-10-01 15:48 +0000 [r400217] Matthew Jordan <mjordan@digium.com>
  6127. * main/cdr.c: Filter out internal channels for bridge leave
  6128. messages and parked call messages Granted, if you manage to park
  6129. a Conference announcer channel, something has gone horrifically
  6130. wrong.
  6131. 2013-09-30 21:31 +0000 [r400205] Jonathan Rose <jrose@digium.com>
  6132. * configs/res_parking.conf.sample, configs/features.conf.sample:
  6133. configuration samples: Pull all parking related stuff out of
  6134. features.conf This patch also adds documentation for parking from
  6135. features.conf to res_parking.conf
  6136. 2013-09-30 19:57 +0000 [r400194-400196] Matthew Jordan <mjordan@digium.com>
  6137. * funcs/func_cdr.c: Parse arguments passed to the CDR_PROP function
  6138. correctly I can only blame this on a bad merge, because this in
  6139. no way worked properly the way it was written. Mea culpa. The
  6140. function should now parse its arguments correctly and function
  6141. properly. (Note that the API used by the CDR_PROP function has
  6142. working unit tests... this was merely bad coding of the actual
  6143. registered function) (closes issue ASTERISK-22613) Reported by:
  6144. Private Name
  6145. * main/cdr.c: Remove spurious event raised when CDRs are reloaded
  6146. The Reload event is now raised by the module loading core. As
  6147. such, the Reload event in the CDR engine was a duplicate and not
  6148. needed.
  6149. 2013-09-30 18:48 +0000 [r400178-400181] David M. Lee <dlee@digium.com>
  6150. * include/asterisk/stasis.h, main/devicestate.c, res/res_xmpp.c,
  6151. main/taskprocessor.c, main/sounds_index.c, main/endpoints.c,
  6152. channels/chan_iax2.c, res/res_jabber.c,
  6153. res/parking/parking_bridge_features.c, res/res_chan_stats.c,
  6154. main/cdr.c, main/manager_bridges.c, main/manager.c,
  6155. channels/chan_skinny.c, tests/test_devicestate.c,
  6156. res/res_pjsip_mwi.c, tests/test_taskprocessor.c,
  6157. tests/test_stasis.c, res/parking/parking_manager.c,
  6158. channels/chan_mgcp.c, res/res_security_log.c, main/pbx.c,
  6159. main/ccss.c, apps/app_meetme.c, include/asterisk/taskprocessor.h,
  6160. res/parking/parking_applications.c, channels/sig_pri.c,
  6161. apps/app_queue.c, main/cel.c, main/stasis.c,
  6162. channels/chan_dahdi.c, main/stasis_message_router.c,
  6163. funcs/func_presencestate.c, apps/confbridge/confbridge_manager.c,
  6164. res/res_agi.c, res/res_stasis_test.c, main/manager_channels.c,
  6165. main/manager_mwi.c, res/res_pjsip_refer.c, apps/app_voicemail.c,
  6166. main/stasis_cache.c, main/stasis_wait.c, res/stasis/app.c,
  6167. include/asterisk/stasis_internal.h, channels/chan_sip.c,
  6168. main/manager_endpoints.c: Remove dispatch object allocation from
  6169. Stasis publishing While looking for areas for performance
  6170. improvement, I realized that an unused feature in Stasis was
  6171. negatively impacting performance. When a message is sent to a
  6172. subscriber, a dispatch object is allocated for the dispatch,
  6173. containing the topic the message was published to, the subscriber
  6174. the message is being sent to, and the message itself. The topic
  6175. is actually unused by any subscriber in Asterisk today. And the
  6176. subscriber is associated with the taskprocessor the message is
  6177. being dispatched to. First, this patch removes the unused topic
  6178. parameter from Stasis subscription callbacks. Second, this patch
  6179. introduces the concept of taskprocessor local data, data that may
  6180. be set on a taskprocessor and provided along with the data
  6181. pointer when a task is pushed using the
  6182. ast_taskprocessor_push_local() call. This allows the task to have
  6183. both data specific to that taskprocessor, in addition to data
  6184. specific to that invocation. With those two changes, the dispatch
  6185. object can be removed completely, and the message is simply
  6186. refcounted and sent directly to the taskprocessor. Review:
  6187. https://reviewboard.asterisk.org/r/2884/
  6188. * main/manager_system.c, tests/test_stasis.c,
  6189. main/manager_channels.c, main/manager_mwi.c,
  6190. main/stasis_cache_pattern.c, include/asterisk/vector.h (added),
  6191. res/stasis/app.c, main/channel_internal_api.c,
  6192. include/asterisk/stasis.h, apps/app_queue.c, main/cel.c,
  6193. main/stasis.c, tests/test_stasis_endpoints.c, main/cdr.c,
  6194. main/manager_bridges.c, main/manager.c: Optimize how Stasis
  6195. forwards are dispatched This patch optimizes how forwards are
  6196. dispatched in Stasis. Originally, forwards were dispatched as
  6197. subscriptions that are invoked on the publishing thread. This did
  6198. not account for the vast number of forwards we would end up
  6199. having in the system, and the amount of work it would take to
  6200. walk though the forward subscriptions. This patch modifies Stasis
  6201. so that rather than walking the tree of forwards on every
  6202. dispatch, when forwards and subscriptions are changed, the
  6203. subscriber list for every topic in the tree is changed. This has
  6204. a couple of benefits. First, this reduces the workload of
  6205. dispatching messages. It also reduces contention when dispatching
  6206. to different topics that happen to forward to the same
  6207. aggregation topic (as happens with all of the channel, bridge and
  6208. endpoint topics). Since forwards are no longer subscriptions, the
  6209. bulk of this patch is simply changing stasis_subscription objects
  6210. to stasis_forward objects (which, admittedly, I should have done
  6211. in the first place.) Since this required me to yet again put in a
  6212. growing array, I finally abstracted that out into a set of
  6213. ast_vector macros in asterisk/vector.h. Review:
  6214. https://reviewboard.asterisk.org/r/2883/
  6215. * configure, include/asterisk/autoconfig.h.in,
  6216. configs/stasis.conf.sample (removed), include/asterisk/sem.h
  6217. (added), configure.ac, include/asterisk/stasis.h,
  6218. main/taskprocessor.c, main/sem.c (added), main/stasis.c,
  6219. main/stasis_config.c (removed), include/asterisk/taskprocessor.h:
  6220. Taskprocessor optimization; switch Stasis to use taskprocessors
  6221. This patch optimizes taskprocessor to use a semaphore for
  6222. signaling, which the OS can do a better job at managing
  6223. contention and waiting that we can with a mutex and condition.
  6224. The taskprocessor execution was also slightly optimized to reduce
  6225. the number of locks taken. The only observable difference in the
  6226. taskprocessor implementation is that when the final reference to
  6227. the taskprocessor goes away, it will execute all tasks to
  6228. completion instead of discarding the unexecuted tasks. For
  6229. systems where unnamed semaphores are not supported, a really
  6230. simple semaphore implementation is provided. (Which gives
  6231. identical performance as the original taskprocessor
  6232. implementation). The way we ended up implementing Stasis caused
  6233. the threadpool to be a burden instead of a boost to performance.
  6234. This was switched to just use taskprocessors directly for
  6235. subscriptions. Review: https://reviewboard.asterisk.org/r/2881/
  6236. 2013-09-30 15:55 +0000 [r400141] Kinsey Moore <kmoore@digium.com>
  6237. * configs/pjsip.conf.sample, res/res_pjsip_outbound_registration.c,
  6238. configs/sip.conf.sample, CHANGES, /, channels/chan_sip.c:
  6239. chan_sip: Allow Asterisk to retry after 403 on register This adds
  6240. a global option in chan_sip to allow it to continue attempting
  6241. registration if a 403 is received, clearing the cached nonce and
  6242. treating it as a non-fatal response. Normally, this would cause
  6243. registration attempts to that endpoint to stop. This also adds a
  6244. similar per-outbound-registration option to chan_pjsip which
  6245. allows the retry interval to be altered for 403 responses to
  6246. REGISTER requests. (closes issue ASTERISK-17138) Review:
  6247. https://reviewboard.asterisk.org/r/2874/ Reported by: Rudi
  6248. ........ Merged revisions 400137 from
  6249. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6250. revisions 400140 from
  6251. http://svn.asterisk.org/svn/asterisk/branches/11
  6252. 2013-09-30 15:24 +0000 [r400138] David M. Lee <dlee@digium.com>
  6253. * main/astobj2.c, main/stasis.c, main/stasis_message_router.c,
  6254. main/taskprocessor.c, include/asterisk/stasis_message_router.h,
  6255. res/res_pjsip/include/res_pjsip_private.h, tests/test_stasis.c:
  6256. Stasis performance improvements This patch addresses several
  6257. performance problems that were found in the initial performance
  6258. testing of Asterisk 12. The Stasis dispatch object was allocated
  6259. as an AO2 object, even though it has a very confined lifecycle.
  6260. This was replaced with a straight ast_malloc(). The Stasis
  6261. message router was spending an inordinate amount of time
  6262. searching hash tables. In this case, most of our routers had 6 or
  6263. fewer routes in them to begin with. This was replaced with an
  6264. array that's searched linearly for the route. We more heavily
  6265. rely on AO2 objects in Asterisk 12, and the memset() in ao2_ref()
  6266. actually became noticeable on the profile. This was #ifdef'ed to
  6267. only run when AO2_DEBUG was enabled. After being misled by an
  6268. erroneous comment in taskprocessor.c during profiling, the wrong
  6269. comment was removed. Review:
  6270. https://reviewboard.asterisk.org/r/2873/
  6271. 2013-09-28 22:56 +0000 [r400058-400121] Matthew Jordan <mjordan@digium.com>
  6272. * res/res_pjsip_notify.c, configs/pjsip_notify.conf.sample (added):
  6273. res_pjsip_notify: Add documentation We forgot to add
  6274. documentation for res_pjsip_notify, which would prevent it from
  6275. being loaded. Whoops. This patch also updates res_pjsip_notify to
  6276. use pjsip_notify.conf, which now has its own sample file in the
  6277. configs directory as well. Review:
  6278. https://reviewboard.asterisk.org/r/2835/
  6279. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Correct erroneous
  6280. lost packet information in RTCP reports RTCP's calculation of the
  6281. number of lost packets in an RTP stream is based on that stream's
  6282. sequence number count, the number of received packets, and how
  6283. many packets we expect to receive. When the SSRC for an RTP
  6284. stream changes, there can - and almost always will be - a large
  6285. jump in the next packet's timestamp and sequence number. If we
  6286. don't reset the number of received packets, sequence number
  6287. count, and other metrics used by RTCP, the next RR/SR report will
  6288. use the previous SSRC's values to calculate the lost packet count
  6289. for the new SSRC - resulting in a very large number of lost
  6290. packets. This patch modifies res_rtp_asterisk such that, if it
  6291. detects a SSRC change, it will reset the various values used by
  6292. the RTCP calculations. From the perspective of RTCP, this appears
  6293. as a new media stream - which is what it is. Review:
  6294. https://reviewboard.asterisk.org/r/2886/ (closes issue AST-1174)
  6295. Reported by: Thomas Arimont ........ Merged revisions 400089 from
  6296. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6297. revisions 400093 from
  6298. http://svn.asterisk.org/svn/asterisk/branches/11
  6299. * configure.ac, /, configure: Add check for openSUSE when detecting
  6300. bfd library In ASTERISK-17842, some additional library checks
  6301. were added to the configure script so that the bfd library could
  6302. be found on CentOS and Fedora systems. As it turns out, openSUSE
  6303. requires an additional library. This patch adds another check to
  6304. the configure script for openSUSE that will add that library.
  6305. Review: https://reviewboard.asterisk.org/r/2885/ (closes issue
  6306. AST-1169) Reported by: Guenther Kelleter ........ Merged
  6307. revisions 400073 from
  6308. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6309. revisions 400075 from
  6310. http://svn.asterisk.org/svn/asterisk/branches/11
  6311. * main/cdr.c: CDR: Improve handling of parking; resolve assertion
  6312. when originating into park This patch covers two problems: 1)
  6313. Currently, when a call is transferred into a parking lot from a
  6314. bridge (using either the blind transfer or one touch parking
  6315. mechanisms), the application fails to be set to "Park" in the
  6316. resulting CDR record for the parked channel. This is due to the
  6317. ParkedCall message arriving before the BridgeEnter for the
  6318. channel entering the parking bridge. The ParkedCall message isn't
  6319. handled as the CDR for the channel has already been finalized
  6320. (due to the channel having left its two party bridge), and the
  6321. BridgeEnter - which creates the new CDR - doesn't have the
  6322. parking information. This patch modifies the behavior so that
  6323. reception of a ParkedCall message will - if not handled by a CDR
  6324. chain - cause a new CDR to be created and put into the Parking
  6325. state. 2) It fixes a FRACK that occurred when a channel is
  6326. originated into a parking space. The DialedPending state - which
  6327. occurs for both Dialed and Originated channels - assumed that it
  6328. couldn't handle the parking transitions due to it having a Party
  6329. B; however, Originated channels don't have a Party B. As such,
  6330. the existing CDR needs to transition into the parking state -
  6331. this patch does that. Review:
  6332. https://reviewboard.asterisk.org/r/2877/ (closes issue
  6333. ASTERISK-22482) Reported by: Richard Mudgett
  6334. * apps/app_queue.c: app_queue: Make manager events tolerant of
  6335. Local channel shenanigans app_queue currently attempts to handle
  6336. Local channel optimizations in an effort to provide accurate
  6337. information in Stasis messages (and their corresponding AMI
  6338. events) as well as the Queue log. Sometimes, however, things
  6339. don't go as planned. Consider the following scenario: SIP/foo <->
  6340. L;1 <-> L;2 <-> SIP/agent SIP/agent answers, triggering a Local
  6341. channel optimization. app_queue will normally do the following: *
  6342. Listen for the Local optimization events and update our agent
  6343. accordingly to SIP/agent in the queue log and messages * When we
  6344. get a hangup, publish the AgentComplete event based on our
  6345. information (SIP/foo and SIP/agent) However, as with all things
  6346. that depend on sanity from something as capricious as Local
  6347. channels, things can go wrong: (1) SIP/agent immediately hangs up
  6348. upon answering. This triggers a race condition between
  6349. termination messages coming from SIP/agent and the ongoing Local
  6350. channel optimization messages. (Note that this can also occur
  6351. with SIP/foo) (2) In a race condition, Asterisk can (rarely)
  6352. deliver the hangup messages prior to the Local channel
  6353. optimization. In that case, the messages *may* arrive to
  6354. app_queue in the following order: * Hangup SIP/Agent * Hangup
  6355. SIP/foo * Optimize L;1/L;2 * Hangup L;2 * Hangup L;1 When
  6356. app_queue receives the hangup of the agent or the caller, it will
  6357. attempt to publish the AgentComplete event. However, it now has a
  6358. problem - it thinks its agent is the ;1 side of the Local
  6359. channel, as it never received the optimization event. At the same
  6360. time, that channel is already gone. This results in getting NULL
  6361. from the Stasis cache. What's more, we can't really wait for the
  6362. optimization message, as we are currently handling the hangup of
  6363. the channel that the optimization event would tell us to use.
  6364. This patch modifies the behavior in app_queue such that, since we
  6365. still have a lot of pertinent queue information (interface, queue
  6366. name, etc.), we now raise the event with what information we
  6367. know. The channels involved now may or may not be present. Users
  6368. will still at least get the "AgentComplete" event, which
  6369. "completes" the known Agent information. Review:
  6370. https://reviewboard.asterisk.org/r/2878/ (closes issue
  6371. ASTERISK-22507) Reported by: Richard Mudgett
  6372. * main/manager.c: manager: Fix crash when appending a manager
  6373. channel variable In r399887, a minor performance improvement was
  6374. introduced by not allocating the manager variable struct if it
  6375. wasn't used. Unfortunately, when directly accessing an
  6376. ast_channel struct, manager assumed that the struct was always
  6377. allocated. Since this was no longer the case, things got a bit
  6378. crashy. This fixes that problem by simply bypassing appending
  6379. variables if the manager channel variable struct isn't there.
  6380. 2013-09-27 21:56 +0000 [r400015-400020] Richard Mudgett <rmudgett@digium.com>
  6381. * apps/app_cdr.c, res/res_parking.c: app_cdr and res_parking: Fix
  6382. some resource leaks. * app_cdr left the ResetCDR application
  6383. registered. * res_parking leaked a ref to config global. (closes
  6384. issue ASTERISK-22566) Reported by: Corey Farrell Patches:
  6385. ASTERISK-22566-r2.patch (license #5909) patch uploaded by Corey
  6386. Farrell
  6387. * /, channels/chan_sip.c, channels/sip/reqresp_parser.c: chan_sip:
  6388. Increase some scratch buffer sizes dealing with caller id. *
  6389. Eliminated an unnecessary initialization in check_user_full().
  6390. (closes issue ASTERISK-22477) Reported by: Michael Shepelev
  6391. ........ Merged revisions 400013 from
  6392. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6393. revisions 400014 from
  6394. http://svn.asterisk.org/svn/asterisk/branches/11
  6395. 2013-09-27 18:26 +0000 [r399990] Kevin Harwell <kharwell@digium.com>
  6396. * include/asterisk/res_pjsip.h, res/res_pjsip.exports.in,
  6397. res/res_pjsip.c, res/res_pjsip_session.c: res_pjsip: crash when
  6398. using localnet and external_signaling_address options There was a
  6399. collision of mod_data use on the transaction between using a nat
  6400. hook and an session response callback. During state change it was
  6401. assumed what was in the mod_data was nothing or the response
  6402. callback. However, it was possible for it to also contain a nat
  6403. hook thus resulting in a bad cast and a crash. Added the ability
  6404. to store multiple data elements in mod_data via a hash table. In
  6405. this instance, mod_data now stores a hash table of the two values
  6406. that can be retrieved using an associated string key. (closes
  6407. issue ASTERISK-22394) Reported by: Rusty Newton Review:
  6408. https://reviewboard.asterisk.org/r/2843/
  6409. 2013-09-27 17:34 +0000 [r399976] Jonathan Rose <jrose@digium.com>
  6410. * /, channels/chan_sip.c, channels/sip/include/sip.h: chan_sip:
  6411. Reject calls on 200 OKs if no SDP has been received When Asterisk
  6412. receives a 200 OK in response to an invite, that peer should have
  6413. sent an SDP at some point by then. If the channel has never
  6414. received an SDP, media won't have been set and the remote address
  6415. won't be known. Endpoints in general should not be doing this.
  6416. This patch makes it so that Asterisk will simply hang up a call
  6417. if it sends a 200 OK at this point. So far this odd behavior for
  6418. endpoints has only been observed in tests which involved manually
  6419. created SIP transactions in SIPp. (closes issue ASTERISK-22424)
  6420. Reported by: Jonathan Rose Review:
  6421. https://reviewboard.asterisk.org/r/2827/ ........ Merged
  6422. revisions 399939 from
  6423. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6424. revisions 399962 from
  6425. http://svn.asterisk.org/svn/asterisk/branches/11
  6426. 2013-09-27 17:03 +0000 [r399937] Richard Mudgett <rmudgett@digium.com>
  6427. * include/asterisk/astobj2.h, tests/test_astobj2.c, main/astobj2.c:
  6428. astobj2: Remove OBJ_CONTINUE support. OBJ_CONTINUE was a strange
  6429. feature that came into the world under suspicious circumstances
  6430. to support an abuse of the ao2_container by chan_iax2. Since
  6431. chan_iax2 no longer uses OBJ_CONTINUE, it is safe to remove it.
  6432. The simplified code should help performance slightly and make
  6433. understanding the code easier. Review:
  6434. https://reviewboard.asterisk.org/r/2887/
  6435. 2013-09-27 14:29 +0000 [r399924] Mark Michelson <mmichelson@digium.com>
  6436. * bridges/bridge_native_rtp.c: Fix refleaks of ast_rtp_instance
  6437. structures. These refleaks were causing bridged calls not to
  6438. close their RTP ports. Thus a call would leave open 4 ports (RTP
  6439. for party A, RTCP for party A, RTP for party B, and RTCP for
  6440. party B). This led to an eventual depletion of available RTP
  6441. ports.
  6442. 2013-09-27 14:01 +0000 [r399912] Kinsey Moore <kmoore@digium.com>
  6443. * include/asterisk/cel.h, tests/test_cel.c, main/cel.c: Restore
  6444. usefulness of the CEL Peer field This change makes the CEL peer
  6445. field useful again for BRIDGE_ENTER and BRIDGE_EXIT events and
  6446. fills the field with a comma-separated list of all channels in
  6447. the bridge other than the channel that is entering or exiting the
  6448. bridge. Review: https://reviewboard.asterisk.org/r/2840/ (closes
  6449. issue ASTERISK-22393)
  6450. 2013-09-26 18:48 +0000 [r399897] Kevin Harwell <kharwell@digium.com>
  6451. * res/res_pjsip/security_events.c, res/res_pjsip_registrar.c,
  6452. include/asterisk/res_pjsip.h, res/res_pjsip.exports.in: pjsip:
  6453. race condition in registrar While handling a registration request
  6454. a race condition could occur if/when two+ clients registered at
  6455. the same time. This happened when one request obtained a copy of
  6456. the current contacts for an AOR and another request did the same
  6457. before the first request updated. Thus the second would update
  6458. and overwrite the first (or vice-versa depending on which
  6459. actually updated first). In the case of it being the same contact
  6460. two "add" events would be raised. pjsip registration handling is
  6461. now serialized to alleviate this issue. (closes issue AST-1213)
  6462. Reported by: John Bigelow Review:
  6463. https://reviewboard.asterisk.org/r/2860/
  6464. 2013-09-26 15:41 +0000 [r399887] David M. Lee <dlee@digium.com>
  6465. * main/channel.c: Minor performance bump by not allocate manager
  6466. variable struct if we don't need it
  6467. 2013-09-26 14:12 +0000 [r399874] Rusty Newton <rnewton@digium.com>
  6468. * apps/app_dial.c: Adding a few words to the Dial option 'r' help
  6469. text to clarify its tone argument description
  6470. 2013-09-25 20:36 +0000 [r399842] Richard Mudgett <rmudgett@digium.com>
  6471. * channels/sig_ss7.c, channels/chan_dahdi.c, /: chan_dahdi: CLI
  6472. "core stop gracefully" has needless delay for PRI and SS7. The
  6473. PRI and SS7 link control threads are not stopped correctly when
  6474. the chan_dahdi.so module is unloaded. The link control threads
  6475. pri_dchannel() and ss7_linkset() are not awakened from a poll()
  6476. to cancel the thread. * Added a SIGURG signal after requesting
  6477. the thread cancel to break the link control thread poll()
  6478. immediately. For SS7 it was slightly worse, the link poll()
  6479. timeout would always be whatever was the last libss7 scheduled
  6480. event time used. If no libss7 scheduled event was pending, the
  6481. thread could run more often than necessary. * Set nextms to 60
  6482. seconds for the ss7_linkset() poll() if there is no other libss7
  6483. scheduled event. ........ Merged revisions 399818 from
  6484. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6485. revisions 399834 from
  6486. http://svn.asterisk.org/svn/asterisk/branches/11
  6487. 2013-09-25 19:40 +0000 [r399798] Rusty Newton <rnewton@digium.com>
  6488. * res/res_pjsip.c: Broke the build - Fixing XML DTD violation added
  6489. in r399782, missing <para> tags inside a <note>
  6490. 2013-09-25 19:28 +0000 [r399796] Michael L. Young <elgueromexicano@gmail.com>
  6491. * /, channels/chan_sip.c: chan_sip: Fix Realtime Peer Update
  6492. Problem When Un-registering And Expires Header In 200ok 1st Issue
  6493. When a realtime peer sends an un-REGISTER request, Asterisk
  6494. un-registers the peer but the database table record still has
  6495. regseconds and fullcontact for the peer. This results in calls
  6496. attempting to be routed to the peer which is no longer
  6497. registered. The expected behavior is to get busy/congested when
  6498. attempting to call an un-registered peer through the dialplan.
  6499. What was discovered is that we are clearing out the peer's
  6500. registration in the database in parse_register_contact() when
  6501. calling expire_register() but then upon returning from
  6502. parse_register_contact(), update_peer() is run which stores back
  6503. in the database table regseconds and fullcontact. 2nd Issue The
  6504. reporter pointed out that the 200 ok being returned by Asterisk
  6505. after un-registering a peer contains a Contact header with
  6506. ;expires= and the Expires header is not set to 0. This is
  6507. actually a regression. Tests were created for this second issue
  6508. (ASTERISK-22548). The tests have been reviewed and a Ship It! was
  6509. received on those tests. This patch does the following: * Do not
  6510. ignore the Expires header value even when it is set to 0. The
  6511. patch sets the pvt->expiry earlier on in the function so that it
  6512. is set properly and used. * If pvt->expiry is 0, do not call
  6513. update_peer since that means the peer has already been
  6514. un-registered and there is no need to update the database record
  6515. again since nothing has changed. (closes issue ASTERISK-22428)
  6516. Reported by: Ben Smithurst Tested by: Ben Smithurst, Michael L.
  6517. Young Patches:
  6518. asterisk-22428-rt-peer-update-and-expires-header.diff by Michael
  6519. L. Young (license 5026) Review:
  6520. https://reviewboard.asterisk.org/r/2869/ ........ Merged
  6521. revisions 399794 from
  6522. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6523. revisions 399795 from
  6524. http://svn.asterisk.org/svn/asterisk/branches/11
  6525. 2013-09-25 18:36 +0000 [r399781] Rusty Newton <rnewton@digium.com>
  6526. * res/res_pjsip.c: Fixing documentation for the configOption
  6527. "external_media_address" of both Endpoints and Transports
  6528. Re-using some of Mark Michelson's text from an E-mail discussion
  6529. for: * Modifying synopsis for both options * Adding description
  6530. to both options * Changing name of "external_media_address" for
  6531. Endpoint configuration to "media_address" in anticipation of the
  6532. option name being changed. (As it is not really specific to
  6533. external destinations) (issue ASTERISK-22405) (closes issue
  6534. ASTERISK-22405) Reported by: Rusty Newton Review:
  6535. https://reviewboard.asterisk.org/r/2850/
  6536. 2013-09-24 22:50 +0000 [r399736-399749] Richard Mudgett <rmudgett@digium.com>
  6537. * main/astobj2.c: astobj2: Made use OBJ_SEARCH_xxx identifiers as
  6538. field enum values internally. * Made ao2_unlink to protect itself
  6539. from stray OBJ_SEARCH_xxx values passed in.
  6540. * channels/chan_iax2.c, /: chan_iax2: Prevent some needless
  6541. breaking of the native IAX2 bridge. * Clean up some twisted code
  6542. in the iax2_bridge() loop. * Add AST_CONTROL_VIDUPDATE and
  6543. AST_CONTROL_SRCCHANGE to a list of frames to prevent the native
  6544. bridge loop from breaking. * Passing the
  6545. AST_CONTROL_T38_PARAMETERS frame should also allow FAX over a
  6546. native IAX2 bridge. (issue ABE-2912) Review:
  6547. https://reviewboard.asterisk.org/r/2870/ ........ Merged
  6548. revisions 399697 from
  6549. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6550. revisions 399708 from
  6551. http://svn.asterisk.org/svn/asterisk/branches/11 For v12 and
  6552. above this is really just documentation until IAX2 native
  6553. bridging is restored.
  6554. 2013-09-24 19:22 +0000 [r399666-399695] Matthew Jordan <mjordan@digium.com>
  6555. * apps/app_queue.c: app_queue: Don't be quite so aggressive in
  6556. initializing the array We only need the first character.
  6557. * apps/app_queue.c: app_queue: Initialize array holding MixMonitor
  6558. exec options If the channel variable MONITOR_EXEC is set,
  6559. app_queue will pass the specified execution parameters to the
  6560. MixMonitor application when a queue is recorded. If that channel
  6561. variable is not set, the buffer that holds the escaped value was
  6562. not being initialized to NULL, and so would be passed to the
  6563. MixMonitor application with garbage. Hilarity ensued as
  6564. app_mixmonitor attempted to execute gobeldy-gook.
  6565. * main/cdr.c, main/stasis_bridges.c, tests/test_cdr.c: Fix a
  6566. performance problem CDRs There is a large performance price
  6567. currently in the CDR engine. We currently perform two
  6568. ao2_callback calls on a container that has an entry for every
  6569. channel in the system. This is done to create matching pairs
  6570. between channels in a bridge. As such, the portion of the CDR
  6571. logic that this patch deals with is how we make pairings when a
  6572. channel enters a mixing bridge. In general, when a channel enters
  6573. such a bridge, we need to do two things: (1) Figure out if anyone
  6574. in the bridge can be this channel's Party B. (2) Make pairings
  6575. with every other channel in the bridge that is not already our
  6576. Party B. This is a two step process. In the first step, we look
  6577. through everyone in the bridge and see if they can be our Party B
  6578. (single_state_process_bridge_enter). If they can - yay! We mark
  6579. our CDR as having gotten a Party B. If not, we keep searching. If
  6580. we don't find one, we wait until someone joins who can be our
  6581. Party B. Step 2 is where we changed the logic
  6582. (handle_bridge_pairings and bridge_candidate_process).
  6583. Previously, we would first find candidates - those channels in
  6584. the bridge with us - from the active_cdrs_by_channel container.
  6585. Because a channel could be a candidate if it was Party B to an
  6586. item in the container, the code implemented multiple
  6587. ao2_container callbacks to get all the candidates. We also had to
  6588. store them in another container with some other meta information.
  6589. This was rather complex and costly, particularly if you have 300
  6590. Local channels (600 channels!) going at once. Luckily, none of it
  6591. is needed: when a channel enters a bridge (which is when we're
  6592. figuring all this stuff out), the bridge snapshot tells us the
  6593. unique IDs of everyone already in the bridge. All we need to do
  6594. is: For all channels in the bridge: If the channel is us or our
  6595. Party B that we got in step 1, skip it Compare us and the
  6596. candidate to figure out who is Party A (based on some specific
  6597. rules) If we are Party A: Make a new CDR for us, append it to our
  6598. chain, and set the candidate as Party B If they are Party A: If
  6599. they don't have a Party B: Make a new CDR for them, append us to
  6600. their chain, and us as Party B Otherwise: Copy us over as Party B
  6601. on their existing CDR. This patch does that. Because we now use
  6602. channel unique IDs to find the candidates during bridging,
  6603. active_cdrs_by_channel now looks up things using uniqueid instead
  6604. of channel name. This makes the more complex code simpler; it
  6605. does, however, have the drawback that dialplan applications and
  6606. functions will be slightly slower as they have to iterate through
  6607. the container looking for the CDR by name. That's a small price
  6608. to pay however as the bridging code will be called a lot more
  6609. often. This patch also does two other minor changes: (1) It
  6610. reduces the container size of the channels in a bridge snapshot
  6611. to 1. In order to be predictable for multi-party bridges, the
  6612. order of the channels in the container must be stable; that is,
  6613. it must always devolve to a linked list. (2) CDRs and the
  6614. multi-party test was updated to show the relationship between two
  6615. dialed channels. You still want to know if they talked -
  6616. previously, dialed channels were always ignored, which is wrong
  6617. when they have managed to get a Party B. (closes issue
  6618. ASTERISK-22488) Reported by: Richard Mudgett Review:
  6619. https://reviewboard.asterisk.org/r/2861/
  6620. 2013-09-23 12:02 +0000 [r399624] Joshua Colp <jcolp@digium.com>
  6621. * res/res_pjsip.c, res/res_pjsip_session.c: Fix crash in res_pjsip
  6622. on load if error occurs, and prevent unloading of res_pjsip and
  6623. res_pjsip_session. During load time in res_pjsip if an error
  6624. occurred the operation would attempt to rollback all operations
  6625. done during load. This is not permitted by PJSIP as it will
  6626. assert if the operation has not been done. This fix changes the
  6627. code so it will only rollback what has been initialized already.
  6628. Further changes also prevent res_pjsip and res_pjsip_session from
  6629. being unloaded. This is due to limitations within PJSIP itself.
  6630. The library environment can only be changed to a certain extent
  6631. and does not provide the ability, currently, to deinitialize
  6632. certain required functionality. (closes issue ASTERISK-22474)
  6633. Reported by: Corey Farrell
  6634. 2013-09-21 04:48 +0000 [r399576-399607] Richard Mudgett <rmudgett@digium.com>
  6635. * res/res_rtp_asterisk.c: res_rtp_asterisk: Fix ref leaks in
  6636. ast_rtcp_read(). Moved rtcp_report RAII_VAR declaration into the
  6637. loop so it is unref'ed after every loop. Moved message_blob to
  6638. loop and switched it to a regular variable. The regular variable
  6639. was used since message_blob is used in a very contained way.
  6640. (closes issue ASTERISK-22565) Reported by: Corey Farrell Patches:
  6641. rtcp_report-leak.patch (license #5909) patch uploaded by Corey
  6642. Farrell Tested by: Corey Farrell
  6643. * main/media_index.c: media_index: Fix process_description_file()
  6644. memory leak of file_id_persist.
  6645. * main/features_config.c: features_config: Fix config ref leak of
  6646. parkinglots. This leak happend for just about every channel
  6647. created.
  6648. * apps/app_queue.c: app_queue: Fix json blob ref leak. The json ref
  6649. from queue_member_blob_create() was never released.
  6650. * main/json.c: json: Make it obvious that ast_json_unref() is NULL
  6651. safe. It looked like the safety check was done after the NULL
  6652. pointer was used.
  6653. 2013-09-20 22:41 +0000 [r399565] Kinsey Moore <kmoore@digium.com>
  6654. * main/config_options.c, /: Ensure global types in the config
  6655. framework are initialized If a config object was allocated but
  6656. one of its global objects was never encountered, then the global
  6657. object's defaults were never applied. Ensure that global objects
  6658. are initialized properly upon allocation instead of on
  6659. configuration. Review: https://reviewboard.asterisk.org/r/2866/
  6660. ........ Merged revisions 399564 from
  6661. http://svn.asterisk.org/svn/asterisk/branches/11
  6662. 2013-09-20 22:04 +0000 [r399553] Jonathan Rose <jrose@digium.com>
  6663. * main/dial.c: originate/call forwarding: Fix a crash when
  6664. forwarding a call from originate (closes issue ASTERISK-22487)
  6665. Reported by: David M. Lee Review:
  6666. https://reviewboard.asterisk.org/r/2868/
  6667. 2013-09-20 16:17 +0000 [r399531] Joshua Colp <jcolp@digium.com>
  6668. * channels/chan_pjsip.c: Add a missing session supplement
  6669. unregistration in chan_pjsip for ACKs. (closes issue
  6670. ASTERISK-22453) Reported by: Corey Farrell Patches:
  6671. chan_pjsip_session_unregister_supplement.patch uploaded by Corey
  6672. Farrell (license 5909)
  6673. 2013-09-20 14:25 +0000 [r399514] Kevin Harwell <kharwell@digium.com>
  6674. * /, main/logger.c: Fix memory leak in logger. Fixed a memory leak
  6675. discovered in the logger where a temporary string buffer was not
  6676. being freed. (closes issue ASTERISK-22540) Reported by: John
  6677. Hardin ........ Merged revisions 399513 from
  6678. http://svn.asterisk.org/svn/asterisk/branches/11
  6679. 2013-09-19 23:16 +0000 [r399501] Richard Mudgett <rmudgett@digium.com>
  6680. * main/optional_api.c: optional_api: Make always use the standard
  6681. malloc functions even with MALLOC_DEBUG.
  6682. 2013-09-19 16:53 +0000 [r399458] Jonathan Rose <jrose@digium.com>
  6683. * /, channels/chan_sip.c: chan_sip: Make direct media reinvites for
  6684. T38 put Asterisk in the media path Prior to this patch, Asterisk
  6685. would incorrectly use the previous endpoint addresses in SDP in
  6686. spite of providing its own port. T38 is never meant to be done
  6687. through directmedia and Asterisk should always be in the media
  6688. path for these streams. (closes issue ASTERISK-17273) Reported
  6689. by: Kevin Stewart (closes issue ASTERISK-18706) Reported by:
  6690. Jeremy Kister Review: https://reviewboard.asterisk.org/r/2853/
  6691. ........ Merged revisions 399456 from
  6692. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6693. revisions 399457 from
  6694. http://svn.asterisk.org/svn/asterisk/branches/11
  6695. 2013-09-18 19:59 +0000 [r399404] Kinsey Moore <kmoore@digium.com>
  6696. * main/abstract_jb.c, /: Fix jitter buffer log file creation This
  6697. adjusts '/'-to-'#' replacement to replace all instances of '/'
  6698. instead of just the first to ensure that the jitter buffer log
  6699. file gets the correct name as per Richard Kenner's suggestion.
  6700. (closes issue ASTERISK-21036) Reported by: Richard Kenner
  6701. ........ Merged revisions 399402 from
  6702. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6703. revisions 399403 from
  6704. http://svn.asterisk.org/svn/asterisk/branches/11
  6705. 2013-09-18 17:23 +0000 [r399365-399376] Matthew Jordan <mjordan@digium.com>
  6706. * /, build_tools/prep_tarball: Update prep_tarball with new
  6707. documentation files on the Asterisk wiki This will now pull both
  6708. a command reference for the version being prepared, as well as an
  6709. Admin Guide that applies to all versions of Asterisk. (issue
  6710. ASTERISK-22439) Reported by: Olle Johansson ........ Merged
  6711. revisions 399351 from
  6712. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6713. revisions 399373 from
  6714. http://svn.asterisk.org/svn/asterisk/branches/11
  6715. * bridges/bridge_softmix.c, /: Add a WARNING in bridge_softmix when
  6716. a timing module isn't loaded If bridge_softmix fails to be
  6717. created because no timing source is present in Asterisk, this
  6718. will currently fail gracefully but with (most likely) a generic
  6719. error message by whatever module tried to create the softmix
  6720. bridge. This patch adds a more explicit warning so you can
  6721. actually diagnose and fix the problem. Review:
  6722. https://reviewboard.asterisk.org/r/2857/ ........ Merged
  6723. revisions 399353 from
  6724. http://svn.asterisk.org/svn/asterisk/branches/11
  6725. 2013-09-18 14:34 +0000 [r399339] Kevin Harwell <kharwell@digium.com>
  6726. * res/res_pjsip_messaging.c: res_pjsip_messaging: Register message
  6727. technology as pjsip pjsip's message technology was being
  6728. registered as 'sip', which was causing it to not load due it
  6729. conflicting with chan_sip's registered 'sip' technology for
  6730. messaging. It now registers as 'pjsip'. However, due to this
  6731. change the "to" field for outgoing pjsip messages need to be
  6732. prefixed with 'pjsip:' instead of 'sip:'. Incoming messages to
  6733. res_pjsip_messaging will automatically have their "to" fields
  6734. altered in order to accommodate the change. Outgoing messages
  6735. also handle changing it back to 'sip' before being sent so the
  6736. pjsip library will properly handle it. (closes issue
  6737. ASTERISK-22445) Reported by: Matt Jordan Review:
  6738. https://reviewboard.asterisk.org/r/2833/
  6739. 2013-09-18 00:12 +0000 [r399294] Michael L. Young <elgueromexicano@gmail.com>
  6740. * main/features_config.c: Fix Segfault In features-config.c When
  6741. Application Has No Arguments Some applications do not require
  6742. arguments. Therefore, when parsing application maps in
  6743. features.conf, it is possible that app_data will be set to NULL.
  6744. * This patch sets app_data to "" if it is NULL. Review:
  6745. https://reviewboard.asterisk.org/r/2804
  6746. 2013-09-17 23:08 +0000 [r399283] Mark Michelson <mmichelson@digium.com>
  6747. * include/asterisk/res_pjsip.h, res/res_pjsip_sdp_rtp.c,
  6748. res/res_pjsip/pjsip_configuration.c, res/res_pjsip_t38.c: Change
  6749. the "external_media_address" PJSIP endpoint option to
  6750. "media_address". The endpoint option does not apply to
  6751. communication with external entities. Rather, the option is
  6752. applied to all communications with the endpoint. The
  6753. external_media_address transport configuration option may
  6754. override the endpoint option if it turns out that we are going to
  6755. be communicating with an external entity. Two things of note: 1)
  6756. I have not updated the XML documentation. This is being taken
  6757. care of by Rusty as part of his work on issue ASTERISK-22405 2)
  6758. This commit is likely to cause testsuite failures since there are
  6759. tests that use the external_media_address endpoint option, and
  6760. they will need to be changed over. Well, I'm planning to get that
  6761. updated ASAP after this commit. (closes issue ASTERISK-22528)
  6762. reported by Rusty Newton
  6763. 2013-09-17 18:37 +0000 [r399268] Kevin Harwell <kharwell@digium.com>
  6764. * main/asterisk.c, /, main/logger.c: Remote console: more output
  6765. discrepancies The remote console continued to have issues with
  6766. its output. In this case CLI command output would either not show
  6767. up (if verbose level = 0) or would contain verbose prefixes (if
  6768. verbose level > 0) once log messages were sent to the remote
  6769. console. The fix now now adds verbose prefix data to all new
  6770. lines contained in a verbose log string. (closes issue
  6771. ASTERISK-22450) Reported by: David Brillert (closes issue
  6772. AST-1193) Reported by: Guenther Kelleter Review:
  6773. https://reviewboard.asterisk.org/r/2825/ ........ Merged
  6774. revisions 399267 from
  6775. http://svn.asterisk.org/svn/asterisk/branches/11
  6776. 2013-09-17 17:54 +0000 [r399257] Richard Mudgett <rmudgett@digium.com>
  6777. * include/asterisk/features_config.h: Fix doxygen to use correct
  6778. units of features.conf options.
  6779. 2013-09-17 17:09 +0000 [r399237-399247] Mark Michelson <mmichelson@digium.com>
  6780. * main/features_config.c, main/bridge_basic.c: Fix other timeouts
  6781. (atxferloopdelay and atxfernoanswertimeout) to use seconds
  6782. instead of milliseconds. Thanks to Richard Mudgett for pointing
  6783. this out.
  6784. * include/asterisk/features_config.h, main/bridge_basic.c,
  6785. main/features_config.c: Switch transferdigittimeout to be
  6786. configured as seconds instead of milliseconds. This was an
  6787. unintentional consequence of the update of features.conf to use
  6788. the config framework in Asterisk 12. Thanks to Marco Signorini on
  6789. the Asterisk developers list for pointing out the problem.
  6790. 2013-09-17 14:48 +0000 [r399225] Kevin Harwell <kharwell@digium.com>
  6791. * /, apps/confbridge/conf_state_multi_marked.c: Confbridge: empty
  6792. conference not being torn down Confbridge would not properly tear
  6793. down an empty conference bridge when all users were kicked via
  6794. end_marked=yes and at least one user was also set to wait_marked.
  6795. This occurred because while end_marked users were being kicked
  6796. and at least one was also set to wait_marked then the leave
  6797. wait_marked handler would be called on that user, but there would
  6798. be no waiting user (still considered active). The waiting users
  6799. would decrement and now be negative. The conference would remain,
  6800. but be put into an inactive state. The solution was to move from
  6801. the active list to the wait list, those users with wait_marked
  6802. set right before kicking. This allows both the active and wait
  6803. users to decrement correctly and the confbridge to tear down
  6804. properly. A crashed also occurred when trying to list the
  6805. specific conference from the CLI. This happened because the
  6806. conference specified was invalid. Since the conference properly
  6807. tears down now there is no way to reference it thus alleviating
  6808. the crash as well. (closes issue ASTERISK-21859) Reported by:
  6809. Chris Gentle Review: https://reviewboard.asterisk.org/r/2848/
  6810. ........ Merged revisions 399222 from
  6811. http://svn.asterisk.org/svn/asterisk/branches/11
  6812. 2013-09-16 18:34 +0000 [r399160-399207] Richard Mudgett <rmudgett@digium.com>
  6813. * tests/test_ari_model.c: Fix module load errors for
  6814. test_ari_model.so. You cannot use a function pointer variable
  6815. with an external function from another dynamically loaded module
  6816. because data variables are always resolved even with RTLD_LAZY. *
  6817. Added wrapper functions for ast_ari_validate_int() and
  6818. ast_ari_validate_string() to use instead for the function pointer
  6819. variable. (closes issue ASTERISK-22457) Reported by: David M. Lee
  6820. * res/res_speech.exports.in, apps/app_speech_utils.c:
  6821. app_speech_utils: Fix unresolved symbol ast_speech_get_setting().
  6822. Fixes regression introduced by -r374096. * Made
  6823. res_speech.export.in export ast_* symbols instead of specific
  6824. functions. * Made app_speech_utils.c declare that it is dependent
  6825. upon res_speech. (issue ASTERISK-17136) Reported by: Richard
  6826. Kenner
  6827. * /, channels/chan_iax2.c: chan_iax2: Fix saving the wrong expiry
  6828. time in astdb. When a new IAX2 client registers, the astdb
  6829. database is updated with the value of minregexpire defined in
  6830. iax.conf instead of using the expiry time that is provided by the
  6831. client. The provided expiry time of the client is updated after
  6832. inserting the astdb entry. As a consequence, restarting or
  6833. reloading asterisk creates clients whose registration may expire
  6834. before they reregister. The clients are therefore unavailable
  6835. after minregexpire seconds until they reregister. * Move updating
  6836. of the expiry time to before inserting into the astdb. (closes
  6837. issue ASTERISK-22504) Reported by: Stefan Wachtler Patches:
  6838. chan_iax2.c.patch (license #6533) patch uploaded by Stefan
  6839. Wachtler ........ Merged revisions 399158 from
  6840. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6841. revisions 399159 from
  6842. http://svn.asterisk.org/svn/asterisk/branches/11
  6843. 2013-09-16 02:33 +0000 [r399146] Matthew Jordan <mjordan@digium.com>
  6844. * main/cdr.c: Filter internal channels out of bridge enter/leave
  6845. message handling Some channels exist merely as an implementation
  6846. detail in Asterisk, such as ConfBridge's announcer/recorder
  6847. channels. These channels should never be exposed to the outside
  6848. world, or to interfaces that report on Asterisk. We already
  6849. filter out such channels in snapshot processing; however, we
  6850. failed to filter out bridge related messages that involved these
  6851. channels. This patch filters out bridge related messages that are
  6852. for such channels. This prevents a spurious WARNING message from
  6853. being displayed when those channels move in and out of bridges.
  6854. 2013-09-13 22:05 +0000 [r399136] Richard Mudgett <rmudgett@digium.com>
  6855. * channels/chan_sip.c, res/stasis/control.c, main/bridge.c,
  6856. main/bridge_basic.c, main/core_unreal.c,
  6857. res/parking/parking_applications.c, main/core_local.c,
  6858. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  6859. include/asterisk/features.h, main/channel.c,
  6860. include/asterisk/bridge_channel.h, res/parking/parking_tests.c,
  6861. main/features.c, tests/test_cel.c, main/bridge_channel.c,
  6862. include/asterisk/bridge.h, apps/confbridge/conf_chan_announce.c,
  6863. tests/test_cdr.c, res/res_pjsip_refer.c: Restore Dial, Queue, and
  6864. FollowMe 'I' option support. The Dial, Queue, and FollowMe
  6865. applications need to inhibit the bridging initial connected line
  6866. exchange in order to support the 'I' option. * Replaced the
  6867. pass_reference flag on ast_bridge_join() with a flags parameter
  6868. to pass other flags defined by enum ast_bridge_join_flags. *
  6869. Replaced the independent flag on ast_bridge_impart() with a flags
  6870. parameter to pass other flags defined by enum
  6871. ast_bridge_impart_flags. * Since the Dial, Queue, and FollowMe
  6872. applications are now the only callers of ast_bridge_call() and
  6873. ast_bridge_call_with_flags(), changed the calling contract to
  6874. require the initial COLP exchange to already have been done by
  6875. the caller. * Made all callers of ast_bridge_impart() check the
  6876. return value. It is important. As a precaution, I also made the
  6877. compiler complain now if it is not checked. * Did some cleanup in
  6878. parking_tests.c as a result of checking the ast_bridge_impart()
  6879. return value. An independent, but associated change is: * Reduce
  6880. stack usage in ast_indicate_data() and add a dropping redundant
  6881. connected line verbose message. (closes issue ASTERISK-22072)
  6882. Reported by: Joshua Colp Review:
  6883. https://reviewboard.asterisk.org/r/2845/
  6884. 2013-09-13 20:54 +0000 [r399100] David M. Lee <dlee@digium.com>
  6885. * main/astobj2.c, /: Don't write to /tmp/refs when REF_DEBUG is not
  6886. defined. If MALLOC_DEBUG is enabled, then the debug destructor
  6887. for the container is used, which would erroneously write to
  6888. /tmp/refs. This patch only uses the debug destructor if ref_debug
  6889. is used. (closes issue ASTERISK-22536) ........ Merged revisions
  6890. 399098 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  6891. ........ Merged revisions 399099 from
  6892. http://svn.asterisk.org/svn/asterisk/branches/11
  6893. 2013-09-13 14:49 +0000 [r399083] Mark Michelson <mmichelson@digium.com>
  6894. * res/res_pjsip.c, res/res_pjsip_pubsub.c, res/res_pjsip_session.c,
  6895. include/asterisk/res_pjsip.h, res/res_pjsip.exports.in: Create
  6896. more accurate Contact headers for dialogs when we are the UAS.
  6897. (closes issue AST-1207) reported by John Bigelow Review:
  6898. https://reviewboard.asterisk.org/r/2842
  6899. 2013-09-13 14:25 +0000 [r399064] Rusty Newton <rnewton@digium.com>
  6900. * res/res_pjsip_endpoint_identifier_ip.c: Broke the build! Forgot
  6901. para tags within my description.
  6902. https://bamboo.asterisk.org/bamboo/browse/AST-ATRUNKBUILD-304
  6903. 2013-09-13 14:24 +0000 [r399059] Mark Michelson <mmichelson@digium.com>
  6904. * res/res_pjsip_outbound_authenticator_digest.c,
  6905. res/res_pjsip_authenticator_digest.c,
  6906. res/res_pjsip/config_auth.c: Change how realms are handled for
  6907. outbound authentication. With this change, if no realm is
  6908. specified in an outbound auth section, then we will simply match
  6909. the realm that was present in the 401/407 challenge. (closes
  6910. issue ASTERISK-22471) Reported by George Joseph (closes issue
  6911. ASTERISK-22386) Reported by Rusty Newton Patches:
  6912. outbound_auth_realm_v4.patch uploaded by George Joseph (License
  6913. #6322)
  6914. 2013-09-13 14:21 +0000 [r399039-399049] David M. Lee <dlee@digium.com>
  6915. * res/res_pjsip_logger.c, res/res_rtp_asterisk.c,
  6916. res/res_pjsip_log_forwarder.c (added): res_pjsip: Forward PJSIP
  6917. logging to Asterisk logging This patch uses PJSIP's
  6918. pj_log_set_log_func() to forward PJSIP's log messages to
  6919. Asterisk's logger. This is done in a new module:
  6920. res_pjsip_log_forwarder.so. This patch sets defaultenabled on the
  6921. existing res_pjsip_logger.so to no, since logging every SIP
  6922. packet seems a bit odd to do by default, and is (hopefully) less
  6923. necessary with regular PJSIP logging. It also removes
  6924. res_rtp_asterisk's disabling of PJSIP logging. (closes issue
  6925. ASTERISK-22360) Reported by: Joshua Colp Review:
  6926. https://reviewboard.asterisk.org/r/2830/
  6927. * res/res_http_websocket.c: ARI: Fix WebSocket response when
  6928. subprotocol isn't specified When I moved the ARI WebSocket from
  6929. /ws to /ari/events, I added code to allow a WebSocket to connect
  6930. without specifying the subprotocol if there's only one
  6931. subprotocol handler registered for the WebSocket. Naively, I
  6932. coded it to always respond with the subprotocol in use.
  6933. Unfortunately, according to RFC 6455, if the server's response
  6934. includes a subprotocol header field that "indicates the use of a
  6935. subprotocol that was not present in the client's handshake [...],
  6936. the client MUST _Fail the WebSocket Connection_.", emphasis
  6937. theirs. This patch correctly omits the Sec-WebSocket-Protocol if
  6938. one is not specified by the client. (closes issue ASTERISK-22441)
  6939. Review: https://reviewboard.asterisk.org/r/2828/
  6940. 2013-09-13 13:54 +0000 [r399035] Kinsey Moore <kmoore@digium.com>
  6941. * /, apps/app_meetme.c: Fix several crashes in MeetMeAdmin This
  6942. change ensures that MeetMeAdmin commands requiring a user
  6943. actually get a user and fixes another issue where an extra
  6944. dereference could occur for a last-entered user being ejected if
  6945. a user identifier was also provided. (closes issue
  6946. ASTERISK-21907) Reported by: Alex Epshteyn Review:
  6947. https://reviewboard.asterisk.org/r/2844/ ........ Merged
  6948. revisions 399033 from
  6949. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6950. revisions 399034 from
  6951. http://svn.asterisk.org/svn/asterisk/branches/11
  6952. 2013-09-13 13:27 +0000 [r399031] Rusty Newton <rnewton@digium.com>
  6953. * res/res_pjsip_endpoint_identifier_ip.c: 'identify' configObject
  6954. doesn't have a synopsis Add a straightforward synopsis and
  6955. description to the identify config object in XML documentation.
  6956. (issue ASTERISK-22311) (closes issue ASTERISK-22311) Reported By:
  6957. Rusty Newton
  6958. 2013-09-12 23:41 +0000 [r399019-399021] Richard Mudgett <rmudgett@digium.com>
  6959. * main/bridge.c: CLI bridge: Fix "bridge destroy <id>" and "bridge
  6960. kick <id> <chan>" tab completion. These two commands must deal
  6961. with the live bridges container for tab completion and not the
  6962. stasis cache.
  6963. * main/bridge.c: astobj2: Register the bridges container for debug
  6964. inspection.
  6965. 2013-09-12 23:21 +0000 [r399017] Rusty Newton <rnewton@digium.com>
  6966. * res/res_pjsip_acl.c: Documentation fix and improvements to XML
  6967. configuration help res_pjsip_acl * One bug fix. Made the synopsis
  6968. for "type" to accurate. * changing the usage of "IP-domains" to
  6969. "IP addresses" * clarifying the usage for the options, by adding
  6970. a relevant description for each * modified other areas of the XML
  6971. help for clarity, such as the module description and a few
  6972. synopsis changes here and there. See the patch. (issue
  6973. ASTERISK-22458) (closes issue ASTERISK-22458) Reported By: Rusty
  6974. Newton Review: https://reviewboard.asterisk.org/r/2823/
  6975. 2013-09-12 20:20 +0000 [r398991] Jonathan Rose <jrose@digium.com>
  6976. * /, channels/chan_sip.c, channels/sip/include/sip.h: chan_sip:
  6977. Revert r398835 due to failing tests involving originate (issue
  6978. ASTERISK-22424) Reported by: Jonathan Rose ........ Merged
  6979. revisions 398977 from
  6980. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6981. revisions 398986 from
  6982. http://svn.asterisk.org/svn/asterisk/branches/11
  6983. 2013-09-12 16:38 +0000 [r398938] Richard Mudgett <rmudgett@digium.com>
  6984. * main/core_unreal.c: core_local: Fix memory corruption race
  6985. condition. The masquerade super test is failing on v12 with high
  6986. fence violations and crashing. The fence violations are showing
  6987. that party id allocated memory strings are somehow getting
  6988. corrupted in the bridge_reconfigured_connected_line_update()
  6989. function. The invalid string values happen to be the freed memory
  6990. fill pattern. After much puzzling, I deduced that the
  6991. bridge_reconfigured_connected_line_update() is copying a string
  6992. out of the source channel's caller party id struct just as
  6993. another thread is updating it with a new value. The copying
  6994. thread is using the old string pointer being freed by the
  6995. updating thread. A search of the code found the
  6996. unreal_colp_redirect_indicate() routine updating the caller party
  6997. id's without holding the channel lock. A latent bug in v1.8 and
  6998. v11 hatched in v12 because of the bridging and connected line
  6999. changes. :) (issue ASTERISK-22221) Reported by: Matt Jordan
  7000. Review: https://reviewboard.asterisk.org/r/2839/
  7001. 2013-09-12 15:23 +0000 [r398927] David M. Lee <dlee@digium.com>
  7002. * res/res_pjsip.c: Fix symbol collision with pjsua. We shouldn't be
  7003. exporting any symbols that start with pjsip_.
  7004. 2013-09-12 00:04 +0000 [r398882-398886] Rusty Newton <rnewton@digium.com>
  7005. * apps/app_queue.c, /: 'queue add member' help text correction You
  7006. are adding dial strings to the queue, not channels. An aribitrary
  7007. string could be used, but you are typically referencing a
  7008. channel. Correcting the command help text. (issue ASTERISK-22263)
  7009. (closes issue ASTERISK-22263) Reported By: Rusty Newton ........
  7010. Merged revisions 398884 from
  7011. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7012. revisions 398885 from
  7013. http://svn.asterisk.org/svn/asterisk/branches/11
  7014. * configs/chan_dahdi.conf.sample, /: Documentation fix -
  7015. waitfordialtone is not boolean, it's time in milliseconds
  7016. Changing text in chan_dahdi.conf sample to be accurate. (issue
  7017. ASTERISK-22308) (closes issue ASTERISK-22308) Reported By:
  7018. Malcolm Davenport ........ Merged revisions 398880 from
  7019. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7020. revisions 398881 from
  7021. http://svn.asterisk.org/svn/asterisk/branches/11
  7022. 2013-09-11 19:56 +0000 [r398837] Jonathan Rose <jrose@digium.com>
  7023. * channels/sip/include/sip.h, /, channels/chan_sip.c: chan_sip:
  7024. Reject calls without prior SDP on 200 OK If we receive a 200 OK
  7025. without SDP, we will now check to see if the remote address has
  7026. been established for that channel's RTP session and if the to tag
  7027. for that channel has changed from the most recent to tag in a
  7028. response less than 200. If either a change has been made since
  7029. the last to-tag was received or the remote address is unset, then
  7030. we will drop the call. (closes issue ASTERISK-22424) Reported by:
  7031. Jonathan Rose Review:
  7032. https://reviewboard.asterisk.org/r/2827/diff/#index_header
  7033. ........ Merged revisions 398835 from
  7034. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7035. revisions 398836 from
  7036. http://svn.asterisk.org/svn/asterisk/branches/11
  7037. 2013-09-11 18:02 +0000 [r398821] Russell Bryant <russell@russellbryant.com>
  7038. * configs/confbridge.conf.sample, /: Fix typo in
  7039. confbridge.conf.sample The denoise filter requires func_speex,
  7040. not codec_speex. Fix this in the description of the denoise=yes
  7041. option in confbridge.conf. ........ Merged revisions 398820 from
  7042. http://svn.asterisk.org/svn/asterisk/branches/11
  7043. 2013-09-11 14:14 +0000 [r398806] Kevin Harwell <kharwell@digium.com>
  7044. * res/res_pjsip_caller_id.c, channels/chan_pjsip.c: pjsip: reinvite
  7045. for connected line updates occurs when it should not Connected
  7046. line updates are now only sent out if an actual update needs to
  7047. occur. This happens under the following conditions: 1. The
  7048. endpoint we are sending to is trusted. 2. Either a
  7049. P-Asserted-Identity or Remote Party-ID header needs to be
  7050. added/sent. 3. The connected id's number and name are valid. Also
  7051. added an SDP when an update is sent out. (closes issue AST-1212)
  7052. Reported by: John Bigelow Review:
  7053. https://reviewboard.asterisk.org/r/2831/
  7054. 2013-09-10 18:03 +0000 [r398759] Richard Mudgett <rmudgett@digium.com>
  7055. * res/res_musiconhold.c, main/indications.c, main/asterisk.c,
  7056. main/xmldoc.c, main/cli.c, /, funcs/func_dialgroup.c,
  7057. main/heap.c, res/res_pjsip/pjsip_configuration.c, main/event.c:
  7058. Fix incorrect usages of ast_realloc(). There are several
  7059. locations in the code base where this is done: buf =
  7060. ast_realloc(buf, new_size); This is going to leak the original
  7061. buf contents if the realloc fails. Review:
  7062. https://reviewboard.asterisk.org/r/2832/ ........ Merged
  7063. revisions 398757 from
  7064. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7065. revisions 398758 from
  7066. http://svn.asterisk.org/svn/asterisk/branches/11
  7067. 2013-09-10 17:49 +0000 [r398750-398754] David M. Lee <dlee@digium.com>
  7068. * /, utils/check_expr.c: Fixed utils directory breakage from
  7069. r398748, this time with extra hate. ........ Merged revisions
  7070. 398752 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  7071. ........ Merged revisions 398753 from
  7072. http://svn.asterisk.org/svn/asterisk/branches/11
  7073. * utils/ael_main.c, utils/conf2ael.c, utils/check_expr.c, /: Fixed
  7074. utils directory breakage from r398648 ........ Merged revisions
  7075. 398748 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  7076. ........ Merged revisions 398749 from
  7077. http://svn.asterisk.org/svn/asterisk/branches/11
  7078. 2013-09-09 23:23 +0000 [r398726] Richard Mudgett <rmudgett@digium.com>
  7079. * /, main/astmm.c: MALLOC_DEBUG: Change fence magic number to be
  7080. completely different from the freed magic number. Race conditions
  7081. between freeing a nul terminated string and ast_strdup()'ing it
  7082. are more likely to be detected if the fence and freed magic
  7083. numbers are completely different. ........ Merged revisions
  7084. 398703 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  7085. ........ Merged revisions 398721 from
  7086. http://svn.asterisk.org/svn/asterisk/branches/11
  7087. 2013-09-09 21:59 +0000 [r398694] Mark Michelson <mmichelson@digium.com>
  7088. * res/res_pjsip_endpoint_identifier_ip.c: Add extra debugging to
  7089. res_pjsip_endpoint_identifier_ip
  7090. 2013-09-09 20:12 +0000 [r398638-398651] David M. Lee <dlee@digium.com>
  7091. * main/lock.c, /, main/utils.c, include/asterisk/lock.h: Fix
  7092. DEBUG_THREADS when lock is acquired in __constructor__ This patch
  7093. fixes some long-standing bugs in debug threads that were
  7094. exacerbated with recent Optional API work in Asterisk 12. With
  7095. debug threads enabled, on some systems, there's a lock ordering
  7096. problem between our mutex and glibc's mutex protecting its module
  7097. list (Ubuntu Lucid, glibc 2.11.1 in this instance). In one
  7098. thread, the module list will be locked before acquiring our
  7099. mutex. In another thread, our mutex will be locked before locking
  7100. the module list (which happens in the depths of calling
  7101. backtrace()). This patch fixes this issue by moving backtrace()
  7102. calls outside of critical sections that have the mutex acquired.
  7103. The bigger change was to reentrancy tracking for
  7104. ast_cond_{timed,}wait, which wrongly assumed that waiting on the
  7105. mutex was equivalent to a single unlock (it actually suspends all
  7106. recursive locks on the mutex). (closes issue ASTERISK-22455)
  7107. Review: https://reviewboard.asterisk.org/r/2824/ ........ Merged
  7108. revisions 398648 from
  7109. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7110. revisions 398649 from
  7111. http://svn.asterisk.org/svn/asterisk/branches/11
  7112. * res/ari/resource_channels.h: Added note about expected behavior
  7113. of originate (the rest of the commit)
  7114. * rest-api/api-docs/channels.json: Added note about expected
  7115. behavior of originate
  7116. 2013-09-08 23:25 +0000 [r398628] Matthew Jordan <mjordan@digium.com>
  7117. * tests/test_cdr.c: Update CDR Unit tests to reflect container
  7118. changes in r398579 When a channel joins a multi-party bridge, the
  7119. ordering of the CDRs that is created is determined by the
  7120. ordering of the channels who happen to be in that bridge. When
  7121. r398579 changed the number of buckets in the container to
  7122. something sensible, it changed the ordering that the CDRs was
  7123. created in, causing one of the multiparty tests to fail. This
  7124. fixes the test with the now expected ordering.
  7125. 2013-09-07 01:02 +0000 [r398580-398619] Kinsey Moore <kmoore@digium.com>
  7126. * /, res/res_xmpp.c: Prevent XMPP timeout on blank responses
  7127. Sometimes the Google Voice servers have a bad habit of sending
  7128. out 1 byte replies to the xmpp resource. When a blank 1 byte
  7129. reply is received from the socket the buffer attempts to wait
  7130. (endlessly) for the rest of the reply from google which
  7131. effectively blocks the socket and google voice calls will no
  7132. longer come into the server. This patch allows the xmpp module to
  7133. correctly detect empty packets and send out ping replies to
  7134. google. It also sets a socket timeout on the default socket which
  7135. prevents the xmpp socket from closing and preventing future
  7136. google voice calls from coming into the server. Furthermore
  7137. instead of sending an empty reply back to google we send a proper
  7138. xmpp ping reply back. This also adds several more socket
  7139. messages. (closes issue ASTERISK-22347) Reported by: Andrew Nagy
  7140. Review: https://reviewboard.asterisk.org/r/2771 Patches:
  7141. xmpp_fix_1.diff uploaded by Andrew Nagy (License #6524) ........
  7142. Merged revisions 398618 from
  7143. http://svn.asterisk.org/svn/asterisk/branches/11
  7144. * /, res/res_xmpp.c, res/res_jabber.c: Multiple revisions
  7145. 398558,398577 ........ r398558 | kmoore | 2013-09-06 14:28:16
  7146. -0500 (Fri, 06 Sep 2013) | 17 lines Fix Jabber/XMPP distributed
  7147. MWI The mailbox and context are swapped on the receiving end for
  7148. all users of Jabber and XMPP distributed MWI in Asterisk 1.8 and
  7149. all more recent versions. This swaps those values to be correct
  7150. when publishing to the internal event system from Jabber/XMPP
  7151. distributed MWI state. (closes issue ASTERISK-22435) Reported by:
  7152. abelbeck Tested by: Michael Keuter Patches:
  7153. asterisk-1.8-res_jabber-aji_handle_pubsub_event.patch uploaded by
  7154. abelbeck asterisk-11-res_xmpp-xmpp_pubsub_handle_event.patch
  7155. uploaded by abelbeck ........ Merged revisions 398523 from
  7156. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  7157. r398577 | kmoore | 2013-09-06 16:00:56 -0500 (Fri, 06 Sep 2013) |
  7158. 10 lines Commit the remainder of r398523 This is a missing part
  7159. of the commit in revision 398523 that corrects the name of a
  7160. variable. (issue ASTERISK-22435) ........ Merged revisions 398576
  7161. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  7162. Merged revisions 398558,398577 from
  7163. http://svn.asterisk.org/svn/asterisk/branches/11
  7164. 2013-09-06 21:16 +0000 [r398579] Richard Mudgett <rmudgett@digium.com>
  7165. * main/cdr.c: cdr: Change the number of container buckets to be
  7166. similar to the channels container. * Fix the temporary cdr
  7167. candidate containers to use a prime number of buckets.
  7168. 2013-09-06 21:03 +0000 [r398578] Kinsey Moore <kmoore@digium.com>
  7169. * /: Unblock r398558
  7170. 2013-09-06 20:20 +0000 [r398533-398572] Richard Mudgett <rmudgett@digium.com>
  7171. * main/core_local.c: core_local: Fix LocalOptimizationBegin AMI
  7172. event missing Source channel snapshot. * Fix the
  7173. LocalOptimizationBegin AMI event by eliminating an artificial
  7174. buffer size limitation that is too small anyway.
  7175. * main/cdr.c: cdr: Fix some ref leaks. * Added missing unregister
  7176. of the cdr container in cdr_engine_shutdown(). * Fixed ref leak
  7177. in off nominal path of cdr_object_alloc(). * Removed some
  7178. unnecessary NULL checks in cdr_object_dtor().
  7179. * main/parking.c, main/stasis_config.c, include/asterisk/astobj2.h,
  7180. main/cel.c, main/features_config.c, apps/app_agent_pool.c,
  7181. main/cdr.c, main/udptl.c: astobj2: Add warn unused attribute to
  7182. some functions. * Fixed resulting warnings with improper use of
  7183. ao2_global_obj_replace(). * Made a couple uses of
  7184. ao2_global_obj_replace_unref(x, NULL) into the equivalent and
  7185. more appropriate ao2_global_obj_release() call.
  7186. 2013-09-06 18:49 +0000 [r398511-398521] Kinsey Moore <kmoore@digium.com>
  7187. * res/stasis/app.c, main/http.c: Fix build warnings When
  7188. AST_DEVMODE is not defined, ast_asserts are not compiled into the
  7189. binary. In some cases, this means variables are not referenced or
  7190. are set but unused which causes warnings to show up. (closes
  7191. issue ASTERISK-22446) Reported by: Jason Parker (qwell)
  7192. * channels/chan_h323.c, /: Fix chan_h323 compilation This fixes the
  7193. things in chan_h323 that were missed or ignored in the great
  7194. channel opaquification and gets chan_h323 back into a compiling
  7195. state. (closes issue ASTERISK-22365) Reported by: Dmitry Melekhov
  7196. Patches: chan_h323.patch uploaded by Dmitry Melekhov ........
  7197. Merged revisions 398510 from
  7198. http://svn.asterisk.org/svn/asterisk/branches/11
  7199. 2013-09-05 21:46 +0000 [r398381-398498] Richard Mudgett <rmudgett@digium.com>
  7200. * main/astobj2.c: astobj2: Only define ao2_bt() once. * Make
  7201. ao2_bt() not use single char variable names. * Fix ao2_bt()
  7202. formatting.
  7203. * channels/chan_iax2.c, /: chan_iax2: Reduce indentation in
  7204. __attempt_transmit(). * Reduce indentation in
  7205. __attempt_transmit(). * Don't update the static last error time
  7206. variable every time in __schedule_action() and socket_read().
  7207. ........ Merged revisions 398456 from
  7208. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7209. revisions 398457 from
  7210. http://svn.asterisk.org/svn/asterisk/branches/11
  7211. * channels/chan_iax2.c, /: chan_iax2: Fix stray reference to worker
  7212. thread idle_list. * Fix stray reference to idle_list in
  7213. cleanup_thread_list(). This may be the reason for the note in
  7214. iax2_process_thread() about threads not being removed from the
  7215. task lists. * Move cleanup_thread_list(&idle_list) to after the
  7216. other lists are cleaned up. ........ Merged revisions 398416 from
  7217. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7218. revisions 398417 from
  7219. http://svn.asterisk.org/svn/asterisk/branches/11
  7220. * channels/chan_iax2.c, /: chan_iax2: Fix bridgecallno deadlock
  7221. avoidance. * Fix bridgecallno deadlock avoidance. When doing
  7222. deadlock avoidance, you need to retest the status of values for
  7223. each loop to see if you still need the lock for bridgecallno. *
  7224. As a safety check, after acquiring the bridgecallno lock you
  7225. should check if iaxs[bridgecallno] is NULL just like the current
  7226. callno checks. * Move setting thread->iostate to IAX_IOSTATE_IDLE
  7227. to after processing any deferred frames to ensure that the
  7228. iostate is IDLE when it is placed back into the idle list.
  7229. defer_full_frame() tries to ensure iax2_process_thread() wakes up
  7230. to process the frame. ........ Merged revisions 398379 from
  7231. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7232. revisions 398380 from
  7233. http://svn.asterisk.org/svn/asterisk/branches/11
  7234. 2013-09-05 14:09 +0000 [r398368] Mark Michelson <mmichelson@digium.com>
  7235. * res/res_pjsip_outbound_registration.c: Clarify server_uri and
  7236. client_uri registration settings. Used some of Rusty's suggested
  7237. language plus also included more SIPesque descriptions of where
  7238. the URIs are actually used in an outgoing REGISTER. (closes issue
  7239. ASTERISK-22390) reported by Rusty Newton
  7240. 2013-09-04 23:06 +0000 [r398303] Richard Mudgett <rmudgett@digium.com>
  7241. * channels/iax2/parser.c, /: chan_iax2: Add missing control frame
  7242. names to debug frame decode output. ........ Merged revisions
  7243. 398301 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  7244. ........ Merged revisions 398302 from
  7245. http://svn.asterisk.org/svn/asterisk/branches/11
  7246. 2013-09-04 22:28 +0000 [r398299] Mark Michelson <mmichelson@digium.com>
  7247. * res/res_pjsip_outbound_authenticator_digest.c: Give more detail
  7248. regarding failures to create request with auth credentials.
  7249. (issue ASTERISK-22386)
  7250. 2013-09-04 21:36 +0000 [r398283-398286] Jonathan Rose <jrose@digium.com>
  7251. * /, tests/test_voicemail_api.c: unit tests: test_voicemail_api
  7252. leaks stringfields from snapshots (closes issue ASTERISK-22414)
  7253. Reported by: Corey Farrell Patches:
  7254. test_voicemail_api-leaks-11.patch uploaded by coreyfarrell
  7255. (license 5909) ........ Merged revisions 398285 from
  7256. http://svn.asterisk.org/svn/asterisk/branches/11
  7257. * apps/app_voicemail.c, /: app_voicemail: Fix leaking config
  7258. objects when msg_id doesn't match (issues ASTERISK-22414)
  7259. Reported by: Corey Farrell Patch:
  7260. test_voicemail_api-leaks-11.patch uploaded by coreyfarrell
  7261. (license 5909) ........ Merged revisions 398281 from
  7262. http://svn.asterisk.org/svn/asterisk/branches/11
  7263. 2013-09-04 16:00 +0000 [r398237] Richard Mudgett <rmudgett@digium.com>
  7264. * channels/chan_misdn.c, /: chan_misdn: Fix misdn debug output
  7265. printed with arbitrary verbose levels. Fix the misdn debug output
  7266. to remote consoles. chan_misdn uses ast_console_puts() which
  7267. doesn't know about verbose levels. Better to use ast_verbose()
  7268. instead. Without this patch the misdn debug messages are appended
  7269. to the verbose level which ever was set by the message sent to
  7270. the console before, i.e. any undefined level. (closes issue
  7271. AST-1218) Reported by: Guenther Kelleter Patches: misdnlog.patch
  7272. (license #6372) patch uploaded by Guenther Kelleter ........
  7273. Merged revisions 398235 from
  7274. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7275. revisions 398236 from
  7276. http://svn.asterisk.org/svn/asterisk/branches/11
  7277. 2013-09-04 14:29 +0000 [r398226] Kevin Harwell <kharwell@digium.com>
  7278. * res/res_pjsip_outbound_registration.c: Debug messages for pjsip
  7279. outbound registration Added debug messages indicating that an
  7280. outbound registration attempt was made and it was successful in
  7281. pjsip. (closes issue ASTERISK-22388) Reported by: Rusty Newton
  7282. 2013-09-03 19:49 +0000 [r398215] Alexandr Anikin <may@telecom-service.ru>
  7283. * /, addons/ooh323c/src/ooh245.c: Fix remote tcs sequence handling
  7284. on empty tcs received ........ Merged revisions 398214 from
  7285. http://svn.asterisk.org/svn/asterisk/branches/11
  7286. 2013-09-03 18:08 +0000 [r398206] Kinsey Moore <kmoore@digium.com>
  7287. * res/res_pjsip_dtmf_info.c: Prevent a crash in
  7288. res_pjsip_dtmf_info.c This change makes sure that a content type
  7289. header exists before checking the contents of the header against
  7290. known SIP INFO DTMF content types.
  7291. 2013-09-03 14:36 +0000 [r398198] David M. Lee <dlee@digium.com>
  7292. * Makefile: Fixed 'make clean' for wiki docs
  7293. 2013-09-03 14:27 +0000 [r398196] Walter Doekes <walter+asterisk@wjd.nu>
  7294. * /, cel/cel_custom.c: Be a little more verbose when loading
  7295. cel_custom.conf. Review: https://reviewboard.asterisk.org/r/2805/
  7296. ........ Merged revisions 398167 from
  7297. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7298. revisions 398168 from
  7299. http://svn.asterisk.org/svn/asterisk/branches/11
  7300. 2013-08-30 20:58 +0000 [r398149] David M. Lee <dlee@digium.com>
  7301. * main/optional_api.c, main/asterisk.c,
  7302. include/asterisk/optional_api.h: Fix graceful shutdown crash. The
  7303. cleanup code for optional_api needs to happen after all of the
  7304. optional API users and providers have unused/unprovided.
  7305. Unfortunately, regsitering the atexit() handler at the beginning
  7306. of main() isn't soon enough, since module destructors run after
  7307. that.
  7308. 2013-08-30 20:34 +0000 [r398147] Rusty Newton <rnewton@digium.com>
  7309. * configs/pjsip.conf.sample: New pjsip.conf.sample (issue
  7310. ASTERISK-22145) (closes issue ASTERISK-22145) Reported By: Matt
  7311. Jordan Review: https://reviewboard.asterisk.org/r/2811/
  7312. 2013-08-30 19:51 +0000 [r398116-398139] Kevin Harwell <kharwell@digium.com>
  7313. * include/asterisk/sorcery.h, res/res_pjsip.c,
  7314. res/res_pjsip/config_transport.c, main/sorcery.c,
  7315. res/res_pjsip_outbound_registration.c: Add a reloadable option
  7316. for sorcery type objects Some configuration objects currently
  7317. won't place nice if reloaded. Specifically, in this case the
  7318. pjsip transport objects. Now when registering an object in
  7319. sorcery one may specify that the object is allowed to be reloaded
  7320. or not. If the object is set to not reload then upon reloading of
  7321. the configuration the objects of that type will not be reloaded.
  7322. The initially loaded objects of that type however will remain.
  7323. While the transport objects will not longer be reloaded it is
  7324. still possible for a user to configure an endpoint to an invalid
  7325. transport. A couple of log messages were added to help diagnose
  7326. this problem if it occurs. (closes issue ASTERISK-22382) Reported
  7327. by: Rusty Newton (closes issue ASTERISK-22384) Reported by: Rusty
  7328. Newton Review: https://reviewboard.asterisk.org/r/2807/
  7329. * main/translate.c, main/named_acl.c, main/indications.c,
  7330. main/config.c, res/res_security_log.c, /, channels/chan_sip.c:
  7331. Fix various memory leaks main/config.c - cleanup cache fie
  7332. includes res/res_security_log.c - unregister logger level
  7333. channesl/chan_sip.c - cleanup io context and notify_types
  7334. main/translator.c - cleanup at shutdown main/named_acl.c -
  7335. cleanup cli commands main/indications.c -
  7336. ast_get_indication_tone() unref default_tone_zone if used (closes
  7337. issues ASTERISK-22378) Reported by: Corey Farrell Patches:
  7338. config_shutdown.patch uploaded by coreyfarrell (license 5909)
  7339. res_security_log.patch uploaded by coreyfarrell (license 5909)
  7340. chan_sip-11.patch uploaded by coreyfarrell (license 5909)
  7341. indications_refleak.patch uploaded by coreyfarrell (license 5909)
  7342. named_acl-cli_unreg-trunk.patch uploaded by coreyfarrell (license
  7343. 5909) translate_shutdown.patch uploaded by coreyfarrell (license
  7344. 5909) ........ Merged revisions 398102 from
  7345. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7346. revisions 398103 from
  7347. http://svn.asterisk.org/svn/asterisk/branches/11
  7348. 2013-08-30 18:35 +0000 [r398100] Matthew Jordan <mjordan@digium.com>
  7349. * UPGRADE.txt: Update UPGRADE.txt file for Asterisk 12 This simply
  7350. pulls in the changes that were breaking from the CHANGES file and
  7351. updates a few other areas accordingly. It also removes the 10 =>
  7352. 11 notes, which are traditionally removed from each major version
  7353. and stored in the appropriate UPGRADE-X.txt file.
  7354. 2013-08-30 18:18 +0000 [r398068] Jonathan Rose <jrose@digium.com>
  7355. * main/config_options.c, main/features_config.c: features_config:
  7356. Ignore parkinglots in features.conf instead of failing to load
  7357. Parkinglots are defined in res_features.conf now, but this patch
  7358. fixes features_config so that features don't fail to load when
  7359. parkinglots are present in features.conf Review:
  7360. https://reviewboard.asterisk.org/r/2801/
  7361. 2013-08-30 17:57 +0000 [r398062] Kevin Harwell <kharwell@digium.com>
  7362. * main/manager.c, /, res/res_agi.c: Memory leak fix
  7363. ast_xmldoc_printable returns an allocated block that must be
  7364. freed by the caller. Fixed manager.c and res_agi.c to stop
  7365. leaking these results. (closes issue ASTERISK-22395) Reported by:
  7366. Corey Farrell Patches: manager-leaks-12.patch uploaded by
  7367. coreyfarrell (license 5909) res_agi-xmldoc-leaks.patch uploaded
  7368. by coreyfarrell (license 5909) ........ Merged revisions 398060
  7369. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  7370. Merged revisions 398061 from
  7371. http://svn.asterisk.org/svn/asterisk/branches/11
  7372. 2013-08-30 17:10 +0000 [r398023-398025] Richard Mudgett <rmudgett@digium.com>
  7373. * tests/test_substitution.c: test_substitution: Fix failing test.
  7374. Revert the -r392190 change. The original test was correct. The
  7375. CDR code was actually returning an unititialized buffer.
  7376. * /, tests/test_substitution.c: test_substituition: Fix failed test
  7377. reporting to actually report failure. You cannot put the "Testing
  7378. <blah> pass/fail" on a single line before actually performing the
  7379. test. Now any additional failure information is logged before the
  7380. test pass/fail announcement. * Added an additional CDR(answer,u)
  7381. test. ........ Merged revisions 398018 from
  7382. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7383. revisions 398019 from
  7384. http://svn.asterisk.org/svn/asterisk/branches/11
  7385. 2013-08-30 16:57 +0000 [r398020] Jonathan Rose <jrose@digium.com>
  7386. * main/udptl.c, main/features_config.c: features_config: Don't
  7387. require features.conf to be present for Asterisk to load (closes
  7388. issue ASTERISK-22426) Reported by: Matt Jordan Review:
  7389. https://reviewboard.asterisk.org/r/2806/
  7390. 2013-08-30 16:26 +0000 [r398002-398016] Kevin Harwell <kharwell@digium.com>
  7391. * apps/app_mixmonitor.c, /: Fix memory leaks (closes issue
  7392. ASTERISK-22368) Reported by: Corey Farrell Patches:
  7393. issueA22368_mixmonitor_free_filename.patch uploaded by wdoekes
  7394. (license 5674) ........ Merged revisions 398004 from
  7395. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  7396. revisions 398011 from
  7397. http://svn.asterisk.org/svn/asterisk/branches/11
  7398. * main/asterisk.c, /: Check return value on fwrite ........ Merged
  7399. revisions 398000 from
  7400. http://svn.asterisk.org/svn/asterisk/branches/11
  7401. 2013-08-30 13:39 +0000 [r397985-397989] David M. Lee <dlee@digium.com>
  7402. * build_tools/cflags.xml, configure, res/res_ari_events.c,
  7403. include/asterisk/http_websocket.h, main/optional_api.c (added),
  7404. rest-api-templates/swagger_model.py, res/ari/ari_websockets.c,
  7405. main/asterisk.c, channels/sip/include/sip.h, res/res_ari.c,
  7406. tests/test_optional_api.c (added), channels/chan_sip.c,
  7407. include/asterisk/autoconfig.h.in, configure.ac,
  7408. rest-api-templates/res_ari_resource.c.mustache,
  7409. res/ari/internal.h, res/res_http_websocket.c, CHANGES,
  7410. include/asterisk/compiler.h, include/asterisk/ari.h,
  7411. main/loader.c, include/asterisk/optional_api.h: optional_api: Fix
  7412. linking problems between modules that export global symbols With
  7413. the new work in Asterisk 12, there are some uses of the
  7414. optional_api that are prone to failure. The details are rather
  7415. involved, and captured on [the wiki][1]. This patch addresses the
  7416. issue by removing almost all of the magic from the optional API
  7417. implementation. Instead of relying on weak symbol resolution, a
  7418. new optional_api.c module was added to Asterisk core. For modules
  7419. providing an optional API, the pointer to the implementation
  7420. function is registered with the core. For modules that use an
  7421. optional API, a pointer to a stub function, along with a
  7422. optional_ref function pointer are registered with the core. The
  7423. optional_ref function pointers is set to the implementation
  7424. function when it's provided, or the stub function when it's now.
  7425. Since the implementation no longer relies on magic, it is now
  7426. supported on all platforms. In the spirit of choice, an
  7427. OPTIONAL_API flag was added, so we can disable the optional_api
  7428. if needed (maybe it's buggy on some bizarre platform I haven't
  7429. tested on) The AST_OPTIONAL_API*() macros themselves remained
  7430. unchanged, so existing code could remain unchanged. But to help
  7431. with debugging the optional_api, the patch limits the #include of
  7432. optional API's to just the modules using the API. This also
  7433. reduces resource waste maintaining optional_ref pointers that
  7434. aren't used. Other changes made as a part of this patch: * The
  7435. stubs for http_websocket that wrap system calls set errno to
  7436. ENOSYS. * res_http_websocket now properly increments module use
  7437. count. * In loader.c, the while() wrappers around dlclose() were
  7438. removed. The while(!dlclose()) is actually an anti-pattern, which
  7439. can lead to infinite loops if the module you're attempting to
  7440. unload exports a symbol that was directly linked to. * The
  7441. special handling of nonoptreq on systems without weak symbol
  7442. support was removed, since we no longer rely on weak symbols for
  7443. optional_api. [1]: https://wiki.asterisk.org/wiki/x/wACUAQ
  7444. (closes issue ASTERISK-22296) Reported by: Matt Jordan Review:
  7445. https://reviewboard.asterisk.org/r/2797/
  7446. * res/stasis_recording (added), res/ari/resource_recordings.c,
  7447. res/ari/ari_model_validators.h, res/res_ari_recordings.c,
  7448. res/res_stasis_playback.c,
  7449. include/asterisk/stasis_app_recording.h,
  7450. res/ari/resource_recordings.h, res/res_stasis_recording.c,
  7451. res/Makefile, res/ari/ari_model_validators.c,
  7452. rest-api/api-docs/recordings.json: ARI: Implement
  7453. /recordings/stored API's his patch implements the ARI API's for
  7454. stored recordings. While the original task only specified
  7455. deleting a recording, it was simple enough to implement the GET
  7456. for all recordings, and for an individual recording. The
  7457. recording playback operation was modified to use the same code
  7458. for accessing the recording as the REST API, so that they will
  7459. behave consistently. There were several problems with the
  7460. api-docs that were also fixed, bringing the ARI spec in line with
  7461. the implementation. There were some 'wishful thinking' fields on
  7462. the stored recording model (duration and timestamp) that were
  7463. removed, because I ended up not implementing a metadata file to
  7464. go along with the recording to store such information. The GET
  7465. /recordings/live operation was removed, since it's not really
  7466. that useful to get a list of all recordings that are currently
  7467. going on in the system. (At least, if we did that, we'd probably
  7468. want to also list all of the current playbacks. Which seems
  7469. weird.) (closes issue ASTERISK-21582) Review:
  7470. https://reviewboard.asterisk.org/r/2693/
  7471. 2013-08-30 01:19 +0000 [r397975-397977] Richard Mudgett <rmudgett@digium.com>
  7472. * main/pbx.c: pbx.c: Make pbx_substitute_variables_helper_full()
  7473. not mask variables.
  7474. * main/pbx.c, tests/test_substitution.c, funcs/func_cdr.c: Revert
  7475. last commit.
  7476. * funcs/func_cdr.c, main/pbx.c, tests/test_substitution.c: pbx.c:
  7477. Make ast_str_substitute_variables_full() not mask variables.
  7478. 2013-08-30 00:10 +0000 [r397960-397968] Mark Michelson <mmichelson@digium.com>
  7479. * res/res_pjsip_pidf.c: Sanitize XML output for PIDF bodies.
  7480. PJSIP's PIDF API does not replace angle brackets with their
  7481. appropriate counterparts for XML. So we have to do it ourself. In
  7482. this particular case, the problem had to do with attempting to
  7483. place an unsanitized SIP URI into an XML node. Now we don't get a
  7484. 488 from recipients of our PIDF NOTIFYs.
  7485. * res/res_pjsip_pidf.c: Fix method for creating activities string
  7486. in PIDF bodies. The previous method did not allocate enough space
  7487. to create the entire string, but adjusted the string's slen value
  7488. to be larger than the actual allocation. This resulted in garbled
  7489. text in NOTIFY requests from Asterisk. This method allocates the
  7490. proper amount of space first and then writes the content into the
  7491. buffer.
  7492. 2013-08-29 22:45 +0000 [r397958] Kevin Harwell <kharwell@digium.com>
  7493. * apps/app_verbose.c, main/asterisk.c, channels/chan_misdn.c, /,
  7494. apps/app_dumpchan.c, main/logger.c: Verbose logging discrepancies
  7495. Refactored cases where a combination of
  7496. ast_verbose/options_verbose were present. Also in general tried
  7497. to eliminate, in as many places as possible, where the
  7498. options_verbose global variable was being used. Refactored the
  7499. way local and remote consoles handle verbose message logging in
  7500. an attempt to solve the various discrepancies that sometimes
  7501. would show between the two. (closes issue AST-1193) Reported by:
  7502. Guenther Kelleter Review:
  7503. https://reviewboard.asterisk.org/r/2798/ ........ Merged
  7504. revisions 397948 from
  7505. http://svn.asterisk.org/svn/asterisk/branches/11
  7506. 2013-08-29 22:24 +0000 [r397955] Mark Michelson <mmichelson@digium.com>
  7507. * res/res_pjsip_pubsub.c: Fix when the subscription_terminated
  7508. callback is called for subscription handlers. The previous
  7509. placement would result in the resubscribe() callback called
  7510. instead of the subscription_terminated() callback being called
  7511. when a subscription was ended via a SUBSCRIBE request. This would
  7512. result in confusing PJSIP and having it throw an assertion.
  7513. 2013-08-29 21:34 +0000 [r397946] Kevin Harwell <kharwell@digium.com>
  7514. * main/cel.c, main/asterisk.c, main/cdr.c, main/manager.c,
  7515. main/stasis_config.c, main/file.c, main/app.c,
  7516. main/config_options.c: Memory leaks fix (closes ASTERISK-22376)
  7517. Reported by: John Hardin Patches: memleak.patch uploaded by
  7518. jhardin (license 6512) memleak2.patch uploaded by jhardin
  7519. (license 6512)
  7520. 2013-08-29 21:33 +0000 [r397945] Mark Michelson <mmichelson@digium.com>
  7521. * res/res_pjsip_session.c: Fix a race condition where a canceled
  7522. call was answered. RFC 5407 section 3.1.2 details a scenario
  7523. where a UAC sends a CANCEL at the same time that a UAS sends a
  7524. 200 OK for the INVITE that the UAC is canceling. When this
  7525. occurs, it is the role of the UAC to immediately send a BYE to
  7526. terminate the call. This scenario was reproducible by have a
  7527. Digium phone with two lines place a call to a second phone that
  7528. forwarded the call to the second line on the original phone. The
  7529. Digium phone, upon realizing that it was connecting to itself,
  7530. would attempt to cancel the call. The timing of this happened to
  7531. trigger the aforementioned race condition about 80% of the time.
  7532. Asterisk was not doing its job of sending a BYE when receiving a
  7533. 200 OK on a cancelled INVITE. The result was that the ast_channel
  7534. structure was destroyed but the underlying SIP session, as well
  7535. as the PJSIP inv_session and dialog, were still alive. Attempting
  7536. to perform an action such as a transfer, once in this state,
  7537. would result in Asterisk crashing. The circumstances are now
  7538. detected properly and the session is ended as recommended in RFC
  7539. 5407. (closes issue AST-1209) reported by John Bigelow
  7540. 2013-08-29 20:21 +0000 [r397938] Matthew Jordan <mjordan@digium.com>
  7541. * CHANGES, contrib/scripts/safe_asterisk, Makefile,
  7542. configs/safe_asterisk.conf.sample (removed): Revert r394939 due
  7543. to (numerous) objections The patch from ASTERISK-21965 was
  7544. committed perhaps a bit too hastily. Walter and Tzafrir have
  7545. pointed out numerous issues with the approach and have propsed an
  7546. alternative in r/2757. Since it's not a time critical issue and
  7547. is not worth holding up the release of 12 for it, I've gone ahead
  7548. and reverted r394939 from 12/trunk and re-opened ASTERISK-21965.
  7549. 2013-08-29 16:18 +0000 [r397927] David M. Lee <dlee@digium.com>
  7550. * rest-api-templates/asterisk_processor.py,
  7551. rest-api-templates/make_ari_stubs.py,
  7552. rest-api-templates/api.wiki.mustache: Account for {} in Swagger
  7553. notes
  7554. 2013-08-29 16:04 +0000 [r397924] Matthew Jordan <mjordan@digium.com>
  7555. * Makefile: Recursively search for '.c' files when making
  7556. documentation with 'make full' Without this, documentation
  7557. defined in sub-folders is ignored. Since having properly
  7558. generated documentation is especially important in Asterisk 12 -
  7559. not having it can cause a module to not load - 'make full' needs
  7560. to look in all .c files.
  7561. 2013-08-29 15:42 +0000 [r397921-397922] Mark Michelson <mmichelson@digium.com>
  7562. * main/cel.c: Remove extra debug message.
  7563. * apps/app_queue.c, main/cel.c, main/stasis_bridges.c: Resolve
  7564. assumptions that bridge snapshots would be non-NULL for transfer
  7565. stasis events. Attempting to transfer an unbridged call would
  7566. result in crashes in either CEL code or in the conversion to AMI
  7567. messages.
  7568. 2013-08-29 12:27 +0000 [r397911] Matthew Jordan <mjordan@digium.com>
  7569. * contrib/ast-db-manage/README.md (added),
  7570. contrib/ast-db-manage/config/versions (added),
  7571. contrib/ast-db-manage/voicemail/versions/a2e9769475e_create_tables.py
  7572. (added), contrib/ast-db-manage (added),
  7573. contrib/ast-db-manage/voicemail/versions (added),
  7574. contrib/ast-db-manage/config.ini.sample (added),
  7575. contrib/ast-db-manage/config/env.py (added),
  7576. contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py
  7577. (added), contrib/ast-db-manage/config (added),
  7578. contrib/ast-db-manage/config/script.py.mako (added),
  7579. contrib/ast-db-manage/voicemail.ini.sample (added),
  7580. contrib/ast-db-manage/voicemail/env.py (added),
  7581. contrib/ast-db-manage/voicemail (added),
  7582. contrib/ast-db-manage/voicemail/script.py.mako (added): Actually
  7583. *add* the database schema management utilities In r397874, the
  7584. scripts were removed... but not replaced. Thanks to Michael Young
  7585. for noticing this!
  7586. 2013-08-28 23:14 +0000 [r397885-397902] Richard Mudgett <rmudgett@digium.com>
  7587. * main/stdtime/localtime.c, main/cdr.c, funcs/func_cdr.c: Fix some
  7588. uninitialized buffers for CDR handling valgrind found. * Made
  7589. ast_strftime_locale() ensure that the output buffer is
  7590. initialized. The std library strftime() returns 0 and does not
  7591. touch the buffer if it has an error. However, the function can
  7592. also return 0 without an error. (closes issue ASTERISK-22412)
  7593. Reported by: rmudgett
  7594. * main/cdr.c: Fixed problems with ast_cdr_serialize_variables(). *
  7595. Fixed return value of ast_cdr_serialize_variables() on error. It
  7596. needs to return 0 indicating no CDR variables found. * Made
  7597. ast_cdr_serialize_variables() check the return value of
  7598. cdr_object_format_property() and assert if nonzero. A member of
  7599. the cdr_readonly_vars[] was not handled. * Removed unused
  7600. elements from cdr_readonly_vars[]: total_duration, total_billsec,
  7601. first_start, and first_answer.
  7602. * main/cdr.c: Made the on/off in CLI "cdr set debug [on|off]" case
  7603. insensitive.
  7604. * main/cdr.c: Make CDR variable name chandling consistently case
  7605. insensitive.
  7606. * main/cdr.c: Make CDR code deal with channel names case
  7607. insensitively.
  7608. * funcs/func_cdr.c, main/cdr.c: Some CDR code optimization.
  7609. * funcs/func_cdr.c: Whitespace and curly braces.
  7610. 2013-08-28 21:05 +0000 [r397876] Mark Michelson <mmichelson@digium.com>
  7611. * res/res_pjsip_refer.c: Improve detection of answer on SIP blind
  7612. transfer. A problem encountered during testing was that
  7613. res_pjsip_refer would not ever send a NOTIFY with a 200 OK
  7614. sipfrag. This is because the framehook that was supposed to send
  7615. the NOTIFY would never be told that an answer had occurred. This
  7616. happened for two reasons: 1) The transferee channel on which the
  7617. framehook was on was already up. 2) Answers are rarely if ever
  7618. written to channels. Rather, the ast_answer() or ast_raw_answer()
  7619. function is used to answer channels. Thanks to a suggestion by
  7620. Matt Jordan, the best way to detect that the call had been
  7621. answered was to find out when the transferee channel joined a
  7622. bridge. With stasis this is an easy task. So now, in addition to
  7623. the framehook logic, there is a stasis subscription used to
  7624. determine when the transferee has entered a bridge. Once it has
  7625. entered, an appropriate NOTIFY is sent.
  7626. 2013-08-28 20:55 +0000 [r397870-397874] Matthew Jordan <mjordan@digium.com>
  7627. * contrib/realtime/mysql/voicemail_messages.sql,
  7628. contrib/realtime/postgresql/realtime.sql,
  7629. contrib/realtime/mysql/voicemail_data.sql, CHANGES,
  7630. contrib/realtime/mysql/musiconhold.sql,
  7631. contrib/realtime/mysql/queue_log.sql,
  7632. contrib/realtime/mysql/voicemail.sql,
  7633. contrib/realtime/mysql/sippeers.sql,
  7634. contrib/realtime/mysql/iaxfriends.sql,
  7635. contrib/realtime/mysql/meetme.sql: Add database schema management
  7636. using Alembic This patch replaces contrib/realtime/ with a new
  7637. setup for managing the database schema required for database
  7638. integration with Asterisk. In addition to initializing a database
  7639. with the proper schema, alembic can do a database migration to
  7640. assist with upgrading Asterisk in the future. Hopefully this
  7641. helps make setting up and operating Asterisk with a database
  7642. easier. With this the schema only needs to be maintained in one
  7643. place instead of once per database. The schemas I have added here
  7644. have a bit of improvement over the examples that were there
  7645. before (some added consistency and added some missing indexes).
  7646. Managing the schema in one place here also applies to all
  7647. databases supported by SQLAlchemy. See
  7648. contrib/ast-db-manage/README.md for more details. Review:
  7649. https://reviewboard.asterisk.org/r/2731 patch by Russell Bryant
  7650. (license 6300)
  7651. * CHANGES: Update CHANGES file for Asterisk 12 This updates the
  7652. Asterisk 12 CHANGES file with the things that were missed during
  7653. the development cycle. Review:
  7654. https://reviewboard.asterisk.org/r/2795/
  7655. 2013-08-28 16:12 +0000 [r397856-397859] Richard Mudgett <rmudgett@digium.com>
  7656. * main/pbx.c: pbx.c: Make ast_str_substitute_variables_full() not
  7657. mask variables.
  7658. * include/asterisk/threadstorage.h: Match use of ast_free() with
  7659. ast_calloc() and add some curly braces.
  7660. 2013-08-28 15:40 +0000 [r397854] Mark Michelson <mmichelson@digium.com>
  7661. * res/res_pjsip/pjsip_distributor.c: Fix dialog matching in the SIP
  7662. distributor. Dialog matching is performed in the distributor for
  7663. the sole purpose of retrieving an associated serializer so the
  7664. request may be serialized. This patch fixes two problems. First,
  7665. incoming CANCEL requests that had no to-tag (which really should
  7666. be *all* CANCEL requests) would not match with a dialog. An
  7667. earlier bug fix to deal with early CANCEL requests would result
  7668. in the CANCEL being replied to with a 481. The fix for this is to
  7669. find the matching INVITE transaction and get the dialog from that
  7670. transaction. Second, no SIP responses were matching dialogs. This
  7671. is because we were inverting the tags that we were passing into
  7672. PJSIP's dialog finding function. This logic has been corrected by
  7673. setting local and remote tag variables based on whether the
  7674. incoming message is a request or response.
  7675. 2013-08-27 19:15 +0000 [r397816] David M. Lee <dlee@digium.com>
  7676. * res/res_ari_bridges.c, res/stasis/app.c, res/res_ari_events.c,
  7677. res/res_ari_asterisk.c,
  7678. rest-api-templates/res_ari_resource.c.mustache, res/stasis/app.h,
  7679. res/res_stasis.c, main/stasis_bridges.c,
  7680. rest-api-templates/param_parsing.mustache: ARI: WebSocket event
  7681. cleanup Stasis events (which get distributed over the ARI
  7682. WebSocket) are created by subscribing to the channel_all_cached
  7683. and bridge_all_cached topics, filtering out events for
  7684. channels/bridges currently subscribed to. There are two issues
  7685. with that. First was a race condition, where messages in-flight
  7686. to the master subscribe-to-all-things topic would get sent out,
  7687. even though the events happened before the channel was put into
  7688. Stasis. Secondly, as the number of channels and bridges grow in
  7689. the system, the work spent filtering messages becomes excessive.
  7690. Since r395954, individual channels and bridges have caching
  7691. topics, and can be subscribed to individually. This patch takes
  7692. advantage, so that channels and bridges are subscribed to on
  7693. demand, instead of filtering the global topics. The one case
  7694. where filtering is still required is handling BridgeMerge
  7695. messages, which are published directly to the bridge_all topic.
  7696. Other than the change to how subscriptions work, this patch
  7697. mostly just moves code around. Most of the work generating JSON
  7698. objects from messages was moved to .to_json handlers on the
  7699. message types. The callback functions handling app subscriptions
  7700. were moved from res_stasis (b/c they were global to the model) to
  7701. stasis/app.c (b/c they are local to the app now). (closes issue
  7702. ASTERISK-21969) Reported by: Matt Jordan Review:
  7703. https://reviewboard.asterisk.org/r/2754/
  7704. 2013-08-27 18:49 +0000 [r397809] Richard Mudgett <rmudgett@digium.com>
  7705. * main/astmm.c: Made MALLOC_DEBUG less CPU intensive by default.
  7706. Storing a backtrace for each allocation in anticipation of a
  7707. memory management problem is very CPU intensive. * Added the CLI
  7708. "memory backtrace {on|off}" command to request that the backtrace
  7709. be gathered only on request. The backtrace is off by default.
  7710. (issue ASTERISK-22221) Reported by: Matt Jordan
  7711. 2013-08-27 18:05 +0000 [r397759] Matthew Jordan <mjordan@digium.com>
  7712. * /, channels/chan_sip.c: AST-2013-005: Fix crash caused by invalid
  7713. SDP If the SIP channel driver processes an invalid SDP that
  7714. defines media descriptions before connection information, it may
  7715. attempt to reference the socket address information even though
  7716. that information has not yet been set. This will cause a crash.
  7717. This patch adds checks when handling the various media
  7718. descriptions that ensures the media descriptions are handled only
  7719. if we have connection information suitable for that media. Thanks
  7720. to Walter Doekes, OSSO B.V., for reporting, testing, and
  7721. providing the solution to this problem. (closes issue
  7722. ASTERISK-22007) Reported by: wdoekes Tested by: wdoekes patches:
  7723. issueA22007_sdp_without_c_death.patch uploaded by wdoekes
  7724. (License 5674) ........ Merged revisions 397756 from
  7725. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7726. revisions 397757 from
  7727. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  7728. revisions 397758 from
  7729. http://svn.asterisk.org/svn/asterisk/branches/11
  7730. 2013-08-27 16:47 +0000 [r397745] Richard Mudgett <rmudgett@digium.com>
  7731. * channels/chan_dahdi.c, channels/sig_analog.c, /,
  7732. channels/chan_sip.c, channels/chan_motif.c, channels/chan_iax2.c,
  7733. channels/sig_pri.c, channels/sig_ss7.c: Fix uninitialized value
  7734. in struct ast_control_pvt_cause_code usage. ........ Merged
  7735. revisions 397744 from
  7736. http://svn.asterisk.org/svn/asterisk/branches/11
  7737. 2013-08-27 16:03 +0000 [r397690-397713] Matthew Jordan <mjordan@digium.com>
  7738. * /, channels/chan_sip.c: AST-2013-004: Fix crash when handling ACK
  7739. on dialog that has no channel A remote exploitable crash
  7740. vulnerability exists in the SIP channel driver if an ACK with SDP
  7741. is received after the channel has been terminated. The handling
  7742. code incorrectly assumed that the channel would always be
  7743. present. This patch adds a check such that the SDP will only be
  7744. parsed and applied if Asterisk has a channel present that is
  7745. associated with the dialog. Note that the patch being applied was
  7746. modified only slightly from the patch provided by Walter Doekes
  7747. of OSSO B.V. (closes issue ASTERISK-21064) Reported by: Colin
  7748. Cuthbertson Tested by: wdoekes, Colin Cutherbertson patches:
  7749. issueA21064_fix.patch uploaded by wdoekes (License 5674) ........
  7750. Merged revisions 397710 from
  7751. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7752. revisions 397711 from
  7753. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  7754. revisions 397712 from
  7755. http://svn.asterisk.org/svn/asterisk/branches/11
  7756. * main/bridge_channel.c: Better handle clearing the OUTGOING flag
  7757. when a channel leaves a bridge When a channel with the OUTGOING
  7758. flag leaves a bridge, and it will survive being pulled from the
  7759. bridge (either because it will execute dialplan, go into another
  7760. bridge, or live in a friendly autoloop), we have to clear the
  7761. OUTGOING flag. This is the signal to the CDR engine that this
  7762. channel is no longer a second class citizen, i.e., it is not
  7763. "dialed". The soft hangup flags are only half the picture. If a
  7764. channel is being moved from one bridge to another, the soft
  7765. hangup flags aren't set; however, the state of the bridge_channel
  7766. will not be hung up. Since the channel does not have one of the
  7767. two hang up states, that implies that the channel is still
  7768. technically alive. This patch modifies the check so that it
  7769. checks both the soft hangup flags as well as the bridge_channel
  7770. state. If either suggests that the channel is going to persist,
  7771. we clear the OUTGOING flag.
  7772. 2013-08-26 21:30 +0000 [r397673] David M. Lee <dlee@digium.com>
  7773. * main/bucket.c: Fixed bucket.c for systems where tv_usec is not an
  7774. unsigned long.
  7775. 2013-08-26 16:24 +0000 [r397643-397650] Richard Mudgett <rmudgett@digium.com>
  7776. * include/asterisk/bridge_channel.h, main/bridge_channel.c:
  7777. bridging: Fix a livelock with local channel optimization. Use a
  7778. better means of waking up the bridge channel thread.
  7779. * channels/Makefile: chan_dahdi: Add some missing build cleanup.
  7780. 2013-08-25 18:12 +0000 [r397621-397630] Matthew Jordan <mjordan@digium.com>
  7781. * tests/test_bucket.c: Fix bucket unit tests After the review for
  7782. buckets was completed (r2715), the handling of names in the
  7783. bucket core was deferred to the wizards. As such, the bucket unit
  7784. tests cannot expect that passing a URI with a scheme specified
  7785. but no actual resource name will automatically fail. The tests
  7786. have been updated to not make this check.
  7787. * include/asterisk/config_options.h, main/config_options.c,
  7788. tests/test_config.c: Fix the config_options_test The config
  7789. options test requires the entire configuration item to be
  7790. transparent from the documentation system. So we let it do that
  7791. too. As an aside, please do not use this power for evil.
  7792. Documentation is your friend, and you really should document your
  7793. configurations. Hiding your module's configuration information
  7794. from the system attempting to enforce some sanity in the universe
  7795. is something only a Bond villain would contemplate.
  7796. * res/res_pjsip/pjsip_configuration.c: Add rtpengine configuration
  7797. parameter The rtpengine configuration parameter was documented in
  7798. the XML documentation, but it was not actually registered with
  7799. the sorcery object. This adds the parameter with a default of
  7800. "asterisk", such that res_rtp_asterisk is chosen as the default
  7801. RTP implementation. (closes issue ASTERISK-22380) Reported by:
  7802. Rusty Newton Tested by: Rusty Newton
  7803. 2013-08-23 22:36 +0000 [r397614] Matthew Jordan <mjordan@digium.com>
  7804. * / (added): __________ | \ |_______ | | | ______| | / | _ _ _ _ _
  7805. | _______| / \ ___| |_ ___ _ __(_)___| | __ / || | / _ \ / __|
  7806. __/ _ \ '__| / __| |/ / | || |_______ / ___ \__ \| | __/ | | \__
  7807. \ < | || | /_/ \_\___/\__\___|_| |_|___/_|\_\ |_| \__________|
  7808. 2013-08-23 22:20 +0000 [r397613] Joshua Colp <jcolp@digium.com>
  7809. * main/bucket.c: Fix building of trunk. Note: This is why I commit
  7810. on the weekend.
  7811. 2013-08-23 22:12 +0000 [r397606] Matthew Jordan <mjordan@digium.com>
  7812. * main/pbx.c: Fix channel reference leak in Originated channels
  7813. When originating channels, ast_pbx_outgoing_* caused the dialed
  7814. channel reference to be bumped twice. Ostensibly, this routine is
  7815. bumping the channel lifetime such that the channel doesn't get
  7816. nuked in between locks/unlocks; however, since the routine should
  7817. return the dialed channel with its reference bumped, it only
  7818. needs to do this one time.
  7819. 2013-08-23 21:53 +0000 [r397603] Mark Michelson <mmichelson@digium.com>
  7820. * res/res_pjsip.c: Add some clarifying documentation to the
  7821. rewrite_contact endpoint option.
  7822. 2013-08-23 21:51 +0000 [r397602] Richard Mudgett <rmudgett@digium.com>
  7823. * main/bridge_channel.c: Blank line tweaks.
  7824. 2013-08-23 21:49 +0000 [r397599-397600] Joshua Colp <jcolp@digium.com>
  7825. * makeopts.in, main/asterisk.c, include/asterisk/bucket.h (added),
  7826. main/sorcery.c, include/asterisk/config_options.h,
  7827. tests/test_bucket.c (added), build_tools/menuselect-deps.in,
  7828. configure, include/asterisk/autoconfig.h.in, main/Makefile,
  7829. main/bucket.c (added), configure.ac, main/config_options.c: Add
  7830. the bucket API. Bucket is a URI based API for the creation,
  7831. retrieval, updating, and deletion of "buckets" and files
  7832. contained within them. Review:
  7833. https://reviewboard.asterisk.org/r/2715/
  7834. * include/asterisk/sorcery.h: Fix a bug where the argc value was
  7835. passed as no_doc when registering custom sorcery types. This also
  7836. adds a _nodoc equivalent.
  7837. 2013-08-23 21:02 +0000 [r397593] Mark Michelson <mmichelson@digium.com>
  7838. * main/bridge_channel.c: Add test events necessary for bridge tests
  7839. to pass in the test suite. (closes issue AST-1200) reported by
  7840. John Bigelow Review: https://reviewboard.asterisk.org/r/2790/
  7841. 2013-08-23 20:14 +0000 [r397585] Matthew Jordan <mjordan@digium.com>
  7842. * main/stasis_channels.c: Fix error in using
  7843. ast_channel_snapshot_type before initialization Starting Asterisk
  7844. would kick back an ERROR message stating that the Stasis message
  7845. type ast_channel_snapshot_type was used prior to initialization.
  7846. This occurred due to the caching topic being created prior to the
  7847. message type that it depended on. This patch re-orders the start
  7848. up such that the message type is initialized prior to the caching
  7849. topic. It also checks the return value of the initialization of
  7850. the agent login/logoff types.
  7851. 2013-08-23 19:05 +0000 [r397578] Jonathan Rose <jrose@digium.com>
  7852. * bridges/bridge_native_rtp.c: bridge_native_rtp: Fix hold chain
  7853. bugs caused by native RTP bridge framehook Issuing hold/unhold
  7854. would lead to odd behavior. Between two chan_sip devices, a hold
  7855. could cause an endless chain of updates while with pjsip a
  7856. similar chain would begin but then end somewhat randomly. This
  7857. patch fixes that by no longer tweaking the RTP glue on both sides
  7858. of the call for every HOLD/UNHOLD/UPDATE_RTP_PEER frame. (issue
  7859. ASTERISK-22217) Reported by: Matt Jordan Review:
  7860. https://reviewboard.asterisk.org/r/2794/
  7861. 2013-08-23 18:33 +0000 [r397577] Richard Mudgett <rmudgett@digium.com>
  7862. * include/asterisk/bridge_channel.h, main/channel_internal_api.c,
  7863. bridges/bridge_builtin_interval_features.c,
  7864. include/asterisk/channel.h, res/res_musiconhold.c,
  7865. main/bridge_channel.c, main/channel.c,
  7866. include/asterisk/bridge_channel_internal.h, main/bridge.c: Handle
  7867. DTMF and hold wrapup when a channel leaves the bridging system.
  7868. DTMF start/end and hold/unhold events have state because a DTMF
  7869. begin event and hold event must be ended by something. The
  7870. following cases need to be handled when a channel is moved around
  7871. in the system. * When a channel leaves a bridge it may owe a DTMF
  7872. end event to the bridge. * When a channel leaves a bridge it may
  7873. owe an UNHOLD event to the bridge. (This case is explicitly
  7874. ignored because things like transfers need explicit control over
  7875. this.) * When a channel leaves the bridging system it may need to
  7876. simulate a DTMF end event to the channel. * When a channel leaves
  7877. the bridging system it may need to simulate an UNHOLD event to
  7878. the channel. The patch also fixes the following: * Fixes playing
  7879. a file and restarting MOH using the latest MOH class used.
  7880. (closes issue ASTERISK-22043) Reported by: Matt Jordan Review:
  7881. https://reviewboard.asterisk.org/r/2791/
  7882. 2013-08-23 18:10 +0000 [r397571] Matthew Jordan <mjordan@digium.com>
  7883. * tests/test_sorcery_realtime.c, tests/test_sorcery_astdb.c,
  7884. tests/test_sorcery.c: Fix sorcery unit tests When strict XML
  7885. documentation checking was re-enabled, the test objects used in
  7886. sorcery would fail to register as the types were not marked
  7887. internal and the nodoc option wasn't used for the options. This
  7888. fixes that problem, such that, as one would hope, they once again
  7889. pass.
  7890. 2013-08-23 18:07 +0000 [r397570] Richard Mudgett <rmudgett@digium.com>
  7891. * include/asterisk/utils.h, include/asterisk/astmm.h, /,
  7892. main/backtrace.c, main/logger.c, main/utils.c,
  7893. include/asterisk/lock.h, main/astmm.c, channels/sig_pri.c,
  7894. main/astobj2.c, include/asterisk/backtrace.h, main/lock.c: Fix
  7895. memory corruption when trying to get "core show locks". Review
  7896. https://reviewboard.asterisk.org/r/2580/ tried to fix the
  7897. mismatch in memory pools but had a math error determining the
  7898. buffer size and didn't address other similar memory pool
  7899. mismatches. * Effectively reverted the previous patch to go in
  7900. the same direction as trunk for the returned memory pool of
  7901. ast_bt_get_symbols(). * Fixed memory leak in ast_bt_get_symbols()
  7902. when BETTER_BACKTRACES is defined. * Fixed some formatting in
  7903. ast_bt_get_symbols(). * Fixed sig_pri.c freeing memory allocated
  7904. by libpri when MALLOC_DEBUG is enabled. * Fixed
  7905. __dump_backtrace() freeing memory from ast_bt_get_symbols() when
  7906. MALLOC_DEBUG is enabled. * Moved __dump_backtrace() because of
  7907. compile issues with the utils directory. (closes issue
  7908. ASTERISK-22221) Reported by: Matt Jordan Review:
  7909. https://reviewboard.asterisk.org/r/2778/ ........ Merged
  7910. revisions 397525 from
  7911. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7912. revisions 397528 from
  7913. http://svn.asterisk.org/svn/asterisk/branches/11
  7914. 2013-08-23 18:02 +0000 [r397568] Matthew Jordan <mjordan@digium.com>
  7915. * main/config_options.c: Prevent seg fault in off nominal path when
  7916. registered option fails to validate If an option is registered to
  7917. a type and it is the last known type in the list of registered
  7918. types, and the option fails to register, an overrun of the types
  7919. array can occur due to the index variable having been already
  7920. incremented.
  7921. 2013-08-23 17:45 +0000 [r397567] Kevin Harwell <kharwell@digium.com>
  7922. * contrib/scripts/sip_to_res_sip/sip_to_res_sip.py,
  7923. contrib/scripts/sip_to_res_sip/astconfigparser.py,
  7924. contrib/scripts/sip_to_res_sip/astdicts.py: PSJIP - sip.conf to
  7925. res_sip.conf script Most, if not all, of the backing features of
  7926. a conf file should now be implemented (e.g. multi-line comments,
  7927. includes, templates, etc...). A few of the options still need to
  7928. be mapped. Those are currently listed in the 'sip_to_res_sip.py'
  7929. file. Things to do: (1) There is more work to do here, at least
  7930. for the sip.conf items that aren't currently parsed. An issue
  7931. will be created for that. (2) All of the scripts should probably
  7932. be passed through pylint and have as many PEP8 issues fixed as
  7933. possible. (3) A public review is probably warranted at that point
  7934. of the entire script. Reported by: Matt Jordan
  7935. 2013-08-23 17:19 +0000 [r397565] David M. Lee <dlee@digium.com>
  7936. * rest-api/api-docs/bridges.json, res/ari/resource_bridges.c,
  7937. res/res_ari_bridges.c, res/stasis/control.c,
  7938. include/asterisk/stasis_app.h,
  7939. include/asterisk/stasis_app_impl.h: ARI: Correct error codes for
  7940. bridge operations This patch adds error checking to ARI bridge
  7941. operations, when adding/removing channels to/from bridges. In
  7942. general, the error codes fall out as follows: * Bridge not found
  7943. - 404 Not Found * Bridge not in Stasis - 409 Conflict * Channel
  7944. not found - 400 Bad Request * Channel not in Stasis - 422
  7945. Unprocessable Entity * Channel not in this bridge (on remove) -
  7946. 422 Unprocessable Entity (closes issue ASTERISK-22036) Review:
  7947. https://reviewboard.asterisk.org/r/2769/
  7948. 2013-08-23 15:49 +0000 [r397524-397527] Matthew Jordan <mjordan@digium.com>
  7949. * CHANGES: Update CHANGES file to reflect pass through support for
  7950. Opus/VP8
  7951. * channels/chan_sip.c, res/res_pjsip_sdp_rtp.c,
  7952. include/asterisk/opus.h (added), include/asterisk/format.h,
  7953. channels/chan_pjsip.c, res/res_format_attr_opus.c (added),
  7954. main/channel.c, main/format.c, res/res_rtp_asterisk.c,
  7955. main/frame.c, main/rtp_engine.c: Add pass through support for
  7956. Opus and VP8; Opus format attribute negotiation This patch adds
  7957. pass through support for Opus and VP8. That includes: * Format
  7958. attribute negotiation for Opus. Note that unlike some other
  7959. codecs, the draft RFC specifies having spaces delimiting the
  7960. attributes in addition to ';', so you have "attra=X; attrb=Y".
  7961. This broke the attribute parsing in chan_sip, so a small tweak
  7962. was also included in this patch for that. * A format attribute
  7963. negotiation module for Opus, res_format_attr_opus * Fast picture
  7964. update for VP8. Since VP8 uses a different RTCP packet number
  7965. than FIR, this really is specific to VP8 at this time. Note that
  7966. the format attribute negotiation in res_pjsip_sdp_rtp was written
  7967. by mjordan. The rest of this patch was written completely by
  7968. Lorenzo Miniero. Review: https://reviewboard.asterisk.org/r/2723/
  7969. (closes issue ASTERISK-21981) Reported by: Tzafrir Cohen patches:
  7970. asterisk_opus+vp8_passthrough_20130718.patch uploaded by lminiero
  7971. (License 6518)
  7972. * main/sorcery.c, include/asterisk/config_options.h,
  7973. include/asterisk/sorcery.h, res/res_pjsip/pjsip_configuration.c,
  7974. main/config_options.c, main/features_config.c,
  7975. res/res_pjsip/pjsip_options.c, res/res_pjsip.c: Update config
  7976. framework/sorcery with types/options without documentation There
  7977. are times when a configuration option should not have
  7978. documentation. 1. Some options are registered with a particular
  7979. object merely as a warning to users. These options aren't even
  7980. really 'deprecated' - which has its own separate API call - they
  7981. are actually provided by a different configuration file. The
  7982. options are merely registered so that the user gets a warning
  7983. that a different configuration file provides the item. 2. Some
  7984. object types - most notably some used by modules that use sorcery
  7985. - are completely internal and should never be shown to the user.
  7986. 3. Sorcery itself has several 'hidden' fields that should never
  7987. be shown to a user. This patch updates the configuration
  7988. framework and sorcery with additional API calls that allow a
  7989. module to register types as internal and options as not requiring
  7990. documentation. This bypasses the XML documentation checking. This
  7991. patch also re-enables the strict XML documentation checking in
  7992. trunk, as well as updates some documentation that was missing.
  7993. Review: https://reviewboard.asterisk.org/r/2785/ (closes issue
  7994. ASTERISK-22359) Reported by: Matt Jordan (closes issue
  7995. ASTERISK-22112) Reported by: Rusty Newton
  7996. 2013-08-23 13:58 +0000 [r397515] Joshua Colp <jcolp@digium.com>
  7997. * channels/chan_pjsip.c: Fix crash when answering after a transport
  7998. error occurs. If a response to an initial incoming INVITE results
  7999. in a transport error the INVITE transaction is removed from the
  8000. INVITE session. Any attempts to answer the INVITE session after
  8001. this results in a crash as it requires the INVITE transaction to
  8002. exist. This change explicitly locks the dialog and checks to
  8003. ensure that the INVITE transaction exists before answering.
  8004. (closes issue AST-1203) Reported by: John Bigelow
  8005. 2013-08-23 13:18 +0000 [r397514] Kinsey Moore <kmoore@digium.com>
  8006. * configs/cel.conf.sample: Update CEL sample config
  8007. 2013-08-23 00:26 +0000 [r397505] Jonathan Rose <jrose@digium.com>
  8008. * res/res_stasis.c, rest-api/api-docs/bridges.json,
  8009. res/ari/resource_bridges.c, res/res_ari_bridges.c,
  8010. res/ari/resource_bridges.h, include/asterisk/stasis_app.h: ARI:
  8011. Music on Hold/Background Music for bridges Adds ARI functions to
  8012. be able to turn on/off music on hold in a bridge. It actually
  8013. functions more as a background music without further actions on
  8014. the bridge since if the rest of the channels in the bridge aren't
  8015. explicitly muted, they will still be able to communicate. (closes
  8016. issue ASTERISK-21974) Reported by: Matt Jordan Review:
  8017. https://reviewboard.asterisk.org/r/2688/
  8018. 2013-08-22 23:15 +0000 [r397494] Richard Mudgett <rmudgett@digium.com>
  8019. * apps/app_followme.c, main/channel.c, bridges/bridge_holding.c:
  8020. Minor tweaks with ast_moh_start() callers.
  8021. 2013-08-22 22:33 +0000 [r397493] Kinsey Moore <kmoore@digium.com>
  8022. * include/asterisk/say.h, apps/app_voicemail.c, main/channel.c,
  8023. main/pbx.c, main/say.c, res/res_agi.c, CHANGES,
  8024. apps/app_directory.c, apps/app_chanspy.c: Add SayAlphaCase and
  8025. similar functionality for AGI This adds a new dialplan
  8026. application, SayAlphaCase, that performs much the same function
  8027. as SayAlpha except that it takes additional options which allow
  8028. the user to specify whether the case of each letter should be
  8029. announced for uppercase, lowercase, or all letters. Similar
  8030. functionality has been added to the SAY ALPHA AGI command via an
  8031. optional parameter. Original Patch by: Kevin Scott Adams Reported
  8032. by: Kevin Scott Adams Review:
  8033. https://reviewboard.asterisk.org/r/2725/ (closes issue
  8034. ASTERISK-20782)
  8035. 2013-08-22 22:09 +0000 [r397484] Kevin Harwell <kharwell@digium.com>
  8036. * res/res_pjsip.c, res/res_pjsip_dtmf_info.c: res_sip_dtmf_info:
  8037. Support sending of 'raw' DTMF Added the ability to handle 'raw'
  8038. DTMF within the body of an INFO message. Also made it so values
  8039. 10-16 are mapped to valid DTMF values. (closes issue
  8040. ASTERISK-22144) Reported by: Matt Jordan Review:
  8041. https://reviewboard.asterisk.org/r/2776/
  8042. 2013-08-22 21:39 +0000 [r397483] Kinsey Moore <kmoore@digium.com>
  8043. * res/res_pjsip.c: Add missing configOption close tags
  8044. 2013-08-22 21:29 +0000 [r397482] Richard Mudgett <rmudgett@digium.com>
  8045. * include/asterisk/musiconhold.h: Update MOH start/stop routine
  8046. doxygen.
  8047. 2013-08-22 21:21 +0000 [r397481] Rusty Newton <rnewton@digium.com>
  8048. * res/res_pjsip.c: Fix missing xml doc configOption 'type' for for
  8049. both 'system' and 'global' configObjects (issue ASTERISK-22344)
  8050. (closes issue ASTERISK-22344)
  8051. 2013-08-22 21:09 +0000 [r397472] Richard Mudgett <rmudgett@digium.com>
  8052. * include/asterisk/bridge_channel.h, main/features.c,
  8053. bridges/bridge_builtin_interval_features.c,
  8054. include/asterisk/bridge_internal.h, apps/app_confbridge.c,
  8055. main/bridge_channel.c, res/res_stasis.c,
  8056. include/asterisk/bridge.h, apps/app_dial.c, main/bridge.c,
  8057. main/bridge_basic.c, apps/app_bridgewait.c,
  8058. res/parking/parking_applications.c,
  8059. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  8060. res/res_parking.c, bridges/bridge_builtin_features.c: Bridge API:
  8061. Set a cause code on a channel when it is ejected from a bridge.
  8062. The cause code needs to be passed from the disconnecting channel
  8063. to the bridge peers if the disconnecting channel dissolves the
  8064. bridge. * Made the call to an app_agent_pool agent disconnect
  8065. with the busy cause code if the agent does not ack the call in
  8066. time or hangs up before acking the call. (closes issue
  8067. ASTERISK-22042) Reported by: Matt Jordan Review:
  8068. https://reviewboard.asterisk.org/r/2772/
  8069. 2013-08-22 20:29 +0000 [r397471] Kinsey Moore <kmoore@digium.com>
  8070. * main/cel.c: Ensure CEL creates a default config if it isn't
  8071. provided with one
  8072. 2013-08-22 20:18 +0000 [r397466] Mark Michelson <mmichelson@digium.com>
  8073. * apps/app_queue.c: Remove set but unused variable 'meid'.
  8074. 2013-08-22 19:52 +0000 [r397461] Kinsey Moore <kmoore@digium.com>
  8075. * main/cel.c: Fix crash when getting CEL config
  8076. 2013-08-22 18:52 +0000 [r397441-397451] Mark Michelson <mmichelson@digium.com>
  8077. * include/asterisk/core_unreal.h, include/asterisk/features.h,
  8078. include/asterisk/app.h, main/bridge.c, main/bridge_basic.c,
  8079. main/features.c, main/app.c, main/core_local.c, CHANGES,
  8080. apps/app_queue.c, include/asterisk/bridge_basic.h: Massively
  8081. clean up app_queue. This essentially makes app_queue usable
  8082. again. From reviewboard: * Reporting of transfers and call
  8083. completion is done by creating stasis subscriptions and listening
  8084. for specific events in order to determine when the call is
  8085. finished (either via a transfer or hangup). * Dial end messages
  8086. have been added where they were previously missing. * Queue stats
  8087. are properly being updated again once calls have finished. *
  8088. AgentComplete stasis messages and AMI events are now occurring
  8089. again. * Mixmonitor starting has been factored into its own
  8090. function and uses the Mixmonitor API now instead of using
  8091. ast_pbx_run() In addition to the changes in app_queue, there are
  8092. several supplementary changes as well: * Queue logging now
  8093. differentiates between attended and blind transfers. A note about
  8094. this is in the CHANGES file. * Local channel optimization events
  8095. now report more information. This includes which of the two local
  8096. channels involved is the destination of the optimization, the
  8097. channel that is replacing the destination local channel, and an
  8098. identifier so that begin and end events can be matched to each
  8099. other. The end events are now sent whether the optimization was
  8100. successful or not and includes an indicator of whether the
  8101. optimization was successful. * Changes were made to features and
  8102. bridging_basic so that additional flags may be set on a bridge.
  8103. This is necessary because the queue requires that its bridge only
  8104. allows move-swap local channel optimizations into the bridge.
  8105. (closes issue ASTERISK-21517) Reported by Matt Jordan (closes
  8106. issue ASTERISK-21943) Reported by Matt Jordan Review:
  8107. https://reviewboard.asterisk.org/r/2694
  8108. * res/res_pjsip_exten_state.c, include/asterisk/res_pjsip_pubsub.h,
  8109. res/res_pjsip_mwi.c, res/res_pjsip_pubsub.c: Handle default body
  8110. types for SIP event packages in res_pjsip_pubsub Prior to this
  8111. change, we would reject SUBSCRIBE requests that had no Accept
  8112. headers. Now event package handlers that handle the default type
  8113. for the event package indicate that they do so. Therefore, if we
  8114. have a handler that can handle the default type, we can allow
  8115. SUBSCRIBEs for the handler's event package that have no Accept
  8116. headers. (closes issue ASTERISK-22067) reported by Mark Michelson
  8117. Review: https://reviewboard.asterisk.org/r/2774
  8118. 2013-08-22 17:34 +0000 [r397440] Richard Mudgett <rmudgett@digium.com>
  8119. * main/bridge_channel.c, main/abstract_jb.c: Made the abstract
  8120. jitter buffer resync on some more control frames. Resync the
  8121. abstract jitter buffer on the following additional control
  8122. frames: AST_CONTROL_HOLD AST_CONTROL_UNHOLD
  8123. AST_CONTROL_T38_PARAMETERS
  8124. 2013-08-22 17:13 +0000 [r397431] Kinsey Moore <kmoore@digium.com>
  8125. * tests/test_cel.c, main/cel.c, include/asterisk/cel.h: Make CEL
  8126. behavior conform to the documentation This modifies the behavior
  8127. of the CEL engine to conform to documented behavior for Asterisk
  8128. 12 as defined on the wiki
  8129. https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+CEL+Specification
  8130. The primary changes deal with removal of the peer field from
  8131. function calls since it is no longer directly relevant to the
  8132. bridging system and removal of the layer of CDR-like business
  8133. logic that was providing a partial emulation of Asterisk 11 CEL
  8134. functionality. With this change, there is no longer a distinction
  8135. between "bridges" and "conferences" and all participation changes
  8136. are denoted with bridge enter and bridge exit messages. This
  8137. updates the CEL unit tests to handle these changes and simplifies
  8138. some of the macros used in the process. This also fixes a
  8139. segfault when attempting to ref a configuration that failed to
  8140. load. Review: https://reviewboard.asterisk.org/r/2788/ (issue
  8141. ASTERISK-21567)
  8142. 2013-08-22 16:46 +0000 [r397426] Richard Mudgett <rmudgett@digium.com>
  8143. * main/bridge.c: Update BUGBUG comment.
  8144. 2013-08-22 12:28 +0000 [r397379-397415] Walter Doekes <walter+asterisk@wjd.nu>
  8145. * main/asterisk.c: Don't store repeated commands in the editline
  8146. history buffer. The equivalent of bash HISTCONTROL=ignoredups.
  8147. Review: https://reviewboard.asterisk.org/r/2775/
  8148. * /, main/asterisk.exports.in, default.exports: Add _IO_stdin_used
  8149. in version-script to fix SIGBUSes on Sparc. The
  8150. --version-script,asterisk.exports linker flag (and the module
  8151. exports) didn't provide _IO_stdin_used in the list of exported
  8152. symbols. That causes some kind of libc compatibility mode to kick
  8153. in, where stdio file structures (stdout/stderr) land somewhere
  8154. else. In the case of the Sparc, they landed on misaligned memory.
  8155. This became apparent first after r376428 (Reorder startup
  8156. sequence) when a lot of ast_log's were replaced with fprintf's.
  8157. Writing to stderr triggered a SIGBUS. (Compared to x86 and amd64
  8158. architectures, the Sparc is very picky about memory alignment.)
  8159. (issue ASTERISK-21763) (issue ASTERISK-21665) Reported by: Jeremy
  8160. Kister Review: https://reviewboard.asterisk.org/r/2760/ ........
  8161. Merged revisions 397377 from
  8162. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8163. revisions 397378 from
  8164. http://svn.asterisk.org/svn/asterisk/branches/11
  8165. 2013-08-21 23:09 +0000 [r397366] Jonathan Rose <jrose@digium.com>
  8166. * main/udptl.c, /: UDPTL: Fix a regression where UDPTL won't load
  8167. default settings If the file udptl.conf is unavailable at
  8168. startup, UDPTL will fail to initialize and while it makes some
  8169. noise, it isn't immediately obvious why consumers start to fail
  8170. when using it. This patch makes UDPTL load as though an empty
  8171. config was provided when udptl is unavailable at startup. (closes
  8172. issue ASTERISK-22349) Reported by: Jonathan Rose Review:
  8173. https://reviewboard.asterisk.org/r/2773/ ........ Merged
  8174. revisions 397365 from
  8175. http://svn.asterisk.org/svn/asterisk/branches/11
  8176. 2013-08-21 20:02 +0000 [r397346-397355] Richard Mudgett <rmudgett@digium.com>
  8177. * include/asterisk/bridge_basic.h, main/bridge_basic.c,
  8178. main/features.c: * Move ast_bridge_channel_setup_features() into
  8179. bridge_basic.c. * Made application map hooks be removed on a
  8180. basic bridge personality change.
  8181. * main/bridge.c, main/bridge_channel.c: Deferred some more BUGBUG
  8182. comments to a JIRA issue or XXX comment.
  8183. 2013-08-21 17:12 +0000 [r397310] David M. Lee <dlee@digium.com>
  8184. * /, main/http.c: Complete http_shutdown. This patch frees up some
  8185. resources allocated in http.c. * tcp listeners stopped * tls
  8186. settings freed * uri redirects freed * unregister internal http.c
  8187. uri's (closes issue ASTERISK-22237) Reported by: Corey Farrell
  8188. Patches: http.patch uploaded by Corey Farrell (license 5909)
  8189. ........ Merged revisions 397308 from
  8190. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8191. revisions 397309 from
  8192. http://svn.asterisk.org/svn/asterisk/branches/11
  8193. 2013-08-21 16:31 +0000 [r397307] Matthew Jordan <mjordan@digium.com>
  8194. * include/asterisk/frame.h, /: Set 14400 as the default max bit
  8195. rate if T38MaxBitRate is not specified If an endpoint fails to
  8196. include the T38MaxBitRate attribute during negotiation, Asterisk
  8197. will negotiate a bit rate of 2400 instead of the ITU recommended
  8198. bit rate of 14400. This patch fixes this by making
  8199. AST_T38_RATE_14400 the 'default' value of the enum by assigning
  8200. it a value of 0, such that if an endpoint fails to include the
  8201. attribute, the default will be 14400. Note that Walter Doekes
  8202. included the nice comment in frame.h about why we are
  8203. purposefully assigning AST_T38_RATE_14400 a value of 0. (closes
  8204. issue ASTERISK-22275) Reported by: Andreas Steinmetz patches:
  8205. fax-fix.patch uploaded by anstein (License 6523) ........ Merged
  8206. revisions 397256 from
  8207. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8208. revisions 397257 from
  8209. http://svn.asterisk.org/svn/asterisk/branches/11
  8210. 2013-08-21 16:23 +0000 [r397295-397306] David M. Lee <dlee@digium.com>
  8211. * rest-api/api-docs/asterisk.json, res/ari/resource_asterisk.c,
  8212. res/res_ari_asterisk.c, rest-api/api-docs/channels.json,
  8213. res/ari/resource_channels.c, res/res_ari_channels.c: ARI: Correct
  8214. segfault with /variable calls are missing ?variable parameter.
  8215. Both /asterisk/variable and /channel/{channelId}/variable
  8216. requires a ?variable parameter to be passed into the query. But
  8217. we weren't checking for the parameter being missing, which caused
  8218. a segfault. All calls now properly return 400 Bad Request errors
  8219. when the parameter is missing. The Swagger api-docs were updated
  8220. accordingly. (closes issue ASTERISK-22273)
  8221. * main/stasis_endpoints.c: ARI: Remove the 'channel:' scheme from
  8222. endpoint's channel list. For times when a reference in ARI might
  8223. be ambiguous, the reference is built as an URI (such as
  8224. channel:1376341790.3). An endpoint's channel list is not
  8225. ambiguous, and in fact the field is named 'channel_ids', but it
  8226. had channel URI's instead of channel id's. This patch changes the
  8227. list to be the raw id instead of the URI. (closes issue
  8228. ASTERISK-22291)
  8229. * res/stasis/control.h, res/res_stasis.c: res_stasis: remove call
  8230. to missing function control_continue. In the shuffling around of
  8231. res_stasis, control_continue was renamed to
  8232. stasis_app_control_continue, but the call in res_stasis wasn't
  8233. updated. In looking into it, it turns out it wasn't really the
  8234. right thing to do in res_stasis anyways. This patch changes the
  8235. handling of received a AST_CONTROL_HANGUP frame to be the same as
  8236. receiving a NULL frame, and removed the declaration of
  8237. control_continue(), since it doesn't exist any more. (closes
  8238. issue ASTERISK-22292) Reported by: Denis Smirnov
  8239. 2013-08-21 15:51 +0000 [r397294] Richard Mudgett <rmudgett@digium.com>
  8240. * apps/app_bridgewait.c, include/asterisk/bridge_features.h,
  8241. main/bridge_channel.c, res/parking/parking_bridge_features.c,
  8242. apps/app_agent_pool.c, bridges/bridge_holding.c, main/bridge.c,
  8243. include/asterisk/bridge_channel.h, main/features.c,
  8244. bridges/bridge_builtin_interval_features.c: Fix several
  8245. interrelated issues dealing with the holding bridge technology. *
  8246. Added an option flags parameter to interval hooks. Interval hooks
  8247. now can specify if the callback will affect the media path or
  8248. not. * Added an option flags parameter to the bridge action
  8249. custom callback. The action callback now can specify if the
  8250. callback will affect the media path or not. * Made the holding
  8251. bridge technology reexamine the participant idle mode option
  8252. whenever the entertainment is restarted. * Fixed app_agent_pool
  8253. waiting agents needlessly starting and stopping MOH every second
  8254. by specifying the heartbeat interval hook as not affecting the
  8255. media path. * Fixed app_agent_pool agent alert from restarting
  8256. the MOH after the alert beep. The agent entertainment is now
  8257. changed from MOH to silence after the alert beep. * Fixed holding
  8258. bridge technology to defer starting the entertainment. It was
  8259. previously a mixture of immediate and deferred. * Fixed holding
  8260. bridge technology to immediately stop the entertainment. It was
  8261. previously a mixture of immediate and deferred. If the channel
  8262. left the bridging system, any deferred stopping was discarded
  8263. before taking effect. * Miscellaneous holding bridge technology
  8264. rework coding improvements. Review:
  8265. https://reviewboard.asterisk.org/r/2761/
  8266. 2013-08-21 14:39 +0000 [r397255] Mark Michelson <mmichelson@digium.com>
  8267. * /, channels/chan_sip.c: Prevent a crash on outbound SIP MESSAGE
  8268. requests. If a From header on an outbound out-of-call SIP MESSAGE
  8269. were malformed, the result could crash Asterisk. In addition, if
  8270. a From header on an incoming out-of-call SIP MESSAGE request were
  8271. malformed, the message was happily accepted rather than being
  8272. rejected up front. The incoming message path would not result in
  8273. a crash, but the behavior was bad nonetheless. (closes issue
  8274. ASTERISK-22185) reported by Zhang Lei ........ Merged revisions
  8275. 397254 from http://svn.asterisk.org/svn/asterisk/branches/11
  8276. 2013-08-21 14:08 +0000 [r397244] Kinsey Moore <kmoore@digium.com>
  8277. * res/res_stasis.c: Allow channels in app_stasis to hangup properly
  8278. This detects hangups that occur while bridged to allow channels
  8279. to exit app_stasis even if the hangup frame was absorbed by the
  8280. bridge the channel was in. Reported by: David Lee (closes issue
  8281. ASTERISK-22297)
  8282. 2013-08-21 13:41 +0000 [r397243] Matthew Jordan <mjordan@digium.com>
  8283. * CHANGES, channels/chan_sip.c: Allow the SIP_CODEC family of
  8284. variables to specify more than one codec The SIP_CODEC family of
  8285. variables let you set the preferred codec to be offered on an
  8286. outbound INVITE request. However, for video calls, you need to be
  8287. able to set both the audio and video codecs to be offered. This
  8288. patch lets the SIP_CODEC variables accept a comma delineated list
  8289. of codecs. The first codec in the list is set as the preferred
  8290. codec; additional codecs are still offered however. This lets a
  8291. dialplan writer set both audio and video codecs, e.g.,
  8292. Set(SIP_CODEC=ulaw,h264) Note that this feature was written by
  8293. both Dennis Guse and Frank Haase Review:
  8294. https://reviewboard.asterisk.org/r/2728 (closes issue
  8295. ASTERISK-21976) Reported by: Denis Guse Tested by: mjordan,
  8296. sysreq patches: patch-channels-chan__sip.c-393919 uploaded by
  8297. dennis.guse (license 6513)
  8298. 2013-08-21 02:15 +0000 [r397206] Michael L. Young <elgueromexicano@gmail.com>
  8299. * /, channels/chan_sip.c: Fix Not Storing Current Incoming Recv
  8300. Address In 1.8, r384779 introduced a regression by retrieving an
  8301. old dialog and keeping the old recv address since recv was
  8302. already set. This has caused a problem when a proxy is involved
  8303. since responses to incoming requests from the proxy server, after
  8304. an outbound call is established, are never sent to the correct
  8305. recv address. In 11, r382322 introduced this regression. The fix
  8306. is to revert that change and always store the recv address on
  8307. incoming requests. Thank you Walter Doekes for helping to point
  8308. out this error and Mark Michelson for your input/review of the
  8309. fix. (closes issue ASTERISK-22071) Reported by: Alex Zarubin
  8310. Tested by: Alex Zarubin, Karsten Wemheuer Patches:
  8311. asterisk-22071-store-recvd-address.diff by Michael L. Young
  8312. (license 5026) ........ Merged revisions 397204 from
  8313. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8314. revisions 397205 from
  8315. http://svn.asterisk.org/svn/asterisk/branches/11
  8316. 2013-08-20 21:01 +0000 [r397111-397193] Mark Michelson <mmichelson@digium.com>
  8317. * include/asterisk/res_pjsip.h, res/res_pjsip/config_security.c
  8318. (removed), res/res_pjsip/pjsip_configuration.c,
  8319. res/res_pjsip_acl.c: Localize and rename ACL configuration. This
  8320. is more-or-less a reversion of previous ACL behavior so that it
  8321. is more self-contained. ACL sections are now only parsed if
  8322. res_pjsip_acl.so is loaded. Moreover, the configuration section
  8323. is now "type=acl" instead of "type=security". The original reason
  8324. for having ACLs configured in a "type=security" section was to
  8325. lump ACLs and other security-related items into the same section.
  8326. The problem is that ACLs really should be in their own sections
  8327. and there are no other security-related options implemented
  8328. anyways.
  8329. * /, channels/chan_sip.c: Remove REF_DEBUG definition. ........
  8330. Merged revisions 397156 from
  8331. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8332. revisions 397157 from
  8333. http://svn.asterisk.org/svn/asterisk/branches/11
  8334. * /, channels/chan_sip.c, channels/sip/dialplan_functions.c: Fix
  8335. refcounting of sip_pvt in test_sip_rtpqos test and unlink it from
  8336. the list of pvts. (closes issue ASTERISK-22248) reported by Corey
  8337. Farrell patches: test_sip_rtpqos.patch uploaded by Corey Farrell
  8338. (license #5909) ........ Merged revisions 397112 from
  8339. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8340. revisions 397133 from
  8341. http://svn.asterisk.org/svn/asterisk/branches/11
  8342. * res/res_pjsip.c: Clarify documentation for the "identify_by"
  8343. option for SIP endpoints. This also removes documentation for the
  8344. options that no longer exist. (closes issue ASTERISK-22306)
  8345. reported by Rusty Newton
  8346. 2013-08-20 15:36 +0000 [r397110] Kinsey Moore <kmoore@digium.com>
  8347. * /, main/threadstorage.c, main/astfd.c: Unregister CLI commands on
  8348. exit This patch ensures that CLI commands enabled by
  8349. DEBUG_FD_LEAKS and DEBUG_THREADLOCALS are cleaned up properly on
  8350. exit. (closes issue ASTERISK-22238) Reported by: Corey Farrell
  8351. Tested by: Corey Farrell Patches: debug_cli_unregister.patch
  8352. uploaded by Corey Farrell ........ Merged revisions 397106 from
  8353. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8354. revisions 397107 from
  8355. http://svn.asterisk.org/svn/asterisk/branches/11
  8356. 2013-08-20 15:32 +0000 [r397073-397109] Mark Michelson <mmichelson@digium.com>
  8357. * res/res_pjsip_endpoint_identifier_ip.c: Add debug message to
  8358. res_pjsip_endpoint_identifier_ip to indicate when an endpoint is
  8359. successfully retrieved. (closes issue ASTERISK-22101) reported by
  8360. Rusty Newton
  8361. * res/res_pjsip_registrar.c: Add warning messages for registration
  8362. failure paths. (closes issue ASTERISK-22089) reported by Rusty
  8363. Newton patches: patch1.txt uploaded by John Bigelow (License
  8364. #5091)
  8365. * res/res_pjsip.c: Add note to transport configuration that a
  8366. restart is required to change transports. (closes issue
  8367. ASTERISK-22094) reported by Rusty Newton
  8368. 2013-08-20 14:26 +0000 [r397072] Kinsey Moore <kmoore@digium.com>
  8369. * /: Recorded merge of revisions 397067 from
  8370. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Fix
  8371. xmldoc memory leak This fixes a single-attribute memory leak that
  8372. was occurring when the "required" attribute was not true. (closes
  8373. issue ASTERISK-22249) Reported by: Corey Farrell Tested by: Corey
  8374. Farrell Patches: xmldoc-free_attr_required.patch uploaded by
  8375. Corey Farrell ........ Merged revisions 397064 from
  8376. http://svn.asterisk.org/svn/asterisk/branches/1.8
  8377. 2013-08-20 11:48 +0000 [r396996] Walter Doekes <walter+asterisk@wjd.nu>
  8378. * configs/sip.conf.sample, configs/h323.conf.sample, /: Add
  8379. "autoframing" option to sip.conf.sample and h323.conf.sample. The
  8380. autoframing option was added to chan_sip.c in r43243 (mogorman,
  8381. 2006-09-19 01:32:57), but never made its way into the sample
  8382. configs. Review: https://reviewboard.asterisk.org/r/2768/
  8383. ........ Merged revisions 396994 from
  8384. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8385. revisions 396995 from
  8386. http://svn.asterisk.org/svn/asterisk/branches/11
  8387. 2013-08-20 11:33 +0000 [r396993] Joshua Colp <jcolp@digium.com>
  8388. * res/res_pjsip_dtmf_info.c: Remove assumption in
  8389. res_pjsip_dtmf_info that all INFO messages will contain a body.
  8390. (closes issue ASTERISK-22320) Reported by: Matt Jordan
  8391. 2013-08-20 00:08 +0000 [r396946-396949] Matthew Jordan <mjordan@digium.com>
  8392. * /, apps/app_queue.c: Let Queue wrap up time influence member
  8393. availability Queue members who happen to be in multiple queues at
  8394. the same time may not have any wrap up time. This problem
  8395. occurred due to a code change in Asterisk 11.3.0 that unified
  8396. device state tracking of Queue members in multiple Queues (which
  8397. fixed some other problems, but unfortunately caused this one).
  8398. This patch fixes the behavior by having the is_member_available
  8399. function check the queue's wrap up time and the time of the
  8400. member's last call, such that for a particular queue, the member
  8401. won't be considered available if their last call is within the
  8402. wrap up time. (closes issue ASTERISK-22189) Reported by: Tony
  8403. Lewis Tested by: Tony Lewis ........ Merged revisions 396948 from
  8404. http://svn.asterisk.org/svn/asterisk/branches/11
  8405. * /, apps/app_meetme.c: Resolve conflicts between
  8406. CONFFLAG_DONT_DENOISE and CONFFLAG_INTROUSER_VMREC When r382230
  8407. added an option to not denoise the MeetMe conference (if a user
  8408. had a channel whose format's sample rate changed frequently, for
  8409. example), the value added was the maximum allowed value for the
  8410. constants that define the options for MeetMe in 1.8. Not so in 11
  8411. - unfortunately, the option CONFFLAG_DONT_DENOISE conflicts with
  8412. CONFFLAG_INTROUESR_VMREC. This patch fixes that, and also tweaks
  8413. one of the way in which the constants was declared for
  8414. consistency. Thanks to Tony Mountifield for pointing out the
  8415. problem and solution. (closes issue ASTERISK-22269) Reported by:
  8416. Tony Mountifield ........ Merged revisions 396944 from
  8417. http://svn.asterisk.org/svn/asterisk/branches/11
  8418. 2013-08-19 16:10 +0000 [r396930] Richard Mudgett <rmudgett@digium.com>
  8419. * main/bridge.c: Update BUGBUG comment.
  8420. 2013-08-19 14:54 +0000 [r396923] Jonathan Rose <jrose@digium.com>
  8421. * main/bridge.c: attended transfers: Fix a bug affecting external
  8422. blond transfers Performing a blond transfer (attended transfer
  8423. that is completed before the transfer recipient picks up)
  8424. externally through chan_sip or chan_pjsip would result in lost
  8425. references to the channels involved with the transfer as well as
  8426. their bridge. (closes issue ASTERISK-22092) Reported by:
  8427. mmichelson Review: https://reviewboard.asterisk.org/r/2766/
  8428. 2013-08-19 14:53 +0000 [r396915-396922] Matthew Jordan <mjordan@digium.com>
  8429. * channels/sip/include/sip.h: Whitespace cleanup Remove some
  8430. extraneous blobs
  8431. * main/data.c: Fix invalid access to disposed memory in main/data
  8432. unit test It is not safe to iterate over a macro'd list of ao2
  8433. objects, deref them such that the item's destructor is called,
  8434. and leave them in the list. The list macro to iterate over items
  8435. requires the item to be a valid allocated object in order to
  8436. proceed to the next item; with MALLOC_DEBUG on the corruption of
  8437. the linked list is caught in the crash. This patch fixes the
  8438. invalid access to free'd memory by removing the ao2 item from the
  8439. list before de-refing it.
  8440. 2013-08-18 03:05 +0000 [r396908-396909] Kinsey Moore <kmoore@digium.com>
  8441. * channels/chan_mgcp.c: Update chan_mgcp to the modified parking
  8442. API
  8443. * res/res_corosync.c: Disable build of res_corosync until it is
  8444. back in a compiling state
  8445. 2013-08-17 18:13 +0000 [r396899-396902] Rusty Newton <rnewton@digium.com>
  8446. * res/res_pjsip.c: xml doc changes for 'aor' config object and a
  8447. few of its options Added or modified text in the xml doc for the
  8448. 'aor' config object to address a few issues: * help for the
  8449. 'mailboxes' option didn't make it clear how the "list" should be
  8450. formatted. * AoR object's involvement in inbound registration
  8451. wasn't mentioned. * help for the 'contact' option didn't describe
  8452. how to specify multiple contacts. * help for the 'max_contacts'
  8453. option didn't tell whether it limited the amount of contacts
  8454. defined through static configuration. (issue ASTERISK-22118)
  8455. (closes issue ASTERISK-22118)
  8456. * res/res_pjsip.c: 'domain_alias' config object XML help doesn't
  8457. make it clear that the name used for the object is the domain
  8458. alias (issue ASTERISK-22114) (closes issue ASTERISK-22114)
  8459. * res/res_pjsip.c: xml doc changes for clarity - 'auth' config
  8460. object and auth's 'auth_type' config option (issue
  8461. ASTERISK-22108) (closes issue ASTERISK-22108)
  8462. * res/res_pjsip.c: xml doc change for transport config object -
  8463. remove non-applicable warning and add text regarding Asterisk
  8464. restart (closes issue ASTERISK-22105)
  8465. 2013-08-17 15:01 +0000 [r396887-396890] Kinsey Moore <kmoore@digium.com>
  8466. * main/bridge.c, res/parking/parking_applications.c,
  8467. include/asterisk/parking.h, main/bridge_channel.c,
  8468. res/parking/parking_bridge_features.c, channels/chan_dahdi.c,
  8469. res/parking/res_parking.h, res/res_parking.c,
  8470. channels/sig_analog.c, channels/chan_skinny.c, main/parking.c:
  8471. Allow res_parking to be unloadable This change protects accesses
  8472. of res_parking such that it can unload safely once transient uses
  8473. of its registered functions are complete. The parking API has
  8474. been restructured such that its consumers do not have access to
  8475. the vtable exposed by the parking provider, but instead route
  8476. through stubs to prevent consumers from holding on to function
  8477. pointers. This adds calls to all the parking unload functions and
  8478. moves application loading and unloading into functions in
  8479. parking_applications.c similar to the rest of the parts of
  8480. res_parking. Review: https://reviewboard.asterisk.org/r/2763/
  8481. (closes issue ASTERISK-22142)
  8482. * tests/test_event.c, include/asterisk/_private.h, main/cel.c,
  8483. cel/cel_odbc.c, include/asterisk/event.h,
  8484. include/asterisk/event_defs.h, cel/cel_manager.c,
  8485. cel/cel_custom.c, tests/test_cel.c, cel/cel_sqlite3_custom.c,
  8486. main/event.c, main/asterisk.c, cel/cel_pgsql.c, cel/cel_radius.c,
  8487. include/asterisk/cel.h, cel/cel_tds.c: Refactor CEL to avoid
  8488. using the event system core This removes usage of the event
  8489. system for CEL backend data distribution and strips unused pieces
  8490. out of the event system. Review:
  8491. https://reviewboard.asterisk.org/r/2732/
  8492. * main/presencestate.c, channels/sig_pri.h, res/res_parking.c,
  8493. channels/chan_dahdi.c, main/manager.c,
  8494. funcs/func_presencestate.c, include/asterisk/event.h,
  8495. include/asterisk/event_defs.h, channels/chan_skinny.c,
  8496. tests/test_cel.c, main/event.c,
  8497. include/asterisk/security_events_defs.h,
  8498. res/parking/parking_manager.c, channels/chan_mgcp.c,
  8499. res/res_security_log.c, apps/app_voicemail.c,
  8500. res/parking/parking_ui.c, channels/chan_unistim.c, main/pbx.c,
  8501. include/asterisk/devicestate.h, main/security_events.c,
  8502. channels/chan_sip.c, main/ccss.c, tests/test_event.c,
  8503. main/devicestate.c, res/parking/parking_applications.c,
  8504. res/res_xmpp.c, channels/sig_pri.c, channels/chan_iax2.c,
  8505. apps/app_queue.c, res/res_jabber.c: Strip down the old event
  8506. system This removes unused code, event types, IE pltypes, and
  8507. event IE types where possible and makes several functions private
  8508. that were once public. This includes a renumbering of the
  8509. remaining event and IE types which breaks binary compatibility
  8510. with previous versions. The last remaining consumers of the old
  8511. event system (or parts thereof) are main/security_events.c,
  8512. res/res_security_log.c, tests/test_cel.c, tests/test_event.c,
  8513. main/cel.c, and the CEL backends. Review:
  8514. https://reviewboard.asterisk.org/r/2703/ (closes issue
  8515. ASTERISK-22139)
  8516. 2013-08-16 20:48 +0000 [r396849-396877] Richard Mudgett <rmudgett@digium.com>
  8517. * main/bridge_channel.c, include/asterisk/bridge.h, main/bridge.c,
  8518. include/asterisk/bridge_channel.h: Fix CLI "bridge kick <bridge>
  8519. <channel>" to check if the bridge needs dissolving. SIP/foo --
  8520. Local;1==Local;2 -- .... -- Local;1==Local;2 -- SIP/bar Kick a ;1
  8521. channel and the chain toward SIP/foo goes away. Kick a ;2 channel
  8522. and the chain toward SIP/bar goes away. This can leave a local
  8523. channel chain between the kicked ;1 and ;2 channels that are
  8524. orphaned until you manually request one of those channels to
  8525. hangup or request the bridge to dissolve. * Added
  8526. ast_bridge_kick() as a companion to ast_bridge_remove(). The
  8527. functional difference is that ast_bridge_kick() may dissolve the
  8528. bridge as a result of the channel leaving the bridge. * Made CLI
  8529. "bridge kick <bridge> <channel>" use ast_bridge_kick() instead of
  8530. ast_bridge_remove() so the bridge can dissolve if needed. *
  8531. Renamed bridge_channel_handle_hangup() to
  8532. ast_bridge_channel_kick() and made it accessible to other files.
  8533. * include/asterisk/doxygen/architecture.h,
  8534. include/asterisk/bridge_channel_internal.h: Fix some doxygen
  8535. bridging file references.
  8536. * res/parking/parking_bridge_features.c, main/cdr.c, main/data.c,
  8537. main/manager.c, tests/test_jitterbuf.c, main/features.c,
  8538. tests/test_voicemail_api.c, main/file.c, tests/test_cel.c,
  8539. main/stasis_channels.c, main/bridge_channel.c, main/message.c,
  8540. tests/test_cdr.c, main/db.c, main/xmldoc.c, main/format.c,
  8541. res/res_rtp_asterisk.c, main/pbx.c, main/rtp_engine.c,
  8542. tests/test_abstract_jb.c, channels/chan_sip.c, main/pickup.c,
  8543. apps/app_queue.c, main/indications.c: Doxygen comment tweaks.
  8544. * main/utils.c, main/hashtab.c: Fix utilities compilation/linking.
  8545. The horrid structure of the source in the utils directory strikes
  8546. again. Moved the _ast_mem_backtrace_buffer[] definition from the
  8547. logical location in utils.c to hashtab.c so the aelparse and
  8548. conf2ael utilities can link.
  8549. * include/asterisk/utils.h: utils.h: Minor formatting tweaks.
  8550. 2013-08-16 16:03 +0000 [r396842] David M. Lee <dlee@digium.com>
  8551. * main/stasis.c, main/stasis_cache_pattern.c, main/stasis_cache.c,
  8552. include/asterisk/astobj2.h, main/stasis_channels.c,
  8553. tests/test_stasis.c: Stasis: address refcount races;
  8554. implementation comments Change r395954 reordered some stasis
  8555. object destruction, which should have been fine. Unfortunately,
  8556. it caused some hard to reproduce issues related to objects being
  8557. accessed after they had been destroyed. The patch in r396329
  8558. fixed the destruction order problem; this patch addresses the
  8559. underlying issue. A few other stasis-related fixes were also
  8560. added. * Add ref-bumps around areas where objects may get
  8561. transitively destroyed. (For example, where we lock a topic,
  8562. unref a subscription, which unrefs the topic, which explodes the
  8563. topic when we try to unlock it.) * Wrote an extensive doxygen
  8564. page about Stasis implementation, relationships between objects,
  8565. lifecycles of objects, how the refcounting works, etc. Many other
  8566. comments were added, corrected, or cleaned up. * Added an assert
  8567. to the topic dtor to catch extra ref decrements. * Fixed type
  8568. used after destruction errors for graceful shutdown in
  8569. stasis_channels.c. * I added two unit tests in an attempt to
  8570. catch destruction order issues. Since the underlying cause is a
  8571. race condition, though, the tests rarely failed even when the
  8572. code was wrong. * Fixed a leak in stasis_cache_pattern.c. (closes
  8573. issue ASTERISK-22243) Review:
  8574. https://reviewboard.asterisk.org/r/2746/
  8575. 2013-08-16 12:20 +0000 [r396829] Kinsey Moore <kmoore@digium.com>
  8576. * main/utils.c, main/sounds_index.c, main/loader.c: Improve sounds
  8577. indexer CLI commands This reworks the CLI commands used to access
  8578. sounds information from "sounds show[ soundid]" to "core show
  8579. sounds" and "core show sound <soundid>". This also reworks the
  8580. "sounds reload" CLI command to fall under normal module reloading
  8581. ("module reload sounds"). Also, make trunk build when
  8582. DEBUG_MALLOC is not enabled. Review:
  8583. https://reviewboard.asterisk.org/r/2745/ (closes issue
  8584. ASTERISK-22141)
  8585. 2013-08-16 07:18 +0000 [r396822] Walter Doekes <walter+asterisk@wjd.nu>
  8586. * include/asterisk/utils.h, main/pbx.c, main/utils.c: Prevent heap
  8587. alloc functions from running out of stack space. When asterisk
  8588. has run out of memory (for whatever reason), the alloc function
  8589. logs a message. Logging requires memory. A recipe for infinite
  8590. recursion. Stop the recursion by comparing the function call
  8591. depth for sane values before attempting another OOM log message.
  8592. Review: https://reviewboard.asterisk.org/r/2743/
  8593. 2013-08-15 22:10 +0000 [r396783-396814] Richard Mudgett <rmudgett@digium.com>
  8594. * main/bridge_channel.c: Bridge: Don't suspend/unspend the channel
  8595. for interception routines. By their nature, the connected line
  8596. and redirecting interception routines are not supposed to affect
  8597. the channel's media. Therefore, they should not suspend and
  8598. unsuspend the channel while running. The suspend/unsuspend
  8599. operations could be expensive depending upon the bridge and
  8600. channel technology involved.
  8601. * res/parking/res_parking.h, res/res_parking.c,
  8602. res/parking/parking_tests.c, main/features.c: Minor parking
  8603. cleanup.
  8604. * res/parking/parking_bridge_features.c: Parking: Eliminate local
  8605. channel name hack to get peer channel. (closes issue
  8606. ASTERISK-22034) Reported by: Matt Jordan
  8607. * main/bridge_channel.c, main/features.c: Remove early bridge
  8608. BUGBUG comments. Remove some unneeded features.c comments.
  8609. * configs/features.conf.sample: Update features.conf.sample
  8610. atxferdropcall option.
  8611. * main/bridge.c, include/asterisk/bridge_channel.h,
  8612. main/config_options.c, main/bridge_channel.c,
  8613. apps/confbridge/conf_config_parser.c: Changed some BUGBUG tags to
  8614. associated JIRA issue tags.
  8615. * main/bridge.c, main/features.c, bridges/bridge_softmix.c,
  8616. include/asterisk/bridge.h: Resolve some BUGBUG comments.
  8617. 2013-08-15 16:37 +0000 [r396747] Kinsey Moore <kmoore@digium.com>
  8618. * main/asterisk.c, main/cli.c, /: Remove leading spaces from the
  8619. CLI command before parsing If you've mistakenly put a space
  8620. before typing in a command, the leading space will be included as
  8621. part of the command, and the command parser will not find the
  8622. corresponding command. This patch rectifies that situation by
  8623. stripping the leading spaces on commands. Review:
  8624. https://reviewboard.asterisk.org/r/2709/ Patch-by: Tilghman
  8625. Lesher ........ Merged revisions 396745 from
  8626. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8627. revisions 396746 from
  8628. http://svn.asterisk.org/svn/asterisk/branches/11
  8629. 2013-08-15 15:12 +0000 [r396732-396734] Richard Mudgett <rmudgett@digium.com>
  8630. * channels/chan_vpb.cc, main/features.c,
  8631. include/asterisk/channel.h, channels/chan_iax2.c: Remove some
  8632. dead code dealing with: AST_BRIDGE_REC_CHANNEL_0,
  8633. AST_BRIDGE_REC_CHANNEL_1, and AST_BRIDGE_IGNORE_SIGS.
  8634. * include/asterisk/bridge_channel_internal.h, main/manager.c,
  8635. main/bridge_channel.c: Fix Bridge API DTMF hook matching for
  8636. begin and end DTMF events. The Bridge API DTMF hook matching
  8637. would not deal with DTMF end events only. It required a DTMF
  8638. begin event to start matching the DTMF hooks. There are many
  8639. places in Asterisk where code only generates DTMF end events
  8640. without the corresponding begin event. One such place is the AMI
  8641. action Atxfer. * Fixed DTMF hook matching if there is a string of
  8642. DTMF frames in the read queue. We could potentially miss some of
  8643. them before. * Fixed AMI Atxfer action documentation. (closes
  8644. issue ASTERISK-22037) Reported by: Matt Jordan Review:
  8645. https://reviewboard.asterisk.org/r/2752/
  8646. 2013-08-15 12:17 +0000 [r396722-396724] Kinsey Moore <kmoore@digium.com>
  8647. * apps/app_confbridge.c, main/bridge.c, main/features.c: Fix
  8648. feature_attended_transfer test The feature_attended_transfer test
  8649. is failing due to Asterisk not passing DTMF in the bridges
  8650. created for internal attended transfers. This sets the features
  8651. initialization routine to set this flag by default and adjusts
  8652. the basic bridge and confbridge's use of the bridging system
  8653. accordingly as per Richard's suggestion instead of adjusting this
  8654. individual case. This change allows the necessary DTMF to pass
  8655. through the attended transfer bridge and complete the test
  8656. successfully. Review: https://reviewboard.asterisk.org/r/2759/
  8657. (closes issue ASTERISK-22222)
  8658. * main/utils.c, include/asterisk/lock.h, channels/chan_sip.c: Fix
  8659. deadlocks in chan_sip in REFER and BYE handling This resolves
  8660. several deadlocks in chan_sip relating to usage of
  8661. ast_channel_bridge_peer and improves accessibility of lock
  8662. debugging function calls. Review:
  8663. https://reviewboard.asterisk.org/r/2756/ (closes issue
  8664. ASTERISK-22215)
  8665. * res/res_stasis.c: Prevent automagic things from happening to
  8666. Stasis application bridges This prevents swap optimization,
  8667. merges, and transfers involving Stasis application bridges. It
  8668. wouldn't be nice if the bridge you thought you owned disappeared
  8669. from under you. Reported-by: Richard Mudgett
  8670. 2013-08-15 00:16 +0000 [r396695-396713] Richard Mudgett <rmudgett@digium.com>
  8671. * include/asterisk/channel.h, main/channel.c, channels/chan_vpb.cc:
  8672. Remove unsupported channel technology callbacks.
  8673. * channels/chan_vpb.cc: chan_vpb: Effectively remove native
  8674. support. Left enough bread crumbs to be able to convert later if
  8675. needed.
  8676. * channels/chan_iax2.c: chan_iax2: Conditionally remove native
  8677. support for now. (issue ASTERISK-21944)
  8678. * channels/chan_misdn.c: chan_misdn: Effectively remove native
  8679. support. Left enough bread crumbs to be able to convert later if
  8680. needed.
  8681. * apps/app_bridgewait.c: app_bridgewait: Inhibit local channel
  8682. optimizations to the bridge. Holding bridges can allow local
  8683. channel move/swap optimization to the bridge. However, we cannot
  8684. allow it for the BridgeWait holding bridge because the call will
  8685. lose the channel roles and dialplan location as a result.
  8686. 2013-08-14 19:06 +0000 [r396621-396658] Joshua Colp <jcolp@digium.com>
  8687. * /, tests/test_hashtab_thrash.c: Tweak comment for why usleep is
  8688. used. ........ Merged revisions 396656 from
  8689. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8690. revisions 396657 from
  8691. http://svn.asterisk.org/svn/asterisk/branches/11
  8692. * tests/test_hashtab_thrash.c, /: Tweak test_hashtab_thrash test to
  8693. allow the critical threads to execute. Depending on certain
  8694. conditions it was possible for the hashtab counting thread to
  8695. starve other threads, preventing them from executing in the
  8696. expected fashion. This change adds a sleep to allow the others to
  8697. do what they need to do. While this doesn't thrash the hashtab as
  8698. much as previously, it at least works. (closes issue
  8699. ASTERISK-22276) Reported by: Matt Jordan ........ Merged
  8700. revisions 396619 from
  8701. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8702. revisions 396620 from
  8703. http://svn.asterisk.org/svn/asterisk/branches/11
  8704. 2013-08-13 18:47 +0000 [r396581-396584] Walter Doekes <walter+asterisk@wjd.nu>
  8705. * /, channels/chan_sip.c: chan_sip: Convert 'just did sched_add
  8706. waitid...' from warning to debug message. Patches:
  8707. reviewboard-2377.patch uploaded by Paul Belanger Review:
  8708. https://reviewboard.asterisk.org/r/2377/ ........ Merged
  8709. revisions 396582 from
  8710. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8711. revisions 396583 from
  8712. http://svn.asterisk.org/svn/asterisk/branches/11
  8713. * /, channels/chan_sip.c: chan_sip: Fix IP-addr in warning when
  8714. rejecting a contact ACL. Patches: reviewboard-2155.patch uploaded
  8715. by Paul Belanger Review: https://reviewboard.asterisk.org/r/2155/
  8716. ........ Merged revisions 396579 from
  8717. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8718. revisions 396580 from
  8719. http://svn.asterisk.org/svn/asterisk/branches/11
  8720. 2013-08-13 15:27 +0000 [r396559-396568] David M. Lee <dlee@digium.com>
  8721. * include/asterisk/stasis_app_impl.h, res/res_stasis_recording.c,
  8722. res/stasis/control.h, include/asterisk/bridge_internal.h,
  8723. include/asterisk/bridge_features.h, res/res_stasis.c,
  8724. res/ari/resource_bridges.c, res/res_stasis_bridge_add.c
  8725. (removed), res/res_stasis_playback.c, res/stasis/control.c,
  8726. res/res_stasis_bridge_add.exports.in (removed),
  8727. include/asterisk/stasis_app.h: ARI: allow other operations to
  8728. happen while bridged This patch changes ARI bridging to allow
  8729. other channel operations to happen while the channel is bridged.
  8730. ARI channel operations are designed to queue up and execute
  8731. sequentially. This meant, though, that while a channel was
  8732. bridged, any other channel operations would queue up and execute
  8733. only after the channel left the bridge. This patch changes ARI
  8734. bridging so that channel commands can execute while the channel
  8735. is bridged. For most operations, things simply work as expected.
  8736. The one thing that ended up being a bit odd is recording. The
  8737. current recording implementation will fail when one attempts to
  8738. record a channel that's in a bridge. Note that the bridge itself
  8739. may be recording; it's recording a specific channel in the bridge
  8740. that fails. While this is an annoying limitation, channel
  8741. recording is still very useful for use cases such as voice mail,
  8742. and bridge recording makes up much of the difference for other
  8743. use cases. (closes issue ASTERISK-22084) Review:
  8744. https://reviewboard.asterisk.org/r/2726/
  8745. * tests/test_hashtab_thrash.c: Missed a spot in r396559
  8746. * tests/test_hashtab_thrash.c: Fix build warnings when printf a
  8747. tv_usec. The debug logs added in r396528 neglected to account for
  8748. suseconds_t being an int. See r392076 for more info.
  8749. 2013-08-12 22:05 +0000 [r396552] John Bigelow <jbigelow@digium.com>
  8750. * res/res_pjsip_registrar.c: Add test suite events for when
  8751. contacts are added or removed from an AOR These are needed by the
  8752. pjsip inbound registration test suite tests. (issue
  8753. ASTERISK-21833) (issue ASTERISK-21834) (issue ASTERISK-21835)
  8754. (issue ASTERISK-21837) Review:
  8755. https://reviewboard.asterisk.org/r/2700/ Review:
  8756. https://reviewboard.asterisk.org/r/2739/
  8757. 2013-08-12 15:59 +0000 [r396542-396543] Matthew Jordan <mjordan@digium.com>
  8758. * main/bridge_channel.c, main/bridge.c, main/features.c: Fix two
  8759. race conditions and ref counting issue when joining a bridge
  8760. These problems were all caught by a test in the Asterisk Test
  8761. Suite that originated some Local channels and attempted to move
  8762. the ;2 half of the Local channel into a bridge using the Bridge
  8763. AMI action. (1) When originating a channel, the Newchannel event
  8764. is emitted quickly; however, the ;2 channel will not have a pbx
  8765. thread assigned to it until after the outbound 'dialing' for the
  8766. ;1 is complete. Thus, there is a period of time where the outside
  8767. world "knows" of the channel's existence and can influence it but
  8768. Asterisk has not yet started the dialplan execution thread. If a
  8769. Bridge AMI action is taken on the channel, the channel appears to
  8770. be a Dialed channel with no PBX thread; hence, the channel will
  8771. be imparted into the Bridge by first 'yanking' the channel. At
  8772. the same time, a race condition can occur after the yank (but
  8773. before entering the bridge) when ;1 answers and starts a PBX on
  8774. the ;2. The end result currently is an assertion failure in the
  8775. Bridging API, as a channel with a PBX is imparted into the
  8776. Bridge. There's no way to prevent AMI from attempting to Bridge a
  8777. channel immediately after creation; likewise, holding the channel
  8778. lock through the entire Dial operation is unwise (and
  8779. impossible). Instead of treating the presence of a PBX thread as
  8780. an error, we simply bail out of the adding the channel to the
  8781. bridge through ast_bridge_impart. The Bridge action will then
  8782. fail - but we avoid a situation where the channel is both
  8783. executing a PBX thread and simultaneously being given a separate
  8784. thread in the bridging system (which would be a "bad thing").
  8785. Since imparting a channel with a PBX *can* occur and is not a
  8786. programming error, the asserts have been removed. (2) When the
  8787. first condition occurs, we have to take one of two actions:
  8788. either hangup the yanked channel as it did not enter the bridge,
  8789. or deref it because we don't own it. We can determine if we own
  8790. it or not by testing for the presence of the PBX thread. If we
  8791. hung it up directly, we'd crash. (3) bridge_find_channel does not
  8792. increase the reference count of the ast_bridge_channel object.
  8793. The RAII_VAR usage in ast_bridge_add_channel thus created a
  8794. ticking time bomb in whatever bridge the channel moved into, as
  8795. the destructor for the ast_bridge_channel object would be called.
  8796. Review: https://reviewboard.asterisk.org/r/2741/
  8797. * main/pbx.c: Unlock outgoing dial lock on off nominal path If the
  8798. thread servicing the dial request isn't created successfully, the
  8799. outgoing dial lock will still be held when the function returns.
  8800. This patch unlocks the lock on this off nominal path.
  8801. 2013-08-10 20:29 +0000 [r396521-396535] Matthew Jordan <mjordan@digium.com>
  8802. * tests/test_hashtab_thrash.c: Pipe test output through test object
  8803. not stdout Otherwise, it doesn't show up in the automated test
  8804. failures
  8805. * tests/test_hashtab_thrash.c: Add some debugging when
  8806. test_hashtab_thrash fails Disabling DEBUG_THREADS caused this
  8807. test to fail on the 32-bit build agent. Adding some debugging to
  8808. see why it thinks the test is timing out.
  8809. * main/pbx.c: Unlock the dial operation lock on a failed dial If a
  8810. dial operation fails, the pbx_outgoing_attempt routine will exit
  8811. without first having unlocked the outgoing dial lock. This would
  8812. be a "bad thing".
  8813. 2013-08-09 21:50 +0000 [r396512] Richard Mudgett <rmudgett@digium.com>
  8814. * bridges/bridge_native_rtp.c: bridge_native_rtp: Remove some
  8815. unnecessary NULL checks on c1.
  8816. 2013-08-09 20:29 +0000 [r396505] Walter Doekes <walter+asterisk@wjd.nu>
  8817. * main/autoservice.c: Don't leak frames when memory is full in
  8818. autoservice_run. Review: https://reviewboard.asterisk.org/r/2566/
  8819. 2013-08-09 17:28 +0000 [r396497-396498] Jonathan Rose <jrose@digium.com>
  8820. * main/pbx.c, channels/chan_sip.c: pbx: Make originate threads
  8821. indicate dial status when synchronous This makes it so that we
  8822. can detect failures to originate as with earlier versions of
  8823. Asterisk, which restores the Asterisk 11 behavior for the
  8824. originate manager action. This was causing the ACL tests for SIP
  8825. and IAX2 to fail since those tests expected originate failures
  8826. when ACLs would cause rejections. Also, this patch fixes crashes
  8827. in chan_sip when ACLs rejected peers during registration
  8828. verification. (closes issue ASTERISK-22212) Reported by: Matt
  8829. Jordan Review: https://reviewboard.asterisk.org/r/2753/
  8830. * main/core_unreal.c, main/bridge_channel.c,
  8831. include/asterisk/bridge.h, res/ari/resource_bridges.c,
  8832. include/asterisk/core_unreal.h: bridge_channel: Support the
  8833. lonely flag and make ARI use it. The lonely flag is an optional
  8834. flag for bridge channels that will make them leave a bridge when
  8835. a channel leaves if only lonely channels are in the bridge at
  8836. that point. This is useful for things like ending recording and
  8837. playback channels when they cease to be interacting with other
  8838. channels in the bridge. (closes issue ASTERISK-22117) Reported
  8839. by: Matt Jordan Review: https://reviewboard.asterisk.org/r/2721/
  8840. 2013-08-09 13:58 +0000 [r396490] Matthew Jordan <mjordan@digium.com>
  8841. * apps/confbridge/conf_config_parser.c: Update documentation for
  8842. ConfBridge with some additional markup Add some additional markup
  8843. for items that needed it, e.g., replaceable tags, literal tags,
  8844. etc.
  8845. 2013-08-08 22:57 +0000 [r396480] Richard Mudgett <rmudgett@digium.com>
  8846. * tests/test_stasis.c: Fix stasis/core unit test. Should have had
  8847. the CR/LF.
  8848. 2013-08-08 22:09 +0000 [r396474] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  8849. * channels/chan_dahdi.c: chan_dahdi: create channels at run-time
  8850. This code adds chan_dahdi the command 'dahdi create channels
  8851. <range>' (where <range> is a single <n>-<m> or 'new') and updates
  8852. 'dahdi destroy channel' with a similar 'dahdi destroy channels'.
  8853. It allows DAHDI channels and spans to be added after the initial
  8854. channel load (without destroying all other channels as in 'dahdi
  8855. restart'). It also includes some fixes to the D-Channel / span
  8856. destruction code (r394552). This change is intended to provide a
  8857. hook for a script running from udev once a span has been assigned
  8858. ("registered") / unassigned ("unregistered") for its channels.
  8859. The udev hook configures the span's channels with dahdi_cfg -S,
  8860. and can then ask Asterisk to create ethe channels. See the
  8861. scripts added to DAHDI-tools in 2.7.0. Review:
  8862. https://reviewboard.asterisk.org/r/1598/
  8863. 2013-08-08 20:52 +0000 [r396417-396463] Richard Mudgett <rmudgett@digium.com>
  8864. * tests/test_stasis.c: Add missing CR/LF to FakeMI stasis test AMI
  8865. event.
  8866. * main/stasis_bridges.c: Remove extra CR/LF from AMI event.
  8867. * main/manager_bridges.c, apps/confbridge/confbridge_manager.c,
  8868. include/asterisk/manager.h, main/stasis_bridges.c: Make bridge
  8869. snapshots use prefixes. * Changed
  8870. ast_manager_build_bridge_state_string() to assume an empty prefix
  8871. string just like ast_manager_build_channel_state_string(). *
  8872. Created ast_manager_build_bridge_state_string_prefix() to work
  8873. just like ast_manager_build_channel_state_string_prefix(). * Made
  8874. BridgeMerge AMI event use To/From prefixes.
  8875. 2013-08-08 18:40 +0000 [r396412] Matthew Jordan <mjordan@digium.com>
  8876. * formats/format_wav_gsm.c: Improve disk writes for wav49 format
  8877. Writing to a file in the wav49 format performs rather
  8878. inefficiently. The procedure is approximately: (1) Write GSM
  8879. frame to the end of the file (2) Seek to the end of the file (3)
  8880. Seek to the header (4) Update the file size (5) Seek (again) to
  8881. the end of the file (6) Repeat This pattern negates any attempt
  8882. to use the stdio buffering setup in ast_writefile. It also
  8883. results in many small writes that require a seek going to the
  8884. disk each second which translates to poor disk performance on
  8885. certain file systems, particularly when there are multiple wav49
  8886. files being written simultaneously. (closes issue ASTERISK-19595)
  8887. Reported by: Byron Clark Tested by: Byron Clark patches:
  8888. gsm_wav_only_update_header_on_close.patch uploaded by byronclark
  8889. (License 6157)
  8890. 2013-08-08 17:51 +0000 [r396401] Richard Mudgett <rmudgett@digium.com>
  8891. * main/channel_internal_api.c, main/features.c,
  8892. include/asterisk/bridge_features.h, main/bridge.c: Remove some
  8893. resolved or obsolete BUGBUG comments.
  8894. 2013-08-08 14:13 +0000 [r396391-396392] Matthew Jordan <mjordan@digium.com>
  8895. * apps/confbridge/conf_chan_announce.c, main/manager_channels.c,
  8896. main/channel.c, main/manager_bridges.c,
  8897. channels/chan_bridge_media.c, apps/confbridge/conf_chan_record.c,
  8898. main/channel_internal_api.c, include/asterisk/channel.h,
  8899. main/cel.c: Hide the Surrogate channels from external consumers;
  8900. kill Masquerade events This patch does three things: 1. It
  8901. provides a Surrogate channel technology with a consolidated
  8902. "implementation detail flag" on the channel technology. This
  8903. tells consumers of Stasis that the creation of this channel is an
  8904. implementation detail in Asterisk and can be ignored (if they so
  8905. choose). This consolidates the conference recorder/announcer
  8906. flags as well - these flags had no additional meaning beyond
  8907. "ignore this channel please". 2. It modifies allocation of a
  8908. channel in two ways: (a) If a channel technology can be
  8909. determined from the name, we set it directly in the allocation
  8910. routine. This prevents the initial publication of the message
  8911. from going out with a NULL channel technology where possible.
  8912. This lets Stasis consumers get the right channel technology on
  8913. the first publication. (b) It reorganizes allocation to make use
  8914. of the 'finalized' property on the channel. This was already used
  8915. to know that a channel had completely finished its construction
  8916. in the masquerade routine; now we also use it to know whether or
  8917. not the setting of certain channel properties is occurring during
  8918. or post construction. The various set routines were modified
  8919. accordingly as well. 3. The masquerade event is now dead, Jim. It
  8920. no longer served any purpose whatsoever - if you perform a call
  8921. pickup you'll get a Pickup event; if you perform an attended
  8922. transfer you will still get those events; if you steal a channel
  8923. to put it elsewhere you'll get the corresponding NewExten or
  8924. BridgeEnter events. Review:
  8925. https://reviewboard.asterisk.org/r/2740
  8926. * main/utils.c: Prevent spurious memory error when appending
  8927. backtrace with MALLOC_DEBUG Backtraces are allocated outside of
  8928. the usual memory tracking performed by MALLOC_DEBUG. This allows
  8929. them to be used by the memory tracking enabled by that build
  8930. option; however, it also means that when backtraces are disposed
  8931. of they have to be done so outside of the re-defined free. This
  8932. patch undef's free prior to disposing of the allocated backtrace
  8933. when a backtrace is appended as a result of 'core show locks'.
  8934. 2013-08-08 12:38 +0000 [r396385] Kinsey Moore <kmoore@digium.com>
  8935. * main/bridge.c: Prevent unreal channels from optimizing during
  8936. DTMF emulation This prevents unreal channel optimization during
  8937. the prequalification phase when either channel is involved in
  8938. DTMF emulation. This prevents a situation where an emulated digit
  8939. would be missed because the emulation was never completed.
  8940. Review: https://reviewboard.asterisk.org/r/2747/ (closes issue
  8941. ASTERISK-22214)
  8942. 2013-08-08 07:05 +0000 [r396378] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  8943. * channels/chan_unistim.c, /: - Fix different issues with call
  8944. transfer cancel. In case 3rd party busy or congestion call was
  8945. not returned. - Fix displaying soft button 'Redial' in case of no
  8946. redial number exists ........ Merged revisions 396377 from
  8947. http://svn.asterisk.org/svn/asterisk/branches/11
  8948. 2013-08-08 02:58 +0000 [r396365-396371] Matthew Jordan <mjordan@digium.com>
  8949. * main/cdr.c: Handle Surrogate channels in Dial message processing
  8950. Depending on when a Surrogate channel replaces an existing
  8951. channel, it is possible to get a Dial message for the Surrogate
  8952. channel. When this occurs, no CDR will exist for the channel as
  8953. Surrogate channels are ignored. Safely handle the case when a CDR
  8954. doesn't exist for a Dial message.
  8955. * apps/app_queue.c: Perform Ring-No-Answer checks before processing
  8956. Hangup logic The rna() routine will raise a Stasis message
  8957. involving both the caller and the agent. This doesn't work so
  8958. well if we already hung up the agent channel, as the channel
  8959. doesn't quite exist. Not surprisingly, this will crash. This
  8960. patch properly runs the rna subroutine (performing all of the
  8961. Ring-No-Answer logic) prior to hanging up the agent channel.
  8962. (closes issue ASTERISK-22258) Reported by: Kiril Valchev Tested
  8963. by: Kiril Valchev
  8964. 2013-08-06 21:20 +0000 [r396329-396347] David M. Lee <dlee@digium.com>
  8965. * apps/app_meetme.c: Fixed app_meetme for cache split changes
  8966. * include/asterisk/frame.h, rest-api/api-docs/recordings.json,
  8967. res/ari/resource_recordings.c, apps/app_voicemail.c,
  8968. main/channel.c, res/res_ari_recordings.c, include/asterisk/app.h,
  8969. include/asterisk/stasis_app_recording.h,
  8970. res/ari/resource_recordings.h, funcs/func_frame_trace.c,
  8971. apps/app_minivm.c, main/app.c, res/res_stasis_recording.c: ARI:
  8972. Add recording controls This patch implements the controls from
  8973. ARI recordings. The controls are: * DELETE
  8974. /recordings/live/{recordingName} - stop recording and discard it
  8975. * POST /recordings/live/{recordingName}/stop - stop recording *
  8976. POST /recordings/live/{recordingName}/pause - pause recording *
  8977. POST /recordings/live/{recordingName}/unpause - resume recording
  8978. * POST /recordings/live/{recordingName}/mute - mute recording
  8979. (record silence to the file) * POST
  8980. /recordings/live/{recordingName}/unmute - unmute recording. Since
  8981. this underlying functionality did not already exist, is was added
  8982. to app.c by a set of control frames, similar to how playback
  8983. control works. The pause/mute control frames are toggles, even
  8984. though the ARI controls are idempotent, to be consistent with the
  8985. playback control frames. (closes issue ASTERISK-22181) Review:
  8986. https://reviewboard.asterisk.org/r/2697/
  8987. * main/stasis_cache_pattern.c, main/stasis_cache.c,
  8988. include/asterisk/stasis.h, tests/test_stasis.c: Tweak caching
  8989. topics to fix CEL tests The Stasis changes in r395954 had an
  8990. unanticipated side effect: messages published directly to an _all
  8991. topic does not get forwarded to the corresponding caching topic.
  8992. This patch fixes that by changing how caching topics forward
  8993. messages, and how the caching pattern forwards are setup. For the
  8994. caching pattern, the all_topic is forwarded to the
  8995. all_topic_cached. This forwards messages published directly to
  8996. the all_topic to all_topic_cached. In order to avoid duplicate
  8997. messages on all_topic_cached, caching topics were changed to no
  8998. longer forward uncached messages. Subscribers to an individual
  8999. caching topic should only expect to receive cache updates, and
  9000. subscription change messages. Since individual caching topics are
  9001. new, this shouldn't be a problem. There are a few minor changes
  9002. to the pre-cache split behavior. * For topics changed to use the
  9003. caching pattern, the all_topic_cached will forward snapshots in
  9004. addition to cache updates. Since subscribers by design ignore
  9005. unexpected messages, this should be fine. * Caching topics that
  9006. don't use the caching pattern no longer forward non-cache
  9007. updates. This makes no difference for the current caching topics.
  9008. * mwi_topic_cached, channel_by_name_topic and
  9009. presence_state_topic_cached have no subscribers *
  9010. device_state_topic_cached's only subscriber only processes cache
  9011. udpates (issue ASTERISK-22243) Review:
  9012. https://reviewboard.asterisk.org/r/2738
  9013. 2013-08-06 13:08 +0000 [r396320-396321] Kinsey Moore <kmoore@digium.com>
  9014. * res/res_pjsip/include/res_pjsip_private.h, res/res_pjsip.c,
  9015. res/res_pjsip/config_system.c: Expose res_pjsip threadpool
  9016. options Expose initial size, automatic increment, maximum size,
  9017. and idle timeout as configurable parameters for the res_pjsip
  9018. thread pool. Review: https://reviewboard.asterisk.org/r/2704/
  9019. (closes issue ASTERISK-22143)
  9020. * main/cdr.c: Fix memory leaks in the CDR engine Fix refcount bugs
  9021. and a possible locking problem in the CDR engine relating to use
  9022. of ao2_iterators. Review:
  9023. https://reviewboard.asterisk.org/r/2724/ (closes issue
  9024. ASTERISK-22126)
  9025. 2013-08-06 12:39 +0000 [r396319] Joshua Colp <jcolp@digium.com>
  9026. * res/res_pjsip_notify.c, res/res_pjsip_outbound_registration.c,
  9027. res/res_pjsip_messaging.c, res/res_pjsip_exten_state.c: Fix crash
  9028. in res_pjsip_outbound_registration when the remote server can not
  9029. be resolved. This crash was caused by decrementing the reference
  9030. count of a newly created message when it should not be. This
  9031. change fixes that but also fixes all other cases where this was
  9032. incorrectly done. (closes issue ASTERISK-22188) Reported by:
  9033. Kinsey Moore
  9034. 2013-08-06 08:43 +0000 [r396309-396311] Walter Doekes <walter+asterisk@wjd.nu>
  9035. * /, funcs/func_strings.c: Check result of ast_var_assign() calls
  9036. for memory allocation failure (2). Missed a spot in the previous
  9037. commit. ........ Merged revisions 396310 from
  9038. http://svn.asterisk.org/svn/asterisk/branches/11
  9039. * pbx/pbx_dundi.c, utils/extconf.c, apps/app_stack.c,
  9040. apps/app_playback.c, funcs/func_global.c, main/cdr.c,
  9041. pbx/pbx_loopback.c, main/pbx.c, /, funcs/func_strings.c: Check
  9042. result of ast_var_assign() calls for memory allocation failure.
  9043. We try to keep the system running even when all available memory
  9044. is spent. Review: https://reviewboard.asterisk.org/r/2734/
  9045. ........ Merged revisions 396279 from
  9046. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9047. revisions 396287 from
  9048. http://svn.asterisk.org/svn/asterisk/branches/11
  9049. 2013-08-05 20:20 +0000 [r396253] Michael L. Young <elgueromexicano@gmail.com>
  9050. * /, channels/chan_sip.c: Fix Registration Failure When A Peer And
  9051. TLS Are Used If a peer is used in a register line and TLS is
  9052. defined as the transport, the registration fails since the
  9053. transport on the dialog is never set properly resulting in UDP
  9054. being used instead of TLS. This patch sets the dialog's transport
  9055. based on the transport that was defined in the register line. If
  9056. the register line does not specify a transport, the parsing
  9057. function for the register line always defaults back to UDP.
  9058. (closes issue ASTERISK-21964) Reported by: Doug Bailey Tested by:
  9059. Doug Bailey Patches: asterisk-21964-set-reg-dialog-transport.diff
  9060. by Michael L. Young (license 5026) ........ Merged revisions
  9061. 396240 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  9062. ........ Merged revisions 396248 from
  9063. http://svn.asterisk.org/svn/asterisk/branches/11
  9064. 2013-08-05 20:18 +0000 [r396245] Jonathan Rose <jrose@digium.com>
  9065. * main/bridge_basic.c, main/features.c,
  9066. include/asterisk/bridge_basic.h: bridge features: Dial and Queue
  9067. add features instead of replace them. Dial and Queue would
  9068. previously apply a new set of features whenever bridging. These
  9069. options would be based purely on the options supplied to the
  9070. dial/queue applications. This patch changes the function those
  9071. applications use to bridge calls so that the features will be
  9072. added to the set of existing features for each channel rather
  9073. than having them override the existing features. (closes issue
  9074. ASTERISK-22209) Reported by: Jonathan Rose Review:
  9075. https://reviewboard.asterisk.org/r/2713/
  9076. 2013-08-05 19:01 +0000 [r396201] Matthew Jordan <mjordan@digium.com>
  9077. * res/res_pjsip_outbound_registration.c: Add AMI registration
  9078. events for PJSIP outbound registration attempts This patch adds
  9079. AMI events whenever an outbound registration attempt succeeds or
  9080. fails from res_pjsip_outbound_registration. This brings it inline
  9081. with the existing SIP channel driver and IAX channel driver.
  9082. Review: https://reviewboard.asterisk.org/r/2729/
  9083. 2013-08-05 18:52 +0000 [r396198-396200] Michael L. Young <elgueromexicano@gmail.com>
  9084. * /, UPGRADE-11.txt: Change "from" to "From". (related to issue
  9085. ASTERISK-21903) ........ Merged revisions 396199 from
  9086. http://svn.asterisk.org/svn/asterisk/branches/11
  9087. * UPGRADE-11.txt, /: Adding a note to UPGRADE.txt about a change
  9088. made to res_agi in order to indicate when streaming an audio file
  9089. fails like it is done in other parts of the code to indicate an
  9090. error. Note was requested by Paul Belanger:
  9091. http://lists.digium.com/pipermail/asterisk-dev/2013-July/061420.html
  9092. (related to issue ASTERISK-21903) ........ Merged revisions
  9093. 396196 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  9094. ........ Merged revisions 396197 from
  9095. http://svn.asterisk.org/svn/asterisk/branches/11
  9096. 2013-08-05 17:48 +0000 [r396175-396189] Jonathan Rose <jrose@digium.com>
  9097. * bridges/bridge_holding.c: bridge_holding: Add suspsend/unsuspend
  9098. callbacks Suspend and unsuspend callbacks are added to the
  9099. holding bridge so that entertainment can be disabled and
  9100. re-enabled when operations would suspend a channel on the bridge
  9101. (such as playback operations). This fixes entertainment so that
  9102. when those operations end, the entertainment can pick back up and
  9103. it also serves as an optimization. Also, this patch fixes a bug
  9104. caused by triggering ringing frames immediately instead of
  9105. pushing them to the queue which created a race condition where
  9106. sometimes parking with ringing during attended transfers would
  9107. cause the ringing to be interrupted by an unhold frame. (closes
  9108. issue ASTERISK-22006) Reported by: Matt Jordan Review:
  9109. https://reviewboard.asterisk.org/r/2711/
  9110. * res/res_ari_bridges.c, include/asterisk/bridge_roles.h,
  9111. res/ari/resource_bridges.h, res/stasis/control.c,
  9112. include/asterisk/stasis_app.h, main/bridge_roles.c,
  9113. rest-api/api-docs/bridges.json, res/ari/resource_bridges.c: ARI:
  9114. bridges/{bridgeID}/addChannel: add roles parameter Roles are now
  9115. cleared with each entry into a bridge with addChannel. If the
  9116. roles parameter is present, the role specified will be applied to
  9117. all channels being added with the addChannel command. (closes
  9118. issue ASTERISK-21973) Reported by: Matt Jordan
  9119. https://reviewboard.asterisk.org/r/2691/
  9120. * res/parking/res_parking.h, res/res_parking.c,
  9121. res/parking/parking_tests.c (added),
  9122. res/parking/parking_bridge.c: res_parking: Unit tests Adds the
  9123. following unit tests: * create_lot: tests adding and removal of a
  9124. new parking lot (baseline) * park_extensions: creates a parking
  9125. lot that registers extensions and then confirms that all of the
  9126. expected extensions exist * extensions_conflicts: creates
  9127. numerous parking lots to test that extension conflicts in parking
  9128. lots result in parking lot creation failing *
  9129. dynamic_parking_variables: Tests that the creation of dynamic
  9130. parking lots respects the related channel variables set on the
  9131. channel that requests them. * park_call: Tests adding a channel
  9132. to a parking lot's holding bridge by standard parking functions.
  9133. * retrieve_call: Tests pulling a channel out of a parking lot's
  9134. holding bridge via parked call retrieval functions. (closes issue
  9135. ASTERISK-22138) Reported by: Matt Jordan Review:
  9136. https://reviewboard.asterisk.org/r/2714/
  9137. 2013-08-05 14:35 +0000 [r396166] David M. Lee <dlee@digium.com>
  9138. * main/asterisk.c, main/cli.c, main/channel.c, main/pbx.c,
  9139. main/manager.c, res/ari/resource_asterisk.c, utils/extconf.c,
  9140. include/asterisk/options.h: Fix res_ari_asterisk load issue The
  9141. new res_ari_asterisk.so module presents several config options
  9142. from asterisk main. Unfortunately, they aren't exported, so the
  9143. module won't load on Linux. This patch renames the variables,
  9144. adding the ast_ prefix so they will be exported. Review:
  9145. https://reviewboard.asterisk.org/r/2737
  9146. 2013-08-03 03:53 +0000 [r396158] Matthew Jordan <mjordan@digium.com>
  9147. * main/manager_bridges.c: Don't unsubscribe from the AMI message
  9148. router from manager_bridges The AMI message router is owned
  9149. wholly by manager.c. Previously, each of the manager_{item}
  9150. source files had their own message router and they unsubscribed
  9151. from each; once they moved over to using a single message router
  9152. only a single unsubscribe became necessary.
  9153. 2013-08-02 17:50 +0000 [r396145] Mark Michelson <mmichelson@digium.com>
  9154. * channels/sig_pri.c: And get rid of another ast_bridged_channel()
  9155. 2013-08-02 17:29 +0000 [r396136-396143] David M. Lee <dlee@digium.com>
  9156. * main/stasis_bridges.c: Clean up ast_json with ast_json_unref
  9157. * /: Removed svnmerge-integrated from trunk
  9158. 2013-08-02 15:01 +0000 [r396126] Mark Michelson <mmichelson@digium.com>
  9159. * res/snmp/agent.c: Get the SNMP code to compile.
  9160. 2013-08-02 14:46 +0000 [r396119-396125] David M. Lee <dlee@digium.com>
  9161. * res/ari/ari_model_validators.c, res/ari/ari_model_validators.h,
  9162. rest-api/api-docs/asterisk.json, res/ari/resource_asterisk.c: ARI
  9163. - GET /ari/asterisk/info This patch adds basic system information
  9164. access to ARI. The results are roughly what you get from 'core
  9165. show settings', with a few minor differences. * Data is
  9166. structured, with 'build', 'system', 'config' and 'status'
  9167. sub-objects. * Each sub-object is selectable, using the ?only=
  9168. parameter. A comma separated list can be provided to select
  9169. multiple sections. * A few config options are numeric, for which
  9170. 0 means 'unlimited'. Instead of having a special interpretation
  9171. of those fields, they are simply omitted if they're 0. * The
  9172. information is limited to what might be useful to building
  9173. external applications. (closes issue ASTERISK-21575) Review:
  9174. https://reviewboard.asterisk.org/r/2702/
  9175. * rest-api-templates/param_cleanup.mustache (added),
  9176. rest-api/api-docs/events.json, /, res/ari/resource_events.c,
  9177. rest-api-templates/ari_resource.h.mustache,
  9178. res/res_ari_asterisk.c, res/res_ari_playback.c,
  9179. rest-api-templates/res_ari_resource.c.mustache,
  9180. res/ari/resource_events.h, rest-api/api-docs/sounds.json,
  9181. res/res_ari_channels.c, rest-api/api-docs/bridges.json,
  9182. rest-api-templates/param_parsing.mustache,
  9183. res/ari/resource_bridges.c, res/ari/resource_sounds.h,
  9184. res/res_ari_recordings.c, res/ari/resource_bridges.h,
  9185. res/res_ari_endpoints.c, res/res_ari_events.c,
  9186. res/ari/resource_asterisk.h, rest-api/api-docs/channels.json,
  9187. res/res_ari_sounds.c, res/res_ari_bridges.c: ARI - implement
  9188. allowMultiple for parameters Swagger allows parameters to be
  9189. specified as 'allowMultiple', meaning that the parameter may be
  9190. specified as a comma separated list of values. I had written some
  9191. of the API docs using that, but promptly forgot about
  9192. implementing it. This patch finally fills in that gap. The
  9193. codegen template was updated to represent 'allowMultiple' fields
  9194. as array/size fields in the _args structs. It also parses the
  9195. comma separated list using ast_app_separate_args(), so quoted
  9196. strings in the argument will be handled properly. Review:
  9197. https://reviewboard.asterisk.org/r/2698/
  9198. * tests/test_json.c, main/json.c, res/res_sorcery_astdb.c,
  9199. include/asterisk/json.h, main/cel.c, res/ari/ari_websockets.c:
  9200. Address JSON thread safety issues. In tracking down some unit
  9201. tests failures, I ended up reading the fine print[1] regarding
  9202. Jansson's thread safety. In short: 1. Ref-counting is non-atomic.
  9203. 2. json_dumps() and friends are not thread safe. This patch adds
  9204. locking where necessary to our ast_json_* wrapper API, with
  9205. documentation in json.h describing the thread safety limitations
  9206. of the API. [1]:
  9207. http://www.digip.org/jansson/doc/2.4/portability.html#thread-safety
  9208. Review: https://reviewboard.asterisk.org/r/2716/
  9209. 2013-08-02 14:13 +0000 [r396107] Mark Michelson <mmichelson@digium.com>
  9210. * main/cel.c, include/asterisk/parking.h, main/bridge_channel.c,
  9211. main/stasis_bridges.c, res/parking/parking_manager.c,
  9212. res/parking/parking_bridge.c, main/manager_bridges.c,
  9213. include/asterisk/stasis_bridges.h: Make a couple of changes to
  9214. help AMI events to be more clear in what is occurring. *
  9215. BridgeEnter now contains the unique ID of the channel that is to
  9216. be swapped out, if applicable. * There is a ParkedCallSwap event
  9217. that is sent when a parked channel has a new channel take its
  9218. place. (closes issue ASTERISK-22193) reported by Mark Michelson
  9219. Review: https://reviewboard.asterisk.org/r/2712
  9220. 2013-08-02 14:08 +0000 [r396105] Kinsey Moore <kmoore@digium.com>
  9221. * include/asterisk/strings.h, main/astobj2.c, utils/Makefile,
  9222. utils/refcounter.c, main/strings.c, include/asterisk/astobj2.h:
  9223. Move ast_str_container_alloc and friends This moves
  9224. ast_str_container_alloc, ast_str_container_add,
  9225. ast_str_container_remove, and related private functions into
  9226. strings.c/h since they really don't belong in astobj2.c/h. As a
  9227. result of this move, utils also had to be updated. Review:
  9228. https://reviewboard.asterisk.org/r/2719/ (closes issue
  9229. ASTERISK-22041)
  9230. 2013-08-02 14:05 +0000 [r396102-396103] Mark Michelson <mmichelson@digium.com>
  9231. * channels/chan_sip.c, channels/chan_skinny.c,
  9232. funcs/func_channel.c, main/channel_internal_api.c,
  9233. include/asterisk/channel.h, channels/chan_iax2.c,
  9234. apps/app_chanspy.c, channels/chan_oss.c, channels/chan_mgcp.c,
  9235. main/channel.c, channels/chan_dahdi.c, channels/chan_misdn.c,
  9236. main/rtp_engine.c: Get rid of ast_bridged_channel() and the
  9237. bridged_channel field on ast_channels. This commit is smaller
  9238. than the initial review placed on review board. This is because a
  9239. change to allow for channel drivers to access parking
  9240. functionality externally was committed and invalidated quite a
  9241. few of the changes initially made. (closes issue ASTERISK-22039)
  9242. reported by Matt Jordan Review:
  9243. https://reviewboard.asterisk.org/r/2717
  9244. * include/asterisk/pickup.h: Make sure that pickup.h does not use
  9245. an include guard name used elsewhere.
  9246. 2013-08-02 13:29 +0000 [r396087-396099] Kinsey Moore <kmoore@digium.com>
  9247. * main/pickup.c: Correct the last of the Newchannel xi:includes
  9248. * res/res_pjsip_notify.c, res/res_pjsip_outbound_registration.c,
  9249. res/res_pjsip/include/res_pjsip_private.h,
  9250. res/res_pjsip/pjsip_options.c, res/res_pjsip.c: Add CLI/AMI
  9251. commands to force chan_pjsip actions For chan_pjsip, this
  9252. introduces CLI/AMI remote unregistration commands, reworks CLI
  9253. syntax for sending NOTIFYs, adds AMI qualification support, and
  9254. adds documentation for PJSIPNotify. This also fixes two
  9255. refcounting bugs in the outbound registration code. Review:
  9256. https://reviewboard.asterisk.org/r/2695/ (closes issue
  9257. ASTERISK-21939)
  9258. 2013-08-02 04:48 +0000 [r396075] David M. Lee <dlee@digium.com>
  9259. * channels/sig_analog.c: Fixed chan_dahdi compilation failure
  9260. 2013-08-02 03:12 +0000 [r396060-396062] Matthew Jordan <mjordan@digium.com>
  9261. * tests/test_cel.c, tests/test_cdr.c: Fix test modules More missing
  9262. include files. :-\
  9263. * channels/chan_dahdi.c, channels/chan_mgcp.c: Add pickup.h include
  9264. lines for chan_dahdi and chan_mgcp
  9265. * include/asterisk/parking.h, include/asterisk/pickup.h (added),
  9266. main/asterisk.c, res/parking/parking_manager.c, tests/test_cdr.c,
  9267. channels/chan_unistim.c, main/pbx.c, res/stasis/control.c,
  9268. main/pickup.c (added), channels/chan_sip.c, main/bridge.c,
  9269. UPGRADE.txt, res/parking/parking_applications.c,
  9270. include/asterisk/_private.h, channels/chan_gtalk.c, main/cel.c,
  9271. CHANGES, include/asterisk/features.h, main/cdr.c,
  9272. res/res_parking.c, channels/chan_skinny.c,
  9273. apps/app_directed_pickup.c, main/features.c, tests/test_cel.c:
  9274. Remove dead code from features.c; refactor pickup code into
  9275. pickup.c This patch does the following: * It moves the pickup
  9276. code out of features.c and into pickup.c * It removes the vast
  9277. majority of dead code out of features.c. In particular, this
  9278. includes the parking code. (issue ASTERISK-22134)
  9279. 2013-08-01 23:38 +0000 [r396048] Joshua Colp <jcolp@digium.com>
  9280. * res/res_pjsip_registrar.c: Fix a crash due to performing full URI
  9281. validation on a contact which only contains '*'. (closes issue
  9282. AST-1198) Reported by: John Bigelow
  9283. 2013-08-01 21:19 +0000 [r396035] David M. Lee <dlee@digium.com>
  9284. * main/sorcery.c: Fix sorcery for some rather picky regex
  9285. implementations. Some regex implementations won't compile an
  9286. empty string. Assuming that it's equivalent of a regex that will
  9287. match anything, use ".?" instead.
  9288. 2013-08-01 20:55 +0000 [r396010-396028] Matthew Jordan <mjordan@digium.com>
  9289. * channels/chan_skinny.c, main/parking.c, main/bridge.c,
  9290. main/features.c, channels/chan_iax2.c,
  9291. include/asterisk/parking.h, main/bridge_channel.c,
  9292. res/parking/parking_bridge_features.c, channels/chan_mgcp.c,
  9293. include/asterisk/features.h, channels/chan_dahdi.c,
  9294. res/res_parking.c, channels/sig_analog.c: Support externally
  9295. initiated parking requests; remove some dead code This patch does
  9296. the following: * It adds support for externally initiated parking
  9297. requests. In particular, chan_skinny has a protocol level message
  9298. that initiates a call park. This patch now supports that option,
  9299. as well as the protocol specific mechanisms in
  9300. chan_dahdi/sig_analog and chan_mgcp. * A parking bridge features
  9301. virtual table has been added that provides access to the parking
  9302. functionality that the Bridging API needs. This includes requests
  9303. to park an entire 'call' (with little or no additional
  9304. information, thank you chan_skinny), perform a blind transfer to
  9305. a parking extension, determine if an extension is a parking
  9306. extension, as well as the actual "do the parking" request from
  9307. the Bridging API. * Refactoring in chan_mgcp, chan_skinny, and
  9308. chan_dahdi to make use of the new functions * The removal of some
  9309. - but not all - dead parking code from features.c This also fixed
  9310. blind transferring a multi-party bridge to a parking lot (which
  9311. was implemented, but had at least one code path where using the
  9312. parking features kK might not have worked) Review:
  9313. https://reviewboard.asterisk.org/r/2710 (closes issue
  9314. ASTERISK-22134) Reported by: Matt Jordan
  9315. * CHANGES, apps/app_queue.c: Add queue member paused hints This
  9316. patch adds the ability in Queue to raise a hint when a member's
  9317. paused state changes. The hint uses the form
  9318. 'Queue:{queue_name}_pause_{member_name}', where {queue_name} and
  9319. {member_name} are the name of the queue and the name of the
  9320. member to subscribe to, respectively. For example: exten =>
  9321. 8501,hint,Queue:sales_pause_mark. Members will show as In Use
  9322. when paused. Note that the format of the queue pause hint was
  9323. changed slightly from what is on the issue to accomodate
  9324. suggestion on the code review. Review:
  9325. https://reviewboard.asterisk.org/r/2254 (closes issue
  9326. ASTERISK-20842) Reported by: Philippe Lindheimer patches:
  9327. qpause-10-378206.diff uploaded by Philippe Lindheimer (license
  9328. 5519) qpause-11-378206.diff uploaded by Philippe Lindheimer
  9329. (license 5519) qpause-trunk-378206.diff uploaded by Philippe
  9330. Lindheimer (license 5519)
  9331. 2013-08-01 17:23 +0000 [r395985-395998] Kinsey Moore <kmoore@digium.com>
  9332. * configure: Regenerate configure for configure.ac changes
  9333. * Makefile, apps/confbridge/confbridge_manager.c, makeopts.in,
  9334. doc/appdocsxml.dtd, apps/app_stack.c,
  9335. res/parking/parking_manager.c, main/manager_mwi.c,
  9336. main/rtp_engine.c, apps/app_meetme.c,
  9337. include/asterisk/autoconfig.h.in, main/xml.c,
  9338. main/stasis_bridges.c, contrib/scripts/install_prereq,
  9339. main/manager_bridges.c, channels/chan_dahdi.c, main/manager.c,
  9340. doc/snapshots.xslt (added), main/features.c, apps/app_minivm.c,
  9341. res/res_agi.c, main/stasis_channels.c, main/manager_channels.c,
  9342. channels/chan_sip.c, main/Makefile, configure.ac, UPGRADE.txt,
  9343. main/aoc.c, main/core_local.c, channels/sig_pri.c,
  9344. apps/app_queue.c, CHANGES, funcs/func_global.c,
  9345. apps/app_agent_pool.c: Fix documentation replication issues This
  9346. prevents XML documentation duplication by expanding channel and
  9347. bridge snapshot tags into channel and bridge snapshot parameter
  9348. sets with a given prefix or defaulting to no prefix. This also
  9349. prevents documentation from becoming fractured and out of date by
  9350. keeping all variations of the documentation in template form such
  9351. that it only needs to be updated once and keeps maintenance to a
  9352. minimum. Review: https://reviewboard.asterisk.org/r/2708/
  9353. 2013-08-01 16:56 +0000 [r395954-395984] David M. Lee <dlee@digium.com>
  9354. * utils/astman.c: Fixed warning in astman for gcc-4.8.
  9355. * res/res_pjsip_mwi.c, channels/chan_pjsip.c: Fixed compile errors
  9356. introduced in r395954. Just a merge error due to a file rename.
  9357. Grrr...
  9358. * main/manager.c, tests/test_devicestate.c, res/res_agi.c,
  9359. include/asterisk/stasis_cache_pattern.h (added), main/app.c,
  9360. main/stasis_channels.c, res/ari/resource_channels.c,
  9361. include/asterisk/stasis_endpoints.h, include/asterisk/bridge.h,
  9362. main/manager_channels.c, channels/chan_mgcp.c, main/pbx.c,
  9363. include/asterisk/devicestate.h, main/stasis_cache.c,
  9364. res/ari/resource_endpoints.c, channels/chan_sip.c,
  9365. main/channel_internal_api.c, include/asterisk/presencestate.h,
  9366. include/asterisk/stasis_bridges.h, include/asterisk/stasis.h,
  9367. include/asterisk/channel.h, channels/sig_pri.c, main/cel.c,
  9368. tests/test_stasis_endpoints.c, res/ari/resource_bridges.c,
  9369. include/asterisk/app.h, include/asterisk/stasis_channels.h,
  9370. apps/confbridge/confbridge_manager.c, tests/test_cel.c,
  9371. tests/test_stasis.c, res/res_stasis.c,
  9372. main/stasis_cache_pattern.c (added), apps/app_voicemail.c,
  9373. channels/chan_unistim.c, main/stasis_endpoints.c,
  9374. main/stasis_wait.c (added), apps/app_meetme.c,
  9375. res/stasis/control.c, main/bridge.c, main/manager_endpoints.c,
  9376. include/asterisk/channel_internal.h, main/devicestate.c,
  9377. res/res_xmpp.c, main/endpoints.c, channels/chan_iax2.c,
  9378. res/res_jabber.c, main/presencestate.c, main/stasis_bridges.c,
  9379. res/res_chan_stats.c, main/stasis.c, main/cli.c, main/cdr.c,
  9380. channels/chan_dahdi.c, main/manager_bridges.c: Split caching out
  9381. from the stasis_caching_topic. In working with res_stasis, I
  9382. discovered a significant limitation to the current structure of
  9383. stasis_caching_topics: you cannot subscribe to cache updates for
  9384. a single channel/bridge/endpoint/etc. To address this, this patch
  9385. splits the cache away from the stasis_caching_topic, making it a
  9386. first class object. The stasis_cache object is shared amongst
  9387. individual stasis_caching_topics that are created per
  9388. channel/endpoint/etc. These are still forwarded to global
  9389. whatever_all_cached topics, so their use from most of the code
  9390. does not change. In making these changes, I noticed that we
  9391. frequently used a similar pattern for bridges, endpoints and
  9392. channels: single_topic ----------------> all_topic ^ |
  9393. single_topic_cached ----+----> all_topic_cached | +----> cache
  9394. This pattern was extracted as the 'Stasis Caching Pattern',
  9395. defined in stasis_caching_pattern.h. This avoids a lot of
  9396. duplicate code between the different domain objects. Since the
  9397. cache is now disassociated from its upstream caching topics, this
  9398. also necessitated a change to how the 'guaranteed' flag worked
  9399. for retrieving from a cache. The code for handling the caching
  9400. guarantee was extracted into a 'stasis_topic_wait' function,
  9401. which works for any stasis_topic. (closes issue ASTERISK-22002)
  9402. Review: https://reviewboard.asterisk.org/r/2672/
  9403. 2013-08-01 11:21 +0000 [r395938] Joshua Colp <jcolp@digium.com>
  9404. * res/res_pjsip_session.c: Answer with multiple codecs if the
  9405. underlying pjproject supports it.
  9406. 2013-08-01 00:07 +0000 [r395906-395907] Matthew Jordan <mjordan@digium.com>
  9407. * channels/chan_sip.c: Raise Registry AMI events on registration
  9408. failures This patch makes it so that all registration attempts
  9409. that fail that also permanently modify the registration state
  9410. will raise an appropriate AMI event. Note that this patch was
  9411. forward ported to trunk and the Stasis Core message bus by
  9412. mjordan. (closes issue ASTERISK-21368) Reported by: Dmitriy Serov
  9413. patches: chan_sip.c.diff uploaded by Demon (license 6479)
  9414. * res/res_agi.c, CHANGES: Update CONTROL STREAM FILE to accept an
  9415. 'offsetms' parameter This patch allows starting playback of audio
  9416. through the CONTROL STREAM FILE AGI command to start at a
  9417. particular offset. It will also return the final position of the
  9418. file in the 'endpos' attribute. (closes issue ASTERISK-17803)
  9419. Reported by: Murray Melvin patches: res_agi.c.r316293.diff
  9420. uploaded by murraytm (license 6221)
  9421. 2013-07-31 15:43 +0000 [r395884] Mark Michelson <mmichelson@digium.com>
  9422. * res/res_pjsip/pjsip_options.c: Found another missed "sip" ->
  9423. "pjsip" CLI command.
  9424. 2013-07-31 15:27 +0000 [r395881] Kinsey Moore <kmoore@digium.com>
  9425. * tests/test_cel.c: Disable CEL tests that need rearchitecting to
  9426. operate properly
  9427. 2013-07-31 14:45 +0000 [r395868] Mark Michelson <mmichelson@digium.com>
  9428. * res/res_pjsip_endpoint_identifier_constant.c (removed): Remove
  9429. "constant" endpoint identifier. This was created as a debugging
  9430. tool before proper endpoint identifiers were created. Using it
  9431. now can actually lead to harmful results.
  9432. 2013-07-31 14:29 +0000 [r395866] Joshua Colp <jcolp@digium.com>
  9433. * bridges/bridge_native_rtp.c: Fix hold/unhold in
  9434. bridge_native_rtp, use tech_pvt instead of bridge_pvt, reduce
  9435. bridging attempts, and fix breaking native RTP bridges. (closes
  9436. issue ASTERISK-22128) (closes issue ASTERISK-22104)
  9437. 2013-07-31 13:31 +0000 [r395837-395851] Kinsey Moore <kmoore@digium.com>
  9438. * channels/chan_pjsip.c, include/asterisk/res_pjsip.h,
  9439. include/asterisk/res_pjsip_pubsub.h,
  9440. include/asterisk/res_pjsip_exten_state.h,
  9441. include/asterisk/res_pjsip_session.h, configs/pjsip.conf.sample,
  9442. res/res_pjsip/include/res_pjsip_private.h: Fix remnants of the
  9443. pjsip renaming
  9444. * tests/test_cel.c: Enforce conference exit order for CEL tests
  9445. 2013-07-30 22:41 +0000 [r395810-395824] Mark Michelson <mmichelson@digium.com>
  9446. * res/res_pjsip_endpoint_identifier_ip.c: Missed a conversion to
  9447. pjsip.conf in documentation and sorcery.
  9448. * main/abstract_jb.c: Remove ast_bridged_channel call from
  9449. abstract_jb.c Interestingly, this only happens in dead code.
  9450. 2013-07-30 20:44 +0000 [r395793] David M. Lee <dlee@digium.com>
  9451. * res/res_pjsip: Setting svn:ignore for res/res_pjsip
  9452. 2013-07-30 19:10 +0000 [r395748-395779] Mark Michelson <mmichelson@digium.com>
  9453. * res/res_pjsip_endpoint_identifier_constant.c: Update
  9454. res_pjsip_endpoint_identifier_constant.c to use reorganized
  9455. endpoint structure.
  9456. * res/res_sip_nat.c (removed),
  9457. res/res_pjsip_outbound_registration.c (added),
  9458. res/res_sip_session.c (removed),
  9459. res/res_pjsip_endpoint_identifier_anonymous.c (added),
  9460. res/res_sip_rfc3326.c (removed), res/res_pjsip_acl.c (added),
  9461. res/res_pjsip/pjsip_distributor.c (added),
  9462. res/res_sip_endpoint_identifier_constant.c (removed),
  9463. res/res_sip_mwi.c (removed), res/res_pjsip_diversion.c (added),
  9464. res/res_sip (removed), res/res_pjsip_dtmf_info.c (added),
  9465. res/res_sip_pubsub.c (removed),
  9466. include/asterisk/res_pjsip_exten_state.h (added),
  9467. res/res_pjsip_sdp_rtp.c (added), res/res_pjsip_messaging.c
  9468. (added), res/res_pjsip_registrar_expire.c (added),
  9469. res/res_pjsip_caller_id.c (added),
  9470. res/res_sip_authenticator_digest.c (removed),
  9471. res/res_sip_session.exports.in (removed),
  9472. res/res_pjsip_exten_state.c (added), res/res_sip_logger.c
  9473. (removed), res/res_sip.c (removed),
  9474. res/res_pjsip_pubsub.exports.in (added),
  9475. res/res_pjsip_endpoint_identifier_constant.c (added),
  9476. res/res_sip_outbound_registration.c (removed),
  9477. res/res_sip_endpoint_identifier_anonymous.c (removed),
  9478. res/res_pjsip_pubsub.c (added), res/res_pjsip/config_transport.c
  9479. (added), res/res_pjsip_transport_websocket.c (added),
  9480. res/res_pjsip_registrar.c (added), channels/chan_pjsip.c (added),
  9481. res/res_pjsip/pjsip_outbound_auth.c (added),
  9482. res/res_pjsip/config_global.c (added), res/res_sip_acl.c
  9483. (removed), res/res_sip_diversion.c (removed),
  9484. res/res_pjsip_authenticator_digest.c (added),
  9485. res/res_pjsip_session.exports.in (added), res/res_sip_dtmf_info.c
  9486. (removed), res/res_pjsip/config_domain_aliases.c (added),
  9487. include/asterisk/res_sip_session.h (removed), res/res_pjsip_t38.c
  9488. (added), res/res_sip_notify.c (removed), res/res_pjsip_logger.c
  9489. (added), res/res_pjsip/pjsip_options.c (added),
  9490. res/res_sip_endpoint_identifier_ip.c (removed),
  9491. res/res_sip_sdp_rtp.c (removed), res/res_sip_messaging.c
  9492. (removed), include/asterisk/res_pjsip_pubsub.h (added),
  9493. res/res_sip_caller_id.c (removed),
  9494. res/res_sip_endpoint_identifier_user.c (removed),
  9495. res/res_sip_pidf.c (removed),
  9496. res/res_pjsip_outbound_authenticator_digest.c (added),
  9497. res/res_sip_exten_state.c (removed),
  9498. res/res_pjsip_one_touch_record_info.c (added),
  9499. res/res_sip_pubsub.exports.in (removed), res/res_pjsip_refer.c
  9500. (added), include/asterisk/res_pjsip_session.h (added),
  9501. res/res_pjsip_notify.c (added), res/res_sip_transport_websocket.c
  9502. (removed), res/res_sip_registrar.c (removed),
  9503. res/res_pjsip_endpoint_identifier_ip.c (added),
  9504. include/asterisk/res_sip.h (removed),
  9505. res/res_pjsip/config_security.c (added), res/res_sip.exports.in
  9506. (removed), res/Makefile, res/res_sip_exten_state.exports.in
  9507. (removed), res/res_pjsip_endpoint_identifier_user.c (added),
  9508. res/res_pjsip/include (added), res/res_pjsip_pidf.c (added),
  9509. res/res_pjsip_nat.c (added), res/res_pjsip_session.c (added),
  9510. res/res_sip_t38.c (removed), channels/chan_gulp.c (removed),
  9511. res/res_pjsip/location.c (added), res/res_pjsip_rfc3326.c
  9512. (added), res/res_pjsip/config_system.c (added),
  9513. configs/pjsip.conf.sample (added),
  9514. include/asterisk/res_sip_pubsub.h (removed), res/res_pjsip_mwi.c
  9515. (added), res/res_pjsip/pjsip_configuration.c (added),
  9516. res/res_sip_outbound_authenticator_digest.c (removed),
  9517. res/res_pjsip (added), res/res_pjsip/include/res_pjsip_private.h
  9518. (added), res/res_sip_one_touch_record_info.c (removed),
  9519. include/asterisk/res_pjsip.h (added), res/res_pjsip/config_auth.c
  9520. (added), res/res_pjsip.exports.in (added),
  9521. configs/res_sip.conf.sample (removed), res/res_sip_refer.c
  9522. (removed), res/res_pjsip_exten_state.exports.in (added),
  9523. res/res_pjsip/security_events.c (added),
  9524. include/asterisk/res_sip_exten_state.h (removed),
  9525. res/res_pjsip/pjsip_global_headers.c (added), res/res_pjsip.c
  9526. (added), res/res_sip_registrar_expire.c (removed): The large
  9527. GULP->PJSIP renaming effort. The general gist is to have a clear
  9528. boundary between old SIP stuff and new SIP stuff by having the
  9529. word "SIP" for old stuff and "PJSIP" for new stuff. Here's a
  9530. brief rundown of the changes: * The word "Gulp" in dialstrings,
  9531. functions, and CLI commands is now "PJSIP" * chan_gulp.c is now
  9532. chan_pjsip.c * Function names in chan_gulp.c that were "gulp_*"
  9533. are now "chan_pjsip_*" * All files that were "res_sip*" are now
  9534. "res_pjsip*" * The "res_sip" directory is now "res_pjsip" * Files
  9535. in the "res_pjsip" directory that began with "sip_*" are now
  9536. "pjsip_*" * The configuration file is now "pjsip.conf" instead of
  9537. "res_sip.conf" * The module info for all PJSIP-related files now
  9538. uses "PJSIP" instead of "SIP" * CLI and AMI commands created by
  9539. Asterisk's PJSIP modules now have "pjsip" as the starting word
  9540. instead of "sip"
  9541. * res/res_sip/sip_options.c,
  9542. res/res_sip_outbound_authenticator_digest.c,
  9543. res/res_sip_outbound_registration.c, res/res_sip_mwi.c,
  9544. res/res_sip_one_touch_record_info.c, res/res_sip_pubsub.c,
  9545. res/res_sip_diversion.c, res/res_sip/sip_configuration.c,
  9546. include/asterisk/res_sip.h, res/res_sip/sip_distributor.c,
  9547. res/res_sip.exports.in, res/res_sip_authenticator_digest.c,
  9548. res/res_sip/sip_outbound_auth.c, res/res_sip_sdp_rtp.c,
  9549. res/res_sip_messaging.c, res/res_sip_t38.c, channels/chan_gulp.c,
  9550. res/res_sip_caller_id.c, res/res_sip.c, res/res_sip_nat.c,
  9551. res/res_sip_session.c: Reorganize the ast_sip_endpoint structure
  9552. into substructures. (closes issue ASTERISK-22135) reported by
  9553. Matt Jordan Review: https://reviewboard.asterisk.org/r/2707
  9554. 2013-07-30 14:16 +0000 [r395731] Joshua Colp <jcolp@digium.com>
  9555. * res/res_sip.c, res/res_sip/sip_configuration.c,
  9556. res/res_sip_session.c, include/asterisk/res_sip.h,
  9557. include/asterisk/res_sip_session.h,
  9558. res/res_sip_session.exports.in, channels/chan_gulp.c,
  9559. res/res_sip_t38.c (added): Add support for T.38 fax to
  9560. chan_pjsip. Review: https://reviewboard.asterisk.org/r/2692/
  9561. 2013-07-30 13:46 +0000 [r395728] Kinsey Moore <kmoore@digium.com>
  9562. * res/res_pktccops.c: Fix compilation on gcc 4.8.1
  9563. 2013-07-29 17:51 +0000 [r395686] David M. Lee <dlee@digium.com>
  9564. * res/parking/parking_devicestate.c, include/asterisk/mixmonitor.h,
  9565. main/mixmonitor.c: Removed quotes from svn:keywords props on a
  9566. few files. Subversion doesn't do quote processing, so it actually
  9567. thinks that the closing quote in 'Revision"' is a part of the
  9568. keyword.
  9569. 2013-07-29 16:16 +0000 [r395674] Mark Michelson <mmichelson@digium.com>
  9570. * res/res_sip.c: Clarify documentation for trust of identification.
  9571. (closes issue ASTERISK-22023) Reported by Rusty Newton
  9572. 2013-07-29 15:58 +0000 [r395672-395673] Matthew Jordan <mjordan@digium.com>
  9573. * main/loader.c: Put the include in there Mea culpa...
  9574. * main/loader.c: When performing a reload, reload the new
  9575. features_config and not the old Performing a module reload of
  9576. core components causes specific functions compiled into the
  9577. Asterisk binary to be reloaded. The table of said functions was
  9578. still pointing to the old features reload mechanism, and not the
  9579. new one.
  9580. 2013-07-29 14:51 +0000 [r395653] Kinsey Moore <kmoore@digium.com>
  9581. * tests/test_cel.c: Clean up and improve test_cel Improve
  9582. reliability of attended transfer merge and link tests. Stop using
  9583. ast_log(LOG_ERROR, ...); in favor of ast_test_status_update
  9584. Remove fred and eve channel helpers since they are not necessary
  9585. 2013-07-29 14:08 +0000 [r395636] David M. Lee <dlee@digium.com>
  9586. * res/ari: Set svn:ignore in res/ari directory
  9587. 2013-07-29 12:10 +0000 [r395619] Kinsey Moore <kmoore@digium.com>
  9588. * res/res_sip.c: Remove comment that no longer applies The monitor
  9589. thread is already properly torn down on unload and load failure.
  9590. 2013-07-27 23:11 +0000 [r395588-395603] Kinsey Moore <kmoore@digium.com>
  9591. * tests/test_ari_model.c, res/ari.make (added),
  9592. res/ari/resource_bridges.h (added), res/ari/resource_asterisk.c
  9593. (added), res/res_ari_endpoints.c (added),
  9594. res/res_stasis_http_sounds.c (removed),
  9595. res/ari/resource_asterisk.h (added), res/res_stasis_http.c
  9596. (removed), rest-api-templates/stasis_http_resource.h.mustache
  9597. (removed), res/res_ari.c (added),
  9598. rest-api-templates/make_ari_stubs.py,
  9599. rest-api-templates/ari_resource.h.mustache (added),
  9600. res/res_ari_asterisk.c (added), res/Makefile, res/ari/internal.h
  9601. (added), res/res_ari_model.c, res/res_stasis_http.exports.in
  9602. (removed), res/ari/resource_playback.c (added),
  9603. tests/test_stasis_http.c (removed), res/ari/resource_playback.h
  9604. (added), res/ari/resource_channels.c (added),
  9605. res/ari/ari_websockets.c (added), res/ari/resource_recordings.c
  9606. (added), res/ari/resource_channels.h (added), tests/test_ari.c
  9607. (added), res/ari/resource_endpoints.c (added),
  9608. res/ari/resource_events.c (added), res/ari/resource_recordings.h
  9609. (added), include/asterisk/stasis_http.h (removed),
  9610. res/res_ari_playback.c (added), res/ari/resource_endpoints.h
  9611. (added), res/ari/resource_events.h (added),
  9612. res/ari/resource_sounds.c (added), configs/ari.conf.sample,
  9613. include/asterisk/ari.h (added), res/res_ari_channels.c (added),
  9614. rest-api-templates/stasis_http.make.mustache (removed),
  9615. res/stasis_http.make (removed), res/ari/resource_sounds.h
  9616. (added), res/res_ari_recordings.c (added),
  9617. rest-api-templates/ari.make.mustache (added),
  9618. res/res_ari_events.c (added), res/res_statsd.c,
  9619. res/res_stasis_http_bridges.c (removed), res/res_ari_sounds.c
  9620. (added), rest-api-templates/ari_model_validators.c.mustache,
  9621. res/res_ari_bridges.c (added), res/res_stasis_http_asterisk.c
  9622. (removed), res/stasis_http (removed),
  9623. rest-api-templates/res_stasis_http_resource.c.mustache (removed),
  9624. main/stasis_config.c, rest-api-templates/rest_handler.mustache,
  9625. res/ari (added), rest-api-templates/res_ari_resource.c.mustache
  9626. (added), res/ari/ari_model_validators.c (added),
  9627. res/ari/ari_model_validators.h (added), res/res_ari.exports.in
  9628. (added), rest-api-templates/stasis_http_resource.c.mustache
  9629. (removed), res/ari/config.c (added),
  9630. rest-api-templates/ari_resource.c.mustache (added), res/ari/cli.c
  9631. (added), res/res_stasis_http_playback.c (removed),
  9632. rest-api-templates/ari_model_validators.h.mustache,
  9633. res/res_stasis_http_channels.c (removed),
  9634. res/res_ari_model.exports.in, res/res_stasis_http_recordings.c
  9635. (removed), res/res_stasis_http_endpoints.c (removed),
  9636. res/ari/resource_bridges.c (added), res/res_stasis_http_events.c
  9637. (removed): Rename everything Stasis-HTTP to ARI This renames all
  9638. files and API calls from several variants of Stasis-HTTP to ARI
  9639. including: * Stasis-HTTP -> ARI * STASIS_HTTP -> ARI *
  9640. stasis_http -> ari (ast_ari for global symbols, file names as
  9641. well) * stasis http -> ARI Review:
  9642. https://reviewboard.asterisk.org/r/2706/ (closes issue
  9643. ASTERISK-22136)
  9644. * tests/test_cel.c: Improve reliability of bridge merge CEL test
  9645. 2013-07-26 21:34 +0000 [r395559-395574] Richard Mudgett <rmudgett@digium.com>
  9646. * bridges/bridge_builtin_features.c, main/parking.c, main/bridge.c,
  9647. main/bridge_basic.c, main/features.c,
  9648. bridges/bridge_builtin_interval_features.c,
  9649. apps/app_bridgewait.c, apps/app_confbridge.c,
  9650. include/asterisk/bridge_features.h, include/asterisk/parking.h,
  9651. main/bridge_channel.c, res/parking/parking_bridge_features.c,
  9652. apps/app_agent_pool.c, apps/confbridge/conf_config_parser.c:
  9653. Remove the unsafe bridge parameter from
  9654. ast_bridge_hook_callback's. Most hook callbacks did not need the
  9655. bridge parameter. The pointer value could become invalid if the
  9656. channel is moved to another bridge while it is executing. * Fixed
  9657. some issues in feature_attended_transfer() as a result. * Reduce
  9658. the bridge inhibit count in
  9659. attended_transfer_properties_shutdown() after it has restored the
  9660. bridge channel hooks. * Removed basic bridge requirement on
  9661. feature_blind_transfer(). It does not require the basic bridge
  9662. like feature_attended_transfer().
  9663. * include/asterisk/bridge_features.h,
  9664. res/parking/parking_bridge_features.c, main/bridge.c,
  9665. bridges/bridge_builtin_interval_features.c,
  9666. apps/app_bridgewait.c: Improved feature limits interval hook
  9667. implementaion. * Fixed feature limits to not use special members
  9668. of struct ast_bridge_features. * Fixed memory leak in off nominal
  9669. paths of bridge_builtin_set_limits(). * Fixed off nominal path in
  9670. ast_bridge_features_limits_construct() freeing unallocated memory
  9671. if it was not called by bridge_builtin_set_limits(). * Made
  9672. bridge_builtin_interval_features.so unloadable. * Simplified
  9673. parking's use of its duration interval hook. * Made BridgeWait S
  9674. option not depend upon another module being loaded. (closes issue
  9675. ASTERISK-22107) Reported by: Matt Jordan Review:
  9676. https://reviewboard.asterisk.org/r/2701/
  9677. 2013-07-26 17:42 +0000 [r395527] David M. Lee <dlee@digium.com>
  9678. * res/stasis_http/resource_events.c, res/stasis/app.c: Fix
  9679. /stasis/res/app_replaced unit test. A typo in recent changes
  9680. caused the JSON ApplicationReplaced message to fail to build, so
  9681. the message wasn't being sent out the WebSocket. Related, the
  9682. replaced application would also unregister itself when it
  9683. disconnected, which would actually unregister the new
  9684. application. This was also fixed.
  9685. 2013-07-26 16:34 +0000 [r395509] Jonathan Rose <jrose@digium.com>
  9686. * main/bridge_channel.c, include/asterisk/bridge.h,
  9687. include/asterisk/bridge_channel_internal.h, main/bridge.c,
  9688. apps/app_bridgewait.c: Add name argument to BridgeWait() so
  9689. multiple holding bridges may be used Changes arguments for
  9690. BridgeWait from BridgeWait(role, options) to
  9691. BridgeWait(bridge_name, role, options). Now multiple holding
  9692. bridges may be created and referenced by this application.
  9693. (closes issue ASTERISK-21922) Reported by: Matt Jordan Review:
  9694. https://reviewboard.asterisk.org/r/2642/
  9695. 2013-07-26 00:03 +0000 [r395466-395477] Richard Mudgett <rmudgett@digium.com>
  9696. * apps/app_bridgewait.c: Remove some unnecessary parentheses.
  9697. * bridges/bridge_builtin_interval_features.c: Revision
  9698. 2013-07-25 20:54 +0000 [r395439-395455] Joshua Colp <jcolp@digium.com>
  9699. * res/res_sip_session.c: Fix crash due to trying to send a
  9700. re-invite while in the incorrect state. This crash would occur if
  9701. a re-invite was queued while the initial INVITE transaction was
  9702. still occurring and the response to the INVITE was not ACKed.
  9703. This lack of ACK would cause the INVITE session state to never
  9704. reach confirmed. Once the transaction terminated, however, the
  9705. queued re-invite would occur and cause a crash due to this lack
  9706. of state change. This fix checks the INVITE session state before
  9707. performing the re-invite to ensure it is in the required
  9708. confirmed state.
  9709. * res/res_sip.c, res/res_sip/sip_configuration.c: Change the
  9710. default value for "allowsubscribe" to yes to match chan_sip.
  9711. 2013-07-25 18:27 +0000 [r395430] Richard Mudgett <rmudgett@digium.com>
  9712. * main/stasis_bridges.c, include/asterisk/bridge_after.h,
  9713. include/asterisk/bridge_channel_internal.h,
  9714. main/manager_bridges.c, include/asterisk/bridge_channel.h,
  9715. main/bridge_after.c, include/asterisk/bridge_technology.h,
  9716. include/asterisk/bridge_internal.h,
  9717. include/asterisk/bridge_features.h, main/bridge_channel.c,
  9718. include/asterisk/bridge.h, include/asterisk/bridge_basic.h,
  9719. include/asterisk/bridge_roles.h, main/bridge.c,
  9720. main/bridge_basic.c, include/asterisk/stasis_bridges.h,
  9721. main/bridge_roles.c: Restore bridging files history.
  9722. 2013-07-25 15:29 +0000 [r395367-395410] Matthew Jordan <mjordan@digium.com>
  9723. * main/features.c, include/asterisk/features.h: Remove some dead
  9724. parking call Since nothing is using these global parking
  9725. functions, remove them! The first of many.
  9726. * main/features.c: Remove dead bridging code from features This
  9727. removes the previously #if 0'd code. The functionality removed
  9728. has either been subsumed by the Bridging API or is no longer
  9729. applicable.
  9730. * main/cli.c, main/cdr.c, main/manager_bridges.c, main/manager.c,
  9731. res/stasis_http/resource_bridges.c, tests/test_cel.c,
  9732. res/res_stasis.c, main/stasis_bridges.c, tests/test_cdr.c: Fix
  9733. incorrect reference to stasis/bridging.h
  9734. * include/asterisk/stasis_bridges.h (added),
  9735. include/asterisk/bridging_after.h (removed),
  9736. bridges/bridge_simple.c, main/core_local.c,
  9737. res/parking/parking_bridge_features.c,
  9738. res/parking/parking_bridge.c, main/cli.c, main/manager_bridges.c
  9739. (added), include/asterisk/bridging_technology.h (removed),
  9740. apps/confbridge/include/confbridge.h, channels/chan_skinny.c,
  9741. include/asterisk/bridging_features.h (removed),
  9742. main/bridge_after.c (added), main/stasis_channels.c,
  9743. include/asterisk/bridge_features.h (added), main/bridge_channel.c
  9744. (added), res/parking/parking_manager.c, channels/chan_mgcp.c,
  9745. channels/chan_unistim.c, include/asterisk/bridge_roles.h (added),
  9746. channels/chan_bridge_media.c, main/bridge.c (added),
  9747. res/parking/parking_controller.c, apps/app_bridgewait.c,
  9748. res/stasis_http/resource_bridges.c,
  9749. res/parking/parking_applications.c,
  9750. include/asterisk/bridging_channel_internal.h (removed),
  9751. main/cel.c, apps/app_queue.c, include/asterisk/stasis_bridging.h
  9752. (removed), main/stasis_bridges.c (added), main/bridging_after.c
  9753. (removed), res/res_stasis_bridge_add.c,
  9754. include/asterisk/bridge_channel_internal.h (added),
  9755. channels/chan_dahdi.c, channels/sig_analog.c,
  9756. include/asterisk/bridging_internal.h (removed),
  9757. apps/confbridge/confbridge_manager.c, main/manager_bridging.c
  9758. (removed), tests/test_cel.c, include/asterisk/bridge_internal.h
  9759. (added), include/asterisk/bridging_roles.h (removed),
  9760. apps/confbridge/conf_chan_announce.c,
  9761. include/asterisk/bridge_basic.h (added),
  9762. include/asterisk/core_unreal.h, main/parking.c,
  9763. res/stasis/control.c, bridges/bridge_holding.c,
  9764. channels/chan_sip.c, bridges/bridge_softmix.c,
  9765. main/bridge_roles.c (added), channels/chan_iax2.c,
  9766. apps/app_agent_pool.c, include/asterisk/bridging_channel.h
  9767. (removed), apps/confbridge/conf_config_parser.c,
  9768. include/asterisk/features.h, main/channel.c,
  9769. res/parking/res_parking.h, main/manager.c, channels/chan_misdn.c,
  9770. main/stasis_bridging.c (removed), include/asterisk/bridging.h
  9771. (removed), bridges/bridge_builtin_interval_features.c,
  9772. include/asterisk/bridging_basic.h (removed),
  9773. include/asterisk/bridge_technology.h (added),
  9774. bridges/bridge_native_rtp.c, tests/test_cdr.c,
  9775. include/asterisk/doxygen/architecture.h, main/bridging_roles.c
  9776. (removed), res/res_sip_refer.c, main/bridge_basic.c (added),
  9777. apps/confbridge/conf_chan_record.c, main/core_unreal.c,
  9778. channels/sig_pri.c, include/asterisk/bridge_after.h (added),
  9779. bridges/bridge_builtin_features.c,
  9780. channels/dahdi/bridge_native_dahdi.c,
  9781. res/stasis_http/resource_channels.c,
  9782. include/asterisk/bridge_channel.h (added), funcs/func_channel.c,
  9783. main/bridging_channel.c (removed), apps/app_dumpchan.c,
  9784. main/features.c, apps/app_confbridge.c, include/asterisk/bridge.h
  9785. (added), main/bridging.c (removed), main/bridging_basic.c
  9786. (removed), apps/app_dial.c: A great big renaming patch This patch
  9787. renames the bridging* files to bridge*. This may seem pedantic
  9788. and silly, but it fits better in line with current Asterisk
  9789. naming conventions: * channel is not "channeling" * monitor is
  9790. not "monitoring" etc. A bridge is an object. It is a first class
  9791. citizen in Asterisk. "Bridging" is the act of using a bridge on a
  9792. set of channels - and the API that fulfills that role is more
  9793. than just the action. (closes issue ASTERISK-22130)
  9794. * include/asterisk/bridging_features.h, funcs/func_channel.c,
  9795. main/bridging_channel.c, main/features.c,
  9796. include/asterisk/bridging.h,
  9797. bridges/bridge_builtin_interval_features.c, main/bridging.c,
  9798. main/bridging_basic.c, apps/app_dial.c,
  9799. include/asterisk/bridging_after.h (added),
  9800. bridges/bridge_softmix.c,
  9801. include/asterisk/bridging_channel_internal.h, apps/app_queue.c,
  9802. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  9803. include/asterisk/bridging_channel.h, main/bridging_after.c
  9804. (added), include/asterisk/bridging_technology.h,
  9805. include/asterisk/bridging_internal.h,
  9806. bridges/bridge_builtin_features.c: Move after bridge callbacks
  9807. into their own file One more major refactoring to go.
  9808. 2013-07-25 00:44 +0000 [r395351] Joshua Colp <jcolp@digium.com>
  9809. * res/res_sip/sip_distributor.c, channels/chan_gulp.c,
  9810. res/res_sip_session.c: Improve initial INVITE handling and fix
  9811. crash due to rapidly arriving CANCEL. (closes issue
  9812. ASTERISK-22150) Review: https://reviewboard.asterisk.org/r/2696/
  9813. 2013-07-24 23:40 +0000 [r395316-395340] Richard Mudgett <rmudgett@digium.com>
  9814. * main/bridging.c, include/asterisk/bridging_features.h,
  9815. main/bridging_channel.c,
  9816. include/asterisk/bridging_channel_internal.h: Simplify interval
  9817. hooks since there is only one bridge threading model now. *
  9818. Convert interval timers to use the ast_waitfor_nandfds() timeout.
  9819. * Remove bridge channel action for intervals. Now the main loop
  9820. handles running interval hooks.
  9821. * main/bridging.c, include/asterisk/bridging_features.h,
  9822. main/bridging_channel.c, apps/app_confbridge.c: Refactor
  9823. ast_bridge_features struct. * Reduced the number of hook
  9824. containers to just dtmf_hooks, interval_hooks, and other_hooks.
  9825. As a result, several functions dealing with the different hook
  9826. containers could be combined. * Extended the generic hook struct
  9827. for DTMF and interval hooks instead of using a variant record. *
  9828. Merged the special talk detector hook into the other_hooks
  9829. container. * Replaced ast_bridge_features_set_talk_detector()
  9830. with ast_bridge_talk_detector_hook(). (issue ASTERISK-22107)
  9831. * main/features.c: * Refactor setup_bridge_features_builtin(). *
  9832. Add an error message so you know when a feature is not available
  9833. and you tried to use it. It usually means the module has not been
  9834. loaded.
  9835. 2013-07-24 19:32 +0000 [r395295-395298] Matthew Jordan <mjordan@digium.com>
  9836. * main/asterisk.exports.in: Export exports.in as well Because is is
  9837. rather needed.
  9838. * main/bridging.c, res/parking/parking_bridge_features.c,
  9839. apps/app_agent_pool.c, include/asterisk/bridging_channel.h,
  9840. main/bridging_basic.c, bridges/bridge_builtin_features.c,
  9841. include/asterisk/bridging_features.h, main/bridging_channel.c,
  9842. bridges/bridge_builtin_interval_features.c,
  9843. include/asterisk/bridging_channel_internal.h: Update
  9844. bridge_channel refactorings; export bridge_ symbol
  9845. 2013-07-24 18:51 +0000 [r395283] Jason Parker <jparker@digium.com>
  9846. * contrib/scripts/install_prereq: Add pjproject to install_prereq.
  9847. Also fixes spacing, in passing. (closes issue ASTERISK-22131)
  9848. 2013-07-24 18:08 +0000 [r395267-395271] Kinsey Moore <kmoore@digium.com>
  9849. * res/res_sip.c: Tweak another magic number
  9850. * main/manager_bridging.c: Make AMI BridgeInfo action more verbose
  9851. Ensure that the BridgeInfo command provides adequate state
  9852. information about channels by publishing the full channel
  9853. snapshot for BridgeInfoChannel subevents. This prevents a
  9854. two-stage lookup since most consumers will be keying on channel
  9855. names instead of uniqueids. (closes issue ASTERISK-22140)
  9856. * res/res_sip/sip_global_headers.c: Tweak a magic number (closes
  9857. issue ASTERISK-22146)
  9858. 2013-07-24 16:01 +0000 [r395254-395255] Richard Mudgett <rmudgett@digium.com>
  9859. * main/bridging_channel.c,
  9860. include/asterisk/bridging_channel_internal.h,
  9861. include/asterisk/bridging_channel.h, main/channel.c: Add missing
  9862. end-of-file line terminators.
  9863. * bridges/bridge_native_rtp.c: Add missing line terminator to debug
  9864. message.
  9865. 2013-07-24 15:38 +0000 [r395253] Matthew Jordan <mjordan@digium.com>
  9866. * include/asterisk/bridging_channel_internal.h (added),
  9867. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  9868. include/asterisk/bridging_channel.h (added),
  9869. res/parking/parking_bridge.c, include/asterisk/features.h,
  9870. main/channel.c, include/asterisk/bridging_technology.h,
  9871. include/asterisk/bridging_internal.h,
  9872. bridges/bridge_builtin_features.c, main/bridging_channel.c
  9873. (added), main/features.c, include/asterisk/bridging.h,
  9874. bridges/bridge_builtin_interval_features.c, main/bridging.c,
  9875. main/bridging_basic.c, include/asterisk/channel.h: Perform the
  9876. initial renaming of the Bridging API This patch does the
  9877. following: * It pulls out bridge_channel and puts it into its own
  9878. translation unit * It adds public and protected headers for
  9879. bridging_channel. Protected functions are appropriate only for
  9880. the Bridging API and sub-classes of a bridge. (issue
  9881. ASTERISK-22130)
  9882. 2013-07-24 14:35 +0000 [r395243] Richard Mudgett <rmudgett@digium.com>
  9883. * main/bridging.c: Let the compiler do more type checking with
  9884. bridge hook callbacks.
  9885. 2013-07-23 22:32 +0000 [r395227] Joshua Colp <jcolp@digium.com>
  9886. * bridges/bridge_native_rtp.c: Fix a check in bridge_native_rtp
  9887. which determined if attaching the framehook failed or not.
  9888. 2013-07-23 21:32 +0000 [r395215] Jonathan Rose <jrose@digium.com>
  9889. * funcs/func_channel.c, include/asterisk/bridging_basic.h,
  9890. main/bridging_basic.c: func_channel: dtmf_features setting Allows
  9891. reading andsetting dtmf features via a channel function
  9892. CHANNEL(dtmf_features) (closes issue ASTERISK-21876) Reported by:
  9893. Matt Jordan Review: https://reviewboard.asterisk.org/r/2648/
  9894. 2013-07-23 21:14 +0000 [r395203-395205] Joshua Colp <jcolp@digium.com>
  9895. * bridges/bridge_native_rtp.c: Add some debug messages to make it
  9896. clear what RTP bridging functionality is in use.
  9897. * bridges/bridge_native_rtp.c: Fix some logic so native RTP bridge
  9898. will occur when monitor, audiohooks, or framehooks are not
  9899. present.
  9900. 2013-07-23 19:14 +0000 [r395188] Richard Mudgett <rmudgett@digium.com>
  9901. * bridges/bridge_softmix.c, main/bridging.c,
  9902. include/asterisk/bridging.h: Pull softmix bridge parameters into
  9903. a sub structure.
  9904. 2013-07-23 18:41 +0000 [r395183] Joshua Colp <jcolp@digium.com>
  9905. * channels/chan_gulp.c: Drop the reference count on the correct
  9906. object.
  9907. 2013-07-23 18:41 +0000 [r395154-395182] Richard Mudgett <rmudgett@digium.com>
  9908. * channels/chan_dahdi.c, main/utils.c: Reinclude sys/stat.h in
  9909. chan_dahdi.c and remove redundant include in utils.c
  9910. * channels/chan_dahdi.h, channels/chan_mgcp.c,
  9911. channels/chan_dahdi.c, channels/dahdi/bridge_native_dahdi.c: Some
  9912. chan_dahdi protected function renaming. analog_lib_handles -->
  9913. dahdi_analog_lib_handles enable_dtmf_detect -->
  9914. dahdi_dtmf_detect_enable disable_dtmf_detect -->
  9915. dahdi_dtmf_detect_disable dahdi_enable_ec --> dahdi_ec_enable
  9916. dahdi_disable_ec --> dahdi_ec_disable update_conf -->
  9917. dahdi_conf_update dahdi_link --> dahdi_master_slave_link
  9918. dahdi_unlink --> dahdi_master_slave_unlink (closes issue
  9919. ASTERISK-22129) Reported by: rmudgett
  9920. * channels/chan_dahdi.c, channels/dahdi/bridge_native_dahdi.c,
  9921. channels/chan_dahdi.h (added), channels/dahdi (added),
  9922. channels/dahdi/bridge_native_dahdi.h, bridges/bridge_softmix.c,
  9923. channels/Makefile, main/bridging.c: Restore chan_dahdi native
  9924. bridging and PRI tromboned call elimination. Created a
  9925. native_dahdi bridging technology for use with the new bridging
  9926. API. The new bridging technology is part of the chan_dahdi
  9927. channel driver because it is very specific to that driver. Rather
  9928. than include the new code directly into chan_dahdi.c the new
  9929. bridge technology is in its own file and linked into
  9930. chan_dahdi.so. A large part of this change is the mechanical
  9931. process of moving declarations around so chan_dahdi.c can be
  9932. split up into more files later. * Changed the bridging core to
  9933. pass NULL frames into the channel technologies instead of
  9934. discarding them. The channel technologies may need the proding to
  9935. determine if their configuration is still valid. (closes issue
  9936. ASTERISK-21886) Reported by: Matt Jordan Review:
  9937. https://reviewboard.asterisk.org/r/2681/
  9938. 2013-07-23 15:28 +0000 [r395151] Mark Michelson <mmichelson@digium.com>
  9939. * main/bridging_roles.c, include/asterisk/bridging_internal.h
  9940. (added), bridges/bridge_builtin_features.c,
  9941. main/stasis_bridging.c, include/asterisk/bridging_features.h,
  9942. include/asterisk/features_config.h, include/asterisk/bridging.h,
  9943. main/features.c, include/asterisk/bridging_roles.h, main/cel.c,
  9944. main/features_config.c, include/asterisk/stasis_bridging.h,
  9945. main/bridging.c, main/bridging_basic.c: Make DTMF attended
  9946. transfer support feature-complete. This greatly modifies the
  9947. operation of DTMF attended transfers so that the full range of
  9948. options from features.conf applies. In addition, a new option has
  9949. been added that allows for a transferer to switch between bridges
  9950. during a transfer before completing the transfer. (closes issue
  9951. ASTERISK-21543) reported by Matt Jordan Review:
  9952. https://reviewboard.asterisk.org/r/2654
  9953. 2013-07-23 14:57 +0000 [r395136] David M. Lee <dlee@digium.com>
  9954. * res/res_stasis_http_channels.c, res/res_stasis_http_sounds.c,
  9955. res/res_stasis_http_bridges.c, res/res_stasis_http_recordings.c,
  9956. res/res_stasis_http.c, res/res_stasis_http_endpoints.c,
  9957. res/res_stasis_http_asterisk.c, res/res_stasis_http_playback.c,
  9958. rest-api-templates/res_stasis_http_resource.c.mustache: No more
  9959. teapots. Now that the ARI implementation is nearing some
  9960. definition of completeness, we should properly respond with 501's
  9961. for unimplemented functionality, instead of the almost humorous
  9962. 418.
  9963. 2013-07-23 14:49 +0000 [r395135] Matthew Jordan <mjordan@digium.com>
  9964. * main/channel.c: Kill the zombies In previous versions of
  9965. Asterisk, the zombies roamed freely, unchecked and uncontrolled.
  9966. They ravaged Asterisk systems with their biting and their nashing
  9967. and their pointy teeth. Sometimes, you couldn't even hang them
  9968. up. Now, zombies are rare. They still *technically* exist in
  9969. certain places, but they are controlled. Kind of like a zombie
  9970. zoo: you can see them, but you can't touch them, and they can't
  9971. touch you. Bring your kids! Because zombies are now population
  9972. controlled with a very short lifespan, there's no reason to
  9973. rename the channels to '%s<ZOMBIE>'. The channels are guaranteed
  9974. to die off quickly; the rename really is just confusing at this
  9975. point. This patch finally removes the renaming. On the plus side:
  9976. this made my life easier in CDRs during call pickup and attended
  9977. transfers to an Asterisk application. It will make other folks
  9978. lives easier as well! Review:
  9979. https://reviewboard.astierks.org/r/2690/ (closes issue
  9980. ASTERISK-21699) Reported by: Matt Jordan
  9981. 2013-07-23 13:52 +0000 [r395121] Kinsey Moore <kmoore@digium.com>
  9982. * res/res_sip_sdp_rtp.c, channels/chan_gulp.c, res/res_sip.c,
  9983. channels/chan_sip.c, res/res_sip/sip_configuration.c,
  9984. res/res_sip_session.c, include/asterisk/res_sip.h,
  9985. include/asterisk/res_sip_session.h: Add DTLS-SRTP support to
  9986. chan_pjsip This patch introduces DTLS-SRTP support to chan_pjsip
  9987. and the options necessary to configure it including an option to
  9988. allow choosing between 32 and 80 byte SRTP tag lengths. During
  9989. the implementation and testing of this patch, three other bugs
  9990. were found and their fixes are included with this patch. The two
  9991. in chan_sip were a segfault relating to DTLS setup and mistaken
  9992. call rejection. The third bug fix prevents chan_pjsip from
  9993. attempting to perform bridge optimization between two endpoints
  9994. if either of them is running any form of SRTP. Review:
  9995. https://reviewboard.asterisk.org/r/2683/ (closes issue
  9996. ASTERISK-21419)
  9997. 2013-07-23 13:42 +0000 [r395118-395120] David M. Lee <dlee@digium.com>
  9998. * res/stasis/app.h, res/res_stasis.c, res/stasis/app.c: Continue
  9999. events when ARI WebSocket reconnects This patch addresses a bug
  10000. in the /ari/events WebSocket in handling reconnects. When a
  10001. Stasis application's associated WebSocket was disconnected and
  10002. reconnected, it would not receive events for any channels or
  10003. bridges it was subscribed to. The fix was to lazily clean up
  10004. Stasis application registrations, instead of removing them as
  10005. soon as the WebSocket goes away. When an application is
  10006. unregistered at the WebSocket level, the underlying application
  10007. is simply deactivated. If the application WebSocket is
  10008. reconnected, the application is reactivated for the new
  10009. connection. To avoid memory leaks from lingering, unused
  10010. application, the application list is cleaned up whenever new
  10011. applications are registered/unregistered. (closes issue
  10012. ASTERISK-21970) Review: https://reviewboard.asterisk.org/r/2678/
  10013. * main/manager_bridging.c,
  10014. include/asterisk/stasis_message_router.h, tests/test_stasis.c,
  10015. main/manager_channels.c, main/cdr.c,
  10016. main/stasis_message_router.c: Fix bridge/channel AMI event
  10017. ordering issues The stasis_cache_update messages are somewhat
  10018. cumbersome to handle with the stasis_message_router. Since all
  10019. updates have the same message type, they are normally handled
  10020. with the same route. Since caching itself is a first class
  10021. component of stasis-core, it makes sense for the router to handle
  10022. the cache update messages itself. This patch adds
  10023. stasis_message_router_add_cache_update() and
  10024. stasis_message_router_remove_cache_update() to handle the routing
  10025. of stasis_cache_update messages. This patch also corrects an
  10026. issue with manager_{bridging,channels}.c, where events might be
  10027. reordered. The reordering occurs because the components use
  10028. different message routers, which they needed because they both
  10029. needed to route cache update messages. They now both use
  10030. manager's router, and add cache routes for just the cache updates
  10031. they are interested in. (closes issue ASTERISK-22038) Review:
  10032. https://reviewboard.asterisk.org/r/2677/
  10033. 2013-07-23 12:56 +0000 [r395107] Kinsey Moore <kmoore@digium.com>
  10034. * res/res_sip/sip_options.c: Add missing newline
  10035. 2013-07-23 12:27 +0000 [r395102] Joshua Colp <jcolp@digium.com>
  10036. * channels/chan_gulp.c, res/res_sip_session.c,
  10037. include/asterisk/res_sip_session.h,
  10038. res/res_sip_session.exports.in: Expose the chan_pjsip
  10039. implementation pvt and session in a defined manner. This allows
  10040. modules outside of chan_pjsip itself to get the session given
  10041. only an Asterisk channel. Review:
  10042. https://reviewboard.asterisk.org/r/2674/
  10043. 2013-07-23 00:16 +0000 [r395089] Matthew Jordan <mjordan@digium.com>
  10044. * main/cdr.c: Fix unbalanced lock when serializing CDR variables
  10045. I'm only surprised that this didn't cause larger problems.
  10046. 2013-07-23 00:02 +0000 [r395088] Richard Mudgett <rmudgett@digium.com>
  10047. * main/bridging.c: Remove some BUGBUG notes that have been handled.
  10048. 2013-07-22 20:42 +0000 [r395074] Kinsey Moore <kmoore@digium.com>
  10049. * tests/test_cel.c: Make the CEL blind transfer test pass
  10050. consistently
  10051. 2013-07-22 13:52 +0000 [r394881-395034] Matthew Jordan <mjordan@digium.com>
  10052. * /, main/asterisk.c: Update copyright year to 2013 in asterisk.c;
  10053. some whitespace fixes (closes issue ASTERISK-22179) Reported by:
  10054. Malcolm Davenport ........ Merged revisions 395032 from
  10055. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10056. revisions 395033 from
  10057. http://svn.asterisk.org/svn/asterisk/branches/11
  10058. * funcs/func_channel.c, /: Clean up documentation This patch cleans
  10059. up documentation in func_channel for the following items: *
  10060. rtpsource * secure_signaling * secure_media * various OOH323
  10061. parameters (closes issue ASTERISK-20969) Reported by: snuffy
  10062. patches: func_chan-update.diff uploaded by snuffy (License 5024)
  10063. ........ Merged revisions 394980 from
  10064. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10065. revisions 394981 from
  10066. http://svn.asterisk.org/svn/asterisk/branches/11
  10067. * /, configs/indications.conf.sample: Provide proper ring tone in
  10068. indications.conf for Malaysia The ring tone provided in the
  10069. sample indications.conf was incorrect. This patch modifies the
  10070. sample ring tone to be what it should: ring =
  10071. 425/400,0/200,425/400,0/2000 This brings it in line with the tone
  10072. definition in DAHDI 2.7.0. (zonedata.c) (closes issue
  10073. ASTERISK-21997) Reported by: Filip Jenicek patches:
  10074. malaysia_ring.patch uploaded by phill (License 6277) ........
  10075. Merged revisions 394940 from
  10076. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10077. revisions 394941 from
  10078. http://svn.asterisk.org/svn/asterisk/branches/11
  10079. * contrib/scripts/safe_asterisk, Makefile,
  10080. configs/safe_asterisk.conf.sample (added), CHANGES: Always
  10081. install safe_asterisk; add configuration file support This patch
  10082. modifies the behavior of safe_asterisk in two ways: (1) It
  10083. modifies the Asterisk Makefile such that safe_asterisk is always
  10084. installed on a 'make install'. This was done as bugfixes in the
  10085. safe_asterisk script were not applied in previous version of
  10086. Asterisk without first removing the old version of the script.
  10087. (2) In order to keep a newly installed version of safe_asterisk
  10088. from impacting local modifications, a new config file -
  10089. safe_asterisk.conf.sample - has been provided. Settings that were
  10090. previously modified in safe_asterisk can be set there instead.
  10091. (closes issue ASTERISK-21965) Reported by: Jeremy Kister patches:
  10092. safe_asterisk.patch uploaded by jkister (License 6232)
  10093. * /, main/http.c: Tolerate presence of RFC2965 Cookie2 header by
  10094. ignoring it This patch modifies parsing of cookies in Asterisk's
  10095. http server by doing an explicit comparison of the "Cookie"
  10096. header instead of looking at the first 6 characters to determine
  10097. if the header is a cookie header. This avoids parsing "Cookie2"
  10098. headers and overwriting the previously parsed "Cookie" header.
  10099. Note that we probably should be appending the cookies in each
  10100. "Cookie" header to the parsed results; however, while clients can
  10101. send multiple cookie headers they never really do. While this
  10102. patch doesn't improve Asterisk's behavior in that regard, it
  10103. shouldn't make it any worse either. Note that the solution in
  10104. this patch was pointed out on the issue by the issue reporter,
  10105. Stuart Henderson. (closes issue ASTERISK-21789) Reported by:
  10106. Stuart Henderson Tested by: mjordan, Stuart Henderson ........
  10107. Merged revisions 394899 from
  10108. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10109. revisions 394900 from
  10110. http://svn.asterisk.org/svn/asterisk/branches/11
  10111. * /, contrib/realtime/postgresql/realtime.sql: Update PostgreSQL
  10112. realtime scripts with schema for queue_log table This patch
  10113. updates the realtime SQL scripts with an entry that will create
  10114. the queue_log table. This brings the PostgreSQL scripts inline
  10115. with the MySQL scripts, with respect to what tables they will
  10116. create. (closes issue ASTERISK-21021) Reported by: Eugene
  10117. patches: queue_log.sql uploaded by varnav (license 6360) ........
  10118. Merged revisions 394896 from
  10119. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10120. revisions 394897 from
  10121. http://svn.asterisk.org/svn/asterisk/branches/11
  10122. * channels/iax2/parser.c: Add additional control frame types to the
  10123. IAX2 parser for debug messages This patch adds some of the more
  10124. recent control frame types to the IAX2 parser. When IAX2
  10125. debugging is enabled, it will now show more of the control frame
  10126. types. (closes issue ASTERISK-22120) Reported by: Birger "WIMPy"
  10127. Harzenetter patches: iaxcmds.diff uploaded by wimpy
  10128. * /, configs/iax.conf.sample: Document connectedline parameter for
  10129. chan_iax2 The connectedline parameter for a chan_iax2 peer was
  10130. undocumented. This patch documents the options in the sample
  10131. configuration file. (closes issue ASTERISK-21953) Reported by:
  10132. Birger "WIMPy" Harzenetter ........ Merged revisions 394886 from
  10133. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10134. revisions 394890 from
  10135. http://svn.asterisk.org/svn/asterisk/branches/11
  10136. * main/manager.c, CHANGES: Allow setting allowmultiplelogin on an
  10137. account basis This patch modifies manager to allow the
  10138. allowmultiplelogin setting to be set on an account by account
  10139. basis. When set in the general context, it will act as the
  10140. default for the defined accounts. Setting it in the account will
  10141. override the general setting. (closes issue ASTERISK-21324)
  10142. Reported by: vldmr patches:
  10143. asterisk-manager-per-user-allowmultiplelogin.patch uploaded by
  10144. vldmr (License 6487)
  10145. 2013-07-20 13:25 +0000 [r394858-394870] Kinsey Moore <kmoore@digium.com>
  10146. * include/asterisk/cel.h, tests/test_cel.c, CHANGES, main/cel.c,
  10147. main/asterisk.c: Add CEL local optimization record type This adds
  10148. a new CEL event type, AST_CEL_LOCAL_OPTIMIZE, to represent local
  10149. channel optimizations. Local channel optimizations were one of
  10150. several things conveyed by the now defunct BRIDGE_UPDATE event
  10151. type. This also adds a unit test to test generation of this new
  10152. CEL event. Review: https://reviewboard.asterisk.org/r/2676/
  10153. * tests/test_cel.c, CHANGES, apps/app_queue.c, main/cel.c,
  10154. apps/app_dial.c, main/channel.c, channels/chan_dahdi.c,
  10155. main/pbx.c, channels/sig_analog.c, channels/chan_sip.c,
  10156. include/asterisk/cel.h, apps/app_celgenuserevent.c,
  10157. apps/app_directed_pickup.c, main/features.c: Add transfer support
  10158. to CEL This adds CEL support for blind and attended transfers and
  10159. call pickup. During the course of adding this functionality I
  10160. noticed that CONF_ENTER, CONF_EXIT, and BRIDGE_TO_CONF events are
  10161. particularly useless without a bridge identifier, so I added that
  10162. as well. This adds tests for blind transfers, several types of
  10163. attended transfers, and call pickup. The extra field in CEL
  10164. records now consists of a JSON blob whose fields are defined on a
  10165. per-event basis. Review: https://reviewboard.asterisk.org/r/2658/
  10166. (closes issue ASTERISK-21565)
  10167. 2013-07-20 01:11 +0000 [r394825-394846] Richard Mudgett <rmudgett@digium.com>
  10168. * include/asterisk/astobj2.h: Regroup the ao2 search_flags. Moved
  10169. the OBJ_POINTER, OBJ_KEY, and OBJ_PARTIAL_KEY flags together into
  10170. a field and renamed them to OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY,
  10171. and OBJ_SEARCH_PARTIAL_KEY respectively. The values were selected
  10172. to keep existing code compiling and working until the codebase
  10173. can be changed to stop using these values as bit flags and use
  10174. them as an enum field. The old names are defined to the new names
  10175. for backward compatibility.
  10176. * main/audiohook.c, main/channel.c, include/asterisk/audiohook.h:
  10177. Minor optimizations. * Made ast_audiohook_detach_list() and
  10178. ast_audiohook_write_list_empty() NULL tolerant. * Made
  10179. ast_audiohook_detach_list() return void since it is a destructor.
  10180. * main/bridging.c, main/channel.c, include/asterisk/channel.h,
  10181. bridges/bridge_native_rtp.c: Extract a repeated test into
  10182. ast_channel_has_audio_frame_or_monitor().
  10183. 2013-07-19 19:40 +0000 [r394809-394810] Jonathan Rose <jrose@digium.com>
  10184. * res/stasis/control.c, res/stasis_http/resource_channels.c,
  10185. res/res_stasis_http_channels.c, include/asterisk/stasis_app.h,
  10186. res/stasis_http/resource_channels.h,
  10187. rest-api/api-docs/channels.json: ARI: MOH start and stop for a
  10188. channel (issue ASTERISK-21974) Reported by: Matt Jordan Review:
  10189. https://reviewboard.asterisk.org/r/2680/
  10190. * rest-api/api-docs/channels.json, res/res_stasis_http_bridges.c,
  10191. res/res_stasis.c, rest-api/api-docs/recordings.json,
  10192. include/asterisk/core_unreal.h, res/res_stasis_http_playback.c,
  10193. res/res_stasis_playback.c, channels/chan_bridge_media.c (added),
  10194. res/stasis/control.c, res/stasis_http/ari_model_validators.c,
  10195. res/res_stasis_http_channels.c, main/core_unreal.c,
  10196. include/asterisk/stasis_app.h,
  10197. res/stasis_http/resource_bridges.c,
  10198. res/stasis_http/ari_model_validators.h,
  10199. res/stasis_http/resource_bridges.h,
  10200. include/asterisk/stasis_app_playback.h,
  10201. rest-api/api-docs/bridges.json, include/asterisk/logger.h,
  10202. res/stasis_http/resource_channels.c,
  10203. rest-api/api-docs/playback.json: ARI: Bridge Playback, Bridge
  10204. Record Adds a new channel driver for creating channels for
  10205. specific purposes in bridges, primarily to act as either
  10206. recorders or announcers. Adds ARI commands for playing
  10207. announcements to ever participant in a bridge as well as for
  10208. recording a bridge. This patch also includes some
  10209. documentation/reponse fixes to related ARI models such as
  10210. playback controls. (closes issue ASTERISK-21592) Reported by:
  10211. Matt Jordan (closes issue ASTERISK-21593) Reported by: Matt
  10212. Jordan Review: https://reviewboard.asterisk.org/r/2670/
  10213. 2013-07-19 19:23 +0000 [r394795-394808] Kinsey Moore <kmoore@digium.com>
  10214. * include/asterisk/channel.h, main/stasis_channels.c, main/cel.c,
  10215. apps/confbridge/conf_chan_announce.c, main/manager_channels.c,
  10216. res/parking/parking_manager.c, main/cdr.c,
  10217. include/asterisk/stasis_channels.h,
  10218. apps/confbridge/conf_chan_record.c,
  10219. apps/confbridge/confbridge_manager.c, main/manager_bridging.c:
  10220. Filter channels used as internal mechanisms This adds new flags
  10221. to the channel tech properties that flag it as different types of
  10222. implementation detail used exclusively to provide a feature.
  10223. Examples of channels that would have these flags include the
  10224. announcement and recording channels used by confbridge which are
  10225. the only two marked as such by this patch. Review:
  10226. https://reviewboard.asterisk.org/r/2633/ (closes issue
  10227. ASTERISK-21873)
  10228. * channels/chan_sip.c: Fix crash when using temporary peers
  10229. Temporary peers do not have an associated Stasis endpoint and
  10230. quite a bit of code in chan_sip assumes that all peers have a
  10231. Stasis endpoint. All endpoint accesses in chan_sip are now
  10232. wrapped in an endpoint NULL-check.
  10233. 2013-07-19 18:00 +0000 [r394793] Jason Parker <jparker@digium.com>
  10234. * main/stasis_system.c, main/ccss.c,
  10235. include/asterisk/stasis_system.h: Convert CCSS manager events to
  10236. stasis. (closes issue ASTERISK-21473) Review:
  10237. https://reviewboard.asterisk.org/r/2682/
  10238. 2013-07-19 17:55 +0000 [r394776-394791] Richard Mudgett <rmudgett@digium.com>
  10239. * main/bridging.c: Made audiohooks, framehooks, and monitor prevent
  10240. local channel optimization. Audiohooks, framehooks, and monitor
  10241. represent state on a local channel that will go away if it is
  10242. optimized out. (closes issue ASTERISK-21954) Reported by:
  10243. rmudgett Review: https://reviewboard.asterisk.org/r/2685/
  10244. * include/asterisk/channel.h: Fixup doxygen on ast_hangup().
  10245. 2013-07-18 19:25 +0000 [r394759] Mark Michelson <mmichelson@digium.com>
  10246. * res/res_sip_session.c, res/res_sip/sip_global_headers.c (added),
  10247. res/res_sip/config_system.c (added),
  10248. res/res_sip_one_touch_record_info.c, res/res_sip_mwi.c,
  10249. res/res_sip_pubsub.c, res/res_sip/config_transport.c,
  10250. res/res_sip/sip_configuration.c, res/res_sip_refer.c,
  10251. include/asterisk/res_sip.h, res/res_sip/config_global.c (added),
  10252. res/res_sip/include/res_sip_private.h, res/res_sip.exports.in,
  10253. res/res_sip_sdp_rtp.c, channels/chan_gulp.c,
  10254. res/res_sip_caller_id.c, res/res_sip.c: Add a bunch of options
  10255. from sip.conf to res_sip.conf For a complete list of the options
  10256. added, see the review linked at the bottom of this commit
  10257. message. (closes issue ASTERISK-21506) reported by Matt Jordan
  10258. Review: https://reviewboard.asterisk.org/r/2671
  10259. 2013-07-18 18:05 +0000 [r394744] David M. Lee <dlee@digium.com>
  10260. * res/res_http_websocket.c: Fixed null dereference when WebSocket
  10261. subprotocol isn't specified
  10262. 2013-07-18 16:49 +0000 [r394731] Jonathan Rose <jrose@digium.com>
  10263. * apps/app_bridgewait.c, main/bridging_roles.c,
  10264. bridges/bridge_holding.c: bridge_holding/app_bridgewait: Add new
  10265. entertainment options This patch adds more entertainment options
  10266. to holding bridges and the bridge_wait application. Also, holding
  10267. bridges will now use music on hold as the default entertainment
  10268. option instead of none. The parameters for app_bridgewait have
  10269. changed to (role, options) from the previous (options) and the
  10270. options themselves have changed as well (entertainment options
  10271. are now contained in an enumerator, role specification is handled
  10272. by the role parameter, etc) (closes issue ASTERISK-21923)
  10273. Reported by: Matthew Jordan Review:
  10274. https://reviewboard.asterisk.org/r/2679/
  10275. 2013-07-18 16:03 +0000 [r394715] Jason Parker <jparker@digium.com>
  10276. * res/stasis_http/resource_channels.c,
  10277. include/asterisk/stasis_app.h, include/asterisk/channel.h,
  10278. res/res_mutestream.c, main/channel.c, res/stasis/control.c: ARI:
  10279. Add support for suppressing media streams. Also convert
  10280. res_mutestream to use the core feature behind this. (closes issue
  10281. ASTERISK-21618) Review: https://reviewboard.asterisk.org/r/2652/
  10282. 2013-07-18 14:50 +0000 [r394701] Matthew Jordan <mjordan@digium.com>
  10283. * main/http.c: Tweak debug statements This patch does two things:
  10284. 1. It moves the debug statement that shows the HTTP sub-protocols
  10285. being compared after the string length calculation such that it
  10286. shows the correct string length in the output 2. It adds some
  10287. additional debug that displays when it matches on a sub-protocol
  10288. and when it fails
  10289. 2013-07-18 14:08 +0000 [r394686] David M. Lee <dlee@digium.com>
  10290. * main/stasis_cache.c: Fix caching topic shutdown assertions The
  10291. recent changes to update stasis_cache_topics directly from the
  10292. publisher thread uncovered a race condition, which was causing
  10293. asserts in the /stasis/core tests. If the caching topic's
  10294. subscription is the last reference to the caching topic, it will
  10295. destroy the caching topic after the final message has been
  10296. processed. When dispatching to a different thread, this usually
  10297. gave the unsubscribe enough time to finish before destruction
  10298. happened. Now, however, it consistently destroys before
  10299. unsubscription is complete. This patch adds an extra reference to
  10300. the caching topic, to hold it for the duration of the
  10301. unsubscription. This patch also removes an extra unref that was
  10302. happening when the final message was received by the caching
  10303. topic. It was put there because of an extra ref that was put into
  10304. the caching topic's constructor. Both have been removed, which
  10305. makes the destructor a bit less confusing. Review:
  10306. https://reviewboard.asterisk.org/r/2675/
  10307. 2013-07-18 12:54 +0000 [r394642] Michael L. Young <elgueromexicano@gmail.com>
  10308. * /, res/res_agi.c: Properly indicate failure to open an audio
  10309. stream in res_agi If there is an error streaming an audio file,
  10310. the current return status makes it difficult for an AGI script to
  10311. determine that there was an error with the audio file. This
  10312. patches changes the result to return -1 and the function returns
  10313. RESULT_FAILURE instead of RESULT_SUCCESS. From looking at other
  10314. parts of res_agi, this would appear to be the proper way to
  10315. handle an error. (closes issue ASTERISK-21903) Reported by: Ariel
  10316. Wainer Tested by: Ariel Wainer Patches:
  10317. asterisk-21903-return-stream-res_1.8.diff by Michael L. Young
  10318. (license 5026) Review: https://reviewboard.asterisk.org/r/2625/
  10319. ........ Merged revisions 394640 from
  10320. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10321. revisions 394641 from
  10322. http://svn.asterisk.org/svn/asterisk/branches/11
  10323. 2013-07-17 22:30 +0000 [r394600-394623] Richard Mudgett <rmudgett@digium.com>
  10324. * tests/test_app.c, main/features.c, tests/test_voicemail_api.c,
  10325. tests/test_cel.c, include/asterisk/channel.h,
  10326. addons/chan_mobile.c, tests/test_cdr.c,
  10327. tests/test_stasis_endpoints.c, apps/app_voicemail.c,
  10328. main/channel.c, main/dial.c, apps/app_meetme.c: Change
  10329. ast_hangup() to return void and be NULL safe. Since ast_hangup()
  10330. is effectively a channel destructor, it should be a void
  10331. function. * Make the few silly callers checking the return value
  10332. no longer do so. Only the CDR and CEL unit tests checked the
  10333. return value. * Make all callers take advantage of the NULL safe
  10334. change and remove the NULL check before the call.
  10335. * main/features.c: Remove some completed and no longer relevant
  10336. BUGBUG notes.
  10337. 2013-07-17 18:26 +0000 [r394583] Jonathan Rose <jrose@digium.com>
  10338. * apps/confbridge/conf_chan_announce.c: app_confbridge: Eliminate a
  10339. reference leak for confbridge announcer channels
  10340. 2013-07-17 17:49 +0000 [r394552-394567] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  10341. * channels/chan_dahdi.c: Left over spacing issues of review 726.
  10342. * channels/chan_dahdi.c: handle DAHDI_EVENT_REMOVED on a pri
  10343. D-Channel When a DAHDI device is removed at run-time it sends the
  10344. event DAHDI_EVENT_REMOVED on each channel. This is intended to
  10345. signal the userspace program to close the respective file handle,
  10346. as the driver of the device will need all of them closed to
  10347. properly clean-up. This event has long since been handled in
  10348. chan_dahdi (chan_zap at the time). However the event that is sent
  10349. on a D-Channel of a "PRI" (ISDN) span simply gets ignored. This
  10350. commit adds handling for closing the file descriptor (and
  10351. shutting down the span, while we're at it). It also adds a CLI
  10352. command 'pri destroy span <N>' to destroy the span and its DAHDI
  10353. channels. Review: https://reviewboard.asterisk.org/r/726/
  10354. 2013-07-16 22:33 +0000 [r394530-394531] Matthew Jordan <mjordan@digium.com>
  10355. * apps/app_confbridge.c, CHANGES: Add 'kick all' capability to
  10356. ConfBridge CLI command This patch adds the ability to kick all
  10357. users out of a conference from the ConfBridge kick CLI command.
  10358. It is invoked by passing 'all' as the channel parameter to the
  10359. CLI command, i.e., "confbridge kick <conf> all". Note that this
  10360. patch was modified slightly to conform to trunk. (closes issue
  10361. ASTERISK-21827) Reported by: dorianlogan patches:
  10362. kickall-patch_v2.diff uploaded by dorianlogan (License 6504)
  10363. * main/cel.c: Re-order handlers in CEL to ensure that HANGUP events
  10364. happen after APP_END When a channel is hungup, both an APP_END
  10365. event and a HANGUP event can be fired. To ensure that HANGUP
  10366. events occur after APP_END events, the method callbacks for the
  10367. APP_END event should be processed prior to the callbacks for the
  10368. HANGUP event.
  10369. 2013-07-16 21:44 +0000 [r394513] David M. Lee <dlee@digium.com>
  10370. * res/stasis_http/ari_websockets.c: Debug logging to help with
  10371. WebSocket connection problems
  10372. 2013-07-16 20:00 +0000 [r394489] Richard Mudgett <rmudgett@digium.com>
  10373. * channels/chan_gulp.c: chan_gulp: Fix gulp_indicate() handling of
  10374. AST_CONTROL_PVT_CAUSE_CODE.
  10375. 2013-07-16 19:13 +0000 [r394473] Mark Michelson <mmichelson@digium.com>
  10376. * res/res_sip_session.c: Prevent crash from trying to end a session
  10377. in an invalid way. This ensures that code that was only meant to
  10378. be run on a reinvite failure only runs on a reinvite failure.
  10379. (closes issue ASTERISK-22061) reported by Rusty Newton
  10380. 2013-07-16 18:49 +0000 [r394470-394471] Richard Mudgett <rmudgett@digium.com>
  10381. * main/channel.c, channels/chan_sip.c: Remove some dead code
  10382. dealing with old bridging method.
  10383. * bridges/bridge_simple.c: Simplify bridge_simple chan join code.
  10384. 2013-07-16 18:22 +0000 [r394469] Matthew Jordan <mjordan@digium.com>
  10385. * main/cdr.c: Re-order cleanup This patch attempts to fix some
  10386. possible race conditions in shutdown of the CDR engine. It: *
  10387. Adds a cleanup handler to only unsubscribe and join on stasis
  10388. messages during graceful shutdown. The cleanup handler should
  10389. execute before the regular atexit handler, as we want to
  10390. unsubscribe for any further messages before dispatching the CDRs.
  10391. * The CDRs are now locked when we dispatch them on shutdown.
  10392. 2013-07-16 15:30 +0000 [r394442] David M. Lee <dlee@digium.com>
  10393. * res/res_http_websocket.c: Fixed null dereference when WebSocket
  10394. protocol is omitted
  10395. 2013-07-15 23:20 +0000 [r394417] Richard Mudgett <rmudgett@digium.com>
  10396. * configs/agents.conf.sample, include/asterisk/config_options.h,
  10397. include/asterisk/stasis_channels.h, channels/chan_agent.c
  10398. (removed), configs/queues.conf.sample,
  10399. include/asterisk/bridging.h, UPGRADE.txt, main/stasis_channels.c,
  10400. CHANGES, main/bridging.c, apps/app_agent_pool.c (added): Replace
  10401. chan_agent with app_agent_pool. The ill conceived chan_agent is
  10402. no more. It is now replaced by app_agent_pool. Agents login using
  10403. the AgentLogin() application as before. The AgentLogin()
  10404. application no longer does any authentication. Authentication is
  10405. now the responsibility of the dialplan. (Besides, the
  10406. authentication done by chan_agent did not match what the voice
  10407. prompts asked for.) Sample extensions.conf [login] ; Sample agent
  10408. 1001 login ; Set COLP for in between calls so the agent does not
  10409. see the last caller COLP. exten =>
  10410. 1001,1,Set(CONNECTEDLINE(all)="Agent Waiting" <1001>) ; Give the
  10411. agent DTMF transfer and disconnect features when connected to a
  10412. caller. same => n,Set(CHANNEL(dtmf-features)=TX) same =>
  10413. n,AgentLogin(1001) same => n,NoOp(AGENT_STATUS is
  10414. ${AGENT_STATUS}) same => n,Hangup() [caller] ; Sample caller
  10415. direct connect to agent 1001 exten => 800,1,AgentRequest(1001)
  10416. same => n,NoOp(AGENT_STATUS is ${AGENT_STATUS}) same =>
  10417. n,Hangup() ; Sample caller going through a Queue to agent 1001
  10418. exten => 900,1,Queue(agent_q) same => n,Hangup() Sample
  10419. queues.conf [agent_q] member =>
  10420. Local/800@caller,,SuperAgent,Agent:1001 Under the hood operation
  10421. overview: 1) Logged in agents wait for callers in an agents
  10422. holding bridge. 2) Caller requests an agent using AgentRequest()
  10423. 3) A basic bridge is created, the agent is notified, and caller
  10424. joins the basic bridge to wait for the agent. 4) The agent is
  10425. either automatically connected to the caller or must ack the call
  10426. to connect. 5) The agent is moved from the agents holding bridge
  10427. to the basic bridge. 6) The agent and caller talk. 7) The
  10428. connection is ended by either party. 8) The agent goes back to
  10429. the agents holding bridge. To avoid some locking issues with the
  10430. agent holding bridge, I needed to make some changes to the after
  10431. bridge callback support. The after bridge callback is now a list
  10432. of requested callbacks with the last to be added the only active
  10433. callback. The after bridge callback for failed callbacks will
  10434. always happen in the channel thread when the channel leaves the
  10435. bridging system or is destroyed. (closes issue ASTERISK-21554)
  10436. Reported by: Matt Jordan Review:
  10437. https://reviewboard.asterisk.org/r/2657/
  10438. 2013-07-15 22:05 +0000 [r394402] Mark Michelson <mmichelson@digium.com>
  10439. * include/asterisk/stasis_channels.h: Remove misleading
  10440. documentation for channel snapshot creation.
  10441. 2013-07-15 21:22 +0000 [r394397] David M. Lee <dlee@digium.com>
  10442. * res/res_stasis_http.c: Document the ari.conf allowed_origins
  10443. setting
  10444. 2013-07-15 13:43 +0000 [r394370] Joshua Colp <jcolp@digium.com>
  10445. * res/res_sip_session.c, include/asterisk/res_sip_session.h: Remove
  10446. some callbacks and functions which are not needed.
  10447. 2013-07-14 02:41 +0000 [r394278-394346] Matthew Jordan <mjordan@digium.com>
  10448. * /, apps/app_queue.c: Provide error message for QUEUE_MEMBER when
  10449. member is not in queue When QUEUE_MEMBER is used and the member
  10450. specified is not in the queue, Asterisk provides an ERROR message
  10451. that indicates that the option specified is not valid. This patch
  10452. now properly displays an ERROR message that the member is not in
  10453. the queue if an interface is specified. (closes issue
  10454. ASTERISK-21980) Reported by: Avraam David ........ Merged
  10455. revisions 394345 from
  10456. http://svn.asterisk.org/svn/asterisk/branches/11
  10457. * main/dns.c: Remove redundant code in dns.c Peter J Philipp
  10458. pointed out that there are two checks that ensure that len is not
  10459. less than 0. If len is less than 0, the function returns. Having
  10460. both of them is clearly redundant. This removes the second and
  10461. attempts to clarify (slightly) the error condition. (closes issue
  10462. ASTERISK-21772) Reported by: Peter J Philipp
  10463. * /, funcs/func_strings.c: Clarify documentation for function
  10464. PASSTHRU It is not apparent to the average user that the PASSTHRU
  10465. function should not be passed as ${PASSTHRU(string)} but just as
  10466. PASSTHRU(string) to functions which take a variable name and not
  10467. its contents. This patch clarifies the behavior in the
  10468. documentation and provides an example. (closes issue
  10469. ASTERISK-21717) Reported by: Richard Miller patches:
  10470. func_strings.diff uploaded by Richard Miller (license 5685)
  10471. ........ Merged revisions 394302 from
  10472. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10473. revisions 394303 from
  10474. http://svn.asterisk.org/svn/asterisk/branches/11
  10475. * main/bridging.c, main/cdr.c: Fix FRACK message from external
  10476. redirects; handle outbound channels better This patch does the
  10477. following: * It simplifies the Dial handling in CDRs. As a rule,
  10478. the caller in a dial relationship is always the Party A. There
  10479. was some logic present in the handling of the dial message that
  10480. could, conceivably, pick the caller as Party A for the beginning
  10481. of the dial and the peer as Party A for the end of the dial. This
  10482. shouldn't have happened if the code in the bridging framework was
  10483. doing its job; however, that was broken and it led to the FRACK.
  10484. As it is, this code was overly ocmplex and not needed: the
  10485. caller, if present, should always be Party A. Period. * It
  10486. properly checks to see if a channel will continue on in the
  10487. dialplan. ast_check_hangup - much like cake at the end - is a
  10488. lie. It will tell you that you are hungup when you are not. Do
  10489. not believe it. I would make this function tell the truth, but
  10490. I'm nervous that we've been depending on it sitting on its throne
  10491. of lies for far too long, and it would probably break lots of
  10492. things. So I'm just checking the "internal" soft hangup flags,
  10493. like everyone else. (closes issue ASTERISK-22060) Reported by:
  10494. Mark Michelson (issue ASTERISK-21831) Reported by: Matt Jordan
  10495. * channels/chan_sip.c: Pretty up a debug message if the
  10496. referred-by-uri isn't available Instead of formatting a NULL
  10497. pointer into a "%s" format string (which is usually not a good
  10498. thing to do), we instead print "Unknown".
  10499. 2013-07-12 22:35 +0000 [r394263] Moises Silva <moises.silva@gmail.com>
  10500. * channels/chan_dahdi.c, /: Fix a longstanding issue with MFC-R2
  10501. configuration that prevented users from mixing different variants
  10502. or general MFC-R2 settings within the same E1 line. Most users do
  10503. not have a problem with this since MFC-R2 lines are usually
  10504. fractional E1s, or the whole E1 has the same country variant and
  10505. R2 settings. In Venezuela however is common to have inbound
  10506. MFC-R2 and outbound DTMF-R2 within the same E1. This fix now
  10507. properly parses the chan_dahdi.conf file to generate a new openr2
  10508. context every time a new channel => section is found and the
  10509. configuration was changed. (closes issue ASTERISK-21117) Reported
  10510. by: Rafael Angulo Related Elastix issue:
  10511. http://bugs.elastix.org/view.php?id=1612 ........ Merged
  10512. revisions 394106 from
  10513. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10514. revisions 394173 from
  10515. http://svn.asterisk.org/svn/asterisk/branches/11
  10516. 2013-07-12 21:42 +0000 [r394249] Joshua Colp <jcolp@digium.com>
  10517. * main/channel.c, main/channel_internal_api.c,
  10518. include/asterisk/channel.h, main/bridging.c: Add support to the
  10519. bridging core for performing COLP updates when channels join a 2
  10520. party bridge. (closes issue ASTERISK-21829) Review:
  10521. https://reviewboard.asterisk.org/r/2636/
  10522. 2013-07-12 21:01 +0000 [r394232] Mark Michelson <mmichelson@digium.com>
  10523. * main/bridging_basic.c: Prevent potential race condition in
  10524. multiparty basic bridges. For more details about the race
  10525. condition see the linked review at the bottom of this commit
  10526. (closes issue ASTERISK-21882) Reported by Matt Jordan Review:
  10527. https://reviewboard.asterisk.org/r/2663
  10528. 2013-07-12 19:35 +0000 [r394216] Jason Parker <jparker@digium.com>
  10529. * channels/chan_skinny.c: Fix a compiler warning.
  10530. 2013-07-12 18:23 +0000 [r394203] David M. Lee <dlee@digium.com>
  10531. * tests/test_json.c: Fixed intermittent crash when loading
  10532. test_json.so The JSON test attempted an overly clever use of
  10533. RAII_VAR to run code at the beginning and end of each test, in
  10534. order to validate that no JSON objects were leaked during the
  10535. test. The problem is that the validation code would run during
  10536. the initial load, when the tests were initialized. This happens
  10537. during startup, when other parts of the system might actively be
  10538. allocating and freeing JSON objects. This patch changes the
  10539. RAII_VAR to use the new ast_test_register_{init,cleanup}
  10540. functions to run the validations properly. (closes issue
  10541. ASTERISK-21978) Review: https://reviewboard.asterisk.org/r/2669/
  10542. 2013-07-12 17:52 +0000 [r394189] Jason Parker <jparker@digium.com>
  10543. * res/stasis_http/internal.h, res/stasis_http/config.c,
  10544. res/stasis_http/cli.c, res/res_stasis_http.c: ARI: Add support
  10545. for Cross-Origin Resource Sharing (CORS), origin headers This
  10546. rejects requests from any unknown origins. (closes issue
  10547. ASTERISK-21278) Review: https://reviewboard.asterisk.org/r/2667/
  10548. 2013-07-11 21:01 +0000 [r394158] Richard Mudgett <rmudgett@digium.com>
  10549. * include/asterisk/bridging_technology.h: Fix bridge tech write
  10550. callback parameter name.
  10551. 2013-07-11 20:59 +0000 [r394156] David M. Lee <dlee@digium.com>
  10552. * channels/chan_skinny.c: Fixed chan_skinny for systems were
  10553. pthread_t isn't an int. I'm looking at you, OS X.
  10554. 2013-07-11 20:17 +0000 [r394147] Damien Wedhorn <voip@facts.com.au>
  10555. * channels/chan_skinny.c: Refactor and cleanup of skinny session
  10556. handling. Major changes are to pull all packet reading functions
  10557. into skinny_session and move timeout handling to scheduling
  10558. arrangements. Thread cancelling is now undertaken directly rather
  10559. than waiting for the read to timeout (cleanup is popped on thread
  10560. cancel). Also added some keepalive timings in debugging messages.
  10561. Keepalive timeout has been increased from 1.1 by keepalive to 3
  10562. times keepalive. This seems to align (after keepalives stabilise)
  10563. with when devices reset after not receiving keepalives. Probably
  10564. needs more work, especially around the first and/or second
  10565. keepalives that vary significantly by device and firmware
  10566. version. Review: https://reviewboard.asterisk.org/r/2611/
  10567. 2013-07-11 16:23 +0000 [r394103] Joshua Colp <jcolp@digium.com>
  10568. * res/res_sip_exten_state.c: Tweak the subscription failure warning
  10569. message to include endpoint name and context.
  10570. 2013-07-11 15:37 +0000 [r394037-394089] David M. Lee <dlee@digium.com>
  10571. * tests/test_cel.c: Correct test_cel cleanup. When I corrected the
  10572. CEL test crash in r394037, I didn't quite pay attention to how
  10573. the globals and locals were being shuffled around in the cleanup
  10574. callback. I removed the nulling of the global variables, which
  10575. caused them to be double cleaned. This patch puts the global
  10576. nulling code back (since the vars are cleaned up by RAII_VARs),
  10577. and removes the explicit ao2_cleanup() (since they were no-ops,
  10578. because the variables had just been nulled).
  10579. * res/stasis_http/config.c, configs/ari.conf.sample,
  10580. res/res_stasis_http.c: Change ARI user config to use a type field
  10581. When I initially wrote the configuration support for ARI users, I
  10582. determined the section type by a category prefix (i.e.,
  10583. [user-admin]). This is neither idiomatic Asterisk configuration,
  10584. nor is it really that user friendly. This patch replaces the
  10585. category prefix with a type field in the section, which is much
  10586. cleaner. Review: https://reviewboard.asterisk.org/r/2664/
  10587. * res/stasis_http/config.c: Apply defaults to ari.conf's general
  10588. section
  10589. * tests/test_voicemail_api.c: test_voicemail_api: fix warning found
  10590. by gcc-4.8 The voicemail_api test had code like strncmp(a, b,
  10591. sizeof(a)), but a was a char pointer, instead of a literal or
  10592. char array. This meant that sizeof was the size of the pointer,
  10593. not the length of the string. Since the string is in a
  10594. stringfield and should be null terminated, I just changed it to a
  10595. plain strcmp.
  10596. * tests/test_cel.c: Fixed some CEL test crashes
  10597. 2013-07-10 22:26 +0000 [r394024] Kevin Harwell <kharwell@digium.com>
  10598. * contrib/scripts/sip_to_res_sip (added),
  10599. contrib/scripts/sip_to_res_sip/astconfigparser.py (added),
  10600. contrib/scripts/sip_to_res_sip/astdicts.py (added),
  10601. contrib/scripts/sip_to_res_sip/sip_to_res_sip.py (added): PSJIP -
  10602. sip.conf to res_sip.conf script ** This script is in no way
  10603. finished. Started the initial "cut" at converting a sip.conf file
  10604. to a res_sip.conf file. Hopefully the bulk of the framework is in
  10605. place and only a few minor adjustments need to be made when an
  10606. option mapping is added that "doesn't fit". This script and
  10607. supporting files should be executable against python version 2.5.
  10608. An OrderedDict class (backported from a newer version of python)
  10609. is included. A MultiOrderedDict class is implemented so options,
  10610. when added, should be able to be added in order and allowed to
  10611. have multiple values. Currently the scripts supports the majority
  10612. of endpoint options found in res_sip.conf. Support has also been
  10613. added for Aor(s) and the ACL/security sections. Inside the
  10614. sip_to_res_sip.py file one can see a list of options that still
  10615. need to be mapped. Also items that still need to be done:
  10616. templates, includes, parsing '=>' delimiter. Note that some code
  10617. is hopefully in place already to support templates (e.g.
  10618. lookup/retrieving defaults from them). However, the parsing of
  10619. and adding of the section needs to be done.
  10620. 2013-07-10 20:02 +0000 [r394004] Joshua Colp <jcolp@digium.com>
  10621. * res/res_sip_outbound_registration.c: Handle outbound registration
  10622. failures that do not occur as a result of a real response.
  10623. (closes issue ASTERISK-22064) Reported by: Rusty Newton
  10624. 2013-07-10 17:13 +0000 [r393968-393987] David M. Lee <dlee@digium.com>
  10625. * res/res_stasis_http_channels.c, rest-api/api-docs/channels.json:
  10626. Document the 400 error response for originate
  10627. * res/res_stasis_http_asterisk.c, rest-api/api-docs/asterisk.json,
  10628. res/stasis_http/ari_model_validators.c,
  10629. res/res_stasis_http_channels.c, rest-api/api-docs/channels.json,
  10630. res/stasis_http/ari_model_validators.h: Corrected api-docs for
  10631. channel variables
  10632. 2013-07-10 01:56 +0000 [r393930] Russell Bryant <russell@russellbryant.com>
  10633. * configs/sla.conf.sample, /, apps/app_meetme.c: astobj2-ify the
  10634. SLA code The SLA code within app_meetme was written before
  10635. asotbj2 had been merged into Asterisk. Worse, support for reloads
  10636. did not exist at first and was added later as a bolt-on feature.
  10637. I knew at the time that reloading was not safe at all while SLA
  10638. was in use, so the reload would be queued up to execute when the
  10639. system was idle. Unfortunately, this approach was still prone to
  10640. errors beyond the fact that this was the only place in Asterisk
  10641. where configuration was not reloaded instantly when requested.
  10642. This patch converts various SLA objects to be reference counted
  10643. objects using astobj2. This allows reloads to be processed while
  10644. the system is in use. The code ensures that the objects will not
  10645. disappear while one of the other threads is using them. However,
  10646. they will be immediately removed from the global trunk and
  10647. station containers so no new calls will use them if removed from
  10648. configuration. Review: https://reviewboard.asterisk.org/r/2581/
  10649. ........ Merged revisions 393928 from
  10650. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10651. revisions 393929 from
  10652. http://svn.asterisk.org/svn/asterisk/branches/11
  10653. 2013-07-09 21:40 +0000 [r393919] Jason Parker <jparker@digium.com>
  10654. * include/asterisk/lock.h: Make SCOPED_LOCK use RAII_VAR. This
  10655. fixes an issue with requiring SCOPED_LOCK to be the last variable
  10656. declaration and removes duplicate code in the process. Review:
  10657. https://reviewboard.asterisk.org/r/2665/
  10658. 2013-07-09 21:06 +0000 [r393910] Richard Mudgett <rmudgett@digium.com>
  10659. * main/xmldoc.c: Fix printf NULL string (null) substituion for NULL
  10660. config framework default.
  10661. 2013-07-09 20:07 +0000 [r393897] Mark Michelson <mmichelson@digium.com>
  10662. * channels/chan_gulp.c: Use correct function for getting bridged
  10663. peer when doing direct media checks. (closes issue
  10664. ASTERISK-21947) reported by Matt Jordan
  10665. 2013-07-09 19:38 +0000 [r393896] Richard Mudgett <rmudgett@digium.com>
  10666. * include/asterisk/manager.h, include/asterisk/stasis_channels.h:
  10667. Fix some stasis doxygen comments.
  10668. 2013-07-09 11:05 +0000 [r393857-393870] Joshua Colp <jcolp@digium.com>
  10669. * res/res_sip_outbound_registration.c: Ensure all pjsip_regc_*
  10670. access occurs within a pjlib thread. (closes issue
  10671. ASTERISK-22054) Reported by: Rusty Newton
  10672. * res/res_sip/config_auth.c: Tweak log message slightly.
  10673. * res/res_sip/config_auth.c: Treat the authentication object as
  10674. invalid if digest configuration is chosen and the digest is not
  10675. of the correct length. (closes issue ASTERISK-22003) Reported by:
  10676. Rusty Newton
  10677. 2013-07-08 20:31 +0000 [r393834-393843] David M. Lee <dlee@digium.com>
  10678. * res/res_stasis_recording.c: Oh menuconfig, why do you hate
  10679. margins?
  10680. * res/stasis_http/ari_websockets.c: Better structure for the
  10681. WebSocket validation failure message
  10682. 2013-07-08 19:53 +0000 [r393831-393833] Joshua Colp <jcolp@digium.com>
  10683. * res/res_sip/config_transport.c: Ensure that a valid bind host is
  10684. specified for transports. (closes issue ASTERISK-22017) Reported
  10685. by: Rusty Newton
  10686. * main/channel_internal_api.c, res/res_agi.c,
  10687. main/manager_bridging.c, include/asterisk/channel.h,
  10688. main/stasis_channels.c, main/bridging.c, main/manager_channels.c,
  10689. main/cli.c, main/channel.c, build_tools/cflags-devmode.xml,
  10690. main/pbx.c, include/asterisk/stasis_channels.h, main/manager.c:
  10691. Refactor operations to access the stasis cache instead of objects
  10692. directly when retrieving information. (closes issue
  10693. ASTERISK-21883) Review: https://reviewboard.asterisk.org/r/2645/
  10694. 2013-07-08 16:04 +0000 [r393816] David M. Lee <dlee@digium.com>
  10695. * res/res_stasis_http.c: res_stasis_http doesn't depend on
  10696. res_stasis any more
  10697. 2013-07-08 15:59 +0000 [r393815] Jonathan Rose <jrose@digium.com>
  10698. * res/parking/parking_controller.c, main/bridging.c,
  10699. res/parking/parking_bridge.c, res/parking/res_parking.h:
  10700. res_parking: Apply ringing role option on swap with a channel
  10701. that rings (closes issue ASTERISK-21877) Reported by: Matt Jordan
  10702. Review: https://reviewboard.asterisk.org/r/2656/
  10703. 2013-07-08 15:11 +0000 [r393807] Joshua Colp <jcolp@digium.com>
  10704. * res/stasis/control.c: Fix building.
  10705. 2013-07-08 14:46 +0000 [r393804-393806] Jason Parker <jparker@digium.com>
  10706. * res/res_stasis_http_asterisk.c, res/stasis/control.c,
  10707. res/stasis_http/resource_asterisk.h,
  10708. rest-api/api-docs/asterisk.json,
  10709. res/stasis_http/resource_channels.c,
  10710. res/res_stasis_http_channels.c, include/asterisk/stasis_app.h,
  10711. res/stasis_http/resource_channels.h,
  10712. rest-api/api-docs/channels.json,
  10713. res/stasis_http/resource_asterisk.c: ARI: Add support for
  10714. getting/setting channel and global variables. This allows for
  10715. reading and writing of functions on channels. (closes issue
  10716. ASTERISK-21868) Review: https://reviewboard.asterisk.org/r/2641/
  10717. * main/manager_system.c (added), res/res_stun_monitor.c,
  10718. main/file.c, main/sounds_index.c,
  10719. include/asterisk/stasis_system.h (added), channels/chan_iax2.c,
  10720. include/asterisk/manager.h, main/asterisk.c, include/asterisk.h,
  10721. main/stasis_system.c (added), main/manager.c,
  10722. channels/chan_sip.c: Move channel driver Registry manager events
  10723. to core. This also shuffles the stasis system topic and related
  10724. handling. (closes issue ASTERISK-21488) Review:
  10725. https://reviewboard.asterisk.org/r/2631/
  10726. 2013-07-08 14:26 +0000 [r393801] Matthew Jordan <mjordan@digium.com>
  10727. * include/asterisk/core_local.h, include/asterisk/bridging.h,
  10728. main/core_unreal.c, main/core_local.c, CHANGES, main/bridging.c,
  10729. include/asterisk/core_unreal.h: Create Local channel messages on
  10730. the Stasis message bus and produce AMI events This patch does the
  10731. following: * It adds a virtual table of callbacks to core_unreal.
  10732. These callbacks can be supplied by concrete implementations of
  10733. "unreal" channel drivers, which lets the unreal channel driver
  10734. call specific functionality when it performs some action.
  10735. Currently, this is done to notify implementations when an
  10736. optimization operation has begun, and when an optimization
  10737. operation has succeeded. * It adds Stasis-Core messages for Local
  10738. channel bridging and Local channel optimization. Local channel
  10739. optimization is now two events: a Begin and an End. Some
  10740. consumers of Stasis-Core may want to know when an operation is
  10741. beginning so that they can 'prepare' their information; others
  10742. will be more concerned about when the operation has completed, so
  10743. that they can 'fix up' information. Stasis-Core allows for both,
  10744. as does AMI. Review: https://reviewboard.asterisk.org/r/2552
  10745. 2013-07-08 13:57 +0000 [r393793] Mark Michelson <mmichelson@digium.com>
  10746. * res/res_sip_caller_id.c: Fix some broken logic in sending
  10747. outbound caller ID. * trust_id_outbound was required even when
  10748. the caller ID was not marked private. This is against intentions
  10749. and documentation. * We now check both name and number privacy
  10750. instead of checking name privacy twice.
  10751. 2013-07-07 21:29 +0000 [r393777-393785] Matthew Jordan <mjordan@digium.com>
  10752. * main/channel.c: In a channel destructor dispose of items that
  10753. raise Stasis message properly This patch reorders certain actions
  10754. that may raise Stasis messages in the channel destructor such
  10755. that they occur before the Stasis cache is cleared. Once the
  10756. Stasis cache is cleared, its rather a bad idea to be trying to
  10757. publish information about a channel. (closes issue
  10758. ASTERISK-22001) Reported by: Jonathan Rose
  10759. * main/cdr.c, main/channel.c, main/pbx.c,
  10760. include/asterisk/stasis_channels.h, main/channel_internal_api.c,
  10761. include/asterisk/cdr.h, include/asterisk/channel.h,
  10762. main/stasis_channels.c, CHANGES, main/cel.c,
  10763. main/manager_channels.c: Handle hangup logic in the Stasis
  10764. message bus and consumers of Stasis messages This patch does the
  10765. following: * It adds a new soft hangup flag
  10766. AST_SOFTHANGUP_HANGUP_EXEC that is set when a channel is
  10767. executing dialplan hangup logic, i.e., the 'h' extension or a
  10768. hangup handler. Stasis messages now also convey the soft hangup
  10769. flag so consumers of the messages can know when a channel is
  10770. executing said hangup logic. * It adds a new channel flag,
  10771. AST_FLAG_DEAD, which is set when a channel is well and truly
  10772. dead. Not just a zombie, but dead, Jim. Manager, CEL, CDRs, and
  10773. other consumers of Stasis have been updated to look for this flag
  10774. to know when the channel should by lying six feet under. * The
  10775. CDR engine has been updated to better handle a channel entering
  10776. and leaving a bridge. Previously, a new CDR was automatically
  10777. created when a channel left a bridge and put into the 'Pending'
  10778. state; however, this way of handling CDRs made it difficult for
  10779. the 'endbeforehexten' logic to work correctly - there was always
  10780. a new CDR waiting in the hangup logic and, even if 'ended',
  10781. wouldn't be the CDR people wanted to inspect in the hangup
  10782. routine. This patch completely removes the Pending state and
  10783. instead defers creation of the new CDR until it gets a new
  10784. message that requires a new CDR.
  10785. 2013-07-05 22:08 +0000 [r393749-393768] David M. Lee <dlee@digium.com>
  10786. * res/res_stasis_http.c: ARI: return a 503 if Asterisk isn't fully
  10787. booted
  10788. * res/stasis_http/ari_websockets.c: Print error details when set
  10789. nonblock fails
  10790. * res/stasis_http/ari_model_validators.c,
  10791. res/stasis_http/ari_model_validators.h,
  10792. res/stasis_http/resource_events.c, res/res_stasis_http_events.c,
  10793. rest-api/api-docs/events.json: Document MissingParams error
  10794. message for /ari/events
  10795. 2013-07-05 17:33 +0000 [r393740] Matthew Jordan <mjordan@digium.com>
  10796. * include/asterisk/cdr.h, include/asterisk/channel.h,
  10797. channels/chan_gtalk.c, include/asterisk/json.h,
  10798. channels/chan_gulp.c, channels/chan_jingle.c, main/json.c,
  10799. main/manager.c, channels/chan_skinny.c, channels/chan_motif.c,
  10800. channels/chan_h323.c, include/asterisk/rtp_engine.h,
  10801. main/asterisk.c, channels/chan_mgcp.c, channels/chan_unistim.c,
  10802. res/res_rtp_asterisk.c, channels/chan_multicast_rtp.c,
  10803. main/rtp_engine.c, channels/chan_sip.c: Refactor RTCP events over
  10804. to Stasis; associate with channels This patch does the following:
  10805. * It merges Jaco Kroon's patch from ASTERISK-20754, which
  10806. provides channel information in the RTCP events. Because Stasis
  10807. provides a cache, Jaco's patch was modified to pass the channel
  10808. uniqueid to the RTP layer as opposed to a pointer to the channel.
  10809. This has the following benefits: (1) It keeps the RTP engine
  10810. 'clean' of references back to channels (2) It prevents circular
  10811. dependencies and other potential ref counting issues * The RTP
  10812. engine now allows any RTP implementation to raise RTCP messages.
  10813. Potentially, other implementations (such as res_rtp_multicast)
  10814. could also raise RTCP information. The engine provides structs to
  10815. represent RTCP headers and RTCP SR/RR reports. * Some general
  10816. refactoring in res_rtp_asterisk was done to try and tame the RTCP
  10817. code. It isn't perfect - that's *way* beyond the scope of this
  10818. work - but it does feel marginally better. * A few random bugs
  10819. were fixed in the RTCP statistics. (Example: performing an
  10820. assignment of a = a is probably not correct) * We now raise RTCP
  10821. events for each SR/RR sent/received. Previously we wouldn't raise
  10822. an event when we sent a RR report. Note that this work will be of
  10823. use to others who want to monitor call quality or build modules
  10824. that report call quality statistics. Since the events are now
  10825. moving across the Stasis message bus, this is far easier to
  10826. accomplish. It is also a first step (though by no means the last
  10827. step) towards getting Olle's pinefrog work incorporated. Again:
  10828. note that the patch by Jaco Kroon was modified slightly for this
  10829. work; however, he did all of the hard work in finding the right
  10830. places to set the channel in the RTP engine across the channel
  10831. drivers. Much thanks goes to Jaco for his hard work here. Review:
  10832. https://reviewboard.asterisk.org/r/2603/ (closes issue
  10833. ASTERISK-20574) Reported by: Jaco Kroon patches:
  10834. asterisk-rtcp-channel.patch uploaded by jkroon (License 5671)
  10835. (closes issue ASTERISK-21471) Reported by: Matt Jordan
  10836. 2013-07-05 14:54 +0000 [r393729] Richard Mudgett <rmudgett@digium.com>
  10837. * main/bridging.c: OneTouchRecord: Add function defined earlier:
  10838. ast_bridge_features_do()
  10839. 2013-07-05 03:08 +0000 [r393716] Matthew Jordan <mjordan@digium.com>
  10840. * main/stasis_channels.c, include/asterisk/stasis_channels.h:
  10841. Remove parkinglot from the channel snapshot Legacy channel
  10842. drivers often include the ability to set a default parking lot on
  10843. an endpoint basis; when channels are created for that endpoint,
  10844. they inherit the parkinglot option. Parking used to use this
  10845. option more frequently; while it is still supported, other
  10846. options (such as using channel variables or creation of a custom
  10847. parkinglot) are supported. More importantly, conveying the
  10848. parkinglot information through a channel snapshot isn't terribly
  10849. useful - it is rarely (if ever) changed on a channel and some
  10850. consumers of channel snapshots, such as ARI, will never use the
  10851. information. (closes issue ASTERISK-21968) Reported by: Matt
  10852. Jordan
  10853. 2013-07-04 18:46 +0000 [r393704] Jonathan Rose <jrose@digium.com>
  10854. * res/parking/parking_ui.c, main/parking.c,
  10855. res/parking/parking_controller.c, UPGRADE.txt,
  10856. res/parking/parking_applications.c, include/asterisk/channel.h,
  10857. main/cel.c, CHANGES, res/parking/parking_bridge_features.c,
  10858. res/parking/parking_bridge.c, main/channel.c,
  10859. res/parking/res_parking.h, bridges/bridge_builtin_features.c,
  10860. main/features.c, include/asterisk/parking.h, main/bridging.c,
  10861. res/parking/parking_manager.c: res_parking: Replace Parker
  10862. snapshots with ParkerDialString This process also involved a
  10863. large amount of rework regarding how to redial the Parker when a
  10864. channel leaves a parking lot due to timeout. An attended transfer
  10865. channel variable has been added to attended transfers to
  10866. extensions that will eventually park (but haven't at the time of
  10867. transfer) as well. This resolves one of the two BUGBUG comments
  10868. remaining in res_parking. (issues ASTERISK-21877) Reported by:
  10869. Matt Jordan Review: https://reviewboard.asterisk.org/r/2638/
  10870. 2013-07-04 13:37 +0000 [r393675-393687] David M. Lee <dlee@digium.com>
  10871. * res/res_ari_model.c: Fix int width problem for 32-bit... again
  10872. * tests/test_ari_model.c: Fix int width problem for 32-bit
  10873. * main/utils.c, main/crypt.c (added), main/Makefile: Fix utils
  10874. directory breakage.
  10875. 2013-07-03 23:59 +0000 [r393600-393633] Richard Mudgett <rmudgett@digium.com>
  10876. * main/config_options.c: Add BUGBUG note for ASTERISK-22009
  10877. * channels/chan_agent.c (added), configs/queues.conf.sample,
  10878. include/asterisk/bridging.h, UPGRADE.txt, main/config_options.c,
  10879. main/stasis_channels.c, CHANGES, main/bridging.c,
  10880. apps/app_agent_pool.c (removed), configs/agents.conf.sample,
  10881. include/asterisk/config_options.h,
  10882. include/asterisk/stasis_channels.h: Revert accidental overcommit.
  10883. * channels/chan_agent.c (removed), configs/queues.conf.sample,
  10884. include/asterisk/bridging.h, UPGRADE.txt, main/config_options.c,
  10885. main/stasis_channels.c, CHANGES, main/bridging.c,
  10886. apps/app_agent_pool.c (added), configs/agents.conf.sample,
  10887. include/asterisk/config_options.h,
  10888. include/asterisk/stasis_channels.h: Add BUGBUG note for
  10889. ASTERISK-22009
  10890. * channels/chan_dahdi.c, /: chan_dahdi: Fix segfault reloading
  10891. chan_dahdi when round robin is used. * Clear round_robin[] in
  10892. dahdi_restart(). (closes issue ASTERISK-21847) Reported by: Ivo
  10893. Andonov Patches: jira_asterisk_21847_v1.8.patch (license #5621)
  10894. patch uploaded by rmudgett ........ Merged revisions 393627 from
  10895. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10896. revisions 393628 from
  10897. http://svn.asterisk.org/svn/asterisk/branches/11
  10898. * bridges/bridge_builtin_features.c,
  10899. include/asterisk/bridging_features.h: OneTouchRecord: Make so
  10900. Monitor/MixMonitor can be toggled/started/stopped. The
  10901. OneTouchRecord feature has historically been a toggle. This patch
  10902. adds the ability to make the OneTouchRecord hook optionally
  10903. start/stop recording only. If OneTouchRecord is already doing
  10904. what is requested then only the invoker hears the courtesy tone
  10905. and/or start/stop recording message. The new feature is written
  10906. so we could easily add explicit start/stop recording DTMF hooks
  10907. for Monitor and MixMonitor. The majority of the changes in
  10908. bridge_builtin_features.c is a refactoring of the OneTouchRecord
  10909. code (Monitor and MixMonitor versions) so it is easy to direct
  10910. the toggle/start/stop functionality. Review:
  10911. https://reviewboard.asterisk.org/r/2655/
  10912. * main/bridging.c: Move when bridge channel enter is published so
  10913. it does not interrupt the thought of some lines of code.
  10914. * main/stasis_config.c: Fix some indentation in stasis_config.c.
  10915. 2013-07-03 22:04 +0000 [r393589-393599] Matthew Jordan <mjordan@digium.com>
  10916. * main/cdr.c: Fix some bugs in CDRs; add some CLI commands to help
  10917. debugging This patch fixes a few minor bugs and one major one:
  10918. the CDR by bridge container was less than helpful. The mechanism
  10919. previously used to try and find all of the CDRs in a particular
  10920. bridge ended up missing CDRs, resulting in incorrect records.
  10921. When looking up CDRs in a bridge, we now just bite the bullet and
  10922. do a selection across all existing CDRs.
  10923. * main/stasis_config.c: Let Stasis load itself with default values
  10924. While a Stasis configuration file is nice, it shouldn't be
  10925. mandatory. We can carry on with default values.
  10926. 2013-07-03 20:41 +0000 [r393586] Mark Michelson <mmichelson@digium.com>
  10927. * main/bridging.c: Publish a bridge enter before pulling on a
  10928. push-and-swap operation. Prior to this patch, the order of
  10929. procedures on a bridge push was * Add new bridge channel to
  10930. bridge's array. * Pull the swap channel out of the bridge *
  10931. Publish a bridge enter event. The problem is that when the swap
  10932. channel was pulled from the bridge, a bridge leave event would be
  10933. published. The bridge snapshot published during the bridge leave
  10934. showed the new channel that had been added to the bridge, but
  10935. there had been no bridge enter event for that channel. The fix
  10936. provided here was to change the order a bit * Add new bridge
  10937. channel to bridge's array. * Publish bridge enter event. * Pull
  10938. the swap channel out of the bridge. This makes it so that the
  10939. bridge snapshots during the stasis events are accurate.
  10940. 2013-07-03 19:46 +0000 [r393528-393576] David M. Lee <dlee@digium.com>
  10941. * res/res_stasis_http_bridges.c, res/res_stasis_http_recordings.c,
  10942. res/stasis_http/ari_model_validators.h,
  10943. res/res_stasis_http_endpoints.c, res/res_stasis_http_events.c,
  10944. rest-api-templates/ari_model_validators.c.mustache,
  10945. rest-api-templates/res_stasis_http_resource.c.mustache,
  10946. rest-api-templates/ari_model_validators.h.mustache,
  10947. res/stasis_http/ari_model_validators.c,
  10948. res/res_stasis_http_channels.c, res/res_stasis_http_sounds.c: Fix
  10949. load errors related to the new ari_model_validators. The Asterisk
  10950. strategy of loading modules with RTLD_LAZY to extract metadata
  10951. from the module works well enough, until you try to take the
  10952. address of a function. If a module takes the address of a
  10953. function, that function needs to be resolved at load time. That
  10954. kinda defeats RTLD_LAZY. This patch adds some
  10955. ari_validator_{id}_fn() wrapper functions for safely getting the
  10956. function pointer from a different module.
  10957. * res/res_ari_model.c: Violating the margins to make menuconfig
  10958. happy
  10959. * res/res_stasis_recording.exports.in (added), Makefile,
  10960. include/asterisk/file.h, include/asterisk/paths.h,
  10961. main/channel.c, include/asterisk/app.h,
  10962. res/stasis_http/resource_channels.c, tests/test_utils.c,
  10963. apps/app_minivm.c, main/file.c,
  10964. res/stasis_http/resource_recordings.c, main/app.c,
  10965. res/res_stasis_recording.c (added),
  10966. rest-api-templates/swagger_model.py,
  10967. rest-api/api-docs/channels.json,
  10968. res/stasis_http/resource_channels.h,
  10969. res/res_stasis_http_bridges.c, rest-api/api-docs/recordings.json,
  10970. res/stasis_http/resource_recordings.h, main/asterisk.c,
  10971. rest-api-templates/asterisk_processor.py, apps/app_voicemail.c,
  10972. include/asterisk/utils.h, res/res_stasis_playback.c,
  10973. include/asterisk/stasis_app_recording.h (added),
  10974. res/res_stasis_http_channels.c, main/utils.c,
  10975. include/asterisk/channel.h, res/res_stasis_http_recordings.c: ARI
  10976. - channel recording support This patch is the first step in
  10977. adding recording support to the Asterisk REST Interface.
  10978. Recordings are stored in /var/spool/recording. Since recordings
  10979. may be destructive (overwriting existing files), the API rejects
  10980. attempts to escape the recording directory (avoiding issues if
  10981. someone attempts to record to ../../lib/sounds/greeting, for
  10982. example). (closes issue ASTERISK-21594) (closes issue
  10983. ASTERISK-21581) Review: https://reviewboard.asterisk.org/r/2612/
  10984. * include/asterisk/stasis.h, configs/stasis_core.conf.sample
  10985. (removed), main/asterisk.c, main/stasis.c, main/stasis_config.c
  10986. (added), configs/stasis.conf.sample (added): Configuration for
  10987. Stasis threadpool The appropriate settings for the Stasis
  10988. threadpool is very system specific, depending upon both workload
  10989. and system configuration. This patch adds a stasis.conf file
  10990. which can be used to configure the key attributes of the
  10991. threadpool for the Stasis message bus. (closes issue
  10992. ASTERISK-21280) Review: https://reviewboard.asterisk.org/r/2651/
  10993. * res/stasis_http/cli.c (added), res/Makefile,
  10994. configs/ari.conf.sample (added), makeopts.in,
  10995. res/res_stasis_http.c, res/stasis_http/internal.h (added),
  10996. configs/stasis_http.conf.sample (removed), main/Makefile,
  10997. res/stasis_http/config.c (added), main/http.c, main/utils.c: No
  10998. message for rev 393530 found
  10999. * main/json.c, rest-api/api-docs/asterisk.json,
  11000. rest-api/api-docs/playback.json,
  11001. res/stasis_http/ari_websockets.c, main/stasis_channels.c,
  11002. rest-api-templates/swagger_model.py,
  11003. res/res_stasis_http_bridges.c,
  11004. rest-api-templates/res_stasis_json_resource.c.mustache (removed),
  11005. res/res_stasis_json_recordings.exports.in (removed),
  11006. rest-api/api-docs/endpoints.json, main/stasis_endpoints.c,
  11007. rest-api/api-docs/events.json, tests/test_res_stasis.c,
  11008. tests/test_stasis_channels.c, include/asterisk/stasis_http.h,
  11009. res/res_stasis_json_sounds.exports.in (removed),
  11010. res/res_ari_model.exports.in (added),
  11011. res/res_stasis_http_recordings.c,
  11012. rest-api-templates/res_stasis_json_resource.exports.mustache
  11013. (removed), rest-api/api-docs/bridges.json,
  11014. res/res_stasis_http_events.c, res/res_ari_model.c (added),
  11015. res/res_stasis_json_playback.exports.in (removed),
  11016. res/res_stasis_http_sounds.c, res/stasis_json (removed),
  11017. rest-api/api-docs/recordings.json,
  11018. rest-api-templates/ari_model_validators.c.mustache (added),
  11019. res/res_stasis_json_endpoints.exports.in (removed),
  11020. res/res_stasis_json_events.exports.in (removed),
  11021. res/res_stasis_http_asterisk.c,
  11022. rest-api-templates/res_stasis_http_resource.c.mustache,
  11023. rest-api-templates/make_ari_stubs.py (added),
  11024. res/res_stasis_json_recordings.c (removed),
  11025. rest-api-templates/api.wiki.mustache (added),
  11026. rest-api/api-docs/sounds.json, res/Makefile,
  11027. res/res_stasis_json_events.c (removed),
  11028. res/res_stasis_json_bridges.exports.in (removed),
  11029. res/res_stasis_json_sounds.c (removed),
  11030. rest-api-templates/models.wiki.mustache (added),
  11031. main/stasis_bridging.c, rest-api-templates/transform.py,
  11032. rest-api-templates/stasis_json_resource.h.mustache (removed),
  11033. res/res_stasis_json_channels.exports.in (removed),
  11034. res/res_stasis_json_asterisk.c (removed), res/res_stasis_http.c,
  11035. rest-api-templates/asterisk_processor.py,
  11036. res/res_stasis_http_playback.c,
  11037. rest-api-templates/ari_model_validators.h.mustache (added),
  11038. res/res_stasis_http_channels.c, res/res_stasis_json_endpoints.c
  11039. (removed), include/asterisk/json.h, tests/test_ari_model.c
  11040. (added), Makefile, res/res_stasis_json_asterisk.exports.in
  11041. (removed), res/res_stasis_json_bridges.c (removed),
  11042. res/stasis_http/resource_recordings.c,
  11043. rest-api/api-docs/channels.json, res/res_stasis_json_playback.c
  11044. (removed), res/res_stasis.c, doc/rest-api (added),
  11045. rest-api-templates/make_stasis_http_stubs.py (removed),
  11046. res/stasis_http/resource_recordings.h,
  11047. res/res_stasis_json_channels.c (removed),
  11048. res/stasis_http/ari_model_validators.c (added),
  11049. rest-api-templates/event_function_decl.mustache (removed),
  11050. res/stasis_http/ari_model_validators.h (added),
  11051. res/res_stasis_http_endpoints.c: No message for rev 393529 found
  11052. * res/Makefile, res/res_http_websocket.c,
  11053. res/res_stasis_http.exports.in, configure, tests/test_utils.c,
  11054. res/stasis_http/ari_websockets.c (added),
  11055. rest-api-templates/stasis_http_resource.c.mustache,
  11056. tests/test_stasis_http.c, res/stasis_http/resource_events.c,
  11057. rest-api-templates/asterisk_processor.py,
  11058. include/asterisk/utils.h, res/res_stasis_http_playback.c,
  11059. res/res_http_websocket.exports.in,
  11060. res/stasis_http/resource_events.h,
  11061. res/res_stasis_http_channels.c, include/asterisk/stasis_http.h,
  11062. configure.ac, res/res_stasis_http_recordings.c,
  11063. rest-api-templates/param_parsing.mustache (added),
  11064. res/res_stasis_http_endpoints.c, res/res_stasis_http_events.c,
  11065. include/asterisk/http.h, res/res_stasis_http_sounds.c,
  11066. rest-api-templates/swagger_model.py,
  11067. res/res_stasis_http_bridges.c, res/res_stasis_http.c,
  11068. rest-api-templates/stasis_http_resource.h.mustache,
  11069. res/res_stasis_http_asterisk.c,
  11070. rest-api-templates/res_stasis_http_resource.c.mustache,
  11071. rest-api/api-docs/events.json, res/res_stasis_websocket.c
  11072. (removed), include/asterisk/autoconfig.h.in,
  11073. rest-api-templates/rest_handler.mustache: No message for rev
  11074. 393528 found
  11075. 2013-07-02 22:01 +0000 [r393508] Jason Parker <jparker@digium.com>
  11076. * main/manager.c, CHANGES: Add a SystemName field to all AMI
  11077. events. This only gets sent out if configured in asterisk.conf
  11078. (closes issue ASTERISK-21494)
  11079. 2013-07-02 21:19 +0000 [r393485-393500] Richard Mudgett <rmudgett@digium.com>
  11080. * apps/app_mixmonitor.c: MixMonitor: Minor code cleanup.
  11081. * apps/app_mixmonitor.c: MixMonitor: Make
  11082. start_mixmonitor_callback() options parameter NULL tolerant. *
  11083. Removed some unnecessary code in start_mixmonitor_callback().
  11084. * apps/app_mixmonitor.c: MixMonitor: Don't use ast_strdupa() in a
  11085. loop.
  11086. * apps/app_mixmonitor.c: MixMonitor: Update XML documentation and
  11087. CLI "mixmonitor {start|stop|list}" help.
  11088. * apps/app_mixmonitor.c: MixMonitor: Fix refleak in
  11089. manager_stop_mixmonitor() if could not stop monitoring.
  11090. * apps/app_mixmonitor.c: MixMonitor: Remove some unnecessary
  11091. channel locking.
  11092. * apps/app_mixmonitor.c: Fix MixMonitor b option. The option had
  11093. not been converted to use the replacement for
  11094. ast_bridged_channel(). One touch mixmonitor now records files
  11095. again.
  11096. * channels/chan_gtalk.c: Fix chan_gtalk.c compile error.
  11097. 2013-07-02 20:34 +0000 [r393484] David M. Lee <dlee@digium.com>
  11098. * res/res_sip_notify.c: Add pjproject dependency to res_sip_notify
  11099. 2013-07-02 18:28 +0000 [r393463] Mark Michelson <mmichelson@digium.com>
  11100. * include/asterisk/stasis_bridging.h: Remove unused blind transfer
  11101. publication structure. I ended up using a bridge blob, so this
  11102. structure was unused. Keeping it in the header would just cause
  11103. confusion.
  11104. 2013-07-02 17:20 +0000 [r393442-393449] Kevin Harwell <kharwell@digium.com>
  11105. * main/aoc.c, main/manager.c: Stasis - Refactor AOC Events
  11106. Refactored the AMI events in AOC onto Stasis-Core. The
  11107. ast_aoc_manager_event function now publishes a channel snapshot,
  11108. along with a JSON blob describing the advice of charge. A
  11109. "to_ami" handler has also been added that converts the channel
  11110. snapshot and AOC event data back into the appropriate data
  11111. structure for use with AMI. (closes issue ASTERISK-21472)
  11112. Reported by: Matt Jordan Review:
  11113. https://reviewboard.asterisk.org/r/2643/
  11114. * res/res_sip/sip_configuration.c, include/asterisk/res_sip.h,
  11115. res/res_sip/sip_distributor.c, res/res_sip/config_auth.c,
  11116. res/res_sip.exports.in,
  11117. res/res_sip_outbound_authenticator_digest.c,
  11118. res/res_sip_authenticator_digest.c, res/res_sip/config_security.c
  11119. (added), res/res_sip_acl.c, res/res_sip.c: New SIP Channel
  11120. driver: Always Auth Reject If no matching endpoint is found for
  11121. the incoming request Asterisk will respond with a 401
  11122. Unauthorized (rejecting the request), but will first challenge if
  11123. no authorization creditials are given. Changes also included
  11124. moving ACL options into a new global 'security' configuration
  11125. section in res_sip.conf. (closes issue ASTERISK-21433) Reported
  11126. by: Matt Jordan Review: https://reviewboard.asterisk.org/r/2554/
  11127. 2013-07-02 16:11 +0000 [r393410-393429] Kinsey Moore <kmoore@digium.com>
  11128. * main/stasis_bridging.c: Fix transfer AMI event parameter naming
  11129. * tests/test_cel.c (added), main/cel.c, include/asterisk/cel.h: Add
  11130. CEL unit tests and do some cleanup This adds several unit tests
  11131. for CEL functionality and provides the requisite framework for
  11132. creating additional unit tests. This also cleans up some
  11133. reference leaks that were occurring in Stasis-Core message
  11134. callback code. Review: https://reviewboard.asterisk.org/r/2646/
  11135. 2013-07-02 10:16 +0000 [r393396] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  11136. * channels/chan_unistim.c, /: Fix issue with inability to cancell
  11137. call transfer made by on-sceen menus. Reported by: Igor Olhovskiy
  11138. ........ Merged revisions 393395 from
  11139. http://svn.asterisk.org/svn/asterisk/branches/11
  11140. 2013-07-02 08:23 +0000 [r393383] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  11141. * contrib/scripts/ast_tls_cert: ast_tls_cert: don't recreate
  11142. generated files Don't regenrate cat.cfg, ca.crt and ca.key if
  11143. they were already created on a previous run. (closes issue
  11144. ASTERISK-21932)
  11145. 2013-07-01 21:28 +0000 [r393364] Kevin Harwell <kharwell@digium.com>
  11146. * res/res_sip/sip_configuration.c, include/asterisk/res_sip.h,
  11147. res/res_sip/include/res_sip_private.h, res/res_sip/sip_options.c,
  11148. res/res_sip.exports.in, res/res_sip_notify.c (added): New SIP
  11149. Channel Driver - Add CLI/AMI initiated NOTIFY requests Added the
  11150. ability to send unsolicited NOTIFY requests to a particular
  11151. endpoint with a configured payload. Added both CLI and AMI
  11152. support. For a given endpoint, this module will iterate over all
  11153. its contacts sending the appropriate NOTIFY request to each.
  11154. (closes issue ASTERISK-21436) Reported by: Matt Jordan Review:
  11155. https://reviewboard.asterisk.org/r/2623/
  11156. 2013-07-01 21:24 +0000 [r393361] Matthew Jordan <mjordan@digium.com>
  11157. * include/asterisk/pbx.h, main/pbx.c, main/manager.c: Prevent crash
  11158. during synchronous AMI origination by ref bumping returned
  11159. channel The originate APIs allow callers to provide a pointer to
  11160. a channel that will point to the originated channel if the
  11161. function call succeeds. This is used by AMI to provide channel
  11162. information when the originate is performed synchronously.
  11163. Unfortunately, if the originate fails in certain ways, the
  11164. outbound channel is already disposed of during the dialing
  11165. itself. This results in the channel being improperly dereferenced
  11166. by the internal originate function in pbx.c. This patch ref bumps
  11167. the channel to prevent this from occurring. Callers must now
  11168. unlock and unref the channel (which is more in line with general
  11169. channel management guidelines anyway). This only affects manager,
  11170. as it is the only consumer of this API function that actually
  11171. passes in a channel pointer. Review:
  11172. https://reviewboard.asterisk.org/r/2617/
  11173. 2013-07-01 18:56 +0000 [r393326-393332] Jason Parker <jparker@digium.com>
  11174. * res/stasis/control.c, res/stasis_http/resource_channels.c,
  11175. include/asterisk/stasis_app.h: ARI: Implement channel
  11176. hold/unhold. This puts the channel on hold (rather than queueing
  11177. a frame from the channel). (closes issue ASTERISK-21619) Review:
  11178. https://reviewboard.asterisk.org/r/2647/
  11179. * res/stasis_http/resource_channels.c,
  11180. res/res_stasis_http_channels.c, include/asterisk/stasis_app.h,
  11181. res/stasis_http/resource_channels.h,
  11182. rest-api/api-docs/channels.json, res/stasis/control.c: ARI:
  11183. Implement channel dial. This creates a new outbound channel, and
  11184. bridges it to a channel already in the Stasis application.
  11185. (closes issue ASTERISK-21620) Review:
  11186. https://reviewboard.asterisk.org/r/2634/
  11187. 2013-07-01 16:01 +0000 [r393309] Jonathan Rose <jrose@digium.com>
  11188. * bridges/bridge_builtin_features.c,
  11189. include/asterisk/features_config.h, include/asterisk/mixmonitor.h
  11190. (added), include/asterisk/channel.h, CHANGES,
  11191. main/features_config.c, apps/app_mixmonitor.c,
  11192. configs/features.conf.sample, main/mixmonitor.c (added):
  11193. bridge_features: Support One touch Monitor/MixMonitor In addition
  11194. to porting those features, they now enjoy greater feature parity
  11195. with one another. Specifically, AutoMixMon now has a start and
  11196. stop message that can be specified with
  11197. TOUCH_MIXMONITOR_MESSAGE_START and TOUCH_MIXMONITOR_MESSAGE_STOP.
  11198. (closes issue ASTERISK-21553) Reported by: Matt Jordan Review:
  11199. https://reviewboard.asterisk.org/r/2620/
  11200. 2013-07-01 13:16 +0000 [r393284] Kinsey Moore <kmoore@digium.com>
  11201. * channels/chan_sip.c, apps/app_meetme.c,
  11202. include/asterisk/stasis.h, main/core_local.c,
  11203. include/asterisk/json.h, channels/chan_gtalk.c,
  11204. channels/sig_pri.c, channels/chan_iax2.c, apps/app_queue.c,
  11205. CHANGES, main/json.c, channels/chan_dahdi.c,
  11206. channels/sig_analog.c, res/res_agi.c, configs/sip.conf.sample,
  11207. channels/sip/include/sip.h: Refactor extraneous channel events
  11208. This change removes JitterBufStats, ChannelReload, and
  11209. ChannelUpdate and refactors the following events to travel over
  11210. Stasis-Core: * LocalBridge * DAHDIChannel * AlarmClear *
  11211. SpanAlarmClear * Alarm * SpanAlarm * DNDState * MCID *
  11212. SIPQualifyPeerDone * SessionTimeout Review:
  11213. https://reviewboard.asterisk.org/r/2627/ (closes issue
  11214. ASTERISK-21476)
  11215. 2013-06-29 13:47 +0000 [r393262-393264] Joshua Colp <jcolp@digium.com>
  11216. * res/res_sip_pubsub.c: Nothing to see here, move along.
  11217. * res/res_sip_pubsub.c, include/asterisk/res_sip_pubsub.h,
  11218. res/res_sip_pubsub.exports.in: Implement the defined PUBLISH ESC
  11219. API within res_sip_pubsub. (closes issue ASTERISK-21452) Review:
  11220. https://reviewboard.asterisk.org/r/2630/
  11221. 2013-06-29 00:31 +0000 [r393219-393241] Richard Mudgett <rmudgett@digium.com>
  11222. * main/bridging.c, include/asterisk/bridging.h: Tweak after bridge
  11223. callback reason to string strings.
  11224. * main/bridging.c: Fix after bridge callback datastore data memory
  11225. leak.
  11226. * main/datastore.c: This is no longer needed.
  11227. * main/bridging.c: Promote local channel optimizing debug messages
  11228. to verbose 3 messages.
  11229. 2013-06-28 19:22 +0000 [r393190-393197] Jonathan Rose <jrose@digium.com>
  11230. * res/parking/parking_applications.c, CHANGES,
  11231. res/parking/parking_ui.c, res/parking/res_parking.h,
  11232. res/res_parking.c: res_parking: Dynamic Parking Lots (closes
  11233. issue ASTERISK-21644) Reported by: Matt Jordan Review:
  11234. https://reviewboard.asterisk.org/r/2615/
  11235. * main/features.c, include/asterisk/features.h: features: call
  11236. pickup stasis refactoring (issue ASTERISK-21544) Reported by:
  11237. Matt Jordan Review: https://reviewboard.asterisk.org/r/2588/
  11238. 2013-06-28 19:05 +0000 [r393184] Richard Mudgett <rmudgett@digium.com>
  11239. * include/asterisk/bridging_features.h: Fix overlapping enum
  11240. ast_bridge_feature_flags. Things may no longer behave in an
  11241. unexpected fashion. Local channel optimization to holding bridges
  11242. will work again.
  11243. 2013-06-28 18:42 +0000 [r393182] Mark Michelson <mmichelson@digium.com>
  11244. * main/manager.c, bridges/bridge_builtin_features.c,
  11245. channels/chan_sip.c, channels/chan_skinny.c,
  11246. main/stasis_bridging.c, res/res_sip_refer.c,
  11247. include/asterisk/bridging.h, main/manager_bridging.c,
  11248. channels/chan_iax2.c, include/asterisk/stasis_bridging.h,
  11249. main/bridging.c: Add stasis publications for blind and attended
  11250. transfers. This creates stasis messages that are sent during a
  11251. blind or attended transfer. The stasis messages also are
  11252. converted to AMI events. Review:
  11253. https://reviewboard.asterisk.org/r/2619 (closes issue
  11254. ASTERISK-21337) Reported by Matt Jordan
  11255. 2013-06-28 17:31 +0000 [r393164] Matthew Jordan <mjordan@digium.com>
  11256. * tests/test_cdr.c, main/cdr.c: Handle an originated channel being
  11257. sent into a non-empty bridge Originated channels are a bit odd -
  11258. they are technically a dialed channel (thus the party B or peer)
  11259. but, since there is no caller, they are treated as the party A.
  11260. When entering into a bridge that already contains participants,
  11261. the CDR engine - if the CDR record is in the Dial state -
  11262. attempts to match the person entering the bridge with an existing
  11263. participant. The idea is that if you dialed someone and the
  11264. person you dialed is already in the bridge, you don't need a new
  11265. CDR record, the existing CDR record describes the relationship.
  11266. Unfortunately, for an originated channel, there is no Party B. If
  11267. no one was in the bridge this didn't cause any issues; however,
  11268. if participants were in the bridge the CDR engine would attempt
  11269. to match a non-existant Party B on the channel's CDR record and
  11270. explode. This patch fixes that, and a unit test has been added to
  11271. cover this case.
  11272. 2013-06-28 16:23 +0000 [r393144] Jason Parker <jparker@digium.com>
  11273. * res/res_stasis_http_channels.c,
  11274. res/stasis_http/resource_channels.h,
  11275. rest-api/api-docs/channels.json,
  11276. res/stasis_http/resource_channels.c: Change ARI originate to also
  11277. allow dialing an exten/context/priority. The old way didn't make
  11278. much sense, so some of the fields were repurposed. (closes issue
  11279. ASTERISK-21658) Review: https://reviewboard.asterisk.org/r/2626/
  11280. 2013-06-28 15:50 +0000 [r393130] Matthew Jordan <mjordan@digium.com>
  11281. * include/asterisk/parking.h, main/asterisk.c, main/bridging.c,
  11282. main/cdr.c, include/asterisk/cdr.h: Better handle parking in CDRs
  11283. Parking typically occurs when a channel is transferred to a
  11284. parking extension. When this occurs, the channel never actually
  11285. hits the dialplan if the extension it was transferred to was a
  11286. "parking extension", that is, the extension in the first priority
  11287. calls the Park application. Instead, the channel is immediately
  11288. sent into the holding bridge acting as the parking bridge. This
  11289. is problematic. Because we never go out to the dialplan, the CDRs
  11290. won't transition properly and the application field will not be
  11291. set to "Park". CDRs typically swallow holding bridges, so the CDR
  11292. itself won't even be generated. This patch handles this by
  11293. pulling out the holding bridge handling into its own CDR state.
  11294. CDRs now have an explicit parking state that accounts for this
  11295. specific subclass of the holding bridge. In addition, we handle
  11296. the parking stasis message to set application specific data on
  11297. the CDR such that the last known application for the CDR properly
  11298. reflects "Park". This is a bit sad since we're working around the
  11299. odd internal implementation of parking that exists in Asterisk
  11300. (and that we had to maintain in order to continue to meet some
  11301. odd use cases of parking), but at least the code to handle that
  11302. is where it belongs: in CDRs as opposed to sprinkled liberally
  11303. throughout the codebase. This patch also properly clears the
  11304. OUTBOUND channel flag from a channel when it leaves a bridge, and
  11305. tweaks up dialing handling to properly compare the correct CDR
  11306. with the channel calling/being dialed.
  11307. 2013-06-28 15:36 +0000 [r393128] Jason Parker <jparker@digium.com>
  11308. * res/stasis_http/resource_channels.c: Change some 500 errors to
  11309. 400.
  11310. 2013-06-28 02:14 +0000 [r393083-393100] David M. Lee <dlee@digium.com>
  11311. * res/res_stasis_http.c: Removed stray apostrophe. Apparently the
  11312. pluralization of an acronym does not use an apostophe, according
  11313. to most modern style guides. I feel like I've been living a lie
  11314. this whole time.
  11315. * res/res_stasis_http.c: Removed the automatic 302 redirects for
  11316. ARI URL's that end with a slash. There were some problems
  11317. redirecting RESTful API requests; notably the client would change
  11318. the request method to GET on the redirected requests. After some
  11319. looking into, I decided that a 404 would be simpler and have more
  11320. consistent behavior.
  11321. 2013-06-27 21:01 +0000 [r393034-393066] Richard Mudgett <rmudgett@digium.com>
  11322. * main/bridging.c: Change the name of some local variables in
  11323. bridging.c to reflect what they really mean.
  11324. * main/config_options.c, include/asterisk/config_options.h: Add
  11325. config framework non-empty string validation requirement option.
  11326. Add config framework OPT_CHAR_ARRAY_T and OPT_STRINGFIELD_T
  11327. non-empty requirement option. There are cases were you don't want
  11328. a config option string to be empty. To require the option string
  11329. to be non-empty, just set the aco_option_register() flags
  11330. parameter to non-zero. * Updated some config framework enum
  11331. aco_option_type comments.
  11332. 2013-06-26 20:59 +0000 [r393005] Jonathan Rose <jrose@digium.com>
  11333. * funcs/func_channel.c, include/asterisk/bridging.h,
  11334. main/bridging.c: func_channel: Read/Write after_bridge_goto
  11335. option Allows reading and setting of a channel's
  11336. after_bridge_goto datastore (closes issue ASTERISK-21875)
  11337. Reported by: Matt Jordan Review:
  11338. https://reviewboard.asterisk.org/r/2628/
  11339. 2013-06-26 19:29 +0000 [r392987] Jason Parker <jparker@digium.com>
  11340. * res/res_stasis_http_channels.c, include/asterisk/stasis_app.h,
  11341. res/stasis_http/resource_channels.h,
  11342. rest-api/api-docs/channels.json, res/stasis/control.c,
  11343. res/stasis_http/resource_channels.c: ARI: Add support for
  11344. continuing to a different location in dialplan. This allows going
  11345. elsewhere in the dialplan, so that the location can be specified
  11346. after exiting the Stasis application. (closes issue
  11347. ASTERISK-21870) Review: https://reviewboard.asterisk.org/r/2644/
  11348. 2013-06-26 19:15 +0000 [r392933-392972] Richard Mudgett <rmudgett@digium.com>
  11349. * res/res_parking.c: Remove some redundant parking config error
  11350. messages.
  11351. * main/bridging.c: Fix several problems with
  11352. ast_bridge_add_channel(). * Fix locking problems.
  11353. ast_bridge_move() locks two bridges. To do that, deadlock
  11354. avoidance must be done. Called bridge_move_locked() instead. *
  11355. Fix inconsistency in the bridge dissolve check callers. The
  11356. original caller has already removed the channel from the bridge.
  11357. The new caller has not removed the channel from the bridge.
  11358. Reverted bridge_dissolve_check() and added
  11359. bridge_dissolve_check_stolen() to be used by the new caller on
  11360. the original bridge after the channel is moved to the new bridge.
  11361. * Fix memory leak of features if the added channel was already in
  11362. a bridge. * Fix incorrect call to ast_bridge_impart(). * Renamed
  11363. bridge_chan to yanked_chan.
  11364. * channels/chan_sip.c, include/asterisk/bridging.h,
  11365. apps/confbridge/conf_chan_announce.c: Fix incorrect calls to
  11366. ast_bridge_impart(). There was a misunderstanding about
  11367. ast_bridge_impart()'s handling of the imparted channel's
  11368. reference. The channel reference is passed by the caller unless
  11369. ast_bridge_impart() returns an error. * Fixed a memory leak in
  11370. conf_announce_channel_push() if the impart failed.
  11371. * main/features.c: AMI Bridge action: Get channel xfer config after
  11372. we have found the second channel.
  11373. 2013-06-25 22:28 +0000 [r392915] Jonathan Rose <jrose@digium.com>
  11374. * res/parking/parking_applications.c, CHANGES, main/bridging.c,
  11375. res/parking/parking_bridge_features.c,
  11376. res/parking/parking_manager.c, include/asterisk/features.h,
  11377. res/parking/parking_bridge.c, res/parking/res_parking.h,
  11378. main/features.c, res/parking/parking_controller.c: res_parking:
  11379. Add Parking manager action to the new parking system (closes
  11380. issue ASTERISK-21641) Reported by: Matt Jordan Review:
  11381. https://reviewboard.asterisk.org/r/2573/
  11382. 2013-06-25 20:25 +0000 [r392898] Jason Parker <jparker@digium.com>
  11383. * Makefile: Fix typo with XML docs.
  11384. 2013-06-25 19:22 +0000 [r392864-392879] Joshua Colp <jcolp@digium.com>
  11385. * include/asterisk/sorcery.h: Add a note about being ready to
  11386. accept observer invocations before adding an observer.
  11387. * res/res_sip/sip_options.c: Move where the sorcery observer is
  11388. added for qualify to guarantee the sched_qualifies container
  11389. exists.
  11390. 2013-06-25 13:03 +0000 [r392829] Kinsey Moore <kmoore@digium.com>
  11391. * apps/app_queue.c, main/cel.c, apps/app_dial.c,
  11392. include/asterisk/stasis_channels.h, include/asterisk/cel.h,
  11393. apps/app_celgenuserevent.c, main/stasis_channels.c: CEL
  11394. refactoring cleanup This change removes AST_CEL_BRIDGE_UPDATE
  11395. since it should no longer be used because masquerade situations
  11396. are now accounted for in other ways. This also refactors usage of
  11397. AST_CEL_FORWARD to be produced by a Dial message which has been
  11398. extended with a "forward" field. (closes issue ASTERISK-21566)
  11399. Review: https://reviewboard.asterisk.org/r/2635/
  11400. 2013-06-25 01:12 +0000 [r392797-392812] Matthew Jordan <mjordan@digium.com>
  11401. * main/named_acl.c, res/res_calendar.c, /, channels/chan_motif.c,
  11402. main/http.c, main/config_options.c: Fix memory/ref counting leaks
  11403. in a variety of locations This patch fixes the following memory
  11404. leaks: * http.c: The structure containing the addresses to bind
  11405. to was not being deallocated when no longer used * named_acl.c:
  11406. The global configuration information was not disposed of *
  11407. config_options.c: An invalid read was occurring for certain
  11408. option types. * res_calendar.c: The loaded calendars on module
  11409. unload were not being properly disposed of. * chan_motif.c: The
  11410. format capabilities needed to be disposed of on module unload. In
  11411. addition, this now specifies the default options for the
  11412. maxpayloads and maxicecandidates in such a way that it doesn't
  11413. cause the invalid read in config_options.c to occur. (issue
  11414. ASTERISK-21906) Reported by: John Hardin patches: http.patch
  11415. uploaded by jhardin (license 6512) named_acl.patch uploaded by
  11416. jhardin (license 6512) config_options.patch uploaded by jhardin
  11417. (license 6512) res_calendar.patch uploaded by jhardin (license
  11418. 6512) chan_motif.patch uploaded by jhardin (license 6512)
  11419. ........ Merged revisions 392810 from
  11420. http://svn.asterisk.org/svn/asterisk/branches/11
  11421. * main/presencestate.c, main/sorcery.c,
  11422. res/parking/parking_bridge.c, main/cdr.c, main/manager.c,
  11423. main/parking.c, main/devicestate.c, main/cel.c: Fix a variety of
  11424. memory leaks This patch addresses the following memory/ref
  11425. counting leaks: * main/devicestate.c - unsubscribe and join our
  11426. devicestate message subscription * main/cel.c - clean up the
  11427. datastore and config objects on exist * main/parking.c - cleanup
  11428. memory leak of retriever snapshot on message payload destruction
  11429. * res/parking/parking_bridge.c - cleanup memory leak of retrieve
  11430. snapshot on message payload destruction * main/presencestate.c -
  11431. unsubscribe and join the caching topic on exit * manager.c -
  11432. properly unregister the manager action "BlindTransfer" *
  11433. sorcery.c - shutdown the threadpool on exit and dispose of any
  11434. wizards (issue ASTERISK-21906) Reported by: John Hardin patches:
  11435. cel.patch uploaded by jhardin (license #6512) devicestate.patch
  11436. uploaded by jhardin (license #6512) manager.patch uploaded by
  11437. jardin (license #6512) presencestate.patch uploaded by jhardin
  11438. (license #6512) retriever-channel-snapshot.patch uploaded by
  11439. jhardin (license #6512) sorcery.patch uploaded by jhardin
  11440. (license #6512)
  11441. 2013-06-24 22:05 +0000 [r392778-392779] David M. Lee <dlee@digium.com>
  11442. * tests/test_endpoints.c, tests/test_stasis_endpoints.c: Few more
  11443. menuselect fixes missed in r392777
  11444. * res/stasis_json/resource_sounds.h,
  11445. rest-api-templates/res_stasis_json_resource.c.mustache,
  11446. rest-api-templates/res_stasis_http_resource.c.mustache: Fixed
  11447. templates so that the changes from r392777 won't be overwritten
  11448. the next time we run the generators.
  11449. 2013-06-24 21:40 +0000 [r392777] Richard Mudgett <rmudgett@digium.com>
  11450. * res/res_stasis_http_playback.c, res/res_stasis_playback.c,
  11451. res/res_stasis_websocket.c, res/res_stasis_json_recordings.c,
  11452. res/res_stasis_http_channels.c, res/res_stasis_json_endpoints.c,
  11453. res/res_stasis_json_events.c, res/res_stasis_http_recordings.c,
  11454. res/res_stasis_answer.c, res/res_chan_stats.c,
  11455. res/res_stasis_http_endpoints.c, res/res_stasis_http_events.c,
  11456. res/res_stasis_json_sounds.c, res/res_stasis_bridge_add.c,
  11457. res/res_stasis_json_bridges.c, res/res_stasis_http_sounds.c,
  11458. res/res_statsd.c, res/res_stasis_http_bridges.c,
  11459. res/res_stasis_json_asterisk.c, res/res_stasis_test.c,
  11460. res/res_stasis_json_playback.c, res/res_stasis_http.c,
  11461. res/res_stasis.c, apps/app_stasis.c,
  11462. res/res_stasis_http_asterisk.c, res/res_stasis_json_channels.c:
  11463. Fix menuselect display for stasis modules. The menuselect parser
  11464. is very simple. It looks for AST_MODULE_INFO and uses any quoted
  11465. string on that line as the module summary display.
  11466. 2013-06-24 19:28 +0000 [r392729-392747] Mark Michelson <mmichelson@digium.com>
  11467. * /: Remove stray properties from merge.
  11468. * /, main/features_config.c, doc/appdocsxml.dtd: Add documentation
  11469. for features configuration. Review:
  11470. https://reviewboard.asterisk.org/r/2616 (closes issue
  11471. ASTERISK-21542) Reported by Matt Jordan
  11472. 2013-06-24 13:49 +0000 [r392700] Kinsey Moore <kmoore@digium.com>
  11473. * include/asterisk/media_index.h (added), main/file.c, main/http.c,
  11474. include/asterisk/format.h, rest-api/api-docs/sounds.json,
  11475. include/asterisk/_private.h, main/sounds_index.c (added),
  11476. res/res_stasis_http.c, main/asterisk.c, main/media_index.c
  11477. (added), include/asterisk/file.h, include/asterisk/http.h,
  11478. include/asterisk/sounds_index.h (added),
  11479. res/stasis_http/resource_sounds.c: Index installed sounds and
  11480. implement ARI sounds queries This adds support for stasis/sounds
  11481. and stasis/sounds/{ID} queries via the Asterisk RESTful Interface
  11482. (ARI, formerly Stasis-HTTP). The following changes have been made
  11483. to accomplish this: * A modular indexer was created for local
  11484. media. * A new function to get an ast_format associated with a
  11485. file extension was added. * Modifications were made to the
  11486. built-in HTTP server so that URI decoding could be deferred to
  11487. the URI handler when necessary. * The Stasis-HTTP sounds JSON
  11488. documentation was modified to handle cases where multiple
  11489. languages are installed in different formats. * Register and
  11490. Unregister events for formats were added to the system topic.
  11491. (closes issue ASTERISK-21584) (closes issue ASTERISK-21585)
  11492. Review: https://reviewboard.asterisk.org/r/2507/
  11493. 2013-06-23 19:19 +0000 [r392676] Matthew Jordan <mjordan@digium.com>
  11494. * res/res_fax.c: Properly pack the parameters into ast_json_pack
  11495. when sending a send fax message This patch properly packs the
  11496. parameters into the send fax message so that it actually work.
  11497. Missing a ',' between two string fields can be difficult to
  11498. debug, particularly when the actual packing succeeds.
  11499. Interestingly enough, this didn't actually crash until the JSON
  11500. blob we deref'd and disposed of. Since that happened in a
  11501. different thread, it was pretty tough to track down.
  11502. 2013-06-23 18:59 +0000 [r392627-392667] Joshua Colp <jcolp@digium.com>
  11503. * res/res_sip_outbound_registration.c,
  11504. res/res_sip_endpoint_identifier_ip.c, res/res_sip_acl.c: Add some
  11505. more missing ast_sorcery_generic_alloc conversions.
  11506. * tests/test_sorcery_realtime.c, tests/test_sorcery_astdb.c: Add
  11507. missing ast_sorcery_generic_alloc conversions.
  11508. * main/manager_endpoints.c: Fix a bug where messages were getting
  11509. duplicated on AMI. This was caused by forwarding all endpoint
  11510. messages to manager which includes channel messages that are
  11511. related to the endpoint. This change causes only the PeerStatus
  11512. messages to be forwarded to manager thus eliminating the
  11513. duplicate channel messages.
  11514. 2013-06-22 22:42 +0000 [r392607] Matthew Jordan <mjordan@digium.com>
  11515. * res/res_fax.c: Properly extract channel variables for the
  11516. SendFAX/ReceiveFAX Stasis messages By the time something extracts
  11517. the pointers from ast_json_pack, the channels will already be
  11518. disposed of. This patch properly pulls the information out of the
  11519. variables and packs them into the JSON blob.
  11520. 2013-06-22 14:26 +0000 [r392565-392586] Joshua Colp <jcolp@digium.com>
  11521. * include/asterisk/sorcery.h, res/res_sip/config_auth.c,
  11522. res/res_sip/sip_options.c, res/res_sip/location.c,
  11523. tests/test_sorcery.c, main/sorcery.c,
  11524. res/res_sip/config_domain_aliases.c,
  11525. res/res_sip/config_transport.c, res/res_sip/sip_configuration.c:
  11526. Make sorcery details opaque and add extended fields. Sorcery
  11527. specific object information is now opaque and allocated with the
  11528. object. This means that modules do not need to be recompiled if
  11529. the sorcery specific part is changed. It also means that sorcery
  11530. can store additional information on objects and ensure it is
  11531. freed or the reference count decreased when the object goes away.
  11532. To facilitate the above a generic sorcery allocator function has
  11533. been added which also ensures that allocated objects do not have
  11534. a lock. Extended fields have been added thanks to all of the
  11535. above which allows specific fields to be marked as extended, and
  11536. thus simply stored as-is within the object. Type safety is *NOT*
  11537. enforced on these fields. A consumer of them has to query and
  11538. ultimately perform their own safety check. What does this mean?
  11539. Extra modules can extend already defined structures without
  11540. having to modify them. Tests have also been included to verify
  11541. extended field functionality. Review:
  11542. https://reviewboard.asterisk.org/r/2585/
  11543. * res/res_sip_exten_state.exports.in (added),
  11544. res/res_sip_session.exports.in, res/res_sip_sdp_rtp.c,
  11545. res/res_sip_messaging.c (added), res/res_sip_caller_id.c,
  11546. channels/chan_gulp.c, res/res_sip_session.c,
  11547. res/res_sip_exten_state.c (added), res/res_sip/sip_options.c,
  11548. res/res_sip_pubsub.exports.in, channels/sip/include/sip.h,
  11549. include/asterisk/sdp_srtp.h (added), channels/sip/sdp_crypto.c
  11550. (removed), main/pbx.c, channels/sip/srtp.c (removed),
  11551. res/res_sip_transport_websocket.c (added), channels/chan_sip.c,
  11552. res/res_sip_registrar.c, res/res_sip/sip_distributor.c,
  11553. include/asterisk/res_sip_session.h,
  11554. include/asterisk/res_sip_exten_state.h (added),
  11555. res/res_sip/security_events.c (added),
  11556. res/res_sip_registrar_expire.c (added), res/res_sip.c,
  11557. res/res_sip_pidf.c (added), include/asterisk/res_sip_pubsub.h,
  11558. channels/sip/include/sdp_crypto.h (removed),
  11559. res/res_sip/location.c, res/res_sip_outbound_registration.c,
  11560. channels/sip/include/srtp.h (removed),
  11561. res/res_sip_endpoint_identifier_anonymous.c (added),
  11562. res/res_sip_one_touch_record_info.c (added),
  11563. res/res_sip_pubsub.c, res/res_sip/config_transport.c,
  11564. configs/res_sip.conf.sample, res/res_sip/sip_configuration.c,
  11565. res/res_sip_diversion.c (added), res/res_sip_refer.c (added),
  11566. include/asterisk/res_sip.h, res/res_sip_dtmf_info.c,
  11567. main/sdp_srtp.c (added), res/res_sip/include/res_sip_private.h,
  11568. res/res_sip.exports.in: Merge in current pimp_my_sip work,
  11569. including: 1. Security events 2. Websocket support 3. Diversion
  11570. header + redirecting support 4. An anonymous endpoint identifier
  11571. 5. Inbound extension state subscription support 6. PIDF notify
  11572. generation 7. One touch recording support (special thanks Sean
  11573. Bright!) 8. Blind and attended transfer support 9. Automatic
  11574. inbound registration expiration 10. SRTP support 11. Media offer
  11575. control dialplan function 12. Connected line support 13.
  11576. SendText() support 14. Qualify support 15. Inband DTMF detection
  11577. 16. Call and pickup groups 17. Messaging support Thanks everyone!
  11578. Side note: I'm reminded of the song "How Far We've Come" by
  11579. Matchbox Twenty.
  11580. 2013-06-22 13:58 +0000 [r392564] Matthew Jordan <mjordan@digium.com>
  11581. * res/res_fax.c: Fix a deadlock and possible crash in res_fax This
  11582. patch fixes two bugs. (1) It unlocks the channel in the framehook
  11583. handlers before attempting to grab the peer from the bridge. The
  11584. locking order for the bridging framework is bridge first, then
  11585. channel - having the channel locked while attempting to obtain
  11586. the bridge lock causes a locking inversion and a deadlock. This
  11587. patch bumps the channel ref count prior to releasing the lock in
  11588. the framehook to avoid lifetime issues. Note that this does
  11589. expose a subtle problem in framehooks; that is, something could
  11590. modify the framehook list while we are executing, causing issues
  11591. in the framehook list traversal that the callback executes in.
  11592. Fixing this is a much larger problem that is beyond the scope of
  11593. this patch - (a) we already unlock the channel in this particular
  11594. framehook and we haven't run into a problem yet (as modifying the
  11595. framehook list when a channel is about to perform a fax gateway
  11596. would be a very odd operation) and (b) migrating to an ao2
  11597. container of framehooks would be more invasive at this point. See
  11598. the referenced ASTERISK issue for more information. (2) Directly
  11599. packing channel variables into a JSON object turned out to be
  11600. unsafe. A condition existed where the strings in the JSON blob
  11601. were no longer safe to be accessed if the channel object itself
  11602. was disposed of. (issue ASTERISK-21951)
  11603. 2013-06-22 12:40 +0000 [r392538] Joshua Colp <jcolp@digium.com>
  11604. * include/asterisk/res_sip.h, main/manager_endpoints.c (added),
  11605. include/asterisk/stasis_endpoints.h, channels/chan_iax2.c,
  11606. include/asterisk/manager.h, channels/chan_gulp.c,
  11607. main/stasis_endpoints.c, res/res_sip.c, main/manager.c,
  11608. channels/chan_sip.c, channels/chan_skinny.c,
  11609. res/res_sip/sip_configuration.c: Migrate PeerStatus events to
  11610. stasis, add stasis endpoints, and add chan_pjsip device state.
  11611. (closes issue ASTERISK-21489) (closes issue ASTERISK-21503)
  11612. Review: https://reviewboard.asterisk.org/r/2601/
  11613. 2013-06-21 22:39 +0000 [r392514] Richard Mudgett <rmudgett@digium.com>
  11614. * bridges/bridge_simple.c, bridges/bridge_softmix.c,
  11615. bridges/bridge_native_rtp.c, main/bridging.c,
  11616. include/asterisk/bridging_technology.h, bridges/bridge_holding.c,
  11617. include/asterisk/bridging.h: Extract a useful routine from the
  11618. softmix bridge technology. * Extract a useful routine from the
  11619. softmix bridge technology for other technologies. Make other
  11620. technologies use it if they can. * Made native and 1-1 bridges
  11621. write to all parties if the bridge channel writing the frame into
  11622. the bridge is NULL. Softmix will also do the same for frame types
  11623. that make sense. * Tweak the bridge write routine return value
  11624. meaning and adjust the bridge technologies to match.
  11625. 2013-06-21 21:22 +0000 [r392489] Matthew Jordan <mjordan@digium.com>
  11626. * channels/chan_gulp.c: Add BUGBUG for broken direct media in
  11627. chan_gulp (issue ASTERISK-21947)
  11628. 2013-06-21 18:54 +0000 [r392464] Jason Parker <jparker@digium.com>
  11629. * rest-api/api-docs/channels.json: Fix typo.
  11630. 2013-06-21 18:10 +0000 [r392437] Richard Mudgett <rmudgett@digium.com>
  11631. * main/bridging.c: Add channel optimization interaction with frame
  11632. hooks BUGBUG comments.
  11633. 2013-06-21 18:05 +0000 [r392436] Mark Michelson <mmichelson@digium.com>
  11634. * channels/chan_unistim.c: Change chan_unistim to use core transfer
  11635. API. Review: https://reviewboard.asterisk.org/r/2553 (closes
  11636. issue ASTERISK-21527) Reported by Matt Jordan
  11637. 2013-06-21 17:48 +0000 [r392435] Richard Mudgett <rmudgett@digium.com>
  11638. * bridges/bridge_softmix.c, main/bridging.c,
  11639. include/asterisk/bridging_technology.h,
  11640. include/asterisk/bridging.h, main/features.c: Change several
  11641. bridge functions to return error status. The bridge frame queue
  11642. functions need to return an error status if the frame failed to
  11643. be queued because of an error condition. The main calls that
  11644. needed to return the status are:
  11645. ast_bridge_channel_queue_action_data() and
  11646. ast_bridge_channel_write_action_data(). The other return changes
  11647. are ripple effects.
  11648. 2013-06-21 14:21 +0000 [r392409] Matthew Jordan <mjordan@digium.com>
  11649. * contrib/scripts/autosupport: Update autosupport script This patch
  11650. updates the autosupport script to collect all information
  11651. available to the Asterisk CLI command "digium_phones". It also
  11652. makes minor improvements in options handling. (closes issue
  11653. AST-1163) Reported by: Trey Blancher patches:
  11654. 390347_autosupport.diff uploaded by tblancher (License 5821)
  11655. 390348_autosupport.diff uploaded by tblancher (License 5821)
  11656. 2013-06-20 21:13 +0000 [r392364] Joshua Colp <jcolp@digium.com>
  11657. * res/res_sip_session.c: Add a log message for when an incoming
  11658. session is rejected due to the extension not being found.
  11659. 2013-06-20 17:21 +0000 [r392335] Richard Mudgett <rmudgett@digium.com>
  11660. * include/asterisk/bridging_features.h, main/features.c,
  11661. main/bridging.c, res/parking/parking_bridge_features.c,
  11662. apps/confbridge/conf_config_parser.c: Fix potential bridge hook
  11663. resource leak if the hook install fails.
  11664. 2013-06-20 16:29 +0000 [r392318] Mark Michelson <mmichelson@digium.com>
  11665. * main/threadpool.c: Fix threadpool rapid growth problem. When a
  11666. threadpool is set to autoincrement its threadcount, an issue may
  11667. arise when multiple tasks are queued at once into the threadpool.
  11668. Since threads start active, each new task would result in
  11669. autoincrementing the thread count. So if all threads were active,
  11670. and a thread's autoincrement value were 5, then 3 new tasks would
  11671. result in 15 threads being created even though the initial
  11672. autoincrement was sufficient to handle the number of tasks. This
  11673. change introduces three behavior changes: 1) New threads in the
  11674. threadpool start idle instead of active. 2) When a threadpool
  11675. autoincrements, one thread is activated after the growth. 3) When
  11676. a threadpool's size is incremented manually, all added threads
  11677. are activated. For a more detailed explanation about the changes,
  11678. please see the Review Board link at the bottom of this commit.
  11679. Review: https://reviewboard.asterisk.org/r/2629
  11680. 2013-06-19 22:52 +0000 [r392279] David M. Lee <dlee@digium.com>
  11681. * Makefile, main/Makefile: Fix build problem on OS X Mountain Lion
  11682. (10.8) For about forever, our build flags for OS X have been
  11683. slightly off, but good enough to build and run. Apparently they
  11684. aren't good enough any more. Previously, we would compile with
  11685. macosx-version-min unset and link with it set. This combination,
  11686. using GCC 4.8, on Mountain Lion, would create a bad executable
  11687. ("Illegal Instruction: 4", or something like that) This patch
  11688. consistently sets macosx-version-min for both compiling and
  11689. linking, which makes everything happy enough to build and run.
  11690. 2013-06-19 12:55 +0000 [r392241] Kinsey Moore <kmoore@digium.com>
  11691. * include/asterisk/cel.h, main/cel.c: Pull CEL linkedid
  11692. manipulation into cel.c This finishes moving all CEL linkedid
  11693. tracking entirely within cel.c since that is now possible with
  11694. channel snapshots. This also removes another CEL linkedid
  11695. manipulation function from cel.h that has already been
  11696. internalized and is neither called nor available to link against.
  11697. Review: https://reviewboard.asterisk.org/r/2632/
  11698. 2013-06-19 01:28 +0000 [r392190-392214] Matthew Jordan <mjordan@digium.com>
  11699. * funcs/func_cdr.c: Handle variable substitution in dummy variables
  11700. When func_cdr is used for variable substitution, there is no
  11701. channel name and hence no run-time information available for CDR
  11702. variable substitution. In that case, the correct thing to do is
  11703. to use the CDR object on the channel passed to the function. This
  11704. patch checks to see if the channel passed in has a name - if not,
  11705. it uses ast_cdr_format_var instead of ast_cdr_get_var. This
  11706. allows CDR backends to continue to use variable substitution in
  11707. order to resolve ast_cdr object properties.
  11708. * tests/test_substitution.c: Fix the test_substitution test In
  11709. r391947, the CDR function was modified such that it will return a
  11710. value for the start,answer, and end times if asked. That time
  11711. will just be 0 if it hasn't happened yet.
  11712. 2013-06-18 19:31 +0000 [r392139-392166] Richard Mudgett <rmudgett@digium.com>
  11713. * main/bridging.c, include/asterisk/bridging.h: Bridging: Fix crash
  11714. on destruction of a partially constructed bridge. * Promoted some
  11715. bridge construction debug messages to warnings.
  11716. * main/bridging.c: Add some safety cleanup for a failed push into a
  11717. bridge.
  11718. * main/bridging_basic.c: Remove stub comment on function that is
  11719. not a stub.
  11720. 2013-06-18 14:30 +0000 [r392116] Kinsey Moore <kmoore@digium.com>
  11721. * include/asterisk/stasis_bridging.h,
  11722. rest-api/api-docs/bridges.json, main/stasis_bridging.c: Fix
  11723. bridge snapshot conversion to JSON This makes
  11724. ast_bridge_snapshot_to_json conform to the swagger Bridge model
  11725. by adding the two fields it required. Review:
  11726. https://reviewboard.asterisk.org/r/2583/
  11727. 2013-06-17 18:58 +0000 [r392076] David M. Lee <dlee@digium.com>
  11728. * funcs/func_cdr.c, main/cdr.c: Fix build warnings related to
  11729. printf/scanf of tv_usec. The type of tv_usec is suseconds_t. On
  11730. Linux, this is usually a long int, but the specification is
  11731. actually pretty lax on what it might actually be. And, sadly,
  11732. there's no printf/scanf width specifier for suseconds_t. So it
  11733. could bit an int or a long, but there's not a great way to tell
  11734. which it is. This patch fixes scanf by reading into a long
  11735. temporary variable that's then stored into the tv_usec. It fixes
  11736. printf by casting the tv_usec to a long first. This patch also
  11737. adds some missing width specifiers for some debug statements,
  11738. which would cause ".000001" to be displayed at ".1".
  11739. 2013-06-17 18:37 +0000 [r392053-392073] Richard Mudgett <rmudgett@digium.com>
  11740. * main/channel.c, channels/chan_vpb.cc: chan_vpb: Fix compile error
  11741. and __ast_channel_alloc() prototype const inconsistency.
  11742. * channels/chan_misdn.c: chan_misdn: Fix compile error after CDR
  11743. merge.
  11744. 2013-06-17 16:59 +0000 [r392032] Jason Parker <jparker@digium.com>
  11745. * include/asterisk/app.h: Fix a build warning with stasis messages.
  11746. 2013-06-17 14:40 +0000 [r392004-392005] Matthew Jordan <mjordan@digium.com>
  11747. * main/manager_channels.c: Prevent sending a NewExten event after a
  11748. Hangup during a stack restore When a channel is originated, its
  11749. application is typically set to AppDial2, indicating that it was
  11750. a dialed channel through the Dial API. Asterisk during an
  11751. originate will perform a stack execute to direct the outgoing
  11752. channel to a particular place in the dialplan or application.
  11753. When the stack returns, the previous application (AppDial2) is
  11754. restored. Unfortunately, in the case of an originated channel,
  11755. the stack restore happens after hangup. A stasis message is sent
  11756. notifying everyone that the application was restored, and this
  11757. causes a NewExten event to go out after the Hangup event,
  11758. violating the basic contract consumers have of the channel
  11759. lifetime. While we could preclude the message from going out,
  11760. restoring the channel's state before it executed the next higher
  11761. frame in the stack has to occur, and other places in the code
  11762. depend on this behavior. Since we know that channel hung up (it's
  11763. a ZOMBIE!), this patch simply checks to see if the channel has
  11764. been zombified before sending a NewExten event. Note that this
  11765. will fix a number of bouncing tests in the Test Suite. Go tests.
  11766. * CHANGES: Restore bad merge on CHANGES The patch for CDRs moved
  11767. around a lot of content in CHANGES to try and organize the areas
  11768. that were affected. This missed some changes that went in with a
  11769. merge and removed some updates - this patch adds them back in.
  11770. 2013-06-17 12:28 +0000 [r391982] Joshua Colp <jcolp@digium.com>
  11771. * main/cdr.c: Fix build warning (which is transmogrified into an
  11772. error) with my compiler due to uninitialized variable.
  11773. 2013-06-17 03:31 +0000 [r391947-391964] Matthew Jordan <mjordan@digium.com>
  11774. * addons/cdr_mysql.c: Make cdr_mysql compile again by not directly
  11775. setting the run-time CDR object A stray ast_cdr_setvar was missed
  11776. in cdr_mysql (silly addons). This has now been refactored to not
  11777. set the property, as the property would have been set on a
  11778. run-time object that was already dispatched to the backend. The
  11779. module simply remembers the value it wanted to set and writes it
  11780. to MySQL later in the processing.
  11781. * apps/app_forkcdr.c, include/asterisk/stasis_channels.h,
  11782. main/test.c, channels/chan_h323.c, main/asterisk.c,
  11783. channels/chan_unistim.c, addons/chan_ooh323.c,
  11784. include/asterisk/cel.h, apps/app_authenticate.c, cdr/cdr_pgsql.c,
  11785. apps/app_followme.c, channels/chan_iax2.c,
  11786. res/res_config_sqlite.c, main/stasis.c, cdr/cdr_csv.c,
  11787. main/cli.c, main/dial.c, channels/chan_skinny.c,
  11788. cel/cel_manager.c, res/res_agi.c, main/stasis_channels.c,
  11789. cdr/cdr_odbc.c, tests/test_cdr.c (added), main/bridging_basic.c,
  11790. main/pbx.c, channels/chan_sip.c, main/channel_internal_api.c,
  11791. UPGRADE.txt, include/asterisk/cdr.h, include/asterisk/channel.h,
  11792. res/res_stasis_answer.c, main/cel.c, cdr/cdr_tds.c,
  11793. funcs/func_channel.c, funcs/func_cdr.c,
  11794. include/asterisk/bridging.h, addons/cdr_mysql.c,
  11795. funcs/func_callerid.c, apps/app_cdr.c, include/asterisk/time.h,
  11796. cel/cel_radius.c, include/asterisk/stasis_internal.h (added),
  11797. include/asterisk/channel_internal.h, main/utils.c,
  11798. cdr/cdr_adaptive_odbc.c, cdr/cdr_radius.c, main/channel.c,
  11799. main/cdr.c, include/asterisk/test.h, channels/chan_dahdi.c,
  11800. main/manager.c, apps/app_osplookup.c, main/features.c,
  11801. apps/app_dumpchan.c, main/manager_channels.c, main/bridging.c,
  11802. cdr/cdr_custom.c, channels/chan_mgcp.c, cdr/cdr_manager.c,
  11803. apps/app_dial.c, main/stasis_cache.c, cdr/cdr_syslog.c,
  11804. cel/cel_tds.c, channels/chan_agent.c, apps/app_disa.c,
  11805. apps/app_queue.c, CHANGES, res/res_monitor.c: Update Asterisk's
  11806. CDRs for the new bridging framework This patch is the initial
  11807. push to update Asterisk's CDR engine for the new bridging
  11808. framework. This patch guts the existing CDR engine and builds the
  11809. new on top of messages coming across Stasis. As changes in
  11810. channel state and bridge state are detected, CDRs are built and
  11811. dispatched accordingly. This fundamentally changes CDRs in a few
  11812. ways. (1) CDRs are now *very* reflective of the actual state of
  11813. channels and bridges. This means CDRs track well with what an
  11814. actual channel is doing - which is useful in transfer scenarios
  11815. (which were previously difficult to pin down). It does, however,
  11816. mean that CDRs cannot be 'fooled'. Previous behavior in Asterisk
  11817. allowed for CDR applications, channels, and other properties to
  11818. be spoofed in parts of the code - this no longer works. (2) CDRs
  11819. have defined behavior in multi-party scenarios. This behavior
  11820. will not be what everyone wants, but it is a defined behavior and
  11821. as such, it is predictable. (3) The CDR manipulation functions
  11822. and applications have been overhauled. Major changes have been
  11823. made to ResetCDR and ForkCDR in particular. Many of the options
  11824. for these two applications no longer made any sense with the new
  11825. framework and the (slightly) more immutable nature of CDRs. There
  11826. are a plethora of other changes. For a full description of CDR
  11827. behavior, see the CDR specification on the Asterisk wiki. (closes
  11828. issue ASTERISK-21196) Review:
  11829. https://reviewboard.asterisk.org/r/2486/
  11830. 2013-06-14 23:26 +0000 [r391921] Mark Michelson <mmichelson@digium.com>
  11831. * main/app.c: Fix regression in MWI stasis handling. In revision
  11832. 389733, mwi state allocation was placed into its own function
  11833. instead of performing the allocation in-line when required. The
  11834. issue was that in ast_publish_mwi_state_full(), the local
  11835. variable "uniqueid" was no longer being set, but it was still
  11836. being used as the topic for MWI. This meant that all MWI
  11837. publications ended up being published to the "" (empty string)
  11838. mailbox topic. Thus MWI subscriptions for specific mailboxes were
  11839. never notified of mailbox state changes. This change fixes the
  11840. issue by removing the local uniqueid variable from
  11841. ast_publish_mwi_state_full() and instead referencing the
  11842. mwi_state->uniqueid field since it has been properly set. (closes
  11843. issue ASTERISK-21913) Reported by Malcolm Davenport
  11844. 2013-06-14 21:57 +0000 [r391902] Joshua Colp <jcolp@digium.com>
  11845. * res/res_sip_registrar.c: Ensure that the number of added contacts
  11846. never goes below 0. This can happen when a REGISTER request is
  11847. removing a contact. (closes issue ASTERISK-21911) Reported by:
  11848. mdavenport
  11849. 2013-06-14 18:50 +0000 [r391855-391856] Kinsey Moore <kmoore@digium.com>
  11850. * main/stasis_bridging.c, include/asterisk/stasis_bridging.h,
  11851. rest-api/api-docs/bridges.json: Revert parts of r391855 that were
  11852. not ready to go in to trunk
  11853. * main/cel.c, include/asterisk/stasis_bridging.h,
  11854. rest-api/api-docs/bridges.json, main/stasis_bridging.c: Fix two
  11855. more possible crashes in CEL These are locations that should
  11856. return valid snapshots, but need to be handled if not.
  11857. 2013-06-14 16:32 +0000 [r391828] Jonathan Rose <jrose@digium.com>
  11858. * apps/app_mixmonitor.c, /: app_mixmonitor: Fix crashes caused by
  11859. unloading app_mixmonitor Unloading app_mixmonitor while active
  11860. mixmonitors were running would cause a segfault. This patch fixes
  11861. that by making it impossible to unload app_mixmonitor while
  11862. mixmonitors are active. Review:
  11863. https://reviewboard.asterisk.org/r/2624/ ........ Merged
  11864. revisions 391778 from
  11865. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11866. revisions 391794 from
  11867. http://svn.asterisk.org/svn/asterisk/branches/11
  11868. 2013-06-14 16:12 +0000 [r391776-391777] Kinsey Moore <kmoore@digium.com>
  11869. * main/cel.c: Fix a crash in CEL bridge snapshot handling Properly
  11870. search for bridge association structures so that they are found
  11871. when expected and handle cases where they don't exist.
  11872. * main/bridging.c: Publish bridge snapshots more often Bridge
  11873. snapshot events were missing some important transitions that were
  11874. noticed in subsequent snapshots. Snapshots will now be published
  11875. on all bridge reconfigurations.
  11876. 2013-06-13 21:53 +0000 [r391732] Matthew Jordan <mjordan@digium.com>
  11877. * utils/check_expr.c, utils/refcounter.c, utils/ael_main.c,
  11878. utils/conf2ael.c: Make the utils directory compile... again.
  11879. Utils is a source folder that lies, eventually all developers
  11880. will cry, "I know I must maintain it, But really with this last
  11881. commit I can kiss my software ethics good-bye."
  11882. 2013-06-13 19:04 +0000 [r391701] Richard Mudgett <rmudgett@digium.com>
  11883. * apps/app_confbridge.c, apps/confbridge/conf_config_parser.c, /,
  11884. apps/confbridge/include/confbridge.h: app_confbridge: Fix memory
  11885. leak on reload. The config framework options should not be
  11886. registered multiple times. Instead the configuration just needs
  11887. to be reprocessed by the config framework. ........ Merged
  11888. revisions 391700 from
  11889. http://svn.asterisk.org/svn/asterisk/branches/11
  11890. 2013-06-13 18:26 +0000 [r391699] Mark Michelson <mmichelson@digium.com>
  11891. * main/features_config.c: Just return outright on a reload since we
  11892. have already processed configuration.
  11893. 2013-06-13 18:20 +0000 [r391689] Kinsey Moore <kmoore@digium.com>
  11894. * main/cel.c: Ensure that Asterisk still starts up when cel.conf is
  11895. missing
  11896. 2013-06-13 18:17 +0000 [r391676] Mark Michelson <mmichelson@digium.com>
  11897. * main/features_config.c: Fix memory leak in features_config.c The
  11898. options should not be registered multiple times. Instead, the
  11899. configuration just needs to be reprocessed by the config
  11900. framework. This also exposed that we were not properly telling
  11901. the config framework to treat the configuration processing with
  11902. the "reload" semantics when a reload occurred. Both of these
  11903. errors are fixed now. Thanks to Richard Mudgett for discovering
  11904. the leak.
  11905. 2013-06-13 18:14 +0000 [r391675] Matthew Jordan <mjordan@digium.com>
  11906. * main/json.c, main/manager.c, include/asterisk/json.h: Blow away
  11907. usage of libjansson's foreach macro While very handy, this macro
  11908. didn't occur until a later version of libjansson. We'd prefer to
  11909. be compatible with older versions still - as such, iteration over
  11910. key/value pairs in a JSON object have to be done with a little
  11911. bit more manual work.
  11912. 2013-06-13 13:46 +0000 [r391622-391643] Kinsey Moore <kmoore@digium.com>
  11913. * main/parking.c, include/asterisk/cel.h, main/features.c,
  11914. include/asterisk/_private.h, main/cel.c,
  11915. include/asterisk/parking.h, main/asterisk.c,
  11916. res/parking/parking_manager.c: Refactor CEL bridge events on top
  11917. of Stasis-Core This pulls bridge-related CEL event triggers out
  11918. of the code in which they were residing and pulls them into cel.c
  11919. where they are now triggered by changes in bridge snapshots. To
  11920. get access to the Stasis-Core parking topic in cel.c, the
  11921. Stasis-Core portions of parking init have been pulled into core
  11922. Asterisk init. This also adds a new CEL event
  11923. (AST_CEL_BRIDGE_TO_CONF) that indicates a two-party bridge has
  11924. transitioned to a multi-party conference. The reverse cannot
  11925. occur in CEL terms even though it may occur in actuality and two
  11926. party bridges which receive a AST_CEL_BRIDGE_TO_CONF will be
  11927. treated as multi-party conferences for the duration of the
  11928. bridge. Review: https://reviewboard.asterisk.org/r/2563/ (closes
  11929. issue ASTERISK-21564)
  11930. * include/asterisk/strings.h, main/cel.c,
  11931. include/asterisk/stasis_bridging.h, main/asterisk.c,
  11932. main/channel.c, include/asterisk/config_options.h, main/pbx.c,
  11933. include/asterisk/stasis_channels.h, main/stasis_bridging.c,
  11934. main/config_options.c, main/stasis_channels.c: Refactor CEL
  11935. channel events on top of Stasis-Core This uses the channel state
  11936. change events from Stasis-Core to determine when channel-related
  11937. CEL events should be raised. Those refactored in this patch are:
  11938. * AST_CEL_CHANNEL_START * AST_CEL_ANSWER * AST_CEL_APP_START *
  11939. AST_CEL_APP_END * AST_CEL_HANGUP * AST_CEL_CHANNEL_END Retirement
  11940. of Linked IDs is also refactored. CEL configuration has been
  11941. refactored to use the config framework. Note: Some HANGUP events
  11942. are not generated correctly because the bridge layer does not
  11943. propagate hangupcause/hangupsource information yet. Review:
  11944. https://reviewboard.asterisk.org/r/2544/ (closes issue
  11945. ASTERISK-21563)
  11946. 2013-06-13 11:02 +0000 [r391596] Joshua Colp <jcolp@digium.com>
  11947. * main/endpoints.c, res/stasis_http/resource_endpoints.c,
  11948. main/stasis_cache.c, main/stasis_endpoints.c,
  11949. main/channel_internal_api.c, include/asterisk/stasis.h,
  11950. include/asterisk/channel.h, include/asterisk/stasis_endpoints.h:
  11951. Add support for requiring that all queued messages on a caching
  11952. topic have been handled before retrieving from the cache and also
  11953. change adding channels to an endpoint to be an immediate
  11954. operation. Review: https://reviewboard.asterisk.org/r/2599/
  11955. 2013-06-12 21:08 +0000 [r391561] David M. Lee <dlee@digium.com>
  11956. * res/res_http_websocket.c, /: Fix segfault for certain invalid
  11957. WebSocket input. The WebSocket code would allocate, on the stack,
  11958. a string large enough to hold a key provided by the client, and
  11959. the WEBSOCKET_GUID. If the key is NULL, this causes a segfault.
  11960. If the key is too large, it could overflow the stack. This patch
  11961. checks the key for NULL and checks the length of the key to avoid
  11962. stack smashing nastiness. (closes issue ASTERISK-21825) Reported
  11963. by: Alfred Farrugia Tested by: Alfred Farrugia, David M. Lee
  11964. Patches: issueA21825_check_if_key_is_sent.patch uploaded by
  11965. Walter Doekes (license 5674) ........ Merged revisions 391560
  11966. from http://svn.asterisk.org/svn/asterisk/branches/11
  11967. 2013-06-12 02:29 +0000 [r391479-391521] Matthew Jordan <mjordan@digium.com>
  11968. * main/loader.c, main/format.c, /, main/endpoints.c: Fix memory
  11969. leak while loading modules, adding formats, and destroying
  11970. endpoints This patch fixes three memory leaks * When we load a
  11971. module with the LOAD_PRIORITY flag, we remove its entry from the
  11972. load order list. Unfortunately, we don't free the memory
  11973. associated with entry in the list. This patch corrects that and
  11974. properly frees the memory for the module in the list. * When
  11975. adding a custom format (such as SILK or CELT), the routine for
  11976. adding the format was leaking a reference. RAII_VAR cleans this
  11977. up properly. * We now de-ref the channel_snapshot appropriately
  11978. when an endpoint is disposed of ........ Merged revisions 391489
  11979. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  11980. Merged revisions 391507 from
  11981. http://svn.asterisk.org/svn/asterisk/branches/11
  11982. * main/stasis_channels.c, bridges/bridge_native_rtp.c: Fix memory
  11983. leaks in stasis_channels and bridge_native_rtp This patch fixes
  11984. two memory leaks: * A memory leak in packing channels into a
  11985. multi-channel blob payload when publishing dial messages. The
  11986. multi-channel blob payload does not steal the references - this
  11987. approach was chosen because it works well with the RAII_VAR
  11988. macro. Unfortunately, this does mean that you actually have to
  11989. use the RAII_VAR macro (or manually deref it yourself) * RTP
  11990. instances returned as a result of one of the glue operations are
  11991. ref counted and have to be de-ref'd appropriately. We now do
  11992. that, as saying that we should do it and then not would be silly.
  11993. 2013-06-11 22:57 +0000 [r391455] Mark Michelson <mmichelson@digium.com>
  11994. * main/bridging.c: Remove incorrect comment about local channel
  11995. optimization occurring when performing an attended transfer on an
  11996. entire bridge.
  11997. 2013-06-11 22:21 +0000 [r391430-391453] Jonathan Rose <jrose@digium.com>
  11998. * bridges/bridge_native_rtp.c, include/asterisk/framehook.h,
  11999. main/framehook.c: bridge_native_rtp: Fix native bridge tech being
  12000. incompatible when it should be. When checking compatability for
  12001. the native RTP bridge technology there is a race condition
  12002. between clearing framehooks that are destroyed when leaving
  12003. certain bridges with certain technologies (such as
  12004. bridge_native_rtp) and joining bridges with the bridge_native_rtp
  12005. technology. Yes, that means a channel in a native RTP bridge
  12006. could move to another native RTP bridge and be considered
  12007. incompatible with the new native RTP bridge causing it to revert
  12008. to a simple bridge technology0. This fixes that bug by ignoring
  12009. framehooks that have been marked for destruction when checking
  12010. for compatibility with the bridge_native_rtp technology.
  12011. * bridges/bridge_native_rtp.c: bridge_native_rtp: Fix possible
  12012. segfaults on leaves/joins native_rtp_bridge_get can return any
  12013. result from the ast_rtp_glue_result enumerator and the join/leave
  12014. functions for bridge_native_rtp seem to assume that if the result
  12015. wasn't local that it was remote. Meanwhile forbid can be returned
  12016. by that function which can mean certain glue pointers are NULL.
  12017. Then when the join/leave functions try to use members of that
  12018. pointer, boom. Segfault.
  12019. 2013-06-11 15:46 +0000 [r391403] David M. Lee <dlee@digium.com>
  12020. * main/manager.c, main/stasis_message.c, main/parking.c,
  12021. tests/test_stasis_channels.c, include/asterisk/stasis.h,
  12022. main/stasis_channels.c, tests/test_stasis.c,
  12023. main/manager_channels.c: Add vtable and methods for to_json and
  12024. to_ami for Stasis messages When a Stasis message type is defined
  12025. in a loadable module, handling those messages for AMI and
  12026. res_stasis events can be cumbersome. This patch adds a vtable to
  12027. stasis_message_type, with to_ami and to_json virtual functions.
  12028. These allow messages to be handled abstractly without putting
  12029. module-specific code in core. As an example, the VarSet AMI event
  12030. was refactored to use the to_ami virtual function. (closes issue
  12031. ASTERISK-21817) Review: https://reviewboard.asterisk.org/r/2579/
  12032. 2013-06-11 10:24 +0000 [r391380] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  12033. * channels/chan_unistim.c, /: Fix issue with no sound in both way
  12034. in case of previous call to chan_unistim phone was canceled.
  12035. (related to ASTERISK-20183) ........ Merged revisions 391379 from
  12036. http://svn.asterisk.org/svn/asterisk/branches/11
  12037. 2013-06-11 08:13 +0000 [r391335] Alec L Davis <sivad.a@paradise.net.nz>
  12038. * channels/chan_iax2.c, /: IAX2: Transfer Reject: Lock bridgecallno
  12039. before touching it, refactor 1). When touching the bridgecallno,
  12040. we need to lock it. 2). Remove magic number '0' and replace with
  12041. TRANSFER_NONE. 3). Exit early if no bridgecallno. 4). Reduce
  12042. indentation. Reported by: alecdavis Tested by: alecdavis
  12043. alecdavis (license 585) Review
  12044. https://reviewboard.asterisk.org/r/2613/ ........ Merged
  12045. revisions 391333 from
  12046. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12047. revisions 391334 from
  12048. http://svn.asterisk.org/svn/asterisk/branches/11
  12049. 2013-06-10 22:38 +0000 [r391314] Matthew Jordan <mjordan@digium.com>
  12050. * main/loader.c: Make the reload stasis message bump the ref count
  12051. of its sub-object JSON objects are reference stealing. Hence, if
  12052. you've RAII_VAR'd some subobject and want to pack it into another
  12053. JSON object, you have to bump the reference count. Using the 'O'
  12054. option during the pack will bump the reference count for you.
  12055. 2013-06-10 21:04 +0000 [r391297] Damien Wedhorn <voip@facts.com.au>
  12056. * channels/chan_skinny.c: Change chan_skinny to use core transfer
  12057. API. Changes for both attended and blind transfers in chan_skinny
  12058. to use the new transfer API instead of masquerade. (closes issue
  12059. ASTERISK-21526) Reported by: Matt Jordan Review:
  12060. https://reviewboard.asterisk.org/r/2557/
  12061. 2013-06-10 16:03 +0000 [r391271] Kinsey Moore <kmoore@digium.com>
  12062. * res/res_agi.c: Add AGI command arguments to AsyncAGI event This
  12063. makes the AGI AsyncAGI event put provided AGI command arguments
  12064. in the event's environment. (closes issue ASTERISK-21304)
  12065. Patch-By: Dirk Wendland
  12066. 2013-06-10 15:32 +0000 [r391269] Mark Michelson <mmichelson@digium.com>
  12067. * main/features_config.c: Temporary fix for people using sample
  12068. features.conf from previous Asterisk versions. People who use the
  12069. features.conf.sample file from Asterisk 11 and before in trunk
  12070. were given a rude awakening when features configuration changes
  12071. were made. Because it uses the config framework and the config
  12072. framework is strict about what is accepted and what isn't, people
  12073. that had parking options configured found that Asterisk no longer
  12074. started. This is because parking options are currently handled in
  12075. res_parking.conf instead of features.conf. This fix seeks to
  12076. create a temporary band-aid fix for the problem, but having
  12077. parking options from the general section be passed to a handler
  12078. that will simply print that the option is no longer supported.
  12079. This will not cause Asterisk to exit. The fix only applies to
  12080. options in the general section. There are two main reasons for
  12081. this: 1) The sample features.conf file only has parking options
  12082. in the general section. There are no configured parking lots.
  12083. Therefore it's not quite as "urgent" to get the parking lot
  12084. parsing fixed. 2) The plan is to move parking configuration back
  12085. from res_parking.conf to features.conf. When that happens, the
  12086. parking lots will also be addressed at that time.
  12087. 2013-06-10 14:36 +0000 [r391245] Matthew Jordan <mjordan@digium.com>
  12088. * apps/app_queue.c, /, configs/queues.conf.sample, UPGRADE.txt: Add
  12089. announce-to-first-user option for app_queue In r386792, the
  12090. ability to play prompts to the first caller in a call queue was
  12091. added. While this is arguably a bug fix for those who expect the
  12092. first caller to continue receiving prompts while the agent is
  12093. dialed, it has the side effect of preventing the first caller
  12094. from hearing the agent immediately upon bridging. This may not be
  12095. a problem for those who really want this option, but for those
  12096. who didn't care whether or not the first caller in queue heard
  12097. their position, it was an issue. This patch disables the ability
  12098. for the first caller in the queue to hear prompts and adds a new
  12099. option, announce-to-first-user, to queues.conf. Those who the
  12100. behavior can enable it by setting this value to True. Note that
  12101. if we ever implement the ability to have the prompts be stopped
  12102. upon bridging, this option can be removed. (closes issue
  12103. ASTERISK-21782) Reported by: Remi Quezada ........ Merged
  12104. revisions 391215 from
  12105. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12106. revisions 391241 from
  12107. http://svn.asterisk.org/svn/asterisk/branches/11
  12108. 2013-06-10 13:07 +0000 [r391199] Kinsey Moore <kmoore@digium.com>
  12109. * res/res_stasis_bridge_add.exports.in (added),
  12110. include/asterisk/stasis_app.h,
  12111. res/stasis_http/resource_bridges.c, res/stasis/app.h,
  12112. res/res_stasis_json_events.c, include/asterisk/stasis_bridging.h,
  12113. rest-api/api-docs/bridges.json,
  12114. res/stasis_http/resource_bridges.h, res/res_stasis_bridge_add.c
  12115. (added), main/stasis_bridging.c,
  12116. res/stasis_json/resource_events.h, res/res_stasis.c,
  12117. res/res_stasis_json_events.exports.in,
  12118. rest-api/api-docs/events.json, res/stasis/control.c,
  12119. res/stasis/app.c: Stasis-HTTP: Flesh out bridge-related
  12120. capabilities This adds support for Stasis applications to receive
  12121. bridge-related messages when the application shows interest in a
  12122. given bridge. To supplement this work and test it, this also adds
  12123. support for the following bridge-related Stasis-HTTP
  12124. functionality: * GET stasis/bridges * GET
  12125. stasis/bridges/{bridgeId} * POST stasis/bridges * DELETE
  12126. stasis/bridges/{bridgeId} * POST
  12127. stasis/bridges/{bridgeId}/addChannel * POST
  12128. stasis/bridges/{bridgeId}/removeChannel Review:
  12129. https://reviewboard.asterisk.org/r/2572/ (closes issue
  12130. ASTERISK-21711) (closes issue ASTERISK-21621) (closes issue
  12131. ASTERISK-21622) (closes issue ASTERISK-21623) (closes issue
  12132. ASTERISK-21624) (closes issue ASTERISK-21625) (closes issue
  12133. ASTERISK-21626)
  12134. 2013-06-10 09:33 +0000 [r391064-391154] Alec L Davis <sivad.a@paradise.net.nz>
  12135. * /, channels/chan_iax2.c: chan_iax2: nativebridge refactor, missed
  12136. unlock bridgecallno ........ Merged revisions 391143 from
  12137. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12138. revisions 391148 from
  12139. http://svn.asterisk.org/svn/asterisk/branches/11
  12140. * channels/chan_iax2.c, /: fix bad edit after conflict resolution
  12141. ........ Merged revisions 391107 from
  12142. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12143. revisions 391111 from
  12144. http://svn.asterisk.org/svn/asterisk/branches/11
  12145. * channels/chan_iax2.c, /: IAX2: refactor nativebridge transfer
  12146. remove triple checking of iaxs[fr->callno]->transferring reduce
  12147. indentation. Reported by: alecdavis Tested by: alecdavis
  12148. alecdavis (license 585) Review
  12149. https://reviewboard.asterisk.org/r/2602/ ........ Merged
  12150. revisions 391065 from
  12151. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12152. revisions 391084 from
  12153. http://svn.asterisk.org/svn/asterisk/branches/11
  12154. * channels/chan_iax2.c, /: IAX2: fix race condition with
  12155. nativebridge transfers. 1). When touching the bridgecallno, we
  12156. need to lock it. 2). stop_stuff() which calls
  12157. iax2_destroy_helper() Assumes the lock on the pvt is already
  12158. held, when iax2_destroy_helper() is called. Thus we need to lock
  12159. the bridgecallno pvt before we call
  12160. stop_stuff(iaxs[fr->callno]->bridgecallno); 3). When evaluating
  12161. the state of 'callno->transferring' of the current leg, we can't
  12162. change it to READY unless the bridgecallno is locked. Why, if we
  12163. are interrupted by the other call leg before 'transferring =
  12164. TRANSFER_RELEASED', the interrupt will find that it is READY and
  12165. that the bridgecallno is also READY so Releases the legs. (closes
  12166. issue ASTERISK-21409) Reported by: alecdavis Tested by: alecdavis
  12167. alecdavis (license 585) Review
  12168. https://reviewboard.asterisk.org/r/2594/ ........ Merged
  12169. revisions 391062 from
  12170. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12171. revisions 391063 from
  12172. http://svn.asterisk.org/svn/asterisk/branches/11
  12173. 2013-06-09 21:11 +0000 [r391012-391040] Matthew Jordan <mjordan@digium.com>
  12174. * main/app.c: Clean up MWI topic pool before message type
  12175. destruction Topics need to be disposed of prior to the message
  12176. types that are published on them. This includes topic pools. This
  12177. prevents an assertion from being raised on shutdown.
  12178. * main/manager.c: Only initialize manager_bridging during startup
  12179. This moves the initialization call behind the protection against
  12180. reloads. We don't want to re-add message router routes during
  12181. reloads.
  12182. * main/backtrace.c (added), main/logger.c, include/asterisk/lock.h,
  12183. main/astmm.c, utils/extconf.c, main/astobj2.c,
  12184. include/asterisk/backtrace.h (added), include/asterisk/logger.h:
  12185. Add backtrace generation to MALLOC_DEBUG memory corruption
  12186. reports This patch allows astmm to access the backtrace
  12187. generation code in Asterisk. When memory is allocated, a
  12188. backtrace is created and stored with the memory region that
  12189. tracks the allocation. If a memory corruption is detected, the
  12190. backtrace is printed to the astmm log. The backtrace will make
  12191. use of the BETTER_BACKTRACES build option if available. As a
  12192. result, this patch moves the backtrace generation code into its
  12193. own file and uses the non-wrapped versions of the C library
  12194. memory allocation routines. This allows the memory allocation
  12195. code to safely use the backtrace generation routines without
  12196. infinitely recursing. Review:
  12197. https://reviewboard.asterisk.org/r/2567
  12198. 2013-06-08 06:31 +0000 [r390940-390991] Richard Mudgett <rmudgett@digium.com>
  12199. * include/asterisk/bridging_technology.h, main/bridging.c: Add more
  12200. support for native bridging. * Added a start technology callback
  12201. that technologies can use to start bridging operations. It is
  12202. expected that native bridges will find this useful. * Factored
  12203. out bridge_channel_complete_join().
  12204. * main/bridging.c, include/asterisk/bridging_technology.h,
  12205. bridges/bridge_softmix.c: Fix a crash when a bridge switches from
  12206. the softmix bridge technology to another. A three party bridge
  12207. uses the softmix bridging technology. This technology has a
  12208. dedicated thread used to perform the analog mixing. When one of
  12209. these parties leaves the bridge, the bridge technology is changed
  12210. from the softmix technology to a two-party mixing technology.
  12211. Changing technologies is done by removing channels from the old
  12212. technology and adding them to the new technology. Since the
  12213. remaining channels do not leave the bridge, the softmix mixing
  12214. thread could continue to process all channels in the bridge. If
  12215. the bridge code is not able to start destruction of the softmix
  12216. technology before the softmix mixing thread wakes up, a crash
  12217. happens. * Added a stop technology callback that technologies can
  12218. use to request any helper threads to stop in preparation for
  12219. being destroyed. (closes issue AST-1156) Reported by: John
  12220. Bigelow
  12221. * include/asterisk/bridging_technology.h: Update some doxygen
  12222. comments.
  12223. * bridges/bridge_softmix.c: The bridge uniqueid is available for
  12224. softmix destructor.
  12225. * bridges/bridge_softmix.c: Add some bridge identifiers to some
  12226. softmix messages.
  12227. 2013-06-07 20:51 +0000 [r390920] Jonathan Rose <jrose@digium.com>
  12228. * res/parking/parking_devicestate.c (added): res_parking: Add
  12229. parking_devicestate.c left out from previous commit (issue
  12230. ASTERISK-21645) Reported by: Matt Jordan Review:
  12231. https://reviewboard.asterisk.org/r/2545/
  12232. 2013-06-07 19:51 +0000 [r390885-390901] Jason Parker <jparker@digium.com>
  12233. * configs/queues.conf.sample, CHANGES, apps/app_queue.c,
  12234. main/manager.c: Make app_queue AMI events more consistent. Give
  12235. Join/Leave more useful names. This also removes the
  12236. eventwhencalled and eventmemberstatus configuration options.
  12237. These events can just be filtered via manager.conf blacklists.
  12238. (closes issue ASTERISK-21469) Review:
  12239. https://reviewboard.asterisk.org/r/2586/
  12240. * res/res_stasis_http_channels.c,
  12241. res/stasis_http/resource_channels.h,
  12242. rest-api/api-docs/channels.json,
  12243. res/stasis_json/resource_channels.h,
  12244. res/stasis_http/resource_channels.c: Implement ARI POST to
  12245. /channels, to originate a call. (closes issue ASTERISK-21617)
  12246. Review: https://reviewboard.asterisk.org/r/2597/
  12247. 2013-06-07 16:22 +0000 [r390864] Kinsey Moore <kmoore@digium.com>
  12248. * tests/test_devicestate.c: Ensure that all unit tests compile with
  12249. the cache clear rework in place
  12250. 2013-06-07 16:07 +0000 [r390848-390849] Jonathan Rose <jrose@digium.com>
  12251. * include/asterisk/pbx.h, CHANGES,
  12252. res/parking/parking_bridge_features.c,
  12253. res/parking/parking_bridge.c, main/pbx.c,
  12254. res/parking/res_parking.h, res/res_parking.c, main/features.c,
  12255. res/parking/parking_controller.c: res_parking: Automatically
  12256. generate extensions, hints, etc. (closes issue ASTERISK-21645)
  12257. Reported by: Matt Jordan Review:
  12258. https://reviewboard.asterisk.org/r/2545/
  12259. * main/manager.c, apps/app_meetme.c,
  12260. apps/confbridge/confbridge_manager.c, include/asterisk/manager.h:
  12261. app_meetme: Refactor manager events to use stasis (closes issue
  12262. ASTERISK-21467) Reported by: Matt Jordan Review:
  12263. https://reviewboard.asterisk.org/r/2564/
  12264. 2013-06-07 12:56 +0000 [r390830] Kinsey Moore <kmoore@digium.com>
  12265. * main/channel.c, main/stasis_cache.c, include/asterisk/stasis.h,
  12266. main/stasis_channels.c, main/endpoints.c, tests/test_stasis.c,
  12267. main/bridging.c: Rework stasis cache clear events Stasis cache
  12268. clear message payloads now consist of a stasis_message
  12269. representative of the message to be cleared from the cache. This
  12270. allows multiple parallel caches to coexist and be cleared
  12271. properly by the same cache clear message even when keyed on
  12272. different fields. This change fixes a bug where multiple cache
  12273. clears could be posted for channels. The cache clear is now
  12274. produced in the destructor instead of ast_hangup. Additionally,
  12275. dummy channels are no longer capable of producing channel
  12276. snapshots. Review: https://reviewboard.asterisk.org/r/2596
  12277. 2013-06-07 01:06 +0000 [r390803-390804] Richard Mudgett <rmudgett@digium.com>
  12278. * channels/sig_pri.c, channels/sig_pri.h, main/channel.c,
  12279. channels/chan_dahdi.c, channels/chan_misdn.c,
  12280. channels/sig_analog.c: Refactor chan_dahdi/sig_analog/sig_pri and
  12281. chan_misdn to use the common transfer functions. (closes issue
  12282. ASTERISK-21523) Reported by: Matt Jordan (closes issue
  12283. ASTERISK-21524) Reported by: Matt Jordan Review:
  12284. https://reviewboard.asterisk.org/r/2600/
  12285. * main/features_config.c: Tweak applicationmap and featuregroup
  12286. config containers. * Change applicationmap and featuregroup to
  12287. replace duplicate config items rather than reject them. * Remove
  12288. some unneeded warning messages when getting the applicationmap
  12289. allows duplicates from DYNAMIC_FEATURES.
  12290. 2013-06-06 23:32 +0000 [r390787] Mark Michelson <mmichelson@digium.com>
  12291. * main/features_config.c: Conditionally reject duplicate entries in
  12292. applicationmap containers. When reading from a config file, it's
  12293. important to reject duplicates. Otherwise, featuregroups will
  12294. have ambiguity when pointing to applicationmap items. However,
  12295. when constructing the channel's current applicationmap, we don't
  12296. care about duplicate names since it's the DTMF that identifies a
  12297. feature, not the name.
  12298. 2013-06-06 22:46 +0000 [r390771] Richard Mudgett <rmudgett@digium.com>
  12299. * configs/iax.conf.sample, configs/chan_dahdi.conf.sample,
  12300. bridges/bridge_builtin_features.c,
  12301. include/asterisk/bridging_features.h,
  12302. include/asterisk/bridging.h, main/features.c, UPGRADE.txt,
  12303. configs/sip.conf.sample, configs/skinny.conf.sample, CHANGES,
  12304. main/bridging.c: Reimplement bridging and DTMF features related
  12305. channel variables in the bridging core. * The channel variable
  12306. ATTENDED_TRANSFER_COMPLETE_SOUND is no longer channel driver
  12307. specific. If the channel variable is set on the transferrer
  12308. channel, the sound will be played to the target of an attended
  12309. transfer. * The channel variable BRIDGEPEER becomes a comma
  12310. separated list of peers in a multi-party bridge. The BRIDGEPEER
  12311. value can have a maximum of 10 peers listed. Any more peers in
  12312. the bridge will not be included in the list. BRIDGEPEER is not
  12313. valid in holding bridges like parking since those channels do not
  12314. talk to each other even though they are in a bridge. * The
  12315. channel variable BRIDGEPVTCALLID is only valid for two party
  12316. bridges and will contain a value if the BRIDGEPEER's channel
  12317. driver supports it. * The channel variable DYNAMIC_PEERNAME is
  12318. redundant with BRIDGEPEER and is removed. The more useful
  12319. DYNAMIC_WHO_ACTIVATED gives the channel name that activated the
  12320. dynamic feature. * The channel variables DYNAMIC_FEATURENAME and
  12321. DYNAMIC_WHO_ACTIVATED are set only on the channel executing the
  12322. dynamic feature. Executing a dynamic feature on the bridge peer
  12323. in a multi-party bridge will execute it on all peers of the
  12324. activating channel. (closes issue ASTERISK-21555) Reported by:
  12325. Matt Jordan Review: https://reviewboard.asterisk.org/r/2582/
  12326. 2013-06-06 21:40 +0000 [r390751] Mark Michelson <mmichelson@digium.com>
  12327. * channels/sip/include/sip.h, main/bridging.c,
  12328. channels/chan_mgcp.c, apps/app_dial.c, channels/chan_unistim.c,
  12329. channels/chan_sip.c, include/asterisk/features_config.h (added),
  12330. include/asterisk/channel.h, main/features_config.c (added),
  12331. include/asterisk/features.h, channels/chan_dahdi.c,
  12332. channels/chan_misdn.c, channels/sig_analog.c, main/manager.c,
  12333. bridges/bridge_builtin_features.c, main/features.c: Refactor the
  12334. features configuration scheme. Features configuration is handled
  12335. in its own API in features_config.h and features_config.c. This
  12336. way, features configuration is accessible to anything that needs
  12337. it. In addition, features configuration has been altered to be
  12338. more channel-oriented. Most callers of features API code will be
  12339. supplying a channel so that the individual channel's settings
  12340. will be acquired rather than the global setting. Missing from
  12341. this commit is XML documentation for the features configuration.
  12342. That will be handled in a separate commit. Review:
  12343. https://reviewboard.asterisk.org/r/2578/ (issue ASTERISK-21542)
  12344. 2013-06-06 20:50 +0000 [r390733-390734] Richard Mudgett <rmudgett@digium.com>
  12345. * main/stasis_message_router.c: Fix compiler warning.
  12346. * main/bridging.c, main/features.c, apps/app_bridgewait.c: * Fix a
  12347. couple missed hook installs that need
  12348. AST_BRIDGE_HOOK_REMOVE_ON_PULL. * Rename some hook flag
  12349. parameters to remove_flags.
  12350. 2013-06-06 20:37 +0000 [r390730] Kinsey Moore <kmoore@digium.com>
  12351. * res/res_agi.c: Fix documentation generation Regression from
  12352. r390701
  12353. 2013-06-06 20:32 +0000 [r390729] Jason Parker <jparker@digium.com>
  12354. * /: Remove props that people will yell at me for. I'm sorry I
  12355. broke automerge. :(
  12356. 2013-06-06 20:30 +0000 [r390728] Kinsey Moore <kmoore@digium.com>
  12357. * res/parking/parking_manager.c: Fix documentation that was in
  12358. review during the great suffix/prefix swap
  12359. 2013-06-06 19:51 +0000 [r390698-390701] Jason Parker <jparker@digium.com>
  12360. * CHANGES, /, res/res_agi.c: Split AGI manager events, to remove
  12361. SubEvent field. This moves them to stasis, in the process.
  12362. (closes issue ASTERISK-21470) Review:
  12363. https://reviewboard.asterisk.org/r/2587/
  12364. * main/stasis_message_router.c,
  12365. include/asterisk/stasis_message_router.h: Convert message_router
  12366. routes to ao2. Add support for removal. Review:
  12367. https://reviewboard.asterisk.org/r/2591/
  12368. 2013-06-06 18:21 +0000 [r390669] Jonathan Rose <jrose@digium.com>
  12369. * main/bridging.c: Parking: Enable code responsible for
  12370. intercepting park exten transfers
  12371. 2013-06-06 01:52 +0000 [r390612-390639] Richard Mudgett <rmudgett@digium.com>
  12372. * channels/chan_dahdi.c: Add a BUGBUG note.
  12373. * main/bridging.c: Misc core external attended transfer fixes. *
  12374. Fix external attended transfer bridge move/swap method. One of
  12375. the transferrer channels was not kicked out of the bridge. * Fix
  12376. several off-nominal extended attended transfer paths. Mainly the
  12377. channels involved needed to be hung up or kicked out of the
  12378. bridge.
  12379. * main/core_local.c: Make local channels use ast_channel_move()
  12380. instead of the inlined version.
  12381. 2013-06-05 21:14 +0000 [r390584-390585] David M. Lee <dlee@digium.com>
  12382. * include/asterisk/stasis.h: Corrected comment on stasis_cache_get
  12383. * main/manager_channels.c: Fixed refcounting problems with chanspy
  12384. AMI support. The ast_multi_channel_blob_get_channel function does
  12385. not bump the refcount on the channel snapshot that it returns.
  12386. This is typical for Stasis message payloads, since being
  12387. immutable means that the object won't get unreffed out from
  12388. underneath you. The manager code for chanspy was unreffing the
  12389. snapshots it got out of the multi-channel blob, which was one
  12390. unref too many.
  12391. 2013-06-05 19:19 +0000 [r390510-390550] Mark Michelson <mmichelson@digium.com>
  12392. * include/asterisk/bridging_features.h, main/features.c,
  12393. bridges/bridge_builtin_interval_features.c, main/bridging.c,
  12394. res/parking/parking_bridge_features.c, main/bridging_basic.c:
  12395. Remove remaining traces of remove_on_pull from hooks and hook
  12396. APIs.
  12397. * include/asterisk/bridging_features.h: Give the
  12398. AST_BRIDGE_HOOK_REMOVE_ON_PULL a legitimate value.
  12399. * include/asterisk/bridging_features.h, main/bridging.c: Change the
  12400. remove_on_pull flag on ast_bridge_hook to be a set of flags. This
  12401. change is used to make bridge hook removal more generic. This
  12402. way, depending on the circumstance, the appropriate bridge hooks
  12403. may be removed.
  12404. 2013-06-05 14:50 +0000 [r390473] Joshua Colp <jcolp@digium.com>
  12405. * main/channel.c: Publish the channel state snapshot *before*
  12406. calling device state so a device state producer can use an up to
  12407. date snapshot.
  12408. 2013-06-05 14:47 +0000 [r390472] David M. Lee <dlee@digium.com>
  12409. * main/channel_internal_api.c: Fixed a consistency problem with
  12410. channel snapshot and endpoint state. When channels are added to
  12411. an endpoint, the code originally posted a channel snapshot to the
  12412. endoint's topic directly. Turns out, this is a bad idea. This
  12413. causes the endpoint to see an inconsistent view of the channel,
  12414. since it will later receive in-flight messages with old channel
  12415. snapshots. This patch instead just publishes channel state
  12416. immediately after setting up the forward to the endpoint's topic.
  12417. This gives the endpoints a consistent view of the channel's
  12418. state.
  12419. 2013-06-04 22:55 +0000 [r390439-390440] Richard Mudgett <rmudgett@digium.com>
  12420. * bridges/bridge_native_rtp.c: Add BUGBUG comment.
  12421. * bridges/bridge_native_rtp.c: Simple lock, assignment, unlock
  12422. sandwich optimization.
  12423. 2013-06-04 15:55 +0000 [r390352-390398] David M. Lee <dlee@digium.com>
  12424. * include/asterisk/manager.h: Corrected the docs on
  12425. ast_manager_event_blob_create
  12426. * configure.ac, makeopts.in, configure,
  12427. include/asterisk/autoconfig.h.in, main/Makefile: Correct autoconf
  12428. script for finding UUID support. The library that provides UUID
  12429. support varies greatly from system to system. On most Linux
  12430. distros, it's in libuuid. On OpenBSD, it's in libe2fs-uuid. On OS
  12431. X, it is in libsystem. This patch plays hide-and-seek with UUID
  12432. support, looking for it in the three places we know about. It
  12433. also corrects the Makefile so that it uses the configured library
  12434. name and include path. (closes issue ASTERISK-21816) Reported by:
  12435. Brad Latus (snuffy) Tested by: Brad Latus (snuffy)
  12436. 2013-05-31 19:00 +0000 [r390317] Kinsey Moore <kmoore@digium.com>
  12437. * main/pbx.c, apps/app_userevent.c, main/stasis_channels.c:
  12438. Refactor code and fix a reference leak Refactor some channel blob
  12439. publishing code to use ast_channel_publish_blob now that it is
  12440. available and fix a JSON reference leak that was occurring during
  12441. varset publishing.
  12442. 2013-05-31 16:15 +0000 [r390289-390291] Richard Mudgett <rmudgett@digium.com>
  12443. * main/channel.c, main/manager.c, main/channel_internal_api.c,
  12444. include/asterisk/channel.h: Remove ast_channel_bridge() and
  12445. associated code called only by it. * Added some more BUGBUG
  12446. notes.
  12447. * include/asterisk/stasis_channels.h,
  12448. bridges/bridge_builtin_features.c, include/asterisk/bridging.h,
  12449. main/stasis_channels.c, main/bridging.c, main/channel.c: Fixup
  12450. hold/unhold with attended and blind transfers. * DTMF attended
  12451. and blind transfers have hold/unhold behavior restored. *
  12452. External attended and blind transfers unhold the transfered party
  12453. when the transfer is initiated. * Made prohibit blind
  12454. transferring a bridge marked as masquerade only. (ConfBridge
  12455. bridges) * Made running an application or playing a file inside a
  12456. bridge post the hold/unhold messages if MOH is requested. Review:
  12457. https://reviewboard.asterisk.org/r/2574/
  12458. 2013-05-31 14:36 +0000 [r390268] Jason Parker <jparker@digium.com>
  12459. * main/manager.c, include/asterisk/manager.h, main/asterisk.c:
  12460. Replace ast_manager_publish_message() with a more useful version.
  12461. It's much easier to just create a blob of the message. Convert
  12462. some AMI events to use it. Review:
  12463. https://reviewboard.asterisk.org/r/2577/
  12464. 2013-05-31 12:41 +0000 [r390249-390250] Kinsey Moore <kmoore@digium.com>
  12465. * apps/confbridge/include/confbridge.h, main/stasis_bridging.c,
  12466. apps/confbridge/confbridge_manager.c, apps/app_confbridge.c,
  12467. include/asterisk/stasis_bridging.h: Remove remnant of snapshot
  12468. blob JSON types Remove usage of the once-mandatory snapshot blob
  12469. type field, refactor confbridge stasis messages accordingly, and
  12470. remove ast_bridge_blob_json_type(). Review:
  12471. https://reviewboard.asterisk.org/r/2575/
  12472. * main/stasis_channels.c, include/asterisk/stasis_channels.h: Add
  12473. snapshot cache that indexes by channel name This adds a new
  12474. channel snapshot cache in parallel to the existing cache; the
  12475. difference being that it indexes the channel snapshots by channel
  12476. name instead of channel uniqueid. Review:
  12477. https://reviewboard.asterisk.org/r/2576
  12478. 2013-05-31 10:42 +0000 [r390230] Alexandr Anikin <may@telecom-service.ru>
  12479. * addons/chan_ooh323.c, /: Multiple revisions 390228-390229
  12480. ........ r390228 | may | 2013-05-31 14:19:52 +0400 (Fri, 31 May
  12481. 2013) | 14 lines reject call attempts when gatekeeper is
  12482. configured but not registered (closes issue ASTERISK-21800)
  12483. Reported by: Dmitry Melekhov Patches: ASTERISK-21800-1.patch
  12484. Tested by: Dmitry Melekhov ........ Merged revisions 390181 from
  12485. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12486. revisions 390223 from
  12487. http://svn.asterisk.org/svn/asterisk/branches/10 ........ r390229
  12488. | may | 2013-05-31 14:34:20 +0400 (Fri, 31 May 2013) | 4 lines
  12489. remove unnecessary declarations (issue ASTERISK-21800) ........
  12490. Merged revisions 390228-390229 from
  12491. http://svn.asterisk.org/svn/asterisk/branches/11
  12492. 2013-05-31 07:57 +0000 [r390180] Walter Doekes <walter+asterisk@wjd.nu>
  12493. * Makefile: Let find do its own globbing. Previously a stray .c
  12494. file would cause xmldocs to not get built.
  12495. 2013-05-30 19:23 +0000 [r390122-390154] David M. Lee <dlee@digium.com>
  12496. * main/app.c: Missed a line from a bad merge in r390122
  12497. * main/stasis_cache.c, include/asterisk.h, main/security_events.c,
  12498. include/asterisk/stasis.h, main/devicestate.c, main/named_acl.c,
  12499. include/asterisk/stasis_bridging.h, main/presencestate.c,
  12500. main/stasis.c, main/channel.c,
  12501. include/asterisk/stasis_channels.h, main/stasis_bridging.c,
  12502. main/test.c, main/app.c, main/stasis_channels.c,
  12503. include/asterisk/security_events.h, main/asterisk.c,
  12504. main/bridging.c: Avoid unnecessary cleanups during immediate
  12505. shutdown This patch addresses issues during immediate shutdowns,
  12506. where modules are not unloaded, but Asterisk atexit handlers are
  12507. run. In the typical case, this usually isn't a big deal. But the
  12508. introduction of the Stasis message bus makes it much more likely
  12509. for asynchronous activity to be happening off in some thread
  12510. during shutdown. During an immediate shutdown, Asterisk skips
  12511. unloading modules. But while it is processing the atexit
  12512. handlers, there is a window of time where some of the core
  12513. message types have been cleaned up, but the message bus is still
  12514. running. Specifically, it's still running module subscriptions
  12515. that might be using the core message types. If a message is
  12516. received by that subscription in that window, it will attempt to
  12517. use a message type that has been cleaned up. To solve this
  12518. problem, this patch introduces ast_register_cleanup(). This
  12519. function operates identically to ast_register_atexit(), except
  12520. that cleanup calls are not invoked on an immediate shutdown. All
  12521. of the core message type and topic cleanup was moved from atexit
  12522. handlers to cleanup handlers. This ensures that core type and
  12523. topic cleanup only happens if the modules that used them are
  12524. first unloaded. This patch also changes the ast_assert() when
  12525. accessing a cleaned up or uninitialized message type to an error
  12526. log message. Message type functions are actually NULL safe across
  12527. the board, so the assert was a bit heavy handed. Especially for
  12528. anyone with DO_CRASH enabled. Review:
  12529. https://reviewboard.asterisk.org/r/2562/
  12530. 2013-05-29 20:24 +0000 [r390068] Richard Mudgett <rmudgett@digium.com>
  12531. * main/channel.c, /: Fix segfault when dealing with chan_agent
  12532. channels. Check the returned bridged pointer for NULL to avoid a
  12533. crash. It looks like chan_agent is returning a NULL pointer when
  12534. it probably should be returning a pointer to the channel the
  12535. Agent channel is pretending to be. (closes issue ASTERISK-21793)
  12536. Reported by: Rodrigo P. Telles Patches:
  12537. jira_asterisk_21793_v1.8.patch (license #5621) patch uploaded by
  12538. rmudgett Tested by: Rodrigo P. Telles ........ Merged revisions
  12539. 390044 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  12540. ........ Merged revisions 390047 from
  12541. http://svn.asterisk.org/svn/asterisk/branches/11
  12542. 2013-05-29 19:54 +0000 [r390042] Jason Parker <jparker@digium.com>
  12543. * main/channel.c: Remove unused RAII vars.
  12544. 2013-05-29 03:22 +0000 [r389990] Matthew Jordan <mjordan@digium.com>
  12545. * res/res_fax.c: Pack the right number of items into the status and
  12546. receive fax blobs The code was still attempting to pack an
  12547. additional item into the blobs that didn't exist. Crashes ensued.
  12548. This patch modifies the publishing of these messages so that the
  12549. correct number of items are packed in the JSON.
  12550. 2013-05-29 02:26 +0000 [r389974] Kinsey Moore <kmoore@digium.com>
  12551. * res/res_musiconhold.c, res/res_monitor.c,
  12552. include/asterisk/stasis_channels.h, res/res_fax.c,
  12553. apps/app_fax.c, main/stasis_channels.c: Resolve a merge conflict
  12554. When ast_channel_cached_blob_create was merged,
  12555. ast_channel_blob_create_from_cache was partially removed in an
  12556. unresolved merge conflict. This restores
  12557. ast_channel_blob_create_from_cache and refactors usage of
  12558. ast_channel_cached_blob_create (requires an ast_channel) to use
  12559. ast_channel_blob_create_from_cache (requires a channel uniqueid)
  12560. instead.
  12561. 2013-05-28 17:47 +0000 [r389897] Jonathan Rose <jrose@digium.com>
  12562. * /, main/slinfactory.c: Fix a memory copying bug in slinfactory
  12563. which was causing mixmonitor issues. Reported by: Michael Walton
  12564. Tested by: Jonathan Rose Patches:
  12565. slinfactory.c.ASTERISK-21799.patch uploaded by Michael Walton
  12566. (license 6502) (closes issue ASTERISK-21799) ........ Merged
  12567. revisions 389895 from
  12568. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12569. revisions 389896 from
  12570. http://svn.asterisk.org/svn/asterisk/branches/11
  12571. 2013-05-28 15:54 +0000 [r389848-389870] Mark Michelson <mmichelson@digium.com>
  12572. * main/bridging.c: Add missing NULL check to acquire_bridge()
  12573. function.
  12574. * channels/chan_sip.c, channels/sip/include/sip.h: Add attended
  12575. transfer support for chan_sip.c This now uses the core API for
  12576. performing attended transfers. Review
  12577. https://reviewboard.asterisk.org/r/2513 (Closes issue
  12578. ASTERISK-21520) reported by Matt Jordan
  12579. * main/channel.c, main/pbx.c, bridges/bridge_builtin_features.c,
  12580. channels/chan_sip.c, apps/confbridge/confbridge_manager.c,
  12581. include/asterisk/bridging.h, main/features.c,
  12582. include/asterisk/channel.h, CHANGES, main/bridging.c,
  12583. channels/chan_mgcp.c: Adds support for a core attended transfer
  12584. function plus adds some hiding of masquerades. The attended
  12585. transfer API call can complete the attended transfer in a number
  12586. of ways depending on the current bridged states of the channels
  12587. involved. The hiding of masquerades is done in some
  12588. bridging-related functions, such as the manager Bridge action and
  12589. the Bridge dialplan application. In addition, call pickup was
  12590. edited to "move" a channel rather than masquerade it. Review:
  12591. https://reviewboard.asterisk.org/r/2511 (closes issue
  12592. ASTERISK-21334) Reported by Matt Jordan (closes issue
  12593. Asterisk-21336) Reported by Matt Jordan
  12594. 2013-05-27 01:33 +0000 [r389770-389827] Matthew Jordan <mjordan@digium.com>
  12595. * res/res_fax.c, res/res_fax_spandsp.c: Fix some more fax test
  12596. errors due to needing the peer in a bridge In r389799, a number
  12597. of fax errors in gateway mode were fixed by using the appropriate
  12598. function to get a channel's peer while in a bridge. This patch
  12599. does two things: (1) It uses the same function in res_fax_spandsp
  12600. while starting the fax gateway. Without this, the fax gateway
  12601. will not actually start up, as res_fax_spandsp also must inspect
  12602. the channel's peer in a two-party bridge (2) It refactors some
  12603. ao2 objects in sendfax_exec to use RAII_VAR. This was reverted in
  12604. r389799 as some off nominal paths were getting hit without the
  12605. fix in (1) that indicated an ao2 object issue; this turned out to
  12606. be a red herring (which is an odd phrase)
  12607. * main/stasis_endpoints.c: Initialize the message type before the
  12608. topic Caching topics will during initialization attempt to
  12609. reference their message type. The message type therefore has to
  12610. be initialized prior to the topic to prevent the dreaded
  12611. assertion.
  12612. * res/res_fax.c: Fix a few fax gateway failures Fax gateway
  12613. requires knowledge of a channel's peer in a bridge. This patch
  12614. now uses the supported mechanisms to get this information. This
  12615. is acceptable for a few reasons: * Fax gateway can only ever work
  12616. in a 2-party bridge * Fax gateway cannot work when not in a
  12617. bridge * Fax gateway cannot work without knowledge of the
  12618. capabilities of both channels in the fax operation (it is, after
  12619. all, a gateway)
  12620. * main/asterisk.c, res/res_fax.c, main/devicestate.c: Fix a variety
  12621. of memory corruption/assertion errors * Initialize a Stasis-Core
  12622. message type prior to initializing a caching topic. The caching
  12623. topic will attempt to use the message type. * Don't attempt to
  12624. publish Stasis-Core messages from remote console connections.
  12625. They aren't the main process; they shouldn't attempt to behave as
  12626. it (they also don't have the infrastructure to do so) * Don't
  12627. treat a JSON object as an ao2 object (whoops) * In asterisk.c,
  12628. ref bump the JSON even package that is distributed with the event
  12629. meta data. The callers assume that they own the reference, and
  12630. the packing routine steals references.
  12631. * main/asterisk.c: Restore initialization of security topics During
  12632. a merge the security topic initialization got blown away. This
  12633. patch restores it.
  12634. 2013-05-24 21:23 +0000 [r389746-389748] Jason Parker <jparker@digium.com>
  12635. * /: grr, props.
  12636. * channels/chan_h323.c, main/stasis_channels.c,
  12637. main/manager_channels.c, channels/chan_mgcp.c,
  12638. channels/chan_unistim.c, /, channels/chan_sip.c,
  12639. include/asterisk/channel.h, channels/sig_pri.c,
  12640. channels/chan_iax2.c, CHANGES, res/res_sip_sdp_rtp.c,
  12641. main/channel.c, channels/chan_dahdi.c,
  12642. include/asterisk/stasis_channels.h, channels/sig_analog.c,
  12643. channels/chan_misdn.c, channels/chan_skinny.c,
  12644. channels/chan_motif.c: Split Hold event into Hold/Unhold, and
  12645. move it into core. (closes issue ASTERISK-21487) Review:
  12646. https://reviewboard.asterisk.org/r/2565/
  12647. 2013-05-24 21:01 +0000 [r389738] Kinsey Moore <kmoore@digium.com>
  12648. * res/res_stasis.c: Remove a junk define BLOB_HANDLER_BUCKETS is a
  12649. remnant of using "type" fields in JSON/snapshot blobs and is no
  12650. longer used.
  12651. 2013-05-24 20:44 +0000 [r389680-389733] Matthew Jordan <mjordan@digium.com>
  12652. * include/asterisk/_private.h, include/asterisk/manager.h,
  12653. channels/sig_pri.c, CHANGES, res/res_monitor.c,
  12654. include/asterisk/app.h, main/json.c,
  12655. include/asterisk/stasis_channels.h, apps/app_chanspy.c,
  12656. res/parking/parking_manager.c, main/asterisk.c,
  12657. main/manager_mwi.c (added), apps/app_voicemail.c,
  12658. channels/chan_unistim.c, include/asterisk/json.h,
  12659. res/res_musiconhold.c, res/res_xmpp.c, channels/chan_iax2.c,
  12660. res/res_jabber.c, main/enum.c, main/loader.c, main/cli.c,
  12661. main/cdr.c, channels/chan_dahdi.c, main/manager.c,
  12662. channels/chan_skinny.c, apps/app_minivm.c, main/app.c,
  12663. main/stasis_channels.c, main/manager_channels.c,
  12664. res/res_sip_mwi.c, channels/chan_mgcp.c, main/pbx.c,
  12665. main/dnsmgr.c, channels/chan_sip.c, res/res_fax.c,
  12666. apps/app_fax.c: Migrate a large number of AMI events over to
  12667. Stasis-Core This patch moves a number of AMI events over to the
  12668. Stasis-Core message bus. This includes: * ChanSpyStart/Stop *
  12669. MonitorStart/Stop * MusicOnHoldStart/Stop * FullyBooted/Reload *
  12670. All Voicemail/MWI related events In addition, it adds some
  12671. Stasis-Core and AMI support for generic AMI messages, refactors
  12672. the message router in AMI to use a single router with topic
  12673. forwarding for the topics that AMI cares about, and refactors MWI
  12674. message types and topics to be more name compliant. Review:
  12675. https://reviewboard.asterisk.org/r/2532 (closes issue
  12676. ASTERISK-21462)
  12677. * /, main/logger.c: Print all logger messages on shutdown When
  12678. Asterisk shuts down and shuts down the loggin gsubsystem, any
  12679. messages currently in flight will not get logged. This patch
  12680. prevents the loop writing messages from breaking out prematurely,
  12681. such that all of the messages are logged. (closes issue
  12682. ASTERISK-21716) Reported by: Corey Farrell patches:
  12683. logger-process-all-messages.patch uploaded by Corey Farrell
  12684. (license 5909) ........ Merged revisions 389676 from
  12685. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12686. revisions 389677 from
  12687. http://svn.asterisk.org/svn/asterisk/branches/11
  12688. 2013-05-24 10:23 +0000 [r389663] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  12689. * channels/chan_unistim.c, /: Fix several problems caused by
  12690. multiple line usage with i2004 phones. Reported by: Daniel
  12691. Bohling, MihaiMircea (closes issue ASTERISK-21061) (closes issue
  12692. ASTERISK-21120) ........ Merged revisions 389661 from
  12693. http://svn.asterisk.org/svn/asterisk/branches/11
  12694. 2013-05-23 21:46 +0000 [r389639] David M. Lee <dlee@digium.com>
  12695. * res/res_stasis_playback.c, res/stasis_http/resource_channels.c,
  12696. include/asterisk/stasis_http.h, res/res_stasis_http.c:
  12697. stasis-http: Provide a response body for 201 created responses
  12698. 2013-05-23 21:11 +0000 [r389618-389623] Jonathan Rose <jrose@digium.com>
  12699. * res/parking/parking_bridge.c: res_parking: Add a verbose message
  12700. when a channel is parked
  12701. * res/parking/parking_bridge.c: res_parking: Fix some simple bugs
  12702. Both of them are covered in the dynamic parking review on
  12703. https://reviewboard.asterisk.org/r/2550 - Remove unref against
  12704. parking lot that the bridge did on dissolve since the reference
  12705. wasn't taken in the first place. On a swap, reapply bridge roles
  12706. in order to get music on hold and such playing on the channel
  12707. that swaps into the bridge.
  12708. 2013-05-23 20:25 +0000 [r389609] Joshua Colp <jcolp@digium.com>
  12709. * res/res_sip_session.c: Fix a crash due to the INVITE session
  12710. being destroyed before the session. This change ensures that the
  12711. INVITE session remains valid for the lifetime of the session
  12712. object itself by increasing the session count on the dialog that
  12713. the INVITE session is allocated from. Once this reaches zero
  12714. (normally as a result of decrementing it within the session
  12715. destructor) the dialog, and INVITE session, are destroyed.
  12716. 2013-05-23 20:21 +0000 [r389587-389603] David M. Lee <dlee@digium.com>
  12717. * include/asterisk/stasis_app_playback.h,
  12718. res/stasis_http/resource_playback.c, include/asterisk/app.h,
  12719. res/res_stasis_playback.c, res/stasis/control.c,
  12720. res/stasis_http/resource_channels.c,
  12721. rest-api/api-docs/playback.json, res/res_stasis_http_channels.c,
  12722. include/asterisk/stasis_app.h, main/app.c,
  12723. include/asterisk/channel.h, res/stasis_http/resource_channels.h,
  12724. rest-api/api-docs/channels.json: This patch adds support for
  12725. controlling a playback operation from the Asterisk REST
  12726. interface. This adds the /playback/{playbackId}/control resource,
  12727. which may be POSTed to to pause, unpause, reverse, forward or
  12728. restart the media playback. Attempts to control a playback that
  12729. is not currently playing will either return a 404 Not Found
  12730. (because the playback object no longer exists) or a 409 Conflict
  12731. (because the playback object is still in the queue to be played).
  12732. This patch also adds skipms and offsetms parameters to the
  12733. /channels/{channelId}/play resource. (closes issue
  12734. ASTERISK-21587) Review: https://reviewboard.asterisk.org/r/2559
  12735. * res/res_stasis_json_events.exports.in, res/res_stasis_playback.c
  12736. (added), rest-api/api-docs/events.json, res/stasis/control.c,
  12737. main/channel_internal_api.c, include/asterisk/stasis_http.h,
  12738. res/res_stasis_http_channels.c, res/res_stasis_json_events.c,
  12739. include/asterisk/stasis_app_playback.h (added),
  12740. res/stasis_http/resource_playback.c, include/asterisk/app.h,
  12741. include/asterisk/stasis_channels.h,
  12742. res/stasis_json/resource_channels.h,
  12743. res/stasis_http/resource_channels.c,
  12744. res/stasis_http/resource_channels.h, main/stasis_channels.c,
  12745. rest-api/api-docs/channels.json,
  12746. res/res_stasis_playback.exports.in (added),
  12747. res/res_stasis_http.c, res/stasis_json/resource_events.h: This
  12748. patch implements the REST API's for POST
  12749. /channels/{channelId}/play and GET /playback/{playbackId}. This
  12750. allows an external application to initiate playback of a sound on
  12751. a channel while the channel is in the Stasis application. /play
  12752. commands are issued asynchronously, and return immediately with
  12753. the URL of the associated /playback resource. Playback commands
  12754. queue up, playing in succession. The /playback resource shows the
  12755. state of a playback operation as enqueued, playing or complete.
  12756. (Although the operation will only be in the 'complete' state for
  12757. a very short time, since it is almost immediately freed up).
  12758. (closes issue ASTERISK-21283) (closes issue ASTERISK-21586)
  12759. Review: https://reviewboard.asterisk.org/r/2531/
  12760. 2013-05-23 18:40 +0000 [r389569] Richard Mudgett <rmudgett@digium.com>
  12761. * main/features.c: Fix inverted test preventing DTMF disconnect
  12762. from working.
  12763. 2013-05-23 18:39 +0000 [r389551-389568] Joshua Colp <jcolp@digium.com>
  12764. * res/res_sip_sdp_rtp.c: Fix a bug where the DTMF mode was not set
  12765. on newly created RTP instances in the res_sip_sdp_rtp module.
  12766. * res/res_sip_sdp_rtp.c: Fix a bug with applying the end result of
  12767. the codec negotiation to the Asterisk channel.
  12768. * res/res_sip_session.c: Fix a bug where the codec order as
  12769. configured was not being obeyed.
  12770. 2013-05-22 19:15 +0000 [r389519] David M. Lee <dlee@digium.com>
  12771. * main/app.c: Fixed startup race condition which caused occasional
  12772. stasis_mwi_state_type assertions. The caching topic (which refers
  12773. to the message type) was created before the message type. If the
  12774. initial subscription message gets processed before the type can
  12775. be initialized, the assertion about using an uninitialized type
  12776. fires.
  12777. 2013-05-22 18:20 +0000 [r389492-389505] Jason Parker <jparker@digium.com>
  12778. * /: Remove bad props, before anybody notices.
  12779. * /, include/asterisk/dial.h, apps/app_followme.c,
  12780. apps/app_queue.c, apps/app_dial.c, main/dial.c: Add dial events
  12781. to app_queue and app_followme. Also fixes an issue in app_dial,
  12782. where the channels were swapped on dial events. (closes issue
  12783. ASTERISK-21551) (closes issue ASTERISK-21550) Review:
  12784. https://reviewboard.asterisk.org/r/2549/
  12785. 2013-05-21 22:49 +0000 [r389454] David M. Lee <dlee@digium.com>
  12786. * main/stasis_bridging.c: Fix destruction order assert for
  12787. stasis_bridging
  12788. 2013-05-21 21:08 +0000 [r389426] Richard Mudgett <rmudgett@digium.com>
  12789. * apps/app_queue.c: Conditional out more app_queue logging that
  12790. needs to be reworked. Fixes crash because app_queue was
  12791. unconditionally freeing a datastore that was still on a channel.
  12792. 2013-05-21 18:45 +0000 [r389402] Matthew Jordan <mjordan@digium.com>
  12793. * apps/app_confbridge.c, apps/confbridge/confbridge_manager.c:
  12794. Raise the ConfBridgeMute/Unmute events when a CLI or AMI action
  12795. triggers the change New in 12 are the ConfBridgeMute/Unmute
  12796. events, which are triggered when a user changes their mute/unmute
  12797. state. This was typically triggered when a user hit a DTMF key
  12798. that triggered the mute/unmute menu handler. Forgotten in this is
  12799. when an AMI action or CLI command triggers the mute/unmute. This
  12800. patch now raises the events in those situations as well. (closes
  12801. issue ASTERISK-21802) Reported by: Birger "WIMPy" Harzenetter
  12802. 2013-05-21 18:00 +0000 [r389378] Richard Mudgett <rmudgett@digium.com>
  12803. * rest-api-templates/res_stasis_json_resource.c.mustache,
  12804. include/asterisk/frame.h, apps/app_mixmonitor.c,
  12805. include/asterisk/parking.h (added), channels/chan_mgcp.c,
  12806. main/bridging_roles.c (added), main/pbx.c, main/strings.c,
  12807. rest-api/api-docs/events.json, include/asterisk/core_local.h
  12808. (added), configs/res_parking.conf.sample (added),
  12809. channels/chan_bridge.c (removed),
  12810. res/parking/parking_controller.c,
  12811. res/parking/parking_applications.c, include/asterisk/channel.h,
  12812. include/asterisk/manager.h, apps/app_queue.c,
  12813. include/asterisk/stasis_bridging.h (added),
  12814. include/asterisk/framehook.h, include/asterisk/config_options.h,
  12815. bridges/bridge_builtin_features.c,
  12816. apps/confbridge/confbridge_manager.c (added), main/features.c,
  12817. apps/app_dumpchan.c, channels/chan_motif.c, channels/chan_h323.c,
  12818. apps/app_confbridge.c, include/asterisk/rtp_engine.h,
  12819. apps/app_chanspy.c, include/asterisk/ccss.h,
  12820. main/manager_channels.c, main/bridging.c,
  12821. apps/confbridge/conf_chan_announce.c (added),
  12822. main/bridging_basic.c (added), include/asterisk/core_unreal.h
  12823. (added), apps/app_dial.c, res/res_stasis_json_events.exports.in,
  12824. addons/chan_ooh323.c, main/frame.c, main/parking.c (added),
  12825. bridges/bridge_holding.c (added), bridges/bridge_simple.c,
  12826. bridges/bridge_softmix.c, funcs/func_jitterbuffer.c,
  12827. res/Makefile, res/res_stasis_json_events.c, main/core_local.c
  12828. (added), CHANGES, channels/chan_iax2.c,
  12829. bridges/bridge_multiplexed.c (removed),
  12830. res/parking/parking_bridge_features.c,
  12831. include/asterisk/abstract_jb.h, channels/chan_gulp.c,
  12832. apps/confbridge/conf_config_parser.c, main/channel.c,
  12833. res/res_parking.c (added), main/manager.c, main/stasis_bridging.c
  12834. (added), res/parking (added),
  12835. bridges/bridge_builtin_interval_features.c (added),
  12836. rest-api-templates/stasis_json_resource.h.mustache,
  12837. main/config_options.c, res/stasis_json/resource_events.h,
  12838. main/asterisk.c, res/parking/parking_manager.c,
  12839. apps/app_parkandannounce.c (removed), channels/chan_unistim.c,
  12840. res/parking/parking_ui.c, channels/chan_local.c (removed),
  12841. main/rtp_engine.c, apps/confbridge/conf_chan_record.c (added),
  12842. main/core_unreal.c (added), apps/app_bridgewait.c (added),
  12843. apps/app_followme.c, configs/features.conf.sample,
  12844. channels/chan_jingle.c, channels/chan_dahdi.c,
  12845. apps/app_channelredirect.c, funcs/func_channel.c,
  12846. main/abstract_jb.c, main/manager_bridging.c (added),
  12847. include/asterisk/bridging_roles.h (added), channels/chan_vpb.cc,
  12848. channels/chan_sip.c, main/channel_internal_api.c,
  12849. channels/chan_agent.c, UPGRADE.txt, include/asterisk/_private.h,
  12850. res/parking/parking_bridge.c, main/cli.c,
  12851. res/parking/res_parking.h,
  12852. include/asterisk/bridging_technology.h, channels/chan_misdn.c,
  12853. apps/confbridge/include/confbridge.h, channels/chan_skinny.c,
  12854. include/asterisk/bridging_features.h, funcs/func_frame_trace.c,
  12855. include/asterisk/bridging.h, include/asterisk/bridging_basic.h
  12856. (added), bridges/bridge_native_rtp.c (added): Merge in the
  12857. bridge_construction branch to make the system use the Bridging
  12858. API. Breaks many things until they can be reworked. A partial
  12859. list: chan_agent chan_dahdi, chan_misdn, chan_iax2 native
  12860. bridging app_queue COLP updates DTMF attended transfers Protocol
  12861. attended transfers
  12862. 2013-05-21 14:17 +0000 [r389343] David M. Lee <dlee@digium.com>
  12863. * apps/app_userevent.c, main/stasis_channels.c: Fixed some extra
  12864. field assertion when the event WebSocket is connected
  12865. 2013-05-20 19:24 +0000 [r389306] Matthew Jordan <mjordan@digium.com>
  12866. * main/pbx.c: Set the AST_CDR_FLAG_ORIGINATED flag on originated
  12867. channel's CDRs This may alleviate some of the CDR woes with
  12868. originated channels, as CDRs do like to know when a channel was
  12869. originated. Eventually this will get converted to be a channel
  12870. flag, so its location is still good to know post the great CDR
  12871. shakeup of 2013.
  12872. 2013-05-20 18:03 +0000 [r389247-389251] Richard Mudgett <rmudgett@digium.com>
  12873. * res/stasis_http/resource_recordings.c, cel/cel_sqlite3_custom.c,
  12874. main/event.c, funcs/func_iconv.c,
  12875. res/stasis_http/resource_recordings.h,
  12876. res/stasis_http/resource_events.c,
  12877. res/res_stasis_http_asterisk.c, main/udptl.c,
  12878. res/res_stasis_websocket.c, res/stasis_http/resource_events.h,
  12879. tests/test_gosub.c, main/threadstorage.c, cel/cel_tds.c,
  12880. tests/test_dlinklists.c, res/res_stasis_http_endpoints.c,
  12881. res/stasis_http/resource_asterisk.c, res/ael/pval.c, main/json.c,
  12882. res/stasis_http/resource_asterisk.h, res/ael/ael_lex.c,
  12883. res/res_stasis_http_bridges.c, tests/test_stasis_http.c,
  12884. tests/test_stasis.c, res/res_clioriginate.c, cel/cel_pgsql.c,
  12885. tests/test_res_stasis.c, res/res_stasis_http_channels.c,
  12886. res/res_srtp.c, main/stasis.c, main/stasis_message.c,
  12887. main/stasis_message_router.c, main/hashtab.c, res/ael/ael.tab.c,
  12888. cel/cel_manager.c, funcs/func_odbc.c,
  12889. res/stasis_http/resource_channels.c, funcs/func_channel.c,
  12890. res/ael/ael.tab.h, res/stasis_http/resource_channels.h,
  12891. utils/ael_main.c, formats/format_h264.c, codecs/codec_dahdi.c,
  12892. contrib/utils/eagi_proxy.c, res/res_stasis.c,
  12893. main/manager_channels.c, tests/test_json.c, cel/cel_radius.c,
  12894. main/stasis_cache.c, tests/test_astobj2_thrash.c,
  12895. funcs/func_dialgroup.c, tests/test_xml_escape.c, pbx/pbx_lua.c,
  12896. res/res_ael_share.c, res/res_pktccops.c, funcs/func_realtime.c,
  12897. cel/cel_odbc.c, res/res_smdi.c, cel/cel_custom.c, res/res_curl.c,
  12898. res/res_stasis_http.c, res/stasis_http/resource_endpoints.c,
  12899. utils/refcounter.c, res/stasis_http/resource_endpoints.h,
  12900. funcs/func_rand.c, funcs/func_version.c, main/sha1.c,
  12901. tests/test_hashtab_thrash.c, res/stasis_http/resource_bridges.c,
  12902. res/res_stasis_http_recordings.c, main/cel.c,
  12903. res/stasis_http/resource_bridges.h, res/res_stasis_http_events.c,
  12904. tests/test_time.c: Fixup svn:keywords in all *.c and *.h files.
  12905. * channels/sip/include/globals.h, apps/app_celgenuserevent.c,
  12906. channels/sip/dialplan_functions.c, include/asterisk/pktccops.h,
  12907. channels/sip/include/sdp_crypto.h,
  12908. include/asterisk/ael_structs.h, include/asterisk/udptl.h,
  12909. channels/sip/include/srtp.h, include/asterisk/frame_defs.h,
  12910. apps/app_stasis.c, include/asterisk/sha1.h,
  12911. include/asterisk/smdi.h, include/asterisk/stringfields.h,
  12912. channels/sip/sdp_crypto.c, channels/sip/include/dialog.h,
  12913. include/asterisk/res_srtp.h, channels/sip/srtp.c,
  12914. include/asterisk/cel.h, include/asterisk/stasis_http.h,
  12915. include/asterisk/stasis_app.h, include/asterisk/stasis.h,
  12916. apps/app_morsecode.c, apps/app_waituntil.c,
  12917. include/asterisk/json.h,
  12918. include/asterisk/stasis_message_router.h,
  12919. include/asterisk/hashtab.h,
  12920. channels/sip/include/dialplan_functions.h,
  12921. include/asterisk/paths.h, include/asterisk/event.h,
  12922. apps/app_setcallerid.c, include/asterisk/event_defs.h: Fixup
  12923. svn:keywords in all *.c and *.h files.
  12924. 2013-05-20 17:44 +0000 [r389246] Jason Parker <jparker@digium.com>
  12925. * /: Add doxygen.log to svn:ignore property. ........ Merged
  12926. revisions 389244 from
  12927. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12928. revisions 389245 from
  12929. http://svn.asterisk.org/svn/asterisk/branches/11
  12930. 2013-05-20 14:21 +0000 [r389217] Kinsey Moore <kmoore@digium.com>
  12931. * res/res_stasis_answer.exports.in (added): Add missing exports
  12932. file This exposes stasis_app_control_answer and allows
  12933. res_stasis_http_channels to load properly.
  12934. 2013-05-20 14:02 +0000 [r389204] Joshua Colp <jcolp@digium.com>
  12935. * main/sorcery.c: In Sorcery pass the name of the object being
  12936. allocated to the allocator.
  12937. 2013-05-20 13:45 +0000 [r389202] Kinsey Moore <kmoore@digium.com>
  12938. * apps/confbridge/conf_config_parser.c: Add documentation for
  12939. record_file_append When this option was added, it was noted in
  12940. CHANGES, but was missing the XML documentation that this patch
  12941. adds. (closes issue ASTERISK-21780) Patch-by: Brad Latus (snuffy)
  12942. 2013-05-19 20:52 +0000 [r389180] Alexandr Anikin <may@telecom-service.ru>
  12943. * addons/chan_ooh323.c, addons/chan_ooh323.h: add
  12944. ast_publish_channel_state according new event framework
  12945. 2013-05-19 19:45 +0000 [r389164] Damien Wedhorn <voip@facts.com.au>
  12946. * channels/chan_skinny.c: Add transfer softkey to ringout state to
  12947. enable blond transfers. (closes issue ASTERISK-21327) Reported
  12948. by: wedhorn Tested by: myself Patches: skinny-blindxfer01.diff
  12949. uploaded by wedhorn (license 5019)
  12950. 2013-05-19 17:45 +0000 [r389148] Kinsey Moore <kmoore@digium.com>
  12951. * res/res_sip_acl.c, res/res_sip.c,
  12952. res/res_sip_outbound_registration.c,
  12953. res/res_sip_endpoint_identifier_ip.c: Add base XML documentation
  12954. for res_sip Thanks to Brad Latus, this patch adds a significant
  12955. amount much-needed documentation to res_sip. It should cover all
  12956. existing configuration options currently in Asterisk trunk.
  12957. Patch-by: Brad Latus (snuffy) Review:
  12958. https://reviewboard.asterisk.org/r/2471/
  12959. 2013-05-19 02:21 +0000 [r389116-389132] Joshua Colp <jcolp@digium.com>
  12960. * main/pbx.c: Don't hold the outgoing lock for a prolonged period
  12961. of time as it may block the originator.
  12962. * main/pbx.c: If the caller of the originate API calls wants the
  12963. channel ensure it has been requested and dialed.
  12964. 2013-05-18 23:20 +0000 [r389097] Damien Wedhorn <voip@facts.com.au>
  12965. * channels/chan_skinny.c, configs/skinny.conf.sample: Add call
  12966. forward no answer to skinny and cleanup general callfwd handling.
  12967. CallforwardNoAnswer uses a sched to determine when to forward the
  12968. call. Defaults to 20secs but configurable in skinny.conf. Adds
  12969. dialType to each subchannel structure to be used to differentiate
  12970. between normal dials that result in a call being placed (default)
  12971. and other uses for the skinny_dialer (such as cfwd digit
  12972. collection). Restructured all cfwd handling to use this new
  12973. arrangement. (closes issue ASTERISK-21292) Reported by: wedhorn
  12974. Tested by: myself Patches: skinny-callfwdnoans03.diff uploaded by
  12975. wedhorn (license 5019)
  12976. 2013-05-18 22:49 +0000 [r389053-389085] Joshua Colp <jcolp@digium.com>
  12977. * main/pbx.c: Fix a bug where synchronous origination (oddly enough
  12978. triggered by doing an async manager Originate) would not work
  12979. properly.
  12980. * include/asterisk/dial.h, main/manager_channels.c, main/dial.c,
  12981. main/pbx.c: Move origination to use the dialing API and send
  12982. Stasis messages on dial begin and end. (closes issue
  12983. ASTERISK-21549) Reported by: Matt Jordan Review:
  12984. https://reviewboard.asterisk.org/r/2512/
  12985. 2013-05-17 21:10 +0000 [r389011] David M. Lee <dlee@digium.com>
  12986. * res/res_jabber.c, apps/app_queue.c, channels/chan_iax2.c,
  12987. main/endpoints.c, include/asterisk/stasis_message_router.h,
  12988. res/res_chan_stats.c, main/stasis.c, main/manager.c,
  12989. funcs/func_presencestate.c, main/stasis_message_router.c,
  12990. main/app.c, main/stasis_channels.c, res/res_stasis.c,
  12991. main/manager_channels.c, apps/app_voicemail.c,
  12992. main/stasis_cache.c, main/pbx.c, main/stasis_endpoints.c,
  12993. channels/chan_sip.c, include/asterisk/stasis.h,
  12994. main/devicestate.c: Fix shutdown assertions in stasis-core In
  12995. r388005, macros were introduced to consistently define message
  12996. types. This added an assert if a message type was used either
  12997. before it was initialized or after it had been cleaned up. It
  12998. turns out that this assertion fires during shutdown. This
  12999. actually exposed a hidden shutdown ordering problem. Since
  13000. unsubscribing is asynchronous, it's possible that the message
  13001. types used by the subscription could be freed before the final
  13002. message of the subscription was processed. This patch adds
  13003. stasis_subscription_join(), which blocks until the last message
  13004. has been processed by the subscription. Since joining was most
  13005. commonly done right after an unsubscribe, a
  13006. stasis_unsubscribe_and_join() convenience function was also
  13007. added. Similar functions were also added to the
  13008. stasis_caching_topic and stasis_message_router, since they wrap
  13009. subscriptions and have similar problems. Other code in trunk was
  13010. refactored to join() where appropriate, or at least verify that
  13011. the subscription was complete before being destroyed. Review:
  13012. https://reviewboard.asterisk.org/r/2540
  13013. 2013-05-17 20:24 +0000 [r389009] Michael L. Young <elgueromexicano@gmail.com>
  13014. * channels/chan_iax2.c: Remove Character Limit On "inkeys" For IAX2
  13015. Currently, the buffer for processing "inkeys" is limited to 256
  13016. characters. If the user has many keys and the names of those key
  13017. files are long, the 256 character limit is not enough. * Change
  13018. inkeys buffer to be dynamic (closes issue ASTERISK-21398)
  13019. Reported by: Pavel Kopchyk Tested by: Pavel Kopchyk, Michael L.
  13020. Young Patches: asterisk-21398-iax2-inkeys-dynamic-buffer_v3.diff
  13021. by Michael L. Young (license 5026) Review:
  13022. https://reviewboard.asterisk.org/r/2501/
  13023. 2013-05-17 17:43 +0000 [r388976] Matthew Jordan <mjordan@digium.com>
  13024. * apps/app_dial.c, main/channel.c, main/dial.c,
  13025. include/asterisk/stasis_channels.h, main/stasis_channels.c:
  13026. Publish the outbound channel's application/data when dialing This
  13027. patch does two things: * It fixes a bug where the outbound
  13028. channel's application/data set by the dialing API/app_dial is not
  13029. communicated until the channel is hung up. If that happens, AMI
  13030. would incorrectly send a NewExten event immediately after a
  13031. Hangup. This isn't really AMI's fault, as the dialing APIs never
  13032. communicated the 'helpful' app/data on the outbound channel until
  13033. it was hungup. * It makes public sending a stasis message about a
  13034. change in channel state. This is useful enough that - for now at
  13035. least - it should be public. If operations on a channel go to
  13036. being more coarse-grained, this function could be made private
  13037. again. Review: https://reviewboard.asterisk.org/r/2548 Note that
  13038. this problem was found and reported by Matt DiMeo.
  13039. 2013-05-17 17:36 +0000 [r388975] Jonathan Rose <jrose@digium.com>
  13040. * include/asterisk/json.h, main/named_acl.c, CHANGES,
  13041. channels/chan_iax2.c, tests/test_security_events.c,
  13042. res/res_sip.c, main/json.c, main/manager.c,
  13043. channels/sip/include/config_parser.h, res/res_sip_nat.c,
  13044. channels/sip/dialplan_functions.c, include/asterisk/netsock2.h,
  13045. res/res_sip_outbound_registration.c,
  13046. channels/sip/config_parser.c, include/asterisk/security_events.h,
  13047. channels/sip/include/sip.h,
  13048. include/asterisk/security_events_defs.h, main/asterisk.c,
  13049. res/res_security_log.c, include/asterisk/acl.h,
  13050. res/res_sip/config_transport.c, channels/chan_sip.c,
  13051. main/security_events.c, channels/sip/security_events.c,
  13052. include/asterisk/res_sip.h: Stasis: Update security events to use
  13053. Stasis Also moves ACL messages to the security topic and gets rid
  13054. of the ACL topic (closes issue ASTERISK-21103) Reported by: Matt
  13055. Jordan Review: https://reviewboard.asterisk.org/r/2496/
  13056. 2013-05-15 21:13 +0000 [r388896] David M. Lee <dlee@digium.com>
  13057. * res/stasis/app.c, res/stasis/app.h: Fixed inverted logic in
  13058. app_add_channel(). Also added some missing doc comments for
  13059. stasis/app.h.
  13060. 2013-05-15 15:58 +0000 [r388840] Kevin Harwell <kharwell@digium.com>
  13061. * main/lock.c, /: Fix for segfault in __ast_rwlock_destroy with
  13062. DEBUG_THREADS If DEBUG_THREADS is enabled __ast_rwlock_destroy
  13063. causes a segfault while trying to access a possible NULL t->track
  13064. object. A NULL check has been added before trying to access the
  13065. memory. (closes issue ASTERISK-21724) Reported by: Corey Farrell
  13066. Fixed by: Corey Farrell Patches: ast_rwlock_destroy-segv.patch
  13067. uploaded by Corey Farrell (license 5909) ........ Merged
  13068. revisions 388838 from
  13069. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13070. revisions 388839 from
  13071. http://svn.asterisk.org/svn/asterisk/branches/11
  13072. 2013-05-15 15:03 +0000 [r388818] Jason Parker <jparker@digium.com>
  13073. * apps/app_voicemail.c, /: Fix VM snapshot handling for combined
  13074. INBOX. The snapshot API contains an option that allow for
  13075. combining of new and old messages within a single snapshot. New
  13076. messages, however, include options beyond just 'INBOX' - it also
  13077. includes the Urgent folder. A previous patch that combined INBOX
  13078. and Urgent accidentally impacted snapshots that attempted to gain
  13079. messages from just the Old folder. This patch fixes the snapshot
  13080. gathering such that the API returns the appropriate messages for
  13081. the folder selected, with and without the combine option. This
  13082. should make it more clear about what's happening. Review:
  13083. https://reviewboard.asterisk.org/r/2539/ ........ Merged
  13084. revisions 388816 from
  13085. http://svn.asterisk.org/svn/asterisk/branches/11
  13086. 2013-05-15 12:42 +0000 [r388770] Kinsey Moore <kmoore@digium.com>
  13087. * res/res_srtp.c, /, configure, include/asterisk/autoconfig.h.in,
  13088. configure.ac: Use srtp_shutdown when available This allows the
  13089. SRTP library to be shut down properly when the functionality is
  13090. offered by libsrtp. Review:
  13091. https://reviewboard.asterisk.org/r/2538/ (closes issue
  13092. ASTERISK-21719) ........ Merged revisions 388768 from
  13093. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13094. revisions 388769 from
  13095. http://svn.asterisk.org/svn/asterisk/branches/11
  13096. 2013-05-15 02:37 +0000 [r388729-388751] David M. Lee <dlee@digium.com>
  13097. * main/named_acl.c, res/res_stasis_test.c, main/asterisk.c,
  13098. main/presencestate.c, main/stasis.c, main/stasis_cache.c,
  13099. main/stasis_endpoints.c, include/asterisk/stasis.h, main/test.c,
  13100. main/app.c, main/devicestate.c: Refactored the rest of the
  13101. message types to use the STASIS_MESSAGE_TYPE_* macros.
  13102. * res/res_stasis_answer.c (added), res/res_stasis.c,
  13103. apps/app_stasis.c, res/stasis (added), include/asterisk/module.h,
  13104. include/asterisk/stasis_app.h, include/asterisk/stasis_app_impl.h
  13105. (added), res/Makefile: Break res_stasis into smaller files. When
  13106. implementing playback for stasis-http, the monolithicedness of
  13107. res_stasis really started to get in my way. This patch breaks the
  13108. major components of res_stasis.c into individual files. *
  13109. res/stasis/app.c - Stasis application tracking *
  13110. res/stasis/control.c - Channel control objects *
  13111. res/stasis/command.c - Channel command object This refactoring
  13112. also allows res_stasis applications to be loaded as independent
  13113. modules, such as the new res_stasis_answer module. The bulk of
  13114. this patch is simply moving code from one file to another,
  13115. adjusting names and adding accessors as necessary. Review:
  13116. https://reviewboard.asterisk.org/r/2530/
  13117. 2013-05-14 19:03 +0000 [r388701] Richard Mudgett <rmudgett@digium.com>
  13118. * main/astobj2.c, /, include/asterisk/astobj2.h: Make ao2 global
  13119. objects not always use the debug version of the ao2_ref() calls.
  13120. The debug versions of ao2_ref() should only be used if REF_DEBUG
  13121. is enabled so nothing is written to /tmp/refs unexpectedly.
  13122. (closes issue ASTERISK-21785) Reported by: abelbeck Patches:
  13123. jira_asterisk_21785_v11.patch (license #5621) patch uploaded by
  13124. rmudgett Tested by: abelbeck ........ Merged revisions 388700
  13125. from http://svn.asterisk.org/svn/asterisk/branches/11
  13126. 2013-05-14 12:47 +0000 [r388668] Kinsey Moore <kmoore@digium.com>
  13127. * res/stasis_http/resource_recordings.h,
  13128. rest-api-templates/stasis_http_resource.h.mustache,
  13129. res/res_stasis_json_endpoints.exports.in (added),
  13130. res/res_stasis_json_events.exports.in (added),
  13131. res/res_stasis_json_channels.c (added),
  13132. rest-api-templates/res_stasis_http_resource.c.mustache,
  13133. res/stasis_http/resource_events.h,
  13134. res/res_stasis_json_recordings.c (added),
  13135. res/stasis_json/resource_bridges.h (added),
  13136. res/stasis_http/resource_sounds.h, res/res_stasis_json_events.c
  13137. (added), res/res_stasis_json_bridges.exports.in (added),
  13138. res/stasis_json/resource_playback.h (added),
  13139. res/res_stasis_json_sounds.c (added),
  13140. res/stasis_http/resource_asterisk.h,
  13141. res/stasis_json/resource_channels.h (added),
  13142. rest-api-templates/stasis_json_resource.h.mustache (added),
  13143. res/res_stasis_json_channels.exports.in (added),
  13144. res/stasis_json/resource_recordings.h (added),
  13145. res/res_stasis_json_asterisk.c (added),
  13146. rest-api-templates/res_stasis_json_resource.c.mustache (added),
  13147. res/res_stasis_json_recordings.exports.in (added),
  13148. res/stasis_json/resource_events.h (added),
  13149. res/stasis_http/resource_endpoints.h,
  13150. res/stasis_json/resource_sounds.h (added),
  13151. tests/test_res_stasis.c, res/res_stasis_json_sounds.exports.in
  13152. (added), res/res_stasis_json_endpoints.c (added),
  13153. rest-api-templates/res_stasis_json_resource.exports.mustache
  13154. (added), res/stasis_http/resource_bridges.h,
  13155. res/stasis_json/resource_asterisk.h (added),
  13156. res/res_stasis_http_events.c,
  13157. res/res_stasis_json_asterisk.exports.in (added),
  13158. res/res_stasis_json_playback.exports.in (added),
  13159. res/stasis_http/resource_playback.h,
  13160. res/res_stasis_json_bridges.c (added),
  13161. res/stasis_http/resource_channels.h, res/stasis_json (added),
  13162. res/stasis_json/resource_endpoints.h (added),
  13163. res/res_stasis_json_playback.c (added), res/res_stasis.c,
  13164. rest-api-templates/make_stasis_http_stubs.py: Move JSON event
  13165. generators into separate modules This moves the JSON event
  13166. generators out of the Stasis-HTTP modules and into standalone
  13167. JSON-related counterparts so that Stasis-HTTP and res_stasis can
  13168. depend on them without creating dependency cycles. This also
  13169. provides a future location for Swagger Model validator functions
  13170. once the generators for that code are written. Review:
  13171. https://reviewboard.asterisk.org/r/2534/
  13172. 2013-05-13 21:21 +0000 [r388602-388617] Michael L. Young <elgueromexicano@gmail.com>
  13173. * /, main/logger.c: Fix Missing CALL-ID When Logging Through Syslog
  13174. The CALL-ID (ie [C-00000074]) is missing when logging to syslog.
  13175. This was just an oversight when this feature was added. * Add
  13176. CALL-IDs when using syslog (closes issue ASTERISK-21430) Reported
  13177. by: Nikola Ciprich Tested by: Nikola Ciprich, Michael L. Young
  13178. Patches: asterisk-21430-syslog-callid_trunk.diff by Michael L.
  13179. Young (license 5026) Review:
  13180. https://reviewboard.asterisk.org/r/2526/ ........ Merged
  13181. revisions 388605 from
  13182. http://svn.asterisk.org/svn/asterisk/branches/11
  13183. * /, channels/chan_sip.c: Fix Crash Caused By One-way Audio With
  13184. auto_* NAT Settings Fix The prior code committed, r385473, failed
  13185. to take into consideration that not all outgoing calls will be to
  13186. a peer. My fault. This patch does the following: * Check if there
  13187. is a related peer involved. If there is, check and set NAT
  13188. settings according to the peer's settings. * Fix a problem with
  13189. realtime peers. If the global setting has auto_force_rport set
  13190. and we issued a "sip reload" while a peer is still registered,
  13191. the peer's flags for NAT are reset to off. When this happens, we
  13192. were always setting the contact address of the peer to that of
  13193. the full contact info that we had. (closes issue ASTERISK-21374)
  13194. Reported by: jmls Tested by: Michael L. Young Patches:
  13195. asterisk-21374-fix-crash-and-rt-peers.diff by Michael L. Young
  13196. (license 5026) Review: https://reviewboard.asterisk.org/r/2524/
  13197. ........ Merged revisions 388601 from
  13198. http://svn.asterisk.org/svn/asterisk/branches/11
  13199. 2013-05-13 20:37 +0000 [r388598] Kinsey Moore <kmoore@digium.com>
  13200. * res/res_srtp.c, /: Revert r388529 for now Adding the cleanup
  13201. function needs some deeper thought since it apparently doesn't
  13202. exist for all variants of libsrtp. ........ Merged revisions
  13203. 388596 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  13204. ........ Merged revisions 388597 from
  13205. http://svn.asterisk.org/svn/asterisk/branches/11
  13206. 2013-05-13 19:29 +0000 [r388579] Jonathan Rose <jrose@digium.com>
  13207. * main/pbx.c, /: pbx: Fix lack of cleanup on macrolock and
  13208. context_table (closes issue ASTERISK-21723) Reported by: Corey
  13209. Farrell Patches: core-pbx-cleanup.patch uploaded by Correy
  13210. Farrell (license 5909) ........ Merged revisions 388532 from
  13211. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13212. revisions 388578 from
  13213. http://svn.asterisk.org/svn/asterisk/branches/11
  13214. 2013-05-13 18:10 +0000 [r388531] Kinsey Moore <kmoore@digium.com>
  13215. * res/res_srtp.c, /: Close libsrtp properly Ensure that libsrtp is
  13216. shutdown properly when res_srtp is unloaded. (closes issue
  13217. ASTERISK-21719) Reported by: Corey Farrell Patches:
  13218. res_srtp-library-shutdown.patch uploaded by Corey Farrell
  13219. ........ Merged revisions 388529 from
  13220. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13221. revisions 388530 from
  13222. http://svn.asterisk.org/svn/asterisk/branches/11
  13223. 2013-05-13 17:20 +0000 [r388526] Jonathan Rose <jrose@digium.com>
  13224. * channels/chan_gulp.c: chan_gulp: Minor readability Improvements
  13225. to chan_gulp (closes issue ASTERISK-21670) Reported by: Snuffy
  13226. Review: https://reviewboard.asterisk.org/r/2473/ Patches:
  13227. gulp-coding-guide.diff uploaded by snuffy (license 5024)
  13228. 2013-05-13 14:28 +0000 [r388479] Richard Mudgett <rmudgett@digium.com>
  13229. * main/manager.c, /: Fix SendText AMI action to never return
  13230. non-zero. AMI actions must never return non-zero unless they
  13231. intend to close the AMI connection. (Which is almost never.)
  13232. (closes issue ASTERISK-21779) Reported by: Paul Goldbaum ........
  13233. Merged revisions 388477 from
  13234. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13235. revisions 388478 from
  13236. http://svn.asterisk.org/svn/asterisk/branches/11
  13237. 2013-05-10 22:12 +0000 [r388427] Richard Mudgett <rmudgett@digium.com>
  13238. * /, channels/misdn/isdn_msg_parser.c: Allow mISDN to send PROGRESS
  13239. messsage. * Made isdn_msg_parser.c build a progress message with
  13240. the mandatory progress indicator IE. (The mISDNuser NT state
  13241. machine rejected sending the incomplete message.) Note: The
  13242. associated mISDN and mISDNuser patches respectively are viewable
  13243. here: http://svnview.digium.com/svn/thirdparty?view=rev&rev=200
  13244. http://svnview.digium.com/svn/thirdparty?view=rev&rev=201 (closes
  13245. issue AST-1153) Reported by: Guenther Kelleter Patches:
  13246. progress-chan_misdn.diff (license #6372) patch uploaded by
  13247. Guenther Kelleter progress-misdn.diff (license #6372) mISDN patch
  13248. uploaded by Guenther Kelleter progress-misdnuser.diff (license
  13249. #6372) mISDNuser patch uploaded by Guenther Kelleter ........
  13250. Merged revisions 388425 from
  13251. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13252. revisions 388426 from
  13253. http://svn.asterisk.org/svn/asterisk/branches/11
  13254. 2013-05-10 20:50 +0000 [r388380] Mark Michelson <mmichelson@digium.com>
  13255. * /, pbx/pbx_dundi.c: Fix memory leak in pbx_dundi pbx_dundi added
  13256. an io context without removing it. This caused a memory leak when
  13257. the module was unloaded. (closes ASTERISK-21718) Reported by
  13258. Corey Farrell Patches: pbx_dundi-ast_io_remove.patch uploaded by
  13259. Corey Farrell (License #5909) ........ Merged revisions 388376
  13260. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  13261. Merged revisions 388378 from
  13262. http://svn.asterisk.org/svn/asterisk/branches/11
  13263. 2013-05-10 20:28 +0000 [r388375] Michael L. Young <elgueromexicano@gmail.com>
  13264. * res/res_config_odbc.c: Fix Finding Extensions With Patterns Using
  13265. ODBC Realtime After the merge of support for the realtime sorcery
  13266. module, extensions that contained a pattern were not being found
  13267. through odbc realtime. It was tracked down to this one line that
  13268. was advancing to the next variable list before it should have
  13269. been. The removal of this one line fixes this. Tested this fix on
  13270. my machine. Received confirmation that this is the right fix from
  13271. file on IRC.
  13272. 2013-05-10 17:12 +0000 [r388318-388350] David M. Lee <dlee@digium.com>
  13273. * res/res_stasis_http_channels.c, include/asterisk/stasis_app.h,
  13274. res/res_stasis_http_recordings.c,
  13275. res/res_stasis_http_endpoints.c, main/loader.c,
  13276. res/res_stasis_http_events.c, res/res_stasis_http_sounds.c,
  13277. res/res_stasis_http_bridges.c, res/res_stasis_http.c,
  13278. res/res_stasis.c, apps/app_stasis.c,
  13279. res/res_stasis_http_asterisk.c,
  13280. rest-api-templates/res_stasis_http_resource.c.mustache,
  13281. res/res_stasis_http_playback.c, res/res_stasis_websocket.c,
  13282. tests/test_res_stasis.c: Address unload order issues for
  13283. res_stasis* modules I've noticed when doing a graceful shutdown
  13284. that the res_stasis_http.so module gets unloaded before the
  13285. modules that use it, which causes some asserts during their
  13286. unload. While r386928 was a quick hack to get it to not assert
  13287. and die, this patch increases the use counts on res_stasis.so and
  13288. res_stasis_http.so properly. It's a bigger change than I
  13289. expected, hence the review instead of just committing it. Review:
  13290. https://reviewboard.asterisk.org/r/2489/
  13291. * include/asterisk/stasis.h: Avoided __ast names for the private
  13292. variables created by the STASIS_MESSAGE_TYPE_*() macros.
  13293. 2013-05-10 13:13 +0000 [r388275] Kinsey Moore <kmoore@digium.com>
  13294. * rest-api-templates/event_function_decl.mustache (added),
  13295. res/stasis_http/resource_sounds.h, CHANGES,
  13296. res/res_stasis_http_events.c, include/asterisk/stasis_channels.h,
  13297. main/stasis_channels.c, rest-api-templates/swagger_model.py,
  13298. res/res_stasis.c, main/manager_channels.c,
  13299. rest-api-templates/stasis_http_resource.h.mustache,
  13300. res/stasis_http/resource_recordings.h,
  13301. rest-api-templates/asterisk_processor.py,
  13302. rest-api-templates/res_stasis_http_resource.c.mustache,
  13303. res/stasis_http/resource_endpoints.h,
  13304. rest-api/api-docs/events.json, res/stasis_http/resource_events.h,
  13305. res/res_stasis_websocket.c, apps/app_userevent.c: Add channel
  13306. events for res_stasis apps This change adds a framework in
  13307. res_stasis for handling events from channel topics. JSON event
  13308. generation and validation code is created from event
  13309. documentation in rest-api/api-docs/events.json to assist in JSON
  13310. event generation, ensure consistency, and ensure that accurate
  13311. documentation is available for ALL events that are received by
  13312. res_stasis applications. The userevent application has been
  13313. refactored along with the code that handles userevent channel
  13314. blob events to pass the headers as key/value pairs in the JSON
  13315. blob. As a side-effect, app_userevent now handles duplicate keys
  13316. by overwriting the previous value. Review:
  13317. https://reviewboard.asterisk.org/r/2428/ (closes issue
  13318. ASTERISK-21180) Patch-By: Kinsey Moore <kmoore@digium.com>
  13319. 2013-05-10 11:47 +0000 [r388254] Sean Bright <sean@malleable.com>
  13320. * /, channels/chan_sip.c: Fix copy/paste error in
  13321. one-touch-recording implementation. ........ Merged revisions
  13322. 388253 from http://svn.asterisk.org/svn/asterisk/branches/11
  13323. 2013-05-09 14:41 +0000 [r388175] Matthew Jordan <mjordan@digium.com>
  13324. * apps/app_userevent.c: Don't expect to pack three tuples when you
  13325. only have two
  13326. 2013-05-09 04:11 +0000 [r388110-388113] Michael L. Young <elgueromexicano@gmail.com>
  13327. * res/res_rtp_asterisk.c, /: Fix The Payload Being Set On CN
  13328. Packets And Do Not Set Marker Bit When we send out a CN packet
  13329. (for instance, in the case of using rtpkeepalives), we are not
  13330. setting the payload code properly. Also, we are setting the
  13331. marker bit when we shouldn't be according to RFC 3389, section 4.
  13332. AST_RTP_CN is not defined by AST_FORMAT codes. Therefore, we
  13333. should be using ast_rtp_codecs_payload_code() rather than
  13334. ast_rtp_codecs_payload_lookup(). 11 and trunk already use the
  13335. appropriate function. * In 1.8, use ast_rtp_codecs_payload_code()
  13336. * Remove the setting of the marker bit * Fix the debug message by
  13337. incrementing the seqno after the debug message is set in order to
  13338. display the correct seqno that was sent out (closes issue
  13339. ASTERISK-21246) Reported by: Peter Katzmann Tested by: Peter
  13340. Katzmann, Michael L. Young Patches:
  13341. asterisk-21246-rtp-cng-payload-error_1.8_v2.diff uploaded by
  13342. Michael L. Young (license 5026) Review:
  13343. https://reviewboard.asterisk.org/r/2500/ ........ Merged
  13344. revisions 388111 from
  13345. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13346. revisions 388112 from
  13347. http://svn.asterisk.org/svn/asterisk/branches/11
  13348. * /, apps/app_queue.c: Fix Segfault In app_queue When
  13349. "persistentmembers" Is Enabled And Using Realtime When the
  13350. "ignorebusy" setting was deprecated, we added some code to allow
  13351. us to be compatible with older setups that are still using the
  13352. "ignorebusy" setting instead of "ringinuse". We set a char
  13353. *variable with the column name to use, which helps the realtime
  13354. functions to use the correct column in their SQL queries. When
  13355. "persistentmembers" is enabled, we are not setting this variable
  13356. before the realtime functions were called to load members. This
  13357. results in the variable being NULL and therefore causing a
  13358. segfault when loading members during the module's process of
  13359. loading. The solution was to move the code that sets that
  13360. variable to be before these realtime functions are called during
  13361. the loading of the module. (closes issue ASTERISK-21738) Reported
  13362. by: JoshE Tested by: JoshE Patches:
  13363. asterisk-21738-rt-ringinuse-field-not-set.diff uploaded by
  13364. Michael L. Young (license 5026) Review:
  13365. https://reviewboard.asterisk.org/r/2499/ ........ Merged
  13366. revisions 388108 from
  13367. http://svn.asterisk.org/svn/asterisk/branches/11
  13368. 2013-05-08 22:00 +0000 [r388014-388075] David M. Lee <dlee@digium.com>
  13369. * res/res_stasis_websocket.c: Fixed MODFLAG for
  13370. res_stasis_websocket
  13371. * build_tools/cflags.xml, include/asterisk/inline_api.h: Add
  13372. development flag to disable the inline API. A GCC bug[1] can, in
  13373. some cases, pop up an unsuppressible pedwarn when using a static
  13374. inline standard library function from a non-static inline
  13375. function. This normally doesn't show up, but can occur if you're
  13376. running an upgrade version of GCC (such as GCC 4.8 on OS X, which
  13377. normally runs GCC 4.2). [1]:
  13378. http://gcc.gnu.org/bugzilla/show_bug.cgi?id=47816
  13379. * main/srv.c, main/enum.c: Removed #if checks for crazy old
  13380. versions of OS X. The <arpa/nameser_compat.h> was introduced way
  13381. back in OS X Panther, which itself was end-of-lifed back in 2007.
  13382. We can assume that any OS X machine we build on will need that
  13383. header file :-) Why bother removing it? The flag we're checking
  13384. (__APPLE_CC__) is actually Apple's build number. Self-compiled
  13385. versions of GCC (such as installing the latest version of GCC
  13386. from homebrew) sets the value to 0, making it useless for this
  13387. sort of compile flaggery.
  13388. * tests/test_stasis_endpoints.c: Fixed set-but-not-used warning
  13389. caught by newer GCC
  13390. 2013-05-08 18:36 +0000 [r388008] Matthew Jordan <mjordan@digium.com>
  13391. * apps/app_directory.c: Don't perform a realtime lookup with a NULL
  13392. keyword Previously, a call to ast_load_realtime_multientry could
  13393. get away with passing a NULL parameter to the function, even
  13394. though it really isn't supposed to do that. After the change over
  13395. to using ast_variable instead of variadic arguments, the realtime
  13396. engine gets unhappy if you do this. This was always an unintended
  13397. function call in app_directory anyway - now, we just don't call
  13398. into the realtime function calls if we don't have anything to
  13399. query on.
  13400. 2013-05-08 18:34 +0000 [r388005] David M. Lee <dlee@digium.com>
  13401. * main/stasis_channels.c, res/res_stasis.c,
  13402. main/manager_channels.c, main/channel.c,
  13403. include/asterisk/stasis_channels.h, tests/test_stasis_channels.c,
  13404. apps/app_userevent.c, include/asterisk/stasis.h: Remove required
  13405. type field from channel blobs When we first introduced the
  13406. channel blob types, the JSON blobs were self identifying by a
  13407. required "type" field in the JSON object itself. This, as it
  13408. turns out, was a bad idea. When we introduced the message router,
  13409. it was useless for routing based on the JSON type. And messages
  13410. had two type fields to check: the stasis_message_type() of the
  13411. message itself, plus the type field in the JSON blob (but only if
  13412. it was a blob message). This patch corrects that mistake by
  13413. removing the required type field from JSON blobs, and introducing
  13414. first class stasis_message_type objects for the actual message
  13415. type. Since we now will have a proliferation of message types, I
  13416. introduced a few macros to help reduce the amount of boilerplate
  13417. necessary to set them up. Review:
  13418. https://reviewboard.asterisk.org/r/2509
  13419. 2013-05-08 16:58 +0000 [r387974] Richard Mudgett <rmudgett@digium.com>
  13420. * utils: Add version.c to list of ignored files in the utils
  13421. directory.
  13422. 2013-05-08 13:39 +0000 [r387932] David M. Lee <dlee@digium.com>
  13423. * tests/test_endpoints.c (added),
  13424. include/asterisk/stasis_endpoints.h (added),
  13425. res/res_stasis_test.c (added),
  13426. res/stasis_http/resource_endpoints.c, channels/sip/include/sip.h,
  13427. main/asterisk.c, rest-api/api-docs/endpoints.json,
  13428. res/stasis_http/resource_endpoints.h, main/stasis_cache.c,
  13429. main/stasis_endpoints.c (added), channels/chan_sip.c,
  13430. include/asterisk/endpoints.h (added), include/asterisk/astobj2.h,
  13431. main/channel_internal_api.c, include/asterisk/stasis_test.h
  13432. (added), include/asterisk/stasis.h, main/endpoints.c (added),
  13433. main/astobj2.c, res/res_stasis_http_endpoints.c,
  13434. tests/test_stasis_endpoints.c (added),
  13435. res/res_stasis_test.exports.in (added): Initial support for
  13436. endpoints. An endpoint is an external device/system that may
  13437. offer/accept channels to/from Asterisk. While this is a very
  13438. useful concept for end users, it is surprisingly not a core
  13439. concept within Asterisk itself. This patch defines ast_endpoint
  13440. as a separate object, which channel drivers may use to expose
  13441. their concept of an endpoint. As the channel driver creates
  13442. channels, it can use ast_endpoint_add_channel() to associate
  13443. channels to the endpoint. This updated the endpoint
  13444. appropriately, and forwards all of the channel's events to the
  13445. endpoint's topic. In order to avoid excessive locking on the
  13446. endpoint object itself, the mutable state is not accessible via
  13447. getters. Instead, you can create a snapshot using
  13448. ast_endpoint_snapshot_create() to get a consistent snapshot of
  13449. the internal state. This patch also includes a set of topics and
  13450. messages associated with endpoints, and implementations of the
  13451. endpoint-related RESTful API. chan_sip was updated to create
  13452. endpoints with SIP peers, but the state of the endpoints is not
  13453. updated with the state of the peer. Along for the ride in this
  13454. patch is a Stasis test API. This is a stasis_message_sink object,
  13455. which can be subscribed to a Stasis topic. It has functions for
  13456. blocking while waiting for conditions in the message sink to be
  13457. fulfilled. (closes issue ASTERISK-21421) Review:
  13458. https://reviewboard.asterisk.org/r/2492/
  13459. 2013-05-08 07:21 +0000 [r387885] Alec L Davis <sivad.a@paradise.net.nz>
  13460. * /, channels/chan_sip.c: chan_sip: NOTIFYs for BLF start queuing
  13461. up and fail to be sent out after retries fail RFC6665 4.2.2: ...
  13462. after a failed State NOTIFY transaction remove the subscription
  13463. The problem is that the State Notify requests rely on the 200OK
  13464. reponse for pacing control and to not confuse the notify
  13465. susbsystem. The issue is, the pendinginvite isn't cleared if a
  13466. response isn't received, thus further notify's are never sent.
  13467. The solution, follow RFC 6665 4.2.2's 'SHOULD' and remove the
  13468. subscription after failure. (closes issue ASTERISK-21677)
  13469. Reported by: Dan Martens Tested by: alecdavis alecdavis (license
  13470. 585) Review https://reviewboard.asterisk.org/r/2475/ ........
  13471. Merged revisions 387875 from
  13472. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13473. revisions 387880 from
  13474. http://svn.asterisk.org/svn/asterisk/branches/11
  13475. 2013-05-07 18:32 +0000 [r387803-387825] David M. Lee <dlee@digium.com>
  13476. * include/asterisk/lock.h: Fixed up \example marker in lock.h
  13477. Doxygen comment. The \example tags marks an entire file as an
  13478. example, not a code snippet.
  13479. * res/res_config_pgsql.c, main/manager.c, /: Minor fixups to
  13480. Doxygen comments. The \example tags marks an entire file as an
  13481. example, not a code snippet. ........ Merged revisions 387823
  13482. from http://svn.asterisk.org/svn/asterisk/branches/11
  13483. * include/asterisk/json.h: Better explained the depths of reference
  13484. stealing.
  13485. 2013-05-07 17:53 +0000 [r387802] Jason Parker <jparker@digium.com>
  13486. * include/asterisk.h: Fix build breakage, from LOW_MEMORY fix.
  13487. 2013-05-06 17:15 +0000 [r387740-387741] Richard Mudgett <rmudgett@digium.com>
  13488. * include/asterisk/astobj2.h: Update ao2_destructor_fn doxygen.
  13489. * channels/chan_dahdi.c: Make a log NOTICE more explicit that the
  13490. event comes from DAHDI and not PRI.
  13491. 2013-05-06 17:01 +0000 [r387738] Jason Parker <jparker@digium.com>
  13492. * main/asterisk.c: Fix building with LOW_MEMORY defined.
  13493. 2013-05-06 15:58 +0000 [r387690] Russell Bryant <russell@russellbryant.com>
  13494. * /, apps/app_meetme.c: Make SLA reload more paranoid. Reload
  13495. support was originally not included for SLA. It was added later,
  13496. but in a fairly non-traditional way. It basically sets a flag
  13497. indicating that a reload is pending, and then waits for a time
  13498. where it thinks everything SLA related is idle and unused, and
  13499. *then* executes the reload. It does this because the reload
  13500. process is destructive. It starts by throwing everything away and
  13501. starting over. There are a number of problems with this approach.
  13502. One of them is that the check to see if anything in use was
  13503. incomplete. This patch makes it more complete and thus less
  13504. likely for a crash to occur during reload processing. However,
  13505. this approach still has problems so some much more significant
  13506. reworking of this code will need to come in as a next step. Patch
  13507. credit and testing by CoreDial, LLC. ........ Merged revisions
  13508. 387688 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  13509. ........ Merged revisions 387689 from
  13510. http://svn.asterisk.org/svn/asterisk/branches/11
  13511. 2013-05-06 13:04 +0000 [r387662] Joshua Colp <jcolp@digium.com>
  13512. * include/asterisk/sorcery.h, res/res_sorcery_astdb.c,
  13513. tests/test_sorcery.c, main/sorcery.c: Add support for observers
  13514. and JSON objectset creation to sorcery. This change adds the
  13515. ability for modules to add themselves as observers to sorcery
  13516. object types. Observers can be notified when objects are created,
  13517. updated, or deleted as well as when the object type is loaded or
  13518. reloaded. Observer notifications are done using a thread pool in
  13519. a serialized fashion so the caller of the sorcery API calls is
  13520. minimally impacted. This also adds the ability to create JSON
  13521. changesets of a sorcery object. Tests are also present to confirm
  13522. all of the above functionality. Review:
  13523. https://reviewboard.asterisk.org/r/2477/
  13524. 2013-05-04 16:00 +0000 [r387630-387633] Matthew Jordan <mjordan@digium.com>
  13525. * main/asterisk.c, include/asterisk.h: Clean up documentation;
  13526. prevent ref leak on exit This patch: * Cleans up some doxygen *
  13527. Prevents leaking the system level Stasis topics and messages on
  13528. exit (users of valgrind will be happier)
  13529. * funcs/func_global.c: Migrate SHARED's use of the VarSet AMI event
  13530. to Stasis-Core This patch removes the direct call to AMI from the
  13531. SHARED function and instead call Stasis-Core. Stasis-Core
  13532. delivers the notification that a shared variable has changed on a
  13533. channel to all interested consumers. (issue ASTERISK-21462)
  13534. 2013-05-03 18:03 +0000 [r387594] Jonathan Rose <jrose@digium.com>
  13535. * main/asterisk.c, include/asterisk.h, channels/chan_sip.c,
  13536. res/res_stun_monitor.c, main/event.c, channels/chan_iax2.c:
  13537. Stasis: Convert network change events into network change stasis
  13538. messages (issue ASTERISK-21103) Review:
  13539. https://reviewboard.asterisk.org/r/2490/
  13540. 2013-05-03 11:35 +0000 [r387545] Joshua Colp <jcolp@digium.com>
  13541. * res/res_sip_sdp_rtp.c, channels/chan_gulp.c: Use the configured
  13542. formats for Gulp sessions if there are no joint formats between
  13543. requested formats and configured formats. (closes issue
  13544. ASTERISK-21756)
  13545. 2013-05-02 20:59 +0000 [r387519] Matthew Jordan <mjordan@digium.com>
  13546. * build_tools/post_process_documentation.py, apps/app_stack.c:
  13547. Migrate AMI VarSet events raised by GoSub local variables This
  13548. patch moves VarSet events for local variables raised by GoSub
  13549. over to Stasis-Core. It also tweaks up the post-processing
  13550. documentation scripts to not combine parameters if both
  13551. parameters are already documented. (issue ASTERISK-21462)
  13552. 2013-05-02 19:06 +0000 [r387482] Richard Mudgett <rmudgett@digium.com>
  13553. * main/channel.c: Remove the ABI compatability ast_channel_alloc().
  13554. It is no longer needed.
  13555. 2013-05-02 17:15 +0000 [r387423] Matthew Jordan <mjordan@digium.com>
  13556. * utils/Makefile, /: Update utils Makefile to handle r387294 Alec's
  13557. patch that added the Asterisk version to 'core show locks'
  13558. angered the items in utils, as they exist somewhat outside of the
  13559. Asterisk build system. Some day, this Makefile should get nuked
  13560. from high orbit, but for now, include version.c in its list of
  13561. stuff to pile in. ........ Merged revisions 387421 from
  13562. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13563. revisions 387422 from
  13564. http://svn.asterisk.org/svn/asterisk/branches/11
  13565. 2013-05-02 16:39 +0000 [r387420] Jonathan Rose <jrose@digium.com>
  13566. * include/asterisk/event_defs.h, main/event.c: Putting all event
  13567. defs and names back for now due to res_corosync dependency
  13568. 2013-05-02 08:24 +0000 [r387296-387369] Alec L Davis <sivad.a@paradise.net.nz>
  13569. * /, channels/chan_sip.c, channels/sip/include/sip.h: chan_sip:
  13570. Session-Expires: Set timer to correctly expire at (~2/3) of the
  13571. interval when not the refresher RFC 4028 Section 10 if the side
  13572. not performing refreshes does not receive a session refresh
  13573. request before the session expiration, it SHOULD send a BYE to
  13574. terminate the session, slightly before the session expiration.
  13575. The minimum of 32 seconds and one third of the session interval
  13576. is RECOMMENDED. Prior to this asterisk would refresh at 1/2 the
  13577. Session-Expires interval, or if the remote device was the
  13578. refresher, asterisk would timeout at interval end. Now, when not
  13579. refresher, timeout as per RFC noted above. (closes issue
  13580. ASTERISK-21742) Reported by: alecdavis Tested by: alecdavis
  13581. alecdavis (license 585) Review
  13582. https://reviewboard.asterisk.org/r/2488/ ........ Merged
  13583. revisions 387344 from
  13584. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13585. revisions 387345 from
  13586. http://svn.asterisk.org/svn/asterisk/branches/11
  13587. * /, channels/chan_sip.c: chan_sip: Honor Session-Expires in 200OK
  13588. response when it's a RE-INVITE when asterisk is the refresher.
  13589. RFC 4028 Section 7.2 "UACs MUST be prepared to receive a
  13590. Session-Expires header field in a response, even if none were
  13591. present in the request." What changed After ASTERISK-20787,
  13592. inbound calls to asterisk with no Session-Expires in the INVITE
  13593. are now are offered a Session-Expires (1800 asterisk default) in
  13594. the response, with asterisk as the refresher. Symptom: After 900
  13595. seconds (asterisk default refresher period 1800), asterisk
  13596. RE-INVITEs the device, the device may respond with a much lower
  13597. Session-Expires (180 in our case) value that it is now using.
  13598. Asterisk ignores this response, as it's deemed both an INBOUND
  13599. CALL, and a RE-INVITE. After 180 seconds the device times out and
  13600. sends BYE (hangs up), asterisk is still working with the
  13601. refresher period of 1800 as it ignored the 'Session Expires: 180'
  13602. in the previous 200OK response. Fix: handle_response_invite()
  13603. when 200OK, remove check for outbound and reinvite. (closes issue
  13604. ASTERISK-21664) Reported by: alecdavis Tested by: alecdavis
  13605. alecdavis (license 585) Review
  13606. https://reviewboard.asterisk.org/r/2463/ ........ Merged
  13607. revisions 387312 from
  13608. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13609. revisions 387319 from
  13610. http://svn.asterisk.org/svn/asterisk/branches/11
  13611. * channels/chan_dahdi.c, /: chan_dahdi: fix lower bound check with
  13612. -ve integer conversion from a float Lower bound of a 16bit signed
  13613. int is -32768 not -32767 (closes issue ASTERISK-21744) Reported
  13614. by: alecdavis Tested by: alecdavis alecdavis (license 585)
  13615. ........ Merged revisions 387297 from
  13616. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13617. revisions 387298 from
  13618. http://svn.asterisk.org/svn/asterisk/branches/11
  13619. * /, main/utils.c: Add Asterisk Version to core show locks Assist
  13620. with reporting 'core show locks' when submitting bug reports.
  13621. Example below: =========================== == SVN-branch-1.8-...
  13622. == Currently Held Locks =========================== (closes issue
  13623. ASTERISK-21743) Reported by: alecdavis Tested by: alecdavis
  13624. alecdavis (license 585) ........ Merged revisions 387294 from
  13625. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13626. revisions 387295 from
  13627. http://svn.asterisk.org/svn/asterisk/branches/11
  13628. 2013-05-01 21:55 +0000 [r387260-387261] Richard Mudgett <rmudgett@digium.com>
  13629. * channels/chan_local.c: Simplify
  13630. chan_local.c:manager_optimize_away() using ao2_find().
  13631. * channels/chan_local.c: Cleanup chan_local.c:local_new(). * Remove
  13632. t and ama local variables. There is no way they could be anything
  13633. other than default because p->owner can only be NULL at this
  13634. point. * Rename tmp and tmp2 to owner and chan respectively. *
  13635. Remove redundant initialization of channel context, exten,
  13636. priority.
  13637. 2013-05-01 21:18 +0000 [r387220] Matthew Jordan <mjordan@digium.com>
  13638. * res/res_rtp_asterisk.c, /: Clear the DTMF sending digit tracking
  13639. on off nominal paths In certain situations, when the RTP engine
  13640. goes to send a DTMF end digit it may be in a situation where the
  13641. remote address is no longer available, or the digit that was
  13642. supposed to be sent is invalid. In such cases, we need to clear
  13643. the RTP counters appropriately. Otherwise, when the RTP source is
  13644. set again, we'll continue to think that we're in the middle of
  13645. sending a DTMF digit, which can confuse the remote party
  13646. (signficantly). (closes issue ASTERISK-21522) Reported by: Corey
  13647. Farrell patches: rtp_dtmf_process_end.patch uploaded by Corey
  13648. Farrell (License 5909) ........ Merged revisions 387213 from
  13649. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13650. revisions 387216 from
  13651. http://svn.asterisk.org/svn/asterisk/branches/11
  13652. 2013-05-01 21:09 +0000 [r387181-387212] Richard Mudgett <rmudgett@digium.com>
  13653. * channels/chan_local.c: Trivial changes. Comments, parentheses,
  13654. spelling, wording.
  13655. * channels/chan_local.c: Make chan_local locals container an
  13656. explicit list container. Pretending that chan_local locals
  13657. container can have more than one bucket is silly. The container
  13658. has no key to help search.
  13659. * channels/chan_local.c: Whitespace changes.
  13660. * main/loader.c: Make mod_load_cmp() not as klunky. There is a
  13661. reason the heap comparison functions like qsort(), and other
  13662. comparison functions specify <0, >0, and =0 for the return
  13663. values.
  13664. * channels/chan_unistim.c: Remove some unnecessary calls to
  13665. ast_bridged_channel() in chan_unistim.c
  13666. * channels/chan_mgcp.c: Remove some unnecessary calls to
  13667. ast_bridged_channel() in chan_mgcp.c
  13668. * channels/chan_skinny.c: Remove some unnecessary calls to
  13669. ast_bridged_channel() in chan_skinny.c
  13670. * channels/chan_iax2.c: Remove some unnecessary calls to
  13671. ast_bridged_channel() in chan_iax2.c
  13672. * channels/chan_dahdi.c, channels/sig_analog.c: Remove some
  13673. unnecessary calls to ast_bridged_channel() in
  13674. chan_dahdi.c/sig_analog.c
  13675. 2013-05-01 18:38 +0000 [r387135] Matthew Jordan <mjordan@digium.com>
  13676. * /, channels/chan_sip.c: Prevent crash in 'sip show peers' when
  13677. the number of peers on a system is large When you have lots of
  13678. SIP peers (according to the issue reporter, around 3500), the
  13679. 'sip show peers' CLI command or AMI action can crash due to a
  13680. poorly placed string duplication that occurs on the stack. This
  13681. patch refactors the command to not allocate the string on the
  13682. stack, and handles the formatting of a single peer in a separate
  13683. function call. (closes issue ASTERISK-21466) Reported by:
  13684. Guillaume Knispel patches:
  13685. fix_sip_show_peers_stack_overflow_asterisk_11.3.0-v2.patch
  13686. uploaded by gknispel (License 6492) ........ Merged revisions
  13687. 387134 from http://svn.asterisk.org/svn/asterisk/branches/11
  13688. 2013-05-01 17:15 +0000 [r387108] Richard Mudgett <rmudgett@digium.com>
  13689. * channels/chan_dahdi.c: Move some annoying chan_dahdi debug
  13690. messages to level 5.
  13691. 2013-04-30 22:50 +0000 [r387039] Matthew Jordan <mjordan@digium.com>
  13692. * main/features.c, /: Fix CDR not being created during an
  13693. externally initiated blind transfer Way back when in the dark
  13694. days of Asterisk 1.8.9, blind transferring a call in a context
  13695. that included the 'h' extension would inadvertently execute the
  13696. hangup code logic on the transferred channel. This was a "bad
  13697. thing". The fix was to properly check for the softhangup flags on
  13698. the channel and only execute the 'h' extension logic (and, in
  13699. later versions, hangup handler logic) if the channel was well and
  13700. truly dead (Jim). Unfortunately, CDRs are fickle. Setting the
  13701. softhangup flag when we detected that the channel was leaving the
  13702. bridge (but not to die) caused some crucial snippet of CDR code,
  13703. lying in ambush in the middle of the bridging code, to not get
  13704. executed. This had the effect of blowing away one of the CDRs
  13705. that is typically created during a blind transfer. While we live
  13706. and die by the adage "don't touch CDRs in release branches", this
  13707. was our bad. The attached patch restores the CDR behavior, and
  13708. still manages to not run the 'h' extension during a blind
  13709. transfer (at least not when it's supposed to). Thanks to Steve
  13710. Davies for diagnosing this and providing a fix. Review:
  13711. https://reviewboard.asterisk.org/r/2476 (closes issue
  13712. ASTERISK-21394) Reported by: Ishfaq Malik Tested by: Ishfaq
  13713. Malik, mjordan patches: fix_missing_blindXfer_cdr2 uploaded by
  13714. one47 (License 5012) ........ Merged revisions 387036 from
  13715. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13716. revisions 387038 from
  13717. http://svn.asterisk.org/svn/asterisk/branches/11
  13718. 2013-04-30 22:37 +0000 [r387035-387037] Jonathan Rose <jrose@digium.com>
  13719. * main/event.c, include/asterisk/json.h, channels/chan_iax2.c,
  13720. main/named_acl.c, include/asterisk/acl.h, main/json.c,
  13721. main/manager.c, channels/chan_sip.c,
  13722. include/asterisk/event_defs.h: Stasis Core: Refactor ACL Change
  13723. events to go out over the stasis core msg bus (issue
  13724. ASTERISK-21103) Reported by: Matt Jordan Review:
  13725. https://reviewboard.asterisk.org/r/2481/
  13726. * /, main/event.c: Add forgotten event types to event_names array
  13727. ........ Merged revisions 387030 from
  13728. http://svn.asterisk.org/svn/asterisk/branches/11
  13729. 2013-04-30 18:12 +0000 [r386990] Jason Parker <jparker@digium.com>
  13730. * channels/chan_gulp.c: Fix a log message.
  13731. 2013-04-30 13:48 +0000 [r386931] Sean Bright <sean@malleable.com>
  13732. * include/asterisk/utils.h, /: Use the proper lower bound when
  13733. doing saturation arithmetic. 16 bit signed integers have a range
  13734. of [-32768, 32768). The existing code was using the interval
  13735. (-32768, 32768) instead. This patch fixes that. Review:
  13736. https://reviewboard.asterisk.org/r/2479/ ........ Merged
  13737. revisions 386929 from
  13738. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13739. revisions 386930 from
  13740. http://svn.asterisk.org/svn/asterisk/branches/11
  13741. 2013-04-30 13:37 +0000 [r386928] David M. Lee <dlee@digium.com>
  13742. * tests/test_stasis_http.c, res/res_stasis_http.c: Just a couple of
  13743. Stasis-HTTP nitpick fixes. * Fixed crash when res_stasis_http is
  13744. unloaded before the implementation modules. * Cleaned up test
  13745. initialization for test_stasis_http.so.
  13746. 2013-04-29 23:36 +0000 [r386879] Rusty Newton <rnewton@digium.com>
  13747. * sounds/Makefile, /: Modifying sounds/Makefile to pull down 1.4.24
  13748. core sounds 1.4.24 core sounds includes a full set of Italian
  13749. prompts for core sounds and a fix for the missing voicemail
  13750. prompts in the Russian language. (closes issue ASTERISK-19431)
  13751. (closes issue ASTERISK-19721) ........ Merged revisions 386877
  13752. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  13753. Merged revisions 386878 from
  13754. http://svn.asterisk.org/svn/asterisk/branches/11
  13755. 2013-04-29 13:38 +0000 [r386793-386841] Olle Johansson <oej@edvina.net>
  13756. * /, CHANGES, apps/app_queue.c: Play periodic prompts for first
  13757. call in a call queue Review:
  13758. https://reviewboard.asterisk.org/r/2263/ ........ Merged
  13759. revisions 386792 from
  13760. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13761. revisions 386794 from
  13762. http://svn.asterisk.org/svn/asterisk/branches/11
  13763. * include/asterisk/doxygen/commits.h: Change pointer to existing
  13764. wiki page instead of non-existing page
  13765. 2013-04-28 03:32 +0000 [r386774] Kinsey Moore <kmoore@digium.com>
  13766. * rest-api-templates/swagger_model.py: Fix spelling error in python
  13767. doc
  13768. 2013-04-27 19:03 +0000 [r386731-386760] Joshua Colp <jcolp@digium.com>
  13769. * res/res_sip.c: Tweak res_sip priority so it gets loaded first
  13770. before all other SIP stuff.
  13771. * res/res_config_sqlite.c: Update res_config_sqlite to use the
  13772. ast_variable lists.
  13773. * CHANGES, res/res_config_ldap.c, main/config.c,
  13774. tests/test_sorcery_realtime.c (added), main/sorcery.c,
  13775. res/res_sorcery_realtime.c (added), addons/res_config_mysql.c,
  13776. res/res_config_sqlite3.c, res/res_config_curl.c,
  13777. res/res_config_pgsql.c, res/res_config_odbc.c,
  13778. include/asterisk/config.h: Add support for a realtime sorcery
  13779. module. This change does the following: 1. Adds the sorcery
  13780. realtime module 2. Adds unit tests for the sorcery realtime
  13781. module 3. Changes the realtime core to use an ast_variable list
  13782. instead of variadic arguments 4. Changes all realtime drivers to
  13783. accept an ast_variable list Review:
  13784. https://reviewboard.asterisk.org/r/2424/
  13785. 2013-04-26 21:52 +0000 [r386685-386686] Matthew Jordan <mjordan@digium.com>
  13786. * res/res_sip_nat.c, res/res_sip_registrar.c,
  13787. res/res_sip_dtmf_info.c,
  13788. res/res_sip_outbound_authenticator_digest.c,
  13789. res/res_sip_rfc3326.c, res/res_sip_outbound_registration.c,
  13790. res/res_sip_endpoint_identifier_ip.c,
  13791. res/res_sip_endpoint_identifier_constant.c, res/res_sip_mwi.c,
  13792. res/res_sip_acl.c, res/res_sip_logger.c,
  13793. res/res_sip_endpoint_identifier_user.c, res/res_sip_pubsub.c: Add
  13794. missing module dependencies to various res_sip* modules This
  13795. patch updates the various res_sip modules with their proper
  13796. menuselect options and proper dependencies, such that Asterisk
  13797. still has a snowball's chance in hell of compiling without
  13798. pjproject. Much thanks to snuffy(-home|-work) for making
  13799. everyone's life easier with this patch. Review:
  13800. https://reviewboard.asterisk.org/r/2472/ (closes issue
  13801. ASTERISK-21669) Reported by: snuffy patches: xml-depends.diff
  13802. uploaded by snuffy (license 5024)
  13803. * /, main/config.c: Clean up memory leak in config file on off
  13804. nominal paths when glob is allowed If a system allows for its
  13805. usage, Asterisk will use glob to help parse Asterisk .conf files.
  13806. The config file loading routine was leaking the memory allocated
  13807. by the glob() routine when the config file was in an unmodified
  13808. or invalid state. This patch properly calls globfree in those off
  13809. nominal paths. (closes issue ASTERISK-21412) Reported by: Corey
  13810. Farrell patches: config_glob_leak.patch uploaded by Corey Farrell
  13811. (license 5909) ........ Merged revisions 386672 from
  13812. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13813. revisions 386677 from
  13814. http://svn.asterisk.org/svn/asterisk/branches/11
  13815. 2013-04-26 21:31 +0000 [r386684] David M. Lee <dlee@digium.com>
  13816. * main/loader.c: By popular demand, putting the
  13817. about-to-load-module printf back. But now it only prints during
  13818. the initial startup, and prints at verbose 1 level.
  13819. 2013-04-26 21:27 +0000 [r386676] Matthew Jordan <mjordan@digium.com>
  13820. * /, main/features.c: Clean up resources in features on exit This
  13821. patch cleans up two things features: * It properly unregisters
  13822. the CLI commands that features registered * It cancels and
  13823. performs a pthread_join on the created parking thread. This not
  13824. only properly joins a non-detached thread, but also prevents
  13825. disposing of the parking lots prior to the parking thread
  13826. completely exiting. (closes issue ASTERISK-21407) Reported by:
  13827. Corey Farrell patches: features_shutdown-r2.patch uploaded by
  13828. Corey Farrell (License 5909) ........ Merged revisions 386641
  13829. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  13830. Merged revisions 386642 from
  13831. http://svn.asterisk.org/svn/asterisk/branches/11
  13832. 2013-04-26 21:00 +0000 [r386640] David M. Lee <dlee@digium.com>
  13833. * main/loader.c: Removing stray printf from r386540
  13834. 2013-04-26 20:32 +0000 [r386638] Mark Michelson <mmichelson@digium.com>
  13835. * main/uuid.c: Add an \extref doxygen pointer for libuuid. Thanks
  13836. to Olle Johansson for suggesting this.
  13837. 2013-04-26 20:05 +0000 [r386623-386624] David M. Lee <dlee@digium.com>
  13838. * res/res_chan_stats.c (added), res/res_statsd.exports.in (added),
  13839. configs/statsd.conf.sample (added), include/asterisk/utils.h,
  13840. include/asterisk/statsd.h (added), res/res_statsd.c (added):
  13841. Example of how to use the Stasis message bus In order to get
  13842. people familiar with the Stasis message bus, it would be useful
  13843. to have something of a tutorial. Since I'm not clever enough to
  13844. think of some cool integration we could do with Twitter, I
  13845. settled for something that might actually be useful. This patch
  13846. adds a res_statsd.so module, which implements a basic statsd[1]
  13847. client. Statsd is a very simple statistics gathering server,
  13848. which can publish its results to a backend graphing engine, like
  13849. Graphite[2]. There are several different Statsd server
  13850. implementations[3], so you can pick what works best for your
  13851. environment. The actual example of how to use the Stasis message
  13852. bus is in res_chan_stats.so. This module demonstrates how to use
  13853. subscriptions and the message router by monitoring messages and
  13854. posting channels stats to the statsd server. A wiki page walking
  13855. through res_chan_stats.so is forthcoming. [1]:
  13856. https://github.com/etsy/statsd/ [2]:
  13857. http://graphite.readthedocs.org/en/latest/ [3]:
  13858. http://joemiller.me/2011/09/21/list-of-statsd-server-implementations/
  13859. Review: https://reviewboard.asterisk.org/r/2460/
  13860. * res/res_sip: Ignore *.[oi] files in res/res_sip
  13861. 2013-04-25 21:32 +0000 [r386577] Joshua Colp <jcolp@digium.com>
  13862. * configs/res_sip.conf.sample: Don't bind to anything in the sample
  13863. configuration so we don't clash with chan_sip on a "make samples"
  13864. right now.
  13865. 2013-04-25 18:28 +0000 [r386540-386541] Mark Michelson <mmichelson@digium.com>
  13866. * /: REmove automerge properties.
  13867. * res/res_sip/sip_options.c, res/res_sip_pubsub.exports.in (added),
  13868. res/res_sip_rfc3326.c (added), res/res_sip_mwi.c (added),
  13869. main/sorcery.c, res/res_sip (added),
  13870. include/asterisk/threadpool.h, res/res_sip_registrar.c (added),
  13871. res/res_sip/sip_distributor.c, res/res_sip/config_auth.c,
  13872. include/asterisk/res_sip_session.h (added),
  13873. res/res_sip_endpoint_identifier_ip.c (added), channels/Makefile,
  13874. tests/test_sorcery.c, res/res_sip/config_domain_aliases.c,
  13875. res/res_sip_endpoint_identifier_user.c (added), res/res_sip.c
  13876. (added), include/asterisk/res_sip_pubsub.h (added),
  13877. include/asterisk/sorcery.h,
  13878. res/res_sip_outbound_authenticator_digest.c (added),
  13879. res/res_sip/location.c, res/res_sip_outbound_registration.c
  13880. (added), res/res_sip_endpoint_identifier_constant.c (added),
  13881. res/res_sip_acl.c (added), res/res_sip_pubsub.c (added),
  13882. res/res_sorcery_config.c, res/res_sip/config_transport.c,
  13883. configs/res_sip.conf.sample (added),
  13884. res/res_sip/sip_configuration.c, /,
  13885. include/asterisk/autoconfig.h.in, include/asterisk/res_sip.h
  13886. (added), res/res_sip_dtmf_info.c (added),
  13887. res/res_sip/include/res_sip_private.h, res/res_sip.exports.in
  13888. (added), main/threadpool.c, res/Makefile,
  13889. res/res_sip_authenticator_digest.c (added), main/taskprocessor.c,
  13890. res/res_sip_session.exports.in (added), main/astobj2.c,
  13891. res/res_sip_sdp_rtp.c (added), res/res_sip/sip_outbound_auth.c,
  13892. main/loader.c, channels/chan_gulp.c (added),
  13893. res/res_sip_caller_id.c (added), res/res_sip_logger.c (added),
  13894. res/res_sip/include, res/res_sip_nat.c (added), configure,
  13895. res/res_sip_session.c (added): Merge the pimp_my_sip branch into
  13896. trunk. The pimp_my_sip branch is being merged at this point
  13897. because it offers basic functionality, and from an API
  13898. standpoint, things are complete. SIP work is *not*
  13899. feature-complete; however, with the completion of the
  13900. SUBSCRIBE/NOTIFY API, all APIs (except a PUBLISH API) have been
  13901. created, and thus it is possible for developers to attempt to
  13902. create new SIP work. API documentation can be found in the
  13903. doxygen in the code, but usability documentation is still
  13904. lacking.
  13905. 2013-04-25 03:04 +0000 [r386485-386487] Michael L. Young <elgueromexicano@gmail.com>
  13906. * /, channels/chan_sip.c: Fix Displaying Symmetric RTP Global
  13907. Setting * Use comedia_string() to display correctly the symmetric
  13908. rtp setting when running "sip show settings" ........ Merged
  13909. revisions 386486 from
  13910. http://svn.asterisk.org/svn/asterisk/branches/11
  13911. * /, channels/chan_sip.c: Change Case On Forcerport For Consistency
  13912. * Change "ForcerPort" to "Forcerport" to match everywhere else it
  13913. is displayed ........ Merged revisions 386483 from
  13914. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13915. revisions 386484 from
  13916. http://svn.asterisk.org/svn/asterisk/branches/11
  13917. 2013-04-24 21:47 +0000 [r386461-386462] David M. Lee <dlee@digium.com>
  13918. * res/stasis_http/resource_bridges.h,
  13919. res/stasis_http/resource_recordings.h,
  13920. rest-api-templates/stasis_http_resource.h.mustache,
  13921. res/stasis_http/resource_endpoints.h,
  13922. res/stasis_http/resource_events.h,
  13923. res/stasis_http/resource_asterisk.h,
  13924. res/stasis_http/resource_playback.h,
  13925. res/stasis_http/resource_channels.h,
  13926. res/stasis_http/resource_sounds.h: Document JSON models in
  13927. resource_*.h
  13928. * rest-api-templates/swagger_model.py: Oops. Mustache doesn't like
  13929. dictionaries
  13930. 2013-04-23 20:18 +0000 [r386375] Richard Mudgett <rmudgett@digium.com>
  13931. * apps/confbridge/conf_config_parser.c, apps/app_confbridge.c:
  13932. confbridge: Make search the conference bridges container using
  13933. OBJ_KEY. * Make confbridge config parsing user profile, bridge
  13934. profile, and menu container hash/cmp functions correctly check
  13935. the OBJ_POINTER, OBJ_KEY, and OBJ_PARTIAL_KEY flags. * Made
  13936. confbridge load_module()/unload_module() free all resources on
  13937. failure conditions.
  13938. 2013-04-23 18:57 +0000 [r386352] Kinsey Moore <kmoore@digium.com>
  13939. * res/res_stasis.c: Fix some bad whitespace This crept in with the
  13940. RESTful HTTP interface merge.
  13941. 2013-04-22 16:44 +0000 [r386289] Richard Mudgett <rmudgett@digium.com>
  13942. * main/channel.c, /: Fix crash when AMI redirect action redirects
  13943. two channels out of a bridge. The two party bridging loops were
  13944. changing the bridge peer pointers without the channel locks held.
  13945. Thus when ast_channel_massquerade() tested and used the pointer
  13946. there is a small window of opportunity for the pointers to become
  13947. NULL even though the masquerade code has the channels locked.
  13948. (closes issue ASTERISK-21356) Reported by: William luke Patches:
  13949. jira_asterisk_21356_v11.patch (license #5621) patch uploaded by
  13950. rmudgett Tested by: William luke ........ Merged revisions 386256
  13951. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  13952. Merged revisions 386286 from
  13953. http://svn.asterisk.org/svn/asterisk/branches/11
  13954. 2013-04-22 16:22 +0000 [r386266] Andrew Latham <lathama@gmail.com>
  13955. * include/asterisk/srv.h: Doxygen - Markup Guidelines Expand on a
  13956. commit by OEJ to use the Coding-Guidelines (issue ASTERISK-20259)
  13957. 2013-04-22 14:58 +0000 [r386232] David M. Lee <dlee@digium.com>
  13958. * res/stasis_http/resource_channels.c, res/res_stasis_http_sounds.c
  13959. (added), rest-api (added), main/http.c,
  13960. res/res_stasis_http_bridges.c (added), tests/test_stasis_http.c
  13961. (added), include/asterisk/strings.h, res/res_stasis_http.c
  13962. (added), tests/test_stasis.c, res/res_stasis.c,
  13963. res/res_stasis_http_asterisk.c (added),
  13964. res/res_stasis_http_playback.c (added), res/stasis_http (added),
  13965. configs/stasis_http.conf.sample (added),
  13966. include/asterisk/stasis_http.h (added),
  13967. res/res_stasis_http_channels.c (added),
  13968. include/asterisk/stasis_app.h, res/Makefile,
  13969. include/asterisk/json.h, res/res_stasis_http_recordings.c
  13970. (added), res/stasis_http.make (added), tests/test_strings.c,
  13971. res/res_stasis_http_endpoints.c (added),
  13972. res/res_stasis_http_events.c (added), include/asterisk/http.h,
  13973. Makefile, main/json.c, res/res_stasis_http.exports.in (added),
  13974. rest-api-templates (added): This patch adds a RESTful HTTP
  13975. interface to Asterisk. The API itself is documented using
  13976. Swagger, a lightweight mechanism for documenting RESTful API's
  13977. using JSON. This allows us to use swagger-ui to provide
  13978. executable documentation for the API, generate client bindings in
  13979. different languages, and generate a lot of the boilerplate code
  13980. for implementing the RESTful bindings. The API docs live in the
  13981. rest-api/ directory. The RESTful bindings are generated from the
  13982. Swagger API docs using a set of Mustache templates. The code
  13983. generator is written in Python, and uses Pystache. Pystache has
  13984. no dependencies, and be installed easily using pip. Code
  13985. generation code lives in rest-api-templates/. The generated code
  13986. reduces a lot of boilerplate when it comes to handling HTTP
  13987. requests. It also helps us have greater consistency in the REST
  13988. API. (closes issue ASTERISK-20891) Review:
  13989. https://reviewboard.asterisk.org/r/2376/
  13990. 2013-04-22 12:45 +0000 [r386211] Olle Johansson <oej@edvina.net>
  13991. * include/asterisk/srv.h: Fix mistake in Doxygen. Doxygen is only
  13992. *ONE* comment that applies to the NEXT piece of code.
  13993. 2013-04-22 01:05 +0000 [r386190] Russell Bryant <russell@russellbryant.com>
  13994. * apps/app_meetme.c: sla: remove redundant locking. sla.lock was
  13995. already locked in the only place that sla_check_reload() was
  13996. called. Remove the redundant locking of sla.lock done in this
  13997. function. Less recursive locking is A Good Thing.
  13998. 2013-04-19 22:27 +0000 [r386160] Matthew Jordan <mjordan@digium.com>
  13999. * /, res/res_timing_pthread.c: Prevent res_timing_pthread from
  14000. blocking callers There were several reports of deadlock when
  14001. using res_timing_pthread. Backtraces indicated that one thread
  14002. was blocked waiting for the write to the pipe to complete and
  14003. this thread held the container lock for the timers. Therefore any
  14004. thread that wanted to create a new timer or read an existing
  14005. timer would block waiting for either the timer lock or the
  14006. container lock and deadlock ensued. This patch changes the way
  14007. the pipe is used to eliminate this source of deadlocks: 1) The
  14008. pipe is placed in non-blocking mode so that it would never block
  14009. even if the following changes someone fail... 2) Instead of
  14010. writing bytes into the pipe for each "tick" that's fired the pipe
  14011. now has two states--signaled and unsignaled. If signaled, the
  14012. pipe is hot and any pollers of the read side filedescriptor will
  14013. be woken up. If unsigned the pipe is idle. This eliminates even
  14014. the chance of filling up the pipe and reduces the potential
  14015. overhead of calling unnecessary writes. 3) Since we're tracking
  14016. the signaled / unsignaled state, we can eliminate the exta poll
  14017. system call for every firing because we know that there is data
  14018. to be read. (closes issue ASTERISK-21389) Reported by: Matt
  14019. Jordan Tested by: Shaun Ruffell, Matt Jordan, Tony Lewis patches:
  14020. 0001-res_timing_pthread-Reduce-probability-of-deadlocking.patch
  14021. uploaded by sruffell (License 5417) (closes issue ASTERISK-19754)
  14022. Reported by: Nikola Ciprich (closes issue ASTERISK-20577)
  14023. Reported by: Kien Kennedy (closes issue ASTERISK-17436) Reported
  14024. by: Henry Fernandes (closes issue ASTERISK-17467) Reported by:
  14025. isrl (closes issue ASTERISK-17458) Reported by: isrl Review:
  14026. https://reviewboard.asterisk.org/r/2441/ ........ Merged
  14027. revisions 386109 from
  14028. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14029. revisions 386159 from
  14030. http://svn.asterisk.org/svn/asterisk/branches/11
  14031. 2013-04-19 05:20 +0000 [r386019-386054] David M. Lee <dlee@digium.com>
  14032. * main/cli.c, /: cli.c: Properly initialize debug_modules and
  14033. verbose_modules. This avoids some lock errors on the core set
  14034. {debug,verbose} commands. ........ Merged revisions 386049 from
  14035. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14036. revisions 386051 from
  14037. http://svn.asterisk.org/svn/asterisk/branches/11
  14038. * res/res_http_websocket.c, include/asterisk/http_websocket.h:
  14039. Allow WebSocket connections on more URL's This patch adds the
  14040. concept of ast_websocket_server to res_http_websocket, allowing
  14041. WebSocket connections on URL's more more than /ws. The existing
  14042. funcitons for managing the WebSocket subprotocols on /ws still
  14043. work, so this patch should be completely backward compatible.
  14044. (closes issue ASTERISK-21279) Review:
  14045. https://reviewboard.asterisk.org/r/2453/
  14046. * main/message.c, /: Fix lock errors on startup. In messages.c,
  14047. there are several places in the code where we create a
  14048. tmp_tech_holder and pass that into an ao2_find call.
  14049. Unfortunately, we weren't initializing the rwlock on the
  14050. tmp_tech_holder, which the hash function was locking. It's
  14051. apparently harmless, but still not the best code. This patch
  14052. extracts all that copy/pasted code into two functions,
  14053. msg_find_by_tech and msg_find_by_tech_name, which properly
  14054. initialize and destroy the rwlock on the tmp_tech_holder. Review:
  14055. https://reviewboard.asterisk.org/r/2454/ ........ Merged
  14056. revisions 386006 from
  14057. http://svn.asterisk.org/svn/asterisk/branches/11
  14058. 2013-04-16 23:44 +0000 [r385939] Alec L Davis <sivad.a@paradise.net.nz>
  14059. * res/res_xmpp.c, res/res_jabber.c, /: res_xmpp and res_jabber need
  14060. to search 'cachable' in the attrib section of the received IE,
  14061. not data. (issue ASTERISK-20175) (closes issue ASTERISK-21429)
  14062. (closes issue ASTERISK-21069) (closes issue ASTERISK-21164)
  14063. Reported by: alecdavis Tested by: alecdavis alecdavis (license
  14064. 585) Review https://reviewboard.asterisk.org/r/2452/
  14065. 2013-04-16 17:50 +0000 [r385860-385886] Kinsey Moore <kmoore@digium.com>
  14066. * res/res_corosync.c: Allow res_corosync to build
  14067. ast_enable_distributed_devstate is no longer applicable to how
  14068. the distributed device state system works and is no longer
  14069. necessary.
  14070. * main/pbx.c, funcs/func_presencestate.c,
  14071. include/asterisk/presencestate.h, main/presencestate.c: Move
  14072. presence state distribution to Stasis-core Convert presence state
  14073. events to Stasis-core messages and remove redundant serializers
  14074. where possible. Review: https://reviewboard.asterisk.org/r/2410/
  14075. (closes issue ASTERISK-21102) Patch-by: Kinsey Moore
  14076. <kmoore@digium.com>
  14077. * include/asterisk/devicestate.h, main/pbx.c, main/ccss.c,
  14078. include/asterisk/xmpp.h, tests/test_devicestate.c,
  14079. main/devicestate.c, res/res_xmpp.c, apps/app_queue.c,
  14080. res/res_jabber.c, main/asterisk.c: Move device state distribution
  14081. to Stasis-core In the move from Asterisk's event system to
  14082. Stasis, this makes distributed device state aggregation
  14083. always-on, removes unnecessary task processors where possible,
  14084. and collapses aggregate and non-aggregate states into a single
  14085. cache for ease of retrieval. This also removes an intermediary
  14086. step in device state aggregation. Review:
  14087. https://reviewboard.asterisk.org/r/2389/ (closes issue
  14088. ASTERISK-21101) Patch-by: Kinsey Moore <kmoore@digium.com>
  14089. 2013-04-16 14:09 +0000 [r385835] David M. Lee <dlee@digium.com>
  14090. * include/asterisk/stasis_channels.h: Fixed a typo
  14091. 2013-04-15 17:26 +0000 [r385782] Jason Parker <jparker@digium.com>
  14092. * Makefile, /: Don't unnecessarily rebuild things on every run of
  14093. 'make'. Review: https://reviewboard.asterisk.org/r/2449/ ........
  14094. Merged revisions 385745 from
  14095. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14096. revisions 385768 from
  14097. http://svn.asterisk.org/svn/asterisk/branches/11
  14098. 2013-04-15 16:47 +0000 [r385718-385743] David M. Lee <dlee@digium.com>
  14099. * res/res_stasis_websocket.c: Avoid unused variable warning when
  14100. not in devmode
  14101. * main/json.c, include/asterisk/stasis_channels.h,
  14102. res/res_stasis.exports.in (added), apps/Makefile,
  14103. apps/app_stasis.exports.in (removed), apps/stasis_json.c
  14104. (removed), main/stasis_channels.c, tests/test_app_stasis.c
  14105. (removed), res/res_stasis.c (added), main/manager_channels.c,
  14106. apps/app_stasis.c, tests/test_json.c, res/res_stasis_websocket.c,
  14107. tests/test_res_stasis.c (added), tests/test_stasis_channels.c,
  14108. include/asterisk/app_stasis.h (removed),
  14109. include/asterisk/stasis_app.h (added), include/asterisk/json.h:
  14110. Moved core logic from app_stasis to res_stasis After some
  14111. discussion on asterisk-dev, it was decided that the bulk of the
  14112. logic in app_stasis actually belongs in a resource module instead
  14113. of the application module. This patch does that, leaves the app
  14114. specific stuff in app_stasis, and fixes up everything else to be
  14115. consistent with that change. * Renamed test_app_stasis to
  14116. test_res_stasis * Renamed app_stasis.h to stasis_app.h * This is
  14117. still stasis application support, even though it's no longer in
  14118. an app_ module. The name should never have been tied to the type
  14119. of module, anyways. * Now that json isn't a resource module
  14120. anymore, moved the ast_channel_snapshot_to_json function to
  14121. main/stasis_channels.c, where it makes more sense. Review:
  14122. https://reviewboard.asterisk.org/r/2430/
  14123. * apps/app_stasis.c, main/manager_channels.c, main/channel.c,
  14124. include/asterisk/cli.h, include/asterisk/strings.h: DTMF events
  14125. are now published on a channel's stasis_topic. AMI was refactored
  14126. to use these events rather than producing the events directly in
  14127. channel.c. Finally, the code was added to app_stasis to produce
  14128. DTMF events on the WebSocket. The AMI events are completely
  14129. backward compatible, including sending events on transmitted
  14130. DTMF, and sending DTMF start events. The Stasis-HTTP events are
  14131. somewhat simplified. Since DTMF start and DTMF send events are
  14132. generally less useful, Stasis-HTTP will only send events on
  14133. received DTMF end. (closes issue ASTERISK-21282) (closes issue
  14134. ASTERISK-21359) Review: https://reviewboard.asterisk.org/r/2439
  14135. * apps/app_saycounted.c, channels/sip/security_events.c,
  14136. contrib/realtime/mysql/voicemail_messages.sql, BSDmakefile,
  14137. contrib/realtime/mysql/voicemail_data.sql,
  14138. build_tools/sha1sum-sh, res/res_mutestream.c,
  14139. configs/res_curl.conf.sample, tests/test_func_file.c,
  14140. res/res_rtp_multicast.c, include/asterisk/select.h,
  14141. include/asterisk/bridging_technology.h,
  14142. include/asterisk/bridging_features.h, tests/test_locale.c,
  14143. doc/Makefile, tests/test_poll.c,
  14144. contrib/realtime/mysql/musiconhold.sql, res/res_timing_kqueue.c,
  14145. contrib/realtime/mysql/queue_log.sql,
  14146. channels/sip/include/security_events.h, channels/sig_ss7.c,
  14147. channels/chan_multicast_rtp.c, channels/sig_ss7.h, /,
  14148. tests/test_expr.c: Fix the svn:keywords property on several
  14149. files. Normally I think keyword expansion is silly, but the one
  14150. time it would have been good, it didn't work because the property
  14151. had quotes in it. This patch fixes obviously busted svn:keywords
  14152. properties. ........ Merged revisions 385683 from
  14153. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14154. revisions 385689 from
  14155. http://svn.asterisk.org/svn/asterisk/branches/11
  14156. 2013-04-14 03:01 +0000 [r385635-385638] Matthew Jordan <mjordan@digium.com>
  14157. * res/res_rtp_multicast.c, /: Calculate the timestamp for outbound
  14158. RTP if we don't have timing information This patch calculates the
  14159. timestamp for outbound RTP when we don't have timing information.
  14160. This uses the same approach in res_rtp_asterisk. Thanks to both
  14161. Pietro and Tzafrir for providing patches. (closes issue
  14162. ASTERISK-19883) Reported by: Giacomo Trovato Tested by: Pietro
  14163. Bertera, Tzafrir Cohen patches: rtp-timestamp-1.8.patch uploaded
  14164. by tzafrir (License 5035) rtp-timestamp.patch uploaded by
  14165. pbertera (License 5943) ........ Merged revisions 385636 from
  14166. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14167. revisions 385637 from
  14168. http://svn.asterisk.org/svn/asterisk/branches/11
  14169. * /, channels/chan_alsa.c: Don't attempt to create a voice frame on
  14170. a read error Prior to this patch, a read error in snd_pcm_readi
  14171. would still be treated as a nominal result when constructing a
  14172. voice frame from the expected data. Since the value returned is
  14173. negative, as opposed to the number of samples read, this could
  14174. result in a crash. With this patch, we now return a null frame
  14175. when a read error is detected. Note that the patch on
  14176. ASTERISK-21329 was modified slightly for this commit, in that we
  14177. bail immediately on detecting the read error, rather than
  14178. bypassing the construction of the voice frame. (closes issue
  14179. ASTERISK-21329) Reported by: Keiichiro Kawasaki patches:
  14180. chan_alsa.diff uploaded by kawasaki (License 6489) ........
  14181. Merged revisions 385633 from
  14182. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14183. revisions 385634 from
  14184. http://svn.asterisk.org/svn/asterisk/branches/11
  14185. 2013-04-12 22:38 +0000 [r385595] Michael L. Young <elgueromexicano@gmail.com>
  14186. * /, apps/app_queue.c: Fix Manager Segfault When app_queue Is
  14187. Unloaded When app_queue is unloaded, some manager commands are
  14188. not being unregistered which result in a segfault. This patch
  14189. corrects this. (closes issue ASTERISK-21397) Reported by: Peter
  14190. Katzmann, Corey Farrell Tested by: Corey Farrell Patches:
  14191. asterisk-21397-missing-unreg-manager-cmd_1.8.diff Michael L.
  14192. Young (license 5026)
  14193. asterisk-21397-missing-unreg-manager-cmd_11.diff Michael L. Young
  14194. (license 5026) Review: https://reviewboard.asterisk.org/r/2444/
  14195. ........ Merged revisions 385593 from
  14196. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14197. revisions 385594 from
  14198. http://svn.asterisk.org/svn/asterisk/branches/11
  14199. 2013-04-12 22:26 +0000 [r385585] Kinsey Moore <kmoore@digium.com>
  14200. * /, codecs/codec_resample.c: Allow codec_resample to be unloaded
  14201. Ensure that trans_size is correct to prevent uninitialized
  14202. entries from preventing reload. (closes issue ASTERISK-21401)
  14203. Reported by: Corey Farrell Tested by: Corey Farrell Patches:
  14204. codec_resample-unload.patch uploaded by Corey Farrell ........
  14205. Merged revisions 385582 from
  14206. http://svn.asterisk.org/svn/asterisk/branches/11
  14207. 2013-04-12 22:22 +0000 [r385573] Michael L. Young <elgueromexicano@gmail.com>
  14208. * apps/app_voicemail.c, /: Fix app_voicemail Segfault And A Few
  14209. Memory Leaks The original report was that app_voicemail would
  14210. crash. This was caused by ast_config_load() returning
  14211. CONFIG_STATUS_FILEINVALID but no checks being performed for that
  14212. return status. After adding the initial patch to fix this issue,
  14213. Jaco Kroon (jkroon) added some fixes to memory leaks he had
  14214. discovered. During review, Walter Doekes (wdoekes) suggested
  14215. adding a helper function in order to determine if we had a valid
  14216. configuration or not. This patch does the following: * Creates a
  14217. helper function to check if the configuration is valid * Adds
  14218. calls to the new helper function where appropiate * Fixes memory
  14219. leaks where the code returned without running
  14220. ast_config_destroy() on the configuration that was loaded (closes
  14221. issue ASTERISK-21302) Reported by: Jaco Kroon Tested by: Jaco
  14222. Kroon, Michael L. Young Patches:
  14223. asterisk-11.3.0-app_voicemail-ast_config-fixes.patch Jaco Kroon
  14224. (license 5671) asterisk-21302-valid_cfg_and_mem_leaks_v3-1.8.diff
  14225. Michael L. Young (license 5026) Review:
  14226. https://reviewboard.asterisk.org/r/2443/ ........ Merged
  14227. revisions 385551 from
  14228. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14229. revisions 385557 from
  14230. http://svn.asterisk.org/svn/asterisk/branches/11
  14231. 2013-04-12 21:48 +0000 [r385548] Jason Parker <jparker@digium.com>
  14232. * include/asterisk/sorcery.h: Fix documentation.
  14233. 2013-04-12 21:11 +0000 [r385522] Kinsey Moore <kmoore@digium.com>
  14234. * include/asterisk/manager.h, main/manager_channels.c: Expose
  14235. channel snapshot manager blob generation These functions are
  14236. already used in one branch (jrose's parking branch) and will soon
  14237. be used in other branches as well.
  14238. 2013-04-12 15:06 +0000 [r385474] Michael L. Young <elgueromexicano@gmail.com>
  14239. * /, channels/chan_sip.c: Fix One-Way Audio With auto_* NAT
  14240. Settings When SIP Calls Initiated By PBX When we reload Asterisk
  14241. or chan_sip, the flags force_rport and comedia that are turned on
  14242. and off when using the auto_force_rport and auto_comedia nat
  14243. settings go back to the default setting off. These flags are
  14244. turned on when needed or off when not needed at the time that a
  14245. peer registers, re-registers or initiates a call. This would
  14246. apply even when only the default global setting
  14247. "nat=auto_force_rport" is being used, which in this case would
  14248. only affect the force_rport flag. Everything is good except for
  14249. the following: The nat setting is set to auto_force_rport and
  14250. auto_comedia. We reload Asterisk and the peer's registration has
  14251. not expired. We load in the settings for the peer which turns
  14252. force_rport and comedia back to off. Since the peer has not
  14253. re-registered or placed a call yet, those flags remain off. We
  14254. then initiate a call to the peer from the PBX. The force_rport
  14255. and comedia flags stay off. If NAT is involved, we end up with
  14256. one-way audio since we never checked to see if the peer is behind
  14257. NAT or not. This patch does the following: * Moves the checking
  14258. of whether a peer is behind NAT into its own function * Create a
  14259. function to set the peer's NAT flags if they are using the auto_*
  14260. NAT settings * Adds calls in sip_request_call() to these new
  14261. functions in order to setup the dialog according to the peer's
  14262. settings (closes issue ASTERISK-21374) Reported by: Michael L.
  14263. Young Tested by: Michael L. Young Patches:
  14264. asterisk-21374-auto-nat-outgoing-fix_v2.diff Michael L. Young
  14265. (license 5026) Review: https://reviewboard.asterisk.org/r/2421/
  14266. ........ Merged revisions 385473 from
  14267. http://svn.asterisk.org/svn/asterisk/branches/11
  14268. 2013-04-12 08:52 +0000 [r385406-385431] Alec L Davis <sivad.a@paradise.net.nz>
  14269. * channels/chan_iax2.c, /: IAX2 defer_full_frames fail to get sent
  14270. Ensure iax2_process_thread is signalled when a deferred frame is
  14271. queued to it. (closes issue ASTERISK-18827) Reported by:
  14272. alecdavis Tested by: alecdavis alecdavis (license 585) Review
  14273. https://reviewboard.asterisk.org/r/2426/ ........ Merged
  14274. revisions 385429 from
  14275. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14276. revisions 385430 from
  14277. http://svn.asterisk.org/svn/asterisk/branches/11
  14278. * /, channels/chan_iax2.c: IAX2, prevent network thread starting
  14279. before all helper threads are ready On startup, it's possible for
  14280. a frame to arrive before the processing threads were ready. In
  14281. iax2_process_thread() the first pass through falls into
  14282. ast_cond_wait, should a frame arrive before we are at
  14283. ast_cond_wait, the signal will be ignored. The result
  14284. iax2_process_thread stays at ast_cond_wait forever, with deferred
  14285. frames being queued. Fix: When creating initial idle
  14286. iax2_process_threads, wait for init_cond to be signalled after
  14287. each thread is started. (issue ASTERISK-18827) Reported by:
  14288. alecdavis Tested by: alecdavis alecdavis (license 585) Review
  14289. https://reviewboard.asterisk.org/r/2427/ ........ Merged
  14290. revisions 385402 from
  14291. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14292. revisions 385403 from
  14293. http://svn.asterisk.org/svn/asterisk/branches/11
  14294. 2013-04-11 16:53 +0000 [r385277-385314] Richard Mudgett <rmudgett@digium.com>
  14295. * /, configs/cli_aliases.conf.sample: Fix 'pri intense debug span'
  14296. alias. ........ Merged revisions 385313 from
  14297. http://svn.asterisk.org/svn/asterisk/branches/11
  14298. * main/features.c: Eliminated dial_features_destroy() since it is
  14299. equivalent to ast_free_ptr()
  14300. * main/manager.c, main/features.c: * Fix unlocked accesses to
  14301. feature_list. The feature_list is now also protected by the
  14302. features_lock. * Made all calls to ast_find_call_feature() have
  14303. the features_lock held. * Fixed set_config_flags() to actually
  14304. use find_group() to look for feature groups in DYNAMIC_FEATURES.
  14305. The code originally assumed all feature groups were listed in
  14306. DYNAMIC_FEATURES. * Make everyone use ast_rdlock_call_features(),
  14307. ast_unlock_call_features(), and new ast_wrlock_call_features()
  14308. instead of directly calling the rwlock API on features_lock.
  14309. 2013-04-10 15:34 +0000 [r385236] David M. Lee <dlee@digium.com>
  14310. * main/stasis_channels.c: Fixed manager channelvars support. For
  14311. the events that have been ported to Stasis, this was broken in
  14312. r384910, when a couple of lines of code was lost in a merge.
  14313. 2013-04-10 14:26 +0000 [r385174-385202] Matthew Jordan <mjordan@digium.com>
  14314. * /, res/res_config_ldap.c: Use LDAP memory management functions
  14315. instead of Asterisk's When MALLOC_DEBUG is enabled with
  14316. res_config_ldap, issues (munmap_chunk: invalid pointer errors)
  14317. can occur as the memory is being allocated with Asterisk's
  14318. wrappers around malloc/calloc/free/strdup, as opposed to the LDAP
  14319. library's wrappers. This patch uses the LDAP library's wrappers
  14320. where appropriate, so that compiling with MALLOC_DEBUG doesn't
  14321. cause more problems than it solves. Note that the patch listed
  14322. below was modified slightly for this commit to account for some
  14323. additional memory allocation/deallocations. (closes issue
  14324. ASTERISK-17386) Reported by: John Covert Tested by: Andrew Latham
  14325. patches: issue18789-1.8-r316873.patch uploaded by seanbright
  14326. (License 5060) ........ Merged revisions 385190 from
  14327. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14328. revisions 385199 from
  14329. http://svn.asterisk.org/svn/asterisk/branches/11
  14330. * /, channels/chan_sip.c: Fix crash in chan_sip when a core
  14331. initiated op occurs at the same time as a BYE When a BYE request
  14332. is processed in chan_sip, the current SIP dialog is detached from
  14333. its associated Asterisk channel structure. The tech_pvt pointer
  14334. in the channel object is set to NULL, and the dialog persists for
  14335. an RFC mandated period of time to handle re-transmits. While this
  14336. process occurs, the channel is locked (which is good).
  14337. Unfortunately, operations that are initiated externally have no
  14338. way of knowing that the channel they've just obtained (which is
  14339. still valid) and that they are attempting to lock is about to
  14340. have its tech_pvt pointer removed. By the time they obtain the
  14341. channel lock and call the channel technology callback, the
  14342. tech_pvt is NULL. This patch adds a few checks to some channel
  14343. callbacks that make sure the tech_pvt isn't NULL before using it.
  14344. Prime offenders were the DTMF digit callbacks, which would crash
  14345. if AMI initiated a DTMF on the channel at the same time as a BYE
  14346. was received from the UA. This patch also adds checks on
  14347. sip_transfer (as AMI can also cause a callback into this
  14348. function), as well as sip_indicate (as lots of things can queue
  14349. an indication onto a channel). Review:
  14350. https://reviewboard.asterisk.org/r/2434/ (closes issue
  14351. ASTERISK-20225) Reported by: Jeff Hoppe ........ Merged revisions
  14352. 385170 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  14353. ........ Merged revisions 385173 from
  14354. http://svn.asterisk.org/svn/asterisk/branches/11
  14355. 2013-04-09 19:58 +0000 [r385142] Richard Mudgett <rmudgett@digium.com>
  14356. * main/features.c: Rename struct feature_ds to struct
  14357. feature_datastore. Because "struct feature_ds *feature_ds" is not
  14358. a good thing.
  14359. 2013-04-09 18:22 +0000 [r385116] David M. Lee <dlee@digium.com>
  14360. * apps/app_stasis.c: Backported app_stasis fix from stasis-http
  14361. branch. The hash and compare functions for the control container
  14362. was reusing the wrong ones, causing some problems. I fixed it,
  14363. but in the wrong branch. Oh well, it happens.
  14364. 2013-04-09 06:16 +0000 [r385088] Russell Bryant <russell@russellbryant.com>
  14365. * main/features.c, CHANGES: Add inheritance support to
  14366. FEATURE()/FEATUREMAP(). The settings saved on the channel for
  14367. FEATURE()/FEATUREMAP() were only for that channel. This patch
  14368. adds the ability to have these settings inherited to child
  14369. channels if you set FEATURE(inherit)=yes. Closes issue
  14370. ASTERISK-21306. Review: https://reviewboard.asterisk.org/r/2415/
  14371. 2013-04-08 23:38 +0000 [r385049] Rusty Newton <rnewton@digium.com>
  14372. * /, configs/extconfig.conf.sample: Modified the list of keys for
  14373. the driver backends for sake of sample clarity Added a line
  14374. showing the mapping of "mysql" to res_config_mysql available in
  14375. add-ons. We used "mysql" as an example driver key in the sample,
  14376. but didn't show what module it mapped too. Also added a subtitle
  14377. above the list of keys for driver backends. ........ Merged
  14378. revisions 385047 from
  14379. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14380. revisions 385048 from
  14381. http://svn.asterisk.org/svn/asterisk/branches/11
  14382. 2013-04-08 18:24 +0000 [r384989] Walter Doekes <walter+asterisk@wjd.nu>
  14383. * build_tools/make_buildopts_h,
  14384. build_tools/make_linker_version_script, Makefile,
  14385. build_tools/mkpkgconfig, build_tools/make_version: Clean up
  14386. Makefile "warning" clutter when makeopts doesn't exist. Review:
  14387. https://reviewboard.asterisk.org/r/2304
  14388. 2013-04-08 15:38 +0000 [r384910-384942] Matthew Jordan <mjordan@digium.com>
  14389. * res/res_http_websocket.c, res/res_stasis_websocket.c: Don't
  14390. attempt a websocket protocol removal if res_http_websocket isn't
  14391. there This patch sets the protocols container provided by
  14392. res_http_websocket to NULL when the module gets unloaded and adds
  14393. the necessary checks when adding/ removing a websocket protocol.
  14394. This prevents some FRACKing on an invalid pointer to the disposed
  14395. container if a module that uses res_http_websocket is unloaded
  14396. after it.
  14397. * apps/app_stasis.c, main/manager_channels.c, apps/app_dial.c,
  14398. main/pbx.c, main/channel_internal_api.c,
  14399. tests/test_stasis_channels.c (added),
  14400. include/asterisk/app_stasis.h, apps/app_userevent.c,
  14401. include/asterisk/channel.h, CHANGES, main/channel.c, main/dial.c,
  14402. include/asterisk/stasis_channels.h (added), main/features.c,
  14403. apps/stasis_json.c, pbx/pbx_realtime.c, main/stasis_channels.c
  14404. (added): Add multi-channel Stasis messages; refactor Dial AMI
  14405. events to Stasis This patch does the following: * A new Stasis
  14406. payload has been defined for multi-channel messages. This payload
  14407. can store multiple ast_channel_snapshot objects along with a
  14408. single JSON blob. The payload object itself is opaque; the
  14409. snapshots are stored in a container keyed by roles. APIs have
  14410. been provided to query for and retrieve the snapshots from the
  14411. payload object. * The Dial AMI events have been refactored onto
  14412. Stasis. This includes dial messages in app_dial, as well as the
  14413. core dialing framework. The AMI events have been modified to send
  14414. out a DialBegin/DialEnd events, as opposed to the subevent type
  14415. that was previously used. * Stasis messages, types, and other
  14416. objects related to channels have been placed in their own file,
  14417. stasis_channels. Unit tests for some of these objects/messages
  14418. have also been written.
  14419. 2013-04-08 13:27 +0000 [r384879] David M. Lee <dlee@digium.com>
  14420. * main/json.c, res/res_stasis_websocket.c (added), main/frame.c,
  14421. apps/Makefile, tests/test_abstract_jb.c,
  14422. apps/app_stasis.exports.in (added), apps/stasis_json.c (added),
  14423. include/asterisk/app_stasis.h (added), include/asterisk/json.h,
  14424. include/asterisk/localtime.h, tests/test_app_stasis.c (added),
  14425. include/asterisk/frame.h, apps/app_stasis.c (added),
  14426. tests/test_json.c: Stasis application WebSocket support This is
  14427. the API that binds the Stasis dialplan application to external
  14428. Stasis applications. It also adds the beginnings of WebSocket
  14429. application support. This module registers a dialplan function
  14430. named Stasis, which is used to put a channel into the named
  14431. Stasis app. As a channel enters and leaves the Stasis diaplan
  14432. application, the Stasis app receives a 'stasis-start' and
  14433. 'stasis-end' events. Stasis apps register themselves using the
  14434. stasis_app_register and stasis_app_unregister functions. Messages
  14435. are sent to an application using stasis_app_send. Finally, Stasis
  14436. apps control channels through the use of the stasis_app_control
  14437. object, and the family of stasis_app_control_* functions. Other
  14438. changes along for the ride are: * An ast_frame_dtor function
  14439. that's RAII_VAR safe * Some common JSON encoders for name/number,
  14440. timeval, and context/extension/priority Review:
  14441. https://reviewboard.asterisk.org/r/2361/
  14442. 2013-04-06 16:00 +0000 [r384857] Joshua Colp <jcolp@digium.com>
  14443. * tests/test_sorcery_astdb.c (added), res/res_sorcery_astdb.c
  14444. (added): Add a res_sorcery_astdb module which uses the astdb to
  14445. persist objects. Review: https://reviewboard.asterisk.org/r/2420/
  14446. 2013-04-05 20:41 +0000 [r384828] Michael L. Young <elgueromexicano@gmail.com>
  14447. * /, channels/chan_sip.c, UPGRADE-11.txt: Fix For Not Overriding
  14448. The Default Settings In chan_sip The initial report was that the
  14449. "nat" setting in the [general] section was not having any effect
  14450. in overriding the default setting. Upon confirming that this was
  14451. happening and looking into what was causing this, it was
  14452. discovered that other default settings would not be overriden as
  14453. well. This patch works similar to what occurs in build_peer(). We
  14454. create a temporary ast_flags structure and using a mask, we
  14455. override the default settings with whatever is set in the
  14456. [general] section. In the bug report, the reporter who helped to
  14457. test this patch noted that the directmedia settings were being
  14458. overriden properly as well as the nat settings. This issue is
  14459. also present in Asterisk 1.8 and a separate patch will be applied
  14460. to it. (issue ASTERISK-21225) Reported by: Alexandre Vezina
  14461. Tested by: Alexandre Vezina, Michael L. Young Patches:
  14462. asterisk-21225-handle-options-default-prob_v4.diff Michael L.
  14463. Young (license 5026) Review:
  14464. https://reviewboard.asterisk.org/r/2385/ ........ Merged
  14465. revisions 384827 from
  14466. http://svn.asterisk.org/svn/asterisk/branches/11
  14467. 2013-04-04 18:15 +0000 [r384696-384760] Richard Mudgett <rmudgett@digium.com>
  14468. * main/event.c: Separate some event struct definitions from
  14469. instantiation.
  14470. * channels/chan_dahdi.c, configs/chan_dahdi.conf.sample,
  14471. UPGRADE.txt: chan_dahdi: Change inband_on_proceeding option
  14472. default to no/disabled. (issue ASTERISK-21151)
  14473. * channels/sig_pri.h, channels/chan_dahdi.c,
  14474. configs/chan_dahdi.conf.sample, /, channels/sig_pri.c:
  14475. chan_dahdi: Add inband_on_proceeding compatibility option. The
  14476. new inband_on_proceeding option causes Asterisk to assume inband
  14477. audio may be present when a PROCEEDING message is received. Q.931
  14478. Section 5.1.2 says the network cannot assume that the CPE side
  14479. has attached to the B channel at this time without explicitly
  14480. sending the progress indicator ie informing the CPE side to
  14481. attach to the B channel for audio. However, some non-compliant
  14482. ISDN switches send a PROCEEDING without the progress indicator ie
  14483. indicating inband audio is available and assume that the CPE
  14484. device has connected the media path for listening to ringback and
  14485. other messages. ASTERISK-17834 which causes this issue was
  14486. dealing with a non-compliant network switch. (closes issue
  14487. ASTERISK-21151) Reported by: Gianluca Merlo Tested by: rmudgett
  14488. ........ Merged revisions 384685 from
  14489. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14490. revisions 384689 from
  14491. http://svn.asterisk.org/svn/asterisk/branches/11
  14492. 2013-04-03 17:17 +0000 [r384642] Matthew Jordan <mjordan@digium.com>
  14493. * funcs/func_channel.c, /: Update documentation for CHANNEL
  14494. function Document that you can read/write the 'accountcode' and
  14495. 'amaflags' on a channel. ........ Merged revisions 384640 from
  14496. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14497. revisions 384641 from
  14498. http://svn.asterisk.org/svn/asterisk/branches/11
  14499. 2013-04-03 16:01 +0000 [r384616] Richard Mudgett <rmudgett@digium.com>
  14500. * main/astobj2.c: astobj2: Fix rbtree duplicate handling.
  14501. OBJ_PARTIAL_KEY searching a rbtree did not find all possible
  14502. matches if the container did not accept duplicates. Added
  14503. matching node bias to indicate which matching node is being
  14504. searched for: first, last, any.
  14505. 2013-04-02 17:35 +0000 [r384546] David M. Lee <dlee@digium.com>
  14506. * Makefile, /: Fixed spurious rebuilds of func_version.
  14507. func_version.so was being rebuilt every time, because build.h was
  14508. changing every build, because of the cleantest dependency that
  14509. was added in r384410 to fix parallel make bugs. Now build.h will
  14510. only be created if it does not exist, which was the original
  14511. behavior of the Makefile. ........ Merged revisions 384544 from
  14512. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14513. revisions 384545 from
  14514. http://svn.asterisk.org/svn/asterisk/branches/11
  14515. 2013-04-02 12:18 +0000 [r384518] Joshua Colp <jcolp@digium.com>
  14516. * main/sorcery.c: Pass the object type name to the configuration
  14517. framework.
  14518. 2013-04-02 11:40 +0000 [r384514] Matthew Jordan <mjordan@digium.com>
  14519. * main/xmldoc.c, include/asterisk/app.h: Make things work again
  14520. Sorry folks. ',' are still greater than '|'. Thanks for playing
  14521. along :-)
  14522. 2013-04-01 20:10 +0000 [r384488] David M. Lee <dlee@digium.com>
  14523. * contrib/scripts/install_prereq: install_prereq: Build jansson
  14524. from source, when necessary When r383579 was committed, it made
  14525. Jansson a required dependency. While libjansson-dev and
  14526. jansson-devel are available on recent distros, some older (but
  14527. still supported) distros don't have it. There's a pull request[1]
  14528. to get it into repoforge, but that still doesn't help everyone.
  14529. (And helps no one until the pull request is merged and packages
  14530. are built). This patch adds Jansson install from source to the
  14531. install_unpackaged() function. There are a few gotcha's, which
  14532. makes this change not completely trivial. * Since Jansson may be
  14533. installed by a package, don't install from source if a package
  14534. installation can be found * libresample may also be installed via
  14535. package, so I added a similar check to that. * Since Jansson
  14536. installs into /usr/local, this patch also adds /usr/local/lib to
  14537. /etc/ld.so.conf.d so that the library can be found. * The
  14538. alternative was to install into /usr, but then it gets
  14539. complicated having to deal with EL's /usr/lib{32,64} shenanigans.
  14540. [1]: https://github.com/repoforge/rpms/pull/250 Review:
  14541. https://reviewboard.asterisk.org/r/2414/
  14542. 2013-04-01 14:44 +0000 [r384452] Matthew Jordan <mjordan@digium.com>
  14543. * main/xmldoc.c, include/asterisk/app.h: Make appropriate items
  14544. parse using '|' instead of ',' This patch fixes a bug introduced
  14545. in r76703, wherein Asterisk could only parse arguments in the
  14546. so-called 'recommended' way, e.g., NoOp(foo,bar). The proper
  14547. syntax of NoOp,foo|bar is now parsed correctly.
  14548. 2013-04-01 14:10 +0000 [r384416] Joshua Colp <jcolp@digium.com>
  14549. * /, apps/app_voicemail.c: Remove silly use of strncmp. ........
  14550. Merged revisions 384414 from
  14551. http://svn.asterisk.org/svn/asterisk/branches/11
  14552. 2013-04-01 13:37 +0000 [r384412-384413] David M. Lee <dlee@digium.com>
  14553. * main/stasis.c, tests/test_stasis.c: stasis: Fixed message
  14554. ordering issues when forwarding This patch fixes an issue of
  14555. message ordering that occurs when multiple topics are forwarded
  14556. to an aggregator topic (such as ast_channel_topic_all()). It is
  14557. (very reasonably) expected that the rules governing message
  14558. dispatch order still apply, so long as the messages start from
  14559. the same thread, and are received by the same subscription.
  14560. Because the existing code had an additional layer of dispatching
  14561. via the Stasis thread pool for forwards, those promises couldn't
  14562. be kept. Forwarding subscriptions no longer have their own
  14563. mailbox, and now dispatch directly from the forwarding topic's
  14564. stasis_publish() call. This means that the topic's lock is held
  14565. for the duration of not only a message's dispatch, but the
  14566. dispatch of all the forwards. This shouldn't be a problem right
  14567. now, but if an aggregator topic had many subscribers, it could
  14568. become a problem. But I figure we can write more clever code when
  14569. the time comes, if necessary. Review:
  14570. https://reviewboard.asterisk.org/r/2419/
  14571. * /, Makefile: Fix parallel make problems. Occasionally, make -j
  14572. would fail due to missing includes, or other unusual errors. This
  14573. was due to the 'cleantest' target, which was designed to force a
  14574. make clean when some change in the code would cause the typical
  14575. depedency checking to fail. Several targets in the main Makefile
  14576. did not depend upon cleantest, hence would run in parallel to it.
  14577. By adding the dependency, make -j runs happily now. Review:
  14578. https://reviewboard.asterisk.org/r/2418/ ........ Merged
  14579. revisions 384410 from
  14580. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14581. revisions 384411 from
  14582. http://svn.asterisk.org/svn/asterisk/branches/11
  14583. 2013-03-30 05:15 +0000 [r384389-384390] Matthew Jordan <mjordan@digium.com>
  14584. * main/manager.c: Properly format an intmax_t value
  14585. * include/asterisk/test.h, main/manager.c, main/test.c,
  14586. apps/app_voicemail.c: Convert TestEvent AMI events over to Stasis
  14587. Core This patch migrates the TestEvent AMI events to first be
  14588. dispatched over the Stasis-Core message bus. This helps to
  14589. preserve the ordering of the events with other events in the AMI
  14590. system, such as the various channel related events.
  14591. 2013-03-29 16:37 +0000 [r384327] Jonathan Rose <jrose@digium.com>
  14592. * apps/app_voicemail.c: app_voicemail: Add blank argument to
  14593. externnotify if no context argument At least one call to
  14594. run_externnotify provides a NULL context parameter and because
  14595. the snprintf statement doesn't account for a NULL context
  14596. parameter, it simply writes '(null)' to the arguments string
  14597. instead. This patch makes it write two quotes back to back for
  14598. that argument instead in the event of a NULL context. (closes
  14599. issue ASTERISK-18207) Reported by: Barry L. Kline Patches:
  14600. modified from patch-20130306 uploaded by Karsten Wemheuer
  14601. (License 5930) ........ Merged revisions 384325 from
  14602. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14603. revisions 384326 from
  14604. http://svn.asterisk.org/svn/asterisk/branches/11
  14605. 2013-03-28 23:59 +0000 [r384302] Richard Mudgett <rmudgett@digium.com>
  14606. * main/sorcery.c, main/stasis.c, main/uuid.c,
  14607. res/res_calendar_exchange.c, res/res_sorcery_config.c,
  14608. include/asterisk/uuid.h, tests/test_uuid.c: Add uuid wrapper API
  14609. call ast_uuid_generate_str(). * Updated test_uuid.c to test the
  14610. new API call. * Made system use the new API call to eliminate
  14611. "10's of lines" where used. * Fixed untested ast_strdup() return
  14612. in stasis_subscribe() by eliminating the need for it. struct
  14613. stasis_subscription now contains the uniqueid[] string. * Fixed
  14614. some issues in exchangecal_write_event(): Create uid with enough
  14615. space for a UUID string to avoid a realloc. Fix off by one error
  14616. if the calendar event provided a UUID string. There is no need to
  14617. check for NULL before calling ast_free().
  14618. 2013-03-28 15:45 +0000 [r384219-384261] Kinsey Moore <kmoore@digium.com>
  14619. * include/asterisk/stasis.h, main/app.c, pbx/pbx_realtime.c,
  14620. include/asterisk/channel.h, tests/test_stasis.c,
  14621. main/manager_channels.c, main/stasis.c, apps/app_voicemail.c,
  14622. main/channel.c, main/pbx.c, main/stasis_cache.c: Break the world.
  14623. Stasis message type accessors should now all be named correctly.
  14624. * main/app.c, res/res_xmpp.c, channels/chan_iax2.c,
  14625. channels/sig_pri.c, res/res_jabber.c, channels/chan_mgcp.c,
  14626. channels/chan_unistim.c, channels/chan_dahdi.c,
  14627. include/asterisk/app.h, channels/chan_sip.c,
  14628. channels/chan_skinny.c: Convert MWI state message type to the new
  14629. stasis naming convention
  14630. 2013-03-27 21:52 +0000 [r384201] David M. Lee <dlee@digium.com>
  14631. * include/asterisk/app.h, include/asterisk/stasis.h,
  14632. include/asterisk/channel.h: Added a doxygen group for Stasis
  14633. messages and topics
  14634. 2013-03-27 19:52 +0000 [r384164] Kinsey Moore <kmoore@digium.com>
  14635. * main/format_pref.c, /, channels/chan_sip.c: Address uninitialized
  14636. conditional that valgrind found ........ Merged revisions 384162
  14637. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  14638. Merged revisions 384163 from
  14639. http://svn.asterisk.org/svn/asterisk/branches/11
  14640. 2013-03-27 18:52 +0000 [r384120] Matthew Jordan <mjordan@digium.com>
  14641. * /, main/http.c: Fix a file descriptor leak in off nominal path
  14642. While looking at the security vulnerability in ASTERISK-20967,
  14643. Walter noticed a file descriptor leak and some other issues in
  14644. off nominal code paths. This patch corrects them. Note that this
  14645. patch is not related to the vulnerability in ASTERISK-20967, but
  14646. the patch was placed on that issue. (closes issue ASTERISK-20967)
  14647. Reported by: wdoekes patches:
  14648. issueA20967_file_leak_and_unused_wkspace.patch uploaded by
  14649. wdoekes (License 5674) ........ Merged revisions 384118 from
  14650. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14651. revisions 384119 from
  14652. http://svn.asterisk.org/svn/asterisk/branches/11
  14653. 2013-03-27 17:07 +0000 [r384050] Kinsey Moore <kmoore@digium.com>
  14654. * res/res_rtp_asterisk.c, /: Fix white noise on SRTP decryption
  14655. When res_rtp_asterisk.c was altered to avoid attempting to apply
  14656. unprotect algorithms to non-audio RTP packets, the test used was
  14657. incorrect. This caused the audio packets to not be decrypted and
  14658. resulted in loud white noise on the other endpoint (or both
  14659. endpoints depending on the call legs involved). The test now
  14660. properly checks the version field in the RTP header to ensure
  14661. that RTP and RTCP are decrypted while other types of packets are
  14662. not. (closes issue ASTERISK-21323) Reported by: andrea Tested by:
  14663. Kinsey Moore, andrea, John Bigelow Patches: whitenoise_fix.diff
  14664. uploaded by Kinsey Moore ........ Merged revisions 384048 from
  14665. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14666. revisions 384049 from
  14667. http://svn.asterisk.org/svn/asterisk/branches/11
  14668. 2013-03-27 15:27 +0000 [r383975-384019] Matthew Jordan <mjordan@digium.com>
  14669. * channels/sip/include/sip.h, /, channels/chan_sip.c,
  14670. channels/sip/security_events.c: AST-2013-003: Prevent username
  14671. disclosure in SIP channel driver When authenticating a SIP
  14672. request with alwaysauthreject enabled, allowguest disabled, and
  14673. autocreatepeer disabled, Asterisk discloses whether a user exists
  14674. for INVITE, SUBSCRIBE, and REGISTER transactions in multiple
  14675. ways. The information is disclosed when: * A "407 Proxy
  14676. Authentication Required" response is sent instead of a "401
  14677. Unauthorized" response * The presence or absence of additional
  14678. tags occurs at the end of "403 Forbidden" (such as "(Bad Auth)")
  14679. * A "401 Unauthorized" response is sent instead of "403
  14680. Forbidden" response after a retransmission * Retransmission are
  14681. sent when a matching peer did not exist, but not when a matching
  14682. peer did exist. This patch resolves these various vectors by
  14683. ensuring that the responses sent in all scenarios is the same,
  14684. regardless of the presence of a matching peer. This issue was
  14685. reported by Walter Doekes, OSSO B.V. A substantial portion of the
  14686. testing and the solution to this problem was done by Walter as
  14687. well - a huge thanks to his tireless efforts in finding all the
  14688. ways in which this setting didn't work, providing automated
  14689. tests, and working with Kinsey on getting this fixed. (closes
  14690. issue ASTERISK-21013) Reported by: wdoekes Tested by: wdoekes,
  14691. kmoore patches: AST-2013-003-1.8 uploaded by kmoore, wdoekes
  14692. (License 6273, 5674) AST-2013-003-10 uploaded by kmoore, wdoekes
  14693. (License 6273, 5674) AST-2013-003-11 uploaded by kmoore, wdoekes
  14694. (License 6273, 5674) ........ Merged revisions 384003 from
  14695. http://svn.asterisk.org/svn/asterisk/branches/11
  14696. * /, main/http.c: AST-2013-002: Prevent denial of service in HTTP
  14697. server AST-2012-014, fixed in January of this year, contained a
  14698. fix for Asterisk's HTTP server for a remotely-triggered crash.
  14699. While the fix put in place fixed the possibility for the crash to
  14700. be triggered, a denial of service vector still exists with that
  14701. solution if an attacker sends one or more HTTP POST requests with
  14702. very large Content-Length values. This patch resolves this by
  14703. capping the Content-Length at 1024 bytes. Any attempt to send an
  14704. HTTP POST with Content-Length greater than this cap will not
  14705. result in any memory allocation. The POST will be responded to
  14706. with an HTTP 413 "Request Entity Too Large" response. This issue
  14707. was reported by Christoph Hebeisen of TELUS Security Labs (closes
  14708. issue ASTERISK-20967) Reported by: Christoph Hebeisen patches:
  14709. AST-2013-002-1.8.diff uploaded by mmichelson (License 5049)
  14710. AST-2013-002-10.diff uploaded by mmichelson (License 5049)
  14711. AST-2013-002-11.diff uploaded by mmichelson (License 5049)
  14712. ........ Merged revisions 383978 from
  14713. http://svn.asterisk.org/svn/asterisk/branches/11
  14714. * res/res_format_attr_h264.c, /: AST-2013-001: Prevent buffer
  14715. overflow through H.264 format negotiation The format attribute
  14716. resource for H.264 video performs an unsafe read against a media
  14717. attribute when parsing the SDP. The value passed in with the
  14718. format attribute is not checked for its length when parsed into a
  14719. fixed length buffer. This patch resolves the vulnerability by
  14720. only reading as many characters from the SDP value as will fit
  14721. into the buffer. (closes issue ASTERISK-20901) Reported by: Ulf
  14722. Harnhammar patches: h264_overflow_security_patch.diff uploaded by
  14723. jrose (License 6182) ........ Merged revisions 383973 from
  14724. http://svn.asterisk.org/svn/asterisk/branches/11
  14725. 2013-03-27 07:24 +0000 [r383948] Damien Wedhorn <voip@facts.com.au>
  14726. * channels/chan_skinny.c: Fix skinny encall button to not blind
  14727. xfer. The softbutton endcall should not turn a transfer into a
  14728. blind transfer but hangup the exten being called and leave the
  14729. original call on hold. This does that. (closes issue
  14730. ASTERISK-21321) Reported by: wedhorn Tested by: snuffy, myself
  14731. Patches: skinny-xferendcall01.diff uploaded by wedhorn (license
  14732. 5019)
  14733. 2013-03-26 23:34 +0000 [r383925] Joshua Colp <jcolp@digium.com>
  14734. * main/sorcery.c: Remove the noop handler from sorcery so it does
  14735. not produce an empty value.
  14736. 2013-03-26 02:30 +0000 [r383841-383879] Matthew Jordan <mjordan@digium.com>
  14737. * /, channels/chan_sip.c: Resolve deadlock between SIP registration
  14738. and channel based functions In r373424, several reentrancy
  14739. problems in chan_sip were addressed. As a result, the SIP channel
  14740. driver is now properly locking the channel driver private
  14741. information in certain operations that it wasn't previously. This
  14742. exposed two latent problems either in register_verify or by
  14743. functions called by register_verify. This includes: * Holding the
  14744. private lock while calling sip_send_mwi_to_peer. This can create
  14745. a new sip_pvt via sip_alloc, which will obtain the channel
  14746. container lock. This is a locking inversion, as any channel
  14747. related lock must be obtained prior to obtaining the SIP channel
  14748. technology private lock. Note that this issue was already fixed
  14749. in Asterisk 11. * Holding the private lock while calling
  14750. sip_poke_peer. In the same vein as sip_send_mwi_to_peer,
  14751. sip_poke_peer can create a new SIP private, causing the same
  14752. locking inversion. Note that this locking inversion typically
  14753. occured when CLI commands were run while a SIP REGISTER request
  14754. was being processed, as many CLI commands (such as 'sip show
  14755. channels', 'core show channels', etc.) have to obtain the channel
  14756. container lock. (issue ASTERISK-21068) Reported by: Nicolas
  14757. Bouliane (issue ASTERISK-20550) Reported by: David Brillert
  14758. (issue ASTERISK-21314) Reported by: Badalian Vyacheslav (issue
  14759. ASTERISK-21296) Reported by: Gabriel Birke ........ Merged
  14760. revisions 383863 from
  14761. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14762. revisions 383878 from
  14763. http://svn.asterisk.org/svn/asterisk/branches/11
  14764. * main/cdr.c, /: Resolve deadlock between pending CDR and batch CDR
  14765. locks r375757 attempted to resolve a race condition between
  14766. multiple submissions of CDRs while in batch mode from attempting
  14767. to destroy the scheduled batch submission by extending the batch
  14768. CDR lock. Unfortunately, this causes a deadlock between the
  14769. pending CDR lock and the batch CDR lock. This patch resolves the
  14770. intent of r375757 by simply providing a new lock that protects
  14771. the scheduling of the batches. The original batch CDR lock is
  14772. kept to protect manipulation of the batch CDR settings, but has
  14773. been placed such that it is not held when the pending lock is
  14774. held. Thanks to Chase Venters for providing lock analysis on the
  14775. issue. (issue ASTERISK-21162) Reported by: Chase Venters ........
  14776. Merged revisions 383839 from
  14777. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14778. revisions 383840 from
  14779. http://svn.asterisk.org/svn/asterisk/branches/11
  14780. 2013-03-26 01:46 +0000 [r383837-383838] Russell Bryant <russell@russellbryant.com>
  14781. * channels/chan_skinny.c: Suppress compiler warning. This code
  14782. caused a compiler warning when --enable-dev-mode was not used.
  14783. The warning was that this variable was set but not used. That was
  14784. indeed the case as the only place this is used is as an argument
  14785. to SKINNY_DEBUG which is compiled out when not in dev mode.
  14786. * /, apps/app_meetme.c: Fix multi-station answer race condition.
  14787. When an SLA trunk is ringing (inbound call on the trunk) Asterisk
  14788. will make outbound calls to the stations that have that trunk. If
  14789. more than one station answers the call at the same time, all
  14790. channels other than the first one to answer are left in a bad
  14791. state. The channel gets leaked, is not connected to anything, and
  14792. there's no way to get rid of it. We now properly clean up these
  14793. losing channels by hanging up on them. Since they lost the race,
  14794. as we process their answer, there is no ringing trunk for them to
  14795. answer. ........ Merged revisions 383835 from
  14796. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14797. revisions 383836 from
  14798. http://svn.asterisk.org/svn/asterisk/branches/11
  14799. 2013-03-25 23:25 +0000 [r383799] Richard Mudgett <rmudgett@digium.com>
  14800. * /, channels/sig_pri.c: Set the CALLERID(dnid-num-plan) for
  14801. incoming ISDN calls. The CALLEDTON channel variable is set for
  14802. incoming ISDN calls to the lower 7 bits of the Q.931
  14803. type-of-number/numbering-plan octet. The CALLERID(dnid-num-plan)
  14804. should have the same value. (closes issue ASTERISK-21248)
  14805. Reported by: rmudgett ........ Merged revisions 383796 from
  14806. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14807. revisions 383798 from
  14808. http://svn.asterisk.org/svn/asterisk/branches/11
  14809. 2013-03-25 20:15 +0000 [r383753-383754] Kinsey Moore <kmoore@digium.com>
  14810. * main/manager_channels.c: Fix typo
  14811. * main/stasis.c: Fix missing ' ' around '='
  14812. 2013-03-25 19:28 +0000 [r383726-383747] David M. Lee <dlee@digium.com>
  14813. * contrib/scripts/install_prereq: install_prereq: removed some
  14814. out-of-date comments
  14815. * contrib/scripts/install_prereq: install_prereq: Adding
  14816. jansson-devel to RH packages
  14817. * main/channel_internal_api.c, include/asterisk/channel.h, CHANGES,
  14818. main/manager_channels.c, main/channel.c, main/manager.c: Move
  14819. NewCallerid, HangupRequest and SoftHangupRequest to Stasis
  14820. HangupRequest and SoftHangupRequest are now ast_channel_blob
  14821. Stasis messages, with the cause code as an optional field in the
  14822. blob. NewCallerid now simply watches for changes in the callerid
  14823. information in channel snapshots, and creates the AMI event
  14824. appropriately. Since the original NewCallerid event honored the
  14825. channelvars setting in manager.conf, the channel variables
  14826. configured there had to become a part of the channel snapshot.
  14827. These are now a part of every snapshot based event, making the
  14828. configuration description "every time a channel-oriented event is
  14829. emitted" less of a lie. There a a few other changes wrapped up in
  14830. here as well. * When ast_channel_topic() is given NULL for a
  14831. channel, it returns the ast_channel_topic_all() topic instead of
  14832. NULL. This can clean up a lot of NULL checking we're doing
  14833. currently. * The fields Cause and Cause-txt were removed from the
  14834. base channel information and put only on the Hangup events, since
  14835. those fields are meaningless outside of a Hangup event. * Removed
  14836. the pipe-delimiter processing of the channelvars field, since
  14837. that's been deprecated forever. (closes issue ASTERISK-21096)
  14838. Review: https://reviewboard.asterisk.org/r/2405/
  14839. 2013-03-25 12:38 +0000 [r383669] Sean Bright <sean@malleable.com>
  14840. * res/res_config_curl.c, /: Properly delimit post data in
  14841. res_config_curl. ........ Merged revisions 383667 from
  14842. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14843. revisions 383668 from
  14844. http://svn.asterisk.org/svn/asterisk/branches/11
  14845. 2013-03-22 20:51 +0000 [r383633] David M. Lee <dlee@digium.com>
  14846. * main/json.c, main/Makefile: Fixed another issue from r383579.
  14847. Core modules don't honor <depend> flags in MODULEINFO, which
  14848. broke jansson if specified --with-jansson to configure.
  14849. 2013-03-22 20:43 +0000 [r383632] Michael L. Young <elgueromexicano@gmail.com>
  14850. * apps/app_mixmonitor.c, /: Fix StopMixMonitor Hanging Up When
  14851. Unable To Stop MixMonitor On A Channel A regression was
  14852. accidentally introduced when allowing an optional ID to be used
  14853. when calling StopMixMonitor. When we are unable to stop
  14854. MixMonitor on a channel, -1 is being returned which triggers the
  14855. hangup of the channel. This patch restores the prior behavior by
  14856. returning 0 whether we were successful or not. It also allows the
  14857. call from the manager to use the return code when the action
  14858. fails. (closes issue ASTERISK-21294) Reported by: daroz Tested
  14859. by: daroz Patches: asterisk-21294-stop_mixmonitor_hangingup.diff
  14860. Michael L. Young (license 5026) Review:
  14861. https://reviewboard.asterisk.org/r/2404/ ........ Merged
  14862. revisions 383631 from
  14863. http://svn.asterisk.org/svn/asterisk/branches/11
  14864. 2013-03-22 19:26 +0000 [r383579-383611] David M. Lee <dlee@digium.com>
  14865. * main/asterisk.c, main/json.c, include/asterisk/json.h: Corrected
  14866. some module issues introduced by r383579. When I moved res_json.c
  14867. to json.c, I left the MODULE_INFO stuff in there, which was
  14868. interesting if you ran module show. I also forgot to call what
  14869. was in module_load() from asterisk main().
  14870. * pbx/pbx_realtime.c, main/manager_channels.c (added),
  14871. tests/test_json.c, res/res_json.c (removed), main/pbx.c,
  14872. include/asterisk/autoconfig.h.in, configure.ac,
  14873. apps/app_userevent.c, include/asterisk/channel.h, CHANGES,
  14874. include/asterisk/manager.h, main/channel.c, main/json.c (added),
  14875. main/manager.c, configure, res/res_json.exports.in (removed):
  14876. Move more channel events to Stasis; move res_json.c to
  14877. main/json.c. This patch started out simply as fixing the bouncing
  14878. tests introduced in r382685, but required some other changes to
  14879. give it a decent implementation. To fix the bouncing tests, the
  14880. UserEvent and Newexten AMI events needed to be refactored to
  14881. dispatch via Stasis. Dispatching directly to AMI resulted in
  14882. those events sometimes getting ahead of the associated Newchannel
  14883. events, which would understandably confuse anyone. I found that
  14884. instead of creating a zillion different message types and
  14885. structures associated with them, it would be preferable to define
  14886. a message type that has a channel snapshot and a blob of
  14887. structured data with a small bit of additional information. The
  14888. JSON object model provides a very nice way of representing
  14889. structured data, so I went with that. * Move JSON support from
  14890. res_json.c to main/json.c * Made libjansson-dev a required
  14891. dependency * Added an ast_channel_blob message type, which has a
  14892. channel snapshot and JSON blob of data. * Changed UserEvent and
  14893. Newexten events so that they are dispatched via ast_channel_blob
  14894. messages on the channel's topic. * Got rid of the
  14895. ast_channel_varset message; used ast_channel_blob instead. *
  14896. Extracted the manager functions converting Stasis channel events
  14897. to AMI events into manager_channel.c. (issue ASTERISK-21096)
  14898. Review: https://reviewboard.asterisk.org/r/2381/
  14899. 2013-03-22 06:32 +0000 [r383560] Damien Wedhorn <voip@facts.com.au>
  14900. * channels/chan_skinny.c: Fix skinny voicemail indication issues.
  14901. Unsubscribe from MWI stasis event on channel reload. (closes
  14902. issue ASTERISK-21216) Reported by: wedhorn Tested by: snuffy,
  14903. myself Patches: skinny-mwiind02.diff uploaded by snuffy (license
  14904. 5024)
  14905. 2013-03-21 20:09 +0000 [r383541] David M. Lee <dlee@digium.com>
  14906. * include/asterisk/stasis.h: Corrected doc error for Stasis. I
  14907. guess the mutex isn't necessary. Thanks, rmudgett!
  14908. 2013-03-21 17:41 +0000 [r383519] Richard Mudgett <rmudgett@digium.com>
  14909. * include/asterisk/astobj2.h: Fix astobj2 doxygen comment.
  14910. 2013-03-20 20:27 +0000 [r383458-383462] Walter Doekes <walter+asterisk@wjd.nu>
  14911. * funcs/func_curl.c, /: Have func_curl log a warning when a curl
  14912. request fails. Review: https://reviewboard.asterisk.org/r/2403/
  14913. ........ Merged revisions 383460 from
  14914. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14915. revisions 383461 from
  14916. http://svn.asterisk.org/svn/asterisk/branches/11
  14917. * funcs/func_curl.c, /: Minor cleanup in func_curl near hashcompat
  14918. code. Review: https://reviewboard.asterisk.org/r/2402/ ........
  14919. Merged revisions 383457 from
  14920. http://svn.asterisk.org/svn/asterisk/branches/11
  14921. 2013-03-20 16:01 +0000 [r383422] Kinsey Moore <kmoore@digium.com>
  14922. * main/stasis.c: Resolve a race condition in Stasis Because of the
  14923. way that topics were handled when publishing, it was possible to
  14924. dispatch a message to a subscription after that subscription had
  14925. been unsubscribed such that the dispatched message arrived at the
  14926. callback after the callback had received its final message. In
  14927. callbacks that cleaned up user data, this would often cause a
  14928. segfault. This has been resolved by locking the topic during the
  14929. entirety of dispatch. To prevent long publishing and topic
  14930. locking times, forwarding subscriptions have been made to be
  14931. standard subscriptions instead of mailboxless subscriptions which
  14932. were dispatched at publishing time.
  14933. 2013-03-20 14:52 +0000 [r383405] Joshua Colp <jcolp@digium.com>
  14934. * main/sorcery.c, res/res_sorcery_memory.c,
  14935. include/asterisk/sorcery.h, tests/test_sorcery.c: Pass the
  14936. sorcery instance to wizards for CUD operations as well as
  14937. retrieve.
  14938. 2013-03-19 19:07 +0000 [r383377] Kinsey Moore <kmoore@digium.com>
  14939. * main/stasis_message_router.c: Fix lock destruction/unlock
  14940. inversion When using scoped locks, the unref of an AO2 object
  14941. should happen after the unlock occurs which requires usage of
  14942. scoped refs.
  14943. 2013-03-19 16:00 +0000 [r383343] David M. Lee <dlee@digium.com>
  14944. * codecs/Makefile, /: Multiple revisions 383341-383342 ........
  14945. r383341 | dlee | 2013-03-19 10:57:29 -0500 (Tue, 19 Mar 2013) | 5
  14946. lines Removed codecs/g722/*.i on make clean ........ Merged
  14947. revisions 383340 from
  14948. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  14949. r383342 | dlee | 2013-03-19 10:58:33 -0500 (Tue, 19 Mar 2013) | 1
  14950. line Remove codecs/speex/*.i on make clean ........ Merged
  14951. revisions 383341-383342 from
  14952. http://svn.asterisk.org/svn/asterisk/branches/11
  14953. 2013-03-16 16:00 +0000 [r383284-383287] Kinsey Moore <kmoore@digium.com>
  14954. * res/res_jabber.c, channels/chan_mgcp.c: Make sure things
  14955. compile...
  14956. * channels/sip/include/sip.h, main/asterisk.c,
  14957. channels/chan_mgcp.c, apps/app_voicemail.c,
  14958. channels/chan_unistim.c, channels/chan_sip.c,
  14959. include/asterisk/stasis.h, res/res_xmpp.c, channels/sig_pri.c,
  14960. channels/chan_iax2.c, res/res_jabber.c, main/stasis.c,
  14961. channels/sig_pri.h, main/channel.c, include/asterisk/app.h,
  14962. channels/chan_dahdi.c, channels/chan_skinny.c,
  14963. include/asterisk/xmpp.h, apps/app_minivm.c, main/app.c:
  14964. Transition MWI to Stasis-core Remove MWI's dependency on the
  14965. event system by moving it to Stasis-core. This also introduces
  14966. forwarding topic pools in Stasis-core which aggregate many
  14967. dynamically allocated topics into a single primary topic. Review:
  14968. https://reviewboard.asterisk.org/r/2368/ (closes issue
  14969. ASTERISK-21097) Patch-by: Kinsey Moore
  14970. 2013-03-16 15:40 +0000 [r383267-383283] Joshua Colp <jcolp@digium.com>
  14971. * res/res_xmpp.c, CHANGES: Add support for using XMPP buddy state
  14972. via device state. This change allows you to use XMPP buddy state
  14973. in places where device state can be used be used, such as
  14974. dialplan hints. If at least one resource is available the buddy
  14975. is considered available. Now your phone can reflect their IM
  14976. status too!
  14977. * res/res_xmpp.c, /: Fix a bug where resources were not found due
  14978. to hashing on the priority itself. ........ Merged revisions
  14979. 383266 from http://svn.asterisk.org/svn/asterisk/branches/11
  14980. 2013-03-15 17:35 +0000 [r383225-383242] David M. Lee <dlee@digium.com>
  14981. * main/stasis_cache.c, main/stasis_message_router.c (added),
  14982. main/stasis_message.c, include/asterisk/stasis_message_router.h
  14983. (added), tests/test_stasis.c, main/stasis.c: A simplistic router
  14984. for stasis_message's. Often times, when subscribing to a topic,
  14985. one wants to handle different message types differently. While
  14986. one could cascade if/else statements through the subscription
  14987. handler, it is much cleaner to specify a different callback for
  14988. each message type. The stasis_message_router is here to help! A
  14989. stasis_message_router is constructed for a particular
  14990. stasis_topic, which is subscribes to. Call
  14991. stasis_message_router_unsubscribe() to cancel that subscription.
  14992. Once constructed, routes can be added using
  14993. stasis_message_router_add() (or
  14994. stasis_message_router_set_default() for any messages not handled
  14995. by other routes). There may be only one route per
  14996. stasis_message_type. The route's callback is invoked just as if
  14997. it were a callback for a subscription; but it only gets called
  14998. for messages of the specified type. (issue ASTERISK-20887)
  14999. Review: https://reviewboard.asterisk.org/r/2390/
  15000. * configs/stasis_core.conf.sample (added): Sample config file for
  15001. stasis-core. (issue ASTERISK-20887)
  15002. 2013-03-15 13:04 +0000 [r383167-383169] Kinsey Moore <kmoore@digium.com>
  15003. * tests/test_stasis.c, main/manager.c, main/channel_internal_api.c:
  15004. Take advantage of the fact that stasis_unsubscribe now returns
  15005. NULL
  15006. * main/stasis.c, main/stasis_cache.c, include/asterisk/stasis.h:
  15007. Make stasis unsubscription functions return NULL Unsubscribing
  15008. things in Asterisk seems to very commonly follow with NULLing out
  15009. the variable that was unsubscribed. This change makes that a bit
  15010. simpler.
  15011. * main/tcptls.c, main/manager.c, /, channels/chan_sip.c,
  15012. main/http.c: tcptls: Prevent unsupported options from being set
  15013. AMI, HTTP, and chan_sip all support TLS in some way, but none of
  15014. them support all the options that Asterisk's TLS core is capable
  15015. of interpreting. This prevents consumers of the TLS/SSL layer
  15016. from setting TLS/SSL options that they do not support. This also
  15017. gets tlsverifyclient closer to a working state by requesting the
  15018. client certificate when tlsverifyclient is set. Currently, there
  15019. is no consumer of main/tcptls.c in Asterisk that supports this
  15020. feature and so it can not be properly tested. Review:
  15021. https://reviewboard.asterisk.org/r/2370/ Reported-by: John
  15022. Bigelow Patch-by: Kinsey Moore (closes issue AST-1093) ........
  15023. Merged revisions 383165 from
  15024. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15025. revisions 383166 from
  15026. http://svn.asterisk.org/svn/asterisk/branches/11
  15027. 2013-03-15 01:38 +0000 [r383122-383126] Matthew Jordan <mjordan@digium.com>
  15028. * /, channels/chan_sip.c: When a session timer expires during a
  15029. T.38 call, re-invite with correct SDP When a session timer
  15030. expires during a dialog that has re-negotiated to T.38 and
  15031. Asterisk is the refresher, Asterisk will send a re-INVITE with an
  15032. SDP containing audio media only. This causes some hilarity with
  15033. the poor fax session under weigh. This patch corrects that by
  15034. sending T.38 parameters if we are in the middle of a T.38
  15035. session. (closes issue ASTERISK-21232) Reported by: Nitesh Bansal
  15036. patches:
  15037. dont-send-audio-reinvite-for-sess-timer-in-t38-call.patch
  15038. uploaded by nbansal (License 6418) ........ Merged revisions
  15039. 383124 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  15040. ........ Merged revisions 383125 from
  15041. http://svn.asterisk.org/svn/asterisk/branches/11
  15042. * pbx/pbx_spool.c, /: Fix processing of call files when using
  15043. KQueue on OS X In certain situations, call files are not
  15044. processed when using KQueue with pbx_spool. Asterisk was sending
  15045. an invalid timeout value when the spool directory is empty,
  15046. causing the call to kevent to error immediately. This can create
  15047. a tight loop, increasing the CPU load on the system. (closes
  15048. issue ASTERISK-21176) Reported by: Carlton O'Riley patches:
  15049. kqueue_osx.patch uploaded by coriley (License 6473) ........
  15050. Merged revisions 383120 from
  15051. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15052. revisions 383121 from
  15053. http://svn.asterisk.org/svn/asterisk/branches/11
  15054. 2013-03-14 16:57 +0000 [r383063] Jason Parker <jparker@digium.com>
  15055. * /, autoconf/ast_ext_lib.m4: Fix whitespace in AST_EXT_LIB_CHECK
  15056. macro. ........ Merged revisions 383061 from
  15057. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15058. revisions 383062 from
  15059. http://svn.asterisk.org/svn/asterisk/branches/11
  15060. 2013-03-13 14:39 +0000 [r383008] Matthew Jordan <mjordan@digium.com>
  15061. * res/res_rtp_asterisk.c: Always set the RTP instance data in the
  15062. RTP engine Not informing the RTP engine of the instance data
  15063. creates shrapnel.
  15064. 2013-03-12 22:43 +0000 [r382989] Andrew Latham <lathama@gmail.com>
  15065. * res/res_config_ldap.c: Update Doxygen Push some cleanups upstream
  15066. before testing another ticket. (issue ASTERISK-20259)
  15067. 2013-03-12 21:19 +0000 [r382941-382954] Michael L. Young <elgueromexicano@gmail.com>
  15068. * addons/res_config_mysql.c, /: Fix Sorting Order For Parking Lots
  15069. Stored In Static Realtime When retrieving the parking lots from a
  15070. MySQL database table, the current order is "filename, cat_metric
  15071. desc, var_metric asc, category". If there are multiple parking
  15072. lots with the same cat_metric but different categories,
  15073. everything is being sorted on cat_metric first resulting in
  15074. errors when loading the parking lots. This patch fixes the
  15075. problem by sorting on the category field first, then the
  15076. cat_metric field. (closes issue ASTERISK-21035) Reported by: Alex
  15077. Epshteyn Patches: asterisk-21035-orderby.diff Michael L. Young
  15078. (license 5026) ........ Merged revisions 382942 from
  15079. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15080. revisions 382943 from
  15081. http://svn.asterisk.org/svn/asterisk/branches/11
  15082. * contrib/realtime/mysql/sippeers.sql, /,
  15083. contrib/realtime/postgresql/realtime.sql: Update Contributed
  15084. Realtime Schema Files - IPv6 Addresses This commit updates some
  15085. fields in the contributed realtime schema files to handle IPv6
  15086. addresses. (closes issue ASTERISK-21173) Reported by: Torrey
  15087. Searle Patches: realtime_sql.patch Torrey Searle (license 5334)
  15088. asterisk-21173-update-ip-fields.diff Michael L. Young (license
  15089. 5026) ........ Merged revisions 382939 from
  15090. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15091. revisions 382940 from
  15092. http://svn.asterisk.org/svn/asterisk/branches/11
  15093. 2013-03-12 20:07 +0000 [r382924] Joshua Colp <jcolp@digium.com>
  15094. * res/res_xmpp.c, /: Fix a crash when res_xmpp is configured using
  15095. a username without a domain. (closes issue ASTERISK-21156)
  15096. Reported by: amsoft2001 ........ Merged revisions 382923 from
  15097. http://svn.asterisk.org/svn/asterisk/branches/11
  15098. 2013-03-12 19:08 +0000 [r382900] Jason Parker <jparker@digium.com>
  15099. * build_tools/menuselect-deps.in, configure,
  15100. include/asterisk/autoconfig.h.in, configure.ac, res/Makefile,
  15101. CHANGES, makeopts.in, res/pjproject (removed),
  15102. res/res_rtp_asterisk.c: Switch to using external pjproject
  15103. libraries. ICE/STUN/TURN support in res_rtp_asterisk is also now
  15104. optional.
  15105. 2013-03-12 16:30 +0000 [r382852] Matthew Jordan <mjordan@digium.com>
  15106. * /, channels/chan_sip.c: Include the Username field in SIP
  15107. Registry events when Status is registered In ASTERISK-17888, the
  15108. AMI Registry event during SIP registrations was supposed to
  15109. include the Username field. Somehow, one of the events was
  15110. missed. This patch corrects that - the Username field should be
  15111. included in all AMI Registry events involving SIP registrations.
  15112. (issue ASTERISK-17888) (closes issue ASTERISK-21201) Reported by:
  15113. Dmitriy Serov patches: chan_sip.c.diff uploaded by Dmitriy Serov
  15114. (license 6479) ........ Merged revisions 382847 from
  15115. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15116. revisions 382848 from
  15117. http://svn.asterisk.org/svn/asterisk/branches/11
  15118. 2013-03-12 08:55 +0000 [r382828] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  15119. * channels/chan_unistim.c, /: Fix core dump on CLI usage Fix issue
  15120. with 'unistim show info' CLI command when device connected not
  15121. configured ........ Merged revisions 382827 from
  15122. http://svn.asterisk.org/svn/asterisk/branches/11
  15123. 2013-03-11 15:22 +0000 [r382787] Kevin Harwell <kharwell@digium.com>
  15124. * CHANGES, channels/sip/include/sip.h, channels/chan_sip.c: Added
  15125. an option to disallow music on hold Added an option
  15126. "discard_remote_hold_retrieval" (default "no") that if set does
  15127. not trigger the music on hold event. This essentially stops
  15128. telling the peer to start music on hold. (issue ABE-2899)
  15129. Reported by: Denis Alberto Martinez Review:
  15130. https://reviewboard.asterisk.org/r/2336/
  15131. 2013-03-09 00:21 +0000 [r382764] Richard Mudgett <rmudgett@digium.com>
  15132. * apps/confbridge/include/conf_state.h,
  15133. apps/confbridge/conf_state_multi.c, apps/app_confbridge.c,
  15134. apps/confbridge/conf_state_multi_marked.c,
  15135. apps/confbridge/conf_state_empty.c, apps/confbridge/conf_state.c,
  15136. apps/confbridge/conf_config_parser.c,
  15137. apps/confbridge/conf_state_single.c,
  15138. apps/confbridge/conf_state_inactive.c,
  15139. apps/confbridge/conf_state_single_marked.c,
  15140. apps/confbridge/include/confbridge.h: confbridge: Rename items
  15141. for clarity and consistency. struct conference_bridge_user ->
  15142. struct confbridge_user struct conference_bridge -> struct
  15143. confbridge_conference struct conference_state -> struct
  15144. confbridge_state struct conference_bridge_user
  15145. *conference_bridge_user -> struct confbridge_user *user struct
  15146. conference_bridge_user *cbu -> struct confbridge_user *user
  15147. struct conference_bridge *conference_bridge -> struct
  15148. confbridge_conference *conference The names are now generally
  15149. shorter, consistently used, and don't conflict with the struct
  15150. names. This patch handles the renaming part of the issue. (issue
  15151. ASTERISK-20776) Reported by: rmudgett
  15152. 2013-03-08 20:26 +0000 [r382746] Jonathan Rose <jrose@digium.com>
  15153. * /, channels/chan_sip.c: chan_sip: Update the via header when
  15154. relaying SMS MESSAGE Prior to this change, certain conditions for
  15155. sending the message would result in an address of '(null)' being
  15156. used in the via header of the SIP message because a NULl value of
  15157. pvt->ourip was used when initially generating the via header.
  15158. This is fixed by adding a call to build_via when the address is
  15159. set before sending the message. (closes issue ASTERISK-21148)
  15160. Reported by: Zhi Cheng Patches: 700-sip_msg_send_via_fix.patch
  15161. uploaded by Zhi Cheng (license 6475) ........ Merged revisions
  15162. 382739 from http://svn.asterisk.org/svn/asterisk/branches/11
  15163. 2013-03-08 16:59 +0000 [r382721-382724] David M. Lee <dlee@digium.com>
  15164. * main/stasis_cache.c, include/asterisk/stasis.h: Stasis
  15165. documentation updates. (issue ASTERISK-20887) (issue
  15166. ASTERISK-20959)
  15167. * main/stasis.c, main/channel.c, main/channel_internal_api.c:
  15168. Ensure dummy channels get a stasis topic. Fixes test failure
  15169. introduced in r382685. (issue ASTERISK-20887) (issue
  15170. ASTERISK-20959)
  15171. 2013-03-08 16:00 +0000 [r382705] Kinsey Moore <kmoore@digium.com>
  15172. * include/asterisk/stasis.h, tests/test_stasis.c,
  15173. main/stasis_cache.c: Add message dump capability to stasis cache
  15174. layer The cache dump mechanism allows the developer to retreive
  15175. multiple items of a given type (or of all types) from the cache
  15176. residing in a stasis caching topic in addition to the existing
  15177. single-item cache retreival mechanism. This also adds to the
  15178. caching unit tests to ensure that the new cache dump mechanism is
  15179. functioning properly. Review:
  15180. https://reviewboard.asterisk.org/r/2367/ (issue ASTERISK-21097)
  15181. 2013-03-08 15:15 +0000 [r382685] David M. Lee <dlee@digium.com>
  15182. * include/asterisk/channel.h, tests/test_stasis.c (added),
  15183. main/asterisk.c, main/stasis.c (added), main/channel.c,
  15184. main/stasis_cache.c (added), main/pbx.c, main/stasis_message.c
  15185. (added), main/manager.c, main/asterisk.exports.in,
  15186. include/asterisk/channel_internal.h, main/channel_internal_api.c,
  15187. include/asterisk/stasis.h (added): This patch adds a new message
  15188. bus API to Asterisk. For the initial use of this bus, I took some
  15189. work kmoore did creating channel snapshots. So rather than create
  15190. AMI events directly in the channel code, this patch generates
  15191. Stasis events, which manager.c uses to then publish the AMI
  15192. event. This message bus provides a generic publish/subscribe
  15193. mechanism within Asterisk. This message bus is: - Loosely
  15194. coupled; new message types can be added in seperate modules. -
  15195. Easy to use; publishing and subscribing are straightforward
  15196. operations. In addition to basic publish/subscribe, the patch
  15197. also provides mechanisms for message forwarding, and for message
  15198. caching. (issue ASTERISK-20887) (closes issue ASTERISK-20959)
  15199. Review: https://reviewboard.asterisk.org/r/2339/
  15200. 2013-03-08 04:11 +0000 [r382670-382671] Matthew Jordan <mjordan@digium.com>
  15201. * channels/chan_sip.c: Remove unused function After r382670,
  15202. get_ip_and_port_from_sdp was no longer used.
  15203. * channels/chan_sip.c: Don't reset the RTP address on a glare
  15204. re-INVITE Originally, way back in r201583, we added the alternate
  15205. RTP address so that the RTP engine would expect to receive audio
  15206. from a new source when a glare re-INVITE occurred. In r382589, we
  15207. remove the alternate RTP source, as the 'secret' probation mode
  15208. allows for switching to a new RTP source when a previous source
  15209. stops sending RTP. At the time, it seemed appropriate to set the
  15210. RTP source based on the information in the glared re-INVITE.
  15211. Unfortunately, that doesn't work so well - in a glared re-INVITE
  15212. that occurs with no SDP - such as in a connected line update that
  15213. glances - we'll set the RTP source to an invalid address. In
  15214. subsequent re-INVITE requests from this Asterisk instance, we'll
  15215. then send an invalid media address, which will result in the
  15216. remote side sending a 488. Whoops. There isn't any need to reset
  15217. the RTP source - if we're using strictrtp, we'll simply
  15218. synchronize to a new source when we stop getting packets from the
  15219. old one. If we aren't using strictrtp, then again there shouldn't
  15220. be a problem. Note that the Asterisk Test Suite's connectedline
  15221. test caught this error.
  15222. 2013-03-07 21:55 +0000 [r382648] David M. Lee <dlee@digium.com>
  15223. * main/threadpool.c: Changing log level of "Not changing threadpool
  15224. size" from notice to debug.
  15225. 2013-03-07 21:14 +0000 [r382636] Jason Parker <jparker@digium.com>
  15226. * res/res_sorcery_config.c, res/res_sorcery_memory.c: Load sorcery
  15227. modules earlier, so they can actually be used.
  15228. 2013-03-07 19:14 +0000 [r382621] Matthew Jordan <mjordan@digium.com>
  15229. * apps/app_voicemail.c, /: Let vm_mailbox_snapshot combine "Urgent"
  15230. when no folder is specified r381835 fixed a bug in
  15231. vm_mailbox_snapshot where combining INBOX and Old forgot that
  15232. Urgent also "counts" as new messages. This fixed the problem when
  15233. any of the three folders was specified and the combine option was
  15234. used. It missed the case where the folder isn't specified and we
  15235. build a snapshot of all folders. This patch corrects that.
  15236. ........ Merged revisions 382617 from
  15237. http://svn.asterisk.org/svn/asterisk/branches/11
  15238. 2013-03-07 16:48 +0000 [r382600-382604] Kinsey Moore <kmoore@digium.com>
  15239. * main/xmldoc.c: Fix a memory leak in xmldoc Another instance of
  15240. attribute retrieval not being freed properly.
  15241. * main/xmldoc.c: Resolve more memory leaks in xmldoc Many places
  15242. that allocated to pull out an attribute are now freed properly.
  15243. 2013-03-07 15:48 +0000 [r382589] Matthew Jordan <mjordan@digium.com>
  15244. * include/asterisk/rtp_engine.h, res/res_rtp_asterisk.c,
  15245. main/rtp_engine.c, /, channels/chan_sip.c: Add a 'secret'
  15246. probation strictrtp mode to handle delayed changes in RTP source
  15247. Often, Asterisk may realize that a change in the source of an RTP
  15248. stream is about to occur and ask that the RTP engine reset it's
  15249. lock on the current RTP source. In certain scenarios, it may take
  15250. awhile for the new remote system to send RTP packets, while the
  15251. old remote system may continue providing RTP during that time
  15252. period. This causes Asterisk to re-lock onto the old source,
  15253. thereby rejecting the new source when the old source stops
  15254. sending RTP and the new source begins. This patch prevents that
  15255. by having a constant secondary, 'secret' probation mode enabled
  15256. when an RTP source has been chosen. RTP packets from other
  15257. sources are always considered, but never chosen unless the
  15258. current RTP source stops sending RTP. Review:
  15259. https://reviewboard.asterisk.org/r/2364 (closes issue AST-1124)
  15260. Reported by: John Bigelow Tested by: John Bigelow (closes issue
  15261. AST-1125) Reported by: John Bigelow Tested by: John Bigelow
  15262. ........ Merged revisions 382573 from
  15263. http://svn.asterisk.org/svn/asterisk/branches/11
  15264. 2013-03-07 15:36 +0000 [r382489-382587] Kinsey Moore <kmoore@digium.com>
  15265. * main/xmldoc.c: Fix minor memory leak in xmldoc Strings retrieved
  15266. via ast_xml_get_text() must be freed with ast_xml_free_text().
  15267. * /, main/logger.c: Ensure that logmsgs are freed properly Messages
  15268. sent while the logger thread is shutting down will now have their
  15269. associated callid freed properly. ........ Merged revisions
  15270. 382574 from http://svn.asterisk.org/svn/asterisk/branches/11
  15271. * main/threadpool.c: Fix ref leak in threadpool.c If
  15272. ast_threadpool_set_size with a size equal to the current size, a
  15273. reference to a set_size_data structure would be leaked.
  15274. * main/threadpool.c: Resolve a ref leak in threadpool.c Ownership
  15275. of the listener reference is not transferred because the listener
  15276. is reffed when placed into the taskprocessor. Ensure that the
  15277. listener is dereffed properly.
  15278. 2013-03-05 13:14 +0000 [r382440] Matthew Jordan <mjordan@digium.com>
  15279. * configs/res_ldap.conf.sample,
  15280. contrib/realtime/postgresql/realtime.sql,
  15281. configs/sip.conf.sample, CHANGES,
  15282. contrib/scripts/asterisk.ldap-schema,
  15283. contrib/scripts/asterisk.ldif, channels/sip/include/sip.h,
  15284. CREDITS, contrib/realtime/mysql/sippeers.sql,
  15285. channels/chan_sip.c: Add RFC 3327 Path header support to chan_sip
  15286. This patch adds support for RFC 3327 "Path" headers. This can be
  15287. enabled in sip.conf using the 'supportpath' setting, either on a
  15288. global basis or on a peer basis. This setting enables Asterisk to
  15289. route outgoing out-of-dialog requests via a set of proxies by
  15290. using a pre-loaded route-set defined by the Path headers in the
  15291. REGISTER request. This patch also adds Realtime support for
  15292. dynamically updating the Path information for a peer. A huge
  15293. thank-you to Klaus Darillion and Olle E Johansson for their
  15294. efforts in writing this patch. Review:
  15295. https://reviewboard.asterisk.org/r/2235/ Review:
  15296. https://reviewboard.asterisk.org/r/991/ (closes issue
  15297. ASTERISK-16884) Reported by: klaus3000 Tested by: klaus3000, oej,
  15298. mjordan patches: path-1.8.0-patch.txt uploaded by klaus3000
  15299. (License 5054) oolong-path-support-trunk in team branch by oej
  15300. (License 5267)
  15301. 2013-03-05 03:53 +0000 [r382411] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  15302. * /, channels/chan_unistim.c: Fix several unreleased mutex locks
  15303. that cause problem with processing calls Reported by: Daniel
  15304. Bohling Tested by: Daniel Bohling (Closes issue ASTERISK-21119)
  15305. ........ Merged revisions 382409 from
  15306. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15307. revisions 382410 from
  15308. http://svn.asterisk.org/svn/asterisk/branches/11
  15309. 2013-03-04 21:15 +0000 [r382392] Richard Mudgett <rmudgett@digium.com>
  15310. * include/asterisk/format_cap.h, main/bridging.c: Fixup some bridge
  15311. and format capabilities comments and whitespace.
  15312. 2013-03-04 21:14 +0000 [r382391] Jason Parker <jparker@digium.com>
  15313. * /, main/event.c: Fix comparison of presence state in event
  15314. subsystem. Several new IEs were not given types (or names),
  15315. causing the comparison function to improperly succeed. This adds
  15316. those. (closes issue AST-1128) ........ Merged revisions 382390
  15317. from http://svn.asterisk.org/svn/asterisk/branches/11
  15318. 2013-03-04 20:18 +0000 [r382386] Kevin Harwell <kharwell@digium.com>
  15319. * /, apps/app_confbridge.c: Confbridge CLI new record file name
  15320. check. This fix checks to make sure that if a confbridge record
  15321. start command is issued from the CLI it will always use the file
  15322. name given on the CLI even if it changes between start/stop
  15323. records for a conference. Previously it had been reusing the same
  15324. file between start/stops even if a new filename was given. (issue
  15325. AST-1088) Reported by: John Bigelow ........ Merged revisions
  15326. 382385 from http://svn.asterisk.org/svn/asterisk/branches/11
  15327. 2013-03-01 18:01 +0000 [r382340] Joshua Colp <jcolp@digium.com>
  15328. * include/asterisk/sorcery.h, tests/test_sorcery.c, main/sorcery.c:
  15329. Add support for registering a sorcery handler which supports
  15330. multiple fields using a regex. Review:
  15331. https://reviewboard.asterisk.org/r/2332/
  15332. 2013-03-01 04:32 +0000 [r382323] Michael L. Young <elgueromexicano@gmail.com>
  15333. * contrib/realtime/postgresql/realtime.sql, CHANGES,
  15334. contrib/realtime/mysql/sippeers.sql, /, channels/chan_sip.c: Fix
  15335. / Clean Up Some Items To Handle The New auto_* NAT Options The
  15336. original report had to do with a realtime peer behind NAT being
  15337. pruned and the peer's private address being used instead of its
  15338. external address. Upon debugging, it was discovered that this was
  15339. being caused by the addition of the auto_force_rport and
  15340. auto_comedia settings. This patch does the following: * Adds a
  15341. missing note to the CHANGES file indicating that the default
  15342. global nat setting is auto_force_rport * Constify the 'req'
  15343. parameter for check_via() * Add calls to check_via() in a couple
  15344. of places in order for the auto_* settings to do their job in
  15345. attempting to determine if NAT is involved * Set the flags
  15346. SIP_NAT_FORCE_RPORT and SIP_PAGE2_SYMMETRICRTP if the auto_*
  15347. settings are in use where it was needed * Moves the copying of
  15348. peer flags up in build_peer() to before they are used; this fixes
  15349. the realtime prune issue * Update the contrib/realtime schemas to
  15350. allow the nat column to handle the different nat setting
  15351. combinations we have This patch received a review and "Ship It!"
  15352. on the issue itself. (closes issue ASTERISK-20904) Reported by:
  15353. JoshE Tested by: JoshE, Michael L. Young Patches:
  15354. asterisk-20904-nat-auto-and-rt-peersv2.diff Michael L. Young
  15355. (license 5026) ........ Merged revisions 382322 from
  15356. http://svn.asterisk.org/svn/asterisk/branches/11
  15357. 2013-02-28 21:59 +0000 [r382297-382299] Joshua Colp <jcolp@digium.com>
  15358. * /, res/res_rtp_asterisk.c: While the ICE negotiation is occurring
  15359. leave strictrtp in an open state, media can and will come from
  15360. different places. ........ Merged revisions 382298 from
  15361. http://svn.asterisk.org/svn/asterisk/branches/11
  15362. * res/res_rtp_asterisk.c, /: Fix a bug with ICE and strictrtp where
  15363. media could get dropped. If the end result of the ICE negotiation
  15364. resulted in the path for media changing it was possible for the
  15365. strictrtp code to discard the RTP packets. This change causes
  15366. strictrtp to enter learning mode once again when the ICE
  15367. negotiation has completed successfully. ........ Merged revisions
  15368. 382296 from http://svn.asterisk.org/svn/asterisk/branches/11
  15369. 2013-02-28 21:31 +0000 [r382294-382295] Richard Mudgett <rmudgett@digium.com>
  15370. * main/threadpool.c: threadpool: Make ast_threadpool_push() return
  15371. -1 if shutting_down
  15372. * include/asterisk/threadpool.h, main/threadpool.c: threadpool:
  15373. Whitespace and comment corrections.
  15374. 2013-02-28 21:21 +0000 [r382292] Jason Parker <jparker@digium.com>
  15375. * res/res_rtp_asterisk.c, include/asterisk.h: Don't undefine
  15376. bzero()/bcopy(). This was causing build failures against external
  15377. libraries that happened to use them, unless silly hacks were
  15378. added to the modules that used those headers. Review:
  15379. https://reviewboard.asterisk.org/r/2359/
  15380. 2013-02-28 17:17 +0000 [r382232-382236] Matthew Jordan <mjordan@digium.com>
  15381. * /, channels/chan_iax2.c: Prevent deadlock in chan_iax2 when
  15382. attempting to set caller ID A deadlock can occur in chan_iax2
  15383. when it attempts to set the caller ID, as it already holds the
  15384. iax2 private lock and improperly fails to obtain the channel lock
  15385. before calling ast_set_callerid. By not safely obtaining the
  15386. channel lock, a locking inversion can take place, causing a
  15387. deadlock. This patch solves this by calling the required deadlock
  15388. avoidance functions that obtain the channel lock before setting
  15389. the caller ID. Thanks to Pavel for fixing my syntax errors and
  15390. testing this patch out. (closes issue ASTERISK-21128) Reported
  15391. by: Pavel Troller Tested by: Pavel Troller patches:
  15392. ASTERISK-21128-1.8.diff uploaded by mjordan (license 6283)
  15393. ASTERISK-21128-modified-1.8.diff uploaded by Pavel Troller
  15394. (license 6302) ........ Merged revisions 382233 from
  15395. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15396. revisions 382234 from
  15397. http://svn.asterisk.org/svn/asterisk/branches/11
  15398. * /, apps/app_meetme.c, CHANGES: Let channels joining a MeetMe
  15399. conference opt out of the denoiser For some channel drivers,
  15400. specifically those that have a varying rate in the number of
  15401. audio samples, the audio quality for a MeetMe conference can be
  15402. exceedingly poor. This is due to a unilateral application of the
  15403. DENOISE function in func_speex to channels joining the
  15404. conference. The denoiser function in the speex library is
  15405. initialized with the number of audio samples in each sample that
  15406. will be provided to it. If the number of audio samples changes,
  15407. the denoiser has to be thrown away and re-initialized. While this
  15408. could be worked around by removing func_speex, that doesn't help
  15409. if you actually use the denoiser with other channels on the
  15410. system. This patches does the following: * Checks for the
  15411. presence of func_speex as opposed to codec_speex when determining
  15412. if the DENOISE function is present (which is where the function
  15413. is actually implemented) * Adds an option to MeetMe 'n' that
  15414. causes the denoiser to not be applied to a channel when it joins.
  15415. This keeps the current behavior the default, but let's users
  15416. disable the denoiser if it causes problems on their system.
  15417. Review: https://reviewboard.asterisk.org/r/2358 (closes issue
  15418. AST-1062) Reported by: Thomas Arimont ........ Merged revisions
  15419. 382227 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  15420. ........ Merged revisions 382230 from
  15421. http://svn.asterisk.org/svn/asterisk/branches/11
  15422. 2013-02-27 20:31 +0000 [r382203-382204] Richard Mudgett <rmudgett@digium.com>
  15423. * channels/chan_skinny.c: More places to eliminate the cast to argv
  15424. but were not giving warnings.
  15425. * channels/chan_skinny.c: Fix compiler warning by eliminating the
  15426. need for a cast.
  15427. 2013-02-27 16:19 +0000 [r382182] Joshua Colp <jcolp@digium.com>
  15428. * /, channels/chan_sip.c: Relax dialog checking in
  15429. get_sip_pvt_byid_locked so it works when the dialog is forked.
  15430. (closes issue ASTERISK-20638) Reported by: eelcob Patches:
  15431. pedantic-call-pickup-from-tag.patch uploaded by eelcob (license
  15432. 6442) ........ Merged revisions 382171 from
  15433. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15434. revisions 382174 from
  15435. http://svn.asterisk.org/svn/asterisk/branches/11
  15436. 2013-02-26 20:05 +0000 [r382113] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  15437. * /, configure, configure.ac: Consider linux-gnuspe as linux-gnu *
  15438. The powerpcspe Linux port uses linux-gnuspe as the OS string. *
  15439. Our build system shouldn't really care for that, so just call it
  15440. linux-gnu. * Original report: Roland Stigge ,
  15441. http://bugs.debian.org/701505 Review:
  15442. https://reviewboard.asterisk.org/r/2357/ ........ Merged
  15443. revisions 382110 from
  15444. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15445. revisions 382111 from
  15446. http://svn.asterisk.org/svn/asterisk/branches/11
  15447. 2013-02-26 19:36 +0000 [r382109] Walter Doekes <walter+asterisk@wjd.nu>
  15448. * /, channels/chan_sip.c: Correct RPID parsing for unquoted
  15449. display-name. Parsing Remote-Party-ID will now succeed if
  15450. display-name is of the *(token LWS) kind and not just the
  15451. quoted-string kind. Review:
  15452. https://reviewboard.asterisk.org/r/2341/ ........ Merged
  15453. revisions 382107 from
  15454. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15455. revisions 382108 from
  15456. http://svn.asterisk.org/svn/asterisk/branches/11
  15457. 2013-02-26 19:29 +0000 [r382106] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  15458. * /, main/Makefile: Remove unneeded linux-gnueabi* As of r380522
  15459. the configure scripts converts the value of linux-gnueabi* of
  15460. OSARCH to "linux-gnu". So no point in testing for those values.
  15461. ........ Merged revisions 382087 from
  15462. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15463. revisions 382096 from
  15464. http://svn.asterisk.org/svn/asterisk/branches/11
  15465. 2013-02-26 15:52 +0000 [r382067-382070] Matthew Jordan <mjordan@digium.com>
  15466. * apps/app_confbridge.c, /: Clean up ConfBridge commands to account
  15467. for wait_marked users When ConfBridge was refactored to better
  15468. handle the concept of marked, wait_marked, and normal users
  15469. co-existing in a conference (thereby implementing a state machine
  15470. for the conference), the wait_marked users were put into their
  15471. own list of conference participants, separate from the active
  15472. users. This list is used for wait_marked users when they are
  15473. waiting in a conference but no marked user has joined; normal
  15474. users may have joined at this point however. There are several
  15475. AMI/CLI commands that affect conference users that were not
  15476. checking the wait_marked users list: * CLI/AMI commands that
  15477. mute/unmute a participant. In this case, wait_marked users have
  15478. to remain in their particular state and should not be affected -
  15479. however, the commands would return "Channel not found" as opposed
  15480. to the appropriate error condition. * CLI/AMI commands that kick
  15481. a participant. An admin should always be able to kick a
  15482. participant out of the conference. This patch fixes both sets of
  15483. commands, and cleans up the CLI commands slightly by allowing
  15484. them to complete a participant name (this was supposed to have
  15485. been added, but the function call was commented out and wasn't
  15486. implemented). Review: https://reviewboard.asterisk.org/r/2346/
  15487. (closes issue AST-1114) Reported by: John Bigelow Tested by: John
  15488. Bigelow ........ Merged revisions 382068 from
  15489. http://svn.asterisk.org/svn/asterisk/branches/11
  15490. * configs/confbridge.conf.sample, /,
  15491. apps/confbridge/conf_config_parser.c: Ensure that the default
  15492. bridge/user profiles are always available ConfBridge and Page
  15493. require that there always be a default bridge and user profile
  15494. available. While properties of the default profiles can be
  15495. overriden in the configuration file, removing them can create
  15496. situations where neither application can function properly. This
  15497. patch ensures that if an administrator removes the profiles from
  15498. the confbridge.conf configuration file, the profiles are added
  15499. upon load. Documentation clarifying this has been added to the
  15500. confbridge.conf.sample file. Review:
  15501. https://reviewboard.asterisk.org/r/2356/ (closes issue AST-1115)
  15502. Reported by: John Bigelow Tested by: John Bigelow ........ Merged
  15503. revisions 382066 from
  15504. http://svn.asterisk.org/svn/asterisk/branches/11
  15505. 2013-02-25 12:51 +0000 [r382023] Matthew Jordan <mjordan@digium.com>
  15506. * addons/res_config_mysql.c, /: Clean up use of va_end/va_args in
  15507. res_config_mysql There were several problems using variadic
  15508. argument macros in res_config_mysql. * Improper use of va_end.
  15509. Multiple calls to va_end were possible resulting in an unbalanced
  15510. matching of va_start/va_end. * Calls to va_arg after a possible
  15511. encounter of a SENTINEL value. This patch corrects those errors.
  15512. (closes issue ASTERISK-19451) Reported by: wdoekes patches:
  15513. ASTERISK-19451-1.8--2.diff uploaded by wdoekes (License 5674)
  15514. ........ Merged revisions 382021 from
  15515. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15516. revisions 382022 from
  15517. http://svn.asterisk.org/svn/asterisk/branches/11
  15518. 2013-02-25 07:09 +0000 [r382007-382008] Damien Wedhorn <voip@facts.com.au>
  15519. * channels/chan_skinny.c: More called details fixup for skinny.
  15520. Basically sets the callerid and callername to the first device
  15521. talked to for the purposes of putting the the calls made log on
  15522. the device. Does not affect the device displaying who the device
  15523. is currently talking to. Also some minor changes to use
  15524. sub->exten in lieu of l->lastnumberdialed. (closes issue
  15525. ASTERISK-21095) Reported by: wedhorn Tested by: snuffy, myself
  15526. Patches: skinny-calllogsoutbound03.diff uploaded by wedhorn
  15527. (license 5019)
  15528. * channels/chan_skinny.c: Add prinotify messages to skinny. Adds
  15529. both fixed and variable prinotify messages and clearprinotify
  15530. messages to skinny. Also adds cli function for pushing messages
  15531. to devices. i Initial code by snuffy, expanded by myself to
  15532. include fixed messages. (closes issue ASTERISK-21091) Reported
  15533. by: snuffy Tested by: snuffy, myself Patches:
  15534. skinny-prinotify02.diff uploaded by wedhorn (license 5019)
  15535. 2013-02-24 23:01 +0000 [r381918-381977] Matthew Jordan <mjordan@digium.com>
  15536. * channels/chan_jingle.c, /: Set the sin_family on the bind address
  15537. socket during initialization Somehow, chan_jingle has managed to
  15538. operate for years without setting the sin_family on its bindaddr
  15539. socket. This patch properly sets the field during initial module
  15540. load to AF_INET. Note that the patch on the issue was modified
  15541. slightly to change the initialization of the socket from
  15542. allocation of a chan_jingle private to the module initialization,
  15543. as the bindaddr object (which is static) only needs to have the
  15544. address set once. (closes issue ASTERISK-19341) Reported by:
  15545. andre valentin patches: 0105-chan_jingle.patch uploaded by
  15546. avalentin (License 6064) ........ Merged revisions 381975 from
  15547. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15548. revisions 381976 from
  15549. http://svn.asterisk.org/svn/asterisk/branches/11
  15550. * main/manager.c, /: Don't display the AMI ALL class authorization
  15551. for users if they don't have it When converting AMI class
  15552. authorizations to a string representation, the method always
  15553. appends the ALL class authorization. This is especially important
  15554. for events, as they should always communicate that class
  15555. authorization - even if the event itself does not specify ALL as
  15556. a class authorization for itself. (Events have always assumed
  15557. that the ALL class authorization is implied when they are raised)
  15558. Unfortunately, this did mean that specifying a user with
  15559. restricted class authorizations would show up in the 'manager
  15560. show user' CLI command as having the ALL class authorization.
  15561. Rather then modifying the existing string manipulation function,
  15562. this patch adds a function that will only return a string if the
  15563. field being compared explicitly matches class authorization field
  15564. it is being compared against. This prevents ALL from being
  15565. returned unless it is actually specified for the user. (closes
  15566. issue ASTERISK-20397) Reported by: Johan Wilfer ........ Merged
  15567. revisions 381939 from
  15568. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15569. revisions 381943 from
  15570. http://svn.asterisk.org/svn/asterisk/branches/11
  15571. * /, apps/app_parkandannounce.c: Make ParkAndAnnounce return to
  15572. priority + 1 when return context is not defined The
  15573. ParkAndAnnounce application documentation for the optional
  15574. return_context parameter states the following: return_context The
  15575. goto-style label to jump the call back into after timeout.
  15576. Default 'priority+1'. Unfortunately, the application was sending
  15577. the channel back into the dialplan at 'priority', which is the
  15578. ParkAndAnnounce application call. This causes an infinite loop of
  15579. the channel constantly being parked, announced, timed out,
  15580. parked, announced, timed out... while fun, especially for those
  15581. callers you wish to drive to the end of madness, this was not the
  15582. intent of the application. (closes issue ASTERISK-20113) Reported
  15583. by: serginuez patches: app_parkandannounce.diff uploaded by
  15584. serginuez (License 6405) ........ Merged revisions 381916 from
  15585. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15586. revisions 381917 from
  15587. http://svn.asterisk.org/svn/asterisk/branches/11
  15588. 2013-02-22 19:40 +0000 [r381894] Michael L. Young <elgueromexicano@gmail.com>
  15589. * /, res/res_agi.c: Fix FastAGI To Properly Check For A Connection
  15590. When IPv6 support was added to FastAGI, the intent was to have
  15591. the ability to check all addresses resolved for a host since we
  15592. might receive an IPv4 address and an IPv6 address. The problem
  15593. with the current code, is that, since we are doing O_NONBLOCK, we
  15594. get EINPROGRESS when calling ast_connect() but are ignoring this
  15595. instead of handling it. We break out of the loop and continue on.
  15596. When we later call ast_poll(), it succeeds but we never check if
  15597. we have a connection or not on the socket level. We then attempt
  15598. to send data to the host address that we think is setup and it
  15599. fails. We then check the errno and see that we have "connection
  15600. refused" and then return with agi failed. This patch does the
  15601. following: * Handles EINPROGRESS by creating the function
  15602. handle_connection() - ast_poll() was moved into this function -
  15603. This function checks the results of the connection on the socket
  15604. level after calling ast_poll() * Continues to the next address if
  15605. the above fails to create a connection * Once all addresses
  15606. resolved are tried and we still are unable to establish a
  15607. connection, then we return that the FastAGI call failed (closes
  15608. issue ASTERISK-21065) Reported by: Jeremy Kister Tested by:
  15609. Jeremy Kister, Michael L. Young Patches:
  15610. asterisk-21065_poll_correctly_v4.diff Michael L. Young (license
  15611. 5026) Review: https://reviewboard.asterisk.org/r/2330/ ........
  15612. Merged revisions 381893 from
  15613. http://svn.asterisk.org/svn/asterisk/branches/11
  15614. 2013-02-22 15:51 +0000 [r381881] Jonathan Rose <jrose@digium.com>
  15615. * /, apps/app_dial.c: app_dial: Honor the 'c' flag when the calling
  15616. party hangs up Apparently this feature became broken in 11,
  15617. probably as a result of the Hangup Cause project. (closes issue
  15618. ASTERISK-21113) Reprted by: Heiko Wundram Patches: app_dial.patch
  15619. uploaded by Heiko Wundram (license 5822) ........ Merged
  15620. revisions 381880 from
  15621. http://svn.asterisk.org/svn/asterisk/branches/11
  15622. 2013-02-22 01:52 +0000 [r381869] Matthew Jordan <mjordan@digium.com>
  15623. * configure, configure.ac, /: Properly detect launchd Asterisk was
  15624. a little too pro-active in claiming that it found launchd. On
  15625. systems without launchd - such as FreeBSD - this resulted in
  15626. certain items in Asterisk that conflict with launchd to not be
  15627. selectable, such as res_timing_kqueue. (closes issue
  15628. ASTERISK-20749) Reported by: Oleg Baranov ........ Merged
  15629. revisions 381847 from
  15630. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15631. revisions 381848 from
  15632. http://svn.asterisk.org/svn/asterisk/branches/11
  15633. 2013-02-19 19:47 +0000 [r381792] Kevin Harwell <kharwell@digium.com>
  15634. * main/features.c: Write the correct callid to the data1 field in
  15635. queue_log for transfer events. The incorrect callid was being
  15636. written to the "data1" field in queue_log table for transfer
  15637. events. The callid of the queue was being written instead of the
  15638. transfer target's callid. This now gets the correct "transfer to"
  15639. number and places that in the "data1" field of the queue_log
  15640. table when a transfer event is triggered. (closes issue
  15641. ASTERISK-19960) Reported by: vladimir shmagin ........ Merged
  15642. revisions 381770 from
  15643. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15644. revisions 381791 from
  15645. http://svn.asterisk.org/svn/asterisk/branches/11
  15646. 2013-02-19 17:17 +0000 [r381749] Michael L. Young <elgueromexicano@gmail.com>
  15647. * channels/chan_motif.c, include/asterisk/module.h,
  15648. res/snmp/agent.c, main/loader.c, main/cli.c: Add The Status Of A
  15649. Module To The Output Of "CLI> module show" When a module's
  15650. configuration is not loadable, we still load the module but it is
  15651. not in a running state. When trying to troubleshoot, let's say,
  15652. why chan_motif is ignoring inbound XMPP traffic, there is no way
  15653. to indicate that a loaded module is not currently running.
  15654. (closes issue ASTERISK-21108) Reported by: Rusty Newton Tested
  15655. by: Michael L. Young Patches: asterisk-21108_add_status-v2.diff
  15656. Michael L. Young (license 5026) Review:
  15657. https://reviewboard.asterisk.org/r/2331/
  15658. 2013-02-19 16:23 +0000 [r381729-381741] Kevin Harwell <kharwell@digium.com>
  15659. * apps/app_confbridge.c: Confbridge channels staying active when
  15660. all participants leave. If you started/stopped recording of a
  15661. conference multiple times channels would remain active even when
  15662. all participants left the conference. This was due to the fact
  15663. that a reference to the confbridge was being added every time a
  15664. start record command was issued, but when the recording was
  15665. stopped there was no matching de-reference thus keeping the
  15666. conference alive. Made sure only a single reference is added for
  15667. the record thread no matter how many times recording is
  15668. started/stopped. A de-reference is issued upon thread ending.
  15669. Note, this issue is being fixed under AST-1088 since it relates
  15670. to it and should have been corrected along with those
  15671. modifications. (issue AST-1088) Reported by: John Bigelow
  15672. ........ Merged revisions 381737 from
  15673. http://svn.asterisk.org/svn/asterisk/branches/11
  15674. * CHANGES, apps/confbridge/conf_config_parser.c,
  15675. apps/confbridge/include/confbridge.h, apps/app_confbridge.c:
  15676. Added Confbridge record_file_append option. Currently, if one
  15677. starts, stops, and then starts a recording again for a conference
  15678. the recorded data is appended to the file originally created on
  15679. the first record start. An option record_file_append has been
  15680. added that defaults to "yes", but when set to "no" will force
  15681. creation of a new file between every record start/stop. (issue
  15682. AST-1088) Reported by: John Bigelow Review:
  15683. http://reviewboard.digium.internal/r/374/
  15684. 2013-02-19 06:54 +0000 [r381717-381718] Damien Wedhorn <voip@facts.com.au>
  15685. * channels/chan_skinny.c, configs/skinny.conf.sample: Add
  15686. serviceURL stuff to skinny. Patch adds all the packet and
  15687. structure stuff to skinny to enable setting service URLs in
  15688. skinny, such as corporate directories. This stuff is only
  15689. relevant during load/unload as when activated. Also some minor
  15690. changes removing duplicated counting of addons and speedials in
  15691. handle_skinny_show_devices. Review:
  15692. https://reviewboard.asterisk.org/r/2321/
  15693. * channels/chan_skinny.c: Fixup skinny CLI completion. Auto
  15694. complete for skinny debug allows multiple options and negation,
  15695. also add debug all option. Usage example: 'skinny debug all
  15696. -packets' (each can be autocompleted including -packet). Change
  15697. show device to use device name. Remove the duplicate ast_strdup's
  15698. from place calling device complete return immediately from
  15699. complete devicename and complete linename so that multiple
  15700. options are displayed on the CLI if more than one option
  15701. available. Review: https://reviewboard.asterisk.org/r/2333/
  15702. 2013-02-18 22:23 +0000 [r381703] Kevin Harwell <kharwell@digium.com>
  15703. * apps/app_confbridge.c, /: Fixed Confbridge file recording
  15704. deadlock and appending. A deadlock occurred after
  15705. starting/stopping and then restarting a confbridge recording.
  15706. Upon starting a recording a record thread is created that holds a
  15707. lock until just before exiting. Stopping the recording does not
  15708. stop/exit the thread or release the lock. The thread waits until
  15709. recording begins again. Starting a stopped recording signals the
  15710. thread to continue and start recording again. However restarting
  15711. the recording also created another record thread resulting in a
  15712. deadlock. The fix was to make sure the record thread was only
  15713. created once. Also it was noted that filenames for the recordings
  15714. were being concatenated for each start/stop. This was fixed by
  15715. creating a new file for each conference session and appending the
  15716. actual recorded data within the file (e.g. passing the 'a' option
  15717. to MixMonitor). (issue AST-1088) Reported by: John Bigelow
  15718. Review: http://reviewboard.digium.internal/r/374/ ........ Merged
  15719. revisions 381702 from
  15720. http://svn.asterisk.org/svn/asterisk/branches/11
  15721. 2013-02-18 20:31 +0000 [r381670] Walter Doekes <walter+asterisk@wjd.nu>
  15722. * configs/sip.conf.sample, /: Remove "registertrying" and add
  15723. "rtp_engine" from/to sip.conf.sample The "registertrying" option
  15724. was removed in r343220. The "rtp_engine" option was added in
  15725. r186078 but erroneously named "engine" in the sample. Note that
  15726. there is no global sip setting for a different engine. ........
  15727. Merged revisions 381668 from
  15728. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15729. revisions 381669 from
  15730. http://svn.asterisk.org/svn/asterisk/branches/11
  15731. 2013-02-18 19:48 +0000 [r381656] Jonathan Rose <jrose@digium.com>
  15732. * funcs/func_presencestate.c, /: PRESENCE_STATE: Provide better
  15733. documentation for the 'e' option. Notes that the 'e' option
  15734. actually decodes data when used as a write function such as with
  15735. the SET application while it encodes data when used to read.
  15736. Review: https://reviewboard.asterisk.org/r/2335/ ........ Merged
  15737. revisions 381655 from
  15738. http://svn.asterisk.org/svn/asterisk/branches/11
  15739. 2013-02-18 19:12 +0000 [r381644] Richard Mudgett <rmudgett@digium.com>
  15740. * apps/app_confbridge.c: confbridge: Add flags column to CLI
  15741. "confbridge list <conference>" * Added the following flags to the
  15742. CLI "confbridge list <conference>" output: A - The user is an
  15743. admin M - The user is a marked user W - The user must wait for a
  15744. marked user to join E - The user will be kicked after the last
  15745. marked user leaves the conference w - The user is waiting for a
  15746. marked user to join * Added the following header to the AMI
  15747. ConfbridgeList events: WaitMarked, EndMarked, and Waiting.
  15748. (closes issue AST-1101) Reported by: John Bigelow Patches:
  15749. confbridge-show-admin3.txt (license #5091) patch uploaded by John
  15750. Bigelow Modified
  15751. 2013-02-16 20:44 +0000 [r381628] Richard Mudgett <rmudgett@digium.com>
  15752. * apps/app_confbridge.c: confbridge: Rename i iterator variables to
  15753. iter.
  15754. 2013-02-16 16:28 +0000 [r381615] Matthew Jordan <mjordan@digium.com>
  15755. * /, channels/chan_sip.c: Don't send presencestate information if
  15756. the state is invalid Previously, presencestate information was
  15757. sent whenever the state was not NOT_SET. When r381594 actually
  15758. returned INVALID presence state in all the places it was supposed
  15759. to, it caused chan_sip to start adding presence state information
  15760. to NOTIFY requests that it previously would not have added.
  15761. chan_sip shouldn't be adding presence state information when the
  15762. provider is in an invalid state; users can't set the state to
  15763. invalid and an invalid state always implies that the provider is
  15764. in an error condition. (issue AST-1084) ........ Merged revisions
  15765. 381613 from http://svn.asterisk.org/svn/asterisk/branches/11
  15766. 2013-02-16 16:24 +0000 [r381614] Joshua Colp <jcolp@digium.com>
  15767. * res/res_sorcery_memory.c, include/asterisk/sorcery.h,
  15768. tests/test_sorcery.c, main/sorcery.c, res/res_sorcery_config.c:
  15769. Add support for retrieving multiple objects from sorcery using a
  15770. regex on their id. Review:
  15771. https://reviewboard.asterisk.org/r/2329/
  15772. 2013-02-15 23:29 +0000 [r381595] Matthew Jordan <mjordan@digium.com>
  15773. * /, main/presencestate.c, funcs/func_presencestate.c,
  15774. main/manager.c: Fix crash in PresenceState AMI action when
  15775. specifying an invalid provider This patch fixes a crash in
  15776. Asterisk that could be caused by using the PresenceState AMI
  15777. action while providing an invalid provider. This patch also adds
  15778. some additional warnings when a user attempts to provide the
  15779. PresenceState action with invalid data, and removes some NOTICE
  15780. statements that were still lurking in the code from testing.
  15781. (closes issue AST-1084) Reported by: John Bigelow Tested by: John
  15782. Bigelow ........ Merged revisions 381594 from
  15783. http://svn.asterisk.org/svn/asterisk/branches/11
  15784. 2013-02-15 18:51 +0000 [r381568] Mark Michelson <mmichelson@digium.com>
  15785. * /, channels/chan_sip.c: Fix a crash that occurred when a BYE was
  15786. received on a replaced dialog. Reference counting for the channel
  15787. and its tech_pvt got messed up at some point between 1.8 and 11.
  15788. The result was that if a BYE for a dialog that had been replaced
  15789. (via an INVITE with Replaces) was received, Asterisk would crash
  15790. due to trying to access data on a channel that was no longer
  15791. there. The fix I introduced is to remove code that both unrefs
  15792. the sip_pvt and sets the channel's tech_pvt to NULL when an
  15793. INVITE with Replaces is handled. This way when a BYE is received,
  15794. the tech_pvt will be non-NULL and so the BYE can be processed and
  15795. not cause a crash. (closes issue ASTERISK-20929) reported by
  15796. Kristopher Lalletti patches: ASTERISK-20929.patch uploaded by
  15797. Mark Michelson (License #5049) ........ Merged revisions 381566
  15798. from http://svn.asterisk.org/svn/asterisk/branches/11
  15799. 2013-02-15 18:44 +0000 [r381567] Matthew Jordan <mjordan@digium.com>
  15800. * include/asterisk/sorcery.h, main/config_options.c,
  15801. main/sorcery.c: Disable strict XML documentation config checking;
  15802. fix crash caused by sorcery This patch does two things: 1. It
  15803. disables (temporarily) strict XML documentation checking for
  15804. module configurations. We should re-enable it before making any
  15805. release from trunk. 2. Pass the module flag AST_MODULE through
  15806. sorcery. This means several of the API calls are now macros and
  15807. will do this automatically for you. The config framework needs
  15808. the module that objects are registering to so it can properly
  15809. construct the documentation. (This was already a required field,
  15810. but sorcery was getting by without it)
  15811. 2013-02-15 17:38 +0000 [r381557] Kevin Harwell <kharwell@digium.com>
  15812. * main/logger.c, include/asterisk/logger.h, main/autoservice.c:
  15813. Stopped spamming of debug messages during attended transfer.
  15814. While autoservice is running and servicing a channel the callid
  15815. is being stored and removed in the thread's local storage for
  15816. each iteration of the thread loop. If debug was set to a
  15817. sufficient level the log file would be spammed with callid thread
  15818. local storage debug messages. Added a new function that checks to
  15819. see if the callid to be stored is different than what is already
  15820. contained (if anything). If it is different then store/replace
  15821. and log, otherwise just leave as is. Also made it so all logging
  15822. of debug messages pertaining to the callid thread storage outputs
  15823. only when TEST_FRAMEWORK is defined. (issue ASTERISK-21014)
  15824. (closes issue ASTERISK-21014) Report by: Rusty Newton Review:
  15825. https://reviewboard.asterisk.org/r/2324/
  15826. 2013-02-15 17:33 +0000 [r381556] Jonathan Rose <jrose@digium.com>
  15827. * /, channels/chan_sip.c: chan_sip: Use video and text crypto
  15828. attributes to append RTP profiles to SDP Some bad copy/pasting
  15829. resulted in using the audio crypto attribute for both text and
  15830. video RTP. Also the audio crypto isn't set until after these, so
  15831. it was really just bad all around. (closes ASTERISK-20905)
  15832. Reported by: Kristopher Lalletti patches:
  15833. rtp_crypto_video_text.diff uploaded by Jonathan Rose (license
  15834. 6182) ........ Merged revisions 381553 from
  15835. http://svn.asterisk.org/svn/asterisk/branches/11
  15836. 2013-02-15 15:26 +0000 [r381527-381543] Matthew Jordan <mjordan@digium.com>
  15837. * /: Remove automerge propertrties added in r381527
  15838. * main/asterisk.c, main/xmldoc.c, main/udptl.c,
  15839. include/asterisk/xml.h, /, main/xml.c,
  15840. include/asterisk/_private.h, res/res_xmpp.c, main/named_acl.c,
  15841. configs/motif.conf.sample, apps/confbridge/conf_config_parser.c,
  15842. Makefile, include/asterisk/config_options.h,
  15843. configs/xmpp.conf.sample, apps/app_skel.c, channels/chan_motif.c,
  15844. include/asterisk/xmldoc.h, main/config_options.c,
  15845. doc/appdocsxml.dtd: Add CLI configuration documentation This
  15846. patch allows a module to define its configuration in XML in
  15847. source, such that it can be parsed by the XML documentation
  15848. engine. Documentation is generated in a two-pass approach: 1. The
  15849. documentation is first generated from the XML pulled from the
  15850. source 2. The documentation is then enhanced by the registration
  15851. of configuration options that use the configuration framework
  15852. This patch include configuration documentation for the following
  15853. modules: * chan_motif * res_xmpp * app_confbridge * app_skel *
  15854. udptl Two new CLI commands have been added: * config show help -
  15855. show configuration help by module, category, and item * xmldoc
  15856. dump - dump the in-memory representation of the XML documentation
  15857. to a new XML file. Review:
  15858. https://reviewboard.asterisk.org/r/2278 Review:
  15859. https://reviewboard.asterisk.org/r/2058 patches: on review 2058
  15860. uploaded by twilson
  15861. 2013-02-14 19:58 +0000 [r381470-381471] Damien Wedhorn <voip@facts.com.au>
  15862. * channels/chan_skinny.c: Remove extraneous stuff from r381470.
  15863. * channels/chan_skinny.c: Add back sending dialnumber to skinny.
  15864. Don't know why it seemed to work during testing, but it really is
  15865. needed for protocol v17 (and probably above).
  15866. 2013-02-14 19:52 +0000 [r381469] Richard Mudgett <rmudgett@digium.com>
  15867. * /, main/features.c: End stuck DTMF if AST_SOFTHANGUP_ASYNCGOTO
  15868. because it isn't a real hangup. It doesn't hurt to check
  15869. AST_SOFTHANGUP_UNBRIDGE either, but it should not be set outside
  15870. of a bridge. (issue ASTERISK-20492) ........ Merged revisions
  15871. 381466 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  15872. ........ Merged revisions 381467 from
  15873. http://svn.asterisk.org/svn/asterisk/branches/11
  15874. 2013-02-14 19:25 +0000 [r381465] Damien Wedhorn <voip@facts.com.au>
  15875. * channels/chan_skinny.c: Respect callerid presentation in skinny.
  15876. Fix chan_skinny so that it respects callerID presentation of
  15877. inbound calls to device and a couple of other minor fixes: 145
  15878. packet (add OCTAL_FROM amd callerid), and dont send dialednumber
  15879. message if protocol >= 17. (closes issue ASTERISK-21066) Reported
  15880. by: snuffy Tested by: snuffy, myself Patches:
  15881. skinny-respect-clid-restrictions-v2.diff uploaded by snuffy
  15882. (license 5024)
  15883. 2013-02-14 18:47 +0000 [r381448] Kinsey Moore <kmoore@digium.com>
  15884. * main/logger.c, include/asterisk/term.h, apps/app_queue.c,
  15885. main/asterisk.c, main/term.c, main/data.c, main/pbx.c,
  15886. main/manager.c: Revamp of terminal color codes The core module
  15887. related to coloring terminal output was old and needed some love.
  15888. The main thing here was an attempt to get rid of the obscene
  15889. number of stack-local buffers that were allocated for no other
  15890. reason than to colorize some output. Instead, this uses a simple
  15891. trick to allocate several buffers within threadlocal storage,
  15892. then automatically rotates between them, so that you can make
  15893. multiple calls to the colorization routine within one function
  15894. and not need to allocate multiple buffers. Review:
  15895. https://reviewboard.asterisk.org/r/2241/ Patches: bug.patch
  15896. uploaded by Tilghman Lesher
  15897. 2013-02-14 17:06 +0000 [r381398-381427] Sean Bright <sean@malleable.com>
  15898. * channels/chan_iax2.c: Use a shuffling algorithm to find unused
  15899. IAX2 call numbers. While adding red-black tree containers to
  15900. astobj2 in r376575, Richard pointed out the way chan_iax2 finds
  15901. unused call numbers will prevent ao2_container integrity checks
  15902. at runtime. This patch removes the ao2_container and instead uses
  15903. fixed sized arrays and a modified Fisher-Yates-Durstenfeld
  15904. shuffle to maintain the call number list. While the locking
  15905. semantics are similar to the ao2_container implementation, this
  15906. implementation should be faster and more memory efficient.
  15907. Review: https://reviewboard.asterisk.org/r/2288/
  15908. * include/asterisk/doxygen/asterisk-git-howto.h: Update the name of
  15909. the update_tags utility in the git mirror how-to.
  15910. 2013-02-14 03:49 +0000 [r381366] Matthew Jordan <mjordan@digium.com>
  15911. * apps/app_db.c, /: Don't throw a spurious error when using
  15912. DBdeltree The function call ast_db_deltree returns the number of
  15913. row deleted, or a negative number if it failed. DBdeltree was
  15914. treating any non-zero return as an error, causing a spurious
  15915. verbose error message to be displayed. This patch handles the
  15916. return code of ast_db_deltree correctly. (closes issue
  15917. ASTERISK-21070) Reported by: ianc patches: dbdeltree.diff
  15918. uploaded by ianc (License #5955) ........ Merged revisions 381364
  15919. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  15920. Merged revisions 381365 from
  15921. http://svn.asterisk.org/svn/asterisk/branches/11
  15922. 2013-02-12 21:45 +0000 [r381326] David M. Lee <dlee@digium.com>
  15923. * tests/test_threadpool.c, tests/test_taskprocessor.c,
  15924. main/threadpool.c, main/taskprocessor.c,
  15925. include/asterisk/threadpool.h: Add a serializer interface to the
  15926. threadpool This patch adds the ability to create a serializer
  15927. from a thread pool. A serializer is a ast_taskprocessor with the
  15928. same contract as a default taskprocessor (tasks execute serially)
  15929. except instead of executing out of a dedicated thread, execution
  15930. occurs in a thread from a ast_threadpool. Think of it as a
  15931. lightweight thread. While it guarantees that each task will
  15932. complete before executing the next, there is no guarantee as to
  15933. which thread from the pool individual tasks will execute. This
  15934. normally only matters if your code relys on thread specific
  15935. information, such as thread locals. This patch also fixes a bug
  15936. in how the 'was_empty' parameter is computed for the push
  15937. callback, and gets rid of the unused 'shutting_down' field.
  15938. Review: https://reviewboard.asterisk.org/r/2323/
  15939. 2013-02-12 20:57 +0000 [r381307] Mark Michelson <mmichelson@digium.com>
  15940. * main/rtp_engine.c, /: Do not allow native RTP bridging if
  15941. packetization of media streams differs. The RTP engine will no
  15942. longer allow for local and remote native RTP bridges if
  15943. packetization of streams differs. Allowing native bridging in
  15944. this scenario has been known to cause FAX failures. (closes
  15945. ASTERISK-20650) Reported by: Maciej Krajewski Patches:
  15946. ASTERISK-20659.patch uploaded by Mark Michelson (License #5049)
  15947. Review: https://reviewboard.asterisk.org/r/2319 ........ Merged
  15948. revisions 381281 from
  15949. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15950. revisions 381306 from
  15951. http://svn.asterisk.org/svn/asterisk/branches/11
  15952. 2013-02-12 20:18 +0000 [r381285] Kinsey Moore <kmoore@digium.com>
  15953. * /, channels/chan_sip.c, channels/sip/security_events.c,
  15954. channels/sip/include/sip.h: Fix some more REF_DEBUG-related build
  15955. errors When sip_ref_peer and sip_unref_peer were exported to be
  15956. usable in channels/sip/security_events.c, modifications to those
  15957. functions when building under REF_DEBUG were not taken into
  15958. account. This change moves the necessary defines into sip.h to
  15959. make them accessible to other parts of chan_sip that need them.
  15960. ........ Merged revisions 381282 from
  15961. http://svn.asterisk.org/svn/asterisk/branches/11
  15962. 2013-02-12 03:31 +0000 [r381256] Michael L. Young <elgueromexicano@gmail.com>
  15963. * apps/app_confbridge.c: Adding Some More Manager Events To
  15964. ConfBridge Currently, ConfBridge does not send manager events for
  15965. ConfbridgeMute, ConfbridgeUnmute, ConfbridgeStartRecord and
  15966. ConfbridgeStopRecord. This patch adds these events to the
  15967. manager. The reporter's patch moves some other events up to the
  15968. beginning of the file. The patch being committed is based on the
  15969. patch contributed from the reporter of this issue. I have made a
  15970. lot of modifications to the patch in order for it to fit in
  15971. better with what we currently are doing in the code when it comes
  15972. to manager events. I also made a few changes to the <see-also>
  15973. elements on some of the events. (closes issue ASTERISK-20827)
  15974. Reported by: Clint Davis Tested by: Clint Davis, Michael L. Young
  15975. Patches: 20827.diff uploaded by Clint Davis (license 6453)
  15976. asterisk-20827-confbridge-events.diff uploaded by Michael L.
  15977. Young (license 5026) Review:
  15978. https://reviewboard.asterisk.org/r/2309/
  15979. 2013-02-11 21:17 +0000 [r381219] Kevin Harwell <kharwell@digium.com>
  15980. * /, apps/app_playback.c: Properly load say.conf upon reload of
  15981. module app_playback. If say.conf did not exists prior to
  15982. originally loading module app_playback it would not load on
  15983. subsequent reloads of the module once it had been created. This
  15984. occurred because upon reload of the app_playback module it would
  15985. only load a new configuration if an old one had previously
  15986. existed. This fix simply removed the association between checking
  15987. if an old configuration existed and the loading of the new one.
  15988. (closes issue ASTERISK-20800) Reported by: pgoergler ........
  15989. Merged revisions 381216 from
  15990. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15991. revisions 381217 from
  15992. http://svn.asterisk.org/svn/asterisk/branches/11
  15993. 2013-02-11 21:10 +0000 [r381218] Kinsey Moore <kmoore@digium.com>
  15994. * include/asterisk/astobj2.h: Fix compilation error with REF_DEBUG
  15995. When the red/black tree work was committed, there was an extra ",
  15996. " in the REF_DEBUG definition of ao2_container_alloc_rbtree.
  15997. 2013-02-11 20:39 +0000 [r381214] David M. Lee <dlee@digium.com>
  15998. * tests/test_json.c, res/res_json.c: Minor fixes to res_json and
  15999. test_json. * Made input checking more consistent with other
  16000. Asterisk code * Added validation to ast_json_dump_new_file *
  16001. Fixed tests for ownereship semantics (issue ASTERISK-20887)
  16002. 2013-02-11 18:54 +0000 [r381195] Damien Wedhorn <voip@facts.com.au>
  16003. * channels/chan_skinny.c: Fix some issues with skinny callid. Add
  16004. extra string to transmit_callinfo_var, Only set string2 to tonum
  16005. for outgoing calls and changes to send_callinfo and push_callinfo
  16006. to not set callid name to last number. (closes issue
  16007. ASTERISK-21063) Reported by: wedhorn Tested by: snuffy, myself
  16008. Patches: skinny-callinfoupdate03.diff uploaded by wedhorn
  16009. (license 5019)
  16010. 2013-02-11 18:00 +0000 [r381177] Richard Mudgett <rmudgett@digium.com>
  16011. * main/features.c: features: Don't cache a struct ast_app pointer.
  16012. Caching a struct ast_app pointer is not a good idea because
  16013. someone could unload the application. After the applicaiton
  16014. unload the cached ast_app pointer is no longer valid. Only pbx.c
  16015. can cache the pointer because it knows when the application is
  16016. unloaded and removes the pointer. * Fixed one-touch Monitor and
  16017. MixMonitor to not cache the ast_app pointer and not use the silly
  16018. monitor_ok/mixmonitor_ok/stopmixmonitor_ok flags. * Extracted
  16019. bridge_check_monitor() from ast_bridge_call() and use propper
  16020. locking.
  16021. 2013-02-11 15:11 +0000 [r381160] Matthew Jordan <mjordan@digium.com>
  16022. * /, res/res_xmpp.c: Fix crash in res_xmpp when deleting pubsub
  16023. node from CLI An error existed in res_xmpp where it would attempt
  16024. to delete attributes from a node that itself was also deleted.
  16025. Per the iksemel documentation, attributes added using iks_insert
  16026. are copied to the parent node's stack, and will be reclaimed when
  16027. that node is itself destroyed. (closes issue ASTERISK-20982)
  16028. Reported by: marcelloceschia patches: delete-node-fix.diff
  16029. uploaded by marcelloceschia (License 6036) ........ Merged
  16030. revisions 381159 from
  16031. http://svn.asterisk.org/svn/asterisk/branches/11
  16032. 2013-02-10 14:58 +0000 [r381134] Joshua Colp <jcolp@digium.com>
  16033. * include/asterisk/sorcery.h, tests/test_sorcery.c, main/sorcery.c:
  16034. Add additional functionality to the Sorcery API. This commit adds
  16035. native implementation support for copying and diffing objects, as
  16036. well as the ability to load or reload on a per-object type level.
  16037. Review: https://reviewboard.asterisk.org/r/2320/
  16038. 2013-02-09 20:58 +0000 [r381069-381118] Richard Mudgett <rmudgett@digium.com>
  16039. * main/pbx.c: pbx: Fix regression caused by taking advantage of the
  16040. function name sort. Taking advantage of the sorted order of the
  16041. registered functions container requires that they are actually
  16042. inserted in the expected sort order. * Insert the registered
  16043. functions into the container in case sensitive position. As a
  16044. result, only the complete_functions() routine needs to search the
  16045. entire container because it does a case insensitive search for
  16046. convenience. Caught by the unit tests.
  16047. * main/pbx.c: pbx: Make function and application containers take
  16048. advantage of being sorted. * Fixed "core show function" tab
  16049. completion and token count checking. * Refactored function and
  16050. application container handling code to reduce redundancy. * Made
  16051. __ast_pbx_run() return using the defines the caller should
  16052. expect. Doesn't change the returned values. Just made use the
  16053. defines.
  16054. * include/asterisk/channel.h, main/channel.c, channels/chan_sip.c:
  16055. Make ast_do_masquerade() a void function.
  16056. * /, apps/app_confbridge.c: app_confbridge: Fix crash from
  16057. receiving an AMI action after ConfBridge unloaded. Unloading
  16058. ConfBridge caused the next AMI action received to crash Asterisk.
  16059. * Add the missing unregister of AMI action
  16060. ConfbridgeSetSingleVideoSrc when ConfBridge is unloaded. (closes
  16061. issue ASTERISK-20994) Reported by: Jeremy Kister Patches:
  16062. jira_asterisk_20994_v11.patch (license #5621) patch uploaded by
  16063. rmudgett Tested by: Rusty Newton, Jeremy Kister ........ Merged
  16064. revisions 381067 from
  16065. http://svn.asterisk.org/svn/asterisk/branches/11
  16066. 2013-02-08 17:36 +0000 [r381068] Jonathan Rose <jrose@digium.com>
  16067. * configs/features.conf.sample, main/features.c, CHANGES: Call
  16068. Parking: Set PARKINGLOT and PARKINGSLOT variables on all parked
  16069. calls These two variables were previously not being set when
  16070. comebacktoorigin=yes and the example configs seemed to imply that
  16071. they should be. Since there is no harm in this and since calls
  16072. that are sent back to origin are capable of continuing in the
  16073. dialplan, this seemed like a no-brainer. Also it supports some
  16074. bridging tests I've been working on.
  16075. 2013-02-07 17:57 +0000 [r381037] Joshua Colp <jcolp@digium.com>
  16076. * res/res_sorcery_config.c: Fix a bug where a changed configuration
  16077. file might not be available to all sorcery object types. Since
  16078. res_sorcery_config used a static name of "res_sorcery_config" to
  16079. inform the configuration file API that it asked for the
  16080. configuration file it was possible during a reload for some
  16081. sorcery object types not to receive the new configuration file.
  16082. This change introduces a UUID on a per-sorcery config instance
  16083. basis so that the unchanged state is kept on an instance basis
  16084. and not for the res_sorcery_config module as a whole.
  16085. 2013-02-07 15:16 +0000 [r381017] Kinsey Moore <kmoore@digium.com>
  16086. * include/asterisk/stringfields.h, tests/test_stringfields.c: Add
  16087. aggregate operations for stuctures with string fields Add
  16088. struct-level comparison and copying of string fields to reduce
  16089. the complexity of whole-struct comparison and copying when using
  16090. string fields. The new macros do not take into account
  16091. non-stringfield data. Review:
  16092. https://reviewboard.asterisk.org/r/2308/
  16093. 2013-02-06 20:18 +0000 [r380977] David M. Lee <dlee@digium.com>
  16094. * /, channels/chan_sip.c: Fixed failing test from r380696. When I
  16095. added my extensive suite of session timer unit tests, apparently
  16096. one of them was failing and I never noticed. If neither Min-SE
  16097. nor Session-Expires is set in the header, it was responding with
  16098. a Session-Expires of the global maxmimum instead of the
  16099. configured max for the endpoint. (issue ASTERISK-20787) ........
  16100. Merged revisions 380973 from
  16101. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16102. revisions 380974 from
  16103. http://svn.asterisk.org/svn/asterisk/branches/11
  16104. 2013-02-06 08:44 +0000 [r380925-380943] Damien Wedhorn <voip@facts.com.au>
  16105. * /, channels/chan_skinny.c: Fix reload skinny with active devices.
  16106. Patch ensures that d->activeline and l->activesub are moved over
  16107. to the new device and line so that on callend the appropriate
  16108. subs can be found to complete hangup before device resets.
  16109. (closes issue ASTERISK-16610) Reported by: wedhorn Tested by:
  16110. snuffy, myself Patches: skinny-reloadactive01.diff uploaded by
  16111. wedhorn (license 5019) ........ Merged revisions 380942 from
  16112. http://svn.asterisk.org/svn/asterisk/branches/11
  16113. * configs/skinny.conf.sample, channels/chan_skinny.c: Reset skinny
  16114. vmexten and immeddial char on reload. Make skinny reset vmexten
  16115. and immeddial to '\0' on reload to ensure that it is set to '\0'
  16116. if the appropriate item is removed/commented in skinny.conf. Also
  16117. small fix re immeddial char in skinny.conf and add immedial
  16118. setting to skinny show settings. (closes issue ASTERISK-21037)
  16119. Reported by: snuffy Tested by: snuffy, myself Patches:
  16120. immed_dial_fix.diff uploaded by snuffy (license 5024)
  16121. 2013-02-05 19:11 +0000 [r380855-380896] Richard Mudgett <rmudgett@digium.com>
  16122. * apps/app_confbridge.c, /, apps/app_page.c: app_page and
  16123. app_confbridge: Fix custom announcement on entering conference.
  16124. The Page and ConfBridge custom announcement did not play when
  16125. users entered the conference. * Fix the
  16126. CONFBRIDGE(user,announcement) file not getting played. The code
  16127. to do this got removed accidentally when the ConfBridge code was
  16128. restructured to be more state machine like. * Fixed
  16129. play_prompt_to_user() doxygen comments. * Fixed the Page A(x) and
  16130. n options for the caller. The caller never played the
  16131. announcement file and totally ignored the n option. The code to
  16132. do this was lost when the application was converted to use
  16133. ConfBridge. * Factored out setup_profile_bridge(),
  16134. setup_profile_paged(), and setup_profile_caller() routines to
  16135. setup ConfBridge profiles. Made each profile setup routine use
  16136. the default template if one has not already been setup by
  16137. dialplan. (closes issue ASTERISK-20990) Reported by: Jeremy
  16138. Kister Tested by: rmudgett ........ Merged revisions 380894 from
  16139. http://svn.asterisk.org/svn/asterisk/branches/11
  16140. * /, apps/confbridge/conf_state_multi_marked.c: app_confbridge: Fix
  16141. error messages on exiting conference. A marked user ending a
  16142. conference with only end_marked users generates error messages:
  16143. ERROR[0000][C-00000000]: confbridge/conf_state.c:47
  16144. conf_invalid_event_fn: Invalid event for confbridge user '' * The
  16145. MULTI_MARKED state was doing too much when it was kicking out the
  16146. end_marked users from the conference. The kicked out users will
  16147. clean up after themselves when they exit the conference. (closes
  16148. issue ASTERISK-20991) Reported by: Jeremy Kister Tested by:
  16149. rmudgett ........ Merged revisions 380892 from
  16150. http://svn.asterisk.org/svn/asterisk/branches/11
  16151. * /, apps/app_page.c: app_page: Fixup application XML documentation
  16152. typos and inaccuracies. ........ Merged revisions 380869 from
  16153. http://svn.asterisk.org/svn/asterisk/branches/11
  16154. * apps/confbridge/conf_config_parser.c, /: Because the compiler can
  16155. check types with a struct copy and memcpy() cannot. ........
  16156. Merged revisions 380856 from
  16157. http://svn.asterisk.org/svn/asterisk/branches/11
  16158. * main/dial.c, /: Separate option_types[] from the struct
  16159. definition. Updated the option_types[] doxygen comment. ........
  16160. Merged revisions 380853 from
  16161. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16162. revisions 380854 from
  16163. http://svn.asterisk.org/svn/asterisk/branches/11
  16164. 2013-02-04 19:52 +0000 [r380817] Jason Parker <jparker@digium.com>
  16165. * /, res/Makefile, res/pjproject/build/common.mak,
  16166. res/pjproject/aconfigure, res/pjproject/build/os-auto.mak.in,
  16167. Makefile, res/pjproject/aconfigure.ac: Fix how we build
  16168. pjproject. Allow parallel builds, better tolerate failures, build
  16169. faster. This also stops running dependencies before top-level
  16170. configure has been run. (closes issue ASTERISK-20815) Review:
  16171. https://reviewboard.asterisk.org/r/2292/ ........ Merged
  16172. revisions 380816 from
  16173. http://svn.asterisk.org/svn/asterisk/branches/11
  16174. 2013-02-02 01:52 +0000 [r380792] Damien Wedhorn <voip@facts.com.au>
  16175. * channels/chan_skinny.c: Add variable length displayprompt packet
  16176. to skinny and use octals. Add new variable length displayprompt
  16177. packet (0x0145) to skinny. Uses the new packet if the device is
  16178. reporting protocol versions >= 17. Add the use of octal codes for
  16179. sending prompts to both the new and old displayprompt messages
  16180. (also cleaned up soft_key_template_default to use the defined
  16181. octal codes). Review: https://reviewboard.asterisk.org/r/2294/
  16182. 2013-02-01 19:35 +0000 [r380774] Richard Mudgett <rmudgett@digium.com>
  16183. * channels/iax2/firmware.c: chan_iax2: Fix compile error if
  16184. MALLOC_DEBUG enabled. NEVER INCLUDE astmm.h DIRECTLY!!
  16185. 2013-02-01 06:37 +0000 [r380755] Damien Wedhorn <voip@facts.com.au>
  16186. * channels/chan_skinny.c: Adds variable length callinfo packets to
  16187. skinny. Add packet 0x014A (variable length call info messages) to
  16188. skinny for newer firmware. Plenty of unknown information but
  16189. includes the equivalent functionality as the fixed size callinfo
  16190. packet already included. Only send this packet if protocol
  16191. reported is >= 17. Review:
  16192. https://reviewboard.asterisk.org/r/2290/
  16193. 2013-01-31 22:03 +0000 [r380738] Jason Parker <jparker@digium.com>
  16194. * res/pjproject/pjlib/src/pj/ssl_sock_ossl.c,
  16195. res/pjproject/pjlib/src/pj/log.c,
  16196. res/pjproject/pjlib/src/pj/pool_buf.c, /,
  16197. res/pjproject/pjsip-apps/src/samples/icedemo.c,
  16198. res/pjproject/pjlib/include/pj/config_site.h,
  16199. res/pjproject/pjmedia/src/test/test.c: Multiple revisions
  16200. 380735-380736 ........ r380735 | qwell | 2013-01-31 15:40:09
  16201. -0600 (Thu, 31 Jan 2013) | 1 line Fix a few compiler warnings.
  16202. ........ r380736 | qwell | 2013-01-31 15:42:34 -0600 (Thu, 31 Jan
  16203. 2013) | 1 line Ignore warnings caused by PJ_TODO()s in pjproject.
  16204. ........ Merged revisions 380735-380736 from
  16205. http://svn.asterisk.org/svn/asterisk/branches/11
  16206. 2013-01-31 20:17 +0000 [r380699] David M. Lee <dlee@digium.com>
  16207. * /, channels/chan_sip.c: Process session timers, even if
  16208. Session-Expires header is missing Previously, Asterisk only
  16209. processed session timer information if both the 'Supported:
  16210. timer' and 'Session-Expires' headers were present. However, the
  16211. Session-Expires header is optional. If we were to receive a
  16212. request with a Min-SE greater than our configured
  16213. session-expires, we would respond with a 'Session-Expires' header
  16214. that was too small. This patch cleans the situation up a bit,
  16215. always processing timer information if the 'Supported: timer'
  16216. header is present. (closes issue ASTERISK-20787) Reported by:
  16217. Mark Michelson Review: https://reviewboard.asterisk.org/r/2299/
  16218. ........ Merged revisions 380696 from
  16219. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16220. revisions 380698 from
  16221. http://svn.asterisk.org/svn/asterisk/branches/11
  16222. 2013-01-31 19:52 +0000 [r380695] Sean Bright <sean@malleable.com>
  16223. * channels/iax2/include/firmware.h (added),
  16224. channels/iax2/include/parser.h, channels/chan_iax2.c,
  16225. channels/iax2/firmware.c (added): Move IAX firmware related
  16226. functionality into separate files. This patch is mostly a
  16227. reorganization of existing code with a few exceptions: * Added
  16228. doxygen comments to all of the extracted functions. * Split
  16229. reload_firmware(int unload) into iax_firmware_reload() and
  16230. iax_firmware_unload() for readability. * Create
  16231. iax_firmware_traverse() to support the 'iax2 show firmware' CLI
  16232. command. * Renamed iax_check_version() to
  16233. iax_firmware_get_version() and change its arguments and return
  16234. value so that it returns a success/failure value and sets the
  16235. selected version into an out parameter to avoid confusion with
  16236. failure and version 0.
  16237. 2013-01-31 19:04 +0000 [r380674] Jason Parker <jparker@digium.com>
  16238. * res/pjproject/build/rules.mak,
  16239. res/pjproject/pjnath/build/Makefile,
  16240. res/pjproject/pjsip/build/Makefile, res/pjproject/aconfigure,
  16241. res/pjproject/pjsip-apps/build/Makefile,
  16242. res/pjproject/aconfigure.ac,
  16243. res/pjproject/pjmedia/build/Makefile,
  16244. res/pjproject/build/cc-auto.mak.in, /,
  16245. res/pjproject/pjlib-util/build/Makefile,
  16246. res/pjproject/pjlib/build/Makefile: Multiple revisions
  16247. 380671-380673 ........ r380671 | qwell | 2013-01-31 12:59:28
  16248. -0600 (Thu, 31 Jan 2013) | 4 lines Remove a cross-compile
  16249. workaround. ar and ranlib can be easily detected with autoconf.
  16250. ........ r380672 | qwell | 2013-01-31 13:00:38 -0600 (Thu, 31 Jan
  16251. 2013) | 2 lines Always check for libm, regardless of configure
  16252. options. ........ r380673 | qwell | 2013-01-31 13:03:03 -0600
  16253. (Thu, 31 Jan 2013) | 7 lines Add support for parallel builds of
  16254. pjproject. Also adds proper dependency checking, and direct .a
  16255. file targets. We don't take advantage of this currently, but we
  16256. will soon. (issue ASTERISK-20815) ........ Merged revisions
  16257. 380671-380673 from
  16258. http://svn.asterisk.org/svn/asterisk/branches/11
  16259. 2013-01-31 18:22 +0000 [r380576-380666] Richard Mudgett <rmudgett@digium.com>
  16260. * bridges/bridge_multiplexed.c: bridge_multiplexed: Keep the
  16261. multiplexed thread until no more bridges use it. * Fixed the
  16262. potential of losing the multiplexed bridge thread when the last
  16263. channel leaves and another joins while the multiplexed thread is
  16264. being shut down. * Refactored and improved the management of the
  16265. serviced channels array. * Changed the channels count to a
  16266. bridges count so it only needs to be incremented rather than
  16267. changed by two.
  16268. * main/frame.c, funcs/func_frame_trace.c: Improve func FRAME_TRACE
  16269. DTMF digit format.
  16270. * include/asterisk/bridging.h: Eliminate an unused lock in
  16271. ast_bridge_channel.
  16272. * main/channel.c: Eliminate a use of a C++ keyword as a variable.
  16273. new to new_frame
  16274. * channels/iax2: Add ignore properties to channels/iax2
  16275. * include/asterisk/channel.h, /: Make CHECK_BLOCKING() debug
  16276. message more useful. Change the displayed pthread value to hex
  16277. format so it can be easily matched with CLI core show threads or
  16278. gdb. ........ Merged revisions 380611 from
  16279. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16280. revisions 380612 from
  16281. http://svn.asterisk.org/svn/asterisk/branches/11
  16282. * channels/chan_dahdi.c, /: chan_dahdi: Fix "dahdi show channels
  16283. group" for groups greater than 31. The variable type used was not
  16284. large enough to hold a group bit field. ........ Merged revisions
  16285. 380572 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  16286. ........ Merged revisions 380575 from
  16287. http://svn.asterisk.org/svn/asterisk/branches/11
  16288. 2013-01-30 17:49 +0000 [r380460-380522] Matthew Jordan <mjordan@digium.com>
  16289. * /, configure, configure.ac: Support building Asterisk for
  16290. Raspberry Pi/Raspbian with hard-float support Building Asterisk
  16291. on Raspbian with hard-float support fails as it uses the string
  16292. 'linux-gnueabihf' for host os, as opposed to 'linux-gnueabi'.
  16293. This patch modifies the configure script for Asterisk such that
  16294. it will match on any string beginning with 'linux-gnueabi', as
  16295. opposed to requiring an explicit match. (closes issue
  16296. ASTERISK-21006) Reported by: Christian Hesse Tested by: Christian
  16297. Hesse patches: linux-gnueabihf.patch uploaded by Christian Hesse
  16298. (license 6459) linux-gnueabihf-autoconf.patch uploaded by
  16299. Christian Hesse (license 6459) ........ Merged revisions 380520
  16300. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  16301. Merged revisions 380521 from
  16302. http://svn.asterisk.org/svn/asterisk/branches/11
  16303. * /, channels/chan_sip.c: Unregister SIP provider API if module
  16304. load is declined A user in #asterisk ran into a problem where a
  16305. configuration error prevented the chan_sip module from being
  16306. loaded. Upon fixing their configuratione error, they could no
  16307. longer load the chan_sip module. This was because the
  16308. configuration checking happened after the SIP provider was
  16309. registered with the Asterisk core, and subsequent attempts to
  16310. load the SIP module failed as the provider was already
  16311. registered. Since we want to detect any failure in registering
  16312. chan_sip as early as possible (as that could be emblematic of a
  16313. deeper mismatch between module and Asterisk core), this patch
  16314. does not change the registration location, but does ensure that
  16315. if a module load is declined, we unregister the module as the SIP
  16316. api provider. ........ Merged revisions 380480 from
  16317. http://svn.asterisk.org/svn/asterisk/branches/11
  16318. * /, channels/chan_sip.c: Perform case insensitive comparisons for
  16319. T.38 attributes RFC5347 section 2.5.2 states the following: ...
  16320. The attribute "T38MaxBitRate" was once incorrectly registered
  16321. with IANA as "T38maxBitRate" (lower-case "m"). In accordance with
  16322. T.38 examples and common implementation practice, the form
  16323. "T38MaxBitRate" SHOULD be generated by implementations conforming
  16324. to this package. In general, it is RECOMMENDED that
  16325. implementations of this package accept lowercase, uppercase, and
  16326. mixed upper/lowercase encodings of all the T.38 attributes. ...
  16327. Asterisk currently does not perform case insensitive matching on
  16328. the T.38 attributes. This causes the T38MaxBitRate attribute to
  16329. be negotiated at 2400 baud instead of 14400 (or whatever value
  16330. you actually wanted). This patch makes it so that when we compare
  16331. T.38 attributes, we do so in a case insensitive fashion. Note
  16332. that while the issue reporter did not directly write the patch,
  16333. they contributed to it (and would have provided one themselves if
  16334. the license had gone through a tad faster), and hence get
  16335. attribution for it. Review:
  16336. https://reviewboard.asterisk.org/r/2298/ (closes issue
  16337. ASTERISK-20897) Reported by: Eric Hill Tested by: Eric Hill
  16338. patches: -- uploaded by Eric Hill ........ Merged revisions
  16339. 380458 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  16340. ........ Merged revisions 380465 from
  16341. http://svn.asterisk.org/svn/asterisk/branches/11
  16342. * res/res_calendar_icalendar.c, /: Fix memory leak in
  16343. res_calendar_icalendar The ICalendar module had a systemic memory
  16344. leak on each fetch of data from the ICalendar source. The
  16345. previous fetched data was not being properly disposed. This patch
  16346. makes it so that before each fetch of data, we dispose of the
  16347. previously fetched data. (closes issue ASTERISK-21012) Reported
  16348. by: Joel Vandal Tested by: Joel Vandal ........ Merged revisions
  16349. 380451 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  16350. ........ Merged revisions 380452 from
  16351. http://svn.asterisk.org/svn/asterisk/branches/11
  16352. 2013-01-29 22:58 +0000 [r380433] Sean Bright <sean@malleable.com>
  16353. * channels/iax2/parser.c (added), channels/iax2 (added),
  16354. channels/iax2-parser.h (removed),
  16355. channels/iax2/include/provision.h (added), channels/iax2/include
  16356. (added), channels/iax2/include/parser.h (added), channels/iax2.h
  16357. (removed), channels/iax2-provision.c (removed),
  16358. channels/iax2/provision.c (added), channels/Makefile,
  16359. channels/chan_iax2.c, channels/iax2-parser.c (removed),
  16360. channels/iax2/include/iax2.h (added), channels/iax2-provision.h
  16361. (removed): Move the ancillary iax2 source files into a separate
  16362. sub-directory. This patch just moves the IAX2 source and header
  16363. files into a separate iax2 sub-directory in the channels
  16364. directory, similar to how the sip source files are structured.
  16365. The only thing that was added was an #ifndef to protect
  16366. provision.h from multiple inclusion.
  16367. 2013-01-29 20:19 +0000 [r380407] Joshua Colp <jcolp@digium.com>
  16368. * tests/test_sorcery.c, main/sorcery.c: Fix an issue where building
  16369. with DEBUG_FD_LEAKS enabled would not work due to sorcery using
  16370. calls called "open" and "close".
  16371. 2013-01-29 18:02 +0000 [r380386] Richard Mudgett <rmudgett@digium.com>
  16372. * /, channels/chan_agent.c: chan_agent: Prevent multiple channels
  16373. from logging in as the same agent. Multiple channels logging in
  16374. as the same agent can result in dead channels waiting for a
  16375. condition signal that will never come because another channel
  16376. thread stole it. A symptom is chan_sip repeatedly generating
  16377. warning messages about rescheduling autodestruction of dialogs
  16378. with an agent channel owner. * Made only login_exec() (the app
  16379. AgentLogin) clear the agent_pvt->chan pointer to prevent multiple
  16380. channels from logging in as the same agent. agent_read(),
  16381. agent_call(), and agent_set_base_channel() no longer disconnect
  16382. the agent channel from the agent_pvt. This also eliminates the
  16383. need to keep checking for agent_pvt->chan being NULL. * Made
  16384. agent_hangup() not wake up the AgentLogin agent thread until it
  16385. is done. * Made agent_request() not able to get the agent until
  16386. he has logged in and any wrapup time has expired. * Made
  16387. agent_request() use ast_hangup() instead of agent_hangup() to
  16388. correctly dispose of a channel. * Removed
  16389. agent_set_base_channel(). Nobody calls it and it is a bad thing
  16390. in general. * Made only agent_devicestate() determine the current
  16391. device state of an agent. Note: Agent group device states have
  16392. never been supported. Review:
  16393. https://reviewboard.asterisk.org/r/2260/ ........ Merged
  16394. revisions 380364 from
  16395. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16396. revisions 380384 from
  16397. http://svn.asterisk.org/svn/asterisk/branches/11
  16398. 2013-01-29 17:46 +0000 [r380383] David M. Lee <dlee@digium.com>
  16399. * channels/sip/sdp_crypto.c, /: Corrected crypto tag in SDP ANSWER
  16400. for SRTP. (again) The original fix (r380043) for getting Asterisk
  16401. to respond with the correct tag overlooked some corner cases, and
  16402. the fact that the same code is in 1.8. This patch moves the
  16403. building of the crypto line out of sdp_crypto_process(). Instead,
  16404. it merely copies the accepted tag. The call to sdp_crypto_offer()
  16405. will build the crypto line in all cases now, using a tag of "1"
  16406. in the case of sending offers. (closes issue ASTERISK-20849)
  16407. Reported by: José Luis Millán Review:
  16408. https://reviewboard.asterisk.org/r/2295/ ........ Merged
  16409. revisions 380347 from
  16410. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16411. revisions 380350 from
  16412. http://svn.asterisk.org/svn/asterisk/branches/11
  16413. 2013-01-29 17:06 +0000 [r380349] Jonathan Rose <jrose@digium.com>
  16414. * main/features.c, /: call_parking: Make sure fallbacks are used
  16415. when lacking a flat channel exten A regression was introduced
  16416. which removed automatic fallback behavior from the PBX. This
  16417. behavior was used by call parking (or at least documented as how
  16418. the feature works) in order to select an extension when the flat
  16419. channel extension wasn't available from the comebackcontext.
  16420. Parking now handles the fallbacks internally in order to keep
  16421. behavior matching with how it is documented. (closes issue
  16422. ASTERISK-20716) Reported by: Chris Gentle Review:
  16423. https://reviewboard.asterisk.org/r/2296/ ........ Merged
  16424. revisions 380348 from
  16425. http://svn.asterisk.org/svn/asterisk/branches/11
  16426. 2013-01-29 14:48 +0000 [r380299-380332] Matthew Jordan <mjordan@digium.com>
  16427. * /, channels/chan_sip.c: Ensure that a declined media stream is
  16428. terminated with a '\r\n' In r369028, chan_sip's processing of
  16429. media streams in an SDP was modified to better handle multiple
  16430. offered media streams. Part of that change modified how streams
  16431. were declined. Previously, declined media streams were not
  16432. handled in an RFC compliant manner; now, we set the port number
  16433. to 0 in the media stream definition and proceed on with the next
  16434. media stream. Unfortunately, the formatting of the declined media
  16435. stream forgot to append a '\r\n' to the end of the media stream.
  16436. This is normally added to the accepted media streams later on in
  16437. the processing of the SDP. Since the declined media stream uses a
  16438. different buffer than the accepted media streams (and is a
  16439. malloc'd buffer as opposed to a struct ast_str), it's easier to
  16440. just slap the '\r\n' on the declined media stream buffer rather
  16441. than attempt to append it later on. So, that's what we do. And
  16442. now some devices (and probably some providers) will be a bit
  16443. happier (but probably not terribly happy, since we just rejected
  16444. something they offered). Review:
  16445. https://reviewboard.asterisk.org/r/2297/ (closes issue
  16446. ASTERISK-20908) Reported by: Dennis DeDonatis Tested by: Dennis
  16447. DeDonatis ........ Merged revisions 380331 from
  16448. http://svn.asterisk.org/svn/asterisk/branches/11
  16449. * autoconf/ast_check_pwlib.m4, /, configure,
  16450. include/asterisk/autoconfig.h.in: Update configure script to be
  16451. compatible with ptlib 2.10.9 With ptlib 2.10.9, the configure
  16452. script fails due to grep returning multiple matches for the
  16453. pattern it searches for. This patch updates the pattern matching
  16454. to return only the actual version for the symbol searched for,
  16455. PTLIB_VERSION. (closes issue ASTERISK-20980) Reported by: Stefan
  16456. Reuter patches: ASTERISK-20980-1.patch uploaded by Stefan Reuter
  16457. (license 5339) ........ Merged revisions 380297 from
  16458. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16459. revisions 380298 from
  16460. http://svn.asterisk.org/svn/asterisk/branches/11
  16461. 2013-01-28 21:09 +0000 [r380256] Sean Bright <sean@malleable.com>
  16462. * /, channels/iax2.h, channels/chan_iax2.c: Correct the number of
  16463. available call numbers in IAX2. There is currently an edge case
  16464. where call number 32768 might be allocated for a call, even
  16465. though the IAX2 protocol requires call numbers be only 15 bits.
  16466. This resulted in some unpredictable behavior when call number
  16467. 32678 is chosen. This patch was mostly written by Richard Mudgett
  16468. via ReviewBoard. I'm just committing it. Review:
  16469. https://reviewboard.asterisk.org/r/2293/ ........ Merged
  16470. revisions 380254 from
  16471. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16472. revisions 380255 from
  16473. http://svn.asterisk.org/svn/asterisk/branches/11
  16474. 2013-01-28 01:58 +0000 [r380209-380212] Russell Bryant <russell@russellbryant.com>
  16475. * main/file.c, /: Change cleanup ordering in filestream destructor.
  16476. This patch came about due to a problem observed where wav files
  16477. had an empty header. The header is supposed to be updated in
  16478. wav_close(). It turns out that this was broken when the
  16479. cache_record_files option from asterisk.conf was enabled. The
  16480. cleanup code was moving the file to its final destination
  16481. *before* running the close() method of the file destructor, so
  16482. the header didn't get updated. Another problem here is that the
  16483. move was being done before actually closing the FILE *. Finally,
  16484. the last bug fixed here is that I noticed that wav_close() checks
  16485. for stream->filename to be non-NULL. In the previous cleanup
  16486. order, it's checking a pointer to freed memory. This doesn't
  16487. actually cause anything to break, but it's treading on dangerous
  16488. waters. Now the free() of stream->filename is happening after the
  16489. format module's close() method gets called, so it's safer.
  16490. Review: https://reviewboard.asterisk.org/r/2286/ ........ Merged
  16491. revisions 380210 from
  16492. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16493. revisions 380211 from
  16494. http://svn.asterisk.org/svn/asterisk/branches/11
  16495. * main/logger.c, CHANGES, configs/logger.conf.sample: Add
  16496. queue_log_realtime_use_gmt option to logger.conf Add an option
  16497. that lets you specify that the timestamps going into the realtime
  16498. queue log should be in GMT instead of local time. Review:
  16499. https://reviewboard.asterisk.org/r/2287/
  16500. 2013-01-27 20:33 +0000 [r380194] Michael L. Young <elgueromexicano@gmail.com>
  16501. * apps/confbridge/conf_config_parser.c, /: Fix Some Configured
  16502. Conference Bridge Sounds Not Being Set The "sound_only_one" sound
  16503. was not being set even though it was configured. In looking into
  16504. this, I found that the "join" and "leave" prompts were not being
  16505. set either. (closes issue ASTERISK-20898) Reported by: Stephan
  16506. Tested by: Stephan Patches:
  16507. asterisk-20898-custom-sounds-ignored.diff uploaded by Michael L.
  16508. Young (license 5026) Review:
  16509. https://reviewboard.asterisk.org/r/2289/ ........ Merged
  16510. revisions 380193 from
  16511. http://svn.asterisk.org/svn/asterisk/branches/11
  16512. 2013-01-27 18:40 +0000 [r380165-380178] Joshua Colp <jcolp@digium.com>
  16513. * tests/test_sorcery.c: Add a unit test which confirms the apply
  16514. handler callback is called when it should be.
  16515. * main/sorcery.c: Fix a bug where the apply function was not
  16516. getting called.
  16517. 2013-01-25 23:23 +0000 [r380142] Richard Mudgett <rmudgett@digium.com>
  16518. * bridges/bridge_multiplexed.c: bridge_multiplexed: Rename
  16519. variables so they are not the same as the struct name. * Rename
  16520. multiplexed_thread variables to muxed_thread. It is shorter and
  16521. my editer tagging works much better. Struct names and variable
  16522. names have different purposes and therefore should have different
  16523. names. * Renamed the multiplexed_threads container to
  16524. muxed_threads for consistency.
  16525. 2013-01-25 20:46 +0000 [r380121] Jason Parker <jparker@digium.com>
  16526. * res/res_sorcery_memory.c, res/res_sorcery_config.c: Make sorcery
  16527. modules global, since they are required by other modules that are
  16528. global.
  16529. 2013-01-25 20:00 +0000 [r380108-380109] Richard Mudgett <rmudgett@digium.com>
  16530. * bridges/bridge_multiplexed.c, main/bridging.c: Misc bridge code
  16531. improvements * Made multiplexed_bridge_destroy() check if
  16532. anything to destroy and cleared bridge_pvt pointer after
  16533. destruction. * Made multiplexed_add_or_remove() handling of the
  16534. chans array simpler. * Extracted bridge_channel_poke(). *
  16535. Simplified bridge_array_remove() handling of the bridge->array[].
  16536. The array does not have a NULL sentinel pointer. * Made
  16537. ast_bridge_new() not create a temporary bridge just to see if it
  16538. can be done. Only need to check if there is an appropriate bridge
  16539. tech available. * Made ast_bridge_new() clean up on allocation
  16540. failures. * Made destroy_bridge() free resources in the opposite
  16541. order of creation.
  16542. * bridges/bridge_simple.c, bridges/bridge_softmix.c,
  16543. bridges/bridge_multiplexed.c, main/bridging.c: More trivial
  16544. bridge code cleanup. * Breaking long lines * Word wrapping
  16545. comment blocks. * Removing redundant initializers. * Debug
  16546. message wording.
  16547. 2013-01-25 14:23 +0000 [r380069-380082] Joshua Colp <jcolp@digium.com>
  16548. * res/res_sorcery_config.c: Add a missing '\' to a log message.
  16549. * configs/test_sorcery.conf.sample (added),
  16550. res/res_sorcery_memory.c (added), configs/sorcery.conf.sample
  16551. (added), include/asterisk/sorcery.h (added), tests/test_sorcery.c
  16552. (added), main/asterisk.c, main/sorcery.c (added),
  16553. res/res_sorcery_config.c (added): Merge the sorcery data access
  16554. layer API. Sorcery is a unifying data access layer which provides
  16555. a pluggable mechanism to allow object creation, retrieval,
  16556. updating, and deletion using different backends (or wizards).
  16557. This is a fancy way of saying "one interface to rule them all"
  16558. where them is configuration, realtime, and anything else that
  16559. comes along. Review: https://reviewboard.asterisk.org/r/2259/
  16560. 2013-01-25 05:49 +0000 [r380057] Damien Wedhorn <voip@facts.com.au>
  16561. * channels/chan_skinny.c, configs/skinny.conf.sample: Add force
  16562. dial keys to skinny. Adds a dial softkey when the device is in
  16563. DAFD. The softkey is greyed (unusable) until a possible dialplan
  16564. match is entered. Code includes updating transmit_selectsoftkeys
  16565. to allow the use of a button mask. Also add option to use # or *
  16566. as a dial now button. Original patch by snuffy cleaned up by
  16567. myself. Review: https://reviewboard.asterisk.org/r/2277/
  16568. 2013-01-24 16:40 +0000 [r380044] David M. Lee <dlee@digium.com>
  16569. * /, channels/sip/sdp_crypto.c: Corrected crypto tag in SDP ANSWER
  16570. for SRTP. When Asterisk responds with an SDP ANSWER for SRTP, it
  16571. had the code to correctly fill in the crypto data, which was
  16572. overwritten by a call to sdp_crypto_offer. Corrected the
  16573. situation by changing sdp_crypto_offer to not replacing crypto
  16574. data if it already exists. (closes issue ASTERISK-20849) Reported
  16575. by: José Luis Millán Tested by: Iñaki Baz Castillo Patches:
  16576. fix_sdp_crypto_tags.diff uploaded by Pedro Kiefer (license 6407)
  16577. ........ Merged revisions 380043 from
  16578. http://svn.asterisk.org/svn/asterisk/branches/11
  16579. 2013-01-24 04:02 +0000 [r380029] Matthew Jordan <mjordan@digium.com>
  16580. * /, apps/app_confbridge.c: Correct documentation for
  16581. ConfbridgeList AMI action The documentation for ConfbridgeList
  16582. states that the Conference field is optional. That's not really
  16583. the case: if you fail to provide a Conference number, the command
  16584. will kick back an error. (closes issue AST-1090) Reported by:
  16585. John Bigelow ........ Merged revisions 380028 from
  16586. http://svn.asterisk.org/svn/asterisk/branches/11
  16587. 2013-01-23 16:50 +0000 [r380004] Kinsey Moore <kmoore@digium.com>
  16588. * contrib/scripts/autosupport: Add support for DPMA to autosupport
  16589. This adds the ability to get the DPMA version, a listing of the
  16590. local firmware directory, and indexes of configured remote
  16591. directories. (closes issue AST-1070) Reported By: Malcolm
  16592. Davenport Tested By: Kinsey Moore <kmoore@digium.com>
  16593. 2013-01-23 00:30 +0000 [r379966] Richard Mudgett <rmudgett@digium.com>
  16594. * main/astobj2.c, /: Attempt to be more helpful when using a bad
  16595. ao2 object pointer. Put the external obj pointer in the message
  16596. instead of the internal version. ........ Merged revisions 379963
  16597. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  16598. Merged revisions 379964 from
  16599. http://svn.asterisk.org/svn/asterisk/branches/11
  16600. 2013-01-22 22:19 +0000 [r379950] Jonathan Rose <jrose@digium.com>
  16601. * /, res/res_fax_spandsp.c: res_fax_spandsp: fix t38 transmission
  16602. bug caused by not returning success This patch fixes the problem,
  16603. but the issue includes a test which is still being considered for
  16604. the automated test suite. (issue ASTERISK-20919) Reported by:
  16605. NITESH BANSAL Patches: patch_ast_fax_spandsp.patch uploaded by
  16606. NITESH BANSAL (license 6418) ........ Merged revisions 379949
  16607. from http://svn.asterisk.org/svn/asterisk/branches/11
  16608. 2013-01-22 20:58 +0000 [r379936] Sean Bright <sean@malleable.com>
  16609. * channels/chan_iax2.c: Remove a large block of commented out code
  16610. from chan_iax2. During the conversion to the newer CLI command
  16611. structure the old definitions were commented out. I think it's
  16612. safe to remove them completely now.
  16613. 2013-01-22 19:29 +0000 [r379912] Jonathan Rose <jrose@digium.com>
  16614. * sounds/Makefile, /, apps/app_meetme.c: app_meetme: Use new
  16615. prompts for administrator menu The old prompts for the
  16616. administrator menu were inadequate. They didn't mention that the
  16617. menu had additional options through the 8 key and pressing the 8
  16618. key wouldn't reveal what those options were. This patch fixes all
  16619. of that while also organizing code pertaining to each individual
  16620. menu type which was previously all stored in one gigantic
  16621. function along with many of the basic conference functions.
  16622. (closes issue AST-996) Reported by: John Bigelow Review:
  16623. http://reviewboard.digium.internal/r/360/ ........ Merged
  16624. revisions 379885 from
  16625. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16626. revisions 379892 from
  16627. http://svn.asterisk.org/svn/asterisk/branches/11
  16628. 2013-01-22 16:48 +0000 [r379864] Richard Mudgett <rmudgett@digium.com>
  16629. * /: Remove stray property.
  16630. 2013-01-22 15:16 +0000 [r379828-379830] Matthew Jordan <mjordan@digium.com>
  16631. * res/res_agi.c, main/file.c, main/app.c, CHANGES,
  16632. include/asterisk/frame.h, apps/app_playback.c,
  16633. apps/app_controlplayback.c, include/asterisk/file.h,
  16634. main/channel.c, funcs/func_frame_trace.c: Add ControlPlayback
  16635. manager action This patch adds the capability for asynchronous
  16636. manipulation of audio being played back to a channel though a new
  16637. AMI action "ControlPlayback". The ControlPlayback action supports
  16638. a number of operations, the availability of which depend on the
  16639. application being used to send audio to the channel. When the
  16640. audio playback was initiated using the ControlPlayback
  16641. application or CONTROL STREAM FILE AGI command, the audio can be
  16642. paused, stopped, restarted, reversed, or skipped forward. When
  16643. initiated by other mechanisms (such as the Playback application),
  16644. the audio can be stopped, reversed, or skipped forward. Review:
  16645. https://reviewboard.asterisk.org/r/2265/ (closes issue
  16646. ASTERISK-20882) Reported by: mjordan
  16647. * /, apps/app_meetme.c: Fix station ringback; trunk hangup issues
  16648. in SLA This patch fixes two bugs: * If an outbound call is made
  16649. from a SLA phone using SLAStation, then there is no ringtone
  16650. audible to the phone that originates the call. The indication of
  16651. the ringing was not being passed to the SLA station; this patch
  16652. fixes that by passing through the progress indications. * If an
  16653. SLA station hangs up before the called party answers, then the
  16654. channel to the called party continues to ring until a timeout
  16655. occurs. If the called party manages to answer, Asterisk attempts
  16656. to connect the called party to a non-existant MeetMe room. This
  16657. patch corrects the behavior by abandoning the call attempt if it
  16658. detects that the SLA station is no longer in use while attempting
  16659. to call the called party. Review:
  16660. https://reviewboard.asterisk.org/r/2275/ (closes issue
  16661. ASTERISK-20462) Reported by: dkerr patches:
  16662. asterisk-11-bugid20440+20462.patch uploaded by dkerr (license
  16663. 5558) asterisk-11-bugid20462.patch uploaded by dkerr (license
  16664. 5558) (closes issue ASTERISK-20440) Reported by: dkerr patches:
  16665. asterisk-11-bugid20440.patch uploaded by dkerr (license 5558)
  16666. asterisk-11-bugid20440+20462.patch uploaded by dkerr (license
  16667. 5558) ........ Merged revisions 379825 from
  16668. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16669. revisions 379826 from
  16670. http://svn.asterisk.org/svn/asterisk/branches/11
  16671. 2013-01-22 00:36 +0000 [r379809] Richard Mudgett <rmudgett@digium.com>
  16672. * /, channels/chan_bridge.c, apps/app_confbridge.c: confbridge:
  16673. Minor fixes playing user counts to the conference. * Generate a
  16674. warning message if sound files do not exist when trying to play
  16675. the user count to the conference. Use the new helper routine
  16676. sound_file_exists() for consistency. * Put the new user into
  16677. autoservice when playing user counts to the conference. * Check
  16678. the return value of ast_bridge_impart(). ........ Merged
  16679. revisions 379808 from
  16680. http://svn.asterisk.org/svn/asterisk/branches/11
  16681. 2013-01-21 20:41 +0000 [r379791] Matthew Jordan <mjordan@digium.com>
  16682. * /, contrib/init.d/rc.redhat.asterisk,
  16683. contrib/init.d/rc.gentoo.asterisk,
  16684. contrib/init.d/rc.slackware.asterisk,
  16685. contrib/init.d/rc.archlinux.asterisk,
  16686. contrib/scripts/safe_asterisk, main/asterisk.c,
  16687. contrib/init.d/rc.suse.asterisk,
  16688. contrib/init.d/rc.mandriva.asterisk,
  16689. contrib/init.d/rc.debian.asterisk: Update init.d scripts to
  16690. handle stderr; readd splash screen for remote consoles When
  16691. r376428 was commited to re-order start up sequences to be more
  16692. tolerant of forking with thread primitives, a few items were
  16693. changed that caused changes in behavior on some distros. This
  16694. includes: * Not displaying the splash screen on a remote console.
  16695. * Displaying an error message on stderr when a remote console
  16696. cannot connect to a running instance of Asterisk. In the first
  16697. case, the splash screen was re-added (thanks to Michael L.
  16698. Young). In the second case, the various init.d scripts were
  16699. modified to pipe stderr to /dev/null, as the error message is
  16700. useful - if you execute a remote console or a remote console
  16701. command execution and it fail, it should tell you. Note that the
  16702. error message was always present, it just failed to be printed
  16703. prior to r376428. Much thanks to the folks who quickly reported
  16704. this problem, provided solutions, and promptly tested the various
  16705. init.d scripts on a variety of distros. (closes issue
  16706. ASTERISK-20945) Reported by: Warren Selby Tested by: Michael L.
  16707. Young, Jamuel Starkey, kaldemar, Danny Nicholas, mjordan patches:
  16708. asterisk-20945-remote-intro-msg.diff uploaded by elguero (license
  16709. 5026) ASTERISK-20945-1.8-mjordan.diff uploaded by mjordan
  16710. (license 6283) ........ Merged revisions 379760 from
  16711. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16712. revisions 379777 from
  16713. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  16714. revisions 379790 from
  16715. http://svn.asterisk.org/svn/asterisk/branches/11
  16716. 2013-01-21 20:35 +0000 [r379753-379789] Richard Mudgett <rmudgett@digium.com>
  16717. * bridges/bridge_builtin_features.c, main/bridging.c: Better
  16718. protect bridge_channel state from other threads.
  16719. * main/bridging.c: Extract common bridging code into bridge_stop()
  16720. and bridge_force_out_all().
  16721. * bridges/bridge_builtin_features.c,
  16722. include/asterisk/bridging_features.h,
  16723. include/asterisk/bridging.h, main/bridging.c: Made some bridging
  16724. API calls void. Some bridging comments updated.
  16725. 2013-01-21 18:47 +0000 [r379721] Kinsey Moore <kmoore@digium.com>
  16726. * codecs/codec_ilbc.c, /: Prevent segfault for interpolated iLBC
  16727. frames When iLBC is being used with a jitter buffer and the jb
  16728. has to interpolate frames, it generates frames with a null
  16729. pointer and a non-zero datalen. This is now handled properly.
  16730. (closes issue ASTERISK-20914) Reported By: John McEleney Patches:
  16731. ASTERISK-20914-1.8.diff uploaded by Matt Jordan (license 6283)
  16732. ........ Merged revisions 379718 from
  16733. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16734. revisions 379719 from
  16735. http://svn.asterisk.org/svn/asterisk/branches/11
  16736. 2013-01-21 18:45 +0000 [r379703-379720] Richard Mudgett <rmudgett@digium.com>
  16737. * main/bridging.c: Trivial bridge code cleanup.
  16738. * include/asterisk/bridging_features.h,
  16739. include/asterisk/bridging.h,
  16740. include/asterisk/bridging_technology.h,
  16741. bridges/bridge_builtin_features.c: Bridge API comment tweaks.
  16742. 2013-01-21 07:26 +0000 [r379678] Damien Wedhorn <voip@facts.com.au>
  16743. * /, channels/chan_skinny.c: Fix device call logging issues in
  16744. skinny Skinny device call logging (ie missed, place and received
  16745. calls) has issues because the incorrect sequence of callstates
  16746. is/can be sent to the device. This patch removes some extra
  16747. callstate updates driven by forces external to skinny and ensures
  16748. the needed intermediary callstate messages are sent. (closes
  16749. issue ASTERISK-20964) Reported by: wedhorn Tested by: snuffy,
  16750. myself Patches: ast11-skinny-calllog01.diff uploaded by wedhorn
  16751. (license 5019) ........ Merged revisions 379677 from
  16752. http://svn.asterisk.org/svn/asterisk/branches/11
  16753. 2013-01-21 04:50 +0000 [r379644] Andrew Latham <lathama@gmail.com>
  16754. * contrib/scripts/install_prereq, /: Add LDAP libraries to install
  16755. script Add LDAP dev package to Debian/Ubuntu install list.
  16756. Existed in Redhat already. (issue ASTERISK-20886) ........ Merged
  16757. revisions 379643 from
  16758. http://svn.asterisk.org/svn/asterisk/branches/11
  16759. 2013-01-21 04:17 +0000 [r379610-379612] Matthew Jordan <mjordan@digium.com>
  16760. * /, apps/app_minivm.c: Fix crash in app_minivm when mime encoding
  16761. string An incorrect string initializations was left in
  16762. ast_str_encode_mime from the patch that converted string
  16763. manipulations to use ast_str strings (r191140). The string
  16764. initialization causes a crash when ast_str_set is called on the
  16765. string later on in the function. (closes issue ASTERISK-18697)
  16766. Reported by: Chris Boot patches:
  16767. minivm-null-pointer-dereference-fix.patch uploaded by bootc
  16768. (license 6309) (issue ASTERISK-20854) Reported by: Chris Warr
  16769. Tested by: Chris Warr ........ Merged revisions 379608 from
  16770. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16771. revisions 379609 from
  16772. http://svn.asterisk.org/svn/asterisk/branches/11
  16773. * /: Re-add merge properties
  16774. 2013-01-20 03:06 +0000 [r379583] Damien Wedhorn <voip@facts.com.au>
  16775. * /, channels/chan_skinny.c: Fix issues with skinny sessions Fixes
  16776. a couple of issues with the way skinny handles sessions by
  16777. ensuring sessions aren't used after being freed. Some other minor
  16778. changes. Review: https://reviewboard.asterisk.org/r/2272/
  16779. ........ Merged revisions 379582 from
  16780. http://svn.asterisk.org/svn/asterisk/branches/11
  16781. 2013-01-19 20:54 +0000 [r379549] Walter Doekes <walter+asterisk@wjd.nu>
  16782. * configure.ac, /, configure, include/asterisk/autoconfig.h.in,
  16783. include/asterisk/compat.h, main/strcompat.c: Add builtin roundf()
  16784. for systems lacking it. (closes issue ASTERISK-16854) Review:
  16785. https://reviewboard.asterisk.org/r/2276 Reported-by: Ovidiu Sas
  16786. ........ Merged revisions 379547 from
  16787. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16788. revisions 379548 from
  16789. http://svn.asterisk.org/svn/asterisk/branches/11
  16790. 2013-01-19 00:19 +0000 [r379518] Matthew Jordan <mjordan@digium.com>
  16791. * main/asterisk.c, /: Fix astcanary startup problem due to wrong
  16792. pid value from before daemon call When Asterisk forks itself into
  16793. the background via a call to daemon, it must re-set the pid value
  16794. of the new process. Otherwise, astcanary gets the pid value of
  16795. the process before the fork, which prevents it from running.
  16796. Asterisk eventually starts lowering its priority, as it can no
  16797. longer communicate with the proverbial canary in the coal mine.
  16798. This patch ensures that the correct process identifier is used by
  16799. astcanary. Note that this is getting committed to 10 as a
  16800. regression fix. (closes issue ASTERISK-20947) Reported by: Jakob
  16801. Hirsch Tested by: mjordan patches:
  16802. asterisk-10.12.0.astcanary_ppid.diff uploaded by Jakob Hirsch
  16803. (license 6113) ........ Merged revisions 379509 from
  16804. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16805. revisions 379510 from
  16806. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  16807. revisions 379513 from
  16808. http://svn.asterisk.org/svn/asterisk/branches/11
  16809. 2013-01-18 22:42 +0000 [r379495] David M. Lee <dlee@digium.com>
  16810. * configure, main/Makefile, configure.ac, Makefile: Up the minimum
  16811. OS X version to 10.6. * This allows us to remove some
  16812. special-case build logic. * 10.5 is down to less that 8% of the
  16813. OS X market share. 10.4 is down to under 2%. * Apple is no longer
  16814. releasing security updates for 10.5 and earlier.
  16815. 2013-01-18 21:52 +0000 [r379479] Kinsey Moore <kmoore@digium.com>
  16816. * /, apps/app_confbridge.c: Fix regression in Confbridge user count
  16817. When the restructuring work got committed to Confbridge in
  16818. r375470 to fix many open issues, it caused a regression in the
  16819. reported count of users when conference information was requested
  16820. via CLI or manager. This corrects the user count and user
  16821. information displayed when listing conference information from
  16822. the CLI and manager. (closes issue ASTERISK-20938) Reported By:
  16823. Timo Teras Patches: confbridge-list.patch uploaded by Timo Teras
  16824. (license 5409) ........ Merged revisions 379478 from
  16825. http://svn.asterisk.org/svn/asterisk/branches/11
  16826. 2013-01-18 21:35 +0000 [r379477] David M. Lee <dlee@digium.com>
  16827. * /, configure, main/Makefile, configure.ac, UPGRADE-11.txt,
  16828. UPGRADE.txt, makeopts.in, Makefile: Specify the -rpath linker
  16829. flag when prefix != /usr. This allows Asterisk to start without
  16830. having to specify the LD_LIBRARY_PATH. This can be disabled by
  16831. passing --disable-rpath to configure. (closes issue
  16832. ASTERISK-20407) Reported by: David M. Lee Review:
  16833. https://reviewboard.asterisk.org/r/2132/ ........ Merged
  16834. revisions 379475 from
  16835. http://svn.asterisk.org/svn/asterisk/branches/11
  16836. 2013-01-18 18:25 +0000 [r379461] Jonathan Rose <jrose@digium.com>
  16837. * /, apps/app_voicemail.c: app_voicemail: Improve msg_id handling
  16838. app_voicemail will no longer issue error messages when it
  16839. retrieves an msg_id with a NULL value from realtime and will
  16840. instead simply populate the msg_id field with a newly generated
  16841. msg_id. In addition, this patch changes the way msg_ids are
  16842. generated to eliminate certain causes of duplicate IDs appearing
  16843. within a single system. In addition, when messages are copied,
  16844. they will now receive a new msg_id. (closes issue ASTERISK-20717)
  16845. Reported by: Alec Davis Review:
  16846. https://reviewboard.asterisk.org/r/2220/ ........ Merged
  16847. revisions 379460 from
  16848. http://svn.asterisk.org/svn/asterisk/branches/11
  16849. 2013-01-18 15:42 +0000 [r379432] Mark Michelson <mmichelson@digium.com>
  16850. * main/threadpool.c (added), main/taskprocessor.c,
  16851. include/asterisk/threadpool.h (added), /,
  16852. include/asterisk/taskprocessor.h, tests/test_threadpool.c
  16853. (added), tests/test_taskprocessor.c (added): Add threadpool
  16854. support to Asterisk. This commit consists of two parts. Part one
  16855. changes the taskprocessor API to be less self-contained. Instead,
  16856. the taskprocessor is now more of a task queue that informs a
  16857. listener of changes to the queue. The listener then has the
  16858. responsibility of executing the tasks as it pleases. There is a
  16859. default listener implementation that functions the same way as
  16860. "classic" taskprocessors, in that it creates a single thread for
  16861. tasks to execute in. Old users of taskprocessors have not been
  16862. altered and still function the same way. Part two introduces the
  16863. threadpool API. A threadpool is a special type of taskprocessor
  16864. listener that has multiple threads associated with it. The
  16865. threadpool also has an optional listener that can adjust the
  16866. threadpool as conditions change. In addition the threadpool has a
  16867. set of options that can allow for the threadpool to grow and
  16868. shrink on its own as tasks are added and executed. Both set of
  16869. changes contain accompanying unit tests. (closes issue
  16870. ASTERISK-20691) Reported By: Matt Jordan Review:
  16871. https://reviewboard.asterisk.org/r/2242
  16872. 2013-01-18 05:31 +0000 [r379394] David M. Lee <dlee@digium.com>
  16873. * channels/sip/include/reqresp_parser.h, /, channels/chan_sip.c,
  16874. channels/sip/reqresp_parser.c: Fix Record-Route parsing for large
  16875. headers. Record-Route parsing copied the header into a char[256]
  16876. array, which can be a problem if the header is longer than that.
  16877. This patch parses the header in place, without the copy, avoiding
  16878. the issue. In addition to the original patch, I added a unit test
  16879. for the new get_in_brackets_const function. (closes issue
  16880. ASTERISK-20837) Reported by: Corey Farrell Patches:
  16881. chan_sip-build_route-optimized-rev1.patch uploaded by Corey
  16882. Farrell (license 5909) (with minor changes by dlee) ........
  16883. Merged revisions 379392 from
  16884. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16885. revisions 379393 from
  16886. http://svn.asterisk.org/svn/asterisk/branches/11
  16887. 2013-01-17 02:32 +0000 [r379344] Matthew Jordan <mjordan@digium.com>
  16888. * addons/chan_mobile.c, /: Fix issue where chan_mobile fails to
  16889. bind to first available port Per the bluez API, in order to bind
  16890. to the first available port, the rc_channel field of the socket
  16891. addressing structure used to bind the socket should be set to 0.
  16892. Previously, Asterisk had set the rc_channel field set to 1,
  16893. causing it to connect to whatever happens to be on port 1. We
  16894. could probably not explicitly set rc_channel to 0 since we memset
  16895. the struct earlier, but explicitly setting it will hopefully
  16896. prevent someone from coming in and setting it to some explicit
  16897. port in the future. (closes issue ASTERISK-16357) Reported by:
  16898. challado Tested by: Alexander Heinz, Nikolay Ilduganov, benjamin,
  16899. eliafino, David van Geyn patches: ASTERISK-16357.diff uploaded by
  16900. Nikolay Ilduganov (license 6253) ........ Merged revisions 379342
  16901. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  16902. Merged revisions 379343 from
  16903. http://svn.asterisk.org/svn/asterisk/branches/11
  16904. 2013-01-16 22:51 +0000 [r379312] Mark Michelson <mmichelson@digium.com>
  16905. * /, main/manager.c: Further fix misinformation in the description
  16906. of manager MailboxStatus command. The description still claimed
  16907. that it returned the number of messages rather than whether there
  16908. were messages waiting. ........ Merged revisions 379310 from
  16909. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16910. revisions 379311 from
  16911. http://svn.asterisk.org/svn/asterisk/branches/11
  16912. 2013-01-16 21:13 +0000 [r379278] Jason Parker <jparker@digium.com>
  16913. * contrib/scripts/install_prereq, /: Reduce number of packages
  16914. install_prereq installs on Debian systems. 'search' will look for
  16915. any package containing the name provided, so we need to force a
  16916. more exact search. ........ Merged revisions 379276 from
  16917. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16918. revisions 379277 from
  16919. http://svn.asterisk.org/svn/asterisk/branches/11
  16920. 2013-01-16 18:09 +0000 [r379231-379233] Richard Mudgett <rmudgett@digium.com>
  16921. * /, main/logger.c: Reduce call-id logging resource usage. Since
  16922. there is no need for the call-id logging ao2 object to have a
  16923. lock, don't create it with one. ........ Merged revisions 379232
  16924. from http://svn.asterisk.org/svn/asterisk/branches/11
  16925. * channels/chan_misdn.c, /: chan_misdn: Fix compile error. (issue
  16926. ASTERISK-15456) ........ Merged revisions 379226 from
  16927. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16928. revisions 379230 from
  16929. http://svn.asterisk.org/svn/asterisk/branches/11
  16930. 2013-01-16 17:46 +0000 [r379144-379229] Matthew Jordan <mjordan@digium.com>
  16931. * /, res/res_xmpp.c, res/res_jabber.c, doc/appdocsxml.dtd: Let
  16932. documentation reference links specify which module they're
  16933. linking to Again, since res_jabber/res_xmpp have duplicate APIs,
  16934. their documentation ref links have to specify which reference
  16935. they're referring to. The various documentation parsers can
  16936. interpret the module attribute however they want in order to
  16937. construct the appropriate links. ........ Merged revisions 379228
  16938. from http://svn.asterisk.org/svn/asterisk/branches/11
  16939. * /, res/res_xmpp.c, res/res_jabber.c, doc/appdocsxml.dtd: Multiple
  16940. revisions 379209-379210 ........ r379209 | mjordan | 2013-01-16
  16941. 09:27:44 -0600 (Wed, 16 Jan 2013) | 8 lines Add module tags to
  16942. documentation for res_jabber/res_xmpp Since res_jabber/res_xmpp
  16943. provide the same APIs (app/func/manager/etc.), the XML
  16944. documentation for each needs to call out which module is
  16945. providing the documentation. The module attribute has been added
  16946. to the various XML fragments for this purpose. ........ r379210 |
  16947. mjordan | 2013-01-16 09:30:20 -0600 (Wed, 16 Jan 2013) | 4 lines
  16948. Update the dtd to actually *support* the module attribute in all
  16949. elements Mea culpa. ........ Merged revisions 379209-379210 from
  16950. http://svn.asterisk.org/svn/asterisk/branches/11
  16951. * addons/chan_mobile.c, /: Fix parsing SMSSRC for SMS messages The
  16952. parser for SMS messages would incorrectly parse out the from
  16953. number. The parsing would incorrectly start scanning for the from
  16954. number at the same index as the first double quote ("); this
  16955. would inadvertently cause it to treat the first double quote as
  16956. the terminating double quote for the from number as well. The
  16957. SMSSRC should now populate correctly. (closes issue
  16958. ASTERISK-16822) Reported by: menschentier Tested by: Jonas Falck
  16959. patches: fixSMSSRC.patch uploaded by jonax (license 6320) (closes
  16960. issue ASTERISK-19153) Reported by: Panos Gkikakis patches:
  16961. sms-sender-fix.diff uploaded by roeften (license 5884) ........
  16962. Merged revisions 379178 from
  16963. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16964. revisions 379179 from
  16965. http://svn.asterisk.org/svn/asterisk/branches/11
  16966. * channels/chan_misdn.c, /: Set the INVALID_EXTEN channel variable
  16967. when chan_misdn forces the 'i' extension The chan_misdn channel
  16968. driver will send a channel with an invalid destination to the 'i'
  16969. extension itself if said extension can be reached. It forgot,
  16970. however, to set the INVALID_EXTEN channel variable when it
  16971. bounces the channel to this extension. Dialplan writers
  16972. everywhere moaned at yet another inconsistency. This is yet
  16973. another example of why duplicating logic in multiple places
  16974. results in bugs that stick around in Jira for just under three
  16975. years. Yes: ASTERISK-15456 was created on January 18th, 2010.
  16976. Patch committed on January 15th, 2013. Ouch. (closes issue
  16977. ASTERISK-15456) Reported by: Thomas Omerzu patches:
  16978. chan_misdn_invalid.patch2 uploaded by Thomas Omerzu (license
  16979. 5927) ........ Merged revisions 379145 from
  16980. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16981. revisions 379146 from
  16982. http://svn.asterisk.org/svn/asterisk/branches/11
  16983. * CHANGES, addons/chan_mobile.c: Add busy detection to chan_mobile
  16984. From the patch author: "First this patch adds general support for
  16985. busy detection. It also adds support for the ECAM command at Sony
  16986. Ericsson phones and also signals busy when only early media was
  16987. received but the call got not answered." Review:
  16988. https://reviewboard.asterisk.org/r/323 (closes issue
  16989. ASTERISK-14527) Reported by: Artem Makhutov Tested by: Artem
  16990. Makhutov patches: busy-full5.patch uploaded by artem (license
  16991. 5757)
  16992. 2013-01-15 22:23 +0000 [r379128] Richard Mudgett <rmudgett@digium.com>
  16993. * main/bridging.c: Fix ast_bridge_features_register() not
  16994. registering builtin features. I broke. Ooops.
  16995. 2013-01-14 21:47 +0000 [r379021-379070] David M. Lee <dlee@digium.com>
  16996. * include/asterisk/test.h: Fixed doc comment for ast_test_validate
  16997. * UPGRADE.txt, include/asterisk/manager.h, main/channel.c: Gently
  16998. reduce masquerade insanity Masquerades are an insane
  16999. implementation detail within Asterisk. It generates a number of
  17000. useless and confusing events, and manipulates channels in a way
  17001. that semantically doesn't make sense. I've given a fairly
  17002. thorough review of masquerade code and its usage on the wiki at
  17003. https://wiki.asterisk.org/wiki/x/IwBRAQ. While ultimately it
  17004. makes the most sense to abandon masquerades altogether, it will
  17005. take some time to completely irradicate. Even then, there may
  17006. always be code that's not worth rewriting to get rid of the
  17007. masquerade. This patch does two things to make masquerades
  17008. slightly less insane: * When swapping the names of the original
  17009. and clone channel, only emit a single rename event of original ->
  17010. original<ZOMBIE>. The original code issued three rename events to
  17011. accomplish the same end. * In addition to swapping the names of
  17012. the channels, also swap their uniqueid's. This allows the
  17013. 'Uniqueid' field to be used as a stable identifier for a channel
  17014. from and external interface, such as AMI. Review:
  17015. https://reviewboard.asterisk.org/r/2266/
  17016. * /, channels/chan_sip.c: Fix XML encoding of 'identity display' in
  17017. NOTIFY messages, continued. When r378933 was merged into 1.8, it
  17018. should have also escaped remote_display, since it will have the
  17019. same XML encoding problem when the caller/callee roles are
  17020. reversed. (closes issue ABE-2902) Reported by: Guenther Kelleter
  17021. ........ Merged revisions 379001 from
  17022. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17023. revisions 379020 from
  17024. http://svn.asterisk.org/svn/asterisk/branches/11
  17025. 2013-01-13 22:07 +0000 [r378985] Matthew Jordan <mjordan@digium.com>
  17026. * res/res_rtp_asterisk.c, /: Reset RTP timestamp; sequence number
  17027. on SSRC change In r370252 for ASTERISK-18404, Asterisk's handling
  17028. of RTP was modified to better account for out of order RTP
  17029. packets. This was accomplished by using the RTP timestamp and
  17030. sequence number to check for out of order packets. However, when
  17031. a SSRC change occurs, the timestamp and sequence number will no
  17032. longer have any relation to the previously received packets. The
  17033. variables tracking the timestamp and sequence number therefore
  17034. have to be reset. (closes issue ASTERISK-20906) Reported by:
  17035. Eelco Brolman patches: dtmf_on_hold.patch uploaded by Eelco
  17036. Brolman (license #6442) ........ Merged revisions 378967 from
  17037. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17038. revisions 378984 from
  17039. http://svn.asterisk.org/svn/asterisk/branches/11
  17040. 2013-01-12 06:43 +0000 [r378935] David M. Lee <dlee@digium.com>
  17041. * include/asterisk/utils.h, /, channels/chan_sip.c,
  17042. tests/test_xml_escape.c (added), main/utils.c: Fix XML encoding
  17043. of 'identity display' in NOTIFY messages. XML encoding in
  17044. chan_sip is accomplished by naively building the XML directly
  17045. from strings. While this usually works, it fails to take into
  17046. account escaping the reserved characters in XML. This patch adds
  17047. an 'ast_xml_escape' function, which works similarly to
  17048. 'ast_uri_encode'. This is used to properly escape the
  17049. local_display attribute in XML formatted NOTIFY messages. Several
  17050. things to note: * The Right Thing(TM) to do would probably be to
  17051. replace the ast_build_string stuff with building an ast_xml_doc.
  17052. That's a much bigger change, and out of scope for the original
  17053. ticket, so I refrained myself. * It is with great sadness that I
  17054. wrote my own ast_xml_escape function. There's one in libxml2, but
  17055. it's knee-deep in libxml2-ness, and not easily used to one-off
  17056. escape a string. * I only escaped the string we know is causing
  17057. problems (local_display). At least some of the other strings are
  17058. URI-encoded, which should be XML safe. Rather than figuring out
  17059. what's safe and escaping what's not, it would be much cleaner to
  17060. simply build an ast_xml_doc for the messages and let the XML
  17061. library do the XML escaping. Like I said, that's out of scope.
  17062. (closes issue ABE-2902) Reported by: Guenther Kelleter Tested by:
  17063. Guenther Kelleter Review:
  17064. http://reviewboard.digium.internal/r/365/ ........ Merged
  17065. revision 378919 from
  17066. https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  17067. ........ Merged revisions 378933 from
  17068. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17069. revisions 378934 from
  17070. http://svn.asterisk.org/svn/asterisk/branches/11
  17071. 2013-01-11 23:05 +0000 [r378918] Joshua Colp <jcolp@digium.com>
  17072. * res/res_xmpp.c, /: Retain XMPP filters across reconnections so
  17073. external modules continue to function as expected. Previously if
  17074. an XMPP client reconnected any filters added by an external
  17075. module were lost. This issue exhibited itself with chan_motif not
  17076. receiving and reacting to Jingle signaling. (closes issue
  17077. ASTERISK-20916) Reported by: kuj ........ Merged revisions 378917
  17078. from http://svn.asterisk.org/svn/asterisk/branches/11
  17079. 2013-01-11 22:31 +0000 [r378915] David M. Lee <dlee@digium.com>
  17080. * include/asterisk/json.h (added), makeopts.in, tests/test_json.c
  17081. (added), contrib/scripts/install_prereq, res/res_json.c (added),
  17082. include/asterisk/test.h, build_tools/menuselect-deps.in,
  17083. configure, include/asterisk/autoconfig.h.in, main/Makefile,
  17084. res/res_json.exports.in (added), configure.ac: Add JSON API for
  17085. Asterisk. This provides a JSON API by pulling in and wrapping the
  17086. Jansson JSON library[1]. The Asterisk API basically mirrors the
  17087. Jansson functionality, with a few minor tweaks. * Some names have
  17088. been asteriskified to protect the innocent. * Jansson provides
  17089. both reference-stealing and reference-borrowing versions of
  17090. several API's. The Asterisk API is exclusively reference-stealing
  17091. for operations that put elements into arrays and objects. * No
  17092. support for doubles, since we usually don't need that. * Coming
  17093. along for the ride is the ast_test_validate macro, which made the
  17094. unit tests much easier to write. [1]:
  17095. http://www.digip.org/jansson/ (issue ASTERISK-20887) (closes
  17096. issue ASTERISK-20888) Review:
  17097. https://reviewboard.asterisk.org/r/2264/
  17098. 2013-01-10 02:40 +0000 [r378789-378889] Richard Mudgett <rmudgett@digium.com>
  17099. * main/channel.c: * Simplify native bridge code in
  17100. ast_channel_bridge(). * Fix an unbalanced
  17101. manager_bridge_event(unlink) call if AST_SOFTHANGUP_UNBRIDGE is
  17102. set in ast_channel_bridge(). * Make ast_channel_bridge() use
  17103. common cleanup code when leaving the bridge.
  17104. * main/channel.c: * Removed some noop code and restructured an
  17105. else-if ladder in ast_generic_bridge(). * Trivial changes in
  17106. ast_channel_bridge().
  17107. * main/channel.c: * Simple optimization of bridge_playfile(). *
  17108. Squeezed some redundancy out of update_bridge_vars(). * Wrapped
  17109. long line in __ast_change_name_nolink().
  17110. * bridges/bridge_softmix.c, bridges/bridge_multiplexed.c: Trivial
  17111. misc bridge code changes. * softmix_bridge_thread() was
  17112. redundantly initializing an 8K buffer. * Promoted a debug message
  17113. to a warning in multiplexed_add_or_remove().
  17114. * main/logger.c: Fix logger.c function definition.
  17115. * bridges/bridge_multiplexed.c, main/bridging.c,
  17116. include/asterisk/bridging_features.h, bridges/bridge_simple.c:
  17117. Trivial misc bridge code changes.
  17118. * include/asterisk/test.h, main/test.c: Tweaked
  17119. __ast_test_suite_assert_notify() and
  17120. __ast_test_suite_event_notify() to be void functions.
  17121. * include/asterisk/test.h, main/test.c: * Whitespace changes. *
  17122. Made ast_test_init() match its prototype.
  17123. * main/udptl.c, main/rtp_engine.c: * Found some more places to use
  17124. ast_channel_lock_both(). * Minor optimization in
  17125. ast_rtp_instance_early_bridge().
  17126. 2013-01-09 20:30 +0000 [r378735-378783] David M. Lee <dlee@digium.com>
  17127. * main/rtp_engine.c, /: Fix end condition in
  17128. ast_rtp_lookup_mime_multiple2. The erroneous end condition would
  17129. never include the AST_RTP_CISCO_DTMF flag in the debug output.
  17130. (closes issue ASTERISK-20772) Reported by: Xavier Hienne ........
  17131. Merged revisions 378776 from
  17132. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17133. revisions 378780 from
  17134. http://svn.asterisk.org/svn/asterisk/branches/11
  17135. * /, include/asterisk/strings.h: Move declaration of
  17136. ast_regex_string_to_regex_pattern futher down strings.h. The
  17137. prior location is before the declaration of struct ast_str, which
  17138. causes compiler warnings. (closes issue ASTERISK-20852) Reported
  17139. by: Pavel Troller Patches: strings.diff uploaded by Pavel Troller
  17140. (license 6302) ........ Merged revisions 378747 from
  17141. http://svn.asterisk.org/svn/asterisk/branches/11
  17142. * /, include/asterisk/causes.h: Replace errant tabs with spaces in
  17143. causes.h. (closes issue ASTERISK-20826) Reported by: snuffy
  17144. Patches: notabs.dif uploaded by snuffy (license 5024) ........
  17145. Merged revisions 378733 from
  17146. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17147. revisions 378734 from
  17148. http://svn.asterisk.org/svn/asterisk/branches/11
  17149. 2013-01-09 00:05 +0000 [r378688-378691] Richard Mudgett <rmudgett@digium.com>
  17150. * apps/app_queue.c, /: app_queue: Fix incorrect assertion. (issue
  17151. ASTERISK-16115) ........ Merged revisions 378689 from
  17152. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17153. revisions 378690 from
  17154. http://svn.asterisk.org/svn/asterisk/branches/11
  17155. * CHANGES, apps/app_queue.c, /, configs/queues.conf.sample,
  17156. UPGRADE.txt: app_queue: Fix multiple calls to a queue member that
  17157. is in only one queue. When ringinuse=no queue members can receive
  17158. more than one call if these calls happen at nearly the same time.
  17159. * Fix so a queue member does not receive more than one call from
  17160. a queue. NOTE: This fix does not prevent multiple calls to a
  17161. member if the member is in more than one queue. * Did some
  17162. refactoring to eliminate some code redundancy. (issue
  17163. ASTERISK-16115) Reported by: nik600 Patches:
  17164. jira_asterisk_16115_single_q_v1.8.patch (license #5621) patch
  17165. uploaded by rmudgett Modified * Revert the -r341580 and -r341599
  17166. changes adding the queues.conf check_state_unknown option as it
  17167. was added in an attempt to fix this problem. The fix did not need
  17168. to be optional. The fix should not have tried to explicitly set
  17169. the device state. Setting the device state by something other
  17170. than the device introduces a race condition. I also could not see
  17171. how the change would be effective other than delaying the
  17172. app_queue code long enough for the device state to propagate to
  17173. app_queue. ........ Merged revisions 378663 from
  17174. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17175. revisions 378683 from
  17176. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17177. revisions 378687 from
  17178. http://svn.asterisk.org/svn/asterisk/branches/11
  17179. 2013-01-06 21:37 +0000 [r378623-378634] Damien Wedhorn <voip@facts.com.au>
  17180. * channels/chan_skinny.c: Skinny blob cleanup Cleanup of red blobs
  17181. in chan_skinny and possible other small formatting issues.
  17182. Review: https://reviewboard.asterisk.org/r/2262/
  17183. * channels/chan_skinny.c: Add group and namedgroup pickup to skinny
  17184. Above says it all. Code by snuff, cleaned up by me. Review:
  17185. https://reviewboard.asterisk.org/r/2246/
  17186. * /, channels/chan_skinny.c: Rewrite skinny dialing to remove
  17187. threaded simpleswitch This rewrite changes skinny dialing from
  17188. the threaded simpleswitch to a scheduled timeout approach. There
  17189. were some underlying issues with the threaded simple switch with
  17190. occasional corruption and possible segfaults. Review:
  17191. https://reviewboard.asterisk.org/r/2240/ ........ Merged
  17192. revisions 378622 from
  17193. http://svn.asterisk.org/svn/asterisk/branches/11
  17194. 2013-01-04 23:14 +0000 [r378593] Jonathan Rose <jrose@digium.com>
  17195. * res/res_srtp.c, /: res_srtp: Prevent a crash from occurring due
  17196. to srtp_create failures in srtp_create Under some circumstances,
  17197. libsrtp's srtp_create function deallocates memory that it wasn't
  17198. initially responsible for allocating. Because we weren't
  17199. initially aware of this behavior, this memory was still used in
  17200. spite of being unallocated during the course of the
  17201. srtp_unprotect function. A while back I made a patch which would
  17202. set this value to NULL, but that exposed a possible condition
  17203. where we would then try to check a member of the struct which
  17204. would cause a segfault. In order to address these problems,
  17205. ast_srtp_unprotect will now set an error value when it ends
  17206. without a valid SRTP session which will result in the caller of
  17207. srtp_unprotect observing this error and hanging up the relevant
  17208. channel instead of trying to keep using the invalid session
  17209. address. (closes issue ASTERISK-20499) Reported by: Tootai
  17210. Review:
  17211. https://reviewboard.asterisk.org/r/2228/diff/#index_header
  17212. ........ Merged revisions 378591 from
  17213. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17214. revisions 378592 from
  17215. http://svn.asterisk.org/svn/asterisk/branches/11
  17216. 2013-01-04 22:19 +0000 [r378585] Kinsey Moore <kmoore@digium.com>
  17217. * res/pjproject/aconfigure, res/pjproject/aconfigure.ac, /,
  17218. res/pjproject/build/common.mak: Fix pjproject compilation in
  17219. certain circumstances On a fresh checkout of Asterisk 11, running
  17220. make before ./configure could cause the pjproject subdirectory to
  17221. get in an odd state that would prevent compilation. This patch by
  17222. Tilghman prevents that from occurring. (closes issue
  17223. ASTERISK-20681) Reported by: Dinesh Ramjuttun Tested by: danilo
  17224. borges, Steve Lang patches: 20121208__ccar_solved.diff.txt
  17225. uploaded by Tilghman Lesher (license 5003) ........ Merged
  17226. revisions 378582 from
  17227. http://svn.asterisk.org/svn/asterisk/branches/11
  17228. 2013-01-04 21:20 +0000 [r378565] Michael L. Young <elgueromexicano@gmail.com>
  17229. * /, channels/chan_sip.c: Fix SIP Notify Messages To Have The
  17230. Proper IP Address In The FROM Field On a multihomed server when
  17231. sending a NOTIFY message, we were not figuring out which network
  17232. should be used to contact the peer. This patch fixes the problem
  17233. by calling ast_sip_ouraddrfor() and then build_via() so that our
  17234. NOTIFY message contains the correct IP address. Also, a debug
  17235. message is being added to help follow the call-id changes that
  17236. occur. This was helpful for confirming that the IP address was
  17237. set properly since the call-id contains the IP address. It also
  17238. will be helpful for troubleshooting purposes when following a
  17239. call in the debug logs. (closes issue ASTERISK-20805) Reported
  17240. by: Bryan Hunt Tested by: Bryan Hunt, Michael L. Young Patches:
  17241. asterisk-20805-notify-ip-v2.diff uploaded by Michael L. Young
  17242. (license 5026) Review: https://reviewboard.asterisk.org/r/2255/
  17243. ........ Merged revisions 378554 from
  17244. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17245. revisions 378559 from
  17246. http://svn.asterisk.org/svn/asterisk/branches/11
  17247. 2013-01-04 21:18 +0000 [r378557] Joshua Colp <jcolp@digium.com>
  17248. * /, res/res_rtp_asterisk.c: Don't pass STUN packets through the
  17249. SRTP unprotect function. (closes issue AST-1036) Reported by:
  17250. jbigelow ........ Merged revisions 378553 from
  17251. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17252. revisions 378555 from
  17253. http://svn.asterisk.org/svn/asterisk/branches/11
  17254. 2013-01-04 16:44 +0000 [r378543] Andrew Latham <lathama@gmail.com>
  17255. * res/res_config_ldap.c: Doxygen Cleanups Baseline clean up of
  17256. formating to make room for extended documentation (issue
  17257. ASTERISK-20259)
  17258. 2013-01-03 22:14 +0000 [r378516] Michael L. Young <elgueromexicano@gmail.com>
  17259. * apps/app_queue.c, /: Fix Queue Log Reporting Every Call
  17260. COMPLETECALLER With "h" Extension Present When the "h" extension
  17261. is present within the context of the queue, all calls are being
  17262. reported COMPLETECALLER even when the agent is hanging up the
  17263. call. This patch checks to see if the agent hung-up or not
  17264. instead of only relying on checking if the queue (caller) channel
  17265. hung-up or not. It would appear that having the h extension in
  17266. the mix, the pbx goes to the h extension, "hanging-up" the queue
  17267. channel and triggering the reporting of COMPLETECALLER. (closes
  17268. issue ASTERISK-20743) Reported by: call Tested by: call, Michael
  17269. L. Young Patches: asterisk-20743-q-cmplt-caller.diff uploaded by
  17270. Michael L. Young (license 5026) Review:
  17271. https://reviewboard.asterisk.org/r/2256/ ........ Merged
  17272. revisions 378514 from
  17273. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17274. revisions 378515 from
  17275. http://svn.asterisk.org/svn/asterisk/branches/11
  17276. 2013-01-03 19:42 +0000 [r378488] Richard Mudgett <rmudgett@digium.com>
  17277. * /, channels/chan_agent.c: chan_agent: Fix wrapup time wait
  17278. response. * Made agent_cont_sleep() and agent_ack_sleep() stop
  17279. waiting if the wrapup time expires. agent_cont_sleep() had tried
  17280. but returned the wrong value to stop waiting. * Made
  17281. agent_ack_sleep() take a struct agent_pvt pointer instead of a
  17282. void pointer for better type safety. ........ Merged revisions
  17283. 378486 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17284. ........ Merged revisions 378487 from
  17285. http://svn.asterisk.org/svn/asterisk/branches/11
  17286. 2013-01-03 18:51 +0000 [r378460] Kinsey Moore <kmoore@digium.com>
  17287. * main/channel.c, /: Add missing test event This test event was
  17288. missing from channel.c causing the dial_LS_options test to fail
  17289. intermittently because of a race condition where most code paths
  17290. emitted the test event but this one did not. The dial_LS_options
  17291. test should stop bouncing now. ........ Merged revisions 378455
  17292. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  17293. Merged revisions 378459 from
  17294. http://svn.asterisk.org/svn/asterisk/branches/11
  17295. 2013-01-03 18:47 +0000 [r378429-378458] Richard Mudgett <rmudgett@digium.com>
  17296. * /, channels/chan_agent.c: chan_agent: Misc code cleanup. * Fix
  17297. off-nominal path resource cleanup in agent_request(). * Create
  17298. agent_pvt_destroy() to eliminate inlined versions in many places.
  17299. * Pull invariant code out of loop in add_agent(). * Remove
  17300. redundant module user references in login_exec(). * Remove unused
  17301. struct agent_pvt logincallerid[] member. ........ Merged
  17302. revisions 378456 from
  17303. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17304. revisions 378457 from
  17305. http://svn.asterisk.org/svn/asterisk/branches/11
  17306. * /, channels/chan_agent.c: chan_agent: Fix agent_indicate()
  17307. locking. Avoid deadlock potential with local channels and
  17308. simplify the locking. ........ Merged revisions 378427 from
  17309. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17310. revisions 378428 from
  17311. http://svn.asterisk.org/svn/asterisk/branches/11
  17312. 2013-01-03 16:04 +0000 [r378414] Tilghman Lesher <tilghman@meg.abyt.es>
  17313. * apps/app_directory.c, contrib/realtime/mysql/voicemail.sql,
  17314. configs/voicemail.conf.sample: Add aliases to the Directory. This
  17315. is an interesting feature that allows additional strings to be
  17316. used to search the Directory, primarily intended to be used with
  17317. nicknames, but could be used with affiliations and the like.
  17318. Because the name field is used in more than one place (such as
  17319. email notifications), it is important that these additional
  17320. strings not be placed in the name field, but be specified
  17321. separately. Review: https://reviewboard.asterisk.org/r/2244/
  17322. 2013-01-03 15:40 +0000 [r378412] Joshua Colp <jcolp@digium.com>
  17323. * /, res/res_xmpp.c: Prevent exhaustion of system resources through
  17324. exploitation of event cache This patch changes res_xmpp to no
  17325. longer cache events under certain circumstances. (issue
  17326. ASTERISK-20175) Reported by: Russell Bryant, Leif Madsen, Joshua
  17327. Colp Tested by: kmoore ........ Merged revisions 378411 from
  17328. http://svn.asterisk.org/svn/asterisk/branches/11
  17329. 2013-01-03 15:37 +0000 [r378377-378410] Matthew Jordan <mjordan@digium.com>
  17330. * /, res/res_xmpp.c: Prevent crashes in res_xmpp when receiving
  17331. large messages Similar to r378287, res_xmpp was marshaling data
  17332. read from an external source onto the stack. For a sufficiently
  17333. large message, this could cause a stack overflow. This patch
  17334. modifies res_xmpp in a similar fashion to res_jabber by removing
  17335. the stack allocation, as it was unnecessary. (issue
  17336. ASTERISK-20658) Reported by: wdoekes ........ Merged revisions
  17337. 378409 from http://svn.asterisk.org/svn/asterisk/branches/11
  17338. * addons/app_mysql.c: Clean up app_mysql's application entry points
  17339. to properly parse arguments When parsing arguments, application
  17340. entry points should not attempt to directly modify the parameters
  17341. to the function. This patch properly duplicates the passed in
  17342. parameters before attempting to parse them. (issue
  17343. ASTERISK-20658) Reported by: wdoekes patches:
  17344. issueA20658_sanitize_app_mysql.patch uploaded by wdoekes (license
  17345. 5674)
  17346. * main/config.c, funcs/func_realtime.c, /: Prevent crashes from
  17347. occurring when reading from data sources with large values When
  17348. reading configuration data from an Asterisk .conf file or when
  17349. pulling data from an Asterisk RealTime backend, Asterisk was
  17350. copying the data on the stack for manipulation. Unfortunately, it
  17351. is possible to read configuration data or realtime data from some
  17352. data source that provides a large blob of characters. This could
  17353. potentially cause a crash via a stack overflow. This patch
  17354. prevents large sets of data from being read from an ARA backend
  17355. or from an Asterisk conf file. (issue ASTERISK-20658) Reported
  17356. by: wdoekes Tested by: wdoekes, mmichelson patches: *
  17357. issueA20658_dont_process_overlong_config_lines.patch uploaded by
  17358. wdoekes (license 5674) * issueA20658_func_realtime_limit.patch
  17359. uploaded by wdoekes (license 5674) ........ Merged revisions
  17360. 378375 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17361. ........ Merged revisions 378376 from
  17362. http://svn.asterisk.org/svn/asterisk/branches/11
  17363. 2013-01-02 21:23 +0000 [r378374] Richard Mudgett <rmudgett@digium.com>
  17364. * main/features.c, include/asterisk/channel.h, main/manager.c, /:
  17365. Fix AMI redirect action with two channels failing to redirect
  17366. both channels. The AMI redirect action can fail to redirect two
  17367. channels that are bridged together. There is a race between the
  17368. AMI thread redirecting the two channels and the bridge thread
  17369. noticing that a channel is hungup from the redirects. * Made the
  17370. bridge wait for both channels to be redirected before exiting. *
  17371. Made the AMI redirect check that all required headers are present
  17372. before proceeding with the redirection. * Made the AMI redirect
  17373. require that any supplied ExtraChannel exist before proceeding.
  17374. Previously the code fell back to a single channel redirect
  17375. operation. (closes issue ASTERISK-18975) Reported by: Ben Klang
  17376. (closes issue ASTERISK-19948) Reported by: Brent Dalgleish
  17377. Patches: jira_asterisk_19948_v11.patch (license #5621) patch
  17378. uploaded by rmudgett Tested by: rmudgett, Thomas Sevestre, Deepak
  17379. Lohani, Kayode Review: https://reviewboard.asterisk.org/r/2243/
  17380. ........ Merged revisions 378356 from
  17381. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17382. revisions 378358 from
  17383. http://svn.asterisk.org/svn/asterisk/branches/11
  17384. 2013-01-02 18:11 +0000 [r378288-378322] Matthew Jordan <mjordan@digium.com>
  17385. * main/event.c, apps/app_confbridge.c,
  17386. apps/confbridge/conf_state_empty.c, funcs/func_devstate.c,
  17387. res/res_calendar.c, include/asterisk/devicestate.h,
  17388. channels/chan_local.c, /, main/ccss.c, channels/chan_sip.c,
  17389. apps/app_meetme.c, main/channel_internal_api.c,
  17390. channels/chan_agent.c, main/devicestate.c,
  17391. include/asterisk/channel.h, res/res_jabber.c, apps/app_queue.c,
  17392. channels/chan_iax2.c, main/channel.c, channels/chan_dahdi.c,
  17393. channels/chan_skinny.c, include/asterisk/event_defs.h,
  17394. main/features.c: Prevent exhaustion of system resources through
  17395. exploitation of event cache Asterisk maintains an internal cache
  17396. for devices in the event subsystem. The device state cache holds
  17397. the state of each device known to Asterisk, such that consumers
  17398. of device state information can query for the last known state
  17399. for a particular device, even if it is not part of an active
  17400. call. The concept of a device in Asterisk can include entities
  17401. that do not have a physical representation. One way that this
  17402. occurred was when anonymous calls are allowed in Asterisk. A
  17403. device was automatically created and stored in the cache for each
  17404. anonymous call that occurred; this was possible in the SIP and
  17405. IAX2 channel drivers and through channel drivers that utilized
  17406. the res_jabber/res_xmpp resource modules (Gtalk, Jingle, and
  17407. Motif). These devices are never removed from the system, allowing
  17408. anonymous calls to potentially exhaust a system's resources. This
  17409. patch changes the event cache subsystem and device state
  17410. management to no longer cache devices that are not associated
  17411. with a physical entity. (issue ASTERISK-20175) Reported by:
  17412. Russell Bryant, Leif Madsen, Joshua Colp Tested by: kmoore
  17413. patches: event-cachability-3.diff uploaded by jcolp (license
  17414. 5000) ........ Merged revisions 378303 from
  17415. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17416. revisions 378320 from
  17417. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17418. revisions 378321 from
  17419. http://svn.asterisk.org/svn/asterisk/branches/11
  17420. * main/http.c, res/res_jabber.c, channels/sip/include/sip.h, /,
  17421. channels/chan_sip.c: Resolve crashes due to large stack
  17422. allocations when using TCP Asterisk had several places where
  17423. messages received over various network transports may be copied
  17424. in a single stack allocation. In the case of TCP, since multiple
  17425. packets in a stream may be concatenated together, this can lead
  17426. to large allocations that overflow the stack. This patch modifies
  17427. those portions of Asterisk using TCP to either favor heap
  17428. allocations or use an upper bound to ensure that the stack will
  17429. not overflow: * For SIP, the allocation now has an upper limit *
  17430. For HTTP, the allocation is now a heap allocation instead of a
  17431. stack allocation * For XMPP (in res_jabber), the allocation has
  17432. been eliminated since it was unnecesary. Note that the HTTP
  17433. portion of this issue was independently found by Brandon Edwards
  17434. of Exodus Intelligence. (issue ASTERISK-20658) Reported by:
  17435. wdoekes, Brandon Edwards Tested by: mmichelson, wdoekes patches:
  17436. ASTERISK-20658_res_jabber.c.patch uploaded by mmichelson (license
  17437. 5049) issueA20658_http_postvars_use_malloc2.patch uploaded by
  17438. wdoekes (license 5674) issueA20658_limit_sip_packet_size3.patch
  17439. uploaded by wdoekes (license 5674) ........ Merged revisions
  17440. 378269 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17441. ........ Merged revisions 378286 from
  17442. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17443. revisions 378287 from
  17444. http://svn.asterisk.org/svn/asterisk/branches/11
  17445. 2013-01-01 19:02 +0000 [r378259] Andrew Latham <lathama@gmail.com>
  17446. * contrib/scripts/install_prereq: Add UUID packages now required to
  17447. configure In ASTERISK-20726 UUID was added to Asterisk. This
  17448. commit is to add the dependancies to the install script
  17449. 2013-01-01 17:10 +0000 [r378248-378249] Sean Bright <sean@malleable.com>
  17450. * main/translate.c: Revert 378248. I changed the logic of this
  17451. function unitentionally, pointed out by file.
  17452. * main/translate.c: Bail out early when building an ast_trans_pvt
  17453. and the translator doesn't supply a 'newpvt'
  17454. 2012-12-31 14:46 +0000 [r378220] Kinsey Moore <kmoore@digium.com>
  17455. * /, channels/chan_sip.c: Ensure chan_sip rejects encrypted streams
  17456. without crypto info This ensures that Asterisk rejects encrypted
  17457. media streams (RTP/SAVP audio and video) that are missing
  17458. cryptographic keys and ensures that the incoming SDP is
  17459. consistent with RFC4568 as far as having a crypto attribute
  17460. present for any SAVP streams. Review:
  17461. https://reviewboard.asterisk.org/r/2204/ ........ Merged
  17462. revisions 378217 from
  17463. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17464. revisions 378218 from
  17465. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17466. revisions 378219 from
  17467. http://svn.asterisk.org/svn/asterisk/branches/11
  17468. 2012-12-20 21:51 +0000 [r378166] Richard Mudgett <rmudgett@digium.com>
  17469. * main/channel.c, /: Give the causes[] a struct name. ........
  17470. Merged revisions 378164 from
  17471. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17472. revisions 378165 from
  17473. http://svn.asterisk.org/svn/asterisk/branches/11
  17474. 2012-12-18 17:48 +0000 [r378122] Kinsey Moore <kmoore@digium.com>
  17475. * main/channel.c, /: Add test events for time limit-related hangups
  17476. This patch adds hangup-related test events in order to support
  17477. testing of time-limited bridges. This aids in testing the S() and
  17478. L() bridge options. (issue SWP-4713) ........ Merged revisions
  17479. 378119 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17480. ........ Merged revisions 378120 from
  17481. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17482. revisions 378121 from
  17483. http://svn.asterisk.org/svn/asterisk/branches/11
  17484. 2012-12-17 23:10 +0000 [r378081-378095] Richard Mudgett <rmudgett@digium.com>
  17485. * main/loader.c, /: Fix potential double free when unloading a
  17486. module. ........ Merged revisions 378092 from
  17487. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17488. revisions 378093 from
  17489. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17490. revisions 378094 from
  17491. http://svn.asterisk.org/svn/asterisk/branches/11
  17492. * channels/chan_local.c, /: Make chan_local module references tied
  17493. to local_pvt lifetime. The chan_local module references were
  17494. manually tied to the existence of the ;1 and ;2 channel links. *
  17495. Made chan_local module references tied to the existence of the
  17496. local_pvt structure as well as automatically take care of the
  17497. module references. * Tweaked the wording of the local_fixup()
  17498. failure warning message to make sense. Review:
  17499. https://reviewboard.asterisk.org/r/2181/ ........ Merged
  17500. revisions 378088 from
  17501. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17502. revisions 378089 from
  17503. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17504. revisions 378090 from
  17505. http://svn.asterisk.org/svn/asterisk/branches/11
  17506. * channels/chan_local.c: chan_local: Parse dial string
  17507. consistently. * Fix local_alloc() unexpected limitation of exten
  17508. and context length from a combined length of 80 characters to a
  17509. normal 80 characters each. * Made local_alloc() and
  17510. local_devicestate() parse the same way.
  17511. 2012-12-17 20:59 +0000 [r378074] Jason Parker <jparker@digium.com>
  17512. * /, main/Makefile: Make libasteriskssl.so symlink use a relative
  17513. path. This was causing issues when using DESTDIR, since the path
  17514. to which the link pointed is not likely to exist (and not useful
  17515. to exist) on the target system. (issue ASTNOW-284) ........
  17516. Merged revisions 378073 from
  17517. http://svn.asterisk.org/svn/asterisk/branches/11
  17518. 2012-12-17 20:34 +0000 [r378072] Richard Mudgett <rmudgett@digium.com>
  17519. * channels/chan_local.c: chan_local: Misc lock and ref tweaks. *
  17520. awesome_locking() does not need to thrash the pvt lock as much. *
  17521. local_setoption() does not need to check for NULL pvt on cleanup
  17522. since it will never be NULL. * Made ref the pvt before locking
  17523. for consistency.
  17524. 2012-12-14 22:45 +0000 [r378064] Richard Mudgett <rmudgett@digium.com>
  17525. * channels/chan_agent.c: chan_agent: Remove some duplicated code.
  17526. No need to check for an agent twice. Santa does that.
  17527. 2012-12-14 22:34 +0000 [r378063] Jonathan Rose <jrose@digium.com>
  17528. * CHANGES, main/features.c, UPGRADE.txt: Features: BRIDGE_FEATURES
  17529. variable automixmonitor support and use proper party
  17530. BRIDGE_FEATURES did not previously support the automixmonitor
  17531. feature. Now it does. In addition, the BRIDGE_FEATURES variable
  17532. would not apply features to the proper party based on whether the
  17533. feature option letter was in caps or in lowercase (both ways
  17534. would apply it to the caller). Now uppercase applies to the
  17535. caller while lowercase applies to the callee (like with the dial
  17536. option)
  17537. 2012-12-14 21:35 +0000 [r378029-378039] Richard Mudgett <rmudgett@digium.com>
  17538. * apps/app_queue.c, /: app_queue: Revert bad ringinuse=no patch.
  17539. With the option ringinuse=no set, the patch committed for
  17540. ASTERISK-16115 causes non-SIP queue members to never be called
  17541. because the device state is checked after a channel is created to
  17542. determine if the member is busy. These queue members always get
  17543. the "Member %s is busy, cannot dial" message. Most channel
  17544. drivers other than chan_sip use the default device state
  17545. handling. The default device-state state is considered in use or
  17546. unknown if the channel exists or not respectively. (closes issue
  17547. ASTERISK-20801) Reported by: rmudgett Patches:
  17548. jira_asterisk_16115_revert_r370418_v1.8.patch (license #5621)
  17549. patch uploaded by rmudgett ........ Merged revisions 378036 from
  17550. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17551. revisions 378037 from
  17552. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17553. revisions 378038 from
  17554. http://svn.asterisk.org/svn/asterisk/branches/11
  17555. * apps/app_queue.c: app_queue: Make update_status() not return
  17556. anything.
  17557. 2012-12-14 01:55 +0000 [r378006-378011] Damien Wedhorn <voip@facts.com.au>
  17558. * /, channels/chan_skinny.c: Fix skinny to recognise vmexten in
  17559. general section of conf Fixup the vmexten so if globally set in
  17560. general section will be honored by chan_skinny. Also get rid of
  17561. the 'global_' part of variable name to match regexten. (closes
  17562. issue ASTERISK-20790) Reported by: snuffy Tested by: snuffy,
  17563. myself Patches: skinny-vm.diff uploaded by snuffy (license 5024)
  17564. ........ Merged revisions 378010 from
  17565. http://svn.asterisk.org/svn/asterisk/branches/11
  17566. * channels/chan_skinny.c: Add g722 codec support to skinny (closes
  17567. issue ASTERISK-20788) Reported by: snuffy Tested by: snuffy,
  17568. myself Patches: skinny-g722.diff uploaded by snuffy (license
  17569. 5024)
  17570. 2012-12-13 21:28 +0000 [r378002] Richard Mudgett <rmudgett@digium.com>
  17571. * apps/app_confbridge.c, apps/confbridge/conf_state_multi_marked.c,
  17572. apps/confbridge/conf_state.c, /,
  17573. apps/confbridge/include/confbridge.h,
  17574. include/asterisk/bridging.h: confbridge: Fix MOH on simultaneous
  17575. user entry to a new conference. When two users entered a new
  17576. conference simultaneously, one of the callers hears MOH. This
  17577. happened if two unmarked users entered simultaneously and also if
  17578. a waitmarked and a marked user entered simultaneously. * Created
  17579. a confbridge internal MOH API to eliminate the inlined MOH
  17580. handling code. Note that the conference mixing bridge needs to be
  17581. locked when actually starting/stopping MOH because there is a
  17582. small window between the conference join unsuspend MOH and
  17583. actually joining the mixing bridge. * Created the concept of
  17584. suspended MOH so it can be interrupted while conference join
  17585. announcements to the user and DTMF features can operate. *
  17586. Suspend any MOH until the user is about to actually join the
  17587. mixing bridge of the conference. This way any pre-join file
  17588. playback does not need to worry about MOH. * Made post-join
  17589. actions only play deferred entry announcement files. Changing the
  17590. user/conference state during that time is not protected or
  17591. controlled by the state machine. (closes issue ASTERISK-20606)
  17592. Reported by: Eugenia Belova Tested by: rmudgett Review:
  17593. https://reviewboard.asterisk.org/r/2232/ ........ Merged
  17594. revisions 377992 from
  17595. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17596. revisions 377993 from
  17597. http://svn.asterisk.org/svn/asterisk/branches/11
  17598. 2012-12-13 21:25 +0000 [r378001] Damien Wedhorn <voip@facts.com.au>
  17599. * /, channels/chan_skinny.c: Minor fixes for chan_skinny
  17600. Whitespace, change SUBSTATE_ONHOOK to correct SKINNY_ONHOOK and
  17601. correct len of 2 strcmp in skinny_setdebug(). (see opticron's
  17602. review on https://reviewboard.asterisk.org/r/2240/) ........
  17603. Merged revisions 377991 from
  17604. http://svn.asterisk.org/svn/asterisk/branches/11
  17605. 2012-12-13 21:20 +0000 [r378000] Sean Bright <sean@malleable.com>
  17606. * res/res_calendar_exchange.c: Make generate_exchange_uuid() always
  17607. return the passed ast_str pointer. I changed this code earlier to
  17608. return NULL if it wasn't able to generate a UUID, whereas the
  17609. earlier code would always return the ast_str that was passed in.
  17610. Switch back to returning the ast_str, only set it to the empty
  17611. string instead if UUID generation fails. We still do a validity
  17612. check later which will catch this and blow up if necessary.
  17613. 2012-12-13 21:15 +0000 [r377994] David M. Lee <dlee@digium.com>
  17614. * /: Fixed svn merge property breakage from r377986
  17615. 2012-12-13 18:28 +0000 [r377986] Damien Wedhorn <voip@facts.com.au>
  17616. * /, channels/chan_skinny.c: Fix skinny debug tab completion Review
  17617. the syntax of the 'skinny debug' command to show more than just
  17618. 'show' for options to 'skinny debug' command. (closes issue
  17619. ASTERISK-20789) Reported by: snuffy Tested by: snuffy, myself
  17620. Patches: skinny-debug.diff uploaded by snuffy (license 5024)
  17621. ........ Merged revisions 377985 from
  17622. http://svn.asterisk.org/svn/asterisk/branches/11
  17623. 2012-12-13 16:43 +0000 [r377981] David M. Lee <dlee@digium.com>
  17624. * configure.ac, configure, include/asterisk/autoconfig.h.in: Bail
  17625. configure if it can't find libuuid.
  17626. 2012-12-13 16:18 +0000 [r377977] Russell Bryant <russell@russellbryant.com>
  17627. * configure.ac, main/utils.c, configure,
  17628. include/asterisk/autoconfig.h.in: Remove compile time check
  17629. HAVE_DEV_URANDOM. The code was doing a runtime check, anyway. The
  17630. compile time check isn't always valid (cross-compiling,
  17631. packages). Review: https://reviewboard.asterisk.org/r/2245/
  17632. 2012-12-13 15:40 +0000 [r377975] Mark Michelson <mmichelson@digium.com>
  17633. * main/taskprocessor.c: Re-add taskprocessor cleanup code that was
  17634. removed by the UUID merge.
  17635. 2012-12-13 15:37 +0000 [r377974] Sean Bright <sean@malleable.com>
  17636. * res/res_calendar_exchange.c: Use the UUID API to generate and
  17637. validate UUIDs for res_calendar_exchange. Currently the
  17638. res_calendar_exchange module uses its own method of generating
  17639. UUIDs using ast_random(). Now that we have a UUID API we should
  17640. use that instead.
  17641. 2012-12-13 15:37 +0000 [r377973] Mark Michelson <mmichelson@digium.com>
  17642. * res/res_clialiases.c: The UUID commit removed changes made in
  17643. res_clialiases.c This puts back in the changes that are designed
  17644. to work around a memory leak fix in the CLI code.
  17645. 2012-12-13 15:24 +0000 [r377972] David M. Lee <dlee@digium.com>
  17646. * configure, include/asterisk/autoconfig.h.in, configure.ac: Fixed
  17647. configure.ac to look for proper uuid.h file Introduced in
  17648. r377846, the configure script was looking for uuid.h instead of
  17649. uuid/uuid.h.
  17650. 2012-12-13 15:22 +0000 [r377971] Brent Eagles <beagles@digium.com>
  17651. * configs/sip.conf.sample, channels/sip/include/sip.h,
  17652. channels/chan_sip.c: This change adds a SIP peer configuration
  17653. feature to allow the peer's configured codecs to take precedence
  17654. on an outgoing call. This change introduces a new peer
  17655. configuration property named 'ignore_requested_pref' that causes
  17656. the requested codec to be ignored when determining the preferred
  17657. codec for an outgoing call leg. The consequence is that
  17658. Asterisk's usual efforts to prefer avoiding transcoding can be
  17659. overridden on a peer-by-peer basis where appropriate.
  17660. 2012-12-13 14:28 +0000 [r377966] Kinsey Moore <kmoore@digium.com>
  17661. * /, channels/chan_sip.c: Ensure Min-SE is included in outbound
  17662. INVITEs Asterisk now includes Min-SE in outbound INVITEs when the
  17663. value is not 90 (the default) and session timers are not
  17664. disabled. This has the effect of Asterisk following RFC4028 more
  17665. closely with regard to 422 responses and preventing situations in
  17666. which Asterisk would be forced to temporarily accept a call to
  17667. tear it down based on a Session-Expires below the locally
  17668. configured Min-SE. (issue SWP-5051) Review:
  17669. https://reviewboard.asterisk.org/r/2222/ Reported-by: Kinsey
  17670. Moore Patch-by: Kinsey Moore ........ Merged revisions 377946
  17671. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  17672. Merged revisions 377947 from
  17673. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17674. revisions 377948 from
  17675. http://svn.asterisk.org/svn/asterisk/branches/11
  17676. 2012-12-12 22:43 +0000 [r377925] Rusty Newton <rnewton@digium.com>
  17677. * sounds/Makefile, /: Incremented EXTRA_SOUNDS_VERSION in
  17678. sounds/Makefile to 1.4.12 for new Extra Sounds releases See
  17679. CHANGES-* files in English extra 1.4.12 tarballs for new sound
  17680. prompts added. (closes ASTERISK-20328) Reported by: Matt Jordan
  17681. (closes AST-755) Reported by: John Bigelow ........ Merged
  17682. revisions 377922 from
  17683. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17684. revisions 377923 from
  17685. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17686. revisions 377924 from
  17687. http://svn.asterisk.org/svn/asterisk/branches/11
  17688. 2012-12-12 04:43 +0000 [r377915] Michael L. Young <elgueromexicano@gmail.com>
  17689. * main/features.c: Convert Dynamic Features Buffer To Use ast_str
  17690. Currently, the buffer for the dynamic features list is set to a
  17691. fixed size of 128. If the list is bigger than that, it results in
  17692. the dynamic feature(s) not being recognized. This patch changes
  17693. the buffer from a fixed size to a dynamic one. (closes issue
  17694. ASTERISK-20680) Reported by: Clod Patry Tested by: Michael L.
  17695. Young Patches: asterisk-20680-dynamic-features-v2.diff uploaded
  17696. by Michael L. Young (license 5026) Review:
  17697. https://reviewboard.asterisk.org/r/2221/
  17698. 2012-12-12 00:02 +0000 [r377906-377911] Mark Michelson <mmichelson@digium.com>
  17699. * /, channels/chan_sip.c: Fix a potential deadlock in chan_sip
  17700. during transfers. The issue comes from the fact that transfers
  17701. may perform a redirecting update on a channel. The issue is that
  17702. lock inversion between the channel and its tech_pvt occurs since
  17703. the channel lock is released during the transfer process. The fix
  17704. is to move when the redirecting update occurs to a place where
  17705. neither the tech_pvt or the channel is locked so that the two can
  17706. be locked in the proper order. (closes issue ASTERISK-20708)
  17707. reported by Mark Michelson patches: ASTERISK-20708-3.patch
  17708. uploaded by Mark Michelson (License #5049) Tested by: Tim
  17709. Ringenbach at Asteria Solutions Group ........ Merged revisions
  17710. 377910 from http://svn.asterisk.org/svn/asterisk/branches/11
  17711. * main/features.c: Add test events necessary for bridging tests to
  17712. be able to properly run.
  17713. 2012-12-11 22:03 +0000 [r377884] Richard Mudgett <rmudgett@digium.com>
  17714. * main/file.c, main/http.c, main/aoc.c, main/image.c, main/cel.c,
  17715. main/timing.c, main/channel.c, main/data.c, main/stun.c, /:
  17716. Cleanup CLI commands on exit for several files. (issue
  17717. ASTERISK-20649) Reported by: Corey Farrell Patches:
  17718. unregister-cli-multiple-all.patch (license #5909) patch uploaded
  17719. by Corey Farrell ........ Merged revisions 377881 from
  17720. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17721. revisions 377882 from
  17722. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17723. revisions 377883 from
  17724. http://svn.asterisk.org/svn/asterisk/branches/11
  17725. 2012-12-11 21:53 +0000 [r377878-377880] Mark Michelson <mmichelson@digium.com>
  17726. * /: And remove svnmerge-integrated property.
  17727. * /: Remove automerge properties.
  17728. 2012-12-11 21:22 +0000 [r377867] Richard Mudgett <rmudgett@digium.com>
  17729. * main/udptl.c, /: Cleanup udptl on exit. * Cleanup CLI commands on
  17730. exit. (issue ASTERISK-20649) Reported by: Corey Farrell Patches:
  17731. udptl-shutdown-1_8-10.patch (license #5909) patch uploaded by
  17732. Corey Farrell udptl-shutdown-11-trunk.patch (license #5909) patch
  17733. uploaded by Corey Farrell Modified ........ Merged revisions
  17734. 377847 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17735. ........ Merged revisions 377848 from
  17736. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17737. revisions 377849 from
  17738. http://svn.asterisk.org/svn/asterisk/branches/11
  17739. 2012-12-11 21:04 +0000 [r377844-377846] Mark Michelson <mmichelson@digium.com>
  17740. * configure.ac, include/asterisk/uuid.h (added),
  17741. main/taskprocessor.c, tests/test_uuid.c (added), main/asterisk.c,
  17742. main/uuid.c (added), res/res_clialiases.c, /, configure,
  17743. include/asterisk/autoconfig.h.in, main/Makefile: Add UUID support
  17744. to Asterisk. This provides a common API for dealing with unique
  17745. identifiers. The API provides methods to create, parse, copy, and
  17746. stringify UUIDs. An accompanying unit test is provided that tests
  17747. all operations. (closes issue ASTERISK-20726) reported by Matt
  17748. Jordan Review: https://reviewboard.asterisk.org/r/2217
  17749. * res/res_clialiases.c, /: Fix crash that can occur if CLI
  17750. registration fails for an aliased command. A recent memory leak
  17751. fix in main/cli.c causes an ast_cli_entry's command field to be
  17752. freed and NULLed if ast_cli_register() fails. res_clialiases was
  17753. ignoring the return value of ast_cli_register() and was then
  17754. passing the NULL command off to a a hash function. This resulted
  17755. in a crash. The fix is not to ignore the erroneous return value.
  17756. If ast_cli_register() fails, then we do not continue trying to
  17757. process the current alias. ........ Merged revisions 377840 from
  17758. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17759. revisions 377842 from
  17760. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17761. revisions 377843 from
  17762. http://svn.asterisk.org/svn/asterisk/branches/11
  17763. 2012-12-11 20:46 +0000 [r377707-377841] Richard Mudgett <rmudgett@digium.com>
  17764. * main/taskprocessor.c, /: Cleanup taskprocessor on exit. * Cleanup
  17765. CLI commands on exit. (issue ASTERISK-20649) Reported by: Corey
  17766. Farrell Patches: taskprocessor-cleanup-1_8-11-trunk.patch
  17767. (license #5909) patch uploaded by Corey Farrell
  17768. taskprocessor-cleanup-10-only.patch (license #5909) patch
  17769. uploaded by Corey Farrell Modified ........ Merged revisions
  17770. 377837 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17771. ........ Merged revisions 377838 from
  17772. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17773. revisions 377839 from
  17774. http://svn.asterisk.org/svn/asterisk/branches/11
  17775. * main/pbx.c, /: Cleanup pbx on exit. * Cleanup CLI commands on
  17776. exit. * Unreference hints and statecbs containers on exit. (issue
  17777. ASTERISK-20649) Reported by: Corey Farrell Patches:
  17778. pbx-cleanup-1_8.patch (license #5909) patch uploaded by Corey
  17779. Farrell pbx-cleanup-10.patch (license #5909) patch uploaded by
  17780. Corey Farrell pbx-cleanup-11-trunk.patch (license #5909) patch
  17781. uploaded by Corey Farrell Modified ........ Merged revisions
  17782. 377806 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17783. ........ Merged revisions 377807 from
  17784. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17785. revisions 377808 from
  17786. http://svn.asterisk.org/svn/asterisk/branches/11
  17787. * /, main/logger.c: Cleanup logger on exit. * Cleanup CLI commands,
  17788. destroy verbosers and logchannels lists on exit. (issue
  17789. ASTERISK-20649) Reported by: Corey Farrell Patches:
  17790. logger-cleanup-all.patch (license #5909) patch uploaded by Corey
  17791. Farrell Modified ........ Merged revisions 377771 from
  17792. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17793. revisions 377772 from
  17794. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17795. revisions 377773 from
  17796. http://svn.asterisk.org/svn/asterisk/branches/11
  17797. * /, main/indications.c: Cleanup indications on exit. * Made
  17798. ast_unregister_indication_country() unlink the found tone zone
  17799. before selecting a new default_tone_zone to make it impossible to
  17800. select the tone zone being unregistered again. * Ringcadence is
  17801. no longer parsed twice in store_config_tone_zone(). * Cleanup CLI
  17802. commands and destroy default_tone_zone on exit. (issue
  17803. ASTERISK-20649) Reported by: Corey Farrell Patches:
  17804. indications-cleanup-all.patch (license #5909) patch uploaded by
  17805. Corey Farrell Modified ........ Merged revisions 377740 from
  17806. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17807. revisions 377741 from
  17808. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17809. revisions 377742 from
  17810. http://svn.asterisk.org/svn/asterisk/branches/11
  17811. * /, main/event.c: Cleanup event on exit. * Cleanup CLI commands on
  17812. exit. (issue ASTERISK-20649) Reported by: Corey Farrell Patches:
  17813. event_shutdown-10-only.patch (license #5909) patch uploaded by
  17814. Corey Farrell event_shutdown-1_8-11-trunk.patch (license #5909)
  17815. patch uploaded by Corey Farrell ........ Merged revisions 377708
  17816. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  17817. Merged revisions 377709 from
  17818. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17819. revisions 377710 from
  17820. http://svn.asterisk.org/svn/asterisk/branches/11
  17821. * main/dnsmgr.c, /: Cleanup dnsmgr on exit. * Cleanup dnsmgr thread
  17822. and CLI commands on exit. (issue ASTERISK-20649) Reported by:
  17823. Corey Farrell Patches: dnsmgr-cleanup-1_8.patch (license #5909)
  17824. patch uploaded by Corey Farrell dnsmgr-cleanup-10-11-trunk.patch
  17825. (license #5909) patch uploaded by Corey Farrell Modified ........
  17826. Merged revisions 377704 from
  17827. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17828. revisions 377705 from
  17829. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17830. revisions 377706 from
  17831. http://svn.asterisk.org/svn/asterisk/branches/11
  17832. 2012-12-10 16:56 +0000 [r377626-377658] Kinsey Moore <kmoore@digium.com>
  17833. * /, res/res_fax.c: Ensure ReceiveFax provides a CED tone via T.38
  17834. When using res_fax_digium, the T.38 CED tone was not being
  17835. provided properly which would cause some incoming faxes to fail.
  17836. This was not an issue with res_fax_spandsp since it does not
  17837. strictly honor the send_ced flag and sends the CED tone whenever
  17838. receiving a T.38 fax. (closes issue FAX-343) Reported-by:
  17839. Benjamin Tietz Patch-by: Kinsey Moore ........ Merged revisions
  17840. 377655 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17841. ........ Merged revisions 377656 from
  17842. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17843. revisions 377657 from
  17844. http://svn.asterisk.org/svn/asterisk/branches/11
  17845. * /, channels/chan_sip.c: Handle Session-Expires less than local
  17846. Min-SE in 200 OK Ensure that a call is immediately torn down if a
  17847. Session-Expires value received in a 200 OK is less than the local
  17848. Min-SE. This also prevents Asterisk from allowing calls with
  17849. Session-Expires below the RFC4028-mandated minimum (90s). (closes
  17850. issue ASTERISK-20653) Review:
  17851. https://reviewboard.asterisk.org/r/2237/ Patch-by: Kinsey Moore
  17852. ........ Merged revisions 377623 from
  17853. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17854. revisions 377624 from
  17855. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17856. revisions 377625 from
  17857. http://svn.asterisk.org/svn/asterisk/branches/11
  17858. 2012-12-10 07:03 +0000 [r377579-377595] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  17859. * channels/chan_unistim.c: Add firmware information to CLI devices
  17860. listing
  17861. * channels/chan_unistim.c, /: Fix codec mismatch Fix code to send
  17862. in both rx and tx open stream messages correct codecs. Found that
  17863. on phase 0/1 phones wrong codecs cause to no audio in some
  17864. situations. (issue ASTERISK-20183) ........ Merged revisions
  17865. 377591 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17866. ........ Merged revisions 377592 from
  17867. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17868. revisions 377593 from
  17869. http://svn.asterisk.org/svn/asterisk/branches/11
  17870. * channels/chan_unistim.c, /: Remove trailing whitespaces in number
  17871. from incoming redial list. Reported by: Igor Olhovskiy ........
  17872. Merged revisions 377577 from
  17873. http://svn.asterisk.org/svn/asterisk/branches/11
  17874. 2012-12-10 01:41 +0000 [r377506-377512] Tilghman Lesher <tilghman@meg.abyt.es>
  17875. * main/xmldoc.c, /: Improve documentation by making all of the
  17876. colors used readable, no matter what the background color is.
  17877. Dark blue on a black background is unreadable, as is yellow on a
  17878. light background. This patch turns on the bright attribute for
  17879. colors when on a dark background and turns *off* the bright
  17880. attribute when the -W command line option is used (indicating a
  17881. _light_ background). This ensures that text is readable in both
  17882. cases. Patch by: tilghman Review:
  17883. https://reviewboard.asterisk.org/r/2224 ........ Merged revisions
  17884. 377509 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17885. ........ Merged revisions 377510 from
  17886. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17887. revisions 377511 from
  17888. http://svn.asterisk.org/svn/asterisk/branches/11
  17889. * addons/cdr_mysql.c, /: Remove some dead code and additionally
  17890. handle a case that wasn't handled. ........ Merged revisions
  17891. 377487 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  17892. ........ Merged revisions 377504 from
  17893. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17894. revisions 377505 from
  17895. http://svn.asterisk.org/svn/asterisk/branches/11
  17896. 2012-12-09 01:23 +0000 [r377463] Joshua Colp <jcolp@digium.com>
  17897. * channels/chan_motif.c, /: Add missing support for "who hung up"
  17898. to chan_motif. (closes issue ASTERISK-20671) Reported by: Matt
  17899. Jordan Review: https://reviewboard.asterisk.org/r/2208/ ........
  17900. Merged revisions 377462 from
  17901. http://svn.asterisk.org/svn/asterisk/branches/11
  17902. 2012-12-08 00:30 +0000 [r377402-377434] Richard Mudgett <rmudgett@digium.com>
  17903. * contrib/realtime/mysql/sippeers.sql, /: Fix order of SIP
  17904. allow/disallow in MySQL contrib script. Using the contrib
  17905. sippeers.sql script to create the sippeers MySQL table would
  17906. result in being unable to place calls if you set the disallow
  17907. value to all. (closes issue ASTERISK-20756) Reported by: Andre
  17908. Luis Patches: sippeers.patch patch uploaded by Andre Luis
  17909. ........ Merged revisions 377431 from
  17910. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17911. revisions 377432 from
  17912. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17913. revisions 377433 from
  17914. http://svn.asterisk.org/svn/asterisk/branches/11
  17915. * main/astmm.c, /: MALLOC_DEBUG: Only wait if we want atexit
  17916. allocation dumps. ........ Merged revisions 377398 from
  17917. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17918. revisions 377399 from
  17919. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17920. revisions 377401 from
  17921. http://svn.asterisk.org/svn/asterisk/branches/11
  17922. 2012-12-07 22:08 +0000 [r377384] Kinsey Moore <kmoore@digium.com>
  17923. * codecs/codec_dahdi.c: codec_dahdi: Fix output of "transcoder
  17924. show" CLI command. In r306010 "Asterisk media architecture
  17925. conversion - no more format bitfields", the logic for
  17926. incrementing encoders and decoders when opening transcoder
  17927. channels was changed without making the corresponding change when
  17928. decrementing encoder / decoder channels. The result being that
  17929. when a channel was destroyed, codec_dahdi couldn't properly tell
  17930. if it was an encoder or decoder, and the default case is to
  17931. assume it was a decoder. This could result in negative numbers
  17932. for decoders in use like in: VOIP6*CLI> transcoder show 2/-2
  17933. encoders/decoders of 92 channels are in use. (closes issue
  17934. ASTERISK-19921) Patch-by: Shaun Ruffell ........ Merged revisions
  17935. 377382 from http://svn.asterisk.org/svn/asterisk/branches/10
  17936. ........ Merged revisions 377383 from
  17937. http://svn.asterisk.org/svn/asterisk/branches/11
  17938. 2012-12-07 00:00 +0000 [r377356] Richard Mudgett <rmudgett@digium.com>
  17939. * apps/confbridge/conf_config_parser.c, /, apps/app_confbridge.c:
  17940. confbridge: Fix some resource leaks on conference teardown. *
  17941. Made destroy_conference_bridge() destroy a missed ast_mutex_t and
  17942. ast_cond_t. * Made join_conference_bridge() init the
  17943. ast_mutex_t's and ast_cond_t so destroy_conference_bridge() can
  17944. destroy them unconditionally. * Made join_conference_bridge()
  17945. abort if the new conference could not be added to the conferences
  17946. container. * Made leave_conference() discard any post-join
  17947. actions if join_conference_bridge() had to abort early. * Made
  17948. the join_conference_bridge() diagnostic messages better describe
  17949. what happened. * Renamed leave_conference_bridge() to
  17950. leave_conference() and made it only take a conference user
  17951. pointer. The conference pointer was redundant. * Made
  17952. conf_bridge_profile_copy() use struct copy instead of memcpy(). *
  17953. No need to lock the conference in start_conf_record_thread()
  17954. since all of the callers already have it locked. ........ Merged
  17955. revisions 377354 from
  17956. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17957. revisions 377355 from
  17958. http://svn.asterisk.org/svn/asterisk/branches/11
  17959. 2012-12-06 17:29 +0000 [r377329-377341] Russell Bryant <russell@russellbryant.com>
  17960. * /: Recorded merge of revisions 377340 from
  17961. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Add CLI
  17962. tab completion to 'acl show'. The 'acl show' CLI command allows
  17963. you to show the details about a specific named ACL in acl.conf.
  17964. This patch adds tab completion to the command. Review:
  17965. https://reviewboard.asterisk.org/r/2230/
  17966. * main/named_acl.c: Minor code cleanup in named_acl.c. This patch
  17967. makes a few little cleanups to named_acl.c. A couple non-public
  17968. functions were made static and an opening brace for a function
  17969. was moved to its own line, per the coding guidelines.
  17970. * main/named_acl.c: Add CLI tab completion to 'acl show'. The 'acl
  17971. show' CLI command allows you to show the details about a specific
  17972. named ACL in acl.conf. This patch adds tab completion to the
  17973. command. Review: https://reviewboard.asterisk.org/r/2230/
  17974. 2012-12-06 14:26 +0000 [r377324] Matthew Jordan <mjordan@digium.com>
  17975. * main/manager.c, /: Fix memory leak in 'manager show event' when
  17976. command entered incorrectly When the CLI command 'manager show
  17977. event' was run incorrectly and its usage instructions returned, a
  17978. reference to the event container was leaked. This would prevent
  17979. the container from being reclaimed when Asterisk exits. We now
  17980. properly decrement the count on the ao2 object using the nifty
  17981. RAII_VAR macro. Thanks to Russell for helping me stumble on this,
  17982. and Terry for writing that ridiculously helpful macro. ........
  17983. Merged revisions 377319 from
  17984. http://svn.asterisk.org/svn/asterisk/branches/11
  17985. 2012-12-05 17:17 +0000 [r377263] Jonathan Rose <jrose@digium.com>
  17986. * /, res/res_srtp.c: res_srtp: Fix a crash caused by srtp_dealloc
  17987. on an already dealloced session When srtp_create fails, the
  17988. session may be dealloced or just not alloced. At the same time
  17989. though, the session pointer might not be set to NULL in this
  17990. process and attempting to srtp_dealloc it again will cause a
  17991. segfault. This patch checks for failure of srtp_create and sets
  17992. the session pointer to NULL if it fails. (closes issue
  17993. ASTERISK-20499) Reported by: tootai Review:
  17994. https://reviewboard.asterisk.org/r/2228/ ........ Merged
  17995. revisions 377256 from
  17996. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  17997. revisions 377261 from
  17998. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  17999. revisions 377262 from
  18000. http://svn.asterisk.org/svn/asterisk/branches/11
  18001. 2012-12-05 16:51 +0000 [r377260] Joshua Colp <jcolp@digium.com>
  18002. * /, channels/chan_sip.c: Fix a SIP request memory leak with TLS
  18003. connections. During the TLS re-work in chan_sip some TLS specific
  18004. code was moved into a separate function. This function operates
  18005. on a copy of the incoming SIP request. This copy was never
  18006. deinitialized causing a memory leak for each request processed.
  18007. This function is now given a SIP request structure which it can
  18008. use to copy the incoming request into. This reduces the amount of
  18009. memory allocations done since the internal allocated components
  18010. are reused between packets and also ensures the SIP request
  18011. structure is deinitialized when the TLS connection is torn down.
  18012. (closes issue ASTERISK-20763) Reported by: deti ........ Merged
  18013. revisions 377257 from
  18014. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18015. revisions 377258 from
  18016. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18017. revisions 377259 from
  18018. http://svn.asterisk.org/svn/asterisk/branches/11
  18019. 2012-12-05 02:23 +0000 [r377214-377246] Richard Mudgett <rmudgett@digium.com>
  18020. * include/asterisk/_private.h, main/asterisk.c, main/format.c:
  18021. Remove init_framer(). It no longer does anything.
  18022. * main/format.c, /: Fix registering core show codecs/codec CLI
  18023. commands twice. ........ Merged revisions 377241 from
  18024. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18025. revisions 377244 from
  18026. http://svn.asterisk.org/svn/asterisk/branches/11
  18027. * apps/confbridge/conf_config_parser.c, /: confbridge: Fix several
  18028. small issues. * Made func_confbridge_helper() allow an empty
  18029. value when setting options. You previously could not
  18030. Set(CONFBRIDGE(user,pin)=) and clear the configured pin from the
  18031. dialplan. * Made func_confbridge_helper() handle its datastore
  18032. better if multiple threads attempt to set the first CONFBRIDGE
  18033. option value on the channel. * Made the func_confbridge_helper()
  18034. only output one diagnostic message concerning the option. * Made
  18035. the bridge video_mode able to repeatedly change in the config
  18036. file and CONFBRIDGE dialplan function. The video_mode option
  18037. values are an enum and not independent of each other. * Made
  18038. handle_cli_confbridge_show_bridge_profile() better handle the
  18039. video_mode option. * Simplified datastore handling code in
  18040. conf_find_user_profile() and conf_find_bridge_profile(). (closes
  18041. issue ASTERISK-20655) Reported by: Birger "WIMPy" Harzenetter
  18042. ........ Merged revisions 377227 from
  18043. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18044. revisions 377228 from
  18045. http://svn.asterisk.org/svn/asterisk/branches/11
  18046. * /, apps/app_confbridge.c: confbridge: Update online XML
  18047. documentation. ........ Merged revisions 377212 from
  18048. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18049. revisions 377213 from
  18050. http://svn.asterisk.org/svn/asterisk/branches/11
  18051. 2012-12-04 13:01 +0000 [r377196] Russell Bryant <russell@russellbryant.com>
  18052. * contrib/scripts/install_prereq, /: Add libuuid to install_prereq
  18053. for Fedora. I ran this script and my build failed. pjproject
  18054. requires this. ........ Merged revisions 377195 from
  18055. http://svn.asterisk.org/svn/asterisk/branches/11
  18056. 2012-12-03 23:00 +0000 [r377040-377168] Richard Mudgett <rmudgett@digium.com>
  18057. * /, main/asterisk.c: Cleanup ast_run_atexits() atexits list. *
  18058. Convert atexits list to a mutex instead of a rd/wr lock. The lock
  18059. is only write locked. * Move CLI verbose Asterisk ending message
  18060. to where AMI message is output in really_quit() to avoid further
  18061. surprises about using stuff already shutdown. (issue
  18062. ASTERISK-20649) Reported by: Corey Farrell ........ Merged
  18063. revisions 377165 from
  18064. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18065. revisions 377166 from
  18066. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18067. revisions 377167 from
  18068. http://svn.asterisk.org/svn/asterisk/branches/11
  18069. * include/asterisk/_private.h, main/stdtime/localtime.c,
  18070. main/asterisk.c, /: Cleanup core main on exit. * Cleanup time
  18071. zones on exit. * Make exit clean/unclean report consistent for
  18072. AMI and CLI in really_quit(). (issue ASTERISK-20649) Reported by:
  18073. Corey Farrell Patches: core-cleanup-1_8-10.patch (license #5909)
  18074. patch uploaded by Corey Farrell core-cleanup-11-trunk.patch
  18075. (license #5909) patch uploaded by Corey Farrell Modified ........
  18076. Merged revisions 377135 from
  18077. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18078. revisions 377136 from
  18079. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18080. revisions 377137 from
  18081. http://svn.asterisk.org/svn/asterisk/branches/11
  18082. * main/config.c, /: Cleanup config cache on exit. (issue
  18083. ASTERISK-20649) Reported by: Corey Farrell Patches:
  18084. config-cleanup-all.patch (license #5909) patch uploaded by Corey
  18085. Farrell ........ Merged revisions 377104 from
  18086. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18087. revisions 377105 from
  18088. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18089. revisions 377106 from
  18090. http://svn.asterisk.org/svn/asterisk/branches/11
  18091. * main/cli.c, /: Cleanup CLI resources on exit and CLI command
  18092. registration errors. (issue ASTERISK-20649) Reported by: Corey
  18093. Farrell Patches: cli-leaks-1_8-10.patch (license #5909) patch
  18094. uploaded by Corey Farrell cli-leaks-11-trunk.patch (license
  18095. #5909) patch uploaded by Corey Farrell Modified ........ Merged
  18096. revisions 377073 from
  18097. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18098. revisions 377074 from
  18099. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18100. revisions 377075 from
  18101. http://svn.asterisk.org/svn/asterisk/branches/11
  18102. * main/cdr.c, /: Cleanup CDR resources on exit. * Simplify
  18103. do_reload() return handling since it never returned anything
  18104. other than 0. (issue ASTERISK-20649) Reported by: Corey Farrell
  18105. Patches: cdr-cleanup-1_8.patch (license #5909) patch uploaded by
  18106. Corey Farrell cdr-cleanup-10-11-trunk.patch (license #5909) patch
  18107. uploaded by Corey Farrell Modified ........ Merged revisions
  18108. 377069 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  18109. ........ Merged revisions 377070 from
  18110. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18111. revisions 377071 from
  18112. http://svn.asterisk.org/svn/asterisk/branches/11
  18113. * /, main/ccss.c: Fix CCSS CLI commands and logger level not
  18114. unregistered. (issue ASTERISK-20649) Reported by: Corey Farrell
  18115. Patches: ccss-cleanup-all.patch (license #5909) patch uploaded by
  18116. Corey Farrell ........ Merged revisions 377037 from
  18117. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18118. revisions 377038 from
  18119. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18120. revisions 377039 from
  18121. http://svn.asterisk.org/svn/asterisk/branches/11
  18122. 2012-12-03 16:45 +0000 [r377035] Olle Johansson <oej@edvina.net>
  18123. * res/res_rtp_asterisk.c: Formatting fixes
  18124. 2012-12-03 14:56 +0000 [r377022] Joshua Colp <jcolp@digium.com>
  18125. * channels/chan_motif.c, /: Fix an RTP instance reference count
  18126. leak in chan_motif. When setting up an RTP instance the RTCP
  18127. portion of the instance keeps a reference to the instance itself.
  18128. In order to release this reference and stop RTCP the stop API
  18129. call must be called before destroying the instance. (closes issue
  18130. ASTERISK-20751) Reported by: joshoa ........ Merged revisions
  18131. 377021 from http://svn.asterisk.org/svn/asterisk/branches/11
  18132. 2012-12-03 14:46 +0000 [r376998-377018] Olle Johansson <oej@edvina.net>
  18133. * channels/chan_sip.c: Move functions to AFTER the block of forward
  18134. declarations of functions. It was a mess. The first part of
  18135. chan_sip.c is constants, declarations, structures and stuff, then
  18136. forward declarations and then actual code. It's still a mess, but
  18137. a bit less messy ;-)
  18138. * channels/chan_sip.c, res/res_rtp_asterisk.c: Formatting changes
  18139. Found a large amount of missing {} in the code before patching in
  18140. another branch
  18141. 2012-12-01 00:47 +0000 [r376984] Joshua Colp <jcolp@digium.com>
  18142. * configs/motif.conf.sample, /, channels/chan_motif.c: Tweak
  18143. extension used for incoming calls received on Motif. Based on
  18144. feedback from numerous individuals this patch tweaks incoming
  18145. calls to first look for an extension with the name of the
  18146. endpoint. If no such extension exists the call will silently fall
  18147. back to the "s" extension as it previously did. ........ Merged
  18148. revisions 376983 from
  18149. http://svn.asterisk.org/svn/asterisk/branches/11
  18150. 2012-11-30 21:38 +0000 [r376953] Richard Mudgett <rmudgett@digium.com>
  18151. * /, channels/misdn/isdn_lib.c: chan_misdn: Fix sending
  18152. RELEASE_COMPLETE in response to SETUP. Fix sending a
  18153. RELEASE_COMPLETE in response to a SETUP if chan_misdn does not
  18154. have a B channel available to assign to the call. (closes issue
  18155. ABE-2869) Reported by: Guenther Kelleter Patches:
  18156. setup-reject_2.diff (license #6372) patch uploaded by Guenther
  18157. Kelleter Modified ........ Merged revision 376949 from
  18158. https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  18159. ........ Merged revisions 376950 from
  18160. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18161. revisions 376951 from
  18162. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18163. revisions 376952 from
  18164. http://svn.asterisk.org/svn/asterisk/branches/11
  18165. 2012-11-30 17:08 +0000 [r376922] Sean Bright <sean@malleable.com>
  18166. * /, funcs/func_volume.c: Minor spelling fix to the VOLUME
  18167. documentation. ........ Merged revisions 376919 from
  18168. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18169. revisions 376920 from
  18170. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18171. revisions 376921 from
  18172. http://svn.asterisk.org/svn/asterisk/branches/11
  18173. 2012-11-30 16:56 +0000 [r376918] Mark Michelson <mmichelson@digium.com>
  18174. * /, channels/chan_sip.c: Fix potential crashes during SIP attended
  18175. transfers. The principal behind this patch is simple. During a
  18176. transfer, we manipulate channels that are owned by a separate
  18177. thread than the one we currently are running in, so it makes
  18178. sense that we need to grab a reference to the channels so that
  18179. they cannot disappear out from under us. In the wild, crashes
  18180. were sometimes seen when the transferring party would hang up the
  18181. call before the transfer target answered the call. The most
  18182. common place to see the crash occur was when attempting to send a
  18183. connected line update to the transferer channel. (closes issue
  18184. ASTERISK-20226) Reported by Jared Smith Patches:
  18185. ASTERISK-20226.patch uploaded by Mark Michelson (License #5049)
  18186. Tested by: Jared Smith ........ Merged revisions 376901 from
  18187. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18188. revisions 376916 from
  18189. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18190. revisions 376917 from
  18191. http://svn.asterisk.org/svn/asterisk/branches/11
  18192. 2012-11-29 23:01 +0000 [r376867-376871] Richard Mudgett <rmudgett@digium.com>
  18193. * channels/chan_local.c, /: chan_local: Fix local_pvt ref leak in
  18194. local_devicestate(). Regression introduced by ASTERISK-20390 fix.
  18195. (closes issue ASTERISK-20769) Reported by: rmudgett Tested by:
  18196. rmudgett ........ Merged revisions 376868 from
  18197. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18198. revisions 376869 from
  18199. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18200. revisions 376870 from
  18201. http://svn.asterisk.org/svn/asterisk/branches/11
  18202. * /, channels/chan_sip.c: Fix compile error. (issue ASTERISK-20724)
  18203. ........ Merged revisions 376864 from
  18204. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18205. revisions 376865 from
  18206. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18207. revisions 376866 from
  18208. http://svn.asterisk.org/svn/asterisk/branches/11
  18209. 2012-11-29 21:58 +0000 [r376837] Michael L. Young <elgueromexicano@gmail.com>
  18210. * /, channels/chan_sip.c: Improve Code Readability And Fix Setting
  18211. natdetected Flag For 1.8, 10, 11 and trunk we are are improving
  18212. the code readability. For 11 and trunk, auto nat detection was
  18213. added. The natdetected flag was being set to 1 when the host
  18214. address in the VIA header did not specifiy a port. This patch
  18215. fixes this by setting the port on the temporary sock address used
  18216. to SIP_STANDARD_PORT in order for the sock address comparison to
  18217. work properly. (closes issue ASTERISK-20724) Reported by: Michael
  18218. L. Young Patches: asterisk-20724-set-port-v2.diff uploaded by
  18219. Michael L. Young (license 5026) Review:
  18220. https://reviewboard.asterisk.org/r/2206/ ........ Merged
  18221. revisions 376834 from
  18222. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18223. revisions 376835 from
  18224. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18225. revisions 376836 from
  18226. http://svn.asterisk.org/svn/asterisk/branches/11
  18227. 2012-11-29 17:16 +0000 [r376821] David M. Lee <dlee@digium.com>
  18228. * main/utils.c: Fixed ast_random's comment about locking. The
  18229. original comment was separated from the code at some point, and
  18230. didn't reflect the use of libc's other than glibc for Linux.
  18231. 2012-11-29 16:44 +0000 [r376820] Pedro Kiefer <pedro@kiefer.com.br>
  18232. * channels/chan_sip.c: Fix chan_sip websocket payload handling
  18233. Websocket by default doesn't return an ast_str for the payload
  18234. received. When converting it to an ast_str on chan_sip the last
  18235. character was being omitted, because ast_str functions expects
  18236. that the given length includes the trailing 0x00. payload_len
  18237. only has the actual string length without counting the trailing
  18238. zero. For most cases this passed unnoticed as most of SIP
  18239. messages ends with \r\n. (closes issue ASTERISK-20745) Reported
  18240. by: Iñaki Baz Castillo Review:
  18241. https://reviewboard.asterisk.org/r/2219/
  18242. 2012-11-29 00:48 +0000 [r376761-376791] Richard Mudgett <rmudgett@digium.com>
  18243. * main/astmm.c, main/asterisk.c, /: Add MALLOC_DEBUG atexit
  18244. unreleased malloc memory summary. * Adds the following CLI
  18245. commands to control MALLOC_DEBUG reporting of unreleased malloc
  18246. memory when Asterisk is shut down. memory atexit list on memory
  18247. atexit list off memory atexit summary byline memory atexit
  18248. summary byfunc memory atexit summary byfile memory atexit summary
  18249. off * Made check all remaining allocated region blocks atexit for
  18250. fence violations. * Increased the allocated region hash table
  18251. size by about three times. It still isn't large enough
  18252. considering the number of malloced blocks Asterisk uses. * Made
  18253. CLI "memory show allocations anomalies" use
  18254. regions_check_all_fences(). Review:
  18255. https://reviewboard.asterisk.org/r/2196/ ........ Merged
  18256. revisions 376788 from
  18257. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18258. revisions 376789 from
  18259. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18260. revisions 376790 from
  18261. http://svn.asterisk.org/svn/asterisk/branches/11
  18262. * /, main/astmm.c: Enhance MALLOC_DEBUG CLI commands. * Fixed CLI
  18263. "memory show allocations" misspelling of anomalies option. The
  18264. command will still accept the original misspelling. *
  18265. Miscellaneous tweaks to CLI "memory show allocations" command
  18266. output format. * Made CLI "memory show summary" summarize by line
  18267. number instead of by function if a filename is given. * Made CLI
  18268. "memory show summary" sort its output by filename or
  18269. function-name/line-number depending upon request. * Miscellaneous
  18270. tweaks to CLI "memory show summary" command output format.
  18271. ........ Merged revisions 376758 from
  18272. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18273. revisions 376759 from
  18274. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18275. revisions 376760 from
  18276. http://svn.asterisk.org/svn/asterisk/branches/11
  18277. 2012-11-28 16:47 +0000 [r376728] Jonathan Rose <jrose@digium.com>
  18278. * main/manager.c, /: manager: Make challenge work with
  18279. allowmultiplelogin=no Prior to this patch, challenge would yield
  18280. a multiple logins error if used without providing the username
  18281. (which isn't really supposed to be an argument to challenge) if
  18282. allowmultiplelogin was set to no because allowmultiplelogin finds
  18283. a user with a zero length login name. This check is simply
  18284. disabled for the challenge action when the username is empty by
  18285. this patch. (closes issue ASTERISK-20677) Reported by: Vladimir
  18286. Patches: challenge_action_nomultiplelogin.diff uploaded by
  18287. Jonathan Rose (license 6182) ........ Merged revisions 376725
  18288. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  18289. Merged revisions 376726 from
  18290. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18291. revisions 376727 from
  18292. http://svn.asterisk.org/svn/asterisk/branches/11
  18293. 2012-11-28 00:13 +0000 [r376630-376691] Richard Mudgett <rmudgett@digium.com>
  18294. * UPGRADE.txt, main/pbx.c, /: Fix extension matching with the '-'
  18295. char. The '-' char is supposed to be ignored by the dialplan
  18296. extension matching. Unfortunately, it's treatment is not handled
  18297. consistently throughout the extension matching code. * Made the
  18298. old exten matching code consistently ignore '-' chars. * Made the
  18299. old exten matching code consistently handle case in the matching.
  18300. * Made ignore empty character sets. * Fixed ast_extension_cmp()
  18301. to return -1, 0, or 1 as documented. The only user of it in
  18302. pbx_lua.c was testing for -1. It was originally returning the
  18303. strcmp() value for less than which is not usually going to be -1.
  18304. * Fix character set sorting if the sets have the same number of
  18305. characters and start with the same character. Character set [0-9]
  18306. now sorts before [02-9a] as originally intended. * Updated some
  18307. extension label and priority already in use warnings to also
  18308. indicate if the extension is aliased. (closes issue
  18309. ASTERISK-19205) Reported by: Philippe Lindheimer, Birger "WIMPy"
  18310. Harzenetter Tested by: rmudgett Review:
  18311. https://reviewboard.asterisk.org/r/2201/ ........ Merged
  18312. revisions 376688 from
  18313. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18314. revisions 376689 from
  18315. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18316. revisions 376690 from
  18317. http://svn.asterisk.org/svn/asterisk/branches/11
  18318. * /, apps/app_celgenuserevent.c, pbx/pbx_dundi.c,
  18319. addons/res_config_mysql.c: Remove unnecessary channel module
  18320. references. * Removed call to ast_module_user_hangup_all() in
  18321. res_config_mysql.c since it is effectively a noop. No channels
  18322. can attach a reference to that module. * Removed call to
  18323. ast_module_user_hangup_all() in app_celgenuserevent.c. The caller
  18324. of unload_module() has already called it. * Removed redundant
  18325. channel module references in pbx_dundi.c. The registered dialplan
  18326. function callback dispatchers for the read/read2/write callbacks
  18327. already reference the module before calling. * pbx_dundi: Moved
  18328. unregistering CLI commands, DUNDi switch, and dialplan functions
  18329. to the first thing the unload_module() does. This will reduce the
  18330. chance of new channels using DUNDi services while the module is
  18331. being torn down. ........ Merged revisions 376657 from
  18332. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18333. revisions 376658 from
  18334. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18335. revisions 376659 from
  18336. http://svn.asterisk.org/svn/asterisk/branches/11
  18337. * include/asterisk/linkedlists.h, /: Made AST_LIST_REMOVE() simpler
  18338. and use better names. * Update doxygen of AST_LIST_REMOVE().
  18339. ........ Merged revisions 376627 from
  18340. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18341. revisions 376628 from
  18342. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18343. revisions 376629 from
  18344. http://svn.asterisk.org/svn/asterisk/branches/11
  18345. 2012-11-23 00:02 +0000 [r376589] Matthew Jordan <mjordan@digium.com>
  18346. * main/lock.c, /, main/logger.c, include/asterisk/lock.h:
  18347. Re-initialize logmsgs mutex upon logger initialization to prevent
  18348. lock errors Similar to the patch that moved the fork earlier in
  18349. the startup sequence to prevent mutex errors in the recursive
  18350. mutex surrounding the read/write thread registration lock, this
  18351. patch re-initializes the logmsgs mutex. Part of the start up
  18352. sequence before forking the process into the background includes
  18353. reading asterisk.conf; this has to occur prior to the call to
  18354. daemon in order to read startup parameters. When reading in a
  18355. conf file, log statements can be generated. Since this can't be
  18356. avoided, the mutex instead is re-initialized to ensure a reset of
  18357. any thread tracking information. This patch also includes some
  18358. additional debugging to catch errors when locking or unlocking
  18359. the recursive mutex that surrounds locks when the DEBUG_THREADS
  18360. build option is enabled. DO_CRASH or THREAD_CRASH will cause an
  18361. abort() if a mutex error is detected. (issue ASTERISK-19463)
  18362. Reported by: mjordan Tesetd by: mjordan ........ Merged revisions
  18363. 376586 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  18364. ........ Merged revisions 376587 from
  18365. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18366. revisions 376588 from
  18367. http://svn.asterisk.org/svn/asterisk/branches/11
  18368. 2012-11-21 18:33 +0000 [r376575] Richard Mudgett <rmudgett@digium.com>
  18369. * channels/chan_iax2.c, main/astobj2.c, include/asterisk/test.h,
  18370. main/channel.c, include/asterisk/astobj2.h, main/test.c,
  18371. tests/test_astobj2.c: Add red-black tree container type to
  18372. astobj2. * Add red-black tree container type. * Add CLI command
  18373. "astobj2 container dump <name>" * Added ao2_container_dump() so
  18374. the container could be dumped by other modules for debugging
  18375. purposes. * Changed ao2_container_stats() so it can be used by
  18376. other modules like ao2_container_check() for debugging purposes.
  18377. * Updated the unit tests to check red-black tree containers.
  18378. (closes issue ASTERISK-19970) Reported by: rmudgett Tested by:
  18379. rmudgett Review: https://reviewboard.asterisk.org/r/2110/
  18380. 2012-11-20 22:06 +0000 [r376562] David M. Lee <dlee@digium.com>
  18381. * res/res_http_websocket.c, /: Added missing newlines to websocket
  18382. ast_logs. Without these newlines, log messages just continue
  18383. tacking onto the same line, and do not flush immediately.
  18384. ........ Merged revisions 376561 from
  18385. http://svn.asterisk.org/svn/asterisk/branches/11
  18386. 2012-11-20 19:09 +0000 [r376551] Mark Michelson <mmichelson@digium.com>
  18387. * channels/sip/include/sip.h, /, channels/chan_sip.c: Add "Require:
  18388. timer" to 200 OK responses when appropriate. The method by which
  18389. the Require header is added to 200 responses is inspired by the
  18390. method that Olle Johansson uses in his darjeeling-prack branch.
  18391. (closes issue ASTERISK-20570) Reported by Matt Jordan, at the
  18392. behest of Olle Johansson Review:
  18393. https://reviewboard.asterisk.org/r/2172 ........ Merged revisions
  18394. 376521 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  18395. ........ Merged revisions 376522 from
  18396. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18397. revisions 376550 from
  18398. http://svn.asterisk.org/svn/asterisk/branches/11
  18399. 2012-11-20 17:39 +0000 [r376541] Alec L Davis <sivad.a@paradise.net.nz>
  18400. * /, channels/chan_sip.c: Reduce CLI spam of "Extension Changed"
  18401. device state messages. Asterisk 11 follows RFC3265 that states
  18402. that after every subscribe or resubscribe a notify should be
  18403. sent. Thus the console if filled continuously with the following
  18404. after every subscribe; == Extension Changed 8512[phones] new
  18405. state IDLE for Notify User cisco1 In Asterisk 1.8 only changes
  18406. would be sent. Thus only when a device state changed was anything
  18407. emitted to the console. fix: Only print to console when device
  18408. state isn't forced. (closes issue ASTERISK-20706) Reported by:
  18409. alecdavis Tested by: alecdavis alecdavis (license 585) ........
  18410. Merged revisions 376540 from
  18411. http://svn.asterisk.org/svn/asterisk/branches/11
  18412. 2012-11-19 20:03 +0000 [r376472] Walter Doekes <walter+asterisk@wjd.nu>
  18413. * main/indications.c, /, channels/chan_sip.c,
  18414. main/security_events.c: Fix most leftover non-opaque ast_str
  18415. uses. Instead of calling str->str, one should use
  18416. ast_str_buffer(str). Same goes for str->used as
  18417. ast_str_strlen(str) and str->len as ast_str_size(str). Review:
  18418. https://reviewboard.asterisk.org/r/2198 ........ Merged revisions
  18419. 376469 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  18420. ........ Merged revisions 376470 from
  18421. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18422. revisions 376471 from
  18423. http://svn.asterisk.org/svn/asterisk/branches/11
  18424. 2012-11-19 02:14 +0000 [r376416-376457] Matthew Jordan <mjordan@digium.com>
  18425. * tests/test_astobj2.c: Fix uninitialized in this function error
  18426. With some versions of gcc, n_buckets will be flagged as being
  18427. uninitialized before use. While its technically impossible (since
  18428. the switch statement, even without a default, accounts for all
  18429. possibilities), we'll initialize the variable to 0 anyway.
  18430. * main/asterisk.c, /, main/utils.c: Reorder startup sequence to
  18431. prevent lockups when process is sent to background Although it is
  18432. very rare and timing dependent, the potential exists for the call
  18433. to 'daemon' to cause what appears to be a deadlock in Asterisk
  18434. during startup. This can occur when a recursive mutex is obtained
  18435. prior to the daemon call executing. Since daemon uses fork to
  18436. send the process into the background, any threading primitives
  18437. are unsafe to re-use after the call. Implementations of pthread
  18438. recursive mutexes are highly likely to store the thread
  18439. identifier of the thread that previously obtained the mutex. If
  18440. the mutex was locked prior to the fork, a subsequent unlock
  18441. operation will potentially fail as the thread identifier is no
  18442. longer valid. Since the mutex is still locked, all subsequent
  18443. attempts to grab the mutex by other threads will block. This
  18444. behavior exhibited itself most often when DEBUG_THREADS was
  18445. enabled, as this compile time option surrounds the mutexes in
  18446. Asterisk with another recursive mutex that protects the storage
  18447. of thread related information. This made it much more likely that
  18448. a recursive mutex would be obtained prior to daemon and unlocked
  18449. after the call. This patch does the following: a) It backports a
  18450. patch from Asterisk 11 that prevents the spawning of the
  18451. localtime monitoring thread. This thread is now spawned after
  18452. Asterisk has fully booted. b) It re-orders the startup sequence
  18453. to call daemon earlier during Asterisk startup. This limits the
  18454. potential of threading primitives being accessed by
  18455. initialization calls before daemon is called. c) It removes calls
  18456. to ast_verbose/ast_log/etc. prior to daemon being called.
  18457. Developers should send error messages directly to stderr prior to
  18458. daemon, as calls to ast_log may access recursive mutexes that
  18459. store thread related information. d) It reorganizes when thread
  18460. local storage is created for storing lock information during the
  18461. creation of threads. Prior to this patch, the read/write lock
  18462. protecting the list of threads in ast_register_thread would
  18463. utilize the lock in the thread local storage prior to it being
  18464. initialized; this patch prevents that. On a very related note,
  18465. this patch will *greatly* improve the stability of the Asterisk
  18466. Test Suite. Review: https://reviewboard.asterisk.org/r/2197
  18467. (closes issue ASTERISK-19463) Reported by: mjordan Tested by:
  18468. mjordan ........ Merged revisions 376428 from
  18469. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18470. revisions 376431 from
  18471. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18472. revisions 376441 from
  18473. http://svn.asterisk.org/svn/asterisk/branches/11
  18474. * apps/confbridge/conf_state.c, /: Add a test event that reports
  18475. changes in ConfBridge state This patch adds a test event to
  18476. ConfBridge that reports transitions between states in ConfBridge.
  18477. This is used by tests in the Asterisk Test Suite that verify
  18478. state changes based on the entering/leaving of conference
  18479. participants. ........ Merged revisions 376414 from
  18480. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18481. revisions 376415 from
  18482. http://svn.asterisk.org/svn/asterisk/branches/11
  18483. 2012-11-16 00:15 +0000 [r376341-376345] David M. Lee <dlee@digium.com>
  18484. * /, utils/extconf.c: Fixed extconf.c breakage introduced in
  18485. r376306. To quote wdoekes: > Note that I'm not confirming
  18486. legitimacy of having that file in tree at > all. Is anyone using
  18487. aelparse/conf2ael? ........ Merged revisions 376340 from
  18488. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18489. revisions 376342 from
  18490. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18491. revisions 376343 from
  18492. http://svn.asterisk.org/svn/asterisk/branches/11
  18493. * /: Somehow I put in svn-1.6 merge information. Oops.
  18494. * utils/Makefile, tests/test_astobj2_thrash.c (added),
  18495. utils/utils.xml, /, utils/hashtest.c (removed),
  18496. tests/test_hashtab_thrash.c (added), utils/hashtest2.c (removed),
  18497. include/asterisk/hashtab.h: Migrate hashtest/hashtest2 to be unit
  18498. tests. Both hashtest and hashtest2 are manual testing apps that
  18499. thrash hash tables (hashtab and ao2 containers, respectively), by
  18500. spinning up several threads that randomly insert, delete, lookup
  18501. and iterate over the hash table. If the app doesn't crash, the
  18502. hash table probably passes the test. Those utils are not a part
  18503. of the typical Asterisk build, so they do not usually get
  18504. compiled. This all makes them less that useful. This patch
  18505. removes those manual test programs and replaces them with
  18506. Asterisk unit test modules (test_{hashtab,astobj2}_thrash.so). It
  18507. also attempts to make the tests more deterministic. * Rather than
  18508. spinning up some number of threads that operate on the hash table
  18509. randomly, spin up four threads that concurrenly add, remove,
  18510. lookup and iterate over the hash table. * Each thread checks the
  18511. state of the hash table both during and after execution, and
  18512. indicates a test failure if things are not as expected. * Each
  18513. thread times out after 60 seconds to prevent deadlocking the unit
  18514. test run. (closes issue ASTERISK-20505) Reported by: Matt Jordan
  18515. Review: https://reviewboard.asterisk.org/r/2189/ ........ Merged
  18516. revisions 376306 from
  18517. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18518. revisions 376315 from
  18519. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18520. revisions 376339 from
  18521. http://svn.asterisk.org/svn/asterisk/branches/11
  18522. 2012-11-15 23:10 +0000 [r376312] Jonathan Rose <jrose@digium.com>
  18523. * /, apps/app_meetme.c: app_meetme: Fix channels lingering when
  18524. hung up under certain conditions Channels would get stuck and
  18525. MeetMe would repeatedly display an Unable to write frame to
  18526. channel error in the conf_run function if hung up during certain
  18527. sound prompts such as during user count announcements. This patch
  18528. fixes that by reintroducing a hangup check in the meetme's main
  18529. loop (also in conf_run). (closes issue ASTERISK-20486) Reported
  18530. by: Michael Cargile Review:
  18531. https://reviewboard.asterisk.org/r/2187/ Patches:
  18532. meetme_hangup_patch_ASTERISK-20486_v3.diff uploaded by Jonathan
  18533. Rose (license 6182) ........ Merged revisions 376307 from
  18534. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18535. revisions 376308 from
  18536. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18537. revisions 376310 from
  18538. http://svn.asterisk.org/svn/asterisk/branches/11
  18539. 2012-11-15 14:35 +0000 [r376291] Brent Eagles <beagles@digium.com>
  18540. * main/channel.c, /: Patch to prevent stopping the active generator
  18541. when it is not the silence generator. This patch introduces an
  18542. internal helper function to safely check whether the current
  18543. generator is the one that is expected before deactivating it. The
  18544. current externally accessible ast_channel_stop_generator()
  18545. function has been modified to be implemented in terms of the new
  18546. function. (closes issue ASTERISK-19918) Reported by: Eduardo Abad
  18547. ........ Merged revisions 376217 from
  18548. http://svn.asterisk.org/svn/asterisk/branches/11
  18549. 2012-11-15 02:29 +0000 [r376282] Rusty Newton <rnewton@digium.com>
  18550. * apps/app_voicemail.c, /: Patch to play correct sound file when a
  18551. voicemail's urgent status is removed We were attempting to play
  18552. "vm-urgent-removed", which didn't exist. Now we play
  18553. "vm-marked-nonurgent" which exists and is the correct sound file.
  18554. Previous behavior was silence and a warning on the CLI. (issue
  18555. ASTERISK-20280) (closes issue ASTERISK-20280) Reported by: Tomo
  18556. Takebe Tested by: Rusty Newton Patches: asterisk20280.patch
  18557. uploaded by Rusty Newton (license 5829) ........ Merged revisions
  18558. 376262 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  18559. ........ Merged revisions 376263 from
  18560. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18561. revisions 376264 from
  18562. http://svn.asterisk.org/svn/asterisk/branches/11
  18563. 2012-11-14 19:55 +0000 [r376235] Richard Mudgett <rmudgett@digium.com>
  18564. * pbx/pbx_spool.c, /: Fix call files when astspooldir is relative.
  18565. Future dated call files are ignored when astspooldir is relative
  18566. to the current directory. The queue_file() assumed that the qdir
  18567. needed to be prepended if the given filename did not start with a
  18568. '/'. If astspooldir is relative it is not going to start from the
  18569. root directory obviously so it will not start with a '/'. The
  18570. filename used in queue_file() ultimately results in qdir
  18571. prepended multiple times. * Made queue_file() not prepend qdir if
  18572. the filename contains a '/'. (closes issue ASTERISK-20593)
  18573. Reported by: James Le Cuirot Patches:
  18574. 0004-Fix-future-call-files-from-relative-directories.patch
  18575. (license #6439) patch uploaded by James Le Cuirot ........ Merged
  18576. revisions 376232 from
  18577. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18578. revisions 376233 from
  18579. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18580. revisions 376234 from
  18581. http://svn.asterisk.org/svn/asterisk/branches/11
  18582. 2012-11-13 19:42 +0000 [r376219] Jonathan Rose <jrose@digium.com>
  18583. * CHANGES, channels/chan_sip.c: chan_sip: Add SubscribeContext
  18584. field to SIPshowpeer AMI response The new field is will show up
  18585. within the response if the requested peer has a subscribe context
  18586. set. (closes issue ASTERISK-20626) Reported by: Jaco Kroon
  18587. Patches: asterisk-sip-ami-SubscrContext.patch uploaded by jkroon
  18588. (license 5671) -with modifications by jrose to conform to style
  18589. guidelines Review: https://reviewboard.asterisk.org/r/2195/
  18590. 2012-11-12 20:46 +0000 [r376169] Joshua Colp <jcolp@digium.com>
  18591. * /, main/pbx.c: Properly check if the "Context" and "Extension"
  18592. headers are empty in a ShowDialPlan action. The code which
  18593. handles the ShowDialPlan action wrongly assumed that a non-NULL
  18594. return value from the function which retrieves headers from an
  18595. action indicates that the header has a value. This is incorrect
  18596. and the contents must be checked to see if they are blank.
  18597. (closes issue ASTERISK-20628) Reported by: jkroon Patches:
  18598. asterisk-showdialplan-incorrect-error.patch uploaded by jkroon
  18599. ........ Merged revisions 376166 from
  18600. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18601. revisions 376167 from
  18602. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18603. revisions 376168 from
  18604. http://svn.asterisk.org/svn/asterisk/branches/11
  18605. 2012-11-12 20:18 +0000 [r376148] Michael L. Young <elgueromexicano@gmail.com>
  18606. * main/pbx.c, /: Fix Dynamic Hints Variable Substition - Underscore
  18607. Problem When adding a dynamic hint, if an extension contains an
  18608. underscore no variable subsitution is being performed. This patch
  18609. changes from checking if the extension contains an underscore to
  18610. checking if the extension begins with an underscore. (closes
  18611. issue ASTERISK-20639) Reported by: Steven T. Wheeler Tested by:
  18612. Steven T. Wheeler, Michael L. Young Patches:
  18613. asterisk-20639-dynamic-hint-underscore.diff uploaded by Michael
  18614. L. Young (license 5026) Review:
  18615. https://reviewboard.asterisk.org/r/2188/ ........ Merged
  18616. revisions 376142 from
  18617. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18618. revisions 376143 from
  18619. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18620. revisions 376144 from
  18621. http://svn.asterisk.org/svn/asterisk/branches/11
  18622. 2012-11-11 17:15 +0000 [r376131] Joshua Colp <jcolp@digium.com>
  18623. * configs/sip.conf.sample, res/res_rtp_asterisk.c, /,
  18624. channels/chan_sip.c: Remove a fixed size limitation for producing
  18625. SDP and change how ICE support is disabled by default. With ICE
  18626. support enabled in chan_sip and a large number of interfaces on
  18627. the system it was possible for the produced SDP to be truncated
  18628. due to some fixed size buffers. These buffers have now been
  18629. changed so they will dynamically grow as needed. ICE support is
  18630. now also enabled by default in res_rtp_asterisk to provide a
  18631. smoother experience for chan_motif users where it is required. To
  18632. maintain the previous behavior in chan_sip it is no longer
  18633. enabled by default there. (closes issue ASTERISK-20643) Reported
  18634. by: coopvr ........ Merged revisions 376130 from
  18635. http://svn.asterisk.org/svn/asterisk/branches/11
  18636. 2012-11-08 22:10 +0000 [r376092] Mark Michelson <mmichelson@digium.com>
  18637. * /, res/res_fax.c: Fix a "set but not used" warning on newer gccs.
  18638. Turns out the "helpful" setting of ms and res in this macro is
  18639. completely useless after the timeout antipattern fix. If you're a
  18640. new guy looking to write code, don't write a macro like this one.
  18641. ........ Merged revisions 376087 from
  18642. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18643. revisions 376088 from
  18644. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18645. revisions 376089 from
  18646. http://svn.asterisk.org/svn/asterisk/branches/11
  18647. 2012-11-08 21:12 +0000 [r376049-376061] Richard Mudgett <rmudgett@digium.com>
  18648. * /, channels/sig_ss7.c: chan_dahdi/SS7: Made reject incoming call
  18649. for an in-alarm or blocked channel. If a SS7 call comes in
  18650. requesting a CIC that is in-alarm, the call is accepted and
  18651. connects if the extension exists in the dialplan. The call does
  18652. not have any audio. * Made release the call immediately with
  18653. circuit congestion cause. (closes issue ASTERISK-20204) Reported
  18654. by: Tuan Le Patches: jira_asterisk_20204_v1.8.patch (license
  18655. #5621) patch uploaded by rmudgett ........ Merged revisions
  18656. 376058 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  18657. ........ Merged revisions 376059 from
  18658. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18659. revisions 376060 from
  18660. http://svn.asterisk.org/svn/asterisk/branches/11
  18661. * include/asterisk/utils.h, include/asterisk/astmm.h, /,
  18662. main/utils.c, main/astmm.c, main/asterisk.c: Add MALLOC_DEBUG
  18663. enhancements. * Makes malloc() behave like calloc(). It will
  18664. return a memory block filled with 0x55. A nonzero value. * Makes
  18665. free() fill the released memory block and boundary fence's with
  18666. 0xdeaddead. Any pointer use after free is going to have a pointer
  18667. pointing to 0xdeaddead. The 0xdeaddead pointer is usually an
  18668. invalid memory address so a crash is expected. * Puts the freed
  18669. memory block into a circular array so it is not reused
  18670. immediately. * When the circular array rotates out a memory block
  18671. to the heap it checks that the memory has not been altered from
  18672. 0xdeaddead. * Made the astmm_log message wording better. * Made
  18673. crash if the DO_CRASH menuselect option is enabled and something
  18674. is found. * Fixed a potential alignment issue on 64 bit systems.
  18675. struct ast_region.data[] should now be aligned correctly for all
  18676. platforms. * Extracted region_check_fences() from
  18677. __ast_free_region() and handle_memory_show(). * Updated
  18678. handle_memory_show() CLI usage help. Review:
  18679. https://reviewboard.asterisk.org/r/2182/ ........ Merged
  18680. revisions 376029 from
  18681. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18682. revisions 376030 from
  18683. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18684. revisions 376048 from
  18685. http://svn.asterisk.org/svn/asterisk/branches/11
  18686. 2012-11-07 19:15 +0000 [r376015] Mark Michelson <mmichelson@digium.com>
  18687. * apps/app_dial.c, main/pbx.c, main/rtp_engine.c, /,
  18688. apps/app_meetme.c, res/res_fax.c, apps/app_record.c,
  18689. channels/chan_agent.c, main/utils.c, include/asterisk/channel.h,
  18690. apps/app_queue.c, channels/sig_pri.c, channels/chan_iax2.c,
  18691. main/channel.c, channels/chan_dahdi.c, apps/app_waitforring.c,
  18692. channels/sig_analog.c, apps/app_jack.c, include/asterisk/time.h:
  18693. Multiple revisions 375993-375994 ........ r375993 | mmichelson |
  18694. 2012-11-07 11:01:13 -0600 (Wed, 07 Nov 2012) | 30 lines Fix
  18695. misuses of timeouts throughout the code. Prior to this change, a
  18696. common method for determining if a timeout was reached was to
  18697. call a function such as ast_waitfor_n() and inspect the out
  18698. parameter that told how many milliseconds were left, then use
  18699. that as the input to ast_waitfor_n() on the next go-around. The
  18700. problem with this is that in some cases, submillisecond timeouts
  18701. can occur, resulting in the out parameter not decreasing any.
  18702. When this happens thousands of times, the result is that the
  18703. timeout takes much longer than intended to be reached. As an
  18704. example, I had a situation where a 3 second timeout took multiple
  18705. days to finally end since most wakeups from ast_waitfor_n() were
  18706. under a millisecond. This patch seeks to fix this pattern
  18707. throughout the code. Now we log the time when an operation began
  18708. and find the difference in wall clock time between now and when
  18709. the event started. This means that sub-millisecond timeouts now
  18710. cannot play havoc when trying to determine if something has timed
  18711. out. Part of this fix also includes changing the function
  18712. ast_waitfor() so that it is possible for it to return less than
  18713. zero when a negative timeout is given to it. This makes it
  18714. actually possible to detect errors in ast_waitfor() when there is
  18715. no timeout. (closes issue ASTERISK-20414) reported by David M.
  18716. Lee Review: https://reviewboard.asterisk.org/r/2135/ ........
  18717. r375994 | mmichelson | 2012-11-07 11:08:44 -0600 (Wed, 07 Nov
  18718. 2012) | 3 lines Remove some debugging that accidentally made it
  18719. in the last commit. ........ Merged revisions 375993-375994 from
  18720. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18721. revisions 375995 from
  18722. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18723. revisions 376014 from
  18724. http://svn.asterisk.org/svn/asterisk/branches/11
  18725. 2012-11-06 19:05 +0000 [r375967] Richard Mudgett <rmudgett@digium.com>
  18726. * /, main/channel_internal_api.c, main/features.c,
  18727. include/asterisk/channel.h, include/asterisk/features.h,
  18728. main/channel.c: Fix stuck DTMF when bridge is broken. When a
  18729. bridge is broken by an AMI Redirect action or the ChannelRedirect
  18730. application, an in progress DTMF digit could be stuck sending
  18731. forever. * Made simulate a DTMF end event when a bridge is broken
  18732. and a DTMF digit was in progress. (closes issue ASTERISK-20492)
  18733. Reported by: Jeremiah Gowdy Patches: bridge_end_dtmf-v3.patch.txt
  18734. (license #6358) patch uploaded by Jeremiah Gowdy Modified to
  18735. jira_asterisk_20492_v1.8.patch jira_asterisk_20492_v1.8.patch
  18736. (license #5621) patch uploaded by rmudgett Tested by: rmudgett
  18737. Review: https://reviewboard.asterisk.org/r/2169/ ........ Merged
  18738. revisions 375964 from
  18739. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18740. revisions 375965 from
  18741. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18742. revisions 375966 from
  18743. http://svn.asterisk.org/svn/asterisk/branches/11
  18744. 2012-11-06 12:15 +0000 [r375926] Joshua Colp <jcolp@digium.com>
  18745. * /, channels/chan_motif.c: Fix a bug where our Motif ICE
  18746. candidates were not quite proper, and make us more forgiving. An
  18747. issue was reported on the mailing list where calling would result
  18748. in an "Incomplete ICE-UDP candidate received on session" error
  18749. message. This is the result of the ICE-UDP candidate code not
  18750. placing a "network" attribute within the candidates. This is now
  18751. done. To increase compatibility though I have removed the
  18752. requirement for the "network" attribute to exist within ICE-UDP
  18753. candidates that are received since we don't actually require the
  18754. value. Reported on the mailing list by Jean-Denis Girard.
  18755. ........ Merged revisions 375925 from
  18756. http://svn.asterisk.org/svn/asterisk/branches/11
  18757. 2012-11-05 23:10 +0000 [r375896] Matthew Jordan <mjordan@digium.com>
  18758. * channels/chan_iax2.c, res/res_fax_spandsp.c,
  18759. res/res_timing_kqueue.c, main/timing.c, main/channel.c, /,
  18760. res/res_timing_pthread.c, res/res_timing_dahdi.c,
  18761. res/res_timing_timerfd.c, bridges/bridge_softmix.c,
  18762. funcs/func_jitterbuffer.c, include/asterisk/timing.h,
  18763. res/res_musiconhold.c: Refactor ast_timer_ack to return an error
  18764. and handle the error in timer users Currently, if an
  18765. acknowledgement of a timer fails Asterisk will not realize that a
  18766. serious error occurred and will continue attempting to use the
  18767. timer's file descriptor. This can lead to situations where errors
  18768. stream to the CLI/log file. This consumes significant resources,
  18769. masks the actual problem that occurred (whatever caused the timer
  18770. to fail in the first place), and can leave channels in odd
  18771. states. This patch propagates the errors in the timing resource
  18772. modules up through the timer core, and makes users of these
  18773. timers handle acknowledgement failures. It also adds some
  18774. defensive coding around the use of timers to prevent using bad
  18775. file descriptors in off nominal code paths. Note that the patch
  18776. created by the issue reporter was modified slightly for this
  18777. commit and backported to 1.8, as it was originally written for
  18778. Asterisk 10. Review: https://reviewboard.asterisk.org/r/2178/
  18779. (issue ASTERISK-20032) Reported by: Jeremiah Gowdy patches:
  18780. jgowdy-timerfd-6-22-2012.diff uploaded by Jeremiah Gowdy (license
  18781. 6358) ........ Merged revisions 375893 from
  18782. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18783. revisions 375894 from
  18784. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18785. revisions 375895 from
  18786. http://svn.asterisk.org/svn/asterisk/branches/11
  18787. 2012-11-05 21:42 +0000 [r375865] Richard Mudgett <rmudgett@digium.com>
  18788. * main/loader.c, /: Add safety NULL pointer check in module user
  18789. references. Made __ast_module_user_remove() check for NULL
  18790. pointers. ........ Merged revision 375860 from C.3 ........
  18791. Merged revisions 375862 from
  18792. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18793. revisions 375863 from
  18794. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18795. revisions 375864 from
  18796. http://svn.asterisk.org/svn/asterisk/branches/11
  18797. 2012-11-05 18:00 +0000 [r375848] Jonathan Rose <jrose@digium.com>
  18798. * /, UPGRADE.txt: chan_sip: Document a change to user-field
  18799. encoding introduced with r303509 The change in question was added
  18800. to improve compliance with RFC3261, but at the time of commit, it
  18801. wasn't adequately documented in the UPGRADE notes. (closes issue
  18802. ASTERISK-20561) Reported by: Deniz Review:
  18803. https://reviewboard.asterisk.org/r/2177/ ........ Merged
  18804. revisions 375846 from
  18805. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18806. revisions 375847 from
  18807. http://svn.asterisk.org/svn/asterisk/branches/11
  18808. 2012-11-04 03:10 +0000 [r375730-375803] Matthew Jordan <mjordan@digium.com>
  18809. * main/manager.c, /: Don't attempt to purge sessions when no
  18810. sessions exist Manager's tcp/tls objects have a periodic function
  18811. that purge old manager sessions periodically. During shutdown,
  18812. the underlying container holding those sessions can be disposed
  18813. of and set to NULL before the tcp/tls periodic function is
  18814. stopped. If the periodic function fires, it will attempt to
  18815. iterate over a NULL container. This patch checks for whether or
  18816. not the sessions container exists before attempting to purge
  18817. sessions out of it. If the sessions container is NULL, we simply
  18818. return. Note that this error was also caught by the Asterisk Test
  18819. Suite. ........ Merged revisions 375800 from
  18820. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18821. revisions 375801 from
  18822. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18823. revisions 375802 from
  18824. http://svn.asterisk.org/svn/asterisk/branches/11
  18825. * /, res/res_fax.c: Only deref a reserved gateway session if we
  18826. actually reserved one Its perfectly acceptable to have a gateway
  18827. session unreserved when we go to first allocate one. Unreffing
  18828. the reserved gateway session - when its NULL - will result in an
  18829. assertion error. This problem was caught by the Asterisk Test
  18830. Suite (once we had enough of the debugging flags enabled)
  18831. ........ Merged revisions 375797 from
  18832. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18833. revisions 375798 from
  18834. http://svn.asterisk.org/svn/asterisk/branches/11
  18835. * /, main/manager.c: Properly clean up manager resources on exit
  18836. This patch does two things: 1) It properly unregisters the
  18837. manager CLI commands 2) It cleans up AMI users on exit. Prior to
  18838. this patch, the AMI users were not being disposed of properly,
  18839. resulting in a memory leak. (closes issue ASTERISK-20646)
  18840. Reported by: Corey Farrell patches: manager_shutdown.patch
  18841. uploaded by Corey Farrell (license 5909) ........ Merged
  18842. revisions 375793 from
  18843. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18844. revisions 375794 from
  18845. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18846. revisions 375795 from
  18847. http://svn.asterisk.org/svn/asterisk/branches/11
  18848. * /, main/db.c: Properly finalize prepared SQLite3 statements to
  18849. prevent memory leak The AstDB uses prepared SQLite3 statements to
  18850. retrieve data from the SQLite3 database. These statements should
  18851. be finalized during Asterisk shutdown so that the SQLite3
  18852. database can be properly closed. Failure to finalize the
  18853. statements results in a memory leak and a failure when closing
  18854. the database. This patch fixes those issues by ensuring that all
  18855. prepared statements are properly finalized at shutdown. (closes
  18856. issue ASTERISK-20647) Reported by: Corey Farrell patches:
  18857. astdb-sqlite3_close.patch uploaded by Corey Farrell (license
  18858. 5909) ........ Merged revisions 375761 from
  18859. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18860. revisions 375763 from
  18861. http://svn.asterisk.org/svn/asterisk/branches/11
  18862. * main/xmldoc.c, /: Fix memory leaks in XML documentation This
  18863. patch fixes two memory leaks: 1) When building XML documentation
  18864. items, the 'name' attribute was extracted from XML elements but
  18865. not properly freed after being copied into the item being built.
  18866. 2) When unloading XML documentation, the doctree container
  18867. objects were not properly freed. This patch corrects these memory
  18868. leaks. Note that this patch was modified slightly for this
  18869. commmit, as the case where the 'name' attribute doesn't exist
  18870. also wasn't handled in the item construction. This patch also
  18871. checks for that attribute not existing. (closes issue
  18872. ASTERISK-20648) Reported by: Corey Farrell Tested by: mjordan
  18873. patches: xmldoc-memory_leak.patch uploaded by Corey Farrell
  18874. (license 5909) ........ Merged revisions 375756 from
  18875. http://svn.asterisk.org/svn/asterisk/branches/11
  18876. * main/cdr.c, /: Prevent multiple CDR batches from conflicting when
  18877. scheduling the CDR write The Asterisk Test Suite caught an error
  18878. condition where a scheduled CDR batch write can be deleted twice
  18879. if two channels attempt to post their CDRs at the same time. The
  18880. batch CDR mutex is locked while the CDRs are appended to the
  18881. current batch list; however, it is unlocked prior to actually
  18882. scheduling the CDR write. As such, two threads can attempt to
  18883. remove the currently scheduled batch write at the same time,
  18884. resulting in an assertion error. This patch extends the time that
  18885. the mutex is locked to encompass actually scheduling the write.
  18886. This prevents two threads from unscheduling the currently
  18887. scheduled write at the same time. ........ Merged revisions
  18888. 375727 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  18889. ........ Merged revisions 375728 from
  18890. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18891. revisions 375729 from
  18892. http://svn.asterisk.org/svn/asterisk/branches/11
  18893. 2012-11-02 21:03 +0000 [r375663] Damien Wedhorn <voip@facts.com.au>
  18894. * /, channels/chan_skinny.c: Fix for chan_skinny leaving RTP ports
  18895. open Skinny wasn't closing RTP sockets. This patch includes
  18896. ast_rtp_instance_stop before ast_rtp_instance_destroy which fixes
  18897. the problem. Also add destroy for VRTP (which I believe is
  18898. unused, but exists). Review:
  18899. https://reviewboard.asterisk.org/r/2176/ ........ Merged
  18900. revisions 375660 from
  18901. http://svn.asterisk.org/svn/asterisk/branches/11
  18902. 2012-11-02 21:01 +0000 [r375628-375662] Richard Mudgett <rmudgett@digium.com>
  18903. * main/channel.c, channels/chan_misdn.c, /, main/ccss.c,
  18904. main/format_pref.c: Things don't need to be that const. ........
  18905. Merged revisions 375658 from
  18906. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18907. revisions 375659 from
  18908. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18909. revisions 375661 from
  18910. http://svn.asterisk.org/svn/asterisk/branches/11
  18911. * channels/misdn/isdn_lib.c, channels/misdn/isdn_lib.h, /: Multiple
  18912. revisions 375519-375524 ........ r375519 | rmudgett | 2012-10-30
  18913. 16:06:15 -0500 (Tue, 30 Oct 2012) | 11 lines chan_misdn: Timer
  18914. primitives must be handled first. The frm->addr is a different
  18915. "address space" than the stack/instance address of other Lx
  18916. primitives. The test for B channel instance address could fail.
  18917. Patches: patch01_timers.diff (license #6372) patch uploaded by
  18918. Guenther Kelleter JIRA ABE-2888 ........ r375520 | rmudgett |
  18919. 2012-10-30 16:14:58 -0500 (Tue, 30 Oct 2012) | 10 lines
  18920. chan_misdn: Free memory in error paths and other memory leaks.
  18921. The one line commented with BUG is not easily fixable because
  18922. there is no de-init function one can call. Patches:
  18923. patch02_memory.diff (license #6372) patch uploaded by Guenther
  18924. Kelleter JIRA ABE-2888 ........ r375521 | rmudgett | 2012-10-30
  18925. 16:38:41 -0500 (Tue, 30 Oct 2012) | 14 lines chan_misdn: ISDN NT
  18926. L2 de-establish/establish * An NT-PTMP cannot de/establish L2
  18927. since it doesn't know the TEIs. * On NT-PTP L2 is started when L1
  18928. is finally active in handle_l1. * L2 deactivation logging
  18929. cleanup. * L2 aggregate link status is unknown for NT-PTMP, show
  18930. as "UNKN". * Removed unused functions and code for L2 handling.
  18931. Patches: patch03_L2estab.diff (license #6372) patch uploaded by
  18932. Guenther Kelleter Modified JIRA ABE-2888 ........ r375522 |
  18933. rmudgett | 2012-10-30 16:56:14 -0500 (Tue, 30 Oct 2012) | 22
  18934. lines chan_misdn: Fix broken upper_id/lower_id usage. Sending PH
  18935. prim via lower_id layer (3 or 1) simply does not work. For TE (3)
  18936. it returns an error (len=-6) which is not evaluated by
  18937. handle_l1(), so the L1 layer status ends up wrong. Instead PH
  18938. must be sent via L4, only then does it reach L1 without an error
  18939. message. And NT PH prims only reach L1 when they are sent to
  18940. layer 2 id. --> use upper_id to send PH primitives. * Check for
  18941. errors in PH_(DE)ACTIVATE | CONFIRM. * Debug messages are
  18942. improved. * The lower_id is now not used for anything, except:
  18943. Why is lower_id layer deleted when it wasn't created? I removed
  18944. this code since it looks very wrong. Patches:
  18945. patch04_l1activation.diff (license #6372) patch uploaded by
  18946. Guenther Kelleter JIRA ABE-2888 ........ r375523 | rmudgett |
  18947. 2012-10-30 17:29:15 -0500 (Tue, 30 Oct 2012) | 31 lines
  18948. chan_misdn: Fix loss of B channels if L1 is down. If you make 2
  18949. calls out an NT PTMP port which is not connected to any phone,
  18950. the B channel associated with that call becomes unusable until
  18951. Asterisk is restarted. The problem is the EVENT_SETUP is queued
  18952. when L1 is not up in misdn_lib_send_event(). If L1 cannot be
  18953. activated the event won't be dequeued. It gets even worse when
  18954. the call is hung up. The queued EVENT_SETUP will be overwritten
  18955. by an EVENT_DISCONNECT. The reserved B channel then will never be
  18956. freed. If later someone connects a phone to the port, L1 will
  18957. eventually activate and the queued EVENT_DISCONNECT is sent down
  18958. the stack. However, it is ignored because it is the wrong call
  18959. state. The real fix would be that activation and queueing for a
  18960. new SETUP is done by the NT stack. But since it doesn't, the
  18961. workaround must be removed because it doesn't always work. Fix:
  18962. The event is no longer queued but immediately sent to the stack.
  18963. If L1 cannot be activated, the L3 state machine that was started
  18964. by the EVENT_SETUP will do its work, i.e. a timeout will release
  18965. the B channel properly. The SETUP possibly cannot be sent the
  18966. first time but is resent by T303 in case L1 could be activated.
  18967. Patches: patch05_bchan-loss.diff (license #6372) patch uploaded
  18968. by Guenther Kelleter Modified JIRA ABE-2888 ........ r375524 |
  18969. rmudgett | 2012-10-30 18:26:05 -0500 (Tue, 30 Oct 2012) | 13
  18970. lines chan_misdn: Remove some calls to exit(). Try proper cleanup
  18971. when something goes wrong in misdn_lib_init(). Especially do not
  18972. call exit()! * Fix memory leak because stack_destroy() does not
  18973. free the stack struct. Patches: patch06_cleanup-init.diff
  18974. (license #6372) patch uploaded by Guenther Kelleter Modified JIRA
  18975. ABE-2888 ........ Merged revisions 375519-375524 from
  18976. https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  18977. ........ Merged revisions 375625 from
  18978. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18979. revisions 375626 from
  18980. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18981. revisions 375627 from
  18982. http://svn.asterisk.org/svn/asterisk/branches/11
  18983. 2012-11-02 17:27 +0000 [r375614] Michael L. Young <elgueromexicano@gmail.com>
  18984. * /, channels/chan_sip.c: Fix Wrong Result In Debug Message For SDP
  18985. Origin Processing While looking at some debug logs, I noticed
  18986. that it was being reported that the SDP origin line was
  18987. unsupported or failed. Upon looking into this on my local
  18988. machine, I found that I too was getting this debug message yet
  18989. everything seemed to be getting processed properly. What was
  18990. discovered is, that, the variable to determine what is displayed
  18991. in the debug message for the SDP line that was processed, was not
  18992. being set for the origin line when the result was successful.
  18993. This patch fixes this and was tested on local machine. ........
  18994. Merged revisions 375594 from
  18995. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  18996. revisions 375601 from
  18997. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  18998. revisions 375613 from
  18999. http://svn.asterisk.org/svn/asterisk/branches/11
  19000. 2012-11-01 15:03 +0000 [r375576] Jonathan Rose <jrose@digium.com>
  19001. * configs/sip.conf.sample, /, channels/chan_sip.c: chan_sip: Fix a
  19002. bug causing SIP reloads to remove all entries from the registry A
  19003. regression was introduced in chan_sip by changes to sip reload
  19004. introduced by r349097. That patch moved peer purging from the
  19005. beginning of the reload to after the general configuration was
  19006. finished. This patch fixes that by undoing the repositioning of
  19007. the original peer purging code and using a similar function after
  19008. performing general configuration that purges only autocreated
  19009. peers that were created when persist mode isn't enabled. (closes
  19010. issue ASTERISK-20611) Reported by: Alisher Review:
  19011. https://reviewboard.asterisk.org/r/2171/ ........ Merged
  19012. revisions 375575 from
  19013. http://svn.asterisk.org/svn/asterisk/branches/11
  19014. 2012-10-31 18:01 +0000 [r375560] Joshua Colp <jcolp@digium.com>
  19015. * res/res_http_websocket.exports.in, /: Fix an issue with
  19016. res_http_websocket where the chan_sip WebSocket handler could not
  19017. be registered. On some systems the optional API support uses the
  19018. GCC compiler attribute "weakref" to provide its functionality.
  19019. This code changes the function names and prefixes "__" to the
  19020. front. The res_http_websocket exports file did not take this into
  19021. account, thereby not allowing those functions to be global and
  19022. ultimately found. (closes issue ASTERISK-20631) Reported by:
  19023. danjenkins ........ Merged revisions 375559 from
  19024. http://svn.asterisk.org/svn/asterisk/branches/11
  19025. 2012-10-31 14:58 +0000 [r375533] Matthew Jordan <mjordan@digium.com>
  19026. * /, res/res_calendar_ews.c: Properly extract the Body information
  19027. of an EWS calendar item Unlike all other calendar modules,
  19028. res_calendar_ews fails to extract the Body information for a
  19029. calendar item. This is due, in part, to a quirk in the schema in
  19030. the XML - not only does a CalendarItem contain a Body element,
  19031. but the CalendarItem exists as a descendant of a different Body
  19032. element. The neon parser was erroneously skipping all Body
  19033. elements. This patch fixes that by bypassing Body elements that
  19034. are not a child of CalendarItem, and parsing the Body element out
  19035. if it is a child. Note that the original patch by Terry Wilson
  19036. only needed slight modifications to make it properly pull the
  19037. Body information out; as such, while I've linked to the patch
  19038. that I uploaded for Dmitry, I've attributed the patch to Terry.
  19039. (closes issue ASTERISK-19738) Reported by: Dmitry Burilov Tested
  19040. by: Dmitry Burilov patches: calendar_ews_body_2012_10_29.diff
  19041. uploaded by Terry Wilson (license 6283) ........ Merged revisions
  19042. 375528 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  19043. ........ Merged revisions 375531 from
  19044. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19045. revisions 375532 from
  19046. http://svn.asterisk.org/svn/asterisk/branches/11
  19047. 2012-10-30 19:31 +0000 [r375511] Richard Mudgett <rmudgett@digium.com>
  19048. * /, bridges/bridge_softmix.c: Fix ConfBridge crash if no timing
  19049. module loaded. (closes issue ASTERISK-19448) Reported by: feyfre
  19050. Patches: smfix.patch (license #6099) patch uploaded by feyfre
  19051. Modified for coding guidelines. ........ Merged revisions 375496
  19052. from http://svn.asterisk.org/svn/asterisk/branches/10 ........
  19053. Merged revisions 375506 from
  19054. http://svn.asterisk.org/svn/asterisk/branches/11
  19055. 2012-10-30 19:20 +0000 [r375472-375498] Jonathan Rose <jrose@digium.com>
  19056. * /, apps/app_mixmonitor.c: mixmonitor: Add a test event This test
  19057. event is being used to fix the mixmonitor_audiohook_inherit test.
  19058. ........ Merged revisions 375484 from
  19059. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19060. revisions 375485 from
  19061. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19062. revisions 375486 from
  19063. http://svn.asterisk.org/svn/asterisk/branches/11
  19064. * /, apps/app_confbridge.c: confbridge: Fix a bug which made
  19065. conferences not record with AMI/CLI commands When confbridge was
  19066. changed to handle conference status with a state machine in
  19067. r374658. The function responsible for starting recording for a
  19068. conference was refactored with the function actually responsible
  19069. for launching the recording thread being split into a function
  19070. with another name. The old function name was still used for
  19071. manually started recordings through AMI or CLI. This patch fixes
  19072. that by switching which function is used to start recording the
  19073. conference. (closes issue ASTERISK-20601) Reported by: Vilius
  19074. Patches: confbridge_mixmonitor.diff uploaded by Jonathan Rose
  19075. (license 6182) ........ Merged revisions 375470 from
  19076. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19077. revisions 375471 from
  19078. http://svn.asterisk.org/svn/asterisk/branches/11
  19079. 2012-10-29 21:38 +0000 [r375442-375443] Mark Michelson <mmichelson@digium.com>
  19080. * /, channels/chan_sip.c: Prevent resetting of NATted realtime peer
  19081. address on reload. If a "sip reload" is issued for a SIP peer,
  19082. then his IP address will be cleared, thus resulting in forgetting
  19083. the public IP address. Asterisk will then attempt to route SIP
  19084. traffic to the private IP address. The fix here is to make "sip
  19085. reload" ignore realtime peers when "host = dynamic" is spotted.
  19086. Realtime peers can now only have their IP address reset if they
  19087. have gone from being not dynamic to being dynamic. (closes issue
  19088. ASTERISK-18203) reported by daren ferreira (closes issue
  19089. ASTERISK-20572) reported by JoshE Patches: fix_nat_realtime.diff
  19090. uploaded by JoshE (license #6075) ........ Merged revisions
  19091. 375415 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  19092. ........ Merged revisions 375417 from
  19093. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19094. revisions 375437 from
  19095. http://svn.asterisk.org/svn/asterisk/branches/11
  19096. * channels/chan_mgcp.c, main/pbx.c, apps/app_osplookup.c,
  19097. channels/chan_sip.c, channels/chan_skinny.c,
  19098. funcs/func_strings.c, UPGRADE.txt: Make evaluation of channel
  19099. variables consistently case-sensitive. Due to inconsistencies in
  19100. how variable names were evaluated, the decision was made to make
  19101. all evaluations case-sensitive. See the UPGRADE.txt file or
  19102. https://wiki.asterisk.org/wiki/display/AST/Case+Sensitivity for
  19103. more details. (closes issue ASTERISK-20163) reported by Matt
  19104. Jordan Review: https://reviewboard.asterisk.org/r/2160
  19105. 2012-10-29 21:02 +0000 [r375416] Matthew Jordan <mjordan@digium.com>
  19106. * UPGRADE.txt, apps/app_queue.c: Ensure that CDRs for a caller in a
  19107. Queue that is not answered is NO ANSWER. When a caller enters a
  19108. queue and no queue member answers the call, the current behaviour
  19109. can be a little odd depending on the paused status of the queue
  19110. members. If any queue member is paused, but not all, the CDR
  19111. disposition will be BUSY. If all queue members are paused, then
  19112. the CDR disposition is based instead on the disposition of the
  19113. call prior to entering the Queue. This patch modifies the
  19114. behaviour in the following ways: * If no queue members are
  19115. paused, the CDR disposition is whatever the disposition was prior
  19116. to going into Queue. If the call was answered this will be
  19117. ANSWERED; otherwise, it is NO ANSWER. * If some queue members are
  19118. pused, the CDR result is NO ANSWER. (This is a change in
  19119. behaviour, as the result would previously have been BUSY) * If
  19120. all queue members are paused, the CDR result is whatever the
  19121. result was prior to going into Queue. This is the same as the
  19122. behaviour prior to this patch. * If the caller hangs up, times
  19123. out, or presses '*' with the 'h' option, the CDR disposition is
  19124. again not set and is dependent on whether or not the caller was
  19125. Answered prior to entering Queue. This patch was based on one
  19126. provided by Thomas Arimont, but has been modified to accomodate
  19127. findings by the reviewers. Review:
  19128. https://reviewboard.asterisk.org/r/2064/ (closes issue AST-906)
  19129. Reported by: Thomas Arimont (closes issue ASTERISK-17776)
  19130. Reported by: Attila Megyeri
  19131. 2012-10-29 19:31 +0000 [r375364-375391] Richard Mudgett <rmudgett@digium.com>
  19132. * /, main/features.c: Fix the Park 'r' option when a channel parks
  19133. itself. When a channel uses the Park appliation to park itself
  19134. with the 'r' option, the channel hears music-on-hold instead of
  19135. the requested ringing. * Added a missing check for the 'r' option
  19136. when a channel parks itself. (closes issue ASTERISK-19382)
  19137. Reported by: James Stocks Patches by: dsessions Review:
  19138. https://reviewboard.asterisk.org/r/2148/ ........ Merged
  19139. revisions 375388 from
  19140. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19141. revisions 375389 from
  19142. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19143. revisions 375390 from
  19144. http://svn.asterisk.org/svn/asterisk/branches/11
  19145. * channels/chan_dahdi.c, /: chan_dahdi: Fix segfault dereferencing
  19146. a NULL tech_pvt. The tech support customer was using the AMI
  19147. Redirect action shortly after a call was placed. While the
  19148. channel tried to do an ast_read(), the masquerade resulting from
  19149. the channel redirect took place. The masquerade in the middle of
  19150. the ast_read() resulted in the segfault. (closes issue AST-1025)
  19151. Reported by: Trey Blancher Patches: jira_ast_1025_v1.8_v2.patch
  19152. (license #5621) patch uploaded by rmudgett ........ Merged
  19153. revisions 375361 from
  19154. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19155. revisions 375362 from
  19156. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19157. revisions 375363 from
  19158. http://svn.asterisk.org/svn/asterisk/branches/11
  19159. 2012-10-23 16:22 +0000 [r375291-375328] Jonathan Rose <jrose@digium.com>
  19160. * contrib/scripts/ast_tls_cert, /: ast_tls_cert script: Better
  19161. response for various exit conditions to openssl (closes issue
  19162. ASTERISK-20260) Reported by: Daniel O'Connor Patches:
  19163. ast_tls_cert-update.diff uploaded by Daniel O'Connor (license
  19164. 6419) ........ Merged revisions 375325 from
  19165. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19166. revisions 375326 from
  19167. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19168. revisions 375327 from
  19169. http://svn.asterisk.org/svn/asterisk/branches/11
  19170. * /, main/app.c: core: Fix a memory leak in app.c from an early
  19171. return ast_app_group_match_get_count allocates memory with the
  19172. regcomp function and we previously forgot to free it when bailing
  19173. out due to a regex compilation failure against category. (closes
  19174. issue AST-1018) Reported by: Guenther Kelleter Patches:
  19175. regcomp_memleak.diff uploaded by Guenther Kelleter (license 6372)
  19176. ........ Merged revisions 375299 from
  19177. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19178. revisions 375300 from
  19179. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19180. revisions 375301 from
  19181. http://svn.asterisk.org/svn/asterisk/branches/11
  19182. * codecs/gsm/src/code.c, /: GSM: Fix encoding problems with GSM
  19183. (closes issue ASTERISK-20457) Reported by: Richard Miller
  19184. Patches: code.patch uploaded by Richard Miller (license 5685)
  19185. ........ Merged revisions 375272 from
  19186. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19187. revisions 375273 from
  19188. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19189. revisions 375288 from
  19190. http://svn.asterisk.org/svn/asterisk/branches/11
  19191. 2012-10-18 21:49 +0000 [r375240-375249] Jonathan Rose <jrose@digium.com>
  19192. * UPGRADE.txt: app_queue: add upgrade notes for 375216 Adds UPGRADE
  19193. notes describing behavioral changes to rrmemory strategy caused
  19194. by 375216 (issue AST-989) Reported by: Thomas Arimont
  19195. * /, apps/app_queue.c: app_queue: Make ordering of
  19196. rrmemory/rrordered persist over add/remove members Prior to this
  19197. patch, adding, removing or reloading members to rrmemory would
  19198. cause the order to become completely jumbled. Now it behaves more
  19199. or less like rrordered other than the fact that it stores the
  19200. members on a hash table rather than a linked list. This patch
  19201. also prevents removal of members and member reloads from jumbling
  19202. rrordered queues. (issue AST-989) Reported by: Thomas Arimont
  19203. Review: https://reviewboard.asterisk.org/r/2164/ ........ Merged
  19204. revisions 375216 from
  19205. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19206. revisions 375217 from
  19207. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19208. revisions 375219 from
  19209. http://svn.asterisk.org/svn/asterisk/branches/11
  19210. 2012-10-18 20:31 +0000 [r375215] Michael L. Young <elgueromexicano@gmail.com>
  19211. * apps/app_alarmreceiver.c: Fix XML Document Validation Failure Fix
  19212. documentation error when validating the xml in trunk caused by
  19213. r375150. Moved the description end tag down to below the
  19214. variablelist element end tag. Found when compiling with
  19215. --dev-mode-enabled. (issue ASTERISK-20289)
  19216. 2012-10-18 20:13 +0000 [r375192] Richard Mudgett <rmudgett@digium.com>
  19217. * makeopts.in, Makefile, /, build_tools/make_version, configure,
  19218. include/asterisk/autoconfig.h.in, configure.ac: build_tools:
  19219. Allow Asterisk to report git SHAs in version string. Make git
  19220. more attractive for managing work-in-progress. Especially
  19221. convenient when a potential patch set needs to be tested on
  19222. multiple platforms since one can use git to keep all the test
  19223. environments in sync independent of a subversion server. Now the
  19224. Asterisk version will show the exact git SHA5 that was used when
  19225. building (still appended by "M" if there are local modifications)
  19226. from a git clone of the Asterisk repository so the developer can
  19227. more easily know what is actually under test. You will now get
  19228. this: $ asterisk -V Asterisk GIT-1698298 Instead of this: $
  19229. asterisk -V Asterisk UNKNOWN__and_probably_unsupported This has
  19230. zero impact for those not using git with the exception of an
  19231. extra test in the configure script to gather git's path. This is
  19232. necessary to prevent "sudo make install" from failing since git
  19233. may not be in the path in make's shell environment. (closes issue
  19234. ASTERISK-20483) Reported by: Shaun Ruffell Patches:
  19235. 0001-build_tools-Allow-Asterisk-to-report-git-SHAs-in-ver.patch
  19236. (license #5417) patch uploaded by Shaun Ruffell Modified ........
  19237. Merged revisions 375189 from
  19238. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19239. revisions 375190 from
  19240. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19241. revisions 375191 from
  19242. http://svn.asterisk.org/svn/asterisk/branches/11
  19243. 2012-10-18 14:17 +0000 [r375182] Andrew Latham <lathama@gmail.com>
  19244. * main/features.c, include/asterisk/module.h,
  19245. include/asterisk/doxygen/reviewboard.h, main/logger.c,
  19246. main/http.c, include/asterisk/doxygen/licensing.h, main/dsp.c,
  19247. main/udptl.c, main/dnsmgr.c, contrib/asterisk-ng-doxygen,
  19248. Makefile.rules, codecs/log2comp.h, main/cli.c, main/cdr.c,
  19249. include/asterisk/doxyref.h,
  19250. include/asterisk/doxygen/asterisk-git-howto.h, main/manager.c,
  19251. main/app.c, pbx/pbx_dundi.c, include/asterisk/doxygen/commits.h,
  19252. include/asterisk/udptl.h, include/asterisk/smdi.h,
  19253. main/asterisk.c, include/asterisk/doxygen/architecture.h,
  19254. include/asterisk.h, main/ccss.c, Makefile.moddir_rules,
  19255. main/cel.c, main/named_acl.c, main/enum.c, Makefile,
  19256. include/asterisk/paths.h, include/asterisk/doxygen/releases.h,
  19257. include/asterisk/compat.h: Doxygen Updates - Title update Update
  19258. and extend the configuration_file group and enable linking.
  19259. Commit other cleanups from multi-version Doxygen testing. Update
  19260. title that was left behind many years ago. (issue ASTERISK-20259)
  19261. 2012-10-17 20:34 +0000 [r375175] Jonathan Rose <jrose@digium.com>
  19262. * main/manager.c: manager: remove curses dependent stuff from
  19263. r375103 Upon further examination, this code was causing
  19264. compliation problems on CentOS at the least (possibly on any
  19265. machine without curses) and also the local value of COLS is used
  19266. even with a remote console, so it is less than ideal. (issue
  19267. ASTERISK-20396) Reported by: Johan Wilfer
  19268. 2012-10-17 19:02 +0000 [r375150] Pedro Kiefer <pedro@kiefer.com.br>
  19269. * apps/app_alarmreceiver.c, configs/alarmreceiver.conf.sample: Adds
  19270. new formats to app_alarmreceiver, ALAW calls support and enhanced
  19271. protection. Commiting this on behalf of Kaloyan Kovachev (license
  19272. 5506). AlarmReceiver now supports the following DTMF signaling
  19273. types: - ContactId - 4x1 - 4x2 - High Speed - Super Fast We are
  19274. also auto-detecting which signaling is being received. So support
  19275. for those protocols should work out-the-box. Correctly identify
  19276. ALAW / ULAW calls. Some enhanced protection for broken panels and
  19277. malicious callers where added. (closes issue ASTERISK-20289)
  19278. Reported by: Kaloyan Kovachev Review:
  19279. https://reviewboard.asterisk.org/r/2088/
  19280. 2012-10-17 19:01 +0000 [r375149] Kinsey Moore <kmoore@digium.com>
  19281. * main/tcptls.c, /: Ensure Asterisk fails TCP/TLS SIP calls when
  19282. certificate checking fails When placing a call to a TCP/TLS SIP
  19283. endpoint whose certificate is not signed by a configured CA
  19284. certificate, Asterisk would issue a warning and continue to
  19285. process the call as if there was not an issue with the
  19286. certificate. Asterisk now properly fails the call if the
  19287. certificate fails verification or if the certificate does not
  19288. exist when certificate checking is enabled (the default
  19289. behavior). (closes issue ASTERISK-20559) Reported by: kmoore
  19290. Review: https://reviewboard.asterisk.org/r/2163/ ........ Merged
  19291. revisions 375146 from
  19292. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19293. revisions 375147 from
  19294. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19295. revisions 375148 from
  19296. http://svn.asterisk.org/svn/asterisk/branches/11
  19297. 2012-10-17 14:24 +0000 [r375110-375137] Walter Doekes <walter+asterisk@wjd.nu>
  19298. * res/res_rtp_asterisk.c, main/pbx.c, channels/chan_sip.c,
  19299. cdr/cdr_odbc.c: Change a few warnings to debug and the inverse.
  19300. Remove the "RTP Read too short" warning for RTP keepalives.
  19301. Remove the the warning about the application delimiter switch
  19302. from pipe to comma. (You should've done this by now.) Make
  19303. cdr_odbc report more when an insert fails. Make chan_sip warn
  19304. less when the peer wants SRTP (and we don't) or sends a zero port
  19305. to disable a media type. Review:
  19306. https://reviewboard.asterisk.org/r/2167 (closes issue
  19307. ASTERISK-20538)
  19308. * /, channels/chan_sip.c: Fixes to the fd-oriented SIP TCP reads.
  19309. Don't crash on large user input. Allow SIP headers without space.
  19310. Optimize code a bit. Review:
  19311. https://reviewboard.asterisk.org/r/2162 ........ Merged revisions
  19312. 375111 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  19313. ........ Merged revisions 375112 from
  19314. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19315. revisions 375113 from
  19316. http://svn.asterisk.org/svn/asterisk/branches/11
  19317. * channels/chan_sip.c: Don't do SIP contact/route DNS if we're not
  19318. using the result. In many cases (for peers behind NAT or for TCP
  19319. sockets) we do not need to look up any hostname in the Contact
  19320. (or Route) when sending an in-dialog request. This should reduce
  19321. netsock2.c: getaddrinfo errors in certain scenarios. Review:
  19322. https://reviewboard.asterisk.org/r/2156
  19323. 2012-10-16 20:45 +0000 [r375103] Jonathan Rose <jrose@digium.com>
  19324. * main/manager.c, CHANGES: manager: Change display of 'manager show
  19325. commands' and 'manager show command' manager show commands now
  19326. shows the full name of the command being displayed regardless of
  19327. size. The privilege column has also been removed from this
  19328. display. It will also now use the full length of the terminal if
  19329. curses is available. Manager show command will now always display
  19330. the privilege of the manager command within the CLI. (closes
  19331. ASTERISK-20396) Reported by: Johan Wilfer Review:
  19332. https://reviewboard.asterisk.org/r/2143/
  19333. 2012-10-16 19:26 +0000 [r375081] Pedro Kiefer <pedro@kiefer.com.br>
  19334. * apps/app_alarmreceiver.c: Fixes two small regressions from
  19335. ASTERISK-20157 - receive_dtmf_digits had the wrong buffer length
  19336. - app_alarmreceiver should wait 100ms before sending the second
  19337. part of handshake (closes issue ASTERISK-20484) Reported by:
  19338. Jean-Philippe Lord Tested by: Jean-Philippe Lord, Pedro Kiefer
  19339. Patches: ASTERISK-20484_v2.diff uploaded by Kaloyan Kovachev
  19340. (license 5506)
  19341. 2012-10-16 19:25 +0000 [r375080] Walter Doekes <walter+asterisk@wjd.nu>
  19342. * /, channels/chan_sip.c: Update sip_request_call SIP dial string
  19343. documentation. This was missed when merging review r1859.
  19344. ........ Merged revisions 375074 from
  19345. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19346. revisions 375078 from
  19347. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19348. revisions 375079 from
  19349. http://svn.asterisk.org/svn/asterisk/branches/11
  19350. 2012-10-16 14:09 +0000 [r375052] Joshua Colp <jcolp@digium.com>
  19351. * /, channels/chan_iax2.c: Remove a log message that was left in
  19352. accidentally from call-id logging development. ........ Merged
  19353. revisions 375051 from
  19354. http://svn.asterisk.org/svn/asterisk/branches/11
  19355. 2012-10-15 21:25 +0000 [r375044] Mark Michelson <mmichelson@digium.com>
  19356. * include/asterisk/strings.h, channels/chan_iax2.c,
  19357. apps/app_dial.c, /, main/ccss.c: Fix some potential misuses of
  19358. ast_str in the code. Passing an ast_str pointer by value that
  19359. then calls ast_str_set(), ast_str_set_va(), ast_str_append(), or
  19360. ast_str_append_va() can result in the pointer originally passed
  19361. by value being invalidated if the ast_str had to be reallocated.
  19362. This fixes places in the code that do this. Only the example in
  19363. ccss.c could result in pointer invalidation though since the
  19364. other cases use a stack-allocated ast_str and cannot be
  19365. reallocated. I've also updated the doxygen in strings.h to
  19366. include notes about potential misuse of the functions mentioned
  19367. previously. Review: https://reviewboard.asterisk.org/r/2161
  19368. ........ Merged revisions 375025 from
  19369. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19370. revisions 375026 from
  19371. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19372. revisions 375027 from
  19373. http://svn.asterisk.org/svn/asterisk/branches/11
  19374. 2012-10-15 08:26 +0000 [r375017] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  19375. * channels/chan_unistim.c, /: Fix underscreen buttons warnings
  19376. apeared while transfer process ........ Merged revisions 375016
  19377. from http://svn.asterisk.org/svn/asterisk/branches/11
  19378. 2012-10-14 21:59 +0000 [r375003-375009] Andrew Latham <lathama@gmail.com>
  19379. * addons/chan_mobile.c, addons/app_mysql.c: Doxygen Updates Update
  19380. and extend the configuration_file group and enable linking.
  19381. (issue ASTERISK-20259)
  19382. * utils/extconf.c, utils/muted.c: Doxygen Updates Update and extend
  19383. the configuration_file group and enable linking. (issue
  19384. ASTERISK-20259)
  19385. * addons/Makefile, pbx/Makefile, formats/Makefile, sounds/Makefile,
  19386. funcs/Makefile, bridges/Makefile, agi/Makefile, codecs/Makefile,
  19387. utils/Makefile, tests/Makefile, cel/Makefile, main/Makefile:
  19388. Title update Update title that was left behind many years ago.
  19389. Used revision 6596 as my guide for what it should be. (issue
  19390. ASTERISK-20259)
  19391. * channels/chan_gtalk.c, channels/chan_console.c,
  19392. channels/Makefile, channels/chan_iax2.c, channels/chan_oss.c,
  19393. channels/chan_jingle.c, channels/chan_phone.c,
  19394. channels/chan_dahdi.c, channels/iax2-parser.h,
  19395. channels/chan_misdn.c, channels/chan_skinny.c,
  19396. channels/chan_motif.c, channels/chan_h323.c, channels/iax2.h,
  19397. channels/chan_alsa.c, channels/chan_mgcp.c, channels/chan_vpb.cc,
  19398. channels/chan_sip.c: Doxygen Updates - Title update Update and
  19399. extend the configuration_file group and enable linking. Update
  19400. title that was left behind many years ago. (issue ASTERISK-20259)
  19401. * cdr/Makefile, cdr/cdr_adaptive_odbc.c, cdr/cdr_pgsql.c,
  19402. cdr/cdr_odbc.c, cdr/cdr_radius.c, cdr/cdr_custom.c,
  19403. cdr/cdr_manager.c, cdr/cdr_csv.c, cdr/cdr_syslog.c: Doxygen
  19404. Updates - Title update Update and extend the configuration_file
  19405. group and enable linking. Update title that was left behind many
  19406. years ago. (issue ASTERISK-20259)
  19407. * apps/Makefile, apps/app_meetme.c, apps/app_festival.c,
  19408. apps/app_fax.c, apps/app_skel.c, apps/app_alarmreceiver.c,
  19409. apps/app_amd.c, apps/app_confbridge.c, apps/app_followme.c,
  19410. apps/app_queue.c, apps/app_adsiprog.c, apps/app_voicemail.c:
  19411. Doxygen Updates - Title update Update and extend the
  19412. configuration_file group and enable linking to the application.
  19413. Update title that was left behind many years ago. (issue
  19414. ASTERISK-20259)
  19415. * res/res_jabber.c, res/res_config_sqlite.c, res/res_smdi.c,
  19416. res/res_curl.c, res/res_config_ldap.c, res/res_odbc.c,
  19417. res/res_clialiases.c, res/res_calendar.c,
  19418. res/res_config_sqlite3.c, res/res_config_pgsql.c, res/res_snmp.c,
  19419. res/res_limit.c, res/res_fax.c, res/res_phoneprov.c,
  19420. res/Makefile, res/res_xmpp.c, res/res_musiconhold.c: Doxygen
  19421. Updates - Title update Update and extend the configuration_file
  19422. group and enable linking to the resource. Update title that was
  19423. left behind many years ago. (issue ASTERISK-20259)
  19424. 2012-10-14 12:23 +0000 [r374996] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  19425. * /, config.guess, config.sub: Update config.guess and config.sub:
  19426. 2012-10-10 Update config.guess and config.sub to revision
  19427. fb456b34ef4aa02b95dc6be69aaa66fa94a844fb from the
  19428. savannah.gnu.org git repo. Adds support for e.g. aarch64 (ARM
  19429. 64bit). config.guess:timestamp='2012-09-25'
  19430. config.sub:timestamp='2012-10-10' ........ Merged revisions
  19431. 374977 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  19432. ........ Merged revisions 374991 from
  19433. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19434. revisions 374995 from
  19435. http://svn.asterisk.org/svn/asterisk/branches/11
  19436. 2012-10-13 19:58 +0000 [r374940-374970] Andrew Latham <lathama@gmail.com>
  19437. * CREDITS: Update CREDITS Update Jean-Denis and add myself (issue
  19438. ASTERISK-20259)
  19439. * Makefile: Multiplatform Makefile Update Paul Belanger pointed out
  19440. that using sed in the Makefile is an issue with multiple
  19441. platforms. We are cleaning up the Doxygen config as a following
  19442. step so I just switched the sed inplace changes to be an echo
  19443. append instead. (issue ASTERISK-20259)
  19444. * main/app.c, apps/app_dial.c: Doxygen Clean ups Add app_skel.c as
  19445. an example in app.c and fix some formating for the "Dial Privacy
  19446. scripts" so it actually shows up in the Doxygen output. (issue
  19447. ASTERISK-20259)
  19448. * Makefile: Test for Asterisk Version info Doxygen uses the
  19449. ASTERISKVERSION as a sub header. If a SVN export is done and no
  19450. .svn or .version file exists it defualts to
  19451. UNKNOWN__and_probably_unsupported which is honest but not great
  19452. for the online docs. During the "make progdocs" I added a test
  19453. for this and just warned and ommitted the version. (issue
  19454. ASTERISK-20259)
  19455. * contrib/asterisk-ng-doxygen: Correct output directory During
  19456. testing I used an alternate output directory and mistakenly
  19457. committed it. Matt Jordan noticed and I reverted. This is the
  19458. correct setting for local output to match with all branches.
  19459. (issue ASTERISK-20259)
  19460. * static-http/ajamdemo.html, static-http/astman.css: Add
  19461. licens/copyright header Begin update of static-http files and
  19462. general clean ups. This only adds the standard header to the
  19463. files. (issue ASTERISK-20503)
  19464. * configure, configure.ac, makeopts.in, Makefile: Add check for
  19465. Doxygen The autoconf configuration system had a test for DOT but
  19466. not for Doxygen. I added the test for Doxygen and did an overhaul
  19467. of the Makefile check to a much simpler process. (issue
  19468. ASTERISK-20259)
  19469. 2012-10-12 21:58 +0000 [r374933] Kinsey Moore <kmoore@digium.com>
  19470. * /, apps/app_voicemail.c: Avoid a segfault on invalid format names
  19471. If a format name was not found by ast_getformatbyname, a NULL
  19472. pointer would be passed into ast_format_rate and immediately
  19473. dereferenced. This ensures that a valid pointer is used since the
  19474. structure is already allocated on the stack. (closes issue
  19475. DPH-523) Reported-by: Steve Pitts ........ Merged revisions
  19476. 374932 from http://svn.asterisk.org/svn/asterisk/branches/11
  19477. 2012-10-12 16:31 +0000 [r374924] Mark Michelson <mmichelson@digium.com>
  19478. * main/tcptls.c, /, channels/chan_sip.c, include/asterisk/tcptls.h:
  19479. Do not use a FILE handle when doing SIP TCP reads. This is used
  19480. to solve an issue where a poll on a file descriptor does not
  19481. necessarily correspond to the readiness of a FILE handle to be
  19482. read. This change makes it so that for TCP connections, we do a
  19483. recv() on the file descriptor instead. Because TCP does not
  19484. guarantee that an entire message or even just one single message
  19485. will arrive during a read, a loop has been introduced to ensure
  19486. that we only attempt to handle a single message at a time. The
  19487. tcptls_session_instance structure has also had an overflow buffer
  19488. added to it so that if more than one TCP message arrives in one
  19489. go, there is a place to throw the excess. Huge thanks goes out to
  19490. Walter Doekes for doing extensive review on this change and
  19491. finding edge cases where code could fail. (closes issue
  19492. ASTERISK-20212) reported by Phil Ciccone Review:
  19493. https://reviewboard.asterisk.org/r/2123 ........ Merged revisions
  19494. 374905 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  19495. ........ Merged revisions 374906 from
  19496. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19497. revisions 374914 from
  19498. http://svn.asterisk.org/svn/asterisk/branches/11
  19499. 2012-10-11 23:40 +0000 [r374879-374897] Andrew Latham <lathama@gmail.com>
  19500. * contrib/scripts/install_prereq: Append Doxygen to Debian packages
  19501. list Add Doxygen to the Debian install list. I will check for
  19502. other platforms like Red Hat (issue ASTERISK-20259)
  19503. * static-http/mantest.html: Update JQuery URL to recent version The
  19504. JQuery URL to version 1.4 will be removed within the life span of
  19505. Asterisk 11. This is a compatible upgrade by using the URL for
  19506. 1.8. (issue ASTERISK-20503)
  19507. * main/manager.c, include/asterisk/module.h: Continue to group
  19508. config files (issue ASTERISK-20259)
  19509. * CREDITS: CREDITS clean up As discussed online
  19510. http://lists.digium.com/pipermail/asterisk-dev/2012-October/057245.html
  19511. the credits file needs some cleaning. This is 95% whitespace with
  19512. a few additions found in file headers. Further additions should
  19513. be added here instead of in the file being updated. (issue
  19514. ASTERISK-20259)
  19515. * contrib/asterisk-ng-doxygen: Revert Local testing Config Revert a
  19516. local testing config that I made. This was not intended to be
  19517. committed. Thank you Matt Jordan for noticing this. (issue
  19518. ASTERISK-20259)
  19519. 2012-10-11 21:19 +0000 [r374852-374878] Joshua Colp <jcolp@digium.com>
  19520. * /, channels/chan_motif.c: Fix a bug where audio on Google Voice
  19521. would not work due to ignoring candidates. Instead of ignoring
  19522. parts of the message that are not known just ignore the ones we
  19523. know may be present and that would cause a problem. ........
  19524. Merged revisions 374877 from
  19525. http://svn.asterisk.org/svn/asterisk/branches/11
  19526. * /, channels/chan_motif.c: Fix an issue where outgoing calls would
  19527. fail to establish audio due to ICE negotiation failures. This
  19528. change removes the requirement for ufrag and pwd in the transport
  19529. stanza and also makes us the controlling agent. (closes issue
  19530. ASTERISK-20554) Reported by: mmichelson ........ Merged revisions
  19531. 374850 from http://svn.asterisk.org/svn/asterisk/branches/11
  19532. 2012-10-11 15:49 +0000 [r374849] Mark Michelson <mmichelson@digium.com>
  19533. * channels/chan_sip.exports.in (removed), main/sip_api.c (added),
  19534. /, channels/chan_sip.c, include/asterisk/sip_api.h: Don't make
  19535. chan_sip export global symbols. During testing, it was discovered
  19536. that having chan_sip export global symbols was problematic. The
  19537. biggest problem was that load order was affected. Trying to use
  19538. realtime could be problematic since in all likelihood the
  19539. necessary realtime driver(s) would not be loaded before chan_sip.
  19540. In addition, it was found that it was impossible to use the
  19541. Digium Phone Module for Asterisk since it must be loaded before
  19542. chan_sip since it must hook into chan_sip's configuration
  19543. parsing. The solution is to use a virtual table in the same
  19544. manner that other modules in Asterisk do, like app_voicemail.
  19545. (closes issue ASTERISK-20545) Reported by: kmoore ........ Merged
  19546. revisions 374842 from
  19547. http://svn.asterisk.org/svn/asterisk/branches/11
  19548. 2012-10-11 15:44 +0000 [r374846] Matthew Jordan <mjordan@digium.com>
  19549. * main/cdr.c, /: Fix incorrect billing duration reported when batch
  19550. mode is enabled Similar to r369351, the billing duration can be
  19551. skewed when batch mode is enabled. This happened much more rarely
  19552. than the duration, as it only occured when the call was answered
  19553. (thereby indicating an actual answer time) and immediately hung
  19554. up on (indicating a billsec of 0). Since a billing time of '0'
  19555. can either mean that the call immediately ended or that the CDR
  19556. was improperly answered, we have to use additional information to
  19557. know whether or not we can trust the CDR billsec value. Prior to
  19558. this patch, we looked to see if we had a valid answer time. If we
  19559. did, and billsec was zero, we used the current time to calculate
  19560. what billsec value we could from the CDR being written. If batch
  19561. mode is enabled, this will incorrectly report a billsec value
  19562. being much greater than the actual duration of the call. Instead
  19563. of relying on the presence of an answer time to know whether or
  19564. not we can re-calculate the billsec for the CDR, we now also use
  19565. the presence of the CDR's end time to know if we need to
  19566. re-calculate or whether we can trust the billsec value that we
  19567. have. This prevents erroneous jumps in the billsec value, while
  19568. still making sure that in the worst case, some billing time will
  19569. be calculated. (closes issue AST-1016) Reported by: Thomas
  19570. Arimont Tested by: Thomas Arimont ........ Merged revisions
  19571. 374843 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  19572. ........ Merged revisions 374844 from
  19573. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19574. revisions 374845 from
  19575. http://svn.asterisk.org/svn/asterisk/branches/11
  19576. 2012-10-11 13:34 +0000 [r374834] Joshua Colp <jcolp@digium.com>
  19577. * /, channels/chan_motif.c: Consider the Google Talk content stanza
  19578. name (jin:content) valid. ........ Merged revisions 374833 from
  19579. http://svn.asterisk.org/svn/asterisk/branches/11
  19580. 2012-10-10 21:05 +0000 [r374805] Richard Mudgett <rmudgett@digium.com>
  19581. * apps/app_queue.c, /: app_queue: Made pass connected line updates
  19582. from the caller to ringing queue members. Party A calls Party B
  19583. Party B puts Party A on hold. Party B calls a queue. Ringing
  19584. queue member D sees Party B identification. Party B transfers
  19585. Party A to the queue. Queue member D does not get a connected
  19586. line update for Party A. Queue member D answers the call and
  19587. still sees Party B information. However, if Party A later
  19588. transfers the call to Party C then queue member D gets a
  19589. connected line update for Party C. * Made pass connected line
  19590. updates from the caller to queue members while the queue members
  19591. are ringing. (closes issue AST-1017) Reported by: Thomas Arimont
  19592. (closes issue ABE-2886) Reported by: Thomas Arimont Tested by:
  19593. rmudgett ........ Merged revisions 374801 from
  19594. https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  19595. ........ Merged revisions 374802 from
  19596. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19597. revisions 374803 from
  19598. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19599. revisions 374804 from
  19600. http://svn.asterisk.org/svn/asterisk/branches/11
  19601. 2012-10-10 13:40 +0000 [r374793] Kinsey Moore <kmoore@digium.com>
  19602. * main/manager.c, /: Fix segfault regression from r370681 Due to
  19603. usage of ast_hook_send_action, AMI action handling code should be
  19604. able to handle a NULL mansession->session. This would cause a
  19605. crash on NULL dereference if action_originate was called from
  19606. ast_hook_send_action. (closes issue ASTERISK-20544) ........
  19607. Merged revisions 374792 from
  19608. http://svn.asterisk.org/svn/asterisk/branches/11
  19609. 2012-10-09 22:24 +0000 [r374778] Richard Mudgett <rmudgett@digium.com>
  19610. * main/pbx.c, /: Fix execution of 'i' extension due to
  19611. uninitialized variable. The fix for ASTERISK-18243 added code
  19612. that could potentially use dst_exten[] uninitialized. As a result
  19613. the 'i' exten may not be executed when it should. (closes issue
  19614. ASTERISK-20455) Reported by: Richard Miller Patches:
  19615. pbx-1.8.16.0.diff (license #5685) patch uploaded by Richard
  19616. Miller Made some cosmetic modifications. ........ Merged
  19617. revisions 374758 from
  19618. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19619. revisions 374763 from
  19620. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19621. revisions 374771 from
  19622. http://svn.asterisk.org/svn/asterisk/branches/11
  19623. 2012-10-09 21:35 +0000 [r374757] Joshua Colp <jcolp@digium.com>
  19624. * /, channels/chan_sip.c: Improve logging for DTLS-SRTP failure
  19625. situations. (closes issue ASTERISK-20487) Reported by: mjordan
  19626. ........ Merged revisions 374756 from
  19627. http://svn.asterisk.org/svn/asterisk/branches/11
  19628. 2012-10-08 22:31 +0000 [r374717-374730] Richard Mudgett <rmudgett@digium.com>
  19629. * configs/chan_dahdi.conf.sample, /: dahdi.conf.sample: Add
  19630. description for "buffers" setting. This contains an edited
  19631. version of the patch originally created by John Bigelow. (closes
  19632. issue ASTERISK-14435) Reported by: John Bigelow Patches:
  19633. buffers.patch (license #5091) patch uploaded by John Bigelow
  19634. 0001-dahdi.conf.sample-Add-description-for-buffers-settin.patch
  19635. (license #5417) patch uploaded by Shaun Ruffell Modified ........
  19636. Merged revisions 374727 from
  19637. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19638. revisions 374728 from
  19639. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19640. revisions 374729 from
  19641. http://svn.asterisk.org/svn/asterisk/branches/11
  19642. * pbx/pbx_spool.c, /: Fix deletion of unopenable spool files. If
  19643. scan_service() cannot open the spool file, it logs a message
  19644. saying that it will delete the file and calls remove_from_queue()
  19645. to do it. However, remove_from_queue() fails to delete the spool
  19646. file because struct outgoing has not yet been fully initialized.
  19647. * Merged allocating a new struct outgoing and init_outgoing()
  19648. into new_outgoing(). Allocation is initialization. * Made
  19649. apply_outgoing() not initialize the spool filename in struct
  19650. outgoing. * Made apply_outgoing() call ast_trim_blanks() and
  19651. ast_skip_blanks() rather than manually inlining them. * Reduced
  19652. indentation levels in apply_outgoing(). * Fixed a garbled comment
  19653. in remove_from_queue(). * Reworked scan_service() to simplify it.
  19654. (closes issue ASTERISK-17231) Reported by: David Chappell
  19655. Patches: spool_open_failure.diff (license #4997) patch uploaded
  19656. by David Chappell Started with this patch. ........ Merged
  19657. revisions 374686 from
  19658. http://svn.asterisk.org/svn/asterisk/branches/1.8 * Fixed some
  19659. memory leaks on off nominal paths in init_outgoing() when merging
  19660. into the new_outgoing() function dealing with o->capabilities.
  19661. ........ Merged revisions 374695 from
  19662. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19663. revisions 374708 from
  19664. http://svn.asterisk.org/svn/asterisk/branches/11
  19665. 2012-10-08 20:39 +0000 [r374633-374677] Matthew Jordan <mjordan@digium.com>
  19666. * res/res_rtp_asterisk.c, /, configs/rtp.conf.sample: Disable ICE
  19667. support by default Since there are a number of legacy devices out
  19668. there that fail to handle ICE candidates properly (which is a
  19669. nice way of saying something much uglier), disable it by default.
  19670. Support for ICE candidates can be enabled in rtp.conf using the
  19671. icesupport setting. ........ Merged revisions 374676 from
  19672. http://svn.asterisk.org/svn/asterisk/branches/11
  19673. * apps/confbridge/conf_state_multi.c (added),
  19674. apps/app_confbridge.c, apps/confbridge/conf_state_multi_marked.c
  19675. (added), apps/confbridge/conf_state_empty.c (added),
  19676. apps/confbridge/conf_state.c (added),
  19677. apps/confbridge/conf_state_single.c (added),
  19678. apps/confbridge/conf_state_inactive.c (added),
  19679. apps/confbridge/conf_state_single_marked.c (added), /,
  19680. apps/confbridge/include/confbridge.h,
  19681. apps/confbridge/include/conf_state.h (added): Resolve issues in
  19682. ConfBridge regarding marked, waitmarked, and unmarked users
  19683. Thank's to Neil Tallim (flan)'s tireless testing, issue
  19684. reporting, and patches it became clear that app_confbridge had
  19685. some complex logic in how it handled interactions between marked,
  19686. waitmarked, and unmarked users. In particular, there were some
  19687. areas in which the interactions between the users resulted in
  19688. inconsistent behavior, and app_confbridge was missing logic in
  19689. how to handle some corner cases. Some areas included: * Poor
  19690. handling of mixing unmarked and waitmarked users *
  19691. Inconsistencies in how MOH and muting was applied to various
  19692. users * Handling of various announcements for different user
  19693. profile options flan's patches seem to fix the various issues,
  19694. but highlighted how hard the code could be to maintain. In an
  19695. attempt to make things easier to maintain and to more fully
  19696. enumerate the various cases that exist, this patch breaks up the
  19697. logic into a state machine-like setup. Please note that the
  19698. various state transitioned are documented on the Asterisk wiki:
  19699. https://wiki.asterisk.org/wiki/display/AST/Confbridge+state+changes
  19700. Review: //https://reviewboard.asterisk.org/r/2072/ Note that for
  19701. the following issues, mjordan uploaded the patch, although it was
  19702. written by twilson. Any contributor license discrepency is due to
  19703. that. (closes issue ASTERISK-19562) Reported by: flan Tested by:
  19704. flan, mjordan, jrose patches:
  19705. bugASTERISK-19562_ASTERISK-19726_ASTERISK-20181.patch uploaded by
  19706. twilson (license 6283) (closes issue ASTERISK-19726) Reported by:
  19707. flan Tested by: flan patches:
  19708. bugASTERISK-19562_ASTERISK-19726_ASTERISK-20181.patch uploaded by
  19709. twilson (license 6283) (closes issue ASTERISK-20181) Reported by:
  19710. Jonathan White Tested by: Jonathan White patches:
  19711. bugASTERISK-19562_ASTERISK-19726_ASTERISK-20181.patch uploaded by
  19712. twilson (license 6283) ........ Merged revisions 374652 from
  19713. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19714. revisions 374657 from
  19715. http://svn.asterisk.org/svn/asterisk/branches/11
  19716. * res/pjproject/pjlib/src/pj/sock_linux_kernel.c,
  19717. res/pjproject/pjlib/include/pj/sock.h,
  19718. res/pjproject/pjlib/src/pj/sock_symbian.cpp, /,
  19719. res/pjproject/pjlib/src/pj/sock_bsd.c: pjproject: Fix for Solaris
  19720. builds. Do not undef s_addr. pjproject, in order to solve build
  19721. problems on Windows [1], undefines s_addr in one of it's headers
  19722. that is included in res_rtp_asterisk.c. On Solaris s_addr is not
  19723. a structure member, but defined to map to the real strucuture
  19724. member, therefore when building on Solaris it's possible to get
  19725. build errors like: [CC] res_rtp_asterisk.c -> res_rtp_asterisk.o
  19726. In file included from
  19727. /export/home/admin/asterisk-11-svn/include/asterisk/stun.h:29,
  19728. from res_rtp_asterisk.c:51:
  19729. /export/home/admin/asterisk-11-svn/include/asterisk/network.h: In
  19730. function `inaddrcmp':
  19731. /export/home/admin/asterisk-11-svn/include/asterisk/network.h:92:
  19732. error: structure has no member named `s_addr'
  19733. /export/home/admin/asterisk-11-svn/include/asterisk/network.h:92:
  19734. error: structure has no member named `s_addr' res_rtp_asterisk.c:
  19735. In function `ast_rtp_on_ice_tx_pkt': res_rtp_asterisk.c:706:
  19736. warning: dereferencing type-punned pointer will break
  19737. strict-aliasing rules res_rtp_asterisk.c:710: warning:
  19738. dereferencing type-punned pointer will break strict-aliasing
  19739. rules res_rtp_asterisk.c: In function
  19740. `rtp_add_candidates_to_ice': res_rtp_asterisk.c:1085: error:
  19741. structure has no member named `s_addr' make[2]: ***
  19742. [res_rtp_asterisk.o] Error 1 make[1]: *** [res] Error 2 make[1]:
  19743. Leaving directory `/export/home/admin/asterisk-11-svn' gmake: ***
  19744. [_cleantest_all] Error 2 Unfortunately, in order to make this
  19745. work, I also had to make sure pjproject only used the typdef
  19746. pj_in_addr and not the struct pj_in_addr so that when building
  19747. Asterisk I could "typedef struct in_addr pj_in_addr". It's
  19748. possible then that the library and users of those interfaces in
  19749. Asterisk have a different idea about the type of the argument,
  19750. while on the surface it looks like they are all 32 bit big endian
  19751. values. [1] http://trac.pjsip.org/repos/changeset/484 (issues
  19752. ASTERISK-20366) Reported by: Ben Klang Tested by: Ben Klang,
  19753. mjordan patches:
  19754. 0001-pjproject-Fix-for-Solaris-builds.-Do-not-undef-s.patch
  19755. uploaded by Shaun Ruffell (license 5417) ........ Merged
  19756. revisions 374642 from
  19757. http://svn.asterisk.org/svn/asterisk/branches/11
  19758. * main/acl.c, /: Trivial patch to make 'best_score' defined for all
  19759. architectures. Fixes trivial build error on Solaris: acl.c: In
  19760. function `get_local_address': acl.c:196: error: `best_score'
  19761. undeclared (first use in this function) acl.c:196: error: (Each
  19762. undeclared identifier is reported only once acl.c:196: error: for
  19763. each function it appears in.) make[2]: *** [acl.o] Error 1 (issue
  19764. ASTERISK-20366) Reported by: Ben Klang Tested by: Ben Klang
  19765. patches:
  19766. 0002-main-acl.c-Trivial.-best_score-should-be-defined-for.patch
  19767. by Shaun Ruffell (license 5417) ........ Merged revisions 374632
  19768. from http://svn.asterisk.org/svn/asterisk/branches/11
  19769. 2012-10-06 03:22 +0000 [r374612-374623] Matthew Jordan <mjordan@digium.com>
  19770. * /, res/res_xmpp.c: Handle capability stanzas that fail to provide
  19771. node or version information While XEP-0115 states that the node
  19772. and ver attributes are both required, some devices fail to
  19773. provide either field. Prior to this patch, failure to provide the
  19774. node or ver attribute would cause a crash in res_xmpp. While
  19775. failing to provide the node or ver attribute is technically
  19776. invalid, since this information is not utilized by Asterisk
  19777. except for reporting purposes, for interoperability reasons, we
  19778. continue to process the capability stanza anyways. (closes issue
  19779. ASTERISK-20495) Reported by: Martin W Tested by: Martin W
  19780. patches: 20495.patch uploaded by Martin W (license #6434)
  19781. ........ Merged revisions 374622 from
  19782. http://svn.asterisk.org/svn/asterisk/branches/11
  19783. * res/res_xmpp.c, main/message.c, /: Update documentation for
  19784. MessageSend application/command's From field for XMPP When using
  19785. the channel technology agnostic application/AMI command
  19786. MessageSend, the "From" field is technically optional for the SIP
  19787. channel driver. However, if being sent by the XMPP resource
  19788. module (either res_xmpp or res_jabber), the "From" field is
  19789. necessary, and must correspond to a defined account. This patch
  19790. updates the documentation for this application/AMI command to
  19791. reflect this. (closes issue ASTERISK-20405) Reported by: Leif
  19792. Madsen ........ Merged revisions 374611 from
  19793. http://svn.asterisk.org/svn/asterisk/branches/11
  19794. 2012-10-05 20:33 +0000 [r374588] David M. Lee <dlee@digium.com>
  19795. * main/manager.c, /: Multiple revisions 374570,374581 ........
  19796. r374570 | dlee | 2012-10-05 15:14:41 -0500 (Fri, 05 Oct 2012) |
  19797. 22 lines Improve AMI long line error handling In AMI's parser,
  19798. when it receives a long line (> 1024 characters), it discards
  19799. that line, but continues to process the message normally.
  19800. Typically, this is not a problem because a) who has lines that
  19801. long and b) usually a discarded line results in an invalid
  19802. message. But if that line is specifying an optional field, then
  19803. the message will be processed, you get a 'Response: Success', but
  19804. things don't work the way you expected them to. This patch
  19805. changes the behavior when a line-too-long parse error occurs. *
  19806. Changes the log message to avoid way-too-long (and truncated
  19807. anyways) log messages * Adds a 'parsing' status flag to Response:
  19808. Success * Sets parsing = MESSAGE_LINE_TOO_LONG if, well, a line
  19809. is too long * Responds with an appropriate error if parsing !=
  19810. MESSAGE_OKAY (closes issue AST-961) Reported by: John Bigelow
  19811. Review: https://reviewboard.asterisk.org/r/2142/ ........ r374581
  19812. | dlee | 2012-10-05 15:20:28 -0500 (Fri, 05 Oct 2012) | 1 line
  19813. I've committed too much. Reverting part of r374570. ........
  19814. Merged revisions 374570,374581 from
  19815. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19816. revisions 374586 from
  19817. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19818. revisions 374587 from
  19819. http://svn.asterisk.org/svn/asterisk/branches/11
  19820. 2012-10-05 18:42 +0000 [r374539] Richard Mudgett <rmudgett@digium.com>
  19821. * channels/chan_misdn.c, /, channels/misdn/isdn_msg_parser.c,
  19822. channels/misdn/isdn_lib.c, channels/misdn/isdn_lib.h: Merged
  19823. revisions 374515-374535 from
  19824. https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  19825. ................ r374515 | rmudgett | 2012-10-04 17:52:36 -0500
  19826. (Thu, 04 Oct 2012) | 10 lines chan_misdn: Remove some deadcode *
  19827. Made setup_bc() static. Patches: patch1_unused-code.diff (license
  19828. #6372) patch uploaded by Guenther Kelleter Modified JIRA ABE-2882
  19829. ................ r374516 | rmudgett | 2012-10-04 18:01:01 -0500
  19830. (Thu, 04 Oct 2012) | 7 lines chan_misdn: Remove unused bchan
  19831. states Patches: patch2_unused-states.diff (license #6372) patch
  19832. uploaded by Guenther Kelleter JIRA ABE-2882 ................
  19833. r374517 | rmudgett | 2012-10-04 18:17:51 -0500 (Thu, 04 Oct 2012)
  19834. | 16 lines chan_misdn: Remove unnecessary null pointer checks and
  19835. checks for stack->nt * cleanup_bc() is always called with valid
  19836. bc (or it would've crashed before). * Value of stack->nt is known
  19837. in advance at some places. * Rename handle_event() to
  19838. handle_event_te(), handle_frm() to handle_frm_te(). Patches:
  19839. patch3_checks.diff (license #6372) patch uploaded by Guenther
  19840. Kelleter Modified JIRA ABE-2882 ................ r374518 |
  19841. rmudgett | 2012-10-04 18:21:59 -0500 (Thu, 04 Oct 2012) | 7 lines
  19842. chan_misdn: Fix spelling in log messages Patches:
  19843. patch4_spelling.diff (license #6372) patch uploaded by Guenther
  19844. Kelleter JIRA ABE-2882 ................ r374519 | rmudgett |
  19845. 2012-10-04 18:31:59 -0500 (Thu, 04 Oct 2012) | 15 lines
  19846. chan_misdn: Don't cleanup a bc twice. In handle_frm_te() after
  19847. calling misdn_lib_send_event(bc, EVENT_RELEASE_COMPLETE) bc is
  19848. emptied, cleaned and set not in use, although
  19849. misdn_lib_send_event() already did the same. This is bad. When
  19850. it's not in use we are not allowed to touch it. * Moved log
  19851. message in front of the resulting actions and fixed it to match
  19852. the case. Patches: patch5_bccleanup.diff (license #6372) patch
  19853. uploaded by Guenther Kelleter JIRA ABE-2882 ................
  19854. r374520 | rmudgett | 2012-10-04 18:43:56 -0500 (Thu, 04 Oct 2012)
  19855. | 12 lines chan_misdn: Fix memory leaks, bc, chan not cleaned up
  19856. etc., really bad stuff. * Fix return codes of cb_events() for
  19857. EVENT_SETUP to use caller's cleanup mechanisms. * Move
  19858. cl_queue_chan() call after bearer check. Patches:
  19859. patch6_leaks.diff (license #6372) patch uploaded by Guenther
  19860. Kelleter JIRA ABE-2882 ................ r374521 | rmudgett |
  19861. 2012-10-04 18:48:38 -0500 (Thu, 04 Oct 2012) | 11 lines
  19862. chan_misdn: We must initialize cause on sending a DISCONNECT. We
  19863. must initialize cause on sending a DISCONNECT, so it is later
  19864. correctly indicated to ast_channel in case the answer
  19865. (RELEASE/RELEASE_COMPLETE) does not include one. Patches:
  19866. patch7_hangupcause.diff (license #6372) patch uploaded by
  19867. Guenther Kelleter JIRA ABE-2882 ................ r374522 |
  19868. rmudgett | 2012-10-04 19:03:56 -0500 (Thu, 04 Oct 2012) | 7 lines
  19869. chan_misdn: Remove unused code for upqueue Patches:
  19870. patch8_unused-upqueue.diff (license #6372) patch uploaded by
  19871. Guenther Kelleter JIRA ABE-2882 ................ r374523 |
  19872. rmudgett | 2012-10-04 19:11:50 -0500 (Thu, 04 Oct 2012) | 7 lines
  19873. chan_misdn: Improve debugging (port number, messages fixed, dups
  19874. removed) Patches: patch9_debug.diff (license #6372) patch
  19875. uploaded by Guenther Kelleter JIRA ABE-2882 ................
  19876. r374533 | rmudgett | 2012-10-05 12:17:18 -0500 (Fri, 05 Oct 2012)
  19877. | 8 lines chan_misdn: Better debug: we can print_bc_info even if
  19878. there's no ast leg. Patches: patch10_debug-bc-2.diff (license
  19879. #6372) patch uploaded by Guenther Kelleter Modified. JIRA
  19880. ABE-2882 ................ r374534 | rmudgett | 2012-10-05
  19881. 12:34:10 -0500 (Fri, 05 Oct 2012) | 16 lines chan_misdn:
  19882. setup_bc() is called too early for an incoming SETUP on TE. This
  19883. prevents the B channel from being setup for HDLC mode when
  19884. requested by the bearer capability and config option hdlc=yes. It
  19885. violates ETS300102 Ch.5.2.3.2: "The user, in any case, must not
  19886. connect to the channel until a CONNECT ACKNOWLEDGE message has
  19887. been received." * Call setup_bc() on receipt of
  19888. CONNECT_ACKNOWLEGDE for PTMP, and on first response to SETUP for
  19889. PTP. Patches: abe-2881-2.diff (license #6372) patch uploaded by
  19890. Guenther Kelleter Modified. JIRA ABE-2881 ................
  19891. r374535 | rmudgett | 2012-10-05 12:41:05 -0500 (Fri, 05 Oct 2012)
  19892. | 2 lines chan_misdn: Remove some more deadcode. ................
  19893. ........ Merged revisions 374536 from
  19894. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19895. revisions 374537 from
  19896. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19897. revisions 374538 from
  19898. http://svn.asterisk.org/svn/asterisk/branches/11
  19899. 2012-10-04 20:21 +0000 [r374478-374493] Alec L Davis <sivad.a@paradise.net.nz>
  19900. * /, configs/dsp.conf.sample, CHANGES, main/dsp.c: dsp.c User
  19901. Configurable DTMF_HITS_TO_BEGIN and DTMF_MISSES_TO_END Instead of
  19902. a recompile, allow values to be adjusted in dsp.conf For binary
  19903. distributions allows easy adjustment for wobbly GSM calls, and
  19904. other reasons. Defaults to DTMF_HITS_TO_BEGIN=2 and
  19905. DTMF_MISSES_TO_END=3 (closes issue ASTERISK-17493) Reported by:
  19906. alecdavis Tested by: alecdavis alecdavis (license 585) Review
  19907. https://reviewboard.asterisk.org/r/2144/ ........ Merged
  19908. revisions 374479 from
  19909. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19910. revisions 374481 from
  19911. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19912. revisions 374485 from
  19913. http://svn.asterisk.org/svn/asterisk/branches/11
  19914. * main/dsp.c, /: dsp.c fix incorrect DTMF Digit_Duration. it's
  19915. always short by 'hits_to_begin*DTMF_GSIZE', or 25.5ms if
  19916. hitstobegin=2 (issue ASTERISK-16003) Tested by: alecdavis
  19917. alecdavis (license 585) Review
  19918. https://reviewboard.asterisk.org/r/2145/ ........ Merged
  19919. revisions 374475 from
  19920. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19921. revisions 374476 from
  19922. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19923. revisions 374477 from
  19924. http://svn.asterisk.org/svn/asterisk/branches/11
  19925. 2012-10-04 15:48 +0000 [r374429] David M. Lee <dlee@digium.com>
  19926. * /, res/res_agi.c, main/db.c: Fix DBDelTree error codes for AMI,
  19927. CLI and AGI The AMI DBDelTree command will return Success/Key
  19928. tree deleted successfully even if the given key does not exist.
  19929. The CLI command 'database deltree' had a similar problem, but was
  19930. saved because it actually responded with '0 database entries
  19931. removed'. AGI had a slightly different error, where it would
  19932. return success if the database was unavailable. This came from
  19933. confusion about the ast_db_deltree retval, which is -1 in the
  19934. event of a database error, or number of entries deleted
  19935. (including 0 for deleting nothing). * Changed some poorly named
  19936. res variables to num_deleted * Specified specific errors when
  19937. calling ast_db_deltree (database unavailable vs. entry not found
  19938. vs. success) * Fixed similar bug in AGI database deltree, where
  19939. 'Database unavailable' results in successful result (closes issue
  19940. AST-967) Reported by: John Bigelow Review:
  19941. https://reviewboard.asterisk.org/r/2138/ ........ Merged
  19942. revisions 374426 from
  19943. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19944. revisions 374427 from
  19945. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19946. revisions 374428 from
  19947. http://svn.asterisk.org/svn/asterisk/branches/11
  19948. 2012-10-04 13:49 +0000 [r374414] Joshua Colp <jcolp@digium.com>
  19949. * include/asterisk/rtp_engine.h, main/rtp_engine.c,
  19950. channels/chan_sip.c: Add support for applying direct media ACLs
  19951. between differing channel technologies. Review:
  19952. https://reviewboard.asterisk.org/r/2122/
  19953. 2012-10-04 04:50 +0000 [r374387] Alec L Davis <sivad.a@paradise.net.nz>
  19954. * CHANGES, main/dsp.c, /, configs/dsp.conf.sample: dsp.c User
  19955. configuration of DTMF_NORMAL_TWIST and DTMF_REVERSE_TWIST values
  19956. Asterisk's DTMF Specifications are based on AT&T specs, which may
  19957. not be compatible in other countries. Various countries have
  19958. different specifications for the maximum power level differences
  19959. between the DTMF low group and high group of frequencies. Power
  19960. level difference between frequencies for different
  19961. Administrations/RPOAs NTT = Max. 5 dB AT&T = 4dB(reverse) to
  19962. 8dB(normal) Danish = Max. 6 dB Australian = Max. 10 dB Brazilian
  19963. = Max. 9 dB ETSI = Max. 6 dB from ETSI ES 201 235-3 V1.3.1
  19964. (2006-03) Now allow 4 variables to be individually configured in
  19965. dsp.conf, with reasonable min/max of 2dB to 20dB. Default is AT&T
  19966. specifications Add's the following variables to dsp.conf
  19967. ;dtmf_normal_twist=6.31 ;dtmf_reverse_twist=2.51
  19968. ;relax_dtmf_normal_twist=6.31 ;relax_dtmf_reverse_twist=3.98
  19969. (closes issue ASTERISK-20442) Reported by: tbsky Tested by:
  19970. tbsky,alecdavis alecdavis (license 585) Review
  19971. https://reviewboard.asterisk.org/r/2141/ ........ Merged
  19972. revisions 374384 from
  19973. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  19974. revisions 374385 from
  19975. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  19976. revisions 374386 from
  19977. http://svn.asterisk.org/svn/asterisk/branches/11
  19978. 2012-10-04 02:16 +0000 [r374302-374338] Matthew Jordan <mjordan@digium.com>
  19979. * /, res/res_jabber.c: Check for presence of buddy in info/dinfo
  19980. handlers The res_jabber resource module uses the ASTOBJ library
  19981. for managing its ref counted objects. After calling
  19982. ASTOBJ_CONTAINER_FIND to locate a buddy object, the pointer to
  19983. the object has to be checked to see if the buddy existed. Prior
  19984. to this patch, the buddy object was not checked for NULL; with
  19985. this patch in both aji_client_info_handler and aji_dinfo_handler
  19986. the pointer is checked before used and, if no buddy object was
  19987. found, the handlers return an error code. This patch does not
  19988. take the approach that our JID can be used to log in from another
  19989. resource. If that approach is desired, an improvement could be
  19990. made to this patch to create the buddy on the fly. This patch
  19991. seeks only to prevent Asterisk from crashing. FYI: In Asterisk
  19992. 11+, you really should be using res_xmpp. It does not have this
  19993. problem, as it moved to the astobj2 library. Note that multiple
  19994. people have proposed patches for this issue; the patch being
  19995. committed here is based on those. (closes issue ASTERISK-19532)
  19996. Reported by: Karsten Wemheuer Tested by: Byron Clark patches:
  19997. fix-jabber uploaded by Karsten Wemheuer (license #5930)
  19998. xmpp_no_crash_with_ejabberd.patch uploaded by Byron Clark
  19999. (license #6157) (closes issue ASTERISK-19557) Reported by:
  20000. ulugutz ........ Merged revisions 374335 from
  20001. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20002. revisions 374336 from
  20003. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20004. revisions 374337 from
  20005. http://svn.asterisk.org/svn/asterisk/branches/11
  20006. * /, main/ccss.c: Destroy the generic_monitors container after the
  20007. core_instances in ccss For each item in core_instances disposed
  20008. of in the shutdown of ccss, any generic monitor instances
  20009. referenced by the objects will be removed from generic_monitors
  20010. during their destruction. Hilarity ensues if generic_monitors no
  20011. longer exists. Thanks to the Asterisk Test Suite's generic_ccss
  20012. test for complaining loudly when it ran into this. ........
  20013. Merged revisions 374300 from
  20014. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20015. revisions 374301 from
  20016. http://svn.asterisk.org/svn/asterisk/branches/11
  20017. 2012-10-02 23:23 +0000 [r374269-374279] Richard Mudgett <rmudgett@digium.com>
  20018. * main/astobj2.c: Missed an astobj2.c debug tag.
  20019. * main/astobj2.c: * Add ref debug tags to astobj2.c ref usage. *
  20020. Make container nodes not show up in the ref debug log.
  20021. 2012-10-02 21:26 +0000 [r374197-374259] Matthew Jordan <mjordan@digium.com>
  20022. * main/asterisk.c, /: Ensure Shutdown AMI event is still fired
  20023. during Asterisk shutdown Richard pointed out that having the
  20024. manager dispose of itself gracefully during shutdown meant that
  20025. the Shutdown event will no longer get fired. This patch moves the
  20026. AMI event just prior to running the atexit callbacks. ........
  20027. Merged revisions 374230 from
  20028. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20029. revisions 374231 from
  20030. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20031. revisions 374248 from
  20032. http://svn.asterisk.org/svn/asterisk/branches/11
  20033. * utils/hashtest2.c: Modify hashtest2 to compile after r374213.
  20034. Someone, somewhere, may care. Because hashtest2 has to provide
  20035. symbols for things in asterisk that items it includes may use,
  20036. when astobj2 decided to use ast_register_atexit it needed to
  20037. provide a declaration for that as well. Otherwise - no linky. On
  20038. a related note, ASTERISK-20505 was filed to convert
  20039. hashtest/hashtest2 into actual unit tests, so we don't run into
  20040. this problem again.
  20041. * main/astobj2.c, main/message.c, /: Fix findings from check-in on
  20042. r374177 Richard pointed out two problems with the check-in from
  20043. r374177: * The ast_msg_shutdown function declaration doesn't
  20044. match the prototype in main/message.c. * The ref/alloc function
  20045. usage in astobj2 (in trunk) can use the ao2_t_* variants of the
  20046. functions to allow the REF_DEBUG flag to enable/disable their
  20047. debug counterparts. ........ Merged revisions 374210 from
  20048. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20049. revisions 374211 from
  20050. http://svn.asterisk.org/svn/asterisk/branches/11
  20051. * main/features.c, main/config_options.c, main/event.c,
  20052. main/message.c, main/asterisk.c, main/db.c, main/xmldoc.c,
  20053. main/format.c, main/udptl.c, main/pbx.c, /, main/ccss.c,
  20054. include/asterisk/astobj2.h, channels/chan_agent.c,
  20055. res/res_xmpp.c, main/taskprocessor.c, res/res_musiconhold.c,
  20056. main/named_acl.c, main/cel.c, main/astobj2.c, main/format_pref.c,
  20057. main/indications.c, main/channel.c, main/data.c, main/manager.c:
  20058. Fix a variety of ref counting issues This patch resolves a number
  20059. of ref leaks that occur primarily on Asterisk shutdown. It adds a
  20060. variety of shutdown routines to core portions of Asterisk such
  20061. that they can reclaim resources allocate duringd initialization.
  20062. Review: https://reviewboard.asterisk.org/r/2137 ........ Merged
  20063. revisions 374177 from
  20064. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20065. revisions 374178 from
  20066. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20067. revisions 374196 from
  20068. http://svn.asterisk.org/svn/asterisk/branches/11
  20069. 2012-10-01 23:39 +0000 [r374164-374167] Andrew Latham <lathama@gmail.com>
  20070. * main/asterisk.c, addons/app_mysql.c, include/asterisk/doxyref.h,
  20071. contrib/asterisk-ng-doxygen, main/http.c: Doxygen Cleanup Start
  20072. adding configuration file linking and pages. Add module loading
  20073. doxygen block. Breaking up commits to keep it easy to track
  20074. (issue ASTERISK-20259)
  20075. * channels/chan_motif.c, channels/chan_alsa.c,
  20076. channels/chan_console.c, channels/chan_gtalk.c,
  20077. channels/chan_iax2.c, channels/chan_oss.c, channels/chan_mgcp.c,
  20078. channels/chan_jingle.c, channels/chan_dahdi.c,
  20079. channels/chan_misdn.c, channels/chan_vpb.cc, channels/chan_sip.c,
  20080. channels/chan_skinny.c: Doxygen Cleanup Start adding
  20081. configuration file linking and pages. Add module loading doxygen
  20082. block. Breaking up commits to keep it easy to track (issue
  20083. ASTERISK-20259)
  20084. * res/res_calendar.c, res/res_clialiases.c,
  20085. res/res_config_sqlite3.c, res/res_smdi.c, res/res_snmp.c,
  20086. res/res_fax.c, res/res_phoneprov.c, res/res_musiconhold.c,
  20087. res/res_xmpp.c, res/res_config_ldap.c, res/res_curl.c,
  20088. res/res_config_sqlite.c, res/res_timing_kqueue.c, res/res_odbc.c:
  20089. Doxygen Cleanup Start adding configuration file linking and
  20090. pages. Add module loading doxygen block. Breaking up commits to
  20091. keep it easy to track (issue ASTERISK-20259)
  20092. * apps/app_alarmreceiver.c, apps/app_amd.c, apps/app_confbridge.c,
  20093. apps/app_followme.c, apps/app_queue.c, apps/app_adsiprog.c,
  20094. apps/app_voicemail.c, apps/app_meetme.c, apps/app_festival.c,
  20095. apps/app_skel.c: Doxygen Cleanup Start adding configuration file
  20096. linking and pages. Add module loading doxygen block. (issue
  20097. ASTERISK-20259)
  20098. 2012-10-01 20:36 +0000 [r374134-374151] Sean Bright <sean@malleable.com>
  20099. * main/db.c, include/asterisk/astdb.h, /, tests/test_db.c,
  20100. apps/app_queue.c: app_queue: Support persisting and loading of
  20101. long member lists. Greenlight in #asterisk brought up that he was
  20102. receiving an error message "Could not create persistent member
  20103. string, out of space" when running app_queue in Asterisk 10.
  20104. dump_queue_members() made an assumption that 8K would be enough
  20105. to store the generated string, but with queues that have large
  20106. member lists this is not always the case. This patch removes the
  20107. limitation and uses ast_str instead of a fixed sized buffer. The
  20108. complicating factor comes from the fact that ast_db_get requires
  20109. a buffer and buffer size argument, which doesn't let us pull back
  20110. more than what we pass in, so I introduced a new
  20111. ast_db_get_allocated() which returns an ast_strdup()'d copy of
  20112. the value from astdb. As an aside, I did some testing on the
  20113. maximum size of data that we can store in the BDB library we
  20114. distribute and was able to store a 10MB string and retrieve it
  20115. with no problems, so I feel this is a safe patch. Review:
  20116. https://reviewboard.asterisk.org/r/2136/ ........ Merged
  20117. revisions 374108 from
  20118. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20119. revisions 374135 from
  20120. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20121. revisions 374150 from
  20122. http://svn.asterisk.org/svn/asterisk/branches/11
  20123. * main/db.c, /: Use ast_copy_string instead of strncpy to guarantee
  20124. a NUL terminated string. ........ Merged revisions 374132 from
  20125. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20126. revisions 374133 from
  20127. http://svn.asterisk.org/svn/asterisk/branches/11
  20128. 2012-10-01 17:05 +0000 [r374109] Richard Mudgett <rmudgett@digium.com>
  20129. * main/cli.c: Change core show help output format. The CLI "core
  20130. show help" output leaves something to be desired. 1) The command
  20131. is truncated to a maximum of 30 characters. 2) The output columns
  20132. are mirrored from the 31st column. Current output format: logger
  20133. mute Toggle logging output to a console logger reload Reopens the
  20134. log files logger rotate Rotates and reopens the log files logger
  20135. set level {DEBUG|NOTICE Enables/Disables a specific logging level
  20136. for this console logger show channels List configured log
  20137. channels New format: logger mute -- Toggle logging output to a
  20138. console logger reload -- Reopens the log files logger rotate --
  20139. Rotates and reopens the log files logger set level
  20140. {DEBUG|NOTICE|WARNING|ERROR|VERBOSE|DTMF} {on|off} --
  20141. Enables/Disables a specific logging level for this console logger
  20142. show channels -- List configured log channels Review:
  20143. https://reviewboard.asterisk.org/r/2133/
  20144. 2012-10-01 16:26 +0000 [r374107] Mark Michelson <mmichelson@digium.com>
  20145. * /, apps/confbridge/conf_config_parser.c: Don't destroy confbridge
  20146. config when error is encountered during a reload. Not panicking
  20147. means that the old config is kept. (closes issue ASTERISK-20458)
  20148. Reported by: Leif Madsen Patches: ASTERISK-20458.patch uploaded
  20149. by Mark Michelson(license #5049) Tested by Leif Madsen ........
  20150. Merged revisions 374106 from
  20151. http://svn.asterisk.org/svn/asterisk/branches/11
  20152. 2012-10-01 12:29 +0000 [r374096] Joshua Colp <jcolp@digium.com>
  20153. * include/asterisk/speech.h, res/res_speech.c,
  20154. apps/app_speech_utils.c: Add support for retrieving engine
  20155. specific settings using the speech API and from dialplan. (closes
  20156. issue ASTERISK-17136) Reported by: kenner
  20157. 2012-09-29 03:56 +0000 [r374086] Matthew Jordan <mjordan@digium.com>
  20158. * /, channels/chan_sip.c: Fix ref leak when adding ICE candidates
  20159. to an SDP There was a missing decrement to the reference count
  20160. for the current ICE candidate when local candidates are being
  20161. added to an outbound SDP. This patch corrects that. ........
  20162. Merged revisions 374085 from
  20163. http://svn.asterisk.org/svn/asterisk/branches/11
  20164. 2012-09-28 22:11 +0000 [r374075] Richard Mudgett <rmudgett@digium.com>
  20165. * res/res_agi.c: Include channel uniqueid in "AsyncAGI" and
  20166. "AGIExec" events. * Added AMI event documentation for AsyncAGI
  20167. and AGIExec events. (closes issue ASTERISK-20318) Reported by:
  20168. Dan Cropp Patches: res_agi_patch.txt (license #6422) patch
  20169. uploaded by Dan Cropp modified for trunk.
  20170. 2012-09-28 19:37 +0000 [r374060] Jonathan Rose <jrose@digium.com>
  20171. * res/res_jabber.c, /: res_jabber: Remove CLI command 'jabber test'
  20172. The opinion of development was that it is both improper to have
  20173. Matt's personal email address used in the source and that the
  20174. command wouldn't be useful without it. (closes issue AST-467)
  20175. Reported by: Malcolm Davenport ........ Merged revisions 374032
  20176. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  20177. Merged revisions 374045 from
  20178. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20179. revisions 374059 from
  20180. http://svn.asterisk.org/svn/asterisk/branches/11
  20181. 2012-09-28 18:27 +0000 [r374030] Richard Mudgett <rmudgett@digium.com>
  20182. * channels/chan_dahdi.c, channels/sig_analog.c, UPGRADE.txt,
  20183. main/app.c, apps/app_senddtmf.c: Add pause one second W dial
  20184. modifier. * The following dialplan applications now recognize 'W'
  20185. to pause sending DTMF for one second in addition to the
  20186. previously existing 'w' that paused sending DTMF for half a
  20187. second. Dial, ExternalIVR, and SendDTMF. * The chan_dahdi analog
  20188. port dialing and deferred DTMF dialing for PRI now distinguishes
  20189. between 'w' and 'W'. The 'w' pauses dialing for half a second.
  20190. The 'W' pauses dialing for one second. * Created dahdi_dial_str()
  20191. in chan_dahdi that eliminated a lot of duplicated dialing code
  20192. and diagnostic messages for the channel driver. (closes issue
  20193. ASTERISK-20039) Reported by: Jeremiah Gowdy Patches:
  20194. jgowdy-wait-6-22-2012.diff (license #5621) patch uploaded by
  20195. Jeremiah Gowdy Expanded patch to add support in chan_dahdi.
  20196. Tested by: rmudgett
  20197. 2012-09-28 13:04 +0000 [r374020] Brent Eagles <beagles@digium.com>
  20198. * res/res_xmpp.c, main/message.c, /: Reset hangup flags on channels
  20199. created through messages and cleanup globals in res_xmpp on
  20200. unload. This patch fixes an issue where hangup flags were not
  20201. being reset on a channel, affecting subsequent use of that
  20202. channel. The patch also adds some additional cleanup to res_xmpp
  20203. to fix an issue with reloading the module. (closes
  20204. ASTERISK-20360) Reported by: Noah Engelberth Tested by: beagles
  20205. Review: https://reviewboard.asterisk.org/r/2134/ ........ Merged
  20206. revisions 374019 from
  20207. http://svn.asterisk.org/svn/asterisk/branches/11
  20208. 2012-09-28 12:17 +0000 [r373992] Joshua Colp <jcolp@digium.com>
  20209. * /, res/res_agi.c: Update documentation to make it explicit that
  20210. "stream file" will not restart musiconhold. (issue
  20211. ASTERISK-17367) Reported by: oej ........ Merged revisions 373989
  20212. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  20213. Merged revisions 373990 from
  20214. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20215. revisions 373991 from
  20216. http://svn.asterisk.org/svn/asterisk/branches/11
  20217. 2012-09-28 03:06 +0000 [r373979] Matthew Jordan <mjordan@digium.com>
  20218. * CHANGES, apps/app_senddtmf.c: Add Duration header for PlayDTMF
  20219. AMI Action This patch adds an optional header to the PlayDTMF AMI
  20220. action, Duration. It allows the duration of the DTMF digit to be
  20221. played on the channel to be specified in milliseconds. (closes
  20222. issue ASTERISK-18172) Reported by: Renato dos Santos patches:
  20223. send-dtmf.patch uploaded by Renato dos Santos (license #6267)
  20224. Modified slightly for this commit for Asterisk 12.
  20225. 2012-09-27 22:43 +0000 [r373965-373967] Richard Mudgett <rmudgett@digium.com>
  20226. * apps/app_dial.c: Tweak app_dial documentation.
  20227. * main/app.c: Cleanup ast_dtmf_stream() * Made ast_dtmf_stream()
  20228. wait after starting the silence generator rather than before. *
  20229. Made ast_dtmf_stream() put the peer in autoservice for the whole
  20230. time things are being done to the chan.
  20231. * apps/app_senddtmf.c, /: Fix SendDTMF crash and channel reference
  20232. leak using channel name parameter. The SendDTMF channel name
  20233. parameter has two issues. 1) Crashes if the channel name does not
  20234. exist. 2) Leaks a channel reference if the channel is the current
  20235. channel. Problem introduced by ASTERISK-15956. * Updated SendDTMF
  20236. documentation. * Renamed app to senddtmf_name and tweaked the
  20237. type. ........ Merged revisions 373945 from
  20238. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20239. revisions 373946 from
  20240. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20241. revisions 373954 from
  20242. http://svn.asterisk.org/svn/asterisk/branches/11
  20243. 2012-09-27 17:12 +0000 [r373915] Joshua Colp <jcolp@digium.com>
  20244. * res/res_http_websocket.c, /, channels/chan_sip.c,
  20245. include/asterisk/http_websocket.h: Make res_http_websocket an
  20246. optional dependency on supported platforms for chan_sip. (closes
  20247. issue ASTERISK-20439) Reported by: sruffell Patches:
  20248. 0001-chan_sip-websocket-support-is-an-optional-API.patch uploaded
  20249. by sruffell (license 5417) ........ Merged revisions 373914 from
  20250. http://svn.asterisk.org/svn/asterisk/branches/11
  20251. 2012-09-27 17:02 +0000 [r373913] Kinsey Moore <kmoore@digium.com>
  20252. * apps/app_voicemail.c, CHANGES: Add VoicemailRefresh AMI Action
  20253. Currently, if there are modifications to mailboxes that Asterisk
  20254. is not aware of, the user needs to add "pollmailboxes" to their
  20255. mailbox configuration, which repeatedly polls the subscribed
  20256. mailboxes for changes. This results in a lot of extra work for
  20257. the CPU. This patch introduces the AMI command VoicemailRefresh
  20258. which permits external applications to trigger the refresh
  20259. themselves. The refresh can apply to a specified mailbox only, an
  20260. entire context, or all configured mailboxes. Even a refresh
  20261. performed on every mailbox would not consume as much CPU as the
  20262. pollmailboxes option, given that pollmailboxes runs continuously
  20263. and this only runs on demand. (closes issue ASTERISK-17206)
  20264. (closes issue ASTERISK-19908) Reported-by: Jeff Hutchins
  20265. Reported-by: Tilghman Lesher Patch-by: Tilghman Lesher
  20266. 2012-09-27 16:53 +0000 [r373881-373912] Joshua Colp <jcolp@digium.com>
  20267. * /, main/loader.c: loader: Ensure dependent modules are properly
  20268. initialized. If an Asterisk module specifies a dependency in
  20269. ast_module_info.nonoptreq, it is possible for Asterisk to skip
  20270. calling the modules's .load function. Asterisk was loading and
  20271. linking the module via load_dynamic_module() but was not adding
  20272. the module to the resource_heap. Therefore the module was not
  20273. initialized based on it's priority along with the other modules
  20274. in the heap. Now use load_resource() instead of
  20275. load_dynamic_module() for non-optional requirement. This will add
  20276. the module to the resource_heap so the module can be properly
  20277. initialized in the correct order. This is required if there are
  20278. any module global data structures initialized in the .load()
  20279. callback for the module on platforms which do not support weak
  20280. references. (issue ASTERISK-20439) Reported by: sruffell Patches:
  20281. 0001-loader-Ensure-dependent-modules-are-properly-initial.patch
  20282. uploaded by sruffell (license 5417) ........ Merged revisions
  20283. 373909 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  20284. ........ Merged revisions 373910 from
  20285. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20286. revisions 373911 from
  20287. http://svn.asterisk.org/svn/asterisk/branches/11
  20288. * channels/chan_local.c, /: Fix an issue where Local channels
  20289. dialed by app_queue are considered in use immediately. The
  20290. chan_local channel driver returns a device state of in use even
  20291. if a created Local channel has not yet been dialed. This fix
  20292. changes the logic to return a state of not in use until the
  20293. channel itself has been dialed. (closes issue ASTERISK-20390)
  20294. Reported by: tim_ringenbach Review:
  20295. https://reviewboard.asterisk.org/r/2116/ ........ Merged
  20296. revisions 373878 from
  20297. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20298. revisions 373879 from
  20299. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20300. revisions 373880 from
  20301. http://svn.asterisk.org/svn/asterisk/branches/11
  20302. 2012-09-26 21:17 +0000 [r373852] Mark Michelson <mmichelson@digium.com>
  20303. * /, channels/chan_sip.c: Move handling of 408 response so there is
  20304. no misleading warning message. (closes issue ASTERISK-20060)
  20305. Reported by: Walter Doekes ........ Merged revisions 373848 from
  20306. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20307. revisions 373849 from
  20308. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20309. revisions 373850 from
  20310. http://svn.asterisk.org/svn/asterisk/branches/11
  20311. 2012-09-26 18:23 +0000 [r373835] Richard Mudgett <rmudgett@digium.com>
  20312. * /, apps/app_meetme.c: Fixed meetme tab completion and command
  20313. documentation. * Removed unnecessary case sensitivity in meetme
  20314. list, lock, unlock, mute, unmute, and kick commands. * Separated
  20315. meetme lock/unlock, mute/unmute, and kick commands into their own
  20316. registered commands to simplify tab completion and parameter
  20317. checking. meetme_lock_cmd(), meetme_mute_cmd(), and
  20318. meetme_kick_cmd() * Simplified meetme_show_cmd() (closes issue
  20319. AST-1006) Reported by: John Bigelow Tested by: rmudgett ........
  20320. Merged revisions 373815 from
  20321. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20322. revisions 373816 from
  20323. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20324. revisions 373818 from
  20325. http://svn.asterisk.org/svn/asterisk/branches/11
  20326. 2012-09-26 08:31 +0000 [r373805] Alec L Davis <sivad.a@paradise.net.nz>
  20327. * apps/app_queue.c, /: app_queue: 'agent available' hint, cleanup
  20328. restart, and initial state Fix previously untested senarios; 1).
  20329. On queue initialisation set queue_avail devstate to INUSE.
  20330. Previously was unavailable, which indicated an agent was
  20331. available. 2). When removing members, if there are no other
  20332. members available, set queue_avail to INUSE. Previously, if a
  20333. member interface had become 'unavailable', they were never going
  20334. to be removed, particularly when persistant queues is enabled.
  20335. 3). When adding a member, check that they are available, if they
  20336. are set queue_avail to NOT_INUSE. Previously on reloaded, members
  20337. may have been 'unavailable'. 4). When pausing or unpausing a
  20338. member, set appropriate queue availability. alecdavis (license
  20339. 585) Reported by: Alec Davis Tested by: alecdavis Review:
  20340. https://reviewboard.asterisk.org/r/2129/ ........ Merged
  20341. revisions 373804 from
  20342. http://svn.asterisk.org/svn/asterisk/branches/11
  20343. 2012-09-25 23:10 +0000 [r373740-373776] Mark Michelson <mmichelson@digium.com>
  20344. * /, main/say.c: Fix saying of date in Dutch. The Dutch say the
  20345. date before the month. (closes issue ASTERISK-20353) Reported by:
  20346. Teun Ouwehand ........ Merged revisions 373773 from
  20347. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20348. revisions 373774 from
  20349. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20350. revisions 373775 from
  20351. http://svn.asterisk.org/svn/asterisk/branches/11
  20352. * /, channels/chan_agent.c, configs/agents.conf.sample: Remove dead
  20353. code and documentation for nonexistent feature. multiplelogin was
  20354. removed from chan_agent back in 1.6.0 when AgentCallbackLogin()
  20355. was removed. (closes issue AST-948) reported by Steve Pitts
  20356. ........ Merged revisions 373768 from
  20357. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20358. revisions 373769 from
  20359. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20360. revisions 373770 from
  20361. http://svn.asterisk.org/svn/asterisk/branches/11
  20362. * apps/app_voicemail.c, /: Fix error where improper IMAP greetings
  20363. would be deleted. (closes issue ASTERISK-20435) Reported by:
  20364. fhackenberger Patches: asterisk-20435-imap-del-greeting.diff
  20365. uploaded by Michael L. Young (License #5026) (with suggested
  20366. modification made by me) ........ Merged revisions 373735 from
  20367. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20368. revisions 373737 from
  20369. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20370. revisions 373738 from
  20371. http://svn.asterisk.org/svn/asterisk/branches/11
  20372. 2012-09-25 20:14 +0000 [r373708] Joshua Colp <jcolp@digium.com>
  20373. * channels/chan_local.c, /: Fix T.38 support when used with
  20374. chan_local in between. Users of the T.38 API can indicate
  20375. AST_T38_REQUEST_PARMS on a channel to request that the channel
  20376. indicate a T.38 negotiation with the parameters present on the
  20377. channel. The return value of this indication is expected to be
  20378. AST_T38_REQUEST_PARMS upon success but with chan_local involved
  20379. this could never occur. This fix changes chan_local to always
  20380. return AST_T38_REQUEST_PARMS for this situation. If the
  20381. underlying channel technology on the other side does not support
  20382. T.38 this would have been determined ahead of time using
  20383. ast_channel_get_t38_state and an indication would not occur.
  20384. (closes issue ASTERISK-20229) Reported by: wdoekes Patches:
  20385. ASTERISK-20229.patch uploaded by wdoekes (license 5674) Review:
  20386. https://reviewboard.asterisk.org/r/2070/ ........ Merged
  20387. revisions 373705 from
  20388. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20389. revisions 373706 from
  20390. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20391. revisions 373707 from
  20392. http://svn.asterisk.org/svn/asterisk/branches/11
  20393. 2012-09-25 19:29 +0000 [r373701] Mark Michelson <mmichelson@digium.com>
  20394. * include/asterisk/channel.h, CHANGES, channels/sig_pri.c,
  20395. funcs/func_callerid.c, include/asterisk/callerid.h,
  20396. main/channel.c, channels/chan_misdn.c, channels/chan_sip.c,
  20397. main/callerid.c: Allow for redirecting reasons to be set to
  20398. arbitrary strings. This allows for the REDIRECTING dialplan
  20399. function to be used to set the reason to any string. The SIP
  20400. channel driver has been modified to set the redirecting reason
  20401. string to the value received in a Diversion header. In addition,
  20402. SIP 480 response reason text will set the redirecting reason as
  20403. well. (closes issue AST-942) reported by Malcolm Davenport
  20404. (closes issue AST-943) reported by Malcolm Davenport Review:
  20405. https://reviewboard.asterisk.org/r/2101
  20406. 2012-09-25 19:08 +0000 [r373691] Terry Wilson <twilson@digium.com>
  20407. * configs/sip.conf.sample, channels/sip/include/sip.h, /,
  20408. channels/chan_sip.c: Properly handle UAC/UAS roles for SIP
  20409. session timers The SIP session timer mechanism contains a
  20410. mandatory 'refresher' parameter (included in the Session-Expires
  20411. header) which is used in the session timer offer/answer signaling
  20412. within a SIP Invite dialog. It looks like asterisk is
  20413. interpreting the uac resp. uas role only as the initial role of
  20414. client and server (caller is uac, callee is uas). The standard
  20415. rfc 4028 however assigns the client role to the ((RE)-Invite)
  20416. requester, the server role to the ((RE)-Invite) responder. This
  20417. patch has Asterisk track the actual refresher as "us" or "them"
  20418. as opposed to relying on just the configured "uas" or "uac"
  20419. properties. (closes issue AST-922) Reported by: Thomas Airmont
  20420. Review: https://reviewboard.asterisk.org/r/2118/ ........ Merged
  20421. revisions 373652 from
  20422. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20423. revisions 373665 from
  20424. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20425. revisions 373690 from
  20426. http://svn.asterisk.org/svn/asterisk/branches/11
  20427. 2012-09-25 18:33 +0000 [r373689] Kinsey Moore <kmoore@digium.com>
  20428. * /, apps/app_queue.c: "show" completion option for "queue"
  20429. shouldn't appear twice When tab-completing CLI commands starting
  20430. with "queue", "show" appeared twice in the list due to the way
  20431. that Asterisk's tab completion functions and the order in which
  20432. the commands were registered. The registration order has been
  20433. altered to resolve this issue. (closes issue AST-940)
  20434. Reported-by: Steve Pitts ........ Merged revisions 373666 from
  20435. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20436. revisions 373675 from
  20437. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20438. revisions 373688 from
  20439. http://svn.asterisk.org/svn/asterisk/branches/11
  20440. 2012-09-25 17:22 +0000 [r373636-373656] Richard Mudgett <rmudgett@digium.com>
  20441. * /, codecs/ilbc/iLBC_encode.c, codecs/ilbc/iLBC_decode.c: Fix
  20442. valgrind found memcpy issues in codec_ilbc. Valgrind found
  20443. codec_ilbc using memcpy instead of memmove for overlapping memory
  20444. blocks. (issue ASTERISK-19890) (closes issue ASTERISK-20231)
  20445. Reported by: Walter Doekes Patches: ASTERISK-20231.patch (license
  20446. #5674) patch uploaded by Walter Doekes ........ Merged revisions
  20447. 373640 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  20448. ........ Merged revisions 373645 from
  20449. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20450. revisions 373650 from
  20451. http://svn.asterisk.org/svn/asterisk/branches/11
  20452. * /, codecs/Makefile: Make rebuild GSM, ilbc, or lpc10 codecs if
  20453. the respective sources change. ........ Merged revisions 373618
  20454. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  20455. Merged revisions 373633 from
  20456. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20457. revisions 373635 from
  20458. http://svn.asterisk.org/svn/asterisk/branches/11
  20459. 2012-09-25 16:45 +0000 [r373608-373634] Jonathan Rose <jrose@digium.com>
  20460. * /, channels/chan_sip.c: chan_sip: Set Quality of Service for
  20461. video rtp instance (closes issue ASTERISK-20201) Reported by:
  20462. ddkprog Patches: chan_sip.c.diff uploaded by ddkprog (license
  20463. 6008) ........ Merged revisions 373617 from
  20464. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20465. revisions 373631 from
  20466. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20467. revisions 373632 from
  20468. http://svn.asterisk.org/svn/asterisk/branches/11
  20469. * res/res_agi.c: res_agi: async_agi responsiveness improvement on
  20470. datastore problems This patch changes get_agi_cmd so that the
  20471. return can be checked to differentiate between an empty list
  20472. success and something that triggered an error. This in turn
  20473. allows launch_asyncagi to detect these errors and break free from
  20474. the command processing loop so that the async agi can be ended
  20475. more cleanly (closes issue ASTERISK-20109) Reported by: Jeremiah
  20476. Gowdy Patches: jgowdy-7-9-2012.diff uploaded by Jeremiah Gowdy
  20477. (license 6358) (Modified by me to fix some logical issues and
  20478. apply to trunk) Review: https://reviewboard.asterisk.org/r/2117/
  20479. 2012-09-25 14:13 +0000 [r373583] Mark Michelson <mmichelson@digium.com>
  20480. * funcs/func_presencestate.c, /: "He who go through turnstile
  20481. sideways is going to Bangkok" ........ Merged revisions 373582
  20482. from http://svn.asterisk.org/svn/asterisk/branches/11
  20483. 2012-09-25 13:29 +0000 [r373581] Kinsey Moore <kmoore@digium.com>
  20484. * configs/res_odbc.conf.sample, /: Fix documentation for default
  20485. username in res_odbc This was previously stated to be "root", but
  20486. is actually the name of the context if unspecified. (closes issue
  20487. ASTERISK-20258) Reported by: Stefan x ........ Merged revisions
  20488. 373578 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  20489. ........ Merged revisions 373579 from
  20490. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20491. revisions 373580 from
  20492. http://svn.asterisk.org/svn/asterisk/branches/11
  20493. 2012-09-25 12:12 +0000 [r373553] Joshua Colp <jcolp@digium.com>
  20494. * /, res/res_rtp_multicast.c: Fix an issue where a caller to
  20495. ast_write on a MulticastRTP channel would determine it failed
  20496. when in reality it did not. When sending RTP packets via
  20497. multicast the amount of data sent is stored in a variable and
  20498. returned from the write function. This is incorrect as any
  20499. non-zero value returned is considered a failure while a return
  20500. value of 0 is success. For callers (such as ast_streamfile) that
  20501. checked the return value they would have considered it a failure
  20502. when in reality nothing went wrong and it was actually a success.
  20503. The write function for the multicast RTP engine now returns -1 on
  20504. failure and 0 on success, as it should. (closes issue
  20505. ASTERISK-17254) Reported by: wybecom ........ Merged revisions
  20506. 373550 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  20507. ........ Merged revisions 373551 from
  20508. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20509. revisions 373552 from
  20510. http://svn.asterisk.org/svn/asterisk/branches/11
  20511. 2012-09-24 22:14 +0000 [r373503] Richard Mudgett <rmudgett@digium.com>
  20512. * /, channels/chan_sip.c: Be consistent, send From: "Anonymous"
  20513. <sip:anonymous@anonymous.invalid> When setting
  20514. CALLERID(pres)=unavailable in the dialplan, the From header in
  20515. the SIP message contains "Anonymous"
  20516. <sip:Anonymous@anonymous.invalid>. For consistency, Asterisk
  20517. should use a lowercase a in the userpart of the URI. * Make the
  20518. From header use a lowercase A in the userpart of the anonymous
  20519. URI. (closes issue ASTERISK-19838) Reported by: Antti Yrjola
  20520. Patches: chan_sip_patch_ASTERISK-19838.patch (license #6383)
  20521. patch uploaded by Antti Yrjola ........ Merged revisions 373500
  20522. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  20523. Merged revisions 373501 from
  20524. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20525. revisions 373502 from
  20526. http://svn.asterisk.org/svn/asterisk/branches/11
  20527. 2012-09-24 21:19 +0000 [r373479] Jonathan Rose <jrose@digium.com>
  20528. * apps/app_mixmonitor.c, funcs/func_audiohookinherit.c, /:
  20529. func_audiohookinherit: Document some missed sources. This patch
  20530. also mentions that AUDIOHOOK_INHERIT can be used to transfer
  20531. MixMonitor audiohooks. There is also wiki that addresses
  20532. audiohooks and the use of AUDIOHOOK_INHERIT at the following
  20533. link: https://wiki.asterisk.org/wiki/display/AST/Audiohooks
  20534. (closes issue ASTERISK-18220) Reported by: Ishfaq Malik ........
  20535. Merged revisions 373467 from
  20536. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20537. revisions 373468 from
  20538. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20539. revisions 373470 from
  20540. http://svn.asterisk.org/svn/asterisk/branches/11
  20541. 2012-09-24 21:15 +0000 [r373471] Richard Mudgett <rmudgett@digium.com>
  20542. * /, channels/chan_sip.c: Fix potential reentrancy problems in
  20543. chan_sip. Asterisk v1.8 and later was not as vulnerable to this
  20544. issue. * Made find_call() lock each private as it processes the
  20545. found dialogs. (Primary cause of ABE-2876) * Made the other
  20546. functions that traverse the dialogs container lock each private
  20547. as it examines them. * Fix race condition in sip_call() if the
  20548. thread that sent the INVITE is held up long enough for a response
  20549. to be processed. The p->initid for the INVITE retransmission
  20550. could be added after it was canceled by the response processing.
  20551. * Made __sip_destroy() clean up resource pointers after freeing.
  20552. This is primarily defensive in case someone has a stale private
  20553. pointer. * Removed redundant memset() in reqprep(). The call to
  20554. init_req() already does the memset() and is the first reference
  20555. to req in reqprep(). * Removed useless set of req.method in
  20556. transmit_invite(). The calls to initreqprep() and reqprep() have
  20557. to do this because they memset() the req. JIRA ABE-2876
  20558. .......... Merged -r373423 from
  20559. https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  20560. ........ Merged revisions 373424 from
  20561. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20562. revisions 373466 from
  20563. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20564. revisions 373469 from
  20565. http://svn.asterisk.org/svn/asterisk/branches/11
  20566. 2012-09-24 19:23 +0000 [r373414-373456] Joshua Colp <jcolp@digium.com>
  20567. * /, channels/chan_sip.c: Fix a deadlock caused by a race condition
  20568. between removing a hint and reloading the dialplan and
  20569. subscribing to the removed hint. If conditions were right it was
  20570. possible for both the PBX core and chan_sip to deadlock by both
  20571. having a lock that the other wants. In the case of the PBX core
  20572. it had the contexts lock and wanted a SIP dialog lock, while in
  20573. the case of chan_sip it had the SIP dialog lock and wanted the
  20574. contexts lock. This fix unlocks the SIP dialog before getting the
  20575. extension state so that the other thread will not block on trying
  20576. to lock it. Once the extension state is retrieved the SIP dialog
  20577. is locked again and life carries on. As the SIP dialog is
  20578. reference counted it is not possible for it to go away after
  20579. unlocking. (closes issue ASTERISK-20437) Reported by: jhutchins
  20580. ........ Merged revisions 373438 from
  20581. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20582. revisions 373440 from
  20583. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20584. revisions 373454 from
  20585. http://svn.asterisk.org/svn/asterisk/branches/11
  20586. * res/res_format_attr_h264.c, /, channels/chan_sip.c: Fix an issue
  20587. with H.264 format attribute comparison and fix an issue with
  20588. improper SDP being produced. The H.264 format attribute module
  20589. compares two format attribute structures to determine if they are
  20590. compatible or not. In some instances it was possible for this
  20591. check to determine that both structures were incompatible when
  20592. they actually should be considered compatible. This check has now
  20593. been made even more permissive by assuming that if no attribute
  20594. information is available the two structures are compatible. If
  20595. both structures contain attribute information a base level
  20596. comparison of the H.264 IDC value is done to see if they are
  20597. compatible or not. The above issue uncovered a secondary issue in
  20598. chan_sip where the SDP being produced would be incorrect if the
  20599. formats were considered incompatible. This has now been fixed by
  20600. checking that all information required to produce the SDP is
  20601. available instead of assuming it is. (closes issue
  20602. ASTERISK-20464) Reported by: Leif Madsen ........ Merged
  20603. revisions 373413 from
  20604. http://svn.asterisk.org/svn/asterisk/branches/11
  20605. 2012-09-24 12:42 +0000 [r373404] Brent Eagles <beagles@digium.com>
  20606. * res/res_rtp_asterisk.c, /, configs/rtp.conf.sample:
  20607. res_rtp_asterisk: Make TURN and STUN server configurations
  20608. consistent. This patch removes the turnport configuration
  20609. property and changes the turnaddr property to be a combined
  20610. host[:port] configuration string. The patch also modifies the
  20611. documentation in the example configuration to reflect the
  20612. property changes and adds some additional text indicating how the
  20613. STUN port is configured. (closes issue ASTERISK-20344) Reported
  20614. by: beagles Tested by: beagles Review:
  20615. https://reviewboard.asterisk.org/r/2111/ ........ Merged
  20616. revisions 373403 from
  20617. http://svn.asterisk.org/svn/asterisk/branches/11
  20618. 2012-09-22 20:43 +0000 [r373384] Andrew Latham <lathama@gmail.com>
  20619. * Makefile, cel/cel_odbc.c, include/asterisk/doxyref.h,
  20620. main/manager.c, doc/README.txt, include/asterisk/xmpp.h,
  20621. apps/app_minivm.c, cel/cel_sqlite3_custom.c,
  20622. include/asterisk/format.h, main/audiohook.c,
  20623. include/asterisk/pbx.h, res/res_timing_kqueue.c,
  20624. addons/chan_mobile.c, main/asterisk.c, main/xmldoc.c,
  20625. channels/chan_mgcp.c, apps/app_voicemail.c, utils/refcounter.c,
  20626. res/res_config_pgsql.c, main/pbx.c, main/ccss.c,
  20627. channels/chan_sip.c, tests/test_gosub.c,
  20628. include/asterisk/doxygen/mantisworkflow.h (removed),
  20629. contrib/asterisk-ng-doxygen, channels/chan_agent.c, main/astfd.c,
  20630. apps/app_queue.c, codecs/speex/speex_resampler.h,
  20631. res/res_config_sqlite.c: Doxygen Updates Janitor Work *
  20632. Whitespace, doc-blocks, spelling, case, missing and incorrect
  20633. tags. * Add cleanup to Makefile for the Doxygen configuration
  20634. update * Start updating Doxygen configuration for cleaner output
  20635. * Enable inclusion of configuration files into documentation *
  20636. remove mantisworkflow... * update documentation README * Add
  20637. markup to Tilghman's email and talk with him about updating his
  20638. email, he knows... * no code changes on this commit other than
  20639. the mentioned Makefile change (issue ASTERISK-20259)
  20640. 2012-09-21 19:35 +0000 [r373369] Jonathan Rose <jrose@digium.com>
  20641. * /, channels/iax2-provision.c: iax2-provision: Fix improper return
  20642. on failed cache retrieval (closes issue ASTERISK-20337) reported
  20643. by: John Covert Patches: iax2-provision.c.patch uploaded by John
  20644. Covert (license 5512) ........ Merged revisions 373342 from
  20645. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20646. revisions 373343 from
  20647. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20648. revisions 373368 from
  20649. http://svn.asterisk.org/svn/asterisk/branches/11
  20650. 2012-09-21 18:22 +0000 [r373320-373341] Andrew Latham <lathama@gmail.com>
  20651. * contrib/asterisk-ng-doxygen: Update Doxygen Config Comments This
  20652. annoying update is almost totally whitespace and updated config
  20653. comments. I did add Python to the documented file types. (issue
  20654. ASTERISK-20259)
  20655. * include/asterisk/localtime.h, apps/app_ices.c, cdr/cdr_pgsql.c,
  20656. res/res_xmpp.c, res/res_jabber.c, cdr/cdr_radius.c,
  20657. include/asterisk/doxygen/releases.h, include/asterisk/doxyref.h,
  20658. res/res_smdi.c, main/manager.c, main/tdd.c,
  20659. include/asterisk/bridging_features.h, main/ast_expr2f.c,
  20660. cdr/cdr_sqlite.c, apps/app_skel.c, include/asterisk/sip_api.h,
  20661. channels/chan_motif.c, main/http.c, apps/app_confbridge.c,
  20662. include/asterisk/doxygen/commits.h, res/res_config_ldap.c,
  20663. res/res_curl.c, main/strings.c, res/res_config_pgsql.c,
  20664. codecs/codec_speex.c, res/res_crypto.c, main/acl.c,
  20665. channels/chan_console.c, res/res_config_curl.c,
  20666. channels/chan_jingle.c, include/asterisk/app.h,
  20667. include/asterisk/res_odbc.h, channels/chan_misdn.c,
  20668. include/asterisk/doxygen/asterisk-git-howto.h,
  20669. include/asterisk/xmpp.h, include/asterisk/jabber.h,
  20670. channels/chan_h323.c, include/asterisk/doxygen/reviewboard.h,
  20671. channels/sip/include/sdp_crypto.h, main/asterisk.c,
  20672. main/xmldoc.c, include/asterisk/doxygen/architecture.h,
  20673. include/asterisk/acl.h, cel/cel_pgsql.c, funcs/func_speex.c,
  20674. cel/cel_radius.c, apps/app_meetme.c, main/ccss.c, res/res_snmp.c,
  20675. include/asterisk/doxygen/mantisworkflow.h, main/sha1.c,
  20676. channels/sip/reqresp_parser.c: Doxygen Updates - janitor work
  20677. Doxygen updates including mistakes, misspellings, missing
  20678. parameters, updates for Doxygen style. Some missing txt file
  20679. links are removed but their content or essense will be included
  20680. in some later updates. A majority of the txt files were removed
  20681. in the 1.6 era but never noted. The HR and EXTREF are simple
  20682. changes that make the documentation more compatable with more
  20683. versions of Doxygen. Further updates coming. (issue
  20684. ASTERISK-20259)
  20685. * README: Start work on documentation janitor project with a little
  20686. commit. This adds a link to the Asterisk wiki at
  20687. https://wiki.asterisk.org to the README file. (issue
  20688. ASTERISK-20259)
  20689. 2012-09-21 15:41 +0000 [r373319] Jonathan Rose <jrose@digium.com>
  20690. * /, apps/app_queue.c: app_queue: Make queue reload members and
  20691. variants of that work Prior to this patch, 'queue reload members'
  20692. cli command did not work at all. This also affects the manager
  20693. function 'QueueReload' when supplied with the 'members: yes'
  20694. field. (closes issue AST-956) Reported by: John Bigelow ........
  20695. Merged revisions 373298 from
  20696. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20697. revisions 373300 from
  20698. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20699. revisions 373318 from
  20700. http://svn.asterisk.org/svn/asterisk/branches/11
  20701. 2012-09-21 09:11 +0000 [r373275-373284] Alec L Davis <sivad.a@paradise.net.nz>
  20702. * main/dsp.c: dsp.c: remove more whitespace mentioned in review2107
  20703. * main/dsp.c: dsp.c ast_dsp_call_progress use local short variable
  20704. in loop, plus other cleanup janitor cleanup. No functional
  20705. change. 1). ast_dsp_call_progress: use 'short samp' instead of
  20706. s[x] inside loop. apply same casting as other _init, dsp->energy
  20707. = (int32_t) samp * (int32_t) samp 2). ast_dtmf_detect_init: move
  20708. repeated setting of s->energy to outside of loop. do
  20709. goertzel_init loop first before setting s->lasthit and
  20710. s->current_hit, consistant with ast_dsp_digitreset() 3).
  20711. ast_mf_detect_init: do goertzel_init loop first before setting
  20712. s->hits[] and s->current_hit, consistant with
  20713. ast_dsp_digitreset() 4). Don't chain init different variables, as
  20714. the type may change Review
  20715. https://reviewboard.asterisk.org/r/2107/
  20716. 2012-09-20 19:16 +0000 [r373247] Joshua Colp <jcolp@digium.com>
  20717. * /, apps/app_meetme.c: Fix incorrect MeetME conference bridge
  20718. reference count decrementing and sometimes premature destruction.
  20719. When using the 'e' or 'E' option to MeetMe the configured
  20720. conference bridges are loaded and examined to see if any are
  20721. empty. If no conference bridges are empty the caller is prompted
  20722. to enter the number of one. This operation left around a pointer
  20723. to the last created conference bridge still containing
  20724. participants. When the caller that was not able to find any empty
  20725. conference bridge hung up this pointer was disposed of and the
  20726. reference count of the conference bridge decremented. If there
  20727. was only a single participant in the conference bridge it was
  20728. ultimately destroyed prematurely. (closes issue AST-994) Reported
  20729. by: John Bigelow ........ Merged revisions 373242 from
  20730. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20731. revisions 373245 from
  20732. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20733. revisions 373246 from
  20734. http://svn.asterisk.org/svn/asterisk/branches/11
  20735. 2012-09-20 18:44 +0000 [r373239] Matthew Jordan <mjordan@digium.com>
  20736. * CHANGES, apps/app_queue.c, configs/extensions.conf.sample, /: Add
  20737. queue monitoring hints This patch adds support for hints on a
  20738. queue. Hints can be added using the nomenclature 'Queue:name',
  20739. where name is the name of the queue being monitored. This nifty
  20740. feature was done by Alec Davis. Review:
  20741. https://reviewboard.asterisk.org/r/1619 Reported by: Alec Davis
  20742. Tested by: alecdavis patches: review1619.diff2 by alecdavis
  20743. (license 585) ........ Merged revisions 373235 from
  20744. http://svn.asterisk.org/svn/asterisk/branches/11
  20745. 2012-09-20 18:27 +0000 [r373234] Joshua Colp <jcolp@digium.com>
  20746. * channels/sip/include/sip.h, res/res_rtp_asterisk.c,
  20747. main/rtp_engine.c, /, channels/chan_sip.c, configure,
  20748. include/asterisk/autoconfig.h.in, configure.ac,
  20749. configs/sip.conf.sample, include/asterisk/rtp_engine.h: Add
  20750. support for DTLS-SRTP to res_rtp_asterisk and chan_sip. As
  20751. mentioned on the review for this, WebRTC has moved towards
  20752. choosing DTLS-SRTP as the mechanism for key exchange for SRTP.
  20753. This commit adds support for this but makes it available for
  20754. normal SIP clients as well. Testing has been done to ensure that
  20755. this introduces no regressions with existing behavior and also
  20756. that it functions as expected. Review:
  20757. https://reviewboard.asterisk.org/r/2113/ ........ Merged
  20758. revisions 373229 from
  20759. http://svn.asterisk.org/svn/asterisk/branches/11
  20760. 2012-09-20 18:02 +0000 [r373222] Matthew Jordan <mjordan@digium.com>
  20761. * apps/app_queue.c: Support all ways a member can be available for
  20762. 'agent available' hints Alec's patch in r373188 added the ability
  20763. to subscribe to a hint for when Queue members are available. This
  20764. patch modifies the check that determines when a Queue member is
  20765. available by refactoring the availability checks in
  20766. num_available_members into a shared function is_member_available.
  20767. This should now handle the ringinuse option, as well as device
  20768. state values other than AST_DEVICE_NOT_INUSE.
  20769. 2012-09-20 17:22 +0000 [r373221] Richard Mudgett <rmudgett@digium.com>
  20770. * apps/app_directed_pickup.c, funcs/func_channel.c,
  20771. main/features.c, include/asterisk/channel.h,
  20772. include/asterisk/features.h, main/channel.c, /: Named call pickup
  20773. groups. Fixes, missing functionality, and improvements. *
  20774. ASTERISK-20383 Missing named call pickup group features:
  20775. CHANNEL(callgroup) - Need CHANNEL(namedcallgroup)
  20776. CHANNEL(pickupgroup) - Need CHANNEL(namedpickupgroup) Pickup() -
  20777. Needs to also select from named pickup groups. * ASTERISK-20384
  20778. Using the pickupexten, the pickup channel selection could fail
  20779. even though there was a call it could have picked up. In a call
  20780. pickup race when there are multiple calls to pickup and two
  20781. extensions try to pickup a call, it is conceivable that the loser
  20782. will not pick up any call even though it could have picked up the
  20783. next oldest matching call. Regression because of the named call
  20784. pickup group feature. * See ASTERISK-20386 for the implementation
  20785. improvements. These are the changes in channel.c and channel.h. *
  20786. Fixed some locking issues in CHANNEL(). (closes issue
  20787. ASTERISK-20383) Reported by: rmudgett (closes issue
  20788. ASTERISK-20384) Reported by: rmudgett (closes issue
  20789. ASTERISK-20386) Reported by: rmudgett Tested by: rmudgett Review:
  20790. https://reviewboard.asterisk.org/r/2112/ ........ Merged
  20791. revisions 373220 from
  20792. http://svn.asterisk.org/svn/asterisk/branches/11
  20793. 2012-09-20 13:04 +0000 [r373212] Kinsey Moore <kmoore@digium.com>
  20794. * /, channels/chan_sip.c: Correct handling of unknown SDP stream
  20795. types When the patch to handle arbitrary SDP stream arrangements
  20796. went into Asterisk, it also included an ability to transparently
  20797. decline unknown stream types. The scanf calls used were not
  20798. checked properly causing this part of the functionality to be
  20799. broken. (closes issue ASTERISK-20203) ........ Merged revisions
  20800. 373211 from http://svn.asterisk.org/svn/asterisk/branches/11
  20801. 2012-09-20 11:05 +0000 [r373203] Sean Bright <sean@malleable.com>
  20802. * res/res_curl.c: When trying to unload res_curl.so, warn about all
  20803. dependent modules. Before this, attempting to unload res_curl.so
  20804. would warn you about the first module it found that was
  20805. dependent. We now warn about all of the loaded modules instead.
  20806. 2012-09-20 10:41 +0000 [r373188-373202] Alec L Davis <sivad.a@paradise.net.nz>
  20807. * main/dsp.c: dsp.c: remove whitespace mentioned in review2107
  20808. Related https://reviewboard.asterisk.org/r/2107/
  20809. * CHANGES, apps/app_queue.c, configs/extensions.conf.sample:
  20810. app_queue: Support an 'agent available' hint Sets INUSE when no
  20811. free agents, NOT_INUSE when an agent is free. modifes
  20812. handle_statechange() scan members loop to scan for a free agent
  20813. and updates the Queue:queuename_avial devstate. Previously exited
  20814. early if the member was found in the queue. Now Exits later when
  20815. both a member was found, and a free agent was found. alecdavis
  20816. (license 585) Reported by: Alec Davis Tested by: alecdavis
  20817. Review: https://reviewboard.asterisk.org/r/2121/
  20818. 2012-09-18 20:19 +0000 [r373134-373142] Sean Bright <sean@malleable.com>
  20819. * main/logger.c: Make the casing of CALL_ID in debug messages
  20820. consistent to satisfy my OCD.
  20821. * main/manager.c, /: Don't crash when passing a NULL message to
  20822. __astman_get_header. Before this commit, __astman_get_header
  20823. would blindly dereference the passed in 'struct message *' to
  20824. traverse the header list. There are cases, however, such as
  20825. '*CLI> sip qualify peer foo' where the message pointer is NULL,
  20826. so we need to check for that. ........ Merged revisions 373131
  20827. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  20828. Merged revisions 373132 from
  20829. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20830. revisions 373133 from
  20831. http://svn.asterisk.org/svn/asterisk/branches/11
  20832. 2012-09-18 15:50 +0000 [r373120] David M. Lee <dlee@digium.com>
  20833. * /, configure, include/asterisk/autoconfig.h.in, configure.ac,
  20834. makeopts.in, Makefile, include/asterisk/utils.h: Add
  20835. -fnested-functions compile flag, if needed. In order to use
  20836. nested functions on some versions of GCC (e.g. GCC on OS X), the
  20837. -fnested-functions flag must be passed to the compiler. This
  20838. patch adds detection logic to ./configure to add the flag if
  20839. necessary. It also adds a comment to utils.h as to why the nested
  20840. function needs a prototype. (closes issue ASTERISK-20399)
  20841. Reported by: David M. Lee Review:
  20842. https://reviewboard.asterisk.org/r/2102/ ........ Merged
  20843. revisions 373119 from
  20844. http://svn.asterisk.org/svn/asterisk/branches/11
  20845. 2012-09-15 00:32 +0000 [r373108] Richard Mudgett <rmudgett@digium.com>
  20846. * channels/sig_ss7.c, /: Made companding law for SS7 calls only
  20847. determined by SS7 signaling type. For SS7, the companding law for
  20848. a call was chosen inconsistently depending upon ss7type (ITU vs
  20849. ANSI) and the DAHDI companding default (T1 vs E1). For incoming
  20850. calls, the companding law was determined by ss7type. For outgoing
  20851. calls, the companding law was determined by the DAHDI default.
  20852. With the wrong combination you would get A-law/u-law conflicts.
  20853. An A-law/u-law conflict sounds like bad static on the line. SS7
  20854. ITU signaling with E1 line: ok SS7 ITU signaling with T1 line:
  20855. noise SS7 ANSI signaling with E1 line: noise SS7 ANSI signaling
  20856. with T1 line: ok * Fix the companding law used to be determined
  20857. by the SS7 signaling type only. ........ Merged revisions 373090
  20858. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  20859. Merged revisions 373101 from
  20860. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20861. revisions 373107 from
  20862. http://svn.asterisk.org/svn/asterisk/branches/11
  20863. 2012-09-14 19:53 +0000 [r373080] Matthew Jordan <mjordan@digium.com>
  20864. * main/libasteriskssl.c, main/tcptls.c, /, channels/chan_sip.c:
  20865. Resolve memory leaks in TLS initialization and TLS client
  20866. connections This patch resolves two sources of memory leaks when
  20867. using TLS in Asterisk: 1) It removes improper initialization (and
  20868. multiple re-initializations) of portions of the SSL library.
  20869. Asterisk calls SSL_library_init and SSL_load_error_strings during
  20870. SSL initialization; collectively this obviates the need for
  20871. calling any of the following during initialization or client
  20872. connection handling: * ERR_load_crypto_strings (handled by
  20873. SSL_load_error_strings) * OpenSSL_add_all_algorithms (synonym for
  20874. SSL_library_init) * SSLeay_add_ssl_algorithms (synonym for
  20875. SSL_library_init) 2) Failure to completely clean up all memory
  20876. allocated by Asterisk and by the SSL library for TLS clients.
  20877. This included not freeing the SSL_CTX object in the SIP channel
  20878. driver, as well as not clearing the error stack when the TLS
  20879. client exited. Note that these memory leaks were found by Thomas
  20880. Arimont, and this patch was essentially written by him with some
  20881. minor tweaks. (closes issue AST-889) Reported by: Thomas Arimont
  20882. Tested by: Thomas Arimont patches: (bugAST-889.patch) by Thomas
  20883. Arimont (license 5525) Review:
  20884. https://reviewboard.asterisk.org/r/2105 ........ Merged revisions
  20885. 373061 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  20886. ........ Merged revisions 373062 from
  20887. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20888. revisions 373079 from
  20889. http://svn.asterisk.org/svn/asterisk/branches/11
  20890. 2012-09-13 20:05 +0000 [r373046-373048] David M. Lee <dlee@digium.com>
  20891. * /, main/Makefile: Fixed make clean when configured
  20892. --disable-asteriskssl ........ Merged revisions 373047 from
  20893. http://svn.asterisk.org/svn/asterisk/branches/11
  20894. * main/channel.c, /, include/asterisk/channel.h: Fix timeouts for
  20895. ast_waitfordigit[_full]. ast_waitfordigit_full would simply pass
  20896. its timeout to ast_waitfor_nandfds, expecting it to decrement the
  20897. timeout by however many milliseconds were waited. This is a
  20898. problem if it consistently waits less than 1ms. The timeout will
  20899. never be decremented, and we wait... FOREVER! This patch makes
  20900. ast_waitfordigit_full manage the timeout itself. It maintains the
  20901. previously undocumented behavior that negative timeouts wait
  20902. forever. (closes issue ASTERISK-20375) Reported by: Mark
  20903. Michelson Tested by: Mark Michelson Review:
  20904. https://reviewboard.asterisk.org/r/2109/ ........ Merged
  20905. revisions 373024 from
  20906. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20907. revisions 373025 from
  20908. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20909. revisions 373029 from
  20910. http://svn.asterisk.org/svn/asterisk/branches/11
  20911. 2012-09-12 21:02 +0000 [r372997] Richard Mudgett <rmudgett@digium.com>
  20912. * main/astobj2.c, main/channel.c, include/asterisk/astobj2.h,
  20913. tests/test_astobj2.c: Enhance astobj2 to support other types of
  20914. containers. The new API allows for sorted containers, insertion
  20915. options, duplicate handling options, and traversal order options.
  20916. * Adds the ability for containers to be sorted when they are
  20917. created. * Adds container creation options to handle duplicates
  20918. when they are inserted. * Adds container creation option to
  20919. insert objects at the beginning or end of the container traversal
  20920. order. * Adds OBJ_PARTIAL_KEY to allow searching with a partial
  20921. key. The partial key works similarly to the OBJ_KEY flag. (The
  20922. real search speed improvement with this flag will come when
  20923. red-black trees are added.) * Adds container traversal and
  20924. iteration order options: Ascending and Descending. * Adds an
  20925. AST_DEVMODE compile feature to check the stats and integrity of
  20926. registered containers using the CLI "astobj2 container stats
  20927. <name>" and "astobj2 container check <name>". The channels
  20928. container is normally registered since it is one of the most
  20929. important containers in the system. * Adds ao2_iterator_restart()
  20930. to allow iteration to be restarted from the beginning. * Changes
  20931. the generic container object to have a v_method table pointer to
  20932. support other types of containers. * Changes the container nodes
  20933. holding objects to be ref counted. The ref counted nodes and
  20934. v_method table pointer changes pave the way to allow other types
  20935. of containers. * Includes a large astobj2 unit test enhancement
  20936. that tests the new features. (closes issue ASTERISK-19969)
  20937. Reported by: rmudgett Review:
  20938. https://reviewboard.asterisk.org/r/2078/
  20939. 2012-09-12 20:54 +0000 [r372996] Joshua Colp <jcolp@digium.com>
  20940. * channels/chan_motif.c, /: Skip any non-content information when
  20941. looking for and handling content. This fixes a bug with Jitsi and
  20942. conference calling. Jitsi implements XEP-0298 which places some
  20943. conference-info information in the session-initiate request which
  20944. chan_motif did not expect to occur. ........ Merged revisions
  20945. 372995 from http://svn.asterisk.org/svn/asterisk/branches/11
  20946. 2012-09-12 18:33 +0000 [r372976-372985] Jonathan Rose <jrose@digium.com>
  20947. * /, res/res_xmpp.c: res_xmpp: Fix a segfault caused by bodyless
  20948. messages (closes issue ASTERISK-20361) Reported by: Noah
  20949. Engelberth Review: https://reviewboard.asterisk.org/r/2108/
  20950. ........ Merged revisions 372984 from
  20951. http://svn.asterisk.org/svn/asterisk/branches/11
  20952. * configs/logger.conf.sample, main/logger.c: logger: Add
  20953. rotatestrategy option of 'none' which does not perform rotations
  20954. With this option in use, it may be necessary to regulate your log
  20955. files externally. (closes issue ASTERISK-20189) Reported by: Jaco
  20956. Kroon Patches: asterisk-logger-norotate-trunk.patch uploaded by
  20957. Jaco Kroon (license 5671)
  20958. 2012-09-12 15:21 +0000 [r372943] Mark Michelson <mmichelson@digium.com>
  20959. * /, channels/chan_sip.c: Add channel name to a warning to make
  20960. debugging easier. The "autodestruct with owner in place" message
  20961. is typically indicative of a channel reference leak. Printing out
  20962. the name of the channel in the message may be helpful when trying
  20963. to debug the issue. ........ Merged revisions 372932 from
  20964. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20965. revisions 372933 from
  20966. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20967. revisions 372937 from
  20968. http://svn.asterisk.org/svn/asterisk/branches/11
  20969. 2012-09-12 14:22 +0000 [r372931] David M. Lee <dlee@digium.com>
  20970. * /, main/Makefile: Fixed r372696 when configured
  20971. --disable-asteriskssl; properly install libasteriskssl.dylib on
  20972. OS X. I didn't realize that libasteriskssl.c was still compiled,
  20973. even when you disable asteriskssl; it simple gets statically
  20974. linked into asterisk. ........ Merged revisions 372930 from
  20975. http://svn.asterisk.org/svn/asterisk/branches/11
  20976. 2012-09-11 22:40 +0000 [r372918] Jonathan Rose <jrose@digium.com>
  20977. * channels/chan_local.c, /: chan_local: Switch from using a random
  20978. 4 digit hex identifier to unique id Changes chan_local channels
  20979. to use an 8 digit hex identifier generated atomically and
  20980. sequentially in order to eliminate the chance of having multiple
  20981. channels with the same name during high call volume situations.
  20982. (issue ASTERISK-20318) Reported by: Dan Cropp Review:
  20983. https://reviewboard.asterisk.org/r/2104/ ........ Merged
  20984. revisions 372902 from
  20985. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  20986. revisions 372916 from
  20987. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  20988. revisions 372917 from
  20989. http://svn.asterisk.org/svn/asterisk/branches/11
  20990. 2012-09-11 21:17 +0000 [r372887-372891] Mark Michelson <mmichelson@digium.com>
  20991. * include/asterisk/_private.h, main/message.c, main/asterisk.c, /:
  20992. Fix inability to shutdown gracefully due to an unending channel
  20993. reference. message.c makes use of a special message queue channel
  20994. that exists in thread storage. This channel never goes away due
  20995. to the fact that the taskprocessor used by message.c does not get
  20996. shut down, meaning that it never ends the thread that stores the
  20997. channel. This patch fixes the problem by shutting down the
  20998. taskprocessor when Asterisk is shut down. In addition, the thread
  20999. storage has a destructor that will release the channel reference
  21000. when the taskprocessor is destroyed. (closes issue AST-937)
  21001. Reported by Jason Parker Patches: AST-937.patch uploaded by Mark
  21002. Michelson (License #5049) Tested by Jason Parker ........ Merged
  21003. revisions 372885 from
  21004. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21005. revisions 372888 from
  21006. http://svn.asterisk.org/svn/asterisk/branches/11
  21007. * main/features.c, /: Fix bad channel application data reference.
  21008. When channels get bridged due to an AMI bridge action or a DTMF
  21009. attended transfer, the two channels that get bridged have their
  21010. application data pointing to the other channel's name. This means
  21011. that if one channel is hung up but the other moves on, it means
  21012. that the channel that moves on will have its application data
  21013. pointing at freed memory. (issue ASTERISK-20335) Reported by:
  21014. aragon ........ Merged revisions 372840 from
  21015. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21016. revisions 372841 from
  21017. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21018. revisions 372886 from
  21019. http://svn.asterisk.org/svn/asterisk/branches/11
  21020. 2012-09-11 18:09 +0000 [r372874] David M. Lee <dlee@digium.com>
  21021. * Makefile, /: Corrects the astsbindir setting when installing the
  21022. sample asterisk.conf. (closes issue ASTERISK-20406) ........
  21023. Merged revisions 372863 from
  21024. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21025. revisions 372864 from
  21026. http://svn.asterisk.org/svn/asterisk/branches/11
  21027. 2012-09-11 14:43 +0000 [r372808-372832] Jonathan Rose <jrose@digium.com>
  21028. * UPGRADE.txt, CHANGES: chan_sip: Fix CHANGES and UPGRADE.txt for
  21029. r372808 (issue AST-969) Reported by John Bigelow
  21030. * channels/chan_sip.c: chan_sip: Change SIPQualifyPeer to improve
  21031. initial response time Prior to this patch, The acknowledgement
  21032. wasn't produced until after executing the sip_poke_peer action
  21033. actually responsible for qualifying the peer. Now the response is
  21034. given immediately once it is known that a peer will be qualified
  21035. and a SIPqualifypeerdone event is issued when the process is
  21036. finished. Thanks to OEJ for identifying the problem and helping
  21037. to come up with a solution. (issue AST-969) Reported by John
  21038. Bigelow Review: https://reviewboard.asterisk.org/r/2098/
  21039. 2012-09-10 21:00 +0000 [r372796-372807] Kinsey Moore <kmoore@digium.com>
  21040. * channels/chan_iax2.c, /: Ensure iax2 debug output is displayed
  21041. when expected When IAX2 debug was changed from iax_showframe to
  21042. iax_outputframe, some instances were missed (or added afterward).
  21043. This was causing debug output to not be displayed when expected.
  21044. (closes issue ASTERISK-20338) Reported-by: John Covert Patch-by:
  21045. John Covert ........ Merged revisions 372804 from
  21046. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21047. revisions 372805 from
  21048. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21049. revisions 372806 from
  21050. http://svn.asterisk.org/svn/asterisk/branches/11
  21051. * /, main/devicestate.c, channels/chan_gtalk.c, res/res_jabber.c,
  21052. channels/chan_jingle.c, include/asterisk/doxygen/architecture.h:
  21053. Deprecate chan_gtalk, chan_jingle, and res_jabber chan_gtalk,
  21054. chan_jingle, and res_jabber are now deprecated in favor of using
  21055. chan_motif and res_xmpp. They are a feature-equivalent
  21056. replacement and are written to be more easily maintainable.
  21057. (closes issue ASTERISK-20298) Review:
  21058. https://reviewboard.asterisk.org/r/2082/ Reported-by: Leif Madsen
  21059. ........ Merged revisions 372795 from
  21060. http://svn.asterisk.org/svn/asterisk/branches/11
  21061. 2012-09-10 19:22 +0000 [r372787] David M. Lee <dlee@digium.com>
  21062. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Eliminate
  21063. "type-punned pointer" build warning. Removes
  21064. "res_rtp_asterisk.c:706: warning: dereferencing type-punned
  21065. pointer will break strict-aliasing rules" warning from the build
  21066. on 32-bit platforms. The problem is that 'size' was referenced
  21067. aliased to both (pj_size_t *) and (pj_ssize_t *). Now just make a
  21068. copy of size that is the right type so there isn't any pointer
  21069. aliasing happening. It also adds comments and asserts regarding
  21070. what looks like an inappropriate use of pj_sock_sendto, but is
  21071. actually totally fine. (closes issue ASTERISK-20368) Reported by:
  21072. Shaun Ruffell Tested by: Michael L. Young Patches:
  21073. 0001-res_rtp_asterisk-Eliminate-type-punned-pointer-build.patch
  21074. uploaded by Shaun Ruffell (license 5417) slightly modified by
  21075. David M. Lee. ........ Merged revisions 372777 from
  21076. http://svn.asterisk.org/svn/asterisk/branches/11
  21077. 2012-09-10 18:58 +0000 [r372755-372769] Jonathan Rose <jrose@digium.com>
  21078. * /, apps/app_meetme.c: app_meetme: Document that 'p' option will
  21079. continue in dialplan. (closes issue AST-991) Reported by John
  21080. Bigelow ........ Merged revisions 372765 from
  21081. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21082. revisions 372767 from
  21083. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21084. revisions 372768 from
  21085. http://svn.asterisk.org/svn/asterisk/branches/11
  21086. * /, main/channel.c: Masquerade: Retain parkinglot settings made by
  21087. CHANNEL function. Prior to this patch, the user would have a
  21088. parkinglot set on a channel that was parked and when the channel
  21089. was retrieved, any attempt by that channel to park would simply
  21090. use the default. This patch makes parkinglot values set in this
  21091. way be retained through the masquerade. (closes issue AST-990)
  21092. Reported by: Nick Huskinson Patches:
  21093. masquerade_parkinglot_patch.diff Uploaded by Jonathan Rose
  21094. (license 6182) ........ Merged revisions 372736 from
  21095. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21096. revisions 372737 from
  21097. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21098. revisions 372754 from
  21099. http://svn.asterisk.org/svn/asterisk/branches/11
  21100. 2012-09-09 01:28 +0000 [r372712] Matthew Jordan <mjordan@digium.com>
  21101. * channels/sip/sdp_crypto.c, /: Only re-create an SRTP session when
  21102. needed In r356604, SRTP handling was fixed to accomodate multiple
  21103. crypto keys in an SDP offer and the ability to re-create an SRTP
  21104. session when the crypto keys changed. In certain circumstances -
  21105. most notably when a phone is put on hold after having been
  21106. bridged for a significant amount of time - the act of re-creating
  21107. the SRTP session causes problems for certain models of phones.
  21108. The patch committed in r356604 always re-created the SRTP session
  21109. regardless of whether or not the cryptographic keys changed.
  21110. Since this is technically not necessary, this patch modifies the
  21111. behavior to only re-create the SRTP session if Asterisk detects
  21112. that the remote key has changed. This allows models of phones
  21113. that do not handle the SRTP session changing to continue to work,
  21114. while also providing the behavior needed for those phones that do
  21115. re-negotiate cryptographic keys. (issue ASTERISK-20194) Reported
  21116. by: Nicolo Mazzon Tested by: Nicolo Mazzon Review:
  21117. https://reviewboard.asterisk.org/r/2099 ........ Merged revisions
  21118. 372709 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  21119. ........ Merged revisions 372710 from
  21120. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21121. revisions 372711 from
  21122. http://svn.asterisk.org/svn/asterisk/branches/11
  21123. 2012-09-08 06:18 +0000 [r372699] David M. Lee <dlee@digium.com>
  21124. * /, main/Makefile: Add OPENSSL_INCLUDE to the CFLAGS for ssl.c and
  21125. tcptls.c. Without this flag, those files will compile with the
  21126. system installed OpenSSL headers (if they exist). This is a real
  21127. bummer if a different path was specified using --with-ssl=
  21128. (closes issue ASTERISK-20392) ........ Merged revisions 372682
  21129. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  21130. Recorded merge of revisions 372695 from
  21131. http://svn.asterisk.org/svn/asterisk/branches/10 ........
  21132. Recorded merge of revisions 372696 from
  21133. http://svn.asterisk.org/svn/asterisk/branches/11
  21134. 2012-09-07 23:10 +0000 [r372623-372658] Richard Mudgett <rmudgett@digium.com>
  21135. * /, main/astmm.c: Fix MALLOC_DEBUG version of ast_strndup().
  21136. (closes issue ASTERISK-20349) Reported by: Brent Eagles ........
  21137. Merged revisions 372655 from
  21138. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21139. revisions 372656 from
  21140. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21141. revisions 372657 from
  21142. http://svn.asterisk.org/svn/asterisk/branches/11
  21143. * /, funcs/func_math.c: Remove annoying unconditional debug message
  21144. from INC/DEC functions. (closes issue AST-1001) Reported by:
  21145. Guenther Kelleter ........ Merged revisions 372628 from
  21146. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21147. revisions 372629 from
  21148. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21149. revisions 372630 from
  21150. http://svn.asterisk.org/svn/asterisk/branches/11
  21151. * apps/app_queue.c, /: Fix exception path typo in app_queue.c
  21152. try_calling(). (closes issue ASTERISK-20380) Reported by: Jeremy
  21153. Pepper Patches: fix-local-channel-locking.patch (license #6350)
  21154. patch uploaded by Jeremy Pepper ........ Merged revisions 372624
  21155. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  21156. Merged revisions 372625 from
  21157. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21158. revisions 372626 from
  21159. http://svn.asterisk.org/svn/asterisk/branches/11
  21160. * apps/app_voicemail.c, /: Fix VoicemailUserEntry event headers
  21161. ServerEmail and MailCommand reported values. The AMI action
  21162. VoicemailUsersList VoicemailUserEntry event headers ServerEmail
  21163. and MailCommand did not report the global values if they were not
  21164. overridden. The VoicemailUserEntry event header ServerEmail was
  21165. not populated with the global value if the voicemail user did not
  21166. override it. The VoicemailUserEntry event header MailCommand was
  21167. never populated with a value. * Removed unused struct ast_vm_user
  21168. member mailcmd[]. (closes issue AST-973) Reported by: John
  21169. Bigelow Tested by: rmudgett ........ Merged revisions 372620 from
  21170. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21171. revisions 372621 from
  21172. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21173. revisions 372622 from
  21174. http://svn.asterisk.org/svn/asterisk/branches/11
  21175. 2012-09-07 21:04 +0000 [r372610-372612] David M. Lee <dlee@digium.com>
  21176. * res/pjproject/pjmedia/lib, codecs/ilbc,
  21177. res/pjproject/pjlib-util/lib, res/pjproject/pjmedia/bin,
  21178. res/pjproject/third_party/gsm/lib,
  21179. res/pjproject/third_party/gsm/bin, res/pjproject/pjnath/lib,
  21180. res/pjproject/pjsip/lib, res/pjproject/pjsip-apps/lib,
  21181. res/pjproject/pjsip/bin, res/pjproject/pjsip-apps/bin,
  21182. res/pjproject/third_party/lib, res/pjproject/third_party/bin,
  21183. res/pjproject/lib, res/pjproject/pjlib/lib, /: svn:ignore
  21184. cleanup. * pjproject bin and lib directories should pretty much
  21185. ignore everything * Ignore *.o in codecs/ilbc ........ Merged
  21186. revisions 372611 from
  21187. http://svn.asterisk.org/svn/asterisk/branches/11
  21188. * /, res/Makefile: Fix parallel make for res_asterisk_rtp. Fixes a
  21189. build regression introduced in r369517 "Add support for
  21190. ICE/STUN/TURN in res_rtp_asterisk and chan_sip." [1]. [1]
  21191. http://svnview.digium.com/svn/asterisk?view=revision&revision=369517
  21192. When compiling asterisk in parallel like: $ make -j 10 It's
  21193. possible to get errors like the following:
  21194. .pjlib-util-test-x86_64-unknown-linux-gnu.depend:120: *** missing
  21195. separator. Stop. make[4]: *** [depend] Error 2 make[3]: *** [dep]
  21196. Error 1 make[2]: ***
  21197. [/home/sruffell/asterisk-working/res/pjproject/pjnath/lib/libpjnath-x86_64-unknown-linux-gnu.a]
  21198. Error 2 make[3]: warning: jobserver unavailable: using -j1. Add
  21199. `+' to parent make rule. This is because the build system is
  21200. trying to build each of the libraries in pjproject in parallel.
  21201. Now the build will build pjproject in a single job and link the
  21202. results into res_asterisk_rtp. Parallel builds, on one test
  21203. system, saves ~1.5 minutes from a default Asterisk build: Single
  21204. job: $ git clean -fdx >/dev/null && time ( ./configure >/dev/null
  21205. 2>&1 && make >/dev/null 2>&1 ) real 2m34.529s user 1m41.810s sys
  21206. 0m15.970s Parallel make: $ git clean -fdx >/dev/null && time (
  21207. ./configure >/dev/null 2>&1 && make -j10 >/dev/null 2>&1 ) real
  21208. 1m2.353s user 2m39.120s sys 0m18.850s (closes issue
  21209. ASTERISK-20362) Reported by: Shaun Ruffel Patches:
  21210. 0001-res_asterisk_rtp-Fix-build-error-when-using-parallel.patch
  21211. uploaded by Shaun Ruffel (License #5417) ........ Merged
  21212. revisions 372609 from
  21213. http://svn.asterisk.org/svn/asterisk/branches/11
  21214. 2012-09-07 02:27 +0000 [r372538-372584] Matthew Jordan <mjordan@digium.com>
  21215. * /, apps/app_minivm.c: Free ast_str objects when temp file fails
  21216. to be created in MiniVM The previous commit (r372554) was from a
  21217. patch that was written before r366880, which ensured that ast_str
  21218. objects allocated in the sendmail routine were free'd in off
  21219. nominal paths. This commit frees the string objects in the off
  21220. nominal path introduced in r372554. (issue ASTERISK-17133)
  21221. Reported by: Tzafrir Cohen ........ Merged revisions 372581 from
  21222. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21223. revisions 372582 from
  21224. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21225. revisions 372583 from
  21226. http://svn.asterisk.org/svn/asterisk/branches/11
  21227. * /, apps/app_minivm.c: Fix file descriptor leak and pointer scope
  21228. issue in MiniVM when sending mail When MiniVM sends an e-mail and
  21229. it has the volgain option set, it will spawn sox in a separate
  21230. process to handle the manipulation of the sound file. In doing
  21231. so, it creates a temporary file. There are two problems here: 1)
  21232. The file descriptor returned from mkstemp is leaked 2) The
  21233. finalfilename character pointer points to a buffer that loses
  21234. scope once volgain processing is finished. Note that in r316265,
  21235. Russell fixed some gcc warnings by using the return value of the
  21236. mkstemp call. A warning was placed in minivm that the file
  21237. descriptor was going to be leaked. This patch reverts that
  21238. change, as it handles the leak and 'uses' the file descriptor
  21239. returned from mkstemp. (closes issue ASTERISK-17133) Reported by:
  21240. Tzafrir Cohen patches: minivm_18501_demo.diff uploaded by Tzafrir
  21241. Cohen (license #5035) ........ Merged revisions 372554 from
  21242. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21243. revisions 372555 from
  21244. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21245. revisions 372556 from
  21246. http://svn.asterisk.org/svn/asterisk/branches/11
  21247. * /, apps/app_queue.c: Update QueueMemberStatus event documentation
  21248. to include member status values The Status: header in a
  21249. QueueMemberStatus event (and other QueueMember* events) is the
  21250. numeric value of the device state corresponding to that Queue
  21251. Member. As those values are not exactly obvious, listing them in
  21252. the documentation is useful. Matt Riddell reported this
  21253. indirectly through the wiki page. (closes issue ASTERISK-20243)
  21254. Reported by: Matt Riddell ........ Merged revisions 372531 from
  21255. http://svn.asterisk.org/svn/asterisk/branches/11
  21256. 2012-09-06 22:14 +0000 [r372524] Richard Mudgett <rmudgett@digium.com>
  21257. * channels/sig_pri.c, /: Fix loss of MOH on an ISDN channel when
  21258. parking a call for the second time. Using the AMI redirect action
  21259. to take an ISDN call out of a parking lot causes the MOH state to
  21260. get confused. The redirect action does not take the call off of
  21261. hold. When the call is subsequently parked again, the call no
  21262. longer hears MOH. * Make chan_dahdi/sig_pri restart MOH on
  21263. repeated AST_CONTROL_HOLD frames if it is already in a state
  21264. where it is supposed to be sending MOH. The MOH may have been
  21265. stopped by other means. (Such as killing the generator.) This
  21266. simple fix is done rather than making the AMI redirect action
  21267. post an AST_CONTROL_UNHOLD unconditionally when it redirects a
  21268. channel and thus potentially breaking something with an
  21269. unexpected AST_CONTROL_UNHOLD. (closes issue ABE-2873) Patches:
  21270. jira_abe_2873_c.3_bier.patch (license #5621) patch uploaded by
  21271. rmudgett ........ Merged revisions 372521 from
  21272. https://origsvn.digium.com/svn/asterisk/be/branches/C.3-bier
  21273. ........ Merged revisions 372522 from
  21274. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21275. revisions 372523 from
  21276. http://svn.asterisk.org/svn/asterisk/branches/11
  21277. 2012-09-06 21:43 +0000 [r372520] Kinsey Moore <kmoore@digium.com>
  21278. * /, apps/app_queue.c: Ensure listed queues are not offered for
  21279. completion When using tab-completion for the list of queues on
  21280. "queue reset stats" or "queue reload
  21281. {all|members|parameters|rules}", the tab-completion listing for
  21282. further queues erroneously listed queues that had already been
  21283. added to the list. The tab-completion listing now only displays
  21284. queues that are not already in the list. (closes issue AST-963)
  21285. Reported-by: John Bigelow ........ Merged revisions 372517 from
  21286. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21287. revisions 372518 from
  21288. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21289. revisions 372519 from
  21290. http://svn.asterisk.org/svn/asterisk/branches/11
  21291. 2012-09-06 15:57 +0000 [r372474] Jonathan Rose <jrose@digium.com>
  21292. * /, UPGRADE-1.8.txt: chan_sip: Note change in behavior to how
  21293. directmediapermit/deny ACL works r366547 introduced a change to
  21294. the directmedia ACL for chan_sip which modified the behavior
  21295. significantly. Prior to the patch, this option would bridge peers
  21296. with directmedia if a peer's IP address matched its own
  21297. directmedia ACL. After that patch, the peer would check the
  21298. bridged peer's ACL instead. This change has been present since
  21299. 1.8.14.0. That patched failed to document the change in
  21300. Upgrade.txt, so this patch adds mention of that change to
  21301. UPGRADE.txt (UPGRADE-1.8.txt in newer branches) (issue AST-876)
  21302. ........ Merged revisions 372471 from
  21303. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21304. revisions 372472 from
  21305. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21306. revisions 372473 from
  21307. http://svn.asterisk.org/svn/asterisk/branches/11
  21308. 2012-09-06 14:31 +0000 [r372447] Kinsey Moore <kmoore@digium.com>
  21309. * /, apps/app_queue.c: Ensure "rules" is tab-completable for "queue
  21310. show" Previously, tabbing at the end of "queue show" produced a
  21311. list of available queues about which information could be shown,
  21312. but did not include an alternative command, "rules", to access
  21313. information about queue rules. The "rules" item should now be
  21314. shown in the list of tab-completable items. (closes issue
  21315. AST-958) Reported-by: John Bigelow ........ Merged revisions
  21316. 372444 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  21317. ........ Merged revisions 372445 from
  21318. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21319. revisions 372446 from
  21320. http://svn.asterisk.org/svn/asterisk/branches/11
  21321. 2012-09-06 02:52 +0000 [r372393-372420] Matthew Jordan <mjordan@digium.com>
  21322. * /, pbx/pbx_dundi.c: Fix DUNDi message routing bug when
  21323. neighboring peer is unreachable Consider a scenario where DUNDi
  21324. peer PBX1 has two peers that are its neighbors, PBX2 and PBX3,
  21325. and where PBX2 and PBX3 are also neighbors. If the connection is
  21326. temporarily broken between PBX1 and PBX3, PBX1 should not include
  21327. PBX3 in the list of peers it sends to PBX2 in a DPDISCOVER
  21328. message, as it cannot send messages to PBX3. If it does, PBX2
  21329. will assume that PBX3 already received the message and fail to
  21330. forward the message on to PBX3 itself. This patch fixes this by
  21331. only including peers in a DPDISCOVER message that are reachable
  21332. by the sending node. This includes all peers with an empty
  21333. address (00:00:00:00:00:00) and that are have been reached by a
  21334. qualify message. This patch also prevents attempting to qualify a
  21335. dynamic peer with an empty address until that peer registers. The
  21336. patch uploaded by Peter was modified slightly for this commit.
  21337. (closes issue ASTERISK-19309) Reported by: Peter Racz patches:
  21338. dundi_routing.patch uploaded by Peter Racz (license 6290)
  21339. ........ Merged revisions 372417 from
  21340. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21341. revisions 372418 from
  21342. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21343. revisions 372419 from
  21344. http://svn.asterisk.org/svn/asterisk/branches/11
  21345. * /, apps/app_followme.c: Allow configured numbers for FollowMe to
  21346. be greater than 90 characters When parsing a 'number' defined in
  21347. followme.conf, FollowMe previously parsed the number in the
  21348. configuration file into a buffer with a length of 90 characters.
  21349. This can artificially limit some parallel dial scenarios. This
  21350. patch allows for numbers of any length to be defined in the
  21351. configuration file. Note that Clod Patry originally wrote a patch
  21352. to fix this problem and received a Ship It! on the JIRA issue.
  21353. The patch originally expanded the buffer to 256 characters.
  21354. Instead, the patch being committed duplicates the string in the
  21355. config file on the stack before parsing it for consumption by the
  21356. application. (closes issue ASTERISK-16879) Reported by: Clod
  21357. Patry Tested by: mjordan patches: followme_no_limit.diff uploaded
  21358. by Clod Patry (license #5138) Slightly modified for this commit.
  21359. ........ Merged revisions 372390 from
  21360. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21361. revisions 372391 from
  21362. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21363. revisions 372392 from
  21364. http://svn.asterisk.org/svn/asterisk/branches/11
  21365. 2012-09-05 19:44 +0000 [r372374] Richard Mudgett <rmudgett@digium.com>
  21366. * /: Recorded merge of revisions 372373 from
  21367. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Fix
  21368. compile error. ........ Merged revisions 372372 from
  21369. http://svn.asterisk.org/svn/asterisk/branches/10
  21370. 2012-09-05 19:26 +0000 [r372344-372371] Kinsey Moore <kmoore@digium.com>
  21371. * main/manager.c, /: Correct documentation for ModuleLoad AMI
  21372. action The documentation incorrectly listed 'rtp' as a reloadable
  21373. subsystem and left out many other reloadable subsystems. It is
  21374. now also documented that subsystems may only be reloaded, not
  21375. loaded or unloaded. (closes issue AST-977) Reported-by: John
  21376. Bigelow ........ Merged revisions 372354 from
  21377. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21378. revisions 372358 from
  21379. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21380. revisions 372365 from
  21381. http://svn.asterisk.org/svn/asterisk/branches/11
  21382. * main/pbx.c, /: Ensure counts generated in
  21383. manager_show_dialplan_helper are correct When
  21384. manager_show_dialplan_helper was written, the counter increment
  21385. for the total number of contexts was placed with the extensions
  21386. increment instead of in the enclosing loop. This function should
  21387. now generate correct context counts. (closes issue AST-970)
  21388. Reported-by: John Bigelow ........ Merged revisions 372337 from
  21389. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21390. revisions 372338 from
  21391. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21392. revisions 372340 from
  21393. http://svn.asterisk.org/svn/asterisk/branches/11
  21394. 2012-09-05 18:56 +0000 [r372343] Alec L Davis <sivad.a@paradise.net.nz>
  21395. * /, main/dsp.c: dsp.c: in ast_mf_detect_init incorrectly sets
  21396. goertzel samples to 160, should be MF_GSIZE Remove unused
  21397. goertzel_state_t member 'samples'. Related
  21398. https://reviewboard.asterisk.org/r/2097/
  21399. 2012-09-05 17:38 +0000 [r372329] Richard Mudgett <rmudgett@digium.com>
  21400. * res/res_rtp_asterisk.c, /: Multiple revisions 372327-372328
  21401. ........ r372327 | rmudgett | 2012-09-05 12:33:11 -0500 (Wed, 05
  21402. Sep 2012) | 15 lines Fix RTP/RTCP read error message confusion.
  21403. The RTP/RTCP read error message can report "fail: success" when
  21404. the read failure is because of an ICE failure. * Changed
  21405. __rtp_recvfrom() to generate a PJ ICE message when ICE fails. *
  21406. Changed RTP/RTCP read error message to indicate an unspecified
  21407. error when errno is zero. (closes issue ASTERISK-20288) Reported
  21408. by: Joern Krebs Patches: jira_asterisk_20288_err_msg.patch
  21409. (license #5621) patch uploaded by rmudgett (modified) ........
  21410. r372328 | rmudgett | 2012-09-05 12:35:20 -0500 (Wed, 05 Sep 2012)
  21411. | 1 line Fix coding guidelines issue with a recent commit.
  21412. ........ Merged revisions 372327-372328 from
  21413. http://svn.asterisk.org/svn/asterisk/branches/11
  21414. 2012-09-05 16:24 +0000 [r372310-372319] Mark Michelson <mmichelson@digium.com>
  21415. * main/rtp_engine.c, /, include/asterisk/rtp_engine.h,
  21416. res/res_rtp_asterisk.c: Re-fix sending unnegotiated payloads
  21417. during a P2P RTP bridge. The previous fix still would look in the
  21418. static_RTP_PT table, which is inappropriate since we specifically
  21419. want to find a codec that has been negotiated. (closes issue
  21420. ASTERISK-20296) reported by NITESH BANSAL Patches:
  21421. codec_negotiation.patch Uploaded by NITESH BANSAL (License #6418)
  21422. ........ Merged revisions 372311 from
  21423. http://svn.asterisk.org/svn/asterisk/branches/11
  21424. * apps/app_alarmreceiver.c: Add fixes and cleanup to
  21425. app_alarmreceiver. This work comes courtesy of Pedro Kiefer
  21426. (License #6407) The work was posted to review board by Kaloyan
  21427. Kovachev (License #5506) (closes issue ASTERISK-16668) Reported
  21428. by Grant Crawshay (closes issue ASTERISK-16694) Reported by Fred
  21429. van Lieshout (closes issue ASTERISK-18417) Reported by Kostas
  21430. Liakakis (closes issue ASTERISK-19435) Reported by Deon George
  21431. (closes issue ASTERISK-20157) Reported by Pedro Kiefer (closes
  21432. issue ASTERISK-20158) Reported by Pedro Kiefer (closes issue
  21433. ASTERISK-20224) Reported by Pedro Kiefer Review:
  21434. https://reviewboard.asterisk.org/r/2075
  21435. 2012-09-05 14:44 +0000 [r372302] Matthew Jordan <mjordan@digium.com>
  21436. * /, apps/app_voicemail.c: Fix memory leaks in app_voicemail when
  21437. using IMAP storage or realtime config This patch fixes two memory
  21438. leaks: 1. When find_user is called with NULL as its first
  21439. parameter, the voicemail user returned is allocated on the heap.
  21440. The inboxcount2 function uses find_user in such a fashion when
  21441. counting new messages, and fails to free the resulting voicemail
  21442. user object. 2. When populate_defaults is called on a voicemail
  21443. user, it wipes whatever flags have been set on the object by
  21444. copying over the global flags object. If the VM_ALLOCED flag was
  21445. ste on the voicemail user prior to doing so, that flag is
  21446. removed. This leaks the voicemail user when free_user is later
  21447. called. (closes issue ASTERISK-19155) Reported by: Filip Jenicek
  21448. patches: asterisk.patch2 uploaded by Filip Jenicek (license 6277)
  21449. Patch slightly modified for this commit. Review:
  21450. https://reviewboard.asterisk.org/r/2096 ........ Merged revisions
  21451. 372268 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  21452. ........ Merged revisions 372288 from
  21453. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21454. revisions 372289 from
  21455. http://svn.asterisk.org/svn/asterisk/branches/11
  21456. 2012-09-05 14:12 +0000 [r372290] Darren Sessions <dmsessions@gmail.com>
  21457. * channels/chan_sip.c, configs/res_ldap.conf.sample: LDAP Realtime
  21458. Peers Cannot Register Prior to 1.8, it was not necessary for an
  21459. explicit "type" to be set for an asterisk LDAP realtime peer. Now
  21460. the routine find_peer actually checks the type field during
  21461. registration and fails to find the peer if it is not set. The
  21462. attached patch makes the realtime type equal whatever type is
  21463. being searched for if the type is 0 upon return from routine
  21464. build_peer. (closes issue ASTERISK-17222) Reported by: John
  21465. Covert Patch by: David Vossel Tested by: Darren Sessions Review:
  21466. https://reviewboard.asterisk.org/r/2095/
  21467. 2012-09-05 12:18 +0000 [r372267] Michael L. Young <elgueromexicano@gmail.com>
  21468. * res/res_rtp_asterisk.c, /: Fix breakage caused by last merge.
  21469. Missing a variable for 11 and trunk. ........ Merged revisions
  21470. 372266 from http://svn.asterisk.org/svn/asterisk/branches/11
  21471. 2012-09-05 07:43 +0000 [r372215-372242] Alec L Davis <sivad.a@paradise.net.nz>
  21472. * main/dsp.c, /: dsp.c: Fix multiple issues when no-interdigit
  21473. delay is present, and fast DTMF 50ms/50ms Revert DTMF hit/miss
  21474. detector to original -r349249 method with some changes, remove
  21475. unnecessary; 1. reseting of hits=0, when no signal, only need to
  21476. set it once. 2. incrementing of hits, when the hit is the same as
  21477. the current hit. 3. setting of lasthit, when it's the same as
  21478. before. Change HITS_TO_BEGIN to 2, MISSES_TO_END to 3 & 3
  21479. spelling mistakes (closes issue ASTERISK-19610) alecdavis
  21480. (license 585) Reported by: Jean-Philippe Lord Tested by:
  21481. alecdavis Review: https://reviewboard.asterisk.org/r/2085/
  21482. ........ Merged revisions 372239 from
  21483. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21484. revisions 372240 from
  21485. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21486. revisions 372241 from
  21487. http://svn.asterisk.org/svn/asterisk/branches/11
  21488. * /, main/dsp.c: dsp.c: optimize goerztzel sample loops, in
  21489. dtmf_detect, mf_detect and tone_detect use a temporary short int
  21490. when repeatedly used to call goertzel_sample. alecdavis (license
  21491. 585) Reported by: alecdavis Tested by: alecdavis Review:
  21492. https://reviewboard.asterisk.org/r/2093/ ........ Merged
  21493. revisions 372212 from
  21494. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21495. revisions 372213 from
  21496. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21497. revisions 372214 from
  21498. http://svn.asterisk.org/svn/asterisk/branches/11
  21499. 2012-09-05 04:55 +0000 [r372200] Michael L. Young <elgueromexicano@gmail.com>
  21500. * res/res_rtp_asterisk.c, /: Fix Incrementing Sequence Number For
  21501. Retransmitted DTMF End Packets In Asterisk 1.4+, a fix was put in
  21502. place to increment the sequence number for retransmitted DTMF end
  21503. packets. With the introduction of the RTP engine API in 1.8, the
  21504. sequence number was no longer being incremented. This patch fixes
  21505. this regression as well as cleans up a few lines that were not
  21506. doing anything. (closes issue ASTERISK-20295) Reported by: Nitesh
  21507. Bansal Tested by: Michael L. Young Patches:
  21508. 01_rtp_event_seq_num.patch uploaded by Nitesh Bansal (license
  21509. 6418) asterisk-20295-dtmf-fix-cleanup.diff uploaded by Michael L.
  21510. Young (license 5026) Review:
  21511. https://reviewboard.asterisk.org/r/2083/ ........ Merged
  21512. revisions 372185 from
  21513. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21514. revisions 372198 from
  21515. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21516. revisions 372199 from
  21517. http://svn.asterisk.org/svn/asterisk/branches/11
  21518. 2012-09-05 02:26 +0000 [r372176] Matthew Jordan <mjordan@digium.com>
  21519. * cel/cel_pgsql.c, /: Fix memory leak when CEL is successfully
  21520. written to PostgreSQL database PQClear is not called when the
  21521. result object of a call to PQExec has a status of
  21522. PGRES_COMMAND_OK. Interestingly enough, the off nominal case was
  21523. handled properly, so this memory leak only occurred when CEL
  21524. records were successfully written. This patch properly clears the
  21525. result in the nominal code path. (closes issue ASTERISK-19991)
  21526. Reported by: Etienne Lessard Tested by: Etienne Lessard patches:
  21527. mem_leak_cel_pgsql.patch uploaded by Etienne Lessard (license
  21528. #6394) ........ Merged revisions 372158 from
  21529. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21530. revisions 372165 from
  21531. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21532. revisions 372175 from
  21533. http://svn.asterisk.org/svn/asterisk/branches/11
  21534. 2012-09-04 19:30 +0000 [r372148-372149] Jonathan Rose <jrose@digium.com>
  21535. * UPGRADE.txt: app_queue: PAUSEALL/UNPAUSEALL logged only if
  21536. interface is a queue member Adding UPGRADE.txt entry for r372148
  21537. (issue AST-946) Reported by: John Bigelow
  21538. * CHANGES, apps/app_queue.c: app_queue: Only log
  21539. PAUSEALL/UNPAUSEALL when 1+ memebers changed. Prior to this
  21540. patch, if pause or unpause was issued on an interface without
  21541. specifying a specific queue, a PAUSEALL or UNPAUSEALL event would
  21542. be logged in the queue log even if that interface wasn't a member
  21543. of any queues. This patch changes it so that these events are
  21544. only logged when at least one member of any queue exists for that
  21545. interface. (closes issue AST-946) Reported by: John Bigelow
  21546. Review: https://reviewboard.asterisk.org/r/2079/
  21547. 2012-09-04 15:50 +0000 [r372136-372138] Mark Michelson <mmichelson@digium.com>
  21548. * /, channels/chan_sip.c: Fix issue where SIP devices were not
  21549. notified when custom devices changed to "ringing". The problem
  21550. had to do with logic used when checking for what the oldest
  21551. ringing channel was. The problem was that if no channel was
  21552. found, then no notification would be sent. For custom device
  21553. states, there is no associated channel, so no notification would
  21554. get sent. This fixes the issue by still sending the notification
  21555. even if no associated channel can be found for a ringing device
  21556. state change. (closes issue ASTERISK-20297) Reported by Noah
  21557. Engelberth ........ Merged revisions 372137 from
  21558. http://svn.asterisk.org/svn/asterisk/branches/11
  21559. * apps/app_confbridge.c, /, main/config_options.c: Prevent crash
  21560. from using app_page with no confbridge.conf file provided. Also
  21561. prevents other potential crashes when using aco API with
  21562. uninitialized aco_info structs. (closes issue ASTERISK-20305)
  21563. reported by Noah Engelberth Tested by Noah Engelberth Review:
  21564. https://reviewboard.asterisk.org/r/2086 ........ Merged revisions
  21565. 372135 from http://svn.asterisk.org/svn/asterisk/branches/11
  21566. 2012-08-31 21:15 +0000 [r372119] Mark Michelson <mmichelson@digium.com>
  21567. * res/res_rtp_asterisk.c, /: Prevent local RTP bridges from sending
  21568. inappropriate formats to participants. A change for Asterisk 11
  21569. caused a check for failure to incorrectly check the return value.
  21570. This resulted in the possibility of transmitting media that a
  21571. party had not negotiated. If this media happened to be G.729,
  21572. then this could potentially result in one-way audio if no G.729
  21573. translators are installed. (closes issue ASTERISK-20296) reported
  21574. by NITESH BANSAL ........ Merged revisions 372118 from
  21575. http://svn.asterisk.org/svn/asterisk/branches/11
  21576. 2012-08-30 20:54 +0000 [r372051-372092] Mark Michelson <mmichelson@digium.com>
  21577. * apps/app_queue.c, /: Prevent crash on shutdown due to refcount
  21578. error on queues container. When app_queue is unloaded, the queues
  21579. container has its refcount decremented, potentially to 0. Then
  21580. the taskprocessor responsible for handling device state changes
  21581. is unreferenced. If the taskprocessor happens to be just about to
  21582. run its task, then it will create and destroy an iterator on the
  21583. queues container. This can cause the refcount on the queues
  21584. container to increase to 1 and then back to 0. Going back to 0 a
  21585. second time results in double frees. This failure was seen
  21586. periodically in the testsuite when Asterisk would shut down.
  21587. ........ Merged revisions 372089 from
  21588. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21589. revisions 372090 from
  21590. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21591. revisions 372091 from
  21592. http://svn.asterisk.org/svn/asterisk/branches/11
  21593. * /, apps/app_queue.c: Help prevent ringing queue members from
  21594. being rung when ringinuse set to no. Queue member status would
  21595. not always get updated properly when the member was called, thus
  21596. resulting in the member getting multiple calls. With this change,
  21597. we update the member's status at the time of calling, and we also
  21598. check to make sure the member is still available to take the call
  21599. before placing an outbound call. (closes issue ASTERISK-16115)
  21600. reported by nik600 Patches: app_queue.c-svn-r370418.patch
  21601. uploaded by Italo Rossi (license #6409) ........ Merged revisions
  21602. 372048 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  21603. ........ Merged revisions 372049 from
  21604. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21605. revisions 372050 from
  21606. http://svn.asterisk.org/svn/asterisk/branches/11
  21607. 2012-08-30 16:25 +0000 [r371964-372029] Matthew Jordan <mjordan@digium.com>
  21608. * channels/chan_iax2.c, /: AST-2012-013: Resolve ACL rules being
  21609. ignored during calls by some IAX2 peers When an IAX2 call is made
  21610. using the credentials of a peer defined in a dynamic Asterisk
  21611. Realtime Architecture (ARA) backend, the ACL rules for that peer
  21612. are not applied to the call attempt. This allows for a remote
  21613. attacker who is aware of a peer's credentials to bypass the ACL
  21614. rules set for that peer. This patch ensures that the ACLs are
  21615. applied for all peers, regardless of their storage mechanism.
  21616. (closes issue ASTERISK-20186) Reported by: Alan Frisch Tested by:
  21617. mjordan, Alan Frisch ........ Merged revisions 372028 from
  21618. http://svn.asterisk.org/svn/asterisk/branches/11
  21619. * main/manager.c, /, README-SERIOUSLY.bestpractices.txt:
  21620. AST-2012-012: Resolve AMI User Unauthorized Shell Access through
  21621. ExternalIVR The AMI Originate action can allow a remote user to
  21622. specify information that can be used to execute shell commands on
  21623. the system hosting Asterisk. This can result in an unwanted
  21624. escalation of permissions, as the Originate action, which
  21625. requires the "originate" class authorization, can be used to
  21626. perform actions that would typically require the "system" class
  21627. authorization. Previous attempts to prevent this permission
  21628. escalation (AST-2011-006, AST-2012-004) have sought to do so by
  21629. inspecting the names of applications and functions passed in with
  21630. the Originate action and, if those applications/functions matched
  21631. a predefined set of values, rejecting the command if the user
  21632. lacked the "system" class authorization. As noted by IBM X-Force
  21633. Research, the "ExternalIVR" application is not listed in the
  21634. predefined set of values. The solution for this particular
  21635. vulnerability is to include the "ExternalIVR" application in the
  21636. set of defined applications/functions that require "system" class
  21637. authorization. Unfortunately, the approach of inspecting fields
  21638. in the Originate action against known applications/functions has
  21639. a significant flaw. The predefined set of values can be bypassed
  21640. by creative use of the Originate action or by certain dialplan
  21641. configurations, which is beyond the ability of Asterisk to
  21642. analyze at run-time. Attempting to work around these scenarios
  21643. would result in severely restricting the applications or
  21644. functions and prevent their usage for legitimate means. As such,
  21645. any additional security vulnerabilities, where an
  21646. application/function that would normally require the "system"
  21647. class authorization can be executed by users with the "originate"
  21648. class authorization, will not be addressed. Instead, the
  21649. README-SERIOUSLY.bestpractices.txt file has been updated to
  21650. reflect that the AMI Originate action can result in commands
  21651. requiring the "system" class authorization to be executed. Proper
  21652. system configuration can limit the impact of such scenarios.
  21653. (closes issue ASTERISK-20132) Reported by: Zubair Ashraf of IBM
  21654. X-Force Research ........ Merged revisions 371998 from
  21655. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21656. revisions 371999 from
  21657. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21658. revisions 372000 from
  21659. http://svn.asterisk.org/svn/asterisk/branches/11
  21660. * include/asterisk/bridging.h, include/asterisk/datastore.h,
  21661. main/file.c, include/asterisk/strings.h, include/asterisk/pbx.h,
  21662. channels/sip/include/srtp.h, main/audiohook.c,
  21663. include/asterisk/translate.h, main/cdr.c, main/channel.c,
  21664. include/asterisk/crypto.h, include/asterisk/config_options.h,
  21665. include/asterisk/bridging_technology.h,
  21666. include/asterisk/audiohook.h,
  21667. apps/confbridge/include/confbridge.h, include/asterisk/format.h,
  21668. include/asterisk/netsock2.h, include/asterisk/rtp_engine.h,
  21669. include/asterisk/ccss.h, main/pbx.c, include/asterisk/utils.h,
  21670. channels/sip/srtp.c, channels/chan_sip.c,
  21671. include/asterisk/format_pref.h, include/asterisk/astobj2.h,
  21672. include/asterisk/presencestate.h, channels/chan_agent.c,
  21673. include/asterisk/config.h, pbx/pbx_lua.c,
  21674. formats/format_ogg_vorbis.c, include/asterisk/channel.h,
  21675. main/named_acl.c, codecs/speex/speex_resampler.h,
  21676. include/asterisk/manager.h, include/asterisk/format_cap.h,
  21677. include/asterisk/framehook.h, include/asterisk/heap.h,
  21678. channels/sig_pri.h, Makefile, include/asterisk/message.h: Clean
  21679. up doxygen warnings This patch fixes numerous doxygen warnings
  21680. across Asterisk. It also updates the makefile to regenerate the
  21681. doxygen configuration on the local system before running doxygen
  21682. to help prevent warnings/errors on the local system. Much thanks
  21683. to Andrew for tackling one of the Asterisk janitor projects!
  21684. (issue ASTERISK-20259) Reported by: Andrew Latham Patches:
  21685. doxygen_partial.diff uploaded by Andrew Latham (license 5985)
  21686. make_progdocs.diff uploaded by Andrew Latham (license 5985)
  21687. * doc/CODING-GUIDELINES (added), /: Restore CODING-GUIDELINES to
  21688. doc folder In r294740, the CODING-GUIDELINES was removed from the
  21689. doc folder in favor of the content on the Asterisk wiki. Some
  21690. folks still look in the doc folder initially for coding guideline
  21691. suggestions; as such, this patch adds a CODING-GUIDELINES file
  21692. back into the doc folder. The content of the file merely points
  21693. to the correct page on the Asterisk wiki where the coding
  21694. guidelines currently live. (closes issue ASTERISK-20279) Reported
  21695. by: Andrew Latham Patches: CODING-GUIDELINES.diff uploaded by
  21696. Andrew Latham (license 5985) ........ Merged revisions 371961
  21697. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  21698. Merged revisions 371962 from
  21699. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21700. revisions 371963 from
  21701. http://svn.asterisk.org/svn/asterisk/branches/11
  21702. 2012-08-29 22:48 +0000 [r371951-371952] Richard Mudgett <rmudgett@digium.com>
  21703. * include/asterisk/md5.h: Ensure alignment of in[] field in
  21704. MD5Context struct. The struct MD5Context character buffer is cast
  21705. to an int32_t* without making sure that said buffer is aligned.
  21706. Since the buffer follows two uint32_t's, the chance of 'in' being
  21707. (32 bits) unaligned is nil in practice. But adding code to ensure
  21708. that 'in' stays aligned costs nothing and removes all doubts
  21709. about the casts being safe. (closes issue ASTERISK-20241)
  21710. Reported by: Walter Doekes Patches: tmp.diff (license #5674)
  21711. patch uploaded by Walter Doekes
  21712. * /, apps/app_meetme.c: Fix compile errors. ........ Merged
  21713. revisions 371950 from
  21714. http://svn.asterisk.org/svn/asterisk/branches/11
  21715. 2012-08-29 21:15 +0000 [r371922] Jonathan Rose <jrose@digium.com>
  21716. * /, apps/app_meetme.c: app_meetme: Adding test events for
  21717. following activity in MeetMe. ........ Merged revisions 371919
  21718. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  21719. Merged revisions 371920 from
  21720. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21721. revisions 371921 from
  21722. http://svn.asterisk.org/svn/asterisk/branches/11
  21723. 2012-08-29 19:57 +0000 [r371892-371894] Richard Mudgett <rmudgett@digium.com>
  21724. * main/channel.c, /: Fix theoretical compile error with HAVE_EPOLL.
  21725. Really shows how much epoll is used since it had not been
  21726. reported yet. ........ Merged revisions 371893 from
  21727. http://svn.asterisk.org/svn/asterisk/branches/11
  21728. * main/channel.c, /: Initialize file descriptors for dummy channels
  21729. to -1. Dummy channels usually aren't read from, but functions
  21730. like SHELL and CURL use autoservice on the channel. (closes issue
  21731. ASTERISK-20283) Reported by: Gareth Palmer Patches:
  21732. svn-371580.patch (license #5169) patch uploaded by Gareth Palmer
  21733. (modified) ........ Merged revisions 371888 from
  21734. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21735. revisions 371890 from
  21736. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21737. revisions 371891 from
  21738. http://svn.asterisk.org/svn/asterisk/branches/11
  21739. 2012-08-29 19:38 +0000 [r371889] Jonathan Rose <jrose@digium.com>
  21740. * channels/chan_sip.c, UPGRADE.txt: chan_sip: Change manager event
  21741. to confirm SIPqualifypeer into an ack Matt Jordan informed me
  21742. that it was more appropriate to use an astman_send_ack here
  21743. instead of making an event response. I've also used this
  21744. opportunity to update UPGRADE.txt to mention this change in
  21745. behavior. (issue AST-969) Reported by: John Bigelow
  21746. 2012-08-29 18:40 +0000 [r371863] Richard Mudgett <rmudgett@digium.com>
  21747. * apps/app_dial.c, /: Fix hangup cause passthrough regression. The
  21748. v1.8 -r369258 change to fix the F and F(x) action logic
  21749. introduced a regression in passing the hangup cause from the
  21750. called channel to the caller channel. (closes issue
  21751. ASTERISK-20287) Reported by: Konstantin Suvorov Patches:
  21752. app_dial_hangupcause.patch (license #6421) patch uploaded by
  21753. Konstantin Suvorov (modified) Tested by: rmudgett ........ Merged
  21754. revisions 371860 from
  21755. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21756. revisions 371861 from
  21757. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21758. revisions 371862 from
  21759. http://svn.asterisk.org/svn/asterisk/branches/11
  21760. 2012-08-29 17:35 +0000 [r371823-371851] Jonathan Rose <jrose@digium.com>
  21761. * /, channels/chan_sip.c: chan_sip: Send 408 on retransmit timeout
  21762. instead of 603 (closes issue ASTERISK-20124) Reported by: Walter
  21763. Doekes ........ Merged revisions 371824 from
  21764. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21765. revisions 371825 from
  21766. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21767. revisions 371845 from
  21768. http://svn.asterisk.org/svn/asterisk/branches/11
  21769. * channels/chan_sip.c: chan_sip: Send a manager event to confirm
  21770. SIPqualifypeer completes Prior to this patch, Issuing
  21771. SIPqualifypeer either resulted in an error or if it succeeded, a
  21772. few \r\ns. This patch adds a SIPqualifypeerComplete event issued
  21773. as a response when the command is successfully executed. (closes
  21774. issue AST-969) Reported by: John Bigelow
  21775. 2012-08-27 21:51 +0000 [r371785-371791] Mark Michelson <mmichelson@digium.com>
  21776. * configs/agents.conf.sample, /: Fix misleading documentation in
  21777. agents.conf.sample regarding ackcall usage. The documentation
  21778. made it sound as if the DTMF acknowledgment was needed at the
  21779. time the agent logs in, rather than when the agent is called.
  21780. This is likely a relic from the days when there were multiple
  21781. ways of logging in agents. (closes issue AST-962) reported by
  21782. Steve Pitts ........ Merged revisions 371787 from
  21783. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21784. revisions 371789 from
  21785. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21786. revisions 371790 from
  21787. http://svn.asterisk.org/svn/asterisk/branches/11
  21788. * main/manager.c, /: Fix incorrect documentation of the
  21789. MailboxStatus manager command. The "Waiting" field was
  21790. misdocumented as reporting the number of messages waiting. In
  21791. reality, it simply indicated the presence or absence of waiting
  21792. messages. ........ Merged revisions 371782 from
  21793. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21794. revisions 371783 from
  21795. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21796. revisions 371784 from
  21797. http://svn.asterisk.org/svn/asterisk/branches/11
  21798. 2012-08-27 18:16 +0000 [r371754] David M. Lee <dlee@digium.com>
  21799. * res/pjproject/pjlib-util/bin, res/pjproject/pjnath/build/output,
  21800. /, res/pjproject/pjlib/bin,
  21801. res/pjproject/pjlib-util/build/output, res/pjproject/pjnath/bin,
  21802. res/pjproject/pjlib/build/output: svn:ignore pjproject bin &
  21803. output for all platforms. ........ Merged revisions 371753 from
  21804. http://svn.asterisk.org/svn/asterisk/branches/11
  21805. 2012-08-27 17:52 +0000 [r371751] Mark Michelson <mmichelson@digium.com>
  21806. * /, configs/queues.conf.sample: Fix incorrectly documented option
  21807. in queues.conf sharedlastcall defaults to "no" not "yes" (closes
  21808. issue AST-979) reported by Steve Pitts ........ Merged revisions
  21809. 371747 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  21810. ........ Merged revisions 371748 from
  21811. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21812. revisions 371750 from
  21813. http://svn.asterisk.org/svn/asterisk/branches/11
  21814. 2012-08-27 16:56 +0000 [r371721] David M. Lee <dlee@digium.com>
  21815. * main/lock.c, /: Fixes ast_rwlock_timed[rd|wr]lock for BSD and
  21816. variants. The original implementations simply wrap pthread
  21817. functions, which take absolute time as an argument. The spinlock
  21818. version for systems without those functions treated the argument
  21819. as a delta. This patch fixes the spinlock version to be
  21820. consistent with the pthread version. (closes issue
  21821. ASTERISK-20240) Reported by: Egor Gorlin Patches: lock.c.patch
  21822. uploaded by Egor Gorlin (license 6416) ........ Merged revisions
  21823. 371718 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  21824. ........ Merged revisions 371720 from
  21825. http://svn.asterisk.org/svn/asterisk/branches/11
  21826. 2012-08-27 14:13 +0000 [r371693] Kinsey Moore <kmoore@digium.com>
  21827. * /, main/utils.c: Implement workaround for BETTER_BACKTRACES crash
  21828. When compiling with BETTER_BACKTRACES enabled, Asterisk will
  21829. sometimes crash when "core show locks" is run. This happens
  21830. regularly in the testsuite since several tests run "core show
  21831. locks" to help with debugging. This seems to be a fault with
  21832. libraries on certain operating systems (notably CentOS 6.2/6.3)
  21833. running on virtual machines and utilizing gcc 4.4.6. (closes
  21834. issue ASTERISK-20090) ........ Merged revisions 371690 from
  21835. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21836. revisions 371691 from
  21837. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21838. revisions 371692 from
  21839. http://svn.asterisk.org/svn/asterisk/branches/11
  21840. 2012-08-26 23:10 +0000 [r371665] Alec L Davis <sivad.a@paradise.net.nz>
  21841. * /, main/dsp.c: mf_detect: incorrectly used DTMF_GSIZE instead of
  21842. MF_GSIZE ........ Merged revisions 371662 from
  21843. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21844. revisions 371663 from
  21845. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21846. revisions 371664 from
  21847. http://svn.asterisk.org/svn/asterisk/branches/11
  21848. 2012-08-23 04:12 +0000 [r371633] Mark Michelson <mmichelson@digium.com>
  21849. * tests/test_scoped_lock.c (added): I forgot to add the unit tests
  21850. for scoped locks earlier today.
  21851. 2012-08-22 15:55 +0000 [r371620] Joshua Colp <jcolp@digium.com>
  21852. * /, channels/chan_motif.c: Add support for call-id logging to
  21853. chan_motif. Review: https://reviewboard.asterisk.org/r/2077/
  21854. ........ Merged revisions 371619 from
  21855. http://svn.asterisk.org/svn/asterisk/branches/11
  21856. 2012-08-21 21:01 +0000 [r371572-371593] Mark Michelson <mmichelson@digium.com>
  21857. * cdr/cdr_tds.c, main/xmldoc.c, apps/app_dial.c,
  21858. channels/chan_dahdi.c, /, channels/chan_sip.c, funcs/func_odbc.c,
  21859. main/file.c, main/utils.c, apps/app_queue.c, pbx/pbx_config.c,
  21860. res/res_jabber.c, apps/app_stack.c, channels/chan_oss.c,
  21861. res/res_config_sqlite.c: Fix misuses of asprintf throughout the
  21862. code. This fixes three main issues * Change asprintf() uses to
  21863. ast_asprintf() so that it pairs properly with ast_free() and no
  21864. longer causes MALLOC_DEBUG to freak out. * When ast_asprintf()
  21865. fails, set the pointer NULL if it will be referenced later. * Fix
  21866. some memory leaks that were spotted while taking care of the
  21867. first two points. (Closes issue ASTERISK-20135) reported by
  21868. Richard Mudgett Review: https://reviewboard.asterisk.org/r/2071
  21869. ........ Merged revisions 371590 from
  21870. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21871. revisions 371591 from
  21872. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21873. revisions 371592 from
  21874. http://svn.asterisk.org/svn/asterisk/branches/11
  21875. * main/config.c, include/asterisk/lock.h: Add scoped locks to
  21876. Asterisk. With the SCOPED_LOCK macro, you can create a variable
  21877. that locks a specific lock and unlocks the lock when the variable
  21878. goes out of scope. This is useful for situations where many
  21879. breaks, continues, returns, or other interruptions would require
  21880. separate unlock statements. With a scoped lock, these aren't
  21881. necessary. There are specializations for mutexes, read locks,
  21882. write locks, ao2 locks, ao2 read locks, ao2 write locks, and
  21883. channel locks. Each of these is a SCOPED_LOCK at heart though.
  21884. Review: https://reviewboard.asterisk.org/r/2060
  21885. * /, res/res_rtp_asterisk.c: Use thread-local storage to store
  21886. pj_thread_descs. pj_thread_register() takes a parameter of type
  21887. pj_thread_desc. It was assumed that pj_thread_register either
  21888. used this item temporarily or made a copy of it. Unfortunately,
  21889. all it does is keep a pointer to the structure in thread-local
  21890. storage. This means that if our pj_thread_desc goes out of scope,
  21891. then pjlib will be referencing bogus data quite often, most
  21892. commonly on operations involving a pj_mutex_t. In our case, our
  21893. pj_thread_desc was on the stack and went out of scope very
  21894. shortly after registering our thread with pjlib. With this
  21895. change, the pj_thread_desc is stored in thread-local storage so
  21896. the pointer that pjlib keeps in thread-local storage will
  21897. reference legitimate memory. (closes issue ASTERISK-20237)
  21898. reported by Jeremy Pepper Patches: ASTERISK-20237.patch uploaded
  21899. by Mark Michelson (license #5049) Tested by Jeremy Pepper
  21900. ........ Merged revisions 371571 from
  21901. http://svn.asterisk.org/svn/asterisk/branches/11
  21902. 2012-08-20 15:39 +0000 [r371535-371547] Kinsey Moore <kmoore@digium.com>
  21903. * main/udptl.c, /: Ignore recovered zero-length secondary UDPTL
  21904. packets In some cases, recovering lost packets using the
  21905. secondary packet recovery mechanism with UDPTL/T.38 can result in
  21906. the recovery of zero-length packets. These must be ignored or the
  21907. frame generated from them can cause segfaults and allocation
  21908. failures. (closes issue ASTERISK-19762) (closes issue
  21909. ASTERISK-19373) Reported-by: Benjamin (bulkorok) Reported-by: Rob
  21910. Gagnon (rgagnon) ........ Merged revisions 371544 from
  21911. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21912. revisions 371545 from
  21913. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21914. revisions 371546 from
  21915. http://svn.asterisk.org/svn/asterisk/branches/11
  21916. * main/utils.c: Fix for commit r371535
  21917. * main/utils.c: Apply work-around for BETTER_BACKTRACES crash When
  21918. compiling with BETTER_BACKTRACES enabled, Asterisk will sometimes
  21919. crash when "core show locks" is run. This happens regularly in
  21920. the testsuite since several tests run "core show locks" to help
  21921. with debugging. This seems to be a fault with libraries on
  21922. certain operating systems (notably CentOS 6.2/6.3) running on
  21923. virtual machines and utilizing gcc 4.4.6. (issue ASTERISK-20090)
  21924. 2012-08-18 02:09 +0000 [r371493-371521] Matthew Jordan <mjordan@digium.com>
  21925. * main/http.c, /: Remove old debug code from http configuration
  21926. loading (closes issue ASTERISK-20254) Reported by: Andrew Latham
  21927. Patches: http.diff uploaded by Andrew Latham (license #5985)
  21928. ........ Merged revisions 371520 from
  21929. http://svn.asterisk.org/svn/asterisk/branches/11
  21930. * res/res_xmpp.c, /: Fix typo in JabberSend that looked for '2'
  21931. instead of '@' in recipient argument The summary says about all
  21932. there is to say. (closes issue ASTERISK-20239) Reported by:
  21933. Gregory Porras ........ Merged revisions 371518 from
  21934. http://svn.asterisk.org/svn/asterisk/branches/11
  21935. * funcs/func_hangupcause.c, /: Make the name of the
  21936. "HangupCauseClear" application consistent The name of the
  21937. "HangupCauseClear" application is "HangupCauseClear", not
  21938. "HangupcauseClear". The incorrect case of 'cause' caused the XML
  21939. documentation to not register properly. As an aside, this commit
  21940. message felt very awkward, but I'm not sure how else to note that
  21941. "X", which has to be "X", was referred to as "x". (closes issue
  21942. ASTERISK-20253) Reported by: Andrew Latham Patches:
  21943. hangupcause.diff uploaded by Andrew Latham (license #5985)
  21944. ........ Merged revisions 371516 from
  21945. http://svn.asterisk.org/svn/asterisk/branches/11
  21946. * sounds/sounds.xml, res/res_curl.c, build_tools/cflags.xml,
  21947. utils/utils.xml, /, res/res_fax.c: Update module support level on
  21948. a variety of modules and compiler options Some core support
  21949. modules and compiler options were no longer tagged with a module
  21950. support level. This patch adds 'core' back to those options. Note
  21951. that this patch modifies a few of the patches provided by Andrew
  21952. Latham slightly. res_curl and res_fax are both 'core' supported
  21953. modules. (closes issue ASTERISK-20215) Reported by: Andrew Latham
  21954. Tested by: mjordan Patches: astcanary.diff (license #5985)
  21955. uploaded by Andrew Latham cflagsxml.diff (license #5985) uploaded
  21956. by Andrew Latham curl_fax.diff (license #5985) uploaded by Andrew
  21957. Latham soundsxml.diff (license #5985) uploaded by Andrew Latham
  21958. ........ Merged revisions 371507 from
  21959. http://svn.asterisk.org/svn/asterisk/branches/11
  21960. * /, main/xmldoc.c: Fix memory leak in XML documentation When
  21961. formatting documentation fields, the XML documentation parser
  21962. calls xmldoc_get_formatted. This function allocates a string
  21963. buffer at the beginning of its routine. Unfortunately, on certain
  21964. code paths, it also calls xmldoc_string_cleanup, which assumes
  21965. that it will create the string buffer. The previously allocated
  21966. string buffer is then leaked by the xmldoc_string_cleanup
  21967. routine. Now: we don't do that. (closes issue AST-932) Reported
  21968. by: Alexander Homig ........ Merged revisions 371469 from
  21969. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  21970. revisions 371491 from
  21971. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21972. revisions 371492 from
  21973. http://svn.asterisk.org/svn/asterisk/branches/11
  21974. 2012-08-17 19:50 +0000 [r371483] Joshua Colp <jcolp@digium.com>
  21975. * /, channels/chan_sip.c: When a peer registers using WebSocket do
  21976. not resolve the Contact provided. (closes issue ASTERISK-20238)
  21977. Reported by: james.mortensen ........ Merged revisions 371482
  21978. from http://svn.asterisk.org/svn/asterisk/branches/11
  21979. 2012-08-17 16:01 +0000 [r371439] Kinsey Moore <kmoore@digium.com>
  21980. * main/loader.c, /: Add instrumentation to subsystem reloads When
  21981. Asterisk is built with TEST_FRAMEWORK defined, Asterisk will now
  21982. generate TestEvent AMI events on subsystem reloads such as cdr,
  21983. dnsmgr, extconfig, etc. (issue PQ-1126) ........ Merged revisions
  21984. 371436 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  21985. ........ Merged revisions 371437 from
  21986. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  21987. revisions 371438 from
  21988. http://svn.asterisk.org/svn/asterisk/branches/11
  21989. 2012-08-17 12:42 +0000 [r371428] Russell Bryant <russell@russellbryant.com>
  21990. * res/res_rtp_asterisk.c, /: rtp: Ensure defaults are set without
  21991. rtp.conf. While building up a new install to test chan_motif, I
  21992. ran into a failure due to icesupport being disabled. This was due
  21993. to me not having an rtp.conf. It was intended in the code for it
  21994. to be enabled by default, but it was only applied if rtp.conf
  21995. existed. This patch updates res_rtp_asterisk to be consistent in
  21996. how it handles defaults. A few options didn't have their default
  21997. values set globally, including icesupport. They are now set and
  21998. icesupport is enabled by default, even if you do not have an
  21999. rtp.conf. ........ Merged revisions 371425 from
  22000. http://svn.asterisk.org/svn/asterisk/branches/11
  22001. 2012-08-17 12:25 +0000 [r371427] Joshua Colp <jcolp@digium.com>
  22002. * res/res_format_attr_h264.c, /: Add some additional H.264
  22003. attributes, "max-smbps" and "max-fps", for passthrough. (closes
  22004. issue ASTERISK-20206) Reported by: ddkprog Patches:
  22005. res_format_attr_h264.c.diff uploaded by ddkprog (license 6008)
  22006. ........ Merged revisions 371426 from
  22007. http://svn.asterisk.org/svn/asterisk/branches/11
  22008. 2012-08-16 23:08 +0000 [r371400] Terry Wilson <twilson@digium.com>
  22009. * /, main/config.c: Handle integer over/under-flow in
  22010. ast_parse_args The strtol family of functions will return
  22011. *_MIN/*_MAX on overflow. To detect when an overflow has happened,
  22012. errno must be set to 0 before calling the function, then checked
  22013. afterward. (closes issue ASTERISK-20120) Reported by: Matt Jordan
  22014. Review: https://reviewboard.asterisk.org/r/2073/ ........ Merged
  22015. revisions 371392 from
  22016. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22017. revisions 371398 from
  22018. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22019. revisions 371399 from
  22020. http://svn.asterisk.org/svn/asterisk/branches/11
  22021. 2012-08-16 22:45 +0000 [r371396] Kinsey Moore <kmoore@digium.com>
  22022. * /, main/loader.c: Add module reload instrumentation for
  22023. TEST_FRAMEWORK This adds AMI events for module reloads when
  22024. Asterisk is built with TEST_FRAMEWORK enabled and corrects
  22025. generation of the module load AMI event. (issue PQ-1126) ........
  22026. Merged revisions 371393 from
  22027. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22028. revisions 371394 from
  22029. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22030. revisions 371395 from
  22031. http://svn.asterisk.org/svn/asterisk/branches/11
  22032. 2012-08-16 19:52 +0000 [r371356-371383] Jonathan Rose <jrose@digium.com>
  22033. * /, channels/chan_sip.c: chan_sip: Use pvt outgoing_call variable
  22034. to set Remote-Party-ID Header Previously the pvt SIP_OUTGOING
  22035. flag was used instead, which will frequently flip during
  22036. reinvites. (closes issue AST-897) Reported by: Thomas Arimont
  22037. ........ Merged revisions 371357 from
  22038. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22039. revisions 371358 from
  22040. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22041. revisions 371382 from
  22042. http://svn.asterisk.org/svn/asterisk/branches/11
  22043. * /, channels/chan_sip.c: chan_sip: Trigger reinvite if the SDP
  22044. answer is included in the SIP ACK Under certain conditions, a SIP
  22045. transaction involving directmedia wouldn't trigger a re-invite
  22046. because the SDP answer was included in an ACK instead of in a
  22047. message that we would have triggered the invite with. This patch
  22048. just queues a source change control frame if the dialog is using
  22049. directmedia when we find sdp for an ACK. (closes issue AST-913)
  22050. Reported by: Thomas Arimont ........ Merged revisions 371337 from
  22051. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22052. revisions 371338 from
  22053. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22054. revisions 371355 from
  22055. http://svn.asterisk.org/svn/asterisk/branches/11
  22056. 2012-08-15 23:35 +0000 [r371325] Mark Michelson <mmichelson@digium.com>
  22057. * /, apps/app_queue.c: Fix bug where final queue member would not
  22058. be removed from memory. If a static queue had realtime members,
  22059. then there could be a potential for those realtime members not to
  22060. be properly deleted from memory. If the queue's members were
  22061. loaded from realtime and then all the members were deleted from
  22062. the backend, then the queue would still think these members
  22063. existed. The reason was that there was a short- circuit in code
  22064. such that if there were no members found in the backend, then the
  22065. queue would not be updated to reflect this. Note that this only
  22066. affected static queues with realtime members. Realtime queues
  22067. with realtime members were unaffected by this issue. (closes
  22068. issue ASTERISK-19793) reported by Marcus Haas ........ Merged
  22069. revisions 371306 from
  22070. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22071. revisions 371313 from
  22072. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22073. revisions 371324 from
  22074. http://svn.asterisk.org/svn/asterisk/branches/11
  22075. 2012-08-15 20:43 +0000 [r371296] Michael L. Young <elgueromexicano@gmail.com>
  22076. * /, channels/chan_sip.c: Fix Segfault When Registering SIP Over
  22077. WebSockets The helper function, get_address_family_filter, in
  22078. chan_sip for dns resolution by address family was not recognizing
  22079. the websockets transport and resulting in a null pointer being
  22080. sent to functions in netsock2, in an attempt to determine if we
  22081. are bound to ANY address ([::]) or not. This patch fixes this
  22082. issue by handling the transport types SIP_TRANSPORT_WS and
  22083. SIP_TRANSPORT_WSS which results in a sock address being set
  22084. properly for use in determining the address family. (closes issue
  22085. ASTERISK-20221) Reported by: Sven Beisiegel Tested by: Sven
  22086. Beisiegel, James Mortensen Patches:
  22087. asterisk-20221-ws-family-filter.diff uploaded by Michael L. Young
  22088. (license 5026) ........ Merged revisions 371295 from
  22089. http://svn.asterisk.org/svn/asterisk/branches/11
  22090. 2012-08-15 20:18 +0000 [r371259-371277] Kinsey Moore <kmoore@digium.com>
  22091. * /, channels/chan_sip.c: Avoid unconditional NULLing of mwipvt on
  22092. relatedpeer on SIP dialog destruction The other instance of this
  22093. bug was fixed by jcolp/file in r121496. If we are destroying a
  22094. dialog only set the MWI dialog pointer on the related peer to
  22095. NULL if it is the dialog currently being destroyed. (closes issue
  22096. ASTERISK-20119) Patch-by: Misha Vodsedalek ........ Merged
  22097. revisions 371270 from
  22098. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22099. revisions 371271 from
  22100. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22101. revisions 371272 from
  22102. http://svn.asterisk.org/svn/asterisk/branches/11
  22103. * channels/chan_iax2.c, channels/sig_pri.c, channels/sig_ss7.c,
  22104. channels/chan_dahdi.c, channels/sig_analog.c, /,
  22105. channels/chan_sip.c: Add HANGUPCAUSE information to callee
  22106. channels This adds HANGUPCAUSE information to called channels so
  22107. that hangup handlers can, in conjunction with predial dialplan
  22108. execution, access the hangupcause information when the dialed
  22109. channel hangs up on a one-to-one basis instead of a many-to-one
  22110. basis as with HANGUPCAUSE usage on the caller channel. Review:
  22111. https://reviewboard.asterisk.org/r/2069/ (closes issue
  22112. ASTERISK-20198) ........ Merged revisions 371258 from
  22113. http://svn.asterisk.org/svn/asterisk/branches/11
  22114. 2012-08-13 20:36 +0000 [r371228] Kinsey Moore <kmoore@digium.com>
  22115. * main/loader.c, /, apps/app_meetme.c: Add test instrumentation
  22116. This adds test instrumentation for loading and unloading of
  22117. modules and for certain actions in MeetMe to be used in the
  22118. testsuite or any other consumer of AMI events. These will only be
  22119. generated when Asterisk is built with TEST_FRAMEWORK enabled.
  22120. (issue PQ-1131) (issue PQ-1133) ........ Merged revisions 371201
  22121. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  22122. Merged revisions 371203 from
  22123. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22124. revisions 371227 from
  22125. http://svn.asterisk.org/svn/asterisk/branches/11
  22126. 2012-08-13 20:02 +0000 [r371202] Mark Michelson <mmichelson@digium.com>
  22127. * /, channels/chan_sip.c: Fix problem where incorrect pointer was
  22128. checked for nullity. ........ Merged revisions 371198 from
  22129. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22130. revisions 371199 from
  22131. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22132. revisions 371200 from
  22133. http://svn.asterisk.org/svn/asterisk/branches/11
  22134. 2012-08-11 19:13 +0000 [r371170] Matthew Jordan <mjordan@digium.com>
  22135. * UPGRADE-11.txt (added), UPGRADE.txt: Add UPGRADE-11.txt file;
  22136. update UPGRADE.txt to reflect Asterisk 12
  22137. 2012-08-10 22:04 +0000 [r371147] Richard Mudgett <rmudgett@digium.com>
  22138. * /, CHANGES: Update CHANGES for private party ID. ........ Merged
  22139. revisions 371146 from
  22140. http://svn.asterisk.org/svn/asterisk/branches/11
  22141. 2012-08-10 21:35 +0000 [r371144] Mark Michelson <mmichelson@digium.com>
  22142. * apps/app_queue.c, /: Fix a couple of documentation problems in
  22143. app_queue.c * The RemoveQueueMember app made mention of options
  22144. that could be passed in, but no options are supported. I have
  22145. removed the listing of options from the documentation. * The
  22146. RQMSTATUS variable did not list "NOTDYNAMIC" as a possible value
  22147. that could be set. (closes issue AST-949) reported by Steve Pitts
  22148. (closes issue AST-954) reported by Steve Pitts ........ Merged
  22149. revisions 371141 from
  22150. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  22151. revisions 371142 from
  22152. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  22153. revisions 371143 from
  22154. http://svn.asterisk.org/svn/asterisk/branches/11
  22155. 2012-08-10 21:09 +0000 [r371134] Matthew Jordan <mjordan@digium.com>
  22156. * /: Remove 10 properties, add 11 properties
  22157. 2012-08-10 19:54 +0000 [r371120] Richard Mudgett <rmudgett@digium.com>
  22158. * include/asterisk/channel.h, channels/sig_pri.c,
  22159. funcs/func_callerid.c, main/cli.c, main/channel.c,
  22160. channels/chan_misdn.c, channels/chan_sip.c,
  22161. main/channel_internal_api.c, main/features.c: Add private
  22162. representation of caller, connected and redirecting party ids.
  22163. This patch adds the feature "Private representation of caller,
  22164. connected and redirecting party ids", as previously discussed
  22165. with us (DATUS) and Digium. 1. Feature motivation Until now it is
  22166. quite difficult to modify a party number or name which can only
  22167. be seen by exactly one particular instantiated technology channel
  22168. subscriber. One example where a modified party number or name on
  22169. one channel is spread over several channels are supplementary
  22170. services like call transfer or pickup. To implement these
  22171. features Asterisk internally copies caller and connected ids from
  22172. one channel to another. Another example are extension
  22173. subscriptions. The monitoring entities (watchers) are notified of
  22174. state changes and - if desired - of party numbers or names which
  22175. represent the involving call parties. One major feature where a
  22176. private representation of party names is essentially needed, i.e.
  22177. where a party name shall be exclusively signaled to only one
  22178. particular user, is a private user-specific name resolution for
  22179. party numbers. A lookup in a private destination-dependent
  22180. telephone book shall provide party names which cannot be seen by
  22181. any other user at any time. 2. Feature Description This feature
  22182. comes along with the implementation of additional private party
  22183. id elements for caller id, connected id and redirecting ids
  22184. inside Asterisk channels. The private party id elements can be
  22185. read or set by the user using Asterisk dialplan functions. When a
  22186. technology channel is initiating a call, receives an internal
  22187. connected-line update event, or receives an internal redirecting
  22188. update event, it merges the corresponding public id with the
  22189. private id to create an effective party id. The effective party
  22190. id is then used for protocol signaling. The channel technologies
  22191. which initially support the private id representation with this
  22192. patch are SIP (chan_sip), mISDN (chan_misdn) and PRI
  22193. (chan_dahdi). Once a private name or number on a channel is set
  22194. and (implicitly) made valid, it is generally used for any further
  22195. protocol signaling until it is rewritten or invalidated. To
  22196. simplify the invalidation of private ids all internally generated
  22197. connected/redirecting update events and also all
  22198. connected/redirecting update events which are generated by
  22199. technology channels -- receiving regarding protocol information -
  22200. automatically trigger the invalidation of private ids. If not
  22201. using the private party id representation feature at all, i.e. if
  22202. using only the 'regular' caller-id, connected and redirecting
  22203. related functions, the current characteristic of Asterisk is not
  22204. affected by the new extended functionality. 3. User interface
  22205. Description To grant access to the private name and number
  22206. representation from the Asterisk dialplan, the CALLERID,
  22207. CONNECTEDLINE and REDIRECTING dialplan functions are extended by
  22208. the following data types. The formats of these data types are
  22209. equal to the corresponding regular 'non-private' already existing
  22210. data types: CALLERID: priv-all priv-name priv-name-valid
  22211. priv-name-charset priv-name-pres priv-num priv-num-valid
  22212. priv-num-plan priv-num-pres priv-subaddr priv-subaddr-valid
  22213. priv-subaddr-type priv-subaddr-odd priv-tag CONNECTEDLINE:
  22214. priv-name priv-name-valid priv-name-pres priv-name-charset
  22215. priv-num priv-num-valid priv-num-pres priv-num-plan priv-subaddr
  22216. priv-subaddr-valid priv-subaddr-type priv-subaddr-odd priv-tag
  22217. REDIRECTING: priv-orig-name priv-orig-name-valid
  22218. priv-orig-name-pres priv-orig-name-charset priv-orig-num
  22219. priv-orig-num-valid priv-orig-num-pres priv-orig-num-plan
  22220. priv-orig-subaddr priv-orig-subaddr-valid priv-orig-subaddr-type
  22221. priv-orig-subaddr-odd priv-orig-tag priv-from-name
  22222. priv-from-name-valid priv-from-name-pres priv-from-name-charset
  22223. priv-from-num priv-from-num-valid priv-from-num-pres
  22224. priv-from-num-plan priv-from-subaddr priv-from-subaddr-valid
  22225. priv-from-subaddr-type priv-from-subaddr-odd priv-from-tag
  22226. priv-to-name priv-to-name-valid priv-to-name-pres
  22227. priv-to-name-charset priv-to-num priv-to-num-valid
  22228. priv-to-num-pres priv-to-num-plan priv-to-subaddr
  22229. priv-to-subaddr-valid priv-to-subaddr-type priv-to-subaddr-odd
  22230. priv-to-tag Reported by: Thomas Arimont Review:
  22231. https://reviewboard.asterisk.org/r/2030/