someonewithpc/gnusocial-issues: A dump for all the issues and such associated with GNU social, in one place

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224
<!DOCTYPE html>
<html>
<head data-suburl="">
	<meta http-equiv="Content-Type" content="text/html; charset=UTF-8" />
	<meta http-equiv="X-UA-Compatible" content="IE=edge"/>
	
		<meta name="author" content="diogo" />
		<meta name="description" content="gnu-social - GNU social is a social communication software used in federated social networks. It is widely supported and has a large userbase. It is already used by the Free Software Foundation." />
		<meta name="keywords" content="go, git, self-hosted, gogs">
	
	<meta name="referrer" content="no-referrer" />
	<meta name="_csrf" content="I36yKTb5Uogt6a6FqcAjOkKtDTE6MTYwNDc5MjMyNDc1MTk4ODI0OA==" />
	<meta name="_suburl" content="" />
	
	
	
		<meta property="og:url" content="https://notabug.org/diogo/gnu-social" />
		<meta property="og:type" content="object" />
		<meta property="og:title" content="diogo/gnu-social">
		<meta property="og:description" content="GNU social is a social communication software used in federated social networks. It is widely supported and has a large userbase. It is already used by the Free Software Foundation.">
		<meta property="og:image" content="https://notabug.org/avatars/12290" />
	

	<link rel="shortcut icon" href="/img/favicon.png" />

	<script src="/js/jquery-1.11.3.min.js"></script>
	<script src="/js/libs/jquery.are-you-sure.js"></script>
        <link href="/img/icon-48.ico" rel="icon" type="image/x-icon" />
        <link href="/img/icon-60.png" rel="apple-touch-icon">
        <link href="/img/icon-76.png" rel="apple-touch-icon" sizes="76x76">
        <link href="/img/icon-120.png" rel="apple-touch-icon" sizes="120x120">
        <link href="/img/icon-152.png" rel="apple-touch-icon" sizes="152x152">
        <link href="/img/icon-240.png" rel="apple-touch-icon" sizes="240x240">

	<link rel="stylesheet" href="/assets/font-awesome-4.6.3/css/font-awesome.min.css">
	<link rel="stylesheet" href="/assets/octicons-4.3.0/octicons.min.css">

	
	

	

	
	<link rel="stylesheet" href="/css/semantic-2.2.13.min.css">
	<link rel="stylesheet" href="/css/gogs.css?v=6fc9e85aa88133794d3434ea74aa557a">
	<link rel="stylesheet" href="/css/notabug.css">

	
	<script src="/js/semantic-2.2.13.min.js"></script>
	<script src="/js/gogs.js?v=6fc9e85aa88133794d3434ea74aa557a"></script>

	<title>Plugin &#34;SensitiveContent&#34; messes up proportion in attachments - NotABug.org: Free code hosting</title>

	<meta name="theme-color" content="#428bca">

	


<noscript><style>.nojs-popup:hover > .menu { display: block ; }</style></noscript>


</head>
<body>
	<div class="full height">
		<noscript>Please enable JavaScript in your browser!</noscript>

		
			<div id="header-div" class="following bar light">
				<div class="ui container">
					<div class="ui grid">
						<div class="column">
							<div class="ui top secondary menu">
								<a class="item brand" href="/">
									<img class="ui mini image" src="/img/favicon.png">
								</a>

								
									<a class="item" href="/">Home</a>
								

								<a class="item" href="/explore/repos">Explore</a>
								

								



									<a class="notabug-item item" href="/help" rel="noreferrer">Help</a>




									<div class="right menu">
										
											<a class="item" href="/user/sign_up">
												<i class="octicon octicon-person"></i> Register
											</a>
										
										<a class="item" href="/user/login?redirect_to=%2fdiogo%2fgnu-social%2fissues%2f121">
											<i class="octicon octicon-sign-in"></i> Sign In
										</a>
									</div>

								
							</div>
						</div>
					</div>
				</div>
			</div>
		


<div class="repository view issue pull">
	<div class="header-wrapper">

	<div class="ui container">
		<div class="ui vertically padded grid head">
			<div class="column">
				<div class="ui header">
					<div class="ui huge breadcrumb">
						<i class="mega-octicon octicon-repo"></i>
						<a href="/diogo">diogo</a>
						<div class="divider"> / </div>
						<a href="/diogo/gnu-social">gnu-social</a>
						
						
					</div>

					
						<div class="ui right">
							<div class="ui labeled button" tabindex="0">
								<a class="ui basic button" href="/diogo/gnu-social/action/watch?redirect_to=%2fdiogo%2fgnu-social%2fissues%2f121">
									<i class="icon fa-eye-slash"></i>Watch
								</a>
								<a class="ui basic label" href="/diogo/gnu-social/watchers">
									9
								</a>
							</div>
							<div class="ui labeled button" tabindex="0">
								<a class="ui basic button" href="/diogo/gnu-social/action/star?redirect_to=%2fdiogo%2fgnu-social%2fissues%2f121">
									<i class="icon fa-star-o"></i>Star
								</a>
								<a class="ui basic label" href="/diogo/gnu-social/stars">
									22
								</a>
							</div>
							
								<div class="ui labeled button" tabindex="0">
									<a class="ui basic button " href="/repo/fork/25974">
										<i class="octicon octicon-repo-forked"></i>Fork
									</a>
									<a class="ui basic label" href="/diogo/gnu-social/forks">
										21
									</a>
								</div>
							
						</div>
					
				</div>
			</div>
		</div>
	</div>


	<div class="ui tabs container">
		<div class="ui tabular menu navbar">
			
				<a class=" item" href="/diogo/gnu-social">
					<i class="octicon octicon-file-text"></i> Files
				</a>
			
			
				<a class="active item" href="/diogo/gnu-social/issues">
					<i class="octicon octicon-issue-opened"></i> Issues <span class="ui blue small label">73</span>
				</a>
			
			
				<a class=" item" href="/diogo/gnu-social/pulls">
					<i class="octicon octicon-git-pull-request"></i> Pull Requests <span class="ui blue small label">3</span>
				</a>
			
			
				<a class=" item" href="/diogo/gnu-social/wiki">
					<i class="octicon octicon-book"></i> Wiki
				</a>
			
			
		</div>
	</div>
	<div class="ui tabs divider"></div>

</div>

	<div class="ui container">
		<div class="navbar">
			<div class="ui compact small menu">
	<a class=" item" href="/diogo/gnu-social/labels">Labels</a>
	<a class=" item" href="/diogo/gnu-social/milestones">Milestones</a>
</div>

			<div class="ui right">
				
					<a class="ui green button" href="/diogo/gnu-social/issues/new">New Issue</a>
				
			</div>
		</div>
		<div class="ui divider"></div>
		
			<div>
				<div class="ui grid">
	
	
		<div class="sixteen wide column title">
	<div class="ui grid">
		<h1 class="twelve wide column">
			<span class="index">#121</span> <span id="issue-title" class="has-emoji">Plugin &#34;SensitiveContent&#34; messes up proportion in attachments</span>
			<div id="edit-title-input" class="ui input" style="display: none">
				<input value="Plugin &#34;SensitiveContent&#34; messes up proportion in attachments">
			</div>
		</h1>
		
	</div>
	
		<div class="ui red large label"><i class="octicon octicon-issue-closed"></i> Closed</div>
	

	
		
		<span class="time-desc">
			
				opened <span class="time-since" title="Sat, 04 Apr 2020 21:03:08 UTC">7 months ago</span> by <a href="/aab">aab</a>
			
			·
			11 comments
		</span>
	
	<div class="ui divider"></div>
</div>

	

	
	<div class="twelve wide column comment-list">
		<ui class="ui comments">
			<div class="comment">
				<a class="avatar" href="/aab">
					<img src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e">
				</a>
				<div class="content">
					<div class="ui top attached header">
						<span class="text grey"><a href="/aab">aab</a> commented <a href="#issue-64679"><span class="time-since" title="Sat, 04 Apr 2020 21:03:08 UTC">7 months ago</span></a></span>
						<div class="ui right actions">
							
						</div>
					</div>
					<div class="ui attached segment">
						<div class="render-content markdown has-emoji">
							
								<p>I had it activated since... i don&#39;t remember. Attachments in the two nodes i administer were showing with no proportion; through setconfig.php i managed to show them <em>a bit</em> better.
Disabling the plugin brings everything back to normal.</p>

							
						</div>
						<div class="raw-content hide">I had it activated since... i don&#39;t remember. Attachments in the two nodes i administer were showing with no proportion; through setconfig.php i managed to show them *a bit* better.
Disabling the plugin brings everything back to normal.</div>
						<div class="edit-content-zone hide" data-write="issue-64679-write" data-preview="issue-64679-preview" data-update-url="/diogo/gnu-social/issues/121/content" data-context="/diogo/gnu-social"></div>
					</div>
					
				</div>
			</div>

			
				

				
				
					<div class="comment" id="issuecomment-18254">
						<a class="avatar" href="/someonewithpc">
							<img src="https://seccdn.libravatar.org/avatar/89baac3327aebd79156eb67a9db545e6">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/someonewithpc">someonewithpc</a> commented <a href="#issuecomment-18254"><span class="time-since" title="Mon, 06 Apr 2020 16:21:19 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Collaborator
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>Wait, all attachments were affected by this plugin?</p>

									
								</div>
								<div class="raw-content hide">Wait, all attachments were affected by this plugin? </div>
								<div class="edit-content-zone hide" data-write="issuecomment-18254-write" data-preview="issuecomment-18254-preview" data-update-url="/diogo/gnu-social/comments/18254" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18256">
						<a class="avatar" href="/aab">
							<img src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/aab">aab</a> commented <a href="#issuecomment-18256"><span class="time-since" title="Mon, 06 Apr 2020 16:46:53 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Poster
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>Yes, both nodes showed that behaviour on all attachments.</p>

									
								</div>
								<div class="raw-content hide">Yes, both nodes showed that behaviour on all attachments.</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18256-write" data-preview="issuecomment-18256-preview" data-update-url="/diogo/gnu-social/comments/18256" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18257">
						<a class="avatar" href="/someonewithpc">
							<img src="https://seccdn.libravatar.org/avatar/89baac3327aebd79156eb67a9db545e6">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/someonewithpc">someonewithpc</a> commented <a href="#issuecomment-18257"><span class="time-since" title="Mon, 06 Apr 2020 16:55:13 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Collaborator
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p><a href="/aab" rel="nofollow">@aab</a> my latest commit should fix this issue, but I don&#39;t really have a way to test it</p>

									
								</div>
								<div class="raw-content hide">@aab my latest commit should fix this issue, but I don&#39;t really have a way to test it</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18257-write" data-preview="issuecomment-18257-preview" data-update-url="/diogo/gnu-social/comments/18257" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18259">
						<a class="avatar" href="/aab">
							<img src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/aab">aab</a> commented <a href="#issuecomment-18259"><span class="time-since" title="Mon, 06 Apr 2020 17:04:04 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Poster
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>I&#39;ve just tried on one of the nodes; as soon as the plugin is activated, proportion is gone.</p>

									
								</div>
								<div class="raw-content hide">I&#39;ve just tried on one of the nodes; as soon as the plugin is activated, proportion is gone.</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18259-write" data-preview="issuecomment-18259-preview" data-update-url="/diogo/gnu-social/comments/18259" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18260">
						<a class="avatar" href="/someonewithpc">
							<img src="https://seccdn.libravatar.org/avatar/89baac3327aebd79156eb67a9db545e6">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/someonewithpc">someonewithpc</a> commented <a href="#issuecomment-18260"><span class="time-since" title="Mon, 06 Apr 2020 17:23:20 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Collaborator
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>What do you mean by proportion? I might be misunderstanding you</p>

									
								</div>
								<div class="raw-content hide">What do you mean by proportion? I might be misunderstanding you</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18260-write" data-preview="issuecomment-18260-preview" data-update-url="/diogo/gnu-social/comments/18260" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18263">
						<a class="avatar" href="/aab">
							<img src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/aab">aab</a> commented <a href="#issuecomment-18263"><span class="time-since" title="Mon, 06 Apr 2020 17:39:54 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Poster
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>Ok, i&#39;ll try to explain better with images.</p>

<p>Now, the one without is specially distorted, as i I had to change width and height thumbnails with setconfig in order to &#34;fix&#34; it: most of thumbnails fit in 600x90, as they are links, and not images like this.
(Edit)Ah, and it doesn&#39;t depend on the theme used.</p>

									
								</div>
								<div class="raw-content hide">Ok, i&#39;ll try to explain better with images.

Now, the one without is specially distorted, as i I had to change width and height thumbnails with setconfig in order to &#34;fix&#34; it: most of thumbnails fit in 600x90, as they are links, and not images like this.
(Edit)Ah, and it doesn&#39;t depend on the theme used.



</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18263-write" data-preview="issuecomment-18263-preview" data-update-url="/diogo/gnu-social/comments/18263" data-context="/diogo/gnu-social"></div>
							</div>
							
								<div class="ui bottom attached segment">
									<div class="ui small images">
										
											<a target="_blank" href="/attachments/c2bec91b-d5ef-4ba5-b2cd-19e20af9f907">
												
													<img class="ui image" src="/attachments/c2bec91b-d5ef-4ba5-b2cd-19e20af9f907" title='Click to see &#34;With_Sensitive_Content.png&#34; in a new tab'>
												
											</a>
										
											<a target="_blank" href="/attachments/74c2b0f1-75b8-4c23-933f-00fcf1e73d4d">
												
													<img class="ui image" src="/attachments/74c2b0f1-75b8-4c23-933f-00fcf1e73d4d" title='Click to see &#34;Without_sensitive_content.png&#34; in a new tab'>
												
											</a>
										
									</div>
								</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18267">
						<a class="avatar" href="/diogo">
							<img src="/avatars/12290">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/diogo">Diogo Cordeiro</a> commented <a href="#issuecomment-18267"><span class="time-since" title="Tue, 07 Apr 2020 02:35:27 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Owner
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>Fixed with  <code><a href="https://notabug.org/diogo/gnu-social/commit/9b587ae4a3f9e2e6f9ec2f496f631d7aaf045417" rel="nofollow">9b587ae4a3</a></code></p>

<p>as seen in <a href="https://social.hackersatporto.com/conversation/5622#notice-11624" rel="nofollow">https://social.hackersatporto.com/conversation/5622#notice-11624</a></p>

									
								</div>
								<div class="raw-content hide">Fixed with https://notabug.org/diogo/gnu-social/commit/9b587ae4a3f9e2e6f9ec2f496f631d7aaf045417

as seen in https://social.hackersatporto.com/conversation/5622#notice-11624</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18267-write" data-preview="issuecomment-18267-preview" data-update-url="/diogo/gnu-social/comments/18267" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="event">
						<span class="octicon octicon-circle-slash"></span>
						<a class="ui avatar image" href="/diogo">
							<img src="/avatars/12290">
						</a>
						<span class="text grey"><a href="/diogo">diogo</a> closed <a id="event-18268" href="#event-18268"><span class="time-since" title="Tue, 07 Apr 2020 02:35:27 UTC">7 months ago</span></a></span>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18279">
						<a class="avatar" href="/aab">
							<img src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/aab">aab</a> commented <a href="#issuecomment-18279"><span class="time-since" title="Tue, 07 Apr 2020 09:44:45 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Poster
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>Ok, sorry to reopen this, just a couple of things:</p>

<ul>
<li>In the new README, this is the example:</li>
</ul>

<p><code> addPlugin(&#39;SensitiveContent&#39;, [&#39;hideforvisitors&#39; =&gt; true] </code></p>

<p>But it does not work unless i write</p>

<p><code> addPlugin(&#39;SensitiveContent&#39;, [&#39;hideforvisitors&#39; =&gt; true]); </code></p>

<ul>
<li>Appart from that, i keep having distorted images with the plugin. I know it has been fixed, and i know why they keep being distorted: before i knew this plugin was responsible, i used setconfig.php to give thumbnails a fixed measure of 600x90. I&#39;ve tried restoring them to the default value, 450x600:</li>
</ul>

<p><a href="https://khp.ignorelist.com/conversation/206812#notice-426573" rel="nofollow">https://khp.ignorelist.com/conversation/206812#notice-426573</a></p>

<p>Is there any way to set this to &#34;auto&#34; (or something like that), so the thumbnails get the proportion they need?</p>

									
								</div>
								<div class="raw-content hide">Ok, sorry to reopen this, just a couple of things:

- In the new README, this is the example: 

&lt;code&gt; addPlugin(&#39;SensitiveContent&#39;, [&#39;hideforvisitors&#39; =&gt; true] &lt;/code&gt;

But it does not work unless i write 

&lt;code&gt; addPlugin(&#39;SensitiveContent&#39;, [&#39;hideforvisitors&#39; =&gt; true]); &lt;/code&gt;

- Appart from that, i keep having distorted images with the plugin. I know it has been fixed, and i know why they keep being distorted: before i knew this plugin was responsible, i used setconfig.php to give thumbnails a fixed measure of 600x90. I&#39;ve tried restoring them to the default value, 450x600:

https://khp.ignorelist.com/conversation/206812#notice-426573

Is there any way to set this to &#34;auto&#34; (or something like that), so the thumbnails get the proportion they need?
</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18279-write" data-preview="issuecomment-18279-preview" data-update-url="/diogo/gnu-social/comments/18279" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18281">
						<a class="avatar" href="/diogo">
							<img src="/avatars/12290">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/diogo">Diogo Cordeiro</a> commented <a href="#issuecomment-18281"><span class="time-since" title="Tue, 07 Apr 2020 12:56:13 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Owner
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>Fixed the README.</p>

<p>run <code>./scripts/clean_thumbnails.php</code></p>

<p>Relevant settings concerning thumbs: <a href="https://notabug.org/diogo/gnu-social/src/nightly/lib/util/default.php#L285-L289" rel="nofollow">https://notabug.org/diogo/gnu-social/src/nightly/lib/util/default.php#L285-L289</a></p>

<ul>
<li><code>crop</code>: Crop to the given dimensions (not preserving aspect ratio)</li>
<li><code>maxsize</code>: width and height won&#39;t be larger than this value (just re-read the code and, I don&#39;t think this setting was needed at all, it would be more helpful if it was an actual max size for a thumb file or smth...)</li>
<li><code>width</code>: Max width</li>
<li><code>height</code>: Max height</li>
<li><code>upscale</code>: Whether to allow a thumb to acquire greater dimensions than its original file or not</li>
</ul>

									
								</div>
								<div class="raw-content hide">Fixed the README.

run `./scripts/clean_thumbnails.php`

Relevant settings concerning thumbs: https://notabug.org/diogo/gnu-social/src/nightly/lib/util/default.php#L285-L289

- `crop`: Crop to the given dimensions (not preserving aspect ratio)
- `maxsize`: width and height won&#39;t be larger than this value (just re-read the code and, I don&#39;t think this setting was needed at all, it would be more helpful if it was an actual max size for a thumb file or smth...)
- `width`: Max width
- `height`: Max height
- `upscale`: Whether to allow a thumb to acquire greater dimensions than its original file or not</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18281-write" data-preview="issuecomment-18281-preview" data-update-url="/diogo/gnu-social/comments/18281" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-18282">
						<a class="avatar" href="/aab">
							<img src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/aab">aab</a> commented <a href="#issuecomment-18282"><span class="time-since" title="Tue, 07 Apr 2020 13:25:37 UTC">7 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Poster
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>It seems i got it just like the default values:</p>

<pre><code>thumbnail            dir                  &#39;/var/www/html/file/thumb&#39;
thumbnail            path                 NULL
thumbnail            server               NULL
thumbnail            crop                 &#39;false&#39;
thumbnail            maxsize              1000
thumbnail            width                &#39;450&#39;
thumbnail            height               &#39;600&#39;
thumbnail            upscale              &#39;false&#39;
thumbnail            animated             &#39;false&#39;
</code></pre>

<p>The only difference i can see is that &#34;dir&#34; is defined.</p>

<p>I&#39;ve executed clean_thumbnails, but there has been no change.</p>

<p>Just in case, i&#39;ve looked in db, everything seems fine...</p>

<pre><code class="language-sh">MariaDB [gnusocial]&gt; select * from config where section = &#39;thumbnail&#39;;
+-----------+----------+-------+
| section   | setting  | value |
+-----------+----------+-------+
| thumbnail | animated | false |
| thumbnail | crop     | false |
| thumbnail | height   | 600   |
| thumbnail | upscale  | false |
| thumbnail | width    | 450   |
+-----------+----------+-------+
</code></pre>

									
								</div>
								<div class="raw-content hide">It seems i got it just like the default values:

````
thumbnail            dir                  &#39;/var/www/html/file/thumb&#39;
thumbnail            path                 NULL
thumbnail            server               NULL
thumbnail            crop                 &#39;false&#39;
thumbnail            maxsize              1000
thumbnail            width                &#39;450&#39;
thumbnail            height               &#39;600&#39;
thumbnail            upscale              &#39;false&#39;
thumbnail            animated             &#39;false&#39;
````

The only difference i can see is that &#34;dir&#34; is defined.

I&#39;ve executed clean_thumbnails, but there has been no change.

Just in case, i&#39;ve looked in db, everything seems fine...

````sh
MariaDB [gnusocial]&gt; select * from config where section = &#39;thumbnail&#39;;
&#43;-----------&#43;----------&#43;-------&#43;
| section   | setting  | value |
&#43;-----------&#43;----------&#43;-------&#43;
| thumbnail | animated | false |
| thumbnail | crop     | false |
| thumbnail | height   | 600   |
| thumbnail | upscale  | false |
| thumbnail | width    | 450   |
&#43;-----------&#43;----------&#43;-------&#43;
````
</div>
								<div class="edit-content-zone hide" data-write="issuecomment-18282-write" data-preview="issuecomment-18282-preview" data-update-url="/diogo/gnu-social/comments/18282" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			
				

				
				
					<div class="comment" id="issuecomment-19931">
						<a class="avatar" href="/aab">
							<img src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e">
						</a>
						<div class="content">
							<div class="ui top attached header">
								<span class="text grey"><a href="/aab">aab</a> commented <a href="#issuecomment-19931"><span class="time-since" title="Fri, 10 Jul 2020 08:13:36 UTC">4 months ago</span></a></span>
								<div class="ui right actions">
									
										<div class="item tag">
											
												Poster
											
										</div>
									
									
								</div>
							</div>
							<div class="ui attached segment">
								<div class="render-content markdown has-emoji">
									
										<p>I&#39;ve checked the plugin today after all this time, i&#39;m afraid there&#39;s still disproportion in images: <a href="https://gnusocial.net/conversation/4963984#notice-8172421" rel="nofollow">https://gnusocial.net/conversation/4963984#notice-8172421</a></p>

<p>setconfig.php -a | grep thumbnail gives</p>

<pre><code>thumbnail            dir                  &#39;/var/www/gnusocial/file/thumb&#39;
thumbnail            path                 NULL
thumbnail            server               NULL
thumbnail            crop                 &#39;false&#39;
thumbnail            maxsize              1000
thumbnail            width                450
thumbnail            height               &#39;600&#39;
thumbnail            upscale              &#39;false&#39;
thumbnail            animated             &#39;false&#39;
thumbnail            file_quota           &#39;2097152&#39;
thumbnail            process_links        &#39;true&#39;
thumbnail            show_thumbs          &#39;true&#39;
</code></pre>

<pre><code>MariaDB [gnusocial]&gt; select * from config where section = &#39;thumbnail&#39;;
+-----------+---------------+---------+
| section   | setting       | value   |
+-----------+---------------+---------+
| thumbnail | animated      | false   |
| thumbnail | crop          | false   |
| thumbnail | file_quota    | 2097152 |
| thumbnail | height        | 600     |
| thumbnail | process_links | true    |
| thumbnail | show_thumbs   | true    |
| thumbnail | upscale       | false   |
+-----------+---------------+---------+
</code></pre>

<p>I&#39;ve also run clean_thumbnails. Anything else i&#39;m missing?</p>

									
								</div>
								<div class="raw-content hide">I&#39;ve checked the plugin today after all this time, i&#39;m afraid there&#39;s still disproportion in images: https://gnusocial.net/conversation/4963984#notice-8172421

setconfig.php -a | grep thumbnail gives
````
thumbnail            dir                  &#39;/var/www/gnusocial/file/thumb&#39;
thumbnail            path                 NULL
thumbnail            server               NULL
thumbnail            crop                 &#39;false&#39;
thumbnail            maxsize              1000
thumbnail            width                450
thumbnail            height               &#39;600&#39;
thumbnail            upscale              &#39;false&#39;
thumbnail            animated             &#39;false&#39;
thumbnail            file_quota           &#39;2097152&#39;
thumbnail            process_links        &#39;true&#39;
thumbnail            show_thumbs          &#39;true&#39;
````
````
MariaDB [gnusocial]&gt; select * from config where section = &#39;thumbnail&#39;;
&#43;-----------&#43;---------------&#43;---------&#43;
| section   | setting       | value   |
&#43;-----------&#43;---------------&#43;---------&#43;
| thumbnail | animated      | false   |
| thumbnail | crop          | false   |
| thumbnail | file_quota    | 2097152 |
| thumbnail | height        | 600     |
| thumbnail | process_links | true    |
| thumbnail | show_thumbs   | true    |
| thumbnail | upscale       | false   |
&#43;-----------&#43;---------------&#43;---------&#43;
````

I&#39;ve also run clean_thumbnails. Anything else i&#39;m missing?


</div>
								<div class="edit-content-zone hide" data-write="issuecomment-19931-write" data-preview="issuecomment-19931-preview" data-update-url="/diogo/gnu-social/comments/19931" data-context="/diogo/gnu-social"></div>
							</div>
							
						</div>
					</div>
				

			

			

			
				<div class="ui warning message">
					<a href="/user/login?redirect_to=/diogo/gnu-social/issues/121">Sign in</a> to join this conversation.
				</div>
			
		</ui>
	</div>

	<div class="four wide column">
		<div class="ui segment metas">
			<div class="ui disabled floating jump select-label dropdown">
				<span class="text">
					<strong>Labels</strong>
					<span class="octicon octicon-gear"></span>
				</span>
				<div class="filter menu" data-action="update" data-update-url="/diogo/gnu-social/issues/121/label">
					<div class="no-select item">Clear labels</div>
					
						<a class=" item" href="#" data-id="1564" data-id-selector="#label_1564"><span class="octicon "></span><span class="label color" style="background-color: #fbca04"></span> bounty</a>
					
						<a class="checked item" href="#" data-id="1483" data-id-selector="#label_1483"><span class="octicon octicon-check"></span><span class="label color" style="background-color: #ee0701"></span> bug</a>
					
						<a class=" item" href="#" data-id="1484" data-id-selector="#label_1484"><span class="octicon "></span><span class="label color" style="background-color: #cccccc"></span> duplicate</a>
					
						<a class=" item" href="#" data-id="1485" data-id-selector="#label_1485"><span class="octicon "></span><span class="label color" style="background-color: #84b6eb"></span> enhancement</a>
					
						<a class=" item" href="#" data-id="1486" data-id-selector="#label_1486"><span class="octicon "></span><span class="label color" style="background-color: #128a0c"></span> help wanted</a>
					
						<a class=" item" href="#" data-id="1487" data-id-selector="#label_1487"><span class="octicon "></span><span class="label color" style="background-color: #e6e6e6"></span> invalid</a>
					
						<a class=" item" href="#" data-id="1488" data-id-selector="#label_1488"><span class="octicon "></span><span class="label color" style="background-color: #cc317c"></span> question</a>
					
						<a class=" item" href="#" data-id="1565" data-id-selector="#label_1565"><span class="octicon "></span><span class="label color" style="background-color: #d4c5f9"></span> RFC</a>
					
						<a class=" item" href="#" data-id="1841" data-id-selector="#label_1841"><span class="octicon "></span><span class="label color" style="background-color: #0052cc"></span> v3</a>
					
						<a class=" item" href="#" data-id="1489" data-id-selector="#label_1489"><span class="octicon "></span><span class="label color" style="background-color: #ffffff"></span> wontfix</a>
					
				</div>
			</div>
			<div class="ui labels list">
				<span class="no-select item hide">No Label</span>
				
					<div class="item">
						<a class="ui label hide" id="label_1564" href="/diogo/gnu-social/issues?labels=1564" style="color: #000; background-color: #fbca04">bounty</a>
					</div>

				
					<div class="item">
						<a class="ui label " id="label_1483" href="/diogo/gnu-social/issues?labels=1483" style="color: #fff; background-color: #ee0701">bug</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1484" href="/diogo/gnu-social/issues?labels=1484" style="color: #000; background-color: #cccccc">duplicate</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1485" href="/diogo/gnu-social/issues?labels=1485" style="color: #000; background-color: #84b6eb">enhancement</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1486" href="/diogo/gnu-social/issues?labels=1486" style="color: #fff; background-color: #128a0c">help wanted</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1487" href="/diogo/gnu-social/issues?labels=1487" style="color: #000; background-color: #e6e6e6">invalid</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1488" href="/diogo/gnu-social/issues?labels=1488" style="color: #fff; background-color: #cc317c">question</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1565" href="/diogo/gnu-social/issues?labels=1565" style="color: #000; background-color: #d4c5f9">RFC</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1841" href="/diogo/gnu-social/issues?labels=1841" style="color: #fff; background-color: #0052cc">v3</a>
					</div>

				
					<div class="item">
						<a class="ui label hide" id="label_1489" href="/diogo/gnu-social/issues?labels=1489" style="color: #000; background-color: #ffffff">wontfix</a>
					</div>

				
			</div>

			<div class="ui divider"></div>

			<div class="ui disabled floating jump select-milestone dropdown">
				<span class="text">
					<strong>Milestone</strong>
					<span class="octicon octicon-gear"></span>
				</span>
				<div class="menu" data-action="update" data-update-url="/diogo/gnu-social/issues/121/milestone">
					<div class="no-select item">Clear milestone</div>
					
					
				</div>
			</div>
			<div class="ui select-milestone list">
				<span class="no-select item ">No Milestone</span>
				<div class="selected">
					
				</div>
			</div>

			<div class="ui divider"></div>

			<input id="assignee_id" name="assignee_id" type="hidden" value="">
			<div class="ui disabled floating jump select-assignee dropdown">
				<span class="text">
					<strong>Assignee</strong>
					<span class="octicon octicon-gear"></span>
				</span>
				<div class="menu" data-action="update" data-update-url="/diogo/gnu-social/issues/121/assignee">
					<div class="no-select item">Clear assignee</div>
					
				</div>
			</div>
			<div class="ui select-assignee list">
				<span class="no-select item hide">No assignee</span>
				<div class="selected">
					
						<a class="item" href="/diogo/gnu-social/issues?assignee=12290"><img class="ui avatar image" src="/avatars/12290"> Diogo Cordeiro</a>
					
				</div>
			</div>

			<div class="ui divider"></div>

			<div class="ui participants">
				<span class="text"><strong>3 Participants</strong></span>
				<div>
					
						<a href="/aab">
							<img class="ui avatar image poping up" src="https://seccdn.libravatar.org/avatar/8e0ba2a1c26a4ecd23662fad4af3dc5e" data-content="aab" data-position="top center" data-variation="small inverted">
						</a>
					
						<a href="/someonewithpc">
							<img class="ui avatar image poping up" src="https://seccdn.libravatar.org/avatar/89baac3327aebd79156eb67a9db545e6" data-content="someonewithpc" data-position="top center" data-variation="small inverted">
						</a>
					
						<a href="/diogo">
							<img class="ui avatar image poping up" src="/avatars/12290" data-content="Diogo Cordeiro" data-position="top center" data-variation="small inverted">
						</a>
					
				</div>
			</div>
		</div>
	</div>
</div>

<div class="hide" id="edit-content-form">
	<div class="ui comment form">
		<div class="ui top attached tabular menu">
			<a class="active write item">Write</a>
			<a class="preview item" data-url="/api/v1/markdown" data-context="/diogo/gnu-social">Preview</a>
		</div>
		<div class="ui bottom attached active write tab segment">
			<textarea tabindex="1" id="content" name="content"></textarea>
		</div>
		<div class="ui bottom attached tab preview segment markdown">
			Loading...
		</div>
		<div class="text right edit buttons">
			<div class="ui basic blue cancel button" tabindex="3">Cancel</div>
			<div class="ui green save button" tabindex="2">Save</div>
		</div>
	</div>
</div>

<div class="hide" id="no-content">
	<span class="no-content">There is no content yet.</span>
</div>

			</div>
		
	</div>
</div>

	</div>
	<footer>
		<div class="ui container">
			<div class="ui left">



				<a href="/tos">Terms of Service</a>
				&bull;
				<a href="/about">About us</a>
				&bull;
				<a href="/outages">Outages</a>
				&bull;
				<a href="/hp/gogs/issues">Report a problem</a>
				&bull;
				<a href="/assets/librejs/librejs.html" data-jslicense="1">Javascript licenses</a>
				&bull;
				<a href="/fingerprints">SSH Fingerprints</a>



			</div>
			<div class="ui right links">
				
				<div class="ui language bottom floating slide up dropdown link item">
					<i class="world icon"></i>
					<div class="text">English</div>
					<div class="menu">
						
							<a class="item active selected" href="#">English</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=zh-CN">简体中文</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=zh-HK">繁體中文（香港）</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=zh-TW">繁體中文（臺灣）</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=de-DE">Deutsch</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=fr-FR">français</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=nl-NL">Nederlands</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=lv-LV">latviešu</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=ru-RU">русский</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=ja-JP">日本語</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=es-ES">español</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=pt-BR">português do Brasil</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=pl-PL">polski</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=bg-BG">български</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=it-IT">italiano</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=fi-FI">suomi</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=tr-TR">Türkçe</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=cs-CZ">čeština</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=sr-SP">српски</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=sv-SE">svenska</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=ko-KR">한국어</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=gl-ES">galego</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=uk-UA">українська</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=en-GB">English (United Kingdom)</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=hu-HU">Magyar</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=sk-SK">Slovenčina</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=id-ID">Indonesian</a>
						
							<a class="item " href="/diogo/gnu-social/issues/121?lang=fa-IR">Persian</a>
						
					</div>
				</div>



				
			</div>
		</div>
	</footer>
</body>



	<link rel="stylesheet" href="/plugins/highlight-9.6.0/github.css">
	<script src="/plugins/highlight-9.6.0/highlight.pack.js"></script>




	<link rel="stylesheet" href="/plugins/dropzone-4.2.0/dropzone.css">
	<script src="/plugins/dropzone-4.2.0/dropzone.js"></script>

<script src="/js/libs/emojify-1.1.0.min.js"></script>
<script src="/js/libs/clipboard-1.5.9.min.js"></script>
	
</html>
121 43 KB Permalink History Raw

121 43 KB

Permalink History Raw
