ChangeLog 992 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250125112521253125412551256125712581259126012611262126312641265126612671268126912701271127212731274127512761277127812791280128112821283128412851286128712881289129012911292129312941295129612971298129913001301130213031304130513061307130813091310131113121313131413151316131713181319132013211322132313241325132613271328132913301331133213331334133513361337133813391340134113421343134413451346134713481349135013511352135313541355135613571358135913601361136213631364136513661367136813691370137113721373137413751376137713781379138013811382138313841385138613871388138913901391139213931394139513961397139813991400140114021403140414051406140714081409141014111412141314141415141614171418141914201421142214231424142514261427142814291430143114321433143414351436143714381439144014411442144314441445144614471448144914501451145214531454145514561457145814591460146114621463146414651466146714681469147014711472147314741475147614771478147914801481148214831484148514861487148814891490149114921493149414951496149714981499150015011502150315041505150615071508150915101511151215131514151515161517151815191520152115221523152415251526152715281529153015311532153315341535153615371538153915401541154215431544154515461547154815491550155115521553155415551556155715581559156015611562156315641565156615671568156915701571157215731574157515761577157815791580158115821583158415851586158715881589159015911592159315941595159615971598159916001601160216031604160516061607160816091610161116121613161416151616161716181619162016211622162316241625162616271628162916301631163216331634163516361637163816391640164116421643164416451646164716481649165016511652165316541655165616571658165916601661166216631664166516661667166816691670167116721673167416751676167716781679168016811682168316841685168616871688168916901691169216931694169516961697169816991700170117021703170417051706170717081709171017111712171317141715171617171718171917201721172217231724172517261727172817291730173117321733173417351736173717381739174017411742174317441745174617471748174917501751175217531754175517561757175817591760176117621763176417651766176717681769177017711772177317741775177617771778177917801781178217831784178517861787178817891790179117921793179417951796179717981799180018011802180318041805180618071808180918101811181218131814181518161817181818191820182118221823182418251826182718281829183018311832183318341835183618371838183918401841184218431844184518461847184818491850185118521853185418551856185718581859186018611862186318641865186618671868186918701871187218731874187518761877187818791880188118821883188418851886188718881889189018911892189318941895189618971898189919001901190219031904190519061907190819091910191119121913191419151916191719181919192019211922192319241925192619271928192919301931193219331934193519361937193819391940194119421943194419451946194719481949195019511952195319541955195619571958195919601961196219631964196519661967196819691970197119721973197419751976197719781979198019811982198319841985198619871988198919901991199219931994199519961997199819992000200120022003200420052006200720082009201020112012201320142015201620172018201920202021202220232024202520262027202820292030203120322033203420352036203720382039204020412042204320442045204620472048204920502051205220532054205520562057205820592060206120622063206420652066206720682069207020712072207320742075207620772078207920802081208220832084208520862087208820892090209120922093209420952096209720982099210021012102210321042105210621072108210921102111211221132114211521162117211821192120212121222123212421252126212721282129213021312132213321342135213621372138213921402141214221432144214521462147214821492150215121522153215421552156215721582159216021612162216321642165216621672168216921702171217221732174217521762177217821792180218121822183218421852186218721882189219021912192219321942195219621972198219922002201220222032204220522062207220822092210221122122213221422152216221722182219222022212222222322242225222622272228222922302231223222332234223522362237223822392240224122422243224422452246224722482249225022512252225322542255225622572258225922602261226222632264226522662267226822692270227122722273227422752276227722782279228022812282228322842285228622872288228922902291229222932294229522962297229822992300230123022303230423052306230723082309231023112312231323142315231623172318231923202321232223232324232523262327232823292330233123322333233423352336233723382339234023412342234323442345234623472348234923502351235223532354235523562357235823592360236123622363236423652366236723682369237023712372237323742375237623772378237923802381238223832384238523862387238823892390239123922393239423952396239723982399240024012402240324042405240624072408240924102411241224132414241524162417241824192420242124222423242424252426242724282429243024312432243324342435243624372438243924402441244224432444244524462447244824492450245124522453245424552456245724582459246024612462246324642465246624672468246924702471247224732474247524762477247824792480248124822483248424852486248724882489249024912492249324942495249624972498249925002501250225032504250525062507250825092510251125122513251425152516251725182519252025212522252325242525252625272528252925302531253225332534253525362537253825392540254125422543254425452546254725482549255025512552255325542555255625572558255925602561256225632564256525662567256825692570257125722573257425752576257725782579258025812582258325842585258625872588258925902591259225932594259525962597259825992600260126022603260426052606260726082609261026112612261326142615261626172618261926202621262226232624262526262627262826292630263126322633263426352636263726382639264026412642264326442645264626472648264926502651265226532654265526562657265826592660266126622663266426652666266726682669267026712672267326742675267626772678267926802681268226832684268526862687268826892690269126922693269426952696269726982699270027012702270327042705270627072708270927102711271227132714271527162717271827192720272127222723272427252726272727282729273027312732273327342735273627372738273927402741274227432744274527462747274827492750275127522753275427552756275727582759276027612762276327642765276627672768276927702771277227732774277527762777277827792780278127822783278427852786278727882789279027912792279327942795279627972798279928002801280228032804280528062807280828092810281128122813281428152816281728182819282028212822282328242825282628272828282928302831283228332834283528362837283828392840284128422843284428452846284728482849285028512852285328542855285628572858285928602861286228632864286528662867286828692870287128722873287428752876287728782879288028812882288328842885288628872888288928902891289228932894289528962897289828992900290129022903290429052906290729082909291029112912291329142915291629172918291929202921292229232924292529262927292829292930293129322933293429352936293729382939294029412942294329442945294629472948294929502951295229532954295529562957295829592960296129622963296429652966296729682969297029712972297329742975297629772978297929802981298229832984298529862987298829892990299129922993299429952996299729982999300030013002300330043005300630073008300930103011301230133014301530163017301830193020302130223023302430253026302730283029303030313032303330343035303630373038303930403041304230433044304530463047304830493050305130523053305430553056305730583059306030613062306330643065306630673068306930703071307230733074307530763077307830793080308130823083308430853086308730883089309030913092309330943095309630973098309931003101310231033104310531063107310831093110311131123113311431153116311731183119312031213122312331243125312631273128312931303131313231333134313531363137313831393140314131423143314431453146314731483149315031513152315331543155315631573158315931603161316231633164316531663167316831693170317131723173317431753176317731783179318031813182318331843185318631873188318931903191319231933194319531963197319831993200320132023203320432053206320732083209321032113212321332143215321632173218321932203221322232233224322532263227322832293230323132323233323432353236323732383239324032413242324332443245324632473248324932503251325232533254325532563257325832593260326132623263326432653266326732683269327032713272327332743275327632773278327932803281328232833284328532863287328832893290329132923293329432953296329732983299330033013302330333043305330633073308330933103311331233133314331533163317331833193320332133223323332433253326332733283329333033313332333333343335333633373338333933403341334233433344334533463347334833493350335133523353335433553356335733583359336033613362336333643365336633673368336933703371337233733374337533763377337833793380338133823383338433853386338733883389339033913392339333943395339633973398339934003401340234033404340534063407340834093410341134123413341434153416341734183419342034213422342334243425342634273428342934303431343234333434343534363437343834393440344134423443344434453446344734483449345034513452345334543455345634573458345934603461346234633464346534663467346834693470347134723473347434753476347734783479348034813482348334843485348634873488348934903491349234933494349534963497349834993500350135023503350435053506350735083509351035113512351335143515351635173518351935203521352235233524352535263527352835293530353135323533353435353536353735383539354035413542354335443545354635473548354935503551355235533554355535563557355835593560356135623563356435653566356735683569357035713572357335743575357635773578357935803581358235833584358535863587358835893590359135923593359435953596359735983599360036013602360336043605360636073608360936103611361236133614361536163617361836193620362136223623362436253626362736283629363036313632363336343635363636373638363936403641364236433644364536463647364836493650365136523653365436553656365736583659366036613662366336643665366636673668366936703671367236733674367536763677367836793680368136823683368436853686368736883689369036913692369336943695369636973698369937003701370237033704370537063707370837093710371137123713371437153716371737183719372037213722372337243725372637273728372937303731373237333734373537363737373837393740374137423743374437453746374737483749375037513752375337543755375637573758375937603761376237633764376537663767376837693770377137723773377437753776377737783779378037813782378337843785378637873788378937903791379237933794379537963797379837993800380138023803380438053806380738083809381038113812381338143815381638173818381938203821382238233824382538263827382838293830383138323833383438353836383738383839384038413842384338443845384638473848384938503851385238533854385538563857385838593860386138623863386438653866386738683869387038713872387338743875387638773878387938803881388238833884388538863887388838893890389138923893389438953896389738983899390039013902390339043905390639073908390939103911391239133914391539163917391839193920392139223923392439253926392739283929393039313932393339343935393639373938393939403941394239433944394539463947394839493950395139523953395439553956395739583959396039613962396339643965396639673968396939703971397239733974397539763977397839793980398139823983398439853986398739883989399039913992399339943995399639973998399940004001400240034004400540064007400840094010401140124013401440154016401740184019402040214022402340244025402640274028402940304031403240334034403540364037403840394040404140424043404440454046404740484049405040514052405340544055405640574058405940604061406240634064406540664067406840694070407140724073407440754076407740784079408040814082408340844085408640874088408940904091409240934094409540964097409840994100410141024103410441054106410741084109411041114112411341144115411641174118411941204121412241234124412541264127412841294130413141324133413441354136413741384139414041414142414341444145414641474148414941504151415241534154415541564157415841594160416141624163416441654166416741684169417041714172417341744175417641774178417941804181418241834184418541864187418841894190419141924193419441954196419741984199420042014202420342044205420642074208420942104211421242134214421542164217421842194220422142224223422442254226422742284229423042314232423342344235423642374238423942404241424242434244424542464247424842494250425142524253425442554256425742584259426042614262426342644265426642674268426942704271427242734274427542764277427842794280428142824283428442854286428742884289429042914292429342944295429642974298429943004301430243034304430543064307430843094310431143124313431443154316431743184319432043214322432343244325432643274328432943304331433243334334433543364337433843394340434143424343434443454346434743484349435043514352435343544355435643574358435943604361436243634364436543664367436843694370437143724373437443754376437743784379438043814382438343844385438643874388438943904391439243934394439543964397439843994400440144024403440444054406440744084409441044114412441344144415441644174418441944204421442244234424442544264427442844294430443144324433443444354436443744384439444044414442444344444445444644474448444944504451445244534454445544564457445844594460446144624463446444654466446744684469447044714472447344744475447644774478447944804481448244834484448544864487448844894490449144924493449444954496449744984499450045014502450345044505450645074508450945104511451245134514451545164517451845194520452145224523452445254526452745284529453045314532453345344535453645374538453945404541454245434544454545464547454845494550455145524553455445554556455745584559456045614562456345644565456645674568456945704571457245734574457545764577457845794580458145824583458445854586458745884589459045914592459345944595459645974598459946004601460246034604460546064607460846094610461146124613461446154616461746184619462046214622462346244625462646274628462946304631463246334634463546364637463846394640464146424643464446454646464746484649465046514652465346544655465646574658465946604661466246634664466546664667466846694670467146724673467446754676467746784679468046814682468346844685468646874688468946904691469246934694469546964697469846994700470147024703470447054706470747084709471047114712471347144715471647174718471947204721472247234724472547264727472847294730473147324733473447354736473747384739474047414742474347444745474647474748474947504751475247534754475547564757475847594760476147624763476447654766476747684769477047714772477347744775477647774778477947804781478247834784478547864787478847894790479147924793479447954796479747984799480048014802480348044805480648074808480948104811481248134814481548164817481848194820482148224823482448254826482748284829483048314832483348344835483648374838483948404841484248434844484548464847484848494850485148524853485448554856485748584859486048614862486348644865486648674868486948704871487248734874487548764877487848794880488148824883488448854886488748884889489048914892489348944895489648974898489949004901490249034904490549064907490849094910491149124913491449154916491749184919492049214922492349244925492649274928492949304931493249334934493549364937493849394940494149424943494449454946494749484949495049514952495349544955495649574958495949604961496249634964496549664967496849694970497149724973497449754976497749784979498049814982498349844985498649874988498949904991499249934994499549964997499849995000500150025003500450055006500750085009501050115012501350145015501650175018501950205021502250235024502550265027502850295030503150325033503450355036503750385039504050415042504350445045504650475048504950505051505250535054505550565057505850595060506150625063506450655066506750685069507050715072507350745075507650775078507950805081508250835084508550865087508850895090509150925093509450955096509750985099510051015102510351045105510651075108510951105111511251135114511551165117511851195120512151225123512451255126512751285129513051315132513351345135513651375138513951405141514251435144514551465147514851495150515151525153515451555156515751585159516051615162516351645165516651675168516951705171517251735174517551765177517851795180518151825183518451855186518751885189519051915192519351945195519651975198519952005201520252035204520552065207520852095210521152125213521452155216521752185219522052215222522352245225522652275228522952305231523252335234523552365237523852395240524152425243524452455246524752485249525052515252525352545255525652575258525952605261526252635264526552665267526852695270527152725273527452755276527752785279528052815282528352845285528652875288528952905291529252935294529552965297529852995300530153025303530453055306530753085309531053115312531353145315531653175318531953205321532253235324532553265327532853295330533153325333533453355336533753385339534053415342534353445345534653475348534953505351535253535354535553565357535853595360536153625363536453655366536753685369537053715372537353745375537653775378537953805381538253835384538553865387538853895390539153925393539453955396539753985399540054015402540354045405540654075408540954105411541254135414541554165417541854195420542154225423542454255426542754285429543054315432543354345435543654375438543954405441544254435444544554465447544854495450545154525453545454555456545754585459546054615462546354645465546654675468546954705471547254735474547554765477547854795480548154825483548454855486548754885489549054915492549354945495549654975498549955005501550255035504550555065507550855095510551155125513551455155516551755185519552055215522552355245525552655275528552955305531553255335534553555365537553855395540554155425543554455455546554755485549555055515552555355545555555655575558555955605561556255635564556555665567556855695570557155725573557455755576557755785579558055815582558355845585558655875588558955905591559255935594559555965597559855995600560156025603560456055606560756085609561056115612561356145615561656175618561956205621562256235624562556265627562856295630563156325633563456355636563756385639564056415642564356445645564656475648564956505651565256535654565556565657565856595660566156625663566456655666566756685669567056715672567356745675567656775678567956805681568256835684568556865687568856895690569156925693569456955696569756985699570057015702570357045705570657075708570957105711571257135714571557165717571857195720572157225723572457255726572757285729573057315732573357345735573657375738573957405741574257435744574557465747574857495750575157525753575457555756575757585759576057615762576357645765576657675768576957705771577257735774577557765777577857795780578157825783578457855786578757885789579057915792579357945795579657975798579958005801580258035804580558065807580858095810581158125813581458155816581758185819582058215822582358245825582658275828582958305831583258335834583558365837583858395840584158425843584458455846584758485849585058515852585358545855585658575858585958605861586258635864586558665867586858695870587158725873587458755876587758785879588058815882588358845885588658875888588958905891589258935894589558965897589858995900590159025903590459055906590759085909591059115912591359145915591659175918591959205921592259235924592559265927592859295930593159325933593459355936593759385939594059415942594359445945594659475948594959505951595259535954595559565957595859595960596159625963596459655966596759685969597059715972597359745975597659775978597959805981598259835984598559865987598859895990599159925993599459955996599759985999600060016002600360046005600660076008600960106011601260136014601560166017601860196020602160226023602460256026602760286029603060316032603360346035603660376038603960406041604260436044604560466047604860496050605160526053605460556056605760586059606060616062606360646065606660676068606960706071607260736074607560766077607860796080608160826083608460856086608760886089609060916092609360946095609660976098609961006101610261036104610561066107610861096110611161126113611461156116611761186119612061216122612361246125612661276128612961306131613261336134613561366137613861396140614161426143614461456146614761486149615061516152615361546155615661576158615961606161616261636164616561666167616861696170617161726173617461756176617761786179618061816182618361846185618661876188618961906191619261936194619561966197619861996200620162026203620462056206620762086209621062116212621362146215621662176218621962206221622262236224622562266227622862296230623162326233623462356236623762386239624062416242624362446245624662476248624962506251625262536254625562566257625862596260626162626263626462656266626762686269627062716272627362746275627662776278627962806281628262836284628562866287628862896290629162926293629462956296629762986299630063016302630363046305630663076308630963106311631263136314631563166317631863196320632163226323632463256326632763286329633063316332633363346335633663376338633963406341634263436344634563466347634863496350635163526353635463556356635763586359636063616362636363646365636663676368636963706371637263736374637563766377637863796380638163826383638463856386638763886389639063916392639363946395639663976398639964006401640264036404640564066407640864096410641164126413641464156416641764186419642064216422642364246425642664276428642964306431643264336434643564366437643864396440644164426443644464456446644764486449645064516452645364546455645664576458645964606461646264636464646564666467646864696470647164726473647464756476647764786479648064816482648364846485648664876488648964906491649264936494649564966497649864996500650165026503650465056506650765086509651065116512651365146515651665176518651965206521652265236524652565266527652865296530653165326533653465356536653765386539654065416542654365446545654665476548654965506551655265536554655565566557655865596560656165626563656465656566656765686569657065716572657365746575657665776578657965806581658265836584658565866587658865896590659165926593659465956596659765986599660066016602660366046605660666076608660966106611661266136614661566166617661866196620662166226623662466256626662766286629663066316632663366346635663666376638663966406641664266436644664566466647664866496650665166526653665466556656665766586659666066616662666366646665666666676668666966706671667266736674667566766677667866796680668166826683668466856686668766886689669066916692669366946695669666976698669967006701670267036704670567066707670867096710671167126713671467156716671767186719672067216722672367246725672667276728672967306731673267336734673567366737673867396740674167426743674467456746674767486749675067516752675367546755675667576758675967606761676267636764676567666767676867696770677167726773677467756776677767786779678067816782678367846785678667876788678967906791679267936794679567966797679867996800680168026803680468056806680768086809681068116812681368146815681668176818681968206821682268236824682568266827682868296830683168326833683468356836683768386839684068416842684368446845684668476848684968506851685268536854685568566857685868596860686168626863686468656866686768686869687068716872687368746875687668776878687968806881688268836884688568866887688868896890689168926893689468956896689768986899690069016902690369046905690669076908690969106911691269136914691569166917691869196920692169226923692469256926692769286929693069316932693369346935693669376938693969406941694269436944694569466947694869496950695169526953695469556956695769586959696069616962696369646965696669676968696969706971697269736974697569766977697869796980698169826983698469856986698769886989699069916992699369946995699669976998699970007001700270037004700570067007700870097010701170127013701470157016701770187019702070217022702370247025702670277028702970307031703270337034703570367037703870397040704170427043704470457046704770487049705070517052705370547055705670577058705970607061706270637064706570667067706870697070707170727073707470757076707770787079708070817082708370847085708670877088708970907091709270937094709570967097709870997100710171027103710471057106710771087109711071117112711371147115711671177118711971207121712271237124712571267127712871297130713171327133713471357136713771387139714071417142714371447145714671477148714971507151715271537154715571567157715871597160716171627163716471657166716771687169717071717172717371747175717671777178717971807181718271837184718571867187718871897190719171927193719471957196719771987199720072017202720372047205720672077208720972107211721272137214721572167217721872197220722172227223722472257226722772287229723072317232723372347235723672377238723972407241724272437244724572467247724872497250725172527253725472557256725772587259726072617262726372647265726672677268726972707271727272737274727572767277727872797280728172827283728472857286728772887289729072917292729372947295729672977298729973007301730273037304730573067307730873097310731173127313731473157316731773187319732073217322732373247325732673277328732973307331733273337334733573367337733873397340734173427343734473457346734773487349735073517352735373547355735673577358735973607361736273637364736573667367736873697370737173727373737473757376737773787379738073817382738373847385738673877388738973907391739273937394739573967397739873997400740174027403740474057406740774087409741074117412741374147415741674177418741974207421742274237424742574267427742874297430743174327433743474357436743774387439744074417442744374447445744674477448744974507451745274537454745574567457745874597460746174627463746474657466746774687469747074717472747374747475747674777478747974807481748274837484748574867487748874897490749174927493749474957496749774987499750075017502750375047505750675077508750975107511751275137514751575167517751875197520752175227523752475257526752775287529753075317532753375347535753675377538753975407541754275437544754575467547754875497550755175527553755475557556755775587559756075617562756375647565756675677568756975707571757275737574757575767577757875797580758175827583758475857586758775887589759075917592759375947595759675977598759976007601760276037604760576067607760876097610761176127613761476157616761776187619762076217622762376247625762676277628762976307631763276337634763576367637763876397640764176427643764476457646764776487649765076517652765376547655765676577658765976607661766276637664766576667667766876697670767176727673767476757676767776787679768076817682768376847685768676877688768976907691769276937694769576967697769876997700770177027703770477057706770777087709771077117712771377147715771677177718771977207721772277237724772577267727772877297730773177327733773477357736773777387739774077417742774377447745774677477748774977507751775277537754775577567757775877597760776177627763776477657766776777687769777077717772777377747775777677777778777977807781778277837784778577867787778877897790779177927793779477957796779777987799780078017802780378047805780678077808780978107811781278137814781578167817781878197820782178227823782478257826782778287829783078317832783378347835783678377838783978407841784278437844784578467847784878497850785178527853785478557856785778587859786078617862786378647865786678677868786978707871787278737874787578767877787878797880788178827883788478857886788778887889789078917892789378947895789678977898789979007901790279037904790579067907790879097910791179127913791479157916791779187919792079217922792379247925792679277928792979307931793279337934793579367937793879397940794179427943794479457946794779487949795079517952795379547955795679577958795979607961796279637964796579667967796879697970797179727973797479757976797779787979798079817982798379847985798679877988798979907991799279937994799579967997799879998000800180028003800480058006800780088009801080118012801380148015801680178018801980208021802280238024802580268027802880298030803180328033803480358036803780388039804080418042804380448045804680478048804980508051805280538054805580568057805880598060806180628063806480658066806780688069807080718072807380748075807680778078807980808081808280838084808580868087808880898090809180928093809480958096809780988099810081018102810381048105810681078108810981108111811281138114811581168117811881198120812181228123812481258126812781288129813081318132813381348135813681378138813981408141814281438144814581468147814881498150815181528153815481558156815781588159816081618162816381648165816681678168816981708171817281738174817581768177817881798180818181828183818481858186818781888189819081918192819381948195819681978198819982008201820282038204820582068207820882098210821182128213821482158216821782188219822082218222822382248225822682278228822982308231823282338234823582368237823882398240824182428243824482458246824782488249825082518252825382548255825682578258825982608261826282638264826582668267826882698270827182728273827482758276827782788279828082818282828382848285828682878288828982908291829282938294829582968297829882998300830183028303830483058306830783088309831083118312831383148315831683178318831983208321832283238324832583268327832883298330833183328333833483358336833783388339834083418342834383448345834683478348834983508351835283538354835583568357835883598360836183628363836483658366836783688369837083718372837383748375837683778378837983808381838283838384838583868387838883898390839183928393839483958396839783988399840084018402840384048405840684078408840984108411841284138414841584168417841884198420842184228423842484258426842784288429843084318432843384348435843684378438843984408441844284438444844584468447844884498450845184528453845484558456845784588459846084618462846384648465846684678468846984708471847284738474847584768477847884798480848184828483848484858486848784888489849084918492849384948495849684978498849985008501850285038504850585068507850885098510851185128513851485158516851785188519852085218522852385248525852685278528852985308531853285338534853585368537853885398540854185428543854485458546854785488549855085518552855385548555855685578558855985608561856285638564856585668567856885698570857185728573857485758576857785788579858085818582858385848585858685878588858985908591859285938594859585968597859885998600860186028603860486058606860786088609861086118612861386148615861686178618861986208621862286238624862586268627862886298630863186328633863486358636863786388639864086418642864386448645864686478648864986508651865286538654865586568657865886598660866186628663866486658666866786688669867086718672867386748675867686778678867986808681868286838684868586868687868886898690869186928693869486958696869786988699870087018702870387048705870687078708870987108711871287138714871587168717871887198720872187228723872487258726872787288729873087318732873387348735873687378738873987408741874287438744874587468747874887498750875187528753875487558756875787588759876087618762876387648765876687678768876987708771877287738774877587768777877887798780878187828783878487858786878787888789879087918792879387948795879687978798879988008801880288038804880588068807880888098810881188128813881488158816881788188819882088218822882388248825882688278828882988308831883288338834883588368837883888398840884188428843884488458846884788488849885088518852885388548855885688578858885988608861886288638864886588668867886888698870887188728873887488758876887788788879888088818882888388848885888688878888888988908891889288938894889588968897889888998900890189028903890489058906890789088909891089118912891389148915891689178918891989208921892289238924892589268927892889298930893189328933893489358936893789388939894089418942894389448945894689478948894989508951895289538954895589568957895889598960896189628963896489658966896789688969897089718972897389748975897689778978897989808981898289838984898589868987898889898990899189928993899489958996899789988999900090019002900390049005900690079008900990109011901290139014901590169017901890199020902190229023902490259026902790289029903090319032903390349035903690379038903990409041904290439044904590469047904890499050905190529053905490559056905790589059906090619062906390649065906690679068906990709071907290739074907590769077907890799080908190829083908490859086908790889089909090919092909390949095909690979098909991009101910291039104910591069107910891099110911191129113911491159116911791189119912091219122912391249125912691279128912991309131913291339134913591369137913891399140914191429143914491459146914791489149915091519152915391549155915691579158915991609161916291639164916591669167916891699170917191729173917491759176917791789179918091819182918391849185918691879188918991909191919291939194919591969197919891999200920192029203920492059206920792089209921092119212921392149215921692179218921992209221922292239224922592269227922892299230923192329233923492359236923792389239924092419242924392449245924692479248924992509251925292539254925592569257925892599260926192629263926492659266926792689269927092719272927392749275927692779278927992809281928292839284928592869287928892899290929192929293929492959296929792989299930093019302930393049305930693079308930993109311931293139314931593169317931893199320932193229323932493259326932793289329933093319332933393349335933693379338933993409341934293439344934593469347934893499350935193529353935493559356935793589359936093619362936393649365936693679368936993709371937293739374937593769377937893799380938193829383938493859386938793889389939093919392939393949395939693979398939994009401940294039404940594069407940894099410941194129413941494159416941794189419942094219422942394249425942694279428942994309431943294339434943594369437943894399440944194429443944494459446944794489449945094519452945394549455945694579458945994609461946294639464946594669467946894699470947194729473947494759476947794789479948094819482948394849485948694879488948994909491949294939494949594969497949894999500950195029503950495059506950795089509951095119512951395149515951695179518951995209521952295239524952595269527952895299530953195329533953495359536953795389539954095419542954395449545954695479548954995509551955295539554955595569557955895599560956195629563956495659566956795689569957095719572957395749575957695779578957995809581958295839584958595869587958895899590959195929593959495959596959795989599960096019602960396049605960696079608960996109611961296139614961596169617961896199620962196229623962496259626962796289629963096319632963396349635963696379638963996409641964296439644964596469647964896499650965196529653965496559656965796589659966096619662966396649665966696679668966996709671967296739674967596769677967896799680968196829683968496859686968796889689969096919692969396949695969696979698969997009701970297039704970597069707970897099710971197129713971497159716971797189719972097219722972397249725972697279728972997309731973297339734973597369737973897399740974197429743974497459746974797489749975097519752975397549755975697579758975997609761976297639764976597669767976897699770977197729773977497759776977797789779978097819782978397849785978697879788978997909791979297939794979597969797979897999800980198029803980498059806980798089809981098119812981398149815981698179818981998209821982298239824982598269827982898299830983198329833983498359836983798389839984098419842984398449845984698479848984998509851985298539854985598569857985898599860986198629863986498659866986798689869987098719872987398749875987698779878987998809881988298839884988598869887988898899890989198929893989498959896989798989899990099019902990399049905990699079908990999109911991299139914991599169917991899199920992199229923992499259926992799289929993099319932993399349935993699379938993999409941994299439944994599469947994899499950995199529953995499559956995799589959996099619962996399649965996699679968996999709971997299739974997599769977997899799980998199829983998499859986998799889989999099919992999399949995999699979998999910000100011000210003100041000510006100071000810009100101001110012100131001410015100161001710018100191002010021100221002310024100251002610027100281002910030100311003210033100341003510036100371003810039100401004110042100431004410045100461004710048100491005010051100521005310054100551005610057100581005910060100611006210063100641006510066100671006810069100701007110072100731007410075100761007710078100791008010081100821008310084100851008610087100881008910090100911009210093100941009510096100971009810099101001010110102101031010410105101061010710108101091011010111101121011310114101151011610117101181011910120101211012210123101241012510126101271012810129101301013110132101331013410135101361013710138101391014010141101421014310144101451014610147101481014910150101511015210153101541015510156101571015810159101601016110162101631016410165101661016710168101691017010171101721017310174101751017610177101781017910180101811018210183101841018510186101871018810189101901019110192101931019410195101961019710198101991020010201102021020310204102051020610207102081020910210102111021210213102141021510216102171021810219102201022110222102231022410225102261022710228102291023010231102321023310234102351023610237102381023910240102411024210243102441024510246102471024810249102501025110252102531025410255102561025710258102591026010261102621026310264102651026610267102681026910270102711027210273102741027510276102771027810279102801028110282102831028410285102861028710288102891029010291102921029310294102951029610297102981029910300103011030210303103041030510306103071030810309103101031110312103131031410315103161031710318103191032010321103221032310324103251032610327103281032910330103311033210333103341033510336103371033810339103401034110342103431034410345103461034710348103491035010351103521035310354103551035610357103581035910360103611036210363103641036510366103671036810369103701037110372103731037410375103761037710378103791038010381103821038310384103851038610387103881038910390103911039210393103941039510396103971039810399104001040110402104031040410405104061040710408104091041010411104121041310414104151041610417104181041910420104211042210423104241042510426104271042810429104301043110432104331043410435104361043710438104391044010441104421044310444104451044610447104481044910450104511045210453104541045510456104571045810459104601046110462104631046410465104661046710468104691047010471104721047310474104751047610477104781047910480104811048210483104841048510486104871048810489104901049110492104931049410495104961049710498104991050010501105021050310504105051050610507105081050910510105111051210513105141051510516105171051810519105201052110522105231052410525105261052710528105291053010531105321053310534105351053610537105381053910540105411054210543105441054510546105471054810549105501055110552105531055410555105561055710558105591056010561105621056310564105651056610567105681056910570105711057210573105741057510576105771057810579105801058110582105831058410585105861058710588105891059010591105921059310594105951059610597105981059910600106011060210603106041060510606106071060810609106101061110612106131061410615106161061710618106191062010621106221062310624106251062610627106281062910630106311063210633106341063510636106371063810639106401064110642106431064410645106461064710648106491065010651106521065310654106551065610657106581065910660106611066210663106641066510666106671066810669106701067110672106731067410675106761067710678106791068010681106821068310684106851068610687106881068910690106911069210693106941069510696106971069810699107001070110702107031070410705107061070710708107091071010711107121071310714107151071610717107181071910720107211072210723107241072510726107271072810729107301073110732107331073410735107361073710738107391074010741107421074310744107451074610747107481074910750107511075210753107541075510756107571075810759107601076110762107631076410765107661076710768107691077010771107721077310774107751077610777107781077910780107811078210783107841078510786107871078810789107901079110792107931079410795107961079710798107991080010801108021080310804108051080610807108081080910810108111081210813108141081510816108171081810819108201082110822108231082410825108261082710828108291083010831108321083310834108351083610837108381083910840108411084210843108441084510846108471084810849108501085110852108531085410855108561085710858108591086010861108621086310864108651086610867108681086910870108711087210873108741087510876108771087810879108801088110882108831088410885108861088710888108891089010891108921089310894108951089610897108981089910900109011090210903109041090510906109071090810909109101091110912109131091410915109161091710918109191092010921109221092310924109251092610927109281092910930109311093210933109341093510936109371093810939109401094110942109431094410945109461094710948109491095010951109521095310954109551095610957109581095910960109611096210963109641096510966109671096810969109701097110972109731097410975109761097710978109791098010981109821098310984109851098610987109881098910990109911099210993109941099510996109971099810999110001100111002110031100411005110061100711008110091101011011110121101311014110151101611017110181101911020110211102211023110241102511026110271102811029110301103111032110331103411035110361103711038110391104011041110421104311044110451104611047110481104911050110511105211053110541105511056110571105811059110601106111062110631106411065110661106711068110691107011071110721107311074110751107611077110781107911080110811108211083110841108511086110871108811089110901109111092110931109411095110961109711098110991110011101111021110311104111051110611107111081110911110111111111211113111141111511116111171111811119111201112111122111231112411125111261112711128111291113011131111321113311134111351113611137111381113911140111411114211143111441114511146111471114811149111501115111152111531115411155111561115711158111591116011161111621116311164111651116611167111681116911170111711117211173111741117511176111771117811179111801118111182111831118411185111861118711188111891119011191111921119311194111951119611197111981119911200112011120211203112041120511206112071120811209112101121111212112131121411215112161121711218112191122011221112221122311224112251122611227112281122911230112311123211233112341123511236112371123811239112401124111242112431124411245112461124711248112491125011251112521125311254112551125611257112581125911260112611126211263112641126511266112671126811269112701127111272112731127411275112761127711278112791128011281112821128311284112851128611287112881128911290112911129211293112941129511296112971129811299113001130111302113031130411305113061130711308113091131011311113121131311314113151131611317113181131911320113211132211323113241132511326113271132811329113301133111332113331133411335113361133711338113391134011341113421134311344113451134611347113481134911350113511135211353113541135511356113571135811359113601136111362113631136411365113661136711368113691137011371113721137311374113751137611377113781137911380113811138211383113841138511386113871138811389113901139111392113931139411395113961139711398113991140011401114021140311404114051140611407114081140911410114111141211413114141141511416114171141811419114201142111422114231142411425114261142711428114291143011431114321143311434114351143611437114381143911440114411144211443114441144511446114471144811449114501145111452114531145411455114561145711458114591146011461114621146311464114651146611467114681146911470114711147211473114741147511476114771147811479114801148111482114831148411485114861148711488114891149011491114921149311494114951149611497114981149911500115011150211503115041150511506115071150811509115101151111512115131151411515115161151711518115191152011521115221152311524115251152611527115281152911530115311153211533115341153511536115371153811539115401154111542115431154411545115461154711548115491155011551115521155311554115551155611557115581155911560115611156211563115641156511566115671156811569115701157111572115731157411575115761157711578115791158011581115821158311584115851158611587115881158911590115911159211593115941159511596115971159811599116001160111602116031160411605116061160711608116091161011611116121161311614116151161611617116181161911620116211162211623116241162511626116271162811629116301163111632116331163411635116361163711638116391164011641116421164311644116451164611647116481164911650116511165211653116541165511656116571165811659116601166111662116631166411665116661166711668116691167011671116721167311674116751167611677116781167911680116811168211683116841168511686116871168811689116901169111692116931169411695116961169711698116991170011701117021170311704117051170611707117081170911710117111171211713117141171511716117171171811719117201172111722117231172411725117261172711728117291173011731117321173311734117351173611737117381173911740117411174211743117441174511746117471174811749117501175111752117531175411755117561175711758117591176011761117621176311764117651176611767117681176911770117711177211773117741177511776117771177811779117801178111782117831178411785117861178711788117891179011791117921179311794117951179611797117981179911800118011180211803118041180511806118071180811809118101181111812118131181411815118161181711818118191182011821118221182311824118251182611827118281182911830118311183211833118341183511836118371183811839118401184111842118431184411845118461184711848118491185011851118521185311854118551185611857118581185911860118611186211863118641186511866118671186811869118701187111872118731187411875118761187711878118791188011881118821188311884118851188611887118881188911890118911189211893118941189511896118971189811899119001190111902119031190411905119061190711908119091191011911119121191311914119151191611917119181191911920119211192211923119241192511926119271192811929119301193111932119331193411935119361193711938119391194011941119421194311944119451194611947119481194911950119511195211953119541195511956119571195811959119601196111962119631196411965119661196711968119691197011971119721197311974119751197611977119781197911980119811198211983119841198511986119871198811989119901199111992119931199411995119961199711998119991200012001120021200312004120051200612007120081200912010120111201212013120141201512016120171201812019120201202112022120231202412025120261202712028120291203012031120321203312034120351203612037120381203912040120411204212043120441204512046120471204812049120501205112052120531205412055120561205712058120591206012061120621206312064120651206612067120681206912070120711207212073120741207512076120771207812079120801208112082120831208412085120861208712088120891209012091120921209312094120951209612097120981209912100121011210212103121041210512106121071210812109121101211112112121131211412115121161211712118121191212012121121221212312124121251212612127121281212912130121311213212133121341213512136121371213812139121401214112142121431214412145121461214712148121491215012151121521215312154121551215612157121581215912160121611216212163121641216512166121671216812169121701217112172121731217412175121761217712178121791218012181121821218312184121851218612187121881218912190121911219212193121941219512196121971219812199122001220112202122031220412205122061220712208122091221012211122121221312214122151221612217122181221912220122211222212223122241222512226122271222812229122301223112232122331223412235122361223712238122391224012241122421224312244122451224612247122481224912250122511225212253122541225512256122571225812259122601226112262122631226412265122661226712268122691227012271122721227312274122751227612277122781227912280122811228212283122841228512286122871228812289122901229112292122931229412295122961229712298122991230012301123021230312304123051230612307123081230912310123111231212313123141231512316123171231812319123201232112322123231232412325123261232712328123291233012331123321233312334123351233612337123381233912340123411234212343123441234512346123471234812349123501235112352123531235412355123561235712358123591236012361123621236312364123651236612367123681236912370123711237212373123741237512376123771237812379123801238112382123831238412385123861238712388123891239012391123921239312394123951239612397123981239912400124011240212403124041240512406124071240812409124101241112412124131241412415124161241712418124191242012421124221242312424124251242612427124281242912430124311243212433124341243512436124371243812439124401244112442124431244412445124461244712448124491245012451124521245312454124551245612457124581245912460124611246212463124641246512466124671246812469124701247112472124731247412475124761247712478124791248012481124821248312484124851248612487124881248912490124911249212493124941249512496124971249812499125001250112502125031250412505125061250712508125091251012511125121251312514125151251612517125181251912520125211252212523125241252512526125271252812529125301253112532125331253412535125361253712538125391254012541125421254312544125451254612547125481254912550125511255212553125541255512556125571255812559125601256112562125631256412565125661256712568125691257012571125721257312574125751257612577125781257912580125811258212583125841258512586125871258812589125901259112592125931259412595125961259712598125991260012601126021260312604126051260612607126081260912610126111261212613126141261512616126171261812619126201262112622126231262412625126261262712628126291263012631126321263312634126351263612637126381263912640126411264212643126441264512646126471264812649126501265112652126531265412655126561265712658126591266012661126621266312664126651266612667126681266912670126711267212673126741267512676126771267812679126801268112682126831268412685126861268712688126891269012691126921269312694126951269612697126981269912700127011270212703127041270512706127071270812709127101271112712127131271412715127161271712718127191272012721127221272312724127251272612727127281272912730127311273212733127341273512736127371273812739127401274112742127431274412745127461274712748127491275012751127521275312754127551275612757127581275912760127611276212763127641276512766127671276812769127701277112772127731277412775127761277712778127791278012781127821278312784127851278612787127881278912790127911279212793127941279512796127971279812799128001280112802128031280412805128061280712808128091281012811128121281312814128151281612817128181281912820128211282212823128241282512826128271282812829128301283112832128331283412835128361283712838128391284012841128421284312844128451284612847128481284912850128511285212853128541285512856128571285812859128601286112862128631286412865128661286712868128691287012871128721287312874128751287612877128781287912880128811288212883128841288512886128871288812889128901289112892128931289412895128961289712898128991290012901129021290312904129051290612907129081290912910129111291212913129141291512916129171291812919129201292112922129231292412925129261292712928129291293012931129321293312934129351293612937129381293912940129411294212943129441294512946129471294812949129501295112952129531295412955129561295712958129591296012961129621296312964129651296612967129681296912970129711297212973129741297512976129771297812979129801298112982129831298412985129861298712988129891299012991129921299312994129951299612997129981299913000130011300213003130041300513006130071300813009130101301113012130131301413015130161301713018130191302013021130221302313024130251302613027130281302913030130311303213033130341303513036130371303813039130401304113042130431304413045130461304713048130491305013051130521305313054130551305613057130581305913060130611306213063130641306513066130671306813069130701307113072130731307413075130761307713078130791308013081130821308313084130851308613087130881308913090130911309213093130941309513096130971309813099131001310113102131031310413105131061310713108131091311013111131121311313114131151311613117131181311913120131211312213123131241312513126131271312813129131301313113132131331313413135131361313713138131391314013141131421314313144131451314613147131481314913150131511315213153131541315513156131571315813159131601316113162131631316413165131661316713168131691317013171131721317313174131751317613177131781317913180131811318213183131841318513186131871318813189131901319113192131931319413195131961319713198131991320013201132021320313204132051320613207132081320913210132111321213213132141321513216132171321813219132201322113222132231322413225132261322713228132291323013231132321323313234132351323613237132381323913240132411324213243132441324513246132471324813249132501325113252132531325413255132561325713258132591326013261132621326313264132651326613267132681326913270132711327213273132741327513276132771327813279132801328113282132831328413285132861328713288132891329013291132921329313294132951329613297132981329913300133011330213303133041330513306133071330813309133101331113312133131331413315133161331713318133191332013321133221332313324133251332613327133281332913330133311333213333133341333513336133371333813339133401334113342133431334413345133461334713348133491335013351133521335313354133551335613357133581335913360133611336213363133641336513366133671336813369133701337113372133731337413375133761337713378133791338013381133821338313384133851338613387133881338913390133911339213393133941339513396133971339813399134001340113402134031340413405134061340713408134091341013411134121341313414134151341613417134181341913420134211342213423134241342513426134271342813429134301343113432134331343413435134361343713438134391344013441134421344313444134451344613447134481344913450134511345213453134541345513456134571345813459134601346113462134631346413465134661346713468134691347013471134721347313474134751347613477134781347913480134811348213483134841348513486134871348813489134901349113492134931349413495134961349713498134991350013501135021350313504135051350613507135081350913510135111351213513135141351513516135171351813519135201352113522135231352413525135261352713528135291353013531135321353313534135351353613537135381353913540135411354213543135441354513546135471354813549135501355113552135531355413555135561355713558135591356013561135621356313564135651356613567135681356913570135711357213573135741357513576135771357813579135801358113582135831358413585135861358713588135891359013591135921359313594135951359613597135981359913600136011360213603136041360513606136071360813609136101361113612136131361413615136161361713618136191362013621136221362313624136251362613627136281362913630136311363213633136341363513636136371363813639136401364113642136431364413645136461364713648136491365013651136521365313654136551365613657136581365913660136611366213663136641366513666136671366813669136701367113672136731367413675136761367713678136791368013681136821368313684136851368613687136881368913690136911369213693136941369513696136971369813699137001370113702137031370413705137061370713708137091371013711137121371313714137151371613717137181371913720137211372213723137241372513726137271372813729137301373113732137331373413735137361373713738137391374013741137421374313744137451374613747137481374913750137511375213753137541375513756137571375813759137601376113762137631376413765137661376713768137691377013771137721377313774137751377613777137781377913780137811378213783137841378513786137871378813789137901379113792137931379413795137961379713798137991380013801138021380313804138051380613807138081380913810138111381213813138141381513816138171381813819138201382113822138231382413825138261382713828138291383013831138321383313834138351383613837138381383913840138411384213843138441384513846138471384813849138501385113852138531385413855138561385713858138591386013861138621386313864138651386613867138681386913870138711387213873138741387513876138771387813879138801388113882138831388413885138861388713888138891389013891138921389313894138951389613897138981389913900139011390213903139041390513906139071390813909139101391113912139131391413915139161391713918139191392013921139221392313924139251392613927139281392913930139311393213933139341393513936139371393813939139401394113942139431394413945139461394713948139491395013951139521395313954139551395613957139581395913960139611396213963139641396513966139671396813969139701397113972139731397413975139761397713978139791398013981139821398313984139851398613987139881398913990139911399213993139941399513996139971399813999140001400114002140031400414005140061400714008140091401014011140121401314014140151401614017140181401914020140211402214023140241402514026140271402814029140301403114032140331403414035140361403714038140391404014041140421404314044140451404614047140481404914050140511405214053140541405514056140571405814059140601406114062140631406414065140661406714068140691407014071140721407314074140751407614077140781407914080140811408214083140841408514086140871408814089140901409114092140931409414095140961409714098140991410014101141021410314104141051410614107141081410914110141111411214113141141411514116141171411814119141201412114122141231412414125141261412714128141291413014131141321413314134141351413614137141381413914140141411414214143141441414514146141471414814149141501415114152141531415414155141561415714158141591416014161141621416314164141651416614167141681416914170141711417214173141741417514176141771417814179141801418114182141831418414185141861418714188141891419014191141921419314194141951419614197141981419914200142011420214203142041420514206142071420814209142101421114212142131421414215142161421714218142191422014221142221422314224142251422614227142281422914230142311423214233142341423514236142371423814239142401424114242142431424414245142461424714248142491425014251142521425314254142551425614257142581425914260142611426214263142641426514266142671426814269142701427114272142731427414275142761427714278142791428014281142821428314284142851428614287142881428914290142911429214293142941429514296142971429814299143001430114302143031430414305143061430714308143091431014311143121431314314143151431614317143181431914320143211432214323143241432514326143271432814329143301433114332143331433414335143361433714338143391434014341143421434314344143451434614347143481434914350143511435214353143541435514356143571435814359143601436114362143631436414365143661436714368143691437014371143721437314374143751437614377143781437914380143811438214383143841438514386143871438814389143901439114392143931439414395143961439714398143991440014401144021440314404144051440614407144081440914410144111441214413144141441514416144171441814419144201442114422144231442414425144261442714428144291443014431144321443314434144351443614437144381443914440144411444214443144441444514446144471444814449144501445114452144531445414455144561445714458144591446014461144621446314464144651446614467144681446914470144711447214473144741447514476144771447814479144801448114482144831448414485144861448714488144891449014491144921449314494144951449614497144981449914500145011450214503145041450514506145071450814509145101451114512145131451414515145161451714518145191452014521145221452314524145251452614527145281452914530145311453214533145341453514536145371453814539145401454114542145431454414545145461454714548145491455014551145521455314554145551455614557145581455914560145611456214563145641456514566145671456814569145701457114572145731457414575145761457714578145791458014581145821458314584145851458614587145881458914590145911459214593145941459514596145971459814599146001460114602146031460414605146061460714608146091461014611146121461314614146151461614617146181461914620146211462214623146241462514626146271462814629146301463114632146331463414635146361463714638146391464014641146421464314644146451464614647146481464914650146511465214653146541465514656146571465814659146601466114662146631466414665146661466714668146691467014671146721467314674146751467614677146781467914680146811468214683146841468514686146871468814689146901469114692146931469414695146961469714698146991470014701147021470314704147051470614707147081470914710147111471214713147141471514716147171471814719147201472114722147231472414725147261472714728147291473014731147321473314734147351473614737147381473914740147411474214743147441474514746147471474814749147501475114752147531475414755147561475714758147591476014761147621476314764147651476614767147681476914770147711477214773147741477514776147771477814779147801478114782147831478414785147861478714788147891479014791147921479314794147951479614797147981479914800148011480214803148041480514806148071480814809148101481114812148131481414815148161481714818148191482014821148221482314824148251482614827148281482914830148311483214833148341483514836148371483814839148401484114842148431484414845148461484714848148491485014851148521485314854148551485614857148581485914860148611486214863148641486514866148671486814869148701487114872148731487414875148761487714878148791488014881148821488314884148851488614887148881488914890148911489214893148941489514896148971489814899149001490114902149031490414905149061490714908149091491014911149121491314914149151491614917149181491914920149211492214923149241492514926149271492814929149301493114932149331493414935149361493714938149391494014941149421494314944149451494614947149481494914950149511495214953149541495514956149571495814959149601496114962149631496414965149661496714968149691497014971149721497314974149751497614977149781497914980149811498214983149841498514986149871498814989149901499114992149931499414995149961499714998149991500015001150021500315004150051500615007150081500915010150111501215013150141501515016150171501815019150201502115022150231502415025150261502715028150291503015031150321503315034150351503615037150381503915040150411504215043150441504515046150471504815049150501505115052150531505415055150561505715058150591506015061150621506315064150651506615067150681506915070150711507215073150741507515076150771507815079150801508115082150831508415085150861508715088150891509015091150921509315094150951509615097150981509915100151011510215103151041510515106151071510815109151101511115112151131511415115151161511715118151191512015121151221512315124151251512615127151281512915130151311513215133151341513515136151371513815139151401514115142151431514415145151461514715148151491515015151151521515315154151551515615157151581515915160151611516215163151641516515166151671516815169151701517115172151731517415175151761517715178151791518015181151821518315184151851518615187151881518915190151911519215193151941519515196151971519815199152001520115202152031520415205152061520715208152091521015211152121521315214152151521615217152181521915220152211522215223152241522515226152271522815229152301523115232152331523415235152361523715238152391524015241152421524315244152451524615247152481524915250152511525215253152541525515256152571525815259152601526115262152631526415265152661526715268152691527015271152721527315274152751527615277152781527915280152811528215283152841528515286152871528815289152901529115292152931529415295152961529715298152991530015301153021530315304153051530615307153081530915310153111531215313153141531515316153171531815319153201532115322153231532415325153261532715328153291533015331153321533315334153351533615337153381533915340153411534215343153441534515346153471534815349153501535115352153531535415355153561535715358153591536015361153621536315364153651536615367153681536915370153711537215373153741537515376153771537815379153801538115382153831538415385153861538715388153891539015391153921539315394153951539615397153981539915400154011540215403154041540515406154071540815409154101541115412154131541415415154161541715418154191542015421154221542315424154251542615427154281542915430154311543215433154341543515436154371543815439154401544115442154431544415445154461544715448154491545015451154521545315454154551545615457154581545915460154611546215463154641546515466154671546815469154701547115472154731547415475154761547715478154791548015481154821548315484154851548615487154881548915490154911549215493154941549515496154971549815499155001550115502155031550415505155061550715508155091551015511155121551315514155151551615517155181551915520155211552215523155241552515526155271552815529155301553115532155331553415535155361553715538155391554015541155421554315544155451554615547155481554915550155511555215553155541555515556155571555815559155601556115562155631556415565155661556715568155691557015571155721557315574155751557615577155781557915580155811558215583155841558515586155871558815589155901559115592155931559415595155961559715598155991560015601156021560315604156051560615607156081560915610156111561215613156141561515616156171561815619156201562115622156231562415625156261562715628156291563015631156321563315634156351563615637156381563915640156411564215643156441564515646156471564815649156501565115652156531565415655156561565715658156591566015661156621566315664156651566615667156681566915670156711567215673156741567515676156771567815679156801568115682156831568415685156861568715688156891569015691156921569315694156951569615697156981569915700157011570215703157041570515706157071570815709157101571115712157131571415715157161571715718157191572015721157221572315724157251572615727157281572915730157311573215733157341573515736157371573815739157401574115742157431574415745157461574715748157491575015751157521575315754157551575615757157581575915760157611576215763157641576515766157671576815769157701577115772157731577415775157761577715778157791578015781157821578315784157851578615787157881578915790157911579215793157941579515796157971579815799158001580115802158031580415805158061580715808158091581015811158121581315814158151581615817158181581915820158211582215823158241582515826158271582815829158301583115832158331583415835158361583715838158391584015841158421584315844158451584615847158481584915850158511585215853158541585515856158571585815859158601586115862158631586415865158661586715868158691587015871158721587315874158751587615877158781587915880158811588215883158841588515886158871588815889158901589115892158931589415895158961589715898158991590015901159021590315904159051590615907159081590915910159111591215913159141591515916159171591815919159201592115922159231592415925159261592715928159291593015931159321593315934159351593615937159381593915940159411594215943159441594515946159471594815949159501595115952159531595415955159561595715958159591596015961159621596315964159651596615967159681596915970159711597215973159741597515976159771597815979159801598115982159831598415985159861598715988159891599015991159921599315994159951599615997159981599916000160011600216003160041600516006160071600816009160101601116012160131601416015160161601716018160191602016021160221602316024160251602616027160281602916030160311603216033160341603516036160371603816039160401604116042160431604416045160461604716048160491605016051160521605316054160551605616057160581605916060160611606216063160641606516066160671606816069160701607116072160731607416075160761607716078160791608016081160821608316084160851608616087160881608916090160911609216093160941609516096160971609816099161001610116102161031610416105161061610716108161091611016111161121611316114161151611616117161181611916120161211612216123161241612516126161271612816129161301613116132161331613416135161361613716138161391614016141161421614316144161451614616147161481614916150161511615216153161541615516156161571615816159161601616116162161631616416165161661616716168161691617016171161721617316174161751617616177161781617916180161811618216183161841618516186161871618816189161901619116192161931619416195161961619716198161991620016201162021620316204162051620616207162081620916210162111621216213162141621516216162171621816219162201622116222162231622416225162261622716228162291623016231162321623316234162351623616237162381623916240162411624216243162441624516246162471624816249162501625116252162531625416255162561625716258162591626016261162621626316264162651626616267162681626916270162711627216273162741627516276162771627816279162801628116282162831628416285162861628716288162891629016291162921629316294162951629616297162981629916300163011630216303163041630516306163071630816309163101631116312163131631416315163161631716318163191632016321163221632316324163251632616327163281632916330163311633216333163341633516336163371633816339163401634116342163431634416345163461634716348163491635016351163521635316354163551635616357163581635916360163611636216363163641636516366163671636816369163701637116372163731637416375163761637716378163791638016381163821638316384163851638616387163881638916390163911639216393163941639516396163971639816399164001640116402164031640416405164061640716408164091641016411164121641316414164151641616417164181641916420164211642216423164241642516426164271642816429164301643116432164331643416435164361643716438164391644016441164421644316444164451644616447164481644916450164511645216453164541645516456164571645816459164601646116462164631646416465164661646716468164691647016471164721647316474164751647616477164781647916480164811648216483164841648516486164871648816489164901649116492164931649416495164961649716498164991650016501165021650316504165051650616507165081650916510165111651216513165141651516516165171651816519165201652116522165231652416525165261652716528165291653016531165321653316534165351653616537165381653916540165411654216543165441654516546165471654816549165501655116552165531655416555165561655716558165591656016561165621656316564165651656616567165681656916570165711657216573165741657516576165771657816579165801658116582165831658416585165861658716588165891659016591165921659316594165951659616597165981659916600166011660216603166041660516606166071660816609166101661116612166131661416615166161661716618166191662016621166221662316624166251662616627166281662916630166311663216633166341663516636166371663816639166401664116642166431664416645166461664716648166491665016651166521665316654166551665616657166581665916660166611666216663166641666516666166671666816669166701667116672166731667416675166761667716678166791668016681166821668316684166851668616687166881668916690166911669216693166941669516696166971669816699167001670116702167031670416705167061670716708167091671016711167121671316714167151671616717167181671916720167211672216723167241672516726167271672816729167301673116732167331673416735167361673716738167391674016741167421674316744167451674616747167481674916750167511675216753167541675516756167571675816759167601676116762167631676416765167661676716768167691677016771167721677316774167751677616777167781677916780167811678216783167841678516786167871678816789167901679116792167931679416795167961679716798167991680016801168021680316804168051680616807168081680916810168111681216813168141681516816168171681816819168201682116822168231682416825168261682716828168291683016831168321683316834168351683616837168381683916840168411684216843168441684516846168471684816849168501685116852168531685416855168561685716858168591686016861168621686316864168651686616867168681686916870168711687216873168741687516876168771687816879168801688116882168831688416885168861688716888168891689016891168921689316894168951689616897168981689916900169011690216903169041690516906169071690816909169101691116912169131691416915169161691716918169191692016921169221692316924169251692616927169281692916930169311693216933169341693516936169371693816939169401694116942169431694416945169461694716948169491695016951169521695316954169551695616957169581695916960169611696216963169641696516966169671696816969169701697116972169731697416975169761697716978169791698016981169821698316984169851698616987169881698916990169911699216993169941699516996169971699816999170001700117002170031700417005170061700717008170091701017011170121701317014170151701617017170181701917020170211702217023170241702517026170271702817029170301703117032170331703417035170361703717038170391704017041170421704317044170451704617047170481704917050170511705217053170541705517056170571705817059170601706117062170631706417065170661706717068170691707017071170721707317074170751707617077170781707917080170811708217083170841708517086170871708817089170901709117092170931709417095170961709717098170991710017101171021710317104171051710617107171081710917110171111711217113171141711517116171171711817119171201712117122171231712417125171261712717128171291713017131171321713317134171351713617137171381713917140171411714217143171441714517146171471714817149171501715117152171531715417155171561715717158171591716017161171621716317164171651716617167171681716917170171711717217173171741717517176171771717817179171801718117182171831718417185171861718717188171891719017191171921719317194171951719617197171981719917200172011720217203172041720517206172071720817209172101721117212172131721417215172161721717218172191722017221172221722317224172251722617227172281722917230172311723217233172341723517236172371723817239172401724117242172431724417245172461724717248172491725017251172521725317254172551725617257172581725917260172611726217263172641726517266172671726817269172701727117272172731727417275172761727717278172791728017281172821728317284172851728617287172881728917290172911729217293172941729517296172971729817299173001730117302173031730417305173061730717308173091731017311173121731317314173151731617317173181731917320173211732217323173241732517326173271732817329173301733117332173331733417335173361733717338173391734017341173421734317344173451734617347173481734917350173511735217353173541735517356173571735817359173601736117362173631736417365173661736717368173691737017371173721737317374173751737617377173781737917380173811738217383173841738517386173871738817389173901739117392173931739417395173961739717398173991740017401174021740317404174051740617407174081740917410174111741217413174141741517416174171741817419174201742117422174231742417425174261742717428174291743017431174321743317434174351743617437174381743917440174411744217443174441744517446174471744817449174501745117452174531745417455174561745717458174591746017461174621746317464174651746617467174681746917470174711747217473174741747517476174771747817479174801748117482174831748417485174861748717488174891749017491174921749317494174951749617497174981749917500175011750217503175041750517506175071750817509175101751117512175131751417515175161751717518175191752017521175221752317524175251752617527175281752917530175311753217533175341753517536175371753817539175401754117542175431754417545175461754717548175491755017551175521755317554175551755617557175581755917560175611756217563175641756517566175671756817569175701757117572175731757417575175761757717578175791758017581175821758317584175851758617587175881758917590175911759217593175941759517596175971759817599176001760117602176031760417605176061760717608176091761017611176121761317614176151761617617176181761917620176211762217623176241762517626176271762817629176301763117632176331763417635176361763717638176391764017641176421764317644176451764617647176481764917650176511765217653176541765517656176571765817659176601766117662176631766417665176661766717668176691767017671176721767317674176751767617677176781767917680176811768217683176841768517686176871768817689176901769117692176931769417695176961769717698176991770017701177021770317704177051770617707177081770917710177111771217713177141771517716177171771817719177201772117722177231772417725177261772717728177291773017731177321773317734177351773617737177381773917740177411774217743177441774517746177471774817749177501775117752177531775417755177561775717758177591776017761177621776317764177651776617767177681776917770177711777217773177741777517776177771777817779177801778117782177831778417785177861778717788177891779017791177921779317794177951779617797177981779917800178011780217803178041780517806178071780817809178101781117812178131781417815178161781717818178191782017821178221782317824178251782617827178281782917830178311783217833178341783517836178371783817839178401784117842178431784417845178461784717848178491785017851178521785317854178551785617857178581785917860178611786217863178641786517866178671786817869178701787117872178731787417875178761787717878178791788017881178821788317884178851788617887178881788917890178911789217893178941789517896178971789817899179001790117902179031790417905179061790717908179091791017911179121791317914179151791617917179181791917920179211792217923179241792517926179271792817929179301793117932179331793417935179361793717938179391794017941179421794317944179451794617947179481794917950179511795217953179541795517956179571795817959179601796117962179631796417965179661796717968179691797017971179721797317974179751797617977179781797917980179811798217983179841798517986179871798817989179901799117992179931799417995179961799717998179991800018001180021800318004180051800618007180081800918010180111801218013180141801518016180171801818019180201802118022180231802418025180261802718028180291803018031180321803318034180351803618037180381803918040180411804218043180441804518046180471804818049180501805118052180531805418055180561805718058180591806018061180621806318064180651806618067180681806918070180711807218073180741807518076180771807818079180801808118082180831808418085180861808718088180891809018091180921809318094180951809618097180981809918100181011810218103181041810518106181071810818109181101811118112181131811418115181161811718118181191812018121181221812318124181251812618127181281812918130181311813218133181341813518136181371813818139181401814118142181431814418145181461814718148181491815018151181521815318154181551815618157181581815918160181611816218163181641816518166181671816818169181701817118172181731817418175181761817718178181791818018181181821818318184181851818618187181881818918190181911819218193181941819518196181971819818199182001820118202182031820418205182061820718208182091821018211182121821318214182151821618217182181821918220182211822218223182241822518226182271822818229182301823118232182331823418235182361823718238182391824018241182421824318244182451824618247182481824918250182511825218253182541825518256182571825818259182601826118262182631826418265182661826718268182691827018271182721827318274182751827618277182781827918280182811828218283182841828518286182871828818289182901829118292182931829418295182961829718298182991830018301183021830318304183051830618307183081830918310183111831218313183141831518316183171831818319183201832118322183231832418325183261832718328183291833018331183321833318334183351833618337183381833918340183411834218343183441834518346183471834818349183501835118352183531835418355183561835718358183591836018361183621836318364183651836618367183681836918370183711837218373183741837518376183771837818379183801838118382183831838418385183861838718388183891839018391183921839318394183951839618397183981839918400184011840218403184041840518406184071840818409184101841118412184131841418415184161841718418184191842018421184221842318424184251842618427184281842918430184311843218433184341843518436184371843818439184401844118442184431844418445184461844718448184491845018451184521845318454184551845618457184581845918460184611846218463184641846518466184671846818469184701847118472184731847418475184761847718478184791848018481184821848318484184851848618487184881848918490184911849218493184941849518496184971849818499185001850118502185031850418505185061850718508185091851018511185121851318514185151851618517185181851918520185211852218523185241852518526185271852818529185301853118532185331853418535185361853718538185391854018541185421854318544185451854618547185481854918550185511855218553185541855518556185571855818559185601856118562185631856418565185661856718568185691857018571185721857318574185751857618577185781857918580185811858218583185841858518586185871858818589185901859118592185931859418595185961859718598185991860018601186021860318604186051860618607186081860918610186111861218613186141861518616186171861818619186201862118622186231862418625186261862718628186291863018631186321863318634186351863618637186381863918640186411864218643186441864518646186471864818649186501865118652186531865418655186561865718658186591866018661186621866318664186651866618667186681866918670186711867218673186741867518676186771867818679186801868118682186831868418685186861868718688186891869018691186921869318694186951869618697186981869918700187011870218703187041870518706187071870818709187101871118712187131871418715187161871718718187191872018721187221872318724187251872618727187281872918730187311873218733187341873518736187371873818739187401874118742187431874418745187461874718748187491875018751187521875318754187551875618757187581875918760187611876218763187641876518766187671876818769187701877118772187731877418775187761877718778187791878018781187821878318784187851878618787187881878918790187911879218793187941879518796187971879818799188001880118802188031880418805188061880718808188091881018811188121881318814188151881618817188181881918820188211882218823188241882518826188271882818829188301883118832188331883418835188361883718838188391884018841188421884318844188451884618847188481884918850188511885218853188541885518856188571885818859188601886118862188631886418865188661886718868188691887018871188721887318874188751887618877188781887918880188811888218883188841888518886188871888818889188901889118892188931889418895188961889718898188991890018901189021890318904189051890618907189081890918910189111891218913189141891518916189171891818919189201892118922189231892418925189261892718928189291893018931189321893318934189351893618937189381893918940189411894218943189441894518946189471894818949189501895118952189531895418955189561895718958189591896018961189621896318964189651896618967189681896918970189711897218973189741897518976189771897818979189801898118982189831898418985189861898718988189891899018991189921899318994189951899618997189981899919000190011900219003190041900519006190071900819009190101901119012190131901419015190161901719018190191902019021190221902319024190251902619027190281902919030190311903219033190341903519036190371903819039190401904119042190431904419045190461904719048190491905019051190521905319054190551905619057190581905919060190611906219063190641906519066190671906819069190701907119072190731907419075190761907719078190791908019081190821908319084190851908619087190881908919090190911909219093190941909519096190971909819099191001910119102191031910419105191061910719108191091911019111191121911319114191151911619117191181911919120191211912219123191241912519126191271912819129191301913119132191331913419135191361913719138191391914019141191421914319144191451914619147191481914919150191511915219153191541915519156191571915819159191601916119162191631916419165191661916719168191691917019171191721917319174191751917619177191781917919180191811918219183191841918519186191871918819189191901919119192191931919419195191961919719198191991920019201192021920319204192051920619207192081920919210192111921219213192141921519216192171921819219192201922119222192231922419225192261922719228192291923019231192321923319234192351923619237192381923919240192411924219243192441924519246192471924819249192501925119252192531925419255192561925719258192591926019261192621926319264192651926619267192681926919270192711927219273192741927519276192771927819279192801928119282192831928419285192861928719288192891929019291192921929319294192951929619297192981929919300193011930219303193041930519306193071930819309193101931119312193131931419315193161931719318193191932019321193221932319324193251932619327193281932919330193311933219333193341933519336193371933819339193401934119342193431934419345193461934719348193491935019351193521935319354193551935619357193581935919360193611936219363
  1. 2014-11-20 Asterisk Development Team <asteriskteam@digium.com>
  2. * Asterisk 13.0.1 Released.
  3. * AST-2014-012: Fix error with mixed address family ACLs.
  4. Prior to this commit, the address family of the first item in an ACL
  5. was used to compare all incoming traffic. This could lead to traffic
  6. of other IP address families bypassing ACLs.
  7. ASTERISK-24469 #close
  8. Reported by Matt Jordan
  9. * AST-2014-013: Fix PJSIP ACLs not loading on startup and apply/ACL
  10. issues on contact
  11. The biggest problem this patch fixes is that ACLs weren't previously
  12. being loaded when the res_pjsip_acl module was loaded. In addition,
  13. the ACL options contact_permit and contact_acl were effectively
  14. interpreted as contact_deny and this patch fixes that as well.
  15. ASTERISK-24531 #close
  16. Reported by: Matt Jordan
  17. * AST-2014-015: Fix race condition in chan_pjsip when sending responses
  18. after a CANCEL has been received.
  19. Due to the serialized architecture of chan_pjsip there exists a race
  20. condition where a CANCEL may be received and processed before
  21. responses (such as 180 Ringing, 183 Session Progress, and 200 OK)
  22. are sent. Since the session is in an unexpected state PJSIP will
  23. assert when this is attempted.
  24. This change makes it so that these responses are not sent on
  25. disconnected sessions.
  26. ASTERISK-24471 #close
  27. Reported by: yaron nahum
  28. * AST-2014-016: Fix crash when receiving an in-dialog INVITE with
  29. Replaces in res_pjsip_refer.
  30. The implementation of INVITE with Replaces in res_pjsip_refer did not
  31. expect them to occur in-dialog. As a result it would incorrectly
  32. attempt to hang up a channel it thought was under its control. In
  33. reality the channel would be under the control of another thread.
  34. When the other thread accessed the channel it would be accessing
  35. freed memory and could crash.
  36. This change makes res_pjsip_refer not act on an in-dialog INVITE
  37. with Replaces.
  38. ASTERISK-24528 #close
  39. Reported by: Joshua Colp
  40. * AST-2014-017 - app_confbridge: permission escalation/ class
  41. authorization.
  42. Confbridge dialplan function permission escalation via AMI and
  43. inappropriate class authorization on the ConfbridgeStartRecord action.
  44. The CONFBRIDGE dialplan function when executed from an external
  45. protocol (for instance AMI), could result in a privilege escalation.
  46. Also, the AMI action “ConfbridgeStartRecord” could also be used to
  47. execute arbitrary system commands without first checking for system
  48. access.
  49. Asterisk now inhibits the CONFBRIDGE function from being executed
  50. from an external interface if the live_dangerously option is set to
  51. no. Also, the “ConfbridgeStartRecord” AMI action is now only allowed
  52. to execute under a user with system level access.
  53. ASTERISK-24490
  54. Reported by: Gareth Palmer
  55. * AST-2014-018 - func_db: DB Dialplan function permission escalation
  56. via AMI.
  57. The DB dialplan function when executed from an external protocol
  58. (for instance AMI), could result in a privilege escalation.
  59. Asterisk now inhibits the DB function from being executed from an
  60. external interface if the live_dangerously option is set to no.
  61. ASTERISK-24534
  62. Reported by: Gareth Palmer
  63. patches: submitted by Gareth Palmer (license 5169)
  64. 2014-10-24 Asterisk Development Team <asteriskteam@digium.com>
  65. * Asterisk 13.0.0 Released.
  66. 2014-10-22 21:27 +0000 [r426097] Shaun Ruffell <sruffell@digium.com>
  67. * codecs/codec_dahdi.c: codec_dahdi: Cannot use struct
  68. ast_translator.core_{src,src}_codec. This fixes a Segmentation
  69. fault introduced in r419044 "media formats: re-architect handling
  70. of media for performance improvements". The problem is that
  71. codec_dahdi was using core_src_codec and core_dst_codec in the
  72. ast_translator structure when these fields were never set. Now
  73. instead of trying to map the new core codec descriptions to the
  74. way DAHDI defines different codecs, we will store the DAHDI
  75. specific formats in 'struct translator' directly so we can refer
  76. to them without mapping. This also allows us to remove the
  77. "global_format_map" structure, since we can now query the list of
  78. translators directly to make sure we do not ever register a DAHDI
  79. based translator for a specific path more than once and eliminate
  80. the need to keep the list and the map in sync. ASTERISK-24435
  81. #close Reported by: Marian Koniuszko Review:
  82. https://reviewboard.asterisk.org/r/4105/
  83. 2014-10-21 17:47 +0000 [r426079] Richard Mudgett <rmudgett@digium.com>
  84. * main/translate.c: translage.c: Fix regression when generating
  85. translation path strings. Fix the AMI Status action read and
  86. write translation path strings from growing for each channel in
  87. the status event list by reseting the ast string given to
  88. ast_translate_path_to_str() to fill in the given translation
  89. path.
  90. 2014-10-20 14:15 +0000 [r425991] Matthew Jordan <mjordan@digium.com>
  91. * res/res_xmpp.c, main/tcptls.c, /: AST-2014-011: Fix POODLE
  92. security issues There are two aspects to the vulnerability: (1)
  93. res_jabber/res_xmpp use SSLv3 only. This patch updates the module
  94. to use TLSv1+. At this time, it does not refactor
  95. res_jabber/res_xmpp to use the TCP/TLS core, which should be done
  96. as an improvement at a latter date. (2) The TCP/TLS core, when
  97. tlsclientmethod/sslclientmethod is left unspecified, will default
  98. to the OpenSSL SSLv23_method. This method allows for all
  99. encryption methods, including SSLv2/SSLv3. A MITM can exploit
  100. this by forcing a fallback to SSLv3, which leaves the server
  101. vulnerable to POODLE. This patch adds WARNINGS if a user uses
  102. SSLv2/SSLv3 in their configuration, and explicitly disables
  103. SSLv2/SSLv3 if using SSLv23_method. For TLS clients, Asterisk
  104. will default to TLSv1+ and WARN if SSLv2 or SSLv3 is explicitly
  105. chosen. For TLS servers, Asterisk will no longer support SSLv2 or
  106. SSLv3. Much thanks to abelbeck for reporting the vulnerability
  107. and providing a patch for the res_jabber/res_xmpp modules.
  108. Review: https://reviewboard.asterisk.org/r/4096/ ASTERISK-24425
  109. #close Reported by: abelbeck Tested by: abelbeck, opsmonitor,
  110. gtjoseph patches: asterisk-1.8-jabber-tls.patch uploaded by
  111. abelbeck (License 5903) asterisk-11-jabber-xmpp-tls.patch
  112. uploaded by abelbeck (License 5903) AST-2014-011-1.8.diff
  113. uploaded by mjordan (License 6283) AST-2014-011-11.diff uploaded
  114. by mjordan (License 6283) ........ Merged revisions 425987 from
  115. http://svn.asterisk.org/svn/asterisk/branches/12
  116. 2014-10-19 17:07 +0000 [r425965] George Joseph <george.joseph@fairview5.com>
  117. * Makefile, /, configure, include/asterisk/autoconfig.h.in,
  118. configure.ac, makeopts.in: build: Force -fsigned-char on
  119. platforms where the default for char is unsigned gcc on the ARM
  120. platform defaults 'char' to 'unsigned char' whereas Intel and
  121. SPARC default to 'signed char'. This is only an issue in the rare
  122. cases where negative values are assigned to a 'char' but this
  123. this patch insures compatibility by detecting platforms that
  124. default to 'unsigned' and adding an '-fsigned-char' flag to
  125. _ASTCFLAGS. If compiling for ARM (native or cross-compile) be
  126. sure to run ./bootstrap.sh and ./configure to regenerate the
  127. build files. You shouldn't have to do this for Intel or SPARC.
  128. Tested-by: George Joseph Review:
  129. https://reviewboard.asterisk.org/r/4091/ ........ Merged
  130. revisions 425964 from
  131. http://svn.asterisk.org/svn/asterisk/branches/12
  132. 2014-10-19 04:01 +0000 [r425923-425944] Matthew Jordan <mjordan@digium.com>
  133. * res/res_pjsip_sdp_rtp.c: res/res_pjsip_sdp_rtp: Revert 425922
  134. This patch for r425922 introduced a bug, wherein sending an
  135. INVITE request with no SDP would cause Asterisk to not send an
  136. SDP Offer in the 200 OK. The current structure of
  137. res_pjsip_sdp_rtp is a bit hard to deal with to fix this, as
  138. create_outgoing_sdp has no knowledge of whether or not it is
  139. creating an SDP as a new Offer or an Answer. This is something of
  140. an oversight in the callback definition, as the caller of it does
  141. have this information.
  142. * res/res_pjsip_sdp_rtp.c: res/res_pjsip_sdp_rtp: Remove left over
  143. reference to override_prefs The usage of the local override_prefs
  144. variable in create_outgoing_sdp_stream was previously to track an
  145. override format preference set by PJSIP_MEDIA_OFFER. Now,
  146. however, that function simply sets the joint capabilities
  147. structure, session->req_caps. During the media format rework, the
  148. override_prefs was instead used to check if there were any
  149. formats in session->req_caps. However, this usage isn't useful in
  150. create_outgoing_sdp_stream. session->req_caps contains the
  151. negotiated formats for *all* streams, not just the current one
  152. being created. Thus, so long as any stream of any type has
  153. provided a format, override_prefs will be non-zero. Hence, its
  154. usage in checking whether or not we should look at the formats on
  155. the endpoint or the joint capabilities is generally useless.
  156. There's only two things useful to check: (1) Does the endpoint
  157. have a format for the media type? (2) Did we negotiate a format
  158. for the media type? If either of those is a 'no', then we must
  159. kill the media stream.
  160. 2014-10-17 22:43 +0000 [r425905] Jonathan Rose <jrose@digium.com>
  161. * configs/samples/cli_aliases.conf.sample: Sample Configurations:
  162. make 'pjsip reload' reload all reloadable pjsip modules AST-1432
  163. #close Reported by: John Bigelow
  164. 2014-10-17 13:35 +0000 [r425821-425879] Matthew Jordan <mjordan@digium.com>
  165. * res/res_pjsip_sdp_rtp.c, res/res_pjsip.c,
  166. res/res_pjsip_session.c, /: res_pjsip_session/res_pjsip_sdp_rtp:
  167. Be more tolerant of offers When an inbound SDP offer is received,
  168. Asterisk currently makes a few incorrection assumptions: (1) If
  169. the offer contains more than a single audio/video stream,
  170. Asterisk will reject the entire stream with a 488. This is an
  171. overly strict response; generally, Asterisk should accept the
  172. media streams that it can accept and decline the others. (2) If
  173. the offer contains a declined media stream, Asterisk will attempt
  174. to process it anyway. This can result in attempting to match
  175. format capabilities on a declined media stream, leading to a 488.
  176. Asterisk should simply ignore declined media streams. (3)
  177. Asterisk will currently attempt to handle offers with AVPF with
  178. use_avpf=No/AVP with use_avpf=Yes. This mismatch results in
  179. invalid SDP answers being sent in response. If there is a
  180. mismatch between the media type being offered and the
  181. configuration, Asterisk must reject the offer with a 488. This
  182. patch does the following: * Asterisk will accept SDP offers with
  183. at least one media stream that it can use. Some WARNING messages
  184. have been dropped to NOTICEs as a result. * Asterisk will not
  185. accept an offer with a media type that doesn't match its
  186. configuration. * Asterisk will ignore declined media streams
  187. properly. #SIPit31 Review:
  188. https://reviewboard.asterisk.org/r/4063/ ASTERISK-24122 #close
  189. Reported by: James Van Vleet ASTERISK-24381 #close Reported by:
  190. Matt Jordan ........ Merged revisions 425868 from
  191. http://svn.asterisk.org/svn/asterisk/branches/12
  192. * /, channels/chan_sip.c: channels/chan_sip: Respect outboundproxy
  193. setting when sending qualify requests The outboundproxy setting
  194. is currently ignored when sending OPTIONS requests as a result of
  195. the qualify setting. This means that if an Asterisk server is
  196. unable to send the packet directly to a peer, it is unable to
  197. qualify any non-inbound registered peer (e.g. a peer SIP Trunk).
  198. This patch grabs the outboundproxy information for a peer when a
  199. qualify attempt is being constructed and, if it finds the
  200. information, uses it when sending the OPTIONS request. Review:
  201. https://reviewboard.asterisk.org/r/3948 ASTERISK-24063 #close
  202. Reported by: Damian Ivereigh patches: outboundproxy-dai.patch
  203. uploaded by Damian Ivereigh (License 6632) ........ Merged
  204. revisions 425818 from
  205. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  206. revisions 425819 from
  207. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  208. revisions 425820 from
  209. http://svn.asterisk.org/svn/asterisk/branches/12
  210. 2014-10-17 02:41 +0000 [r425783] Richard Mudgett <rmudgett@digium.com>
  211. * main/core_unreal.c, main/channel.c, /: AMI: Add missing VarSet
  212. events when a channel inherits variables. There should be AMI
  213. VarSet events when channel variables are inherited by an outgoing
  214. channel. Also local;2 should generate VarSet events when it gets
  215. all of its channel variables from channel local;1. ASTERISK-24415
  216. #close Reported by: Richard Mudgett Patches:
  217. jira_asterisk_24415_v12.patch (license #5621) patch uploaded by
  218. Richard Mudgett Review: https://reviewboard.asterisk.org/r/4074/
  219. ........ Merged revisions 425782 from
  220. http://svn.asterisk.org/svn/asterisk/branches/12
  221. 2014-10-17 01:57 +0000 [r425736-425761] Matthew Jordan <mjordan@digium.com>
  222. * /, bridges/bridge_native_rtp.c: bridge_native_rtp: Fix audio
  223. issues when moving from remote bridge to softmix When a native
  224. RTP bridge that is remotely bridging its participants switches to
  225. a softmix bridge, it may not properly re-INVITE the media for one
  226. or both participants back to Asterisk. This is due to the current
  227. bridge_native_rtp code only re-INVITEs if it believes the channel
  228. will survive the bridge operation. Currently, that code is
  229. failing, as it expects the channels to have a soft hangup flag
  230. set on it indicating that a redirect has occurred or that the
  231. channel is going to leave the bridge. (The code did not take into
  232. account a smart bridge operation). This patch also renames a few
  233. things to be more reflective of the underlying types. Review:
  234. https://reviewboard.asterisk.org/r/3997/ ASTERISK-24327 #close
  235. ........ Merged revisions 425760 from
  236. http://svn.asterisk.org/svn/asterisk/branches/12
  237. * /, tests/test_cel.c: test_cel: Update pickup test to expect
  238. CANCEL instead of ANSWSER The CEL pickup test previously looked
  239. for a disposition of ANSWER between the original caller/peer when
  240. the call is picked up. This is actually incorrect: the
  241. disposition should, at the very least, not be ANSWER as the call
  242. was never ANSWERed. The disposition is now CANCEL; this patch
  243. updates the test accordingly. ........ Merged revisions 425757
  244. from http://svn.asterisk.org/svn/asterisk/branches/12
  245. * main/cdr.c, /: main/cdr: Use 'time' when rescheduling batched
  246. CDRs as opposed to 'size' When refactoring CDRs to use the
  247. configuration framework, a 'whoops' was introduced where the CDR
  248. batch size was used when rescheduling a batch, as opposed to the
  249. time duration. This patch corrects that obvious mistake.
  250. ASTERISK-24426 #close Reported by: Shane Blaser ........ Merged
  251. revisions 425735 from
  252. http://svn.asterisk.org/svn/asterisk/branches/12
  253. 2014-10-16 17:30 +0000 [r425714] George Joseph <george.joseph@fairview5.com>
  254. * include/asterisk/config.h, tests/test_config.c, main/config.c, /:
  255. config: Fix inf loop using ast_category_browse and
  256. ast_variable_retrieve Fix infinite loop when calling
  257. ast_variable_retrieve inside an ast_category_browse loop when
  258. there is more than 1 category with the same name. Tested-by:
  259. George Joseph Review: https://reviewboard.asterisk.org/r/4089/
  260. ........ Merged revisions 425713 from
  261. http://svn.asterisk.org/svn/asterisk/branches/12
  262. 2014-10-16 14:35 +0000 [r425691] Kinsey Moore <kmoore@digium.com>
  263. * res/res_pjsip_t38.c, res/res_pjsip_registrar_expire.c,
  264. res/res_pjsip_mwi_body_generator.c,
  265. res/res_pjsip_endpoint_identifier_user.c,
  266. res/res_pjsip_send_to_voicemail.c,
  267. include/asterisk/res_pjsip_pubsub.h,
  268. res/res_pjsip_outbound_authenticator_digest.c,
  269. res/res_pjsip_outbound_registration.c,
  270. res/res_pjsip_endpoint_identifier_anonymous.c,
  271. res/res_pjsip_path.c, res/res_pjsip_one_touch_record_info.c,
  272. res/res_pjsip_acl.c, res/res_pjsip_pubsub.c,
  273. res/res_pjsip_diversion.c, res/res_pjsip_refer.c,
  274. include/asterisk/res_pjsip.h,
  275. res/res_pjsip_pidf_body_generator.c, res/res_pjsip_dtmf_info.c,
  276. res/res_pjsip_multihomed.c, res/res_pjsip_authenticator_digest.c,
  277. res/res_pjsip_sdp_rtp.c, res/res_hep_pjsip.c,
  278. res/res_pjsip_messaging.c, res/res_pjsip_caller_id.c,
  279. res/res_pjsip_logger.c, res/res_pjsip_nat.c,
  280. res/res_pjsip_session.c, res/res_pjsip_exten_state.c,
  281. res/res_pjsip_header_funcs.c, res/res_pjsip_rfc3326.c,
  282. res/res_pjsip_phoneprov_provider.c, res/res_pjsip_mwi.c,
  283. res/res_pjsip_dialog_info_body_generator.c,
  284. res/res_pjsip_xpidf_body_generator.c, res/res_pjsip_registrar.c,
  285. channels/chan_pjsip.c, res/res_pjsip_transport_websocket.c,
  286. res/res_pjsip_pidf_eyebeam_body_supplement.c,
  287. include/asterisk/res_pjsip_session.h, /, res/res_pjsip_notify.c,
  288. res/res_pjsip_pidf_digium_body_supplement.c,
  289. res/res_pjsip_endpoint_identifier_ip.c,
  290. res/res_pjsip_publish_asterisk.c: PJSIP: Enforce module load
  291. dependencies This enforces that res_pjsip, res_pjsip_session, and
  292. res_pjsip_pubsub have loaded properly before attempting to load
  293. any modules that depend on them since the module loader system is
  294. not currently capable of resolving module dependencies on its
  295. own. ASTERISK-24312 #close Reported by: Dafi Ni Review:
  296. https://reviewboard.asterisk.org/r/4062/ ........ Merged
  297. revisions 425690 from
  298. http://svn.asterisk.org/svn/asterisk/branches/12
  299. 2014-10-16 06:11 +0000 [r425669] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  300. * channels/chan_unistim.c, /: Fix loss of voice after second call
  301. drops (on a second line) in case using multiple lines on unistim
  302. phones. There is regression was introduced in r391379. Reported
  303. by: Rustam Khankishyiev (closes issue ASTERISK-23846) ........
  304. Merged revisions 425667 from
  305. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  306. revisions 425668 from
  307. http://svn.asterisk.org/svn/asterisk/branches/12
  308. 2014-10-16 01:25 +0000 [r425646] Joshua Colp <jcolp@digium.com>
  309. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fix a bug where ICE
  310. state would get reset when it shouldn't. In the case where the
  311. ICE negotiation had not yet started current state would get wiped
  312. when it shouldn't. This also removes channel binding as in
  313. practice this does not work well with other implementations.
  314. ........ Merged revisions 425644 from
  315. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  316. revisions 425645 from
  317. http://svn.asterisk.org/svn/asterisk/branches/12
  318. 2014-10-15 19:31 +0000 [r425627] Richard Mudgett <rmudgett@digium.com>
  319. * channels/chan_motif.c: chan_motif: Cleanup
  320. jingle_tech.capabilities only once.
  321. 2014-10-15 19:05 +0000 [r425611] Jonathan Rose <jrose@digium.com>
  322. * res/parking/parking_tests.c: parking_tests: Fix assertions and
  323. possibly crashes in res_parking unit tests Assertions were caused
  324. by attempting to play music on hold to a channel with no formats.
  325. Parking unit test channels were given formats and a technology so
  326. that they would be able to pretend to read/write frames.
  327. ASTERISK-24413 #close Reported by: Matt Jordan Review:
  328. https://reviewboard.asterisk.org/r/4075/
  329. 2014-10-15 09:59 +0000 [r425590] Alexandr Anikin <may@telecom-service.ru>
  330. * addons/chan_ooh323.c, /: chan_ooh323: fix rtptimeout general
  331. value checking correct condition to check rtptimeout in [general]
  332. config section ASTERISK-24393 #close Reported by: Dmitry Melekhov
  333. Tested by: Dmitry Melekhov Patches: ASTERISK-24393.patch ........
  334. Merged revisions 425547 from
  335. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  336. revisions 425548 from
  337. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  338. revisions 425589 from
  339. http://svn.asterisk.org/svn/asterisk/branches/12
  340. 2014-10-14 20:46 +0000 [r425526] George Joseph <george.joseph@fairview5.com>
  341. * /, include/asterisk/config.h, tests/test_config.c, main/config.c:
  342. config: Fix SEGV in unit test with MALLOC_DEBUG With MALLOC_DEBUG
  343. the /main/config config_basic_ops test was causing a SEGV while
  344. doing an ast_category_delete in an ast_category_browse loop.
  345. Apparently this never worked but was also never tested. I removed
  346. the test, added 2 notes to config.h indicating that it's not
  347. supported and added a few lines of code to ast_category_delete to
  348. prevent the SEGV should someone attempt it in the future.
  349. Tested-by: George Joseph Review:
  350. https://reviewboard.asterisk.org/r/4078/ ........ Merged
  351. revisions 425525 from
  352. http://svn.asterisk.org/svn/asterisk/branches/12
  353. 2014-10-14 19:00 +0000 [r425504] Jonathan Rose <jrose@digium.com>
  354. * main/sched.c, /: Scheduler: Fix a nasty scheduler caching bug
  355. which makes new tasks not execute Tasks that were marked for
  356. pending deletion in the scheduler would be moved to the cache for
  357. later reuse, but after being recycled the deleted mark wouldn't
  358. be removed resulting in fresh tasks being deleted without
  359. reason... and immediately moved back into the cache where they
  360. could be reused again. This could cause horrendous things to
  361. happen in just about anything that used a scheduler.
  362. ASTERISK-24321 #close Reported by: Steve Pitts Review:
  363. https://reviewboard.asterisk.org/r/4071/ ........ Merged
  364. revisions 425503 from
  365. http://svn.asterisk.org/svn/asterisk/branches/12
  366. 2014-10-14 18:12 +0000 [r425481] George Joseph <george.joseph@fairview5.com>
  367. * res/res_phoneprov.c, include/asterisk/phoneprov.h, /,
  368. res/res_pjsip_phoneprov_provider.c: res_phoneprov: Create
  369. accessor for ast_phoneprov_std_variable_lookup Based on feedback
  370. from Richard, I created an accessor for
  371. res_phoneprov/ast_phoneprov_std_variable_lookup and added load
  372. priority to AST_MODULE_INFO. Tested-by: George Joseph Tested-by:
  373. Richard Mudgett Review: https://reviewboard.asterisk.org/r/4076/
  374. ........ Merged revisions 425480 from
  375. http://svn.asterisk.org/svn/asterisk/branches/12
  376. 2014-10-14 16:46 +0000 [r425459] Corey Farrell <git@cfware.com>
  377. * /, res/res_fax.c: res_fax: Fix reference leak caused by gateway
  378. sessions Fax gateway session objects can be re-used, causing the
  379. same gateway session to be added to faxregistry.container more
  380. than once. This change causes fax_session_new to remove the
  381. reserved session from the container before it's id is changed,
  382. ensuring it's possible for the session to be freed.
  383. ASTERISK-24392 #close Reported by: Corey Farrell Review:
  384. https://reviewboard.asterisk.org/r/4049/ ........ Merged
  385. revisions 425457 from
  386. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  387. revisions 425458 from
  388. http://svn.asterisk.org/svn/asterisk/branches/12
  389. 2014-10-14 16:35 +0000 [r425455] Richard Mudgett <rmudgett@digium.com>
  390. * /, main/stasis_channels.c: stasis_channels.c: Resolve unfinished
  391. Dials when doing masquerades (Part 2) Masquerades into and out of
  392. channels that are involved in a dial operation don't create the
  393. expected dial end event. The missing dial end event goes against
  394. the model for things like CDRs and generating Dial end manager
  395. actions and such. There are four cases: 1) A channel masquerades
  396. into the caller channel. The case happens when performing a
  397. blonde transfer using the channel driver's protocol. 2) A channel
  398. masquerades into a callee channel. The case happens when
  399. performing a directed call pickup. 3) The caller channel
  400. masquerades out of dial. The case happens when using the Bridge
  401. application on the caller channel. 4) A callee channel
  402. masquerades out of dial. The case happens when using the Bridge
  403. application on a peer channel. As it turned out, all four cases
  404. need to be handled instead of just the first one. ASTERISK-24237
  405. Reported by: Richard Mudgett ASTERISK-24394 #close Reported by:
  406. Richard Mudgett Review: https://reviewboard.asterisk.org/r/4066/
  407. ........ Merged revisions 425430 from
  408. http://svn.asterisk.org/svn/asterisk/branches/12
  409. 2014-10-14 16:19 +0000 [r425415] Corey Farrell <git@cfware.com>
  410. * /, res/res_fax.c: res_fax: Resolve module reference leak caused
  411. by reserved sessions Remove reference to module providing
  412. reserved session after adding a reference to the final module.
  413. This re-reference is done to ensure that module references are
  414. correct even if the final session selects a different module than
  415. the reserved session. ASTERISK-18923 #close Reported by: Grigoriy
  416. Puzankin Review: https://reviewboard.asterisk.org/r/4048/
  417. ........ Merged revisions 425405 from
  418. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  419. revisions 425407 from
  420. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  421. revisions 425411 from
  422. http://svn.asterisk.org/svn/asterisk/branches/12
  423. 2014-10-13 16:10 +0000 [r425384] George Joseph <george.joseph@fairview5.com>
  424. * apps/app_directory.c, tests/test_sorcery.c, main/config.c,
  425. tests/test_sorcery_realtime.c, res/res_sorcery_realtime.c,
  426. apps/app_voicemail.c, res/res_sorcery_config.c, main/manager.c,
  427. /, include/asterisk/config.h, pbx/pbx_realtime.c,
  428. tests/test_config.c: manager/config: Support templates and
  429. non-unique category names via AMI This patch provides the
  430. capability to manipulate templates and categories with non-unique
  431. names via AMI. Summary of changes: GetConfig and GetConfigJSON:
  432. Added "Filter" parameter: A comma separated list of
  433. name_regex=value_regex expressions which will cause only
  434. categories whose variables match all expressions to be
  435. considered. The special variable name TEMPLATES can be used to
  436. control whether templates are included. Passing 'include' as the
  437. value will include templates along with normal categories.
  438. Passing 'restrict' as the value will restrict the operation to
  439. ONLY templates. Not specifying a TEMPLATES expression results in
  440. the current default behavior which is to not include templates.
  441. UpdateConfig: NewCat now includes options for allowing duplicate
  442. category names, indicating if the category should be created as a
  443. template, and specifying templates the category should inherit
  444. from. The rest of the actions now accept a filter string as
  445. defined above. If there are non-unique category names, you can
  446. now update specific ones based on variable values. To facilitate
  447. the new capabilities in manager, corresponding changes had to be
  448. made to config, most notably the addition of filter criteria to
  449. many of the APIs. In some cases it was easy to change the
  450. references to use the new prototype but others would have
  451. required touching too many files for this patch so a wrapper with
  452. the original prototype was created. Macros couldn't be used in
  453. this case because it would break binary compatibility with
  454. modules such as res_digium_phone that are linked to real symbols.
  455. Tested-by: George Joseph Review:
  456. https://reviewboard.asterisk.org/r/4033/ ........ Merged
  457. revisions 425383 from
  458. http://svn.asterisk.org/svn/asterisk/branches/12
  459. 2014-10-12 21:09 +0000 [r425362] Joshua Colp <jcolp@digium.com>
  460. * /, res/res_rtp_asterisk.c: res_rtp_asterisk: Make the ICE
  461. transport check case insensitive as some implementations use
  462. 'udp'. ........ Merged revisions 425360 from
  463. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  464. revisions 425361 from
  465. http://svn.asterisk.org/svn/asterisk/branches/12
  466. 2014-10-12 08:15 +0000 [r425289-425299] Walter Doekes <walter+asterisk@wjd.nu>
  467. * /, channels/chan_sip.c: chan_sip: Fix so asterisk won't send
  468. reINVITE after a BYE. After a reINVITE glare situation, Asterisk
  469. would re-send the reINVITE even though the call had been hung up
  470. in the mean time. This patch unschedules the reinvite when
  471. handling the BYE. ASTERISK-22791 #close Reported by: Paolo
  472. Compagnini Tested by: Paolo Compagnini Review:
  473. https://reviewboard.asterisk.org/r/4056/ (testcase is in review
  474. r4055) ........ Merged revisions 425296 from
  475. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  476. revisions 425297 from
  477. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  478. revisions 425298 from
  479. http://svn.asterisk.org/svn/asterisk/branches/12
  480. * /, Makefile: build: Relax badshell tilde test to allow for ~ in
  481. middle of DESTDIR. The main Makefile has a target test called
  482. 'badshell' that tests if DESTDIR does not happen to have an
  483. an-expanded tilde (~). This might be the case if you run: make
  484. install DESTDIR=~/somewhere/ That test also disallowed valid
  485. tildes in directory names. The test is now changed to only
  486. trigger on a tilde at the start of the path. ASTERISK-13797
  487. #close Reported by: Tzafrir Cohen Review:
  488. https://reviewboard.asterisk.org/r/4064/ ........ Merged
  489. revisions 425291 from
  490. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  491. revisions 425292 from
  492. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  493. revisions 425293 from
  494. http://svn.asterisk.org/svn/asterisk/branches/12
  495. * /, res/res_calendar_ews.c: res_calendar_ews: Relax neon version
  496. check to work with 0.30 too. Allow res_calendar_ews to work not
  497. only with libneon-0.29 but also with 0.30. ASTERISK-24325 #close
  498. Reported by: Tzafrir Cohen Review:
  499. https://reviewboard.asterisk.org/r/4068/ ........ Merged
  500. revisions 425286 from
  501. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  502. revisions 425287 from
  503. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  504. revisions 425288 from
  505. http://svn.asterisk.org/svn/asterisk/branches/12
  506. 2014-10-11 21:08 +0000 [r425265] George Joseph <george.joseph@fairview5.com>
  507. * /, res/res_phoneprov.c: res_phoneprov: Cleanup module load error
  508. handling Tested module load/reload interaction between
  509. res_phoneprov and res_pjsip_phoneprov_provider in cases where
  510. res_phoneprov didn't load correctly (usually misconfiguration or
  511. missing phoneprov.conf) Tested-by: George Joseph Review:
  512. https://reviewboard.asterisk.org/r/4069/ ........ Merged
  513. revisions 425264 from
  514. http://svn.asterisk.org/svn/asterisk/branches/12
  515. 2014-10-10 20:48 +0000 [r425243] Joshua Colp <jcolp@digium.com>
  516. * /, main/bridge.c, bridges/bridge_native_rtp.c: bridge: During a
  517. smart bridge operation provide a more complete bridge to the old
  518. technology. When a smart bridge operation occurs and a bridge
  519. transitions from one technology to another the old technology is
  520. provided the channels formerly in it and told that they are
  521. leaving. Unfortunately the bridge provided along with them is
  522. incomplete. The bridge, despite there being channels in it,
  523. contains none. This forces technology implementations to have
  524. additional logic when channels are leaving or to store their own
  525. duplicated state. This change makes the bridge more complete so
  526. it contains the expected channels. Now that the bridge is
  527. complete special logic within bridge_native_rtp is no longer
  528. needed and has been removed. Review:
  529. https://reviewboard.asterisk.org/r/4057/ ........ Merged
  530. revisions 425242 from
  531. http://svn.asterisk.org/svn/asterisk/branches/12
  532. 2014-10-10 14:31 +0000 [r425221] Matthew Jordan <mjordan@digium.com>
  533. * /, res/res_phoneprov.c: res/res_phoneprov: Bail on registration
  534. if res_phoneprov didn't load If res_phoneprov failed to fully
  535. load (due to not being configured), the providers container will
  536. be NULL. If a module attempts to register a phone provisioning
  537. provider, it should check for the presence of the container. If
  538. there is no providers container, it should return an error. This
  539. patch makes the ast_phoneprov_provider_register function do
  540. that... otherwise this would be a silly commit message. ........
  541. Merged revisions 425220 from
  542. http://svn.asterisk.org/svn/asterisk/branches/12
  543. 2014-10-10 14:23 +0000 [r425217] Joshua Colp <jcolp@digium.com>
  544. * /, res/res_pjsip_phoneprov_provider.c:
  545. res_pjsip_phoneprov_provider: Add missing dependency on
  546. pjproject. ........ Merged revisions 425216 from
  547. http://svn.asterisk.org/svn/asterisk/branches/12
  548. 2014-10-10 13:01 +0000 [r425155] Kinsey Moore <kmoore@digium.com>
  549. * /, tests/test_callerid.c, main/callerid.c: CallerID: Fix parsing
  550. regression This fixes a regression in callerid parsing introduced
  551. when another bug was fixed. This bug occurred when the name was
  552. composed entirely of DTMF keys and quoted without a number
  553. section (<>). ASTERISK-24406 #close Reported by: Etienne Lessard
  554. Tested by: Etienne Lessard Patches: callerid_fix.diff uploaded by
  555. Kinsey Moore Review: https://reviewboard.asterisk.org/r/4067/
  556. ........ Merged revisions 425152 from
  557. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  558. revisions 425153 from
  559. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  560. revisions 425154 from
  561. http://svn.asterisk.org/svn/asterisk/branches/12
  562. 2014-10-10 12:10 +0000 [r425132] Joshua Colp <jcolp@digium.com>
  563. * res/res_pjsip_nat.c, /: res_pjsip_nat: Place source port into
  564. rport of responses if 'force_rport' is on. When the 'force_rport'
  565. option is enabled the behavior should be the same as if the
  566. remote side placed rport into the message themselves. Therefore
  567. any responses we send should include the source port of the
  568. request in the rport of the Via header. #SIPit31 ASTERISK-24387
  569. #close Reported by: Matt Jordan ........ Merged revisions 425131
  570. from http://svn.asterisk.org/svn/asterisk/branches/12
  571. 2014-10-10 07:32 +0000 [r425071] Walter Doekes <walter+asterisk@wjd.nu>
  572. * /, channels/chan_sip.c: chan_sip: Fix dialog leak resulting from
  573. missing ACK to re-INVITE. If a device re-INVITEs at the same time
  574. as the dialog is hung up, and if then the ACK to the re-INVITE
  575. never reaches Asterisk, chan_sip would fail to destroy the dialog
  576. after a while. This resulted in (most prominently) file handle
  577. leaks. (Patch reindented by me.) ASTERISK-20784 #close
  578. ASTERISK-15879 #close Reported by: Torrey Searle, Nitesh Bansal
  579. Patches: reinvite_ack_timeout.patch uploaded by Torrey Searle
  580. (License #5334) patch_asterisk_20784.txt uploaded by Nitesh
  581. Bansal (License #6418) Reviewboard:
  582. https://reviewboard.asterisk.org/r/4052/ (testcase can be found
  583. at r4051) ........ Merged revisions 425068 from
  584. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  585. revisions 425069 from
  586. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  587. revisions 425070 from
  588. http://svn.asterisk.org/svn/asterisk/branches/12
  589. 2014-10-09 23:35 +0000 [r425052] George Joseph <george.joseph@fairview5.com>
  590. * res/res_pjsip_phoneprov_provider.c: res_pjsip_phoneprov_provider:
  591. fix compile breakage on AST_VECTOR endpoint->inbound_auths was
  592. changed to a vector in 13 and I committed the 12 patch instead of
  593. the 13 patch. Tested-by: George Joseph
  594. 2014-10-09 21:38 +0000 [r425031] Kevin Harwell <kharwell@digium.com>
  595. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Crash if no
  596. candidates received for component When starting ice if there is
  597. not at least one remote ice candidate with an RTP component
  598. asterisk will crash. This is due to an assertion in pjnath as it
  599. expects at least one candidate with an RTP component. Added a
  600. check to make sure at least one candidate contains an RTP
  601. component and at least one candidate has an RTCP component.
  602. ASTERISK-24383 #close Review:
  603. https://reviewboard.asterisk.org/r/4039/ ........ Merged
  604. revisions 425030 from
  605. http://svn.asterisk.org/svn/asterisk/branches/12
  606. 2014-10-09 20:54 +0000 [r425008] George Joseph <george.joseph@fairview5.com>
  607. * /, res/res_pjsip_phoneprov_provider.c (added),
  608. configs/samples/pjsip.conf.sample: res_pjsip_phoneprov_provider:
  609. Provides pjsip integration with res_phoneprov This module allows
  610. res_pjsip to integrate with res_phoneprov. It handles the pjsip
  611. 'phoneprov' object type. Tested-by: George Joseph Review:
  612. https://reviewboard.asterisk.org/r/3976/ ........ Merged
  613. revisions 425007 from
  614. http://svn.asterisk.org/svn/asterisk/branches/12
  615. 2014-10-09 18:37 +0000 [r424986] Matthew Jordan <mjordan@digium.com>
  616. * /, res/res_phoneprov.c: res/res_phoneprov: Don't cancel Asterisk
  617. load on module load failure ........ Merged revisions 424985 from
  618. http://svn.asterisk.org/svn/asterisk/branches/12
  619. 2014-10-09 17:45 +0000 [r424964] George Joseph <george.joseph@fairview5.com>
  620. * include/asterisk/phoneprov.h (added), /,
  621. configs/samples/phoneprov.conf.sample,
  622. include/asterisk/chanvars.h, res/res_phoneprov.c,
  623. res/res_phoneprov.exports.in (added), main/chanvars.c:
  624. res_phoneprov: Refactor phoneprov to allow pluggable config
  625. providers This patch makes res_phoneprov more modular so other
  626. modules (like pjsip) can provide configuration information
  627. instead of res_phoneprov relying solely on users.conf and
  628. sip.conf. To accomplish this a new ast_phoneprov public API is
  629. now exposed which allows config providers to register themselves,
  630. set defaults (server profile, etc) and add user extensions. *
  631. ast_phoneprov_provider_register registers the provider and
  632. provides callbacks for loading default settings and loading
  633. users. * ast_phoneprov_provider_unregister clears the defaults
  634. and users. * ast_phoneprov_add_extension should be called once
  635. for each user/extension by the provider's load_users callback to
  636. add them. * ast_phoneprov_delete_extension deletes one extension.
  637. * ast_phoneprov_delete_extensions deletes all extensions for the
  638. provider. Tested-by: George Joseph Review:
  639. https://reviewboard.asterisk.org/r/3970/ ........ Merged
  640. revisions 424963 from
  641. http://svn.asterisk.org/svn/asterisk/branches/12
  642. 2014-10-09 16:36 +0000 [r424942] Richard Mudgett <rmudgett@digium.com>
  643. * /, main/cdr.c: cdr.c: Make turning on CDR debug a one step
  644. process instead of two. Now "cdr set debug on" doesn't also
  645. require "core set verbose 1" to see CDR debug output. ........
  646. Merged revisions 424941 from
  647. http://svn.asterisk.org/svn/asterisk/branches/12
  648. 2014-10-09 08:08 +0000 [r424880] Walter Doekes <walter+asterisk@wjd.nu>
  649. * /, contrib/scripts/safe_asterisk: safe_asterisk: Don't
  650. automatically exceed MAXFILES value of 2^20. On systems with lots
  651. of RAM (e.g. 24GB) /proc/sys/fs/file-max divided by two can
  652. exceed the per-process file limit of 2^20. This patch ensures the
  653. value is capped. (Patch cleaned up by me.) ASTERISK-24011 #close
  654. Reported by: Michael Myles Patches: safe_asterisk-ulimit.diff
  655. uploaded by Michael Myles (License #6626) ........ Merged
  656. revisions 424875 from
  657. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  658. revisions 424878 from
  659. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  660. revisions 424879 from
  661. http://svn.asterisk.org/svn/asterisk/branches/12
  662. 2014-10-08 18:46 +0000 [r424854] Joshua Colp <jcolp@digium.com>
  663. * /, res/res_rtp_asterisk.c: res_rtp_asterisk: Allow only UDP ICE
  664. candidates. The underlying library, pjnath, that res_rtp_asterisk
  665. uses for ICE support does not have support for ICE-TCP. As
  666. candidates are passed through directly to it this can cause error
  667. messages to occur when it receives something unexpected (such as
  668. a TCP candidate). This change merely ignores all non-UDP
  669. candidates so they never reach pjnath. ASTERISK-24326 #close
  670. Reported by: Joshua Colp ........ Merged revisions 424852 from
  671. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  672. revisions 424853 from
  673. http://svn.asterisk.org/svn/asterisk/branches/12
  674. 2014-10-08 18:24 +0000 [r424769-424850] Kinsey Moore <kmoore@digium.com>
  675. * main/stasis.c: Stasis: Relegate log message to dev-mode This
  676. error message primarily applies to development tasks and will now
  677. only show up when dev-mode is enabled via configure.
  678. * main/sounds_index.c: Indexer: Format message types may not exist
  679. In Asterisk 13+, any given message type is not guaranteed to
  680. exist even if Asterisk comes up correctly since creation of the
  681. message type could be declined. The indexer should not prevent
  682. Asterisk from starting under these conditions.
  683. * main/stasis.c: Stasis: Only log errors for non-declined types
  684. When message type creation is declined via stasis.conf, certain
  685. operations log errors assuming that the declined type is being
  686. used before initialization or after destruction. These error
  687. messages get quite spammy for oft used message types and should
  688. not be logged in the first place since the message type is
  689. validly NULL. Reported by: Matt DiMeo
  690. 2014-10-07 18:33 +0000 [r424752] Joshua Colp <jcolp@digium.com>
  691. * main/data.c: data: Properly access formats in capabilities
  692. structure when adding codecs. Formats within a capabilities
  693. structure are addressed starting at 0, not 1. Assuming 1 causes
  694. it to exceed an array. ASTERISK-24389 #close Reported by: Kevin
  695. Harwell
  696. 2014-10-07 17:41 +0000 [r424692-424731] Matthew Jordan <mjordan@digium.com>
  697. * /, res/res_pjsip_outbound_registration.c:
  698. res/res_pjsip_outbound_registration: Initialize
  699. auth_reject_permanent parameter Prior to this patch, the
  700. auth_reject_permanent parameter was not initialized on the
  701. registration client state, leading to the parameter being
  702. disabled regardless of the value specified in pjsip.conf. This
  703. patch initialized the setting on the registration client state to
  704. the provided configuration value. ASTERISK-24398 #close ........
  705. Merged revisions 424730 from
  706. http://svn.asterisk.org/svn/asterisk/branches/12
  707. * res/res_pjsip_pubsub.c: res/res_pjsip_pubsub: Fix typo in WARNING
  708. message
  709. * main/message.c, /: message: Don't close an AMI connection on
  710. SendMessage action error If SendMessage encounters an error (such
  711. as incorrect input provided to the action), it will currently
  712. return -1. Actions should only return -1 if the connection to the
  713. AMI client should be closed. In this case, SendMessage causing
  714. the client to disconnect is inappropriate. This patch causes the
  715. action to return 0, which simply causes the action to fail.
  716. Review: https://reviewboard.asterisk.org/r/4024 ASTERISK-24354
  717. #close Reported by: Peter Katzmann patches: sendMessage.patch
  718. uploaded by Peter Katzmann (License 5968) ........ Merged
  719. revisions 424690 from
  720. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  721. revisions 424691 from
  722. http://svn.asterisk.org/svn/asterisk/branches/12
  723. 2014-10-06 15:38 +0000 [r424669] Richard Mudgett <rmudgett@digium.com>
  724. * main/features.c, /: features.c: Fix lingering channel ref while
  725. Bridge() application is active. Using the Bridge application to
  726. bridge a channel that is executing an applicaiton such as Wait
  727. results in a lingering Surrogate channel in the CLI "core show
  728. channels" output even though it has already hungup. * Fix
  729. bridge_exec() to not hold onto the current_dest_chan ref once it
  730. has been put into the bridge. * Eliminated bridge_exec()'s use of
  731. RAII_VAR(). ASTERISK-24224 #close Reported by: Mark Michelson
  732. Review: https://reviewboard.asterisk.org/r/4041/ ........ Merged
  733. revisions 424668 from
  734. http://svn.asterisk.org/svn/asterisk/branches/12
  735. 2014-10-06 12:38 +0000 [r424601-424647] Matthew Jordan <mjordan@digium.com>
  736. * /, main/sdp_srtp.c: sdp_srtp: Add new lines to some WARNING
  737. messages ........ Merged revisions 424646 from
  738. http://svn.asterisk.org/svn/asterisk/branches/12
  739. * /, res/res_pjsip/pjsip_options.c: res_pjsip/pjsip_options: Do not
  740. 404 an OPTIONS request not sent to an endpoint An OPTIONS request
  741. that is sent to Asterisk but not to a specific endpoint is
  742. currently sent a 404 in response. This is because, not
  743. surprisingly, an empty extension is never going to be found in
  744. the dialplan. This patch makes it so that we only attempt to look
  745. up the endpoint in the dialplan if it is specified in the OPTIONS
  746. request URI. #SIPit31 ASTERISK-24370 #close Reported by: Matt
  747. Jordan ........ Merged revisions 424624 from
  748. http://svn.asterisk.org/svn/asterisk/branches/12
  749. * channels/pjsip/dialplan_functions.c, /: pjsip/dialplan_functions:
  750. Handle PJSIP_MEDIA_OFFER called on non-PJSIP channels Calling
  751. PJSIP_MEDIA_OFFER on a non-PJSIP channel is hazardous to your
  752. health. It will treat the channels as a PJSIP channel, eventually
  753. hitting an ao2 error, FRACKing on assertion error, and quite
  754. likely crashing. This patch adds checks to the read/write
  755. callbacks that ensure that the channel technology is of type
  756. 'PJSIP' before attempting to operate on the channel. #SIPit31
  757. ASTERISK-24382 #close Reported by: Matt Jordan ........ Merged
  758. revisions 424621 from
  759. http://svn.asterisk.org/svn/asterisk/branches/12
  760. * /, res/res_hep_pjsip.c, res/res_pjsip/pjsip_distributor.c,
  761. res/res_pjsip_logger.c: res_pjsip: Prevent crashes when PJPROJECT
  762. presents an rdata with no message When a message that exceeds the
  763. PJ_MAX_PKT_SIZE is sent over a reliable transport, it is possible
  764. (although it shouldn't occur) for pjproject to pass up an rdata
  765. object with a NULL msg in the msg_info. Needless to say, things
  766. that attempt to dereference this are in for a rough ride. In
  767. particular, this caused crashes in three different locations, all
  768. of which are 'low level' enough to intercept an rdata object
  769. early in processing: (1) res_pjsip_logger (2) res_hep_pjsip (3)
  770. res_pjsip/distributor Anything that can intercept an rdata object
  771. before res_pjsip/distributor should be defensive when looking at
  772. the received packet. #SIPit31 ASTERISK-24369 #close Reported by:
  773. Matt Jordan ........ Merged revisions 424618 from
  774. http://svn.asterisk.org/svn/asterisk/branches/12
  775. * res/res_pjsip_pubsub.c: res/res_pjsip_pubsub: Gracefully handle
  776. errors when re-creating subscriptions A subscription that has
  777. been persisted can - for various reasons - fail to be re-created
  778. on startup. This patch resolves a number of crashes that occurred
  779. when a subscription cannot be re-created on several off-nominal
  780. paths. #SIPit31 ASTERISK-24368 #close Reported by: Matt Jordan
  781. 2014-10-05 00:48 +0000 [r424552-424580] Corey Farrell <git@cfware.com>
  782. * main/manager.c, /: Release AMI connections on shutdown.
  783. ASTERISK-24378 #close Reported by: Corey Farrell Review:
  784. https://reviewboard.asterisk.org/r/4037/ ........ Merged
  785. revisions 424578 from
  786. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  787. revisions 424579 from
  788. http://svn.asterisk.org/svn/asterisk/branches/12
  789. * channels/chan_motif.c: chan_motif: Correct last commit to use
  790. ao2_cleanup to free format cap This fix applies to 13 and trunk.
  791. ASTERISK-24384 #close Reported by: Corey Farrell Review:
  792. https://reviewboard.asterisk.org/r/4043/
  793. * /, channels/chan_motif.c: chan_motif: Release format capabilities
  794. and config on module load error ASTERISK-24384 #close Reported
  795. by: Corey Farrell Review:
  796. https://reviewboard.asterisk.org/r/4043/ ........ Merged
  797. revisions 424550 from
  798. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  799. revisions 424551 from
  800. http://svn.asterisk.org/svn/asterisk/branches/12
  801. 2014-10-03 21:56 +0000 [r424472-424529] Richard Mudgett <rmudgett@digium.com>
  802. * /, CHANGES, res/res_pjsip.c: res_pjsip: Fix XML typo and update
  803. CHANGES. ASTERISK-24199 ........ Merged revisions 424528 from
  804. http://svn.asterisk.org/svn/asterisk/branches/12
  805. * main/audiohook.c, apps/app_chanspy.c, apps/app_mixmonitor.c, /,
  806. main/framehook.c: audiohooks: Reevaluate the bridge technology
  807. when an audiohook is added or removed. Adding a mixmonitor to a
  808. channel causes the bridge to change technologies from native to
  809. simple_bridge so the call can be recorded. However, when the
  810. mixmonitor is stopped the bridge does not switch back to the
  811. native technology. * Added unbridge requests to reevaluate the
  812. bridge when a channel audiohook is removed. * Moved the unbridge
  813. request into ast_audiohook_attach() ensure that the bridge
  814. reevaluates whenever an audiohook is attached. This simplified
  815. the mixmonitor and chan_spy start code as well. * Added defensive
  816. code to stop_mixmonitor_full() in case additional arguments are
  817. ever added to the StopMixMonitor application. * Made
  818. ast_framehook_detach() not do an unbridge request if the
  819. framehook does not exist. * Made ast_framehook_list_fixup() do an
  820. unbridge request if there are any framehooks. Also simplified the
  821. loop. ASTERISK-24195 #close Reported by: Jonathan Rose Review:
  822. https://reviewboard.asterisk.org/r/4046/ ........ Merged
  823. revisions 424506 from
  824. http://svn.asterisk.org/svn/asterisk/branches/12
  825. * main/core_unreal.c, main/taskprocessor.c, channels/chan_iax2.c,
  826. res/res_pjsip_session.c, main/channel.c, channels/chan_misdn.c,
  827. channels/chan_skinny.c, funcs/func_frame_trace.c,
  828. channels/chan_motif.c, include/asterisk/frame.h,
  829. main/bridge_channel.c, channels/chan_pjsip.c,
  830. channels/chan_unistim.c, include/asterisk/res_pjsip_session.h,
  831. addons/chan_ooh323.c, /, include/asterisk/taskprocessor.h,
  832. channels/chan_sip.c, res/res_pjsip_session.exports.in:
  833. chan_pjsip: Fix deadlock when masquerading PJSIP channels.
  834. Performing a directed call pickup resulted in a deadlock when
  835. PJSIP channels were involved. A masquerade needs to hold onto the
  836. channel locks while it swaps channel information between the two
  837. channels involved in the masquerade. With PJSIP channels, the
  838. fixup routine needed to push a fixup task onto the PJSIP
  839. channel's serializer. Unfortunately, if the serializer was also
  840. processing a task that needed to lock the channel, you get
  841. deadlock. * Added a new control frame that is used to notify the
  842. channels that a masquerade is about to start and when it has
  843. completed. * Added the ability to query taskprocessors if the
  844. current thread is the taskprocessor thread. * Added the ability
  845. to suspend/unsuspend the PJSIP serializer thread so a masquerade
  846. could fixup the PJSIP channel without using the serializer.
  847. ASTERISK-24356 #close Reported by: rmudgett Review:
  848. https://reviewboard.asterisk.org/r/4034/ ........ Merged
  849. revisions 424471 from
  850. http://svn.asterisk.org/svn/asterisk/branches/12
  851. 2014-10-03 15:54 +0000 [r424448] George Joseph <george.joseph@fairview5.com>
  852. * /, main/sorcery.c: sorcery: Prevent SEGV in sorcery_wizard_create
  853. when there's no create function When you call
  854. ast_sorcery_create() you don't necessarily know which wizard is
  855. going to be invoked. If it happens to be a wizard like 'config'
  856. that doesn't have a 'create' virtual function you get a segfault
  857. in the sorcery_wizard_create callback. This patch catches the
  858. null function pointer, does an ast_assert, and logs an error.
  859. Review: https://reviewboard.asterisk.org/r/4044/ ........ Merged
  860. revisions 424447 from
  861. http://svn.asterisk.org/svn/asterisk/branches/12
  862. 2014-10-03 13:58 +0000 [r424424-424427] Kinsey Moore <kmoore@digium.com>
  863. * configs/samples/pjsip.conf.sample, /,
  864. res/res_pjsip/pjsip_configuration.c: PJSIP: Restore functional
  865. default for callerid_privacy The pjsip config option default
  866. fixups from r424263 altered the functional default from
  867. "allowed_not_screened" to "allowed". This change restores the
  868. functional default value when none is provided. ........ Merged
  869. revisions 424426 from
  870. http://svn.asterisk.org/svn/asterisk/branches/12
  871. * main/manager.c, /: Manager: Add missing fields and documentation
  872. for CoreShowChannels This corrects some issues introduced in the
  873. responses to the CoreShowChannels AMI command as well as adding
  874. documentation for the responses. The command in Asterisk 12 was
  875. missing the following fields: Duration, Application,
  876. ApplicationData, and BridgedChannel and BridgedUniqueID (replaced
  877. with BridgeId). ASTERISK-24262 #close Reported by: Mitch Claborn
  878. Review: https://reviewboard.asterisk.org/r/4040/ ........ Merged
  879. revisions 424423 from
  880. http://svn.asterisk.org/svn/asterisk/branches/12
  881. 2014-10-03 07:54 +0000 [r424415] Joshua Colp <jcolp@digium.com>
  882. * res/res_pjsip_session.c, /: res_pjsip_session: Reduce SDP size by
  883. removing duplicate connection lines. Due to the architecture of
  884. how media streams are handled each individual handler adds
  885. connection details (IP address) for it. The first media stream is
  886. then used as the top level SDP connection line. In practice each
  887. line ends up being the same so to reduce the SDP size
  888. stream-level connection information is also added to the SDP if
  889. it differs from the top level SDP connection line. ........
  890. Merged revisions 424414 from
  891. http://svn.asterisk.org/svn/asterisk/branches/12
  892. 2014-10-02 21:52 +0000 [r424394] Richard Mudgett <rmudgett@digium.com>
  893. * /, configs/samples/pjsip.conf.sample, res/res_pjsip.c,
  894. res/res_pjsip/config_transport.c: res_pjsip: Make transport
  895. cipher option accept a comma separated list of cipher names.
  896. Improvements to the res_pjsip transport cipher option. * Made the
  897. cipher option accept a comma separated list of OpenSSL cipher
  898. names. Users of realtime will be glad if they have more than one
  899. name to list. * Added the CLI command 'pjsip list ciphers' so a
  900. user can know what OpenSSL names are available for the cipher
  901. option. * Updated the cipher option online XML documentation to
  902. specify what is expected for the value. * Updated
  903. pjsip.conf.sample to not indicate that ALL is acceptable since
  904. ALL does not imply a preference order for the ciphers and PJSIP
  905. does not simply pass the string to OpenSSL for interpretation.
  906. ASTERISK-24199 #close Reported by: Joshua Colp Review:
  907. https://reviewboard.asterisk.org/r/4018/ ........ Merged
  908. revisions 424393 from
  909. http://svn.asterisk.org/svn/asterisk/branches/12
  910. 2014-10-02 20:15 +0000 [r424373] Jonathan Rose <jrose@digium.com>
  911. * /,
  912. contrib/ast-db-manage/config/versions/10aedae86a32_add_outgoing_enum_va.py
  913. (added): Alembic: Add enumerator value to sippeers -> directmedia
  914. - 'outgoing' The 'outgoing' value was left off of the enumerator
  915. when first creating the column. This patch adds it, and should
  916. gracefully upgrade keeping the existing data in tact.
  917. ASTERISK-23781 #close Reported by: Stephen More Review:
  918. https://reviewboard.asterisk.org/r/4013/ ........ Merged
  919. revisions 424372 from
  920. http://svn.asterisk.org/svn/asterisk/branches/12
  921. 2014-10-02 13:35 +0000 [r424338] Scott Griepentrog <sgriepentrog@digium.com>
  922. * /, configs/samples/pjsip.conf.sample: res_pjsip: document use of
  923. rewrite_contact in sample conf Without setting rewrite_contact,
  924. an invite to an endpoint behind NAT will not reach it - unless
  925. the endpoint itself uses STUN or TURN to discover it's public
  926. URI. Thus, the use of this should be in the sample documentation.
  927. Review: https://reviewboard.asterisk.org/r/4036/ ........ Merged
  928. revisions 424337 from
  929. http://svn.asterisk.org/svn/asterisk/branches/12
  930. 2014-10-01 22:52 +0000 [r424333] Jonathan Rose <jrose@digium.com>
  931. * channels/chan_pjsip.c: chan_pjsip: Fix an assertion for channels
  932. that lack formats on creation ASTERISK-24222 #close Reported by:
  933. Mark Michelson Review: https://reviewboard.asterisk.org/r/4017/
  934. 2014-10-01 20:36 +0000 [r424313] Corey Farrell <git@cfware.com>
  935. * res/res_hep.c, /: res_hep: Release allocation reference to
  936. configuration. ASTERISK-24362 #close Reported by: Corey Farrell
  937. Review: https://reviewboard.asterisk.org/r/4026/ ........ Merged
  938. revisions 424312 from
  939. http://svn.asterisk.org/svn/asterisk/branches/12
  940. 2014-10-01 16:37 +0000 [r424288-424291] Joshua Colp <jcolp@digium.com>
  941. * /, res/res_pjsip/pjsip_configuration.c,
  942. configs/samples/pjsip.conf.sample, res/res_pjsip.c: res_pjsip:
  943. Add 'dtls_fingerprint' option to configure DTLS fingerprint hash.
  944. During the latest update to DTLS-SRTP support the ability to
  945. configure the hash used for fingerprints was added. This gave us
  946. two supported ones: SHA-1 and SHA-256. The default was
  947. accordingly updated to SHA-256. Unfortunately this configuration
  948. ability was not exposed within res_pjsip. This change adds a
  949. dtls_fingerprint option that controls it. #SIPit31 ........
  950. Merged revisions 424290 from
  951. http://svn.asterisk.org/svn/asterisk/branches/12
  952. * /, res/res_pjsip_sdp_rtp.c: res_pjsip_sdp_rtp: Accept DTLS
  953. attributes in top level, not just media session. #SIPit31
  954. ........ Merged revisions 424287 from
  955. http://svn.asterisk.org/svn/asterisk/branches/12
  956. 2014-10-01 12:27 +0000 [r424245-424266] Kinsey Moore <kmoore@digium.com>
  957. * res/res_pjsip/config_transport.c, /, res/res_pjsip/location.c,
  958. res/res_pjsip_endpoint_identifier_ip.c,
  959. res/res_pjsip/pjsip_configuration.c,
  960. configs/samples/pjsip.conf.sample: PJSIP: Handle defaults
  961. properly This updates the code behind PJSIP configuration options
  962. with custom handlers to deal with the assigned default values
  963. properly where it makes sense and adjusting the default value
  964. where it doesn't. Before applying this patch, there were several
  965. cases where the default value for an option would prevent that
  966. config section from loading properly. Reported by: Thomas
  967. Thompson Review: https://reviewboard.asterisk.org/r/4019/
  968. ........ Merged revisions 424263 from
  969. http://svn.asterisk.org/svn/asterisk/branches/12
  970. * /, res/res_pjsip_nat.c: PJSIP: Force transport on contact rewrite
  971. If contact rewriting is enabled but the contact differs in
  972. transport from what is actually being used, messages after the
  973. initial INVITE transaction can be sent to an incorrect
  974. transport/port combination. In the case where this bug occurred
  975. the remote party never received a BYE since it was sent to the
  976. remote party's TCP port over UDP. Review:
  977. https://reviewboard.asterisk.org/r/4032/ ........ Merged
  978. revisions 424244 from
  979. http://svn.asterisk.org/svn/asterisk/branches/12
  980. 2014-10-01 10:09 +0000 [r424179-424184] Walter Doekes <walter+asterisk@wjd.nu>
  981. * /, channels/chan_sip.c: chan_sip: Simplify some unref code by
  982. removing unlink_peer_from_tables. ASTERISK-22945 #related
  983. Reported by: ibercom Patches:
  984. asterisk11-chan_sip-simplifies.patch uploaded by ibercom (License
  985. #6599) ........ Merged revisions 424181 from
  986. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  987. revisions 424182 from
  988. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  989. revisions 424183 from
  990. http://svn.asterisk.org/svn/asterisk/branches/12
  991. * /, channels/chan_sip.c: chan_sip: Remove excess ref of realtime
  992. peer before sip_poke_peer. The peer is referenced at the end of
  993. sip_poke_peer, it should not get an extra ref before the call to
  994. sip_poke_peer. This fixes a memory leak. ASTERISK-22945 #close
  995. Reported by: ibercom Tested by: Yuriy Gorlichenko Patches:
  996. asterisk11.patch uploaded by ibercom (License #6599) Review:
  997. https://reviewboard.asterisk.org/r/4031/ ........ Merged
  998. revisions 424176 from
  999. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1000. revisions 424177 from
  1001. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1002. revisions 424178 from
  1003. http://svn.asterisk.org/svn/asterisk/branches/12
  1004. 2014-09-30 11:40 +0000 [r424153-424156] Joshua Colp <jcolp@digium.com>
  1005. * res/res_pjsip_sdp_rtp.c, /: res_pjsip_sdp_rtp: Don't place an
  1006. extra whitespace before 'rport' and don't put IPv6 addresses in
  1007. brackets. #SIPit31 ........ Merged revisions 424155 from
  1008. http://svn.asterisk.org/svn/asterisk/branches/12
  1009. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Ensure that the base
  1010. and mapped address for candidates is present in SDP. This change
  1011. fixes an issue where ICE candidates put into the SDP did not
  1012. contain the 'raddr' and 'rport' information for server reflexive
  1013. and relay candidates. #SIPit31 ........ Merged revisions 424151
  1014. from http://svn.asterisk.org/svn/asterisk/branches/11 ........
  1015. Merged revisions 424152 from
  1016. http://svn.asterisk.org/svn/asterisk/branches/12
  1017. 2014-09-29 21:59 +0000 [r424129] George Joseph <george.joseph@fairview5.com>
  1018. * /, res/res_pjsip/pjsip_cli.c: pjsip_cli: Suppress header print on
  1019. error or no objects If there's an error on the pjsip command line
  1020. or there are no objects, don't print the column headers.
  1021. ASTERISK-24350 #close Reported-by: Brad Latus Tested-by: George
  1022. Joseph Tested-by: Brad Latus Review:
  1023. https://reviewboard.asterisk.org/r/4025/ ........ Merged
  1024. revisions 424128 from
  1025. http://svn.asterisk.org/svn/asterisk/branches/12
  1026. 2014-09-29 21:26 +0000 [r424126] Walter Doekes <walter+asterisk@wjd.nu>
  1027. * /, contrib/scripts/autosupport: autosupport: Fix bashism. '==' is
  1028. bashism (bashspecific, fails when dash is /bin/sh). Anyway, a
  1029. 'case' works better there. Originally committed in r375059 and
  1030. r375060 on 2012-10-16 21:13:08. ASTERISK-20567 #close Reported
  1031. by: Tzafrir Cohen ........ Merged revisions 424117 from
  1032. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1033. revisions 424125 from
  1034. http://svn.asterisk.org/svn/asterisk/branches/12
  1035. 2014-09-29 21:17 +0000 [r424097-424105] Richard Mudgett <rmudgett@digium.com>
  1036. * res/res_pjsip.c, res/res_pjsip_pubsub.c, res/res_pjsip_session.c,
  1037. /, res/res_pjsip_authenticator_digest.c: Simplify UUID generation
  1038. in several places. Replace code using ast_uuid_generate() with
  1039. simpler and faster code using ast_uuid_generate_str(). The new
  1040. code avoids a malloc(), free(), and copy. ........ Merged
  1041. revisions 424103 from
  1042. http://svn.asterisk.org/svn/asterisk/branches/12
  1043. * /, main/threadpool.c: threadpool.c: Minor cleanup fixes. * Fix
  1044. threadpool_alloc() prototype. * Add missing off-nominal NULL
  1045. check of pool in threadpool_alloc(). * searializer_create() does
  1046. not need to create the object with a lock as the lock is not
  1047. used. ........ Merged revisions 424096 from
  1048. http://svn.asterisk.org/svn/asterisk/branches/12
  1049. 2014-09-27 12:43 +0000 [r424057] Joshua Colp <jcolp@digium.com>
  1050. * channels/chan_pjsip.c, res/res_pjsip_session.c, /:
  1051. res_pjsip_session: Add additional checks for delaying session
  1052. refreshes. There are certain situations which no checks existed
  1053. for which need to prevent session refreshes. This includes
  1054. sending a session refresh with SDP before SDP negotiation has
  1055. completed and sending a session refresh before the dialog itself
  1056. has been established. Checks for these have been added.
  1057. Additionally COLP related UPDATEs were including SDP when it is
  1058. not needed. Review: https://reviewboard.asterisk.org/r/4008/
  1059. ........ Merged revisions 424056 from
  1060. http://svn.asterisk.org/svn/asterisk/branches/12
  1061. 2014-09-26 15:21 +0000 [r423992] Richard Mudgett <rmudgett@digium.com>
  1062. * /, res/res_fax.c: res_fax: Fix out of bounds error in
  1063. update_modem_bits(). ASTERISK-24357 #close Reported by: Jeremy
  1064. Laine Patches: res_fax_bounds.patch (license #6561) patch
  1065. uploaded by Jeremy Laine Modified patch to not use magic numbers.
  1066. ........ Merged revisions 423979 from
  1067. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1068. revisions 423983 from
  1069. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1070. revisions 423987 from
  1071. http://svn.asterisk.org/svn/asterisk/branches/12
  1072. 2014-09-26 08:25 +0000 [r423918] Walter Doekes <walter+asterisk@wjd.nu>
  1073. * /, doc/asterisk.8: docs: Escape unescaped minus sign in
  1074. asterisk.8 manpage. ASTERISK-23768 #close Reported by: Jeremy
  1075. Lainé Patches: escape_manpage_hyphen.patch uploaded by Jeremy
  1076. Lainé (License #6561) ........ Merged revisions 423915 from
  1077. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1078. revisions 423916 from
  1079. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1080. revisions 423917 from
  1081. http://svn.asterisk.org/svn/asterisk/branches/12
  1082. 2014-09-25 21:01 +0000 [r423895] Richard Mudgett <rmudgett@digium.com>
  1083. * res/res_pjsip.c, /: res_pjsip.c: Add missing off nominal cleanup
  1084. in ast_sip_push_task_synchronous(). * Made memset the std struct
  1085. in ast_sip_push_task_synchronous() because if DEBUG_THREADS is
  1086. enabled then uninitialized lock tracking data is used. ........
  1087. Merged revisions 423894 from
  1088. http://svn.asterisk.org/svn/asterisk/branches/12
  1089. 2014-09-24 18:32 +0000 [r423867] Richard Mudgett <rmudgett@digium.com>
  1090. * /, res/res_pjsip/pjsip_options.c, res/res_pjsip.c:
  1091. pjsip_options.c: Fix race condition stopping periodic out of
  1092. dialog OPTIONS request. The crash on the issues is a result of an
  1093. invalid transport configuration change when asterisk is
  1094. restarted. The attempt to send the qualify request fails and we
  1095. cleaned up. However, the callback is also called which results in
  1096. a double unref of the objects involved. * Put a wrapper around
  1097. pjsip_endpt_send_request() to detect when the passed in callback
  1098. is called because of an error so callers can know to not cleanup.
  1099. * Made send_request_cb() able to handle repeated challenges (Up
  1100. to 10). * Fix periodic endpoint qualify OPTIONS sched deletion
  1101. race by avoiding it. The sched entry will no longer self stop and
  1102. must be externally stopped. * Added REF_DEBUG description tags to
  1103. struct sched_data in pjsip_options.c. * Fix some off-nominal ref
  1104. leaks in schedule_qualify(), qualify_and_schedule(). * Reordered
  1105. pjsip_options.c module start/stop code to cleanup better on
  1106. error. ASTERISK-24295 #close Reported by: Rogger Padilla Review:
  1107. https://reviewboard.asterisk.org/r/3954/ ........ Merged
  1108. revisions 423866 from
  1109. http://svn.asterisk.org/svn/asterisk/branches/12
  1110. 2014-09-24 08:53 +0000 [r423803] Walter Doekes <walter+asterisk@wjd.nu>
  1111. * /, channels/chan_sip.c: chan_sip: Unref outbound proxy structure
  1112. on dialog/pvt destruction. Make sure outbound proxy refs are
  1113. always unreffed on dialog destruction. Review:
  1114. https://reviewboard.asterisk.org/r/4016/ ........ Merged
  1115. revisions 423800 from
  1116. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1117. revisions 423801 from
  1118. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1119. revisions 423802 from
  1120. http://svn.asterisk.org/svn/asterisk/branches/12
  1121. 2014-09-23 14:29 +0000 [r423783] Mark Michelson <mmichelson@digium.com>
  1122. * tests/test_cel.c, tests/test_cdr.c: Make CDR and CEL unit tests
  1123. less FRACKy. Prior to this commit, CDR and CEL tests were
  1124. expected to trigger FRACKs (i.e. assertions) due to the fact that
  1125. the channels they create have no formats on them. Some code was
  1126. independently added recently that attempts to prevent FRACKs from
  1127. occurring by failing early when attempting to set up translation
  1128. paths if one or both channels support no formats. Unfortunately,
  1129. this attempt to be helpful made the CDR and CEL tests go from
  1130. simply FRACKing to outright failing and in some cases, failing so
  1131. badly as to crash Asterisk. This commit seeks to correct past
  1132. mistakes by adding the ulaw format to channels created by the CDR
  1133. and CEL unit tests. This makes setting up translation paths
  1134. succeed, eliminates previously-seen FRACKs, and ultimately causes
  1135. the unit tests to succeed again. Review:
  1136. https://reviewboard.asterisk.org/r/4014
  1137. 2014-09-22 19:48 +0000 [r423660-423723] Walter Doekes <walter+asterisk@wjd.nu>
  1138. * /, channels/chan_sip.c: chan_sip: On INVITE retransmission, don't
  1139. add an extra 503 response. INVITE arrives to asterisk, asterisk
  1140. responds Busy(). If the INVITE is retransmitted, asterisk would
  1141. generate a 503 in addition to the 486. Thanks Torrey Searle for
  1142. providing a working regression test. ASTERISK-24335 #close
  1143. Review: https://reviewboard.asterisk.org/r/4003/ Patches:
  1144. retrans_486_invite.patch uploaded by Torrey Searle (License
  1145. #5334) ........ Merged revisions 423720 from
  1146. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1147. revisions 423721 from
  1148. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1149. revisions 423722 from
  1150. http://svn.asterisk.org/svn/asterisk/branches/12
  1151. * /, main/editline/readline.c: cli.c: Fix tab completion "module
  1152. load" when MALLOC_DEBUG is enabled. r421600 conflicted with
  1153. r155763. ASTERISK-24348 #close ........ Merged revisions 423657
  1154. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  1155. Merged revisions 423658 from
  1156. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1157. revisions 423659 from
  1158. http://svn.asterisk.org/svn/asterisk/branches/12
  1159. 2014-09-21 01:15 +0000 [r423618-423641] Matthew Jordan <mjordan@digium.com>
  1160. * main/channel.c: main/channel: Unlock channel in off-nominal path
  1161. In r423414 (13) / r423415 (trunk), an API call that determines if
  1162. a format capability structure is empty was added. This returns
  1163. true if the format capability structure is completely empty or
  1164. "none". A check for this was added in channel.c's set_format
  1165. call. Unfortunately, when this check was true, it returned from
  1166. the function while still holding the channel lock. This caused
  1167. the CDR unit tests - which have a tendency to create channels
  1168. with no formats - to deadlock. Whoops. This patch unlocks the
  1169. channel on the off-nominal path.
  1170. * rest-api/api-docs/events.json, /: rest-api/api-docs/events.json:
  1171. Remove non-compliant 'extends' attribute Prior to the release of
  1172. Swagger 1.2, the attribute 'extends' was being promoted as a
  1173. possible way to show that a particular object extends an existing
  1174. object. Instead, the Swagger specification went with the
  1175. 'subTypes' attribute in the base object. This patch removes the
  1176. unsupported attribute; the object that the offending objects
  1177. proposed to extend already lists them in its 'subTypes'
  1178. attribute. ASTERISK-24300 #close Reported by: Bradley Watkins
  1179. ........ Merged revisions 423620 from
  1180. http://svn.asterisk.org/svn/asterisk/branches/12
  1181. * rest-api/api-docs/channels.json, rest-api/api-docs/sounds.json,
  1182. rest-api/api-docs/bridges.json,
  1183. rest-api/api-docs/recordings.json,
  1184. rest-api/api-docs/deviceStates.json,
  1185. rest-api/api-docs/endpoints.json,
  1186. rest-api/api-docs/mailboxes.json, rest-api/api-docs/events.json,
  1187. /, rest-api/api-docs/asterisk.json,
  1188. rest-api/api-docs/applications.json,
  1189. rest-api/api-docs/playbacks.json: rest-api/api-docs: Correct
  1190. basePath in resources to match top resources file The
  1191. resources.json file that defines the resource JSON files used
  1192. with ARI references a basePath of 'http://localhost:8088/ari'.
  1193. This does not match what is defined in the resource files
  1194. themselves, 'http://localhost:8088/stasis'. The correct base path
  1195. is the one that includes 'ari' in the URL; this patch updates the
  1196. various resource JSON files to have the correct basePath.
  1197. ASTERISK-24339 #close Reported by: Bradley Watkins ........
  1198. Merged revisions 423617 from
  1199. http://svn.asterisk.org/svn/asterisk/branches/12
  1200. 2014-09-19 19:51 +0000 [r423580] Joshua Colp <jcolp@digium.com>
  1201. * /, res/res_pjsip_notify.c: res_pjsip_notify: Fix crash on
  1202. unload/load and don't say the module doesn't exist on reload.
  1203. When unloading the module did not unregister the CLI commands
  1204. causing a crash upon load when they were registered again. When
  1205. reloading the module the return value from the config options
  1206. framework was not checked to determine if an error occurred or
  1207. not. This caused a message to be output saying the module did not
  1208. exist when reloading if no changes were present. AST-1433 #close
  1209. AST-1434 #close ........ Merged revisions 423579 from
  1210. http://svn.asterisk.org/svn/asterisk/branches/12
  1211. 2014-09-19 17:08 +0000 [r423561] Richard Mudgett <rmudgett@digium.com>
  1212. * channels/chan_pjsip.c, res/res_pjsip_sdp_rtp.c:
  1213. res_pjsip_sdp_rtp.c: Fix native formats containing formats that
  1214. were not negotiated. Outgoing PJSIP calls can result in
  1215. non-negotiated formats listed in the channel's native formats if
  1216. video formats are listed in the endpoint's configuration. The
  1217. resulting call could then use a non-negotiated format resulting
  1218. in one way audio. * Simplified the update of session->req_caps in
  1219. set_caps(). Why do something in five steps when only one is
  1220. needed? AFS-162 #close Review:
  1221. https://reviewboard.asterisk.org/r/4000/
  1222. 2014-09-19 15:18 +0000 [r423524-423530] Jonathan Rose <jrose@digium.com>
  1223. * /, main/stasis_channels.c: Stasis_channels: Resolve unfinished
  1224. Dials when doing masquerades Masquerades into channels that are
  1225. in the dialing state don't end their dial and this goes against
  1226. the model for things like CDRs and generating Dial end manager
  1227. actions and such. ASTERISK-24237 #close Reported by: Richard
  1228. Mudgett Review: https://reviewboard.asterisk.org/r/3990/ ........
  1229. Merged revisions 423525 from
  1230. http://svn.asterisk.org/svn/asterisk/branches/12
  1231. * channels/chan_iax2.c: chan_iax2: Fix a crash when using chan_iax2
  1232. jitterbuffer settings Caused by format changes in Asterisk 13
  1233. ASTERISK-24265 #close Reported by: Dafi Ni Review:
  1234. https://reviewboard.asterisk.org/r/3999/
  1235. 2014-09-19 12:45 +0000 [r423504] Kinsey Moore <kmoore@digium.com>
  1236. * include/asterisk/framehook.h, /, main/framehook.c,
  1237. res/res_pjsip_t38.c: PJSIP: Prevent T38 framehook being put on
  1238. wrong channel This change gives framehooks a reverse-direction
  1239. masquerade callback in addition to chan_fixup_cb similar to the
  1240. callback added to datastores to handle the same situation. The
  1241. new callback provides the same parameters as the fixup callback,
  1242. but is called on the new channel's framehooks before moving
  1243. framehooks from the old channel to the new channel. This gives
  1244. the framehooks an oppurtunity to decide whether they should
  1245. remain on the new channel or be removed. This new callback is
  1246. used to prevent the PJSIP T.38 framehook from remaining on a
  1247. masqueraded channel if the new channel is not also a PJSIP
  1248. channel. This was causing a crash when a local channel was
  1249. masqueraded into a PJSIP channel and the framehook was executed
  1250. on the local channel since the channel's tech private data was
  1251. not structured as expected. Review:
  1252. https://reviewboard.asterisk.org/r/4001/ ........ Merged
  1253. revisions 423503 from
  1254. http://svn.asterisk.org/svn/asterisk/branches/12
  1255. 2014-09-18 19:30 +0000 [r423482] Sean Bright <sean@malleable.com>
  1256. * res/res_pjsip/config_auth.c, /: res_pjsip: Don't require a
  1257. password when doing userpass authentication. An empty password is
  1258. valid for username/password authentication so we should allow
  1259. password to be empty/not supplied. Review:
  1260. https://reviewboard.asterisk.org/r/3988 ........ Merged revisions
  1261. 423481 from http://svn.asterisk.org/svn/asterisk/branches/12
  1262. 2014-09-18 19:22 +0000 [r423478] George Joseph <george.joseph@fairview5.com>
  1263. * tests/test_strings.c, /, main/utils.c,
  1264. include/asterisk/strings.h: utils: Create ast_strsep function
  1265. that ignores separators inside quotes This function acts like
  1266. strsep with three exceptions... * The separator is a single
  1267. character instead of a string. * Separators inside quotes are
  1268. treated literally instead of like separators. * You can elect to
  1269. have leading and trailing whitespace and quotes stripped from the
  1270. result and have '\' sequences unescaped. Like strsep, ast_strsep
  1271. maintains no internal state and you can call it recursively using
  1272. different separators on the same storage. Also like strsep, for
  1273. consistent results, consecutive separators are not collapsed so
  1274. you may get an empty string as a valid result. Tested by: George
  1275. Joseph Review: https://reviewboard.asterisk.org/r/3989/ ........
  1276. Merged revisions 423476 from
  1277. http://svn.asterisk.org/svn/asterisk/branches/12
  1278. 2014-09-18 18:31 +0000 [r423462] Mark Michelson <mmichelson@digium.com>
  1279. * res/res_pjsip_pubsub.c: Add subscription state test events. These
  1280. are needed for a set of batched notification RLS tests that are
  1281. about to be committed to the testsuite. Review:
  1282. https://reviewboard.asterisk.org/r/3967
  1283. 2014-09-18 17:11 +0000 [r423425] Jonathan Rose <jrose@digium.com>
  1284. * res/res_pjsip_endpoint_identifier_ip.c, /:
  1285. res_pjsip_endpoint_identifier_ip: Fix parsing of match value with
  1286. CIDR Also fixes comma separates match lists ASTERISK-24290 #close
  1287. Reported by: Ray Crumrine Review:
  1288. https://reviewboard.asterisk.org/r/3995/ ........ Merged
  1289. revisions 423417 from
  1290. http://svn.asterisk.org/svn/asterisk/branches/12
  1291. 2014-09-18 17:09 +0000 [r423418-423423] Richard Mudgett <rmudgett@digium.com>
  1292. * bridges/bridge_softmix.c: bridge_softmix.c: Made use
  1293. ao2_replace() instead of the inline equivalent. * Clarified some
  1294. read/write format comments. * Fixed a doxygen tag typo.
  1295. * main/astobj2.c, contrib/scripts/refcounter.py, /:
  1296. astobj2.c/refcounter.py: Fix to deal with invalid object refs. *
  1297. Make astob2 REF_DEBUG output an invalid object line when an
  1298. invalid ao2 object ref/unref is attempted. This is similar to the
  1299. constructor/destructor lines. * Fixed refcounter.py to handle
  1300. skewed objects that have constructor/destructor states. * Made
  1301. refcounter.py highlight the invalid ao2 object refs by putting
  1302. them in their own section of the processed output file. * Made
  1303. refcounter.py highlight unreffing an object by more than one that
  1304. results in a negative ref count and the object being destroyed.
  1305. The abnormally destroyed object is reported in the invalid and
  1306. finalized object sections of the output. Review:
  1307. https://reviewboard.asterisk.org/r/3971/ ........ Merged
  1308. revisions 423349 from
  1309. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1310. revisions 423400 from
  1311. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1312. revisions 423416 from
  1313. http://svn.asterisk.org/svn/asterisk/branches/12
  1314. 2014-09-18 16:37 +0000 [r423348-423414] Mark Michelson <mmichelson@digium.com>
  1315. * include/asterisk/format_cap.h, main/channel.c, main/format_cap.c,
  1316. main/translate.c: Add API call to determine if format capability
  1317. structure is "empty". Empty here means that there are no formats
  1318. in the format_cap structure or the only format in it is the
  1319. "none" format. I've added calls to check the emptiness of a
  1320. format_cap in a few places in order to short-circuit operations
  1321. that would otherwise be pointless as well as to prevent some
  1322. assertions from being triggered in cases where channels with no
  1323. formats are used.
  1324. * /, res/res_fax_spandsp.c: res_fax_spandsp: Properly handle
  1325. cleanup before starting FAXes. If faxing fails at a very early
  1326. stage, then it is possible for us to pass a NULL t30 state
  1327. pointer to spandsp, which spandsp is none too pleased with. This
  1328. patch ensures that we pass the correct pointer to spandsp in the
  1329. situation where we have not yet set our local t30 state pointer.
  1330. ASTERISK-24301 #close Reported by Matt Jordan Patches:
  1331. ASTERISK-24301-fax.diff Uploaded by Mark Michelson (License
  1332. #5049) ........ Merged revisions 423360 from
  1333. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1334. revisions 423365 from
  1335. http://svn.asterisk.org/svn/asterisk/branches/12
  1336. * /, res/res_pjsip_mwi.c,
  1337. res/res_pjsip_dialog_info_body_generator.c,
  1338. res/res_pjsip_xpidf_body_generator.c,
  1339. res/res_pjsip_mwi_body_generator.c, res/res_pjsip_pubsub.c,
  1340. res/res_pjsip_exten_state.c, include/asterisk/res_pjsip_pubsub.h,
  1341. res/res_pjsip_pidf_body_generator.c: res_pjsip_pubsub: Add some
  1342. type safety when generating NOTIFY bodies. res_pjsip_pubsub has
  1343. two separate checks that it makes when a SUBSCRIBE arrives. * It
  1344. checks that there is a subscription handler for the Event * It
  1345. checks that there are body generators for the types in the Accept
  1346. header The problem is, there's nothing that ensures that these
  1347. two things will actually mesh with each other. For instance,
  1348. Asterisk will accept a subscription to MWI that accepts pidf+xml
  1349. bodies. That doesn't make sense. With this commit, we add some
  1350. type information to the mix. Subscription handlers state they
  1351. generate data of type X, and body generators state that they
  1352. consume data of type X. This way, Asterisk doesn't end up in some
  1353. hilariously mismatched situation like the one in the previous
  1354. paragraph. ASTERISK-24136 #close Reported by Mark Michelson
  1355. Review: https://reviewboard.asterisk.org/r/3877 Review:
  1356. https://reviewboard.asterisk.org/r/3878 ........ Merged revisions
  1357. 423344 from http://svn.asterisk.org/svn/asterisk/branches/12
  1358. 2014-09-18 15:13 +0000 [r423284] George Joseph <george.joseph@fairview5.com>
  1359. * /, res/res_pjsip/location.c,
  1360. res/res_pjsip_endpoint_identifier_ip.c,
  1361. res/res_pjsip/pjsip_configuration.c,
  1362. res/res_pjsip/pjsip_options.c, res/res_pjsip/config_transport.c,
  1363. include/asterisk/res_pjsip.h, res/res_pjsip/config_auth.c:
  1364. res_pjsip: ami: Fix error in AMI output when an endpoint has no
  1365. transport When no transport is associated to an endpoint, the AMI
  1366. output for PJSIPShowEndpoint indicates an error instead of
  1367. silently ignoring the missing transport. This patch causes the
  1368. error to appear only if a transport was specified on the endpoint
  1369. and the transport doesn't exist. It also fixes an issue with
  1370. counting the objects that were actually found. ASTERISK-24161
  1371. #close ASTERISK-24331 #close Tested by: George Joseph Review:
  1372. https://reviewboard.asterisk.org/r/3998/ ........ Merged
  1373. revisions 423282 from
  1374. http://svn.asterisk.org/svn/asterisk/branches/12
  1375. 2014-09-18 15:00 +0000 [r423281] David M. Lee <dlee@digium.com>
  1376. * makeopts.in, Makefile: Only install dahdi_span_config_hook if
  1377. DAHDI is enabled This patch changes the install to only install
  1378. the hook script if DAHDI is enabled. It also adds the script to
  1379. the uninstall task, and moves the DAHDI_UDEV_HOOK_DIR variable so
  1380. that it's not between the _MAKEOPTS variables and their comment.
  1381. This allows installs which specify a --prefix to work normally,
  1382. as long as they don't enable DAHDI. Review:
  1383. https://reviewboard.asterisk.org/r/3972/
  1384. 2014-09-18 14:45 +0000 [r423279] George Joseph <george.joseph@fairview5.com>
  1385. * main/manager.c, /, include/asterisk/config.h, main/config.c:
  1386. config: bug: Fix SEGV in ast_category_insert when matching
  1387. category isn't found If you call ast_category_insert with a match
  1388. category that doesn't exist, the list traverse runs out of 'next'
  1389. categories and you get a SEGV. This patch adds check for the
  1390. end-of-list condition and changes the signature to return an int
  1391. for success/failure indication instead of a void. The only
  1392. consumer of this function is manager and it was also changed to
  1393. use the return value. Tested by: George Joseph Review:
  1394. https://reviewboard.asterisk.org/r/3993/ ........ Merged
  1395. revisions 423276 from
  1396. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1397. revisions 423277 from
  1398. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1399. revisions 423278 from
  1400. http://svn.asterisk.org/svn/asterisk/branches/12
  1401. 2014-09-17 18:05 +0000 [r423209-423255] Joshua Colp <jcolp@digium.com>
  1402. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Ensure that the
  1403. thread terminating pj stuff is registered. ........ Merged
  1404. revisions 423253 from
  1405. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1406. revisions 423254 from
  1407. http://svn.asterisk.org/svn/asterisk/branches/12
  1408. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fix 100% CPU usage
  1409. due to timer heap thread spinning. Side note: I need a vacation.
  1410. ........ Merged revisions 423210 from
  1411. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1412. revisions 423211 from
  1413. http://svn.asterisk.org/svn/asterisk/branches/12
  1414. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fix building when
  1415. pjproject is not used. ........ Merged revisions 423207 from
  1416. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1417. revisions 423208 from
  1418. http://svn.asterisk.org/svn/asterisk/branches/12
  1419. 2014-09-16 16:32 +0000 [r423192] Scott Griepentrog <sgriepentrog@digium.com>
  1420. * apps/app_voicemail.c, include/asterisk/file.h, main/file.c:
  1421. Voicemail: get correct duration when copying file to vm Changes
  1422. made during format improvements resulted in the recording to
  1423. voicemail option 'm' of the MixMonitor app writing a zero length
  1424. duration in the msgXXXX.txt file. This change introduces a new
  1425. function ast_ratestream(), which provides the sample rate of the
  1426. format associated with the stream, and updates the app_voicemail
  1427. function for ast_app_copy_recording_to_vm to calculate the right
  1428. duration. Review: https://reviewboard.asterisk.org/r/3996/
  1429. ASTERISK-24328 #close
  1430. 2014-09-16 12:12 +0000 [r423152-423173] Joshua Colp <jcolp@digium.com>
  1431. * res/res_pjsip_session.c, /: res_pjsip_session: Fix usage of wrong
  1432. memory pool when creating local SDP. ........ Merged revisions
  1433. 423172 from http://svn.asterisk.org/svn/asterisk/branches/12
  1434. * include/asterisk/rtp_engine.h, res/res_rtp_asterisk.c, /:
  1435. res_rtp_asterisk: Fix a myriad of TURN client issues. 1. The
  1436. number of file descriptors an ioqueue instance can handle is
  1437. fixed, so we now spawn the required number to handle the load. 2.
  1438. Our transport identifiers were exceeding the range supported by
  1439. pjnath. 3. The TURN client did not set up client binding causing
  1440. needless bandwidth usage. 4. The code no longer updates address
  1441. information on each packet. 5. STUN traffic was getting looped
  1442. back to Asterisk instead of going through the TURN server. 6.
  1443. Synchronization now ensures things are completely setup or
  1444. destroyed. 7. Logging now reflects the target the TURN server is
  1445. sending to/receiving from on our behalf. ASTERISK-23577 #close
  1446. Reported by: Jay Jideliov ASTERISK-23634 #close Reported by:
  1447. Roman Skvirsky Review: https://reviewboard.asterisk.org/r/3982/
  1448. ........ Merged revisions 423150 from
  1449. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1450. revisions 423151 from
  1451. http://svn.asterisk.org/svn/asterisk/branches/12
  1452. 2014-09-15 10:49 +0000 [r423069-423129] Walter Doekes <walter+asterisk@wjd.nu>
  1453. * /,
  1454. contrib/ast-db-manage/config/versions/5950038a6ead_fix_pjsip_verifiy_typo.py
  1455. (added): contrib: Fix verifyi typo in alembic DB script
  1456. ps_transport table. Reported by: Zogot (on IRC) Patches: tmp.diff
  1457. uploaded by Zogot, cleaned up by me. ........ Merged revisions
  1458. 423128 from http://svn.asterisk.org/svn/asterisk/branches/12
  1459. * configs/samples/sip.conf.sample, /: chan_sip: Clarify that
  1460. sipdebug=yes cannot be undone by the CLI. Document it in
  1461. sip.conf. ASTERISK-24249 #close Reported by: Avinash Mohod
  1462. Review: https://reviewboard.asterisk.org/r/3926/ ........ Merged
  1463. revisions 423066 from
  1464. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1465. revisions 423067 from
  1466. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1467. revisions 423068 from
  1468. http://svn.asterisk.org/svn/asterisk/branches/12
  1469. 2014-09-12 16:09 +0000 [r422985] Jonathan Rose <jrose@digium.com>
  1470. * main/config.c, /: Realtime: Fix a bug that caused realtime
  1471. destroy command to crash Also has could affect with anything that
  1472. goes through ast_destroy_realtime. If a CLI user used the command
  1473. 'realtime destroy <family>' with only a single column/value pair,
  1474. Asterisk would crash when trying to create a variable list from a
  1475. NULL value. ASTERISK-24231 #close Reported by: Niklas Larsson
  1476. Review: https://reviewboard.asterisk.org/r/3985/ ........ Merged
  1477. revisions 422984 from
  1478. http://svn.asterisk.org/svn/asterisk/branches/12
  1479. 2014-09-11 22:16 +0000 [r422965] Mark Michelson <mmichelson@digium.com>
  1480. * /, main/app.c: Remove undocumented default behavior of
  1481. ast_play_and_record_full acceptdtmf. ast_play_and_record_full()
  1482. has a parameter called "acceptdtmf" that is a string of
  1483. acceptable DTMF digits that may be pressed by a caller to end and
  1484. accept the recording. ARI uses this function in order to perform
  1485. recording, and it provides options for what is passed as
  1486. acceptdtmf to ast_play_and_record_full(). By default, ARI passes
  1487. an empty string, with the intention that no DTMF can be used to
  1488. end the recording. The problem is that ast_play_and_record_full()
  1489. attempts to be "helpful" by setting "#" as the acceptdtmf if an
  1490. empty string or NULL pointer has been passed in. With ARI, this
  1491. results in unexpected behavior occurring if you have attempted to
  1492. intercept "#" yourself in order to perform some other
  1493. manipulation of the live recording. This change removes the
  1494. "helpful" behavior by no longer accepting "#" as a default
  1495. acceptdtmf if none is specified by the caller of
  1496. ast_play_and_record_full(). This makes the ARI scenario work as
  1497. expected. The other callers of ast_play_and_record_full() are
  1498. app_voicemail and app_minivm, and in both cases, they pass an
  1499. explicit "#" to ast_play_and_record_full() as acceptdtmf, so they
  1500. are unaffected by this change. ........ Merged revisions 422964
  1501. from http://svn.asterisk.org/svn/asterisk/branches/12
  1502. 2014-09-10 16:04 +0000 [r422905] George Joseph <george.joseph@fairview5.com>
  1503. * /, main/config.c: config: bug: fix truncation of included config
  1504. files on permissions error ast_config_text_file_save() currently
  1505. truncates include files as they are processed. If a subsequent
  1506. include file or the main config file has a permissions error that
  1507. prevents writing, earlier include files are left truncated
  1508. resulting in a frantic search for backups. This patch causes
  1509. ast_config_text_file_save to check for write access on all files
  1510. before it truncates any of them. Will be applied 1.8 > trunk.
  1511. Tested by: George Joseph Review:
  1512. https://reviewboard.asterisk.org/r/3986/ ........ Merged
  1513. revisions 422900 from
  1514. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1515. revisions 422903 from
  1516. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1517. revisions 422904 from
  1518. http://svn.asterisk.org/svn/asterisk/branches/12
  1519. 2014-09-10 15:59 +0000 [r422901] Sean Bright <sean@malleable.com>
  1520. * res/res_pjsip/config_auth.c, /: pjsip/config_auth.c: Add missing
  1521. whitespace to log messages. The errors generated when validating
  1522. 'auth' settings are missing a space which makes the messages a
  1523. little confusing. ........ Merged revisions 422899 from
  1524. http://svn.asterisk.org/svn/asterisk/branches/12
  1525. 2014-09-09 20:01 +0000 [r422883] Rusty Newton <rnewton@digium.com>
  1526. * /, sounds/sounds.xml, sounds/Makefile: Sounds/BuildSystem:
  1527. Modifications to include new releases and Japanese language.
  1528. Modifying Makefile and sounds.xml to include new core 1.4.26 and
  1529. extra 1.4.15 sound prompt releases, plus the new Japanese core
  1530. sound prompts contributed by QLOOG. ASTERISK-23324 Reported by:
  1531. Kevin McCoy Tested by: Rusty Newton ........ Merged revisions
  1532. 422789 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  1533. ........ Merged revisions 422790 from
  1534. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1535. revisions 422791 from
  1536. http://svn.asterisk.org/svn/asterisk/branches/12
  1537. 2014-09-08 18:03 +0000 [r422851-422855] Mark Michelson <mmichelson@digium.com>
  1538. * configs/samples/pjsip.conf.sample: Add note about configuring
  1539. list_items on a single line.
  1540. * configs/samples/pjsip.conf.sample: Add sample configuration for
  1541. resource lists. On review /r/3977, it was recommended to note in
  1542. the sample configuration about the size limitation for resource
  1543. lists. However, since there was no section in the sample
  1544. configuration at all for resource list subscriptions, I decided
  1545. to make a separate commit where I have added the necessary sample
  1546. configuration as well as the size limitation warning.
  1547. * res/res_pjsip_pubsub.c: Pre-allocate transmission data buffer for
  1548. RLS NOTIFY requests. PJSIP, unless a constant is modified at
  1549. compilation time, limits SIP requests to 4000 bytes. Full-state
  1550. RLS notifications can easily exceed this limit with moderately
  1551. small lists. This changeset allows for Asterisk to work around
  1552. this size limit by performing its own allocation of the
  1553. transmission data buffer. This way, Asterisk can allocate a
  1554. buffer that exceeds the built-in maximum. We still impose our own
  1555. limit of 64000 bytes, mainly because making allocations larger
  1556. than that is a bit absurd. ASTERISK-24181 #close Reported by Mark
  1557. Michelson Review: https://reviewboard.asterisk.org/r/3977
  1558. 2014-09-08 15:41 +0000 [r422836] Jonathan Rose <jrose@digium.com>
  1559. * res/res_pjsip_pubsub.c: res_pjsip_pubsub: Check supported headers
  1560. for eventlist when subscribing to resource list
  1561. https://wiki.asterisk.org/wiki/display/AST/Resource+List+Subscription+Test+Plan
  1562. According to the off-nominal plan, if evenlist support is not
  1563. specified in a SUBSCRIBE's supported header(s), that subscription
  1564. should be rejected with an error. ASTERISK-23871 Reported by:
  1565. Mark Michelson Review:
  1566. https://reviewboard.asterisk.org/r/3960/diff/#index_header
  1567. 2014-09-06 22:49 +0000 [r422767-422770] Matthew Jordan <mjordan@digium.com>
  1568. * /, main/cdr.c: main/cdr: Copy over location information during a
  1569. fork When a CDR is forked, a new CDR is created and appended to
  1570. the CDR chain for the Party A. The forked CDR starts life off as
  1571. a clone of the last non-finalized for the particular Party A. In
  1572. the past, merely copying over the snapshots for Party A/Party B
  1573. would be sufficient. However, as the CDRs now contain cached
  1574. information from Party A - specifically application/data,
  1575. context, and extension - we need to copy that over during a fork
  1576. as well. Huzzah for unit tests catching this when the
  1577. context/extension were derived from a cached value on the CDR
  1578. instead of on Party A. ........ Merged revisions 422769 from
  1579. http://svn.asterisk.org/svn/asterisk/branches/12
  1580. * main/rtp_engine.c, /: main/rtp_engine: Format NTP timestamps as
  1581. unsigned ints On some systems, a timeval's tv_sec/tv_usec will be
  1582. unsigned lont ints, as opposed to long ints. When the RTP engine
  1583. formats these as strings, it was previously formatting them as
  1584. signed integers, which can result in some odd negative timestamp
  1585. values (particularly on 32-bit systems). This patch formats the
  1586. values as unsigned long integers. ........ Merged revisions
  1587. 422766 from http://svn.asterisk.org/svn/asterisk/branches/12
  1588. 2014-09-06 19:12 +0000 [r422747] Joshua Colp <jcolp@digium.com>
  1589. * res/res_pjsip_sdp_rtp.c, /: res_pjsip_sdp_rtp: Fix retrieval of
  1590. "ice-pwd" attribute if in session and not media stream. ........
  1591. Merged revisions 422746 from
  1592. http://svn.asterisk.org/svn/asterisk/branches/12
  1593. 2014-09-05 22:03 +0000 [r422716-422719] Matthew Jordan <mjordan@digium.com>
  1594. * main/cdr.c, /, apps/app_macro.c, include/asterisk/channel.h,
  1595. apps/app_stack.c: main/cdrs: Preserve context/extension when
  1596. executing a Macro or GoSub The context/extension in a CDR is
  1597. generally considered the destination of a call. When looking at a
  1598. 2-party call CDR, users will typically be presented with the
  1599. following: context exten channel dest_channel app data default
  1600. 1000 SIP/8675309 SIP/1000 Dial SIP/1000,,20 However, if the Dial
  1601. actually takes place in a Macro, the current behaviour in 12 will
  1602. result in the following CDR: context exten channel dest_channel
  1603. app data macro-dial s SIP/8675309 SIP/1000 Dial SIP/1000,,20 The
  1604. same is true of a GoSub: context exten channel dest_channel app
  1605. data subs dial_stuff SIP/8675309 SIP/1000 Dial SIP/1000,,20 This
  1606. generally makes the context/exten fields less than useful. It
  1607. isn't hard to preserve these values in the CDR state machine;
  1608. however, we need to have something that informs us when a channel
  1609. is executing a subroutine. Prior to this patch, there isn't
  1610. anything that does this. This patch solves this problem by adding
  1611. a new channel flag, AST_FLAG_SUBROUTINE_EXEC. This flag is set on
  1612. a channel when it executes a Macro or a GoSub. The CDR engine
  1613. looks for this value when updating a Party A snapshot; if the
  1614. flag is present, we don't override the context/exten on the main
  1615. CDR object. In a funny quirk, executing a hangup handler must
  1616. *not* abide by this logic, as the endbeforehexten logic assumes
  1617. that the user wants to see data that occurs in hangup logic,
  1618. which includes those subroutines. Since those execute outside of
  1619. a typical Dial operation (and will typically have their own
  1620. dedicated CDR anyway), this is unlikely to cause any heartburn.
  1621. Review: https://reviewboard.asterisk.org/r/3962/ ASTERISK-24254
  1622. #close Reported by: tm1000, Tony Lewis Tested by: Tony Lewis
  1623. ........ Merged revisions 422718 from
  1624. http://svn.asterisk.org/svn/asterisk/branches/12
  1625. * main/cdr.c, /: main/cdr: Fix crash/memory consumption in CDRs in
  1626. multi-party bridge scenarios This patch fixes an issue where CDRs
  1627. would get stuck generating an infinite number of CDRs, eventually
  1628. crashing Asterisk (and consuming a lot of memory along the way).
  1629. When a channel enters into a multi-party bridge, the CDR engine
  1630. creates mappings of each participant to each other participant,
  1631. picking the 'A' party as it goes. So, if we have four channels in
  1632. a multi-party bridge (Alice, Bob, Charlie, Denise), we would have
  1633. something like: Alice => Bob Alice => Charlie Alice => Denise Bob
  1634. => Charlie Bob => Denise Charlie => Denise This works fine when
  1635. participants enter the bridge a single time. When a participant
  1636. leaves a bridge, the CDRs for that channel are transitioned to a
  1637. finalized state. The bug occurs if Bob rejoins. When the CDR
  1638. engine creates mappings between the channels, it walks through
  1639. all the participants currently in the bridge, and realizes that
  1640. no one in the bridge can create a CDR with the channel (Bob). As
  1641. such it creates a new CDR for the candidate and appends it to
  1642. that candidate's chain. Unfortunately, on this particular code
  1643. path, it doesn't stop traversing the candidate's chain. Since we
  1644. just added ourselves to the chain, this causes the loop to keep
  1645. going, constantly adding new CDRs. This patch makes it so the
  1646. engine bails when it creates a CDR match in this case. Review:
  1647. https://reviewboard.asterisk.org/r/3964/ ASTERISK-24241 #close
  1648. Reported by: Deepak Singh Rawat Tested by: Deepak Singh Rawat
  1649. ASTERISK-24208 Reported by: Frankie Chin ........ Merged
  1650. revisions 422715 from
  1651. http://svn.asterisk.org/svn/asterisk/branches/12
  1652. 2014-09-05 20:35 +0000 [r422700] Richard Mudgett <rmudgett@digium.com>
  1653. * funcs/func_channel.c: func_channel.c: Add missing locking to some
  1654. CHANNEL() requests. * The CHANNEL() audionativeformat,
  1655. videonativeformat, audioreadformat, and audiowriteformat now need
  1656. locking since the media format rework when accessing the
  1657. channel's format pointers. * Increased the buffer size for
  1658. CHANNEL() audionativeformat and videonativeformat output strings
  1659. since the allow=all can be a lengthy list. * Tweaked the
  1660. CHANNEL() XML documentation for secure_bridge_signaling,
  1661. secure_bridge_media, and state. * Ensured the output buffer is
  1662. initialized for secure_bridge_signaling and secure_bridge_media.
  1663. * Made use the locked_copy_string() macro instead of inlining it
  1664. for trace and checkhangup.
  1665. 2014-09-05 20:11 +0000 [r422665-422684] Jonathan Rose <jrose@digium.com>
  1666. * main/dial.c, include/asterisk/dial.h: Dial API: Add a dial option
  1667. to indicate the dialed channel will replace dialer Adds an option
  1668. to the dial API that marks an outgoing dial as replacing the
  1669. dialing channel for the purpose of propagating accountcode. When
  1670. it is used, AST_CHANNEL_REQUESTOR_REPLACEMENT is used instead of
  1671. AST_CHANNEL_REQUESTOR_BRIDGE_PEER when setting accountcodes on
  1672. the involved channels with ast_channel_req_accountcodes. Review:
  1673. https://reviewboard.asterisk.org/r/3968/
  1674. * main/cli.c, /: Call IDs: Fix appearance of call ID in core show
  1675. channels when NULL NULL call IDs were meant to appear as '(none)'
  1676. but instead were showing the contents of an uninitialized
  1677. character buffer. ASTERISK-24223 Review:
  1678. https://reviewboard.asterisk.org/r/3979/ ........ Merged
  1679. revisions 422664 from
  1680. http://svn.asterisk.org/svn/asterisk/branches/12
  1681. 2014-09-05 17:36 +0000 [r422661] Richard Mudgett <rmudgett@digium.com>
  1682. * main/devicestate.c, channels/chan_iax2.c: devicestate.c: Minor
  1683. tweaks * In ast_state_chan2dev() use ARRAY_LEN() instead of a
  1684. sentinel value in chan2dev[]. * Fix some comments in chan_iax2.c.
  1685. 2014-09-05 13:28 +0000 [r422646] Kinsey Moore <kmoore@digium.com>
  1686. * menuselect/menuselect.c: Menuselect: Fix incorrect enabling on
  1687. failed deps This corrects a situation where menuselect can
  1688. incorrectly enable a module by default that has defaultenabled
  1689. set to "no" and has failed/non-selected dependencies. The bug is
  1690. due to an inverted test when checking for whether the given
  1691. module should be set to enabled by default on load. Review:
  1692. https://reviewboard.asterisk.org/r/3975/ Reported by: John
  1693. Bigelow
  1694. 2014-09-04 21:23 +0000 [r422631] Jonathan Rose <jrose@digium.com>
  1695. * main/manager.c, /: Manager: Require read permission for SYSTEM in
  1696. order to send FullyBooted Review:
  1697. https://reviewboard.asterisk.org/r/3969/ ........ Merged
  1698. revisions 422584 from
  1699. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1700. revisions 422625 from
  1701. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1702. revisions 422626 from
  1703. http://svn.asterisk.org/svn/asterisk/branches/12
  1704. 2014-09-03 14:05 +0000 [r422558] Joshua Colp <jcolp@digium.com>
  1705. * res/res_pjsip_transport_websocket.c, /:
  1706. res_pjsip_transport_websocket: Fix crash when the Contact header
  1707. is not a URI. The code for changing the Contact header wrongly
  1708. assumed that the Contact would always contain a URI. This is
  1709. incorrect. ASTERISK-24271 Reported by: Dafi Ni ........ Merged
  1710. revisions 422557 from
  1711. http://svn.asterisk.org/svn/asterisk/branches/12
  1712. 2014-09-02 20:29 +0000 [r422542] Mark Michelson <mmichelson@digium.com>
  1713. * /, channels/chan_pjsip.c, res/res_pjsip_diversion.c,
  1714. res/res_pjsip_session.c, include/asterisk/res_pjsip_session.h:
  1715. Resolve race condition where channels enter dialplan application
  1716. before media has been negotiated. Testsuite tests will
  1717. occasionally fail because on reception of a 200 OK SIP response,
  1718. an AST_CONTROL_ANSWER frame is queued prior to when media has
  1719. finished being negotiated. This is because session supplements
  1720. are called into before PJSIP's inv_session code has told us that
  1721. media has been updated. Sometimes the queued answer frame is
  1722. handled by the PBX thread before the ensuing media negotiations
  1723. occur, causing a test failure. As it turns out, there is another
  1724. place that session supplements could be called into, which is
  1725. after media has finished getting negotiated. What this commit
  1726. introduces is a means for session supplements to indicate when
  1727. they wish to be called into when handling an incoming SIP
  1728. response. By default, all session supplements will be run at the
  1729. same point that they were prior to this commit. However, session
  1730. supplements may indicate that they wish to be handled earlier
  1731. than normal on redirects, or they may indicate they wish to be
  1732. handled after media has been negotiated. In this changeset, two
  1733. session supplements have been updated to indicate a preference
  1734. for when they should be run: res_pjsip_diversion executes before
  1735. handling redirection in order to get information from the
  1736. Diversion header, and chan_pjsip now handles responses to INVITEs
  1737. after media negotiation to fix the race condition mentioned
  1738. previously. ASTERISK-24212 #close Reported by Matt Jordan Review:
  1739. https://reviewboard.asterisk.org/r/3930 ........ Merged revisions
  1740. 422536 from http://svn.asterisk.org/svn/asterisk/branches/12
  1741. 2014-09-01 14:16 +0000 [r422504-422507] Matthew Jordan <mjordan@digium.com>
  1742. * main/cli.c, /: main/cli: Do not attempt to show CDR data for
  1743. internal channels Internal channels don't have CDRs. Querying the
  1744. CDR engine for their variables will make it cranky. ........
  1745. Merged revisions 422506 from
  1746. http://svn.asterisk.org/svn/asterisk/branches/12
  1747. * res/res_stasis.c, /, res/stasis/stasis_bridge.c: res_stasis:
  1748. Don't play MoH to channels by default when added to holding
  1749. bridges When ARI manipulates a bridge, it generally doesn't care
  1750. what the mixing technology is. Operations on a bridge initiated
  1751. through ARI should perform their action in generally the same
  1752. way, regardless of the bridge's mixing technology. While the
  1753. mixing technology may determine how media flows to channels, the
  1754. actual operations on a bridge themselves should be the same.
  1755. Currently, this isn't the case with holding bridges. When a
  1756. channel joins without a role, MoH is started on that channel
  1757. automatically. Subsequent bridge operations that would stop MoH
  1758. would fail (as there is no Announcer channel playing MoH to the
  1759. bridge). Starting MoH on the bridge will also create two MoH
  1760. streams: one from the MoH being played on the participant
  1761. channel, and one from the announcer channel. From the perspective
  1762. of ARI users, this is counter-intuitive - I would not expect MoH
  1763. to be started for me. The mixing technology determines how media
  1764. is shared between participants, not the application experience.
  1765. This patch does the following: * The Stasis bridge class now
  1766. inspects channels as they are going into a bridge. If the bridge
  1767. has a holding capability, and the channel has no roles, we give
  1768. it a participant role and mark the default behaviour to have no
  1769. entertainment. This allows addChannel operations to continue to
  1770. set a participant role with an entertainment option if it felt
  1771. like it (or could do it). * The music on hold channel is now
  1772. Stasis approved (tm) Review:
  1773. https://reviewboard.asterisk.org/r/3929/ ASTERISK-24264 #close
  1774. Reported by: Samuel Galarneau Tested by: Samuel Galarneau
  1775. ........ Merged revisions 422503 from
  1776. http://svn.asterisk.org/svn/asterisk/branches/12
  1777. 2014-08-30 17:32 +0000 [r422442-422445] George Joseph <george.joseph@fairview5.com>
  1778. * apps/app_confbridge.c, /: confbridge: Add Duration to
  1779. ConfbridgeList event The ConfbridgeList event doesn't include how
  1780. long the user has been a member of the conference. This patch
  1781. adds Duration (seconds) which is based on user->chan->answertime.
  1782. Tested by: George Joseph Review:
  1783. https://reviewboard.asterisk.org/r/3955/ ........ Merged
  1784. revisions 422444 from
  1785. http://svn.asterisk.org/svn/asterisk/branches/12
  1786. * main/manager.c, /: manager: Make WaitEvent action respect
  1787. eventfilters A WaitEvent issued via an http session isn't
  1788. respecting eventfilters defined for the user. I just added a
  1789. match_filter to the predicate that controls astman_append. Tested
  1790. by: George Joseph Review:
  1791. https://reviewboard.asterisk.org/r/3958/ ........ Merged
  1792. revisions 422439 from
  1793. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1794. revisions 422440 from
  1795. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1796. revisions 422441 from
  1797. http://svn.asterisk.org/svn/asterisk/branches/12
  1798. 2014-08-29 19:40 +0000 [r422374-422379] Matthew Jordan <mjordan@digium.com>
  1799. * doc/smsq.8 (added), /: doc: Add a manpage for the smsq utility
  1800. This patch adds a manpage for the smsq utility. Note that this is
  1801. one of the patches the Debian distro applies for the Asterisk
  1802. project, as per ASTERISK-24191. Review:
  1803. https://reviewboard.asterisk.org/r/3895/ ASTERISK-24171 #close
  1804. Reported by: Jeremy Laine patches: smsq.8 uploaded by Jeremy
  1805. Laine (License 6561) ........ Merged revisions 422376 from
  1806. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1807. revisions 422377 from
  1808. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1809. revisions 422378 from
  1810. http://svn.asterisk.org/svn/asterisk/branches/12
  1811. * doc/aelparse.8 (added), /: doc: Add a manpage for the aelparse
  1812. utility This patch adds a manpage for the aelparse utility. Note
  1813. that this is one of the patches the Debian distro applies for the
  1814. Asterisk project, as per ASTERISK-24191. Review:
  1815. https://reviewboard.asterisk.org/r/3896/ ASTERISK-24171 #close
  1816. Reported by: Jeremy Laine patches: aelparse.8 uploaded by Jeremy
  1817. Laine (License 6561) ........ Merged revisions 422371 from
  1818. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1819. revisions 422372 from
  1820. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1821. revisions 422373 from
  1822. http://svn.asterisk.org/svn/asterisk/branches/12
  1823. 2014-08-29 19:05 +0000 [r422359] Scott Griepentrog <sgriepentrog@digium.com>
  1824. * channels/chan_sip.c: The assertion that peer was not found on
  1825. final event message was being triggered on configuration reload.
  1826. This patch changes that case to just return instead. Review:
  1827. https://reviewboard.asterisk.org/r/3953/ Commited in trunk
  1828. revision 422358
  1829. 2014-08-28 21:54 +0000 [r422296] Matthew Jordan <mjordan@digium.com>
  1830. * LICENSE, /: LICENSE: Clarify language in Asterisk's LICENSE to
  1831. allow for linking to UniMRCP The UniMRCP project distributes
  1832. Asterisk modules that integrate Asterisk with UniMRCP, and other
  1833. Asterisk users use the UniMRCP library as well. Unfortunately,
  1834. the UniMRCP license is Apache 2.0, which per the Free Software
  1835. Foundation, is not a compatible license with the GPLv2. "Please
  1836. note that this license is not compatible with GPL version 2,
  1837. because it has some requirements that are not in that GPL
  1838. version. These include certain patent termination and
  1839. indemnification provisions. The patent termination provision is a
  1840. good thing, which is why we recommend the Apache 2.0 license for
  1841. substantial programs over other lax permissive licenses." On the
  1842. other hand, UniMRCP is a great project and we'd like to let
  1843. people use it with Asterisk. This patch updates the LICENSE text
  1844. to allow users to link Asterisk with UniMRCP and distribute the
  1845. resulting binaries. ........ Merged revisions 422293 from
  1846. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1847. revisions 422294 from
  1848. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1849. revisions 422295 from
  1850. http://svn.asterisk.org/svn/asterisk/branches/12
  1851. 2014-08-28 20:30 +0000 [r422276] Michael L. Young <elgueromexicano@gmail.com>
  1852. * /, channels/chan_iax2.c: chan_iax2: Fix Dynamic IAX2
  1853. Registrations After Temporary DNS Failure The reporter on the
  1854. issue found some issues when upgrading from version 10 to 11 on
  1855. 55 hosts. Two situations that can occur with dynamic
  1856. registrations. 1. With dnsmgr disabled, if the host is not
  1857. resolvable we are not trying to resolve the host again when it is
  1858. time to attempt to register again. This results in never
  1859. registering to the host. 2. With dnsmgr enabled, when the host is
  1860. temporarily not resolvable the address is set to 0.0.0.0:0 and
  1861. then when the host is resolvable the port is not being restored
  1862. and stays set to 0. This patch resolves these two issues by: *
  1863. Storing the hostname so that it can be used for resolving with
  1864. DNS. * Resolve the hostname on the next scheduled attempt to
  1865. register. * Storing the port used to reach the host so that when
  1866. the hostname is resolvable again, we can set the port again if
  1867. the port is still unset after looking up the host. ASTERISK-23767
  1868. #close Reported by: David Herselman Tested by: David Herselman,
  1869. Michael L. Young Patches:
  1870. asterisk-23767-dns_reg_retry_and_set_port_11_v3.diff uploaded by
  1871. Michael L. Young (license 5026) Review:
  1872. https://reviewboard.asterisk.org/r/3856/ ........ Merged
  1873. revisions 422274 from
  1874. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1875. revisions 422275 from
  1876. http://svn.asterisk.org/svn/asterisk/branches/12
  1877. 2014-08-28 17:25 +0000 [r422256] Richard Mudgett <rmudgett@digium.com>
  1878. * /, UPGRADE.txt: Added ConfBridge AMI event note to UPGRADE.txt.
  1879. ........ Merged revisions 422255 from
  1880. http://svn.asterisk.org/svn/asterisk/branches/12
  1881. 2014-08-28 15:49 +0000 [r422239] Mark Michelson <mmichelson@digium.com>
  1882. * res/res_pjsip_pubsub.c: Fix bug that did not allow for multiple
  1883. batched RLS notifications to be sent. A misunderstanding of how
  1884. the scheduler worked caused further batched notifications beyond
  1885. the first not to get scheduled. Now we reset our scheduler ID to
  1886. -1 after the batched notification is sent. This way, further
  1887. notifications can be scheduled when they arise.
  1888. 2014-08-28 00:36 +0000 [r422200-422215] Richard Mudgett <rmudgett@digium.com>
  1889. * res/res_pjsip/pjsip_options.c, /: res/res_pjsip/pjsip_options.c:
  1890. Eliminate excessive RAII_VAR usage. * Fix off nominal ref leak in
  1891. find_or_create_contact_status(). * Add missing NULL check of
  1892. status in update_contact_status() and init_start_time(). ........
  1893. Merged revisions 422214 from
  1894. http://svn.asterisk.org/svn/asterisk/branches/12
  1895. * main/sched.c, include/asterisk/sched.h: sched: Fix typo and
  1896. whitespace change.
  1897. 2014-08-27 17:29 +0000 [r422177] George Joseph <george.joseph@fairview5.com>
  1898. * /, apps/confbridge/confbridge_manager.c, apps/app_confbridge.c:
  1899. confbridge: Add 'Admin' param to join, leave, mute, unmute and
  1900. talking events Currently there's no way to tell if a user is an
  1901. admin or not when receiving the join, leave, mute, unmute and
  1902. talking events. This patch adds that capability. Tested by:
  1903. George Joseph Review: https://reviewboard.asterisk.org/r/3950/
  1904. ........ Merged revisions 422176 from
  1905. http://svn.asterisk.org/svn/asterisk/branches/12
  1906. 2014-08-27 15:31 +0000 [r422154] Kinsey Moore <kmoore@digium.com>
  1907. * include/asterisk/utils.h, /, channels/chan_sip.c,
  1908. tests/test_callerid.c (added), tests/test_utils.c,
  1909. main/callerid.c, main/utils.c, res/res_pjsip_caller_id.c:
  1910. CallerID: Fix parsing of malformed callerid This allows the
  1911. callerid parsing function to handle malformed input strings and
  1912. strings containing escaped and unescaped double quotes. This also
  1913. adds a unittest to cover many of the cases where the parsing
  1914. algorithm previously failed. Review:
  1915. https://reviewboard.asterisk.org/r/3923/ Review:
  1916. https://reviewboard.asterisk.org/r/3933/ ........ Merged
  1917. revisions 422112 from
  1918. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1919. revisions 422113 from
  1920. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1921. revisions 422114 from
  1922. http://svn.asterisk.org/svn/asterisk/branches/12
  1923. 2014-08-26 23:28 +0000 [r422091] George Joseph <george.joseph@fairview5.com>
  1924. * apps/app_confbridge.c, /: confbridge: Make kick, mute and unmute
  1925. handle channel targets consistently. Kick, mute and unmute were a
  1926. little inconsistent in their handling of channel targets. This
  1927. patch cleans that up by insuring they all handle the 'all' target
  1928. consistently and adds the 'participants' target which acts on
  1929. non-admins. Documentation for kick was also cleaned up as it
  1930. never supported partial channel names. Tested by: George Joseph
  1931. Review: https://reviewboard.asterisk.org/r/3944/ ........ Merged
  1932. revisions 422090 from
  1933. http://svn.asterisk.org/svn/asterisk/branches/12
  1934. 2014-08-26 22:13 +0000 [r422071] Mark Michelson <mmichelson@digium.com>
  1935. * main/sched.c, /: Fix race condition in the scheduler when
  1936. deleting a running entry. When scheduled tasks run, they are
  1937. removed from the heap (or hashtab). When a scheduled task is
  1938. deleted, if the task can't be found in the heap (or hashtab), an
  1939. assertion is triggered. If DO_CRASH is enabled, this assertion
  1940. causes a crash. The problem is, sometimes it just so happens that
  1941. someone attempts to delete a scheduled task at the time that it
  1942. is running, leading to a crash. This change corrects the issue by
  1943. tracking which task is currently running. If that task is
  1944. attempted to be deleted, then we mark the task, and then wait for
  1945. the task to complete. This way, we can be sure to coordinate task
  1946. deletion and memory freeing. ASTERISK-24212 Reported by Matt
  1947. Jordan Review: https://reviewboard.asterisk.org/r/3927 ........
  1948. Merged revisions 422070 from
  1949. http://svn.asterisk.org/svn/asterisk/branches/12
  1950. 2014-08-25 16:44 +0000 [r421979-422037] Richard Mudgett <rmudgett@digium.com>
  1951. * res/res_musiconhold.c: res_musiconhold.c: Release any format refs
  1952. before memset(). * Clear the channel music_state pointer before
  1953. destroying the music_state object for safety.
  1954. * res/res_musiconhold.c, /: res_musiconhold: Fix MOH restarting
  1955. where it left off from the last hold. Restore code removed by
  1956. https://reviewboard.asterisk.org/r/3536/ that introduced a
  1957. regression that prevents MOH from restarting were it left off the
  1958. last time. ASTERISK-24019 #close Reported by: Jason Richards
  1959. Patches: jira_asterisk_24019_v1.8.patch (license #5621) patch
  1960. uploaded by rmudgett Review:
  1961. https://reviewboard.asterisk.org/r/3928/ ........ Merged
  1962. revisions 421976 from
  1963. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  1964. revisions 421977 from
  1965. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  1966. revisions 421978 from
  1967. http://svn.asterisk.org/svn/asterisk/branches/12
  1968. 2014-08-24 19:36 +0000 [r421911-421956] Joshua Colp <jcolp@digium.com>
  1969. * res/res_pjsip_transport_websocket.c, /:
  1970. res_pjsip_transport_websocket: Attach the Websocket module on
  1971. outgoing INVITEs. In order to alter the Contact header on
  1972. in-dialog requests and responses the Websocket module must be
  1973. attached on outgoing INVITEs. The Contact header is modified so
  1974. that the PJSIP transport layer can find and use the existing
  1975. Websocket connection based on the source IP address, port, and
  1976. transport. ASTERISK-24143 #close Reported by: Aleksei Kulakov
  1977. ........ Merged revisions 421955 from
  1978. http://svn.asterisk.org/svn/asterisk/branches/12
  1979. * /, res/res_pjsip_transport_websocket.c:
  1980. res_pjsip_transport_websocket: Fix a progressive memory growth.
  1981. The packet structure used to receive messages was using the
  1982. transport pool. This meant that for each parsing the pool would
  1983. grow accordingly. Since memory can not be reclaimed without
  1984. resetting it this would cause the memory pool to grow and grow.
  1985. This change uses a specific memory pool for the packet structure
  1986. and resets it to a fresh state after the message has been
  1987. received and handled. ........ Merged revisions 421939 from
  1988. http://svn.asterisk.org/svn/asterisk/branches/12
  1989. * /, res/res_pjsip_transport_websocket.c:
  1990. res_pjsip_transport_websocket: Ensure secure Websocket clients
  1991. can be called. This change enforces the transport in the Contact
  1992. header for Websocket clients. Previously a client may provide a
  1993. transport of 'ws' when it is actually using a transport of 'wss'.
  1994. This would cause outgoing calls to fail as the existing
  1995. connection could not be found. ........ Merged revisions 421931
  1996. from http://svn.asterisk.org/svn/asterisk/branches/12
  1997. * /, channels/chan_sip.c: chan_sip: Use the server reflexive ICE
  1998. candidate RTCP port as provided. This code originally worked
  1999. around an issue within res_rtp_asterisk itself. The wrong socket
  2000. was being used for the STUN check for RTCP, causing the port to
  2001. be the same as RTP. This was subsequently fixed and the RTCP port
  2002. provided for the ICE candidate is correct and does not need to be
  2003. incremented. ASTERISK-23997 #close Reported by: Badalian
  2004. Vyacheslav Patches: plus1.diff submitted by Badalian Vyacheslav
  2005. (license 5249) ........ Merged revisions 421909 from
  2006. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2007. revisions 421910 from
  2008. http://svn.asterisk.org/svn/asterisk/branches/12
  2009. 2014-08-22 16:56 +0000 [r421882] Mark Michelson <mmichelson@digium.com>
  2010. * apps/app_mixmonitor.c: Fix a locking inversion in MixMonitor. We
  2011. need to unlock the audiohook before trying to lock the channel,
  2012. since the correct locking order is channel then audiohook.
  2013. 2014-08-22 16:44 +0000 [r421880] Jonathan Rose <jrose@digium.com>
  2014. * res/res_stasis_answer.c, res/res_stasis.c, res/stasis/command.c,
  2015. res/res_stasis_playback.c, /, res/stasis/control.c,
  2016. res/stasis/stasis_bridge.c, res/stasis/command.h,
  2017. include/asterisk/stasis_app_impl.h, res/res_stasis_recording.c:
  2018. ARI: Fix a crash caused by hanging during playback to a channel
  2019. in a bridge ASTERISK-24147 #close Reported by: Edvin Vidmar
  2020. Review: https://reviewboard.asterisk.org/r/3908/ ........ Merged
  2021. revisions 421879 from
  2022. http://svn.asterisk.org/svn/asterisk/branches/12
  2023. 2014-08-22 14:08 +0000 [r421860] Matthew Jordan <mjordan@digium.com>
  2024. * main/message.c, /: main/message: Add a new-line to a DEBUG
  2025. message ........ Merged revisions 421859 from
  2026. http://svn.asterisk.org/svn/asterisk/branches/12
  2027. 2014-08-21 22:07 +0000 [r421802] Richard Mudgett <rmudgett@digium.com>
  2028. * /, res/res_musiconhold.c: res_musiconhold.c: Remove obsolete
  2029. REF_DEBUG code. Remove unneeded code that writes to the wrong
  2030. file location in an obsolete format. ........ Merged revisions
  2031. 421799 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  2032. ........ Merged revisions 421800 from
  2033. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2034. revisions 421801 from
  2035. http://svn.asterisk.org/svn/asterisk/branches/12
  2036. 2014-08-21 21:42 +0000 [r421790-421797] Mark Michelson <mmichelson@digium.com>
  2037. * res/res_pjsip_session.c, /: Switch from hostname to an IP address
  2038. in the SDP origin line. Using the hostname in the SDP origin line
  2039. may not satisfy the requirement of RFC 4566 that we use a FQDN or
  2040. IP address. This change has us use the same information from the
  2041. SDP connection line if possible. If not possible, we'll use the
  2042. configured media address. And if that's not possible, we use the
  2043. result of a PJLIB call to get the IP address of ourself.
  2044. ASTERISK-23994 #close Reported by Private Name Review:
  2045. https://reviewboard.asterisk.org/r/3925 ........ Merged revisions
  2046. 421796 from http://svn.asterisk.org/svn/asterisk/branches/12
  2047. * /, res/stasis/control.c: Ensure after-bridge behavior is correct
  2048. when moving from Stasis to a non-Stasis bridge. Because of the
  2049. departable state of channels that enter Stasis bridges, Stasis
  2050. has to take responsibility for directing the channel to its
  2051. intended after-bridge destination if the channel moves from a
  2052. Stasis bridge to a non-Stasis bridge. This change ensures that
  2053. when such a move occurs, when the channel leaves the bridging
  2054. system, any after bridge gotos are honored. Review:
  2055. https://reviewboard.asterisk.org/r/3920 ........ Merged revisions
  2056. 421792 from http://svn.asterisk.org/svn/asterisk/branches/12
  2057. * res/res_pjsip_caller_id.c, /: Let's try checking the name and
  2058. number, instead of the name twice. ........ Merged revisions
  2059. 421789 from http://svn.asterisk.org/svn/asterisk/branches/12
  2060. 2014-08-21 21:25 +0000 [r421788] Jonathan Rose <jrose@digium.com>
  2061. * /, res/res_musiconhold.c: res_musiconhold: Fix reference leaks
  2062. caused when reloading with REF_DEBUG set Due to a faulty function
  2063. for debugging reference decrementing, it was possible to reduce
  2064. the refcount on the wrong object if two moh classes of the same
  2065. name were in the moh class container. (closes issue
  2066. ASTERISK-22252) Reported by: Walter Doekes Patches:
  2067. 18_moh_debug_ref_patch.diff Uploaded by Jonathan Rose (license
  2068. 6182) ........ Merged revisions 398937 from
  2069. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2070. revisions 421777 from
  2071. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2072. revisions 421779 from
  2073. http://svn.asterisk.org/svn/asterisk/branches/12
  2074. 2014-08-21 21:18 +0000 [r421783] Mark Michelson <mmichelson@digium.com>
  2075. * /, res/res_pjsip_caller_id.c: Improve consistency of party ID
  2076. privacy usage. Prior to this change, the Remote-Party-ID header
  2077. took the position of "If caller name and number are not
  2078. explicitly allowed, then they are private" and
  2079. P-Asserted-Identity took the position of "Caller name and number
  2080. are only private if marked explicitly so" Now both mechanisms of
  2081. conveying party identification use the former approach. ........
  2082. Merged revisions 421778 from
  2083. http://svn.asterisk.org/svn/asterisk/branches/12
  2084. 2014-08-21 17:34 +0000 [r421675-421720] Matthew Jordan <mjordan@digium.com>
  2085. * /, channels/chan_sip.c: chan_sip: Don't use port derived from
  2086. fromdomain if it isn't set If a user does not provide a port in
  2087. the fromdomain setting, chan_sip will set the fromdomainport to
  2088. STANDARD_SIP_PORT (5060). The fromdomainport value will then get
  2089. used unilaterally in certain places. This causes issues with TLS,
  2090. where the default port is expected to be 5061. This patch
  2091. modifies chan_sip such that fromdomainport is only used if it is
  2092. not the standard SIP port; otherwise, the port from the SIP pvt's
  2093. recorded self IP address is used. Review:
  2094. https://reviewboard.asterisk.org/r/3893/ ASTERISK-24178 #close
  2095. Reported by: Elazar Broad patches: fromdomainport_fix.diff
  2096. uploaded by Elazar Broad (License 5835) ........ Merged revisions
  2097. 421717 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  2098. ........ Merged revisions 421718 from
  2099. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2100. revisions 421719 from
  2101. http://svn.asterisk.org/svn/asterisk/branches/12
  2102. * /, UPGRADE.txt, main/app.c: ARI: Fix implicit answer when
  2103. playback is initiated on unanswered channel When issuing a POST
  2104. /channels/{channel_id}/play on a channel that is not yet
  2105. answered, ARI is supposed to: * Queue up an AST_CONTROL_PROGRESS
  2106. on the channel * Start up the playback of the media Instead, we
  2107. sneak an answer on the channel right before starting playing
  2108. media. This is due to ARI's usage of control_streamfile. This
  2109. function implicitly answers the channel (and doesn't give ARI the
  2110. option to stop it). The answering of the channel here is probably
  2111. unnecessary: * app_voicemail, by far the biggest consumer of this
  2112. function, always answers the channels anyway * control stream
  2113. file (in res_agi) and ControlPlayback probably shouldn't be
  2114. implicitly answering the channel. Answering should not be tied
  2115. directly to playing back media. As it turns out, the answering of
  2116. the channel here is pretty old: 356042 twilson if
  2117. (ast_channel_state(chan) != AST_STATE_UP) { 3087 anthm res =
  2118. ast_answer(chan); 180259 tilghman } (As in, ancient?) Note that
  2119. others ran into this problem and commented about it on various
  2120. mailing lists. Review: https://reviewboard.asterisk.org/r/3907/
  2121. ASTERISK-24229 #close Reported by: Matt Jordan ........ Merged
  2122. revisions 421695 from
  2123. http://svn.asterisk.org/svn/asterisk/branches/12
  2124. * res/stasis/messaging.h, main/dns.c, /, main/format_cache.c: Clean
  2125. up files that do not end with newlines Trivial patch to add new
  2126. lines to several files missing them. This fixes warnings when
  2127. compiling with gcc 4.1.2 on CentOS 5. ASTERISK-24245 #close
  2128. Reported by: Shaun Ruffell patches:
  2129. 0002-Trivial-addition-of-newlines-at-end-of-three-files.patch
  2130. uploaded by Shaun Ruffell (License 5417) ........ Merged
  2131. revisions 421677 from
  2132. http://svn.asterisk.org/svn/asterisk/branches/12
  2133. * include/asterisk/uri.h, main/uri.c: uri: Quiet warning about type
  2134. qualifiers ignored on function return type This patch fixes gcc
  2135. warnings that occur due to the type qualifier 'const' being
  2136. ignored on a return type of int. ASTERISK-24246 #close Reported
  2137. by: Shaun Ruffell patches:
  2138. 0001-main-uri-Quiet-warning-about-ignored-attribute-on-re.patch
  2139. uploaded by Shaun Ruffell (License 5417)
  2140. 2014-08-20 22:49 +0000 [r421616-421645] Richard Mudgett <rmudgett@digium.com>
  2141. * main/bridge.c, res/res_pjsip_sdp_rtp.c, main/file.c,
  2142. main/bridge_channel.c, channels/chan_pjsip.c, main/channel.c:
  2143. chan_pjsip: Update media translation paths when new SDP
  2144. negotiated. On a SIP reinvite that changes media strams, the
  2145. PJSIP channel driver was flooding the log with "Asked to transmit
  2146. frame type %s, while native formats is %s" warnings. * Fixes
  2147. PJSIP not setting up translation paths when the formats change on
  2148. a reinvite. AFS-63 was effectively reintroduced because of the
  2149. media formats work. res_pjsip_sdp_rtp.c:set_caps() * Improved the
  2150. unexpected frame format WARNING message to include more
  2151. information. * Added protective locking while altering formats on
  2152. a channel. Reworked set_format() to simplify and protect the
  2153. formats under manipulation. * Restored some code that got lost in
  2154. the media_formats work. (channel.c:set_format() and
  2155. res_pjsip_sdp_rtp.c:set_caps()) AFS-137 #close Reported by: Mark
  2156. Michelson Review: https://reviewboard.asterisk.org/r/3906/
  2157. * /, main/cli.c: cli.c: Fix tab completion of "module load" when
  2158. MALLOC_DEBUG is enabled. filename_completion_function() returns
  2159. memory that was not allocated by the MALLOC_DEBUG allocation
  2160. tracker so the memory must be freed by ast_std_free(). ........
  2161. Merged revisions 421600 from
  2162. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2163. revisions 421602 from
  2164. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2165. revisions 421608 from
  2166. http://svn.asterisk.org/svn/asterisk/branches/12
  2167. 2014-08-20 20:40 +0000 [r421566-421585] Mark Michelson <mmichelson@digium.com>
  2168. * res/res_pjsip_pubsub.c: Set the role for inbound subscriptions
  2169. correctly. This was causing the AMI show_subscriptions test in
  2170. the testsuite to fail since all subscriptions were being seen as
  2171. subscribers instead of notifiers.
  2172. * /, channels/chan_pjsip.c: Move evaluation of set_var options in
  2173. pjsip to the end of channel initialization. This allows for
  2174. set_var to override certain defaults such as caller ID and codec
  2175. values. This also fixes a test suite regression. The "set_var"
  2176. test suite test attempted to use set_var to override caller ID,
  2177. but a recent change caused that to no longer work. ........
  2178. Merged revisions 421565 from
  2179. http://svn.asterisk.org/svn/asterisk/branches/12
  2180. 2014-08-20 13:04 +0000 [r421538] Kinsey Moore <kmoore@digium.com>
  2181. * include/asterisk/stasis_bridges.h, tests/test_cel.c,
  2182. res/ari/ari_model_validators.c, main/stasis_bridges.c,
  2183. res/ari/ari_model_validators.h, rest-api/api-docs/events.json, /,
  2184. res/stasis/app.c, main/bridge.c: Stasis: Add information to blind
  2185. transfer event When a blind transfer occurs that is forced to
  2186. create a local channel pair to satisfy the transfer request,
  2187. information about the local channel pair is not published. This
  2188. adds a field to describe that channel to the blind transfer
  2189. message struct so that this information is conveyed properly to
  2190. consumers of the blind transfer message. This also fixes a bug in
  2191. which Stasis() was unable to properly identify the channel that
  2192. was replacing an existing Stasis-controlled channel due to a
  2193. blind transfer. Reported by: Matt Jordan Review:
  2194. https://reviewboard.asterisk.org/r/3921/ ........ Merged
  2195. revisions 421537 from
  2196. http://svn.asterisk.org/svn/asterisk/branches/12
  2197. 2014-08-19 20:28 +0000 [r421448-421488] Mark Michelson <mmichelson@digium.com>
  2198. * /, res/res_pjsip.c: Alter documentation for callerid_privacy to
  2199. use correct values. ........ Merged revisions 421485 from
  2200. http://svn.asterisk.org/svn/asterisk/branches/12
  2201. * res/res_stasis.c, /: Fix compilation error on certain versions of
  2202. GCC. ........ Merged revisions 421447 from
  2203. http://svn.asterisk.org/svn/asterisk/branches/12
  2204. 2014-08-19 19:42 +0000 [r421445] Kinsey Moore <kmoore@digium.com>
  2205. * main/manager.c, /: AMI Docs: Fix Status channel parameter
  2206. optionality ........ Merged revisions 421442 from
  2207. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2208. revisions 421443 from
  2209. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2210. revisions 421444 from
  2211. http://svn.asterisk.org/svn/asterisk/branches/12
  2212. 2014-08-19 16:28 +0000 [r421423] Jonathan Rose <jrose@digium.com>
  2213. * res/res_stasis.c, /: ARI: Fix a bug where
  2214. /channels/{channelID}/continue doesn't execute PBX If
  2215. /channels/{channelID}/continue is called on a channel that was
  2216. originated without a PBX (such as the ARI command POST channel
  2217. with a stasis application argument), the channel will not start
  2218. dialplan execution. This patch will now run the PBX out of the
  2219. stasis execution if the channel doesn't currently have an active
  2220. PBX upon continuing. ASTERISK-24043 #close Reported by: Krandon
  2221. Bruse Review: https://reviewboard.asterisk.org/r/3917/ Patches:
  2222. stasis-continue.diff submitted by Krandon Bruse (license 6631)
  2223. ........ Merged revisions 421416 from
  2224. http://svn.asterisk.org/svn/asterisk/branches/12
  2225. 2014-08-19 16:11 +0000 [r421403] Richard Mudgett <rmudgett@digium.com>
  2226. * /, res/res_pjsip_caller_id.c, channels/chan_pjsip.c,
  2227. res/res_pjsip_session.c: chan_pjsip: Fix attended transfer
  2228. connected line name update. A calls B B answers B SIP attended
  2229. transfers to C C answers, B and C can see each other's connected
  2230. line information B completes the transfer A has number but no
  2231. name connected line information about C while C has the full
  2232. information about A I examined the incoming and outgoing party id
  2233. information handling of chan_pjsip and found several issues: *
  2234. Fixed ast_sip_session_create_outgoing() not setting up the
  2235. configured endpoint id as the new channel's caller id. This is
  2236. why party A got default connected line information. * Made
  2237. update_initial_connected_line() use the channel's CALLERID(id)
  2238. information. The core, app_dial, or predial routine may have
  2239. filled in or changed the endpoint caller id information. * Fixed
  2240. chan_pjsip_new() not setting the full party id information
  2241. available on the caller id and ANI party id. This includes the
  2242. configured callerid_tag string and other party id fields. * Fixed
  2243. accessing channel party id information without the channel lock
  2244. held. * Fixed using the effective connected line id without doing
  2245. a deep copy outside of holding the channel lock. Shallow copy
  2246. string pointers can become stale if the channel lock is not held.
  2247. * Made queue_connected_line_update() also update the channel's
  2248. CALLERID(id) information. Moving the channel to another bridge
  2249. would need the information there for the new bridge peer. * Fixed
  2250. off nominal memory leak in update_incoming_connected_line(). *
  2251. Added pjsip.conf callerid_tag string to party id information from
  2252. enabled trust_inbound endpoint in caller_id_incoming_request().
  2253. AFS-98 #close Reported by: Mark Michelson Review:
  2254. https://reviewboard.asterisk.org/r/3913/ ........ Merged
  2255. revisions 421400 from
  2256. http://svn.asterisk.org/svn/asterisk/branches/12
  2257. 2014-08-18 21:10 +0000 [r421376] Damien Wedhorn <voip@facts.com.au>
  2258. * channels/chan_skinny.c: Skinny: Fixup compile warning for non
  2259. dev-mode.
  2260. 2014-08-18 20:19 +0000 [r421337] George Joseph <george.joseph@fairview5.com>
  2261. * funcs/func_config.c, /: func_config: Change 'Not Found' message
  2262. from ERROR to DEBUG When you call the CONFIG dialplan function
  2263. with the name of a variable that doesn't exist in the target
  2264. context you get an ERROR. This does nothing but clutter up the
  2265. logs with messages that may be perfectly acceptable. Just because
  2266. a variable wasn't in the context doesn't mean it's an error.
  2267. Maybei t's optional or just needs to be defaulted or ignored.
  2268. This patch changes the log level from ERROR to DEBUG. If a
  2269. dialplan developer wants to debug their dialplan they still canby
  2270. setting the console debug level as needed. Tested by: George
  2271. Joseph Review: https://reviewboard.asterisk.org/r/3919/ ........
  2272. Merged revisions 421327 from
  2273. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2274. revisions 421328 from
  2275. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2276. revisions 421329 from
  2277. http://svn.asterisk.org/svn/asterisk/branches/12
  2278. 2014-08-18 01:13 +0000 [r421230-421312] Matthew Jordan <mjordan@digium.com>
  2279. * res/ari/resource_channels.c: res/ari/resource_channels: Fix
  2280. compilation issue Forgot a parameter. Whoops.
  2281. * res/ari/resource_channels.c: res/ari/resource_channels: Don't
  2282. return allocation failure on failed function If a function fails
  2283. to execute, it is most likely due to one of two reasons: (1) The
  2284. function doesn't exist or can't be read from (2) The function is
  2285. dangerous and is restricted based on the user's permissions
  2286. Currently we return allocation failure, which is incorrect. This
  2287. updates the reason code to more accurately reflect why the
  2288. request failed. ASTERISK-24215
  2289. * /, apps/app_meetme.c: apps/app_meetme: Fix crash when publishing
  2290. MeetMe messages with no channel The same function,
  2291. meetme_stasis_generate_msg, handles creating and publishing
  2292. Stasis message both when there are channels in the MeetMe
  2293. conference and when there are no channels in the conference. When
  2294. the performance improvement was made to use cached snapshots,
  2295. this created a situation where Asterisk would crash: obtaining a
  2296. cached snapshot is not NULL tolerant. This patch restores the
  2297. previous implementation, which used a NULL safe set of routines
  2298. to produce a blob containing the channel snapshot (if available)
  2299. and information about the MeetMe conference. ASTERISK-24234
  2300. #close Reported by: Shaun Ruffell Tested by: Shaun Ruffell
  2301. ........ Merged revisions 421270 from
  2302. http://svn.asterisk.org/svn/asterisk/branches/12
  2303. * apps/app_dial.c, /: apps/app_dial: Fix Dial 'z' option The 'z'
  2304. option is supposed to disable the dial timeout in the case of a
  2305. call forward. Unfortunately, the wrong timeout timer was passed
  2306. to the do_forward function, resulting in the option not working.
  2307. ASTERISK-24225 #close Reported by: dimitripietro Tested by:
  2308. dimitripietro patches: jira_asterisk_24225_v1.8.patch uploaded by
  2309. rmudgett (License 5621) jira_asterisk_24225_v11.patch uploaded by
  2310. rmudgett (License 5621) ........ Merged revisions 421232 from
  2311. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2312. revisions 421233 from
  2313. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2314. revisions 421234 from
  2315. http://svn.asterisk.org/svn/asterisk/branches/12
  2316. * /, configure, configure.ac: configure: Undefine FORTIFY_SOURCE
  2317. prior to defining it for patched gcc Some distributions of Linux
  2318. patch gcc to define FORTIFY_SOURCE when gcc is executed with
  2319. optimization. This "help" unfortunately results in re-definition
  2320. warnings when FORTIFY_SOURCE is later defined in Asterisk's build
  2321. system. This patch undefines FORTIFY_SOURCE prior to defining it
  2322. to prevent this warning. Review:
  2323. https://reviewboard.asterisk.org/r/3912/ ASTERISK-24032 #close
  2324. Reported by: Kilburn Tested by: Kilburn, wdoekes patches:
  2325. 1.8.diff uploaded by cloos (License 5956) 10.diff uploaded by
  2326. cloos (License 5956) 11.diff uploaded by cloos (License 5956)
  2327. 12.diff uploaded by cloos (License 5956) 13.diff uploaded by
  2328. cloos (License 5956) ........ Merged revisions 421227 from
  2329. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2330. revisions 421228 from
  2331. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2332. revisions 421229 from
  2333. http://svn.asterisk.org/svn/asterisk/branches/12
  2334. 2014-08-17 16:10 +0000 [r421210] Joshua Colp <jcolp@digium.com>
  2335. * res/res_http_websocket.c: res_http_websocket: Include query
  2336. parameters in client connection requests. Review:
  2337. https://reviewboard.asterisk.org/r/3914/
  2338. 2014-08-15 17:08 +0000 [r421187] Jonathan Rose <jrose@digium.com>
  2339. * main/channel.c, /: Bridging: Fix a behavioral change when
  2340. checking if a channel is leaving a bridge r420934 introduced some
  2341. failures in the test suite. Upon investigating, it was discovered
  2342. that differences in the way we were evaluating whether a channel
  2343. was in the process of leaving a bridge were causing some
  2344. reinvites not to occur (mostly reinvites back to Asterisk when
  2345. ending a call). This patch fixes that behavioral change.
  2346. ASTERISK-24027 #close Reported by: Matt Jordan Review:
  2347. https://reviewboard.asterisk.org/r/3910/ ........ Merged
  2348. revisions 421186 from
  2349. http://svn.asterisk.org/svn/asterisk/branches/12
  2350. 2014-08-15 15:45 +0000 [r421042-421166] Matthew Jordan <mjordan@digium.com>
  2351. * apps/app_voicemail.c, /, main/app.c: app_voicemail/app: Remove
  2352. test events that were duplicated by r421059 Moving the test event
  2353. raised when a file is played back (which occurred in r421059)
  2354. broke the ever loving snot out of the voicemail tests. This
  2355. caused duplicate test events to get raised, as app_voicemail and
  2356. main/app were raising events prior to call ast_streamfile. The
  2357. voicemail tests did not enjoy getting multiple events. Since
  2358. raising the playback event in ast_streamfile is far more useful
  2359. to the vast majority of tests, this patch keeps the call there
  2360. and simply removes the extraneous calls that duplicated the
  2361. event. ........ Merged revisions 421125 from
  2362. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2363. revisions 421164 from
  2364. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2365. revisions 421165 from
  2366. http://svn.asterisk.org/svn/asterisk/branches/12
  2367. * res/res_hep_rtcp.c, /: res/res_hep_rtcp: Remove dependency on
  2368. PJSIP The res_hep_rtcp module was incorrectly including
  2369. <pjsip.h>. This didn't need to be included, as the module does
  2370. not using PJPROJECT any fashion. Unfortunately, because
  2371. res_hep_rtcp did not include pjsip in its MODULEINFO as a
  2372. dependency, this also meant that res_hep_rtcp will fail to
  2373. compile on a system without PJPROJECT. This patch removes the
  2374. include. Thanks to Damien Wedhorn for pointing this out in
  2375. #asterisk-dev. ASTERISK-24236 #close Reported by: Damien Wedhorn,
  2376. Matt Jordan Tested by: Damien Wedhorn ........ Merged revisions
  2377. 421064 from http://svn.asterisk.org/svn/asterisk/branches/12
  2378. * /, main/file.c, main/app.c: main/file: Move test event to emit
  2379. PLAYBACK event more consistently This is being done in advance of
  2380. the test for ASTERISK-23953 ........ Merged revisions 421059 from
  2381. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2382. revisions 421060 from
  2383. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2384. revisions 421061 from
  2385. http://svn.asterisk.org/svn/asterisk/branches/12
  2386. * tests/test_cel.c, main/cel.c, /: cel: Make sure channels in extra
  2387. fields include their unique IDs as well CEL typically tracks a
  2388. lot of information using the unique ID of the channel. This is
  2389. typically needed due to tying events together using the linked ID
  2390. of the various channels involved in a "call", which is derived
  2391. from the channel ID of the oldest channel involved in a bridge
  2392. (or in the case of a Dial, the parent channel). Previously, we
  2393. had updated the extra fields to include the involved channel
  2394. names, but forgot to put in the unique ID. This patch corrects
  2395. that error. ........ Merged revisions 421037 from
  2396. http://svn.asterisk.org/svn/asterisk/branches/12
  2397. 2014-08-14 16:32 +0000 [r420957-421010] Richard Mudgett <rmudgett@digium.com>
  2398. * /, res/ari/resource_channels.c: ARI: Originate to app local
  2399. channel subscription code optimization. Reduce the scope of
  2400. local_peer and only get it if the ARI originate is subscribing to
  2401. the channels. Review: https://reviewboard.asterisk.org/r/3905/
  2402. ........ Merged revisions 421009 from
  2403. http://svn.asterisk.org/svn/asterisk/branches/12
  2404. * main/channel_internal_api.c, main/channel.c:
  2405. channel_internal_api.c: Replace some code with ao2_replace(). Use
  2406. ao2_replace() instead of ao2_cleanup(); ao2_bump(). ao2_replace()
  2407. has the advantange of not altering the ref count if the replaced
  2408. pointer is the same. Review:
  2409. https://reviewboard.asterisk.org/r/3904/
  2410. * /, res/res_pjsip_send_to_voicemail.c:
  2411. res_pjsip_send_to_voicemail.c: Fix svn file properties. ........
  2412. Merged revisions 420956 from
  2413. http://svn.asterisk.org/svn/asterisk/branches/12
  2414. 2014-08-13 16:53 +0000 [r420950] Kinsey Moore <kmoore@digium.com>
  2415. * res/res_pjsip.c, /: PJSIP: Prevent crash no-URI contacts This
  2416. prevents a crash from occurring when a contact with no URI is
  2417. used for the creation of an outbound out-of-dialog request with
  2418. no associated endpoint. ........ Merged revisions 420949 from
  2419. http://svn.asterisk.org/svn/asterisk/branches/12
  2420. 2014-08-13 16:07 +0000 [r420940] Jonathan Rose <jrose@digium.com>
  2421. * main/bridge_after.c, main/channel_internal_api.c,
  2422. include/asterisk/channel.h, apps/app_chanspy.c,
  2423. apps/app_mixmonitor.c, apps/app_stack.c, main/bridge_channel.c,
  2424. main/channel.c, main/pbx.c, /, main/framehook.c: Bridges: Fix
  2425. feature interruption/unintended kick caused by external actions
  2426. If a manager or CLI user attached a mixmonitor to a call running
  2427. a dynamic bridge feature while in a bridge, the feature would be
  2428. interrupted and the channel would be forcibly kicked out of the
  2429. bridge (usually ending the call during a simple 1 to 1 call).
  2430. This would also occur during any similar action that could set
  2431. the unbridge soft hangup flag, so the fix for this was to remove
  2432. unbridge from the soft hangup flags and make it a separate thing
  2433. all together. ASTERISK-24027 #close Reported by: mjordan Review:
  2434. https://reviewboard.asterisk.org/r/3900/ ........ Merged
  2435. revisions 420934 from
  2436. http://svn.asterisk.org/svn/asterisk/branches/12
  2437. 2014-08-13 14:24 +0000 [r420919] Kinsey Moore <kmoore@digium.com>
  2438. * main/manager.c: AMI: Improve documentation for Status action
  2439. 2014-08-13 07:52 +0000 [r420899] Walter Doekes <walter+asterisk@wjd.nu>
  2440. * /, main/logger.c: logger: Don't store verbose-magic in the log
  2441. files. In r399267, the verbose2magic stuff was edited. This time
  2442. it results in magic characters in the log files for multiline
  2443. messages. In trunk (and 13) this was fixed by the "stripping" of
  2444. those characters from multiline messages (in r414798). This fix
  2445. is altered to actually strip the characters and not replace them
  2446. with blanks. Review: https://reviewboard.asterisk.org/r/3901/
  2447. Review: https://reviewboard.asterisk.org/r/3902/ ........ Merged
  2448. revisions 420897 from
  2449. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2450. revisions 420898 from
  2451. http://svn.asterisk.org/svn/asterisk/branches/12
  2452. 2014-08-12 23:43 +0000 [r420879-420881] Richard Mudgett <rmudgett@digium.com>
  2453. * channels/chan_sip.c: chan_sip: Fix type mismatch when the format
  2454. is changed. Symptom is most likely an invalid ao2 object bad
  2455. magic number message or a less likely crash.
  2456. * res/res_stasis_snoop.c: res_stasis_snoop.c: Fix off nominial exit
  2457. path leaving Snoop channel locked and not hungup. * Made use
  2458. ast_copy_string() instead of strcpy() for snoop uniqueid for
  2459. safety. There is no guarantee that the max channel uniqueid
  2460. length will remain the same as the snoop uniqueid space.
  2461. 2014-08-12 11:17 +0000 [r420856] Joshua Colp <jcolp@digium.com>
  2462. * apps/app_voicemail.c: app_voicemail: Fix the
  2463. "test_voicemail_vm_info" unit test.
  2464. 2014-08-11 20:53 +0000 [r420837] Richard Mudgett <rmudgett@digium.com>
  2465. * res/stasis/command.c, /: res/stasis/command.c: Fix recent commit
  2466. using spaces instead of tabs. ........ Merged revisions 420836
  2467. from http://svn.asterisk.org/svn/asterisk/branches/12
  2468. 2014-08-11 18:50 +0000 [r420808] Matthew Jordan <mjordan@digium.com>
  2469. * rest-api/api-docs/playbacks.json,
  2470. rest-api/api-docs/channels.json, rest-api/api-docs/sounds.json,
  2471. rest-api/resources.json, include/asterisk/manager.h,
  2472. rest-api/api-docs/bridges.json,
  2473. rest-api/api-docs/recordings.json,
  2474. rest-api/api-docs/deviceStates.json,
  2475. rest-api/api-docs/endpoints.json,
  2476. rest-api/api-docs/mailboxes.json, rest-api/api-docs/events.json,
  2477. /, rest-api/api-docs/asterisk.json,
  2478. rest-api/api-docs/applications.json: AMI/ARI: Update version to
  2479. 2.5.0/1.5.0 respectively This is to support the backwards
  2480. compatible changes made in the next version of Asterisk. ........
  2481. Merged revisions 420805 from
  2482. http://svn.asterisk.org/svn/asterisk/branches/12
  2483. 2014-08-11 18:46 +0000 [r420796-420803] Kinsey Moore <kmoore@digium.com>
  2484. * /, res/res_stasis.c: Stasis: Use the correct return value Return
  2485. the correct value instead of always returning 0 when setting
  2486. internal status on unreal channels. Reported by: Richard Mudgett
  2487. ........ Merged revisions 420802 from
  2488. http://svn.asterisk.org/svn/asterisk/branches/12
  2489. * res/res_stasis.c, res/ari/resource_bridges.c, /,
  2490. res/stasis/stasis_bridge.c, include/asterisk/stasis_app.h:
  2491. Stasis: Allow internal channels directly into bridges The patch
  2492. to catch channels being shoehorned into Stasis() via external
  2493. mechanisms also happens to catch Announcer and Recorder channels
  2494. because they aren't known to be stasis-controlled channels in the
  2495. usual sense. This marks those channels as Stasis()-internal
  2496. channels and allows them directly into bridges. Review:
  2497. https://reviewboard.asterisk.org/r/3903/ ........ Merged
  2498. revisions 420795 from
  2499. http://svn.asterisk.org/svn/asterisk/branches/12
  2500. 2014-08-11 18:32 +0000 [r420758-420794] Mark Michelson <mmichelson@digium.com>
  2501. * include/asterisk/stasis_app.h, main/stasis_channels.c,
  2502. res/ari/resource_channels.c, CHANGES, res/res_pjsip_pubsub.c,
  2503. main/manager_channels.c, apps/app_dial.c, res/stasis/app.c,
  2504. res/stasis/control.c: Improve call forwarding reporting,
  2505. especially with regards to ARI. This patch addresses a few
  2506. issues: 1) The order of Dial events have been changed when
  2507. performing a call forward. The order has now been altered to 1)
  2508. Dial begins dialing channel A. 2) When A forwards the call to B,
  2509. we issue the dial end event to channel A, indicating the dial is
  2510. being canceled due to a forward to B. 3) When the call to channel
  2511. B occurs, we then issue a new dial begin to channel B. 2) Call
  2512. forwards are now reported on the calling channel, not the peer
  2513. channel. 3) AMI DialEnd events have been altered to display the
  2514. extension the call is being forwarded to when relevant. 4) You
  2515. can now get the values of channel variables for channels that are
  2516. not currently in the Stasis application. This brings the
  2517. retrieval of channel variables more in line with the rest of
  2518. channel read operations since they may be performed on channels
  2519. not in Stasis. ASTERISK-24134 #close Reported by Matt Jordan
  2520. ASTERISK-24138 #close Reported by Matt Jordan Patches:
  2521. forward-shenanigans.diff uploaded by Matt Jordan (License #6283)
  2522. Review: https://reviewboard.asterisk.org/r/3899
  2523. * res/res_pjsip_pubsub.c: Fix crashing unit tests with regards to
  2524. RLS. The unit tests require a sorcery.conf file that has been set
  2525. up to store resource lists in memory rather than retrieving from
  2526. configuration. With a setup that is not conducive to running the
  2527. tests, a fault in sorcery currently causes Asterisk to crash when
  2528. attempting to run any of the tests. To get around the crash, this
  2529. adds a function that verifies the current environment and marks
  2530. the tests as "not run" if the setup is not correct.
  2531. * res/res_pjsip_pubsub.c: Fix crash encountered by the testsuite.
  2532. Running testsuite tests locally produced no errors, but when run
  2533. using the continuous integration framework, crashes occurred. The
  2534. crashes occurred due to a refcounting error that had been fixed
  2535. for a similar situation.
  2536. 2014-08-11 13:57 +0000 [r420742] Matthew Jordan <mjordan@digium.com>
  2537. * res/res_hep.c, res/res_hep_pjsip.c, res/res_hep_rtcp.c: res_hep:
  2538. Remove disabling of modules These modules were originally
  2539. specified as being disabled, as they were introduced midstream in
  2540. Asterisk 12. That makes it nicer for folks who are upgrading to a
  2541. new release in the middle of Asterisk 12. That's not the case for
  2542. Asterisk 13: it's a brand new release. There's no reason to have
  2543. the modules disabled by default in that case.
  2544. 2014-08-11 10:40 +0000 [r420657-420717] Walter Doekes <walter+asterisk@wjd.nu>
  2545. * /, main/utils.c: general: Fix memory Corruption in
  2546. __ast_string_field_ptr_build_va. If the space left in a
  2547. stringfield is between 0 and
  2548. (alignof(ast_string_field_allocation)-1) adding new data would
  2549. cause memory corruption, because we would assume enough space
  2550. (unsigned underrun). Thanks Arnd Schmitter for reporting and
  2551. finding out the cause! ASTERISK-23508 #close Reported by: Arnd
  2552. Schmitter Tested by: Arnd Schmitter, JoshE Review:
  2553. https://reviewboard.asterisk.org/r/3898/ ........ Merged
  2554. revisions 420680 from
  2555. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2556. revisions 420715 from
  2557. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2558. revisions 420716 from
  2559. http://svn.asterisk.org/svn/asterisk/branches/12
  2560. * main/tcptls.c, /: tcptls: Avoid compiler warning on non-dev-mode.
  2561. ........ Merged revisions 420654 from
  2562. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2563. revisions 420655 from
  2564. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2565. revisions 420656 from
  2566. http://svn.asterisk.org/svn/asterisk/branches/12
  2567. 2014-08-11 01:31 +0000 [r420607-420639] Matthew Jordan <mjordan@digium.com>
  2568. * funcs/func_jitterbuffer.c: funcs/func_jitterbuffer: Tweak
  2569. documentation This patch merely reformats and cleans up a bit of
  2570. the jitterbuffer documentation for the wiki.
  2571. * UPGRADE.txt, configs/samples/extconfig.conf.sample, CHANGES,
  2572. apps/app_queue.c,
  2573. contrib/ast-db-manage/config/versions/d39508cb8d8_create_queue_rules.py
  2574. (added), configs/samples/queuerules.conf.sample: app_queue: Add
  2575. RealTime support for queue rules This patch gives the optional
  2576. ability to keep queue rules in RealTime. It is important to note
  2577. that with this patch: (a) Queue rules in RealTime are only
  2578. examined on module load/reload (b) Queue rules are loaded both
  2579. from the queuerules.conf file as well as the RealTime backend To
  2580. inform app_queue to examine RealTime for queue rules, a new
  2581. setting has been added to queuerules.conf's general section
  2582. "realtime_rules". RealTime queue rules will only be used when
  2583. this setting is set to "yes". The schema for the database table
  2584. supports a rule_name, time, min_penalty, and max_penalty columns.
  2585. min_penalty and max_penalty can be relative, if a '-' or '+'
  2586. literal is provided. Otherwise, the penalties are treated as
  2587. constants. For example: rule_name, time, min_penalty, max_penalty
  2588. 'default', '10', '20', '30' 'test2', '20', '30', '55' 'test2',
  2589. '25', '-11', '+1111' 'test2', '400', '112', '333' 'test3', '0',
  2590. '4564', '46546' 'test_rule', '40', '15', '50' which would result
  2591. in : Rule: default - After 10 seconds, adjust QUEUE_MAX_PENALTY
  2592. to 30 and adjust QUEUE_MIN_PENALTY to 20 Rule: test2 - After 20
  2593. seconds, adjust QUEUE_MAX_PENALTY to 55 and adjust
  2594. QUEUE_MIN_PENALTY to 30 - After 25 seconds, adjust
  2595. QUEUE_MAX_PENALTY by 1111 and adjust QUEUE_MIN_PENALTY by -11 -
  2596. After 400 seconds, adjust QUEUE_MAX_PENALTY to 333 and adjust
  2597. QUEUE_MIN_PENALTY to 112 Rule: test3 - After 0 seconds, adjust
  2598. QUEUE_MAX_PENALTY to 46546 and adjust QUEUE_MIN_PENALTY to 4564
  2599. Rule: test_rule - After 40 seconds, adjust QUEUE_MAX_PENALTY to
  2600. 50 and adjust QUEUE_MIN_PENALTY to 15 If you use RealTime, the
  2601. queue rules will be always reloaded on a module reload, even if
  2602. the underlying file did not change. With the option disabled, the
  2603. rules will only be reloaded if the file was modified. Review:
  2604. https://reviewboard.asterisk.org/r/3607/ ASTERISK-23823 #close
  2605. Reported by: Michael K patches: app_queue.c_realtime_trunk.patch
  2606. uploaded by Michael K (License 6621)
  2607. * CHANGES: Update CHANGES file
  2608. * UPGRADE.txt: Update UPGRADE.txt file
  2609. 2014-08-08 20:08 +0000 [r420577-420592] Jason Parker <jparker@digium.com>
  2610. * apps/app_voicemail.c: Fix build in devmode.
  2611. * CHANGES, configs/samples/voicemail.conf.sample,
  2612. apps/app_voicemail.c: app_voicemail: Add the ability to specify
  2613. multiple email addresses. ASTERISK-24045 Reported by: Jacob
  2614. Barber Review: https://reviewboard.asterisk.org/r/3833/
  2615. 2014-08-08 17:53 +0000 [r420534-420562] Matthew Jordan <mjordan@digium.com>
  2616. * channels/chan_sip.c, channels/sip/security_events.c,
  2617. channels/sip/dialplan_functions.c, channels/sip/reqresp_parser.c,
  2618. channels/sip/route.c, channels/sip/utils.c,
  2619. channels/sip/config_parser.c: chan_sip: Mark chan_sip and its
  2620. files as extended support
  2621. * rest-api-templates/make_ari_stubs.py: make_ari_stubs: Update wiki
  2622. prefix to '13'
  2623. * rest-api-templates/res_ari_resource.c.mustache:
  2624. res_ari_resource.c.mustache: Update template to emit module
  2625. support level
  2626. * main/message.c, /: main/message: remove debug message ........
  2627. Merged revisions 420533 from
  2628. http://svn.asterisk.org/svn/asterisk/branches/12
  2629. 2014-08-08 03:03 +0000 [r420514] Kinsey Moore <kmoore@digium.com>
  2630. * tests/test_cel.c, /: CEL: Update unit tests for additional
  2631. information This updates the CEL unit tests for the new
  2632. information contained in the attended transfer CEL extra field.
  2633. ........ Merged revisions 420513 from
  2634. http://svn.asterisk.org/svn/asterisk/branches/12
  2635. 2014-08-08 01:31 +0000 [r420494-420496] Matthew Jordan <mjordan@digium.com>
  2636. * UPGRADE.txt: Update UPGRADE file for 13 branch
  2637. * /: Remove old properties
  2638. * / (added): ___ _ _ _ __ _____ / _ \ | | (_) | | / ||____ | / /_\
  2639. \___| |_ ___ _ __ _ ___| | __ `| | / / | _ / __| __/ _ | '__| /
  2640. __| |/ / | | \ \ | | | \__ | || __| | | \__ | < _| |.___/ / \_|
  2641. |_|___/\__\___|_| |_|___|_|\_\ \___\____/
  2642. 2014-08-07 21:58 +0000 [r420437] Richard Mudgett <rmudgett@digium.com>
  2643. * /, channels/chan_sip.c: chan_sip: Replace sip_tls_read() and
  2644. resolve the large SDP poll issue. Replace sip_tls_read() and
  2645. sip_tcp_read() with a single function and resolve the poll/wait
  2646. issue with large SDP payloads. ASTERISK-18345 #close Reported by:
  2647. Stephane Chazelas Patches: tcptls_pollv4.diff (license #5835)
  2648. patch uploaded by Elazar Broad Review:
  2649. https://reviewboard.asterisk.org/r/3882/ ........ Merged
  2650. revisions 420434 from
  2651. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2652. revisions 420435 from
  2653. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2654. revisions 420436 from
  2655. http://svn.asterisk.org/svn/asterisk/branches/12
  2656. 2014-08-07 21:17 +0000 [r420389-420415] Kinsey Moore <kmoore@digium.com>
  2657. * main/stasis_bridges.c, /: Stasis: Correct blind transfer message
  2658. generation This fixes the json object creation format string and
  2659. key name for the BridgeBlindTransfer Stasis event allowing it to
  2660. be published properly. ........ Merged revisions 420414 from
  2661. http://svn.asterisk.org/svn/asterisk/branches/12
  2662. * main/stasis_bridges.c, /: Stasis: Ensure transfer messages follow
  2663. validation rules This makes Stasis() event generation for
  2664. transfer messages follow validation rules. Currently,
  2665. ast_json_null() is being used in place of omitting a key entirely
  2666. which falls afoul of these validation rules.
  2667. https://reviewboard.asterisk.org/r/3892/ ........ Merged
  2668. revisions 420408 from
  2669. http://svn.asterisk.org/svn/asterisk/branches/12
  2670. * res/res_pjsip_pubsub.c: Fix build in dev mode
  2671. 2014-08-07 19:44 +0000 [r420384-420388] Mark Michelson <mmichelson@digium.com>
  2672. * /, main/bridge.c: Ensure bridges exist when trying to determine
  2673. bridged parties when publishing transfer information. ........
  2674. Merged revisions 420387 from
  2675. http://svn.asterisk.org/svn/asterisk/branches/12
  2676. * main/strings.c, include/asterisk/res_pjsip_presence_xml.h,
  2677. res/res_pjsip_mwi.c, res/res_pjsip_dialog_info_body_generator.c,
  2678. res/res_pjsip_xpidf_body_generator.c, include/asterisk/strings.h,
  2679. res/res_pjsip_pubsub.c, res/res_pjsip_exten_state.c,
  2680. include/asterisk/res_pjsip_pubsub.h,
  2681. res/res_pjsip_pidf_body_generator.c: Add support for RFC 4662
  2682. resource list subscriptions. This commit adds the ability for a
  2683. user to configure a resource list in pjsip.conf. Subscribing to
  2684. this list simultaneously subscribes the subscriber to all
  2685. resources listed. This has the potential to reduce the amount of
  2686. SIP traffic when loads of subscribers on a system attempt to
  2687. subscribe to each others' states.
  2688. 2014-08-07 18:51 +0000 [r420364] Richard Mudgett <rmudgett@digium.com>
  2689. * include/asterisk/format_compatibility.h,
  2690. channels/iax2/format_compatibility.c,
  2691. channels/iax2/include/codec_pref.h, main/format_compatibility.c,
  2692. channels/chan_iax2.c, channels/iax2/codec_pref.c,
  2693. channels/iax2/include/format_compatibility.h: chan_iax2: Several
  2694. media format fixes. * Fixed the iax.conf bandwidth option. This
  2695. is the root cause of ASTERISK-24150. * Added checks in
  2696. iax2_request() to ensure that there are actual formats requested
  2697. for the new channel to prevent any more fracks from issues like
  2698. ASTERISK-24150. This is a consequence of the iax.conf bandwidth
  2699. option not working. * Fixed struct iax2_codec_pref.order member
  2700. size mismatch issue when converting to and from the codec
  2701. preference order list passed over the wire. In addition the
  2702. values sent over the wire are now compatible with previous
  2703. Asterisk versions. * Fixed several issues dealing with the struct
  2704. iax2_codec_pref members. Off-by-one, array limit errors, and the
  2705. order/framing members always need to be updated together. * Made
  2706. iax2_request() setup the channel's native format preference order
  2707. according to the user's wishes. The new media format strategy
  2708. needs the order specified earler. * Fixed usage of
  2709. ast_format_compatibility_bitfield2format(). The function can
  2710. return NULL if the bitfield was not associated with a function. *
  2711. Deleted dead code iax2_codec_pref_getsize() and
  2712. iax2_codec_pref_setsize(). * Made iax2_parse_allow_disallow() and
  2713. iax2_codec_pref_string() call iax2_codec_pref_to_cap() instead of
  2714. inlining it. * Made IAX_CAPABILITY_MEDBANDWIDTH,
  2715. IAX_CAPABILITY_LOWBANDWIDTH, and IAX_CAPABILITY_LOWFREE constants
  2716. again as they were in Asterisk v1.8. * Renamed prefs to
  2717. prefs_global so it won't get confused with the local pref
  2718. versions. * Fixed too small buffer in
  2719. handle_cli_iax2_show_peer(). * Fixed ast_cli() calls in
  2720. handle_cli_iax2_show_peer() to output complete lines. * Changed
  2721. struct create_addr_info.prefs to be struct iax2_codec_pref as an
  2722. optimization so iax2_request() and iax2_call() do less work. *
  2723. Fixed a potential deadlock in ast_iax2_new() on an off-nominal
  2724. path when the pbx could not get started. * Made set_config()
  2725. setup a local prefs list along side the local capability format
  2726. bitfield. Once the config is loaded, then the local copies are
  2727. put into the global versions. * Fix unininialized codec_buf in
  2728. function_iaxpeer(). ASTERISK-24150 #close Reported by: Scott
  2729. Griepentrog Review: https://reviewboard.asterisk.org/r/3890/
  2730. 2014-08-07 15:30 +0000 [r420338] Kinsey Moore <kmoore@digium.com>
  2731. * include/asterisk/bridge_features.h, res/res_stasis.c,
  2732. res/stasis/command.c, rest-api/api-docs/events.json, /,
  2733. res/stasis/app.c, res/stasis/control.c, main/bridge.c,
  2734. main/bridge_basic.c, res/stasis/stasis_bridge.c,
  2735. include/asterisk/stasis_bridges.h, res/stasis/command.h,
  2736. include/asterisk/stasis_app.h, res/stasis/app.h,
  2737. res/stasis/control.h, apps/app_queue.c,
  2738. res/ari/ari_model_validators.c, main/cel.c,
  2739. main/stasis_bridges.c, res/ari/ari_model_validators.h,
  2740. main/channel.c, include/asterisk/datastore.h, tests/test_cel.c:
  2741. Stasis: Convey transfer information to applications This fixes a
  2742. class of issues where Stasis applications were not made aware
  2743. that their channels were being manipulated or replaced by
  2744. external entitiessuch as transfers, AMI commands, or dialplan
  2745. applications such as Bridge(). Inconsistent information such as
  2746. StasisEnd events with unknown channels as a result of masquerades
  2747. has also been corrected. To accomplish these fixes, several new
  2748. fields were added to blind and attended transfer messages as well
  2749. as StasisStart and BridgeAttendedTransfer Stasis events.
  2750. ASTERISK-23941 #close Review:
  2751. https://reviewboard.asterisk.org/r/3865/ Review:
  2752. https://reviewboard.asterisk.org/r/3857/ Review:
  2753. https://reviewboard.asterisk.org/r/3852/ Review:
  2754. https://reviewboard.asterisk.org/r/3816/ Review:
  2755. https://reviewboard.asterisk.org/r/3731/ Review:
  2756. https://reviewboard.asterisk.org/r/3729/ Review:
  2757. https://reviewboard.asterisk.org/r/3728/ ........ Merged
  2758. revisions 420325 from
  2759. http://svn.asterisk.org/svn/asterisk/branches/12
  2760. 2014-08-07 14:37 +0000 [r420314-420315] Joshua Colp <jcolp@digium.com>
  2761. * include/asterisk/res_pjsip_pubsub.h,
  2762. res/res_pjsip_pubsub.exports.in, res/res_pjsip_publish_asterisk.c
  2763. (added), res/res_pjsip_pubsub.c: res_pjsip_publish_asterisk: Add
  2764. support for exchanging device and mailbox state using SIP. This
  2765. module uses the inbound and outbound PUBLISH support to exchange
  2766. device and mailbox state between Asterisk instances. Each
  2767. instance is configured to publish to the other and requires no
  2768. intermediary server. The functionality provided is similar to the
  2769. XMPP and Corosync support. Review:
  2770. https://reviewboard.asterisk.org/r/3780/
  2771. * include/asterisk/res_pjsip_outbound_publish.h (added),
  2772. res/res_pjsip_outbound_publish.exports.in (added),
  2773. res/res_pjsip_outbound_publish.c (added):
  2774. res_pjsip_outbound_publish: Add module which provides outbound
  2775. PUBLISH support. This module implements the core parts required
  2776. for doing outbound PUBLISH. It takes care of configuration,
  2777. lifetime management, and authentication. Additional modules
  2778. implement the specific events that are published. Review:
  2779. https://reviewboard.asterisk.org/r/3780/
  2780. 2014-08-07 14:17 +0000 [r420289-420309] Matthew Jordan <mjordan@digium.com>
  2781. * main/pbx.c: pbx: Filter out pattern matching hints in responses
  2782. sent to ExtensionStateList Hints that are a pattern match are
  2783. technically stored in the hint container in the same fashion as
  2784. concrete implementations of hints. The pattern matching hints,
  2785. however, are not "real" in the sense that things can subscribe to
  2786. them: rather, they are stored in the hints container so that when
  2787. a subscription is made a "real" hint can be generated for the
  2788. subscription if one does not yet exist. The extension state core
  2789. takes care of this correctly by matching against non-pattern
  2790. matching extensions prior to pattern matching extensions. Because
  2791. of this, however, the ExtensionStateList AMI action was returning
  2792. pattern matching hints when executed. These hints are meaningless
  2793. from the perspective of AMI clients: their state will never
  2794. change, they cannot be subscribed to, and events would never
  2795. normally be generated from them. As such, we now filter these out
  2796. of the response.
  2797. * build_tools/post_process_documentation.py: build_tools: Skip
  2798. managerEvent combining for AMI action responses AMI action
  2799. responses can (and will) reference AMI events that they return.
  2800. These event references and definitions should not be combined
  2801. with AMI events raised elsewhere in the code, as they are
  2802. specifically tied to the AMI action that raised them.
  2803. ASTERISK-24156 #close Reported by: Rusty Newton
  2804. 2014-08-06 18:12 +0000 [r420212-420237] Richard Mudgett <rmudgett@digium.com>
  2805. * contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py,
  2806. /: Fix alembic script to work properly in offline mode. When run
  2807. in offline mode, this would attempt to check the database for the
  2808. presence of a type it was going to try to create. I now check the
  2809. context to see if we're running in offline mode and change a
  2810. parameter accordingly. ........ Merged revisions 407567 from
  2811. http://svn.asterisk.org/svn/asterisk/branches/12
  2812. * contrib/ast-db-manage/config/versions/3855ee4e5f85_add_missing_pjsip_options.py
  2813. (added), /: Add alembic script that adds contact user_agent and
  2814. endpoint message_context. ........ Merged revisions 411514 from
  2815. http://svn.asterisk.org/svn/asterisk/branches/12
  2816. * contrib/ast-db-manage/voicemail/versions/39428242f7f5_increase_recording_column_size.py
  2817. (added), /,
  2818. contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py,
  2819. contrib/ast-db-manage/config.ini.sample,
  2820. contrib/ast-db-manage/config/versions/1758e8bbf6b_increase_useragent_column_size.py
  2821. (added),
  2822. contrib/ast-db-manage/config/versions/5139253c0423_make_q_member_uniqueid_autoinc.py
  2823. (added), contrib/ast-db-manage/cdr.ini.sample,
  2824. contrib/ast-db-manage/voicemail.ini.sample: alembic: Adjust
  2825. sippeers, queue_members, and voicemail_messages tables. *
  2826. Increased the sippeers useragent max string size to 255. *
  2827. Changed the queue_members uniqueid to an auto incremented integer
  2828. instead of a string. * Increased the voicemail_messages BLOB size
  2829. to LONGBLOB on mysql. * Fixed the add_tables_for_pjsip config
  2830. change version downgrade actions to drop a table it created. *
  2831. Adjusted the sample alembic.ini files cdr.ini.sample,
  2832. config.ini.sample, and voicemail.ini.sample to give a mysql and
  2833. postgres sqlalchemy.url lines. ASTERISK-23847 #close Reported by:
  2834. Stephen More ASTERISK-23825 #close Reported by: Stephen More
  2835. ASTERISK-23909 #close Reported by: Stephen More Review:
  2836. https://reviewboard.asterisk.org/r/3870/ ........ Merged
  2837. revisions 420211 from
  2838. http://svn.asterisk.org/svn/asterisk/branches/12
  2839. 2014-08-06 16:12 +0000 [r420149] George Joseph <george.joseph@fairview5.com>
  2840. * /, pbx/pbx_lua.c, main/pbx.c: pbx_lua: fix regression with global
  2841. sym export and context clash by pbx_config. ASTERISK-23818 (lua
  2842. contexts being overwritten by contexts of the same name in
  2843. pbx_config) surfaced because pbx_lua, having the
  2844. AST_MODFLAG_GLOBAL_SYMBOLS set, was always force loaded before
  2845. pbx_config. Since I couldn't find any reason for pbx_lua to
  2846. export it's symbols to the rest of Asterisk, I simply changed the
  2847. flag to AST_MODFLAG_DEFAULT. Problem solved. What I didn't
  2848. realize was that the symbols need to be exported not because
  2849. Asterisk needs them but because any external Lua modules like
  2850. luasql.mysql need the base Lua language APIs exported
  2851. (ASTERISK-17279). Back to ASTERISK-23818... It looks like there's
  2852. an issue in pbx.c where context_merge was only merging includes,
  2853. switches and ignore patterns if the context was already existing
  2854. AND has extensions, or if the context was brand new. If pbx_lua
  2855. is loaded before pbx_config, the context will exist BUT pbx_lua,
  2856. being implemented as a switch, will never place extensions in it,
  2857. just the switch statement. The result is that when pbx_config
  2858. loads, it never merges the switch statement created by pbx_lua
  2859. into the final context. This patch sets pbx_lua's modflag back to
  2860. AST_MODFLAG_GLOBAL_SYMBOLS and adds an "else if" in context_merge
  2861. that catches the case where an existing context has includes,
  2862. switchs or ingore patterns but no actual extensions.
  2863. ASTERISK-23818 #close Reported by: Dennis Guse Reported by: Timo
  2864. Teräs Tested by: George Joseph Review:
  2865. https://reviewboard.asterisk.org/r/3891/ ........ Merged
  2866. revisions 420146 from
  2867. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  2868. revisions 420147 from
  2869. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2870. revisions 420148 from
  2871. http://svn.asterisk.org/svn/asterisk/branches/12
  2872. 2014-08-06 15:32 +0000 [r420144] Walter Doekes <walter+asterisk@wjd.nu>
  2873. * funcs/func_channel.c: Add documentation to the ability to
  2874. retrieve the source port of a SIP call. (belongs with r419970)
  2875. ASTERISK-24040 #close Patches: func_channel.c.diff uploaded by
  2876. dtryba Review: https://reviewboard.asterisk.org/r/3781/
  2877. 2014-08-06 12:55 +0000 [r420124] Kinsey Moore <kmoore@digium.com>
  2878. * configs/samples/stasis.conf.sample (added), main/named_acl.c,
  2879. apps/app_queue.c, main/stasis_bridges.c, main/loader.c,
  2880. main/stasis.c, apps/app_forkcdr.c, main/stasis_message.c,
  2881. funcs/func_cdr.c, res/res_corosync.c, res/res_stun_monitor.c,
  2882. res/res_stasis_test.c, res/res_stasis.c, apps/app_chanspy.c,
  2883. main/stasis_cache.c, main/pickup.c, main/security_events.c,
  2884. include/asterisk/stasis.h, main/devicestate.c, main/core_local.c,
  2885. res/res_stasis_snoop.c, main/endpoints.c, main/presencestate.c,
  2886. main/cdr.c, main/channel.c, main/stasis_system.c, main/manager.c,
  2887. main/test.c, main/file.c, main/app.c, pbx/pbx_realtime.c,
  2888. main/stasis_channels.c, tests/test_stasis.c,
  2889. res/parking/parking_manager.c, main/stasis_endpoints.c,
  2890. main/rtp_engine.c, main/ccss.c, main/bridge.c,
  2891. tests/test_stasis_channels.c: Stasis: Allow message types to be
  2892. blocked This introduces stasis.conf and a mechanism to prevent
  2893. certain message types from being published. Internally, this
  2894. works by preventing the chosen message types from being created
  2895. which ensures that those message types can never be published.
  2896. This patch also adjusts message publishers such that message
  2897. payloads are not created if the related message type is not
  2898. available. ASTERISK-23943 #close Review:
  2899. https://reviewboard.asterisk.org/r/3823/
  2900. 2014-08-05 21:48 +0000 [r420098-420100] Matthew Jordan <mjordan@digium.com>
  2901. * res/stasis/messaging.c, /: stasis: Fix compilation issue with ao2
  2902. tagged objects ........ Merged revisions 420099 from
  2903. http://svn.asterisk.org/svn/asterisk/branches/12
  2904. * res/ari/resource_endpoints.c, rest-api/api-docs/events.json, /,
  2905. channels/chan_sip.c, res/stasis/app.c, res/stasis/messaging.h
  2906. (added), res/ari/resource_endpoints.h, res/res_pjsip_messaging.c,
  2907. tests/test_message.c (added), res/res_xmpp.c,
  2908. include/asterisk/json.h, CHANGES, include/asterisk/manager.h,
  2909. res/ari/ari_model_validators.c, res/ari/ari_model_validators.h,
  2910. main/json.c, res/res_ari_endpoints.c, include/asterisk/message.h,
  2911. res/ari/resource_channels.c, main/message.c, res/res_stasis.c,
  2912. res/stasis/messaging.c (added), rest-api/api-docs/endpoints.json:
  2913. Multiple revisions 420089-420090,420097 ........ r420089 |
  2914. mjordan | 2014-08-05 15:10:52 -0500 (Tue, 05 Aug 2014) | 72 lines
  2915. ARI: Add channel technology agnostic out of call text messaging
  2916. This patch adds the ability to send and receive text messages
  2917. from various technology stacks in Asterisk through ARI. This
  2918. includes chan_sip (sip), res_pjsip_messaging (pjsip), and
  2919. res_xmpp (xmpp). Messages are sent using the endpoints resource,
  2920. and can be sent directly through that resource, or to a
  2921. particular endpoint. For example, the following would send the
  2922. message "Hello there" to PJSIP endpoint alice with a display URI
  2923. of sip:asterisk@mycooldomain.org:
  2924. ari/endpoints/sendMessage?to=pjsip:alice&from=sip:asterisk@mycooldomain.org&body=Hello+There
  2925. This is equivalent to the following as well:
  2926. ari/endpoints/PJSIP/alice/sendMessage?from=sip:asterisk@mycooldomain.org&body=Hello+There
  2927. Both forms are available for message technologies that allow for
  2928. arbitrary destinations, such as chan_sip. Inbound messages can
  2929. now be received over ARI as well. An ARI application that
  2930. subscribes to endpoints will receive messages from those
  2931. endpoints: { "type": "TextMessageReceived", "timestamp":
  2932. "2014-07-12T22:53:13.494-0500", "endpoint": { "technology":
  2933. "PJSIP", "resource": "alice", "state": "online", "channel_ids":
  2934. [] }, "message": { "from": "\"alice\" <sip:alice@127.0.0.1>",
  2935. "to": "pjsip:asterisk@127.0.0.1", "body": "Watson, come here.",
  2936. "variables": [] }, "application": "testsuite" } The above was
  2937. made possible due to some rather major changes in the message
  2938. core. This includes (but is not limited to): - Users of the
  2939. message API can now register message handlers. A handler has two
  2940. callbacks: one to determine if the handler has a destination for
  2941. the message, and another to handle it. - All dialplan
  2942. functionality of handling a message was moved into a message
  2943. handler provided by the message API. - Messages can now have the
  2944. technology/endpoint associated with them. Various other
  2945. properties are also now more easily accessible. - A number of ao2
  2946. containers that weren't really needed were replaced with vectors.
  2947. Iteration over ao2_containers is expensive and pointless when the
  2948. lifetime of things is well defined and the number of things is
  2949. very small. res_stasis now has a new file that makes up its
  2950. structure, messaging. The messaging functionality implements a
  2951. message handler, and passes received messages that match an
  2952. interested endpoint over to the app for processing. Note that
  2953. inadvertently while testing this, I reproduced ASTERISK-23969.
  2954. res_pjsip_messaging was incorrectly parsing out the 'to' field,
  2955. such that arbitrary SIP URIs mangled the endpoint lookup. This
  2956. patch includes the fix for that as well. Review:
  2957. https://reviewboard.asterisk.org/r/3726 ASTERISK-23692 #close
  2958. Reported by: Matt Jordan ASTERISK-23969 #close Reported by:
  2959. Andrew Nagy ........ r420090 | mjordan | 2014-08-05 15:16:37
  2960. -0500 (Tue, 05 Aug 2014) | 2 lines Remove automerge properties
  2961. :-( ........ r420097 | mjordan | 2014-08-05 16:36:25 -0500 (Tue,
  2962. 05 Aug 2014) | 2 lines test_message: Fix strict-aliasing
  2963. compilation issue ........ Merged revisions 420089-420090,420097
  2964. from http://svn.asterisk.org/svn/asterisk/branches/12
  2965. 2014-08-05 13:59 +0000 [r420028] Jonathan Rose <jrose@digium.com>
  2966. * main/format.c: chan_iax2: Fix a crash that occurs when using
  2967. allow=all for an IAX2 peer Or any combination of codecs that
  2968. includes Opus. ASTERISK-24107 #close Review:
  2969. https://reviewboard.asterisk.org/r/3885/
  2970. 2014-08-04 21:00 +0000 [r420007] Richard Mudgett <rmudgett@digium.com>
  2971. * main/format_cache.c, include/asterisk/format_cache.h: Remove
  2972. duplicate definitions of ast_format_vp8.
  2973. 2014-08-04 20:25 +0000 [r419970] Mark Michelson <mmichelson@digium.com>
  2974. * channels/sip/dialplan_functions.c: Add the ability to retrieve
  2975. the source port of a SIP call. This adds the ability to call
  2976. CHANNEL(recvport) on chan_sip channels to see the port on which
  2977. an INVITE was received. ASTERISK-24040 #close Reported by dtryba
  2978. Patches: dialplan_functions.patch uploaded by dtryba (License
  2979. #6628) Review: https://reviewboard.asterisk.org/r/3781
  2980. 2014-08-04 19:47 +0000 [r419945] Rusty Newton <rnewton@digium.com>
  2981. * main/manager.c, /: Manager - Improve documentation for manager
  2982. commands Getvar and Setvar. The documentation for these commands
  2983. did not make it clear that they could accept expressions and
  2984. functions. Modified to make this clear, but tried not to be
  2985. overly explicit. ASTERISK-21178 #close Reported by: Rusty Newton
  2986. Tested by: Rusty Newton Review:
  2987. https://reviewboard.asterisk.org/r/3854 ........ Merged revisions
  2988. 419942 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  2989. ........ Merged revisions 419943 from
  2990. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  2991. revisions 419944 from
  2992. http://svn.asterisk.org/svn/asterisk/branches/12
  2993. 2014-08-02 03:37 +0000 [r419914] Kinsey Moore <kmoore@digium.com>
  2994. * res/res_pjsip.c: Manager: Add PJSIPShowEndpoint[s] documentation
  2995. This adds a large swath of response documentation for
  2996. PJSIPShowEndpoint and PJSIPShowEndpoints AMI commands. It relies
  2997. heavily on the existing text in the configInfo documentation via
  2998. xi:include tags to avoid documentation duplication. Review:
  2999. https://reviewboard.asterisk.org/r/3888/
  3000. 2014-08-01 14:48 +0000 [r419888] Mark Michelson <mmichelson@digium.com>
  3001. * CHANGES, res/res_pjsip/pjsip_options.c: Add ContactStatusDetail
  3002. to PJSIPShowEndpoint AMI output. Now when running
  3003. PJSIPShowEndpoint, you will receive a ContactStatusDetail for
  3004. each bound contact that Asterisk is qualifying. This information
  3005. includes the URI of the contact, current reachability, and
  3006. roundtrip time. AFS-91 #close Reported by Mark Michelson Review:
  3007. https://reviewboard.asterisk.org/r/3797
  3008. 2014-07-31 16:19 +0000 [r419851] Jonathan Rose <jrose@digium.com>
  3009. * CHANGES, res/res_pjsip_notify.c: PJSIP: Send Notify AMI and CLI
  3010. commands can now send to URI instead of endpoint Review:
  3011. https://reviewboard.asterisk.org/r/3817/
  3012. 2014-07-31 11:57 +0000 [r419822-419825] Matthew Jordan <mjordan@digium.com>
  3013. * main/rtp_engine.c, /, res/res_hep_rtcp.c (added), CHANGES,
  3014. channels/chan_pjsip.c, res/res_rtp_asterisk.c: res_hep_rtcp: Add
  3015. module that sends RTCP information to a Homer Server This patch
  3016. adds a new module to Asterisk, res_hep_rtcp. The module
  3017. subscribes to the RTCP topics in Stasis and receives RTCP
  3018. information back from the message bus. It encodes into HEPv3
  3019. packets and sends the information to the res_hep module for
  3020. transmission. Using this, someone with a Homer server can get
  3021. live call quality monitoring for all RTP-based channels in their
  3022. Asterisk 12+ systems. In addition, there were a few bugs in the
  3023. RTP engine, res_rtp_asterisk, and chan_pjsip that were uncovered
  3024. by the tests written for the Asterisk Test Suite. This patch
  3025. fixes the following: 1) chan_pjsip failed to set its channel
  3026. unique ids on its RTP instance on outbound calls. It now does
  3027. this in the appropriate location, in the serialized call
  3028. callback. 2) The rtp_engine was overflowing some values when
  3029. packed into JSON. Specifically, some longs and unsigned ints
  3030. can't be be packed into integer values, for obvious reasons.
  3031. Since libjansson only supports integers, floats, strings,
  3032. booleans, and objects, we print these values into strings. 3)
  3033. res_rtp_asterisk had a few problems: (a) it would emit a source
  3034. IP address of 0.0.0.0 if bound to that IP address. We now use
  3035. ast_find_ourip to get a better IP address, and properly marshal
  3036. the result into an ast_strdupa'd string. (b) Reports can be
  3037. generated with no report bodies. In particular, this occurs when
  3038. a sender is transmitting information to a receiver (who will send
  3039. no RTP back to the sender). As such, the sender has no report
  3040. body for what it received. We now properly handle this case, and
  3041. the sender will emit SR reports with no body. Likewise, if we
  3042. receive an RTCP packet with no report body, we will still
  3043. generate the appropriate events. ASTERISK-24119 #close ........
  3044. Merged revisions 419823 from
  3045. http://svn.asterisk.org/svn/asterisk/branches/12
  3046. * funcs/func_jitterbuffer.c, doc/appdocsxml.dtd, main/xmldoc.c:
  3047. xmldocs: Add support for an <example> tag in the Asterisk XML
  3048. Documentation This patch adds support for an <example /> tag in
  3049. the XML documentation schema. For CLI help, this doesn't change
  3050. the formatting too much: - Preceeding white space is removed -
  3051. Unlike with para elements, new lines are preserved However,
  3052. having an <example /> tag in the XML schema allows for the wiki
  3053. documentation generation script to surround the documentation
  3054. with {code} or {noformat} tags, generating much better content
  3055. for the wiki - and allowing us to put dialplan examples (and
  3056. other code snippets, if desired) into the documentation for an
  3057. application/function/AMI command/etc. Review:
  3058. https://reviewboard.asterisk.org/r/3807/
  3059. 2014-07-30 18:32 +0000 [r419806] Kinsey Moore <kmoore@digium.com>
  3060. * main/manager.c, res/res_manager_presencestate.c,
  3061. res/res_manager_devicestate.c, main/pbx.c: manager: Add state
  3062. list commands This patch adds three new AMI commands: *
  3063. ExtensionStateList (pbx.c) - list all known extension state hints
  3064. and their current statuses. Events emitted by the list action are
  3065. equivalent to the ExtensionStatus events. * PresenceStateList
  3066. (res_manager_presencestate) - list all known presence state
  3067. values. Events emitted are generated by the stasis message type,
  3068. and hence are PresenceStateChange events. * DeviceStateList
  3069. (res_manager_devicestate) - list all known device state values.
  3070. Events emitted are generated by the stasis message type, and
  3071. hence are DeviceStateChange events. Patch-by: Matt Jordan Review:
  3072. https://reviewboard.asterisk.org/r/3799/
  3073. 2014-07-29 19:41 +0000 [r419789] Mark Michelson <mmichelson@digium.com>
  3074. * main/manager.c: Do not omit the first header of a UserEvent AMI
  3075. action from the corresponding emitted UserEvent. ASTERISK-24124
  3076. #close Reported by Matt Jordan AFS-131 #close Reported by Matt
  3077. Jordan Patches: userevent.patch uploaded by Matt Jordan (License
  3078. #6283)
  3079. 2014-07-29 10:56 +0000 [r419751-419766] Joshua Colp <jcolp@digium.com>
  3080. * res/res_pjsip_session.c, /: res_pjsip_session: Fix race condition
  3081. where redirecting information may not be set. Since the PJSIP
  3082. INVITE session module is invoked before any session supplements
  3083. it was possible for it to handle a redirect before the
  3084. res_pjsip_diversion module interpreted and set redirecting
  3085. information on the channel. This would cause the redirecting
  3086. information to get lost. This patch ensures that session
  3087. supplements are *always* invoked before a redirect occurs by
  3088. explicitly calling them in the redirect handler. Review:
  3089. https://reviewboard.asterisk.org/r/3850/ ........ Merged
  3090. revisions 419764 from
  3091. http://svn.asterisk.org/svn/asterisk/branches/12
  3092. * /, res/res_pjsip_xpidf_body_generator.c,
  3093. res/res_pjsip_pidf_body_generator.c:
  3094. res_pjsip_pidf_body_generator / res_pjsip_xpidf_body_generator:
  3095. Ensure local entity is unquoted. The local entity as provided by
  3096. PJSIP is quoted within '<' and '>'. As a result placing this
  3097. value into XML will result in malformed XML being produced. This
  3098. patch now unquotes the local entity so it can go safely into the
  3099. XML. Review: https://reviewboard.asterisk.org/r/3851/ ........
  3100. Merged revisions 419750 from
  3101. http://svn.asterisk.org/svn/asterisk/branches/12
  3102. 2014-07-28 18:58 +0000 [r419688] Richard Mudgett <rmudgett@digium.com>
  3103. * apps/app_speech_utils.c, main/channel.c, /,
  3104. funcs/func_frame_trace.c, main/abstract_jb.c: datastores: Audit
  3105. ast_channel_datastore_remove usage. Audit of v1.8 usage of
  3106. ast_channel_datastore_remove() for datastore memory leaks. *
  3107. Fixed leaks in app_speech_utils and func_frame_trace. * Fixed
  3108. app_speech_utils not locking the channel when accessing the
  3109. channel datastore list. Review:
  3110. https://reviewboard.asterisk.org/r/3859/ Audit of v11 usage of
  3111. ast_channel_datastore_remove() for datastore memory leaks. *
  3112. Fixed leak in func_jitterbuffer. (Was not in v12) Review:
  3113. https://reviewboard.asterisk.org/r/3860/ Audit of v12 usage of
  3114. ast_channel_datastore_remove() for datastore memory leaks. *
  3115. Fixed leaks in abstract_jb. * Fixed leak in
  3116. ast_channel_unsuppress(). Used by ARI mute control and
  3117. res_mutestream. * Fixed ref leak in ast_channel_suppress(). Used
  3118. by ARI mute control and res_mutestream. Review:
  3119. https://reviewboard.asterisk.org/r/3861/ ........ Merged
  3120. revisions 419684 from
  3121. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3122. revisions 419685 from
  3123. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  3124. revisions 419686 from
  3125. http://svn.asterisk.org/svn/asterisk/branches/12
  3126. 2014-07-25 18:09 +0000 [r419612] Joshua Colp <jcolp@digium.com>
  3127. * main/loader.c: loader: Fix an infinite loop when printing modules
  3128. using "module show". When creating the alphabetical sorted list
  3129. each module is added to a list temporarily. On the second
  3130. iteration each module already has a pointer to another module,
  3131. causing stuff to go into a loop. ASTERISK-24123 #close Reported
  3132. by: Malcolm Davenport
  3133. 2014-07-25 16:47 +0000 [r419592] Mark Michelson <mmichelson@digium.com>
  3134. * res/res_ari_sounds.c, res/res_stasis.c, res/res_fax_spandsp.c,
  3135. res/res_timing_kqueue.c, res/res_odbc.c,
  3136. res/res_pjsip_transport_websocket.c, apps/app_voicemail.c,
  3137. res/res_calendar.c, channels/chan_unistim.c, cel/cel_radius.c,
  3138. channels/chan_multicast_rtp.c, res/res_pjsip_notify.c,
  3139. res/res_snmp.c, formats/format_sln.c, apps/app_meetme.c,
  3140. apps/app_dictate.c, codecs/codec_gsm.c, res/res_stasis_snoop.c,
  3141. res/res_musiconhold.c, res/res_format_attr_h264.c,
  3142. res/res_http_websocket.c, apps/app_followme.c,
  3143. res/res_config_sqlite.c, formats/format_siren7.c, cdr/cdr_csv.c,
  3144. formats/format_ilbc.c, channels/chan_phone.c,
  3145. apps/app_setcallerid.c, apps/app_osplookup.c, cel/cel_custom.c,
  3146. apps/app_mp3.c, res/res_agi.c, channels/chan_motif.c,
  3147. res/res_timing_timerfd.c, apps/app_confbridge.c,
  3148. res/res_format_attr_silk.c, formats/format_siren14.c,
  3149. res/res_sorcery_realtime.c, channels/chan_mgcp.c,
  3150. apps/app_jack.c, codecs/codec_lpc10.c,
  3151. res/res_pjsip_pidf_body_generator.c, res/res_config_pgsql.c,
  3152. funcs/func_dialplan.c, apps/app_nbscat.c, cdr/cdr_syslog.c,
  3153. res/res_pjsip_authenticator_digest.c, apps/app_festival.c,
  3154. res/res_fax.c, apps/app_waitforsilence.c, res/res_adsi.c,
  3155. res/res_crypto.c, res/res_ari_applications.c,
  3156. res/res_hep_pjsip.c, pbx/pbx_lua.c, res/res_pjsip_messaging.c,
  3157. res/res_pjsip_caller_id.c, channels/chan_console.c,
  3158. apps/app_getcpeid.c, res/res_stasis_answer.c,
  3159. channels/chan_oss.c, res/res_pjsip_nat.c,
  3160. res/res_pjsip_session.c, cdr/cdr_tds.c,
  3161. res/res_pjsip_header_funcs.c, res/res_parking.c,
  3162. formats/format_vox.c, res/res_pjsip_rfc3326.c,
  3163. res/res_ari_endpoints.c, res/res_stun_monitor.c,
  3164. res/res_pjsip_mwi.c, res/res_stasis_recording.c,
  3165. res/res_pjsip_xpidf_body_generator.c, apps/app_sms.c,
  3166. codecs/codec_ulaw.c, channels/chan_nbs.c, apps/app_stack.c,
  3167. channels/chan_pjsip.c, formats/format_g729.c, cel/cel_pgsql.c,
  3168. res/res_sorcery_config.c, res/res_ari.c, addons/chan_ooh323.c,
  3169. cdr/cdr_sqlite3_custom.c, codecs/codec_adpcm.c,
  3170. res/res_ari_asterisk.c, res/res_calendar_caldav.c,
  3171. apps/app_image.c, apps/app_ices.c, formats/format_wav_gsm.c,
  3172. main/cli.c, res/res_format_attr_celt.c, res/res_rtp_multicast.c,
  3173. channels/chan_dahdi.c, funcs/func_pitchshift.c, res/res_smdi.c,
  3174. res/res_pjsip_one_touch_record_info.c, pbx/pbx_ael.c,
  3175. pbx/pbx_realtime.c, apps/app_amd.c, channels/chan_alsa.c,
  3176. formats/format_h263.c, apps/app_url.c, res/res_pjsip_acl.c,
  3177. apps/app_externalivr.c, res/res_curl.c, formats/format_gsm.c,
  3178. res/res_speech.c, cdr/cdr_manager.c, res/res_calendar_exchange.c,
  3179. codecs/codec_g722.c, res/res_pjsip_multihomed.c,
  3180. res/res_ari_mailboxes.c, cel/cel_tds.c, res/res_sorcery_memory.c,
  3181. apps/app_fax.c, codecs/codec_speex.c, res/res_pjsip_sdp_rtp.c,
  3182. codecs/codec_g726.c, formats/format_ogg_vorbis.c,
  3183. apps/app_talkdetect.c, res/res_ari_channels.c,
  3184. res/res_pjsip_exten_state.c, apps/app_speech_utils.c,
  3185. apps/app_agent_pool.c, apps/app_waitforring.c, res/res_statsd.c,
  3186. addons/cdr_mysql.c, formats/format_g726.c, res/res_ari_bridges.c,
  3187. addons/app_mysql.c, res/res_stasis_playback.c,
  3188. addons/format_mp3.c, res/res_pjsip_endpoint_identifier_ip.c,
  3189. res/res_phoneprov.c, res/res_pjsip_t38.c,
  3190. res/res_pjsip_registrar_expire.c, cdr/cdr_pgsql.c,
  3191. cdr/cdr_radius.c, res/res_chan_stats.c,
  3192. res/res_format_attr_opus.c, res/res_config_odbc.c,
  3193. funcs/func_audiohookinherit.c,
  3194. res/res_pjsip_outbound_registration.c, cel/cel_manager.c,
  3195. funcs/func_odbc.c, res/res_pjsip_endpoint_identifier_anonymous.c,
  3196. funcs/func_frame_trace.c, funcs/func_aes.c, cdr/cdr_sqlite.c,
  3197. apps/app_minivm.c, res/res_pjsip_log_forwarder.c,
  3198. formats/format_h264.c, res/res_config_ldap.c, apps/app_ivrdemo.c,
  3199. addons/chan_mobile.c, apps/app_stasis.c,
  3200. res/res_pjsip_diversion.c, cdr/cdr_custom.c, apps/app_adsiprog.c,
  3201. res/res_pjsip_dtmf_info.c, res/res_rtp_asterisk.c,
  3202. res/res_calendar_icalendar.c, res/res_hep.c, channels/chan_sip.c,
  3203. channels/chan_bridge_media.c, codecs/codec_alaw.c,
  3204. apps/app_queue.c, res/res_srtp.c, funcs/func_presencestate.c,
  3205. res/res_timing_pthread.c, res/res_manager_presencestate.c,
  3206. res/res_corosync.c, apps/app_celgenuserevent.c,
  3207. cel/cel_sqlite3_custom.c, res/snmp/agent.c, pbx/pbx_dundi.c,
  3208. formats/format_g723.c, funcs/func_devstate.c,
  3209. res/res_pjsip_registrar.c,
  3210. res/res_pjsip_pidf_eyebeam_body_supplement.c,
  3211. addons/res_config_mysql.c,
  3212. res/res_pjsip_pidf_digium_body_supplement.c, apps/app_test.c,
  3213. res/res_timing_dahdi.c, cdr/cdr_adaptive_odbc.c,
  3214. apps/app_alarmreceiver.c, apps/app_chanisavail.c,
  3215. res/res_format_attr_h263.c, res/res_pjsip_mwi_body_generator.c,
  3216. res/res_xmpp.c, res/res_http_post.c, channels/chan_iax2.c,
  3217. res/res_pjsip_endpoint_identifier_user.c, res/res_pjsip.c,
  3218. res/res_pktccops.c, res/res_pjsip_send_to_voicemail.c,
  3219. main/loader.c, cel/cel_odbc.c, res/res_ari_model.c,
  3220. channels/chan_skinny.c,
  3221. res/res_pjsip_outbound_authenticator_digest.c,
  3222. res/res_mwi_external.c, apps/app_skel.c, formats/format_pcm.c,
  3223. include/asterisk/module.h, res/res_pjsip_path.c,
  3224. res/res_ari_playbacks.c, res/res_pjsip_pubsub.c, cdr/cdr_odbc.c,
  3225. funcs/func_periodic_hook.c, res/res_stasis_test.c,
  3226. formats/format_jpeg.c, res/res_pjsip_refer.c,
  3227. formats/format_g719.c, res/res_clialiases.c,
  3228. res/res_config_sqlite3.c, res/res_ari_device_states.c,
  3229. formats/format_wav.c, apps/app_saycounted.c, apps/app_dahdiras.c,
  3230. apps/app_morsecode.c, res/res_stasis_mailbox.c,
  3231. res/res_ael_share.c, res/res_mwi_external_ami.c,
  3232. res/res_pjsip_logger.c, res/res_stasis_device_state.c,
  3233. res/res_calendar_ews.c, res/res_monitor.c, apps/app_playback.c,
  3234. res/res_ari_recordings.c, res/res_manager_devicestate.c,
  3235. res/res_config_curl.c, channels/chan_misdn.c, funcs/func_curl.c,
  3236. res/res_ari_events.c, res/res_pjsip_dialog_info_body_generator.c,
  3237. res/res_sorcery_astdb.c, codecs/codec_dahdi.c,
  3238. apps/app_zapateller.c, pbx/pbx_config.c: Add module support level
  3239. to ast_module_info structure. Print it in CLI "module show" .
  3240. ASTERISK-23919 #close Reported by Malcolm Davenport Review:
  3241. https://reviewboard.asterisk.org/r/3802
  3242. 2014-07-25 14:47 +0000 [r419563-419567] Matthew Jordan <mjordan@digium.com>
  3243. * CHANGES, res/ari/ari_model_validators.c,
  3244. rest-api/api-docs/recordings.json,
  3245. res/ari/ari_model_validators.h, /, res/res_stasis_recording.c:
  3246. Multiple revisions 419565-419566 ........ r419565 | mjordan |
  3247. 2014-07-25 09:41:23 -0500 (Fri, 25 Jul 2014) | 21 lines ARI:
  3248. report duration values in LiveRecording objects This patch adds
  3249. three new fields to the LiveRecording model: - total_duration:
  3250. the total length of the live recording - talking_duration:
  3251. optional. The duration of talking energy that was detected while
  3252. the recording was made. - silence_duration: optional. The
  3253. duration of silence that was detected while the recording was
  3254. made. These values are reported in the RecordingFinished ARI
  3255. event. When a DSP is enabled on the channel during the recording
  3256. - which occurs when the recording is created with
  3257. max_silence_seconds (indicating that the user actually cares
  3258. about how much silence is in the file), we will report the
  3259. talking_duration and silence_duration in addition to the
  3260. total_duration. Review: https://reviewboard.asterisk.org/r/3770/
  3261. ASTERISK-24037 #close Reported by: Samuel Galarneau ........
  3262. r419566 | mjordan | 2014-07-25 09:46:15 -0500 (Fri, 25 Jul 2014)
  3263. | 1 line Update CHANGES for r419565 ........ Merged revisions
  3264. 419565-419566 from
  3265. http://svn.asterisk.org/svn/asterisk/branches/12
  3266. * main/loader.c, res/res_calendar.c: module loader: Unload modules
  3267. in reverse order of their start order When Asterisk starts a
  3268. module (calling its load_module function), it re-orders the
  3269. module list, sorting it alphabetically. Ostensibly, this was done
  3270. so that the output of 'module show' listed modules in alphabetic
  3271. order. This had the unfortunate side effect of making modules
  3272. with complex usage patterns unloadable. A module that has a large
  3273. number of modules that depend on it is typically abandoned during
  3274. the unloading process. This results in its memory not being
  3275. reclaimed during exit. Generally, this isn't harmful - when the
  3276. process is destroyed, the operating system will reclaim all
  3277. memory allocated by the process. Prior to Asterisk 12, we also
  3278. didn't have many modules with complex dependencies. However, with
  3279. the advent of ARI and PJSIP, this can make make unloading those
  3280. modules successfully nearly impossible, and thus tracking memory
  3281. leaks or ref debug leaks a real pain. While this patch is not a
  3282. complete overhaul of the module loader - such an effort would be
  3283. beyond the scope of what could be done for Asterisk 13 - this
  3284. does make some marginal improvements to the loader such that
  3285. modules like res_pjsip or res_stasis *may* be made properly
  3286. un-loadable in the future. 1. The linked list of modules has been
  3287. replaced with a doubly linked list. This allows traversal of the
  3288. module list to occur backwards. The module shutdown routine now
  3289. walks the global list backwards when it attempts to unload
  3290. modules. 2. The alphabetic reorganization of the module list on
  3291. startup has been removed. Instead, a started module is placed at
  3292. the end of the module list. 3. The ast_update_module_list
  3293. function - which is used by the CLI to display the modules - now
  3294. does the sorting alphabetically itself. It creates its own linked
  3295. list and inserts the modules into it in alphabetic order. This
  3296. allows for the intent of the previous code to be maintained. This
  3297. patch also contains a fix for res_calendar. Without
  3298. calendar.conf, the calendar modules were improperly bumping the
  3299. use count of res_calendar, then failing to load themselves. This
  3300. patch makes it so that we detect whether or not calendaring is
  3301. enabled before altering the use count. Review:
  3302. https://reviewboard.asterisk.org/r/3777/
  3303. 2014-07-25 10:54 +0000 [r419537-419539] Joshua Colp <jcolp@digium.com>
  3304. * apps/app_bridgewait.c, /: app_bridgewait: Remove possibility of
  3305. race condition between channels leaving/joining. Bridges created
  3306. by app_bridgewait previously had the "dissolve when empty" flag
  3307. set. This caused the bridge core to destroy them when the last
  3308. channel had left. This introduced a race condition where we may
  3309. have a reference to the bridge but it is not actually joinable
  3310. when we try to join it. This flag has now been removed and the
  3311. bridge is guaranteed to be joinable at all times. ASTERISK-23987
  3312. #close Reported by: Matt Jordan Review:
  3313. https://reviewboard.asterisk.org/r/3836/ ........ Merged
  3314. revisions 419538 from
  3315. http://svn.asterisk.org/svn/asterisk/branches/12
  3316. * /, main/bridge.c: bridge: Make "bridge destroy" only available in
  3317. developer mode and add "all" to "bridge kick". The "bridge
  3318. destroy" CLI command is invasive to bridges and can leave them in
  3319. an unexpected state for the users of them. Since this command may
  3320. be useful for developers it is now only available when developer
  3321. mode is available. To take its place "all" has been added as a
  3322. valid option to the "bridge kick" CLI command. It will kick all
  3323. of the channels in the bridge out. ASTERISK-23987 Reported by:
  3324. Matt Jordan Review: https://reviewboard.asterisk.org/r/3840/
  3325. ........ Merged revisions 419536 from
  3326. http://svn.asterisk.org/svn/asterisk/branches/12
  3327. 2014-07-24 22:48 +0000 [r419520] Richard Mudgett <rmudgett@digium.com>
  3328. * main/bridge.c, main/bridge_basic.c, main/core_unreal.c,
  3329. UPGRADE.txt, include/asterisk/channel.h, CHANGES,
  3330. apps/app_followme.c, apps/app_queue.c, main/cel.c,
  3331. res/parking/parking_bridge_features.c, apps/app_dial.c,
  3332. main/channel.c, main/dial.c, main/pbx.c: accountcode: Slightly
  3333. change accountcode propagation. The previous behavior was to
  3334. simply set the accountcode of an outgoing channel to the
  3335. accountcode of the channel initiating the call. It was done this
  3336. way a long time ago to allow the accountcode set on the SIP/100
  3337. channel to be propagated to a local channel so the dialplan
  3338. execution on the Local;2 channel would have the SIP/100
  3339. accountcode available. SIP/100 -> Local;1/Local;2 -> SIP/200
  3340. Propagating the SIP/100 accountcode to the local channels is very
  3341. useful. Without any dialplan manipulation, all channels in this
  3342. call would have the same accountcode. Using dialplan, you can set
  3343. a different accountcode on the SIP/200 channel either by setting
  3344. the accountcode on the Local;2 channel or by the Dial
  3345. application's b(pre-dial), M(macro) or U(gosub) options, or by
  3346. the FollowMe application's b(pre-dial) option, or by the Queue
  3347. application's macro or gosub options. Before Asterisk v12, the
  3348. altered accountcode on SIP/200 will remain until the local
  3349. channels optimize out and the accountcode would change to the
  3350. SIP/100 accountcode. Asterisk v1.8 attempted to add peeraccount
  3351. support but ultimately had to punt on the support. The
  3352. peeraccount support was rendered useless because of how the CDR
  3353. code needed to unconditionally force the caller's accountcode
  3354. onto the peer channel's accountcode. The CEL events were thus
  3355. intentionally made to always use the channel's accountcode as the
  3356. peeraccount value. With the arrival of Asterisk v12, the
  3357. situation has improved somewhat so peeraccount support can be
  3358. made to work. Using the indicated example, the the accountcode
  3359. values become as follows when the peeraccount is set on SIP/100
  3360. before calling SIP/200: SIP/100 ---> Local;1 ---- Local;2 --->
  3361. SIP/200 acct: 100 \/ acct: 200 \/ acct: 100 \/ acct: 200 peer:
  3362. 200 /\ peer: 100 /\ peer: 200 /\ peer: 100 If a channel already
  3363. has an accountcode it can only change by the following explicit
  3364. user actions: 1) A channel originate method that can specify an
  3365. accountcode to use. 2) The calling channel propagating its
  3366. non-empty peeraccount or its non-empty accountcode if the
  3367. peeraccount was empty to the outgoing channel's accountcode
  3368. before initiating the dial. e.g., Dial and FollowMe. The
  3369. exception to this propagation method is Queue. Queue will only
  3370. propagate peeraccounts this way only if the outgoing channel does
  3371. not have an accountcode. 3) Dialplan using CHANNEL(accountcode).
  3372. 4) Dialplan using CHANNEL(peeraccount) on the other end of a
  3373. local channel pair. If a channel does not have an accountcode it
  3374. can get one from the following places: 1) The channel driver's
  3375. configuration at channel creation. 2) Explicit user action as
  3376. already indicated. 3) Entering a basic or stasis-mixing bridge
  3377. from a peer channel's peeraccount value. You can specify the
  3378. accountcode for an outgoing channel by setting the
  3379. CHANNEL(peeraccount) before using the Dial, FollowMe, and Queue
  3380. applications. Queue adds the wrinkle that it will not overwrite
  3381. an existing accountcode on the outgoing channel with the calling
  3382. channels values. Accountcode and peeraccount values propagate to
  3383. an outgoing channel before dialing. Accountcodes also propagate
  3384. when channels enter or leave a basic or stasis-mixing bridge. The
  3385. peeraccount value only makes sense for mixing bridges with two
  3386. channels; it is meaningless otherwise. * Made peeraccount
  3387. functional by changing accountcode propagation as described
  3388. above. * Fixed CEL extracting the wrong ie value for the
  3389. peeraccount. This was done intentionally in Asterisk v1.8 when
  3390. that version had to punt on peeraccount. * Fixed a few places
  3391. dealing with accountcodes that were reading from channels without
  3392. the lock held. AFS-65 #close Review:
  3393. https://reviewboard.asterisk.org/r/3601/
  3394. 2014-07-24 21:01 +0000 [r419504] Michael L. Young <elgueromexicano@gmail.com>
  3395. * main/db.c, include/asterisk/astdb.h: core/db: Revert Patch Added
  3396. In Attempt To Improve I/O Performance Reverting the patch since
  3397. it was causing a regression and after fixing the regression,
  3398. there were no performance gains. At least based on my method for
  3399. measurement. ASTERISK-24050 Review:
  3400. https://reviewboard.asterisk.org/r/3841/
  3401. 2014-07-24 17:50 +0000 [r419438-419439] Corey Farrell <git@cfware.com>
  3402. * include/asterisk/astobj.h: Deprecate astobj.h This flags astobj.h
  3403. as deprecated, warns people to use astobj2.h instead. Only
  3404. netsock.c (also deprecated) still uses astobj.h. ASTERISK-24069
  3405. #close Reported by: Corey Farrell Review:
  3406. https://reviewboard.asterisk.org/r/3818/
  3407. * channels/sip/include/sip.h, channels/chan_sip.c: chan_sip:
  3408. complete upgrade to ao2 This change upgrades sip_registry and
  3409. sip_subscription_mwi to astobj2. ASTERISK-24067 #close Reported
  3410. by: Corey Farrell Review:
  3411. https://reviewboard.asterisk.org/r/3759/
  3412. 2014-07-24 16:52 +0000 [r419377] Jason Parker <jparker@digium.com>
  3413. * addons/chan_ooh323.c, /: Don't cause Asterisk to exit if
  3414. ooh323.conf not found. (closes issue ASTERISK-23814) ........
  3415. Merged revisions 419374 from
  3416. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3417. revisions 419375 from
  3418. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  3419. revisions 419376 from
  3420. http://svn.asterisk.org/svn/asterisk/branches/12
  3421. 2014-07-24 15:20 +0000 [r419358] Matthew Jordan <mjordan@digium.com>
  3422. * main/devicestate.c, channels/chan_pjsip.c: device state: Update
  3423. the core to report ONHOLD if a channel is on hold In Asterisk, it
  3424. is possible for a device to have a status of ONHOLD. This is not
  3425. typically an easy thing to determine, as a channel being on hold
  3426. is not a direct channel state. Typically, this has to be
  3427. calculated outside of the core independently in channel drivers,
  3428. notably, chan_sip and chan_pjsip. Both of these channel drivers
  3429. already have to calculate device state in a fashion more complex
  3430. than the core can handle, as they aggregate all state of all
  3431. channels associated with a peer/endpoint; they also independently
  3432. track whether or not one of those channels is currently on hold
  3433. and mark the device state appropriately. In 12+, we now have the
  3434. ability to report an AST_DEVICE_ONHOLD state for all channels
  3435. that defer their device state to the core. This is due to channel
  3436. hold state actually now being tracked on the channel itself. If a
  3437. channel driver defers its device state to the core (which many,
  3438. such as DAHDI, IAX2, and others do in most situations), the
  3439. device state core already goes out to get a channel associated
  3440. with the device. As such, it can now also factor the channel hold
  3441. state in its calculation. This patch adds this logic to the
  3442. device state core. It also uses an existing mapping between
  3443. device state and channel state to handle more channel states.
  3444. chan_pjsip has been updated slightly as well to make use of this
  3445. (as it was, for some reason, reporting a channel state of BUSY as
  3446. a device state of INUSE, which feels slightly wrong). Review:
  3447. https://reviewboard.asterisk.org/r/3771/ ASTERISK-24038 #close
  3448. 2014-07-24 13:00 +0000 [r419342] Kinsey Moore <kmoore@digium.com>
  3449. * include/asterisk/manager.h, doc/appdocsxml.dtd, main/xmldoc.c,
  3450. main/manager_bridges.c, main/manager.c,
  3451. include/asterisk/xmldoc.h, main/config_options.c: AMI: Allow for
  3452. command response documentation Allow for responses to AMI
  3453. actions/commands to be documented properly in XML and displayed
  3454. via the CLI. Response events are documented exactly as standard
  3455. AMI events are documented. Review:
  3456. https://reviewboard.asterisk.org/r/3812/
  3457. 2014-07-23 16:46 +0000 [r419319] Matthew Jordan <mjordan@digium.com>
  3458. * main/endpoints.c, tests/test_stasis_endpoints.c, /: endpoints:
  3459. Fix failing unit tests from r419196 This patch does two things:
  3460. (1) It updates the unit tests to expect additional stasis
  3461. messages. More messages are now sent to the endpoint topic, due
  3462. to forwarding all channel messages and the forwarding
  3463. relationship set up between endpoints themselves. (2) Remove the
  3464. technology forwarding subscription during ast_endpoint_shutdown.
  3465. This prevents an improper double shutdown of an endpoint from
  3466. occurring. ........ Merged revisions 419318 from
  3467. http://svn.asterisk.org/svn/asterisk/branches/12
  3468. 2014-07-23 14:00 +0000 [r419286] Scott Griepentrog <sgriepentrog@digium.com>
  3469. * apps/app_voicemail.c, /: app_voicemail: use a consistent
  3470. generator string When updating voicemail.conf when a user changes
  3471. their pin, change the generator string to be the same as the
  3472. module name when reading so that the same config_hook will be
  3473. called. Review: https://reviewboard.asterisk.org/r/3837/ ........
  3474. Merged revisions 419284 from
  3475. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  3476. revisions 419285 from
  3477. http://svn.asterisk.org/svn/asterisk/branches/12
  3478. 2014-07-23 01:28 +0000 [r419268] Corey Farrell <git@cfware.com>
  3479. * main/manager.c, res/res_fax.c: res_fax: unregister manager
  3480. actions on unload * Unregister manager actions FAXSessions,
  3481. FAXSession and FAXStats at unload. * Update ast_manager_register2
  3482. use ao2_t_alloc tagged with the action name. ASTERISK-24058
  3483. #close Reported by: Corey Farrell Review:
  3484. https://reviewboard.asterisk.org/r/3831/
  3485. 2014-07-22 20:22 +0000 [r419222-419252] Michael L. Young <elgueromexicano@gmail.com>
  3486. * CHANGES, main/bridge_channel.c: core/bridge_channel: Substitute
  3487. Variables In Features Application Map Say you wanted to include
  3488. variables in an application map and have those variables
  3489. substituted and passed along to the application being executed;
  3490. currently this does not happen. This patch adds this ability to
  3491. pass channel variable values to an application before being
  3492. executed. ASTERISK-22608 #close Reported by: Michael L. Young
  3493. patches: features_substitute_arguments_v2.diff uploaded by
  3494. Michael L. Young (license 5026) Review:
  3495. https://reviewboard.asterisk.org/r/3819/
  3496. * CHANGES, apps/app_mixmonitor.c: apps/app_mixmonitor: Add Options
  3497. To Play Beep At Start Or Stop We have a new periodic beep feature
  3498. but sometimes a user needs some sort of feedback, without the
  3499. need to have a periodic beep during the recording, to let them
  3500. know that MixMonitor started recording or ended the recording.
  3501. The use case where this patch is being used is when using Dynamic
  3502. Features to start and end MixMonitor. This patch adds an option
  3503. to play a beep when MixMonitor starts and an option to play a
  3504. beep when MixMonitor ends. ASTERISK-24051 #close Reported by:
  3505. Michael L. Young patches: mixmonitor-play-beep-start-stop.diff
  3506. uploaded by Michael L. Young (license 5026) Review:
  3507. https://reviewboard.asterisk.org/r/3820/
  3508. * main/db.c, include/asterisk/astdb.h: core/db: Improve I/O When
  3509. Updating Rows When updating a row, we are currently doing an
  3510. INSERT OR REPLACE INTO. The downside to this is that the row is
  3511. deleted if it exists and then a new row is inserted. So, we are
  3512. hitting the disk twice. One for the deletion and one for the
  3513. insertion. This patch changes this statement to an INSERT INTO
  3514. and if the insert fails because a row with that key exists, we
  3515. will IGNORE the failure. Then we will attempt to perform an
  3516. UPDATE on the existing row if that row wasn't just INSERTed.
  3517. ASTERISK-24050 #close Reported by: Michael L. Young patches:
  3518. astdb-insert-update-io-help_trunk_v2.diff uploaded by Michael L.
  3519. Young (license 5026) Review:
  3520. https://reviewboard.asterisk.org/r/3815/
  3521. 2014-07-22 17:10 +0000 [r419206] Richard Mudgett <rmudgett@digium.com>
  3522. * codecs/codec_speex.c: codec_speex: Fix trashing normal static
  3523. frame for AST_FRAME_CNG. Made use a local static frame to
  3524. generate the AST_FRAME_CNG frame when silence starts. I don't
  3525. think the handling of the AST_FRAME_CNG has ever really worked
  3526. because there doesn't seem to be any consumers of it. Review:
  3527. https://reviewboard.asterisk.org/r/3813/
  3528. 2014-07-22 16:20 +0000 [r419203] Matthew Jordan <mjordan@digium.com>
  3529. * include/asterisk/endpoints.h,
  3530. rest-api/api-docs/applications.json, include/asterisk/xmpp.h,
  3531. main/channel_internal_api.c, channels/chan_motif.c,
  3532. include/asterisk/channel.h, res/ari/resource_applications.h,
  3533. res/res_xmpp.c, channels/chan_iax2.c, main/endpoints.c,
  3534. channels/chan_pjsip.c, main/channel.c,
  3535. res/ari/resource_endpoints.c, /, channels/chan_sip.c: ARI: Fix
  3536. endpoint/channel subscription issues; allow for subscriptions to
  3537. tech This patch serves two purposes: (1) It fixes some bugs with
  3538. endpoint subscriptions not reporting all of the channel events
  3539. (2) It serves as the preliminary work needed for ASTERISK-23692,
  3540. which allows for sending/receiving arbitrary out of call text
  3541. messages through ARI in a technology agnostic fashion. The
  3542. messaging functionality described on ASTERISK-23692 requires two
  3543. things: (1) The ability to send/receive messages associated with
  3544. an endpoint. This is relatively straight forwards with the
  3545. endpoint core in Asterisk now. (2) The ability to send/receive
  3546. messages associated with a technology and an arbitrary technology
  3547. defined URI. This is less straight forward, as endpoints are
  3548. formed from a tech + resource pair. We don't have a mechanism to
  3549. note that a technology that *may* have endpoints exists. This
  3550. patch provides such a mechanism, and fixes a few bugs along the
  3551. way. The first major bug this patch fixes is the forwarding of
  3552. channel messages to their respective endpoints. Prior to this
  3553. patch, there were two problems: (1) Channel caching messages
  3554. weren't forwarded. Thus, the endpoints missed most of the
  3555. interesting bits (such as channel creation, destruction, state
  3556. changes, etc.) (2) Channels weren't associated with their
  3557. endpoint until after creation. This resulted in endpoints missing
  3558. the channel creation message, which limited the usefulness of the
  3559. subscription in the first place (a major use case being 'tell me
  3560. when this endpoint has a channel'). Unfortunately, this meant
  3561. another parameter to ast_channel_alloc. Since not all channel
  3562. technologies support an ast_endpoint, this patch makes such a
  3563. call optional and opts for a new function,
  3564. ast_channel_alloc_with_endpoint. When endpoints are created, they
  3565. will implicitly create a technology endpoint for their technology
  3566. (if one does not already exist). A technology endpoint is special
  3567. in that it has no state, cannot have channels created for it,
  3568. cannot be created explicitly, and cannot be destroyed except on
  3569. shutdown. It does, however, have all messages from other
  3570. endpoints in its technology forwarded to it. Combined with the
  3571. bug fixes, we now have Stasis messages being properly forwarded.
  3572. Consider the following scenario: two PJSIP endpoints (foo and
  3573. bar), where bar has a single channel associated with it and foo
  3574. has two channels associated with it. The messages would be
  3575. forwarded as follows: channel PJSIP/foo-1 -- \ --> endpoint
  3576. PJSIP/foo -- / \ channel PJSIP/foo-2 -- \ ---- > endpoint PJSIP /
  3577. channel PJSIP/bar-1 -----> endpoint PJSIP/bar -- ARI, through the
  3578. applications resource, can: - subscribe to endpoint:PJSIP/foo and
  3579. get notifications for channels PJSIP/foo-1,PJSIP/foo-2 and
  3580. endpoint PJSIP/foo - subscribe to endpoint:PJSIP/bar and get
  3581. notifications for channels PJSIP/bar-1 and endpoint PJSIP/bar -
  3582. subscribe to endpoint:PJSIP and get notifications for channels
  3583. PJSIP/foo-1,PJSIP/foo-2,PJSIP/bar-1 and endpoints
  3584. PJSIP/foo,PJSIP/bar Note that since endpoint PJSIP never changes,
  3585. it never has events itself. It merely provides an aggregation
  3586. point for all other endpoints in its technology (which in turn
  3587. aggregate all channel messages associated with that endpoint).
  3588. This patch also adds endpoints to res_xmpp and chan_motif,
  3589. because the actual messaging work will need it (messaging without
  3590. XMPP is just sad). Review:
  3591. https://reviewboard.asterisk.org/r/3760/ ASTERISK-23692 ........
  3592. Merged revisions 419196 from
  3593. http://svn.asterisk.org/svn/asterisk/branches/12
  3594. 2014-07-22 14:36 +0000 [r419180] Joshua Colp <jcolp@digium.com>
  3595. * channels/chan_iax2.c: chan_iax2: Restore previous behavior of
  3596. iax2_best_codec. The iax2_best_codec function was changed to
  3597. convert the formats into a format compatibilities structure and
  3598. grab the first format from it. The resulting order differs from
  3599. the previous order of iax2_best_codec which causes unexpected
  3600. formats to get chosen (such as g723). This commit brings back the
  3601. old behavior of iax2_best_codec by having a specified preference
  3602. list. Review: https://reviewboard.asterisk.org/r/3835/
  3603. 2014-07-22 14:22 +0000 [r419110-419175] Kinsey Moore <kmoore@digium.com>
  3604. * addons/ooh323c/src/printHandler.c, tests/test_sorcery_realtime.c,
  3605. tests/test_json.c, addons/ooh323c/src/ooq931.c,
  3606. tests/test_astobj2_thrash.c, addons/chan_ooh323.c, /,
  3607. tests/test_optional_api.c, tests/test_abstract_jb.c,
  3608. apps/app_meetme.c, tests/test_logger.c, tests/test_event.c,
  3609. tests/test_hashtab_thrash.c, res/res_mwi_external_ami.c,
  3610. tests/test_sorcery.c, res/res_corosync.c,
  3611. tests/test_voicemail_api.c, tests/test_aoc.c,
  3612. tests/test_astobj2.c, tests/test_config.c: Fix more dev-mode
  3613. build issues ........ Merged revisions 419129 from
  3614. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  3615. revisions 419162 from
  3616. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  3617. revisions 419163 from
  3618. http://svn.asterisk.org/svn/asterisk/branches/12
  3619. * main/dial.c: Dial API: Prevent crash on NULL cap This prevents a
  3620. crash in the Dial API triggered by use of the Page() application
  3621. where a format capability struct was used before checking whether
  3622. it was NULL. ASTERISK-24074 #close
  3623. * channels/chan_skinny.c, tests/test_core_format.c: Fix build in
  3624. dev-mode
  3625. 2014-07-21 16:26 +0000 [r419109] Jonathan Rose <jrose@digium.com>
  3626. * channels/chan_iax2.c: chan_iax2: Restore codec choice behavior
  3627. from media formats branch After merging the media formats branch,
  3628. chan_iax2 was discarding codec preferences for the purpose of
  3629. choosing which codec a channel would use once a call started.
  3630. This patch restores the Asterisk 1.8-12 codec choice behaviors.
  3631. ASTERISK-23958 #close Review:
  3632. https://reviewboard.asterisk.org/r/3800/
  3633. 2014-07-21 16:09 +0000 [r419093] Joshua Colp <jcolp@digium.com>
  3634. * channels/chan_iax2.c: chan_iax2: Only send mini frames if the
  3635. underlying format has not changed, not if it has. ASTERISK-24072
  3636. #close Reported by: Matt Jordan
  3637. 2014-07-21 14:49 +0000 [r419077] Sean Bright <sean@malleable.com>
  3638. * configure, configure.ac: Fix build when pjproject is installed in
  3639. a non-standard location. When configuring Asterisk to build
  3640. against a version of pjproject installed in a non-standard
  3641. location, the checks for "PJSIP Transaction Group Lock Support"
  3642. and "PJSIP Media Stream Replacement Support" fail. This is
  3643. because these secondary checks are not taking the CFLAGS and LIBS
  3644. returned by the pkg-config check into account. Review:
  3645. https://reviewboard.asterisk.org/r/3830
  3646. 2014-07-21 08:41 +0000 [r419060] Corey Farrell <git@cfware.com>
  3647. * channels/sig_analog.c, res/res_smdi.c, channels/chan_motif.c,
  3648. include/asterisk/smdi.h, apps/app_voicemail.c,
  3649. channels/chan_dahdi.c: res_smdi: convert to astobj2 Remove
  3650. functions: ast_smdi_interface_unref ast_smdi_md_message_putback
  3651. ast_smdi_mwi_message_putback ast_smdi_md_message destructor
  3652. ast_smdi_mwi_message destructor Includes for astobj.h are removed
  3653. everywhere it's possible. ASTERISK-24066 #close Review:
  3654. https://reviewboard.asterisk.org/r/3758/
  3655. 2014-07-20 22:06 +0000 [r419044] Matthew Jordan <mjordan@digium.com>
  3656. * apps/app_confbridge.c, res/ari/resource_channels.c,
  3657. include/asterisk/rtp_engine.h, include/asterisk/slinfactory.h,
  3658. res/res_calendar.c, codecs/codec_g722.c,
  3659. include/asterisk/res_pjsip_session.h, main/frame.c,
  3660. codecs/ex_lpc10.h, apps/app_dictate.c, res/res_fax.c,
  3661. apps/app_echo.c, include/asterisk/slin.h, codecs/codec_g726.c,
  3662. formats/format_ogg_vorbis.c, codecs/codec_gsm.c,
  3663. codecs/ex_alaw.h, formats/format_wav_gsm.c,
  3664. channels/iax2/provision.c, channels/chan_iax2.c,
  3665. res/res_format_attr_h264.c, main/data.c, main/manager.c,
  3666. include/asterisk/audiohook.h, formats/format_pcm.c,
  3667. main/config_options.c, res/res_format_attr_silk.c,
  3668. main/bridge_channel.c, res/res_speech.c, channels/chan_pjsip.c,
  3669. res/res_clioriginate.c, formats/format_g729.c,
  3670. channels/chan_unistim.c, res/res_rtp_asterisk.c,
  3671. include/asterisk/smoother.h (added), main/rtp_engine.c,
  3672. addons/format_mp3.c, formats/format_wav.c,
  3673. apps/confbridge/conf_chan_record.c, include/asterisk/speech.h,
  3674. codecs/ex_adpcm.h, channels/iax2/codec_pref.c (added),
  3675. include/asterisk/codec.h (added), formats/format_siren7.c,
  3676. include/asterisk/file.h, channels/chan_dahdi.c,
  3677. include/asterisk/image.h, funcs/func_channel.c,
  3678. main/abstract_jb.c, formats/format_h263.c, codecs/codec_dahdi.c,
  3679. main/dsp.c, apps/app_voicemail.c, apps/app_jack.c,
  3680. funcs/func_talkdetect.c, channels/chan_vpb.cc,
  3681. channels/chan_sip.c, formats/format_sln.c,
  3682. tests/test_abstract_jb.c, codecs/codec_alaw.c, UPGRADE.txt,
  3683. main/smoother.c (added), codecs/ex_speex.h,
  3684. channels/chan_console.c, apps/app_talkdetect.c,
  3685. main/format_pref.c (removed), main/indications.c,
  3686. include/asterisk/format_cap.h, main/media_index.c,
  3687. apps/app_agent_pool.c, res/res_pjsip_session.c, main/cli.c,
  3688. res/res_format_attr_celt.c, channels/chan_skinny.c,
  3689. tests/test_core_format.c (added), funcs/func_frame_trace.c,
  3690. res/res_pjsip/pjsip_configuration.c, main/file.c,
  3691. include/asterisk/frame.h, formats/format_g726.c,
  3692. apps/app_mixmonitor.c, channels/chan_mgcp.c, main/sorcery.c,
  3693. codecs/ex_ilbc.h, codecs/codec_lpc10.c, tests/test_format_cache.c
  3694. (added), apps/app_meetme.c, main/translate.c,
  3695. apps/app_originate.c, res/parking/parking_applications.c,
  3696. apps/app_ices.c, channels/iax2/parser.c, res/res_rtp_multicast.c,
  3697. pbx/pbx_spool.c, funcs/func_pitchshift.c, formats/format_vox.c,
  3698. main/format_cap.c, tests/test_cel.c, include/asterisk/format.h,
  3699. formats/format_h264.c, apps/app_chanspy.c, apps/app_nbscat.c,
  3700. addons/chan_ooh323.c, bridges/bridge_holding.c,
  3701. channels/iax2/include/codec_pref.h (added), codecs/codec_adpcm.c,
  3702. apps/app_waitforsilence.c, res/res_pjsip_sdp_rtp.c,
  3703. addons/chan_ooh323.h, bridges/bridge_simple.c,
  3704. apps/app_alarmreceiver.c, bridges/bridge_softmix.c,
  3705. res/res_stasis_snoop.c, main/sounds_index.c, main/core_local.c,
  3706. main/codec_builtin.c (added), include/asterisk/format_cache.h
  3707. (added), apps/app_speech_utils.c, res/res_format_attr_opus.c,
  3708. include/asterisk/abstract_jb.h, main/channel.c,
  3709. include/asterisk/format_compatibility.h (added), apps/app_mp3.c,
  3710. tests/test_voicemail_api.c, channels/chan_alsa.c, main/app.c,
  3711. formats/format_g723.c, codecs/codec_ilbc.c, tests/test_config.c,
  3712. formats/format_gsm.c, apps/app_milliwatt.c, codecs/ex_ulaw.h,
  3713. main/asterisk.c, include/asterisk/res_pjsip.h, main/format.c,
  3714. main/ccss.c, main/bridge.c, codecs/codec_speex.c,
  3715. include/asterisk/format_pref.h (removed), apps/app_record.c,
  3716. main/slinfactory.c, res/res_adsi.c, main/core_unreal.c,
  3717. res/ari/resource_bridges.c, include/asterisk/callerid.h,
  3718. channels/pjsip/dialplan_functions.c, main/dial.c,
  3719. channels/dahdi/bridge_native_dahdi.c, main/format_cache.c
  3720. (added), include/asterisk/mod_format.h, apps/app_sms.c,
  3721. codecs/codec_resample.c, main/format_compatibility.c (added),
  3722. main/audiohook.c, formats/format_jpeg.c, res/res_stasis.c,
  3723. formats/format_g719.c, include/asterisk/translate.h,
  3724. funcs/func_speex.c, codecs/codec_a_mu.c,
  3725. channels/iax2/format_compatibility.c (added),
  3726. apps/app_festival.c, main/channel_internal_api.c,
  3727. tests/test_format_api.c (removed), codecs/ex_g722.h,
  3728. main/utils.c, res/ari/resource_sounds.c,
  3729. res/res_format_attr_h263.c, codecs/ex_g726.h,
  3730. include/asterisk/_private.h, channels/chan_oss.c,
  3731. channels/chan_misdn.c, main/codec.c (added), main/callerid.c,
  3732. addons/ooh323cDriver.c, apps/app_amd.c, codecs/codec_ulaw.c,
  3733. main/image.c, channels/chan_nbs.c, bridges/bridge_native_rtp.c,
  3734. channels/iax2/include/format_compatibility.h (added),
  3735. formats/format_siren14.c, res/res_fax_spandsp.c,
  3736. addons/chan_mobile.c, addons/ooh323cDriver.h,
  3737. channels/sip/include/sip.h, tests/test_format_cap.c (added),
  3738. channels/chan_multicast_rtp.c, include/asterisk/vector.h,
  3739. channels/chan_bridge_media.c, apps/app_fax.c,
  3740. main/bridge_basic.c, apps/app_test.c, include/asterisk/channel.h,
  3741. include/asterisk/data.h, tests/test_core_codec.c (added),
  3742. res/res_musiconhold.c, codecs/ex_gsm.h, formats/format_ilbc.c,
  3743. include/asterisk/config_options.h, channels/chan_phone.c,
  3744. include/asterisk/bridge_channel.h, apps/app_dumpchan.c,
  3745. channels/chan_motif.c, res/res_agi.c: media formats: re-architect
  3746. handling of media for performance improvements In the old times
  3747. media formats were represented using a bit field. This was fast
  3748. but had a few limitations. 1. Asterisk was limited in how many
  3749. formats it could handle. 2. Formats, being a bit field, could not
  3750. include any attribute information. A format was strictly its
  3751. type, e.g., "this is ulaw". This was changed in Asterisk 10 (see
  3752. https://wiki.asterisk.org/wiki/display/AST/Media+Architecture+Proposal
  3753. for notes on that work) which led to the creation of the
  3754. ast_format structure. This structure allowed Asterisk to handle
  3755. attributes and bundle information with a format. Additionally,
  3756. ast_format_cap was created to act as a container for multiple
  3757. formats that, together, formed the capability of some entity.
  3758. Another mechanism was added to allow logic to be registered which
  3759. performed format attribute negotiation. Everywhere throughout the
  3760. codebase Asterisk was changed to use this strategy.
  3761. Unfortunately, in software, there is no free lunch. These new
  3762. capabilities came at a cost. Performance analysis and profiling
  3763. showed that we spend an inordinate amount of time comparing,
  3764. copying, and generally manipulating formats and their related
  3765. structures. Basic prototyping has shown that a reasonably large
  3766. performance improvement could be made in this area. This patch is
  3767. the result of that project, which overhauled the media format
  3768. architecture and its usage in Asterisk to improve performance.
  3769. Generally, the new philosophy for handling formats is as follows:
  3770. * The ast_format structure is reference counted. This removed a
  3771. large amount of the memory allocations and copying that was done
  3772. in prior versions. * In order to prevent race conditions while
  3773. keeping things performant, the ast_format structure is immutable
  3774. by convention and lock-free. Violate this tenet at your peril! *
  3775. Because formats are reference counted, codecs are also reference
  3776. counted. The Asterisk core generally provides built-in codecs and
  3777. caches the ast_format structures created to represent them.
  3778. Generally, to prevent inordinate amounts of module reference
  3779. bumping, codecs and formats can be added at run-time but cannot
  3780. be removed. * All compatibility with the bit field representation
  3781. of codecs/formats has been moved to a compatibility API. The
  3782. primary user of this representation is chan_iax2, which must
  3783. continue to maintain its bit-field usage of formats for
  3784. interoperability concerns. * When a format is negotiated with
  3785. attributes, or when a format cannot be represented by one of the
  3786. cached formats, a new format object is created or cloned from an
  3787. existing format. That format may have the same codec underlying
  3788. it, but is a different format than a version of the format with
  3789. different attributes or without attributes. * While formats are
  3790. reference counted objects, the reference count maintained on the
  3791. format should be manipulated with care. Formats are generally
  3792. cached and will persist for the lifetime of Asterisk and do not
  3793. explicitly need to have their lifetime modified. An exception to
  3794. this is when the user of a format does not know where the format
  3795. came from *and* the user may outlive the provider of the format.
  3796. This occurs, for example, when a format is read from a channel:
  3797. the channel may have a format with attributes (hence, non-cached)
  3798. and the user of the format may last longer than the channel (if
  3799. the reference to the channel is released prior to the format's
  3800. reference). For more information on this work, see the API design
  3801. notes:
  3802. https://wiki.asterisk.org/wiki/display/AST/Media+Format+Rewrite
  3803. Finally, this work was the culmination of a large number of
  3804. developer's efforts. Extra thanks goes to Corey Farrell, who took
  3805. on a large amount of the work in the Asterisk core, chan_sip, and
  3806. was an invaluable resource in peer reviews throughout this
  3807. project. There were a substantial number of patches contributed
  3808. during this work; the following issues/patch names simply reflect
  3809. some of the work (and will cause the release scripts to give
  3810. attribution to the individuals who work on them). Reviews:
  3811. https://reviewboard.asterisk.org/r/3814
  3812. https://reviewboard.asterisk.org/r/3808
  3813. https://reviewboard.asterisk.org/r/3805
  3814. https://reviewboard.asterisk.org/r/3803
  3815. https://reviewboard.asterisk.org/r/3801
  3816. https://reviewboard.asterisk.org/r/3798
  3817. https://reviewboard.asterisk.org/r/3800
  3818. https://reviewboard.asterisk.org/r/3794
  3819. https://reviewboard.asterisk.org/r/3793
  3820. https://reviewboard.asterisk.org/r/3792
  3821. https://reviewboard.asterisk.org/r/3791
  3822. https://reviewboard.asterisk.org/r/3790
  3823. https://reviewboard.asterisk.org/r/3789
  3824. https://reviewboard.asterisk.org/r/3788
  3825. https://reviewboard.asterisk.org/r/3787
  3826. https://reviewboard.asterisk.org/r/3786
  3827. https://reviewboard.asterisk.org/r/3784
  3828. https://reviewboard.asterisk.org/r/3783
  3829. https://reviewboard.asterisk.org/r/3778
  3830. https://reviewboard.asterisk.org/r/3774
  3831. https://reviewboard.asterisk.org/r/3775
  3832. https://reviewboard.asterisk.org/r/3772
  3833. https://reviewboard.asterisk.org/r/3761
  3834. https://reviewboard.asterisk.org/r/3754
  3835. https://reviewboard.asterisk.org/r/3753
  3836. https://reviewboard.asterisk.org/r/3751
  3837. https://reviewboard.asterisk.org/r/3750
  3838. https://reviewboard.asterisk.org/r/3748
  3839. https://reviewboard.asterisk.org/r/3747
  3840. https://reviewboard.asterisk.org/r/3746
  3841. https://reviewboard.asterisk.org/r/3742
  3842. https://reviewboard.asterisk.org/r/3740
  3843. https://reviewboard.asterisk.org/r/3739
  3844. https://reviewboard.asterisk.org/r/3738
  3845. https://reviewboard.asterisk.org/r/3737
  3846. https://reviewboard.asterisk.org/r/3736
  3847. https://reviewboard.asterisk.org/r/3734
  3848. https://reviewboard.asterisk.org/r/3722
  3849. https://reviewboard.asterisk.org/r/3713
  3850. https://reviewboard.asterisk.org/r/3703
  3851. https://reviewboard.asterisk.org/r/3689
  3852. https://reviewboard.asterisk.org/r/3687
  3853. https://reviewboard.asterisk.org/r/3674
  3854. https://reviewboard.asterisk.org/r/3671
  3855. https://reviewboard.asterisk.org/r/3667
  3856. https://reviewboard.asterisk.org/r/3665
  3857. https://reviewboard.asterisk.org/r/3625
  3858. https://reviewboard.asterisk.org/r/3602
  3859. https://reviewboard.asterisk.org/r/3519
  3860. https://reviewboard.asterisk.org/r/3518
  3861. https://reviewboard.asterisk.org/r/3516
  3862. https://reviewboard.asterisk.org/r/3515
  3863. https://reviewboard.asterisk.org/r/3512
  3864. https://reviewboard.asterisk.org/r/3506
  3865. https://reviewboard.asterisk.org/r/3413
  3866. https://reviewboard.asterisk.org/r/3410
  3867. https://reviewboard.asterisk.org/r/3387
  3868. https://reviewboard.asterisk.org/r/3388
  3869. https://reviewboard.asterisk.org/r/3389
  3870. https://reviewboard.asterisk.org/r/3390
  3871. https://reviewboard.asterisk.org/r/3321
  3872. https://reviewboard.asterisk.org/r/3320
  3873. https://reviewboard.asterisk.org/r/3319
  3874. https://reviewboard.asterisk.org/r/3318
  3875. https://reviewboard.asterisk.org/r/3266
  3876. https://reviewboard.asterisk.org/r/3265
  3877. https://reviewboard.asterisk.org/r/3234
  3878. https://reviewboard.asterisk.org/r/3178 ASTERISK-23114 #close
  3879. Reported by: mjordan media_formats_translation_core.diff uploaded
  3880. by kharwell (License 6464) rb3506.diff uploaded by mjordan
  3881. (License 6283) media_format_app_file.diff uploaded by kharwell
  3882. (License 6464) misc-2.diff uploaded by file (License 5000)
  3883. chan_mild-3.diff uploaded by file (License 5000)
  3884. chan_obscure.diff uploaded by file (License 5000) jingle.diff
  3885. uploaded by file (License 5000) funcs.diff uploaded by file
  3886. (License 5000) formats.diff uploaded by file (License 5000)
  3887. core.diff uploaded by file (License 5000) bridges.diff uploaded
  3888. by file (License 5000) mf-codecs-2.diff uploaded by file (License
  3889. 5000) mf-app_fax.diff uploaded by file (License 5000)
  3890. mf-apps-3.diff uploaded by file (License 5000)
  3891. media-formats-3.diff uploaded by file (License 5000)
  3892. ASTERISK-23715 rb3713.patch uploaded by coreyfarrell (License
  3893. 5909) rb3689.patch uploaded by mjordan (License 6283)
  3894. ASTERISK-23957 rb3722.patch uploaded by mjordan (License 6283)
  3895. mf-attributes-3.diff uploaded by file (License 5000)
  3896. ASTERISK-23958 Tested by: jrose rb3822.patch uploaded by
  3897. coreyfarrell (License 5909) rb3800.patch uploaded by jrose
  3898. (License 6182) chan_sip.diff uploaded by mjordan (License 6283)
  3899. rb3747.patch uploaded by jrose (License 6182) ASTERISK-23959
  3900. #close Tested by: sgriepentrog, mjordan, coreyfarrell
  3901. sip_cleanup.diff uploaded by opticron (License 6273)
  3902. chan_sip_caps.diff uploaded by mjordan (License 6283)
  3903. rb3751.patch uploaded by coreyfarrell (License 5909)
  3904. chan_sip-3.diff uploaded by file (License 5000) ASTERISK-23960
  3905. #close Tested by: opticron direct_media.diff uploaded by opticron
  3906. (License 6273) pjsip-direct-media.diff uploaded by file (License
  3907. 5000) format_cap_remove.diff uploaded by opticron (License 6273)
  3908. media_format_fixes.diff uploaded by opticron (License 6273)
  3909. chan_pjsip-2.diff uploaded by file (License 5000) ASTERISK-23966
  3910. #close Tested by: rmudgett rb3803.patch uploaded by rmudgetti
  3911. (License 5621) chan_dahdi.diff uploaded by file (License 5000)
  3912. ASTERISK-24064 #close Tested by: coreyfarrell, mjordan, opticron,
  3913. file, rmudgett, sgriepentrog, jrose rb3814.patch uploaded by
  3914. rmudgett (License 5621) moh_cleanup.diff uploaded by opticron
  3915. (License 6273) bridge_leak.diff uploaded by opticron (License
  3916. 6273) translate.diff uploaded by file (License 5000) rb3795.patch
  3917. uploaded by rmudgett (License 5621) tls_fix.diff uploaded by
  3918. mjordan (License 6283) fax-mf-fix-2.diff uploaded by file
  3919. (License 5000) rtp_transfer_stuff uploaded by mjordan (License
  3920. 6283) rb3787.patch uploaded by rmudgett (License 5621)
  3921. media-formats-explicit-translate-format-3.diff uploaded by file
  3922. (License 5000) format_cache_case_fix.diff uploaded by opticron
  3923. (License 6273) rb3774.patch uploaded by rmudgett (License 5621)
  3924. rb3775.patch uploaded by rmudgett (License 5621)
  3925. rtp_engine_fix.diff uploaded by opticron (License 6273)
  3926. rtp_crash_fix.diff uploaded by opticron (License 6273)
  3927. rb3753.patch uploaded by mjordan (License 6283) rb3750.patch
  3928. uploaded by mjordan (License 6283) rb3748.patch uploaded by
  3929. rmudgett (License 5621) media_format_fixes.diff uploaded by
  3930. opticron (License 6273) rb3740.patch uploaded by mjordan (License
  3931. 6283) rb3739.patch uploaded by mjordan (License 6283)
  3932. rb3734.patch uploaded by mjordan (License 6283) rb3689.patch
  3933. uploaded by mjordan (License 6283) rb3674.patch uploaded by
  3934. coreyfarrell (License 5909) rb3671.patch uploaded by coreyfarrell
  3935. (License 5909) rb3667.patch uploaded by coreyfarrell (License
  3936. 5909) rb3665.patch uploaded by mjordan (License 6283)
  3937. rb3625.patch uploaded by coreyfarrell (License 5909) rb3602.patch
  3938. uploaded by coreyfarrell (License 5909)
  3939. format_compatibility-2.diff uploaded by file (License 5000)
  3940. core.diff uploaded by file (License 5000)
  3941. 2014-07-18 21:48 +0000 [r419022] Matthew Jordan <mjordan@digium.com>
  3942. * rest-api/api-docs/recordings.json, res/ari/resource_recordings.c,
  3943. res/stasis_recording/stored.c, res/res_ari_recordings.c, /,
  3944. include/asterisk/stasis_app_recording.h,
  3945. res/ari/resource_recordings.h, CHANGES: ari: Add a copy operation
  3946. for stored recordings This patch adds a new operation for stored
  3947. recordings, copy. It takes an existing stored recording and makes
  3948. a copy of it in the same directory or a relative directory under
  3949. the stored recording directory.
  3950. /ari/recordings/stored/{recordingName}/copy?destinationRecordingName={copy_name}
  3951. This is particularly useful for voicemail-esque applications,
  3952. which may need to copy or move recordings around a directory
  3953. structure. Review: https://reviewboard.asterisk.org/r/3768/
  3954. ASTERISK-24036 #close Reported by: Sam Galarneau Tested by: Sam
  3955. Galarneau ........ Merged revisions 419021 from
  3956. http://svn.asterisk.org/svn/asterisk/branches/12
  3957. 2014-07-18 21:25 +0000 [r418997-419020] Corey Farrell <git@cfware.com>
  3958. * main/stasis_message_router.c, /: stasis: fix call to ao2_t_alloc
  3959. for stasis_message_router_create This fixes a build failure
  3960. introduced by r3821. struct stasis_topic is opaque, so
  3961. topic->name is unavailable. Switch to using stasis_topic_name().
  3962. ........ Merged revisions 419019 from
  3963. http://svn.asterisk.org/svn/asterisk/branches/12
  3964. * main/stasis.c, main/stasis_cache_pattern.c,
  3965. main/stasis_message.c, main/stasis_message_router.c, /: stasis:
  3966. use ao2_t_alloc for certain object allocators Add tags to stasis
  3967. objects using the name. This makes it easier to track the source
  3968. of certain stasis ref leaks. Review:
  3969. https://reviewboard.asterisk.org/r/3821/ ........ Merged
  3970. revisions 418996 from
  3971. http://svn.asterisk.org/svn/asterisk/branches/12
  3972. 2014-07-18 19:07 +0000 [r418980] Kinsey Moore <kmoore@digium.com>
  3973. * res/res_fax_spandsp.c: Fix build in dev-mode
  3974. 2014-07-18 17:55 +0000 [r418961-418963] Scott Griepentrog <sgriepentrog@digium.com>
  3975. * res/res_pjsip_pubsub.c, main/astobj2.c,
  3976. include/asterisk/astobj2.h, main/logger.c, main/utils.c: astobj2:
  3977. assert on invalid ref and backtrace cleanup If a reference count
  3978. goes negative, instead of just logging that fact, be more helpful
  3979. with a backtrace and an assert that will DO_CRASH. This patch
  3980. also removes the duplicate ao2_bt() function and cleans up
  3981. extraneous usage of the ast_log_backtrace() call. Review:
  3982. https://reviewboard.asterisk.org/r/3765/
  3983. * /, channels/chan_sip.c: media formats: fix ref leak of peer for
  3984. mwi subscription Holding a reference to the peer during mwi
  3985. subscriptions resulted in a circular reference because the final
  3986. event message would not be sent until destruction of the peer.
  3987. Instead, pass the name of the peer to the event callback so that
  3988. it can fail gracefully after the peer has gone. ASTERISK-23959
  3989. Review: https://reviewboard.asterisk.org/r/3754/ ........ Merged
  3990. revisions 418636 from
  3991. http://svn.asterisk.org/svn/asterisk/branches/12
  3992. * /, main/features_config.c: feature_config: insure featuregroups
  3993. and applicationmaps are initialized If the features.conf is
  3994. missing, the cfg->featurgroups and cfg->applicationmaps is not
  3995. initialized, resulting in assert on ao2_find of a null container.
  3996. This patch changes the initialization call and adds asserts for a
  3997. safeguard. Review: https://reviewboard.asterisk.org/r/3809/
  3998. ........ Merged revisions 418886 from
  3999. http://svn.asterisk.org/svn/asterisk/branches/12
  4000. 2014-07-18 16:47 +0000 [r418938] Richard Mudgett <rmudgett@digium.com>
  4001. * funcs/func_audiohookinherit.c, /: func_audiohookinherit.c: Fixup
  4002. some XML documentation wording. ........ Merged revisions 418937
  4003. from http://svn.asterisk.org/svn/asterisk/branches/12
  4004. 2014-07-18 16:28 +0000 [r418911-418936] Jonathan Rose <jrose@digium.com>
  4005. * main/channel.c, funcs/func_audiohookinherit.c, /,
  4006. include/asterisk/audiohook.h, main/framehook.c, res/res_fax.c,
  4007. main/bridge_basic.c, include/asterisk/res_fax.h,
  4008. bridges/bridge_native_rtp.c, main/audiohook.c, CHANGES,
  4009. include/asterisk/framehook.h, res/res_pjsip_refer.c: Channels:
  4010. Masquerades to automatically move frame/audio hooks Whenever
  4011. possible, audiohooks and framehooks will now be copied over to
  4012. the channel that the masquerading channel gets cloned into. This
  4013. should occur for all audiohooks and most framehooks. As a result,
  4014. in Asterisk 12.5 and up, the AUDIOHOOK_INHERIT function is now
  4015. deprecated and its behavior is essentially the new default for
  4016. all audiohooks, plus some additional audiohooks/framehooks.
  4017. Review: https://reviewboard.asterisk.org/r/3721/ ........ Merged
  4018. revisions 418914 from
  4019. http://svn.asterisk.org/svn/asterisk/branches/12
  4020. * res/res_fax.c, include/asterisk/res_fax.h, CHANGES,
  4021. res/res_fax.exports.in, res/res_fax_spandsp.c: res_fax: Provide
  4022. AMI equivalents for fax CLI commands Specifically the following
  4023. equivalents were created: fax show session -> FAXSession fax show
  4024. sessions -> FAXSessions fax show stats -> FAXStats Review:
  4025. https://reviewboard.asterisk.org/r/3666/
  4026. 2014-07-18 00:11 +0000 [r418893-418895] Sean Bright <sean@malleable.com>
  4027. * config.sub, menuselect/config.guess, menuselect/config.sub,
  4028. config.guess: Update config.guess and config.sub
  4029. * autoconf/ast_ext_tool_check.m4: Add missing file from previous
  4030. commit.
  4031. * menuselect/aclocal.m4, menuselect/configure,
  4032. menuselect/acinclude.m4 (removed), menuselect/bootstrap.sh,
  4033. menuselect/autoconfig.h.in: Import Asterisk's autoconf magic
  4034. instead of using our own.
  4035. 2014-07-17 21:17 +0000 [r418832-418870] Matthew Jordan <mjordan@digium.com>
  4036. * configs/samples/acl.conf.sample (added),
  4037. configs/samples/extensions.conf.sample (added),
  4038. configs/res_parking.conf.sample (removed),
  4039. configs/samples/cel_sqlite3_custom.conf.sample (added),
  4040. configs/cdr_sqlite3_custom.conf.sample (removed),
  4041. configs/modules.conf.sample (removed),
  4042. configs/samples/cli_aliases.conf.sample (added),
  4043. configs/meetme.conf.sample (removed),
  4044. configs/cdr_pgsql.conf.sample (removed),
  4045. configs/samples/extensions.ael.sample (added),
  4046. configs/samples/cdr_adaptive_odbc.conf.sample (added),
  4047. configs/samples/motif.conf.sample (added),
  4048. configs/samples/extensions_minivm.conf.sample (added),
  4049. configs/samples/res_curl.conf.sample (added),
  4050. configs/res_config_sqlite3.conf.sample (removed),
  4051. configs/mgcp.conf.sample (removed), configs/dsp.conf.sample
  4052. (removed), configs/udptl.conf.sample (removed),
  4053. configs/sip.conf.sample (removed), configs/dbsep.conf.sample
  4054. (removed), configs/queuerules.conf.sample (removed),
  4055. configs/samples/cdr_mysql.conf.sample (added),
  4056. configs/confbridge.conf.sample (removed),
  4057. configs/samples/cdr_odbc.conf.sample (added),
  4058. configs/samples/minivm.conf.sample (added),
  4059. configs/enum.conf.sample (removed),
  4060. configs/samples/codecs.conf.sample (added),
  4061. configs/samples/chan_dahdi.conf.sample (added),
  4062. configs/samples/cdr_custom.conf.sample (added),
  4063. configs/samples/res_config_mysql.conf.sample (added),
  4064. configs/samples/dundi.conf.sample (added),
  4065. configs/samples/oss.conf.sample (added),
  4066. configs/samples/app_mysql.conf.sample (added),
  4067. configs/samples/queues.conf.sample (added),
  4068. configs/samples/cdr.conf.sample (added),
  4069. configs/samples/cdr_syslog.conf.sample (added),
  4070. configs/festival.conf.sample (removed),
  4071. configs/samples/cel_pgsql.conf.sample (added),
  4072. configs/http.conf.sample (removed), configs/phoneprov.conf.sample
  4073. (removed), configs/alarmreceiver.conf.sample (removed),
  4074. configs/samples/features.conf.sample (added),
  4075. configs/cdr_tds.conf.sample (removed),
  4076. configs/func_odbc.conf.sample (removed),
  4077. configs/samples/logger.conf.sample (added),
  4078. configs/samples/res_odbc.conf.sample (added),
  4079. configs/samples/agents.conf.sample (added),
  4080. configs/res_fax.conf.sample (removed),
  4081. configs/samples/xmpp.conf.sample (added),
  4082. configs/iaxprov.conf.sample (removed),
  4083. configs/res_pgsql.conf.sample (removed),
  4084. configs/extensions.conf.sample (removed),
  4085. configs/chan_mobile.conf.sample (removed), configs/asterisk.adsi
  4086. (removed), configs/cel_sqlite3_custom.conf.sample (removed),
  4087. configs/users.conf.sample (removed),
  4088. configs/samples/res_pktccops.conf.sample (added),
  4089. configs/samples/amd.conf.sample (added), configs/rtp.conf.sample
  4090. (removed), configs/samples/res_parking.conf.sample (added),
  4091. configs/hep.conf.sample (removed),
  4092. configs/samples/modules.conf.sample (added),
  4093. configs/cel_tds.conf.sample (removed),
  4094. configs/res_curl.conf.sample (removed),
  4095. configs/samples/skinny.conf.sample (added),
  4096. configs/samples/cdr_pgsql.conf.sample (added),
  4097. configs/samples/sip_notify.conf.sample (added),
  4098. configs/samples/test_sorcery.conf.sample (added),
  4099. configs/samples/dsp.conf.sample (added),
  4100. configs/ss7.timers.sample (removed),
  4101. configs/samples/udptl.conf.sample (added),
  4102. configs/cdr_odbc.conf.sample (removed),
  4103. configs/samples/sip.conf.sample (added),
  4104. configs/minivm.conf.sample (removed),
  4105. configs/res_config_sqlite.conf.sample (removed),
  4106. configs/codecs.conf.sample (removed), configs/osp.conf.sample
  4107. (removed), configs/samples/cel_custom.conf.sample (added),
  4108. configs/samples/dbsep.conf.sample (added),
  4109. configs/samples/app_skel.conf.sample (added),
  4110. configs/console.conf.sample (removed),
  4111. configs/cdr_manager.conf.sample (removed),
  4112. configs/cdr_custom.conf.sample (removed),
  4113. configs/chan_dahdi.conf.sample (removed),
  4114. configs/res_config_mysql.conf.sample (removed),
  4115. configs/samples/statsd.conf.sample (added),
  4116. configs/cli.conf.sample (removed), configs/queues.conf.sample
  4117. (removed), configs/cdr_syslog.conf.sample (removed), UPGRADE.txt,
  4118. configs/manager.conf.sample (removed),
  4119. configs/samples/res_corosync.conf.sample (added),
  4120. configs/features.conf.sample (removed), configs/sla.conf.sample
  4121. (removed), configs/logger.conf.sample (removed),
  4122. configs/res_odbc.conf.sample (removed),
  4123. configs/agents.conf.sample (removed),
  4124. configs/samples/ooh323.conf.sample (added), Makefile,
  4125. configs/xmpp.conf.sample (removed),
  4126. configs/samples/phoneprov.conf.sample (added),
  4127. configs/samples/alarmreceiver.conf.sample (added),
  4128. configs/samples/cdr_tds.conf.sample (added),
  4129. configs/extconfig.conf.sample (removed),
  4130. configs/samples/func_odbc.conf.sample (added),
  4131. configs/samples/res_fax.conf.sample (added),
  4132. configs/samples/iaxprov.conf.sample (added),
  4133. configs/samples/res_ldap.conf.sample (added),
  4134. configs/samples/dnsmgr.conf.sample (added),
  4135. configs/res_pktccops.conf.sample (removed),
  4136. configs/cel.conf.sample (removed),
  4137. configs/samples/res_pgsql.conf.sample (added),
  4138. configs/samples/chan_mobile.conf.sample (added),
  4139. configs/samples/asterisk.adsi (added),
  4140. configs/samples/users.conf.sample (added),
  4141. configs/samples/rtp.conf.sample (added),
  4142. configs/phone.conf.sample (removed), configs/skinny.conf.sample
  4143. (removed), configs/muted.conf.sample (removed),
  4144. configs/samples/hep.conf.sample (added), configs/iax.conf.sample
  4145. (removed), configs/samples/cel_tds.conf.sample (added),
  4146. configs/sip_notify.conf.sample (removed),
  4147. configs/samples/telcordia-1.adsi (added),
  4148. configs/samples/alsa.conf.sample (added),
  4149. configs/samples/adsi.conf.sample (added),
  4150. configs/test_sorcery.conf.sample (removed),
  4151. configs/samples/followme.conf.sample (added),
  4152. configs/samples/asterisk.conf.sample (added),
  4153. configs/extensions.lua.sample (removed), configs/say.conf.sample
  4154. (removed), configs/cel_custom.conf.sample (removed),
  4155. configs/samples/ss7.timers.sample (added),
  4156. configs/samples/cel_odbc.conf.sample (added),
  4157. configs/app_skel.conf.sample (removed),
  4158. configs/samples/ccss.conf.sample (added),
  4159. configs/cli_permissions.conf.sample (removed),
  4160. configs/statsd.conf.sample (removed),
  4161. configs/samples/res_config_sqlite.conf.sample (added),
  4162. configs/config_test.conf.sample (removed),
  4163. configs/indications.conf.sample (removed),
  4164. configs/samples/osp.conf.sample (added),
  4165. configs/samples/cdr_manager.conf.sample (added),
  4166. configs/samples/console.conf.sample (added),
  4167. configs/voicemail.conf.sample (removed),
  4168. configs/res_corosync.conf.sample (removed),
  4169. configs/misdn.conf.sample (removed),
  4170. configs/samples/cli.conf.sample (added), configs/ari.conf.sample
  4171. (removed), configs/ooh323.conf.sample (removed),
  4172. configs/samples/calendar.conf.sample (added),
  4173. configs/samples/res_stun_monitor.conf.sample (added),
  4174. configs/samples/manager.conf.sample (added),
  4175. configs/samples/pjsip_notify.conf.sample (added),
  4176. configs/samples/sla.conf.sample (added),
  4177. configs/musiconhold.conf.sample (removed),
  4178. configs/pjsip.conf.sample (removed), configs/sorcery.conf.sample
  4179. (removed), configs/vpb.conf.sample (removed),
  4180. configs/unistim.conf.sample (removed),
  4181. configs/res_ldap.conf.sample (removed),
  4182. configs/dnsmgr.conf.sample (removed),
  4183. configs/samples/extconfig.conf.sample (added),
  4184. configs/samples/res_snmp.conf.sample (added),
  4185. configs/acl.conf.sample (removed),
  4186. configs/samples/smdi.conf.sample (added),
  4187. configs/samples/cel.conf.sample (added),
  4188. configs/cli_aliases.conf.sample (removed),
  4189. configs/samples/cdr_sqlite3_custom.conf.sample (added),
  4190. configs/extensions.ael.sample (removed),
  4191. configs/cdr_adaptive_odbc.conf.sample (removed),
  4192. configs/samples/phone.conf.sample (added),
  4193. configs/extensions_minivm.conf.sample (removed),
  4194. configs/motif.conf.sample (removed), configs/telcordia-1.adsi
  4195. (removed), configs/samples/meetme.conf.sample (added),
  4196. configs/adsi.conf.sample (removed), configs/alsa.conf.sample
  4197. (removed), configs/samples/muted.conf.sample (added),
  4198. configs/followme.conf.sample (removed),
  4199. configs/asterisk.conf.sample (removed),
  4200. configs/samples/iax.conf.sample (added),
  4201. configs/samples/res_config_sqlite3.conf.sample (added),
  4202. configs/samples/mgcp.conf.sample (added),
  4203. configs/cel_odbc.conf.sample (removed), configs/ccss.conf.sample
  4204. (removed), configs/cdr_mysql.conf.sample (removed),
  4205. configs/samples/extensions.lua.sample (added),
  4206. configs/samples/say.conf.sample (added),
  4207. configs/dundi.conf.sample (removed),
  4208. configs/samples/queuerules.conf.sample (added),
  4209. configs/oss.conf.sample (removed), configs/app_mysql.conf.sample
  4210. (removed), configs/samples/confbridge.conf.sample (added),
  4211. configs/samples/cli_permissions.conf.sample (added),
  4212. configs/samples/enum.conf.sample (added),
  4213. configs/samples/config_test.conf.sample (added),
  4214. configs/cdr.conf.sample (removed),
  4215. configs/samples/indications.conf.sample (added),
  4216. configs/cel_pgsql.conf.sample (removed),
  4217. configs/res_stun_monitor.conf.sample (removed),
  4218. configs/calendar.conf.sample (removed),
  4219. configs/samples/voicemail.conf.sample (added),
  4220. configs/pjsip_notify.conf.sample (removed),
  4221. configs/samples/misdn.conf.sample (added),
  4222. configs/samples/ari.conf.sample (added),
  4223. configs/samples/festival.conf.sample (added),
  4224. configs/samples/http.conf.sample (added),
  4225. configs/res_snmp.conf.sample (removed),
  4226. configs/samples/musiconhold.conf.sample (added),
  4227. configs/samples/pjsip.conf.sample (added),
  4228. configs/samples/sorcery.conf.sample (added),
  4229. configs/samples/vpb.conf.sample (added), configs/smdi.conf.sample
  4230. (removed), configs/samples/unistim.conf.sample (added),
  4231. configs/samples (added), configs/amd.conf.sample (removed):
  4232. configs: Move sample config files into a subdirectory of configs
  4233. This moves all samples configs from configs/ to configs/samples.
  4234. This allows for additional sets of sample configuration files to
  4235. be added in the future. Review:
  4236. https://reviewboard.asterisk.org/r/3804/
  4237. * channels/chan_sip.c, UPGRADE.txt: chan_sip: Make
  4238. progressinband=never really mean 'never' progressinband=never in
  4239. sip.conf is easily defeated if an onward trunk sends a progress
  4240. indication of its own. This is almost certain to happen if the
  4241. onward trunk is ISDN or IAX as these technologies send a progress
  4242. indication even if early media is not required. This progress
  4243. message is passed to the caller, and causes the "never" option to
  4244. be rather badly named. This patch changes the behaviour of this
  4245. setting in the following ways: 1) In sip_write(), do not pass the
  4246. media unless we have either progressed beyond INV_EARLY_MEDIA, or
  4247. we are in INV_EARLY_MEDIA state, and early media is both set-up
  4248. and wanted. This helps resolve double-ringing on some buggy
  4249. handsets. 2) In sip_indicate(), if we see AST_CONTROL_PROGRESS,
  4250. but SIP_PROG_INBAND_NEVER is set, send a 180 Ringing instead to
  4251. avoid implicitly enabling early media. Avoid sending double ring
  4252. indications. NOTE: the meaning of the SIP_PROGRESS_SENT flag
  4253. changes slightly in this patch to also encapsulate the fact that
  4254. a channel has *sent or received* a 183 Progress indication. This
  4255. makes the updated code in sip_write() much more simple. Review:
  4256. https://reviewboard.asterisk.org/r/3700 ASTERISK-23972 #close
  4257. Reported by: Steve Davies patches:
  4258. inband_never_present_early_media2 uploaded by Steve Davies
  4259. (License 5012)
  4260. * menuselect: Add svn:ignore property
  4261. * UPGRADE.txt, menuselect/configure, menuselect/configure.ac,
  4262. configure, configure.ac: configure: Fix libxml2 development
  4263. library dependency checking The commit that added libxml2 support
  4264. didn't fully check for the libxml2 development script in the
  4265. Asterisk configure file. As a result, Asterisk could be
  4266. configured, then fail on menuselect. This patch fixes it so that
  4267. Asterisk should detect the libxml2 dependency failure first.
  4268. * menuselect/makeopts.in, menuselect/autoconfig.h.in,
  4269. menuselect/menuselect.h, menuselect/example_menuselect-tree,
  4270. configure, include/asterisk/autoconfig.h.in, menuselect/Makefile,
  4271. menuselect/README, menuselect/aclocal.m4, configure.ac,
  4272. UPGRADE.txt, menuselect/configure, menuselect/configure.ac,
  4273. menuselect/menuselect.c, menuselect/acinclude.m4: menuselect: Add
  4274. libxml2 support (Patch 3) This is the final patch in adding
  4275. menuselect to Asterisk. - The first patch (r418832) added
  4276. menuselect along with mxml - The second patch (r418833) removed
  4277. mxml from menuselect This patch adds support for libxml2 to
  4278. menuselect, and makes libxml2 a required library for Asterisk.
  4279. Note that the libxml2 portion of this patch was written by Sean
  4280. Bright, and was made available on a team branch:
  4281. http://svn.digium.com/svn/menuselect/team/seanbright/libxml2/
  4282. Review: https://reviewboard.asterisk.org/r/3773/ ASTERISK-20703
  4283. #close patches: some_mysterious_team_branch uploaded by
  4284. seanbright (License 5060)
  4285. * menuselect/mxml (removed): menuselect: Remove mxml from
  4286. menuselect (Patch 2) This is the second patch that adds
  4287. menuselect to Asterisk trunk. The previous commit (r418832) added
  4288. menuselect along with mxml; this patch removes mxml completely
  4289. from Menuselect. A subsequent patch will switch menuselect over
  4290. to using libxml2, and make libxml2 a required dependency for
  4291. Asterisk. ASTERISK-20703
  4292. * menuselect/mxml/configure.in (added), menuselect/acinclude.m4
  4293. (added), menuselect/mxml/mxml.list.in (added),
  4294. menuselect/mxml/README (added), menuselect/linkedlists.h (added),
  4295. menuselect/mxml (added), menuselect/mxml/config.h.in (added),
  4296. menuselect/aclocal.m4 (added), menuselect/install-sh (added),
  4297. menuselect/mxml/mxml-string.c (added),
  4298. menuselect/menuselect_stub.c (added), menuselect/make_version
  4299. (added), menuselect/mxml/mxml-entity.c (added),
  4300. menuselect/bootstrap.sh (added), menuselect/makeopts.in (added),
  4301. menuselect/autoconfig.h.in (added), menuselect/config.guess
  4302. (added), menuselect/mxml/install-sh (added),
  4303. menuselect/test/build_tools/menuselect-deps (added), /,
  4304. menuselect/contrib/menuselect-dummy (added),
  4305. menuselect/config.sub (added), menuselect/mxml/configure (added),
  4306. menuselect/mxml/Makefile.in (added), menuselect (added),
  4307. menuselect/contrib (added), menuselect/mxml/mxml.pc.in (added),
  4308. menuselect/configure.ac (added), menuselect/mxml/mxml-set.c
  4309. (added), menuselect/contrib/Makefile-dummy (added),
  4310. menuselect/mxml/ANNOUNCEMENT (added), menuselect/missing (added),
  4311. menuselect/menuselect_curses.c (added),
  4312. menuselect/example_menuselect-tree (added), menuselect/Makefile
  4313. (added), menuselect/mxml/mxml-search.c (added), menuselect/test
  4314. (added), menuselect/test/menuselect-tree (added),
  4315. menuselect/mxml/mxml.h (added), menuselect/mxml/mxml-index.c
  4316. (added), menuselect/configure (added),
  4317. menuselect/menuselect_newt.c (added), menuselect/mxml/mxml-attr.c
  4318. (added), menuselect/mxml/mxml-private.c (added),
  4319. menuselect/menuselect.c (added), menuselect/mxml/CHANGES (added),
  4320. menuselect/mxml/COPYING (added), menuselect/mxml/mxml-file.c
  4321. (added), menuselect/menuselect.h (added),
  4322. menuselect/menuselect_gtk.c (added), menuselect/README (added),
  4323. menuselect/strcompat.c (added), menuselect/mxml/mxml-node.c
  4324. (added), menuselect/test/build_tools (added): menuselect: Add
  4325. menuselect to Asterisk trunk (Patch 1) This is the first patch
  4326. that adds menuselect to Asterisk trunk, and removes the
  4327. svn:externals property. This is being done for two reasons: (1)
  4328. The removal of external repositories eases a future migration to
  4329. git (2) Asterisk is now the only thing that uses menuselect; as a
  4330. result, there's little need to keep it in an external repository
  4331. Subsequent patches will remove the mxml dependency from
  4332. menuselect and tidy up the build system. ASTERISK-20703
  4333. 2014-07-17 14:28 +0000 [r418811] Kinsey Moore <kmoore@digium.com>
  4334. * /, main/bridge_channel.c: TEST_FRAMEWORK: Fix threewaytransfer
  4335. reporting Ensure that three-way transfers can be reported even if
  4336. featuremap is non-NULL. ........ Merged revisions 418810 from
  4337. http://svn.asterisk.org/svn/asterisk/branches/12
  4338. 2014-07-16 23:08 +0000 [r418788] Corey Farrell <git@cfware.com>
  4339. * /, channels/dahdi/bridge_native_dahdi.c: Remove include of
  4340. astobj.h from channels/dahdi/bridge_native_dahdi.c. The include
  4341. was unneeded, this is split off from r3758 as it applies to 12.
  4342. ........ Merged revisions 418787 from
  4343. http://svn.asterisk.org/svn/asterisk/branches/12
  4344. 2014-07-16 14:03 +0000 [r418717-418757] Matthew Jordan <mjordan@digium.com>
  4345. * res/res_pjsip/pjsip_configuration.c, CHANGES, res/res_pjsip.c,
  4346. channels/chan_pjsip.c, include/asterisk/res_pjsip.h,
  4347. contrib/ast-db-manage/config/versions/1d50859ed02e_create_accountcode.py
  4348. (added), /, configs/pjsip.conf.sample: res_pjsip: Support setting
  4349. a default accountcode on endpoints Most channel drivers let you
  4350. specify a default accountcode to be set on channels associated
  4351. with a particular peer/endpoint/object. Prior to this patch,
  4352. chan_pjsip/res_pjsip did not support such a setting. This patch
  4353. adds a new setting to the res_pjsip endpoint object,
  4354. 'accountcode'. When a channel is created that is associated with
  4355. an endpoint with this value set, the channel will automatically
  4356. have its accountcode property set to the value configured for the
  4357. endpoint. Review: https://reviewboard.asterisk.org/r/3724/
  4358. ASTERISK-24000 #close Reported by: Matt Jordan ........ Merged
  4359. revisions 418756 from
  4360. http://svn.asterisk.org/svn/asterisk/branches/12
  4361. * cdr/cdr_pgsql.c, CHANGES, configs/cdr_pgsql.conf.sample,
  4362. configs/res_pgsql.conf.sample, cel/cel_pgsql.c,
  4363. res/res_config_pgsql.c, configs/cel_pgsql.conf.sample: cel_pgsql,
  4364. cdr_pgsql, res_config_pgsql: Add PostgreSQL application_name
  4365. support This patch adds support for the PostgreSQL
  4366. application_name connection setting. When the appropriate
  4367. PostgreSQL module's configuration is set with an application
  4368. name, the name will be passed to PostgreSQL on connection and
  4369. displayed in the database's pg_stat_activity view, as well as in
  4370. CSV logs. This aids in managing which applications/servers are
  4371. connected to a PostgreSQL database, as well as tracing the
  4372. activity of those connections. Review:
  4373. https://reviewboard.asterisk.org/r/3591 ASTERISK-23737 #close
  4374. Reported by: Gergely Domodi patches: pgsql_application_name.patch
  4375. uploaded by Gergely Domodi (License 6610)
  4376. * codecs/codec_adpcm.c, main/format.c: codec_adpcm: Change
  4377. description of codec "ADPCM" to "Dialogic ADPCM" Technically,
  4378. ADPCM is a method that can be applied to several codecs.
  4379. Asterisk's ADPCM codec is the Dialogic ADPCM or VOX codec. See
  4380. http://en.wikipedia.org/wiki/Dialogic_ADPCM for more information
  4381. about said codec. Review: https://reviewboard.asterisk.org/r/3744
  4382. patches: rb3744.patch uploaded by dennis.guse (License 6513)
  4383. * UPGRADE.txt, main/manager.c, /: manager: Return ActionID on
  4384. nominal responses to PresenceState action When the PresenceState
  4385. action is executed, the nominal path fails to include the
  4386. ActionID in the successful response. This patch adds a call to
  4387. astman_start_ack, which guarantees that an ActionID (if provided)
  4388. will be sent back to the AMI client. Unlike the Asterisk 11 and
  4389. 12 patches, this patch also deprecates the duplicate Message key
  4390. in the response to the action, replacing it with the key
  4391. 'PresenceMessage'. Review:
  4392. https://reviewboard.asterisk.org/r/3776/ ASTERISK-23985 #close
  4393. ........ Merged revisions 418713 from
  4394. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4395. revisions 418714 from
  4396. http://svn.asterisk.org/svn/asterisk/branches/12
  4397. 2014-07-15 23:03 +0000 [r418716] Kinsey Moore <kmoore@digium.com>
  4398. * /, main/bridge_channel.c: TEST_FRAMEWORK: Fix ref leak in feature
  4399. activation This fixes two reference leaks that would occur when
  4400. TEST_FRAMEWORK was enabled and features were successfully
  4401. executed. ........ Merged revisions 418715 from
  4402. http://svn.asterisk.org/svn/asterisk/branches/12
  4403. 2014-07-15 17:57 +0000 [r418654] Jonathan Rose <jrose@digium.com>
  4404. * funcs/func_uri.c, /: func_uri: URIENCODE/URIDECODE - allow empty
  4405. strings as argument Previously these two dialplan functions would
  4406. issue warnings and return failure when an empty string is used as
  4407. the argument. Now they will not issue a warning and will
  4408. successfully return an empty string. ASTERISK-23911 #close
  4409. Reported by: Matt Jordan Review:
  4410. https://reviewboard.asterisk.org/r/3745/ ........ Merged
  4411. revisions 418641 from
  4412. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4413. revisions 418649 from
  4414. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4415. revisions 418650 from
  4416. http://svn.asterisk.org/svn/asterisk/branches/12
  4417. 2014-07-15 12:11 +0000 [r418616] Sean Bright <sean@malleable.com>
  4418. * main/asterisk.c: Update Asterisk copyright year in
  4419. main/asterisk.c It's been 2014 for like... 6 months.
  4420. 2014-07-14 14:55 +0000 [r418566-418587] Richard Mudgett <rmudgett@digium.com>
  4421. * include/asterisk/logger.h, /: logger.h: Extract DEBUG_ATLEAST()
  4422. to complement VERBOSITY_ATLEAST(). ........ Merged revisions
  4423. 418586 from http://svn.asterisk.org/svn/asterisk/branches/12
  4424. * include/asterisk/jabber.h (removed), include/asterisk/jingle.h
  4425. (removed), include/asterisk/frame_defs.h (removed),
  4426. configs/h323.conf.sample (removed): Actually delete the removed
  4427. files.
  4428. 2014-07-13 21:57 +0000 [r418507] Corey Farrell <git@cfware.com>
  4429. * /, main/astobj2.c, contrib/scripts/refcounter.py: astobj2: work
  4430. around REF_DEBUG race which causes out of order log entries *
  4431. Update refcounter.py to use delta's to track the current
  4432. reference count. * Use result from internal_ao2_ref to write
  4433. old_refcount to refs_log. Review:
  4434. https://reviewboard.asterisk.org/r/3756/ ........ Merged
  4435. revisions 418504 from
  4436. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4437. revisions 418505 from
  4438. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4439. revisions 418506 from
  4440. http://svn.asterisk.org/svn/asterisk/branches/12
  4441. 2014-07-13 20:08 +0000 [r418488] Scott Griepentrog <sgriepentrog@digium.com>
  4442. * include/asterisk/astobj2.h: astobj2: correct define for
  4443. ao2_t_cleanup This change maps the ao2_t_cleanup() function to
  4444. the correct debug function so that it can be used. Review:
  4445. https://reviewboard.asterisk.org/r/3764/
  4446. 2014-07-13 16:48 +0000 [r418448-418467] Corey Farrell <git@cfware.com>
  4447. * main/manager.c, /, apps/app_skel.c: Fix minor reference leaks in
  4448. app_skel and TEST_FRAMEWORK * Cleanup games object in app_skel. *
  4449. Cleanup stasis subscription to TEST_FRAMEWORK in manager.c (12+).
  4450. Review: https://reviewboard.asterisk.org/r/3757/ ........ Merged
  4451. revisions 418465 from
  4452. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4453. revisions 418466 from
  4454. http://svn.asterisk.org/svn/asterisk/branches/12
  4455. * include/asterisk/jabber.h, include/asterisk/jingle.h,
  4456. configs/h323.conf.sample: Remove files left behind on removal of
  4457. h323, jingle and jabber. This change removes h323.conf.sample,
  4458. jingle.h, jabber.h left behind by r3698. Review:
  4459. https://reviewboard.asterisk.org/r/3755/
  4460. 2014-07-11 23:00 +0000 [r418419] Matthew Jordan <mjordan@digium.com>
  4461. * main/astobj2.c, include/asterisk/astobj2.h: astobj2: Add tag
  4462. variants for ao2_bump, ao2_cleanup, and ao2_replace Tags are
  4463. useful in hunting down ref imbalances; this patch adds tag
  4464. variants for these commonly used macros/functions. Review:
  4465. https://reviewboard.asterisk.org/r/3750/
  4466. 2014-07-11 21:10 +0000 [r418397] Corey Farrell <git@cfware.com>
  4467. * /, include/asterisk/astobj2.h: astobj2: tweak ao2_replace to do
  4468. nothing when it would be a NoOp This change causes ao2_replace to
  4469. do nothing when src == dst. This avoids REF_DEBUG logging when
  4470. we're not actually doing anything. Review:
  4471. https://reviewboard.asterisk.org/r/3743/ ........ Merged
  4472. revisions 418396 from
  4473. http://svn.asterisk.org/svn/asterisk/branches/12
  4474. 2014-07-11 16:42 +0000 [r418370] Scott Griepentrog <sgriepentrog@digium.com>
  4475. * /, main/config.c: config: inform config hook of change when
  4476. writing file When updated configuration is written back to the
  4477. conf file - for example when a user changes their voicemail pin,
  4478. make sure that any config hook that wants to know of changes is
  4479. informed. Review: https://reviewboard.asterisk.org/r/3708/
  4480. ........ Merged revisions 418366 from
  4481. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4482. revisions 418369 from
  4483. http://svn.asterisk.org/svn/asterisk/branches/12
  4484. 2014-07-10 15:36 +0000 [r418325] Matthew Jordan <mjordan@digium.com>
  4485. * /, include/asterisk/xmpp.h: include/asterisk/xmpp.h: Convert
  4486. indentation to tabs This is a whitespace only change. ........
  4487. Merged revisions 418323 from
  4488. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4489. revisions 418324 from
  4490. http://svn.asterisk.org/svn/asterisk/branches/12
  4491. 2014-07-10 01:59 +0000 [r418226-418264] Richard Mudgett <rmudgett@digium.com>
  4492. * channels/sig_pri.c, /: chan_dahdi/sig_pri: Fix type mismatch in
  4493. the idledial feature's channel creation. Square pegs in round
  4494. holes don't work very well. ........ Merged revisions 418261 from
  4495. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4496. revisions 418262 from
  4497. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4498. revisions 418263 from
  4499. http://svn.asterisk.org/svn/asterisk/branches/12
  4500. * res/stasis/stasis_bridge.h (added), main/bridge_channel.c,
  4501. res/res_stasis.c, /, res/stasis/stasis_bridge.c (added),
  4502. include/asterisk/bridge_channel.h, main/bridge_basic.c: ARI: Make
  4503. mixing bridges propagate linkedids and accountcodes. * Create a
  4504. Stasis bridge sub-class to propagate linkedids and accountcodes.
  4505. * Fixed the basic bridge sub-class to update peeraccount codes
  4506. when the number of channels in the bridge drops back down to two
  4507. parties. * Refactored ast_bridge_channel_update_accountcodes() to
  4508. handle channels joining/leaving the bridge. * Fixed the basic
  4509. bridge sub-class to not call the base bridge class pull method
  4510. twice. AFS-105 #close ASTERISK-23852 #close Reported by: Richard
  4511. Mudgett Review: https://reviewboard.asterisk.org/r/3720/ ........
  4512. Merged revisions 418225 from
  4513. http://svn.asterisk.org/svn/asterisk/branches/12
  4514. 2014-07-08 14:48 +0000 [r418174-418183] Matthew Jordan <mjordan@digium.com>
  4515. * rest-api/api-docs/deviceStates.json,
  4516. rest-api/api-docs/endpoints.json,
  4517. rest-api/api-docs/mailboxes.json, rest-api/api-docs/events.json,
  4518. /, rest-api/api-docs/asterisk.json,
  4519. rest-api/api-docs/applications.json,
  4520. rest-api/api-docs/playbacks.json,
  4521. rest-api/api-docs/channels.json, rest-api/api-docs/sounds.json,
  4522. rest-api/resources.json, include/asterisk/manager.h,
  4523. rest-api/api-docs/bridges.json,
  4524. rest-api/api-docs/recordings.json: manager/ARI: Update version to
  4525. 2.4.0/1.4.0; Update UPGRADE.txt ........ Merged revisions 418182
  4526. from http://svn.asterisk.org/svn/asterisk/branches/12
  4527. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fix undefined
  4528. function when PJPROJECT is not installed The
  4529. dtls_perform_handshake function was mistakenly placed under the
  4530. guards for USE_PJPROJECT. If PJPROJECT was not installed, the
  4531. function would not be defined, while other functions would
  4532. attempt to still use it. This prevented res_rtp_asterisk from
  4533. being loaded. ASTERISK-24001 #close Reported by: Don Fanning
  4534. ........ Merged revisions 418172 from
  4535. http://svn.asterisk.org/svn/asterisk/branches/12
  4536. 2014-07-07 16:08 +0000 [r418117] Joshua Colp <jcolp@digium.com>
  4537. * include/asterisk/res_pjsip_body_generator_types.h,
  4538. res/res_pjsip_dialog_info_body_generator.c (added),
  4539. res/res_pjsip_exten_state.c, res/res_pjsip/presence_xml.c, /,
  4540. include/asterisk/res_pjsip_presence_xml.h:
  4541. res_pjsip_dialog_info_body_generator: Add dialog-info+xml support
  4542. for presence. This module implements dialog-info+xml for the
  4543. purposes of presence. This means that phones such as Grandstreams
  4544. can now subscribe to receive presence information for an
  4545. extension. ASTERISK-21443 #close Reported by: Matt Jordan Review:
  4546. https://reviewboard.asterisk.org/r/3705/ ........ Merged
  4547. revisions 418116 from
  4548. http://svn.asterisk.org/svn/asterisk/branches/12
  4549. 2014-07-07 02:15 +0000 [r418090] Matthew Jordan <mjordan@digium.com>
  4550. * include/asterisk/stasis_app.h, res/ari/resource_channels.c,
  4551. res/res_stasis.c, /, res/stasis/app.c: ARI/res_stasis: Subscribe
  4552. to both Local channel halves when originating to app This patch
  4553. fixes two bugs: 1. When originating a channel into a Stasis
  4554. application, we already create a subscription for the channel
  4555. that is going into our Stasis app. Unfortunately, when you create
  4556. a Local channel and pass it off to a Stasis app, you really
  4557. aren't creating just one channel: you're creating two. This patch
  4558. snags the second half of the Local channel pair (assuming it is a
  4559. Local channel pair, but luckily core_local is kind about such
  4560. assumptions) and subscribes to it as well. 2. Subscriptions are a
  4561. bit sticky right now. If a subscription is made, the 'interest'
  4562. count gets bumped on the Stasis subscription - but unless
  4563. something explicitly unsubscribes the channel, said subscription
  4564. sticks around. This is not much of a problem is a user is
  4565. creating the subscription - if they made it, they must want it.
  4566. However, when we are creating implicit subscriptions, we need to
  4567. make sure something clears them out. This patch takes a
  4568. pessimistic approach: it watches the cache updates coming from
  4569. Stasis and, if we notice that the cache just cleared out an
  4570. object, we delete our subscription object. This keeps our ao2
  4571. container of Stasis forwards in an application from growing out
  4572. of hand; it also is a bit more forgiving for end users who may
  4573. not realize they were supposed to unsubscribe from that channel
  4574. that just hung up. Review:
  4575. https://reviewboard.asterisk.org/r/3710/ #ASTERISK-23939 #close
  4576. ........ Merged revisions 418089 from
  4577. http://svn.asterisk.org/svn/asterisk/branches/12
  4578. 2014-07-07 01:22 +0000 [r418067-418084] Kinsey Moore <kmoore@digium.com>
  4579. * tests/test_cel.c, main/cel.c, channels/chan_pjsip.c,
  4580. res/res_pjsip_session.c, /: CEL: Fix incorrect/missing extra
  4581. field information This corrects two issues with the extra field
  4582. information in Asterisk 12+ in channel event logs. It is possible
  4583. to inject custom values into the dialstatus provided by
  4584. ast_channel_dial_type() Stasis messages that fall outside the
  4585. enumeration allowed for the DIALSTATUS channel variable. CEL now
  4586. filters for the allowed values and ignores other values. The
  4587. "hangupsource" extra field key is always blank if the far end
  4588. channel is a chan_pjsip channel. This is because the hangupsource
  4589. is never set for the pjsip channel driver. This change sets the
  4590. hangupsource whenever a hangup is queued for chan_pjsip channels.
  4591. This corrects an issue with the pjsip channel driver where the
  4592. hangupcause information was not being set properly. Review:
  4593. https://reviewboard.asterisk.org/r/3690/ ........ Merged
  4594. revisions 418071 from
  4595. http://svn.asterisk.org/svn/asterisk/branches/12
  4596. * /, main/http.c: HTTP: Fix build for gcc 4.10 ........ Merged
  4597. revisions 418066 from
  4598. http://svn.asterisk.org/svn/asterisk/branches/12
  4599. 2014-07-04 15:26 +0000 [r418019-418050] Matthew Jordan <mjordan@digium.com>
  4600. * main/Makefile: main/Makefile: fix compilation error of buildinfo
  4601. occurring on 'make install' Egads. Another bad deletion of too
  4602. much when attempting to remove h323 stuff.
  4603. * configure.ac, build_tools/menuselect-deps.in, configure,
  4604. main/Makefile: configure: Remove last vestiges of h323; DO create
  4605. menuselect-deps The previous patch (r418034) fixed the 'glitch'
  4606. that the channels/h323 Makefile no longer existed. Unfortunately,
  4607. removing the entire line was a bit of a blunder, as it meant that
  4608. build_tools/menuselect-deps was never generated. Hilarity ensued
  4609. when actually trying to compile. But hey! At least configure
  4610. worked. This patch fixes *that* glitch, and removes some more of
  4611. the vestiges of h323. (It had tendrils in the main Makefile?
  4612. Crazy.)
  4613. * configure.ac, configure: configure: Update script to pass if
  4614. channels/h323/Makefile.in does not exist This simply removes that
  4615. check from the configure script, as r418019 removed chan_h323.
  4616. * apps/app_dahdibarge.c (removed), configs/gtalk.conf.sample
  4617. (removed), main/pbx.c, apps/app_readfile.c (removed),
  4618. channels/chan_sip.c, configs/jingle.conf.sample (removed),
  4619. UPGRADE.txt, res/res_musiconhold.c, channels/chan_gtalk.c
  4620. (removed), channels/Makefile, CHANGES, res/res_jabber.c
  4621. (removed), channels/h323 (removed), utils/conf2ael.c,
  4622. channels/chan_jingle.c (removed), res/ael/pval.c,
  4623. configs/jabber.conf.sample (removed),
  4624. configs/asterisk.conf.sample, res/res_agi.c, channels/chan_h323.c
  4625. (removed), addons/Makefile, pbx/pbx_realtime.c, utils/ael_main.c,
  4626. include/asterisk/options.h, main/asterisk.c,
  4627. addons/app_saycountpl.c (removed): Remove many deprecated modules
  4628. Billing records are fair, To get paid is quite bright, You should
  4629. really use ODBC; Good-bye cdr_sqlite. Microsoft did once push
  4630. H.323, Hell, we all remember NetMeeting. But try to compile
  4631. chan_h323 now And you will take quite a beating. The XMPP and SIP
  4632. war was fierce, And in the distant fray Was birthed
  4633. res_jabber/chan_jingle; But neither to stay. For everyone did
  4634. care and chase what Google professed. "Free Internet Calling" was
  4635. what devotees cried, But Google did change the specs so often
  4636. That the developers were happy the day chan_gtalk died. And then
  4637. there was that odd application Dedicated to the Polish tongue.
  4638. app_saycountpl was subsumed by Say; One could say its bell was
  4639. rung. To read and parse a file from the dialplan You could (I
  4640. guess) use an application. app_readfile did fill that purpose,
  4641. but I think A function is perhaps better in its creation. Barging
  4642. is rude, I'm not sure why we do it. Inwardly, the caller will
  4643. probably sigh. But if you really must do it, Don't use
  4644. app_dahdibarge, use ChanSpy. We all despise the sound of tinny
  4645. robots It makes our queues so cold. To control such an
  4646. abomination It's better to not use Wait/SetMusicOnHold. It's
  4647. often nice to know properties of a channel It makes our calls
  4648. right We have a nice function called CHANNEL And so SIPCHANINFO
  4649. is sent off into the night. And now things get odd; Apparently
  4650. one could delimit with a colon Properties from the SIPPEER
  4651. function! Commas are in; all others are done. Finally, a word on
  4652. pipes and commas. We're sorry. We can't say it enough. But those
  4653. compatibility options in asterisk.conf; To maintain them forever
  4654. was just too tough. This patch removes: * cdr_sqlite * chan_gtalk
  4655. * chan_jingle * chan_h323 * res_jabber * app_saycountpl *
  4656. app_readfile * app_dahdibarge It removes the following
  4657. applications/functions: * WaitMusicOnHold * SetMusicOnHold *
  4658. SIPCHANINFO It removes the colon delimiter from the SIPPEER
  4659. function. Finally, it also removes all compatibility options that
  4660. were configurable from asterisk.conf, as these all applied to
  4661. compatibility with Asterisk 1.4 systems. Review:
  4662. https://reviewboard.asterisk.org/r/3698/
  4663. 2014-07-03 22:22 +0000 [r417933-417976] Richard Mudgett <rmudgett@digium.com>
  4664. * channels/sig_pri.h, channels/chan_dahdi.c,
  4665. configs/chan_dahdi.conf.sample, /, UPGRADE.txt,
  4666. channels/sig_pri.c: chan_dahdi: Add inband_on_setup_ack
  4667. compatibility option. The new inband_on_setup_ack option causes
  4668. Asterisk to assume inband audio may be present when a
  4669. SETUP_ACKNOWLEDGE message is received. Q.931 Section 5.1.3 says
  4670. that in scenarios with overlap dialing, when a dialtone is sent
  4671. from the network side, progress indicator 8 "Inband info now
  4672. available" MAY be sent to the CPE if no digits were received with
  4673. the SETUP. It is thus implied that the ie is mandatory if digits
  4674. came with the SETUP and dialtone is needed. This option should be
  4675. enabled, when the network sends dialtone and you want to hear it,
  4676. but the network doesn't send the progress indicator when needed.
  4677. NOTE: For Q.SIG setups this option should be enabled when
  4678. outgoing overlap dialing is also enabled because Q.SIG does not
  4679. send the progress indicator with the SETUP ACK. The commit
  4680. -r413714 (AST-1338) which causes this issue was dealing with a
  4681. SIP-to-ISDN interoperability issue. This commit is a merge of the
  4682. two patches indicated below. ASTERISK-23897 #close Reported by:
  4683. Pavel Troller Patches: pri-4.diff (license #6302) patch uploaded
  4684. by Pavel Troller jira_asterisk_23897_v11.patch (license #5621)
  4685. patch uploaded by rmudgett Review:
  4686. https://reviewboard.asterisk.org/r/3633/ ........ Merged
  4687. revisions 417956 from
  4688. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4689. revisions 417957 from
  4690. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4691. revisions 417958 from
  4692. http://svn.asterisk.org/svn/asterisk/branches/12
  4693. * res/ari/resource_channels.c, res/res_ari.c, main/manager.c, /:
  4694. res_ari: Fix some off-nominal paths just dropping the HTTP
  4695. connection. * Removed some incorrect newlines on ast_http_error()
  4696. messages in manager.c. * Removed an incorrect newline in
  4697. res_ari_channels.c. Addendum to ASTERISK-23552 ........ Merged
  4698. revisions 417932 from
  4699. http://svn.asterisk.org/svn/asterisk/branches/12
  4700. 2014-07-03 17:34 +0000 [r417910-417916] Jonathan Rose <jrose@digium.com>
  4701. * CHANGES, channels/chan_dahdi.c: chan_dahdi: Add AMI commands for
  4702. controlling PRI debugging output Adds the following AMI commands:
  4703. PRIDebugSet - Set PRI debug levels for a specific span
  4704. PRIDebugFileSet - Set the file used for PRI debug message output
  4705. PRIDebugFileUnset - Disables file output for PRI debug messages
  4706. Review: https://reviewboard.asterisk.org/r/3681/
  4707. * CHANGES, pbx/pbx_config.c, main/pbx.c: pbx_config: Add manager
  4708. actions to add/remove extensions Adds two new manager commands to
  4709. pbx_config - DialplanExtensionAdd and DialplanExtensionRemove
  4710. which allow manager users to create and delete extensions
  4711. respectively. Review: https://reviewboard.asterisk.org/r/3650/
  4712. 2014-07-03 17:16 +0000 [r417901] Richard Mudgett <rmudgett@digium.com>
  4713. * res/res_phoneprov.c, main/http.c, UPGRADE.txt,
  4714. include/asterisk/tcptls.h, res/res_http_post.c,
  4715. res/res_http_websocket.c, configs/http.conf.sample,
  4716. include/asterisk/http.h, main/tcptls.c, res/res_ari.c,
  4717. main/manager.c, /: HTTP: Add persistent connection support.
  4718. Persistent HTTP connection support is needed due to the increased
  4719. usage of the Asterisk core HTTP transport and the frequency at
  4720. which REST API calls are going to be issued. * Add http.conf
  4721. session_keep_alive option to enable persistent connections. *
  4722. Parse and discard optional chunked body extension information and
  4723. trailing request headers. * Increased the maximum
  4724. application/json and application/x-www-form-urlencoded body size
  4725. allowed to 4k. The previous 1k was kind of small. * Removed a
  4726. couple inlined versions of ast_http_manid_from_vars() by calling
  4727. the function. manager.c:generic_http_callback() and
  4728. res_http_post.c:http_post_callback() * Add missing va_end() in
  4729. ast_ari_response_error(). * Eliminated unnecessary RAII_VAR() use
  4730. in http.c:auth_create(). ASTERISK-23552 #close Reported by: Scott
  4731. Griepentrog Review: https://reviewboard.asterisk.org/r/3691/
  4732. ........ Merged revisions 417880 from
  4733. http://svn.asterisk.org/svn/asterisk/branches/12
  4734. 2014-07-03 16:55 +0000 [r417900] Matthew Jordan <mjordan@digium.com>
  4735. * main/tcptls.c, configure, include/asterisk/autoconfig.h.in,
  4736. configure.ac: main/tcptls: Add checks for OpenSSL Elliptic Curve
  4737. support The patch for ASTERISK-23905 that added PFS support in
  4738. Asterisk depends on the elliptic curve library support being
  4739. present in OpenSSL. As it turns out, some versions of OpenSSL
  4740. don't have this library - notably the version running on our
  4741. build agents. This patch fixes the build by providing a configure
  4742. check for the specific library calls that the PFS patch relies
  4743. on. Review: https://reviewboard.asterisk.org/r/3709/
  4744. 2014-07-03 16:14 +0000 [r417877-417879] sgalarneau <sgalarneau@localhost>:
  4745. * res/ari/resource_events.h, rest-api/api-docs/channels.json,
  4746. res/ari/resource_channels.h, rest-api/api-docs/events.json, /:
  4747. ARI: Improvements to body parameters documentation The variables
  4748. body parameter under the originate and originate with id
  4749. operations of the channel resource showed invalid JSON in its
  4750. description. The variables body parameter under the userEvent
  4751. operation of the event resource made no mention that the custom
  4752. key/value pairs should be wrapped in a variables key in order to
  4753. be added to the custom user event. ASTERISK-23975 #close Review:
  4754. https://reviewboard.asterisk.org/r/3692/ ........ Merged
  4755. revisions 417878 from
  4756. http://svn.asterisk.org/svn/asterisk/branches/12
  4757. * rest-api-templates/api.wiki.mustache,
  4758. rest-api-templates/swagger_model.py, /: api.wiki.mustache: Update
  4759. wiki template to support body parameters This patch updates the
  4760. api.wiki.mustache template and the swagger_model python script to
  4761. understand if an operation has a body parameter. If an operation
  4762. does have a body parameter, it will now be displayed in the
  4763. corresponding wiki entry. ........ Merged revisions 407389 from
  4764. http://svn.asterisk.org/svn/asterisk/branches/12
  4765. 2014-07-03 14:08 +0000 [r417863] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  4766. * Makefile, contrib/scripts/dahdi_span_config_hook (added):
  4767. dahdi_span_config_hook: automatically register new dahdi channels
  4768. Install a hook script for DAHDI to register new spans with
  4769. Asterisk automatically by running: asterisk -rx 'dahdi create
  4770. channel FIRST LAST' Review:
  4771. https://reviewboard.asterisk.org/r/3157/
  4772. 2014-07-03 12:10 +0000 [r417800-417803] Matthew Jordan <mjordan@digium.com>
  4773. * main/tcptls.c, CHANGES: main/tcptls: Add support for Perfect
  4774. Forward Secrecy This patch enables Perfect Forward Secrecy (PFS)
  4775. in Asterisk's core TLS API. Modules that wish to enable PFS
  4776. should consider the following: - Ephemeral ECDH (ECDHE) is
  4777. enabled by default. To disable it, do not specify a ECDHE cipher
  4778. suite in a module's configuration, for example:
  4779. tlscipher=AES128-SHA:DES-CBC3-SHA - Ephemeral DH (DHE) is
  4780. disabled by default. To enable it, add DH parameters into the
  4781. private key file, i.e., tlsprivatekey. For an example, see the
  4782. default dh2048.pem at
  4783. http://www.opensource.apple.com/source/OpenSSL098/OpenSSL098-35.1/src/apps/dh2048.pem?txt
  4784. - Because clients expect the server to prefer PFS, and because
  4785. OpenSSL sorts its cipher suites by bit strength, (see "openssl
  4786. ciphers -v DEFAULT") consider re-ordering your cipher suites in
  4787. the conf file. For example:
  4788. tlscipher=AES128+kEECDH:AES128+kEDH:3DES+kEDH:AES128-SHA:DES-CBC3-SHA:-ADH:-AECDH
  4789. will use PFS when offered by the client. Clients which do not
  4790. offer PFS fall-back to AES-128 (or even 3DES as recommend by RFC
  4791. 3261). Review: https://reviewboard.asterisk.org/r/3647/
  4792. ASTERISK-23905 #close Reported by: Alexander Traud patches:
  4793. tlsPFS_for_HEAD.patch uploaded by Alexander Traud (License 6520)
  4794. tlsPFS.patch uploaded by Alexander Traud (License 6520)
  4795. * /, main/utils.c: main/untils: Prevent potential infinite loop in
  4796. ast_careful_fwrite A loop in ast_careful_fwrite exists that will
  4797. continually attempt to write to a file stream, even in the
  4798. presence of EAGAIN/EINTR errors. However, if a connection that
  4799. uses ast_careful_fwrite closes suddenly, ast_careful_fwrite's
  4800. call to fflush may return EAGAIN/EINTER along with EOF. A
  4801. subsequent call to fflush will return EOF but not clear errno,
  4802. resulting in an infinite loop. This patch clears errno after it
  4803. is detected and handled the loop, such that any subsequent call
  4804. to fflush will not get erroneously stuck. Review:
  4805. https://reviewboard.asterisk.org/r/3704 #ASTERISK-23984 #close
  4806. Reported by: Steve Davies patches: fflush_loop_fix uploaded by
  4807. one47 (License 5012) ........ Merged revisions 417797 from
  4808. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4809. revisions 417798 from
  4810. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4811. revisions 417799 from
  4812. http://svn.asterisk.org/svn/asterisk/branches/12
  4813. 2014-07-02 21:13 +0000 [r417770] Jonathan Rose <jrose@digium.com>
  4814. * res/ari/resource_events.h, res/ari/resource_asterisk.h,
  4815. res/ari/resource_applications.h, res/ari/resource_playbacks.h,
  4816. res/ari/resource_channels.h, res/ari/resource_sounds.h, /,
  4817. res/ari/resource_bridges.h, res/ari/resource_recordings.h,
  4818. rest-api-templates/ari_resource.h.mustache,
  4819. res/ari/resource_device_states.h, res/ari/resource_endpoints.h,
  4820. res/ari/resource_mailboxes.h: ARI: Remove unnecessary \briefs
  4821. from automatically generated documentation Review:
  4822. https://reviewboard.asterisk.org/r/3440/ ........ Merged
  4823. revisions 412653 from
  4824. http://svn.asterisk.org/svn/asterisk/branches/12
  4825. 2014-07-01 14:42 +0000 [r417679-417706] Joshua Colp <jcolp@digium.com>
  4826. * /, res/res_rtp_asterisk.c: res_rtp_asterisk: Don't leak memory or
  4827. reset state if DTLS configuration is set multiple times. ........
  4828. Merged revisions 417705 from
  4829. http://svn.asterisk.org/svn/asterisk/branches/12
  4830. * res/res_rtp_asterisk.c,
  4831. contrib/ast-db-manage/config/versions/51f8cb66540e_add_further_dtls_options.py
  4832. (added), include/asterisk/res_pjsip_session.h, main/rtp_engine.c,
  4833. /, channels/chan_sip.c, main/sdp_srtp.c, res/res_pjsip_sdp_rtp.c,
  4834. res/res_pjsip/pjsip_configuration.c, configs/sip.conf.sample,
  4835. include/asterisk/rtp_engine.h, res/res_pjsip.c,
  4836. channels/sip/include/sip.h, include/asterisk/res_pjsip.h,
  4837. include/asterisk/sdp_srtp.h: Recorded merge of revisions 417677
  4838. from http://svn.asterisk.org/svn/asterisk/branches/11 ........
  4839. res_rtp_asterisk: Add SHA-256 support for DTLS and perform DTLS
  4840. negotiation on RTCP. This change fixes up DTLS support in
  4841. res_rtp_asterisk so it can accept and provide a SHA-256
  4842. fingerprint, so it occurs on RTCP, and so it occurs after ICE
  4843. negotiation completes. Configuration options to chan_sip and
  4844. chan_pjsip have also been added to allow behavior to be tweaked
  4845. (such as forcing the AVP type media transports in SDP).
  4846. ASTERISK-22961 #close Reported by: Jay Jideliov Review:
  4847. https://reviewboard.asterisk.org/r/3679/ Review:
  4848. https://reviewboard.asterisk.org/r/3686/ ........ Merged
  4849. revisions 417678 from
  4850. http://svn.asterisk.org/svn/asterisk/branches/12
  4851. 2014-06-30 18:39 +0000 [r417663] Mark Michelson <mmichelson@digium.com>
  4852. * res/res_pjsip_pubsub.c: Reverse logic during subscription
  4853. persistence recreation. In the abstraction effort, this bit of
  4854. logic got messed up. We want to recreate the persistence if
  4855. things go well, not if things fail.
  4856. 2014-06-30 13:02 +0000 [r417590-417649] Matthew Jordan <mjordan@digium.com>
  4857. * apps/app_voicemail.c: apps/app_voicemail: Fix compilation error
  4858. introduced in r417591 Not sure why that change to
  4859. ast_channel_alloc was made but ... okay.
  4860. * apps/app_voicemail.c, main/say.c, CHANGES: app_voicemail, say:
  4861. Add support for Japanese Language This patch adds support for the
  4862. Japanese language to both the say family of applications, as well
  4863. as for VoiceMail and VoiceMailMain. A new pack of language sounds
  4864. will be released at the same time as the next major version of
  4865. Asterisk to support the new language features. The language
  4866. features can be enabled using a language code of 'ja'. Review:
  4867. https://reviewboard.asterisk.org/r/3477 ASTERISK-23324 #close
  4868. Reported by: Kevin McCoy patches:
  4869. app_voicemail.c.20140226.jb.patch uploaded by Kevin McCoy
  4870. (License 6586) say.c.20140226.jb.patch uploaded by Kevin McCoy
  4871. (License 6586)
  4872. * /, channels/chan_sip.c: chan_sip: be more tolerant of whitespace
  4873. between attributes in SDP fmtp line This patch is essentially a
  4874. backport of a small portion of r397526 from ASTERISK-21981. In
  4875. that patch, pass through support and format attribute negotiation
  4876. was added for Opus. Part of that included being more tolerant to
  4877. whitespace in the fmtp line of an SDP; that part of the patch is
  4878. being applied here. As the author of the backport pointed out, in
  4879. SDP, the fmtp line is allowed to include whitespace between
  4880. attributes. RFC 3267 chapter 8.3 (from 2001) includes an example
  4881. for this. This was not removed in the updated RFC 4867 in 2007.
  4882. Review: https://reviewboard.asterisk.org/r/3658 #ASTERISK-23916
  4883. #close Reported by: Alexander Traud patches:
  4884. sdpFMTPspace_Asterisk11.patch uploaded by Alexander Traud
  4885. (License 6520) ........ Merged revisions 417587 from
  4886. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4887. revisions 417588 from
  4888. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4889. revisions 417589 from
  4890. http://svn.asterisk.org/svn/asterisk/branches/12
  4891. 2014-06-27 23:21 +0000 [r417571] Richard Mudgett <rmudgett@digium.com>
  4892. * /, main/event.c: event.c: Fix type mismatch errors in ie_maps[].
  4893. In v12+ the type values from the table are only used by the CEL
  4894. unit tests. Since the unit tests were only comparing a generated
  4895. expected event with a real event to see if the ie contents
  4896. matched and using the same table IE_PLTYPE values to read the
  4897. event contents, the type mismatches were not detected. ........
  4898. Merged revisions 417565 from
  4899. http://svn.asterisk.org/svn/asterisk/branches/12
  4900. 2014-06-27 19:27 +0000 [r417485-417511] Corey Farrell <git@cfware.com>
  4901. * /, main/astobj2.c: Ensure REF_DEBUG records entrys for attempts
  4902. to ao2_ref an invalid object This change ensures that
  4903. __ao2_ref_debug writes to ref_log when given a non-NULL pointer
  4904. to an invalid ao2 object. This is to ensure that we record any
  4905. attempt manipulate references of already freed objects.
  4906. ASTERISK-23948 #close Reported by: Corey Farrell Review:
  4907. https://reviewboard.asterisk.org/r/3677/ ........ Merged
  4908. revisions 417500 from
  4909. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4910. revisions 417505 from
  4911. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4912. revisions 417509 from
  4913. http://svn.asterisk.org/svn/asterisk/branches/12
  4914. * /, contrib/scripts/refcounter.py: refcounter.py: prevent use of
  4915. excessive RAM with large refs logs When processing a 212MB refs
  4916. file, refcounter.py used over 3GB of RAM. This change greatly
  4917. reduces memory usage in two ways: * Saving object history in
  4918. whole lines instead of separated values. * Not saving
  4919. normal/skewed/leaked object lists unless they are requested.
  4920. ASTERISK-23921 #close Reported by: Corey Farrell Review:
  4921. https://reviewboard.asterisk.org/r/3668/ ........ Merged
  4922. revisions 417480 from
  4923. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  4924. revisions 417481 from
  4925. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4926. revisions 417483 from
  4927. http://svn.asterisk.org/svn/asterisk/branches/12
  4928. 2014-06-27 13:50 +0000 [r417461] Matthew Jordan <mjordan@digium.com>
  4929. * res/res_pjsip/pjsip_configuration.c, res/res_pjsip_pubsub.c,
  4930. res/res_pjsip_registrar.c, include/asterisk/res_pjsip.h, /,
  4931. res/res_pjsip_outbound_registration.c: res_pjsip: Add ActionID to
  4932. events created as a result of PJSIP AMI actions A number of
  4933. various PJSIP AMI actions were failing to parse out and place the
  4934. ActionID into their responses. This patch updates the various
  4935. PJSIP actions such that the passed in ActionID is emitted on any
  4936. event list complete events, as well as any intermediate events
  4937. created as a result of the action. #ASTERISK-23947 #close
  4938. Reported by: Mark Michelson Review:
  4939. https://reviewboard.asterisk.org/r/3675/ ........ Merged
  4940. revisions 417460 from
  4941. http://svn.asterisk.org/svn/asterisk/branches/12
  4942. 2014-06-27 02:04 +0000 [r417423-417447] Kinsey Moore <kmoore@digium.com>
  4943. * tests/test_cel.c: CEL: Update unit tests for bridge tech field
  4944. Update the CEL unit tests that handle BRIDGE_ENTER and
  4945. BRIDGE_EXIT events to expect the "bridge_technology" extra field
  4946. key.
  4947. * CHANGES: CHANGES: Add missing changes Add missing CHANGES changes
  4948. from r417361 and r417383.
  4949. 2014-06-26 18:27 +0000 [r417400-417421] Matthew Jordan <mjordan@digium.com>
  4950. * res/res_http_websocket.exports.in, /: res_http_websocket: Export
  4951. symbol for ast_websocket_set_timeout Thanks to Sean Bright for
  4952. pointing out that this was missed in #asterisk-dev. ........
  4953. Merged revisions 417419 from
  4954. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  4955. revisions 417420 from
  4956. http://svn.asterisk.org/svn/asterisk/branches/12
  4957. * channels/chan_pjsip.c, /: chan_pjsip: Add a test event for fast
  4958. picture updates This will drive the test on review r3419. Note
  4959. that the patch for this was done by Ben Ford, although it was
  4960. slightly modified for this commit. ASTERISK-23562 Reported by:
  4961. Matt Jordan ........ Merged revisions 417399 from
  4962. http://svn.asterisk.org/svn/asterisk/branches/12
  4963. 2014-06-26 14:48 +0000 [r417361-417383] Kinsey Moore <kmoore@digium.com>
  4964. * main/cel.c: CEL: Add bridge tech to relevant CEL records Add the
  4965. "bridge_technology" extra field key to BRIDGE_ENTER and
  4966. BRIDGE_EXIT CEL events to convey the bridge technology in use at
  4967. the time the record was generated.
  4968. * main/bridge.c, include/asterisk/channel.h,
  4969. include/asterisk/bridge_features.h,
  4970. tests/test_channel_feature_hooks.c (added),
  4971. main/bridge_channel.c, main/channel.c: Bridging: Allow channels
  4972. to define bridging hooks This patch allows the current owner of a
  4973. channel to define various feature hooks to be made available once
  4974. the channel has entered a bridge. This includes any hooks that
  4975. are setup on the ast_bridge_features struct such as DTMF hooks,
  4976. bridge event hooks (join, leave, etc.), and interval hooks.
  4977. Review: https://reviewboard.asterisk.org/r/3649/
  4978. 2014-06-26 12:43 +0000 [r417317-417360] Matthew Jordan <mjordan@digium.com>
  4979. * CHANGES, apps/app_jack.c: app_jack: Support audio with a sampling
  4980. rate higher than 8kHz This patch enables the jack-audiohook to
  4981. cope with dynamic sampling rates from and to Asterisk.
  4982. Information from the channel is taken to derive the channel's
  4983. sampling rate, suiting SLINxx format and frame->datalen. There
  4984. are stil a few limitations after this patch: * Required
  4985. information is taken from the channel during initialization as
  4986. the audiohook does not provide this information.
  4987. Audiohook.internal_sampl_rate(...) is set later, but no callback
  4988. is available to inform app_jack. * Frame.datalen is computed
  4989. using "rate / 50" assuming a ptime of 20ms. There is no internal
  4990. API available to determine datalen for a SLINxx. * Ringbuffer
  4991. size is now dynamic depending on the value of frame.datalen (see
  4992. above) and the number of frames, which are in
  4993. RINGBUFFER_FRAME_CAPACITY, that need to fit. Review:
  4994. https://reviewboard.asterisk.org/r/3618 Note that the patch being
  4995. committed here is based on the patch posted on ASTERISK-23836.
  4996. However, Matthis Schmieder also provided a patch to enable this
  4997. functionality, and that patch is noted below. ASTERISK-20696
  4998. #close Reported by: Matthis Schmieder patches: app_jack.patch
  4999. uploaded by Matthis Schmieder (License 6445) ASTERISK-23836
  5000. #close Reported by: Dennis Guse patches: patch-app_jack.c
  5001. uploaded by Dennis Guse (License 6513)
  5002. * main/udptl.c, /: udptl: Correct FEC to not consider negative
  5003. sequence numbers as missing When using FEC, with span=3 and
  5004. entries=4 Asterisk will attempt to repair the packet with
  5005. sequence number 5, as it will see that packet -4 is missing. The
  5006. result is Asterisk sending garbage packets that can kill a fax.
  5007. This patch adds a check to see if the sequence number is valid
  5008. before checking if the packet is missing. Review:
  5009. https://reviewboard.asterisk.org/r/3657/ #ASTERISK-23908 #close
  5010. Reported by: Torrey Searle patches: udptl_fec.patch uploaded by
  5011. Torrey Searle (License 5334) ........ Merged revisions 417318
  5012. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  5013. Merged revisions 417320 from
  5014. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5015. revisions 417324 from
  5016. http://svn.asterisk.org/svn/asterisk/branches/12
  5017. * res/ari/internal.h, configs/ari.conf.sample,
  5018. res/res_http_websocket.c, res/res_pjsip.c,
  5019. configs/pjsip.conf.sample, include/asterisk/http_websocket.h,
  5020. configs/sip.conf.sample, res/res_pjsip/config_transport.c,
  5021. res/ari/ari_websockets.c, res/res_pjsip_transport_websocket.c,
  5022. res/ari/config.c, channels/sip/include/sip.h,
  5023. include/asterisk/res_pjsip.h, res/res_ari.c, /,
  5024. channels/chan_sip.c, UPGRADE.txt: res_http_websocket: Close
  5025. websocket correctly and use careful fwrite When a client takes a
  5026. long time to process information received from Asterisk, a write
  5027. operation using fwrite may fail to write all information. This
  5028. causes the underlying file stream to be in an unknown state, such
  5029. that the socket must be disconnected. Unfortunately, there are
  5030. two problems with this in Asterisk's existing websocket code: 1.
  5031. Periodically, during the read loop, Asterisk must write to the
  5032. connected websocket to respond to pings. As such, Asterisk
  5033. maintains a reference to the session during the loop. When
  5034. ast_http_websocket_write fails, it may cause the session to
  5035. decrement its ref count, but this in and of itself does not break
  5036. the read loop. The read loop's write, on the other hand, does not
  5037. break the loop if it fails. This causes the socket to get in a
  5038. 'stuck' state, preventing the client from reconnecting to the
  5039. server. 2. More importantly, however, is that the fwrite in
  5040. ast_http_websocket_write fails with a large volume of data when
  5041. the client takes awhile to process the information. When it does
  5042. fail, it fails writing only a portion of the bytes. With some
  5043. debugging, it was shown that this was failing in a similar
  5044. fashion to ASTERISK-12767. Switching this over to
  5045. ast_careful_fwrite with a long enough timeout solved the problem.
  5046. Note that this version of the patch, unlike r417310 in Asterisk
  5047. 11, exposes configuration options beyond just chan_sip's
  5048. sip.conf. Configuration options to configure the write timeout
  5049. have also been added to pjsip.conf and ari.conf. #ASTERISK-23917
  5050. #close Reported by: Matt Jordan Review:
  5051. https://reviewboard.asterisk.org/r/3624/ ........ Merged
  5052. revisions 417310 from
  5053. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5054. revisions 417311 from
  5055. http://svn.asterisk.org/svn/asterisk/branches/12
  5056. 2014-06-26 10:06 +0000 [r417251] Corey Farrell <git@cfware.com>
  5057. * /, channels/chan_sip.c: chan_sip: Fix handling of "From" headers
  5058. longer than 256 characters From headers were processed using a
  5059. 256 character buffer on the stack. This change replaces that with
  5060. a heap allocation by ast_strdup. ASTERISK-23790 #close Reported
  5061. by: uniken1 Tested by: uniken1 Review:
  5062. https://reviewboard.asterisk.org/r/3669/ Patches:
  5063. chan_sip-large-from-header-1.8-r3.patch uploaded by wdoekes
  5064. (license 5674) ........ Merged revisions 417248 from
  5065. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5066. revisions 417249 from
  5067. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5068. revisions 417250 from
  5069. http://svn.asterisk.org/svn/asterisk/branches/12
  5070. 2014-06-25 20:57 +0000 [r417233] Mark Michelson <mmichelson@digium.com>
  5071. * res/res_pjsip_pubsub.c, res/res_pjsip_exten_state.c,
  5072. include/asterisk/res_pjsip_pubsub.h,
  5073. res/res_pjsip_pidf_body_generator.c,
  5074. res/res_pjsip_pubsub.exports.in, res/res_pjsip_mwi.c,
  5075. res/res_pjsip_xpidf_body_generator.c: Abstract PJSIP-specific
  5076. elements from the pubsub API. This helps to pave the way for RLS
  5077. work that is to come. Since this is a self-contained change and
  5078. subscription tests still pass, this work is being committed
  5079. directly to trunk instead of a working branch. ASTERISK-23865
  5080. #close Review: https://reviewboard.asterisk.org/r/3628
  5081. 2014-06-25 18:57 +0000 [r417213] Corey Farrell <git@cfware.com>
  5082. * main/astobj2_container.c, /: ao2_container node object ignores
  5083. REF_DEBUG in all places except one Almost every reference
  5084. operation against container node's uses __ao2_alloc or __ao2_ref,
  5085. thereby preventing ref logging for the nodes. One node reference
  5086. is released with ao2_t_ref, causing refcounter.py to falsely
  5087. report skews and leaks for many nodes. ASTERISK-23922 #close
  5088. Reported by: Corey Farrell Review:
  5089. https://reviewboard.asterisk.org/r/3670/ ........ Merged
  5090. revisions 417212 from
  5091. http://svn.asterisk.org/svn/asterisk/branches/12
  5092. 2014-06-25 00:45 +0000 [r417193] Damien Wedhorn <voip@facts.com.au>
  5093. * channels/chan_skinny.c: Skinny: cleanup some log messages around
  5094. sessions.
  5095. 2014-06-24 02:50 +0000 [r417167] Corey Farrell <git@cfware.com>
  5096. * include/asterisk/netsock.h, main/utils.c, main/netsock.c,
  5097. include/asterisk/res_pjsip_session.h: Move eid functions to
  5098. utils.c, mark netsock.h deprecated Move eid functions from
  5099. netsock.c to utils.c. These functions were already published by
  5100. utils.h. Flag netsock.h as deprecated and switch
  5101. res_pjsip_session.h to use netsock2.h. The only code that still
  5102. uses netsock.h is chan_iax2. ASTERISK-23920 #close Reported by:
  5103. Corey Farrell Review: https://reviewboard.asterisk.org/r/3661/
  5104. 2014-06-23 18:50 +0000 [r417143] Joshua Colp <jcolp@digium.com>
  5105. * /, res/res_rtp_asterisk.c: res_rtp_asterisk: Return the length of
  5106. data written when sending via ICE instead of 0. ASTERISK-23834
  5107. #close Reported by: Richard Kenner ........ Merged revisions
  5108. 417141 from http://svn.asterisk.org/svn/asterisk/branches/11
  5109. ........ Merged revisions 417142 from
  5110. http://svn.asterisk.org/svn/asterisk/branches/12
  5111. 2014-06-23 16:04 +0000 [r417120] Richard Mudgett <rmudgett@digium.com>
  5112. * /, main/core_unreal.c: core_unreal: Fix off by one buffer
  5113. overwrite error. Appending the ;2 to the user supplied ;1
  5114. uniqueid to create the ;2 version if the user did not also supply
  5115. an extra uniqueid for the ;2 channel resulted in allocating a
  5116. buffer that was one byte too small. * Fix off by one error in
  5117. ast_unreal_new_channels() when generating the ;2 uniqueid from
  5118. the user suppled ;1 version. * Pulled some long assignment lines
  5119. from if tests to improve line break readability in
  5120. ast_unreal_new_channels(). ........ Merged revisions 417119 from
  5121. http://svn.asterisk.org/svn/asterisk/branches/12
  5122. 2014-06-23 07:44 +0000 [r417059] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  5123. * channels/sig_pri.c, channels/sig_pri.h, channels/chan_dahdi.c:
  5124. suspended destructions of pri spans on events If a DAHDI span
  5125. disappears, we wish for its representation in Asterisk to be
  5126. destroyed as well. The information about the span's removal may
  5127. come from several paths: 1. DAHDI sends DAHDI_EVENT_REMOVE on
  5128. every channel. 2. An extra DAHDI_EVENT_REMOVED is sent on every
  5129. subsequent call to DAHDI_GET_EVENT. 3. Every read (including the
  5130. internal one by libpri on the D-channel) returns -ENODEV.
  5131. Asterisk responsds to DAHDI_EVENT_REMOVE on a channel by
  5132. destroying it. Destroying a channel requires holding the channel
  5133. list lock (iflock). Destroying a channel that is part of a span
  5134. requires holding the span's lock. Destroying a channel from a
  5135. context that holds the span lock, while at the same time another
  5136. channel is destroyed directly, leads to a deadlock. Solution:
  5137. don't destroy span while holding the channels list lock. Thus
  5138. changes in this patch: * Deferring removal of PRI spans in
  5139. response to events: doomed spans are collected on a list. *
  5140. Doomed spans are removed periodically by the monitor thread. *
  5141. ENODEV reads from the D-channel will warant the same deferred
  5142. removal. Review: https://reviewboard.asterisk.org/r/3548/
  5143. 2014-06-22 18:53 +0000 [r416996] George Joseph <george.joseph@fairview5.com>
  5144. * include/asterisk/astobj2.h, Makefile.rules, Makefile, /: astobj2:
  5145. Add an ao2_replace macro to astobj2.h This macro replaces one
  5146. object reference with another cleaning up the original. param dst
  5147. Pointer to the object that will be cleaned up. param src Pointer
  5148. to the object replacing it. src's ref count is bumped if it's
  5149. non-NULL. dst's ref count is decremented if it's non-NULL. src is
  5150. assigned to dst, This patch was reviewed on IRC by coreyfarrell
  5151. and mjordan. Tested by: George Joseph ........ Merged revisions
  5152. 416995 from http://svn.asterisk.org/svn/asterisk/branches/12
  5153. 2014-06-20 23:18 +0000 [r416872-416935] George Joseph <george.joseph@fairview5.com>
  5154. * /, configure, include/asterisk/autoconfig.h.in: build: Allow
  5155. autoconf/ast_ext_tool_check to handle cross-compiling better.
  5156. ast_ext_tool_check.m4 isn't handling cases where a path to a
  5157. package is provided (E.G. --with-mysqlclient=/some/sysroot) and
  5158. the package has a config tool (E.G. mysql_config) and the package
  5159. has its own subdirectories in include or lib. For example,
  5160. mysql's libraries are in ${MYSQLCLIENT_DIR}/usr/lib/mysql but
  5161. ast_ext_tool_check sets MYSQLCLIENT_LIB to
  5162. ${MYSQLCLIENT_DIR}/usr/lib. libxml2 has the same problem with its
  5163. includes. They're in ${LIBXML2_DIR}/usr/include/libxml2 not
  5164. directly in ${LIBXML2_DIR}/usr/include. Both cause configure to
  5165. fail and there are others in the same boat. The problem is caused
  5166. by logic in ast_ext_tool_check that overrides the result of the
  5167. config tool's --cflags and --libs options if package_DIR is set.
  5168. This patch prepends package_DIR (if specified) to the -L and -I
  5169. results from the package's config tool instead of overriding
  5170. them. A regenerated ./configure and
  5171. include/asterisk/autoconfig.h.in are included but can be
  5172. regenerated by running ./bootstrap.sh at any time. Tested by:
  5173. George Joseph Tested by: Matt Jordan Review:
  5174. https://reviewboard.asterisk.org/r/3550/ ........ Merged
  5175. revisions 416929 from
  5176. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5177. revisions 416930 from
  5178. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5179. revisions 416931 from
  5180. http://svn.asterisk.org/svn/asterisk/branches/12
  5181. * autoconf/ast_ext_tool_check.m4, /: build: Allow
  5182. autoconf/ast_ext_tool_check to handle cross-compiling better.
  5183. ast_ext_tool_check.m4 isn't handling cases where a path to a
  5184. package is provided (E.G. --with-mysqlclient=/some/sysroot) and
  5185. the package has a config tool (E.G. mysql_config) and the package
  5186. has its own subdirectories in include or lib. For example,
  5187. mysql's libraries are in ${MYSQLCLIENT_DIR}/usr/lib/mysql but
  5188. ast_ext_tool_check sets MYSQLCLIENT_LIB to
  5189. ${MYSQLCLIENT_DIR}/usr/lib. libxml2 has the same problem with its
  5190. includes. They're in ${LIBXML2_DIR}/usr/include/libxml2 not
  5191. directly in ${LIBXML2_DIR}/usr/include. Both cause configure to
  5192. fail and there are others in the same boat. The problem is caused
  5193. by logic in ast_ext_tool_check that overrides the result of the
  5194. config tool's --cflags and --libs options if package_DIR is set.
  5195. This patch prepends package_DIR (if specified) to the -L and -I
  5196. results from the package's config tool instead of overriding
  5197. them. Tested by: George Joseph Tested by: Matt Jordan Review:
  5198. https://reviewboard.asterisk.org/r/3550/ ........ Merged
  5199. revisions 416870 from
  5200. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5201. revisions 416871 from
  5202. http://svn.asterisk.org/svn/asterisk/branches/12
  5203. 2014-06-20 20:57 +0000 [r416848-416850] Jonathan Rose <jrose@digium.com>
  5204. * res/parking/parking_manager.c, /: res_parking: Make manager
  5205. commands register with module information Previously module
  5206. information was not included due to an oversight. Review:
  5207. https://reviewboard.asterisk.org/r/3626/ ........ Merged
  5208. revisions 416849 from
  5209. http://svn.asterisk.org/svn/asterisk/branches/12
  5210. * main/logger.c, CHANGES, include/asterisk/logger.h,
  5211. main/manager.c: Logger: Add manager command 'LoggerRotate' to
  5212. rotate logger Part of a series of AMI command equivalents to
  5213. existing CLI commands Review:
  5214. https://reviewboard.asterisk.org/r/3651/
  5215. 2014-06-20 17:06 +0000 [r416830] Richard Mudgett <rmudgett@digium.com>
  5216. * apps/app_voicemail.c, include/asterisk/app.h, main/app.c,
  5217. apps/app_directory.c, apps/app_chanspy.c: voicemail API
  5218. callbacks: Extract the sayname API call to its own registerd
  5219. callback. * Extract the sayname API call to its own registerd
  5220. callback. This allows the app_directory and app_chanspy
  5221. applications to say a mailbox owner's name using an alternate
  5222. provider when app_voicemail is not available because you are
  5223. using res_mwi_external. app_directory still uses the
  5224. voicemail.conf file. AFS-64 #close Reported by: Mark Michelson
  5225. 2014-06-20 15:27 +0000 [r416738-416807] George Joseph <george.joseph@fairview5.com>
  5226. * main/astobj2_private.h, main/astobj2_container_private.h,
  5227. main/astobj2_container.c, main/astobj2_hash.c,
  5228. main/astobj2_rbtree.c, build_tools/cflags.xml, /,
  5229. tests/test_astobj2.c: astobj2: Additional refactoring to push
  5230. impl specific code down into the impls. Move some implementation
  5231. specific code from astobj2_container.c into astobj2_hash.c and
  5232. astobj2_rbtree.c. This completely removes the need for
  5233. astobj2_container to switch on RTTI and it no longer has any
  5234. knowledge of the implementation details. Also adds AO2_DEBUG as a
  5235. new compile option in menuselect which controls astobj2 debugging
  5236. independently of AST_DEVMODE and REF_DEBUG. Tested by: George
  5237. Joseph Review: https://reviewboard.asterisk.org/r/3593/ ........
  5238. Merged revisions 416806 from
  5239. http://svn.asterisk.org/svn/asterisk/branches/12
  5240. * /, res/res_pjsip_endpoint_identifier_ip.c, main/acl.c,
  5241. include/asterisk/netsock2.h, include/asterisk/acl.h,
  5242. main/netsock2.c: pjsip cli: Change Identify to show CIDR notation
  5243. instead of netmasks. * Added ast_sockaddr_cidr_bits() to count
  5244. the 1 bits in an ast_sockaddr. * Added ast_ha_join_cidr() which
  5245. uses ast_sockaddr_cidr_bits() for the netmask instead of
  5246. ast_sockaddr_stringify_addr. * Changed
  5247. res_pjsip_endpoint_identifier_ip to call ast_ha_join_cidr()
  5248. instead of ast_ha_join() for the CLI output. This is a CLI change
  5249. only. AMI was not affected. Tested by: George Joseph Review:
  5250. https://reviewboard.asterisk.org/r/3652/ ........ Merged
  5251. revisions 416737 from
  5252. http://svn.asterisk.org/svn/asterisk/branches/12
  5253. 2014-06-19 19:40 +0000 [r416736] Kinsey Moore <kmoore@digium.com>
  5254. * /, main/bridge.c, res/parking/parking_tests.c,
  5255. channels/sip/reqresp_parser.c, main/logger.c, main/test.c: Fix
  5256. build warnings with TEST_FRAMEWORK enabled ........ Merged
  5257. revisions 416732 from
  5258. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5259. revisions 416733 from
  5260. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5261. revisions 416734 from
  5262. http://svn.asterisk.org/svn/asterisk/branches/12
  5263. 2014-06-19 16:04 +0000 [r416589-416670] George Joseph <george.joseph@fairview5.com>
  5264. * pbx/pbx_lua.c, /: Remove the problematic and unneeded
  5265. AST_MODFLAG_GLOBAL_SYMBOLS from pbx_lua.c
  5266. AST_MODFLAG_GLOBAL_SYMBOLS was causing the module to be
  5267. incorrectly loaded before pbx_config. pbx_config was therefore
  5268. blowing away contexts that were created by pbx_lua. With
  5269. AST_MODFLAG_DEFAULT the load order is now correct and contexs are
  5270. being properly merged. AST_MODFLAG_GLOBAL_SYMBOLS was not needed
  5271. anyway since no other modules needed its global symbols that
  5272. early. ASTERISK-23818 #close Reported by: Dennis Guse Tested by:
  5273. Dennis Guse Tested by: George Joseph Review:
  5274. https://reviewboard.asterisk.org/r/3629/ ........ Merged
  5275. revisions 416668 from
  5276. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5277. revisions 416669 from
  5278. http://svn.asterisk.org/svn/asterisk/branches/12
  5279. * configs/extensions.lua.sample, /: Update extensions.lua.sample
  5280. with naming conflict guidance. The sample extensions.lua was
  5281. causing pbx_lua to fail to load when parsing 'app.goto("default",
  5282. "s", 1)' because in Lua 5.2, 'goto' is now a reserved word. This
  5283. patch adds guidance to extensions.lua.sample and changed
  5284. 'app.goto("default", "s", 1)' to 'app.['goto']("default", "s",
  5285. 1)'. ASTERISK-23844 #close Reported by: rnewton Tested by:
  5286. gtjoseph Review: https://reviewboard.asterisk.org/r/3627/
  5287. ........ Merged revisions 416581 from
  5288. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5289. revisions 416582 from
  5290. http://svn.asterisk.org/svn/asterisk/branches/12
  5291. 2014-06-18 04:22 +0000 [r416561] Matthew Jordan <mjordan@digium.com>
  5292. * /, main/stasis_channels.c: stasis_channels: Update the stasis
  5293. cache if manager variables are needed In r416211, the publishing
  5294. of variable changes was modified such that a cached channel
  5295. snapshot was used if manager variables were not requested with
  5296. each AMI event. This was done to reduce the amount of channel
  5297. snapshots created. However, an assumption was made that
  5298. generating a channel snapshot and publishing the snapshot to the
  5299. channel topic was sufficient to ensure that the cache would be
  5300. updated; this is not the case. The channel snapshot type must be
  5301. used to force a snapshot update. This patch updates the
  5302. publication of channel variables such that the cache is updated
  5303. prior to publication of the channel variable message if manager
  5304. variables are in use. This ensures that all AMI events receive
  5305. the variable update when they are supposed to. Note that this
  5306. issue was caught by the Asterisk Test Suite (go go testing)
  5307. ........ Merged revisions 416557 from
  5308. http://svn.asterisk.org/svn/asterisk/branches/12
  5309. 2014-06-17 18:45 +0000 [r416444-416503] Mark Michelson <mmichelson@digium.com>
  5310. * /, funcs/func_strings.c: Allow the PUSH and UNSHIFT functions to
  5311. set inheritable channel variables. ........ Merged revisions
  5312. 416500 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  5313. ........ Merged revisions 416501 from
  5314. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5315. revisions 416502 from
  5316. http://svn.asterisk.org/svn/asterisk/branches/12
  5317. * res/res_pjsip_pidf_body_generator.c, /,
  5318. res/res_pjsip_xpidf_body_generator.c: Fix string growth algorithm
  5319. for XML presence bodies. pjpidf_print() does not return < 0 if
  5320. there is not enough room for the document to be printed. Rather,
  5321. it returns 39, the length of the XML prolog. The algorithm also
  5322. had a bug in that it would return if it attempted to grow the
  5323. string larger. ........ Merged revisions 416442 from
  5324. http://svn.asterisk.org/svn/asterisk/branches/12
  5325. 2014-06-17 16:33 +0000 [r416443] Kinsey Moore <kmoore@digium.com>
  5326. * res/res_musiconhold.c, /: MoH: Don't restart stream on repeated
  5327. start calls Currently, music on hold will stop and then start
  5328. again from the beginning if ast_moh_start() is called multiple
  5329. times. This can happen if a call is put on hold repeatedly (the
  5330. channel receives multiple HOLD control frames) and can be
  5331. triggered from ARI by starting MoH on a channel multiple times.
  5332. This is fairly jarring/annoying to users. This change prevents
  5333. MoH from being restarted if the requested music class is the same
  5334. as the one currently playing. This includes an extra check to
  5335. prevent the errors previously experienced in the testsuite and
  5336. has 100+ test runs behind it. Review:
  5337. https://reviewboard.asterisk.org/r/3615/ ........ Merged
  5338. revisions 416439 from
  5339. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5340. revisions 416440 from
  5341. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5342. revisions 416441 from
  5343. http://svn.asterisk.org/svn/asterisk/branches/12
  5344. 2014-06-16 18:27 +0000 [r416416] Richard Mudgett <rmudgett@digium.com>
  5345. * channels/chan_dahdi.c, configs/chan_dahdi.conf.sample,
  5346. channels/sig_ss7.h, configure, channels/chan_dahdi.h,
  5347. configure.ac, UPGRADE.txt, configs/ss7.timers.sample (added),
  5348. CHANGES, channels/sig_ss7.c: chan_dahdi: Adds support for major
  5349. update to libss7. * SS7 support now requires libss7 v2.0 or
  5350. later. The new libss7 is not backwards compatible. * Added SS7
  5351. support for connected line and redirecting. * Most SS7 CLI
  5352. commands are reworked as well as new SS7 commands added. See
  5353. online CLI help. * Added several SS7 config option parameters
  5354. described in chan_dahdi.conf.sample. * ISUP timer support
  5355. reworked and now requires explicit configuration. See
  5356. ss7.timers.sample. Special thanks to Kaloyan Kovachev for his
  5357. support and persistence in getting the original patch by adomjan
  5358. updated and ready for release. SS7-27 #close Reported by: adomjan
  5359. 2014-06-16 16:22 +0000 [r416394] Kevin Harwell <kharwell@digium.com>
  5360. * include/asterisk/http_websocket.h, tests/test_websocket_client.c,
  5361. res/res_http_websocket.c: res_http_websocket: read/write string
  5362. fixup There was a problem when reading a string from the
  5363. websocket. It assumed the received data had a null terminator and
  5364. tried to write the data to an ast_str. This of course could/would
  5365. read past the end of the given buffer while writing the data to
  5366. the internal buffer of ast_str. Modified the the code to
  5367. correctly place a null terminator on the result string.
  5368. 2014-06-16 09:04 +0000 [r416339] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  5369. * cel/cel_sqlite3_custom.c, main/db.c, res/res_config_sqlite3.c,
  5370. cdr/cdr_sqlite3_custom.c, /: We have faced situation when using
  5371. CDR and CEL by sqlite3 modules. With system having high load
  5372. (~100 concurrent calls created by sipp) we found many cdr and cel
  5373. records missed. There is special finction in sqlite3, that make
  5374. able to fix this situation - sqlite3_wait_timeout, that also can
  5375. replace awful code cdr_sqlite3 ad cel_sqlite3 modules. Also this
  5376. function can be used for aastdb and res_config_sqlite3 to avoid
  5377. missed writes to sqlite db. #ASTERISK-23766 #close Reported by:
  5378. Igor Goncharovsky Review:
  5379. https://reviewboard.asterisk.org/r/3559/ ........ Merged
  5380. revisions 416336 from
  5381. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5382. revisions 416337 from
  5383. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5384. revisions 416338 from
  5385. http://svn.asterisk.org/svn/asterisk/branches/12
  5386. 2014-06-16 02:40 +0000 [r416267-416319] Matthew Jordan <mjordan@digium.com>
  5387. * /, channels/chan_sip.c: channels/chan_sip: Forbid remote bridging
  5388. if T.38 is negotiated When a framehook is removed - such as the
  5389. fax gateway framehook - the bridge framework will re-evaluate the
  5390. bridge mixing technologies to see if it can improve the bridging.
  5391. When this occurs, get_rtp_info will be called to determine if
  5392. local or remote bridging can be used. Using remote bridging will
  5393. cause a fax to fail, as direct media negotiation will cause some
  5394. small number of packets to not arrive at the remote endpoint.
  5395. This patch forces local native bridging if T.38 negotiation is in
  5396. progress or has been established. ........ Merged revisions
  5397. 416318 from http://svn.asterisk.org/svn/asterisk/branches/12
  5398. * /, main/channel_internal_api.c: channel_internal_api: Publish a
  5399. snapshot change when linkedids change Snapshots are now not
  5400. published *quite* as much as they used to. One instance where
  5401. they are not published any longer is during bridge enter and exit
  5402. - the state of the channel doesn't change, the bridge does.
  5403. However, channels are changed when a linkedid is propagated;
  5404. previously, the channel's state would be updated and published
  5405. during the bridge enter event. Now this must be explicitly done.
  5406. ........ Merged revisions 416300 from
  5407. http://svn.asterisk.org/svn/asterisk/branches/12
  5408. * /, tests/test_stasis_endpoints.c: test_stasis_endpoints: Remove
  5409. expected channel snapshot We no longer publish a channel snapshot
  5410. when it is associated with an endpoint; after all, the channel
  5411. itself hasn't changed - the endpoint state has changed. This
  5412. updates the channel_messages unit test accordingly. ........
  5413. Merged revisions 416298 from
  5414. http://svn.asterisk.org/svn/asterisk/branches/12
  5415. * /, res/res_musiconhold.c: MoH: Undo commit r416150 (1.8) This
  5416. patch reverts r416150. When the comparison between mohclass->name
  5417. and state->class->name is made, you are not guaranteed that (a)
  5418. state->class is non-NULL or that state or state->class are in a
  5419. safe state. Crashes caught by the bridges/transfer_capabilities
  5420. test. ........ Merged revisions 416251 from
  5421. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5422. revisions 416252 from
  5423. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5424. revisions 416255 from
  5425. http://svn.asterisk.org/svn/asterisk/branches/12
  5426. 2014-06-14 19:26 +0000 [r416237] Corey Farrell <git@cfware.com>
  5427. * res/res_manager_devicestate.c, res/res_manager_presencestate.c:
  5428. res_manager_devicestate and res_manager_presencestate missing
  5429. support level Add MODULEINFO comment block to define support
  5430. level core for these new modules. Review:
  5431. https://reviewboard.asterisk.org/r/3620/
  5432. 2014-06-13 18:24 +0000 [r416216] Matthew Jordan <mjordan@digium.com>
  5433. * res/res_agi.c, res/res_pjsip/pjsip_configuration.c,
  5434. main/stasis_channels.c, res/ari/resource_channels.c,
  5435. main/bridge_channel.c, main/pbx.c, main/stasis_cache.c, /,
  5436. apps/app_meetme.c, main/pickup.c, main/channel_internal_api.c,
  5437. include/asterisk/channel.h, main/core_local.c, main/aoc.c,
  5438. main/endpoints.c, main/cel.c, apps/app_queue.c,
  5439. main/stasis_bridges.c, apps/app_agent_pool.c, main/cli.c,
  5440. main/channel.c, main/dial.c, main/manager.c,
  5441. include/asterisk/stasis_channels.h: stasis: Reduce creation of
  5442. channel snapshots to improve performance During some performance
  5443. testing of Asterisk with AGI, ARI, and lots of Local channels, we
  5444. noticed that there's quite a hit in performance during channel
  5445. creation and releasing to the dialplan (ARI continue). After
  5446. investigating the performance spike that occurs during channel
  5447. creation, we discovered that we create a lot of channel snapshots
  5448. that are technically unnecessary. This includes creating
  5449. snapshots during: * AGI execution * Returning objects for ARI
  5450. commands * During some Local channel operations * During some
  5451. dialling operations * During variable setting * During some
  5452. bridging operations And more. This patch does the following: - It
  5453. removes a number of fields from channel snapshots. These fields
  5454. were rarely used, were expensive to have on the snapshot, and
  5455. hurt performance. This included formats, translation paths, Log
  5456. Call ID, callgroup, pickup group, and all channel variables. As a
  5457. result, AMI Status, "core show channel", "core show channelvar",
  5458. and "pjsip show channel" were modified to either hit the live
  5459. channel or not show certain pieces of data. While this is
  5460. unfortunate, the performance gain from this patch is worth the
  5461. loss in behaviour. - It adds a mechanism to publish a cached
  5462. snapshot + blob. A large number of publications were changed to
  5463. use this, including: - During Dial begin - During Variable
  5464. assignment (if no AMI variables are emitted - if AMI variables
  5465. are set, we have to make snapshots when a variable is changed) -
  5466. During channel pickup - When a channel is put on hold/unhold -
  5467. When a DTMF digit is begun/ended - When creating a bridge
  5468. snapshot - When an AOC event is raised - During Local channel
  5469. optimization/Local bridging - When endpoint snapshots are
  5470. generated - All AGI events - All ARI responses that return a
  5471. channel - Events in the AgentPool, MeetMe, and some in Queue -
  5472. Additionally, some extraneous channel snapshots were being made
  5473. that were unnecessary. These were removed. - The result of
  5474. ast_hashtab_hash_string is now cached in stasis_cache. This
  5475. reduces a large number of calls to ast_hashtab_hash_string, which
  5476. reduced the amount of time spent in this function in gprof by
  5477. around 50%. #ASTERISK-23811 #close Reported by: Matt Jordan
  5478. Review: https://reviewboard.asterisk.org/r/3568/ ........ Merged
  5479. revisions 416211 from
  5480. http://svn.asterisk.org/svn/asterisk/branches/12
  5481. 2014-06-13 13:11 +0000 [r416149-416153] Kinsey Moore <kmoore@digium.com>
  5482. * res/res_musiconhold.c, /: MoH: Don't restart stream on repeated
  5483. start calls Currently, music on hold will stop and then start
  5484. again from the beginning if ast_moh_start() is called multiple
  5485. times. This can happen if a call is put on hold repeatedly (the
  5486. channel receives multiple HOLD control frames) and can be
  5487. triggered from ARI by starting MoH on a channel multiple times.
  5488. This is fairly jarring/annoying to users. This change prevents
  5489. MoH from being restarted if the requested music class is the same
  5490. as the one currently playing. Review:
  5491. https://reviewboard.asterisk.org/r/3615/ ........ Merged
  5492. revisions 416150 from
  5493. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5494. revisions 416151 from
  5495. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5496. revisions 416152 from
  5497. http://svn.asterisk.org/svn/asterisk/branches/12
  5498. * main/cel.c, /: CEL: Expose parking retreiver in extra field This
  5499. exposes the retreiver of a parked call under the "retreiver" key
  5500. of the extra field when this information is available. Review:
  5501. https://reviewboard.asterisk.org/r/3608/ ........ Merged
  5502. revisions 416148 from
  5503. http://svn.asterisk.org/svn/asterisk/branches/12
  5504. 2014-06-13 05:16 +0000 [r416071] Richard Mudgett <rmudgett@digium.com>
  5505. * main/http.c, include/asterisk/tcptls.h, main/tcptls.c,
  5506. main/manager.c, /, channels/chan_sip.c: AST-2014-007: Fix of fix
  5507. to allow AMI and SIP TCP to send messages. ASTERISK-23673 #close
  5508. Reported by: Richard Mudgett Review:
  5509. https://reviewboard.asterisk.org/r/3617/ ........ Merged
  5510. revisions 416066 from
  5511. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5512. revisions 416067 from
  5513. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5514. revisions 416070 from
  5515. http://svn.asterisk.org/svn/asterisk/branches/12
  5516. 2014-06-12 21:27 +0000 [r416024] Rusty Newton <rnewton@digium.com>
  5517. * main/pbx.c: main/pbx - documentation - enhance 'core show hints'
  5518. and 'core show hint' help text Adds descriptive help text to
  5519. 'core show hints' and 'core show hint'. The text describes the
  5520. various columns for the sake of clarity. It takes into account
  5521. recent changes to the content displayed by the commands
  5522. https://reviewboard.asterisk.org/r/3604/ and
  5523. https://reviewboard.asterisk.org/r/3611/. ASTERISK-23764 Review:
  5524. https://reviewboard.asterisk.org/r/3610/
  5525. 2014-06-12 20:17 +0000 [r415982] Kinsey Moore <kmoore@digium.com>
  5526. * res/res_pjsip_pubsub.c, /: Fix build in devmode for GCC 4.10
  5527. ........ Merged revisions 415980 from
  5528. http://svn.asterisk.org/svn/asterisk/branches/12
  5529. 2014-06-12 17:00 +0000 [r415907] Richard Mudgett <rmudgett@digium.com>
  5530. * include/asterisk/utils.h, main/tcptls.c, main/manager.c, /,
  5531. channels/chan_sip.c, main/http.c, UPGRADE.txt, main/utils.c,
  5532. include/asterisk/tcptls.h, res/res_http_websocket.c,
  5533. configs/http.conf.sample: AST-2014-007: Fix DOS by consuming the
  5534. number of allowed HTTP connections. Simply establishing a TCP
  5535. connection and never sending anything to the configured HTTP port
  5536. in http.conf will tie up a HTTP connection. Since there is a
  5537. maximum number of open HTTP sessions allowed at a time you can
  5538. block legitimate connections. A similar problem exists if a HTTP
  5539. request is started but never finished. * Added http.conf
  5540. session_inactivity timer option to close HTTP connections that
  5541. aren't doing anything. Defaults to 30000 ms. * Removed the
  5542. undocumented manager.conf block-sockets option. It interferes
  5543. with TCP/TLS inactivity timeouts. * AMI and SIP TLS connections
  5544. now have better authentication timeout protection. Though I
  5545. didn't remove the bizzare TLS timeout polling code from chan_sip.
  5546. * chan_sip can now handle SSL certificate renegotiations in the
  5547. middle of a session. It couldn't do that before because the
  5548. socket was non-blocking and the SSL calls were not restarted as
  5549. documented by the OpenSSL documentation. * Fixed an off nominal
  5550. leak of the ssl struct in handle_tcptls_connection() if the FILE
  5551. stream failed to open and the SSL certificate negotiations
  5552. failed. The patch creates a custom FILE stream handler to give
  5553. the created FILE streams inactivity timeout and timeout after a
  5554. specific moment in time capability. This approach eliminates the
  5555. need for code using the FILE stream to be redesigned to deal with
  5556. the timeouts. This patch indirectly fixes most of ASTERISK-18345
  5557. by fixing the usage of the SSL_read/SSL_write operations.
  5558. ASTERISK-23673 #close Reported by: Richard Mudgett ........
  5559. Merged revisions 415841 from
  5560. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5561. revisions 415854 from
  5562. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5563. revisions 415896 from
  5564. http://svn.asterisk.org/svn/asterisk/branches/12
  5565. 2014-06-12 15:50 +0000 [r415839] Scott Griepentrog <sgriepentrog@digium.com>
  5566. * /, apps/app_queue.c: app_queue: delayed state can cause early
  5567. leavewhenempty ringing In app_queue, device state changes arrive
  5568. in event messages and update the queue member status value. That
  5569. value is checked in get_member_status() to decide that the caller
  5570. should leave when there are no available members. Although event
  5571. messages can be delayed by other activity, there is no adverse
  5572. affect by lagged status except in one specific case: there is
  5573. only one available member, it was just rung, and leavewhenempty
  5574. is enabled set for ringing members. This change adds a direct
  5575. check of the device state only under this condition where the
  5576. caller may be dropped incorrectly, resolving this issue without
  5577. affecting performance of app_queue normally. AST-1248 #close
  5578. Review: https://reviewboard.asterisk.org/r/3595/ Reported by:
  5579. Thomas Arimont ........ Merged revisions 415833 from
  5580. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5581. revisions 415835 from
  5582. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5583. revisions 415836 from
  5584. http://svn.asterisk.org/svn/asterisk/branches/12
  5585. 2014-06-12 15:39 +0000 [r415834] Jonathan Rose <jrose@digium.com>
  5586. * apps/app_mixmonitor.c, /, UPGRADE.txt: MixMontior: Add class
  5587. authorization requirements to MixMonitor AMI commands MixMonitor
  5588. AMI commands StartMixMonitor and StopMixMonitor lacked class
  5589. authorization. StopMixMonitor now requires that the manager user
  5590. either have the call or system class authorization.
  5591. StartMixMonitor is a slightly larger issue since it can execute
  5592. shell commands if the right arguments are passed into it, and we
  5593. consider this a permission escalation. A security release will be
  5594. issued for problem this shortly. ASTERISK-23609 #close Reported
  5595. by: Corey Farrell ........ Merged revisions 415825 from
  5596. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5597. revisions 415832 from
  5598. http://svn.asterisk.org/svn/asterisk/branches/12
  5599. 2014-06-12 14:39 +0000 [r415813] Kevin Harwell <kharwell@digium.com>
  5600. * res/res_pjsip_pubsub.c, /: res_pjsip_pubsub: unauthenticated
  5601. remote crash in PJSIP pub/sub framework A remotely exploitable
  5602. crash vulnerability exists in the PJSIP channel driver's pub/sub
  5603. framework. If an attempt is made to unsubscribe when not
  5604. currently subscribed and the endpoint's "sub_min_expiry" is set
  5605. to zero, Asterisk tries to create an expiration timer with zero
  5606. seconds, which is not allowed, so an assertion raised. The fix
  5607. was to reject a subscription that is attempting to unsubscribe
  5608. when not being already subscribed. Asterisk now checks for this
  5609. situation appropriately and responds with a 400 instead of
  5610. crashing. AST-2014-005 ASTERISK-23489 #close ........ Merged
  5611. revisions 415812 from
  5612. http://svn.asterisk.org/svn/asterisk/branches/12
  5613. 2014-06-12 14:15 +0000 [r415795] Mark Michelson <mmichelson@digium.com>
  5614. * res/res_pjsip.c, /: Fix potential deadlock situation in
  5615. res_pjsip. SIP transaction timeouts are handled in the PJSIP
  5616. monitor thread. When this happens on a subscription, and the
  5617. subscription is destroyed, the subscription destruction is
  5618. dispatched synchronously to the threadpool. The issue is that the
  5619. PJSIP dialog is locked by the monitor thread, and then the
  5620. dispatched task attempts to lock the dialog. This leads to a
  5621. deadlock that causes SIP traffic to no longer be accepted on the
  5622. Asterisk server. The fix here is to treat the monitor thread as
  5623. if it were a threadpool thread when it attempts to dispatch
  5624. synchronous tasks. This way, the dispatched task turns into a
  5625. simple function call within the same thread, and the locking
  5626. issue is averted. AST-2014-008 ASTERISK-23802 #close ........
  5627. Merged revisions 415794 from
  5628. http://svn.asterisk.org/svn/asterisk/branches/12
  5629. 2014-06-12 11:34 +0000 [r415767] Joshua Colp <jcolp@digium.com>
  5630. * res/res_pjsip.c, res/res_pjsip_pubsub.c,
  5631. res/res_pjsip_exten_state.c, include/asterisk/res_pjsip.h,
  5632. include/asterisk/res_pjsip_pubsub.h,
  5633. res/res_pjsip_pubsub.exports.in, /,
  5634. contrib/ast-db-manage/config/versions/c6d929b23a8_create_pjsip_subscription_persistence_.py
  5635. (added), res/res_pjsip_mwi.c: res_pjsip_pubsub: Persist
  5636. subscriptions in sorcery so they are recreated on startup. This
  5637. change makes res_pjsip_pubsub persist inbound subscriptions in
  5638. sorcery. By default this uses the local astdb but it can also be
  5639. configured to store within an outside database. When Asterisk is
  5640. started these subscriptions are recreated if they have not
  5641. expired. Notifications are sent to the devices which have
  5642. subscribed and they are none the wiser that the system has
  5643. restarted. Review: https://reviewboard.asterisk.org/r/3598/
  5644. ........ Merged revisions 415766 from
  5645. http://svn.asterisk.org/svn/asterisk/branches/12
  5646. 2014-06-12 07:52 +0000 [r415749] Walter Doekes <walter+asterisk@wjd.nu>
  5647. * UPGRADE.txt, contrib/scripts/safe_asterisk, Makefile, /:
  5648. safe_asterisk: Overwrite old safe_asterisk on make install. From
  5649. now on, make install will overwrite safe_asterisk with the latest
  5650. version. You need to move any local modifications to files inside
  5651. /etc/asterisk/startup.d, if you have any. See also commits
  5652. r394939 and r397938. ASTERISK-21965 #close Patches:
  5653. safe_asterisk.patch uploaded by jkister (License 6232, modified
  5654. by me) ........ Merged revisions 415748 from
  5655. http://svn.asterisk.org/svn/asterisk/branches/12
  5656. 2014-06-11 23:01 +0000 [r415730] Richard Mudgett <rmudgett@digium.com>
  5657. * main/format.c, /: format.c: Fix misuse of hash container
  5658. function. The supplied hash function to a container must be
  5659. idempotent given the object's key value to figure out which
  5660. container bucket the object belongs in. Returning a random number
  5661. or the current container count is not idempotent. The "computed
  5662. hash" value doesn't help find the object later in those cases. *
  5663. Fixed the format_list container to actually be a list since that
  5664. is how the container is used. Conceptually, if more than 283
  5665. formats were added to the format_list then odd things may have
  5666. happened before the fix. ........ Merged revisions 415728 from
  5667. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5668. revisions 415729 from
  5669. http://svn.asterisk.org/svn/asterisk/branches/12
  5670. 2014-06-11 20:22 +0000 [r415698-415715] Scott Griepentrog <sgriepentrog@digium.com>
  5671. * main/pbx.c: CLI: correct presence information on core show hints
  5672. Adds presence to core show hint and changes presence string
  5673. conversion to use the correct function. ASTERISK-23858 #close
  5674. Review: https://reviewboard.asterisk.org/r/3611/
  5675. * main/pbx.c: CLI: add presence information to core show hints Adds
  5676. presence state value to output of core show hints. Also reformats
  5677. the output slightly so it doesn't use as much space as it would
  5678. otherwise. Was: 1000@demo : SIP/1000 State:Unavailable Watchers 0
  5679. Now: 1000@demo : SIP/1000 State:Unavailable Presence:Idle
  5680. Watchers 0 AFS-53 #close Review:
  5681. https://reviewboard.asterisk.org/r/3604/
  5682. 2014-06-10 18:32 +0000 [r415679] Kinsey Moore <kmoore@digium.com>
  5683. * main/channel.c, /: Fix build in dev mode due to signed/unsigned
  5684. mismatch ........ Merged revisions 415678 from
  5685. http://svn.asterisk.org/svn/asterisk/branches/12
  5686. 2014-06-10 16:06 +0000 [r415659] Jonathan Rose <jrose@digium.com>
  5687. * main/message.c, /, res/res_pjsip_notify.c: PJSIP: PJSIPNotify -
  5688. Strip content-length headers and add documentation Documentation
  5689. for how to add custom headers/content to notifies created with
  5690. the PJSIPNotify manager action was a little sparse and it also
  5691. wasn't vetting application of Content-length headers like its
  5692. chan_sip equivalent was (so two Content-length headers could be
  5693. applied... and PJSIP determines the content length anyway, so it
  5694. just opens people up for error). This patch also flips the
  5695. variable order so that the variables are interpreted in the same
  5696. order as they are put in the AMI action. Review:
  5697. https://reviewboard.asterisk.org/r/3587/ ........ Merged
  5698. revisions 415658 from
  5699. http://svn.asterisk.org/svn/asterisk/branches/12
  5700. 2014-06-10 09:28 +0000 [r415630] Alexandr Anikin <may@telecom-service.ru>
  5701. * addons/chan_ooh323.c, /: chan_ooh323: fix loading module failure
  5702. if there no accessible h323_log or ooh323 config file change
  5703. return 1 to return AST_MODULE_LOAD_FAILURE on module load routine
  5704. few cosmetic changes ASTERISK-23814 #close (closes issue
  5705. ASTERISK-23814) Reported by: Igor Goncharovsky Patches:
  5706. ASTERISK-23814-ast11.patch ........ Merged revisions 415599 from
  5707. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5708. revisions 415602 from
  5709. http://svn.asterisk.org/svn/asterisk/branches/12
  5710. 2014-06-09 20:21 +0000 [r415580] Mark Michelson <mmichelson@digium.com>
  5711. * res/res_pjsip_header_funcs.c, /: chan_pjsip: Fix bug where custom
  5712. SIP headers could be duplicated on outgoing INVITEs. When using
  5713. PJSIP_HEADER() to add custom headers to outgoing INVITE requests,
  5714. certain situations could result in the headers being duplicated.
  5715. For instance, if the request were retransmitted, or if the INVITE
  5716. were re-sent with authentication credentials, the custom headers
  5717. would be re-added to the request. The fix here is to, after
  5718. adding the custom headers to the outbound INVITE, remove the
  5719. datastore that holds the custom headers to add. This way, there
  5720. is no risk in accidentally adding them if the session supplement
  5721. is called into a second or third time. ........ Merged revisions
  5722. 415579 from http://svn.asterisk.org/svn/asterisk/branches/12
  5723. 2014-06-09 12:12 +0000 [r415524] Walter Doekes <walter+asterisk@wjd.nu>
  5724. * /, UPGRADE.txt, contrib/scripts/safe_asterisk: safe_asterisk:
  5725. Cleanup additions to r415132. * Replaced a stray echo that
  5726. should've been a message call in safe_asterisk. This replaces a
  5727. conditional log message by a slightly different message. Please
  5728. update your log parsing scripts. * Made the $NOTIFY mail Subject
  5729. more verbose by adding the machine name and exitstatus. (Note
  5730. that a 'make install' still won't overwrite your old
  5731. safe_asterisk if it exists. See ASTERISK-21965.) ASTERISK-23492
  5732. #close ........ Merged revisions 415521 from
  5733. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5734. revisions 415522 from
  5735. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5736. revisions 415523 from
  5737. http://svn.asterisk.org/svn/asterisk/branches/12
  5738. 2014-06-09 03:50 +0000 [r415466] Corey Farrell <git@cfware.com>
  5739. * /, main/autoservice.c: autoservice: stop thread on graceful
  5740. shutdown This change adds thread shutdown to autoservice for
  5741. graceful shutdowns only. ast_register_cleanup is backported to
  5742. 1.8 to allow this. The logger callid is also released on shutdown
  5743. in 11+. ASTERISK-23827 #close Reported by: Corey Farrell Review:
  5744. https://reviewboard.asterisk.org/r/3594/ ........ Merged
  5745. revisions 415463 from
  5746. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5747. revisions 415464 from
  5748. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5749. revisions 415465 from
  5750. http://svn.asterisk.org/svn/asterisk/branches/12
  5751. 2014-06-08 18:12 +0000 [r415444] Matthew Jordan <mjordan@digium.com>
  5752. * include/asterisk/channel.h, bridges/bridge_native_rtp.c,
  5753. main/bridge_channel.c, main/channel.c, main/pbx.c, /,
  5754. main/framehook.c, main/bridge_after.c: bridges/bridge_native_rtp:
  5755. Reconfigure bridge on removal of framehook This patch is a re-do
  5756. of r414122. When r414122 was merged, a major problem with it was
  5757. uncovered. UNBRIDGE soft hangup flags have a catastrophic effect
  5758. on the pbx core if they leak out from the bridge layer: the
  5759. channel gets hung up. With the number of threads involved in a
  5760. blind transfer, and with the initial patch, it was likely that
  5761. this would occur. This caused a large number of test failures
  5762. This patch is nearly identical with the one proposed in r414122,
  5763. save for the following changes: - We explicitly clear the
  5764. UNBRIDGE flag when setting an after goto on a channel in a bridge
  5765. - Defensively, if we encounter an UNBRIDGE flag in the pbx core,
  5766. we handle it https://reviewboard.asterisk.org/r/3585/ ........
  5767. Merged revisions 415443 from
  5768. http://svn.asterisk.org/svn/asterisk/branches/12
  5769. 2014-06-07 00:42 +0000 [r415428] Richard Mudgett <rmudgett@digium.com>
  5770. * include/asterisk/bridge.h, /: bridge.h: Remove redundant struct
  5771. ast_bridge_channel forward declaration. ........ Merged revisions
  5772. 415427 from http://svn.asterisk.org/svn/asterisk/branches/12
  5773. 2014-06-06 21:44 +0000 [r415411] Jonathan Rose <jrose@digium.com>
  5774. * include/asterisk/manager.h, main/config.c, main/manager.c, /,
  5775. channels/chan_sip.c, include/asterisk/config.h: chan_sip: Fix
  5776. order of variables specified in SIPNotify action Prior to this
  5777. patch, sequential variables would be ordered in reverse from the
  5778. order specified in the manager action. Review:
  5779. https://reviewboard.asterisk.org/r/3588/ ........ Merged
  5780. revisions 415359 from
  5781. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5782. revisions 415390 from
  5783. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5784. revisions 415410 from
  5785. http://svn.asterisk.org/svn/asterisk/branches/12
  5786. 2014-06-06 20:45 +0000 [r415358] Kevin Harwell <kharwell@digium.com>
  5787. * main/uri.c, tests/test_websocket_client.c: core uri: Custom uri
  5788. parsing error when no query parameters If using the custom URI
  5789. parsing code (not external uriparser lib) and there was no query
  5790. parameters the resulting pointer would be NULL and then an
  5791. attempt was made to subtract from it. The pointer is now set to a
  5792. valid value if there is no query parameter(s). Also, in the
  5793. 'ast_uri_make_host_with_port' function when setting the
  5794. terminator on the resulting string it was writing it one past the
  5795. end of allocated memory. It now writes the string terminator
  5796. appropriately.
  5797. 2014-06-06 19:13 +0000 [r415343] Kinsey Moore <kmoore@digium.com>
  5798. * /, res/res_pjsip_sdp_rtp.c: PJSIP: Remove premature write of raw
  5799. formats Currently, there are situations that can occur when using
  5800. chan_pjsip and certain dialplan applications (notably ChanSpy())
  5801. that can cause the channel to get no audio with scrolling
  5802. warnings about format mismatches. This is caused by a failure to
  5803. update translation paths on a mid-call native format update since
  5804. the raw formats have already been updated by res_pjsip_sdp_rtp.c
  5805. in set_caps(). Removing the premature raw format updates allows
  5806. the translation paths to be setup correctly and the raw read and
  5807. write formats with them. AFS-63 #close ........ Merged revisions
  5808. 415342 from http://svn.asterisk.org/svn/asterisk/branches/12
  5809. 2014-06-06 14:12 +0000 [r415319] George Joseph <george.joseph@fairview5.com>
  5810. * tests/test_astobj2.c, main/astobj2_private.h (added),
  5811. main/astobj2.c, main/astobj2_container_private.h (added),
  5812. main/astobj2_container.c (added), main/astobj2_hash.c (added),
  5813. main/astobj2_rbtree.c (added), /, include/asterisk/astobj2.h:
  5814. Split astobj2.c into more maintainable components. Split
  5815. astobj2.c into the following files to improve maintainability.
  5816. astobj2.c - object primitives, object primitive misc and
  5817. initialization code. astobj2_private.h - internal object
  5818. declarations needed by the containers. astobj2_container.c -
  5819. generic conainer and container misc code.
  5820. astobj2_container_hash.c - hash container specific code.
  5821. astobj2_container_rbtree.c - rbtree container specific code.
  5822. astobj2_container_private.h - generic container definitions and
  5823. rtti prototypes. https://reviewboard.asterisk.org/r/3576/
  5824. ........ Merged revisions 415317 from
  5825. http://svn.asterisk.org/svn/asterisk/branches/12
  5826. 2014-06-06 12:49 +0000 [r415302] Rusty Newton <rnewton@digium.com>
  5827. * /, configs/cli_aliases.conf.sample: configs/cli_aliases.conf: Two
  5828. new aliases, plus enhancements for context names. Changed naming
  5829. of included alias templates to avoid confusion between version
  5830. names. For example, asterisk12 was for asterisk 1.2, so I changed
  5831. it to asterisk_1dot2, so that later we can use asterisk_12 for
  5832. Asterisk 12. Added alias for "features reload" to the template
  5833. for Asterisk 11 style syntax template, as features reload was
  5834. removed in 12, but you can still do "module reload features"
  5835. Added alias for "pjsip reload" to the friendly template. It is
  5836. shorter than "module reload res_pjsip.so" and if some are like
  5837. me; I constantly forget that reloading chan_pjsip doesn't parse
  5838. config. Remembering "pjsip reload" is just easier. ASTERISK-23654
  5839. #close ASTERISK-23654 #comment Fixed by adding two new aliases
  5840. and enhancements for context names. Review:
  5841. https://reviewboard.asterisk.org/r/3572/ ........ Merged
  5842. revisions 415301 from
  5843. http://svn.asterisk.org/svn/asterisk/branches/12
  5844. 2014-06-05 19:04 +0000 [r415231-415288] Richard Mudgett <rmudgett@digium.com>
  5845. * main/config.c: config: Fix indentation and missing curlies in
  5846. config_text_file_load().
  5847. * main/config.c, /: config: Fix config files not reloading when
  5848. only an included file changes. The twisted logic determining if a
  5849. config file should be reloaded was mostly broken and disabled.
  5850. The incorrect test that ASTERISK-23383 fixed actually reenabled
  5851. the broken logic. The incorrect test was causing the timestamp to
  5852. always be cleared which caused config files with includes to
  5853. always be reloaded. * Made wildcard includes always cause a
  5854. reload. Determining if a file was deleted cannot be determined
  5855. without restructuring the cache to determine if any files are
  5856. missing from the last files actually loaded. Also without
  5857. refactoring config_text_file_load(), the glob loop couldn't check
  5858. more than one file for changes anyway. * Made remove the cache
  5859. entry if the file no longer exists when trying to get its
  5860. timestamp or it is no longer a regular file. This fixes the
  5861. corner case where the file was loaded, then deleted, then the
  5862. config reloaded, then the file restored with the same timestamp,
  5863. and then the config reloaded again. * Made remove the cache entry
  5864. include list when actually loading the file. This gets rid of any
  5865. stale includes the file had from the last time the file was
  5866. loaded. ASTERISK-23683 #close Reported by: tootai Review:
  5867. https://reviewboard.asterisk.org/r/3575/ ........ Merged
  5868. revisions 415225 from
  5869. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5870. revisions 415229 from
  5871. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5872. revisions 415230 from
  5873. http://svn.asterisk.org/svn/asterisk/branches/12
  5874. 2014-06-05 17:22 +0000 [r415223] Kevin Harwell <kharwell@digium.com>
  5875. * tests/test_uri.c (added), include/asterisk/http_websocket.h,
  5876. main/http.c, main/uri.c (added), tests/test_websocket_client.c
  5877. (added), res/res_http_websocket.c, include/asterisk/http.h,
  5878. include/asterisk/uri.h (added),
  5879. res/res_http_websocket.exports.in: res_http_websocket: Create a
  5880. websocket client Added a websocket server client in Asterisk.
  5881. Asterisk has a websocket server, but not a client. The ability to
  5882. have Asterisk be able to connect to a websocket server can
  5883. potentially be useful for future work (for instance this could
  5884. allow ARI to connect back to some external system, although more
  5885. work would be needed in order to incorporate that). Also a couple
  5886. of things to note - proxy connection support has not been
  5887. implemented and there is limited http response code handling
  5888. (basically, it is connect or not). Also added an initial new URI
  5889. handling mechanism to core. Internet type URI's are parsed into a
  5890. data structure that contains pointers to the various parts of the
  5891. URI. (closes issue ASTERISK-23742) Reported by: Kevin Harwell
  5892. Review: https://reviewboard.asterisk.org/r/3541/
  5893. 2014-06-05 14:49 +0000 [r415208] Matthew Jordan <mjordan@digium.com>
  5894. * /, apps/app_confbridge.c: app_confbridge: Allow muting of users
  5895. waiting to enter a ConfBridge Prior to this patch, users waiting
  5896. to enter a ConfBridge were not considered when muted via the CLI
  5897. or via AMI. Instead, a confusing message would be emitted stating
  5898. that the channel did not exist. This patch allows a user to be
  5899. muted when waiting to enter a ConfBridge conference. This is
  5900. equivalent to start when muted, only toggled via the CLI or AMI.
  5901. Review: https://reviewboard.asterisk.org/r/3582 #ASTERISK-23824
  5902. #close patches: rb3582.patch uploaded by tm1000 (License 6524)
  5903. ........ Merged revisions 415206 from
  5904. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5905. revisions 415207 from
  5906. http://svn.asterisk.org/svn/asterisk/branches/12
  5907. 2014-06-05 11:59 +0000 [r415192] Kinsey Moore <kmoore@digium.com>
  5908. * /, channels/chan_pjsip.c: PJSIP: Send initial connected line
  5909. information This makes chan_pjsip send connected line information
  5910. when it is called so that connected line information is available
  5911. on the connected channel. (closes issue DPMA-442) Reported by:
  5912. John Bigelow Review: https://reviewboard.asterisk.org/r/3584/
  5913. ........ Merged revisions 415191 from
  5914. http://svn.asterisk.org/svn/asterisk/branches/12
  5915. 2014-06-04 20:16 +0000 [r415173] Walter Doekes <walter+asterisk@wjd.nu>
  5916. * /, contrib/scripts/safe_asterisk: safe_asterisk: Cleanup and
  5917. debian compatibility. Cleans up the safe_asterisk script and adds
  5918. the ASTSAFE_FOREGROUND option that allows the debian asterisk
  5919. init script to capture the right pid. * Drop the vim #modeline
  5920. which wasn't used. Use test consistently without the odd
  5921. configure xno syntax. Double quote all paths. General cleanup. *
  5922. Don't output message()s to the console but only to TTY if set. *
  5923. Allow TTY to be "no" as well as empty (debian compatibility with
  5924. debian/patches/safe_asterisk-config). * Add option to export
  5925. ASTSAFE_FOREGROUND=1 from the init script that calls this to
  5926. disable backgrounding. Debian uses a similar method in
  5927. debian/patches/safe_asterisk-nobg). ASTERISK-23492 #close Review:
  5928. https://reviewboard.asterisk.org/r/3574/ ........ Merged
  5929. revisions 415132 from
  5930. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5931. revisions 415171 from
  5932. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5933. revisions 415172 from
  5934. http://svn.asterisk.org/svn/asterisk/branches/12
  5935. 2014-06-04 14:13 +0000 [r415116-415118] Matthew Jordan <mjordan@digium.com>
  5936. * /, channels/chan_pjsip.c: chan_pjsip: Add debug in RTP Engine
  5937. glue callback This patch adds some debug statements that aid with
  5938. determining why a direct media request may or may not be
  5939. initiated. ........ Merged revisions 415117 from
  5940. http://svn.asterisk.org/svn/asterisk/branches/12
  5941. * res/res_pjsip_session.c, /: res_pjsip_session: Add debug
  5942. statement for session refreshes This small patch adds a debug
  5943. level 3 statement indicating how a session refresh is being sent
  5944. - either as a re-INVITE or as an UPDATE - and where the session
  5945. refresh is going. ........ Merged revisions 415115 from
  5946. http://svn.asterisk.org/svn/asterisk/branches/12
  5947. 2014-06-04 07:27 +0000 [r415080] Corey Farrell <git@cfware.com>
  5948. * /, apps/confbridge/include/confbridge.h, apps/app_confbridge.c:
  5949. app_confbridge: Correct verification of conference name length
  5950. Conference names were not checked for maximum length, allowing
  5951. unexpected behaviour. This change adds checking to ensure the
  5952. maximum length is not exceeded. The maximum length is also
  5953. changed from 32 to AST_MAX_EXTENSION. ASTERISK-23035 #close
  5954. Reported by: Iñaki Cívico Tested by: Iñaki Cívico Patches:
  5955. confbridge-enforce_max-1.8.patch uploaded by coreyfarrell
  5956. (license 5909) confbridge-enforce_max-11up.patch uploaded by
  5957. coreyfarrell (license 5909) ........ Merged revisions 415060 from
  5958. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5959. revisions 415066 from
  5960. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5961. revisions 415078 from
  5962. http://svn.asterisk.org/svn/asterisk/branches/12
  5963. 2014-06-03 07:36 +0000 [r415000] Walter Doekes <walter+asterisk@wjd.nu>
  5964. * /, funcs/func_odbc.c: func_odbc: Fix fixed size buffers fix
  5965. (r414968). The change that removed the fixed size buffers in
  5966. odbc-related code -- removing arbitrary column width limits --
  5967. was incomplete. This change adds: no segfault on writesql without
  5968. insertsql and return value checks after strdup. While I was in
  5969. the vicinity I cleaned up the linefeeds in the odbc function
  5970. descriptions, moved some code for clarity, removed some blobs and
  5971. noted (but didn't fix) that the 'odbc write ... exec' CLI command
  5972. doesn't behave as the dialplan equivalent when insertsql= is
  5973. used. ASTERISK-23582 #close Review:
  5974. https://reviewboard.asterisk.org/r/3579/ ........ Merged
  5975. revisions 414997 from
  5976. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  5977. revisions 414998 from
  5978. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  5979. revisions 414999 from
  5980. http://svn.asterisk.org/svn/asterisk/branches/12
  5981. 2014-06-01 15:32 +0000 [r414976] Joshua Colp <jcolp@digium.com>
  5982. * /, bridges/bridge_native_rtp.c: bridge_native_rtp: Take the
  5983. bridge type choice of both channels into account. The
  5984. bridge_native_rtp module currently uses the bridge result of the
  5985. first channel that joins a bridge as the ultimate result. This
  5986. means that if the first channel has direct media enabled but the
  5987. second does not a direct media bridge will still occur. This
  5988. change makes it so that both sides are taken into account. If
  5989. either side forbids the bridge or responds with a local bridge
  5990. result then either a generic or local bridge occurs.
  5991. ASTERISK-23541 #close Reported by: Justin E Review:
  5992. https://reviewboard.asterisk.org/r/3577/ ........ Merged
  5993. revisions 414975 from
  5994. http://svn.asterisk.org/svn/asterisk/branches/12
  5995. 2014-05-30 14:53 +0000 [r414949] Kinsey Moore <kmoore@digium.com>
  5996. * res/res_pjsip_refer.c, /: PJSIP: Prevent crash on blind transfer
  5997. Blind transfers don't go too well with NULL channels which can
  5998. occur if the channel has already been transferred away. (closes
  5999. issue ASTERISK-23718) Reported by: Jonathan Rose ........ Merged
  6000. revisions 414948 from
  6001. http://svn.asterisk.org/svn/asterisk/branches/12
  6002. 2014-05-30 12:42 +0000 [r414883-414935] Matthew Jordan <mjordan@digium.com>
  6003. * main/audiohook.c, CHANGES, res/ari/ari_model_validators.c,
  6004. res/ari/ari_model_validators.h, funcs/func_talkdetect.c (added),
  6005. include/asterisk/stasis_channels.h,
  6006. rest-api/api-docs/events.json, /, main/stasis_channels.c:
  6007. TALK_DETECT: A channel function that raises events when talking
  6008. is detected This patch adds a new channel function TALK_DETECT
  6009. that, when set on a channel, causes events indicating the
  6010. start/stop of talking on a channel to be emitted to both AMI and
  6011. ARI clients. The function allows setting both the silence
  6012. threshold (the length of silence after which we decide no one is
  6013. talking) as well as the talking threshold (the amount of energy
  6014. that counts as talking). Parameters can be updated on a channel
  6015. after talk detection has been enabled, and talk detection can be
  6016. removed at any time. The events raised by the function use a
  6017. nomenclature similar to existing AMI/ARI events. For AMI:
  6018. ChannelTalkingStart/ChannelTalkingStop For ARI:
  6019. ChannelTalkingStarted/ChannelTalkingFinished Review:
  6020. https://reviewboard.asterisk.org/r/3563/ #ASTERISK-23786 #close
  6021. Reported by: Matt Jordan ........ Merged revisions 414934 from
  6022. http://svn.asterisk.org/svn/asterisk/branches/12
  6023. * main/config.c, /: main/config.c: AMI action UpdateConfig EmptyCat
  6024. clears all categories When invoking UpdateConfig AMI action with
  6025. Action set to EmptyCat, Asterisk will make all categories empty
  6026. in the config but the one requested with a Cat variable. This is
  6027. due to a bug in ast_category_empty (main/config.c) that makes an
  6028. incorrect comparison for a category name. This patch corrects the
  6029. comparison such that only the requested category is cleared.
  6030. Review: https://reviewboard.asterisk.org/r/3573/ #ASTERISK-23803
  6031. #close Reported by: zvision patches: manager.c.diff uploaded by
  6032. zvision (License 5755) ........ Merged revisions 414880 from
  6033. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6034. revisions 414881 from
  6035. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6036. revisions 414882 from
  6037. http://svn.asterisk.org/svn/asterisk/branches/12
  6038. 2014-05-29 18:51 +0000 [r414861] Kinsey Moore <kmoore@digium.com>
  6039. * main/pbx.c, /: PBX: Prevent incorrect hint parsing Dynamic and
  6040. pattern matching hints should not be checked for their last known
  6041. state until they are instantiated by subscribers. (closes issue
  6042. AFS-56) Reported by: John Hardin Patch AFS-56-pbx.diff submitted
  6043. by Matt Jordan (license 6283) ........ Merged revisions 414813
  6044. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  6045. Merged revisions 414859 from
  6046. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6047. revisions 414860 from
  6048. http://svn.asterisk.org/svn/asterisk/branches/12
  6049. 2014-05-28 22:54 +0000 [r414798] Matthew Jordan <mjordan@digium.com>
  6050. * main/loader.c, include/asterisk/logger.h, res/res_config_curl.c,
  6051. cel/cel_odbc.c, res/res_config_odbc.c,
  6052. bridges/bridge_builtin_features.c, main/optional_api.c,
  6053. main/logger.c, main/config_options.c, cdr/cdr_odbc.c,
  6054. apps/app_mixmonitor.c, main/asterisk.c, res/res_odbc.c,
  6055. main/xmldoc.c, apps/app_voicemail.c, cel/cel_pgsql.c,
  6056. channels/chan_unistim.c, res/res_config_pgsql.c, main/pbx.c,
  6057. cdr/cdr_sqlite3_custom.c, res/res_fax.c, main/bridge.c,
  6058. apps/app_waitforsilence.c, cdr/cdr_adaptive_odbc.c,
  6059. res/parking/parking_applications.c, cdr/cdr_pgsql.c,
  6060. res/res_jabber.c: Logger/CLI/etc.: Fix some aesthetic issues;
  6061. reduce chatty verbose messages This patch addresses some
  6062. aesthetic issues in Asterisk. These are all just minor tweaks to
  6063. improve the look of the CLI when used in a variety of settings.
  6064. Specifically: * A number of chatty verbose messages were removed
  6065. or demoted to DEBUG messages. Verbose messages with a verbosity
  6066. level of 5 or higher were - if kept as verbose messages - demoted
  6067. to level 4. Several messages that were emitted at verbose level 3
  6068. were demoted to 4, as announcement of dialplan applications being
  6069. executed occur at level 3 (and so the effects of those
  6070. applications should generally be less). * Some verbose messages
  6071. that only appear when their respective 'debug' options are
  6072. enabled were bumped up to always be displayed. *
  6073. Prefix/timestamping of verbose messages were moved to the
  6074. verboser handlers. This was done to prevent duplication of
  6075. prefixes when the timestamp option (-T) is used with the CLI. *
  6076. Verbose magic is removed from messages before being emitted to
  6077. non-verboser handlers. This prevents the magic in multi-line
  6078. verbose messages (such as SIP debug traces or the output of
  6079. DumpChan) from being written to files. * _Slightly_ better
  6080. support for the "light background" option (-W) was added. This
  6081. includes using ast_term_quit in the output of XML documentation
  6082. help, as well as changing the "Asterisk Ready" prompt to bright
  6083. green on the default background (which stands a better chance of
  6084. being displayed properly than bright white). Review:
  6085. https://reviewboard.asterisk.org/r/3547/
  6086. 2014-05-28 20:53 +0000 [r414781] Rusty Newton <rnewton@digium.com>
  6087. * /, configs/pjsip.conf.sample: pjsip.conf: privkey_file should be
  6088. priv_key_file, mediaencryption=yes should be mediaencryption=sdes
  6089. privkey_file was missed in the snake case update. An example
  6090. included an invalid value for the mediaencryption option.
  6091. ........ Merged revisions 414780 from
  6092. http://svn.asterisk.org/svn/asterisk/branches/12
  6093. 2014-05-28 17:46 +0000 [r414764-414766] Matthew Jordan <mjordan@digium.com>
  6094. * rest-api/api-docs/deviceStates.json,
  6095. rest-api/api-docs/endpoints.json,
  6096. rest-api/api-docs/mailboxes.json, rest-api/api-docs/events.json,
  6097. /, rest-api/api-docs/asterisk.json,
  6098. rest-api/api-docs/applications.json,
  6099. rest-api/api-docs/playbacks.json,
  6100. rest-api/api-docs/channels.json, rest-api/api-docs/sounds.json,
  6101. rest-api/resources.json, include/asterisk/manager.h,
  6102. rest-api/api-docs/bridges.json,
  6103. rest-api/api-docs/recordings.json: AMI/ARI: Update version
  6104. numbers Update the semantic versioning of ARI to 1.3.0 and AMI to
  6105. 2.3.0 to account for backwards compatible changes going from
  6106. 12.2.0 to 12.3.0. ........ Merged revisions 414765 from
  6107. http://svn.asterisk.org/svn/asterisk/branches/12
  6108. * contrib/ast-db-manage/cdr/env.py, /: ast-db-manage/cdr/env.py:
  6109. Don't fail if a config file can't be loaded When generating SQL
  6110. files via the repotools alembic_creator.py script, a
  6111. configuration object is used programatically with SQLAlechemy, as
  6112. opposed to a configuration file. This patch ignores failures to
  6113. interpret a config file, as ... there isn't one in this case.
  6114. ........ Merged revisions 414763 from
  6115. http://svn.asterisk.org/svn/asterisk/branches/12
  6116. 2014-05-28 16:56 +0000 [r414748-414750] Richard Mudgett <rmudgett@digium.com>
  6117. * res/res_pjsip_session.c, include/asterisk/res_pjsip_session.h, /,
  6118. res/res_pjsip_t38.c: res_pjsip_session: Fix leaked video RTP
  6119. ports. Simply enabling PJSIP to negotiage a video codec (e.g.,
  6120. h264) would leak video RTP ports if the codec were not negotiated
  6121. by an incoming call. * Made add_sdp_streams() associate the
  6122. handler with the media stream if the handler handled the media
  6123. stream. Otherwise, when the ast_sip_session_media object was
  6124. destroyed it didn't know how to clean up the RTP resources. *
  6125. Fixed sdp_requires_deferral() associating the handler with the
  6126. media stream when deciding if the SDP processing needs to be
  6127. deferred for T.38. Like the leaked video RTP ports, the T.38
  6128. handler needs to clean up allocated resources from deciding if
  6129. SDP processing needs to be deffered. * Cleaned up some dead code
  6130. in handle_incoming_sdp() and sdp_requires_deferral().
  6131. ASTERISK-23721 #close Reported by: cervajs Review:
  6132. https://reviewboard.asterisk.org/r/3571/ ........ Merged
  6133. revisions 414749 from
  6134. http://svn.asterisk.org/svn/asterisk/branches/12
  6135. * /, CHANGES, apps/app_agent_pool.c: app_agent_pool: Return to
  6136. dialplan if the agent fails to ack the call. Improvements to the
  6137. agent pool functionality. * AgentRequest no longer hangs up the
  6138. caller if the agent fails to connect with the caller. It now
  6139. continues in the dialplan. * AgentRequest returns AGENT_STATUS
  6140. set to NOT_CONNECTED if the agent failed to connect with the
  6141. call. Most likely because the agent did not acknowledge the call
  6142. in time or got disconnected. * The agent alerting play file
  6143. configured by the agent.conf custom_beep option can now be
  6144. disabled by setting the option to an empty string. The agent is
  6145. effectively alerted to a call presence when MOH stops. * Fixed
  6146. bridge reference leak when the agent connects with a caller.
  6147. ASTERISK-23499 #close Reported by: Matt Jordan Review:
  6148. https://reviewboard.asterisk.org/r/3551/ ........ Merged
  6149. revisions 414747 from
  6150. http://svn.asterisk.org/svn/asterisk/branches/12
  6151. 2014-05-28 11:37 +0000 [r414696] Joshua Colp <jcolp@digium.com>
  6152. * res/res_config_odbc.c, /, funcs/func_odbc.c: res_config_odbc: Use
  6153. dynamically sized buffers to store row data so values do not get
  6154. truncated. ASTERISK-23582 #close ASTERISk-23582 #comment Reported
  6155. by: Walter Doekes Review:
  6156. https://reviewboard.asterisk.org/r/3557/ ........ Merged
  6157. revisions 414693 from
  6158. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6159. revisions 414694 from
  6160. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6161. revisions 414695 from
  6162. http://svn.asterisk.org/svn/asterisk/branches/12
  6163. 2014-05-28 09:43 +0000 [r414567-414679] Walter Doekes <walter+asterisk@wjd.nu>
  6164. * /, channels/chan_unistim.c: chan_unistim: Unlock mutex in rare
  6165. OOM condition. #ASTERISK-23792 #close Reported by: Peter Whisker
  6166. Review: https://reviewboard.asterisk.org/r/3567/ ........ Merged
  6167. revisions 414677 from
  6168. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6169. revisions 414678 from
  6170. http://svn.asterisk.org/svn/asterisk/branches/12
  6171. * /, channels/chan_sip.c: chan_sip: Start session timer at 200, not
  6172. at INVITE. Asterisk started counting the session timer at INVITE
  6173. while the other end correctly started at 200. This meant that for
  6174. short session-expiries (90 seconds) combined with long ringing
  6175. times (e.g. 30 seconds), asterisk would wrongly assume that the
  6176. timer was hit before the other end thought it was time to send a
  6177. session refresh. This resulted in prematurely ended calls. This
  6178. changes the session timer to start counting first at 200 like RFC
  6179. says it should. (Also removed a few excess NULL checks that would
  6180. never hit, because if they did, asterisk would have crashed
  6181. already.) ASTERISK-22551 #close Reported by: i2045 Review:
  6182. https://reviewboard.asterisk.org/r/3562/ ........ Merged
  6183. revisions 414620 from
  6184. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6185. revisions 414628 from
  6186. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6187. revisions 414636 from
  6188. http://svn.asterisk.org/svn/asterisk/branches/12
  6189. * res/res_config_odbc.c, /: res_config_odbc: Fix old and new
  6190. ast_string_field memory leaks. The ODBC realtime driver uses ^NN
  6191. parameter encoding to cope with the special meaning of the
  6192. semi-colon. A semi-colon in a field is interpreted as if the key
  6193. was supplied twice, something which isn't otherwise possible with
  6194. fixed database columns. E.g. allow=alaw;ulaw is parsed as
  6195. allow=alaw and allow=ulaw. A literal semi-colon is rewritten to
  6196. ^3B when stored in the database. The module uses a stringfield to
  6197. efficiently store the encoded parameters. However, this
  6198. stringfield wasn't always freed in some off-nominal cases. Commit
  6199. r413241 fixed initialization so the encoding for INSERT and
  6200. DELETE queries wouldn't crash. (Only SELECTs and UPDATEs worked
  6201. apparently.) But that commit forgot the frees. This change cleans
  6202. that up. Review: https://reviewboard.asterisk.org/r/3555/
  6203. ........ Merged revisions 414564 from
  6204. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6205. revisions 414565 from
  6206. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6207. revisions 414566 from
  6208. http://svn.asterisk.org/svn/asterisk/branches/12
  6209. 2014-05-25 02:37 +0000 [r414543] Matthew Jordan <mjordan@digium.com>
  6210. * /, main/core_unreal.c: core_unreal: Prevent double free of
  6211. core_unreal pvt When a channel is destroyed (such as via
  6212. ast_channel_release in off nominal paths in core_unreal), it will
  6213. attempt to free (via ast_free) the channel tech pvt. This is
  6214. problematic for a few reasons: 1. The channel tech pvt is an ao2
  6215. object in core_unreal. Free'ing the pvt directly is no good. 2.
  6216. The channel tech pvt's reference count is dropped just prior to
  6217. calling ast_channel_release, resulting in the pvt's destruction.
  6218. Hence, the channel destructor is free'ing an invalid pointer.
  6219. This patch keeps the dropping of the reference count, but sets
  6220. the pvt to NULL on the channel prior to releasing it. This models
  6221. what would occur if the channel was hung up directly. ........
  6222. Merged revisions 414542 from
  6223. http://svn.asterisk.org/svn/asterisk/branches/12
  6224. 2014-05-23 17:36 +0000 [r414529] Matthew Jordan <mjordan@digium.com>
  6225. * tests/test_cel.c, /: test_cel: Fix unit tests broken due to event
  6226. def changes from res_corosync This patch instructs test_cel to
  6227. skip any IE types it doesn't care about. The addition of the raw
  6228. and bitfield types caused the tests to fail. ........ Merged
  6229. revisions 414528 from
  6230. http://svn.asterisk.org/svn/asterisk/branches/12
  6231. 2014-05-23 14:36 +0000 [r414475] Kinsey Moore <kmoore@digium.com>
  6232. * main/event.c, /: Fix signed/unsigned build warnings ........
  6233. Merged revisions 414474 from
  6234. http://svn.asterisk.org/svn/asterisk/branches/12
  6235. 2014-05-22 16:19 +0000 [r414417] Richard Mudgett <rmudgett@digium.com>
  6236. * /, apps/app_meetme.c: app_meetme: Don't interrupt MOH for
  6237. waitmarked users. Occasionally, when the last marked user leaves
  6238. the conference, waitmarked users don't get MOH if MOH is supposed
  6239. to be played while a waitmarked user is waiting for another
  6240. marked user. * Made not interrupt MOH when the user is a
  6241. waitmarked user. The waitmarked user doesn't need to hear any
  6242. leave announcements from the conference as the user would have
  6243. already heard different leave announcements if they were enabled.
  6244. Apparently DAHDI occasionally sends unending non-silent streams
  6245. to these users or a normal user still in the conference has
  6246. continuous high background noise. These non-silent streams cause
  6247. MOH to be suspended while the never ending "announcement" is
  6248. played. Issue caused by ASTERISK-13680. AST-1349 #close Reported
  6249. by: Tyler Stewart Review:
  6250. https://reviewboard.asterisk.org/r/3543/ ........ Merged
  6251. revisions 414401 from
  6252. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6253. revisions 414402 from
  6254. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6255. revisions 414404 from
  6256. http://svn.asterisk.org/svn/asterisk/branches/12
  6257. 2014-05-22 16:09 +0000 [r414406] Scott Griepentrog <sgriepentrog@digium.com>
  6258. * rest-api/api-docs/events.json, /, res/stasis/app.c,
  6259. res/ari/resource_events.c, include/asterisk/stasis_app.h,
  6260. include/asterisk/stasis.h, apps/app_userevent.c,
  6261. res/ari/resource_events.h, res/ari/ari_model_validators.c,
  6262. CHANGES, main/stasis.c, res/ari/ari_model_validators.h,
  6263. include/asterisk/stasis_channels.h, res/res_ari_events.c,
  6264. main/stasis_channels.c, res/res_stasis.c,
  6265. main/manager_channels.c, main/stasis_endpoints.c: ARI: Add
  6266. ability to raise arbitrary User Events User events can now be
  6267. generated from ARI. Events can be signalled with arbitrary json
  6268. variables, and include one or more of channel, bridge, or
  6269. endpoint snapshots. An application must be specified which will
  6270. receive the event message (other applications can subscribe to
  6271. it). The message will also be delivered via AMI provided a
  6272. channel is attached. Dialplan generated user event messages are
  6273. still transmitted via the channel, and will only be received by a
  6274. stasis application they are attached to or if the channel is
  6275. subscribed to. This change also introduces the multi object blob
  6276. mechanism used to send multiple snapshot types in a single
  6277. message. The dialplan app UserEvent was also changed to use multi
  6278. object blob, and a new stasis message type created to handle
  6279. them. ASTERISK-22697 #close Review:
  6280. https://reviewboard.asterisk.org/r/3494/ ........ Merged
  6281. revisions 414405 from
  6282. http://svn.asterisk.org/svn/asterisk/branches/12
  6283. 2014-05-22 15:52 +0000 [r414403] Jonathan Rose <jrose@digium.com>
  6284. * include/asterisk/bridge.h, res/parking/parking_bridge_features.c,
  6285. channels/chan_mgcp.c, res/res_pjsip_refer.c,
  6286. channels/chan_dahdi.c, channels/sig_analog.c, /,
  6287. channels/chan_sip.c, main/parking.c, main/bridge.c,
  6288. main/bridge_basic.c, res/parking/parking_applications.c,
  6289. include/asterisk/parking.h: res_pjsip_refer: Fix bugs involving
  6290. Parking/PJSIP/transfers PJSIP would never send the final 200
  6291. Notify for a blind transfer when transferring to parking. This
  6292. patch fixes that. In addition, it fixes a reference leak when
  6293. performing blind transfers to non-bridging extensions. Review:
  6294. https://reviewboard.asterisk.org/r/3485/ ........ Merged
  6295. revisions 414400 from
  6296. http://svn.asterisk.org/svn/asterisk/branches/12
  6297. 2014-05-22 14:02 +0000 [r414331-414348] Matthew Jordan <mjordan@digium.com>
  6298. * /, UPGRADE.txt: UPGRADE: Add note for REF_DEBUG flag ........
  6299. Merged revisions 414345 from
  6300. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6301. revisions 414346 from
  6302. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6303. revisions 414347 from
  6304. http://svn.asterisk.org/svn/asterisk/branches/12
  6305. * res/res_corosync.c, include/asterisk/stasis.h, main/app.c,
  6306. main/devicestate.c, main/event.c, main/stasis.c,
  6307. include/asterisk/devicestate.h, include/asterisk/event.h,
  6308. main/stasis_message.c, /, include/asterisk/event_defs.h:
  6309. res_corosync: Update module to work with Stasis (and compile)
  6310. This patch fixes res_corosync such that it works with Asterisk
  6311. 12. This restores the functionality that was present in previous
  6312. versions of Asterisk, and ensures compatibility with those
  6313. versions by restoring the binary message format needed to pass
  6314. information from/to them. The following changes were made in the
  6315. core to support this: * The event system has been partially
  6316. restored. All event definition and event types in this patch were
  6317. pulled from Asterisk 11. Previously, we had hoped that this
  6318. information would live in res_corosync; however, the approach in
  6319. this patch seems to be better for a few reasons: (1)
  6320. Theoretically, ast_events can be used by any module as a binary
  6321. representation of a Stasis message. Given the structure of an
  6322. ast_event object, that information has to live in the core to be
  6323. used universally. For example, defining the payload of a device
  6324. state ast_event in res_corosync could result in an incompatible
  6325. device state representation in another module. (2) Much of this
  6326. representation already lived in the core, and was not easily
  6327. extensible. (3) The code already existed. :-) * Stasis message
  6328. types now have a message formatter that converts their payload to
  6329. an ast_event object. * Stasis message forwarders now handle
  6330. forwarding to themselves. Previously this would result in an
  6331. infinite recursive call. Now, this simply creates a new
  6332. forwarding object with no forwards set up (as it is the thing it
  6333. is forwarding to). This is advantageous for res_corosync, as
  6334. returning NULL would also imply an unrecoverable error. Returning
  6335. a subscription in this case allows for easier handling of message
  6336. types that are published directly to an aggregate topic that has
  6337. forwarders. Review: https://reviewboard.asterisk.org/r/3486/
  6338. ASTERISK-22912 #close ASTERISK-22372 #close ........ Merged
  6339. revisions 414330 from
  6340. http://svn.asterisk.org/svn/asterisk/branches/12
  6341. 2014-05-21 22:24 +0000 [r414297] Richard Mudgett <rmudgett@digium.com>
  6342. * /, main/core_unreal.c: core_unreal: Only block media frames when
  6343. a generator is on both ends of an unreal channel. The fix for
  6344. ASTERISK-12292 was a bit too aggressive. You could have
  6345. generators pointed at each other on local channels but need to
  6346. get other kinds of frames such as DTMF or CONNECTED_LINE frames
  6347. accross. ........ Merged revisions 414269 from
  6348. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6349. revisions 414270 from
  6350. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6351. revisions 414272 from
  6352. http://svn.asterisk.org/svn/asterisk/branches/12
  6353. 2014-05-21 19:08 +0000 [r414217] Scott Griepentrog <sgriepentrog@digium.com>
  6354. * /, funcs/func_strings.c: pbx.c: prevent potential crash from
  6355. recursive replace() Recurisve usage of replace() resulted in
  6356. corruption of the temporary string storage and potential crash.
  6357. By changing the string to be allocated separtely per instance,
  6358. this is eliminated. ASTERISK-23650 #comment Reported by: Roel van
  6359. Meer ASTERISK-23650 #close Review:
  6360. https://reviewboard.asterisk.org/r/3539/ ........ Merged
  6361. revisions 414214 from
  6362. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6363. revisions 414215 from
  6364. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6365. revisions 414216 from
  6366. http://svn.asterisk.org/svn/asterisk/branches/12
  6367. 2014-05-19 19:52 +0000 [r414196] Paul Belanger <paul.belanger@polybeacon.com>
  6368. * res/res_stasis_answer.c, /: Replace __ast_answer with
  6369. ast_raw_answer in app_control_answer While load testing an ARI
  6370. application, I noticed asterisk was returning HTTP 500 internal
  6371. server errors on channels/:id/answer. After talking to
  6372. #asterisk-dev, the issue appeared to be a lack of media flowing
  6373. after __ast_answer() was called. So now, we call ast_raw_answer
  6374. instead and no longer wait for media. ASTERISK-23758 #close
  6375. Review: https://reviewboard.asterisk.org/r/3549/ ........ Merged
  6376. revisions 414195 from
  6377. http://svn.asterisk.org/svn/asterisk/branches/12
  6378. 2014-05-19 01:10 +0000 [r414123-414138] Matthew Jordan <mjordan@digium.com>
  6379. * include/asterisk/channel.h, bridges/bridge_native_rtp.c,
  6380. main/bridge_channel.c, res/res_pjsip_refer.c,
  6381. res/res_pjsip_session.c, main/channel.c, /, main/framehook.c:
  6382. Undo r414123 The Test Suite caught a few problems, undoing until
  6383. those are resolved
  6384. * include/asterisk/channel.h, bridges/bridge_native_rtp.c,
  6385. main/bridge_channel.c, res/res_pjsip_session.c, main/channel.c,
  6386. /, main/framehook.c: bridge_native_rtp/bridge_channel: Fix direct
  6387. media issues due to frame hook This patch fixes issues with
  6388. direct media bridges that occur after a blind transfer. These
  6389. issues were caught by the (currently failing)
  6390. pjsip/transfers/blind_transfer/caller_direct_media test. The test
  6391. currently fails primarily for two reasons: (1) When Bob and
  6392. Charlie (the transfer target and the transfer destination) enter
  6393. a bridge together, the framehook remains on the transfer target
  6394. channel until both channels are in the bridge. As it consumes
  6395. voice frames, the initial bridge type is a simple bridge. The
  6396. framehook is removed when both channels are in the bridge;
  6397. however, this does not currently cause the bridging framework to
  6398. re-evaluate the bridge. This patch adds a AST_SOFTHANGUP_UNBRIDGE
  6399. poke to the transfer target channel when a framehook is removed
  6400. so the bridge can re-evaluate itself. (2) When a channel leaves a
  6401. native RTP bridge, it may be leaving due to being hung up.
  6402. Sending a re-INVITE to a channel that is about to be hung up is
  6403. not nice - in fact, there's a good chance we'll send the BYE
  6404. request before the channel has had a chance to send back a 200
  6405. OK. To be somewhat nicer, this patch adds a function to channel.h
  6406. that allows the bridging framework to query for exactly why a
  6407. channel is leaving a bridge via the channel's soft hangup flags.
  6408. This allows it to only send the re-INVITE if there's a chance the
  6409. channel will survive the native bridging experience. Review:
  6410. https://reviewboard.asterisk.org/r/3535/ ........ Merged
  6411. revisions 414122 from
  6412. http://svn.asterisk.org/svn/asterisk/branches/12
  6413. 2014-05-16 20:06 +0000 [r413994-414070] Richard Mudgett <rmudgett@digium.com>
  6414. * /, channels/chan_dahdi.c: chan_dahdi: Fix analog dialtone
  6415. detection. * Check if waitingfordt (waitfordialtone) is enabled
  6416. in dahdi_read() to allow the DSP to operate early enough to
  6417. detect dialtone. * Made use the correct variable in
  6418. my_check_waitingfordt(). ASTERISK-23709 #close Reported by: Steve
  6419. Davies Patches: dialtone_detect_fix (license #5012) patch
  6420. uploaded by Steve Davies Review:
  6421. https://reviewboard.asterisk.org/r/3534/ ........ Merged
  6422. revisions 414067 from
  6423. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6424. revisions 414068 from
  6425. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6426. revisions 414069 from
  6427. http://svn.asterisk.org/svn/asterisk/branches/12
  6428. * channels/sig_pri.c, /: sig_pri.c: Pull the pri_dchannel()
  6429. PRI_EVENT_RING case into its own function. * Populate the
  6430. CALLERID(ani2) value (and the special CALLINGANI2 channel
  6431. variable) with the ANI2 value in addition to the PRI specific
  6432. ANI2 channel variable. * Made complete snapshot staging with the
  6433. channel lock held. All channel snapshots need to be done while
  6434. the channel lock is held. ........ Merged revisions 414050 from
  6435. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6436. revisions 414051 from
  6437. http://svn.asterisk.org/svn/asterisk/branches/12
  6438. * /, apps/app_meetme.c: app_meetme: Fix overwrite of DAHDI
  6439. conference data structure. Starting a conference recording using
  6440. the admin menu overwrites the DAHDI conference data structure
  6441. used to modify the admin user's conference mute mode. * Made no
  6442. longer pass the user's DAHDI conference data structure into the
  6443. menu functions. The menu now uses its own DAHDI conference data
  6444. structure to start the recording channel. * Moved the unlock
  6445. conf->playlock to before playing the conf-full message. No sense
  6446. keeping the lock while that prompt is playing. The user is never
  6447. going to get into the conference at that point. ........ Merged
  6448. revisions 413991 from
  6449. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6450. revisions 413992 from
  6451. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6452. revisions 413993 from
  6453. http://svn.asterisk.org/svn/asterisk/branches/12
  6454. 2014-05-14 15:41 +0000 [r413897] Walter Doekes <walter+asterisk@wjd.nu>
  6455. * /, res/res_musiconhold.c: res_musiconhold: Minor cleanup. Fix a
  6456. few free()'s that should be ast_free()'s. Reverted an old
  6457. workaround that isn't necessary. Reorder a tiny bit of code.
  6458. Remove a bit of commented-out code. Review:
  6459. https://reviewboard.asterisk.org/r/3536/ ........ Merged
  6460. revisions 413894 from
  6461. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6462. revisions 413895 from
  6463. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6464. revisions 413896 from
  6465. http://svn.asterisk.org/svn/asterisk/branches/12
  6466. 2014-05-13 18:09 +0000 [r413878] Jonathan Rose <jrose@digium.com>
  6467. * main/netsock2.c, /, channels/chan_sip.c,
  6468. include/asterisk/netsock2.h: chan_sip: Add TLS and SRTP status to
  6469. CLI command 'sip show channel' ASTERISK-23564 #close Reported by:
  6470. Patrick Laimbock Review: https://reviewboard.asterisk.org/r/3474/
  6471. ........ Merged revisions 413876 from
  6472. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6473. revisions 413877 from
  6474. http://svn.asterisk.org/svn/asterisk/branches/12
  6475. 2014-05-13 13:53 +0000 [r413790-413793] Walter Doekes <walter+asterisk@wjd.nu>
  6476. * res/res_format_attr_h264.c, /: h264: Fix H264 SDP payload format.
  6477. https://tools.ietf.org/html/rfc3984#section-8.1 says
  6478. profile-level-id takes 3 bytes in base16 (6 hex digits). This
  6479. fixes video setup in certain cases. ASTERISK-23664 #close
  6480. ASTERISK-23664 #comment Patch r3530.patch uploaded by Guillaume
  6481. Maudoux. Review: https://reviewboard.asterisk.org/r/3530/
  6482. ........ Merged revisions 413791 from
  6483. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6484. revisions 413792 from
  6485. http://svn.asterisk.org/svn/asterisk/branches/12
  6486. * /, main/rtp_engine.c: rtp: Fix case typo in H263+ mime.
  6487. http://tools.ietf.org/html/rfc3555#section-4.2.6 says the
  6488. canonical mime subtype is "H263-1998", not "h263-1998". Original
  6489. code was added in r183101 on 2009-03-19 02:26:50 +0100. This
  6490. fixes issues with Polycom phones. ASTERISK-23665 #close
  6491. ASTERISK-23665 #comment Patch r3529.patch uploaded by Guillaume
  6492. Maudoux, backported by me. Review:
  6493. https://reviewboard.asterisk.org/r/3529/ ........ Merged
  6494. revisions 413787 from
  6495. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6496. revisions 413788 from
  6497. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6498. revisions 413789 from
  6499. http://svn.asterisk.org/svn/asterisk/branches/12
  6500. 2014-05-13 00:35 +0000 [r413770-413772] Richard Mudgett <rmudgett@digium.com>
  6501. * configure.ac, channels/sig_pri.c, /, configure,
  6502. include/asterisk/autoconfig.h.in: chan_dahdi/sig_pri: Prevent
  6503. unnecessary PROGRESS events when overlap dialing is enabled. When
  6504. overlap dialing is enabled, the lack of inband audio available
  6505. information in the SETUP_ACKNOWLEDGE events causes an
  6506. interoperability problem with SIP. sig_pri doesn't know if there
  6507. is dialtone present when a SETUP_ACKNOWLEDGE is received so it
  6508. assumes it is there and posts an AST_CONTROL_PROGRESS frame. The
  6509. SIP channel driver then sends out a 183 Session Progress and
  6510. blocks the desired 180 Ringing message when the ALERTING message
  6511. comes in. * Made the configure script detect if the installed
  6512. version of libpri supports the SETUP_ACKNOWLEDGE enhancements. *
  6513. Using the new API, made generate an AST_CONTROL_PROGRESS frame on
  6514. an incoming SETUP_ACKNOWLEDGE message when the message indicates
  6515. inband audio is present instead of assuming that dialtone is
  6516. present. * Using the new API, made SETUP_ACKNOWLEDGE send out an
  6517. inband audio available indication only if dialtone is expected.
  6518. The change also makes the fallback behaviour of sending the
  6519. PROGRESS message better by sending it only if dialtone is
  6520. expected. * Changed receiving a PROCEEDING message to not
  6521. generate an AST_CONTROL_PROGRESS frame if the progress indication
  6522. ie indicates non-end-to-end-ISDN. This helps interoperability
  6523. with SIP. * Changed sending a PROCEEDING message in response to
  6524. an AST_CONTROL_PROCEEDING frame to not indicate inband audio
  6525. available. It was silly to do so anyway because the channel
  6526. driver doesn't know if inband audio is even available. This helps
  6527. interoperability with SIP. This patch and a corresponding change
  6528. in libpri work together to allow Asterisk to control the inband
  6529. audio available progress indication ie on the SETUP_ACKNOWLEDGE
  6530. message when dialtone is present. AST-1338 #close Reported by:
  6531. Tyler Stewart Review: https://reviewboard.asterisk.org/r/3521/
  6532. ........ Merged revisions 413714 from
  6533. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6534. revisions 413765 from
  6535. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6536. revisions 413771 from
  6537. http://svn.asterisk.org/svn/asterisk/branches/12
  6538. * /, channels/sig_pri.c: Fix compiler warning from GCC 4.10 fixup.
  6539. ........ Merged revisions 413766 from
  6540. http://svn.asterisk.org/svn/asterisk/branches/12
  6541. 2014-05-12 22:33 +0000 [r413713] Jonathan Rose <jrose@digium.com>
  6542. * apps/app_chanspy.c, /: app_chanspy: Fix a test that was failing
  6543. on account of r413551 ASTERISK-23381 #close ASTERISK-23381
  6544. #comment Reported by: Robert Moss Review:
  6545. https://reviewboard.asterisk.org/r/3505/ ........ Merged
  6546. revisions 413710 from
  6547. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6548. revisions 413712 from
  6549. http://svn.asterisk.org/svn/asterisk/branches/12
  6550. 2014-05-11 02:09 +0000 [r413651-413682] Joshua Colp <jcolp@digium.com>
  6551. * main/bridge_basic.c, include/asterisk/channel.h,
  6552. bridges/bridge_native_rtp.c, include/asterisk/framehook.h,
  6553. main/channel.c, /, main/framehook.c: framehooks: Add callback for
  6554. determining if a hook is consuming frames of a specific type. In
  6555. the past framehooks have had no capability to determine what
  6556. frame types a hook is actually interested in consuming. This has
  6557. meant that code has had to assume they want all frames, thus
  6558. preventing native bridging. This change adds a callback which
  6559. allows a framehook to be queried for whether it is consuming a
  6560. frame of a specific type. The native RTP bridging module has also
  6561. been updated to take advantange of this, allowing native bridging
  6562. to occur when previously it would not. ASTERISK-23497 #comment
  6563. Reported by: Etienne Lessard ASTERISK-23497 #close Review:
  6564. https://reviewboard.asterisk.org/r/3522/ ........ Merged
  6565. revisions 413681 from
  6566. http://svn.asterisk.org/svn/asterisk/branches/12
  6567. * include/asterisk/channel.h, bridges/bridge_native_rtp.c,
  6568. include/asterisk/framehook.h, main/channel.c, /,
  6569. main/framehook.c, main/bridge_basic.c: Undoing framehook support.
  6570. Issues were uncovered by Bamboo.
  6571. * /, main/framehook.c, main/bridge_basic.c,
  6572. include/asterisk/channel.h, bridges/bridge_native_rtp.c,
  6573. include/asterisk/framehook.h, main/channel.c: framehooks: Add
  6574. callback for determining if a hook is consuming frames of a
  6575. specific type. In the past framehooks have had no capability to
  6576. determine what frame types a hook is actually interested in
  6577. consuming. This has meant that code has had to assume they want
  6578. all frames, thus preventing native bridging. This change adds a
  6579. callback which allows a framehook to be queried for whether it is
  6580. consuming a frame of a specific type. The native RTP bridging
  6581. module has also been updated to take advantange of this, allowing
  6582. native bridging to occur when previously it would not.
  6583. ASTERISK-23497 #comment Reported by: Etienne Lessard
  6584. ASTERISK-23497 #close Review:
  6585. https://reviewboard.asterisk.org/r/3522/ ........ Merged
  6586. revisions 413650 from
  6587. http://svn.asterisk.org/svn/asterisk/branches/12
  6588. 2014-05-09 23:18 +0000 [r413589-413599] Kinsey Moore <kmoore@digium.com>
  6589. * /, funcs/func_env.c: Fix 32bit build for func_env ........ Merged
  6590. revisions 413592 from
  6591. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6592. revisions 413595 from
  6593. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6594. revisions 413597 from
  6595. http://svn.asterisk.org/svn/asterisk/branches/12
  6596. * apps/app_festival.c, pbx/dundi-parser.c, apps/app_getcpeid.c,
  6597. main/netsock.c, funcs/func_channel.c, main/audiohook.c,
  6598. pbx/pbx_config.c, res/res_pjsip_registrar.c, main/xmldoc.c,
  6599. channels/iax2/firmware.c, apps/app_voicemail.c, main/format.c,
  6600. cel/cel_pgsql.c, main/rtp_engine.c, main/parking.c,
  6601. main/bridge.c, res/res_jabber.c, res/res_http_websocket.c,
  6602. main/config.c, res/res_format_attr_opus.c, main/loader.c,
  6603. res/parking/parking_bridge.c, main/cdr.c, main/manager.c,
  6604. include/asterisk/astobj.h, main/bucket.c, apps/app_dumpchan.c,
  6605. main/app.c, res/res_pjsip/config_transport.c,
  6606. res/res_pjsip_refer.c, channels/chan_mgcp.c,
  6607. res/res_rtp_asterisk.c, main/slinfactory.c, main/core_unreal.c,
  6608. res/res_pjsip_sdp_rtp.c, res/res_crypto.c, main/acl.c,
  6609. channels/sig_pri.c, res/res_monitor.c, res/res_srtp.c,
  6610. main/data.c, res/res_corosync.c, channels/sip/config_parser.c,
  6611. res/res_fax_spandsp.c, apps/app_stack.c, main/asterisk.c,
  6612. main/udptl.c, res/res_sorcery_config.c, main/security_events.c,
  6613. res/res_timing_dahdi.c, res/res_pjsip_t38.c,
  6614. res/res_musiconhold.c, main/taskprocessor.c,
  6615. res/res_format_attr_h263.c, res/res_xmpp.c, res/res_pktccops.c,
  6616. funcs/func_hangupcause.c, channels/chan_phone.c,
  6617. main/manager_bridges.c, cel/cel_odbc.c, channels/chan_skinny.c,
  6618. channels/chan_motif.c, res/res_agi.c, main/logger.c,
  6619. funcs/func_srv.c, channels/chan_alsa.c, apps/app_confbridge.c,
  6620. res/res_pjsip_pubsub.c, channels/sip/include/sip.h, main/sched.c,
  6621. apps/app_adsiprog.c, main/pbx.c, channels/chan_sip.c,
  6622. res/res_fax.c, main/aoc.c, res/res_calendar_ews.c,
  6623. res/parking/parking_bridge_features.c, channels/iax2/parser.c,
  6624. main/callerid.c, main/file.c,
  6625. res/res_pjsip/pjsip_configuration.c, main/adsi.c,
  6626. main/config_options.c, pbx/pbx_dundi.c, funcs/func_iconv.c,
  6627. main/bridge_channel.c, res/res_odbc.c, channels/chan_pjsip.c,
  6628. res/parking/parking_manager.c, res/res_calendar.c, /,
  6629. funcs/func_sysinfo.c, main/utils.c, cdr/cdr_adaptive_odbc.c,
  6630. res/res_calendar_caldav.c, res/res_stasis_snoop.c,
  6631. res/res_format_attr_h264.c, main/channel.c, res/ael/pval.c,
  6632. res/res_ari_model.c, channels/chan_dahdi.c,
  6633. channels/sig_analog.c, funcs/func_frame_trace.c,
  6634. res/res_format_attr_silk.c, main/manager_channels.c,
  6635. apps/app_dial.c, res/res_calendar_icalendar.c, main/translate.c,
  6636. apps/app_queue.c, channels/chan_jingle.c, res/res_stun_monitor.c,
  6637. main/abstract_jb.c, res/res_stasis_recording.c, apps/app_sms.c,
  6638. main/event.c, apps/app_verbose.c, main/dsp.c,
  6639. channels/chan_unistim.c, main/frame.c, res/res_stasis_playback.c,
  6640. main/ccss.c, funcs/func_env.c, main/devicestate.c,
  6641. bridges/bridge_softmix.c, channels/chan_gtalk.c,
  6642. channels/chan_iax2.c, main/enum.c, main/cli.c,
  6643. res/res_format_attr_celt.c, apps/confbridge/conf_config_parser.c,
  6644. main/io.c, channels/pjsip/dialplan_functions.c,
  6645. res/res_config_odbc.c, res/res_pjsip/location.c,
  6646. res/res_pjsip_outbound_registration.c, formats/format_pcm.c,
  6647. apps/app_minivm.c, main/stdtime/localtime.c, main/stun.c: Allow
  6648. Asterisk to compile under GCC 4.10 This resolves a large number
  6649. of compiler warnings from GCC 4.10 which cause the build to fail
  6650. under dev mode. The vast majority are signed/unsigned mismatches
  6651. in printf-style format strings. ........ Merged revisions 413586
  6652. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  6653. Merged revisions 413587 from
  6654. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6655. revisions 413588 from
  6656. http://svn.asterisk.org/svn/asterisk/branches/12
  6657. 2014-05-09 18:15 +0000 [r413572] Richard Mudgett <rmudgett@digium.com>
  6658. * main/http.c: http.c: Remove dead code.
  6659. 2014-05-09 17:03 +0000 [r413557] Jonathan Rose <jrose@digium.com>
  6660. * apps/app_chanspy.c, /: app_chanspy: Fix a bug where Barge mode
  6661. could fail If the barge audiohook was attached prior to the spyee
  6662. and its peer actually being bridged, the audiohook would not be
  6663. applied and the connected peer would not be able to hear audio
  6664. from the spy when the spy is in barge mode. (closes issue
  6665. ASTERISK-23381) Reported by: Robert Moss Review:
  6666. https://reviewboard.asterisk.org/r/3505/ ........ Merged
  6667. revisions 413551 from
  6668. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6669. revisions 413556 from
  6670. http://svn.asterisk.org/svn/asterisk/branches/12
  6671. 2014-05-08 00:36 +0000 [r413488] Joshua Colp <jcolp@digium.com>
  6672. * apps/app_queue.c, main/manager.c, /: app_queue: Extend
  6673. documentation for various Manager actions and events. ........
  6674. Merged revisions 413485 from
  6675. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6676. revisions 413486 from
  6677. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6678. revisions 413487 from
  6679. http://svn.asterisk.org/svn/asterisk/branches/12
  6680. 2014-05-07 21:58 +0000 [r413469] Mark Michelson <mmichelson@digium.com>
  6681. * funcs/func_presencestate.c: Ensure that presence state is decoded
  6682. properly on Asterisk startup. The CustomPresence provider
  6683. callback will automatically base64 decode stored data if the 'e'
  6684. option was present when the state was set. However, since the
  6685. provider callback was bypassed on Asterisk startup, encoded
  6686. presence subtypes and messages were being sent instead. This fix
  6687. makes it so the provider callback is always used when providing
  6688. presence state updates.
  6689. 2014-05-07 20:59 +0000 [r413453-413455] Richard Mudgett <rmudgett@digium.com>
  6690. * apps/app_confbridge.c, /: app_confbridge: Fixed "CBAnn" channels
  6691. not going away. Fixed a ref leak in conf_handle_talker_cb()
  6692. everytime the conference bridge was found to report a channel's
  6693. talker status change. The resulting leak caused the "CBAnn"
  6694. channels and the conference bridge to never be destroyed. Thanks
  6695. to Richard Kenner on the asterisk-user's list for locating the
  6696. problem. Reported by: Richard Kenner ........ Merged revisions
  6697. 413454 from http://svn.asterisk.org/svn/asterisk/branches/12
  6698. * apps/app_confbridge.c, /: app_confbridge: Fix ref leak in CLI
  6699. "confbridge kick" command. Fixed ref leak in the CLI "confbridge
  6700. kick" command when the channel to be kicked was not in the
  6701. conference. ........ Merged revisions 413451 from
  6702. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6703. revisions 413452 from
  6704. http://svn.asterisk.org/svn/asterisk/branches/12
  6705. 2014-05-07 17:56 +0000 [r413307-413399] Mark Michelson <mmichelson@digium.com>
  6706. * res/res_config_odbc.c, /: Fix encoding of custom prepare extra
  6707. data. Patches: res_config_odbc-take2.patch by John Hardin
  6708. (License #6512) ........ Merged revisions 413396 from
  6709. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6710. revisions 413397 from
  6711. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6712. revisions 413398 from
  6713. http://svn.asterisk.org/svn/asterisk/branches/12
  6714. * res/res_pjsip/presence_xml.c, /,
  6715. res/res_pjsip_pidf_digium_body_supplement.c: Improve XML
  6716. sanitization in NOTIFYs, especially for presence subtypes and
  6717. messages. Embedded carriage return line feed combinations may
  6718. appear in presence subtypes and messages since they may be
  6719. derived from user input in an instant messenger client. As such,
  6720. they need to be properly escaped so that XML parsers do not vomit
  6721. when the messages are received. ........ Merged revisions 413372
  6722. from http://svn.asterisk.org/svn/asterisk/branches/12
  6723. * res/res_pjsip_registrar.c, /: Check for an act on failures to
  6724. update contacts during registration. There was an underlying
  6725. issue in a realtime backend where database updates would fail.
  6726. Since we were not checking for failure, we would end up in a
  6727. strange state where the old database entry was still present but
  6728. Asterisk thought that it had been updated. Now when an entry
  6729. fails to update, we print a warning and delete the old contact
  6730. from sorcery so there is no mismatch between foreground and
  6731. backend state. Patches: res_pjsip_registrar.patch by John Hardin
  6732. (License #6512) ........ Merged revisions 413358 from
  6733. http://svn.asterisk.org/svn/asterisk/branches/12
  6734. * res/res_config_odbc.c, /: Ensure that all parts of SQL UPDATEs
  6735. and DELETEs are encoded. Patches: res_config_odbc.patch by John
  6736. Hardin (License #6512) ........ Merged revisions 413304 from
  6737. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6738. revisions 413305 from
  6739. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6740. revisions 413306 from
  6741. http://svn.asterisk.org/svn/asterisk/branches/12
  6742. 2014-05-02 20:28 +0000 [r413227-413263] Mark Michelson <mmichelson@digium.com>
  6743. * /, res/res_config_odbc.c: Prevent crashes in res_config_odbc due
  6744. to uninitialized string fields. Patches: odbc-crash.patch by John
  6745. Hardin (License #6512) ........ Merged revisions 413241 from
  6746. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6747. revisions 413251 from
  6748. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6749. revisions 413258 from
  6750. http://svn.asterisk.org/svn/asterisk/branches/12
  6751. * res/res_config_pgsql.c, /: Return the number of rows affected by
  6752. a SQL insert, rather than an object ID. The realtime API
  6753. specifies that the store callback is supposed to return the
  6754. number of rows affected. res_config_pgsql was instead returning
  6755. an Oid cast as an int, which during any nominal execution would
  6756. be cast to 0. Returning 0 when more than 0 rows were inserted
  6757. causes problems to the function's callers. To give an idea of how
  6758. strange code can be, this is the necessary code change to fix a
  6759. device state issue reported against chan_pjsip in Asterisk 12+.
  6760. The issue was that the registrar would attempt to insert contacts
  6761. into the database. Because of the 0 return from res_config_pgsql,
  6762. the registrar would think that the contact was not successfully
  6763. inserted, even though it actually was. As such, even though the
  6764. contact was query-able and it was possible to call the endpoint,
  6765. Asterisk would "think" the endpoint was unregistered, meaning it
  6766. would report the device state as UNAVAILABLE instead of
  6767. NOT_INUSE. The necessary fix applies to all versions of Asterisk,
  6768. so even though the bug reported only applies to Asterisk 12+, the
  6769. code correction is being inserted into 1.8+. Closes issue
  6770. ASTERISK-23707 Reported by Mark Michelson ........ Merged
  6771. revisions 413224 from
  6772. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  6773. revisions 413225 from
  6774. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6775. revisions 413226 from
  6776. http://svn.asterisk.org/svn/asterisk/branches/12
  6777. 2014-05-02 16:39 +0000 [r413211] Richard Mudgett <rmudgett@digium.com>
  6778. * UPGRADE.txt, res/res_pjsip_refer.c, /, channels/chan_sip.c:
  6779. res_pjsip_refer: Add Referred-By header on INVITE for blind
  6780. transfers. Per rfc3892, the Referred-By header in a REFER must be
  6781. copied into the referenced request (IE. The outgoing INVITE to
  6782. the transfer target). * Automatically put the Referred-By header
  6783. in the outgoing INVITE message if the SIPREFERREDBYHDR channel
  6784. variable is defined with a value. * Made
  6785. chan_sip.c:get_refer_info() set SIPREFERREDBYHDR for inheritance
  6786. so chan_pjsip has a better chance to interoperate. * Fixed
  6787. refer_blind_callback() and refer_incoming_refer_request() to not
  6788. modify the data in the pointer returned by
  6789. pjsip_msg_find_hdr_by_name(). It seems wrong to modify that data
  6790. since the calling routine doesn't own the buffer. ASTERISK-23501
  6791. #close Reported by: John Bigelow Review:
  6792. https://reviewboard.asterisk.org/r/3514/ ........ Merged
  6793. revisions 413210 from
  6794. http://svn.asterisk.org/svn/asterisk/branches/12
  6795. 2014-05-02 16:06 +0000 [r413197] Jonathan Rose <jrose@digium.com>
  6796. * res/parking/res_parking.h, /, CHANGES,
  6797. res/parking/parking_bridge_features.c,
  6798. res/parking/parking_manager.c: Parking: Add 'AnnounceChannel'
  6799. argument to manager action 'Park' (closes ASTERISK-23397)
  6800. Reported by: Denis Review:
  6801. https://reviewboard.asterisk.org/r/3446/ ........ Merged
  6802. revisions 413196 from
  6803. http://svn.asterisk.org/svn/asterisk/branches/12
  6804. 2014-05-01 16:21 +0000 [r413174-413183] Mark Michelson <mmichelson@digium.com>
  6805. * funcs/func_presencestate.c: Make behavior of the PRESENCE_STATE
  6806. 'e' option more consistent. When writing presence state, if 'e'
  6807. is specified, then the presence state will be stored in the astdb
  6808. encoded. However, consumers of presence state events or those
  6809. that query for the presence state will be given decoded
  6810. information. If base64 encoding is desired for consumers, then
  6811. the information can be base64-encoded manually and the 'e' option
  6812. can be omitted. closes issue ASTERISK-23671 Reported by Mark
  6813. Michelson Review: https://reviewboard.asterisk.org/r/3482
  6814. * res/res_pjsip_exten_state.c, /: Remove unnecessary repetition
  6815. checks from res_pjsip_exten_state The PBX core already takes care
  6816. of ensuring that repeated state changes are not communicated to
  6817. exten state consumers. Because the check in res_pjsip_exten_state
  6818. was incomplete, it was causing valid presence state changes not
  6819. to be sent out. For instance, if the presence state did not
  6820. change but the message or subtype did, then no presence-related
  6821. NOTIFY request would be sent out. closes issue ASTERISK-23672
  6822. Reported by Mark Michelson ........ Merged revisions 413173 from
  6823. http://svn.asterisk.org/svn/asterisk/branches/12
  6824. 2014-05-01 12:31 +0000 [r413160] Joshua Colp <jcolp@digium.com>
  6825. * res/res_pjsip/config_transport.c, /: res_pjsip: Add the ability
  6826. to configure ciphers based on name. Previously this code would
  6827. only accept the OpenSSL identifier instead of the documented
  6828. name. ASTERISK-23498 #close ASTERISK-23498 #comment Reported by:
  6829. Anthony Messina Review: https://reviewboard.asterisk.org/r/3491/
  6830. ........ Merged revisions 413159 from
  6831. http://svn.asterisk.org/svn/asterisk/branches/12
  6832. 2014-04-30 21:03 +0000 [r413144] Richard Mudgett <rmudgett@digium.com>
  6833. * main/message.c, /, channels/chan_sip.c,
  6834. include/asterisk/message.h, res/res_pjsip_messaging.c:
  6835. chan_sip.c: Fixed off-nominal message iterator ref count and
  6836. alloc fail issues. * Fixed early exit in sip_msg_send() not
  6837. destroying the message iterator. * Made
  6838. ast_msg_var_iterator_next() and ast_msg_var_iterator_destroy()
  6839. tolerant of a NULL iter parameter in case
  6840. ast_msg_var_iterator_init() fails. * Made
  6841. ast_msg_var_iterator_destroy() clean up any current message data
  6842. ref. * Made struct ast_msg_var_iterator,
  6843. ast_msg_var_iterator_init(), ast_msg_var_iterator_next(),
  6844. ast_msg_var_unref_current(), and ast_msg_var_iterator_destroy()
  6845. use iter instead of i. * Eliminated RAII_VAR usage in
  6846. res_pjsip_messaging.c:vars_to_headers(). ........ Merged
  6847. revisions 413139 from
  6848. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6849. revisions 413142 from
  6850. http://svn.asterisk.org/svn/asterisk/branches/12
  6851. 2014-04-30 20:39 +0000 [r413141] Joshua Colp <jcolp@digium.com>
  6852. * /, channels/chan_pjsip.c: chan_pjsip: Fix deadlock when
  6853. retrieving call-id of channel. If a task was in-flight which
  6854. required the channel or bridge lock it was possible for the
  6855. synchronous task retrieving the call-id to deadlock as it holds
  6856. those locks. After discussing with Mark Michelson the synchronous
  6857. task was removed and the call-id accessed directly. This should
  6858. be safe as each object involved is guaranteed to exist and the
  6859. call-id will never change. ........ Merged revisions 413140 from
  6860. http://svn.asterisk.org/svn/asterisk/branches/12
  6861. 2014-04-30 13:08 +0000 [r413125] Kinsey Moore <kmoore@digium.com>
  6862. * res/res_http_websocket.c, /: Websocket: Add session locking and
  6863. delay close This resolves a race condition where data could be
  6864. written to a NULL FILE pointer causing a crash as a websocket
  6865. connection was in the process of shutting down by adding locking
  6866. to websocket session writes and by deferring session teardown
  6867. until session destruction. (closes issue ASTERISK-23605) Review:
  6868. https://reviewboard.asterisk.org/r/3481/ Reported by: Matt Jordan
  6869. ........ Merged revisions 413123 from
  6870. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6871. revisions 413124 from
  6872. http://svn.asterisk.org/svn/asterisk/branches/12
  6873. 2014-04-30 12:42 +0000 [r413118-413122] Joshua Colp <jcolp@digium.com>
  6874. * /, res/stasis/control.c: res_stasis: Add progress indications to
  6875. operations which perform media. This change fixes operations
  6876. which did not account for the fact that they may be executed on
  6877. channels which have not been answered. These operations will now
  6878. indicate progress when invoked. ASTERISK-23560 #close
  6879. ASTERISk-23560 #comment Reported by: Jan Svoboda Review:
  6880. https://reviewboard.asterisk.org/r/3495/ ........ Merged
  6881. revisions 413121 from
  6882. http://svn.asterisk.org/svn/asterisk/branches/12
  6883. * /, res/res_pjsip_sdp_rtp.c: res_pjsip_sdp_rtp: Fix issue where
  6884. sending a hold SDP twice could cause an unhold. This change fixes
  6885. a bug where if an SDP with media address and sendonly was
  6886. received twice the underlying call would go off hold, instead of
  6887. remaining on hold. This occured because the code did not properly
  6888. take into account that the SDP may contain both a valid media
  6889. address and the sendonly attribute. The code now examines the
  6890. sendonly attribute and media address first, so if the SDP is
  6891. received again no change will occur. ASTERISK-23558 #comment
  6892. Reported by: John Bigelow Review:
  6893. https://reviewboard.asterisk.org/r/3472/ ........ Merged
  6894. revisions 413119 from
  6895. http://svn.asterisk.org/svn/asterisk/branches/12
  6896. * channels/chan_pjsip.c, res/res_pjsip_session.c, /: chan_pjsip:
  6897. Add support for picking up calls in the configured pickup group.
  6898. AST-1363 Review: https://reviewboard.asterisk.org/r/3478/
  6899. ........ Merged revisions 413117 from
  6900. http://svn.asterisk.org/svn/asterisk/branches/12
  6901. 2014-04-29 15:10 +0000 [r413103] George Joseph <george.joseph@fairview5.com>
  6902. * /, include/asterisk/spinlock.h: Add "destroy" implementation for
  6903. spinlock. The original commit for spinlock was missing "destroy"
  6904. implementations. Most of them are no-ops but phtread_spin and
  6905. pthread_mutex do need their locks destroyed. ........ Merged
  6906. revisions 413102 from
  6907. http://svn.asterisk.org/svn/asterisk/branches/12
  6908. 2014-04-29 11:27 +0000 [r413089] Joshua Colp <jcolp@digium.com>
  6909. * channels/chan_pjsip.c, /: chan_pjsip: Implement core ability to
  6910. get Call-ID of a channel. This changes implement the
  6911. "get_pvt_uniqueid" which is used to return the technology
  6912. specific unique identifier. In the case of SIP this is the
  6913. Call-ID of the dialog. Review:
  6914. https://reviewboard.asterisk.org/r/3480/ ........ Merged
  6915. revisions 413088 from
  6916. http://svn.asterisk.org/svn/asterisk/branches/12
  6917. 2014-04-28 20:07 +0000 [r413074] Kinsey Moore <kmoore@digium.com>
  6918. * /, main/bridge.c, main/bridge_basic.c: Bridging: Don't lock NULL
  6919. bridges When bridge locking was added for bridge snapshot
  6920. creation, some locations where bridge locking was added were not
  6921. guaranteed to actually have a bridge and locking NULL AO2 objects
  6922. tends to cause segfaults. This ensures that NULL bridges aren't
  6923. locked. ........ Merged revisions 413073 from
  6924. http://svn.asterisk.org/svn/asterisk/branches/12
  6925. 2014-04-28 14:40 +0000 [r413060] Mark Michelson <mmichelson@digium.com>
  6926. * res/res_manager_presencestate.c (added), main/devicestate.c,
  6927. CHANGES, main/presencestate.c, res/res_manager_devicestate.c
  6928. (added): Add DeviceStateChanged and PresenceStateChanged AMI
  6929. events. These events are controlled by two new modules,
  6930. res_manager_devicestate and res_manager_presencestate. Review:
  6931. https://reviewboard.asterisk.org/r/3417
  6932. 2014-04-28 07:43 +0000 [r413048] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  6933. * UPGRADE.txt, CHANGES, channels/chan_unistim.c,
  6934. configs/unistim.conf.sample: Introducing changes proposed to
  6935. chan_unistim driver: 1) Added the unistim.conf variable
  6936. dtmf_duration which can select the DTMF playback duration from
  6937. 0ms to 150ms (0 is off and is the new default) 2) Enabled the
  6938. transmission of month names, which are sent with the date and
  6939. changed the dateformat variable to accept the values 0-3 as per
  6940. the UNISTIM standard (2 & 3 match the previous 1 & 2 formats). 3)
  6941. Enabled the "Mute" packet so muting microphone works as expected
  6942. and microphone muted for all calls while LED light on 4) Changed
  6943. Duree to Timer on i2004 display (closes issue ASTERISK-23592)
  6944. 2014-04-27 19:29 +0000 [r413036] Olle Johansson <oej@edvina.net>
  6945. * main/tcptls.c: tcptls.c : Log errors as ERROR, not warning or
  6946. something else.
  6947. 2014-04-25 19:26 +0000 [r413012] Matthew Jordan <mjordan@digium.com>
  6948. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Add support for DTLS
  6949. handshake retransmissions On congested networks, it is possible
  6950. for the DTLS handshake messages to get lost. This patch adds a
  6951. timer to res_rtp_asterisk that will periodically check to see if
  6952. the handshake has succeeded. If not, it will retransmit the DTLS
  6953. handshake. Review: https://reviewboard.asterisk.org/r/3337
  6954. ASTERISK-23649 #close Reported by: Nitesh Bansal patches:
  6955. dtls_retransmission.patch uploaded by Nitesh Bansal (License
  6956. 6418) ........ Merged revisions 413008 from
  6957. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  6958. revisions 413009 from
  6959. http://svn.asterisk.org/svn/asterisk/branches/12
  6960. 2014-04-24 14:37 +0000 [r412993] Kevin Harwell <kharwell@digium.com>
  6961. * /,
  6962. contrib/ast-db-manage/config/versions/e96a0b8071c_increase_pjsip_column_size.py
  6963. (added): pjsip realtime: increase the size of some columns The
  6964. string lengths on certain columns created through alembic for
  6965. PJSIP were too short. For instance, columns containing URIs are
  6966. currently set to 40 characters, but this can be too small and
  6967. result in truncated values. Added an alembic migration script
  6968. that increases the size of these columns and a few others to 255.
  6969. ASTERISK-23639 #close Reported by: Mark Michelson Review:
  6970. https://reviewboard.asterisk.org/r/3475/ ........ Merged
  6971. revisions 412992 from
  6972. http://svn.asterisk.org/svn/asterisk/branches/12
  6973. 2014-04-23 20:13 +0000 [r412977] George Joseph <george.joseph@fairview5.com>
  6974. * include/asterisk/spinlock.h (added), /, configure,
  6975. include/asterisk/autoconfig.h.in, configure.ac: This patch adds
  6976. support for spinlocks in Asterisk. There are cases in Asterisk
  6977. where it might be desirable to lock a short critical code section
  6978. but not incur the context switch and yield penalty of a mutex or
  6979. rwlock. The primary spinlock implementations execute exclusively
  6980. in userspace and therefore don't incur those penalties. Spinlocks
  6981. are NOT meant to be a general replacement for mutexes. They
  6982. should be used only for protecting short blocks of critical code
  6983. such as simple compares and assignments. Operations that may
  6984. block, hold a lock, or cause the thread to give up it's timeslice
  6985. should NEVER be attempted in a spinlock. The first use case for
  6986. spinlocks is in astobj2 - internal_ao2_ref. Currently the
  6987. manipulation of the reference counter is done with an
  6988. ast_atomic_fetchadd_int which works fine. When weak reference
  6989. containers are introduced however, there's an additional
  6990. comparison and assignment that'll need to be done while the lock
  6991. is held. A mutex would be way too expensive here, hence the
  6992. spinlock. Given that lock contention in this situation would be
  6993. infrequent, the overhead of the spinlock is only a few more
  6994. machine instructions than the current ast_atomic_fetchadd_int
  6995. call. ASTERISK-23553 #close Review:
  6996. https://reviewboard.asterisk.org/r/3405/ ........ Merged
  6997. revisions 412976 from
  6998. http://svn.asterisk.org/svn/asterisk/branches/12
  6999. 2014-04-23 18:03 +0000 [r412925] Richard Mudgett <rmudgett@digium.com>
  7000. * /, main/http.c: http: Fix spurious ERROR message in responses
  7001. with no content. Backport -r411687 and fix the fix because
  7002. content_length is the length of out plus the length of the file
  7003. controlled by fd. When a response has an out content length of 0,
  7004. fwrite would be called to write a buffer with no data in it. This
  7005. resulted in the following classic error message: [Apr 3 11:49:17]
  7006. ERROR[26421] http.c: fwrite() failed: Success This patch makes it
  7007. so that we only attempt to write the content of out if the out
  7008. string is non-zero. ........ Merged revisions 412922 from
  7009. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7010. revisions 412923 from
  7011. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7012. revisions 412924 from
  7013. http://svn.asterisk.org/svn/asterisk/branches/12
  7014. 2014-04-23 15:02 +0000 [r412910] Russell Bryant <russell@russellbryant.com>
  7015. * res/res_monitor.c, funcs/func_periodic_hook.exports.in (added),
  7016. main/asterisk.dynamics, funcs/func_periodic_hook.c: Fix error
  7017. loading res_monitor. For some odd reason, loading app_mixmonitor
  7018. was fine, but res_monitor was not. This patch fixes a set of
  7019. issues related to func_periodic_hook exporting the beep functions
  7020. that gets res_monitor working again.
  7021. 2014-04-22 10:09 +0000 [r412883] Joshua Colp <jcolp@digium.com>
  7022. * /, res/stasis/app.c: res_stasis: Fix crash when handling a failed
  7023. blind transfer message. This changes fixes a crash that occurs
  7024. when stasis determines if it should send a message out to an
  7025. application or not. The code incorrectly assumed that a bridge
  7026. snapshot would always be present when in reality for failure
  7027. cases it may not be. ASTERISK-23573 #close ........ Merged
  7028. revisions 412882 from
  7029. http://svn.asterisk.org/svn/asterisk/branches/12
  7030. 2014-04-21 17:56 +0000 [r412759-412824] Jonathan Rose <jrose@digium.com>
  7031. * CHANGES, /: chan_sip: trust_id_outbound CHANGES message
  7032. improvement (closes issue AST-1301) (closes issue ASTERISK-19465)
  7033. Reported by: Krzysztof Chmielewski ........ Merged revisions
  7034. 412821 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  7035. ........ Merged revisions 412822 from
  7036. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7037. revisions 412823 from
  7038. http://svn.asterisk.org/svn/asterisk/branches/12
  7039. * /, channels/chan_sip.c, configs/sip.conf.sample, CHANGES,
  7040. channels/sip/include/sip.h: chan_sip: Add sendrpid trust options
  7041. In r411189, some behavior was changed which made sendrpid
  7042. behavior act in a more trusting manner by sending full user data
  7043. for peers set with private caller presence in P-Asserted-Identity
  7044. headers. Since this changed long time expected behaviors, we
  7045. decided to pull that patch when that was pointed out by the
  7046. community. Instead, this patch provides a trust_id_outbound
  7047. setting which will expose the data per RFC-3325 if set to 'yes'
  7048. and simply not send the PAI/RPID headers at all if set to 'no'.
  7049. By default trust_id_outbound will be set to 'legacy' which will
  7050. preserve the behavior prior to these patches. Extra special
  7051. thanks to Walter Doekes for providing advice and feedback.
  7052. (closes issue AST-1301) (closes issue ASTERISK-19465) Reported
  7053. by: Krzysztof Chmielewski Review:
  7054. https://reviewboard.asterisk.org/r/3447/ ........ Merged
  7055. revisions 412744 from
  7056. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7057. revisions 412746 from
  7058. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7059. revisions 412747 from
  7060. http://svn.asterisk.org/svn/asterisk/branches/12
  7061. 2014-04-21 16:16 +0000 [r412729-412750] Kinsey Moore <kmoore@digium.com>
  7062. * main/http.c, main/manager.c, /: HTTP: Add TCP_NODELAY to accepted
  7063. connections This adds the TCP_NODELAY option to accepted
  7064. connections on the HTTP server built into Asterisk. This option
  7065. disables the Nagle algorithm which controls queueing of outbound
  7066. data and in some cases can cause delays on receipt of response by
  7067. the client due to how the Nagle algorithm interacts with TCP
  7068. delayed ACK. This option is already set on all non-HTTP AMI
  7069. connections and this change would cover standard HTTP requests,
  7070. manager HTTP connections, and ARI HTTP requests and websockets in
  7071. Asterisk 12+ along with any future use of the HTTP server.
  7072. Review: https://reviewboard.asterisk.org/r/3466/ ........ Merged
  7073. revisions 412745 from
  7074. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7075. revisions 412748 from
  7076. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7077. revisions 412749 from
  7078. http://svn.asterisk.org/svn/asterisk/branches/12
  7079. * apps/app_confbridge.c, /: Confbridge: Fix ConfbridgeKick AMI
  7080. documentation This adds documentation for the "all" channel
  7081. option for the ConfbridgeKick AMI action and adjusts AMI
  7082. responses accordingly. (issue ASTERISK-23282) Reported by: Dorian
  7083. Logan ........ Merged revisions 412730 from
  7084. http://svn.asterisk.org/svn/asterisk/branches/12
  7085. * /, apps/app_confbridge.c: Confbridge: Add references for kick all
  7086. option After the ability to kick all attendees from a conference
  7087. was added, a rework removed the comment about that feature from
  7088. the CLI documentation. This adds that documentation and adds
  7089. "all" to the participant tab completion list for the confbridge
  7090. kick command. (closes issue ASTERISK-23282) Reported by: Dorian
  7091. Logan ........ Merged revisions 412728 from
  7092. http://svn.asterisk.org/svn/asterisk/branches/12
  7093. 2014-04-21 08:36 +0000 [r412714] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  7094. * /, channels/chan_unistim.c: Fix wrong dialtone. The "modulation"
  7095. should not be referenced for tone+tone as it refers to the on-off
  7096. characteristic - this often resulted in a single tone rather than
  7097. the multitone as in the UK. ........ Merged revisions 412712 from
  7098. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7099. revisions 412713 from
  7100. http://svn.asterisk.org/svn/asterisk/branches/12
  7101. 2014-04-19 02:14 +0000 [r412697-412699] Matthew Jordan <mjordan@digium.com>
  7102. * /, main/asterisk.c: main/asterisk: Fix startup sequence for
  7103. realtime features When ASTERISK-23265/ASTERISK-23320 was fixed,
  7104. it inadvertently led to realtime features breaking. This was due
  7105. to features loading prior to realtime. This patch fixes this by
  7106. loading features after loading dynamic modules. ASTERISK-23487
  7107. #close Reported by: Denis Tested by: Denis ........ Merged
  7108. revisions 412698 from
  7109. http://svn.asterisk.org/svn/asterisk/branches/12
  7110. * /, apps/app_sms.c: app_sms: Fix uninitialized values; hangup
  7111. channel when REL is sent successfully This patch fixes two issues
  7112. in app_sms: (1) Firstly, the 'flags' field on the stack in
  7113. sms_exec() is uninitialised, causing it to use the wrong protocol
  7114. in some cases. This patch correctly initializes the flags fields.
  7115. (2) Secondly, when disconnect supervision is not working or
  7116. inbanddisconnect=yes is set in chan_dahdi.conf, app_sms was
  7117. failing to terminate the call after it sent the REL(ease) message
  7118. and the peer stopped talking to it. This patch fixes the code to
  7119. handle the 'bad stop bit' message more gracefully in that case,
  7120. and hang up the call. Review:
  7121. https://reviewboard.asterisk.org/r/1392/ ASTERISK-18331 #close
  7122. Reported by: David Woodhouse patches: asterisk-fix-sms.patch
  7123. uploaded by David Woodhouse (License 5754) ........ Merged
  7124. revisions 412655 from
  7125. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7126. revisions 412656 from
  7127. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7128. revisions 412657 from
  7129. http://svn.asterisk.org/svn/asterisk/branches/12
  7130. 2014-04-18 20:09 +0000 [r412641] Jonathan Rose <jrose@digium.com>
  7131. * /, res/ari/resource_bridges.h, res/stasis/control.c,
  7132. include/asterisk/stasis_app.h, res/stasis/control.h,
  7133. res/ari/resource_channels.c, CHANGES, res/res_stasis.c,
  7134. rest-api/api-docs/bridges.json, res/ari/resource_bridges.c,
  7135. res/res_ari_bridges.c, res/res_stasis_playback.c: ARI: Make
  7136. bridges/{bridgeID}/play queue sound files Previously multiple
  7137. play actions against a bridge at one time would cause the sounds
  7138. to play simultaneously on the bridge. Now if a sound is already
  7139. playing, the play action will queue playback to occur after the
  7140. completion of other sounds currently on the queue. (closes issue
  7141. ASTERISK-22677) Reported by: John Bigelow Review:
  7142. https://reviewboard.asterisk.org/r/3379/ ........ Merged
  7143. revisions 412639 from
  7144. http://svn.asterisk.org/svn/asterisk/branches/12
  7145. 2014-04-18 17:17 +0000 [r412589] Rusty Newton <rnewton@digium.com>
  7146. * sounds/sounds.xml, sounds/Makefile, /: sounds: Fix Sounds
  7147. Makefile and XML that didn't support new sound prompt sets In
  7148. sounds/Makefile 1 Adds and moves some lines necessary for the
  7149. en_GB core set. I'm just following how the other sets are defined
  7150. here. 2 removes the ES extra sounds related lines as we don't
  7151. have ES extra sound sets. In sounds/sounds.xml 3 Adds member
  7152. definitons for EN_AU, EN_GB, IT for core sound sets, and EN_GB in
  7153. extra sound sets ASTERISK-23550 #close Review:
  7154. https://reviewboard.asterisk.org/r/3464/ ........ Merged
  7155. revisions 412586 from
  7156. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7157. revisions 412587 from
  7158. http://svn.asterisk.org/svn/asterisk/branches/12
  7159. 2014-04-18 17:02 +0000 [r412584] Mark Michelson <mmichelson@digium.com>
  7160. * /, res/res_pjsip/location.c: Allow for multiple contacts to be
  7161. configured in a single contact= line. This is useful for
  7162. configuring multiple permanent contacts for an AOR when using
  7163. realtime AORs. Review: https://reviewboard.asterisk.org/r/3462
  7164. ........ Merged revisions 412582 from
  7165. http://svn.asterisk.org/svn/asterisk/branches/12
  7166. 2014-04-18 16:44 +0000 [r412580-412583] Richard Mudgett <rmudgett@digium.com>
  7167. * main/dial.c, main/pbx.c, /, apps/app_originate.c,
  7168. include/asterisk/pbx.h: Originated calls: Fix several originate
  7169. call problems. * Restore the reason value set by
  7170. pbx_outgoing_attempt() to use AST_CONTROL_xxx values as all the
  7171. consumers were expecting rather than cause codes. * Fixed the
  7172. dial routines to set cause codes for more than just ast_request()
  7173. so pbx_outgoing_attempt() reason codes will function. * Fix
  7174. inconsistent locked_channel return status in
  7175. pbx_outgoing_attempt(). The chanel may not have been locked or
  7176. the channel may have been a stale pointer. * Fixed the
  7177. OutgoingSpoolFailed channel to run dialplan whenever the dialing
  7178. fails for an originate exten and 1 < synchronous. * Fix incorrect
  7179. ast_cond_wait() usage in pbx_outgoing_attempt(). Indroduced by
  7180. issue ASTERISK-22212 patch. * Made struct pbx_outgoing use the
  7181. ao2 lock instead of its own lock for the cond wait mutex. No
  7182. sense in having two locks associated with the same struct when
  7183. only one is needed. Review:
  7184. https://reviewboard.asterisk.org/r/3421/ ........ Merged
  7185. revisions 412581 from
  7186. http://svn.asterisk.org/svn/asterisk/branches/12
  7187. * main/stasis_channels.c, apps/app_queue.c, apps/app_dial.c, /:
  7188. app_dial and app_queue: Make lock the forwarding channel while
  7189. taking the channel snapshot. * Fixed
  7190. ast_channel_publish_dial_forward() not locking the forwarded
  7191. channel when taking the channel snapshot. * Fixed
  7192. app_dial.c:do_forward() using the wrong channel to get the
  7193. original call forwarding string. * Removed unnecessary locking
  7194. when calling ast_channel_publish_dial() and
  7195. ast_channel_publish_dial_forward() in app_dial and app_queue.
  7196. Holding channel locks when calling
  7197. ast_channel_publish_dial_forward() with a forwarded channel could
  7198. result in pausing the system while the stasis bus completes
  7199. processsing a forwarded channel subscription. Review:
  7200. https://reviewboard.asterisk.org/r/3451/ ........ Merged
  7201. revisions 412579 from
  7202. http://svn.asterisk.org/svn/asterisk/branches/12
  7203. 2014-04-18 14:25 +0000 [r412566] Kinsey Moore <kmoore@digium.com>
  7204. * res/ari/ari_websockets.c, res/res_ari.c, main/manager.c, /: ARI:
  7205. Add debug logging for events and responses This adds DEBUG level
  7206. logging for ARI websocket events and HTTP responses similar to
  7207. what is available for AMI. Logging for ARI HTTP requests is
  7208. already adequate for debugging purposes. ........ Merged
  7209. revisions 412565 from
  7210. http://svn.asterisk.org/svn/asterisk/branches/12
  7211. 2014-04-17 22:50 +0000 [r412552] Joshua Colp <jcolp@digium.com>
  7212. * /, res/res_pjsip/location.c, res/res_pjsip/pjsip_configuration.c,
  7213. res/res_pjsip/pjsip_options.c, res/res_pjsip.c,
  7214. res/res_pjsip_registrar.c: res_pjsip: Handle reloading when
  7215. permanent contacts exist and qualify is configured. This change
  7216. fixes a problem where permanent contacts being qualified were not
  7217. being updated. This was caused by the permanent contacts getting
  7218. a uuid and not a known identifier, causing an inability to look
  7219. them up when updating in the qualify code. A bug also existed
  7220. where the new configuration may not be available immediately when
  7221. updating qualifies. (closes issue ASTERISK-23514) Reported by:
  7222. Richard Mudgett Review: https://reviewboard.asterisk.org/r/3448/
  7223. ........ Merged revisions 412551 from
  7224. http://svn.asterisk.org/svn/asterisk/branches/12
  7225. 2014-04-17 22:42 +0000 [r412536-412550] Jonathan Rose <jrose@digium.com>
  7226. * /, main/app.c: Fix a silly shadowed variable mistake that was
  7227. missed from play tones patch ........ Merged revisions 412549
  7228. from http://svn.asterisk.org/svn/asterisk/branches/12
  7229. * /, res/ari/resource_bridges.h, main/app.c,
  7230. rest-api/api-docs/channels.json, CHANGES,
  7231. rest-api/api-docs/bridges.json, res/ari/resource_channels.h,
  7232. include/asterisk/app.h, res/res_stasis_playback.c: ARI: Add tones
  7233. playback resource Adds a tones URI type to the playback resource.
  7234. The tone can be specified by name (from indications.conf) or by a
  7235. tone pattern. In addition, tonezone can be specified in the URI
  7236. (by appending ;tonezone=<zone>). Tones must be stopped manually
  7237. in order for a stasis control to move on from playback of the
  7238. tone. Tones may be paused, resumed, restarted, and stopped. They
  7239. may not be rewound or fast forwarded (tones can't be controlled
  7240. in a way that lets you skip around from note to note and pausing
  7241. and resuming will also restart the tone from the beginning).
  7242. Tests are currently in development for this feature
  7243. (https://reviewboard.asterisk.org/r/3428/). (closes issue
  7244. ASTERISK-23433) Reported by: Matt Jordan Review:
  7245. https://reviewboard.asterisk.org/r/3427/ ........ Merged
  7246. revisions 412535 from
  7247. http://svn.asterisk.org/svn/asterisk/branches/12
  7248. 2014-04-17 20:25 +0000 [r412467-412484] Matthew Jordan <mjordan@digium.com>
  7249. * channels/chan_oss.c, /, main/Makefile: main/Makefile: Fix build
  7250. failure on SmartOS/Illumos/SunOS This patch fixes two issues when
  7251. building on SmartOS: - channels/chan_oss.c: it makes sure
  7252. soundcard.h is found - main/Makefile: only use
  7253. "-Wl,--version-script" when GNU LD is used as the Sun Linker
  7254. doesn't support that. Similar checks are already used elswhere in
  7255. the Makefile Review: https://reviewboard.asterisk.org/r/3426
  7256. ASTERISK-23576 #close Reported by: Sebastian Wiedenroth patches:
  7257. fix-sunos.diff uploaded by Sebastian Wiedenroth (License 6597)
  7258. ........ Merged revisions 412468 from
  7259. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7260. revisions 412483 from
  7261. http://svn.asterisk.org/svn/asterisk/branches/12
  7262. * channels/sip/include/sip.h, channels/chan_sip.c, CHANGES:
  7263. chan_sip: Add SIPURIPHONECONTEXT channel variable for Request TEL
  7264. URIs This patch is a continuation of
  7265. https://reviewboard.asterisk.org/r/3349/, committed in r412303.
  7266. It resolves a finding oej had that the phone-context be available
  7267. in a channel variable separate from SIPDOMAIN. This patch adds
  7268. that variable as SIPURIPHONECONTEXT. It also allows a local
  7269. number (or global number specified in the TEL URI) to be used to
  7270. look up as a peer. (issue ASTERISK-17179) Review:
  7271. https://reviewboard.asterisk.org/r/3349/
  7272. 2014-04-17 15:17 +0000 [r412454] Kevin Harwell <kharwell@digium.com>
  7273. * res/res_pjsip_refer.c, /: res_pjsip_refer: Channel variable
  7274. SIPREFERTOHDR not being set during blind transfer The
  7275. SIPREFERTOHDR channel variable is not being set on any channel
  7276. when performing a blind transfer using PJSIP. The
  7277. 'refer->refer_to' was not being set during a blind transfer.
  7278. Updated so the 'refer_to' is set to the target uri on a blind
  7279. transfer. (closes issue ASTERISK-23502) Reported by: John Bigelow
  7280. Review: https://reviewboard.asterisk.org/r/3445/ ........ Merged
  7281. revisions 412453 from
  7282. http://svn.asterisk.org/svn/asterisk/branches/12
  7283. 2014-04-16 19:14 +0000 [r412440] Kinsey Moore <kmoore@digium.com>
  7284. * /, include/asterisk/stasis_app.h: Stasis: Add a usage note on
  7285. stasis_app_get_bridge This function returns an ast_bridge without
  7286. a refcount bump and the caller must increment the count if it
  7287. intends to hold the pointer. (closes issue ASTERISK-23588)
  7288. Review: https://reviewboard.asterisk.org/r/3450/ Reported by:
  7289. Matt Jordan ........ Merged revisions 412439 from
  7290. http://svn.asterisk.org/svn/asterisk/branches/12
  7291. 2014-04-15 23:21 +0000 [r412427] Russell Bryant <russell@russellbryant.com>
  7292. * bridges/bridge_builtin_features.c, include/asterisk/monitor.h,
  7293. CHANGES, apps/app_queue.c, funcs/func_periodic_hook.c,
  7294. apps/app_mixmonitor.c, include/asterisk/beep.h (added),
  7295. res/res_monitor.c: (mix)monitor: Add options to enable a periodic
  7296. beep Add an option to enable a periodic beep to be played into a
  7297. call if it is being recorded. If enabled, it uses the
  7298. PERIODIC_HOOK() function internally to play the 'beep' prompt
  7299. into the call at a specified interval. This option is provided
  7300. for both Monitor() and MixMonitor(). Review:
  7301. https://reviewboard.asterisk.org/r/3424/
  7302. 2014-04-15 18:30 +0000 [r412384-412414] Richard Mudgett <rmudgett@digium.com>
  7303. * main/stasis_channels.c, main/features_config.c,
  7304. res/res_parking.c, main/rtp_engine.c, /: Eliminate some more
  7305. unnecessary RAII_VAR() uses. RAII_VAR() is not a hammer
  7306. appropriate to pound all nails. ........ Merged revisions 412413
  7307. from http://svn.asterisk.org/svn/asterisk/branches/12
  7308. * res/res_stasis_playback.c, /, res/stasis/app.c, res/res_fax.c,
  7309. res/res_pjsip/security_events.c,
  7310. res/parking/parking_applications.c, channels/chan_oss.c,
  7311. main/stasis_bridges.c, res/res_pjsip_session.c,
  7312. res/stasis_recording/stored.c, main/cdr.c, res/res_parking.c,
  7313. channels/chan_skinny.c, res/res_pjsip/location.c,
  7314. res/res_stasis_recording.c, main/stasis_channels.c,
  7315. res/ari/resource_channels.c, res/parking/parking_manager.c,
  7316. res/ari/resource_recordings.c, res/res_pjsip_refer.c,
  7317. res/res_ari.c, main/pbx.c: Remove unused RAII_VAR() declarations.
  7318. * Remove unused RAII_VAR() declarations. The compiler cannot
  7319. catch these because the cleanup function "references" the unused
  7320. variable. Some actually allocated and released resources that
  7321. were never used. * Fixed some whitespace issues in
  7322. stasis_bridges.c. ........ Merged revisions 412399 from
  7323. http://svn.asterisk.org/svn/asterisk/branches/12
  7324. * include/asterisk/rtp_engine.h, main/rtp_engine.c, /,
  7325. channels/chan_sip.c: chan_sip.c: Fix channel staging assertion
  7326. failure. The failing assertion ensures that the final snapshot
  7327. gets generated so CDR records can get finalized. The only place
  7328. where a channel staging snapshot flag could be left set is in
  7329. chan_sip.c:handle_request_bye(). The function could return before
  7330. clearing the flag because the channel could dissappear while the
  7331. function had to have the channel unlocked. * Fixed
  7332. handle_request_bye() channel snapshot staging coverage area to
  7333. not have a return in the middle of it and be unable to clear the
  7334. staging flag. * Pushed the channel snapshot staging coverage area
  7335. into ast_rtp_instance_set_stats_vars() to ensure that the staging
  7336. is not interrutped. * Made callers of
  7337. ast_rtp_instance_set_stats_vars() not call it with any channels
  7338. or channel driver private locks held to eliminate the deadlock
  7339. potential. The callers must hold references to the passed in
  7340. channel and rtp objects. * Eliminated sip_hangup() trying to get
  7341. the bridge peer. It is futile at this point because the channel
  7342. could never be in a bridge. Review:
  7343. https://reviewboard.asterisk.org/r/3431/ ........ Merged
  7344. revisions 412385 from
  7345. http://svn.asterisk.org/svn/asterisk/branches/12
  7346. * /, channels/chan_sip.c: chan_sip.c: Moved some sip_pvt unrefs
  7347. after their last use. * Moved sip_pvt unref in ast_hangup() and
  7348. handle_request_do() to the end of the function. The unref needs
  7349. to happen after the last use of the pointer. ........ Merged
  7350. revisions 412348 from
  7351. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7352. revisions 412383 from
  7353. http://svn.asterisk.org/svn/asterisk/branches/12
  7354. 2014-04-15 16:13 +0000 [r412331] Jonathan Rose <jrose@digium.com>
  7355. * configs/sip.conf.sample, /, channels/chan_sip.c: Reverting
  7356. r411189 so that it can be put up for public review --- r411189 |
  7357. jrose | 2014-03-26 10:50:48 -0500 (Wed, 26 Mar 2014) | 12 lines
  7358. chan_sip: Send real CallerID information with
  7359. P-Assserted-Identity (RFC-3325) Prior to this patch, the
  7360. P-Asserted-Identity header would include anonymous caller id
  7361. information which seems to go against the point of the
  7362. P-Asserted-Identity header. Now the real caller ID information
  7363. will be included in this header. Also, no privacy header would be
  7364. included. This patch adds 'Privacy: id' to outgoing SIP messages
  7365. that include the P-Asserted-Identity header. (closes issue
  7366. AST-1301) --- ........ Merged revisions 412328 from
  7367. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7368. revisions 412329 from
  7369. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7370. revisions 412330 from
  7371. http://svn.asterisk.org/svn/asterisk/branches/12
  7372. 2014-04-14 15:54 +0000 [r412307] Corey Farrell <git@cfware.com>
  7373. * main/autoservice.c, /: autoservice: fix reference leak of logger
  7374. callid. autoservice acquires a local reference to the logger
  7375. callid of each channel in a loop. This local reference was not
  7376. released, causing the callid of every channel in autoservice to
  7377. leak. This change moves the callid unref inside the loop.
  7378. ASTERISK-23616 #close Reported by: ibercom ........ Merged
  7379. revisions 412305 from
  7380. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7381. revisions 412306 from
  7382. http://svn.asterisk.org/svn/asterisk/branches/12
  7383. 2014-04-12 02:27 +0000 [r412292] Matthew Jordan <mjordan@digium.com>
  7384. * channels/sip/reqresp_parser.c, CHANGES, channels/chan_sip.c:
  7385. chan_sip: Support RFC-3966 TEL URIs in inbound INVITE requests
  7386. This patch adds support for handling TEL URIs in inbound INVITE
  7387. requests. This includes the Request URI and the From URI. The
  7388. number specified in the Request URI will be the destination of
  7389. the inbound channel in the dialplan. The phone-context specified
  7390. in the Request URI will be stored in the TELPHONECONTEXT channel
  7391. variable. Review: https://reviewboard.asterisk.org/r/3349
  7392. ASTERISK-17179 #close Reported by: Geert Van Pamel Tested by:
  7393. Geert Van Pamel patches:
  7394. asterisk-12.0.0-chan_sip-RFC3966_patch.txt uploaded by Geert Van
  7395. Pamel (License 6140)
  7396. asterisk-12.0.0-reqresp_parser-RFC3966_patch.txt uploaded by
  7397. Geert Van Pamel (License 6140)
  7398. 2014-04-12 01:35 +0000 [r412279-412280] Russell Bryant <russell@russellbryant.com>
  7399. * funcs/func_periodic_hook.c: func_periodic_hook: move module ref
  7400. The previous code left one error path where the module would be
  7401. unref'd twice instead of once. It was done once in the error
  7402. handling block, and again inside of datastore destruction. Now
  7403. the module ref is only released in the datastore destructor and
  7404. only acquired when the datastore has been successfully allocated.
  7405. * funcs/func_periodic_hook.c: func_periodic_hook: add module ref
  7406. counting This module lacked necessary module ref count
  7407. incrementing and decrementing when used. This patch adds it.
  7408. There's already a datastore used, so doing the ref counting along
  7409. with the lifetime of the datastore provides a convenient place to
  7410. do it.
  7411. 2014-04-11 21:43 +0000 [r412213-412228] Richard Mudgett <rmudgett@digium.com>
  7412. * apps/app_stack.c, /: app_stack: Add missing unlock in off-nominal
  7413. path of STACK_PEEK function. ASTERISK-23620 #close Reported by:
  7414. Bradley Watkins Patches: ASTERISK-23620_unlock_oldlist.patch
  7415. (license #5021) patch uploaded by Bradley Watkins ........ Merged
  7416. revisions 412225 from
  7417. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7418. revisions 412226 from
  7419. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7420. revisions 412227 from
  7421. http://svn.asterisk.org/svn/asterisk/branches/12
  7422. * utils/Makefile, utils: utils dir: Remove no longer needed traces
  7423. of refcounter except in the clean make target. * Removed no
  7424. longer needed files from the svn:ignore property to make them
  7425. visible.
  7426. 2014-04-11 12:43 +0000 [r412194] Kinsey Moore <kmoore@digium.com>
  7427. * /, main/bridge.c, main/bridge_basic.c,
  7428. include/asterisk/stasis_bridges.h, tests/test_cel.c,
  7429. apps/app_confbridge.c, res/ari/resource_bridges.c: bridging:
  7430. Ensure locking during snapshot creation While the vast majority
  7431. of bridge snapshot creation is locked properly, there are
  7432. currently some instances that are not. This adds the missing
  7433. locking to ensure bridge state is not malleable during snapshot
  7434. creation. (closes issue ASTERISK-22904) Review:
  7435. https://reviewboard.asterisk.org/r/3415/ Reported by: Matt Jordan
  7436. ........ Merged revisions 412193 from
  7437. http://svn.asterisk.org/svn/asterisk/branches/12
  7438. 2014-04-11 08:28 +0000 [r412168-412180] Olle Johansson <oej@edvina.net>
  7439. * main/audiohook.c: Formatting: Remove invisible characters
  7440. * main/audiohook.c: Formatting only.
  7441. 2014-04-11 02:59 +0000 [r412154] Matthew Jordan <mjordan@digium.com>
  7442. * main/astobj2.c, contrib/scripts/refcounter.py (added),
  7443. main/asterisk.c, utils/refcounter.c (removed),
  7444. build_tools/cflags.xml, utils/utils.xml, /, channels/chan_sip.c,
  7445. channels/sip/security_events.c, include/asterisk/astobj2.h,
  7446. UPGRADE.txt: main/astobj2: Make REF_DEBUG a menuselect item;
  7447. improve REF_DEBUG output This patch does the following: (1) It
  7448. makes REF_DEBUG a meneselect item. Enabling REF_DEBUG now enables
  7449. REF_DEBUG globally throughout Asterisk. (2) The ref debug log
  7450. file is now created in the AST_LOG_DIR directory. Every run will
  7451. now blow away the previous run (as large ref files sometimes
  7452. caused issues). We now also no longer open/close the file on each
  7453. write, instead relying on fflush to make sure data gets written
  7454. to the file (in case the ao2 call being performed is about to
  7455. cause a crash) (3) It goes with a comma delineated format for the
  7456. ref debug file. This makes parsing much easier. This also now
  7457. includes the thread ID of the thread that caused ref change. (4)
  7458. A new python script instead for refcounting has been added in the
  7459. contrib/scripts folder. (5) The old refcounter implementation in
  7460. utils/ has been removed. Review:
  7461. https://reviewboard.asterisk.org/r/3377/ ........ Merged
  7462. revisions 412114 from
  7463. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7464. revisions 412115 from
  7465. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7466. revisions 412153 from
  7467. http://svn.asterisk.org/svn/asterisk/branches/12
  7468. 2014-04-11 01:12 +0000 [r412102] Russell Bryant <russell@russellbryant.com>
  7469. * res/res_monitor.c: monitor: use app options parsing helper code
  7470. This app is pretty ancient, so it was never converted to use the
  7471. option parsing helper code. I'd like to add an option to this app
  7472. that takes an argument, and that's a pain to do when not using
  7473. this helper, so start by doing this conversion. Review:
  7474. https://reviewboard.asterisk.org/r/3429/
  7475. 2014-04-10 21:28 +0000 [r412089] Matthew Jordan <mjordan@digium.com>
  7476. * /, res/res_hep_pjsip.c: res_hep_pjsip: Use the channel name
  7477. instead of the call ID when it is available During discussions
  7478. with Alexandr Dubovikov at Kamailio World, it became apparent
  7479. that while the SIP call ID is a useful identifier prior to an
  7480. Asterisk channel being created, it is far more preferable to use
  7481. the channel name (or some channel based identifier) when the
  7482. channel is available. Homer is smart enough to tie the various
  7483. messages together. This patch opts to use the channel name when
  7484. it is available, falling back to the call ID otherwise. ........
  7485. Merged revisions 412088 from
  7486. http://svn.asterisk.org/svn/asterisk/branches/12
  7487. 2014-04-10 21:10 +0000 [r412075] Kevin Harwell <kharwell@digium.com>
  7488. * /, res/res_pjsip_pubsub.c: res_pjsip_pubsub: Set the body
  7489. generation result to 0 for a valid path The result of the
  7490. "ast_sip_pubsub_generate_body_content" was not set/initialized.
  7491. Consequently, the nominal path potentially returned an invalid
  7492. value, thus not sending mwi notifications. ........ Merged
  7493. revisions 412074 from
  7494. http://svn.asterisk.org/svn/asterisk/branches/12
  7495. 2014-04-09 21:43 +0000 [r412050] Mark Michelson <mmichelson@digium.com>
  7496. * /, CHANGES, apps/app_mixmonitor.c: Add a Command header to the
  7497. AMI Mixmonitor action. This fixes a parsing error that occurred
  7498. during the processing of the AMI action. The error did not result
  7499. in MixMonitor itself misbehaving, but it could result in the AMI
  7500. response not giving correct information back. The new header
  7501. allows for one to specify a post-process command to run when
  7502. recording finishes. Previously, in order to do this, the
  7503. post-process command would have to be placed at the end of the
  7504. Options: header. Patches: mixmonitor_command_2.patch by jhardin
  7505. (License #6512) ........ Merged revisions 412048 from
  7506. http://svn.asterisk.org/svn/asterisk/branches/12
  7507. 2014-04-09 18:17 +0000 [r412035] Kinsey Moore <kmoore@digium.com>
  7508. * /, res/res_stasis_answer.c: res_stasis_answer: Add missing
  7509. newlines ........ Merged revisions 412034 from
  7510. http://svn.asterisk.org/svn/asterisk/branches/12
  7511. 2014-04-08 21:25 +0000 [r411946-411990] Richard Mudgett <rmudgett@digium.com>
  7512. * /, main/asterisk.c: Internal timing: Add notice that the -I and
  7513. internal_timing option are no longer needed. Add notice messages
  7514. during execution that the -I command line option and the
  7515. astersik.conf internal_timing option are no longer needed. The
  7516. internal timing functionality is now always enabled if there is a
  7517. timing module loaded. NOTE: Since the command line options and
  7518. the asterisk.conf config file are processed before the logging
  7519. system is initialized, the messages are output to stderr. Change
  7520. requested as a result of asterisk-dev list comments about the
  7521. commit for ASTERISK-22846 that removed the -I and internal_timing
  7522. options. Review: https://reviewboard.asterisk.org/r/3423/
  7523. ........ Merged revisions 411964 from
  7524. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7525. revisions 411974 from
  7526. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7527. revisions 411985 from
  7528. http://svn.asterisk.org/svn/asterisk/branches/12
  7529. * main/config.c, /: config: Fix CB_ADD_LEN() to work as originally
  7530. intended. Fix a long standing bug in CB_ADD_LEN() behaving like
  7531. CB_ADD(). ASTERISK-23546 #close Reported by: Walter Doekes
  7532. ........ Merged revisions 411960 from
  7533. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7534. revisions 411961 from
  7535. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7536. revisions 411962 from
  7537. http://svn.asterisk.org/svn/asterisk/branches/12
  7538. * apps/confbridge/conf_config_parser.c, /: app_confbridge: Fix
  7539. confbridge.conf dsp_talking_threshold option setting wrong
  7540. parameter. Fixed copy pasta error. ASTERISK-23545 #close Reported
  7541. by: John Knott ........ Merged revisions 411944 from
  7542. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7543. revisions 411945 from
  7544. http://svn.asterisk.org/svn/asterisk/branches/12
  7545. 2014-04-08 14:49 +0000 [r411928] Joshua Colp <jcolp@digium.com>
  7546. * /, res/res_pjsip.c: res_pjsip: Ignore explicit transport
  7547. configuration if a WebSocket transport is specified. This change
  7548. makes it so if a transport is configured on an endpoint that is a
  7549. WebSocket type the option will be ignored. In practice this is
  7550. fine because the WebSocket transport can not create outgoing
  7551. connections, it can only reuse existing ones. By ignoring the
  7552. option the existing PJSIP logic for using the existing connection
  7553. will be invoked and stuff will proceed. (closes issue
  7554. ASTERISK-23584) Reported by: Rusty Newton ........ Merged
  7555. revisions 411927 from
  7556. http://svn.asterisk.org/svn/asterisk/branches/12
  7557. 2014-04-08 00:26 +0000 [r411897] Russell Bryant <russell@russellbryant.com>
  7558. * funcs/func_periodic_hook.c: func_periodic_hook: List more modules
  7559. as dependencies This module makes use of some existing Asterisk
  7560. components. app_chanspy was already listed as a dependency. There
  7561. are a few function modules used, as well, so list them.
  7562. 2014-04-07 20:41 +0000 [r411884] Kinsey Moore <kmoore@digium.com>
  7563. * /, res/res_pjsip_pubsub.c: PJSIP: Ensure test event has new state
  7564. The change that fixed the pubsub test event's use of a dangling
  7565. pointer also changed when it was processed relative to the pjsip
  7566. subscription state change processing. This change corrects the
  7567. order of events while holding a reference to the pointer that was
  7568. previously dangling. ........ Merged revisions 411883 from
  7569. http://svn.asterisk.org/svn/asterisk/branches/12
  7570. 2014-04-07 16:15 +0000 [r411870] Jonathan Rose <jrose@digium.com>
  7571. * main/manager_channels.c, /: AGI/Manager: Prevent multiple
  7572. NewExten events during AGI application changes AGI applications
  7573. would trigger NewExten events every time the state of the AGI
  7574. application changed. This has historically not been the behavior
  7575. and this behavior was introduced with a CDR patch. This patch
  7576. corrects that. (closes issue ASTERISK-23390) Reported by:
  7577. Benjamin Keith Ford Review:
  7578. https://reviewboard.asterisk.org/r/3406/ ........ Merged
  7579. revisions 411868 from
  7580. http://svn.asterisk.org/svn/asterisk/branches/12
  7581. 2014-04-07 14:57 +0000 [r411812] Walter Doekes <walter+asterisk@wjd.nu>
  7582. * apps/app_queue.c, /: app_queue: Re-add HoldTime to
  7583. QueueCallerAbandon event (simple typo during ast12 refactor).
  7584. Reported by: Ibrahim22 (on IRC) Tested by: Ibrahim22 ........
  7585. Merged revisions 411811 from
  7586. http://svn.asterisk.org/svn/asterisk/branches/12
  7587. 2014-04-07 14:29 +0000 [r411791-411806] Kinsey Moore <kmoore@digium.com>
  7588. * /, res/res_stasis.c: Stasis: Fix Stasis() bridge refcount issue
  7589. The Stasis() dialplan application monitors what bridge a channel
  7590. is in and so necessarily holds on to a bridge pointer. This
  7591. change ensures that it also holds on to a reference for that
  7592. bridge to prevent the bridge pointer from becoming a dangling
  7593. pointer. ........ Merged revisions 411804 from
  7594. http://svn.asterisk.org/svn/asterisk/branches/12
  7595. * res/res_pjsip_pubsub.c, /: PJSIP: Fix crash introduced in r411671
  7596. The test event introduced in revision 411671 uses a dangling
  7597. pointer to access information about pubsub state changes. This
  7598. moves the event to within the lifetime of the pointer. ........
  7599. Merged revisions 411790 from
  7600. http://svn.asterisk.org/svn/asterisk/branches/12
  7601. 2014-04-05 13:06 +0000 [r411768] Russell Bryant <russell@russellbryant.com>
  7602. * CHANGES, funcs/func_periodic_hook.c (added): func_periodic_hook:
  7603. New function for periodic hooks. This commit introduces a new
  7604. dialplan function, PERIODIC_HOOK(). It allows you run to a
  7605. dialplan hook on a channel periodically. The original use case
  7606. that inspired this was the ability to play a beep periodically
  7607. into a call being recorded. The implementation is much more
  7608. generic though and could be used for many other things. The
  7609. implementation makes heavy use of existing Asterisk components.
  7610. It uses a combination of Local channels and ChanSpy() to run some
  7611. custom dialplan and inject any audio it generates into an active
  7612. call. The other important bit of the implementation is how it
  7613. figures out when to trigger the beep playback. This
  7614. implementation uses the audiohook API, even though it's not
  7615. actually touching the audio in any way. It's a convenient way to
  7616. get a callback and check if it's time to kick off another beep.
  7617. It would be nice if this was timer event based instead of polling
  7618. based, but unfortunately I don't see a way to do it that won't
  7619. interfere with other things. Review:
  7620. https://reviewboard.asterisk.org/r/3362/
  7621. 2014-04-04 19:19 +0000 [r411702-411724] Richard Mudgett <rmudgett@digium.com>
  7622. * include/asterisk/options.h, main/asterisk.c, main/channel.c, /,
  7623. channels/chan_sip.c, configs/asterisk.conf.sample, UPGRADE.txt,
  7624. include/asterisk/channel.h, utils/extconf.c: internal_timing:
  7625. Remove the option and always make it enabled if a timing module
  7626. is loaded. The masquerade supertest frequently fails because
  7627. either the local channel chain doesn't completely optimize out or
  7628. the DTMF handshake doesn't completely get accross. Local channel
  7629. optimization requires frames flowing to trigger when optimization
  7630. can happen. When optimization happens the media frame that
  7631. triggered the optimization is dropped. Sending DTMF requires
  7632. frames to flow in the other direction for timing purposes while
  7633. sending nothing. If internal timing is not enabled when MOH is
  7634. playing, Asterisk switches to received timing when an audio frame
  7635. is received. With optimization dropping media frames and MOH not
  7636. sending frames unless it receives frames, occasionaly there are
  7637. no more frames being passed and the test fails. * The asterisk
  7638. command line -I option and the asterisk.conf internal_timing
  7639. option are removed. Asterisk now always uses internal timing when
  7640. needed if any timing module is loaded. The issue ASTERISK-14861
  7641. did this quite awhile ago in v1.4 but effectively is broken if
  7642. other internal timing modules besides DAHDI are used. The
  7643. ast_read_generator_actions() now only does received timing if it
  7644. has no choice for frame generators like MOH, silence, and
  7645. playback streaming. * Cleaned up some code dealing with frame
  7646. generators in ast_deactivate_generator(),
  7647. generator_write_format_change(), ast_activate_generator(), and
  7648. ast_channel_stop_silence_generator(). * Removed
  7649. ast_internal_timing_enabled(), AST_OPT_FLAG_INTERNAL_TIMING, and
  7650. ast_opt_internal_timing. ASTERISK-22846 #close Reported by: Matt
  7651. Jordan Review: https://reviewboard.asterisk.org/r/3414/ ........
  7652. Merged revisions 411715 from
  7653. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7654. revisions 411716 from
  7655. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7656. revisions 411717 from
  7657. http://svn.asterisk.org/svn/asterisk/branches/12
  7658. * main/utils.c, res/res_musiconhold.c, main/channel.c,
  7659. main/stasis_cache.c, /: Add some asserts that were handy when
  7660. looking for a stasis cache problem. * Assert if a channel is
  7661. destroyed but has the snapshot staging flag set. In this case the
  7662. final channel destruction snapshot would never get taken. *
  7663. Assert if what we just got out of the stasis cache is not what we
  7664. were looking for. This assert would have saved several days
  7665. searching for a bug and a lot of my hair. * Assert if the music
  7666. on hold message posts could not find the associated channel. A
  7667. crash will happen later when manager tries to send the MOH AMI
  7668. message. This assert catches the problem when the stasis message
  7669. is posted instead of by the thread processing the defective
  7670. message. * Always generate a backtrace when an ast_assert()
  7671. fails. Review: https://reviewboard.asterisk.org/r/3411/ ........
  7672. Merged revisions 411701 from
  7673. http://svn.asterisk.org/svn/asterisk/branches/12
  7674. 2014-04-04 15:13 +0000 [r411688] Matthew Jordan <mjordan@digium.com>
  7675. * /, main/http.c: http: Fix spurious ERROR message in responses
  7676. with no content When a response has a content length of 0, fwrite
  7677. would be called to write a buffer with no data in it. This
  7678. resulted in the following classic error message: [Apr 3 11:49:17]
  7679. ERROR[26421] http.c: fwrite() failed: Success This patch makes it
  7680. so that we only attempt to write out the content if the
  7681. calculated content_length is non-zero. ........ Merged revisions
  7682. 411687 from http://svn.asterisk.org/svn/asterisk/branches/12
  7683. 2014-04-03 12:06 +0000 [r411671] Kinsey Moore <kmoore@digium.com>
  7684. * /, res/res_pjsip_pubsub.c: res_pjsip_pubsub: Add test event for
  7685. state change This adds a test event when subscription state
  7686. changes so that integration tests may trigger new actions at the
  7687. appropriate times. Review:
  7688. https://reviewboard.asterisk.org/r/3383/ ........ Merged
  7689. revisions 411670 from
  7690. http://svn.asterisk.org/svn/asterisk/branches/12
  7691. 2014-04-03 11:47 +0000 [r411669] Matthew Jordan <mjordan@digium.com>
  7692. * res/res_hep.c, /: res_hep: Fix crash when hep.conf not available
  7693. Parts of res_hep properly checked for a valid configuration
  7694. object before attempting to access the configuration. A check,
  7695. however, was missed when a packet is sent. This patch fixes the
  7696. crash caused by not checking if the configuration object is
  7697. valid. ........ Merged revisions 411668 from
  7698. http://svn.asterisk.org/svn/asterisk/branches/12
  7699. 2014-04-02 18:57 +0000 [r411656] Mark Michelson <mmichelson@digium.com>
  7700. * main/sorcery.c, /, res/res_mwi_external.c,
  7701. res/res_pjsip/config_system.c, configs/sorcery.conf.sample,
  7702. main/bucket.c, include/asterisk/sorcery.h,
  7703. res/res_pjsip/pjsip_configuration.c, tests/test_sorcery_astdb.c,
  7704. tests/test_sorcery.c, tests/test_sorcery_realtime.c: Prevent
  7705. duplicate sorcery wizards from being applied to sorcery object
  7706. types. This commit contains several changes to sorcery: 1)
  7707. Application of sorcery configuration based on module name is
  7708. automatically performed when sorcery is opened for a module. 2)
  7709. Sorcery will not attempt to apply the same wizard to an object
  7710. type more than once. 3) Sorcery gives more exact results when
  7711. attempting to apply a wizard, whether as the default or based on
  7712. configuration. Sorcery unit tests still pass for me after making
  7713. these changes. Review: https://reviewboard.asterisk.org/r/3326
  7714. ........ Merged revisions 411159 from
  7715. http://svn.asterisk.org/svn/asterisk/branches/12
  7716. 2014-04-01 22:42 +0000 [r411637-411639] Richard Mudgett <rmudgett@digium.com>
  7717. * res/parking/parking_bridge.c, /: res_parking: Minor tweaks. * Use
  7718. ast_bridge_channel_lock()/ast_bridge_channel_unlock() instead of
  7719. ao2_lock()/ao2_unlock() for struct ast_bridge_channel variables.
  7720. * Use ast_copy_string() instead of inlining it. * Remove an
  7721. already done TODO comment. * Some whitespace tweaks. ........
  7722. Merged revisions 411638 from
  7723. http://svn.asterisk.org/svn/asterisk/branches/12
  7724. * main/stasis_channels.c, /: stasis_channels.c: Eliminate another
  7725. overuse of RAII_VAR(). ........ Merged revisions 411636 from
  7726. http://svn.asterisk.org/svn/asterisk/branches/12
  7727. 2014-04-01 16:52 +0000 [r411587] Joshua Colp <jcolp@digium.com>
  7728. * /, apps/app_queue.c: app_queue: Fix a bug where realtime members
  7729. would be deleted during reload causing waiting callers to get
  7730. ejected. This patch causes realtime queue members to remain in
  7731. queues during the reload process. Previously these members would
  7732. be removed causing any waiting callers to be ejected from the
  7733. queue with a reason of "EXITEMPTY". ASTERISK-23547 #close
  7734. ASTERISK-23547 #comment Patch
  7735. app_queue_fix_realtime_reload_1.8_trunk.patch submitted by Italo
  7736. Rossi (license 6409) Review:
  7737. https://reviewboard.asterisk.org/r/3404/ ........ Merged
  7738. revisions 411584 from
  7739. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7740. revisions 411585 from
  7741. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7742. revisions 411586 from
  7743. http://svn.asterisk.org/svn/asterisk/branches/12
  7744. 2014-03-28 18:32 +0000 [r411556] Matthew Jordan <mjordan@digium.com>
  7745. * include/asterisk/res_hep.h (added), res/res_hep_pjsip.c (added),
  7746. res/res_hep.exports.in (added), configs/hep.conf.sample (added),
  7747. CHANGES, res/res_hep.c (added), /: res_hep/res_hep_pjsip: Add a
  7748. HEPv3 capture agent module and a logger for PJSIP This patch adds
  7749. the following: (1) A new module, res_hep, which implements a
  7750. generic packet capture agent for the Homer Encapsulation Protocol
  7751. (HEP) version 3. Note that this code is based on a patch provided
  7752. by Alexandr Dubovikov; I basically just wrapped it up, added
  7753. configuration via the configuration framework, and threw in a
  7754. taskprocessor. (2) A new module, res_hep_pjsip, which forwards
  7755. all SIP message traffic that passes through the res_pjsip stack
  7756. over to res_hep for encapsulation and transmission to a HEPv3
  7757. capture server. Much thanks to Alexandr for his Asterisk patch
  7758. for this code and for a *lot* of patience waiting for me to port
  7759. it to 12/trunk. Due to some dithering on my part, this has taken
  7760. the better part of a year to port forward (I still blame CDRs for
  7761. the delay). ASTERISK-23557 #close Review:
  7762. https://reviewboard.asterisk.org/r/3207/ ........ Merged
  7763. revisions 411534 from
  7764. http://svn.asterisk.org/svn/asterisk/branches/12
  7765. 2014-03-28 18:00 +0000 [r411533] Alexandr Anikin <may@telecom-service.ru>
  7766. * addons/ooh323c/src/ooh323.c, addons/ooh323c/src/ooGkClient.c,
  7767. addons/chan_ooh323.c, /, addons/ooh323c/src/oochannels.c,
  7768. addons/ooh323c/src/ooCmdChannel.c, addons/ooh323c/src/ooq931.c:
  7769. process stack command even if gatekeeper client isn't register
  7770. don't destroy gatekeeper client if it is not started don't
  7771. destroy gatekeeper client in some sort of gatekeeper errors
  7772. signal rtp create condition when call cleared before rtp
  7773. structure created (closes issue ASTERISK-23460) Reported by:
  7774. Dmitry Melekhov Patches: ASTERISK-23460-2.patch Tested by: Dmitry
  7775. Melekhov ........ Merged revisions 411531 from
  7776. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7777. revisions 411532 from
  7778. http://svn.asterisk.org/svn/asterisk/branches/12
  7779. 2014-03-28 17:41 +0000 [r411515-411530] Matthew Jordan <mjordan@digium.com>
  7780. * rest-api/api-docs/channels.json,
  7781. rest-api/api-docs/recordings.json,
  7782. rest-api/api-docs/endpoints.json, rest-api/api-docs/events.json,
  7783. /, rest-api/api-docs/playbacks.json, UPGRADE.txt,
  7784. rest-api/api-docs/sounds.json, rest-api/resources.json, CHANGES,
  7785. include/asterisk/manager.h, rest-api/api-docs/bridges.json,
  7786. rest-api/api-docs/deviceStates.json,
  7787. rest-api/api-docs/mailboxes.json,
  7788. rest-api/api-docs/asterisk.json,
  7789. rest-api/api-docs/applications.json: Update API versions and
  7790. UPGRADE/CHANGES for 12.2.0 This patch does the following: * It
  7791. updates the AMI version to 2.2.0 to indicate backwards compatible
  7792. changes have been made since the last release * It updates the
  7793. ARI version to 1.2.0 to indicate backwards compatible changes
  7794. have been made since the last release * It updates the
  7795. UPGRADE/CHANGES files with changes that were not mentioned
  7796. ........ Merged revisions 411529 from
  7797. http://svn.asterisk.org/svn/asterisk/branches/12
  7798. * UPGRADE.txt, res/res_config_odbc.c: res_config_odbc: Fix for
  7799. nullable integer columns and keyfield existence check in
  7800. update_odbc. This patch fixes setting nullable integer columns to
  7801. NULL instead of an empty string, which fails for PostgreSQL, for
  7802. example. The current code is supposed to do so, but the check is
  7803. broken. The patch also allows the first column in the list to be
  7804. a nullable integer. Also, the check for existence of a mandatory
  7805. column checked for the first column in the list instead of the
  7806. key field lookup column. This patch fixes that issue as well.
  7807. Finally, the compatibility option allow_empty_string_in_nontext,
  7808. which was added to previous revisions to allow for some database
  7809. backends with certain schemas to function, has been removed.
  7810. Review: https://reviewboard.asterisk.org/r/3335 ASTERISK-23459
  7811. #close ASTERISK-23351 #close (closes issue ASTERISK-23459)
  7812. Reported by: zvision patches: res_config_odbc.diff uploaded by
  7813. zvision (License 5755)
  7814. 2014-03-28 16:18 +0000 [r411469] Scott Griepentrog <sgriepentrog@digium.com>
  7815. * main/tcptls.c, main/manager.c, /, main/http.c: http: response
  7816. body often missing after specific request This patch works around
  7817. a problem with the HTTP body being dropped from the response to a
  7818. specific client and under specific circumstances: a) Client
  7819. request comes from node.js user agent "Shred" via use of
  7820. swagger-client library. b) Asterisk and Client are *not* on the
  7821. same host or TCP/IP stack In testing this problem, it has been
  7822. determined that the write of the HTTP body is lost, even if the
  7823. data is written using low level write function. The only solution
  7824. found is to instruct the TCP stack with the shutdown function to
  7825. flush the last write and finish the transmission. See review for
  7826. more details. ASTERISK-23548 #close (closes issue ASTERISK-23548)
  7827. Reported by: Sam Galarneau Review:
  7828. https://reviewboard.asterisk.org/r/3402/ ........ Merged
  7829. revisions 411462 from
  7830. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7831. revisions 411463 from
  7832. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7833. revisions 411465 from
  7834. http://svn.asterisk.org/svn/asterisk/branches/12
  7835. 2014-03-28 15:48 +0000 [r411375-411460] Matthew Jordan <mjordan@digium.com>
  7836. * UPGRADE.txt, /: UPGRADE: Note IAX2 compatibility issue between
  7837. 1.4 and 1.8+ systems. ........ Merged revisions 411457 from
  7838. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7839. revisions 411458 from
  7840. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7841. revisions 411459 from
  7842. http://svn.asterisk.org/svn/asterisk/branches/12
  7843. * contrib/realtime/mysql/voicemail_messages.sql (removed),
  7844. contrib/realtime/postgresql/realtime.sql (removed),
  7845. contrib/realtime/mysql/voicemail_data.sql (removed),
  7846. contrib/realtime/mysql/musiconhold.sql (removed),
  7847. contrib/realtime/mysql/queue_log.sql (removed),
  7848. contrib/realtime/mysql/voicemail.sql (removed),
  7849. contrib/realtime/mysql/sippeers.sql (removed), /,
  7850. contrib/realtime/mysql/iaxfriends.sql (removed),
  7851. contrib/realtime/mysql/meetme.sql (removed): contrib/realtime:
  7852. Remove empty SQL script files Since the relatime scripts are now
  7853. managed by Alembic, the previous realtime scripts were previously
  7854. removed. However, the removal process messed up, as the files
  7855. were still in the repository. The contents were just empty. This
  7856. removes the files from the tree. ........ Merged revisions 411442
  7857. from http://svn.asterisk.org/svn/asterisk/branches/12
  7858. * /, channels/sip/include/sip.h: chan_sip: Add MESSAGE request to
  7859. allowed methods The allowed methods advertised by chan_sip did
  7860. not previously note the MESSAGE request. Even in Asterisk 1.8, we
  7861. do accept in-dialog MESSAGE requests; we should advertise that we
  7862. support MESSAGE requests. ASTERISK-23504 #close ASTERISK-23504
  7863. #comment Reported by: Martin Kontsek ASTERISK-23504 #comment
  7864. Patch sip.h_patch.diff uploaded by Martin Kontsek (license 6587)
  7865. Review: https://reviewboard.asterisk.org/r/3396/ ........ Merged
  7866. revisions 411372 from
  7867. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7868. revisions 411373 from
  7869. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7870. revisions 411374 from
  7871. http://svn.asterisk.org/svn/asterisk/branches/12
  7872. 2014-03-27 19:21 +0000 [r411312-411328] Corey Farrell <git@cfware.com>
  7873. * funcs/func_global.c, apps/app_speech_utils.c,
  7874. apps/confbridge/conf_config_parser.c,
  7875. funcs/func_callcompletion.c, funcs/func_frame_trace.c,
  7876. funcs/func_callerid.c, main/message.c, /, res/res_mutestream.c,
  7877. channels/pjsip/dialplan_functions.c,
  7878. res/res_pjsip_header_funcs.c, funcs/func_pitchshift.c,
  7879. funcs/func_groupcount.c, funcs/func_volume.c, funcs/func_odbc.c,
  7880. funcs/func_channel.c, funcs/func_cdr.c, funcs/func_blacklist.c,
  7881. apps/app_stack.c, apps/app_voicemail.c, res/res_calendar.c,
  7882. apps/app_jack.c, funcs/func_dialplan.c, funcs/func_speex.c,
  7883. channels/chan_sip.c, funcs/func_math.c, funcs/func_strings.c,
  7884. funcs/func_jitterbuffer.c, res/res_xmpp.c, channels/chan_iax2.c,
  7885. main/features_config.c, res/res_jabber.c: Fix dialplan function
  7886. NULL channel safety issues (closes issue ASTERISK-23391) Reported
  7887. by: Corey Farrell Review:
  7888. https://reviewboard.asterisk.org/r/3386/ ........ Merged
  7889. revisions 411313 from
  7890. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7891. revisions 411314 from
  7892. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7893. revisions 411315 from
  7894. http://svn.asterisk.org/svn/asterisk/branches/12
  7895. * main/format.c, include/asterisk.h, /: main/formats: Fix crash in
  7896. ast_format_cmp during non-clean shutdown. * Update asterisk.h to
  7897. reflect availability of ast_register_cleanup in 11.9. * Use
  7898. ast_register_cleanup for format_attr_shutdown. (closes issue
  7899. ASTERISK-23103) Reported by: JoshE ........ Merged revisions
  7900. 411310 from http://svn.asterisk.org/svn/asterisk/branches/11
  7901. ........ Merged revisions 411311 from
  7902. http://svn.asterisk.org/svn/asterisk/branches/12
  7903. 2014-03-27 14:21 +0000 [r411296] Mark Michelson <mmichelson@digium.com>
  7904. * main/sorcery.c, /: Give sorcery instances a reference to their
  7905. wizards. On graceful shutdown, sorcery wizards are all killed
  7906. off, but it is possible for sorcery instances to still have
  7907. dangling pointers after this, possibly causing a crash. Giving
  7908. the sorcery instances a reference to their wizards ensures that
  7909. the wizard reference will remain valid for the lifetime of the
  7910. sorcery instance. Review: https://reviewboard.asterisk.org/r/3401
  7911. ........ Merged revisions 411295 from
  7912. http://svn.asterisk.org/svn/asterisk/branches/12
  7913. 2014-03-26 22:45 +0000 [r411246] Joshua Colp <jcolp@digium.com>
  7914. * /, main/say.c: say: Fix a bug where SayNumber in Polish tries to
  7915. play incorrect sound. This change fixes a bug where calling
  7916. SayNumber with a number divisible by 100 using the Polish
  7917. language would cause the code to attempt to play a sound file
  7918. with an empty name. (closes issue ASTERISK-23509) Reported by:
  7919. zvision Review: https://reviewboard.asterisk.org/r/3378/ ........
  7920. Merged revisions 411243 from
  7921. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7922. revisions 411244 from
  7923. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7924. revisions 411245 from
  7925. http://svn.asterisk.org/svn/asterisk/branches/12
  7926. 2014-03-26 16:15 +0000 [r411194] Jonathan Rose <jrose@digium.com>
  7927. * /, channels/chan_sip.c, configs/sip.conf.sample: chan_sip: Send
  7928. real CallerID information with P-Assserted-Identity (RFC-3325)
  7929. Prior too this patch, the P-Asserted-Identity header would
  7930. include anonymous caller id information which seems to go against
  7931. the point of the P-Asserted-Identity header. Now the real caller
  7932. ID information will be included in this header. Also, no privacy
  7933. header would be included. This patch adds 'Privacy: id' to
  7934. outgoing SIP messages that include the P-Asserted-Identity
  7935. header. (closes issue AST-1301) ........ Merged revisions 411189
  7936. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  7937. Merged revisions 411190 from
  7938. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  7939. revisions 411193 from
  7940. http://svn.asterisk.org/svn/asterisk/branches/12
  7941. 2014-03-26 16:05 +0000 [r411192] Richard Mudgett <rmudgett@digium.com>
  7942. * /,
  7943. contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py:
  7944. Fix 'alembic branches' merge conflict as described by the web
  7945. page. ........ Merged revisions 411191 from
  7946. http://svn.asterisk.org/svn/asterisk/branches/12
  7947. 2014-03-25 18:44 +0000 [r411174] Sean Bright <sean@malleable.com>
  7948. * /, res/ari/config.c: ARI: Don't complain about missing ARI users
  7949. when we aren't enabled Currently, if ARI is not enabled it will
  7950. still complain that there are no configured users. This patch
  7951. checks to see if ARI is enabled before logging and error or
  7952. iterating the container to validate the users. Review:
  7953. https://reviewboard.asterisk.org/r/3391/ ........ Merged
  7954. revisions 411173 from
  7955. http://svn.asterisk.org/svn/asterisk/branches/12
  7956. 2014-03-25 17:40 +0000 [r411158] Mark Michelson <mmichelson@digium.com>
  7957. * /, res/res_pjsip/pjsip_configuration.c, UPGRADE.txt,
  7958. res/res_pjsip_messaging.c, res/res_pjsip.c,
  7959. include/asterisk/res_pjsip.h: Add a "message_context" option for
  7960. PJSIP endpoints. ........ Merged revisions 411157 from
  7961. http://svn.asterisk.org/svn/asterisk/branches/12
  7962. 2014-03-25 16:57 +0000 [r411142] Richard Mudgett <rmudgett@digium.com>
  7963. * res/res_pjsip/pjsip_options.c, res/res_pjsip.c,
  7964. include/asterisk/res_pjsip.h, /: res_pjsip: Fix contact
  7965. authenticate_qualify endpoint lookup when qualifing a contact. *
  7966. Fixed bad use of ao2_find() in on_endpoint(). * Replaced use of
  7967. find_endpoints() with find_an_endpoint() since only the first
  7968. found endpoint is ever needed. * Fixed qualify_contact_cb() to
  7969. update the contact with the aor authenticate_qualify setting.
  7970. Otherwise, permanent contacts in the aor type sections would have
  7971. a config line order dependancy. * Fixed off nominal path contact
  7972. ref leak in qualify_contact(). The comment saying the unref is
  7973. not needed was wrong. * Fixed off nominal path use of the
  7974. endpoint parameter if it is NULL in send_out_of_dialog_request().
  7975. * Added missing off nominal path unref of pjsip tdata in
  7976. send_out_of_dialog_request(). * Fixed off nominal path failing to
  7977. call the callback in send_request_cb() when the request is
  7978. challenged for authentication. * Eliminated silly RAII_VAR() use
  7979. in qualify_contact_cb(). * Updated ast_sip_send_request() doxygen
  7980. to better reflect reality. (closes issue ASTERISK-23254) Reported
  7981. by: rmudgett Review: https://reviewboard.asterisk.org/r/3381/
  7982. ........ Merged revisions 411141 from
  7983. http://svn.asterisk.org/svn/asterisk/branches/12
  7984. 2014-03-25 16:06 +0000 [r411092] Kinsey Moore <kmoore@digium.com>
  7985. * /, channels/chan_sip.c: chan_sip: Fix incorrect use of timers If
  7986. update_provisional_keepalive() is called while
  7987. send_provisional_keepalive_full() is waiting on the PVT lock,
  7988. then pvt->provisional_keepalive_sched_id will be changed to a new
  7989. sched_id value by update_provisional_keepalive(), but that new
  7990. sched_id then may be overwritten with -1 by
  7991. send_provisional_keepalive_full(), killing the pvt's reference to
  7992. a schedule and "leaking" the reference. (closes issue
  7993. ASTERISK-22079) Review: https://reviewboard.asterisk.org/r/3368/
  7994. Reported by: Jamuel Starkey, Matteo, Leif Madsen, Steve Davies
  7995. Patches: provisional_keepalive_fix.diff uploaded by Steve Davies
  7996. (license 5012) ........ Merged revisions 411088 from
  7997. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  7998. revisions 411089 from
  7999. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8000. revisions 411091 from
  8001. http://svn.asterisk.org/svn/asterisk/branches/12
  8002. 2014-03-25 15:56 +0000 [r411090] Jonathan Rose <jrose@digium.com>
  8003. * /, res/res_stasis.c: ARI: Resolve a subscription leak against
  8004. implicit bridge subscriptions When a channel in a stasis
  8005. application is joined to a bridge, a subscription for that bridge
  8006. is created implicitly for the stasis application serving the
  8007. channel. Prior to this patch, subsequent removals of the channel
  8008. from the bridge would leave the subscription open. Review:
  8009. https://reviewboard.asterisk.org/r/3380/ ........ Merged
  8010. revisions 411086 from
  8011. http://svn.asterisk.org/svn/asterisk/branches/12
  8012. 2014-03-25 15:47 +0000 [r411073-411087] Richard Mudgett <rmudgett@digium.com>
  8013. * utils/conf2ael.c, main/lock.c, utils/ael_main.c: Revert -r411073.
  8014. It didn't help and blew up the system.
  8015. * utils/ael_main.c, utils/conf2ael.c, main/lock.c: locking: Add
  8016. temporary sanity checks. Add some temporary sanity checks to hunt
  8017. for locking problems with the masquerade supertest.
  8018. 2014-03-24 21:39 +0000 [r411024] Joshua Colp <jcolp@digium.com>
  8019. * /, channels/chan_sip.c: chan_sip: Always use fromdomain if set
  8020. for domain, even if callerid is set to restricted. (closes issue
  8021. ASTERISK-20841) Reported by: Kelly Goedert ........ Merged
  8022. revisions 411021 from
  8023. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8024. revisions 411022 from
  8025. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8026. revisions 411023 from
  8027. http://svn.asterisk.org/svn/asterisk/branches/12
  8028. 2014-03-21 16:04 +0000 [r410996] Richard Mudgett <rmudgett@digium.com>
  8029. * /, res/res_pjsip_registrar.c: res_pjsip_registrar.c:
  8030. Miscellaneous cleanup in rx_task(). * Fix variable shadowing of
  8031. 'updated' by renaming it to 'contact_update'. * Checked
  8032. 'contact_update' for ast_sorcery_copy() failure. * Removed silly
  8033. use of RAII_VAR() for 'contact_update'. ........ Merged revisions
  8034. 410995 from http://svn.asterisk.org/svn/asterisk/branches/12
  8035. 2014-03-21 15:50 +0000 [r410981-410994] Sean Bright <sean@malleable.com>
  8036. * res/ael/ael.flex, utils/Makefile, pbx/pbx_ael.c,
  8037. res/ael/ael_lex.c: Make the AEL load process less chatty.
  8038. Switched a bunch of LOG_NOTICEs to ast_debug. This time without
  8039. breaking the build.
  8040. * pbx/pbx_ael.c, res/ael/ael_lex.c, res/ael/ael.flex: Revert
  8041. r410981. aelparse blew up.
  8042. * main/config.c: Remove a LOG_NOTICE from
  8043. ast_config_engine_register. There is enough indication from the
  8044. CLI that we are loading a realtime engine as it is.
  8045. * pbx/pbx_ael.c, res/ael/ael_lex.c, res/ael/ael.flex: Make the AEL
  8046. load process less chatty. Switched a bunch of LOG_NOTICEs to
  8047. ast_debug.
  8048. 2014-03-20 23:02 +0000 [r410967] Jonathan Rose <jrose@digium.com>
  8049. * apps/app_confbridge.c, /: app_confbridge: Fix bug - users with
  8050. startmuted set don't start muted (closes issue ASTERISK-23461)
  8051. Reported by: Chico Manobela Review:
  8052. https://reviewboard.asterisk.org/r/3373/ ........ Merged
  8053. revisions 410965 from
  8054. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8055. revisions 410966 from
  8056. http://svn.asterisk.org/svn/asterisk/branches/12
  8057. 2014-03-20 16:35 +0000 [r410950] Richard Mudgett <rmudgett@digium.com>
  8058. * include/asterisk/rtp_engine.h, main/dial.c, main/manager.c, /,
  8059. main/channel_internal_api.c, main/core_unreal.c,
  8060. include/asterisk/channel.h, res/ari/resource_channels.c,
  8061. res/res_stasis_snoop.c: assigned-uniqueids: Miscellaneous cleanup
  8062. and fixes. * Fix memory leak in ast_unreal_new_channels(). Made
  8063. it generate the ;2 uniqueid on a stack variable instead of
  8064. mallocing it. * Made send error response to ARI and AMI requests
  8065. instead of just logging excessive uniqueid length and allowing
  8066. truncation. action_originate() and
  8067. ari_channels_handle_originate_with_id(). * Fixed minor truncating
  8068. uniqueid hole when generating the ;2 uniqueid string length.
  8069. Created public and internal lengths of uniqueid. The internal
  8070. length can handle a max public uniqueid plus an appended ;2. *
  8071. free() and ast_free() are NULL tolerant so they don't need a NULL
  8072. test before calling. * Made use better struct initialization
  8073. format instead of the position dependent initialization format.
  8074. Also anything not explicitly initialized in the struct is
  8075. initialized to zero by the compiler. * Made
  8076. ast_channel_internal_set_fake_ids() use the safer
  8077. ast_copy_string() instead of strncpy(). Review:
  8078. https://reviewboard.asterisk.org/r/3371/ ........ Merged
  8079. revisions 410949 from
  8080. http://svn.asterisk.org/svn/asterisk/branches/12
  8081. 2014-03-19 17:27 +0000 [r410934] Mark Michelson <mmichelson@digium.com>
  8082. * /, res/res_pjsip_endpoint_identifier_ip.c: PJSIP: Allow for
  8083. identify sections to be specified in sorcery.conf. "identify" is
  8084. a special type of configuration object in PJSIP because unlike
  8085. the other objects, it is not provided by the base res_pjsip
  8086. module. Instead, it is provided by the
  8087. res_pjsip_endpoint_identifier_ip module. If using the default
  8088. sorcery wizard (config,criteria=type=identify) then things work
  8089. because the module that applies the default wizard is the correct
  8090. module. However, if attempting to use sorcery.conf to apply an
  8091. alternate wizard, it was not possible. If you attempted to
  8092. specify the identify object type in the res_pjsip section, then
  8093. the object could not be registered since the object was
  8094. undocumented for the res_pjsip module. There was no alternate
  8095. configuration section defined for it, so you were out of luck if
  8096. you wanted to override the default wizard. With this change, the
  8097. identify section will properly have a sorcery.conf-based wizard
  8098. applied when the identify definition is within the
  8099. res_pjsip_endpoint_identifier_ip section. ........ Merged
  8100. revisions 410933 from
  8101. http://svn.asterisk.org/svn/asterisk/branches/12
  8102. 2014-03-19 14:25 +0000 [r410905-410919] Joshua Colp <jcolp@digium.com>
  8103. * res/res_stasis.c, /: res_stasis: Fix a bug where the default
  8104. bridge type was not set. ........ Merged revisions 410918 from
  8105. http://svn.asterisk.org/svn/asterisk/branches/12
  8106. * CHANGES, res/res_stasis.c, rest-api/api-docs/bridges.json, /,
  8107. res/ari/resource_bridges.h: res_stasis: Extend bridge type to be
  8108. a comma separated list of bridge attributes. This change turns
  8109. the bridge type field into a comma separated list of attributes.
  8110. These attributes include: mixing, holding, dtmf_events, and
  8111. proxy_media. By setting the various attributes a user can control
  8112. the type of bridge created with the behavior they need for their
  8113. application. (closes issue ASTERISK-23437) Reported by: Matt
  8114. Jordan Review: https://reviewboard.asterisk.org/r/3359/ ........
  8115. Merged revisions 410904 from
  8116. http://svn.asterisk.org/svn/asterisk/branches/12
  8117. 2014-03-19 02:33 +0000 [r410891] Matthew Jordan <mjordan@digium.com>
  8118. * res/res_ari.c, /: res_ari: Fix documentation schema error
  8119. ........ Merged revisions 410890 from
  8120. http://svn.asterisk.org/svn/asterisk/branches/12
  8121. 2014-03-18 23:32 +0000 [r410877] Rusty Newton <rnewton@digium.com>
  8122. * res/res_ari.c, /: res_ari: Add notes about Asterisk HTTP server
  8123. to the "enabled" config option for the res_ari general section
  8124. Added note and see-also reminding user to enable the HTTP server.
  8125. (closes issue ASTERISK-22499) Reported by: Rusty Newton ........
  8126. Merged revisions 410876 from
  8127. http://svn.asterisk.org/svn/asterisk/branches/12
  8128. 2014-03-18 15:45 +0000 [r410863] Scott Griepentrog <sgriepentrog@digium.com>
  8129. * /, main/http.c: ARI: allow json content type with zero length
  8130. body When a request was received with a Content-type of json, the
  8131. body was sent for json parsing - even if it was zero length. This
  8132. resulted in ARI requests failing that were valid, such as a
  8133. channel DELETE with no parameters. The code has now been changed
  8134. to skip json parsing with zero content length. (closes issue
  8135. SWP-6748) Reported by: Samuel Galarneau Review:
  8136. https://reviewboard.asterisk.org/r/3360/ ........ Merged
  8137. revisions 410858 from
  8138. http://svn.asterisk.org/svn/asterisk/branches/12
  8139. 2014-03-18 15:28 +0000 [r410862] Matthew Jordan <mjordan@digium.com>
  8140. * main/cdr.c, /: cdr: Add asserts for when we don't know about a
  8141. CDR for a channel In the CDR core, every channel should either be
  8142. filtered out (due to being an 'internal' channel used as an
  8143. implementation detail, such as playing media back into a bridge)
  8144. or it should get a CDR. Even if that CDR ends up being discarded,
  8145. we still give the channel a CDR in case we end up needing it. If
  8146. we hit a situation where a channel does not have a CDR, we should
  8147. blow up in -dev-mode. Asserts are appropriate for that. This
  8148. patch adds those asserts, as they would have quickly caught the
  8149. error fixed by r410814. ........ Merged revisions 410861 from
  8150. http://svn.asterisk.org/svn/asterisk/branches/12
  8151. 2014-03-18 12:45 +0000 [r410845] Joshua Colp <jcolp@digium.com>
  8152. * /, res/res_pjsip/config_system.c: res_pjsip: Fix memory leak of
  8153. nameservers in off-nominal resolver creation failure. Thanks
  8154. Walter Doekes! ........ Merged revisions 410844 from
  8155. http://svn.asterisk.org/svn/asterisk/branches/12
  8156. 2014-03-18 11:52 +0000 [r410831] Sean Bright <sean@malleable.com>
  8157. * res/res_fax_spandsp.c, /: res_fax_spandsp: Use g711_free() when
  8158. available. Per Johann Steinwendtner on the asterisk-dev mailing
  8159. list:
  8160. http://lists.digium.com/pipermail/asterisk-dev/2014-March/066102.html
  8161. g711_free() was introduced in spandsp 0.0.6pre4 and
  8162. g711_release() became a noop. I opted not to remove the call to
  8163. g711_release() since it is harmless and to call g711_free() if we
  8164. have a sufficiently recent version of spandsp. (issue
  8165. ASTERISK-20149) Reported by: Alexandr Gordeev ........ Merged
  8166. revisions 410829 from
  8167. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8168. revisions 410830 from
  8169. http://svn.asterisk.org/svn/asterisk/branches/12
  8170. 2014-03-18 02:09 +0000 [r410814] Richard Mudgett <rmudgett@digium.com>
  8171. * main/stasis_cache.c, /: stasis_cache: Use the right variable in
  8172. the cache entry ao2 cmp function. ........ Merged revisions
  8173. 410813 from http://svn.asterisk.org/svn/asterisk/branches/12
  8174. 2014-03-17 22:54 +0000 [r410794-410796] Joshua Colp <jcolp@digium.com>
  8175. * include/asterisk/dns.h, CHANGES,
  8176. res/res_pjsip/include/res_pjsip_private.h, res/res_pjsip.c,
  8177. main/dns.c, /, res/res_pjsip/config_system.c: res_pjsip: Enable
  8178. PJSIP DNS client support. This change enables DNS client support
  8179. within PJSIP. System nameservers are automatically discovered
  8180. using res_init or res_ninit. If this fails then PJSIP will resort
  8181. to using gethostbyname for resolution. By enabling this support
  8182. we gain SRV support, failover, and weight support. (closes issue
  8183. ASTERISK-23435) Reported by: Matt Jordan Review:
  8184. https://reviewboard.asterisk.org/r/3343/ ........ Merged
  8185. revisions 410795 from
  8186. http://svn.asterisk.org/svn/asterisk/branches/12
  8187. * res/res_pjsip_multihomed.c, /: res_pjsip_multihomed: Make address
  8188. replacement less aggressive. This change makes the
  8189. res_pjsip_multihomed module less aggressive when changing the
  8190. address in messages. It will now only occur if the transport in
  8191. use is bound to the any address OR if the system determined
  8192. source address matches the bound address of the transport in use.
  8193. Review: https://reviewboard.asterisk.org/r/3369/ ........ Merged
  8194. revisions 410793 from
  8195. http://svn.asterisk.org/svn/asterisk/branches/12
  8196. 2014-03-17 22:24 +0000 [r410775] Russ Meyerriecks <rmeyerreicks@digium.com>
  8197. * /, main/callerid.c: callerid: Logic error in checksum processing
  8198. Callerid checksum-ing was being handled incorrectly here. When
  8199. the checksum is calculated to be 0x00, it will perform 0x100-0x00
  8200. which results in 0x100. This value will then fail the otherwise
  8201. correct callerid message. This patch changes the logic to simply
  8202. add the calculated checksum to the transmitted 2's compliment
  8203. checksum. Review: https://reviewboard.asterisk.org/r/3356/
  8204. (closes issue ASTERISK-23488) ........ This is a merge of merged
  8205. revisions 410750 410747 from
  8206. http://svn.asterisk.org/svn/asterisk/branches/12 I didn't want a
  8207. broken patch to be comitted to trunk so I pre-merge merged them.
  8208. 2014-03-17 19:35 +0000 [r410684-410699] Mark Michelson <mmichelson@digium.com>
  8209. * res/res_mwi_external.c, res/res_pjsip/config_system.c,
  8210. configs/sorcery.conf.sample, include/asterisk/sorcery.h,
  8211. res/res_pjsip/pjsip_configuration.c, tests/test_sorcery_astdb.c,
  8212. tests/test_sorcery.c, tests/test_sorcery_realtime.c,
  8213. main/sorcery.c, /: Revert changes to sorcery that accidentally
  8214. got committed. These changes were still up for review and have
  8215. not been approved yet. I must have had the changes in my working
  8216. copy when making a different change. ........ Merged revisions
  8217. 410696 from http://svn.asterisk.org/svn/asterisk/branches/12
  8218. * bridges/bridge_softmix.c, tests/test_sorcery.c, main/channel.c,
  8219. res/res_pjsip/config_system.c, res/res_mwi_external.c,
  8220. include/asterisk/bridge_channel.h, funcs/func_frame_trace.c,
  8221. configs/sorcery.conf.sample, res/res_pjsip/pjsip_configuration.c,
  8222. include/asterisk/sorcery.h, tests/test_sorcery_astdb.c,
  8223. include/asterisk/frame.h, main/bridge_channel.c,
  8224. tests/test_sorcery_realtime.c, main/sorcery.c,
  8225. res/res_stasis_playback.c, main/frame.c, /: Fix stuck channel in
  8226. ARI through the introduction of synchronous bridge actions.
  8227. Playing back a file to a channel in an ARI bridge would attempt
  8228. to wait until the playback concluded before returning. The method
  8229. used involved signaling the waiting thread in the ARI custom
  8230. playback function. The problem with this is that there were some
  8231. corner cases that were not accounted for: * If a bridge channel
  8232. could not be found, then we never would attempt the playback but
  8233. would still attempt to wait for the playback to complete. * If
  8234. the bridge playfile action failed to queue, we would still
  8235. attempt to wait for the playback to complete. * If the bridge
  8236. playfile action were queued but some circumstance caused the
  8237. playback not to occur (the bridge dies, the channel is removed
  8238. from the bridge), then we would never be notified. The solution
  8239. to this is to move the waiting logic into the bridge code. A new
  8240. bridge API function is added to queue a synchronous action on a
  8241. bridge. The waiting thread is notified when the queued frame has
  8242. been freed, either due to an error occurring or due to successful
  8243. playback. As a failsafe, the waiting thread has a 10 minute
  8244. timeout just in case there is a frame leak somewhere. Review:
  8245. https://reviewboard.asterisk.org/r/3338 ........ Merged revisions
  8246. 410673 from http://svn.asterisk.org/svn/asterisk/branches/12
  8247. 2014-03-17 16:48 +0000 [r410672] Richard Mudgett <rmudgett@digium.com>
  8248. * /, apps/confbridge/conf_chan_announce.c: app_confbridge: Add
  8249. missing destructor call to announcer channel destructor. ........
  8250. Merged revisions 410671 from
  8251. http://svn.asterisk.org/svn/asterisk/branches/12
  8252. 2014-03-16 20:27 +0000 [r410651] Matthew Jordan <mjordan@digium.com>
  8253. * /, res/stasis/app.c: stasis/app.c: Add some extra debugging for
  8254. subscription counts Events are sent to a connected ARI
  8255. application based on the things that ARI application cares about.
  8256. These subscriptions can be set up implicitly - such as when that
  8257. ARI application creates a new object - or explicitly, via the
  8258. application resource's subscription operations. Debugging *why*
  8259. something was being sent to an application - or why something was
  8260. not being sent to an application - was a bit tricky, as there was
  8261. no debug information for the subscriptions. This patch adds some
  8262. debug level 3 statements that show the subscription counts for
  8263. applications. (Level 3 was chosen as it matches the verbose level
  8264. 3 statements elsewhere) ........ Merged revisions 410650 from
  8265. http://svn.asterisk.org/svn/asterisk/branches/12
  8266. 2014-03-15 15:24 +0000 [r410639] Russell Bryant <russell@russellbryant.com>
  8267. * include/asterisk/framehook.h: framehook.h: Fix some doc typos.
  8268. There were a number of instances in this header file where
  8269. "function all" was intended to be "function call". This patch
  8270. fixes that up.
  8271. 2014-03-14 21:56 +0000 [r410626] Mark Michelson <mmichelson@digium.com>
  8272. * /, tests/test_sorcery_realtime.c: Fix failing realtime sorcery
  8273. tests. The store realtime callback needs to return a positive
  8274. value for sorcery to treat the store as a success. ........
  8275. Merged revisions 410625 from
  8276. http://svn.asterisk.org/svn/asterisk/branches/12
  8277. 2014-03-14 21:36 +0000 [r410624] Jonathan Rose <jrose@digium.com>
  8278. * main/manager.c, /: manager: fix memory leak in manager_add_filter
  8279. function (closes issue ASTERISK-23420) Reported by: Etienne
  8280. Lessard Patches: manager_eventfilter_leak uploaded by Etienne
  8281. Lessard (license 6394) ........ Merged revisions 410609 from
  8282. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8283. revisions 410623 from
  8284. http://svn.asterisk.org/svn/asterisk/branches/12
  8285. 2014-03-14 20:55 +0000 [r410591-410608] Mark Michelson <mmichelson@digium.com>
  8286. * /, main/db.c: Remove an extra ast_cond_wait() that slipped
  8287. through the patch. ........ Merged revisions 410606 from
  8288. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8289. revisions 410607 from
  8290. http://svn.asterisk.org/svn/asterisk/branches/12
  8291. * /, main/config.c, res/res_sorcery_realtime.c: Handle the return
  8292. values of realtime updates and stores more accurately. Realtime
  8293. backends' update and store callbacks return the number of rows
  8294. affected, or -1 if there was a failure. There were a couple of
  8295. issues: * The config API was treating 0 as a successful return,
  8296. and positive values as a failure. Now the config API treats
  8297. anything >= 0 as a success. * res_sorcery_realtime was treating 0
  8298. as a successful return from the store procedure, and any positive
  8299. values as a failure. Now sorcery treats anything > 0 as a
  8300. success. It still considers 0 a "failure" since there is no
  8301. change to report to observers. Review:
  8302. https://reviewboard.asterisk.org/r/3341 ........ Merged revisions
  8303. 410592 from http://svn.asterisk.org/svn/asterisk/branches/12
  8304. * /, res/res_pjsip_mwi.c: Prevent conflicts regarding unsolicited
  8305. and solicited MWI to an endpoint. If an endpoint is receiving
  8306. unsolicited MWI for a mailbox and then attempts to subscribe to
  8307. an AOR that provides MWI for the same mailbox, then the SUBSCRIBE
  8308. is rejected with a 500 response. Review:
  8309. https://reviewboard.asterisk.org/r/3345 ........ Merged revisions
  8310. 410590 from http://svn.asterisk.org/svn/asterisk/branches/12
  8311. 2014-03-14 17:56 +0000 [r410589] Scott Griepentrog <sgriepentrog@digium.com>
  8312. * /, CHANGES: uniqueid: Update CHANGES to reflect new features Note
  8313. the new features provided by uniqueid in the CHANGES file. (issue
  8314. ASTERISK-23120) Review: https://reviewboard.asterisk.org/r/3316/
  8315. ........ Merged revisions 410588 from
  8316. http://svn.asterisk.org/svn/asterisk/branches/12
  8317. 2014-03-14 16:42 +0000 [r410575] Jonathan Rose <jrose@digium.com>
  8318. * /, main/acl.c, res/res_pjsip/pjsip_configuration.c,
  8319. contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py,
  8320. CHANGES, res/res_pjsip/config_transport.c,
  8321. include/asterisk/acl.h: PJSIP: TOS values should be represented
  8322. as decimals in sorcery objects (closes issue ASTERISK-23235)
  8323. Reported by: George Joseph Review:
  8324. https://reviewboard.asterisk.org/r/3324/ ........ Merged
  8325. revisions 410574 from
  8326. http://svn.asterisk.org/svn/asterisk/branches/12
  8327. 2014-03-14 16:19 +0000 [r410567] Mark Michelson <mmichelson@digium.com>
  8328. * /, main/db.c: Prevent delayed astdb syncs. The syncing thread
  8329. sleeps for a second before waiting to be told to attempt to sync
  8330. again. If a signal were sent during this sleeping period, we
  8331. would end up having to wait until the next sync signal occurred
  8332. in order to sync up the astdb. This code rearrangement also
  8333. ensures that any pending transactions will be synced prior to
  8334. Asterisk shutting down. Patches: db_sync.patch by John Hardin
  8335. (License #6512) ........ Merged revisions 410556 from
  8336. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8337. revisions 410559 from
  8338. http://svn.asterisk.org/svn/asterisk/branches/12
  8339. 2014-03-14 16:17 +0000 [r410560] Jonathan Rose <jrose@digium.com>
  8340. * res/ari/resource_bridges.c, /: ARI/bridges: Forward
  8341. Playback/Recording Started/Finished to bridge topic (closes issue
  8342. ASTERISK-23444) Reported by: Ben Merrills Review:
  8343. https://reviewboard.asterisk.org/r/3340/ ........ Merged
  8344. revisions 410558 from
  8345. http://svn.asterisk.org/svn/asterisk/branches/12
  8346. 2014-03-14 16:01 +0000 [r410542-410557] Richard Mudgett <rmudgett@digium.com>
  8347. * include/asterisk/app.h, /, res/res_mwi_external.c, main/app.c:
  8348. res_mwi_external: Clear the stasis cache entry when the external
  8349. MWI is deleted. One of the things missing when external MWI
  8350. support was added was the ability to clear the stasis cache entry
  8351. of deleted external MWI mailboxes. Review:
  8352. https://reviewboard.asterisk.org/r/3325/ ........ Merged
  8353. revisions 410555 from
  8354. http://svn.asterisk.org/svn/asterisk/branches/12
  8355. * /, main/cdr.c: cdr.c: Add missing aow_unlock(cdr) in off nominal
  8356. path of handle_dial_message(). * Trivial common code hoisting in
  8357. handle_bridge_leave_message(). * Some whitespace fixing. ........
  8358. Merged revisions 410541 from
  8359. http://svn.asterisk.org/svn/asterisk/branches/12
  8360. 2014-03-13 19:33 +0000 [r410528] Kinsey Moore <kmoore@digium.com>
  8361. * res/stasis/control.h, res/res_stasis.c, /, res/stasis/control.c:
  8362. ARI: Ensure managing application receives ChannelEnteredBridge
  8363. messages This fixes an issue where a Stasis application running
  8364. over ARI and subscribed to ari/events could miss the
  8365. ChannelEnteredBridge event because it did not subscribe to the
  8366. new bridge fast enough. To accomplish this, it subscribes the
  8367. application controlling the channel to the new bridge before
  8368. adding it to that bridge which required the stasis_app_control
  8369. structure to maintain a reference to the stasis_app. (closes
  8370. issue ASTERISK-23295) Review:
  8371. https://reviewboard.asterisk.org/r/3336/ ........ Merged
  8372. revisions 410527 from
  8373. http://svn.asterisk.org/svn/asterisk/branches/12
  8374. 2014-03-13 13:25 +0000 [r410511] Joshua Colp <jcolp@digium.com>
  8375. * res/res_pjsip_multihomed.c, /: Multiple revisions 410509-410510
  8376. ........ r410509 | file | 2014-03-13 06:23:14 -0700 (Thu, 13 Mar
  8377. 2014) | 2 lines res_pjsip_multihomed: Fix a bug where the 200 OK
  8378. for a REGISTER would contain the wrong contact. ........ r410510
  8379. | file | 2014-03-13 06:24:17 -0700 (Thu, 13 Mar 2014) | 2 lines
  8380. res_pjsip_multihomed: Remove change for testing fix. ........
  8381. Merged revisions 410509-410510 from
  8382. http://svn.asterisk.org/svn/asterisk/branches/12
  8383. 2014-03-12 19:06 +0000 [r410492-410494] Richard Mudgett <rmudgett@digium.com>
  8384. * res/res_musiconhold.c, main/channel.c, /: res_musiconhold.c:
  8385. Generate MOH start/stop events whenever the MOH stream is
  8386. started/stopped. * Made res_musiconhold.c always post the
  8387. MusicOnHoldStart/MusicOnHoldStop events when it actually
  8388. starts/stops the music streams. This allows the events to always
  8389. happen when MOH starts/stops. The event posting code was moved to
  8390. the MOH alloc/release routines. * Made channel_do_masquerade()
  8391. stop any MOH on the original channel before masquerading so the
  8392. original channel will get a stop event with correct information.
  8393. * Cleaned up a couple odd codings in moh_files_alloc() and
  8394. moh_alloc() dealing with the music state variable. (issue
  8395. ASTERISK-23311) Reported by: Benjamin Keith Ford Review:
  8396. https://reviewboard.asterisk.org/r/3306/ ........ Merged
  8397. revisions 410493 from
  8398. http://svn.asterisk.org/svn/asterisk/branches/12
  8399. * apps/confbridge/conf_state.c,
  8400. apps/confbridge/conf_state_single.c,
  8401. apps/confbridge/conf_state_inactive.c,
  8402. apps/confbridge/conf_state_single_marked.c, /: app_confbridge:
  8403. Make explicitly stop MOH if a user is kicked or hangs up while
  8404. MOH is playing. When MOH is playing to a user in a conference and
  8405. the user is kicked or hangs up from the conference then the AMI
  8406. MusicOnHoldStop events didn't happen. (Asterisk v11 AMI event:
  8407. MusicOnHold, state:Stop) (closes issue ASTERISK-23311) Reported
  8408. by: Benjamin Keith Ford Review:
  8409. https://reviewboard.asterisk.org/r/3306/ ........ Merged
  8410. revisions 410490 from
  8411. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8412. revisions 410491 from
  8413. http://svn.asterisk.org/svn/asterisk/branches/12
  8414. 2014-03-12 12:51 +0000 [r410452-410472] Joshua Colp <jcolp@digium.com>
  8415. * res/res_pjsip_multihomed.c, /: res_pjsip_multihomed: Fix a bug
  8416. where outgoing messages for TCP would go out using UDP. This
  8417. change fixes a bug where the code which changes the transport did
  8418. not check whether the message is going out over UDP or not before
  8419. changing it. For TCP and TLS transports we don't need to change
  8420. the transport as the correct one is already chosen. ........
  8421. Merged revisions 410471 from
  8422. http://svn.asterisk.org/svn/asterisk/branches/12
  8423. * res/res_pjsip_multihomed.c (added), /: res_pjsip_multihomed: Add
  8424. module which places the correct address within messages. Due to
  8425. how messages are handled within PJSIP it is not until a message
  8426. is actually sent that the destination is reliably known. This
  8427. means that the addresses placed within the message may not be of
  8428. the interface the message is being sent out on. This module
  8429. determines what interface a message is being sent on and updates
  8430. the message to contain the correct address if applicable. This
  8431. module was tested by myself in a virtualized environment with
  8432. multiple interfaces and also by Kinsey Moore in the following
  8433. configuration: Networks: * 10.24.16.0/21 ** hard phone ** default
  8434. gateway * 10.24.64.0/21 ** softphone with pjsip-based stack
  8435. Transport details: bind address: 0.0.0.0 protocol: UDP All
  8436. endpoints were tested with explicitly configured transports and
  8437. unconfigured transports. This was tested with inbound and
  8438. outbound calls, both of which were experiencing detrimental
  8439. effects from incorrect IP addresses in SIP messages. These
  8440. effects were only experienced by the soft phone on the 10.24.64.0
  8441. network since the messages to the hard phone on the 10.24.16.0
  8442. network had the correct IP address. (closes issue ASTERISK-23020)
  8443. Reported by: xrobau Review:
  8444. https://reviewboard.asterisk.org/r/3102/ ........ Merged
  8445. revisions 410451 from
  8446. http://svn.asterisk.org/svn/asterisk/branches/12
  8447. 2014-03-10 17:21 +0000 [r410395] Richard Mudgett <rmudgett@digium.com>
  8448. * /, main/http.c: AST-2014-001: Stack overflow in HTTP processing
  8449. of Cookie headers. Sending a HTTP request that is handled by
  8450. Asterisk with a large number of Cookie headers could overflow the
  8451. stack. Another vulnerability along similar lines is any HTTP
  8452. request with a ridiculous number of headers in the request could
  8453. exhaust system memory. (closes issue ASTERISK-23340) Reported by:
  8454. Lucas Molas, researcher at Programa STIC, Fundacion; and Dr.
  8455. Manuel Sadosky, Buenos Aires, Argentina ........ Merged revisions
  8456. 410380 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  8457. ........ Merged revisions 410381 from
  8458. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8459. revisions 410383 from
  8460. http://svn.asterisk.org/svn/asterisk/branches/12
  8461. 2014-03-10 16:33 +0000 [r410369] Scott Griepentrog <sgriepentrog@digium.com>
  8462. * res/ari/resource_channels.c, main/manager.c, /: unqiueid: correct
  8463. max uniqueid length test This patch adds null string test prior
  8464. to checking for a max uniqueid value that was added in r410157.
  8465. ........ Merged revisions 410368 from
  8466. http://svn.asterisk.org/svn/asterisk/branches/12
  8467. 2014-03-10 13:30 +0000 [r410346] Kinsey Moore <kmoore@digium.com>
  8468. * /, channels/chan_sip.c: AST-2014-002: chan_sip: Exit early on bad
  8469. session timers request This change allows chan_sip to avoid
  8470. creation of the channel and consumption of associated file
  8471. descriptors altogether if the inbound request is going to be
  8472. rejected anyway. (closes issue ASTERISK-23373) Reported by: Corey
  8473. Farrell Patches: chan_sip-earlier-st-1.8.patch uploaded by Corey
  8474. Farrell (license 5909) chan_sip-earlier-st-11.patch uploaded by
  8475. Corey Farrell (license 5909) ........ Merged revisions 410308
  8476. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  8477. Merged revisions 410311 from
  8478. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8479. revisions 410329 from
  8480. http://svn.asterisk.org/svn/asterisk/branches/12
  8481. 2014-03-10 12:53 +0000 [r410307] Joshua Colp <jcolp@digium.com>
  8482. * /, res/res_pjsip/pjsip_options.c, res/res_pjsip.c: AST-2014-003:
  8483. res_pjsip: When handling 401/407 responses don't assume a request
  8484. will have an endpoint. This change removes the assumption that an
  8485. outgoing request will always have an endpoint and makes the
  8486. authenticate_qualify option work once again. (closes issue
  8487. ASTERISK-23210) Reported by: Joshua Colp ........ Merged
  8488. revisions 410306 from
  8489. http://svn.asterisk.org/svn/asterisk/branches/12
  8490. 2014-03-08 16:50 +0000 [r410288] George Joseph <george.joseph@fairview5.com>
  8491. * res/res_pjsip/config_auth.c, /, res/res_pjsip/location.c,
  8492. res/res_pjsip_outbound_registration.c,
  8493. res/res_pjsip_endpoint_identifier_ip.c,
  8494. include/asterisk/res_pjsip_cli.h, include/asterisk/sorcery.h,
  8495. res/res_pjsip/pjsip_cli.c, res/res_pjsip/pjsip_configuration.c,
  8496. res/res_pjsip/config_transport.c, main/sorcery.c,
  8497. include/asterisk/res_pjsip.h: pjsip_cli: Create pjsip show
  8498. channel and contact, and general cli code cleanup. Created the
  8499. 'pjsip show channel' and 'pjsip show contact' commands.
  8500. Refactored out the hated ast_hashtab. Replaced with
  8501. ao2_container. Cleaned up function naming. Internal only, no
  8502. public name changes. Cleaned up whitespace and brace formatting
  8503. in cli code. Changed some NULL checking from "if"s to
  8504. ast_asserts. Fixed some register/unregister ordering to reduce
  8505. deadlock potential. Fixed ast_sip_location_add_contact where the
  8506. 'name' buffer was too short. Fixed some self-assignment issues in
  8507. res_pjsip_outbound_registration. (closes issue ASTERISK-23276)
  8508. Review: http://reviewboard.asterisk.org/r/3283/ ........ Merged
  8509. revisions 410287 from
  8510. http://svn.asterisk.org/svn/asterisk/branches/12
  8511. 2014-03-08 15:45 +0000 [r410275] Matthew Jordan <mjordan@digium.com>
  8512. * /, res/ari/resource_channels.c: resource_channels: Check if a
  8513. passed in ID is NULL before checking its length Calling strlen on
  8514. a NULL string is explosive. This patch checks whether or not the
  8515. passed in string is NULL or zero length before checking to see if
  8516. the string is too long. ........ Merged revisions 410274 from
  8517. http://svn.asterisk.org/svn/asterisk/branches/12
  8518. 2014-03-07 22:56 +0000 [r410227] Corey Farrell <git@cfware.com>
  8519. * /, channels/chan_sip.c: chan_sip: Fix deadlock of monlock between
  8520. unload_module and do_monitor Release monlock before calling
  8521. pthread_join. This ensures do_monitor cannot freeze by locking
  8522. monlock during module unload. (closes issue ASTERISK-21406)
  8523. Reported by: Corey Farrell Review:
  8524. https://reviewboard.asterisk.org/r/3284/ ........ Merged
  8525. revisions 410224 from
  8526. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8527. revisions 410225 from
  8528. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8529. revisions 410226 from
  8530. http://svn.asterisk.org/svn/asterisk/branches/12
  8531. 2014-03-07 22:08 +0000 [r410212] Scott Griepentrog <sgriepentrog@digium.com>
  8532. * /, include/asterisk/sorcery.h: sorcery: correct field register
  8533. argument list This fixes mistakes I previously made in merging
  8534. gtjoseph's changes with mine. ........ Merged revisions 410211
  8535. from http://svn.asterisk.org/svn/asterisk/branches/12
  8536. 2014-03-07 21:54 +0000 [r410208-410210] Matthew Jordan <mjordan@digium.com>
  8537. * /, main/config_options.c: config_options: Display the see-also
  8538. information for CLI config option help The config option help
  8539. information has always parsed the <see-also> tags in the XML
  8540. documentation. Unfortunately, it just never bothered displaying
  8541. them on the CLI. With this patch, when you execute 'config show
  8542. help [module] [obj] [option]', it will display what other options
  8543. are useful to you. (closes issue ASTERISK-22008) Reported by:
  8544. Richard Mudgett ........ Merged revisions 410209 from
  8545. http://svn.asterisk.org/svn/asterisk/branches/12
  8546. * res/res_pjsip.c, /: res_pjsip: Fix documentation for one touch
  8547. recording see-also links The one touch recording options have
  8548. several see-also links between the various configuration options.
  8549. These were 'broken' by the snake casing of those options. This
  8550. patch corrects the see-also links such that they reference the
  8551. correct option names. ........ Merged revisions 410194 from
  8552. http://svn.asterisk.org/svn/asterisk/branches/12
  8553. 2014-03-07 21:23 +0000 [r410207] Mark Michelson <mmichelson@digium.com>
  8554. * main/sorcery.c, res/res_sorcery_realtime.c, /,
  8555. include/asterisk/sorcery.h, tests/test_sorcery_realtime.c: Make
  8556. res_sorcery_realtime filter unknown retrieved results. When
  8557. retrieving data from a database or other realtime backend, it's
  8558. quite possible to retrieve variables that Asterisk does not care
  8559. about but that are legitimate to exist. Asterisk does not need to
  8560. throw a hissy fit when these variables are encountered but rather
  8561. just filter them out. Review:
  8562. https://reviewboard.asterisk.org/r/3305 ........ Merged revisions
  8563. 410187 from http://svn.asterisk.org/svn/asterisk/branches/12
  8564. 2014-03-07 21:11 +0000 [r410191] Scott Griepentrog <sgriepentrog@digium.com>
  8565. * main/sorcery.c, /, include/asterisk/sorcery.h,
  8566. res/res_pjsip/pjsip_configuration.c: pjsip: allow and disallow
  8567. show same codecs In order to prevent confusion over the allow and
  8568. disallow list of codecs being the same an option for registering
  8569. a field as an alias is added. The alias field will be read from
  8570. the configuration file, but afterwards is not listed as a known
  8571. field. With disallow set as an alias, the CLI command pjsip show
  8572. endpoint # will list the allow= field, but not the disallow
  8573. field. (closes issue ASTERISK-23092) Review:
  8574. https://reviewboard.asterisk.org/r/3193/ ........ Merged
  8575. revisions 410190 from
  8576. http://svn.asterisk.org/svn/asterisk/branches/12
  8577. 2014-03-07 20:41 +0000 [r410174-410185] Richard Mudgett <rmudgett@digium.com>
  8578. * include/asterisk/devicestate.h, main/stasis_cache.c,
  8579. main/stasis_message.c, /, tests/test_devicestate.c,
  8580. include/asterisk/stasis.h, main/app.c, main/devicestate.c,
  8581. tests/test_stasis.c: stasis cache: Enhance to keep track of an
  8582. item from different entities. A stasis cache entry now contains
  8583. more than a single message/snapshot. It contains
  8584. messages/snapshots for the local entity as well as any remote
  8585. entities that post to the cached item. In addition callbacks can
  8586. be supplied when the cache is created to compute and post the
  8587. aggregate message/snapshot representing all entities stored in
  8588. the cache entry. * All stasis messages now have an eid to
  8589. indicate what entity posted it. * The stasis cache enhancements
  8590. allow device state to cache and aggregate the device states from
  8591. local and remote entities in a single operation. The cached
  8592. aggregate device state is available immediately after it is
  8593. posted to the stasis bus. This improves performance by
  8594. eliminating a cache dump and associated ao2 container traversals
  8595. to calculate the aggregate state. (closes issue ASTERISK-23204)
  8596. Reported by: Mark Michelson Review:
  8597. https://reviewboard.asterisk.org/r/3281/ ........ Merged
  8598. revisions 410184 from
  8599. http://svn.asterisk.org/svn/asterisk/branches/12
  8600. * tests/test_cel.c, channels/sig_pri.c, channels/sig_ss7.c,
  8601. include/asterisk/bridge.h, tests/test_cdr.c, channels/sig_pri.h,
  8602. channels/chan_dahdi.c, channels/sig_ss7.h, /: uniqueid: Fix
  8603. chan_dahdi, sig_pri, sig_ss7, test_cdr, and test_cel compiler
  8604. errors. (issue ASTERISK-23120) ........ Merged revisions 410171
  8605. from http://svn.asterisk.org/svn/asterisk/branches/12
  8606. 2014-03-07 15:47 +0000 [r410158] Scott Griepentrog <sgriepentrog@digium.com>
  8607. * tests/test_cdr.c, res/res_clioriginate.c, res/res_ari_bridges.c,
  8608. tests/test_substitution.c, res/res_stasis_playback.c,
  8609. channels/chan_multicast_rtp.c, apps/app_meetme.c, /,
  8610. main/bridge_basic.c, include/asterisk/channel_internal.h,
  8611. tests/test_app.c, apps/confbridge/conf_chan_record.c,
  8612. main/core_unreal.c, channels/chan_gtalk.c,
  8613. include/asterisk/stasis_app_playback.h,
  8614. res/ari/resource_bridges.c, channels/chan_jingle.c,
  8615. channels/chan_phone.c, pbx/pbx_spool.c,
  8616. res/ari/resource_bridges.h, res/parking/parking_tests.c,
  8617. channels/chan_motif.c, apps/app_confbridge.c,
  8618. res/ari/resource_channels.c, include/asterisk/pbx.h,
  8619. res/res_stasis.c, include/asterisk/bridge.h,
  8620. apps/app_voicemail.c, res/ari/resource_channels.h,
  8621. apps/app_dial.c, res/res_calendar_exchange.c,
  8622. channels/chan_vpb.cc, apps/app_page.c, apps/app_chanisavail.c,
  8623. include/asterisk/dial.h, main/core_local.c,
  8624. res/parking/parking_bridge_features.c,
  8625. tests/test_stasis_endpoints.c, res/parking/parking_bridge.c,
  8626. channels/chan_skinny.c, include/asterisk/stasis_app_snoop.h,
  8627. addons/chan_mobile.c, main/bridge_channel.c,
  8628. channels/chan_pjsip.c, channels/chan_mgcp.c,
  8629. channels/chan_unistim.c, main/pbx.c,
  8630. res/res_calendar_icalendar.c, main/ccss.c,
  8631. channels/chan_bridge_media.c, main/bridge.c,
  8632. tests/test_stasis_channels.c, apps/app_bridgewait.c,
  8633. apps/app_originate.c, res/res_calendar_caldav.c,
  8634. include/asterisk/channel.h, res/parking/parking_applications.c,
  8635. apps/app_followme.c, main/cel.c, apps/app_queue.c,
  8636. res/res_ari_channels.c, res/res_calendar_ews.c,
  8637. rest-api/api-docs/bridges.json, main/dial.c,
  8638. channels/chan_dahdi.c, channels/chan_h323.c, tests/test_cel.c,
  8639. rest-api/api-docs/channels.json,
  8640. include/asterisk/bridge_internal.h,
  8641. apps/confbridge/conf_chan_announce.c, res/res_calendar.c,
  8642. include/asterisk/core_unreal.h, addons/chan_ooh323.c,
  8643. res/stasis/control.c, channels/chan_sip.c,
  8644. main/channel_internal_api.c, include/asterisk/stasis_app.h,
  8645. res/res_stasis_snoop.c, channels/chan_console.c,
  8646. channels/chan_iax2.c, channels/chan_oss.c, apps/app_agent_pool.c,
  8647. main/channel.c, main/manager.c, channels/chan_misdn.c,
  8648. tests/test_voicemail_api.c, channels/chan_alsa.c,
  8649. channels/chan_nbs.c, main/message.c: uniqueid: channel linkedid,
  8650. ami, ari object creation with id's Much needed was a way to
  8651. assign id to objects on creation, and much change was necessary
  8652. to accomplish it. Channel uniqueids and linkedids are split into
  8653. separate string and creation time components without breaking
  8654. linkedid propgation. This allowed the uniqueid to be specified by
  8655. the user interface - and those values are now carried through to
  8656. channel creation, adding the assignedids value to every function
  8657. in the chain including the channel drivers. For local channels,
  8658. the second channel can be specified or left to default to a ;2
  8659. suffix of first. In ARI, bridge, playback, and snoop objects can
  8660. also be created with a specified uniqueid. Along the way, the
  8661. args order to allocating channels was fixed in chan_mgcp and
  8662. chan_gtalk, and linkedid is no longer lost as masquerade occurs.
  8663. (closes issue ASTERISK-23120) Review:
  8664. https://reviewboard.asterisk.org/r/3191/ ........ Merged
  8665. revisions 410157 from
  8666. http://svn.asterisk.org/svn/asterisk/branches/12
  8667. 2014-03-07 05:04 +0000 [r410108] Matthew Jordan <mjordan@digium.com>
  8668. * /, channels/chan_sip.c: chan_sip: Allow static realtime members
  8669. to be qualified during module load. When a static realtime peer
  8670. with qualify=yes is loaded, Asterisk will fail to send an OPTIONS
  8671. request due to the lastms being equal to 0. This results in the
  8672. peer being unable to receive calls from Asterisk because the
  8673. status is permanently UNKNOWN. This patch allows an OPTIONS
  8674. request to be sent during module load by ignoring the lastms
  8675. value on startup only. Review:
  8676. https://reviewboard.asterisk.org/r/3294/ (closes issue
  8677. ASTERISK-17523) Reported by: Maciej Krajewski Tested by:
  8678. wushumasters patches: realtime_fix_11.7.0.txt uploaded by Trevor
  8679. Peirce (license 6112) ........ Merged revisions 410105 from
  8680. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8681. revisions 410106 from
  8682. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8683. revisions 410107 from
  8684. http://svn.asterisk.org/svn/asterisk/branches/12
  8685. 2014-03-06 23:47 +0000 [r410092] Richard Mudgett <rmudgett@digium.com>
  8686. * main/sorcery.c, /: sorcery.c: Fix off-nominal path ref and memory
  8687. leak in ast_sorcery_objectset_json_create(). * Made exit a loop
  8688. early on error in ast_sorcery_objectset_json_create(). * Removed
  8689. some dead code in ast_sorcery_objectset_create2(). ........
  8690. Merged revisions 410089 from
  8691. http://svn.asterisk.org/svn/asterisk/branches/12
  8692. 2014-03-06 23:43 +0000 [r410091] Russell Bryant <russell@russellbryant.com>
  8693. * /, res/res_musiconhold.c: moh: fix a refcount error with realtime
  8694. MOH I observed a crash in res_musiconhold on an Asterisk 11
  8695. system using realtime MOH. Investigation of the backtrace showed
  8696. a corrupt mohclass, implying that it got destroyed before the
  8697. code expected it to. I went looking for reference counting errors
  8698. that could have caused this crash and this patch this result. It
  8699. contains 2 changes. 1) Remove a usless block of code that was
  8700. impossible to reach. There was even a comment indicating that it
  8701. was impossible to reach. The conditional includes
  8702. "!ast_test_flag(global_flags, MOH_CACHERTCLASSES)" and it's
  8703. inside of an if block with the opposite check
  8704. "ast_test_flag(global_flags, MOH_CACHERTCLASSES)". There's no
  8705. good reason to keep it around. 2) A similar block to #1 contained
  8706. a reference counting error. It stores state->class in the local
  8707. variable mohclass without increasing its reference count. The
  8708. reference count on mohclass is decremented at the end of the
  8709. function. This block of code probably very rarely runs, which
  8710. would help explain why this system was working fine for many
  8711. months before experiencing a crash. Review:
  8712. https://reviewboard.asterisk.org/r/3282/ ........ Merged
  8713. revisions 410043 from
  8714. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8715. revisions 410044 from
  8716. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8717. revisions 410090 from
  8718. http://svn.asterisk.org/svn/asterisk/branches/12
  8719. 2014-03-06 22:39 +0000 [r410042] George Joseph <george.joseph@fairview5.com>
  8720. * res/res_pjsip/config_auth.c, funcs/func_sorcery.c (added),
  8721. res/res_pjsip/location.c, res/res_pjsip_outbound_registration.c,
  8722. main/bucket.c, res/res_pjsip_endpoint_identifier_ip.c,
  8723. include/asterisk/config.h, include/asterisk/sorcery.h,
  8724. res/res_pjsip/pjsip_configuration.c, res/res_pjsip_acl.c,
  8725. CHANGES, tests/test_sorcery.c, res/res_pjsip/config_transport.c,
  8726. main/config.c, main/sorcery.c: sorcery: Create AST_SORCERY
  8727. dialplan function. This patch creates the AST_SORCERY dialplan
  8728. function which allows someone to retrieve any value from a
  8729. sorcery-based config file. It's similar to AST_CONFIG. The
  8730. creation of the function itself was fairly straightforward but it
  8731. required changes to the underlying sorcery infrastructure that
  8732. rippled into individual sorcery objects. The changes stemmed from
  8733. inconsistencies in how sorcery created ast_variable objectsets
  8734. from sorcery objects and the inconsistency in how individual
  8735. objects used that feature especially when it came to parameters
  8736. that can be specified multiple times like contact in aor and
  8737. match in identify. You can read more here...
  8738. http://lists.digium.com/pipermail/asterisk-dev/2014-February/065202.html
  8739. So, what this patch does, besides actually creating the
  8740. AST_SORCERY function, is the following... * Creates
  8741. ast_variable_list_append which is a helper to append one
  8742. ast_variable list to another. * Modifies the
  8743. ast_sorcery_object_field_register functions to accept the
  8744. already-defined sorcery_fields_handler callback. * Modifies
  8745. ast_sorcery_objectset_create to accept a parameter indicating
  8746. return type preference...a single ast_variable with all values
  8747. concatenated or an ast_variable list with multiple entries. Also
  8748. fixed a few bugs. * Modifies individual sorcery object
  8749. implementations to use the new function definition of the
  8750. ast_sorcery_object_field_register functions. * Modifies
  8751. location.c and res_pjsip_endpoint_identifier_ip.c to implement
  8752. sorcery_fields_handler handlers so they return multiple
  8753. occurrences as an ast_variable_list. * Added a whole bunch of
  8754. tests to test_sorcery. (closes issue ASTERISK-22537) Review:
  8755. http://reviewboard.asterisk.org/r/3254/
  8756. 2014-03-06 19:04 +0000 [r410029] Jonathan Rose <jrose@digium.com>
  8757. * include/asterisk/acl.h, /, main/acl.c,
  8758. res/res_pjsip/pjsip_configuration.c, UPGRADE.txt,
  8759. contrib/ast-db-manage/config/versions/4c573e7135bd_fix_tos_field_types.py
  8760. (added), res/res_pjsip/config_transport.c: pjsip configuration:
  8761. Make transport TOS values consistent with endpoints Transport TOS
  8762. values were interpreted as DSCP values without being documented
  8763. as such. Endpoint TOS values (tos_audio/tos_video) behaved
  8764. normally as TOS values have historically. This patch makes the
  8765. transport TOS values behave as TOS values and makes all TOS
  8766. values readable as string values (e.g. AF11). In addition,
  8767. alembic scripts have been updated to use the proper field types
  8768. for all TOS/COS values. (issue ASTERISK-23235) Reported by:
  8769. George Joseph Review: https://reviewboard.asterisk.org/r/3304/
  8770. ........ Merged revisions 410028 from
  8771. http://svn.asterisk.org/svn/asterisk/branches/12
  8772. 2014-03-06 18:20 +0000 [r410027] Joshua Colp <jcolp@digium.com>
  8773. * res/ari/resource_channels.c, CHANGES,
  8774. res/ari/ari_model_validators.c,
  8775. rest-api/api-docs/recordings.json, res/ari/resource_bridges.c,
  8776. res/ari/ari_model_validators.h, /,
  8777. include/asterisk/stasis_app_recording.h,
  8778. res/res_stasis_recording.c: res_stasis_recording: Add a
  8779. "target_uri" field to recording events. This change adds a
  8780. target_uri field to the live recording object. It contains the
  8781. URI of what is being recorded. (closes issue ASTERISK-23258)
  8782. Reported by: Ben Merrills Review:
  8783. https://reviewboard.asterisk.org/r/3299/ ........ Merged
  8784. revisions 410025 from
  8785. http://svn.asterisk.org/svn/asterisk/branches/12
  8786. 2014-03-06 15:58 +0000 [r410012] Mark Michelson <mmichelson@digium.com>
  8787. * res/res_pjsip_mwi.c, /: Don't attempt to link in an aggregate MWI
  8788. subscription if an endpoint does not aggregate MWI. Attempting to
  8789. link a NULL object into an ao2 container had been benign
  8790. previously, but since enabling DO_CRASH in the testsuite, this is
  8791. now causing a crash. It's better to be right here anyway.
  8792. ........ Merged revisions 410011 from
  8793. http://svn.asterisk.org/svn/asterisk/branches/12
  8794. 2014-03-06 02:22 +0000 [r409996] Matthew Jordan <mjordan@digium.com>
  8795. * res/res_fax_spandsp.c, /: res_fax_spandsp: Fix crash when passing
  8796. ulaw/alaw data to spandsp When acting as a T.38 fax gateway,
  8797. res_fax_spandsp would at times cause a crash in libspandsp. This
  8798. would occur when, during fax tone detection, a ulaw/alaw frame
  8799. would be passed to modem_connect_tones_rx. That particular
  8800. routine expects the data to be in slin format. This patch looks
  8801. at the frame type and, if the data is ulaw/alaw, converts the
  8802. format to slin before passing it to modem_connect_tones_rx.
  8803. Review: https://reviewboard.asterisk.org/r/3296 (closes issue
  8804. ASTERISK-20149) Reported by: Alexandr Gordeev Tested by: Michal
  8805. Rybarik patches: spandsp_g711decode.diff uploaded by Michal
  8806. Rybarik (license 6578) ........ Merged revisions 409990 from
  8807. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8808. revisions 409991 from
  8809. http://svn.asterisk.org/svn/asterisk/branches/12
  8810. 2014-03-06 00:33 +0000 [r409970-409977] Richard Mudgett <rmudgett@digium.com>
  8811. * apps/confbridge/conf_state_multi.c,
  8812. apps/confbridge/conf_state_inactive.c, /: app_confbridge: Remove
  8813. some noop code. ........ Merged revisions 409976 from
  8814. http://svn.asterisk.org/svn/asterisk/branches/12
  8815. * /, res/res_musiconhold.c: res_musiconhold.c: Remove some
  8816. unnecessary RAII_VAR() usage. * Made the moh_register() define
  8817. use useful parameter names. ........ Merged revisions 409967 from
  8818. http://svn.asterisk.org/svn/asterisk/branches/12
  8819. 2014-03-05 20:41 +0000 [r409904-409919] Kinsey Moore <kmoore@digium.com>
  8820. * main/config.c, /: config: Fix inverted test The test of the
  8821. result of the stat() call was inverted such that its output was
  8822. only used if the call failed. This inverts the test so that the
  8823. output of stat() is used correctly. This was causing full reloads
  8824. on unchanged files. (closes issue ASTERISK-23383) Reported by:
  8825. David Woolley ........ Merged revisions 409916 from
  8826. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8827. revisions 409917 from
  8828. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8829. revisions 409918 from
  8830. http://svn.asterisk.org/svn/asterisk/branches/12
  8831. * bridges/bridge_native_rtp.c, /: bridge_native_rtp: Fix crash
  8832. involving masquerade It is possible for a channel to be
  8833. masqueraded out of a bridge which means it may no longer have RTP
  8834. glue to check upon leaving said bridge. If this situation
  8835. occurred (it's possible at least during dial and call pickup)
  8836. then Asterisk would crash. This change makes sure the glue is
  8837. checked before use. (closes issue AST-1290) Reported by: John
  8838. Bigelow ........ Merged revisions 409900 from
  8839. http://svn.asterisk.org/svn/asterisk/branches/12
  8840. 2014-03-05 18:51 +0000 [r409889] Richard Mudgett <rmudgett@digium.com>
  8841. * contrib/ast-db-manage/cdr/versions,
  8842. contrib/ast-db-manage/cdr/versions/210693f3123d_create_cdr_table.py,
  8843. /,
  8844. contrib/ast-db-manage/config/versions/28887f25a46f_create_queue_tables.py
  8845. (added), contrib/ast-db-manage/cdr.ini.sample (added),
  8846. contrib/ast-db-manage/cdr/env.py, contrib/ast-db-manage/cdr
  8847. (added), contrib/ast-db-manage/cdr/script.py.mako: alembic: Add
  8848. missing queue and CDR table creation scripts. * Added the queues
  8849. and queue_members tables to the config alembic scripts. * Added
  8850. the CDR table alembic creation script. The CDR table is more of
  8851. an example for new setups since the actual table can be fully
  8852. customized in cdr_adaptive_odbc.conf. (closes issue
  8853. ASTERISK-23233) Reported by: jmls Review:
  8854. https://reviewboard.asterisk.org/r/3227/ ........ Merged
  8855. revisions 409885 from
  8856. http://svn.asterisk.org/svn/asterisk/branches/12
  8857. 2014-03-05 18:47 +0000 [r409888] Mark Michelson <mmichelson@digium.com>
  8858. * funcs/func_presencestate.c, /: Fix documentation for
  8859. PRESENCE_STATE to properly illustrate how to create a presence
  8860. hint. There was a missing comma. This was discovered by Dan
  8861. Kaplan. ........ Merged revisions 409886 from
  8862. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8863. revisions 409887 from
  8864. http://svn.asterisk.org/svn/asterisk/branches/12
  8865. 2014-03-05 16:58 +0000 [r409836] David M. Lee <dlee@digium.com>
  8866. * main/config.c, /, configure, include/asterisk/autoconfig.h.in,
  8867. configure.ac: Corrected cross-platform stat nanosecond code When
  8868. nanosecond time resolution was added for identifying config file
  8869. changes, it didn't cover all of the myriad of ways that one might
  8870. obtain nanosecond time resolution off of struct stat. Rather than
  8871. complicate the #if even further figuring out one system from the
  8872. next, this patch directly tests for the three struct members I
  8873. know about today, and #ifdef's accordingly. Review:
  8874. https://reviewboard.asterisk.org/r/3273/ ........ Merged
  8875. revisions 409833 from
  8876. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8877. revisions 409834 from
  8878. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8879. revisions 409835 from
  8880. http://svn.asterisk.org/svn/asterisk/branches/12
  8881. 2014-03-05 16:26 +0000 [r409831-409832] Moises Silva <moises.silva@gmail.com>
  8882. * res/res_http_websocket.c: Fix res/res_http_websocket.c build
  8883. failure in 32bit due to incorrect print format for uint64_t
  8884. * res/res_http_websocket.c, /: Fix WebRTC over WSS not working
  8885. Several fixes for the WebSockets implementation in
  8886. res/res_http_websocket.c * Flush the websocket session FILE* as
  8887. fwrite() may not actually guarantee sending the data to the
  8888. network. If we do not flush, it seems that buffering on the SSL
  8889. socket for outbound messages causes issues * Refactored
  8890. ast_websocket_read to take into account that SSL file descriptors
  8891. may be ready to read via fread() but poll() will not actually say
  8892. so because the data was already read from the network buffers and
  8893. is now in the libc buffers (closes issue ASTERISK-23099) (closes
  8894. issue ASTERISK-21930) Review:
  8895. https://reviewboard.asterisk.org/r/3248/ ........ Merged
  8896. revisions 409681 from
  8897. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8898. revisions 409697 from
  8899. http://svn.asterisk.org/svn/asterisk/branches/12
  8900. 2014-03-05 12:06 +0000 [r409780] Sean Bright <sean@malleable.com>
  8901. * contrib/scripts/astgenkey, contrib/scripts/astgenkey.8, /: Fix
  8902. references to 'keys' CLI commands in astgenkey ........ Merged
  8903. revisions 409777 from
  8904. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8905. revisions 409778 from
  8906. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8907. revisions 409779 from
  8908. http://svn.asterisk.org/svn/asterisk/branches/12
  8909. 2014-03-05 06:17 +0000 [r409747] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  8910. * channels/chan_unistim.c: Add update_peer function to
  8911. unistim_rtp_glue, improve other unistim_rtp_glue functions
  8912. conforming to other channel drivers. Do not forget auto-detected
  8913. and user-selected phone settings on 'unistim reload' ........
  8914. Merged revisions 409705 from
  8915. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8916. revisions 409745 from
  8917. http://svn.asterisk.org/svn/asterisk/branches/11
  8918. 2014-03-05 01:05 +0000 [r409683] Richard Mudgett <rmudgett@digium.com>
  8919. * /, include/asterisk/stasis_internal.h: stasis: Made
  8920. internal_stasis_subscribe() prototype and definition match
  8921. exactly. ........ Merged revisions 409682 from
  8922. http://svn.asterisk.org/svn/asterisk/branches/12
  8923. 2014-03-04 19:34 +0000 [r409627] Michael L. Young <elgueromexicano@gmail.com>
  8924. * funcs/func_audiohookinherit.c, /: func_audiohookinheritance:
  8925. Check If A Channel Was Specified This patch prevents a crash when
  8926. using the function audiohookinheritance without setting the
  8927. channel. (closes issue ASTERISK-23104) Reported by: Joel Vandal
  8928. Tested by: Joel Vandal Patches:
  8929. asterisk-23104_audiohook_inherit_no_channel-11.diff uploaded by
  8930. Michael L. Young (license 5026) Review:
  8931. https://reviewboard.asterisk.org/r/3272/ ........ Merged
  8932. revisions 409623 from
  8933. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8934. revisions 409625 from
  8935. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8936. revisions 409626 from
  8937. http://svn.asterisk.org/svn/asterisk/branches/12
  8938. 2014-03-04 17:22 +0000 [r409587] Jonathan Rose <jrose@digium.com>
  8939. * /, res/res_rtp_asterisk.c: res_rtp_asterisk: Fix one way audio
  8940. problems with hold/unhold when using ICE ICE sessions will now be
  8941. restarted if sessions are changed to use new sets of remote
  8942. candidates. (closes issue ASTERISK-22911) Reported by: Vytis
  8943. Valentinavičius Review: https://reviewboard.asterisk.org/r/3275/
  8944. ........ Merged revisions 409565 from
  8945. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8946. revisions 409570 from
  8947. http://svn.asterisk.org/svn/asterisk/branches/12
  8948. 2014-03-04 16:55 +0000 [r409569] Kinsey Moore <kmoore@digium.com>
  8949. * /, main/astobj2.c: AO2: Add an assert for bad objects This adds
  8950. an assert that will only be active if Asterisk is compiled with
  8951. DO_CRASH and allows the testsuite to fail tests that would
  8952. otherwise require log file parsing. ........ Merged revisions
  8953. 409566 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  8954. ........ Merged revisions 409567 from
  8955. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8956. revisions 409568 from
  8957. http://svn.asterisk.org/svn/asterisk/branches/12
  8958. 2014-03-04 14:55 +0000 [r409475] Sean Bright <sean@malleable.com>
  8959. * /, channels/chan_sip.c: Minor whitespace change to 'sip show
  8960. peers' output. (closes issue ASTERISK-23406) Reported by: ibercom
  8961. Tested by: ibercom Patches: asterisk-11.patch uploaded by ibercom
  8962. ........ Merged revisions 409472 from
  8963. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8964. revisions 409473 from
  8965. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8966. revisions 409474 from
  8967. http://svn.asterisk.org/svn/asterisk/branches/12
  8968. 2014-03-03 19:44 +0000 [r409423] Joshua Colp <jcolp@digium.com>
  8969. * /, res/res_stasis_recording.c: res_stasis_recording: Fix memory
  8970. leak of the absolute name. ........ Merged revisions 409422 from
  8971. http://svn.asterisk.org/svn/asterisk/branches/12
  8972. 2014-03-03 02:08 +0000 [r409364] Matthew Jordan <mjordan@digium.com>
  8973. * main/asterisk.c, /: doxygen: Tweak the link back to ye olde
  8974. Digium website ........ Merged revisions 409361 from
  8975. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8976. revisions 409362 from
  8977. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8978. revisions 409363 from
  8979. http://svn.asterisk.org/svn/asterisk/branches/12
  8980. 2014-03-02 17:03 +0000 [r409350] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  8981. * /, Makefile.rules: Makefile: replace -O6 with -O3 -O6 is not a
  8982. legal option of gcc. Unofficially gcc considers it to be
  8983. equivalent of -O3. clang chalks on it, though. This commit sets
  8984. the default optimization flag to be -O3, like gcc actually
  8985. considered it. Review: https://reviewboard.asterisk.org/r/3280/
  8986. ........ Merged revisions 409308 from
  8987. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  8988. revisions 409344 from
  8989. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  8990. revisions 409346 from
  8991. http://svn.asterisk.org/svn/asterisk/branches/12
  8992. 2014-03-01 20:28 +0000 [r409288] Joshua Colp <jcolp@digium.com>
  8993. * res/res_pjsip_session.c, /: res_pjsip_session: Set options
  8994. (100rel, timers) on incoming sessions. This change passes options
  8995. to the UAS creation function. This in turn sets up 100rel and
  8996. session timer properties on the incoming session. Reported by
  8997. Julian Russell on asterisk-users mailing list. ........ Merged
  8998. revisions 409287 from
  8999. http://svn.asterisk.org/svn/asterisk/branches/12
  9000. 2014-03-01 00:05 +0000 [r409257-409275] Richard Mudgett <rmudgett@digium.com>
  9001. * /, main/devicestate.c: devicestate.c: Simplified some logic in
  9002. _ast_device_state(). ........ Merged revisions 409274 from
  9003. http://svn.asterisk.org/svn/asterisk/branches/12
  9004. * main/stasis_cache.c, /: stasis_cache.c: Remove some unnecessary
  9005. RAII_VAR() usage. ........ Merged revisions 409272 from
  9006. http://svn.asterisk.org/svn/asterisk/branches/12
  9007. * main/stasis.c, /: stasis.c: Misc code cleanups. * Remove some
  9008. unnecessary RAII_VAR() usage. * Made the struct
  9009. stasis_subscription ao2 object use the ao2 lock instead of a
  9010. redundant join_lock in the struct for ast_cond_wait(). * Removed
  9011. locks on some ao2 objects that don't need the lock. * Made the
  9012. topic pool entries container use the ao2 template functions. *
  9013. Add some missing allocation failure checks. * Add missing cleanup
  9014. in off nominal path of dispatch_message(). ........ Merged
  9015. revisions 409270 from
  9016. http://svn.asterisk.org/svn/asterisk/branches/12
  9017. * /, channels/chan_sip.c: chan_sip: Add precautionary p->owner
  9018. checks. * Add precautionary p->owner checks in sip_hangup(),
  9019. get_refer_info(), get_also_info(), and
  9020. interpret_t38_parameters(). * Simplify some tangled logic in
  9021. get_refer_info(), get_also_info(), and add_rpid(). * Removed some
  9022. dead code in handle_request_invite(). (closes issue
  9023. ASTERISK-23323) Reported by: Walter Doekes Patches:
  9024. issueA23323-more_p_owner_checks-1.8.x.patch (license #5674)
  9025. uploaded by wdoekes (modified)
  9026. issueA23323-more_p_owner_checks-11.x.patch (license #5674)
  9027. uploaded by wdoekes (modified)
  9028. issueA23323-more_p_owner_checks-12.x.patch (license #5674)
  9029. uploaded by wdoekes (modified)
  9030. issueA23323-more_p_owner_checks-trunk.patch (license #5674)
  9031. uploaded by wdoekes (modified) ........ Merged revisions 409207
  9032. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  9033. Merged revisions 409255 from
  9034. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9035. revisions 409256 from
  9036. http://svn.asterisk.org/svn/asterisk/branches/12
  9037. 2014-02-28 21:24 +0000 [r409237] Kinsey Moore <kmoore@digium.com>
  9038. * apps/app_queue.c, /: app_queue: Fix documented AMI event name
  9039. During the rewrite of AMI events to use the Stasis bus, the name
  9040. of the QueueMemberPaused event was changed to QueueMemberPause.
  9041. This corrects documentation to reflect that. ........ Merged
  9042. revisions 409234 from
  9043. http://svn.asterisk.org/svn/asterisk/branches/12
  9044. 2014-02-28 18:03 +0000 [r409159] Richard Mudgett <rmudgett@digium.com>
  9045. * /, channels/chan_sip.c: chan_sip: Fix crash in
  9046. ast_channel_hangupcause_set(). * Fix crash in
  9047. ast_channel_hangupcause_set() because p->owner not checked before
  9048. calling. Regression introduced by the fix for ASTERISK-22621.
  9049. (closes issue ASTERISK-23135) Reported by: OK (issue
  9050. ASTERISK-23323) Reported by: Walter Doekes ........ Merged
  9051. revisions 409156 from
  9052. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9053. revisions 409157 from
  9054. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9055. revisions 409158 from
  9056. http://svn.asterisk.org/svn/asterisk/branches/12
  9057. 2014-02-27 19:54 +0000 [r409132] Jonathan Rose <jrose@digium.com>
  9058. * res/res_rtp_asterisk.c, /: Multiple revisions 409129-409130
  9059. ........ r409129 | jrose | 2014-02-27 13:19:02 -0600 (Thu, 27 Feb
  9060. 2014) | 15 lines res_rtp_asterisk: Fix checklist creating
  9061. problems in ICE sessions Prior to this patch, local candidate
  9062. lists including SRFLX would fail to start properly when building
  9063. ICE candidate check lists. This patch fixes that problem by
  9064. making sure that each SRFLX candidate is associated with the
  9065. proper base address so that the check list can create matches
  9066. properly. This patch was written by jcolp. The issue will be left
  9067. open to await testing by the issue participants. (issue
  9068. ASTERISK-23213) Reported by: Andrea Suisani Review:
  9069. https://reviewboard.asterisk.org/r/3256/ ........ r409130 | jrose
  9070. | 2014-02-27 13:38:10 -0600 (Thu, 27 Feb 2014) | 8 lines
  9071. res_rtp_asterisk: correct build error from r409129 Accidentally
  9072. placed a declaration below functional code (issue ASTERISK-23213)
  9073. Reported by: Andrea Suisani Review:
  9074. https://reviewboard.asterisk.org/r/3256/ ........ Merged
  9075. revisions 409129-409130 from
  9076. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9077. revisions 409131 from
  9078. http://svn.asterisk.org/svn/asterisk/branches/12
  9079. 2014-02-27 16:26 +0000 [r409091] David M. Lee <dlee@digium.com>
  9080. * utils/astman.c, /: Fix memory stomping bug in astman. This memset
  9081. complained in dev mod on my Ubuntu box. The memset is both
  9082. unnecessary and dangerous. At this point, m hasn't been
  9083. initialized yet, so the memset will write off to whatever address
  9084. happens to be on the stack at the time. ........ Merged revisions
  9085. 409077 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  9086. ........ Merged revisions 409083 from
  9087. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9088. revisions 409087 from
  9089. http://svn.asterisk.org/svn/asterisk/branches/12
  9090. 2014-02-27 16:08 +0000 [r409055] Corey Farrell <git@cfware.com>
  9091. * /, configs/res_fax.conf.sample: res_fax: Comment out default
  9092. settings from res_fax.conf. Comment out many settings in
  9093. res_fax.conf.sample. The defaults are set in res_fax.c, so
  9094. setting the same value in sample config does nothing but make the
  9095. sample config more fragile. (closes issue ASTERISK-23231)
  9096. Reported by: David Brillert Review:
  9097. https://reviewboard.asterisk.org/r/3261/ ........ Merged
  9098. revisions 409052 from
  9099. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9100. revisions 409053 from
  9101. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9102. revisions 409054 from
  9103. http://svn.asterisk.org/svn/asterisk/branches/12
  9104. 2014-02-27 12:29 +0000 [r409000] Matthew Jordan <mjordan@digium.com>
  9105. * /, res/res_pjsip_sdp_rtp.c: res_pjsip_sdp_rtp: Apply
  9106. packetization rules on inbound SDP handling The setting
  9107. 'use_ptime' is supposed to tell Asterisk to honour the ptime
  9108. attribute in an offer, preferring it to whatever packetization
  9109. preferences have been set internally. Currently, however,
  9110. something rather quirky will happen: (1) The SDP answer will be
  9111. constructed in create_outgoing_sdp_stream. This will use the
  9112. preferences from the endpoint, such that the 200 OK response will
  9113. add the packetization preferences from the endpoint, and not what
  9114. was offered. (2) When the 200 response is issued,
  9115. apply_negotiated_sdp_stream is called. This will call
  9116. apply_packetization, which will use the ptime attribute from the
  9117. offer internally. We end up telling the offerer to use the
  9118. internal ptime attribute, but we end up using the offered ptime
  9119. attribute. Hilarity ensues. This patch modifies the behaviour by
  9120. calling apply_packetization from negotiate_incoming_sdp_stream,
  9121. which is called prior to create_outgoing_sdp_stream. This causes
  9122. the format preferences on the session's media object to be set to
  9123. the inbound ptime value (if 'use_ptime' is enabled), such that
  9124. the construction of the answer gets the right value immediately.
  9125. Review: https://reviewboard.asterisk.org/r/3244/ ........ Merged
  9126. revisions 408999 from
  9127. http://svn.asterisk.org/svn/asterisk/branches/12
  9128. 2014-02-26 23:35 +0000 [r408984] Richard Mudgett <rmudgett@digium.com>
  9129. * /, tests/test_stasis.c: test_stasis.c: Misc cleanups. * Make the
  9130. consumer ao2 object use the ao2 lock instead of a redundant lock
  9131. in the struct for ast_cond_wait(). * Fixed some curly brace
  9132. placements. * Fixed use of malloc(0). malloc(0) has variant
  9133. behavior. It is up to the implementation to determine if it
  9134. returns NULL or a valid pointer that can be later passed to
  9135. free(). ........ Merged revisions 408983 from
  9136. http://svn.asterisk.org/svn/asterisk/branches/12
  9137. 2014-02-26 19:00 +0000 [r408971] Scott Griepentrog <sgriepentrog@digium.com>
  9138. * channels/chan_pjsip.c, /: pjsip: avoid edge case potential crash
  9139. in answer() When accidentally compiling against a wrong version
  9140. of pjsip headers with a different pjsip_inv_session size, the
  9141. invite_tsx structure could be null in the answer() function. This
  9142. led to a crash because it attempted to send the session response
  9143. with an uninitialized packet pointer. This patch presets packet
  9144. to null and adds a diagnostic log message to explain why the call
  9145. fails. Review: https://reviewboard.asterisk.org/r/3267/ ........
  9146. Merged revisions 408970 from
  9147. http://svn.asterisk.org/svn/asterisk/branches/12
  9148. 2014-02-26 17:04 +0000 [r408958] Joshua Colp <jcolp@digium.com>
  9149. * res/res_ari.c, /: res_ari: Make some additional error responses
  9150. consistent with the rest of the system. This change makes some
  9151. error cases use ast_ari_response_error to construct their error
  9152. responses instead of manually doing it. This ensures they are
  9153. consistent with the other error responses. Based on the original
  9154. patch as done by Paul Belanger on the associated review. Review:
  9155. https://reviewboard.asterisk.org/r/2904/ ........ Merged
  9156. revisions 408957 from
  9157. http://svn.asterisk.org/svn/asterisk/branches/12
  9158. 2014-02-26 13:47 +0000 [r408942-408944] Kinsey Moore <kmoore@digium.com>
  9159. * include/asterisk/res_pjsip_session.h, /: PJSIP: Fix some bad
  9160. spacing ........ Merged revisions 408943 from
  9161. http://svn.asterisk.org/svn/asterisk/branches/12
  9162. * /, res/res_pjsip_refer.c: PJSIP: Prevent crash if channel has
  9163. gone away It is currently possible for an ast_sip_session to
  9164. exist without an associated channel as is the case when a new
  9165. invite is coming in or just after a hangup is issued on a
  9166. chan_pjsip channel. Part of the attended transfer code assumed
  9167. the channel would be non-NULL and used it as such causing a
  9168. crash. This bug was exposed thanks to the attended transfer ARI
  9169. test in the test suite. (closes issue ASTERISK-23287) Reported
  9170. by: Matt Jordan ........ Merged revisions 408941 from
  9171. http://svn.asterisk.org/svn/asterisk/branches/12
  9172. 2014-02-26 08:57 +0000 [r408932] Igor Goncharovskiy <igor.goncharovsky@gmail.com>
  9173. * channels/chan_unistim.c: Implement functions handling keypress,
  9174. display icons and text for i2004 KEM support.
  9175. 2014-02-25 17:51 +0000 [r408881-408883] Kevin Harwell <kharwell@digium.com>
  9176. * res/res_pjsip_exten_state.c, /,
  9177. res/res_pjsip_pidf_digium_body_supplement.c (added),
  9178. include/asterisk/res_pjsip_body_generator_types.h:
  9179. res_pjsip_exten_state: Presence for digium phones Added presence
  9180. support for digium phones. Review:
  9181. https://reviewboard.asterisk.org/r/3239/ ........ Merged
  9182. revisions 408882 from
  9183. http://svn.asterisk.org/svn/asterisk/branches/12
  9184. * /, res/res_pjsip_send_to_voicemail.c (added),
  9185. res/res_pjsip_header_funcs.c: res_pjsip_send_to_voicemail:
  9186. transferring to voicemail for digium phones Added the ability for
  9187. transferring directly to voicemail on digium phones. Added a new
  9188. module that checks for the presence of a custom header and/or
  9189. diversion header within a sip REFER. If either is found and they
  9190. specify a sending to voicemail action then variables are added to
  9191. the channel allowing the user access to them in the dialplan.
  9192. Dialplan can then be written that branches based upon these
  9193. values allowing, for instace, for a single number to be used for
  9194. dialing and/or accessing voicemail directly. Also fixed a problem
  9195. where the PJSIP_HEADER function was allowing non pjsip channels
  9196. through (checked to make sure it has the correct channel type
  9197. before proceeding). Review:
  9198. https://reviewboard.asterisk.org/r/3245/ ........ Merged
  9199. revisions 408880 from
  9200. http://svn.asterisk.org/svn/asterisk/branches/12
  9201. 2014-02-25 17:44 +0000 [r408879] Rusty Newton <rnewton@digium.com>
  9202. * configs/voicemail.conf.sample, /: configs/voicemail.conf.sample -
  9203. Make mailcmd sample text more explicit Made the wording a bit
  9204. more explicit. Didn't really change the meaning. ........ Merged
  9205. revisions 408876 from
  9206. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9207. revisions 408877 from
  9208. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9209. revisions 408878 from
  9210. http://svn.asterisk.org/svn/asterisk/branches/12
  9211. 2014-02-22 23:31 +0000 [r408859] Matthew Jordan <mjordan@digium.com>
  9212. * /, main/asterisk.c: main: Initialize dialplan providing core
  9213. components prior to module pre-load It is possible to pre-load
  9214. pbx_config. As a result, pbx_config - which will load and parse
  9215. the dialplan - will attempt to use various dialplan components,
  9216. such as device state providers and presence state providers,
  9217. prior to them being initialized by the core. This would lead to a
  9218. crash, as the components had not created their Stasis cache
  9219. entries. This patch moves a number of core component
  9220. initializations before the module pre-load. This guarantees that
  9221. if someone does pre-load pbx_config - or other pbx modules - that
  9222. the Stasis caches for the various core components are created.
  9223. (closes issue ASTERISK-23320) Reported by: xrobau (closes issue
  9224. ASTERISK-23265) Reported by: Andrew Nagy Tested by: Andrew Nagy,
  9225. Rusty Newton ........ Merged revisions 408855 from
  9226. http://svn.asterisk.org/svn/asterisk/branches/12
  9227. 2014-02-22 18:01 +0000 [r408840] Alexandr Anikin <may@telecom-service.ru>
  9228. * addons/chan_ooh323.c, /: ignore AST_CONTROL_PVT_CAUSE_CODE
  9229. without any messages (closes issue ASTERISK-23336) Reported by:
  9230. Alexander Semych ........ Merged revisions 408838 from
  9231. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9232. revisions 408839 from
  9233. http://svn.asterisk.org/svn/asterisk/branches/12
  9234. 2014-02-22 02:31 +0000 [r408788] Corey Farrell <git@cfware.com>
  9235. * /, utils/extconf.c, utils/conf2ael.c, res/ael/pval.c, main/pbx.c:
  9236. Remove extra defines of AST_PBX_MAX_STACK. * Ensure
  9237. AST_PBX_MAX_STACK is only defined in extconf.h and pbx.h. * Fix
  9238. incorrect function parameters in utils/extconf.c. (closes issue
  9239. ASTERISK-23141) Reported by: Maxim Review:
  9240. https://reviewboard.asterisk.org/r/3241/ ........ Merged
  9241. revisions 408785 from
  9242. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9243. revisions 408786 from
  9244. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9245. revisions 408787 from
  9246. http://svn.asterisk.org/svn/asterisk/branches/12
  9247. 2014-02-21 18:37 +0000 [r408731] Kevin Harwell <kharwell@digium.com>
  9248. * main/rtp_engine.c, /: rtp_engine: Dynamic payload change in rtp
  9249. mapping not supported Asterisk didn't support the dynamic payload
  9250. change in rtp mapping in the 200 OK response. Scenario: Asterisk
  9251. sends the INVITE proposing alaw and telephone-event, it proposes
  9252. rtpmap:101 for telephone-event. Peer responds with 2xx, it
  9253. answers with alaw and telephone-event also, but it proposes a
  9254. different rtpmap number (rtpmap:103) for telephone-event.
  9255. Expected Behaviour: Asterisk should honour the rtpmapping in the
  9256. response and send DTMF packets using 103 as payload type for
  9257. DTMF. Actual Behaviour: Asterisk sends DTMF packets using payload
  9258. type 101. With this patch asterisk now supports changes that can
  9259. occur in the rtp mapping in the response. (closes issue
  9260. ASTERISK-23279) Reported by: NITESH BANSAL Review:
  9261. https://reviewboard.asterisk.org/r/3225/ Patches:
  9262. dynamic_payload_change.patch uploaded by nbansal (license 6418)
  9263. ........ Merged revisions 408729 from
  9264. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9265. revisions 408730 from
  9266. http://svn.asterisk.org/svn/asterisk/branches/12
  9267. 2014-02-21 18:19 +0000 [r408712-408723] Richard Mudgett <rmudgett@digium.com>
  9268. * main/manager.c, /: manager: Fix AMI Status action of a single
  9269. channel. Fixed use of uninitialized ao2 container iterator in an
  9270. off-nominal condition. Either a memory allocation error or the
  9271. requested channel is an internal channel not exposed to the
  9272. outside. ........ Merged revisions 408715 from
  9273. http://svn.asterisk.org/svn/asterisk/branches/12
  9274. * main/sorcery.c, res/ari/resource_endpoints.c, /,
  9275. apps/app_meetme.c, res/res_fax.c, res/res_stasis_recording.c,
  9276. main/stasis_channels.c, res/res_sorcery_astdb.c,
  9277. include/asterisk/json.h: json: Fix off-nominal json ref counting
  9278. issues. * Fixed off-nominal json ref counting issue with using
  9279. the following API calls: ast_json_object_set() and
  9280. ast_json_array_append(). * Fixed off-nominal error reporting in
  9281. ast_ari_endpoints_list(). * Fixed some miscellaneous off-nominal
  9282. json ref counting issues in report_receive_fax_status() and
  9283. dial_to_json(). ........ Merged revisions 408713 from
  9284. http://svn.asterisk.org/svn/asterisk/branches/12
  9285. * main/json.c, /: json: Fix json API wrapper code for json library
  9286. versions earlier than 2.3.0. * Fixed json ref counting issue with
  9287. json API wrapper code for ast_json_object_update_existing() and
  9288. ast_json_object_update_missing() when the json library is earlier
  9289. than version 2.3.0. ........ Merged revisions 408711 from
  9290. http://svn.asterisk.org/svn/asterisk/branches/12
  9291. 2014-02-21 16:49 +0000 [r408699] Corey Farrell <git@cfware.com>
  9292. * channels/chan_sip.c: chan_sip: prevent add_route from adding
  9293. empty header. Fix regression caused by ASTERISK-22582. Empty
  9294. Route headers were added when the route had a single strict hop.
  9295. (closes issue ASTERISK-23306) Reported by: Matt Jordan Review:
  9296. https://reviewboard.asterisk.org/r/3236/
  9297. 2014-02-21 16:27 +0000 [r408645-408652] Kevin Harwell <kharwell@digium.com>
  9298. * main/rtp_engine.c, /: rtp_engine: Output mixup in
  9299. ${CHANNEL(rtpqos,audio,all)} Fixed the output of
  9300. CHANNEL(rtpqos,audio,all) to use txjitter instead of rxjitter.
  9301. (closes issue ASTERISK-23261) Reported by: rsw686 Patches:
  9302. rtpqos.patch uploaded by rsw686 (license 5887) ........ Merged
  9303. revisions 408646 from
  9304. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9305. revisions 408647 from
  9306. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9307. revisions 408649 from
  9308. http://svn.asterisk.org/svn/asterisk/branches/12
  9309. * main/channel.c, /: channel.c: MOH is not working for transferee
  9310. after attended transfer Updated the code to check to see if MOH
  9311. is playing on the transferor and if so then start it on the
  9312. channel that replaces it during a masquerade. Example scenario of
  9313. the problem: Alice calls Bob and then Bob begins the attended
  9314. transfer process into a queue. Upon going on hold Alice hears
  9315. music and so does Bob once he is in the queue. Bob then transfers
  9316. Alice into the queue and then music for Alice stops even though
  9317. she should be hearing it since has now replaced Bob in the queue.
  9318. The problem that was occurring is that once the channel was
  9319. masqueraded the app (queues, confbridge, etc...) had no way of
  9320. knowing that the channel had just been swapped out thus it did
  9321. not start music for the present channel. Credit to Olle Johansson
  9322. for pointing me in the right direction on this issue. (closes
  9323. issue ASTERISK-19499) Reported by: Timo Teräs Review:
  9324. https://reviewboard.asterisk.org/r/3226/ ........ Merged
  9325. revisions 408642 from
  9326. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9327. revisions 408643 from
  9328. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9329. revisions 408644 from
  9330. http://svn.asterisk.org/svn/asterisk/branches/12
  9331. 2014-02-21 10:45 +0000 [r408592] Alexandr Anikin <may@telecom-service.ru>
  9332. * /, addons/ooh323c/src/ooCalls.h: Fix type of roundTripDelay
  9333. variables ........ Merged revisions 408589 from
  9334. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9335. revisions 408590 from
  9336. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9337. revisions 408591 from
  9338. http://svn.asterisk.org/svn/asterisk/branches/12
  9339. 2014-02-21 00:50 +0000 [r408539] Michael L. Young <elgueromexicano@gmail.com>
  9340. * /, apps/app_chanspy.c: app_chanspy: Documentation Update To
  9341. Clarify "x" Option When using the "x" option (specify a DTMF
  9342. digit to exit the application), it is not obvious in the
  9343. documentation that this only works when spying on a channel. If a
  9344. channel being used to spy on other channels is waiting to connect
  9345. to a channel or is no longer attached to a channel, the DTMF is
  9346. ignored. As noted on the issue tracker, since there are
  9347. workarounds available and this is a rarely used option we are
  9348. opting for a documentation change here. (closes issue
  9349. ASTERISK-22661) Reported by: Chris Hillman Patches:
  9350. asterisk-22661-doc-clarify-chan_spy.diff uploaded by Michael L.
  9351. Young (license 5026) Review:
  9352. https://reviewboard.asterisk.org/r/2990/ ........ Merged
  9353. revisions 408536 from
  9354. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9355. revisions 408537 from
  9356. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9357. revisions 408538 from
  9358. http://svn.asterisk.org/svn/asterisk/branches/12
  9359. 2014-02-20 21:12 +0000 [r408519-408523] George Joseph <george.joseph@fairview5.com>
  9360. * /, res/res_pjsip/location.c,
  9361. res/res_pjsip_outbound_registration.c: pjsip_cli: Add pjsip
  9362. commands 'show registrations' and 'show contacts'. Added 'show
  9363. registrations' and 'show contacts' to pjsip cli to make things a
  9364. little more consistent. The output is exactly the same as the
  9365. list command. Just needed to add entries to their respective
  9366. ast_cli_entry structures. (closes issue ASTERISK-23275) Review:
  9367. http://reviewboard.asterisk.org/r/3210/ ........ Merged revisions
  9368. 408522 from http://svn.asterisk.org/svn/asterisk/branches/12
  9369. * /, res/res_pjsip/pjsip_cli.c, main/config.c: pjsip_cli: Fix
  9370. memory leak in ast_sip_cli_print_sorcery_objectset. Fixed memory
  9371. leaks in ast_sip_cli_print_sorcery_objectset and
  9372. ast_variable_list_sort. (closes issue ASTERISK-23266) Review:
  9373. http://reviewboard.asterisk.org/r/3200/ ........ Merged revisions
  9374. 408520 from http://svn.asterisk.org/svn/asterisk/branches/12
  9375. * include/asterisk/sorcery.h,
  9376. res/res_pjsip/include/res_pjsip_private.h, res/res_pjsip.c,
  9377. tests/test_sorcery.c, main/sorcery.c, /,
  9378. res/res_pjsip/config_system.c: sorcery: Create sorcery instance
  9379. registry. In order to retrieve an arbitrary sorcery instance from
  9380. a dialplan function (or any place else) there needs to be a
  9381. registry of sorcery instances. ast_sorcery_init now creates a
  9382. hashtab as a registry. ast_sorcery_open now checks the hashtab
  9383. for an existing sorcery instance matching the caller's module
  9384. name. If it finds one, it bumps the refcount and returns it. If
  9385. not, it creates a new sorcery instance, adds it to the hashtab,
  9386. then returns it. ast_sorcery_retrieve_by_module_name is a new
  9387. function that does a hashtab lookup by module name. It can be
  9388. called by the future dialplan function. res_pjsip/config_system
  9389. needed a small change to share the main res_pjsip sorcery
  9390. instance. tests/test_sorcery was updated to include a test for
  9391. the registry. (closes issue ASTERISK-22537) Review:
  9392. http://reviewboard.asterisk.org/r/3184/ ........ Merged revisions
  9393. 408518 from http://svn.asterisk.org/svn/asterisk/branches/12
  9394. 2014-02-20 19:02 +0000 [r408503] Matthew Jordan <mjordan@digium.com>
  9395. * res/res_pjsip.c, /: res_pjsip: Update documentation for
  9396. 'use_avpf' option When 'use_avpf' is set to True, inbound offers
  9397. must use the AVPF/SAVPF RTP profile. However, when 'use_avpf' is
  9398. set to False, Asterisk will accept both AVP/SAVP or AVPF/SAVPF
  9399. RTP profiles in inbound offers. The documentation previously
  9400. implied that Asterisk would reject AVPF/SAVPF if 'use_avpf' was
  9401. set to False and a UA offered said profile in an INVITE request.
  9402. ........ Merged revisions 408502 from
  9403. http://svn.asterisk.org/svn/asterisk/branches/12
  9404. 2014-02-20 02:44 +0000 [r408450] Rusty Newton <rnewton@digium.com>
  9405. * /, apps/app_queue.c: apps/app_queue - Fix incorrect Macro
  9406. parameter documentation Macro is executed on the called channel,
  9407. not the calling channel. (closes issue ASTERISK-23069) Reported
  9408. By: Bryan Anderson ........ Merged revisions 408447 from
  9409. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9410. revisions 408448 from
  9411. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9412. revisions 408449 from
  9413. http://svn.asterisk.org/svn/asterisk/branches/12
  9414. 2014-02-19 19:09 +0000 [r408386-408390] Richard Mudgett <rmudgett@digium.com>
  9415. * /, main/config.c: config: Add file size and nanosecond resolution
  9416. fields to the cached modified config file information. Repeatedly
  9417. modifying config files and reloading too fast sometimes fails to
  9418. reload the configuration because the cached modification
  9419. timestamp has one second resolution. * Added file size and
  9420. nanosecond resolution fields to the cached config file
  9421. modification timestamp information. Now if the file size changes
  9422. or the file system supports nanosecond resolution the modified
  9423. file has a better chance of being detected for reload. * Added a
  9424. missing unlock in an off-nominal code path. (closes issue
  9425. AST-1303) Review: https://reviewboard.asterisk.org/r/3235/
  9426. ........ Merged revisions 408387 from
  9427. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9428. revisions 408388 from
  9429. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9430. revisions 408389 from
  9431. http://svn.asterisk.org/svn/asterisk/branches/12
  9432. * /, res/res_sorcery_astdb.c: res_sorcery_astdb.c: Fix regex
  9433. handling and keep simple prefix matching performance. The sorcery
  9434. astDB wizzard does not handle regex correctly if the pattern
  9435. begins with an anchor character. This patch attempts to convert
  9436. the anchored regex pattern to a prefix pattern supported by astDB
  9437. for performance reasons. If it is not able to convert the pattern
  9438. it falls back to getting all astDB members of the family and
  9439. doing a normal regex pattern matching on the retrieved records.
  9440. Review: https://reviewboard.asterisk.org/r/3161/ ........ Merged
  9441. revisions 408385 from
  9442. http://svn.asterisk.org/svn/asterisk/branches/12
  9443. 2014-02-19 12:04 +0000 [r408315-408332] Alexandr Anikin <may@telecom-service.ru>
  9444. * addons/ooh323c/src/ooCapability.c, /,
  9445. addons/ooh323c/src/ooh245.c: process receiveAndTransmit user
  9446. input remote caps instead of receive only send receiveAndTransmit
  9447. user input our caps instead of receive only ........ Merged
  9448. revisions 408328 from
  9449. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9450. revisions 408330 from
  9451. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9452. revisions 408331 from
  9453. http://svn.asterisk.org/svn/asterisk/branches/12
  9454. * addons/ooh323c/src/ooh323.c, /: Allow different socket and
  9455. signalling ip on h.323 connection if gk mode is active Reported
  9456. by: Gabriele Odone Patches: ASTERISK-22738-1.patch Tested by:
  9457. Gabriele Odone (closes issue ASTERISK-22738) ........ Merged
  9458. revisions 408312 from
  9459. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9460. revisions 408314 from
  9461. http://svn.asterisk.org/svn/asterisk/branches/12
  9462. 2014-02-18 19:19 +0000 [r408299] Richard Mudgett <rmudgett@digium.com>
  9463. * contrib/ast-db-manage/config/env.py,
  9464. contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py,
  9465. contrib/ast-db-manage/config,
  9466. contrib/ast-db-manage/voicemail/env.py,
  9467. contrib/ast-db-manage/voicemail,
  9468. contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py,
  9469. contrib/ast-db-manage/config/versions,
  9470. contrib/ast-db-manage/config/versions/21e526ad3040_add_pjsip_debug_option.py,
  9471. contrib/ast-db-manage/voicemail/versions/a2e9769475e_create_tables.py,
  9472. contrib/ast-db-manage/voicemail/versions, contrib/ast-db-manage,
  9473. /: alembic: Add svn:ignore *.pyc to directories and
  9474. svn:executable to *.py files. ........ Merged revisions 408297
  9475. from http://svn.asterisk.org/svn/asterisk/branches/12
  9476. 2014-02-17 15:36 +0000 [r408272] Mark Michelson <mmichelson@digium.com>
  9477. * /, res/res_pjsip/location.c, UPGRADE.txt, res/res_pjsip.c,
  9478. res/res_pjsip_registrar.c, include/asterisk/res_pjsip.h: Store
  9479. SIP User-Agent information in contacts. When an endpoint sends a
  9480. REGISTER request to Asterisk, we now will associate the
  9481. User-Agent header with all contacts that were bound in that
  9482. REGISTER request. ........ Merged revisions 408270 from
  9483. http://svn.asterisk.org/svn/asterisk/branches/12
  9484. 2014-02-16 03:25 +0000 [r408199-408227] Matthew Jordan <mjordan@digium.com>
  9485. * /, main/pbx.c: pbx: Handle a completely empty dialplan during a
  9486. context merge It is highly unlikely, but - at least in Asterisk
  9487. 12 - theoretically possible to load Asterisk with no dialplan
  9488. whatsoever. If that occurs, and some other module (that is not a
  9489. pbx module) attempts to merge its contexts into the dialplan, the
  9490. existing merge routine will crash. This is because it is not
  9491. insane, and rightly believes that you provided some sort of
  9492. dialplan, somewhere. This patch will gracefully merge the
  9493. contexts in such a case. Note that this is highly unlikely to
  9494. occur in 1.8/11, as features will most likely provide some
  9495. dialplan via parking. However, in Asterisk 12, parking is now
  9496. provided by res_parking, and hence may create its dialplan later.
  9497. (closes issue ASTERISK-23297) Reported by: CJ Oster Review:
  9498. https://reviewboard.asterisk.org/r/3222 ........ Merged revisions
  9499. 408200 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  9500. ........ Merged revisions 408201 from
  9501. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9502. revisions 408220 from
  9503. http://svn.asterisk.org/svn/asterisk/branches/12
  9504. * /, Makefile: buildsystem: Unbreak the build (infloop) on Asterisk
  9505. 11+ Apparently r408084 ( https://reviewboard.asterisk.org/r/3212/
  9506. ) broke the build. This patch fixes it by ignoring the .lastclean
  9507. dependencies if the MENUSELECT_EMBED variable is not defined.
  9508. patches: tmp.diff uploaded by wdoekes (License 5674) Review:
  9509. https://reviewboard.asterisk.org/r/3228/ ........ Merged
  9510. revisions 408193 from
  9511. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9512. revisions 408194 from
  9513. http://svn.asterisk.org/svn/asterisk/branches/12
  9514. 2014-02-14 21:44 +0000 [r408139-408141] Scott Griepentrog <sgriepentrog@digium.com>
  9515. * main/stasis_endpoints.c, /: ARI: correct upper/lower case URI
  9516. discrepancies URI's are supposed to be case sensitive and all
  9517. lower case. In practice some portions of URI's in ARI are case
  9518. insensitive and others are not, such as TECH, which in one
  9519. instance would match a lower case name and in another would not.
  9520. In this patch, the ast_endpoint_lastest_snapshot() function is
  9521. modified to change the TECH portion to full upper case before
  9522. lookup. This resolves the discrepancy noted by the reporter.
  9523. However I chose to avoid forcing the /ari prefix of the URI's to
  9524. be lower case for now. Except for the two cases here, all URI's
  9525. should be lower case, unless they are part of a resource name or
  9526. id. Review: https://reviewboard.asterisk.org/r/3211/ Reported by:
  9527. Zane Conkle (closes issue ASTERISK-23125) ........ Merged
  9528. revisions 408140 from
  9529. http://svn.asterisk.org/svn/asterisk/branches/12
  9530. * main/format.c, /: format.c: correct possible null pointer
  9531. dereference In ast_format_sdp_parse and ast_format_sdp_generate
  9532. the check checks for a valid interface and function were
  9533. potentially confusing, and hid an error in the test of the
  9534. presence of the function that is called later. This patch clears
  9535. up and corrects the test. Review:
  9536. https://reviewboard.asterisk.org/r/3208/ (closes issue
  9537. ASTERISK-23098) Reported by: marcelloceschia Patches:
  9538. main_format.patch uploaded by marcelloceschia (license 6036)
  9539. ASTERISK-23098.patch uploaded by coreyfarrell (license 5909)
  9540. ........ Merged revisions 408137 from
  9541. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9542. revisions 408138 from
  9543. http://svn.asterisk.org/svn/asterisk/branches/12
  9544. 2014-02-14 13:31 +0000 [r408086] Walter Doekes <walter+asterisk@wjd.nu>
  9545. * Makefile, /: buildsystem: Don't force main to depend on
  9546. everything else. Directory 'main' only needs to depend on
  9547. embedded modules. If no module embedding is selected, the
  9548. dependency is dropped. Review:
  9549. https://reviewboard.asterisk.org/r/3212/ ........ Merged
  9550. revisions 408083 from
  9551. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9552. revisions 408084 from
  9553. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9554. revisions 408085 from
  9555. http://svn.asterisk.org/svn/asterisk/branches/12
  9556. 2014-02-14 12:41 +0000 [r408070] Matthew Jordan <mjordan@digium.com>
  9557. * /, channels/chan_sip.c: chnan_sip: Set SIP_DEFER_BYE_ON_TRANSFER
  9558. prior to calling bridge blind transfer This patch moves setting
  9559. SIP_DEFER_BY_ON_TRANSFER prior to calling
  9560. ast_bridge_transfer_blind. This prevents a BYE from being sent
  9561. prior to the NOTIFY request that informs the transferor if the
  9562. transfer succeeded or failed. This patch also clears said flag
  9563. from the off nominal NOTIFY paths in the local_attended_transfer
  9564. code, as once we've sent the NOTIFY request it is safe to send by
  9565. the BYE request. This was caught by the
  9566. blind-transfer-accountcode test in the Asterisk Test Suite.
  9567. (closes issue ASTERISK-23290) Reported by: Matt Jordan Review:
  9568. https://reviewboard.asterisk.org/r/3214/ ........ Merged
  9569. revisions 408069 from
  9570. http://svn.asterisk.org/svn/asterisk/branches/12
  9571. 2014-02-14 08:52 +0000 [r408059] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  9572. * Makefile, build_tools/install_subst (added): install_subst:
  9573. helper script for installing with path substitution A helper
  9574. script to copy a source file substituting any
  9575. __ASTERISK_<foo>_DIR__ with the content of $AST<foo>DIR. Review:
  9576. https://reviewboard.asterisk.org/r/3202/
  9577. 2014-02-13 18:52 +0000 [r407990-408006] Mark Michelson <mmichelson@digium.com>
  9578. * res/res_pjsip_pubsub.c, /, res/res_pjsip_mwi.c: Remove all PJSIP
  9579. MWI-specific use from our MWI code. PJSIP has built-in MWI code
  9580. that could be useful to some degree, but our utilization of the
  9581. API actually made our code a bit more cluttered since we had to
  9582. have special cases peppered throughout. With this change, we move
  9583. to using the pjsip_evsub API instead, which streamlines the code
  9584. by removing special cases. Review:
  9585. https://reviewboard.asterisk.org/r/3205 ........ Merged revisions
  9586. 408005 from http://svn.asterisk.org/svn/asterisk/branches/12
  9587. * /, res/res_pjsip/location.c: Fix crash in AMI PJSIPShowEndpoint
  9588. action. If an AOR has no permanent contacts, then the
  9589. permanent_contacts container is never allocated. This makes the
  9590. code safe in the face of NULLs. I also changed the variable that
  9591. counts contacts from "num" to "total_contacts" since there are
  9592. now two variables that are indicate numbers of things. ........
  9593. Merged revisions 407988 from
  9594. http://svn.asterisk.org/svn/asterisk/branches/12
  9595. 2014-02-13 15:51 +0000 [r407989] Kinsey Moore <kmoore@digium.com>
  9596. * main/logger.c, CHANGES: Logger: Add dynamic logger channels This
  9597. adds the ability to dynamically add and remove logger channels
  9598. from Asterisk via the CLI. (closes issue AST-1150) Review:
  9599. https://reviewboard.asterisk.org/r/3185/
  9600. 2014-02-12 08:25 +0000 [r407970] Walter Doekes <walter+asterisk@wjd.nu>
  9601. * /, main/config.c: realtime: Fix ast_update2_realtime() on
  9602. raspberry pi. The old code depended on undefined va_arg
  9603. behaviour: calling a function twice with the same va_list
  9604. parameter and expecting it to continue where it left off. The
  9605. changed code behaves like the manpage says it should. Also added
  9606. a bunch of early returns to trap errors (e.g. OOM) instead of
  9607. crashing. The problem was found by Julian Lyndon-Smith. The
  9608. deviant behaviour on the raspberry PI also uncovered another bug
  9609. (fixed in r407875) in the res_config_pgsql.so driver. Reported
  9610. by: jmls Tested by: jmls Review:
  9611. https://reviewboard.asterisk.org/r/3201/ ........ Merged
  9612. revisions 407968 from
  9613. http://svn.asterisk.org/svn/asterisk/branches/12
  9614. 2014-02-11 20:17 +0000 [r407958] Joshua Colp <jcolp@digium.com>
  9615. * main/sched.c: scheduler: Remove hashtab usage. This is a first
  9616. stab at tweaking the performance profile of the scheduler.
  9617. Removing the hashtab usage removes an extra memory allocation
  9618. when scheduling something and makes it so rescheduling does not
  9619. incur any memory allocation at all. Review:
  9620. https://reviewboard.asterisk.org/r/3199/
  9621. 2014-02-11 03:18 +0000 [r407940] Matthew Jordan <mjordan@digium.com>
  9622. * res/ari/resource_channels.c, /: ari/resource_channels: Add
  9623. channel variables earlier in the creation process This patch
  9624. tweaks the behaviour of POST /channels with channel variables
  9625. such that the variables are passed into the pbx.c routines that
  9626. perform the origination. This allows the variables to be assigned
  9627. to the newly created channels immediately upon their
  9628. construction, as opposed to be assigned after the originate has
  9629. completed. The upshot of this is that the variables are available
  9630. on the channels if they execute in the dialplan, as opposed to
  9631. only being available once the channels are answered. Review:
  9632. https://reviewboard.asterisk.org/r/3183/ ........ Merged
  9633. revisions 407937 from
  9634. http://svn.asterisk.org/svn/asterisk/branches/12
  9635. 2014-02-10 18:28 +0000 [r407926] Corey Farrell <git@cfware.com>
  9636. * channels/sip/include/reqresp_parser.h,
  9637. channels/sip/include/route.h (added), channels/chan_sip.c,
  9638. channels/sip/route.c (added), channels/sip/include/sip.h:
  9639. chan_sip: Isolate code that manages struct sip_route. * Move
  9640. route code to sip/route.c + sip/include/route.h * Rename
  9641. functions to sip_route_* * Replace ad-hoc list code with macro's
  9642. from linkedlists.h * Create sip_route_process_header() to
  9643. processes Path and Record-Route headers (previously done with
  9644. different code in build_route and build_path) * Add use of const
  9645. where possible * Move struct uriparams, struct contact and
  9646. contactliststruct from sip.h to reqresp_parser.h. sip/route.c
  9647. uses reqresp_parser.h but not sip.h, this was a problem. These
  9648. moved declares are not used outside of reqresp_parser. * While
  9649. modifying reqprep() the lack of {} caused me trouble. I added
  9650. them. * Code outside route.c treats sip_route as an opaque
  9651. structure, using macro's or procedures for all access. (closes
  9652. issue ASTERISK-22582) Reported by: Corey Farrell Review:
  9653. https://reviewboard.asterisk.org/r/3173/
  9654. 2014-02-10 16:49 +0000 [r407876] Walter Doekes <walter+asterisk@wjd.nu>
  9655. * res/res_config_pgsql.c, /: res_config_pgsql: Fix
  9656. ast_update2_realtime calls. Fix so multiple updates from a single
  9657. call works (add missing ','). Remove bogus ast_free's that
  9658. weren't supposed to be there. Moved a few spaces for readability.
  9659. Review: https://reviewboard.asterisk.org/r/3194/ ........ Merged
  9660. revisions 407873 from
  9661. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9662. revisions 407874 from
  9663. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9664. revisions 407875 from
  9665. http://svn.asterisk.org/svn/asterisk/branches/12
  9666. 2014-02-10 16:01 +0000 [r407859] Kinsey Moore <kmoore@digium.com>
  9667. * apps/app_confbridge.c, apps/confbridge/conf_state_multi_marked.c,
  9668. apps/confbridge/conf_state_empty.c,
  9669. apps/confbridge/conf_config_parser.c,
  9670. configs/confbridge.conf.sample, /,
  9671. apps/confbridge/include/confbridge.h, UPGRADE.txt: ConfBridge:
  9672. Correct prompt playback target Currently, when the first marked
  9673. user enters the conference that contains waitmarked users, a
  9674. prompt is played indicating that the user is being placed into
  9675. the conference. Unfortunately, this prompt is played to the
  9676. marked user and not the waitmarked users which is not very
  9677. helpful. This patch changes that behavior to play a prompt
  9678. stating "The conference will now begin" to the entire conference
  9679. after adding and unmuting the waitmarked users since the design
  9680. of confbridge is not conducive to playing a prompt to a subset of
  9681. users in a conference in an asynchronous manner. (closes issue
  9682. PQ-1396) Review: https://reviewboard.asterisk.org/r/3155/
  9683. Reported by: Steve Pitts ........ Merged revisions 407857 from
  9684. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9685. revisions 407858 from
  9686. http://svn.asterisk.org/svn/asterisk/branches/12
  9687. 2014-02-07 20:52 +0000 [r407767] Richard Mudgett <rmudgett@digium.com>
  9688. * /, channels/chan_iax2.c: chan_iax2: Add some more iaxs[] NULL
  9689. checks to a routine already full of them. ........ Merged
  9690. revisions 407764 from
  9691. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9692. revisions 407765 from
  9693. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9694. revisions 407766 from
  9695. http://svn.asterisk.org/svn/asterisk/branches/12
  9696. 2014-02-07 20:17 +0000 [r407752] Matthew Jordan <mjordan@digium.com>
  9697. * /, main/security_events.c: security_events: Fix assertion failure
  9698. in dev-mode on optional IE parsing When formatting an optional
  9699. IE, the value is, of course, optional. As such, it is entirely
  9700. appropriate for ast_json_object_get to return NULL. If that
  9701. occurs, we now simply skip the IE that was requested, as it was
  9702. not provided by the entity that raised the event. Thanks to
  9703. George Joseph (gtjoseph) for catching this and reporting it in
  9704. #asterisk-dev ........ Merged revisions 407750 from
  9705. http://svn.asterisk.org/svn/asterisk/branches/12
  9706. 2014-02-07 20:01 +0000 [r407749] Joshua Colp <jcolp@digium.com>
  9707. * main/timing.c, res/res_timing_pthread.c, res/res_timing_dahdi.c,
  9708. res/res_timing_timerfd.c, include/asterisk/timing.h,
  9709. res/res_timing_kqueue.c: timing: Improve performance for most
  9710. timing implementations. This change allows timing implementation
  9711. data to be stored directly on the timer itself thus removing the
  9712. requirement for many implementations to do a container lookup for
  9713. the same information. This means that API calls into timing
  9714. implementations can directly access the information they need
  9715. instead of having to find it. Review:
  9716. https://reviewboard.asterisk.org/r/3175/
  9717. 2014-02-07 19:40 +0000 [r407748] Matthew Jordan <mjordan@digium.com>
  9718. * /, funcs/func_cdr.c: funcs/func_cdr: Handle empty time values
  9719. when extracting parsed values When extracting timestamps that are
  9720. parsed, time stamp values that are not set (time values of
  9721. 0.000000) should not actually result in a parsed string. The
  9722. value should be skipped, and the result of the CDR function
  9723. should be an empty string. Prior to this patch, the result was
  9724. fed to the time formatting, which would result in an output of a
  9725. date/time in 1969. ........ Merged revisions 407747 from
  9726. http://svn.asterisk.org/svn/asterisk/branches/12
  9727. 2014-02-07 18:29 +0000 [r407731] Richard Mudgett <rmudgett@digium.com>
  9728. * channels/chan_iax2.c, include/asterisk/frame.h,
  9729. configs/iax.conf.sample, /: chan_iax2: Block unnecessary control
  9730. frames to/from the wire. Establishing an IAX2 call between
  9731. Asterisk v1.4 and v1.8 (or later) results in an unexpected call
  9732. disconnect. The problem happens because newer values in the enum
  9733. ast_control_frame_type are not consistent between the branch
  9734. versions of Asterisk. For example: 1) v1.4 calls v1.8 (or later)
  9735. using IAX2 2) v1.8 answers and sends a connected line update
  9736. control frame. (on v1.8 AST_CONTROL_CONNECTED_LINE = 22) 3) v1.4
  9737. receives the control frame as an end-of-q (on v1.4
  9738. AST_CONTROL_END_OF_Q = 22) 4) v1.4 disconnects the call once the
  9739. receive queue becomes empty. Several things are done by this
  9740. patch to fix the problem and attempt to prevent it from happening
  9741. again in the future: * Added a warning at the definition of enum
  9742. ast_control_frame_type about how to add new control frame values.
  9743. * Made block sending and receiving control frames that have no
  9744. reason to go over the wire. * Extended the connectedline iax.conf
  9745. parameter to also include the redirecting information updates. *
  9746. Updated the connectedline iax.conf parameter documentation to
  9747. include a notice that the parameter must be "no" when the peer is
  9748. an Asterisk v1.4 instance. (closes issue AST-1302) Review:
  9749. https://reviewboard.asterisk.org/r/3174/ ........ Merged
  9750. revisions 407678 from
  9751. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9752. revisions 407727 from
  9753. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9754. revisions 407729 from
  9755. http://svn.asterisk.org/svn/asterisk/branches/12
  9756. 2014-02-07 16:47 +0000 [r407677] Matthew Jordan <mjordan@digium.com>
  9757. * /, main/security_events.c: security_events: Fix error caused by
  9758. DTD validation error The appdocsxml.dtd specifies that a
  9759. "required" attribute in a parameter may have a value of yes, no,
  9760. true, or false. On some systems, specifying "False" instead of
  9761. "false" would cause a validation error. This patch fixes the
  9762. casing to explicitly match the DTD. ........ Merged revisions
  9763. 407676 from http://svn.asterisk.org/svn/asterisk/branches/12
  9764. 2014-02-07 13:15 +0000 [r407625] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  9765. * /, configs/indications.conf.sample: indications.conf: add stutter
  9766. tone; end properly * If the "stutter" (voicemail indication) tone
  9767. is indeed a stutter tone, and it ends with a constant tone, make
  9768. sure that it is the dial tone. This was done for India (in),
  9769. Mexico (mx) and the Philippines (ph). * If no "stutter" tone
  9770. exists for a country, provide one. This was done for Spain (es),
  9771. Malaysia (my) and Venezuela (ve). Review:
  9772. https://reviewboard.asterisk.org/r/3158/ ........ Merged
  9773. revisions 407622 from
  9774. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9775. revisions 407623 from
  9776. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9777. revisions 407624 from
  9778. http://svn.asterisk.org/svn/asterisk/branches/12
  9779. 2014-02-06 21:24 +0000 [r407602] Matthew Jordan <mjordan@digium.com>
  9780. * /, main/security_events.c, UPGRADE.txt, CHANGES: security_events:
  9781. Add AMI documentation; output optional fields This patch adds
  9782. documentation for the Security Events that are emited over AMI.
  9783. It also notes these events in the UPGRADE/CHANGES file. ........
  9784. Merged revisions 407589 from
  9785. http://svn.asterisk.org/svn/asterisk/branches/12
  9786. 2014-02-06 19:58 +0000 [r407588] Rusty Newton <rnewton@digium.com>
  9787. * /, configs/pjsip.conf.sample: configs/pjsip.conf.sample:
  9788. Configuration section naming in pjsip.conf.sample needs a little
  9789. clarification There is a bit of nuance to how you name things in
  9790. pjsip.conf. This is a documentation patch to at least clear it up
  9791. a little for users. Review:
  9792. https://reviewboard.asterisk.org/r/3180/ ........ Merged
  9793. revisions 407587 from
  9794. http://svn.asterisk.org/svn/asterisk/branches/12
  9795. 2014-02-06 18:11 +0000 [r407574] Kevin Harwell <kharwell@digium.com>
  9796. * /,
  9797. contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py:
  9798. pjsip realtime: already created enum failure for postgresql If an
  9799. enum had been previously created the alembic script would attempt
  9800. to re-create it and an error would be generated while running
  9801. migrations for a postgresql server. The work around for this is
  9802. to use the ENUM object type for postgres as opposed to the
  9803. generic enum type used by sqlalchemy. Using this type in the
  9804. script seems to work properly for both postgres and mysql.
  9805. ........ Merged revisions 407572 from
  9806. http://svn.asterisk.org/svn/asterisk/branches/12
  9807. 2014-02-06 17:55 +0000 [r407573] Richard Mudgett <rmudgett@digium.com>
  9808. * res/res_pjsip_logger.c,
  9809. res/res_pjsip/include/res_pjsip_private.h,
  9810. res/res_pjsip/pjsip_options.c, res/res_pjsip/config_transport.c,
  9811. include/asterisk/res_pjsip.h, res/res_pjsip/config_global.c,
  9812. res/res_pjsip/config_auth.c, /, res/res_pjsip/location.c,
  9813. res/res_pjsip_outbound_registration.c,
  9814. res/res_pjsip_endpoint_identifier_ip.c,
  9815. include/asterisk/res_pjsip_cli.h, res/res_pjsip/pjsip_cli.c,
  9816. res/res_pjsip/pjsip_configuration.c,
  9817. res/res_pjsip/config_domain_aliases.c: res_pjsip: Updates and
  9818. adds more PJSIP CLI commands. * Adds identify, transport, and
  9819. registration support to the PJSIP CLI. * Creates three additional
  9820. callbacks, one for an iterator, one for a comparator, and one for
  9821. a container. This eliminates the link dependency from higher
  9822. level modules to lower level ones. * Eliminates duplicate sorting
  9823. in PJSIP CLI commands. * Cleans up PJSIP CLI output formatting. *
  9824. Pushes CLI command registration down to the implementing source
  9825. file. * Adds several ast_sip_destroy_sorcery functions to
  9826. complement existing ast_sip_sorcery_initialize functions. The
  9827. destroy functions unregister PJSIP CLI commands and PJSIP CLI
  9828. formatters. Reported by: George Joseph Review:
  9829. https://reviewboard.asterisk.org/r/3104/ ........ Merged
  9830. revisions 407568 from
  9831. http://svn.asterisk.org/svn/asterisk/branches/12
  9832. 2014-02-05 23:04 +0000 [r407514] Rusty Newton <rnewton@digium.com>
  9833. * /, formats/format_wav.c: formats/format_wav: enhancing log
  9834. message "Not a wav file" to be clear on what is supported
  9835. Modifying the log message to be more specific as to what is
  9836. supported. Specifically it seems format_wav supports only PCM
  9837. encoded versions with a lower-case '.wav' extension. (closes
  9838. issues ASTERISK-22310) Reported by: Jim Credland Review:
  9839. https://reviewboard.asterisk.org/r/3188/ ........ Merged
  9840. revisions 407511 from
  9841. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9842. revisions 407512 from
  9843. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9844. revisions 407513 from
  9845. http://svn.asterisk.org/svn/asterisk/branches/12
  9846. 2014-02-05 20:56 +0000 [r407462] Jonathan Rose <jrose@digium.com>
  9847. * CHANGES, /: CHANGES: Improved description of Name/Creator changes
  9848. to bridge ARI, adds AMI The changes log was written with language
  9849. that was a little too internal Asterisk specific, so it's been
  9850. changed to be more in the frame of reference of an ARI user.
  9851. Also, previously the AMI event changes were omitted from the
  9852. change log as well as the ability to include a bridge name in the
  9853. ARI post bridges command. ........ Merged revisions 407461 from
  9854. http://svn.asterisk.org/svn/asterisk/branches/12
  9855. 2014-02-05 20:43 +0000 [r407459] Kinsey Moore <kmoore@digium.com>
  9856. * main/logger.c, /: Logger: Fix handling of absolute paths This
  9857. fixes path handling for log files so that an extra / is not
  9858. appended to the file path when the path is absolute (begins with
  9859. /). This would previously result in different but functionally
  9860. equivalent paths in the output of 'logger show channels'.
  9861. ........ Merged revisions 407455 from
  9862. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9863. revisions 407456 from
  9864. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9865. revisions 407458 from
  9866. http://svn.asterisk.org/svn/asterisk/branches/12
  9867. 2014-02-05 19:42 +0000 [r407443] Kevin Harwell <kharwell@digium.com>
  9868. * res/res_pjsip/config_global.c, /: res_pjsip: When no global type
  9869. the debug option defaults to "yes" If the global section was not
  9870. specified in pjsip.conf then the configuration object does not
  9871. exist in sorcery so when retrieving "debug" option it would
  9872. return NULL. Then the NULL result was passed to ast_false utils
  9873. function which would return false because it wasn't set to some
  9874. representation of false, thus enabling sip debug logging. Made it
  9875. so if the global config object does not exist then it will return
  9876. a default of "no" for sip debugging. (issue ASTERISK-23038)
  9877. Reported by: Rusty Newton ........ Merged revisions 407442 from
  9878. http://svn.asterisk.org/svn/asterisk/branches/12
  9879. 2014-02-05 17:42 +0000 [r407422-407425] Jonathan Rose <jrose@digium.com>
  9880. * CHANGES: CHANGES: Update changes log to include r403414 entry
  9881. Adds note of additional 0 for operator option on app_record
  9882. * CHANGES, /: CHANGES: Update changes log to include new bridge
  9883. fields added in r404042 ........ Merged revisions 407419 from
  9884. http://svn.asterisk.org/svn/asterisk/branches/12
  9885. 2014-02-05 15:29 +0000 [r407407] Matthew Jordan <mjordan@digium.com>
  9886. * rest-api/api-docs/playbacks.json, UPGRADE.txt,
  9887. rest-api/api-docs/sounds.json, rest-api/resources.json, CHANGES,
  9888. include/asterisk/manager.h, rest-api/api-docs/bridges.json,
  9889. rest-api/api-docs/deviceStates.json,
  9890. rest-api/api-docs/mailboxes.json,
  9891. rest-api/api-docs/asterisk.json,
  9892. rest-api/api-docs/applications.json,
  9893. rest-api/api-docs/channels.json,
  9894. rest-api/api-docs/recordings.json,
  9895. rest-api/api-docs/endpoints.json, rest-api/api-docs/events.json,
  9896. /: ARI/AMI: Update versions; update UPGRADE/CHANGES notes for
  9897. 12.1.0 changes Due to backwards compatible changes made to
  9898. AMI/ARI, the version needs to be bumped to 1.1.0/2.1.0,
  9899. respectively. ........ Merged revisions 407402 from
  9900. http://svn.asterisk.org/svn/asterisk/branches/12
  9901. 2014-02-04 20:15 +0000 [r407275-407340] Richard Mudgett <rmudgett@digium.com>
  9902. * include/asterisk/devicestate.h, /, main/devicestate.c:
  9903. devicestate: Make ast_devstate_changed_literal() return value and
  9904. doxygen consistent. Nothing actually cares about the value
  9905. anyway. (closes issue ASTERISK-23178) Reported by: Jonathan Rose
  9906. ........ Merged revisions 407337 from
  9907. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9908. revisions 407338 from
  9909. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9910. revisions 407339 from
  9911. http://svn.asterisk.org/svn/asterisk/branches/12
  9912. * /, res/res_pjsip/pjsip_configuration.c: res_pjsip: Fix assertion
  9913. for pjsip.conf authorization list options. (closes issue
  9914. ASTERISK-23168) Reported by: George Joseph Review:
  9915. https://reviewboard.asterisk.org/r/3143/ ........ Merged
  9916. revisions 407324 from
  9917. http://svn.asterisk.org/svn/asterisk/branches/12
  9918. * configs/sip.conf.sample, main/tcptls.c, /: tcptls.c: Made TLS
  9919. handle a certificate chain file. Thanks to Guillaume Martres for
  9920. doing the necessary research to validate the change. (closes
  9921. issue ASTERISK-17727) Reported by: LN Patches:
  9922. use_certificate_chain.patch (license #5864) patch uploaded by st
  9923. documente_certificate_chain.patch (license #6576) patch uploaded
  9924. by Guillaume Martres ........ Merged revisions 407272 from
  9925. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9926. revisions 407273 from
  9927. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9928. revisions 407274 from
  9929. http://svn.asterisk.org/svn/asterisk/branches/12
  9930. 2014-02-04 16:55 +0000 [r407260] Matthew Jordan <mjordan@digium.com>
  9931. * /, funcs/func_cdr.c: funcs/func_cdr: Fix non-epoch timestamps
  9932. broken by improper char array deref Thanks to snuffy for pointing
  9933. this issue out and fixing it. (closes issue ASTERISK-23250)
  9934. Reported by: snuffy patches: func_cdr-fix.diff uploaded by snuffy
  9935. (License 5024) ........ Merged revisions 407259 from
  9936. http://svn.asterisk.org/svn/asterisk/branches/12
  9937. 2014-02-04 02:22 +0000 [r407217] Joshua Colp <jcolp@digium.com>
  9938. * res/res_clialiases.c, /: res_clialiases: Fix crash when reloading
  9939. and re-aliasing an alias that is in use. The code assumed that
  9940. unregistering the alias would always succeed while in practice
  9941. this is not actually true. A common case is the "reload" command
  9942. itself. If the cli_aliases.conf configuration file was changed
  9943. and reload executed the command would fail to unregister and
  9944. ultimately point to freed memory. The reload process now checks
  9945. whether unregistering succeeded or not and if not the old CLI
  9946. alias is retained. (closes issue ASTERISK-19773) Reported by:
  9947. Joel Vandal (closes issue ASTERISK-22757) Reported by: Gareth
  9948. Blades ........ Merged revisions 407205 from
  9949. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9950. revisions 407210 from
  9951. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9952. revisions 407213 from
  9953. http://svn.asterisk.org/svn/asterisk/branches/12
  9954. 2014-02-04 02:07 +0000 [r407198] Damien Wedhorn <voip@facts.com.au>
  9955. * /, channels/chan_skinny.c: Skinny - Fix deadlock when pickup of
  9956. no call. Locking issues in skinny when picking up a call that
  9957. doesn't exist. Cleaned up sub locking by fully removing and using
  9958. the chan lock instead. Also changed ast_call_pickup to check
  9959. whether chan was masq'd. (closes issue ASTERISK-23249) Reported
  9960. by: wedhorn Tested by: snuffy, myself Patches:
  9961. skinny-locking01.diff uploaded by wedhorn (license 5019) ........
  9962. Merged revisions 407197 from
  9963. http://svn.asterisk.org/svn/asterisk/branches/12
  9964. 2014-02-03 01:31 +0000 [r407169] Matthew Jordan <mjordan@digium.com>
  9965. * main/cdr.c, /: cdrs: Check for applications to lock onto during
  9966. dial begin handling This patch brings CDR processing further in
  9967. line with r407085. During some dial operations, the application
  9968. would not be locked to the Dial application and would instead
  9969. continue to show the previously known application. In particular,
  9970. this would occur when a Parked call would time out. This was due
  9971. to a previous snapshot already locking the application to Park -
  9972. processing this in a Dial Begin allows the Dial application to
  9973. reassert its rightful place. (CDRs. Ugh.) But hooray for the
  9974. Parked Call tests for catching this in the Asterisk Test Suite.
  9975. ........ Merged revisions 407166 from
  9976. http://svn.asterisk.org/svn/asterisk/branches/12
  9977. 2014-02-01 16:26 +0000 [r407154] Joshua Colp <jcolp@digium.com>
  9978. * res/ari/ari_model_validators.h, rest-api/api-docs/events.json, /,
  9979. res/stasis/app.c, res/ari/ari_model_validators.c,
  9980. res/res_stasis.c, main/stasis_bridges.c: res_stasis: Enable
  9981. transfers and provide events when they occur. This change enables
  9982. transfers within ARI created bridges and adds events for when
  9983. they occur. Unlike other events these will be received if *any*
  9984. subscribed object is involved in the transfer. (closes issue
  9985. ASTERISK-22984) Reported by: David M. Lee Review:
  9986. https://reviewboard.asterisk.org/r/3120/ ........ Merged
  9987. revisions 407153 from
  9988. http://svn.asterisk.org/svn/asterisk/branches/12
  9989. 2014-02-01 00:25 +0000 [r407105] Corey Farrell <git@cfware.com>
  9990. * apps/app_stack.c, /: app_stack: protect against missing
  9991. parameters to STACK_PEEK and LOCAL_PEEK STACK_PEEK requires 2
  9992. parameters and LOCAL_PEEK requires 1 parameter. This protects
  9993. against situations where those parameters are blank or missing by
  9994. logging an error and returning. (closes issue ASTERISK-23220)
  9995. Reported by: James Sharp ........ Merged revisions 407100 from
  9996. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  9997. revisions 407103 from
  9998. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  9999. revisions 407104 from
  10000. http://svn.asterisk.org/svn/asterisk/branches/12
  10001. 2014-01-31 23:40 +0000 [r407083-407085] Matthew Jordan <mjordan@digium.com>
  10002. * apps/app_dial.c, main/cdr.c, main/pbx.c, /, main/bridge_after.c,
  10003. UPGRADE.txt, main/manager_channels.c: CDRs: fix a variety of dial
  10004. status problems, h/hangup handler creating CDRs This patch fixes
  10005. a number of small-ish problems that were noticed when witnessing
  10006. the records that the FreePBX dialplan produces: (1) Mid-call
  10007. events (as well as privacy options) have the ability to change
  10008. the overall state of the Dial operation after the called party
  10009. answers. This means that publishing the DialEnd event when the
  10010. called party is premature; we have to wait for the execution of
  10011. these subroutines to complete before we can signal the overall
  10012. status of the DialEnd. This patch moves that publication and adds
  10013. handlers for the mid-call events. (2) The AST_FLAG_OUTGOING
  10014. channel flag is cleared if an after bridge goto datastore is
  10015. detected. This flag was preventing CDRs from being recorded for
  10016. all outbound channels that had a 'continue' option enabled on
  10017. them by the Dial application. (3) The CDR engine now locks the
  10018. 'Dial' application as being the CDR application if it detects
  10019. that the current CDR has entered that app. This is similar to the
  10020. logic that is done for Parking. In general, if we entered into
  10021. Dial, then we want that CDR to record the application as such -
  10022. this prevents pre-dial handlers, mid-call handlers, and other
  10023. shenaniganry from changing the application value. (4) The CDR
  10024. engine now checks for the AST_SOFTHANGUP_HANGUP_EXEC in more
  10025. places to determine if the channel is in hangup logic or dead. In
  10026. either case, we don't want to record changes in the channel. (5)
  10027. The default option for "endbeforehexten" has been changed to
  10028. "yes". In general, you don't want to see CDRs in the 'h' exten or
  10029. in hangup logic. Since the semantics of that option changed in
  10030. 12, it made sense to update the default value as well. (6)
  10031. Finally, because we now have the ability to synchronize on the
  10032. messages published to the CDR topic, on shutdown the CDR engine
  10033. will now synchronize to the messages currently in flight. This
  10034. helps to ensure that all in-flight CDRs are written before
  10035. shutting down. (closes issue ASTERISK-23164) Reported by: Matt
  10036. Jordan Review: https://reviewboard.asterisk.org/r/3154 ........
  10037. Merged revisions 407084 from
  10038. http://svn.asterisk.org/svn/asterisk/branches/12
  10039. * apps/app_dial.c, /: app_dial: Allow macro/gosub pre-bridge
  10040. execution to occur on priorities The parsing for the destination
  10041. of the macro/gosub uses the '^' character to separate out
  10042. context, extension, and priority. However, the logic for the
  10043. macro/gosub execution was written such that it would only do the
  10044. actual macro/gosub jump if a '^' character existed. This doesn't
  10045. apply when the macro/gosub jump occurs in a priority/priority
  10046. label. This patch changes the logic so that the parsing still
  10047. occurs, but the jump will occur even for priorities/priority
  10048. labels. (issue ASTERISK-23164) Review:
  10049. https://reviewboard.asterisk.org/r/3154 ........ Merged revisions
  10050. 407041 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  10051. ........ Merged revisions 407074 from
  10052. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10053. revisions 407082 from
  10054. http://svn.asterisk.org/svn/asterisk/branches/12
  10055. 2014-01-31 23:15 +0000 [r407035-407037] Kevin Harwell <kharwell@digium.com>
  10056. * res/res_pjsip_logger.c, CHANGES, res/res_pjsip.c,
  10057. include/asterisk/res_pjsip.h, res/res_pjsip/config_global.c,
  10058. contrib/ast-db-manage/config/versions/21e526ad3040_add_pjsip_debug_option.py
  10059. (added), /, configs/pjsip.conf.sample, UPGRADE.txt: res_pjsip:
  10060. Config option to enable PJSIP logger at load time. Added a
  10061. "debug" configuration option for res_pjsip that when set to "yes"
  10062. enables SIP messages to be logged. It is specified under the
  10063. "system" type. Also added an alembic script to add the option to
  10064. realtime. (closes issue ASTERISK-23038) Reported by: Rusty Newton
  10065. Review: https://reviewboard.asterisk.org/r/3148/ ........ Merged
  10066. revisions 407036 from
  10067. http://svn.asterisk.org/svn/asterisk/branches/12
  10068. * res/res_pjsip_exten_state.c, /: res_pjsip_exten_state: Exporting
  10069. global symbols caused load order issues Removed the exportation
  10070. of global symbols from the module as it is no longer needed and
  10071. it could potentially cause load problems as on some systems it
  10072. would try to load before res_pjsip_pubsub ........ Merged
  10073. revisions 407034 from
  10074. http://svn.asterisk.org/svn/asterisk/branches/12
  10075. 2014-01-31 23:04 +0000 [r407033] Richard Mudgett <rmudgett@digium.com>
  10076. * CHANGES, apps/app_chanspy.c: ChanSpy: Add ability to specify
  10077. channel uniqueids as well as channel names. * Made ChanSpy accept
  10078. a channel uniqueid or a fully specified channel name as the
  10079. chanprefix parameter if the 'u' option is specified. (closes
  10080. issue AFS-42) Review: https://reviewboard.asterisk.org/r/3160/
  10081. 2014-01-31 22:39 +0000 [r407030-407032] Mark Michelson <mmichelson@digium.com>
  10082. * include/asterisk/res_pjsip_presence_xml.h (added), /: Add file
  10083. that apparently got missed in the merge. ........ Merged
  10084. revisions 407031 from
  10085. http://svn.asterisk.org/svn/asterisk/branches/12
  10086. * res/res_pjsip_pidf_body_generator.c (added),
  10087. include/asterisk/res_pjsip_exten_state.h (removed),
  10088. res/res_pjsip_pubsub.exports.in, /,
  10089. include/asterisk/res_pjsip_body_generator_types.h (added),
  10090. res/res_pjsip_mwi.c, res/res_pjsip_xpidf_body_generator.c
  10091. (added), res/res_pjsip_mwi_body_generator.c (added),
  10092. res/res_pjsip_pubsub.c, res/res_pjsip_pidf.c (removed),
  10093. res/res_pjsip_pidf_eyebeam_body_supplement.c (added),
  10094. res/res_pjsip_exten_state.c, res/res_pjsip/presence_xml.c
  10095. (added), include/asterisk/res_pjsip_pubsub.h: Decouple
  10096. subscription handling from NOTIFY/PUBLISH body generation. When
  10097. the PJSIP pubsub framework was created, subscription handlers
  10098. were required to state what event they handled along with what
  10099. body types they knew how to generate. While this serves well when
  10100. implementing a base RFC, it has problems when trying to extend
  10101. the body to support non-standard or proprietary body elements.
  10102. The code also was NOTIFY-specific, meaning that when the time
  10103. comes that we start writing code to send out PUBLISH requests
  10104. with MWI or presence bodies, we would likely find ourselves
  10105. duplicating code that had previously been written. This changeset
  10106. introduces the concept of body generators and body supplements. A
  10107. body generator is responsible for allocating a native structure
  10108. for a given body type, providing the primary body content,
  10109. converting the native structure to a string, and deallocating
  10110. resources. A body supplement takes the primary body content (the
  10111. native structure, not a string) generated by the body generator
  10112. and adds nonstandard elements to the body. With these elements
  10113. living in their own module, it becomes easy to extend our support
  10114. for body types and to re-use resources when sending a PUBLISH
  10115. request. Body generators and body supplements register themselves
  10116. with the pubsub core, similar to how subscription and publish
  10117. handlers had done. Now, subscription handlers do not need to know
  10118. what type of body content they generate, but they still need to
  10119. inform the pubsub core about what the default body type for a
  10120. given event package is. The pubsub core keeps track of what body
  10121. generators and body supplements have been registered. When a
  10122. SUBSCRIBE arrives, the pubsub core will check that there is a
  10123. subscription handler for the event in the SUBSCRIBE, then it will
  10124. check that there is a body generator that can provide the content
  10125. specified in the Accept header(s). Because of the nature of body
  10126. generators and supplements, it means res_pjsip_exten_state and
  10127. res_pjsip_mwi have been completely gutted. They no longer worry
  10128. about body types, instead calling
  10129. ast_sip_pubsub_generate_body_content() when they need to generate
  10130. a NOTIFY body. Review: https://reviewboard.asterisk.org/r/3150
  10131. ........ Merged revisions 407016 from
  10132. http://svn.asterisk.org/svn/asterisk/branches/12
  10133. 2014-01-31 22:23 +0000 [r407015-407029] Kevin Harwell <kharwell@digium.com>
  10134. * contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py,
  10135. contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py,
  10136. /, UPGRADE.txt: alembic: script modifications due to errors A
  10137. couple of the scripts had errors that would not allow a full
  10138. migration to take place. The extensions table needed to make its
  10139. 'id' column a primary key in order to work with mysql. The other
  10140. script ...add_endpoints... was missing tables that it was trying
  10141. to add columns to. Added the primary key on id for extensions and
  10142. added the tables in for the missing pjsip configuration options.
  10143. While it is not ideal to modify already released scripts this was
  10144. a case where it had to be done due to errors in the script and
  10145. lacking a better alternative. Review:
  10146. https://reviewboard.asterisk.org/r/3167/ ........ Merged
  10147. revisions 407019 from
  10148. http://svn.asterisk.org/svn/asterisk/branches/12
  10149. * /, res/res_pjsip_mwi.c: res_pjsip_mwi: Subscribe fails when
  10150. missing aor name When subscribing to MWI (res_pjsip_mwi) and the
  10151. sip uri did not contain a name (ex: sip:<ip address>) then the
  10152. subscription would fail since it would be unable to locate an
  10153. associated aor. This patch makes it so that when a subscribe
  10154. comes with no aor name then it will subscribe to all aors on the
  10155. located endpoint. (closes issue ASTERISK-23072) Reported by: Bob
  10156. M Review: https://reviewboard.asterisk.org/r/3164/ ........
  10157. Merged revisions 407014 from
  10158. http://svn.asterisk.org/svn/asterisk/branches/12
  10159. 2014-01-31 15:08 +0000 [r407001] Kinsey Moore <kmoore@digium.com>
  10160. * res/res_pjsip_nat.c, /: PJSIP: Fix address for ACK in NAT
  10161. situations In NAT scenarios where a call is placed to a
  10162. Grandstream phone, res_pjsip will sometimes send the ACK to a 200
  10163. OK to the private address of the device behind the NAT instead of
  10164. the address of the NAT device. This corrects that behavior by
  10165. rewriting the address in the Contact header in the incoming 200
  10166. OK and the dialog's target address if necessary (since it has
  10167. already been rewritten to the incorrect private address). (closes
  10168. issue ASTERISK-23106) Review:
  10169. https://reviewboard.asterisk.org/r/3168/ Reported by: Matt Jordan
  10170. ........ Merged revisions 407000 from
  10171. http://svn.asterisk.org/svn/asterisk/branches/12
  10172. 2014-01-31 05:31 +0000 [r406988] Damien Wedhorn <voip@facts.com.au>
  10173. * /, channels/chan_skinny.c: Skinny: fix up possible double unlock
  10174. of chan. Return before chan is possibly unlocked a second time
  10175. when hanging up a channel in SUBSTATE_OFFHOOK. ........ Merged
  10176. revisions 406987 from
  10177. http://svn.asterisk.org/svn/asterisk/branches/12
  10178. 2014-01-30 20:36 +0000 [r406936] Corey Farrell <git@cfware.com>
  10179. * main/udptl.c, res/res_rtp_asterisk.c, /: res_rtp_asterisk &
  10180. udptl: fix port selection to work with SELinux restrictions
  10181. ast_bind to a port reserved for another program by SELinux causes
  10182. errno == EACCES. This caused random failures when binding rtp or
  10183. udptl sockets. Treat EACCES as a non-fatal error, try next port.
  10184. (closes issue ASTERISK-23134) Reported by: Corey Farrell ........
  10185. Merged revisions 406933 from
  10186. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10187. revisions 406934 from
  10188. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10189. revisions 406935 from
  10190. http://svn.asterisk.org/svn/asterisk/branches/12
  10191. 2014-01-30 17:35 +0000 [r406920] Sean Bright <sean@malleable.com>
  10192. * main/manager.c, /: Make a NOTICE about an invalid channel name
  10193. more useful. ........ Merged revisions 406918 from
  10194. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10195. revisions 406919 from
  10196. http://svn.asterisk.org/svn/asterisk/branches/12
  10197. 2014-01-29 00:44 +0000 [r406863] Russell Bryant <russell@russellbryant.com>
  10198. * /, configs/queues.conf.sample: queues.conf.sample Fix documented
  10199. default for persistentmembers Closes issue ASTERISK-22662
  10200. ........ Merged revisions 406860 from
  10201. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10202. revisions 406861 from
  10203. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10204. revisions 406862 from
  10205. http://svn.asterisk.org/svn/asterisk/branches/12
  10206. 2014-01-28 23:40 +0000 [r406789-406848] Kevin Harwell <kharwell@digium.com>
  10207. * res/res_pjsip_pubsub.c, /: res_pjsip_pubsub: potential crash on
  10208. timeout What seems to be happening is if a subscription has been
  10209. terminated and the subscription timeout/expires is less than the
  10210. time it takes for all pending transactions (currently on the
  10211. subscription) to end then the subscription timer will not have
  10212. been canceled yet and sub will be null. Since the subscription
  10213. has already been canceled nothing needs to be done so a null
  10214. check in the asterisk code is sufficient in working around this
  10215. problem. (closes issue ASTERISK-23129) Reported by: Dan Jenkins
  10216. ........ Merged revisions 406847 from
  10217. http://svn.asterisk.org/svn/asterisk/branches/12
  10218. * cdr/cdr_radius.c, cel/cel_radius.c, /, configure,
  10219. include/asterisk/autoconfig.h.in, configure.ac: cdr_radius,
  10220. cel_radius: build agains libfreeradius-client Asterisk's RADIUS
  10221. module currently build against libradiusclient-ng, but this
  10222. project has been superseeded by libfreeradius-client. The API is
  10223. 99% compatible except that the header name has changed, the
  10224. library name has changed, and the configuration file location has
  10225. changed. (closes issue ASTERISK-22980) Reported by: Jeremy Lainé
  10226. Patches: freeradius-client.patch uploaded by sharky (license
  10227. 6561) ........ Merged revisions 406801 from
  10228. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10229. revisions 406802 from
  10230. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10231. revisions 406803 from
  10232. http://svn.asterisk.org/svn/asterisk/branches/12
  10233. * res/res_pjsip/include/res_pjsip_private.h, /,
  10234. include/asterisk/compat.h: res_pjsip,compat: INFINITY and NAN
  10235. undefined On some systems the values for INFINITY and NAN are not
  10236. defined thus causing a build error on those systems. Added
  10237. definitions for those if they had not previously been defined.
  10238. (closes issue ASTERISK-23056) Reported by: capouch Patches:
  10239. inf-nan-patch.txt uploaded by capouch (license 6564) ........
  10240. Merged revisions 406788 from
  10241. http://svn.asterisk.org/svn/asterisk/branches/12
  10242. 2014-01-28 19:19 +0000 [r406778] Kinsey Moore <kmoore@digium.com>
  10243. * /, res/res_stasis_device_state.c: ARI: Make double subscribe
  10244. respond with success Currently, attempting to subscribe an
  10245. application to a device state that it has already subscribed to
  10246. will generate a 500 error response. This will now be treated as a
  10247. subscription refresh even though ARI subscriptions don't
  10248. currently support lifetimes and will respond with the normal
  10249. response for a successful subscription (200 OK). (closes issue
  10250. ASTERISK-23143) Reported by: Matt Jordan ........ Merged
  10251. revisions 406775 from
  10252. http://svn.asterisk.org/svn/asterisk/branches/12
  10253. 2014-01-28 16:43 +0000 [r406724] Scott Griepentrog <sgriepentrog@digium.com>
  10254. * main/rtp_engine.c, /: rtp_engine: improved handling of
  10255. get_rtp_info failure In ast_rtp_instance_make_compatible(), after
  10256. a failure of channel tech call get_rtp_info() to return
  10257. peer_instance, the null pointer would be passed to ao2_ref,
  10258. producing an error that looked like a refernce counting problem
  10259. but is not. This patch corrects that and adds helpful LOG_ERROR
  10260. messages to indicate which failure path occurred. (issue
  10261. AST-1276) Review: https://reviewboard.asterisk.org/r/3156/
  10262. ........ Merged revisions 406721 from
  10263. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10264. revisions 406722 from
  10265. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10266. revisions 406723 from
  10267. http://svn.asterisk.org/svn/asterisk/branches/12
  10268. 2014-01-28 00:20 +0000 [r406710] Richard Mudgett <rmudgett@digium.com>
  10269. * /, tests/test_cel.c, tests/test_cdr.c: test_cdr.c, test_cel.c:
  10270. Correctly destroy created bridges. * Fixed the
  10271. test_cel_attended_transfer_bridges_link unit test to also account
  10272. for the local channel link being destroyed now that the bridges
  10273. are actually destroyed. * Made CDR unit test use its own version
  10274. of do_sleep() from the CEL unit tests. ........ Merged revisions
  10275. 406707 from http://svn.asterisk.org/svn/asterisk/branches/12
  10276. 2014-01-27 22:54 +0000 [r406647-406696] Kevin Harwell <kharwell@digium.com>
  10277. * CHANGES: manager: ExtensionStatus event status human readable
  10278. Added a note in the changes file about the new 'StatusText' field
  10279. that was added to the 'ExtensionStatus' event. (issue
  10280. ASTERISK-23154) Reported by: Jonathan Rose
  10281. * main/manager.c: manager: ExtensionStatus event status human
  10282. readable When an 'ExtensionStatus' event was raised it included
  10283. the status as a numerical value, but did not include a text
  10284. description of the status. Added a 'StatusText' field to the
  10285. event which is a string representation of the extension status.
  10286. Also added this to the 'Extension State' command response.
  10287. (closes issue ASTERISK-23154) Reported by: Jonathan Rose
  10288. 2014-01-27 20:38 +0000 [r406646] Russell Bryant <russell@russellbryant.com>
  10289. * main/config.c, /: Allow nested #includes in extconfig.conf
  10290. extconfig.conf was hard-coded to not allow nested includes for
  10291. some reason. The code has been this way since a patch was merged
  10292. for ASTERISK-3333 (revision 4889), which was a significant update
  10293. to this code ("Merge config updates"). I can't figure out any
  10294. good reason why this should be limited. This patch just removes
  10295. the limit and uses the default nesting depth limit. Closes issue
  10296. ASTERISK-17837 Review: https://reviewboard.asterisk.org/r/3159/
  10297. ........ Merged revisions 406643 from
  10298. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10299. revisions 406644 from
  10300. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10301. revisions 406645 from
  10302. http://svn.asterisk.org/svn/asterisk/branches/12
  10303. 2014-01-27 08:17 +0000 [r406618] Walter Doekes <walter+asterisk@wjd.nu>
  10304. * main/manager.c, UPGRADE.txt, configs/manager.conf.sample:
  10305. manager: The eventfilter= option now takes an extended regex. In
  10306. pre-trunk versions (...12) it accepts a basic regex, which is
  10307. confusing because all other regexes in asterisk are of the
  10308. extended kind. Review: https://reviewboard.asterisk.org/r/3147/
  10309. 2014-01-27 01:25 +0000 [r406595] Russell Bryant <russell@russellbryant.com>
  10310. * main/file.c, include/asterisk/channel.h, main/channel.c, /:
  10311. Protect ast_filestream object when on a channel The
  10312. ast_filestream object gets tacked on to a channel via
  10313. chan->timingdata. It's a reference counted object, but the
  10314. reference count isn't used when putting it on a channel. It's
  10315. theoretically possible for another thread to interfere with the
  10316. channel while it's unlocked and cause the filestream to get
  10317. destroyed. Use the astobj2 reference count to make sure that as
  10318. long as this code path is holding on the ast_filestream and
  10319. passing it into the file.c playback code, that it knows it's
  10320. valid. Bug reported by Leif Madsen. Review:
  10321. https://reviewboard.asterisk.org/r/3135/ ........ Merged
  10322. revisions 406566 from
  10323. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10324. revisions 406567 from
  10325. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10326. revisions 406574 from
  10327. http://svn.asterisk.org/svn/asterisk/branches/12
  10328. 2014-01-26 23:04 +0000 [r406517] Richard Mudgett <rmudgett@digium.com>
  10329. * /, main/tcptls.c: tcptls.c: Add missing cleanup on off nominal
  10330. path. ........ Merged revisions 406514 from
  10331. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10332. revisions 406515 from
  10333. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10334. revisions 406516 from
  10335. http://svn.asterisk.org/svn/asterisk/branches/12
  10336. 2014-01-26 14:19 +0000 [r406503] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  10337. * contrib/scripts/live_ast: live_ast: run wrapped programs with
  10338. exec live_ast can be used as a wrapper script to run asterisk,
  10339. gdb or valgrind. In those cases it runs them and returns the
  10340. result. It is more useful to use 'exec' to avoid having another
  10341. odd process in the chain. Review:
  10342. https://reviewboard.asterisk.org/r/3110/
  10343. 2014-01-26 02:11 +0000 [r406490] Joshua Colp <jcolp@digium.com>
  10344. * res/res_pjsip_session.c, /: res_pjsip_session: Be less strict
  10345. with core requested outgoing capabilities. The core may
  10346. (depending on circumstances) request a single codec on outgoing
  10347. calls. Many channel drivers ignore or treat this as a suggestion
  10348. while still including configured codecs. The res_pjsip_session
  10349. logic treated this as an explicit request, leaving out other
  10350. configured codecs. This change makes res_pjsip_session behave
  10351. like other channel driver and simply adds the requested codec to
  10352. the list. (closes issue ASTERISK-23082) Reported by: xrobau
  10353. Review: https://reviewboard.asterisk.org/r/3140/ ........ Merged
  10354. revisions 406489 from
  10355. http://svn.asterisk.org/svn/asterisk/branches/12
  10356. 2014-01-24 23:33 +0000 [r406466] Richard Mudgett <rmudgett@digium.com>
  10357. * /, main/cel.c: CEL: Protect data structures during reload and
  10358. shutdown. The CEL data structures need to be protected during a
  10359. configuration reload and shutdown. Asterisk crashed during a
  10360. shutdown because CEL events were still in flight and the CEL data
  10361. structures were already destroyed. * Protected the cel_backends,
  10362. cel_dialstatus_store, and cel_linkedids ao2 containers with a
  10363. global ao2 object wrapper. * Added NULL checks before use of the
  10364. cel_backends, cel_dialstatus_store, and cel_linkedids ao2
  10365. containers in case the CEL module is already shutdown. * Fixed
  10366. overloading of the cel_linkedids held objects reference count.
  10367. During shutdown any held objects would be leaked. * Fixed memory
  10368. leak of cel_linkedids held objects if the LINKEDID_END is not
  10369. being tracked. The objects in the cel_linkedids container were
  10370. not removed if the LINKEDID_END event is not used. * Added access
  10371. protection to the cel_backends container during the CLI "cel show
  10372. status" command. * Made cel_backends, cel_dialstatus_store, and
  10373. cel_linkedids use the standard ao2 callback templates for the
  10374. hash and cmp functions. * Eliminated unnecessary uses of
  10375. RAII_VAR(). * Made ast_cel_engine_init() cleanup alocated
  10376. resources on failure. (closes issue AST-1253) Reported by:
  10377. Guenther Kelleter Review:
  10378. https://reviewboard.asterisk.org/r/3128/ ........ Merged
  10379. revisions 406417 from
  10380. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10381. revisions 406418 from
  10382. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10383. revisions 406465 from
  10384. http://svn.asterisk.org/svn/asterisk/branches/12
  10385. 2014-01-24 22:34 +0000 [r406416] Jonathan Rose <jrose@digium.com>
  10386. * main/utils.c, CHANGES: Thread Debugging: Add LWP to core show
  10387. locks output This patch adds the LWP to core show locks output if
  10388. it is available. Review: https://reviewboard.asterisk.org/r/3142/
  10389. 2014-01-24 22:18 +0000 [r406407] Richard Mudgett <rmudgett@digium.com>
  10390. * main/manager.c, /: manager: Register atexit shutdown routine only
  10391. once. * Made register atexit shutdown routine only once in
  10392. __init_manager(). * Fixed some initial load failure conditions in
  10393. __init_manager(). * Made reset options to defaults on reload when
  10394. the reload will actually happen. * Removed unnecessary container
  10395. traversals of the white/black filters during manager_free_user().
  10396. * ast_free() does not need a NULL check before calling. ........
  10397. Merged revisions 406359 from
  10398. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10399. revisions 406400 from
  10400. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10401. revisions 406401 from
  10402. http://svn.asterisk.org/svn/asterisk/branches/12
  10403. 2014-01-24 21:46 +0000 [r406399] Jonathan Rose <jrose@digium.com>
  10404. * res/res_config_pgsql.c, /: res_config_pgsql: Fix a memory leak
  10405. and use RAII_VAR for cleanup when practical Review:
  10406. https://reviewboard.asterisk.org/r/3141/ ........ Merged
  10407. revisions 406360 from
  10408. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10409. revisions 406361 from
  10410. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10411. revisions 406389 from
  10412. http://svn.asterisk.org/svn/asterisk/branches/12
  10413. 2014-01-24 18:13 +0000 [r406343] Richard Mudgett <rmudgett@digium.com>
  10414. * main/manager.c, /: manager: Protect data structures during
  10415. shutdown. Occasionally, the manager module would get an
  10416. "INTERNAL_OBJ: bad magic number" error on a "core restart
  10417. gracefully" command if an AMI connection is established. * Added
  10418. ao2_global_obj protection to the sessions global container. *
  10419. Fixed the order of unreferencing a session object in
  10420. session_destroy(). * Removed unnecessary container traversals of
  10421. the white/black filters during session_destructor(). (closes
  10422. issue AST-1242) Reported by: Guenther Kelleter Review:
  10423. https://reviewboard.asterisk.org/r/3144/ ........ Merged
  10424. revisions 406341 from
  10425. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10426. revisions 406342 from
  10427. http://svn.asterisk.org/svn/asterisk/branches/12
  10428. 2014-01-23 23:43 +0000 [r406328] Mark Michelson <mmichelson@digium.com>
  10429. * /: Today is not my day for writing code that compiles. ........
  10430. Merged revisions 406327 from
  10431. http://svn.asterisk.org/svn/asterisk/branches/12
  10432. 2014-01-23 22:56 +0000 [r406312] Michael L. Young <elgueromexicano@gmail.com>
  10433. * /, addons/res_config_mysql.c: res_config_mysql: Fix Setting The
  10434. Column Name Incorrectly When support for a realtime sorcery
  10435. module was added in revision 386731, the wrong property was
  10436. accidentally used for setting the column name to be updated in
  10437. the database table. This patch fixes the typo. (closes issue
  10438. ASTERISK-23177) Reported by: Denis Tested by: Denis Patches:
  10439. asterisk-23177-use-field-name.diff by Michael L. Young (license
  10440. 5026) ........ Merged revisions 406311 from
  10441. http://svn.asterisk.org/svn/asterisk/branches/12
  10442. 2014-01-23 21:18 +0000 [r406298] Mark Michelson <mmichelson@digium.com>
  10443. * res/res_pjsip_pidf.c, /: Multiple revisions 406294-406295
  10444. ........ r406294 | mmichelson | 2014-01-23 15:00:24 -0600 (Thu,
  10445. 23 Jan 2014) | 11 lines Fix presence body errors found during
  10446. testing: * PIDF bodies were reporting an "open" state in many
  10447. cases where it should have been reporting "closed" * XPIDF bodies
  10448. had XML nodes placed incorrectly within the hierarchy. * SIP URIs
  10449. in XPIDF bodies did not go through XML sanitization * XML
  10450. sanitization had some errors: * Right angle bracket was being
  10451. replaced with "&rt;" instead of "&gt;" * Double quote,
  10452. apostrophe, and ampersand were not being escaped. ........
  10453. r406295 | mmichelson | 2014-01-23 15:09:35 -0600 (Thu, 23 Jan
  10454. 2014) | 11 lines Fix presence body errors found during testing: *
  10455. PIDF bodies were reporting an "open" state in many cases where it
  10456. should have been reporting "closed" * XPIDF bodies had XML nodes
  10457. placed incorrectly within the hierarchy. * SIP URIs in XPIDF
  10458. bodies did not go through XML sanitization * XML sanitization had
  10459. some errors: * Right angle bracket was being replaced with "&rt;"
  10460. instead of "&gt;" * Double quote, apostrophe, and ampersand were
  10461. not being escaped. ........ Merged revisions 406294-406295 from
  10462. http://svn.asterisk.org/svn/asterisk/branches/12
  10463. 2014-01-22 22:24 +0000 [r406269] Scott Griepentrog <sgriepentrog@digium.com>
  10464. * main/pbx.c, /, utils/extconf.c: pbx.c: Pre-initialize timezone to
  10465. avoid crash on destroy In ast_build_timing, initialize the
  10466. timezone value to NULL in order to avoid deferencing an
  10467. uninitialized value later when calling ast_destroy_timing. The
  10468. timezone value could be uninitialized if ast_build_timing were to
  10469. fail due to a zero length time string. (closes issue
  10470. ASTERISK-22861) Reported by: Sebastian Murray-Roberts Review:
  10471. https://reviewboard.asterisk.org/r/3134/ Patches:
  10472. ast_build_timing-initialize-timezone.patch uploaded by
  10473. coreyfarrell (license 5909) ........ Merged revisions 406241 from
  10474. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10475. revisions 406245 from
  10476. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10477. revisions 406264 from
  10478. http://svn.asterisk.org/svn/asterisk/branches/12
  10479. 2014-01-22 19:36 +0000 [r406153-406224] Kinsey Moore <kmoore@digium.com>
  10480. * /, apps/app_confbridge.c: ConfBridge: Fix channel parameter
  10481. documentation Confbridge AMI and CLI commands for mute, unmute,
  10482. and setting the single video source can accept channel prefixes
  10483. in lieu of a full channel name, but documentation states only
  10484. that it is required and is a channel name. This corrects the
  10485. documentation. (closes issue PQ-1397) Reported by: Steve Pitts
  10486. ........ Merged revisions 406217 from
  10487. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10488. revisions 406223 from
  10489. http://svn.asterisk.org/svn/asterisk/branches/12
  10490. * /, channels/chan_sip.c: chan_sip: Decline image streams on
  10491. unsupported transports This change allows chan_sip to decline
  10492. individual image streams over unsupported transports in the SDP
  10493. of the 200 response. Previously, an image stream offer with
  10494. RTP/AVP as the transport would cause chan_sip to respond with a
  10495. 488. (closes issue ASTERISK-22988) Reported by: adomjan Original
  10496. patch by: adomjan ........ Merged revisions 406170 from
  10497. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10498. revisions 406171 from
  10499. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10500. revisions 406172 from
  10501. http://svn.asterisk.org/svn/asterisk/branches/12
  10502. * res/res_stasis_playback.c, /: res_stasis_playback: Correct error
  10503. argument order Several of the playback error messages for invalid
  10504. media input in res_stasis_playback.c had the media name and
  10505. channel name reversed. They now correctly identify the channel
  10506. name and media name. Reported by: skrusty ........ Merged
  10507. revisions 406152 from
  10508. http://svn.asterisk.org/svn/asterisk/branches/12
  10509. 2014-01-21 21:48 +0000 [r406134] Rusty Newton <rnewton@digium.com>
  10510. * /, res/res_pjsip.c: res_pjsip: Documentation improvement for
  10511. Endpoint and AOR mailbox options. Making the help text for both
  10512. more explicit regarding the format of mailbox identifiers. i.e.
  10513. clarifying the format for app_voicemail mailboxes vs mailboxes
  10514. from external MWI sources through modules such as
  10515. res_external_mwi. ........ Merged revisions 406133 from
  10516. http://svn.asterisk.org/svn/asterisk/branches/12
  10517. 2014-01-21 21:08 +0000 [r406082] Walter Doekes <walter+asterisk@wjd.nu>
  10518. * main/manager.c, /, configs/manager.conf.sample: manager: Clarify
  10519. eventfilter documentation. Textual changes only. Review:
  10520. https://reviewboard.asterisk.org/r/3133/ ........ Merged
  10521. revisions 406079 from
  10522. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10523. revisions 406080 from
  10524. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10525. revisions 406081 from
  10526. http://svn.asterisk.org/svn/asterisk/branches/12
  10527. 2014-01-21 20:28 +0000 [r406006-406078] Kinsey Moore <kmoore@digium.com>
  10528. * channels/chan_mgcp.c, /: chan_mgcp: Enforce locking for oseq This
  10529. restricts direct usage of global oseq so that all accesses are
  10530. locked and threads are not racing to get oseq values that they
  10531. did not claim. This also fixes a build error in res_pktccops
  10532. under dev mode. (closes issue ASTERISK-23100) Reported by:
  10533. adomjan Patch by: adomjan ........ Merged revisions 406037 from
  10534. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10535. revisions 406038 from
  10536. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10537. revisions 406049 from
  10538. http://svn.asterisk.org/svn/asterisk/branches/12
  10539. * /, res/res_pjsip_outbound_registration.c, res/res_pjsip.c: PJSIP:
  10540. Handle headers in a list appropriately The PJSIP header parsing
  10541. function (pjsip_parse_hdr) can generate more than one header
  10542. instance from a single header field. These header instances exist
  10543. as a list attached to the returned header and must be handled
  10544. appropriately when they are added to a message or else only the
  10545. first header instance will be used. This changes the linked list
  10546. functions used in outbound proxy code to merge the lists
  10547. properly. ........ Merged revisions 406020 from
  10548. http://svn.asterisk.org/svn/asterisk/branches/12
  10549. * res/ari/resource_sounds.h, res/ari/resource_bridges.h,
  10550. res/ari/resource_device_states.h, res/ari/resource_mailboxes.h,
  10551. res/ari/resource_asterisk.h, rest-api/api-docs/channels.json,
  10552. res/ari/resource_applications.h, res/ari/resource_channels.c,
  10553. res/res_ari_playbacks.c, res/res_ari_sounds.c,
  10554. rest-api-templates/asterisk_processor.py,
  10555. res/ari/resource_channels.h, res/res_ari_bridges.c, /,
  10556. res/res_ari_device_states.c,
  10557. rest-api-templates/ari_resource.h.mustache,
  10558. res/res_ari_mailboxes.c, res/res_ari_asterisk.c,
  10559. res/res_ari_applications.c,
  10560. rest-api-templates/res_ari_resource.c.mustache,
  10561. rest-api-templates/body_parsing.mustache (added),
  10562. res/res_ari_channels.c, res/ari/resource_playbacks.h,
  10563. rest-api-templates/param_parsing.mustache: ARI: Support channel
  10564. variables in originate This adds back in support for specifying
  10565. channel variables during an originate without compromising the
  10566. ability to specify query parameters in the JSON body. This was
  10567. accomplished by generating the body-parsing code in a separate
  10568. function instead of being integrated with the URI query parameter
  10569. parsing code such that it could be called by paths with body
  10570. parameters. This is transparent to the user of the API and
  10571. prevents manual duplication of code or data structures. (closes
  10572. issue ASTERISK-23051) Review:
  10573. https://reviewboard.asterisk.org/r/3122/ Reported by: Matt Jordan
  10574. ........ Merged revisions 406003 from
  10575. http://svn.asterisk.org/svn/asterisk/branches/12
  10576. 2014-01-20 23:25 +0000 [r405985] Damien Wedhorn <voip@facts.com.au>
  10577. * /, channels/chan_skinny.c: Skinny: fix up handling of fragmented
  10578. packets. Bad offset in reading second or more fragment of skinny
  10579. packets. Fixed to offset by char (single byte) rather than size
  10580. of req. ........ Merged revisions 405982 from
  10581. http://svn.asterisk.org/svn/asterisk/branches/12
  10582. 2014-01-20 22:23 +0000 [r405947] Richard Mudgett <rmudgett@digium.com>
  10583. * channels/sig_pri.c, /: chan_dahdi/PRI: Suppress CONNECTED_LINE
  10584. updates when nothing in the udpate is valid. * Also simplified
  10585. some subddress handling code. (closes issue ASTERISK-23008)
  10586. Reported by: Michael Cargile ........ Merged revisions 405926
  10587. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  10588. Merged revisions 405927 from
  10589. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10590. revisions 405928 from
  10591. http://svn.asterisk.org/svn/asterisk/branches/12
  10592. 2014-01-20 21:56 +0000 [r405925] Damien Wedhorn <voip@facts.com.au>
  10593. * /, channels/chan_skinny.c: Skinny: fix up session logging.
  10594. Logging from the skinny session loop was providing some incorrect
  10595. reasons for exiting the loop. Cleaned up messages and handling so
  10596. correct reason displayed. ........ Merged revisions 405924 from
  10597. http://svn.asterisk.org/svn/asterisk/branches/12
  10598. 2014-01-20 18:18 +0000 [r405910] Jonathan Rose <jrose@digium.com>
  10599. * channels/chan_pjsip.c, /: chan_pjsip: Provide a means for
  10600. tracking device state when holding/unholding Previously PJSIP did
  10601. not track hold/unhold and it would always simply be 'inuse'. This
  10602. patch fixes that. review:
  10603. https://reviewboard.asterisk.org/r/3129/ ........ Merged
  10604. revisions 405908 from
  10605. http://svn.asterisk.org/svn/asterisk/branches/12
  10606. 2014-01-19 00:01 +0000 [r405894] Damien Wedhorn <voip@facts.com.au>
  10607. * /, channels/chan_skinny.c: Skinny: fix reversed device reset from
  10608. CLI. Existing code would do a full device restart when "skinny
  10609. reset device" was entered at the CLI and do a reset when "skinny
  10610. reset device restart" entered. ........ Merged revisions 405893
  10611. from http://svn.asterisk.org/svn/asterisk/branches/12
  10612. 2014-01-17 22:09 +0000 [r405878] Sean Bright <sean@malleable.com>
  10613. * /, channels/chan_sip.c: Make sure the maxptime attribute is added
  10614. to the correct offers. ........ Merged revisions 405877 from
  10615. http://svn.asterisk.org/svn/asterisk/branches/12
  10616. 2014-01-17 21:33 +0000 [r405862-405876] Scott Griepentrog <sgriepentrog@digium.com>
  10617. * main/format_pref.c, main/sorcery.c, main/frame.c, /,
  10618. include/asterisk/format_pref.h, res/res_pjsip_sdp_rtp.c: pjsip:
  10619. fix support for allow=all This change adds improvements to
  10620. support for allow=all in pjsip.conf so that it functions as
  10621. intended. Previously, the allow/disallow socery configuration
  10622. would set & clear codecs from the media.codecs and media.prefs
  10623. list, but if all was specified the prefs list was not updated.
  10624. Then a call would fail when create_outgoing_sdp_stream() created
  10625. an SDP with no audio codecs. A new function
  10626. ast_codec_pref_append_all() is provided to add all codecs to the
  10627. prefs list - only those not already on the list. This enables the
  10628. configuration to specify a codec preference, but still add all
  10629. codecs, and even then remove some codecs, as shown in this
  10630. example: allow = ulaw, alaw, all, !g729, !g723 Also, the display
  10631. order of allow in cli output is updated to match the
  10632. configuration by using prefs instead of caps when generating a
  10633. human readable string. Finally, a change to
  10634. create_outgoing_sdp_stream() skips a codec when it does not have
  10635. a payload code instead of the call failing. (closes issue
  10636. ASTERISK-23018) Reported by: xrobau Review:
  10637. https://reviewboard.asterisk.org/r/3131/ ........ Merged
  10638. revisions 405875 from
  10639. http://svn.asterisk.org/svn/asterisk/branches/12
  10640. * /, main/http.c: http: supported chunked Transfer-Encoding This
  10641. change implements support for HTTP Transfer-Encoding chunked in
  10642. both JSON and Form (post vars) body content. A new function
  10643. ast_http_get_contents() handles both regular and chunked mode
  10644. body, returning after the entire body is received. (closes issue
  10645. ASTERISK-23068) Reported by: Matt Jordan Review:
  10646. https://reviewboard.asterisk.org/r/3125/ ........ Merged
  10647. revisions 405861 from
  10648. http://svn.asterisk.org/svn/asterisk/branches/12
  10649. 2014-01-17 18:55 +0000 [r405778-405844] Rusty Newton <rnewton@digium.com>
  10650. * res/res_pjsip.c, /: Fixing some XML syntax issues with my
  10651. previous commit at r405777 for ASTERISK-23071 ........ Merged
  10652. revisions 405843 from
  10653. http://svn.asterisk.org/svn/asterisk/branches/12
  10654. * /, channels/chan_sip.c, doc/asterisk.8, main/features.c,
  10655. configs/sip.conf.sample, apps/app_queue.c, apps/app_transfer.c,
  10656. channels/chan_iax2.c: Documentation: doc fixes across various
  10657. parts of the code for ASTERISK issues 23061,23028,23046,23027
  10658. Fixes typos of "transfered" instead of "transferred" in various
  10659. code. Fixes incorrect gosub param help text for app_queue. Fixes
  10660. Asterisk man pages containing unquoted minus signs. Adds note
  10661. about the "textsupport" option in sip.conf.sample. (issue
  10662. ASTERISK-23061) (issue ASTERISK-23028) (issue ASTERISK-23046)
  10663. (issue ASTERISK-23027) (closes issue ASTERISK-23061) (closes
  10664. issue ASTERISK-23028) (closes issue ASTERISK-23046) (closes issue
  10665. ASTERISK-23027) Reported by: Eugene, Jeremy Laine, Denis
  10666. Pantsyrev Patches: transferred.patch uploaded by Jeremy Laine
  10667. (license 6561) hyphen.patch uploaded by Jeremy Laine (license
  10668. 6561) sip.conf.sample.patch uploaded by Eugene (license 6360)
  10669. ........ Merged revisions 405791 from
  10670. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10671. revisions 405792 from
  10672. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10673. revisions 405829 from
  10674. http://svn.asterisk.org/svn/asterisk/branches/12
  10675. * res/res_pjsip.c, /: res_pjsip: enhance documentation for
  10676. mailboxes options, for both endpoints and aors Made documentation
  10677. more explicit as to the use of the both options. (issue
  10678. ASTERISK-23071) (closes issue ASTERISK-23071) Reported by: Matt
  10679. Jordan ........ Merged revisions 405777 from
  10680. http://svn.asterisk.org/svn/asterisk/branches/12
  10681. 2014-01-17 14:17 +0000 [r405766] Walter Doekes <walter+asterisk@wjd.nu>
  10682. * res/res_musiconhold.c, CHANGES: Enable wide band audio in
  10683. musiconhold streams. Review:
  10684. https://reviewboard.asterisk.org/r/3112/
  10685. 2014-01-16 20:06 +0000 [r405747-405749] Kevin Harwell <kharwell@digium.com>
  10686. * res/res_pjsip/pjsip_options.c, /: res_pjsip: AOR option
  10687. qualify_frequency not respected on startup If an endpoint had
  10688. previously dynamically registered a contact and the contact
  10689. information was successfully stored in astdb then upon restart
  10690. the qualify notifications would not be sent out if the
  10691. qualify_frequency was set. This was due to the fact that only
  10692. permanent contacts were being checked and scheduled for qualifies
  10693. on startup. Modified the code to check and schedule all
  10694. registered contacts at startup. (closes issue ASTERISK-23062)
  10695. Reported by: Rusty Newton Review:
  10696. https://reviewboard.asterisk.org/r/3124/ ........ Merged
  10697. revisions 405748 from
  10698. http://svn.asterisk.org/svn/asterisk/branches/12
  10699. * main/manager.c, /: manager: Originate doesn't abort on failed
  10700. format_cap allocation action_originate responds to the remote
  10701. system with an error when cap==NULL, but doesn't return (abort
  10702. the originate). Patched to return. (closes issue ASTERISK-23034)
  10703. Reported by: Corey Farrell Patches: ASTERISK-23034.patch uploaded
  10704. by coreyfarrell (license 5909) ........ Merged revisions 405745
  10705. from http://svn.asterisk.org/svn/asterisk/branches/11 ........
  10706. Merged revisions 405746 from
  10707. http://svn.asterisk.org/svn/asterisk/branches/12
  10708. 2014-01-16 19:33 +0000 [r405744] Kinsey Moore <kmoore@digium.com>
  10709. * /, res/res_pjsip.c: PJSIP: Fix outbound OPTIONS support When path
  10710. support was added and contacts were made available during request
  10711. creation and transmission, the code path used by outbound qualify
  10712. support was not modified correctly and was causing request
  10713. creation to fail. This ensures that outbound request creation
  10714. with only a contact and no dialog, endpoint, or uri can succeed
  10715. which restores qualify support. Reported by: gtjoseph Reported
  10716. by: kharwell ........ Merged revisions 405743 from
  10717. http://svn.asterisk.org/svn/asterisk/branches/12
  10718. 2014-01-16 19:13 +0000 [r405644-405695] Kevin Harwell <kharwell@digium.com>
  10719. * /, res/res_fax.c, configs/res_fax.conf.sample: res_fax:
  10720. check_modem_rate() returned incorrect rate for V.27 According to
  10721. the new standard for V.27 and V.32 they are able to transmit at a
  10722. bit rate of 4,800 or 9,600. The check_mode_rate function needed
  10723. to be updated to reflect this. Also, because of this change the
  10724. default 'minrate' value was updated to be 4800. (closes issue
  10725. ASTERISK-22790) Reported by: Paolo Compagnini Patches:
  10726. res_fax.txt uploaded by looserouting (license 6548) ........
  10727. Merged revisions 405656 from
  10728. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10729. revisions 405693 from
  10730. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10731. revisions 405694 from
  10732. http://svn.asterisk.org/svn/asterisk/branches/12
  10733. * /, channels/chan_pjsip.c: chan_pjsip: initial device state on
  10734. endpoints is INVALID When endpoints get loaded their device state
  10735. gets set to 'INVALID' because the channel driver has not been
  10736. loaded yet. Fixed by updating the device state for every endpoint
  10737. upon load of the channel driver. (closes issue ASTERISK-23065)
  10738. Reported by: Rusty Newton Review:
  10739. https://reviewboard.asterisk.org/r/3123/ ........ Merged
  10740. revisions 405643 from
  10741. http://svn.asterisk.org/svn/asterisk/branches/12
  10742. 2014-01-15 16:51 +0000 [r405586-405589] Jonathan Rose <jrose@digium.com>
  10743. * CHANGES: Make 12 - 12.1 CHANGES log the same as in 12
  10744. * CHANGES, /: Include CHANGES info for r405553 ........ Merged
  10745. revisions 405585 from
  10746. http://svn.asterisk.org/svn/asterisk/branches/12
  10747. 2014-01-15 16:36 +0000 [r405584] Joshua Colp <jcolp@digium.com>
  10748. * /, cel/cel_manager.c: cel_manager: Don't crash if configuration
  10749. file is invalid. The cel_manager module did not properly handle
  10750. the case where the configuration file was invalid. The module
  10751. will now output a warning message and disable itself if this
  10752. occurs. Reported by: Bryan Walters ........ Merged revisions
  10753. 405581 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  10754. ........ Merged revisions 405582 from
  10755. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10756. revisions 405583 from
  10757. http://svn.asterisk.org/svn/asterisk/branches/12
  10758. 2014-01-15 13:16 +0000 [r405566] Kinsey Moore <kmoore@digium.com>
  10759. * res/res_pjsip/location.c, res/res_pjsip_outbound_registration.c,
  10760. res/res_pjsip_path.c (added), res/res_pjsip_mwi.c,
  10761. res/res_pjsip/pjsip_distributor.c, res/res_pjsip_diversion.c,
  10762. channels/chan_pjsip.c, res/res_pjsip_registrar.c,
  10763. res/res_pjsip_refer.c, include/asterisk/res_pjsip.h,
  10764. include/asterisk/res_pjsip_session.h, res/res_pjsip_notify.c, /,
  10765. res/res_pjsip_messaging.c, res/res_pjsip_caller_id.c,
  10766. res/res_pjsip_t38.c, res/res_pjsip.c,
  10767. res/res_pjsip/pjsip_options.c, res/res_pjsip_nat.c,
  10768. res/res_pjsip_session.c,
  10769. contrib/ast-db-manage/config/versions/2fc7930b41b3_add_pjsip_endpoint_options_for_12_1.py
  10770. (added), res/res_pjsip_header_funcs.c: PJSIP: Add Path header
  10771. support This adds Path support to chan_pjsip in res_pjsip_path.c
  10772. with minimal additions in res_pjsip_registrar.c to store the path
  10773. and additions in res_pjsip_outbound_registration.c to enable
  10774. advertisement of path support to registrars and intervening
  10775. proxies. Path information is stored on contacts and is enabled
  10776. via Address of Record (AoRs) and Registration configuration
  10777. sections. While adding path support, it became necessary to be
  10778. able to add SIP supplements that handled messages outside of
  10779. sessions, so a framework for handling these types of hooks was
  10780. added in parallel to the already-existing session supplements and
  10781. several senders of out-of-dialog requests were refactored as a
  10782. result. (closes issue ASTERISK-21084) Review:
  10783. https://reviewboard.asterisk.org/r/3050/ ........ Merged
  10784. revisions 405565 from
  10785. http://svn.asterisk.org/svn/asterisk/branches/12
  10786. 2014-01-14 23:44 +0000 [r405554] Jonathan Rose <jrose@digium.com>
  10787. * res/res_stasis_mailbox.exports.in (added),
  10788. res/ari/ari_model_validators.h, rest-api/api-docs/mailboxes.json
  10789. (added), include/asterisk/stasis_app_mailbox.h (added),
  10790. res/ari/resource_mailboxes.c (added), /, res/ari.make,
  10791. res/res_ari_mailboxes.c (added), res/ari/resource_mailboxes.h
  10792. (added), res/res_stasis_mailbox.c (added),
  10793. rest-api/resources.json, res/ari/ari_model_validators.c: ARI: Add
  10794. mailboxes resource for controlling and polling external MWI Adds
  10795. the following AMI commands: PUT mailboxes/mailboxName modifies
  10796. mailbox state and implicitly creates new mailboxes GET
  10797. mailboxes/mailboxName retrieves a JSON representation of a single
  10798. mailbox if it exists GET mailboxes retrieves a JSON array of all
  10799. mailboxes DELETE mailbox/mailboxName deletes a mailbox Note that
  10800. res_mwi_external must be loaded for these functions to actually
  10801. do anything. Review: https://reviewboard.asterisk.org/r/3117/
  10802. ........ Merged revisions 405553 from
  10803. http://svn.asterisk.org/svn/asterisk/branches/12
  10804. 2014-01-14 21:46 +0000 [r405542] Richard Mudgett <rmudgett@digium.com>
  10805. * main/strings.c, /: string container: Remove unnecessary RAII_VAR
  10806. usage and string object lock. ........ Merged revisions 405541
  10807. from http://svn.asterisk.org/svn/asterisk/branches/12
  10808. 2014-01-14 18:15 +0000 [r405437] Scott Griepentrog <sgriepentrog@digium.com>
  10809. * /, channels/chan_sip.c: chan_sip: fix Local From tag on outbound
  10810. register regression In ASTERISK-12117, an improvement to insure
  10811. consistant local from tags on outbound registrations resulted in
  10812. an undesirable behavior - caused by leftover unexpired sip_pvt
  10813. dialogs (with the previous cseq number), resulting in many
  10814. uncessary REGISTER requests. Instead of significant rework of
  10815. transmit_register(), this change deletes the dialogs after a 200
  10816. OK response indiciating a successful registration, keeping the
  10817. old dialogs from interfering with normal operation. (closes issue
  10818. ASTERISK-22946) Reported by: Stephan Eisvogel Review:
  10819. https://reviewboard.asterisk.org/r/3109/ ........ Merged
  10820. revisions 405433 from
  10821. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  10822. revisions 405434 from
  10823. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10824. revisions 405435 from
  10825. http://svn.asterisk.org/svn/asterisk/branches/12
  10826. 2014-01-14 18:14 +0000 [r405436] Richard Mudgett <rmudgett@digium.com>
  10827. * apps/app_verbose.c, main/asterisk.c, configs/logger.conf.sample,
  10828. main/cli.c, include/asterisk/logger.h, main/pbx.c,
  10829. main/manager.c, /, funcs/func_timeout.c, apps/app_dumpchan.c,
  10830. main/logger.c, UPGRADE.txt: verbosity: Fix performance of console
  10831. verbose messages. The per console verbose level feature as
  10832. previously implemented caused a large performance penalty. The
  10833. fix required some minor incompatibilities if the new rasterisk is
  10834. used to connect to an earlier version. If the new rasterisk
  10835. connects to an older Asterisk version then the root console
  10836. verbose level is always affected by the "core set verbose"
  10837. command of the remote console even though it may appear to only
  10838. affect the current console. If an older version of rasterisk
  10839. connects to the new version then the "core set verbose" command
  10840. will have no effect. * Fixed the verbose performance by not
  10841. generating a verbose message if nothing is going to use it and
  10842. then filtered any generated verbose messages before actually
  10843. sending them to the remote consoles. * Split the "core set debug"
  10844. and "core set verbose" CLI commands to remove the per module
  10845. verbose support that cannot work with the per console verbose
  10846. level. * Added a silent option to the "core set verbose" command.
  10847. * Fixed "core set debug off" tab completion. * Made "core show
  10848. settings" list the current console verbosity in addition to the
  10849. root console verbosity. * Changed the default verbose level of
  10850. the 'verbose' setting in the logger.conf [logfiles] section. The
  10851. default is now to once again follow the current root console
  10852. level. As a result, using the AMI Command action with "core set
  10853. verbose" could again set the root console verbose level and
  10854. affect the verbose level logged. (closes issue AST-1252) Reported
  10855. by: Guenther Kelleter Review:
  10856. https://reviewboard.asterisk.org/r/3114/ ........ Merged
  10857. revisions 405431 from
  10858. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10859. revisions 405432 from
  10860. http://svn.asterisk.org/svn/asterisk/branches/12
  10861. 2014-01-14 16:43 +0000 [r405420] Mark Michelson <mmichelson@digium.com>
  10862. * res/res_pjsip/pjsip_distributor.c: Fix erroneous behavior when
  10863. sending auth rejection to artificial endpoint. We were not
  10864. including an authentication challenge when sending a 401 response
  10865. to unmatched endpoints. This was due to the conversion to use a
  10866. vector for authentication section names on an endpoint. The
  10867. vector for artificial endpoints was empty, resulting in the
  10868. challenge being sent back containing no challenges. This is
  10869. worked around by placing a bogus value in the artificial
  10870. endpoint's auth vector. This value is never looked up by
  10871. anything, since they instead will directly call
  10872. ast_sip_get_artificial_auth().
  10873. 2014-01-14 03:27 +0000 [r405369] Damien Wedhorn <voip@facts.com.au>
  10874. * /, channels/chan_skinny.c: Skinny: do not add call to missed
  10875. calls list if answered elsewhere. Patch updates skinny devices
  10876. with a SKINNY_CONNECTED callstate if an inbound ringing or
  10877. callwaiting call is answered elsewhere. ........ Merged revisions
  10878. 405367 from http://svn.asterisk.org/svn/asterisk/branches/12
  10879. 2014-01-13 13:34 +0000 [r405339] Kinsey Moore <kmoore@digium.com>
  10880. * /, res/res_pjsip/pjsip_cli.c: res_pjsip: Fix CLI tab completion
  10881. issues This fixes several issues with the new res_pjsip CLI tab
  10882. completion such as output of headers during tab completion and
  10883. being able to tab-complete more items than the code actually
  10884. handled (further items would simply be ignored). (closes issue
  10885. ASTERISK-23081) Review: https://reviewboard.asterisk.org/r/3115/
  10886. Reported by: xrobau ........ Merged revisions 405338 from
  10887. http://svn.asterisk.org/svn/asterisk/branches/12
  10888. 2014-01-12 22:24 +0000 [r405326] Joshua Colp <jcolp@digium.com>
  10889. * res/ari/resource_playbacks.c, res/ari/resource_channels.c,
  10890. include/asterisk/ari.h, res/ari/resource_bridges.c,
  10891. res/ari/resource_recordings.c, res/ari/resource_device_states.c,
  10892. res/res_ari.c, res/ari/resource_endpoints.c, /,
  10893. res/ari/resource_applications.c: res_ari: Fix various memory
  10894. leaks. This change fixes a few memory leaks that were found based
  10895. on a mailing list post. 1. Some JSON response messages were never
  10896. freed. This was caused by the documentation stating that message
  10897. references were stolen when in reality they were not. The code
  10898. now follows the documentation and usage has been updated. 2. HTTP
  10899. response headers were never freed. 3. The variable list for
  10900. wildcards paths was never freed. (closes issue ASTERISK-23128)
  10901. Reported by: Kenneth Watson (on list) Review:
  10902. https://reviewboard.asterisk.org/r/3119/ ........ Merged
  10903. revisions 405325 from
  10904. http://svn.asterisk.org/svn/asterisk/branches/12
  10905. 2014-01-12 22:13 +0000 [r405313-405314] Matthew Jordan <mjordan@digium.com>
  10906. * apps/app_forkcdr.c, /, funcs/func_cdr.c, include/asterisk/cdr.h,
  10907. apps/app_cdr.c, main/cdr.c: CDRs: Synchronize dialplan
  10908. applications that manipulate CDRs with the engine In
  10909. https://reviewboard.asterisk.org/r/3057/, applications and
  10910. functions that manipulate CDRs were made to interact over Stasis.
  10911. This was done to synchronize manipulations of CDRs from the
  10912. dialplan with the updates the engine itself receives over the
  10913. message bus. This change rested on a faulty premise: that
  10914. messages published to the CDR topic or to a topic that forwards
  10915. to the CDR topic are synchronized with the messages handled by
  10916. the CDR topic subscription in the CDR engine. This is not the
  10917. case. There is no ordering guaranteed for two messages published
  10918. to the same topic; ordering is only guaranteed if a message is
  10919. published to the same subscriber. Stasis was modified in r405311
  10920. to allow a publisher to synchronize on the subscriber. This patch
  10921. uses that API to synchronize the CDR publishers with the CDR
  10922. engine message router, which maintains the overall topic
  10923. subscription. (closes issue ASTERISK-22884) Reported by: Matt
  10924. Jordan Review: https://reviewboard.asterisk.org/r/3099/ ........
  10925. Merged revisions 405312 from
  10926. http://svn.asterisk.org/svn/asterisk/branches/12
  10927. * main/stasis.c, main/stasis_message_router.c, /,
  10928. include/asterisk/stasis.h,
  10929. include/asterisk/stasis_message_router.h, tests/test_stasis.c:
  10930. stasis: Add methods to allow for synchronous publishing to
  10931. subscriber This patch adds an API call to Stasis that allows a
  10932. publisher to publish a stasis message that will not return until
  10933. a specific subscriber handles the message. Since a subscriber can
  10934. have their own forwarding topic which orders messages from many
  10935. topics, this allows a publisher who knows of that subscriber to
  10936. synchronize to that subscriber regardless of the forwarding
  10937. relationships between topics. This is of particular use for
  10938. dialplan applications that need to synchronize on a particular
  10939. subscriber's handling of a message. (issue ASTERISK-22884)
  10940. Reported by: Matt Jordan Review:
  10941. https://reviewboard.asterisk.org/r/3099/ ........ Merged
  10942. revisions 405311 from
  10943. http://svn.asterisk.org/svn/asterisk/branches/12
  10944. 2014-01-10 20:00 +0000 [r405299] Mark Michelson <mmichelson@digium.com>
  10945. * /, res/res_pjsip/security_events.c: Print "<unknown>" for
  10946. artificial endpoint in PJSIP security events. Previously, this
  10947. printed a UUID, which was not very clear when dealing with an
  10948. artificial endpoint. Review:
  10949. https://reviewboard.asterisk.org/r/3113 ........ Merged revisions
  10950. 405298 from http://svn.asterisk.org/svn/asterisk/branches/12
  10951. 2014-01-10 18:17 +0000 [r405284] Richard Mudgett <rmudgett@digium.com>
  10952. * /, main/logger.c: Logging callid: Fix some sizeof() references
  10953. per coding guidelines. ........ Merged revisions 405281 from
  10954. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  10955. revisions 405282 from
  10956. http://svn.asterisk.org/svn/asterisk/branches/12
  10957. 2014-01-09 23:52 +0000 [r405270] Jonathan Rose <jrose@digium.com>
  10958. * res/res_pjsip_session.c: PJSIP: Add unhold on reinvite without
  10959. SDP behavior Review: https://reviewboard.asterisk.org/r/3106/
  10960. 2014-01-09 23:50 +0000 [r405269] Damien Wedhorn <voip@facts.com.au>
  10961. * channels/chan_dahdi.c, /: Fix chan_dahdi copile issue in
  10962. dev-mode. Error "unused variable i in dahdi_create_channel_range"
  10963. when compiling in dev-mode. Small restructure to
  10964. dahdi_create_channel_range to move the for(x) loop and int i,x to
  10965. a block within the IFDEF. ........ Merged revisions 405268 from
  10966. http://svn.asterisk.org/svn/asterisk/branches/12
  10967. 2014-01-09 23:39 +0000 [r405267] Kevin Harwell <kharwell@digium.com>
  10968. * res/res_pjsip.c, /, res/res_pjsip_messaging.c:
  10969. res_pjsip_messaging: potential for field values in from/to
  10970. headers to be missing Added in ability to specify display name
  10971. format ("name" <sip:name@ipaddr:port>) for a given URI and made
  10972. sure it was fully propagated to the outgoing message. Also made
  10973. it so outoing messages in res_pjsip always send as "sip:".
  10974. (closes issue ASTERISK-22924) Reported by: Anthony Messina
  10975. Review: https://reviewboard.asterisk.org/r/3094/ ........ Merged
  10976. revisions 405266 from
  10977. http://svn.asterisk.org/svn/asterisk/branches/12
  10978. 2014-01-09 20:34 +0000 [r405254] Kinsey Moore <kmoore@digium.com>
  10979. * main/astobj2.c, res/res_pjsip_session.c, /,
  10980. include/asterisk/astobj2.h: astobj2: Correct ao2_iterator opacity
  10981. violations This corrects the ao2_iterator opacity violations in
  10982. res_pjsip_session.c by adding a global function to get the number
  10983. of elements inside the container hidden behind the iterator.
  10984. (closes issue ASTERISK-23053) Review:
  10985. https://reviewboard.asterisk.org/r/3111/ Reported by: Richard
  10986. Mudgett ........ Merged revisions 405253 from
  10987. http://svn.asterisk.org/svn/asterisk/branches/12
  10988. 2014-01-09 16:52 +0000 [r405236] Kevin Harwell <kharwell@digium.com>
  10989. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fails to resume
  10990. WebRTC call from hold In ast_rtp_ice_start if the ice session
  10991. create check list failed, start check was never initiated and
  10992. ice_started was never set to true. Upon re-entering the function
  10993. (for instance, [un]hold) it would try to create the check list
  10994. again with duplicate remote candidates. Fixed so that if the
  10995. create check list fails the necessary data structures are
  10996. properly re-initialized for any subsequent retries. Note, it was
  10997. decided to not stop ice support (by calling ast_rtp_ice_stop) on
  10998. a check list failure because it possible things might still work.
  10999. However, a debug message was added to help with any future
  11000. troubleshooting. (closes issue ASTERISK-22911) Reported by: Vytis
  11001. Valentinavičius Patches: works_on_my_machine.patch uploaded by
  11002. xytis (license 6558) ........ Merged revisions 405234 from
  11003. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11004. revisions 405235 from
  11005. http://svn.asterisk.org/svn/asterisk/branches/12
  11006. 2014-01-09 15:50 +0000 [r405217] Matthew Jordan <mjordan@digium.com>
  11007. * /, apps/app_confbridge.c,
  11008. apps/confbridge/conf_state_multi_marked.c: app_confbridge: Fix
  11009. crash caused when waitmarked/marked users leave together When
  11010. waitmarked users join a ConfBridge, the conference state is
  11011. transitioned from EMPTY -> INACTIVE. In this state, the users are
  11012. maintined in a waiting users list. When a marked user joins, the
  11013. ConfBridge conference transitions from INACTIVE -> MULTI_MARKED,
  11014. and all users are put onto the active list of users. This process
  11015. works correctly. When the marked user leaves, if they are the
  11016. last marked user, the MULTI_MARKED state does the following: (1)
  11017. It plays back a message to the bridge stating that the leader has
  11018. left the conference. This requires an unlocking of the bridge.
  11019. (2) It moves waitmarked users back to the waiting list (3) It
  11020. transitions to the appropriate state: in this case, INACTIVE
  11021. However, because it plays the prompt back to the bridge before
  11022. moving the users and before finishing the state transition, this
  11023. creates a race condition: with the bridge unlocked, waitmarked
  11024. users who leave the conference (or are kicked from it) can cause
  11025. a state transition of the bridge to another state before the
  11026. conference is transitioned to the INACTIVE state. This causes the
  11027. state machine to get a bit wonky, often leading to a crash when
  11028. the MULTI_MARKED state attempts to conclude its processing. This
  11029. patch fixes this problem: (1) It prevents kicked users from being
  11030. kicked again. That's just a nicety. (2) More importantly, it
  11031. fixes the race condition by only playing the prompt once the
  11032. state has transitioned correctly to INACTIVE. If waitmarked users
  11033. sneak out during the prompt being played, no harm no foul.
  11034. Review: https://reviewboard.asterisk.org/r/3108/ Note that the
  11035. patch committed here is essentially the same as uploaded by Simon
  11036. Moxon on ASTERISK-22740, with the addition of the double kick
  11037. prevention. (closes issue AST-1258) Reported by: Steve Pitts
  11038. (closes issue ASTERISK-22740) Reported by: Simon Moxon patches:
  11039. ASTERISK-22740.diff uploaded by Simon Moxon (license 6546)
  11040. ........ Merged revisions 405215 from
  11041. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11042. revisions 405216 from
  11043. http://svn.asterisk.org/svn/asterisk/branches/12
  11044. 2014-01-09 14:15 +0000 [r405163] Walter Doekes <walter+asterisk@wjd.nu>
  11045. * /, apps/app_dumpchan.c: "Minimun" typo. ........ Merged revisions
  11046. 405160 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  11047. ........ Merged revisions 405161 from
  11048. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11049. revisions 405162 from
  11050. http://svn.asterisk.org/svn/asterisk/branches/12
  11051. 2014-01-08 17:23 +0000 [r405144] Mark Michelson <mmichelson@digium.com>
  11052. * /, res/res_pjsip/security_events.c: Use proper case for checking
  11053. if digest authentication is used. ........ Merged revisions
  11054. 405131 from http://svn.asterisk.org/svn/asterisk/branches/12
  11055. 2014-01-08 16:34 +0000 [r405129-405130] Kinsey Moore <kmoore@digium.com>
  11056. * /, configure, configure.ac, pbx/pbx_lua.c: pbx_lua: Add support
  11057. for Lua 5.2 This adds support for Lua 5.2 in pbx_lua which is
  11058. available on newer operating systems. (closes issue
  11059. ASTERISK-23011) Review: https://reviewboard.asterisk.org/r/3075/
  11060. Reported by: George Joseph Patch by: George Joseph ........
  11061. Merged revisions 405090 from
  11062. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11063. revisions 405091 from
  11064. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11065. revisions 405124 from
  11066. http://svn.asterisk.org/svn/asterisk/branches/12
  11067. * /, channels/chan_sip.c: Add the missing part of r400140 When the
  11068. patch to add retry-on-forbidden-response was committed, part of
  11069. the patch for chan_sip was not committed which caused the feature
  11070. to be entirely nonfunctional. This corrects the code in question.
  11071. (closes issue ASTERISK-17138) Review:
  11072. https://reviewboard.asterisk.org/r/2874 ........ Merged revisions
  11073. 405033 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  11074. ........ Merged revisions 405081 from
  11075. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11076. revisions 405083 from
  11077. http://svn.asterisk.org/svn/asterisk/branches/12
  11078. 2014-01-07 19:56 +0000 [r405020-405035] Joshua Colp <jcolp@digium.com>
  11079. * /, res/res_pjsip_acl.c: res_pjsip_acl: Fix another case of
  11080. assuming a contact will always contain a URI. ........ Merged
  11081. revisions 405034 from
  11082. http://svn.asterisk.org/svn/asterisk/branches/12
  11083. * /, res/res_pjsip_nat.c: res_pjsip_nat: Don't assume a Contact
  11084. header will always contain a URI. If the 'rewrite_contact' option
  11085. was enabled and a Contact header was received which contained a
  11086. '*' a crash would occur. This change makes the res_pjsip_nat
  11087. module ignore the Contact header if it contains only a '*'.
  11088. (closes issue ASTERISK-23101) Reported by: Matt Jordan ........
  11089. Merged revisions 405019 from
  11090. http://svn.asterisk.org/svn/asterisk/branches/12
  11091. 2014-01-06 21:55 +0000 [r404953-405007] Richard Mudgett <rmudgett@digium.com>
  11092. * apps/app_voicemail.c, /: app_voicemail: Explicitly set
  11093. defaultenabled=yes ........ Merged revisions 405006 from
  11094. http://svn.asterisk.org/svn/asterisk/branches/12
  11095. * /, res/res_mwi_external_ami.c (added): External MWI AMI support.
  11096. The external MWI AMI interface provides a thin wrapper around the
  11097. core external MWI resource. The resource adds the following AMI
  11098. actions: MWIGet, MWIDelete, and MWIUpdate. (closes issue AFS-46)
  11099. Review: https://reviewboard.asterisk.org/r/3061/ ........ Merged
  11100. revisions 404954 from
  11101. http://svn.asterisk.org/svn/asterisk/branches/12
  11102. * /, res/res_mwi_external.c (added), configs/sorcery.conf.sample,
  11103. include/asterisk/res_mwi_external.h (added),
  11104. res/res_mwi_external.exports.in (added), apps/app_voicemail.c:
  11105. External MWI core support. * The core external MWI resource
  11106. provides for MWI message counts persistence using sorcery. With
  11107. sorcery, the user is able to configure which sorcery wizzard
  11108. backend to use if the default astdb is not desired. * The core
  11109. external MWI resoruce provides some debugging CLI commands
  11110. enabled by defining MWI_DEBUG_CLI. The debugging CLI commands
  11111. are: "mwi delete all", "mwi delete like <regex>", "mwi delete
  11112. mailbox <mailbox>", "mwi list all", "mwi list like <regex>", "mwi
  11113. show mailbox <mailbox>", and "mwi update mailbox <mailbox> [<new>
  11114. [<old>]]". (closes issue AFS-43) Review:
  11115. https://reviewboard.asterisk.org/r/3061/ ........ Merged
  11116. revisions 404952 from
  11117. http://svn.asterisk.org/svn/asterisk/branches/12
  11118. 2014-01-05 16:01 +0000 [r404924-404936] Joshua Colp <jcolp@digium.com>
  11119. * /, res/res_pjsip_outbound_registration.c:
  11120. res_pjsip_outbound_registration: Don't assume that a registration
  11121. client will always exist. ........ Merged revisions 404935 from
  11122. http://svn.asterisk.org/svn/asterisk/branches/12
  11123. * /, res/res_pjsip_outbound_registration.c:
  11124. res_pjsip_outbound_registration: Create registration client in pj
  11125. thread. Depending on which threading was loading the outbound
  11126. registration it was possible for the registration client to be
  11127. allocated outside of a pj thread. This change moves the creation
  11128. inside the synchronous task where it is guaranteed it will occur
  11129. in a pj thread. Reported by: Rob Thomas ........ Merged revisions
  11130. 404923 from http://svn.asterisk.org/svn/asterisk/branches/12
  11131. 2014-01-04 10:52 +0000 [r404912] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  11132. * main/asterisk.c, /: asterisk.c: suppress live_dangerously warning
  11133. on rasterisk Even since the fixes of AST-2013-007, Asterisk
  11134. prints the following warning on startup if the user decided to
  11135. live dangerously: Privilege escalation protection disabled! See
  11136. https://wiki.asterisk.org/wiki/x/1gKfAQ for more details. This
  11137. message is intended for the logs and interactive startup. No need
  11138. for it to appear on a remote console. This commit removes it from
  11139. there. (closes issue ASTERISK-23084) Review:
  11140. https://reviewboard.asterisk.org/r/3101/ ........ Merged
  11141. revisions 404861 from
  11142. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11143. revisions 404888 from
  11144. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11145. revisions 404911 from
  11146. http://svn.asterisk.org/svn/asterisk/branches/12
  11147. 2014-01-03 22:00 +0000 [r404860] Kevin Harwell <kharwell@digium.com>
  11148. * cel/cel_pgsql.c, /: cel_pgsql: module not correctly reloading
  11149. Upon reload the module unconditionally "unloaded" the module
  11150. (freeing memory and setting pointers to NULL) and then when
  11151. attempting a "load" if the config file had not changed then
  11152. nothing would be reinitialized. By moving the "unload" to occur
  11153. conditionally (reload only) after an attempted configuration
  11154. load, but before module "loading" alleviates the issue. The
  11155. module now loads/unloads/reloads correctly. (closes issue
  11156. ASTERISK-22871) Reported by: Matteo ........ Merged revisions
  11157. 404857 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  11158. ........ Merged revisions 404858 from
  11159. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11160. revisions 404859 from
  11161. http://svn.asterisk.org/svn/asterisk/branches/12
  11162. 2014-01-03 21:45 +0000 [r404844-404856] Matthew Jordan <mjordan@digium.com>
  11163. * /, res/res_pjsip_logger.c: res_pjsip_logger: Add the
  11164. ASTERISK_FILE_VERSION macro Registering yourself with the
  11165. Asterisk core is the nice thing to do, even when you're a logging
  11166. module. ........ Merged revisions 404855 from
  11167. http://svn.asterisk.org/svn/asterisk/branches/12
  11168. * /, res/res_pjsip_authenticator_digest.c, tests/test_utils.c:
  11169. res_pjsip_authenticator_digest: Fix md5 hash buffer An md5 hash
  11170. is 32 bytes long. The char buffer must be at least 33 bytes to
  11171. avoid clobbering of the stack. This patch also fixes a potential
  11172. clobbering in test_utils.c. Thanks to Andrew Nagy for reporting
  11173. and testing this out in #asterisk-dev Reported by: Andrew Nagy
  11174. Tested by: Andrew Nagy ........ Merged revisions 404843 from
  11175. http://svn.asterisk.org/svn/asterisk/branches/12
  11176. 2014-01-03 20:02 +0000 [r404787-404832] Kevin Harwell <kharwell@digium.com>
  11177. * main/manager.c: manager: UserEvent including action on output AMI
  11178. action UserEvent event response would include the action header
  11179. in its keyvalue pairs list. Adjusted the start of the header loop
  11180. to skip over the action part. (closes issue ASTERISK-22899)
  11181. Reported by: outtolunc Patches:
  11182. svn_manager.c.skip_action.diff.txt uploaded by outtolunc (license
  11183. 5198)
  11184. * channels/chan_dahdi.c, /: chan_dahdi: dahdi show channels slices
  11185. PRI channel dnid on output dahdi show channels output slices the
  11186. callerid (which is dnid copied over on PRI channels). If the
  11187. channel naming structures look like: 'DAHDI/i1/1408409XXXX-6'
  11188. then the output slices 1408409XXXX down to 1408409XXX. This patch
  11189. just opens it up to 15 chars so you can see the whole thing.
  11190. (closes issue ASTERISK-22918) Reported by: outtolunc Patches:
  11191. svn_chan_dahdi.c.format12_15.diff.txt uploaded by outtolunc
  11192. (license 5198) ........ Merged revisions 404784 from
  11193. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11194. revisions 404785 from
  11195. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11196. revisions 404786 from
  11197. http://svn.asterisk.org/svn/asterisk/branches/12
  11198. 2014-01-03 18:33 +0000 [r404783] Richard Mudgett <rmudgett@digium.com>
  11199. * tests/test_stasis.c, /: test_stasis.c: Fix ref leak in normal
  11200. execution path. ........ Merged revisions 404764 from
  11201. http://svn.asterisk.org/svn/asterisk/branches/12
  11202. 2014-01-03 18:31 +0000 [r404782] Kevin Harwell <kharwell@digium.com>
  11203. * /, apps/app_meetme.c: app_meetme: compiler warning Fixed a
  11204. compiler warning (errors in 'dev-mode') given by gcc version
  11205. 4.8.1. The one in app_meetme involved the
  11206. 'sizeof-pointer-memaccess' (see:
  11207. http://gcc.gnu.org/gcc-4.8/porting_to.html) warning. Fixed so it
  11208. would no longer issue a warning and can compile again in
  11209. 'dev-mode'. Review: https://reviewboard.asterisk.org/r/3098/
  11210. ........ Merged revisions 404742 from
  11211. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11212. revisions 404773 from
  11213. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11214. revisions 404781 from
  11215. http://svn.asterisk.org/svn/asterisk/branches/12
  11216. 2014-01-03 17:27 +0000 [r404726-404738] Joshua Colp <jcolp@digium.com>
  11217. * res/res_pjsip/pjsip_configuration.c, /, res/res_pjsip/location.c:
  11218. res_pjsip: Ensure more URI validation happens in pj threads.
  11219. ........ Merged revisions 404737 from
  11220. http://svn.asterisk.org/svn/asterisk/branches/12
  11221. * /, res/res_pjsip_outbound_registration.c:
  11222. res_pjsip_outbound_registration: Ensure URI validation happens in
  11223. a pjlib thread. This change moves outbound registration URI
  11224. validation into the task executed within a pjlib thread. Reported
  11225. by: Andrew Nagy ........ Merged revisions 404725 from
  11226. http://svn.asterisk.org/svn/asterisk/branches/12
  11227. 2014-01-02 19:38 +0000 [r404677] Scott Griepentrog <sgriepentrog@digium.com>
  11228. * /, funcs/func_strings.c: func_strings: use memmove to prevent
  11229. overlapping memory on strcpy When calling REPLACE() with an empty
  11230. replace-char argument, strcpy is used to overwrite the the
  11231. matching <find-char>. However as the src and dest arguments to
  11232. strcpy must not overlap, it causes other parts of the string to
  11233. be overwritten with adjacent characters and the result is
  11234. mangled. Patch replaces call to strcpy with memmove and adds a
  11235. test suite case for REPLACE. (closes issue ASTERISK-22910)
  11236. Reported by: Gareth Palmer Review:
  11237. https://reviewboard.asterisk.org/r/3083/ Patches:
  11238. func_strings.patch uploaded by Gareth Palmer (license 5169)
  11239. ........ Merged revisions 404674 from
  11240. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11241. revisions 404675 from
  11242. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11243. revisions 404676 from
  11244. http://svn.asterisk.org/svn/asterisk/branches/12
  11245. 2014-01-02 19:08 +0000 [r404664] Kevin Harwell <kharwell@digium.com>
  11246. * channels/chan_pjsip.c, include/asterisk/res_pjsip.h, /,
  11247. configs/pjsip.conf.sample, res/res_pjsip/pjsip_configuration.c,
  11248. CHANGES, res/res_pjsip.c: res_pjsip: add 'set_var' support on
  11249. endpoints Added a new 'set_var' option for ast_sip_endpoint(s).
  11250. For each variable specified that variable gets set upon creation
  11251. of a pjsip channel involving the endpoint. (closes issue
  11252. ASTERISK-22868) Reported by: Joshua Colp Review:
  11253. https://reviewboard.asterisk.org/r/3095/ ........ Merged
  11254. revisions 404663 from
  11255. http://svn.asterisk.org/svn/asterisk/branches/12
  11256. 2013-12-31 22:51 +0000 [r404620-404653] Joshua Colp <jcolp@digium.com>
  11257. * channels/chan_pjsip.c, res/res_pjsip_session.c, /: chan_pjsip:
  11258. Handle hanging up before calling. Channel creation in Asterisk is
  11259. broken up into two steps: requesting and calling. In some cases a
  11260. channel may be requested but never called. This happens in the
  11261. ChanIsAvail dialplan application for determining if something is
  11262. reachable or not. The PJSIP channel driver did not take this
  11263. situation into account and attempted to end a session that was
  11264. never called out on. The code now checks the session state to
  11265. determine if the session has been called out on and if not
  11266. terminates it instead of ending it. (closes issue ASTERISK-23074)
  11267. Reported by: Kilburn ........ Merged revisions 404652 from
  11268. http://svn.asterisk.org/svn/asterisk/branches/12
  11269. * /, res/res_pjsip_endpoint_identifier_ip.c:
  11270. res_pjsip_endpoint_identifier_ip: Accept hostnames in the 'match'
  11271. field. Hostnames specified in the 'match' field will be resolved
  11272. and all addresses returned. Each address will be added to the
  11273. endpoint identifier for the matching process. Reported by: Rob
  11274. Thomas ........ Merged revisions 404613 from
  11275. http://svn.asterisk.org/svn/asterisk/branches/12
  11276. 2013-12-31 21:39 +0000 [r404606] Kevin Harwell <kharwell@digium.com>
  11277. * cel/cel_pgsql.c, /: cel_pgsql: deadlock on unload and
  11278. core_event_dispatcher A deadlock can happen between a thread
  11279. unloading or reloading the cel_pgsql module and the
  11280. core_event_dispatcher taskprocessor thread. Description of what
  11281. is happening: Thread 1 (for example, a netconsole thread): a
  11282. "module reload cel_pgsql" is launched the thread enter the
  11283. "my_unload_module" function (cel_pgsql.c) the thread acquire the
  11284. write lock on psql_columns the thread enter the
  11285. "ast_event_unsubscribe" function (event.c) the thread try to
  11286. acquire the write lock on ast_event_subs[sub->type] Thread 2
  11287. (core_event_dispatcher taskprocessor thread): the taskprocessor
  11288. pop a CEL event the thread enter the "handle_event" function
  11289. (event.c) the thread acquire the read lock on
  11290. ast_event_subs[sub->type] the thread callback the "pgsql_log"
  11291. function (cel_pgsql.c), since it's a subscriber of CEL events the
  11292. thread try to acquire a read lock on psql_columns (closes issue
  11293. ASTERISK-22854) Reported by: Etienne Lessard Patches:
  11294. cel_pgsql_fix_deadlock_event.patch uploaded by hexanol (license
  11295. 6394) ........ Merged revisions 404603 from
  11296. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11297. revisions 404604 from
  11298. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11299. revisions 404605 from
  11300. http://svn.asterisk.org/svn/asterisk/branches/12
  11301. 2013-12-31 20:27 +0000 [r404593] Joshua Colp <jcolp@digium.com>
  11302. * res/res_pjsip_outbound_registration.c, /:
  11303. res_pjsip_outbound_registration: Add validation for 'server_uri'
  11304. and 'client_uri'. When applying configuration for outbound
  11305. registrations the 'server_uri' and 'client_uri' fields were not
  11306. validated. The code will now confirm that they exist and that
  11307. they contain parseable SIP URIs. Reported by: Andrew Nagy
  11308. ........ Merged revisions 404592 from
  11309. http://svn.asterisk.org/svn/asterisk/branches/12
  11310. 2013-12-30 23:25 +0000 [r404582] Kevin Harwell <kharwell@digium.com>
  11311. * main/channel.c, /: channels.c: core show channeltypes slicing
  11312. 'core show channeltypes' type column is being sliced, resulting
  11313. in incomplete type names. (closes issue ASTERISK-22919) Reported
  11314. by: outtolunc Patches: svn_channel.c.format_15.diff.txt uploaded
  11315. by outtolunc (license 5198) ........ Merged revisions 404579 from
  11316. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11317. revisions 404581 from
  11318. http://svn.asterisk.org/svn/asterisk/branches/12
  11319. 2013-12-24 17:12 +0000 [r404567-404569] David M. Lee <dlee@digium.com>
  11320. * UPGRADE-12.txt, /: Added note to UPGRADE.txt about the default
  11321. value of live_dangerously changing ........ Merged revisions
  11322. 404568 from http://svn.asterisk.org/svn/asterisk/branches/12
  11323. * /, main/http.c: http: Properly reject requests with
  11324. Transfer-Encoding set Asterisk does not support any of the
  11325. transfer encodings specified in HTTP/1.1, other than the default
  11326. "identity" encoding. According to RFC 2616: A server which
  11327. receives an entity-body with a transfer-coding it does not
  11328. understand SHOULD return 501 (Unimplemented), and close the
  11329. connection. A server MUST NOT send transfer-codings to an
  11330. HTTP/1.0 client. This patch adds the 501 Unimplemented response,
  11331. instead of the hard work of actually implementing other
  11332. recordings. This behavior is especially problematic for Node.js
  11333. clients, which use chunked encoding by default. (closes issue
  11334. ASTERISK-22486) Review: https://reviewboard.asterisk.org/r/3092/
  11335. ........ Merged revisions 404565 from
  11336. http://svn.asterisk.org/svn/asterisk/branches/12
  11337. 2013-12-24 02:20 +0000 [r404554] Joshua Colp <jcolp@digium.com>
  11338. * /, res/res_pjsip_pubsub.c: res_pjsip_pubsub: Ensure dialog
  11339. manipulation happens on proper thread. When destroying a
  11340. subscription we remove the serializer from its dialog and
  11341. decrease its reference count. Depending on which thread dropped
  11342. the subscription reference count to 0 it was possible for this to
  11343. occur in a thread where it is not possible. (closes issue
  11344. ASTERISK-22952) Reported by: Matt Jordan ........ Merged
  11345. revisions 404553 from
  11346. http://svn.asterisk.org/svn/asterisk/branches/12
  11347. 2013-12-23 16:38 +0000 [r404542] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  11348. * channels/chan_dahdi.c, configs/chan_dahdi.conf.sample,
  11349. UPGRADE-12.txt: chan_dahdi: enable ignore_failed_channels by
  11350. default If ignore_failed_channels is set to "true" for a channel,
  11351. the channel will continue to be configured even if configuring it
  11352. has failed. This allows Asterisk to start before all the DAHDI
  11353. initialization is done and thus not force the starting order
  11354. dahdi -> asterisk. Review:
  11355. https://reviewboard.asterisk.org/r/3063/
  11356. 2013-12-21 03:35 +0000 [r404532] Matthew Jordan <mjordan@digium.com>
  11357. * /, res/res_pjsip/pjsip_cli.c: res_pjsip/pjsip_cli: fix
  11358. compilation error caused by passing ast_free When wanting to pass
  11359. *free as a function pointer, ast_free_ptr has to be used instead
  11360. of ast_free. This allows it to be compiled with MALLOC_DEBUG
  11361. enabled. ........ Merged revisions 404531 from
  11362. http://svn.asterisk.org/svn/asterisk/branches/12
  11363. 2013-12-20 22:04 +0000 [r404511-404512] David M. Lee <dlee@digium.com>
  11364. * rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  11365. res/res_ari_channels.c, res/ari/resource_channels.h, /,
  11366. rest-api/api-docs/applications.json: ari: Remove support for
  11367. specifying channel vars during origination. When we added support
  11368. for specifying channel variables for an origination, we didn't
  11369. consider how that would interact with another feature, namely
  11370. specifying request parameters in a JSON request body. The method
  11371. of specifying channel variables (as a flat JSON object passed in
  11372. the JSON body) interferes with parsing parameters out of the
  11373. request body. Unfortunately, fixing this would be a backward
  11374. incompatible change. In the interest of keeping the API sane and
  11375. keeping our release schedule, we're dropping the feature for
  11376. specifying channel variables in the origination request. We will
  11377. bring the feature back soon, as a backward compatible addition to
  11378. the API. (closes issue ASTERISK-23051) Review:
  11379. https://reviewboard.asterisk.org/r/3088 ........ Merged revisions
  11380. 404509 from http://svn.asterisk.org/svn/asterisk/branches/12
  11381. * /: Remove automerge properties ........ Merged revisions 404488
  11382. from http://svn.asterisk.org/svn/asterisk/branches/12
  11383. 2013-12-20 21:32 +0000 [r404507] Matthew Jordan <mjordan@digium.com>
  11384. * include/asterisk/config.h, main/config.c, main/channel.c,
  11385. res/res_pjsip/location.c, include/asterisk/res_pjsip_cli.h
  11386. (added), res/res_pjsip/pjsip_cli.c (added),
  11387. include/asterisk/sorcery.h, res/res_pjsip/pjsip_configuration.c,
  11388. res/res_pjsip/include/res_pjsip_private.h,
  11389. res/res_pjsip_registrar.c, main/sorcery.c,
  11390. include/asterisk/res_pjsip.h, CREDITS,
  11391. res/res_pjsip/config_auth.c, /,
  11392. res/res_pjsip_endpoint_identifier_ip.c: res_pjsip: Add PJSIP CLI
  11393. commands Implements the following cli commands: pjsip list aors
  11394. pjsip list auths pjsip list channels pjsip list contacts pjsip
  11395. list endpoints pjsip show aor(s) pjsip show auth(s) pjsip show
  11396. channels pjsip show endpoint(s) Also... Minor modifications made
  11397. to the AMI command implementations to facilitate reuse. New
  11398. function ast_variable_list_sort added to config.c and config.h to
  11399. implement variable list sorting. (issue ASTERISK-22610) patches:
  11400. pjsip_cli_v2.patch uploaded by george.joseph (License 6322)
  11401. ........ Merged revisions 404480 from
  11402. http://svn.asterisk.org/svn/asterisk/branches/12
  11403. 2013-12-20 21:18 +0000 [r404461] Scott Griepentrog <sgriepentrog@digium.com>
  11404. * /, main/say.c: say.c: correct time for polish In
  11405. ast_say_date_with_format_pl(), change ast_say_number() to use
  11406. tm_sec instead of tm_mn. (closes issue ASTERISK-22856) Reported
  11407. by: Robert Mordec Review:
  11408. https://reviewboard.asterisk.org/r/3082/ Patches: say.c.patch
  11409. uploaded by veilen (license 6555) ........ Merged revisions
  11410. 404456 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  11411. ........ Merged revisions 404457 from
  11412. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11413. revisions 404458 from
  11414. http://svn.asterisk.org/svn/asterisk/branches/12
  11415. 2013-12-20 20:28 +0000 [r404452] Mark Michelson <mmichelson@digium.com>
  11416. * /, res/res_pjsip_refer.c: Fix issue where PJSIP blind transferer
  11417. dialog may not complete as planned. When transferring to a
  11418. dialplan extension that will not place any outbound calls, the
  11419. only control frames that the PJSIP REFER framehook will receive
  11420. are inconsequential (such as unhold or srcchange). As such, we
  11421. shouldn't allow for the reception of those types of frames
  11422. prevent us from signaling to the transferring party that the
  11423. transfer has completed successfully once voice frames are read.
  11424. Thanks to Jonathan Rose for pointing this out. ........ Merged
  11425. revisions 404439 from
  11426. http://svn.asterisk.org/svn/asterisk/branches/12
  11427. 2013-12-20 20:05 +0000 [r404438] Matthew Jordan <mjordan@digium.com>
  11428. * /, res/ari/resource_applications.h,
  11429. res/res_stasis_device_state.c: res_stasis_device_state: Set
  11430. resource type for subscriptions to deviceState The documentation
  11431. for ARI already specifies that the device state resource when
  11432. used for subscribing for events is "deviceState", not
  11433. "device_state". The code, however, used "device_state"; although
  11434. this was inconsistent as well in doxygen comments in
  11435. resource_applications. Because the actual resource being
  11436. subscribed to is /deviceStates/{device}/, it makes sense for the
  11437. resource type specifier to be deviceState. Note that the key
  11438. value in the events is still "device_state". ........ Merged
  11439. revisions 404437 from
  11440. http://svn.asterisk.org/svn/asterisk/branches/12
  11441. 2013-12-20 20:00 +0000 [r404436] Richard Mudgett <rmudgett@digium.com>
  11442. * res/ari/resource_channels.c, tests/test_scoped_lock.c,
  11443. tests/test_stasis.c, res/parking/parking_manager.c,
  11444. res/ari/resource_bridges.c, res/ari/resource_endpoints.c, /,
  11445. res/res_pjsip/location.c, tests/test_cel.c: ao2_iterator:
  11446. Mini-audit of the ao2_iterator loops in the new code files. *
  11447. Fixed several places where ao2_iterator_destroy() was not called.
  11448. * Fixed several iterator loop object variable reference problems.
  11449. * Fixed res_parking AMI actions returning non-zero. Only the AMI
  11450. logoff action can return non-zero. Review:
  11451. https://reviewboard.asterisk.org/r/3087/ ........ Merged
  11452. revisions 404434 from
  11453. http://svn.asterisk.org/svn/asterisk/branches/12
  11454. 2013-12-20 19:25 +0000 [r404433] Matthew Jordan <mjordan@digium.com>
  11455. * include/asterisk/manager.h, /: manager: bump version to 2.0.0 AMI
  11456. has received substantial updates over the past year. Not only has
  11457. the syntax been vastly improved and made consistent (which
  11458. entails many event changes), but the underlying things that those
  11459. events convey have changed substantially as well. After some
  11460. conversation in #asterisk-dev, it was agreed that this is a good
  11461. time to jump to 2. At the same time, since ARI will most likely
  11462. use semantic versioning, we might as well use that for AMI as
  11463. well. That also affords us greater meaning for the AMI version.
  11464. ........ Merged revisions 404421 from
  11465. http://svn.asterisk.org/svn/asterisk/branches/12
  11466. 2013-12-20 19:06 +0000 [r404420] Richard Mudgett <rmudgett@digium.com>
  11467. * /, main/sounds_index.c: Whitespace fixes. ........ Merged
  11468. revisions 404419 from
  11469. http://svn.asterisk.org/svn/asterisk/branches/12
  11470. 2013-12-20 17:22 +0000 [r404406] Rusty Newton <rnewton@digium.com>
  11471. * /, configs/pjsip.conf.sample: Documentation: Updates for info
  11472. about NAT-related settings and fixes for pjsip.conf.sample Added
  11473. another NAT example to pjsip.conf.sample. We had a few mentions
  11474. of NAT configuration throughout the sample, but I added another
  11475. for a little bit more clarity. Additionally many pjsip options
  11476. were affected by the change to snake case, so I fixed any
  11477. instances of those options in pjsip.conf. I regenerated the
  11478. config option list (at the bottom of the file) from a new xml
  11479. config doc dump, so all the snake case changes should be
  11480. reflected there, as well as any other changes to those options.
  11481. (issue ASTERISK-23004) (closes issue ASTERISK-23004) Reported by:
  11482. Matt Jordan Review: https://reviewboard.asterisk.org/r/3086/
  11483. ........ Merged revisions 404405 from
  11484. http://svn.asterisk.org/svn/asterisk/branches/12
  11485. 2013-12-19 20:48 +0000 [r404387] Scott Griepentrog <sgriepentrog@digium.com>
  11486. * main/security_events.c: security_events: log events with
  11487. descriptive names This patch updates the log messages to include
  11488. descriptive names for event types. This is an improvement over
  11489. having only cryptic type numbers. (closes issue ASTERISK-22909)
  11490. Reported by: outtolunc Review:
  11491. https://reviewboard.asterisk.org/r/3081/ Patches:
  11492. svn_security_events.c.names.diff.txt uploaded by outtolunc
  11493. (license 5198)
  11494. 2013-12-19 18:16 +0000 [r404376] Richard Mudgett <rmudgett@digium.com>
  11495. * /, CHANGES: Put notice in CHANGES as well as UPGRADE.txt.
  11496. ........ Merged revisions 404375 from
  11497. http://svn.asterisk.org/svn/asterisk/branches/12
  11498. 2013-12-19 18:00 +0000 [r404370-404372] Joshua Colp <jcolp@digium.com>
  11499. * res/res_pjsip/pjsip_outbound_auth.c, /: res_pjsip: Ignore 401/407
  11500. responses for transactions and dialogs we don't know about. Under
  11501. normal conditions it is unlikely we will ever receive a response
  11502. for a transaction or dialog we don't know about but if any are
  11503. received ignore them. ........ Merged revisions 404371 from
  11504. http://svn.asterisk.org/svn/asterisk/branches/12
  11505. * /, res/res_pjsip_session.c: res_pjsip_session: Fix SDP
  11506. negotiation when resending an INVITE with authentication. The
  11507. process for resending an INVITE with authentication involves
  11508. restarting the UAC session. We were incorrectly passing in that a
  11509. new offer is being sent, causing the SDP negotiation to get into
  11510. a (technically speaking) funky state. ........ Merged revisions
  11511. 404369 from http://svn.asterisk.org/svn/asterisk/branches/12
  11512. 2013-12-19 17:45 +0000 [r404368] Mark Michelson <mmichelson@digium.com>
  11513. * include/asterisk/channel.h, res/res_pjsip.c, main/channel.c, /,
  11514. include/asterisk/autochan.h: Fix a deadlock that occurred due to
  11515. a conflict of masquerades. For the explanation, here is a
  11516. copy-paste of the review board explanation: Initially, it was
  11517. discovered that performing an attended transfer of a multiparty
  11518. bridge with a PJSIP channel would cause a deadlock. A PBX thread
  11519. started a masquerade and reached the point where it was calling
  11520. the fixup() callback on the "original" channel. For chan_pjsip,
  11521. this involves pushing a synchronous task to the session's
  11522. serializer. The problem was that a task ahead of the fixup task
  11523. was also attempting to perform a channel masquerade. However,
  11524. since masquerades are designed in a way to only allow for one to
  11525. occur at a time, the task ahead of the fixup could not continue
  11526. until the masquerade already in progress had completed. And of
  11527. course, the masquerade in progress could not complete until the
  11528. task ahead of the fixup task had completed. Deadlock. The initial
  11529. fix was to change the fixup task to be asynchronous. While this
  11530. prevented the deadlock from occurring, it had the frightful side
  11531. effect of potentially allowing for tasks in the session's
  11532. serializer to operate on a zombie channel. Taking a step back
  11533. from this particular deadlock, it became clear that the problem
  11534. was not really this one particular issue but that masquerades
  11535. themselves needed to be addressed. A PJSIP attended transfer
  11536. operation calls ast_channel_move(), which attempts to both set up
  11537. and execute a masquerade. The problem was that after it had set
  11538. up the masquerade, the PBX thread had swooped in and tried to
  11539. actually perform the masquerade. Looking at changes that had been
  11540. made to Asterisk 12, it became clear that there never is any time
  11541. now that anyone ever wants to set up a masquerade and allow for
  11542. the channel thread to actually perform the masquerade. Everyone
  11543. always is calling ast_channel_move(), performs the masquerade
  11544. itself before returning. In this patch, I have removed all blocks
  11545. of code from channel.c that will attempt to perform a masquerade
  11546. if ast_channel_masq() returns true. Now, there is no distinction
  11547. between setting up a masquerade and performing the masquerade. It
  11548. is one operation. The only remaining checks for
  11549. ast_channel_masq() and ast_channel_masqr() are in ast_hangup()
  11550. since we do not want to interrupt a masquerade by hanging up the
  11551. channel. Instead, now ast_hangup() will wait for a masquerade to
  11552. complete before moving forward with its operation. The
  11553. ast_channel_move() function has been modified to basically
  11554. in-line the logic that used to be in ast_channel_masquerade().
  11555. ast_channel_masquerade() has been killed off for real.
  11556. ast_channel_move() now has a lock associated with it that is used
  11557. to prevent any simultaneous moves from occurring at once. This
  11558. means there is no need to make sure that ast_channel_masq() or
  11559. ast_channel_masqr() are already set on a channel when
  11560. ast_channel_move() is called. It also means the channel container
  11561. lock is not pulling double duty by both keeping the container
  11562. locked and preventing multiple masquerades from occurring
  11563. simultaneously. The ast_do_masquerade() function has been renamed
  11564. to do_channel_masquerade() and is now internal to channel.c. The
  11565. function now takes explicit arguments of which channels are
  11566. involved in the masquerade instead of a single channel. While it
  11567. probably is possible to do some further refactoring of this
  11568. method, I feel that I would be treading dangerously. Instead, all
  11569. I did was change some comments that no longer are true after this
  11570. changeset. The other more minor change introduced in this patch
  11571. is to res_pjsip.c to make ast_sip_push_task_synchronous() run the
  11572. task in-place if we are already a SIP servant thread. This is
  11573. related to this patch because even when we isolate the channel
  11574. masquerade to only running in the SIP servant thread, we would
  11575. still deadlock when the fixup() callback is reached since we
  11576. would essentially be waiting forever for ourselves to finish
  11577. before actually running the fixup. This makes it so the fixup is
  11578. run without having to push a task into a serializer at all.
  11579. (closes issue ASTERISK-22936) Reported by Jonathan Rose Review:
  11580. https://reviewboard.asterisk.org/r/3069 ........ Merged revisions
  11581. 404356 from http://svn.asterisk.org/svn/asterisk/branches/12
  11582. 2013-12-19 17:13 +0000 [r404355] Richard Mudgett <rmudgett@digium.com>
  11583. * main/udptl.c, addons/chan_ooh323.c, /, channels/chan_sip.c,
  11584. include/asterisk/udptl.h: udptl: Dead code elimination.
  11585. ast_udptl_bridge was not used. Removing dead code starting with
  11586. ast_udptl_bridge() eliminated the code in this change. Note: This
  11587. code has actually been dead since Asterisk v1.4 when it was first
  11588. put in. Review: https://reviewboard.asterisk.org/r/3079/ ........
  11589. Merged revisions 404354 from
  11590. http://svn.asterisk.org/svn/asterisk/branches/12
  11591. 2013-12-19 17:03 +0000 [r404353] Scott Griepentrog <sgriepentrog@digium.com>
  11592. * /, res/res_fax.c: res_fax.c: crash on framehook with no dsp in
  11593. fax detect In fax_detect_framehook() a null pointer reference can
  11594. occur where a voice frame is processed but no dsp is attached to
  11595. the fax detection structure. The code block that rejects frames
  11596. that detection cannot be processed on is checking for dsp but
  11597. falls through when it should instead return, as this change
  11598. implements. (closes issue ASTERISK-22942) Reported by: adomjan
  11599. Review: https://reviewboard.asterisk.org/r/3076/ ........ Merged
  11600. revisions 404351 from
  11601. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11602. revisions 404352 from
  11603. http://svn.asterisk.org/svn/asterisk/branches/12
  11604. 2013-12-19 16:52 +0000 [r404350] Richard Mudgett <rmudgett@digium.com>
  11605. * configs/skinny.conf.sample, res/res_xmpp.c, res/res_jabber.c,
  11606. CHANGES, channels/chan_iax2.c, channels/sig_pri.c,
  11607. channels/h323/chan_h323.h, configs/iax.conf.sample,
  11608. channels/sig_pri.h, channels/chan_dahdi.c,
  11609. include/asterisk/app.h, channels/chan_skinny.c,
  11610. channels/chan_dahdi.h, channels/chan_h323.c, main/app.c,
  11611. UPGRADE-12.txt, configs/sip.conf.sample,
  11612. channels/sip/include/sip.h, channels/chan_mgcp.c,
  11613. apps/app_voicemail.c, channels/chan_unistim.c,
  11614. configs/chan_dahdi.conf.sample, /, channels/chan_sip.c,
  11615. configs/voicemail.conf.sample, funcs/func_vmcount.c: Voicemail:
  11616. Remove mailbox identifier format (box@context) assumptions in the
  11617. system. This change is in preparation for external MWI support.
  11618. Removed code from the system for normal mailbox handling that
  11619. appends @default to the mailbox identifier if it does not have a
  11620. context. The only exception is the legacy hasvoicemail users.conf
  11621. option. The legacy option will only work for app_voicemail
  11622. mailboxes. The system cannot make any assumptions about the
  11623. format of the mailbox identifer used by app_voicemail. chan_sip
  11624. and chan_dahdi/sig_pri had the most changes because they both
  11625. tried to interpret the mailbox identifier. chan_sip just stored
  11626. and compared the two components. chan_dahdi actually used the box
  11627. information. The ISDN MWI support configuration options had to be
  11628. reworked because chan_dahdi was parsing the box@context format to
  11629. get the box number. As a result the mwi_vm_boxes chan_dahdi.conf
  11630. option was added and is documented in the chan_dahdi.conf.sample
  11631. file. Review: https://reviewboard.asterisk.org/r/3072/ ........
  11632. Merged revisions 404348 from
  11633. http://svn.asterisk.org/svn/asterisk/branches/12
  11634. 2013-12-19 16:33 +0000 [r404346] Scott Griepentrog <sgriepentrog@digium.com>
  11635. * main/db.c, /: astdb: crash in sqlite3 during shutdown When
  11636. Asterisk is shut down, the astdb_atexit() function releases
  11637. (finalize) the previously initiated (prepared) SQL statements in
  11638. sqlite3. Another thread making a subsequent request can cause a
  11639. crash in sqlite3. This patch eliminates that issue by resetting
  11640. the statement pointer after it is released/cleared. The sqlite3
  11641. code detects the null pointer, and aborts the operation cleanly.
  11642. (closes issue AST-1265) Reported by: Alexander Hömig (closes
  11643. issue ASTERISK-22350) Reported by: Birger "WIMPy" Harzenetter
  11644. Review: https://reviewboard.asterisk.org/r/3078/ ........ Merged
  11645. revisions 404344 from
  11646. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11647. revisions 404345 from
  11648. http://svn.asterisk.org/svn/asterisk/branches/12
  11649. 2013-12-19 12:18 +0000 [r404333] Joshua Colp <jcolp@digium.com>
  11650. * main/channel.c, /: channel: Add a missing ast_channel_unlock when
  11651. allocating a Surrogate channel. ........ Merged revisions 404332
  11652. from http://svn.asterisk.org/svn/asterisk/branches/12
  11653. 2013-12-19 08:35 +0000 [r404321] Alexandr Anikin <may@telecom-service.ru>
  11654. * addons/ooh323c/src/oochannels.c, addons/ooh323c/src/ooGkClient.c,
  11655. addons/chan_ooh323.c, /, addons/ooh323c/src/ooGkClient.h: Handle
  11656. temporary failures on gk registration Introduce new 'stopped'
  11657. state for gk client and restart gk client on failures Remove
  11658. ooh323 stack command lock as it is not need now. (closes issue
  11659. ASTERISK-21960) Reported by: Dmitry Melekhov Patches:
  11660. ASTERISK-21960.patch ASTERISK-21960-stacklockup-2.patch Tested
  11661. by: Dmitry Melekhov ........ Merged revisions 404318 from
  11662. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11663. revisions 404320 from
  11664. http://svn.asterisk.org/svn/asterisk/branches/12
  11665. 2013-12-19 02:59 +0000 [r404307] Damien Wedhorn <voip@facts.com.au>
  11666. * /, channels/chan_skinny.c: Fixup some skinny bugs causing Fracks
  11667. and ao2 cleanup issues. Moved channel locking into setsubstate so
  11668. that a process can complete working on a sub before another
  11669. starts changing it. The existing code was causing some Fracks
  11670. with schedule deletion. Removed multiple rtp cleanup. Now only
  11671. cleansup up once, fixing ao2 object cleanup issues. ........
  11672. Merged revisions 404306 from
  11673. http://svn.asterisk.org/svn/asterisk/branches/12
  11674. 2013-12-19 00:50 +0000 [r404295] Matthew Jordan <mjordan@digium.com>
  11675. * include/asterisk/cdr.h, CHANGES, apps/app_cdr.c, main/cdr.c,
  11676. apps/app_forkcdr.c, main/pbx.c, /, funcs/func_cdr.c,
  11677. apps/app_disa.c, UPGRADE-12.txt: app_cdr,app_forkcdr,func_cdr:
  11678. Synchronize with engine when manipulating state When doing the
  11679. rework of the CDR engine that pushed all of the logic into cdr.c
  11680. and made it respond to changes in channel state over Stasis, we
  11681. knew that accessing the CDR engine from the dialplan would be
  11682. "slightly" non-deterministic. Dialplan threads would be accessing
  11683. CDRs while Stasis threads would be updating the state of said
  11684. CDRs - whereas in the past, everything happened on the dialplan
  11685. threads. Tests have shown that "slightly" is in reality "very".
  11686. This patch synchronizes things by making the dialplan
  11687. applications/functions that manipulate CDRs do so over Stasis.
  11688. ForkCDR, NoCDR, ResetCDR, CDR, and CDR_PROP now all use Stasis to
  11689. send their requests over to the CDR engine, and synchronize on
  11690. the channel Stasis topic via a subscription so that they return
  11691. their values/control to the dialplan at the appropriate time.
  11692. While going through this, the following changes were also made: *
  11693. DISA, which can reset the CDR when a user successfully
  11694. authenticates, now just uses the ResetCDR app to do this. This
  11695. prevents having to duplicate the same Stasis synchronization
  11696. logic in that application. * Answer no longer disables CDRs. It
  11697. actually didn't work anyway - calling DISABLE on the channel's
  11698. CDR doesn't stop the CDR from getting the Answer time - it just
  11699. kills all CDRs on that channel, which isn't what the caller would
  11700. intend. (closes issue ASTERISK-22884) (closes issue
  11701. ASTERISK-22886) Review: https://reviewboard.asterisk.org/r/3057/
  11702. ........ Merged revisions 404294 from
  11703. http://svn.asterisk.org/svn/asterisk/branches/12
  11704. 2013-12-19 00:32 +0000 [r404293] Damien Wedhorn <voip@facts.com.au>
  11705. * /, channels/chan_skinny.c: Fixup skinny registration following
  11706. network issues. On session registration, if device is already
  11707. reporting that it is connected to a device, an innocuous packet
  11708. (update time) is sent to the already connected device. If the tcp
  11709. connection is down, the device will be unregistered and the new
  11710. connection allowed. Without this patch, network issues can see a
  11711. situation where a device can not reregister until after
  11712. 3*timeout. ........ Merged revisions 404292 from
  11713. http://svn.asterisk.org/svn/asterisk/branches/12
  11714. 2013-12-18 23:00 +0000 [r404280] Jason Parker <jparker@digium.com>
  11715. * main/manager.c, /: Add AMI event for presence state. Review:
  11716. https://reviewboard.asterisk.org/r/3039/ ........ Merged
  11717. revisions 404275 from
  11718. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11719. revisions 404279 from
  11720. http://svn.asterisk.org/svn/asterisk/branches/12
  11721. 2013-12-18 21:12 +0000 [r404264] Richard Mudgett <rmudgett@digium.com>
  11722. * addons/ooh323c/src/ooTimer.c, /: ooh323c: Fix gcc 4.6.3 compiler
  11723. warnings. ........ Merged revisions 404212 from
  11724. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11725. revisions 404219 from
  11726. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11727. revisions 404263 from
  11728. http://svn.asterisk.org/svn/asterisk/branches/12
  11729. 2013-12-18 20:48 +0000 [r404260-404262] Kevin Harwell <kharwell@digium.com>
  11730. * channels/chan_oss.c, /: chan_oss.c: channel being locked twice
  11731. and unlocked once Removed channel lock as it is now being down in
  11732. ast_channel_alloc ........ Merged revisions 404261 from
  11733. http://svn.asterisk.org/svn/asterisk/branches/12
  11734. * pbx/pbx_realtime.c, channels/chan_alsa.c, main/stasis_channels.c,
  11735. addons/chan_mobile.c, main/bridge_channel.c, tests/test_cdr.c,
  11736. channels/chan_pjsip.c, res/parking/parking_manager.c,
  11737. channels/chan_mgcp.c, channels/chan_unistim.c, main/pbx.c,
  11738. funcs/func_timeout.c, /, apps/app_meetme.c, main/bridge.c,
  11739. tests/test_stasis_channels.c, include/asterisk/channel.h,
  11740. channels/chan_gtalk.c, channels/sig_pri.c, apps/app_queue.c,
  11741. main/cel.c, main/stasis_bridges.c, channels/chan_jingle.c,
  11742. channels/chan_phone.c, channels/chan_dahdi.c, main/dial.c,
  11743. channels/sig_analog.c, include/asterisk/stasis_channels.h,
  11744. res/res_agi.c, channels/chan_motif.c, tests/test_cel.c,
  11745. apps/app_confbridge.c, res/res_stasis.c, res/res_pjsip_refer.c,
  11746. apps/app_voicemail.c, apps/app_dial.c, channels/chan_vpb.cc,
  11747. addons/chan_ooh323.c, main/pickup.c, include/asterisk/aoc.h,
  11748. include/asterisk/stasis_bridges.h, apps/app_userevent.c,
  11749. apps/app_disa.c, channels/chan_console.c,
  11750. include/asterisk/channelstate.h, main/core_local.c,
  11751. channels/chan_iax2.c, main/endpoints.c, channels/chan_oss.c,
  11752. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  11753. main/channel.c, channels/chan_misdn.c, channels/chan_skinny.c:
  11754. channel locking: Add locking for channel snapshot creation
  11755. Original commit message by mmichelson (asterisk 12 r403311):
  11756. "This adds channel locks around calls to create channel snapshots
  11757. as well as other functions which operate on a channel and then
  11758. end up creating a channel snapshot. Functions that expect the
  11759. channel to be locked prior to being called have had their
  11760. documentation updated to indicate such." The above was initially
  11761. committed and then reverted at r403398. The problem was found to
  11762. be in core_local.c in the publish_local_bridge_message function.
  11763. The ast_unreal_lock_all function locks and adds a reference to
  11764. the returned channels and while they were being unlocked they
  11765. were not being unreffed when no longer needed. Fixed by unreffing
  11766. the channels. Also in bridge.c a lock was obtained on
  11767. "other->chan", but then an attempt was made to unlock "other" and
  11768. not the previously locked channel. Fixed by unlocking
  11769. "other->chan" (closes issue ASTERISK-22709) Reported by: John
  11770. Bigelow ........ Merged revisions 404237 from
  11771. http://svn.asterisk.org/svn/asterisk/branches/12
  11772. 2013-12-18 19:36 +0000 [r404211] Alexandr Anikin <may@telecom-service.ru>
  11773. * addons/chan_ooh323.c, configs/ooh323.conf.sample: Introduce new
  11774. config option 'aniasdni'. If yes then asterisk set dialed number
  11775. as own id back to the caller on incoming h.323 calls. Option can
  11776. be set globally or per user section. (closes issue
  11777. ASTERISK-22020) Reported by: Ross Beer
  11778. 2013-12-18 19:28 +0000 [r404210] Joshua Colp <jcolp@digium.com>
  11779. * channels/chan_mgcp.c, main/pbx.c, channels/chan_sip.c,
  11780. apps/confbridge/conf_chan_record.c, tests/test_app.c,
  11781. tests/test_stasis_channels.c, main/core_unreal.c,
  11782. include/asterisk/channel.h, channels/chan_console.c,
  11783. channels/chan_oss.c, channels/chan_jingle.c,
  11784. channels/chan_misdn.c, channels/chan_h323.c, tests/test_cel.c,
  11785. channels/chan_nbs.c, channels/chan_pjsip.c, res/res_calendar.c,
  11786. apps/app_voicemail.c, channels/chan_unistim.c,
  11787. tests/test_substitution.c, channels/chan_vpb.cc,
  11788. addons/chan_ooh323.c, channels/chan_multicast_rtp.c, /,
  11789. apps/app_meetme.c, res/res_stasis_snoop.c, channels/chan_gtalk.c,
  11790. channels/chan_iax2.c, main/channel.c, channels/chan_dahdi.c,
  11791. channels/chan_phone.c, channels/chan_skinny.c,
  11792. res/parking/parking_tests.c, channels/chan_motif.c,
  11793. tests/test_voicemail_api.c, channels/chan_alsa.c, main/message.c,
  11794. addons/chan_mobile.c, tests/test_cdr.c: channels: Return
  11795. allocated channels locked. This change makes ast_channel_alloc
  11796. return allocated channels locked. By doing so no other thread can
  11797. acquire, lock, and manipulate the channel before it is completely
  11798. set up. (closes issue AST-1256) Review:
  11799. https://reviewboard.asterisk.org/r/3067/ ........ Merged
  11800. revisions 404204 from
  11801. http://svn.asterisk.org/svn/asterisk/branches/12
  11802. 2013-12-18 19:10 +0000 [r404198] Alexandr Anikin <may@telecom-service.ru>
  11803. * addons/chan_ooh323.c: Implement module reload command for
  11804. chan_ooh323 (close issue ASTERISK-22817) Patches:
  11805. ooh323_module_reload.patch
  11806. 2013-12-18 12:46 +0000 [r404185] Matthew Jordan <mjordan@digium.com>
  11807. * rest-api/api-docs/applications.json,
  11808. rest-api/api-docs/playbacks.json,
  11809. rest-api/api-docs/channels.json, rest-api/api-docs/sounds.json,
  11810. rest-api/resources.json, rest-api/api-docs/bridges.json,
  11811. rest-api/api-docs/recordings.json,
  11812. rest-api/api-docs/deviceStates.json,
  11813. rest-api/api-docs/endpoints.json, rest-api/api-docs/events.json,
  11814. /, rest-api/api-docs/asterisk.json: ari: Bump the version of ARI
  11815. to 1.0.0 (closes issue ASTERISK-23007) ........ Merged revisions
  11816. 404184 from http://svn.asterisk.org/svn/asterisk/branches/12
  11817. 2013-12-18 12:01 +0000 [r404138] Joshua Colp <jcolp@digium.com>
  11818. * res/res_calendar.c, /: res_calendar: Protect channel when adding
  11819. datastore. This change adds a missing channel lock when adding a
  11820. datastore to a channel. ........ Merged revisions 404135 from
  11821. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11822. revisions 404136 from
  11823. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11824. revisions 404137 from
  11825. http://svn.asterisk.org/svn/asterisk/branches/12
  11826. 2013-12-18 00:36 +0000 [r404100] Rusty Newton <rnewton@digium.com>
  11827. * /, funcs/func_strings.c: func_strings: Documentation fix for
  11828. QUOTE() Example output was inaccurate. (issue ASTERISK-22970)
  11829. (closes issue ASTERISK-22970) Reported by: Gareth Palmer Patches:
  11830. func_strings.patch uploaded by Gareth Palmer (license 5169)
  11831. ........ Merged revisions 404081 from
  11832. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11833. revisions 404087 from
  11834. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11835. revisions 404099 from
  11836. http://svn.asterisk.org/svn/asterisk/branches/12
  11837. 2013-12-18 00:17 +0000 [r404051] Matthew Jordan <mjordan@digium.com>
  11838. * /, LICENSE: LICENSE: Update language to include ARI ........
  11839. Merged revisions 404050 from
  11840. http://svn.asterisk.org/svn/asterisk/branches/12
  11841. 2013-12-17 23:57 +0000 [r404049] Jonathan Rose <jrose@digium.com>
  11842. * /, tests/test_cel.c, tests/test_cdr.c: tests: fix
  11843. ast_bridge_base_new calls not using the additional arguments
  11844. r404042 gave ast_bridge_base_new two new arguments for setting a
  11845. bridge creator and name. Unfortunately since a couple test
  11846. modules aren't compiled by default, I missed the fact that this
  11847. change impacted those tests and caused compilation failures
  11848. against them. ........ Merged revisions 404048 from
  11849. http://svn.asterisk.org/svn/asterisk/branches/12
  11850. 2013-12-17 23:38 +0000 [r404047] Rusty Newton <rnewton@digium.com>
  11851. * include/asterisk/test.h, main/channel.c, main/rtp_engine.c, /,
  11852. channels/chan_iax2.c, apps/app_chanspy.c, apps/app_mixmonitor.c:
  11853. Several components: fixing Typos in comments and code,
  11854. "avaliable" instead of "available" (issue ASTERISK-23021) (closes
  11855. issue ASTERISK-23021) Reported by: Jeremy Lainé Tested by: Rusty
  11856. Newton Patches: available.patch uploaded by Jeremy Lainé (license
  11857. 6561) ........ Merged revisions 404046 from
  11858. http://svn.asterisk.org/svn/asterisk/branches/12
  11859. 2013-12-17 23:25 +0000 [r404043] Jonathan Rose <jrose@digium.com>
  11860. * apps/app_bridgewait.c, res/ari/ari_model_validators.c,
  11861. doc/appdocsxml.xslt, main/stasis_bridges.c,
  11862. rest-api/api-docs/bridges.json, res/ari/resource_bridges.c,
  11863. apps/app_agent_pool.c, res/parking/parking_bridge.c,
  11864. res/ari/ari_model_validators.h, main/manager_bridges.c,
  11865. res/ari/resource_bridges.h, include/asterisk/bridge_internal.h,
  11866. apps/app_confbridge.c, res/res_stasis.c,
  11867. include/asterisk/bridge.h, res/res_ari_bridges.c, /,
  11868. main/bridge.c, main/bridge_basic.c,
  11869. include/asterisk/stasis_bridges.h, include/asterisk/stasis_app.h:
  11870. bridging: Give bridges a name and a known creator Bridges have
  11871. two new optional properties, a creator and a name. Certain
  11872. consumers of bridges will automatically provide bridges that they
  11873. create with these properties. Examples include app_bridgewait,
  11874. res_parking, app_confbridge, and app_agent_pool. In addition, a
  11875. name may now be provided as an argument to the POST function for
  11876. creating new bridges via ARI. (closes issue AFS-47) Review:
  11877. https://reviewboard.asterisk.org/r/3070/ ........ Merged
  11878. revisions 404042 from
  11879. http://svn.asterisk.org/svn/asterisk/branches/12
  11880. 2013-12-17 18:35 +0000 [r404028-404030] Joshua Colp <jcolp@digium.com>
  11881. * res/res_sorcery_config.c, /: res_sorcery_config: Output an error
  11882. message when an object can't be created. If object creation fails
  11883. an error message will now be output with the id, type, and
  11884. configuration file. ........ Merged revisions 404029 from
  11885. http://svn.asterisk.org/svn/asterisk/branches/12
  11886. * /, main/framehook.c: framehooks: Re-iterate if framehook provides
  11887. different frame. Framehooks can be used in a reactive manner to
  11888. execute specific logic when a frame is received with a certain
  11889. type and payload. Since it is possible for framehooks to provide
  11890. frames it was possible for this reactive framehook to be unaware
  11891. of frames it is looking for. This change makes it so that when
  11892. framehooks return a modified frame the code will now re-iterate
  11893. (from the beginning) and call any previous framehooks that have
  11894. not provided a modified frame themselves. Review:
  11895. https://reviewboard.asterisk.org/r/3046/ ........ Merged
  11896. revisions 404027 from
  11897. http://svn.asterisk.org/svn/asterisk/branches/12
  11898. 2013-12-17 14:41 +0000 [r404008-404009] David M. Lee <dlee@digium.com>
  11899. * /, configs/asterisk.conf.sample, main/asterisk.c: Changed the
  11900. default for live_dangerously to no ........ Merged revisions
  11901. 404006 from http://svn.asterisk.org/svn/asterisk/branches/12
  11902. * channels/pjsip, /: Setting svn:ignore ........ Merged revisions
  11903. 403748 from http://svn.asterisk.org/svn/asterisk/branches/12
  11904. 2013-12-17 12:59 +0000 [r403994] Matthew Jordan <mjordan@digium.com>
  11905. * /, res/ari/resource_channels.c: ari/resource_channels: When
  11906. creating a channel, specify a default format (SLIN) When creating
  11907. channels via ARI, the current code fails to provide any default
  11908. format capabilities. For non-virtual channels this isn't really a
  11909. problem - the channels typically receive their capabilities as a
  11910. result of the underlying channel driver configuration. For
  11911. virtual channels (such as Local channels), the lack of any format
  11912. capabilities causes the Asterisk core to make some 'odd' choices
  11913. with respect to the translation paths. The issue reporter had
  11914. some paths that had 3 hops on each channel leg, causing multiple
  11915. transcodings and some really crappy audio/performance. By
  11916. specifying a baseline of SLIN, we prevent that from occurring.
  11917. Note that this is what AMI does when it performs an Originate, as
  11918. does res_clioriginate. Review:
  11919. https://reviewboard.asterisk.org/r/3068/ (issue ASTERISK-22962)
  11920. Reported by: Matt DiMeo ........ Merged revisions 403993 from
  11921. http://svn.asterisk.org/svn/asterisk/branches/12
  11922. 2013-12-16 19:11 +0000 [r403960] David M. Lee <dlee@digium.com>
  11923. * include/asterisk/pbx.h, main/asterisk.c, funcs/func_realtime.c,
  11924. main/pbx.c, main/tcptls.c, funcs/func_db.c, /,
  11925. README-SERIOUSLY.bestpractices.txt, configs/asterisk.conf.sample,
  11926. funcs/func_shell.c, funcs/func_env.c, funcs/func_lock.c,
  11927. UPGRADE-12.txt: security: Inhibit execution of privilege
  11928. escalating functions This patch allows individual dialplan
  11929. functions to be marked as 'dangerous', to inhibit their execution
  11930. from external sources. A 'dangerous' function is one which
  11931. results in a privilege escalation. For example, if one were to
  11932. read the channel variable SHELL(rm -rf /) Bad Things(TM) could
  11933. happen; even if the external source has only read permissions.
  11934. Execution from external sources may be enabled by setting
  11935. 'live_dangerously' to 'yes' in the [options] section of
  11936. asterisk.conf. Although doing so is not recommended. Also, the
  11937. ABI was changed to something more reasonable, since Asterisk 12
  11938. does not yet have a public release. (closes issue ASTERISK-22905)
  11939. Review: http://reviewboard.digium.internal/r/432/ ........ Merged
  11940. revisions 403913 from
  11941. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11942. revisions 403917 from
  11943. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11944. revisions 403959 from
  11945. http://svn.asterisk.org/svn/asterisk/branches/12
  11946. 2013-12-16 18:31 +0000 [r403958] Jonathan Rose <jrose@digium.com>
  11947. * /, main/bridge.c: transfers: Fix bug setting both BLINDTRANSFER
  11948. and ATTENDEDTRANSFER The ast_bridge_set_transfer_variables
  11949. function is supposed to wipe whichever variable isn't being set.
  11950. Instead it was setting both to the new value. Oops. (issue
  11951. AFS-24) ........ Merged revisions 403957 from
  11952. http://svn.asterisk.org/svn/asterisk/branches/12
  11953. 2013-12-16 16:12 +0000 [r403857-403865] Scott Griepentrog <sgriepentrog@digium.com>
  11954. * main/pbx.c, /: pbx.c: put copy of ast_exten.data on stack to
  11955. prevent memory corruption During dialplan execution in
  11956. pbx_extension_helper(), the contexts global read lock prevents
  11957. link list corruption, but was released with a pointer to the
  11958. ast_exten and data later used in variable substitution. Instead,
  11959. this patch removes pbx_substitute_variables() and locates a copy
  11960. of the ast_exten data on the stack before releasing the lock,
  11961. where ast_exten could get free'd by another thread performing a
  11962. module reload. (issue AST-1179) Reported by: Thomas Arimont
  11963. (issue AST-1246) Reported by: Alexander Hömig Review:
  11964. https://reviewboard.asterisk.org/r/3055/ ........ Merged
  11965. revisions 403862 from
  11966. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  11967. revisions 403863 from
  11968. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  11969. revisions 403864 from
  11970. http://svn.asterisk.org/svn/asterisk/branches/12
  11971. * /, apps/app_sms.c: app_sms: BufferOverflow when receiving odd
  11972. length 16 bit message This patch prevents an infinite loop
  11973. overwriting memory when a message is received into the
  11974. unpacksms16() function, where the length of the message is an odd
  11975. number of bytes. (closes issue ASTERISK-22590) Reported by: Jan
  11976. Juergens Tested by: Jan Juergens ........ Merged revisions 403856
  11977. from http://svn.asterisk.org/svn/asterisk/branches/12
  11978. 2013-12-15 01:39 +0000 [r403824] Matthew Jordan <mjordan@digium.com>
  11979. * channels/pjsip/dialplan_functions.c, /: pjsip/dialplan_functions:
  11980. Use the right buffer length when printing URIs While
  11981. entertaining, sizeof(buflen) is not the same as buflen. Doh.
  11982. ........ Merged revisions 403823 from
  11983. http://svn.asterisk.org/svn/asterisk/branches/12
  11984. 2013-12-14 17:28 +0000 [r403810-403812] Joshua Colp <jcolp@digium.com>
  11985. * include/asterisk/res_pjsip.h, /, res/res_pjsip/location.c,
  11986. res/res_pjsip/pjsip_options.c, res/res_pjsip.c: res_pjsip: Apply
  11987. outbound proxy to all SIP requests. Objects which are involved in
  11988. SIP request creation and sending now allow an outbound proxy to
  11989. be specified. For cases where an endpoint is used the outbound
  11990. proxy specified there will be applied. (closes issue
  11991. ASTERISK-22673) Reported by: Antti Yrjola Review:
  11992. https://reviewboard.asterisk.org/r/3022/ ........ Merged
  11993. revisions 403811 from
  11994. http://svn.asterisk.org/svn/asterisk/branches/12
  11995. * main/stasis_channels.c, apps/app_queue.c,
  11996. res/ari/ari_model_validators.c, apps/app_dial.c,
  11997. res/ari/ari_model_validators.h, main/dial.c,
  11998. include/asterisk/stasis_channels.h,
  11999. rest-api/api-docs/events.json, /, res/stasis/app.c: res_stasis:
  12000. Expose event for call forwarding and follow forwarded channel.
  12001. This change adds an event for when an originated call is
  12002. redirected to another target. This event contains the original
  12003. channel and the newly created channel. If a stasis subscription
  12004. exists on the original originated channel for a stasis
  12005. application then a new subscription will also be created on the
  12006. stasis application to the redirected channel. This allows the
  12007. application to follow the call path completely. (closes issue
  12008. ASTERISK-22719) Reported by: Joshua Colp Review:
  12009. https://reviewboard.asterisk.org/r/3054/ ........ Merged
  12010. revisions 403808 from
  12011. http://svn.asterisk.org/svn/asterisk/branches/12
  12012. 2013-12-13 21:35 +0000 [r403797] Jonathan Rose <jrose@digium.com>
  12013. * /, res/res_pjsip_messaging.c, main/message.c: documentation: Add
  12014. PJSIP technology to messaging documentation ........ Merged
  12015. revisions 403796 from
  12016. http://svn.asterisk.org/svn/asterisk/branches/12
  12017. 2013-12-13 20:17 +0000 [r403784] Richard Mudgett <rmudgett@digium.com>
  12018. * /, main/test.c: test.c: Fix too sticky unit test failed status.
  12019. Rerunning a failed unit test after loading any required modules
  12020. should allow the test to report a pass status if it now passes.
  12021. ........ Merged revisions 403782 from
  12022. http://svn.asterisk.org/svn/asterisk/branches/12
  12023. 2013-12-13 20:13 +0000 [r403783] Jonathan Rose <jrose@digium.com>
  12024. * /, main/bridge.c, main/bridge_basic.c, include/asterisk/bridge.h,
  12025. res/parking/parking_bridge_features.c,
  12026. res/parking/parking_manager.c: Transfers: Make Asterisk set
  12027. ATTENDEDTRANSFER/BLINDTRANSFER more reliably There were still a
  12028. few cases in which ATTENDEDTRANSFER and BLINDTRANSFER wouldn't be
  12029. set on channels involved with blind and attended transfers. This
  12030. would happen with features that were initialized by channel
  12031. driver specific mechanisms in multiparty calls. This patch
  12032. resolves those cases while attempted to keep the behavior for
  12033. setting those variables as consistent as possible. (closes issue
  12034. AFS-24) Review: https://reviewboard.asterisk.org/r/3040/ ........
  12035. Merged revisions 403781 from
  12036. http://svn.asterisk.org/svn/asterisk/branches/12
  12037. 2013-12-13 18:33 +0000 [r403750-403768] Kevin Harwell <kharwell@digium.com>
  12038. * main/channel.c, /, channels/chan_sip.c,
  12039. include/asterisk/channel.h, bridges/bridge_native_rtp.c,
  12040. channels/chan_pjsip.c: bridge_native_rtp: Deadlock during 4-way
  12041. conference creation The change contains a slightly adjusted patch
  12042. that was on the issue (submitted by kmoore). A fix was made by
  12043. adding in a bridge lock while calling bridge_start/stop from the
  12044. framehook callback. Since the framehook callback is not called
  12045. from the bridging core the bridge is not locked, but needs to be
  12046. before calling bridge_start. (closes issue ASTERISK-22749)
  12047. Reported by: Kinsey Moore Review:
  12048. https://reviewboard.asterisk.org/r/3066/ Patches:
  12049. lock_inversion.diff uploaded by kmoore (license 6273) ........
  12050. Merged revisions 403767 from
  12051. http://svn.asterisk.org/svn/asterisk/branches/12
  12052. * rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  12053. res/res_ari_channels.c, res/ari/resource_channels.h, /,
  12054. main/http.c: ARI: Allow specifying channel variables during a
  12055. POST /channels Added the ability to specify channel variables
  12056. when creating/originating a channel in ARI. The variables are
  12057. sent in the body of the request and should be formatted as a
  12058. single level JSON object. No nested objects allowed. For example:
  12059. {"variable1": "foo", "variable2": "bar"}. (closes issue
  12060. ASTERISK-22872) Reported by: Matt Jordan Review:
  12061. https://reviewboard.asterisk.org/r/3052/ ........ Merged
  12062. revisions 403752 from
  12063. http://svn.asterisk.org/svn/asterisk/branches/12
  12064. * res/res_stasis_answer.c, rest-api/api-docs/bridges.json,
  12065. res/ari/resource_bridges.c, res/res_ari_bridges.c,
  12066. res/stasis/command.c, res/res_stasis_playback.c, /,
  12067. res/stasis/control.c, res/stasis/command.h,
  12068. include/asterisk/stasis_app.h,
  12069. include/asterisk/stasis_app_impl.h, res/res_stasis_recording.c:
  12070. ARI: Adding a channel to a bridge while a live recording is
  12071. active blocks Added the ability to have rules that are checked
  12072. when adding and/or removing channels to/from a bridge. In this
  12073. case, if a channel is currently recording and someone attempts to
  12074. add it to a bridge an "is recording" rule is checked, fails, and
  12075. a 409 conflict is returned. Also command functions now return an
  12076. integer value that can be descriptive of what kind of problems,
  12077. if any, occurred before or during execution. (closes issue
  12078. ASTERISK-22624) Reported by: Joshua Colp Review:
  12079. https://reviewboard.asterisk.org/r/2947/ ........ Merged
  12080. revisions 403749 from
  12081. http://svn.asterisk.org/svn/asterisk/branches/12
  12082. 2013-12-13 05:00 +0000 [r403737] Matthew Jordan <mjordan@digium.com>
  12083. * /, channels/Makefile: channels/Makefile: clean pjsip directory
  12084. ........ Merged revisions 403736 from
  12085. http://svn.asterisk.org/svn/asterisk/branches/12
  12086. 2013-12-13 00:40 +0000 [r403726] Richard Mudgett <rmudgett@digium.com>
  12087. * include/asterisk/app.h, tests/test_voicemail_api.c, main/app.c:
  12088. test_voicemail_api: Add check for a registered voicemail provider
  12089. before tests. It is much nicer diagnosing a test failure if
  12090. app_voicemail is actually loaded.
  12091. 2013-12-12 19:46 +0000 [r403714] Scott Griepentrog <sgriepentrog@digium.com>
  12092. * contrib/ast-db-manage/config/versions/581a4264e537_adding_extensions.py
  12093. (added), /: realtime: Create extensions in alembic ast-db-manage
  12094. contribution When the alembic scripts were written for creating
  12095. Asterisk realtime databases the extensions table for dialplan
  12096. wasn't included. This update creates the extensions table.
  12097. (closes issue ASTERISK-22815) Reported by: Zone Conkle Review:
  12098. https://reviewboard.asterisk.org/r/3064/ ........ Merged
  12099. revisions 403713 from
  12100. http://svn.asterisk.org/svn/asterisk/branches/12
  12101. 2013-12-12 19:18 +0000 [r403707] Jonathan Rose <jrose@digium.com>
  12102. * /, channels/chan_pjsip.c: chan_pjsip: Revert r403587 This patch
  12103. was intended to eliminate a deadlock that occurs when masquerades
  12104. occur in pjsip channels, but has some potential side effects.
  12105. Mark Michelson is currently working on addressing this problem
  12106. from another angle. (issue ASTERISK-22936) Reported by: Jonathan
  12107. Rose ........ Merged revisions 403705 from
  12108. http://svn.asterisk.org/svn/asterisk/branches/12
  12109. 2013-12-11 20:24 +0000 [r403687] Kevin Harwell <kharwell@digium.com>
  12110. * include/asterisk/res_pjsip.h, res/res_pjsip/config_global.c, /,
  12111. configs/pjsip.conf.sample, res/res_pjsip/pjsip_configuration.c,
  12112. res/res_pjsip_messaging.c,
  12113. res/res_pjsip/include/res_pjsip_private.h, res/res_pjsip.c:
  12114. res_pjsip_messaging: send message to a default outbound endpoint
  12115. In some cases messages need to be sent to a direct URI (sip:<ip
  12116. address>). This patch adds in that support by using a default
  12117. outbound endpoint. When sending messages, if no endpoint can be
  12118. found then the default one is used. To facilitate this a new
  12119. default_outbound_endpoint option was added to the globals section
  12120. for pjsip.conf. Review: https://reviewboard.asterisk.org/r/2944/
  12121. ........ Merged revisions 403680 from
  12122. http://svn.asterisk.org/svn/asterisk/branches/12
  12123. 2013-12-11 19:22 +0000 [r403652] Russell Bryant <russell@russellbryant.com>
  12124. * /, channels/chan_sip.c: Reset peer outboundproxy on sip.conf
  12125. reload If you set a peer's outboundproxy and then removed it from
  12126. the config, this would not get picked up in a config reload. This
  12127. patch fixes that by resetting it in set_peer_defaults(). Closes
  12128. ASTERISK-19454 Review: https://reviewboard.asterisk.org/r/3065/
  12129. ........ Merged revisions 403634 from
  12130. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12131. revisions 403635 from
  12132. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  12133. revisions 403639 from
  12134. http://svn.asterisk.org/svn/asterisk/branches/12
  12135. 2013-12-11 19:19 +0000 [r403643] Richard Mudgett <rmudgett@digium.com>
  12136. * apps/app_voicemail.c, include/asterisk/app.h,
  12137. include/asterisk/doxyref.h, main/app.c: app_voicemail: Voicemail
  12138. callback registration/unregistration function improvements. * The
  12139. voicemail registration/unregistration functions now take a struct
  12140. of callbacks instead of a lengthy parameter list of callbacks. *
  12141. The voicemail registration/unregistration functions now prevent a
  12142. competing module from interfering with an already registered
  12143. callback supplying module.
  12144. 2013-12-11 13:06 +0000 [r403617-403619] Matthew Jordan <mjordan@digium.com>
  12145. * channels/pjsip/dialplan_functions.c,
  12146. include/asterisk/res_pjsip_session.h, channels/pjsip (added), /,
  12147. funcs/func_channel.c, channels/pjsip/include,
  12148. channels/pjsip/include/dialplan_functions.h, res/res_pjsip_t38.c,
  12149. channels/pjsip/include/chan_pjsip.h, channels/Makefile,
  12150. channels/chan_pjsip.c, main/xmldoc.c: func_channel, chan_pjsip:
  12151. Add CHANNEL read function support for chan_pjsip This patch adds
  12152. CHANNEL read support for chan_pjsip. This allows the dialplan to
  12153. use the CHANNEL function on a chan_pjsip channel to obtain
  12154. run-time information about the channel from the PJSIP channel
  12155. driver and the PJSIP stack. This includes: * RTP information,
  12156. including source/destination media addresses, whether or not the
  12157. media is secure, held, and other properties. * RTCP information.
  12158. This includes sets of parseable information, as well as
  12159. individual statistic attriutes. * PJSIP information. This
  12160. includes URIs, local/remote signalling addresses, whether or not
  12161. the signalling is secure, and other properties. * The endpoint
  12162. name. This can be used in conjunction with the PJSIP_ENDPOINT
  12163. function to obtain more detailed endpoint information. Review:
  12164. https://reviewboard.asterisk.org/r/3038/ ........ Merged
  12165. revisions 403618 from
  12166. http://svn.asterisk.org/svn/asterisk/branches/12
  12167. * Makefile, funcs/func_pjsip_endpoint.c (added), doc/snapshots.xslt
  12168. (removed), /, doc/appdocsxml.xslt (added), doc/appdocsxml.dtd,
  12169. main/sorcery.c: func_pjsip_endpoint: Add PJSIP_ENDPOINT function
  12170. for querying endpoint details This patch adds a new function,
  12171. PJSIP_ENDPOINT, which lets the dialplan query, for any endpoint,
  12172. any property configured on an endpoint. This function is a
  12173. companion to the CHANNEL function, which can be used to extract
  12174. the endpoint name for a channel. Review:
  12175. https://reviewboard.asterisk.org/r/3035 ........ Merged revisions
  12176. 403616 from http://svn.asterisk.org/svn/asterisk/branches/12
  12177. 2013-12-10 15:15 +0000 [r403605] Mark Michelson <mmichelson@digium.com>
  12178. * res/res_pjsip_authenticator_digest.c: Fix correct authentication
  12179. behavior for artificial endpoint. When switching to using a
  12180. vector for authentication, I initialized the vector for the
  12181. artificial endpoint to be of size 1. However, this does not
  12182. result in AST_VECTOR_SIZE() returning 1 since there isn't
  12183. actually anything in the vector. Rather than trifle with the
  12184. vector by putting unnecessary elements in, I simply changed the
  12185. callback in res_pjsip_authenticator_digest.c to explicitly report
  12186. that the artificial endpoint requires authentication. Thanks to
  12187. Joshua Colp for pointing this out.
  12188. 2013-12-09 22:59 +0000 [r403576-403588] Jonathan Rose <jrose@digium.com>
  12189. * /, channels/chan_pjsip.c: chan_pjsip: Fix a sticking channel lock
  12190. caused by channel masquerades (closes issue ASTERISK-22936)
  12191. Reported by: Jonathan Rose Review:
  12192. https://reviewboard.asterisk.org/r/3042/ ........ Merged
  12193. revisions 403587 from
  12194. http://svn.asterisk.org/svn/asterisk/branches/12
  12195. * CHANGES, main/dial.c, apps/app_page.c, include/asterisk/dial.h:
  12196. app_page: Add predial handlers for app_page. (closes issue
  12197. AFS-14) Review: https://reviewboard.asterisk.org/r/3045/
  12198. 2013-12-09 19:24 +0000 [r403544-403560] Richard Mudgett <rmudgett@digium.com>
  12199. * /, res/res_sorcery_astdb.c: Reverting regex part of -r403545 at
  12200. request of file. res_sorcery_astdb.c: Fix get multiple records by
  12201. regex. * Fix sorcery_astdb_retrieve_regex() pattern matching. Let
  12202. the regexec() function match the stored key values instead of
  12203. having astdb prefilter them. Previoiusly you could only use a
  12204. simple regex pattern when the pattern began with '^'. ........
  12205. Merged revisions 403559 from
  12206. http://svn.asterisk.org/svn/asterisk/branches/12
  12207. * /, res/res_sorcery_astdb.c: res_sorcery_astdb.c: Fix get multiple
  12208. records by regex. * Fix sorcery_astdb_retrieve_regex() pattern
  12209. matching. Let the regexec() function match the stored key values
  12210. instead of having astdb prefilter them. Previoiusly you could
  12211. only use a simple regex pattern when the pattern began with '^'.
  12212. * Fix off nominal memory leak in sorcery_astdb_retrieve_regex().
  12213. ........ Merged revisions 403545 from
  12214. http://svn.asterisk.org/svn/asterisk/branches/12
  12215. * main/sorcery.c, /: sorcery: Eliminate shadowing a varaible that
  12216. caused confusion. * Eliminated shadowing of the
  12217. __ast_sorcery_apply_config() name parameter causing confusion. *
  12218. Fix potential crash from sorcery.conf user input in
  12219. __ast_sorcery_apply_config() if the user supplied a malformed
  12220. config line that is missing the sorcery object type name. *
  12221. Remove redundant test in __ast_sorcery_apply_config(). !config
  12222. and config == CONFIGS_STATUS_FILEMISSING are identical. ........
  12223. Merged revisions 403541 from
  12224. http://svn.asterisk.org/svn/asterisk/branches/12
  12225. 2013-12-09 18:32 +0000 [r403543] Joshua Colp <jcolp@digium.com>
  12226. * /, main/endpoints.c: endpoints: Keep a reference to channel ids
  12227. when creating snapshot. The snapshot process for endpoints uses
  12228. the channel ids present on the endpoint itself. Without keeping a
  12229. reference it was possible for the strings to be freed underneath
  12230. any consumer of an endpoint snapshot. A reference is now held by
  12231. the snapshot to the channel ids and released when the snapshot is
  12232. destroyed. (issue ASTERISK-22801) Reported by: Matt Jordan
  12233. ........ Merged revisions 403542 from
  12234. http://svn.asterisk.org/svn/asterisk/branches/12
  12235. 2013-12-09 18:14 +0000 [r403528] Richard Mudgett <rmudgett@digium.com>
  12236. * main/sorcery.c, /: sorcery: Whitespace You would think that a new
  12237. file would start off without any whitespace oddities. ........
  12238. Merged revisions 403527 from
  12239. http://svn.asterisk.org/svn/asterisk/branches/12
  12240. 2013-12-09 17:29 +0000 [r403512-403526] Mark Michelson <mmichelson@digium.com>
  12241. * apps/app_confbridge.c, CHANGES,
  12242. apps/confbridge/conf_state_multi_marked.c: Add a
  12243. CONFBRIDGE_RESULT channel variable to discern why a channel left
  12244. a ConfBridge. Review: https://reviewboard.asterisk.org/r/3009
  12245. * CHANGES, apps/app_mixmonitor.c: Create function for retrieving
  12246. Mixmonitor instance data. For the time, this is only useful for
  12247. retrieving the filename. The purpose of this function is to
  12248. better facilitate multiple mixmonitors per channel. Setting a
  12249. MIXMONITOR_FILENAME channel variable is not conducive to such
  12250. behavior, so allowing finer grained access to individual
  12251. mixmonitor properties improves the situation. The
  12252. MIXMONITOR_FILENAME channel variable is still set, though, so
  12253. there is no worry about backwards compatibility. Review:
  12254. https://reviewboard.asterisk.org/r/3023
  12255. 2013-12-09 16:41 +0000 [r403511] Joshua Colp <jcolp@digium.com>
  12256. * res/res_pjsip_nat.c, /: res_pjsip_nat: Add NAT module to session
  12257. dialogs. Due to the way pjproject internally works it was
  12258. possible for the NAT module to not be invoked on messages with-in
  12259. a session dialog. This means that the various parts of the
  12260. message would not get rewritten with the source IP address and
  12261. port. This change uses a session supplement to add the NAT module
  12262. to the dialog on the first incoming or outgoing INVITE. (closes
  12263. issue ASTERISK-22941) Reported by: Leif Madsen ........ Merged
  12264. revisions 403510 from
  12265. http://svn.asterisk.org/svn/asterisk/branches/12
  12266. 2013-12-09 16:10 +0000 [r403499] Mark Michelson <mmichelson@digium.com>
  12267. * res/res_pjsip/config_auth.c,
  12268. res/res_pjsip_outbound_authenticator_digest.c,
  12269. res/res_pjsip_authenticator_digest.c,
  12270. res/res_pjsip_outbound_registration.c,
  12271. res/res_pjsip/pjsip_configuration.c,
  12272. res/res_pjsip/pjsip_distributor.c, res/res_pjsip.c,
  12273. include/asterisk/res_pjsip.h: Switch PJSIP auth to use a vector.
  12274. Since Asterisk has a vector API now, places where arrays are
  12275. manually resized don't really make sense any more. Since the auth
  12276. work in PJSIP was freshly-written, it was easy to reform it to
  12277. use a vector. Review: https://reviewboard.asterisk.org/r/3044
  12278. 2013-12-09 03:21 +0000 [r403436-403466] Matthew Jordan <mjordan@digium.com>
  12279. * /, res/res_fax_spandsp.c: res_fax_spandsp: Always init T.38
  12280. session to avoid crashes during state change Prior to this patch,
  12281. res_fax_spandsp was conservative with how it initialized the
  12282. spandsp T.38 context. It would only initialize it if the driver
  12283. thought the current state was a T.38 fax. While this works fine
  12284. in nominal situations, in certain off nominal situations,
  12285. res_fax_spandsp can believe that a T.38 fax will not occur when
  12286. in fact one has started. In particular, this was discovered when
  12287. res_fax would fall back to audio after timing out on a T.38
  12288. upgrade. The SIP channel driver would continue to retry the
  12289. re-INVITE and - if the remote end responded after res_fax timed
  12290. out with a 200 OK - a T.38 frame would be delivered to the
  12291. res_fax stack when it no longer expected it. As it turns out,
  12292. there does not appear to be any downside to always initializing
  12293. the T.38 context, other than the actual memory allocation. Since
  12294. that avoids this off nominal situation (and others which are
  12295. equally likely hard to predict), this is the safest way to avoid
  12296. this problem. Much thanks to Torrey as well for providing a
  12297. scenario that reproduces this issue. (closes issue
  12298. ASTERISK-21242) Reported by: Ashley Winters Tested by: Torrey
  12299. Searle patches: always-init-t38.patch uploaded by awinters
  12300. (License 6477) A_PARTY.xml uploaded by tsearle (License 5334)
  12301. ........ Merged revisions 403449 from
  12302. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12303. revisions 403450 from
  12304. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  12305. revisions 403458 from
  12306. http://svn.asterisk.org/svn/asterisk/branches/12
  12307. * /, res/res_config_sqlite.c: res_config_sqlite: Check for CDR
  12308. unregistration failures If the CDR unregistration fails due to an
  12309. inflight CDR, the res_config_sqlite module needs to bail on
  12310. unloading itself. Otherwise, the config could be unloaded
  12311. (including the CDR table name) while the CDR engine posts a CDR
  12312. to the still registered backend, resulting in a crash. ........
  12313. Merged revisions 403435 from
  12314. http://svn.asterisk.org/svn/asterisk/branches/12
  12315. 2013-12-05 23:40 +0000 [r403414] Jonathan Rose <jrose@digium.com>
  12316. * apps/app_record.c: app_record: Add an option that allows DTMF '0'
  12317. to act as an additional terminator Using this terminator when
  12318. active results in ${RECORD_STATUS} being set to 'OPERATOR'
  12319. instead of 'DTMF' (closes issue AFS-7) Review:
  12320. https://reviewboard.asterisk.org/r/3041/
  12321. 2013-12-05 22:10 +0000 [r403402-403404] David M. Lee <dlee@digium.com>
  12322. * addons/chan_mobile.c, main/bridge_channel.c, tests/test_cdr.c,
  12323. channels/chan_pjsip.c, res/parking/parking_manager.c,
  12324. channels/chan_mgcp.c, channels/chan_unistim.c, main/pbx.c, /,
  12325. apps/app_meetme.c, funcs/func_timeout.c, main/bridge.c,
  12326. tests/test_stasis_channels.c, main/core_unreal.c,
  12327. include/asterisk/channel.h, channels/chan_gtalk.c, main/cel.c,
  12328. apps/app_queue.c, channels/sig_pri.c, main/stasis_bridges.c,
  12329. channels/chan_jingle.c, channels/chan_phone.c,
  12330. channels/chan_dahdi.c, main/dial.c, channels/sig_analog.c,
  12331. include/asterisk/stasis_channels.h, res/res_agi.c,
  12332. channels/chan_motif.c, channels/chan_h323.c, tests/test_cel.c,
  12333. apps/app_confbridge.c, res/res_stasis.c, res/res_pjsip_refer.c,
  12334. apps/app_voicemail.c, apps/app_dial.c, channels/chan_vpb.cc,
  12335. addons/chan_ooh323.c, channels/chan_sip.c, main/pickup.c,
  12336. include/asterisk/aoc.h, include/asterisk/stasis_bridges.h,
  12337. apps/app_userevent.c, apps/app_disa.c, main/core_local.c,
  12338. include/asterisk/channelstate.h, channels/chan_console.c,
  12339. channels/chan_iax2.c, main/endpoints.c, channels/chan_oss.c,
  12340. res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  12341. main/channel.c, channels/chan_misdn.c, channels/chan_skinny.c,
  12342. pbx/pbx_realtime.c, channels/chan_alsa.c, main/stasis_channels.c,
  12343. channels/chan_nbs.c: Reverting r403311. It's causing ARI tests to
  12344. hang. ........ Merged revisions 403398 from
  12345. http://svn.asterisk.org/svn/asterisk/branches/12
  12346. * /, res/stasis/control.c: ari: Fix deadlock problem with functions
  12347. that use autoservice. The code for getting channel variables from
  12348. ARI assumed that you needed to lock the channel in order to
  12349. properly execute functions and read channel variables.
  12350. Apparently, this is not the case, since any dialplan function
  12351. that puts the channel into autoservice deadlocks when attempting
  12352. to remove the channel from autoservice. ........ Merged revisions
  12353. 403342 from http://svn.asterisk.org/svn/asterisk/branches/12
  12354. * /: Multiple revisions 403304,403310 ........ r403304 | dlee |
  12355. 2013-12-02 12:34:50 -0600 (Mon, 02 Dec 2013) | 1 line Fixed the
  12356. filename for the ari.conf docs ........ r403310 | file |
  12357. 2013-12-03 10:32:12 -0600 (Tue, 03 Dec 2013) | 5 lines Revert
  12358. revision 403304: Fixed the filename for the ari.conf docs The
  12359. changed value refers to the name of the module. The name of the
  12360. configuration file is specified in the configFile section.
  12361. ........ Merged revisions 403304,403310 from
  12362. http://svn.asterisk.org/svn/asterisk/branches/12
  12363. 2013-12-04 21:42 +0000 [r403378] Kevin Harwell <kharwell@digium.com>
  12364. * /, res/res_pjsip_registrar.c: res_pjsip_registrar: undefined
  12365. function pointer symbol Used a static wrapper around the
  12366. offending function to alleviate the issue. Reported by: rmudgett
  12367. ........ Merged revisions 403377 from
  12368. http://svn.asterisk.org/svn/asterisk/branches/12
  12369. 2013-12-04 20:54 +0000 [r403365] Joshua Colp <jcolp@digium.com>
  12370. * res/res_pjsip_t38.c, /: res_pjsip_t38: Don't pass T.38 control
  12371. frames through to other hooks. This crept up during gateway
  12372. testing where the gateway would receive the request to negotiate
  12373. and assume it came from the remote side, causing the gateway
  12374. state machine to go a little, to a use a technical term, "wonky".
  12375. ........ Merged revisions 403364 from
  12376. http://svn.asterisk.org/svn/asterisk/branches/12
  12377. 2013-12-04 18:41 +0000 [r403350] Mark Michelson <mmichelson@digium.com>
  12378. * /, res/res_pjsip.c: Initialize the hash value argument to
  12379. pj_hash_get() to 0. Passing a non-zero value causes PJLIB to use
  12380. the given input as the hash value. Passing zero causes the
  12381. parameter to become an output parameter that receives the hash
  12382. value that was computed based on the given key. This change
  12383. essentially makes ast_sip_dict_get() properly retrieve the
  12384. desired value. ........ Merged revisions 403349 from
  12385. http://svn.asterisk.org/svn/asterisk/branches/12
  12386. 2013-12-03 18:01 +0000 [r403330] Joshua Colp <jcolp@digium.com>
  12387. * /, configure, include/asterisk/autoconfig.h.in, configure.ac,
  12388. res/res_pjsip_session.c: res_pjsip_session: Add support for
  12389. PJMEDIA_SDP_NEG_ALLOW_MEDIA_CHANGE flag. Newer versions of PJSIP
  12390. have changed to using a flag for the
  12391. PJMEDIA_SDP_NEG_ALLOW_MEDIA_CHANGE instead of a define. This adds
  12392. a configure check to detect the presence of the flag and use it
  12393. if found. ........ Merged revisions 403329 from
  12394. http://svn.asterisk.org/svn/asterisk/branches/12
  12395. 2013-12-03 17:35 +0000 [r403327] Richard Mudgett <rmudgett@digium.com>
  12396. * include/asterisk/sorcery.h, res/res_pjsip/pjsip_configuration.c,
  12397. res/res_pjsip_registrar_expire.c, res/res_pjsip/pjsip_options.c,
  12398. tests/test_sorcery.c, include/asterisk/bucket.h, main/sorcery.c,
  12399. /, main/bucket.c: sorcery, bucket: Change observer remove calls
  12400. to take const callbacks struct. * Make
  12401. ast_sorcery_observer_remove() accept a const callbacks struct. *
  12402. Make ast_sorcery_observer_remove() tolerant of the sorcery
  12403. parameter being NULL. Now it can be called within a module unload
  12404. routine if the sorcery initialization fails. * Fix
  12405. ast_sorcery_observer_add() to fail if the container link fails.
  12406. ........ Merged revisions 403324 from
  12407. http://svn.asterisk.org/svn/asterisk/branches/12
  12408. 2013-12-03 17:07 +0000 [r403314] Mark Michelson <mmichelson@digium.com>
  12409. * channels/chan_nbs.c, main/bridge_channel.c, res/res_stasis.c,
  12410. channels/chan_pjsip.c, res/parking/parking_manager.c,
  12411. apps/app_voicemail.c, channels/chan_unistim.c,
  12412. channels/chan_vpb.cc, addons/chan_ooh323.c, /,
  12413. include/asterisk/aoc.h, apps/app_meetme.c, main/bridge.c,
  12414. apps/app_userevent.c, channels/chan_gtalk.c,
  12415. channels/chan_iax2.c, main/endpoints.c, main/stasis_bridges.c,
  12416. main/channel.c, channels/chan_phone.c, channels/chan_dahdi.c,
  12417. main/dial.c, channels/sig_analog.c, channels/chan_skinny.c,
  12418. res/res_agi.c, channels/chan_motif.c, pbx/pbx_realtime.c,
  12419. channels/chan_alsa.c, main/stasis_channels.c,
  12420. apps/app_confbridge.c, addons/chan_mobile.c, tests/test_cdr.c,
  12421. res/res_pjsip_refer.c, channels/chan_mgcp.c, apps/app_dial.c,
  12422. main/pbx.c, channels/chan_sip.c, main/pickup.c,
  12423. funcs/func_timeout.c, tests/test_stasis_channels.c,
  12424. main/core_unreal.c, include/asterisk/stasis_bridges.h,
  12425. apps/app_disa.c, include/asterisk/channel.h, main/core_local.c,
  12426. include/asterisk/channelstate.h, channels/chan_console.c,
  12427. main/cel.c, apps/app_queue.c, channels/sig_pri.c,
  12428. channels/chan_oss.c, res/parking/parking_bridge_features.c,
  12429. apps/app_agent_pool.c, channels/chan_jingle.c,
  12430. channels/chan_misdn.c, include/asterisk/stasis_channels.h,
  12431. channels/chan_h323.c, tests/test_cel.c: Add channel locking for
  12432. channel snapshot creation. This adds channel locks around calls
  12433. to create channel snapshots as well as other functions which
  12434. operate on a channel and then end up creating a channel snapshot.
  12435. Functions that expect the channel to be locked prior to being
  12436. called have had their documentation updated to indicate such.
  12437. ........ Merged revisions 403311 from
  12438. http://svn.asterisk.org/svn/asterisk/branches/12
  12439. 2013-12-03 16:39 +0000 [r403313] Joshua Colp <jcolp@digium.com>
  12440. * main/media_index.c, /: media_index: Make media indexing tolerable
  12441. of bad symlinks. Media indexing will now skip over files and
  12442. directories that stat will not return information about. This can
  12443. occur under normal conditions when a symbolic link points to a
  12444. location that no longer exists. ........ Merged revisions 403312
  12445. from http://svn.asterisk.org/svn/asterisk/branches/12
  12446. 2013-12-02 18:12 +0000 [r403292] Alexandr Anikin <may@telecom-service.ru>
  12447. * addons/chan_ooh323.c, /: Check and reject non-digits e164 values
  12448. on peers and general sections in ooh323.conf Regenerate e164
  12449. endpoint list on reload ooh323 (issue ASTERISK-22901) Reported
  12450. by: Cyril CONSTANTIN Patches: ASTERISK-22901.patch ........
  12451. Merged revisions 403288 from
  12452. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  12453. revisions 403290 from
  12454. http://svn.asterisk.org/svn/asterisk/branches/12
  12455. 2013-12-01 21:13 +0000 [r403257-403272] Joshua Colp <jcolp@digium.com>
  12456. * /, res/res_pjsip_session.c: res_pjsip_session: Apply fromuser and
  12457. fromdomain to all requests as documented. ........ Merged
  12458. revisions 403271 from
  12459. http://svn.asterisk.org/svn/asterisk/branches/12
  12460. * res/res_pjsip_t38.c, /: res_pjsip_t38: Add the framehook to the
  12461. channel only on first INVITE. The check for determining whether
  12462. the T.38 framehook should be added to the channel or not has now
  12463. been changed to guarantee adding only occurs on the first
  12464. incoming or outgoing INVITE. ........ Merged revisions 403258
  12465. from http://svn.asterisk.org/svn/asterisk/branches/12
  12466. * res/res_pjsip/security_events.c, res/res_pjsip/pjsip_options.c,
  12467. res/res_pjsip.c, res/res_pjsip_transport_websocket.c,
  12468. include/asterisk/res_pjsip.h, /, res/res_pjsip/location.c:
  12469. res_pjsip_transport_websocket: Fix security events and simplify
  12470. implementation. Transport type determination for security events
  12471. has been simplified to use the type present on the message itself
  12472. instead of searching through configured transports to find the
  12473. transport used. The actual WebSocket transport has also been
  12474. simplified. It now leverages the existing PJSIP transport manager
  12475. for finding the active WebSocket transport for outgoing messages.
  12476. This removes the need for res_pjsip_transport_websocket to store
  12477. a mapping itself. (closes issue ASTERISK-22897) Reported by: Max
  12478. E. Reyes Vera J. Review: https://reviewboard.asterisk.org/r/3036/
  12479. ........ Merged revisions 403256 from
  12480. http://svn.asterisk.org/svn/asterisk/branches/12
  12481. 2013-11-30 14:12 +0000 [r403241] Joshua Colp <jcolp@digium.com>
  12482. * res/ari/ari_model_validators.h, rest-api/api-docs/events.json, /,
  12483. res/ari/ari_model_validators.c: res_ari: Add Recording events to
  12484. the validator. ........ Merged revisions 403240 from
  12485. http://svn.asterisk.org/svn/asterisk/branches/12
  12486. 2013-11-28 02:12 +0000 [r403208-403224] Joshua Colp <jcolp@digium.com>
  12487. * res/res_pjsip_sdp_rtp.c, /: res_pjsip_sdp_rtp: Don't produce an
  12488. invalid media stream with no formats. Depending on configuration
  12489. it was possible for a media stream to be created without any
  12490. media formats. The produced SDP would fail internal validation
  12491. and cause a crash. The code will now no longer add media streams
  12492. with no formats to the SDP, allowing it to pass validation and
  12493. work. (closes issue ASTERISK-22858) Reported by: Anthony Messina
  12494. ........ Merged revisions 403223 from
  12495. http://svn.asterisk.org/svn/asterisk/branches/12
  12496. * res/res_pjsip_header_funcs.c, /: res_pjsip_header_funcs: Don't
  12497. add headers to re-INVITEs. When sending a re-INVITE to an
  12498. endpoint it was possible for received headers to be added as well
  12499. (since they are stored for retrieval using the PJSIP_HEADER
  12500. dialplan function). This caused a broken (and potentially large)
  12501. SIP INVITE to be produced and sent. This changes the module so it
  12502. will no longer add headers to re-INVITEs. (closes issue
  12503. ASTERISK-22882) Reported by: David M. Lee ........ Merged
  12504. revisions 403221 from
  12505. http://svn.asterisk.org/svn/asterisk/branches/12
  12506. * res/res_stasis_playback.c, /: res_stasis_playback: Add 'number',
  12507. 'digits', and 'characters' URI scheme implementations. This
  12508. change adds new URI scheme implementations for playing numbers,
  12509. digits, and characters. This is done as part of the normal
  12510. playback mechanism and can be used with queueing to create a
  12511. combined sentence. Review:
  12512. https://reviewboard.asterisk.org/r/3028/ ........ Merged
  12513. revisions 403209 from
  12514. http://svn.asterisk.org/svn/asterisk/branches/12
  12515. * /, res/res_pjsip/pjsip_configuration.c, res/res_pjsip.c,
  12516. res/res_pjsip_session.c, include/asterisk/res_pjsip.h:
  12517. res_pjsip_session: Add configurable behavior for redirects. The
  12518. action taken when a redirect occurs is now configurable on a
  12519. per-endpoint basis. The redirect can either be treated as a
  12520. redirect to a local extension, to a URI that is dialed through
  12521. the Asterisk core, or to a URI that is dialed within PJSIP
  12522. itself. (closes issue ASTERISK-21710) Reported by: Matt Jordan
  12523. Review: https://reviewboard.asterisk.org/r/2963/ ........ Merged
  12524. revisions 403207 from
  12525. http://svn.asterisk.org/svn/asterisk/branches/12
  12526. 2013-11-27 17:32 +0000 [r403192] Richard Mudgett <rmudgett@digium.com>
  12527. * include/asterisk/astdb.h: astdb: Tweak some doxygen comments.
  12528. 2013-11-27 16:12 +0000 [r403180] Joshua Colp <jcolp@digium.com>
  12529. * /, res/res_pjsip/pjsip_configuration.c: res_pjsip: Fix crash when
  12530. reloading certain configurations. Certain options available that
  12531. specify a SIP URI perform validation on the provided URI using
  12532. the PJSIP URI parser. This operation requires that the thread
  12533. executing it be registered with the PJLIB library. During reloads
  12534. this was done on a thread which was NOT registered with it. This
  12535. fixes the problem by creating a task which reloads the
  12536. configuration on a PJSIP thread. (closes issue ASTERISK-22923)
  12537. Reported by: Anthony Messina ........ Merged revisions 403179
  12538. from http://svn.asterisk.org/svn/asterisk/branches/12
  12539. 2013-11-27 15:48 +0000 [r403177] David M. Lee <dlee@digium.com>
  12540. * res/res_ari_channels.c, include/asterisk/ari.h,
  12541. rest-api-templates/param_parsing.mustache,
  12542. include/asterisk/http.h, res/res_ari_recordings.c,
  12543. res/res_ari_endpoints.c, main/http.c,
  12544. rest-api-templates/swagger_model.py, res/res_ari_playbacks.c,
  12545. res/res_ari_sounds.c, rest-api-templates/asterisk_processor.py,
  12546. res/res_ari_bridges.c, tests/test_ari.c, res/res_ari.c, /,
  12547. res/res_ari_device_states.c, res/res_ari_asterisk.c,
  12548. rest-api-templates/res_ari_resource.c.mustache,
  12549. res/res_ari_applications.c: ari:Add application/json parameter
  12550. support The patch allows ARI to parse request parameters from an
  12551. incoming JSON request body, instead of requiring the request to
  12552. come in as query parameters (which is just weird for POST and
  12553. DELETE) or form parameters (which is okay, but a bit asymmetric
  12554. given that all of our responses are JSON). For any operation that
  12555. does _not_ have a parameter defined of type body (i.e.
  12556. "paramType": "body" in the API declaration), if a request
  12557. provides a request body with a Content type of
  12558. "application/json", the provided JSON document is parsed and
  12559. searched for parameters. The expected fields in the provided JSON
  12560. document should match the query parameters defined for the
  12561. operation. If the parameter has 'allowMultiple' set, then the
  12562. field in the JSON document may optionally be an array of values.
  12563. (closes issue ASTERISK-22685) Review:
  12564. https://reviewboard.asterisk.org/r/2994/
  12565. 2013-11-27 15:31 +0000 [r403161-403174] Joshua Colp <jcolp@digium.com>
  12566. * /, res/res_pjsip/pjsip_configuration.c: res_pjsip: Update
  12567. handling of some options to work with new option names. Some
  12568. options (such as call_group and pickup_group) share the same
  12569. configuration handler and decide what logic to use based on the
  12570. name of the option. These handlers were not updated to check for
  12571. the new option names and were treating the options as invalid.
  12572. This change simply updates the handlers with the proper names of
  12573. the options. (closes issue ASTERISK-22922) Reported by: Anthony
  12574. Messina ........ Merged revisions 403173 from
  12575. http://svn.asterisk.org/svn/asterisk/branches/12
  12576. * /, configure, include/asterisk/autoconfig.h.in, configure.ac: Fix
  12577. a configure issue with PJSIP transaction group lock detection.
  12578. The configure check did not use the provided paths for pjproject
  12579. if provided when looking for transaction group lock support.
  12580. ........ Merged revisions 403160 from
  12581. http://svn.asterisk.org/svn/asterisk/branches/12
  12582. 2013-11-23 17:48 +0000 [r403133-403135] Kevin Harwell <kharwell@digium.com>
  12583. * res/ari.make, rest-api/api-docs/applications.json,
  12584. res/ari/resource_device_states.h (added),
  12585. include/asterisk/stasis_app_device_state.h (added),
  12586. res/ari/resource_applications.h, res/res_stasis.c,
  12587. include/asterisk/devicestate.h, rest-api/api-docs/events.json,
  12588. res/res_stasis_device_state.exports.in (added), res/stasis/app.c,
  12589. res/res_ari_device_states.c (added), /,
  12590. include/asterisk/stasis_app.h, main/devicestate.c,
  12591. res/stasis/app.h, rest-api/resources.json,
  12592. res/res_stasis_device_state.c (added),
  12593. res/ari/ari_model_validators.c, res/ari/ari_model_validators.h,
  12594. res/ari/resource_device_states.c (added),
  12595. rest-api/api-docs/deviceStates.json (added),
  12596. rest-api-templates/ari.make.mustache: ARI: Implement device state
  12597. API Created a data model and implemented functionality for an ARI
  12598. device state resource. The following operations have been added
  12599. that allow a user to manipulate an ARI controlled device:
  12600. Create/Change the state of an ARI controlled device PUT
  12601. /deviceStates/{deviceName}&{deviceState} Retrieve all ARI
  12602. controlled devices GET /deviceStates Retrieve the current state
  12603. of a device GET /deviceStates/{deviceName} Destroy a device-state
  12604. controlled by ARI DELETE /deviceStates/{deviceName} The ARI
  12605. controlled device must begin with 'Stasis:'. An example
  12606. controlled device name would be Stasis:Example. A
  12607. 'DeviceStateChanged' event has also been added so that an
  12608. application can subscribe and receive device change events. Any
  12609. device state, ARI controlled or not, can be subscribed to. While
  12610. adding the event, the underlying subscription control mechanism
  12611. was refactored so that all current and future resource
  12612. subscriptions would be the same. Each event resource must now
  12613. register itself in order to be able to properly handle
  12614. [un]subscribes. (issue ASTERISK-22838) Reported by: Matt Jordan
  12615. Review: https://reviewboard.asterisk.org/r/3025/ ........ Merged
  12616. revisions 403134 from
  12617. http://svn.asterisk.org/svn/asterisk/branches/12
  12618. * res/res_pjsip_registrar.c, main/sorcery.c,
  12619. include/asterisk/res_pjsip.h, include/asterisk/acl.h,
  12620. res/res_pjsip/config_auth.c, include/asterisk/utils.h,
  12621. res/res_pjsip.exports.in, /,
  12622. res/res_pjsip_endpoint_identifier_ip.c, main/acl.c, main/utils.c,
  12623. res/res_pjsip.c, res/res_pjsip_exten_state.c,
  12624. include/asterisk/res_pjsip_pubsub.h, res/res_pjsip/location.c,
  12625. res/res_pjsip_outbound_registration.c, res/res_pjsip_mwi.c,
  12626. res/res_pjsip/pjsip_configuration.c, include/asterisk/sorcery.h,
  12627. include/asterisk/strings.h,
  12628. res/res_pjsip/include/res_pjsip_private.h,
  12629. res/res_pjsip_pubsub.c, res/res_pjsip/config_transport.c:
  12630. res_pjsip: AMI commands and events. Created the following AMI
  12631. commands and corresponding events for res_pjsip:
  12632. PJSIPShowEndpoints - Provides a listing of all pjsip endpoints
  12633. and a few select attributes on each. Events: EndpointList - for
  12634. each endpoint a few attributes. EndpointlistComplete - after all
  12635. endpoints have been listed. PJSIPShowEndpoint - Provides a detail
  12636. list of attributes for a specified endpoint. Events:
  12637. EndpointDetail - attributes on an endpoint. AorDetail - raised
  12638. for each AOR on an endpoint. AuthDetail - raised for each
  12639. associated inbound and outbound auth TransportDetail - transport
  12640. attributes. IdentifyDetail - attributes for the identify object
  12641. associated with the endpoint. EndpointDetailComplete - last event
  12642. raised after all detail events. PJSIPShowRegistrationsInbound -
  12643. Provides a detail listing of all inbound registrations. Events:
  12644. InboundRegistrationDetail - inbound registration attributes for
  12645. each registration. InboundRegistrationDetailComplete - raised
  12646. after all detail records have been listed.
  12647. PJSIPShowRegistrationsOutbound - Provides a detail listing of all
  12648. outbound registrations. Events: OutboundRegistrationDetail -
  12649. outbound registration attributes for each registration.
  12650. OutboundRegistrationDetailComplete - raised after all detail
  12651. records have been listed. PJSIPShowSubscriptionsInbound - A
  12652. detail listing of all inbound subscriptions and their attributes.
  12653. Events: SubscriptionDetail - on each subscription detailed
  12654. attributes SubscriptionDetailComplete - raised after all detail
  12655. records have been listed. PJSIPShowSubscriptionsOutbound - A
  12656. detail listing of all outboundbound subscriptions and their
  12657. attributes. Events: SubscriptionDetail - on each subscription
  12658. detailed attributes SubscriptionDetailComplete - raised after all
  12659. detail records have been listed. (issue ASTERISK-22609) Reported
  12660. by: Matt Jordan Review: https://reviewboard.asterisk.org/r/2959/
  12661. ........ Merged revisions 403131 from
  12662. http://svn.asterisk.org/svn/asterisk/branches/12
  12663. 2013-11-23 12:52 +0000 [r403118-403120] Joshua Colp <jcolp@digium.com>
  12664. * res/res_stasis_playback.c, rest-api/api-docs/events.json, /,
  12665. res/res_stasis_recording.c, res/ari/ari_model_validators.c,
  12666. rest-api/api-docs/recordings.json,
  12667. res/ari/ari_model_validators.h: ari: Add events for playback and
  12668. recording. While there were events defined for playback and
  12669. recording these were not actually sent. This change implements
  12670. the to_json handlers which produces them. (closes issue
  12671. ASTERISK-22710) Reported by: Jonathan Rose Review:
  12672. https://reviewboard.asterisk.org/r/3026/ ........ Merged
  12673. revisions 403119 from
  12674. http://svn.asterisk.org/svn/asterisk/branches/12
  12675. * res/res_stasis_snoop.exports.in (added), /,
  12676. include/asterisk/stasis_app_snoop.h (added),
  12677. rest-api/api-docs/channels.json, res/res_stasis_snoop.c (added),
  12678. main/audiohook.c, res/ari/resource_channels.c,
  12679. res/res_ari_channels.c, res/ari/resource_channels.h: ari: Add
  12680. Snoop operation for spying/whispering on channels. The Snoop
  12681. operation can be invoked on a channel to spy or whisper on it. It
  12682. returns a channel that any channel operations can then be invoked
  12683. on (such as record to do monitoring). (closes issue
  12684. ASTERISK-22780) Reported by: Matt Jordan Review:
  12685. https://reviewboard.asterisk.org/r/3003/ ........ Merged
  12686. revisions 403117 from
  12687. http://svn.asterisk.org/svn/asterisk/branches/12
  12688. 2013-11-23 00:22 +0000 [r403106] Rusty Newton <rnewton@digium.com>
  12689. * apps/app_voicemail.c: app_voicemail: when forwarding a message,
  12690. play vm-msgforwarded instead of vm-msgsaved In the last release
  12691. of sounds, 1.4.25 we added a vm-msgforwarded prompt for various
  12692. core languages. Now we use that prompt. (issue ASTERISK-21413)
  12693. (closes issue ASTERISK-21413) Reported by: netwrkr Tested by:
  12694. newtonr
  12695. 2013-11-22 23:57 +0000 [r403095] Kinsey Moore <kmoore@digium.com>
  12696. * tests/test_stasis.c, /, tests/test_stasis_channels.c: Make sure
  12697. unit tests compile This fixes the unit tests that were broken by
  12698. r403069 and several functions requiring a new parameter for
  12699. sanitization of JSON messages generated from object snapshots.
  12700. ........ Merged revisions 403094 from
  12701. http://svn.asterisk.org/svn/asterisk/branches/12
  12702. 2013-11-22 22:37 +0000 [r403083] Kevin Harwell <kharwell@digium.com>
  12703. * /,
  12704. contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py,
  12705. res/res_pjsip/pjsip_configuration.c: res_pjsip: convert
  12706. configuration settings names to snake case some more Updated the
  12707. alembic script for pjsip. Also, the dtls config parsing stuff was
  12708. expecting strings with no underscores, so removed the underscores
  12709. from the option name before passing it to the parser. ........
  12710. Merged revisions 403082 from
  12711. http://svn.asterisk.org/svn/asterisk/branches/12
  12712. 2013-11-22 20:10 +0000 [r403070] Kinsey Moore <kmoore@digium.com>
  12713. * res/res_stasis.c, main/stasis_endpoints.c,
  12714. res/ari/resource_endpoints.c, main/rtp_engine.c, /,
  12715. res/stasis/app.c, include/asterisk/stasis_bridges.h,
  12716. include/asterisk/stasis.h, include/asterisk/stasis_app.h,
  12717. main/stasis_bridges.c, res/ari/resource_bridges.c, main/json.c,
  12718. main/stasis_message.c, include/asterisk/stasis_channels.h,
  12719. main/stasis_channels.c, res/ari/resource_channels.c,
  12720. include/asterisk/stasis_endpoints.h: ARI: Don't leak
  12721. implementation details This change prevents channels used as
  12722. implementation details from leaking out to ARI. It does this by
  12723. preventing creation of JSON blobs of channel snapshots created
  12724. from those channels and sanitizing JSON blobs of bridge snapshots
  12725. as they are created. This introduces a framework for excluding
  12726. information from output targeted at Stasis applications on a
  12727. consumer-by-consumer basis using channel sanitization callbacks
  12728. which could be extended to bridges or endpoints if necessary.
  12729. This prevents unhelpful error messages from being generated by
  12730. ast_json_pack. This also corrects a bug where BridgeCreated
  12731. events would not be created. (closes issue ASTERISK-22744)
  12732. Review: https://reviewboard.asterisk.org/r/2987/ Reported by:
  12733. David M. Lee ........ Merged revisions 403069 from
  12734. http://svn.asterisk.org/svn/asterisk/branches/12
  12735. 2013-11-22 17:27 +0000 [r403051] Kevin Harwell <kharwell@digium.com>
  12736. * res/res_pjsip_acl.c, res/res_pjsip.c,
  12737. res/res_pjsip/config_transport.c, res/res_pjsip/config_global.c,
  12738. /, configs/pjsip.conf.sample, res/res_pjsip/config_system.c,
  12739. contrib/scripts/sip_to_pjsip/sip_to_pjsip.py,
  12740. res/res_pjsip/pjsip_configuration.c: res_pjsip: convert
  12741. configuration settings names to snake case Renamed, where
  12742. appropriate, the configuration options for chan/res_pjsip to use
  12743. snake case (compound words separated by an underscore). For
  12744. example, faxdetect will become fax_detect, recordofffeature will
  12745. become record_off_feature, etc... Review:
  12746. https://reviewboard.asterisk.org/r/3002/ ........ Merged
  12747. revisions 403022 from
  12748. http://svn.asterisk.org/svn/asterisk/branches/12
  12749. 2013-11-22 17:12 +0000 [r403017] Joshua Colp <jcolp@digium.com>
  12750. * /, main/translate.c: translate: Move freeing of frame to after it
  12751. is used. When translating from one format to another it is
  12752. possible to inform the translation function that the source frame
  12753. should be freed. This was previously done immediately but shortly
  12754. afterwards the frame that was freed was accessed and used again.
  12755. This change moves code around a bit so that the frame is now
  12756. freed after it has been completely used. (closes issue
  12757. ASTERISK-22788) Reported by: Corey Farrell Patches:
  12758. translate-access-after-free-11up.patch uploaded by coreyfarrell
  12759. (license 5909) translate-access-after-free-1.8.patch uploaded by
  12760. coreyfarrell (license 5909) ........ Merged revisions 403014 from
  12761. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12762. revisions 403015 from
  12763. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  12764. revisions 403016 from
  12765. http://svn.asterisk.org/svn/asterisk/branches/12
  12766. 2013-11-22 16:43 +0000 [r403013] Richard Mudgett <rmudgett@digium.com>
  12767. * apps/app_directed_pickup.c, CHANGES: PickupChan: Add ability to
  12768. specify channel uniqueids as well as channel names. * Made
  12769. PickupChan() search by channel uniqueids if the search could not
  12770. find a channel by name. * Ensured PickupChan() never considers
  12771. the picking channel for pickup. * Made PickupChan() option p use
  12772. a common search by name routine. The original search was
  12773. erroneously case sensitive. (issue AFS-42) Review:
  12774. https://reviewboard.asterisk.org/r/3017/
  12775. 2013-11-21 22:38 +0000 [r402995] Jonathan Rose <jrose@digium.com>
  12776. * CHANGES, apps/app_directory.c: app_directory: Set variable
  12777. indicating reason directory exited By the time the directory
  12778. application exits, a channel variable DIRECTORY_RESULT will be
  12779. set for the channel that invoked it which can be used to
  12780. determine the reason for exit. The changes log and the
  12781. app_directory documentation contain specific details about each
  12782. of the possible values for DIRECTORY_RESULT. Review:
  12783. https://reviewboard.asterisk.org/r/3016/
  12784. 2013-11-21 22:36 +0000 [r402982-402994] David M. Lee <dlee@digium.com>
  12785. * rest-api-templates/ari_resource.c.mustache, /,
  12786. rest-api-templates/res_ari_resource.c.mustache: ari: Fix #include
  12787. to match generated headers for snakeCase resource files ........
  12788. Merged revisions 402993 from
  12789. http://svn.asterisk.org/svn/asterisk/branches/12
  12790. * rest-api-templates/make_ari_stubs.py, /: ari: Fix generators for
  12791. resources with camelCase names. For the new deviceState resource,
  12792. we need to properly generate device_state.[ch] files. ........
  12793. Merged revisions 402981 from
  12794. http://svn.asterisk.org/svn/asterisk/branches/12
  12795. 2013-11-21 19:22 +0000 [r402969] Matthew Jordan <mjordan@digium.com>
  12796. * res/res_pjsip_session.c, /: res_pjsip_session: Fix memory leak of
  12797. direct media format capabilities The direct media format
  12798. capabilities are always allocated in ast_sip_session_alloc and
  12799. were not freed in the session destructor. Whoops. (This being the
  12800. third whoops caught by Scott and Nitesh's valgrind work for the
  12801. Asterisk Test Suite. Nifty!) ........ Merged revisions 402968
  12802. from http://svn.asterisk.org/svn/asterisk/branches/12
  12803. 2013-11-21 19:09 +0000 [r402945-402957] Richard Mudgett <rmudgett@digium.com>
  12804. * include/asterisk/app.h, /: voicemail: Fixup some doxygen
  12805. comments. ........ Merged revisions 402956 from
  12806. http://svn.asterisk.org/svn/asterisk/branches/12
  12807. * /, main/bucket.c: bucket: Fix scheme ref leak in
  12808. __ast_bucket_scheme_register(). ........ Merged revisions 402944
  12809. from http://svn.asterisk.org/svn/asterisk/branches/12
  12810. 2013-11-21 17:53 +0000 [r402942-402943] Matthew Jordan <mjordan@digium.com>
  12811. * res/res_pjsip_sdp_rtp.c, /: res_pjsip_sdp_rtp: Fix use of
  12812. uninitialized value in PJSIP In PJMEDIA,
  12813. pjmedia_sdp_rtpmap_to_attr will attempt to use the string
  12814. rtpmap.param regardless of its length value. Simply setting the
  12815. length to 0 does not prevent the garbage on the stack in
  12816. rtpmap.param.ptr from being formatted in a sprintf call. This
  12817. patch initializes the string to NULL so that at the very least,
  12818. something is provided to the function that is predictable.
  12819. ........ Merged revisions 402941 from
  12820. http://svn.asterisk.org/svn/asterisk/branches/12
  12821. * /, res/res_pjsip_mwi.c: res_pjsip_mwi: Fix memory leak of MWI
  12822. subscriptions container This patch fixes a reference counting
  12823. memory leak on the ao2_container created as part of
  12824. create_mwi_subscriptions. When we create the container in this
  12825. routine, the intent is to hand lifetime ownership over to the
  12826. global container unsolicited_mwi. When
  12827. ao2_global_obj_replace_unref is called, the reference count on
  12828. mwi_subscriptions (the container) will be bumped by 1; however,
  12829. the function does not decrement the reference count on
  12830. mwi_subscriptions when this occurs. This will prevent the
  12831. container from being fully disposed of when Asterisk exits (or on
  12832. any subsequent call to this operation, such as during a reload).
  12833. ........ Merged revisions 402940 from
  12834. http://svn.asterisk.org/svn/asterisk/branches/12
  12835. 2013-11-21 15:57 +0000 [r402928-402929] David M. Lee <dlee@digium.com>
  12836. * res/res_stasis.c, /: stasis: Fixed scoping problem with bridge
  12837. tracking. ........ Merged revisions 402817 from
  12838. http://svn.asterisk.org/svn/asterisk/branches/12
  12839. * res/ari/resource_channels.c, res/res_ari_channels.c,
  12840. res/ari/resource_channels.h, /, res/stasis/control.c,
  12841. include/asterisk/stasis_app.h, rest-api/api-docs/channels.json:
  12842. ari: Add silence generator controls This patch adds the ability
  12843. to start a silence generator on a channel via ARI. This generator
  12844. will play silence on the channel (avoiding audio timeouts on the
  12845. peer) until it is stopped, or some other media operation is
  12846. started (like playing media, starting music on hold, etc.).
  12847. (closes issue ASTERISK-22514) Review:
  12848. https://reviewboard.asterisk.org/r/3019/ ........ Merged
  12849. revisions 402926 from
  12850. http://svn.asterisk.org/svn/asterisk/branches/12
  12851. 2013-11-19 23:17 +0000 [r402892] Joshua Colp <jcolp@digium.com>
  12852. * /, res/res_pjsip_caller_id.c: res_pjsip_caller_id: Don't
  12853. overwrite user portion of the From header when fromuser is set.
  12854. The fromuser option is used to explicitly set the user within the
  12855. From header. The res_pjsip_caller_id module did not take this
  12856. setting into account when determining if the From header could be
  12857. modified or not. (closes issue ASTERISK-22866) Reported by:
  12858. Anthony Messina ........ Merged revisions 402891 from
  12859. http://svn.asterisk.org/svn/asterisk/branches/12
  12860. 2013-11-16 13:51 +0000 [r402865] Joshua Colp <jcolp@digium.com>
  12861. * res/res_pjsip/pjsip_distributor.c, /, configure,
  12862. include/asterisk/autoconfig.h.in, configure.ac: res_pjsip: Add
  12863. support for building against pjproject with SIP transaction group
  12864. lock support. SIP transaction group lock support has been
  12865. backported into our pjproject. Since the code now internally uses
  12866. a group lock the code is now changed to unlock it if present.
  12867. Note that the act of finding the transaction is what actually
  12868. returns it locked. For further information about group locks
  12869. check out the wiki page at:
  12870. http://trac.pjsip.org/repos/wiki/Group_Lock (issue
  12871. ASTERISK-22818) Reported by: Matt Jordan ........ Merged
  12872. revisions 402864 from
  12873. http://svn.asterisk.org/svn/asterisk/branches/12
  12874. 2013-11-15 22:38 +0000 [r402854] Jonathan Rose <jrose@digium.com>
  12875. * apps/app_confbridge.c, CHANGES,
  12876. apps/confbridge/conf_config_parser.c,
  12877. configs/confbridge.conf.sample,
  12878. apps/confbridge/include/confbridge.h: Confbridge: Add option to
  12879. review the recording similar to announce_join_leave Review:
  12880. https://reviewboard.asterisk.org/r/3008/
  12881. 2013-11-15 14:37 +0000 [r402839] Kinsey Moore <kmoore@digium.com>
  12882. * /, main/cel.c: CEL: Fix crash when using CELGenUserEvent This
  12883. fixes a crash when CELGenUserEvent is called from the dialplan
  12884. while CEL is disabled. Currently, CEL does not create its topics
  12885. and forwards if it is not enabled and external entities may
  12886. depend on these topics blindly since they should always be
  12887. available. This patch breaks up route creation and topic/forward
  12888. creation such that the CEL topics and forwards will always exist
  12889. while the router and its associated routes will be torn down and
  12890. recreated as necessary. (closes issue ASTERISK-22799) Review:
  12891. https://reviewboard.asterisk.org/r/3010/ Reported by: Matt Jordan
  12892. ........ Merged revisions 402838 from
  12893. http://svn.asterisk.org/svn/asterisk/branches/12
  12894. 2013-11-14 21:36 +0000 [r402820-402829] Richard Mudgett <rmudgett@digium.com>
  12895. * apps/app_directed_pickup.c: Pickup: Pickup() and PickupChan()
  12896. parameter parsing improvements. * Made Pickup() and PickupChan()
  12897. tollerate empty pickup values. i.e., You can now have
  12898. Pickup(&&exten@context). * Made PickupChan() use the standard
  12899. option flag parsing code.
  12900. * apps/app_directed_pickup.c: Pickup: Ensure using PICKUPMARK never
  12901. considers the picking channel.
  12902. 2013-11-14 20:32 +0000 [r402819] Jonathan Rose <jrose@digium.com>
  12903. * CHANGES, main/pbx.c, apps/app_sayunixtime.c: Say: If
  12904. SAY_DTMF_INTERRUPT is set to an ast_true value, jump on DTMF
  12905. Similar to how background works, if a say application is called
  12906. with this variable set to 'true', 'yes', 'on', etc. then using
  12907. DTMF while the say action is in progress will result in the
  12908. channel jumping to that extension in the dialplan. Review:
  12909. https://reviewboard.asterisk.org/r/3011/
  12910. 2013-11-13 23:11 +0000 [r402805] Joshua Colp <jcolp@digium.com>
  12911. * rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  12912. res/res_ari_channels.c, res/ari/resource_channels.h, /,
  12913. res/stasis/control.c, include/asterisk/stasis_app.h:
  12914. res_ari_channels: Add the ability to stop locally generated
  12915. ringing on a channel. Using the 'ring' operation it is possible
  12916. to start locally generated ringback if the channel is answered.
  12917. This change adds the ability to stop it by using DELETE. ........
  12918. Merged revisions 402804 from
  12919. http://svn.asterisk.org/svn/asterisk/branches/12
  12920. 2013-11-12 23:17 +0000 [r402788-402795] Kevin Harwell <kharwell@digium.com>
  12921. * res/ari/resource_endpoints.c, /: ari endpoints: GET
  12922. /ari/endpoints/{invalid-tech} should return a 404 Was returning a
  12923. 404 on a valid technology with an empty list of endpoints. Now
  12924. checking against the channel tech to make sure the tech itself is
  12925. valid and not just an empty list of endpoints. (issue
  12926. ASTERISK-22803) Reported by: David M. Lee ........ Merged
  12927. revisions 402793 from
  12928. http://svn.asterisk.org/svn/asterisk/branches/12
  12929. * rest-api/api-docs/endpoints.json, res/ari/resource_endpoints.c,
  12930. /, res/res_ari_endpoints.c: ari endpoints: GET
  12931. /ari/endpoints/{invalid-tech} should return a 404 Implementation
  12932. listing endpoints by technology returned an empty array if no
  12933. matching endpoints were found. Fixed so a "404 Not Found" will be
  12934. returned instead. (closes issue ASTERISK-22803) Reported by:
  12935. David M. Lee ........ Merged revisions 402787 from
  12936. http://svn.asterisk.org/svn/asterisk/branches/12
  12937. 2013-11-12 19:38 +0000 [r402768-402778] Mark Michelson <mmichelson@digium.com>
  12938. * /, main/channel.c: Switch to a scoped lock to avoid missing
  12939. unlocks in failure returns. ........ Merged revisions 402769 from
  12940. http://svn.asterisk.org/svn/asterisk/branches/12
  12941. * main/channel.c, /: Move a NULL check to a place that makes more
  12942. sense. Two variables were being checked for NULLity immediately
  12943. after being declared NULL. I moved the NULL check until after the
  12944. variables are allocated. This allows for the "channelvars" option
  12945. in manager.conf to work as intended again. ........ Merged
  12946. revisions 402767 from
  12947. http://svn.asterisk.org/svn/asterisk/branches/12
  12948. 2013-11-12 16:49 +0000 [r402758] Kevin Harwell <kharwell@digium.com>
  12949. * res/res_pjsip_messaging.c, res/res_pjsip_header_funcs.c, /:
  12950. pjsip_messaging, pjsip_header_funcs: Crashes due to NULL pointer
  12951. dereferences Both res_pjsip_messaging and res_pjsip_header_funcs
  12952. were causing asterisk to crash because they were trying to
  12953. dereference a NULL pointer. In the case of res_pjsip_messaging it
  12954. was attempting to "print" a contact header that did not exist. In
  12955. fact contact headers should not be part of a SIP MESSAGE, so the
  12956. offending code was simply removed. In the case of
  12957. res_pjsip_header_funcs a null private channel tech was being
  12958. passed to the function and then later dereferenced. Added null
  12959. checks (and error logging) to the read/write function handlers to
  12960. guard against crashing. (closes issue ASTERISK-22821) Reported
  12961. by: Anthony Messina ........ Merged revisions 402757 from
  12962. http://svn.asterisk.org/svn/asterisk/branches/12
  12963. 2013-11-12 16:34 +0000 [r402756] Kinsey Moore <kmoore@digium.com>
  12964. * /, apps/app_celgenuserevent.c: CELGenUserEvent: Fix error message
  12965. from ast_json_pack This prevents NULL from being passed into an
  12966. ast_json_pack call when no extra information is passed to the
  12967. application which prevents an error message about NULL arguments
  12968. from being generated. ........ Merged revisions 402755 from
  12969. http://svn.asterisk.org/svn/asterisk/branches/12
  12970. 2013-11-12 15:27 +0000 [r402741] David M. Lee <dlee@digium.com>
  12971. * res/ari/ari_model_validators.h, rest-api/api-docs/events.json, /:
  12972. Fixed a typ. ........ Merged revisions 402738 from
  12973. http://svn.asterisk.org/svn/asterisk/branches/12
  12974. 2013-11-12 15:03 +0000 [r402711] Kinsey Moore <kmoore@digium.com>
  12975. * channels/chan_dahdi.c, /: chan_dahdi: Fix crash during caller ID
  12976. read Asterisk will sometimes core dump during caller id read on
  12977. analog channels due to a negative return value from the read() in
  12978. my_get_callerid that slips through as a negative length argument
  12979. to callerid_feed() if the errno returned by DAHDI is ELAST. This
  12980. change ensures that the negative return is treated properly even
  12981. when it is ELAST. (closes issue ASTERISK-22746) Reported by:
  12982. Michael Walton Patches: chan_dahdi_cid_crash_fix.r401410.patch
  12983. uploaded by Michael Walton (License 6502) ........ Merged
  12984. revisions 402708 from
  12985. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  12986. revisions 402709 from
  12987. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  12988. revisions 402710 from
  12989. http://svn.asterisk.org/svn/asterisk/branches/12
  12990. 2013-11-11 20:28 +0000 [r402698] Jonathan Rose <jrose@digium.com>
  12991. * apps/app_confbridge.c: Confbridge: add test events for dynamic
  12992. menus test Adds a couple of test events for conference menu
  12993. actions so that it's easy to discern when those menu actions have
  12994. been triggered. (issue ASTERISK-22760) Reported by: Matt Jordan
  12995. Review: https://reviewboard.asterisk.org/r/2999/
  12996. 2013-11-11 19:31 +0000 [r402688] Mark Michelson <mmichelson@digium.com>
  12997. * apps/app_confbridge.c, /: Get rid of some inaccurate comments.
  12998. I'm doing some unrelated work in app_confbridge and finding these
  12999. "invalid pin" comments to be annoying. Get out! ........ Merged
  13000. revisions 402686 from
  13001. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13002. revisions 402687 from
  13003. http://svn.asterisk.org/svn/asterisk/branches/12
  13004. 2013-11-11 15:37 +0000 [r402648] Kinsey Moore <kmoore@digium.com>
  13005. * /, apps/app_queue.c: app_queue: Honor penalty limits of 0 In the
  13006. current app_queue code from 1.8 up to trunk the upper and lower
  13007. penalties can be set to 0 but the value is interpreted to be
  13008. disabled instead of actually setting limits. This is especially
  13009. evident if min and max limits are set to 0 and members with
  13010. penalties of 0 and 1 are in the queue since the member with
  13011. penalty 1 will still receive calls. This patch adjusts the
  13012. special disabled value to be INT_MAX instead of 0. (closes issue
  13013. ASTERISK-20862) Review: https://reviewboard.asterisk.org/r/2995/
  13014. Reported by: Schmooze Com ........ Merged revisions 402645 from
  13015. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13016. revisions 402646 from
  13017. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13018. revisions 402647 from
  13019. http://svn.asterisk.org/svn/asterisk/branches/12
  13020. 2013-11-08 23:07 +0000 [r402607] Scott Griepentrog <sgriepentrog@digium.com>
  13021. * /, channels/chan_sip.c, channels/sip/include/sip.h: chan_sip:
  13022. keep same local (from) tag for outgoing register requests For
  13023. outbound register requests the tag on the From line was updated
  13024. every 20 seconds prior to a successful registration and also once
  13025. for each registration renewal. That behavior can possibly cause
  13026. the registration to be denied because of the different tag, and
  13027. is not aligned with the intention of RFC 3261 8.1.3.5 "...
  13028. request constitutes a new transaction and SHOULD have the same
  13029. value of the Call-ID, To, and From of the previous request...".
  13030. This updates chan_sip to have a field to keep the local tag in
  13031. the registration structure and use that tag for registration
  13032. requests where the callid is also unchanged. (closes issue
  13033. ASTERISK-12117) Reported by: Pawel Pierscionek Review:
  13034. https://reviewboard.asterisk.org/r/2988/ ........ Merged
  13035. revisions 402604 from
  13036. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13037. revisions 402605 from
  13038. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13039. revisions 402606 from
  13040. http://svn.asterisk.org/svn/asterisk/branches/12
  13041. 2013-11-08 20:37 +0000 [r402595] Richard Mudgett <rmudgett@digium.com>
  13042. * /, res/res_stasis.c: res_stasis.c: Fix locking issues with the
  13043. app_bridge_moh container. * Fix unlinking from the
  13044. app_bridges_moh container in remove_bridge_moh() without a lock
  13045. under normal circumstances. * Made check
  13046. ast_bridge_set_after_callback() return value in
  13047. bridge_moh_create() to handle failure. * Fixed SCOPED_AO2LOCK()
  13048. locking over too much scope in stasis_app_bridge_moh_channel()
  13049. and stasis_app_bridge_moh_stop(). * Fixed unusual usage of
  13050. ao2_unlink_flag() in control_unlink(). * Fixed orphaned bridge
  13051. from off nominal path in stasis_app_bridge_create(). * Fixed
  13052. strange construct in stasis_app_unsubscribe(). From a bad merge?
  13053. * Made load_module() cleanup on failure. Review:
  13054. https://reviewboard.asterisk.org/r/2962/ ........ Merged
  13055. revisions 402593 from
  13056. http://svn.asterisk.org/svn/asterisk/branches/12
  13057. 2013-11-08 19:33 +0000 [r402585] Jonathan Rose <jrose@digium.com>
  13058. * /, main/security_events.c, configs/manager.conf.sample, CHANGES,
  13059. include/asterisk/manager.h, main/manager.c: security_events: Push
  13060. out security events over AMI events Security Events will now be
  13061. written to any listener of the new 'security' class Review:
  13062. https://reviewboard.asterisk.org/r/2998/ ........ Merged
  13063. revisions 402584 from
  13064. http://svn.asterisk.org/svn/asterisk/branches/12
  13065. 2013-11-08 19:22 +0000 [r402583] Mark Michelson <mmichelson@digium.com>
  13066. * res/res_pjsip.c, /: Clarify an ambiguous error message. ........
  13067. Merged revisions 402582 from
  13068. http://svn.asterisk.org/svn/asterisk/branches/12
  13069. 2013-11-08 18:53 +0000 [r402571-402572] David M. Lee <dlee@digium.com>
  13070. * /, res/res_pjsip/config_system.c: res_pjsip: Print a helpful
  13071. error message if sorcery registration fails ........ Merged
  13072. revisions 402570 from
  13073. http://svn.asterisk.org/svn/asterisk/branches/12
  13074. * res/ari/resource_playbacks.h, /: Changes from make ari-stubs
  13075. after r402560 ........ Merged revisions 402561 from
  13076. http://svn.asterisk.org/svn/asterisk/branches/12
  13077. 2013-11-08 17:59 +0000 [r402562] Kevin Harwell <kharwell@digium.com>
  13078. * rest-api/resources.json, res/ari/resource_playback.h (removed),
  13079. res/res_ari_playbacks.c (added), res/ari/resource_playbacks.h
  13080. (added), /, res/ari.make, rest-api/api-docs/playback.json
  13081. (removed), res/ari/resource_playback.c (removed),
  13082. res/res_ari_playback.c (removed),
  13083. rest-api/api-docs/playbacks.json (added),
  13084. res/ari/resource_playbacks.c (added): ARI playback: Rename ARI
  13085. Playback to Playbacks Before playback was the only non plural
  13086. resource. It has been renamed to playbacks for consistency.
  13087. (closes issue ASTERISK-22737) Reported by: Paul Belanger ........
  13088. Merged revisions 402560 from
  13089. http://svn.asterisk.org/svn/asterisk/branches/12
  13090. 2013-11-08 17:29 +0000 [r402557] David M. Lee <dlee@digium.com>
  13091. * res/res_ari.c, main/manager.c, /, main/http.c: ari: Add
  13092. application/x-www-form-urlencoded parameter support ARI POST
  13093. calls only accept parameters via the URL's query string. While
  13094. this works, it's atypical for HTTP API's in general, and
  13095. specifically frowned upon with RESTful API's. This patch adds
  13096. parsing for application/x-www-form-urlencoded request bodies if
  13097. they are sent in with the request. Any variables parsed this way
  13098. are prepended to the variable list supplied by the query string.
  13099. (closes issue ASTERISK-22743) Review:
  13100. https://reviewboard.asterisk.org/r/2986/ ........ Merged
  13101. revisions 402555 from
  13102. http://svn.asterisk.org/svn/asterisk/branches/12
  13103. 2013-11-08 14:58 +0000 [r402546] Kevin Harwell <kharwell@digium.com>
  13104. * apps/app_dahdiras.c, utils/extconf.c, main/asterisk.c:
  13105. app_dahdiras: Use waitpid instead of wait4. Several places in the
  13106. code were using wait4 while other places were using waitpid. This
  13107. change makes all places use waitpid in order to make things more
  13108. consistent and since the 'rusage' object passed in/out of wait4
  13109. was never used. (closes issue ASTERISK-22557) Reported by:
  13110. YvesGael Patches: asterisk-11.5.1-wait4.patch uploaded by hurdman
  13111. (license 6537)
  13112. 2013-11-07 23:42 +0000 [r402538] Jonathan Rose <jrose@digium.com>
  13113. * res/res_pjsip_authenticator_digest.c, /: PJSIP: Improve error
  13114. handling in digest authenticator Previously, regardless of
  13115. whether failure to authenticate was due to lacking any
  13116. authentication or actually failing authentication, the Digest
  13117. Authenticator would simply return that a challenge was still
  13118. needed. It will continue to do that when no authentication
  13119. information is in the received SIP digest, but when
  13120. authentication information is present and does not pass
  13121. authentication, that will be treated as an authentication error.
  13122. This is to ensure that PJSIP will issue security events indicated
  13123. failed auths. ........ Merged revisions 402537 from
  13124. http://svn.asterisk.org/svn/asterisk/branches/12
  13125. 2013-11-07 21:10 +0000 [r402529] David M. Lee <dlee@digium.com>
  13126. * res/ari/resource_applications.c, res/ari/resource_playback.c,
  13127. rest-api/api-docs/channels.json, res/ari/resource_applications.h,
  13128. res/ari/resource_channels.c, res/ari/resource_playback.h,
  13129. rest-api/api-docs/recordings.json, res/ari/resource_recordings.c,
  13130. rest-api-templates/ari_resource.c.mustache,
  13131. rest-api-templates/asterisk_processor.py,
  13132. res/ari/resource_channels.h, rest-api/api-docs/endpoints.json,
  13133. res/ari/resource_endpoints.c, res/ari/resource_recordings.h,
  13134. res/ari/resource_events.c, res/res_ari_playback.c,
  13135. res/res_ari_applications.c, res/ari/resource_endpoints.h,
  13136. res/ari/resource_events.h, rest-api/api-docs/sounds.json,
  13137. res/ari/resource_sounds.c, res/res_ari_channels.c,
  13138. rest-api/api-docs/bridges.json, res/ari/resource_bridges.c,
  13139. res/ari/resource_sounds.h, res/res_ari_recordings.c,
  13140. res/ari/resource_bridges.h, rest-api/api-docs/asterisk.json,
  13141. res/ari/resource_asterisk.c, res/res_ari_endpoints.c,
  13142. rest-api/api-docs/applications.json,
  13143. rest-api/api-docs/playback.json, res/res_ari_events.c,
  13144. res/ari/resource_asterisk.h, rest-api-templates/swagger_model.py,
  13145. res/res_ari_sounds.c, res/res_ari_bridges.c, /,
  13146. rest-api-templates/ari_resource.h.mustache,
  13147. rest-api-templates/rest_handler.mustache, res/res_ari_asterisk.c,
  13148. rest-api-templates/res_ari_resource.c.mustache: ari: User better
  13149. nicknames for ARI operations While working on building client
  13150. libraries from the Swagger API, I noticed a problem with the
  13151. nicknames. channel.deleteChannel() channel.answerChannel()
  13152. channel.muteChannel() Etc. We put the object name in the nickname
  13153. (since we were generating C code), but it makes OO generators
  13154. redundant. This patch makes the nicknames more OO friendly. This
  13155. resulted in a lot of name changing within the res_ari_*.so
  13156. modules, but not much else. There were a couple of other fixed I
  13157. made in the process. * When reversible operations (POST /hold,
  13158. POST /unhold) were made more RESTful (POST /hold, DELETE
  13159. /unhold), the path for the second operation was left in the API
  13160. declaration. This worked, but really the two operations should
  13161. have been on the same API. * The POST /unmute operation had still
  13162. not been REST-ified. Review:
  13163. https://reviewboard.asterisk.org/r/2940/ ........ Merged
  13164. revisions 402528 from
  13165. http://svn.asterisk.org/svn/asterisk/branches/12
  13166. 2013-11-06 21:58 +0000 [r402518] Kevin Harwell <kharwell@digium.com>
  13167. * /, apps/app_queue.c: app_queue: crash if first agent is "busy" If
  13168. the first agent/member (via CLI "queue show") in a queue is
  13169. "busy" (dnd, circuit busy, etc...) and no agents answered then
  13170. app_queue would crash. This occurred because while the calling of
  13171. agent(s) remained valid the channel on "busy" agent would be set
  13172. to NULL and then later dereferenced upon a second "rna" function
  13173. call. The original intention of the code is to have only valid
  13174. "call attempt" objects (channels != NULL) checked while
  13175. attempting to call agent(s). It does this by building a
  13176. "call_next" list of valid "call attempt" objects. In the case of
  13177. the "busy" agent subsequent builds of the valid "call attempt"
  13178. list would sometimes include (the case mentioned above) an
  13179. invalid "call attempt" object. The fix was to make sure the "call
  13180. attempt" list was appropriately built on every iteration. A NULL
  13181. sanity check was also added at the original offending spot of the
  13182. crash just in case another one slipped by somehow. (closes issue
  13183. ASTERISK-22644) Reported by: Marco Signorini Review:
  13184. https://reviewboard.asterisk.org/r/2983/ ........ Merged
  13185. revisions 402517 from
  13186. http://svn.asterisk.org/svn/asterisk/branches/12
  13187. 2013-11-05 21:17 +0000 [r402502-402508] Matthew Jordan <mjordan@digium.com>
  13188. * /, channels/chan_sip.c: chan_sip: Use AST_AF* defined constant
  13189. when calling ast_get_ip While the structure passed to ast_get_ip
  13190. should be set memset to 0, thus initializing the ss_family member
  13191. to 0, explicitly setting it to AST_AF_UNSPEC is more portable.
  13192. ........ Merged revisions 402507 from
  13193. http://svn.asterisk.org/svn/asterisk/branches/12
  13194. * channels/chan_iax2.c, /: chan_iax2: Fix incorrect usage of
  13195. ast_get_ip involving uninitialized struct This started off as a
  13196. fix for the failing IAX2 acl_call test in the Asterisk Test
  13197. Suite. When inspecting why that test was failing, it became clear
  13198. that all attempts to bind to any local loopback address was
  13199. failing: [Nov 2 15:56:28] VERBOSE[15787] chan_iax2.c: == Binding
  13200. IAX2 to address 127.0.0.1:4569 [Nov 2 15:56:28] DEBUG[15787]
  13201. netsock2.c: Splitting '127.0.0.1' into... [Nov 2 15:56:28]
  13202. DEBUG[15787] netsock2.c: ...host '127.0.0.1' and port ''. [Nov 2
  13203. 15:56:28] ERROR[15787] netsock2.c: getaddrinfo("127.0.0.1",
  13204. "(null)", ...): ai_family not supported [Nov 2 15:56:28]
  13205. WARNING[15787] acl.c: Unable to lookup '127.0.0.1' While there's
  13206. conceivably other ways for getaddrino to return EAI_FAMILY, the
  13207. most common way is if AF_INET, AF_INET6, or AF_UNSPEC is not
  13208. provided as the desired family. The culprit was the call to
  13209. ast_get_ip, defined in acl.h. This function uses the family from
  13210. the passed in addr object (which it will also populate when it
  13211. returns!) when it eventually calls getaddrinfo. This patch fixes
  13212. the use of ast_get_ip that were not specifying the family in
  13213. chan_iax2. This prevents uninitialized use of the structure, so
  13214. that the addresses resolve correctly. Review:
  13215. https://reviewboard.asterisk.org/r/2991 ........ Merged revisions
  13216. 402505 from http://svn.asterisk.org/svn/asterisk/branches/12
  13217. * include/asterisk/acl.h, /, include/asterisk/netsock2.h: netsock2:
  13218. Define AST_AF_* enum constants to their AF_* equivalents This
  13219. patch explicitly defines AST_AF_* enum constants to their
  13220. sys/socket.h defined equivalents. It is certainly unclear why
  13221. these constants actually have to exist, given that netsock2.h
  13222. includes sys/socket.h; however, since the code base is already
  13223. liberally sprinkled with the usage of AST_AF_* (as well as with
  13224. direct calls to AF_*), this will at least keep the semantics
  13225. consistent between their usage across systems. ........ Merged
  13226. revisions 402503 from
  13227. http://svn.asterisk.org/svn/asterisk/branches/12
  13228. * main/stasis_channels.c, /: stasis_channels: Don't give preference
  13229. to ANI info in channel snapshots When publishing channel
  13230. snapshots, we currently compute the caller ID name and number by
  13231. giving preference first to ani.{name|number}, then to
  13232. id.{name|number}. However, when a channel driver (such as
  13233. chan_sip) updates the caller ID, it typically only updates the
  13234. caller ID stored in id.{name|number}. This means that we are
  13235. currently giving preference to stale information. When looking at
  13236. the rest of the code base, the only other place where we appear
  13237. to use this same logic is in app_amd. Everywhere else, we treat
  13238. the party information in ani as being separate to the party
  13239. information in id. This patch publishes only the caller ID name
  13240. and number in the snapshot field for caller_name and caller_num.
  13241. Note that the information in ANI is still available in
  13242. caller_ani. Review: https://reviewboard.asterisk.org/r/2992/
  13243. ........ Merged revisions 402501 from
  13244. http://svn.asterisk.org/svn/asterisk/branches/12
  13245. 2013-11-04 21:02 +0000 [r402453] Kevin Harwell <kharwell@digium.com>
  13246. * /, channels/chan_sip.c: chan_sip: notify dialog info ignores
  13247. presentation indicator in callerid The presentation indicator in
  13248. a callerid (e.g. set by dialplan function
  13249. Set(CALLERID(name-pres)= ...)) is not checked when SIP Dialog
  13250. Info Notifies are generated during extension monitoring. Added a
  13251. check to make sure the name and/or number presentations on the
  13252. callee (remote identity) are set to allow. If they are restricted
  13253. then "anonymous" is used instead. (closes issue AST-1175)
  13254. Reported by: Thomas Arimont Review:
  13255. https://reviewboard.asterisk.org/r/2976/ ........ Merged
  13256. revisions 402450 from
  13257. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13258. revisions 402452 from
  13259. http://svn.asterisk.org/svn/asterisk/branches/12
  13260. 2013-11-02 04:30 +0000 [r402406-402439] Richard Mudgett <rmudgett@digium.com>
  13261. * main/stasis.c, main/stasis_message_router.c, /,
  13262. include/asterisk/vector.h: vector: Uppercase API to follow C
  13263. convention. C does not support templates like C++. ........
  13264. Merged revisions 402438 from
  13265. http://svn.asterisk.org/svn/asterisk/branches/12
  13266. * include/asterisk/lock.h, main/stasis.c,
  13267. main/stasis_message_router.c, /, include/asterisk/vector.h:
  13268. vector: Update API to be more flexible. Made the vector macro API
  13269. be more like linked lists. 1) Added a name parameter to
  13270. ast_vector() to name the vector struct. 2) Made the API take a
  13271. pointer to the vector struct instead of the struct itself. 3)
  13272. Added an element cleanup macro/function parameter when removing
  13273. an element from the vector for ast_vector_remove_cmp_unordered()
  13274. and ast_vector_remove_elem_unordered(). 4) Added
  13275. ast_vector_get_addr() in case the vector element is not a simple
  13276. pointer. * Converted an inline vector usage in
  13277. stasis_message_router to use the vector API. It needed the API
  13278. improvements so it could be converted. * Fixed topic reference
  13279. leak in router_dtor() when the stasis_message_router is
  13280. destroyed. * Fixed deadlock potential in stasis_forward_all() and
  13281. stasis_forward_cancel(). Locking two topics at the same time
  13282. requires deadlock avoidance. * Made internal_stasis_subscribe()
  13283. tolerant of a NULL topic. * Made stasis_message_router_add(),
  13284. stasis_message_router_add_cache_update(),
  13285. stasis_message_router_remove(), and
  13286. stasis_message_router_remove_cache_update() tolerant of a NULL
  13287. message_type. * Promoted a LOG_DEBUG message to LOG_ERROR as
  13288. intended in dispatch_message(). Review:
  13289. https://reviewboard.asterisk.org/r/2903/ ........ Merged
  13290. revisions 402429 from
  13291. http://svn.asterisk.org/svn/asterisk/branches/12
  13292. * apps/confbridge/conf_state_single.c,
  13293. apps/confbridge/conf_state_inactive.c,
  13294. apps/confbridge/conf_state_single_marked.c, /,
  13295. apps/confbridge/include/confbridge.h,
  13296. apps/confbridge/conf_state_multi.c, apps/app_confbridge.c,
  13297. apps/confbridge/conf_state_multi_marked.c,
  13298. apps/confbridge/conf_state.c: confbridge: Separate user muting
  13299. from system muting overrides. The system overrides the user
  13300. muting requests when MOH is playing or a waitmarked user is
  13301. waiting for a marked user to join. System muting overrides
  13302. interfere with what the user may wish the muting to be when the
  13303. system override ends. * User muting requests are now independent
  13304. of the system muting overrides. The effective muting is now the
  13305. logical or of the user request and system override. * Added a
  13306. Muted flag to the CLI "confbridge list <conference>" command. *
  13307. Added a Muted header to the AMI ConfbridgeList action
  13308. ConfbridgeList event. (closes issue AST-1102) Reported by: John
  13309. Bigelow Review: https://reviewboard.asterisk.org/r/2960/ ........
  13310. Merged revisions 402425 from
  13311. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13312. revisions 402427 from
  13313. http://svn.asterisk.org/svn/asterisk/branches/12
  13314. * main/config.c, apps/confbridge/conf_config_parser.c,
  13315. configs/confbridge.conf.sample, /: config: Allow ConfBridge DTMF
  13316. menus to have '#' as the first digit. ConfBridge allows custom
  13317. DTMF menus to be created in the confbridge.conf file by assigning
  13318. a DTMF key sequence to a sequence of actions as follows:
  13319. DTMF-sequence = action,action... Unfortunately, the normal config
  13320. file processing code interprets an initial '#' character as
  13321. starting a directive such as #include. * Add the ability to
  13322. escape the first non-blank character in a config line so the '#'
  13323. character can be used without triggering the directive processing
  13324. code. (closes issue AFS-2) (closes issue ASTERISK-22478) Reported
  13325. by: Nicolas Tanski Patches: jira_asterisk_22478_v11.patch
  13326. (license #5621) patch uploaded by rmudgett (modified) Review:
  13327. https://reviewboard.asterisk.org/r/2969/ ........ Merged
  13328. revisions 402407 from
  13329. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13330. revisions 402416 from
  13331. http://svn.asterisk.org/svn/asterisk/branches/12
  13332. * include/asterisk/app.h, /, main/app.c: voicemail: Simplify
  13333. callback pointer declarations and add doxygen. * Typedefed and
  13334. added doxegen for the voicemail callback functions. * Simplified
  13335. the prototypes for ast_install_vm_functions() and
  13336. ast_install_vm_test_functions() to use the new function typedefs.
  13337. * Simplified the voicemail callback function pointer variable
  13338. declarations to use the new function typedefs. ........ Merged
  13339. revisions 402398 from
  13340. http://svn.asterisk.org/svn/asterisk/branches/12
  13341. 2013-11-01 22:48 +0000 [r402397] Jonathan Rose <jrose@digium.com>
  13342. * apps/confbridge/conf_config_parser.c,
  13343. apps/confbridge/include/confbridge.h, apps/app_confbridge.c,
  13344. CHANGES: app_confbridge: Make the CONFBRIDGE function be able to
  13345. create dynamic menus Also adds the ability to clear all profile
  13346. items and makes behavior more consistent with documentation as
  13347. when choosing whether to use CONFBRIDGE datastore profiles or the
  13348. application arguments to the confbridge application. (closes
  13349. issue ASTERISK-22760) Reported by: Matt Jordan Review:
  13350. https://reviewboard.asterisk.org/r/2971/
  13351. 2013-11-01 21:51 +0000 [r402388] Scott Griepentrog <sgriepentrog@digium.com>
  13352. * main/manager_bridges.c, /, main/bridge.c,
  13353. include/asterisk/bridge.h: Manager: Add equivalent AMI actions
  13354. for the bridge CLI commands. Adds the following AMI events,
  13355. closely following their CLI counterparts: BridgeDestroy
  13356. BridgeKick BridgeTechnologyList BridgeTechnologySuspend
  13357. BridgeTechnologyUnsuspend BridgeDestroy kicks an entire bridge,
  13358. where BridgeKick kicks just one channel off the bridge. When
  13359. kicking a channel, specifying the bridge also (optional) insures
  13360. it is not removed from the wrong bridge. The BridgeTechnology
  13361. events allow viewing and changing suspension status, which
  13362. affects only subsequent not active bridging. (closes
  13363. ASTERISK-22356) Reported by: Richard Mudgett Review:
  13364. https://reviewboard.asterisk.org/r/2973/ ........ Merged
  13365. revisions 402387 from
  13366. http://svn.asterisk.org/svn/asterisk/branches/12
  13367. 2013-11-01 16:31 +0000 [r402368] David M. Lee <dlee@digium.com>
  13368. * /, rest-api-templates/api.wiki.mustache: ari wiki docs: add notes
  13369. about allowMultiple parameters. This patch adds a note to any
  13370. parameter that has 'allowMultiple' set in the Swagger
  13371. documentation. (closes issue ASTERISK-22704) ........ Merged
  13372. revisions 402367 from
  13373. http://svn.asterisk.org/svn/asterisk/branches/12
  13374. 2013-11-01 14:38 +0000 [r402359] Joshua Colp <jcolp@digium.com>
  13375. * include/asterisk/stasis_app.h, rest-api/api-docs/channels.json,
  13376. res/ari/resource_channels.c, res/res_ari_channels.c,
  13377. res/ari/resource_channels.h, res/res_stasis_playback.c, /,
  13378. res/stasis/control.c: res_ari_channels: Add ring operation, dtmf
  13379. operation, hangup reasons, and tweak early media. The ring
  13380. operation sends ringing to the specified channel it is invoked
  13381. on. The dtmf operation can be used to send DTMF digits to the
  13382. specified channel of a specific length with a wait time in
  13383. between. Finally hangup reasons allow you to specify why a
  13384. channel is being hung up (busy, congestion). Early media behavior
  13385. has also been tweaked slightly. When playing media to a channel
  13386. it will no longer automatically answer. If it has not been
  13387. answered a progress indication is sent instead. (closes issue
  13388. ASTERISK-22701) Reported by: Matt Jordan Review:
  13389. https://reviewboard.asterisk.org/r/2916/ ........ Merged
  13390. revisions 402358 from
  13391. http://svn.asterisk.org/svn/asterisk/branches/12
  13392. 2013-11-01 12:40 +0000 [r402349] Kinsey Moore <kmoore@digium.com>
  13393. * res/res_rtp_asterisk.c, /, channels/chan_sip.c,
  13394. include/asterisk/rtp_engine.h: chan_sip: Fix RTCP port for SRFLX
  13395. ICE candidates This corrects one-way audio between Asterisk and
  13396. Chrome/jssip as a result of Asterisk inserting the incorrect RTCP
  13397. port into RTCP SRFLX ICE candidates. This also exposes an ICE
  13398. component enumeration to extract further details from candidates.
  13399. (closes issue ASTERISK-21383) Reported by: Shaun Clark Review:
  13400. https://reviewboard.asterisk.org/r/2967/ ........ Merged
  13401. revisions 402345 from
  13402. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13403. revisions 402348 from
  13404. http://svn.asterisk.org/svn/asterisk/branches/12
  13405. 2013-11-01 12:33 +0000 [r402337-402347] Joshua Colp <jcolp@digium.com>
  13406. * /, include/asterisk/stasis_app.h, res/ari/resource_channels.c:
  13407. res_ari_channels: Fix a deadlock when originating multiple
  13408. channels close to eachother. If a Stasis application is specified
  13409. an implicit subscription is done on the originated channel. This
  13410. was previously done with the channel lock held which is dangerous
  13411. as the underlying code locks the container and iterates items.
  13412. This change releases the lock on the originated channel before
  13413. subscribing occurs. (closes issue ASTERISK-22768) Reported by:
  13414. Matt Jordan Review: https://reviewboard.asterisk.org/r/2979/
  13415. ........ Merged revisions 402346 from
  13416. http://svn.asterisk.org/svn/asterisk/branches/12
  13417. * /, res/stasis/control.c: res_stasis: Ensure the channel is always
  13418. departed from the bridge when it leaves. This change adds a
  13419. command to the command queue to explicitly depart the channel
  13420. from the bridge when it is told it has left. If the channel has
  13421. already been departed or has entered a different bridge this
  13422. command will become a no-op. (closes issue ASTERISK-22703)
  13423. Reported by: John Bigelow (closes issue ASTERISK-22634) Reported
  13424. by: Kevin Harwell Review:
  13425. https://reviewboard.asterisk.org/r/2965/ ........ Merged
  13426. revisions 402336 from
  13427. http://svn.asterisk.org/svn/asterisk/branches/12
  13428. 2013-10-31 22:09 +0000 [r402328] Mark Michelson <mmichelson@digium.com>
  13429. * /, contrib/scripts/sip_to_pjsip/sip_to_pjsip.py,
  13430. contrib/scripts/sip_to_res_sip (removed),
  13431. contrib/scripts/sip_to_pjsip (added),
  13432. contrib/scripts/sip_to_pjsip/astconfigparser.py,
  13433. contrib/scripts/sip_to_pjsip/astdicts.py: Update the conversion
  13434. script from sip.conf to pjsip.conf (closes issue ASTERISK-22374)
  13435. Reported by Matt Jordan Review:
  13436. https://reviewboard.asterisk.org/r/2846 ........ Merged revisions
  13437. 402327 from http://svn.asterisk.org/svn/asterisk/branches/12
  13438. 2013-10-31 16:06 +0000 [r402286-402290] Matthew Jordan <mjordan@digium.com>
  13439. * main/loader.c, /: core/loader: Don't call dlclose in a while loop
  13440. For awhile now, we've noticed continuous integration builds
  13441. hanging on CentOS 6 64-bit build agents. After resolving a number
  13442. of problems with symbols, strange locks, and other shenanigans,
  13443. the problem has persisted. In all cases, gdb shows the Asterisk
  13444. process stuck in loader.c on one of the infinite while loops that
  13445. calls dlclose repeatedly until success. The documentation of
  13446. dlclose states that it returns 0 on success; any other value on
  13447. error. It does not state that repeatedly calling it will
  13448. eventually clear those errors. Most likely, the repeated calls to
  13449. dlclose was to force a close by exhausting the references on the
  13450. library; however, that will never succeed if: (a) There is some
  13451. fundamental error at work in the loaded library that precludes
  13452. unloading it (b) Some other loaded module is referencing a symbol
  13453. in the currently loaded module This results in Asterisk sitting
  13454. forever. Since we have matching pairs of dlopen/dlclose, this
  13455. patch opts to only call dlclose once, and log out as an ERROR if
  13456. dlclose fails to return success. If nothing else, this might help
  13457. to determine why on the CentOS 6 64-bit build agent things are
  13458. not closing successfully. Review:
  13459. https://reviewboard.asterisk.org/r/2970 ........ Merged revisions
  13460. 402287 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  13461. ........ Merged revisions 402288 from
  13462. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13463. revisions 402289 from
  13464. http://svn.asterisk.org/svn/asterisk/branches/12
  13465. * main/media_index.c, /: medix_index: Display errors when library
  13466. calls fail Based on feedback from ipengineer in #asterisk, when
  13467. the media indexer cannot access a sound file on the system (or
  13468. otherwise fails) Asterisk displays a "Cannot frob file" error but
  13469. fails to tell you why. This is especially problematic as the
  13470. media_indexer failing will rpevent Asterisk from starting, as it
  13471. is in the core. We now display the errno error messages so folks
  13472. can figure out what they've done wrong. ........ Merged revisions
  13473. 402285 from http://svn.asterisk.org/svn/asterisk/branches/12
  13474. 2013-10-31 14:45 +0000 [r402277] David M. Lee <dlee@digium.com>
  13475. * /, res/stasis/app.c: stasis: add functions embarrassingly missing
  13476. from r400522 I neglected to implement two of the endpoint
  13477. subscription functions when I did the work. Normally, you'll only
  13478. hit that when you unsubscribe from a specific endpoint. ........
  13479. Merged revisions 402276 from
  13480. http://svn.asterisk.org/svn/asterisk/branches/12
  13481. 2013-10-30 17:54 +0000 [r402266] Kevin Harwell <kharwell@digium.com>
  13482. * channels/chan_pjsip.c, /, res/res_pjsip_messaging.c:
  13483. pjsip_messaging: Added debug for in dialog messaging (issue
  13484. ASTERISK-22777) Reported by: Matt Jordan ........ Merged
  13485. revisions 402265 from
  13486. http://svn.asterisk.org/svn/asterisk/branches/12
  13487. 2013-10-29 23:43 +0000 [r402227] Rusty Newton <rnewton@digium.com>
  13488. * /, sounds/Makefile: Updates for 1.4.25 core sounds and 1.4.14
  13489. extra sounds, plus new en_GB language set The new sound packages
  13490. relate to issues: ASTERISK-22544, ASTERISK-22411, ASTERISK-21413,
  13491. ASTERISK-20782 Modified sounds/Makefile for the new sound
  13492. versions and to account for the new en_GB language set. (issue
  13493. ASTERISK-22659) (closes issue ASTERISK-22659) (closes issue
  13494. ASTERISK-22411) (closes issue ASTERISK-22544) ........ Merged
  13495. revisions 402224 from
  13496. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13497. revisions 402225 from
  13498. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13499. revisions 402226 from
  13500. http://svn.asterisk.org/svn/asterisk/branches/12
  13501. 2013-10-29 12:57 +0000 [r402155] Matthew Jordan <mjordan@digium.com>
  13502. * main/xmldoc.c, main/channel.c, main/pbx.c, /, main/translate.c:
  13503. Remove some spammy debug messages; improve clarity of others
  13504. Debug messages aren't free. Even when the debug level is
  13505. sufficiently low such that the messages are never evaluated,
  13506. there is a cost to having to parse Asterisk logs that contain
  13507. debug messages that (a) fail to convey sufficient information or
  13508. (b) occur so frequently as to be next to meaningless. Based on
  13509. having to stare at lots of DEBUG messages, this patch makes the
  13510. following changes: * channel.c: When copying variables from a
  13511. parent channel to a child channel, specify the channels involved.
  13512. Do not log anything for a variable that is not inherited; the
  13513. fact that it doesn't have an _ or __ already signifies that it
  13514. won't be inherited. * pbx.c: Specify what function evaluation has
  13515. occurred that created the result. * translate.c: Bump up the
  13516. translator path messages to 10. I've never once had to use these
  13517. debug messages, and for each format that is registered (on
  13518. startup) and unregistered (on shutdown) the entire f^2 matrix is
  13519. logged out. For short tests in the Asterisk Test Suite, this
  13520. should make finding the actual test much easier. * xmldoc.c: The
  13521. debug message that 'blah' is not found in the tree is expected.
  13522. Often, description elements - which are not required - are not
  13523. provided. This debug message adds no additional value, as it is
  13524. not indicative of an error or helpful in debugging which element
  13525. did not contain a 'blah' element as a child. If an element is
  13526. supposed to contain a child element, then that XML tree should
  13527. have failed validation in the first place. Review:
  13528. https://reviewboard.asterisk.org/r/2966/ ........ Merged
  13529. revisions 402150 from
  13530. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13531. revisions 402151 from
  13532. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13533. revisions 402154 from
  13534. http://svn.asterisk.org/svn/asterisk/branches/12
  13535. 2013-10-29 12:51 +0000 [r402149-402153] Kinsey Moore <kmoore@digium.com>
  13536. * rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  13537. res/res_ari_channels.c, res/ari/resource_channels.h, /: ARI:
  13538. Remove channels/{channelId}/dial This removes the
  13539. /ari/channels/{channelId}/dial URI since it is redundant, overly
  13540. complex, is likely to become more externally complex over time,
  13541. and is too high-level compared with other ARI operations. See the
  13542. following for further information:
  13543. http://lists.digium.com/pipermail/asterisk-app-dev/2013-October/000002.html
  13544. (closes issue ASTERISK-22784) Reported by: Matt Jordan Review:
  13545. https://reviewboard.asterisk.org/r/2968/ ........ Merged
  13546. revisions 402152 from
  13547. http://svn.asterisk.org/svn/asterisk/branches/12
  13548. * bridges/bridge_native_rtp.c, /: bridge_native_rtp: Ensure bridge
  13549. is torn down When a bridge transitions away from one tech to
  13550. another, the tech going away is provided a dummy bridge with no
  13551. channels in it to tear down. Currently this means that the
  13552. teardown code exits prematurely and does not tear anything down.
  13553. This change tears down RTP bridging for the channel provided in
  13554. the leave bridge tech callback. This also reverts the majority of
  13555. r400403 since it is now redundant. (closes issue ASTERISK-22628)
  13556. (closes issue ASTERISK-22676) Reported by: John Bigelow Reported
  13557. by: Kevin Harwell Tested by: John Bigelow Review:
  13558. https://reviewboard.asterisk.org/r/2905/ Patches:
  13559. native_rtp_fix.diff uploaded by Kinsey Moore (License 6273)
  13560. ........ Merged revisions 402148 from
  13561. http://svn.asterisk.org/svn/asterisk/branches/12
  13562. 2013-10-29 11:15 +0000 [r402140] Joshua Colp <jcolp@digium.com>
  13563. * /, rest-api/api-docs/playback.json, res/res_ari_playback.c:
  13564. res_ari_playback: Add missing 404 error response for GET and
  13565. DELETE. (closes issue ASTERISK-22722) Reported by: Richard
  13566. Mudgett ........ Merged revisions 402139 from
  13567. http://svn.asterisk.org/svn/asterisk/branches/12
  13568. 2013-10-28 22:10 +0000 [r402128-402130] David M. Lee <dlee@digium.com>
  13569. * /, doc: Ignore full docs ........ Merged revisions 402127 from
  13570. http://svn.asterisk.org/svn/asterisk/branches/12
  13571. * /: Put back several merge revisions that were lost in r402054
  13572. * /: Put back several merge revisions that were lost in r401962
  13573. 2013-10-28 15:08 +0000 [r402113-402117] Michael L. Young <elgueromexicano@gmail.com>
  13574. * /, UPGRADE-11.txt, UPGRADE-12.txt: Fix UPGRADE.txt Due To Merging
  13575. From Branch 11 When merging in the patch for ASTERISK-22728, the
  13576. UPGRADE.txt file was changed incorrectly. That change should have
  13577. gone into ASTERISK-11.txt. This commit is to fix that. Also,
  13578. another comment in the UPGRADE-11.txt was missing and this commit
  13579. adds that as well. ........ Merged revisions 402115 from
  13580. http://svn.asterisk.org/svn/asterisk/branches/12
  13581. * /, channels/chan_sip.c, UPGRADE-12.txt: chan_sip: Clarify
  13582. 'Forcerport' Setting Displayed When Running "sip show peers"
  13583. While looking at ASTERISK-22236, Walter Doekes pointed out that
  13584. when running "sip show peers", the setting being displayed can be
  13585. confusing. The display of "N" used to mean NAT (i.e. yes). The
  13586. NAT setting has gone through many different changes resulting in
  13587. the display of different characters to try and convey what the
  13588. current setting is for 'Forcerport' (A for Auto and Forcerport is
  13589. currently on, a for Auto but Forcerport is off, Y for yes, and N
  13590. for no). During the initial code review to try and clarify these
  13591. settings (especially since "N" no longer meant what it used to
  13592. mean in prior versions of Asterisk), Mark Michelson suggested
  13593. using the full space available to display the settings which
  13594. helped to make the settings very clear. That was a great
  13595. suggestion. Therefore, this patch does the following: * The
  13596. column for 'Forcerport' now will show: Auto (Yes), Auto (No),
  13597. Yes, or No. * A column for the 'Comedia' setting has been added.
  13598. It too will display the setting in a non-cryptic way: Auto (Yes),
  13599. Auto (No), Yes, or No. * UPGRADE.txt has been updated to document
  13600. this change. (closes issue ASTERISK-22728) Reported by: Walter
  13601. Doekes Tested by: Michael L. Young Patches:
  13602. asterisk-forcerport-display-clarification_v3.diff uploaded by
  13603. Michael L. Young (license 5026) Review:
  13604. https://reviewboard.asterisk.org/r/2941 ........ Merged revisions
  13605. 402111 from http://svn.asterisk.org/svn/asterisk/branches/11
  13606. ........ Merged revisions 402112 from
  13607. http://svn.asterisk.org/svn/asterisk/branches/12
  13608. 2013-10-27 23:22 +0000 [r402073-402091] Matthew Jordan <mjordan@digium.com>
  13609. * main/cdr.c, /: Filter out internal channels from dial message
  13610. handling Surrogate channels would pop up from time to time in
  13611. dial message handling. This would cause a WARNING message to
  13612. appear, indicating that the Surrogate channel had no CDR. This
  13613. patch filters out those channels that have the internal
  13614. implementation flag set, such that the WARNING message isn't
  13615. displayed. ........ Merged revisions 402090 from
  13616. http://svn.asterisk.org/svn/asterisk/branches/12
  13617. * cdr/cdr_sqlite3_custom.c, /, cdr/cdr_syslog.c, cdr/cdr_sqlite.c,
  13618. cdr/cdr_adaptive_odbc.c, addons/cdr_mysql.c,
  13619. include/asterisk/cdr.h, cdr/cdr_pgsql.c, cdr/cdr_odbc.c,
  13620. cdr/cdr_radius.c, cdr/cdr_custom.c, cdr/cdr_manager.c,
  13621. cdr/cdr_tds.c, cdr/cdr_csv.c, main/cdr.c: Prevent CDR backends
  13622. from unregistering while billing data is in flight This patch
  13623. makes it so that CDR backends cannot be unregistered while active
  13624. CDR records exist. This helps to prevent billing data from being
  13625. lost during restarts and shutdowns. Review:
  13626. https://reviewboard.asterisk.org/r/2880/ ........ Merged
  13627. revisions 402081 from
  13628. http://svn.asterisk.org/svn/asterisk/branches/12
  13629. * /, contrib/ast-db-manage/config/env.py,
  13630. contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py,
  13631. contrib/ast-db-manage/voicemail/env.py: Update Alembic database
  13632. scripts for external scripting and PostgreSQL, Oracle This patch
  13633. does the following: 1) The env scripts have been updated to be
  13634. tolerant of a NULL configuration file. This occurs when
  13635. configuration is provided by an external script, such that the
  13636. actual config.ini file is not used. 2) Enum types have all been
  13637. given names. This is needed for PostgreSQL script generation. 3)
  13638. The identifier meetme_confno_starttime_endtime is greater than 30
  13639. characters, and hence invalid for Oracle databases. This has been
  13640. truncated down to meetme_confno_start_end. ........ Merged
  13641. revisions 400383 from
  13642. http://svn.asterisk.org/svn/asterisk/branches/12
  13643. 2013-10-26 12:56 +0000 [r402065] Joshua Colp <jcolp@digium.com>
  13644. * channels/chan_pjsip.c, include/asterisk/res_pjsip_session.h, /:
  13645. chan_pjsip: Fix a crash when direct media is enabled and an ACK
  13646. is received after the channel is hung up. (closes issue
  13647. ASTERISK-22731) Reported by: Kinsey Moore ........ Merged
  13648. revisions 402064 from
  13649. http://svn.asterisk.org/svn/asterisk/branches/12
  13650. 2013-10-26 00:36 +0000 [r402056] Richard Mudgett <rmudgett@digium.com>
  13651. * res/res_stasis.c, /: res_stasis.c: Made use the ao2_container
  13652. callback templates. * Made res_stasis.c use the OBJ_SEARCH_XXX
  13653. defines. ........ Merged revisions 402055 from
  13654. http://svn.asterisk.org/svn/asterisk/branches/12
  13655. 2013-10-26 00:27 +0000 [r402054] Scott Griepentrog <sgriepentrog@digium.com>
  13656. * main/rtp_engine.c, /, include/asterisk/rtp_engine.h: rtp_engine:
  13657. fix rtp payloads copy and improve argument names In function
  13658. ast_rtp_instance_early _bridge_make_compatible the use of
  13659. instance 0/1 as arguments doesn't clearly communicate a direction
  13660. that the copying of payloads from the source channel to the
  13661. destination channel will occur, making it more probable to have
  13662. the arguments to ast_rtp_codecs_payloads_copy() put in the
  13663. reverse order. This patch renames the arguments with _dst and
  13664. _src suffixes and corrects the copy direction. (closes issue
  13665. ASTERISK-21464) Reported by: Kevin Stewart Review:
  13666. https://reviewboard.asterisk.org/r/2894/ ........ Merged
  13667. revisions 402000 from
  13668. http://svn.asterisk.org/svn/asterisk/branches/1.8 Test shows
  13669. rtpmap:119 being copied per this change, but is not in sip invite
  13670. ........ Merged revisions 402042 from
  13671. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13672. revisions 402043 from
  13673. http://svn.asterisk.org/svn/asterisk/branches/12
  13674. 2013-10-25 23:58 +0000 [r402004-402045] Richard Mudgett <rmudgett@digium.com>
  13675. * /, main/taskprocessor.c: taskprocessor: Made use pthread_equal()
  13676. to compare thread ids. * Removed another silly use of RAII_VAR().
  13677. RAII_VAR() and SCOPED_LOCK() are not silver bullets that allow
  13678. you to turn off your brain. ........ Merged revisions 402044 from
  13679. http://svn.asterisk.org/svn/asterisk/branches/12
  13680. * /, res/stasis/app.c: You'd think that new files would be free of
  13681. whitespace issues. But you would be wrong. ........ Merged
  13682. revisions 402003 from
  13683. http://svn.asterisk.org/svn/asterisk/branches/12
  13684. 2013-10-25 22:01 +0000 [r401999-402002] Jonathan Rose <jrose@digium.com>
  13685. * res/ari/resource_bridges.c, res/res_ari_bridges.c, /,
  13686. rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  13687. res/res_ari_channels.c, rest-api/api-docs/bridges.json: ARI:
  13688. channel/bridge recording errors when invalid format specified
  13689. Asterisk will now issue 422 if recording is requested against
  13690. channels or bridges with an unknown format (closes issue
  13691. ASTERISK-22626) Reported by: Joshua Colp Review:
  13692. https://reviewboard.asterisk.org/r/2939/ ........ Merged
  13693. revisions 402001 from
  13694. http://svn.asterisk.org/svn/asterisk/branches/12
  13695. * res/res_stasis_recording.c, rest-api/api-docs/channels.json,
  13696. res/ari/resource_channels.c, res/ari/ari_model_validators.c,
  13697. res/res_ari_channels.c, rest-api/api-docs/bridges.json,
  13698. rest-api/api-docs/recordings.json, res/ari/resource_bridges.c,
  13699. res/ari/ari_model_validators.h, res/res_ari_bridges.c,
  13700. rest-api/api-docs/events.json, /: ARI recordings: Issue HTTP
  13701. failures for recording requests with file conflicts If a file
  13702. already exists in the recordings directory with the same name as
  13703. what we would record, issue a 422 instead of relying on the
  13704. internal failure and issuing success. (closes issue
  13705. ASTERISK-22623) Reported by: Joshua Colp Review:
  13706. https://reviewboard.asterisk.org/r/2922/ ........ Merged
  13707. revisions 401973 from
  13708. http://svn.asterisk.org/svn/asterisk/branches/12
  13709. 2013-10-25 20:51 +0000 [r401962] Scott Griepentrog <sgriepentrog@digium.com>
  13710. * include/asterisk/pbx.h, main/pbx.c, /: pbx.c: fix confused match
  13711. caller id that deleted exten still in hash This fixes a bug where
  13712. a zero length callerid match adjacent to a no match callerid
  13713. extension entry would be deleted together, which then resulted in
  13714. hashtable references to free'd memory. A third state of the
  13715. matchcid value has been added to indicate match to any extension
  13716. which allows enforcing comparison of matchcid on/off without
  13717. errors. (closes issue AST-1235) Reported by: Guenther Kelleter
  13718. Review: https://reviewboard.asterisk.org/r/2930/ ........ Merged
  13719. revisions 401959 from
  13720. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13721. revisions 401960 from
  13722. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13723. revisions 401961 from
  13724. http://svn.asterisk.org/svn/asterisk/branches/12
  13725. 2013-10-25 17:41 +0000 [r401898-401939] Jonathan Rose <jrose@digium.com>
  13726. * /, res/res_pjsip/pjsip_distributor.c,
  13727. res/res_pjsip_endpoint_identifier_user.c: PJSIP: Add log messages
  13728. when requests are received for non-existent endpoints (closes
  13729. issue ASTERISK-22552) Reported by: Rusty Newton Review:
  13730. https://reviewboard.asterisk.org/r/2934/ ........ Merged
  13731. revisions 401938 from
  13732. http://svn.asterisk.org/svn/asterisk/branches/12
  13733. * utils/clicompat.c, utils/refcounter.c, /: Put clicompat-r2.patch
  13734. back in We've figured out how to resolve the problems this was
  13735. causing in 12/trunk, so this can go back in now. (issue
  13736. ASTERISK-22467) Reported by: Corey Farrell Patches:
  13737. clicompat-r2.patch uploaded by coreyfarrell (license 5909)
  13738. ........ Merged revisions 401914 from
  13739. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13740. revisions 401935 from
  13741. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13742. revisions 401936 from
  13743. http://svn.asterisk.org/svn/asterisk/branches/12
  13744. * /, utils/clicompat.c: revert clicompat-r2.patch from r401704
  13745. Patch caused the following build errors against testsuite
  13746. https://bamboo.asterisk.org/bamboo/browse/AST-ATRUNKBUILD4-244
  13747. (issue ASTERISK-22467) Reported by: Corey Farrell ........ Merged
  13748. revisions 401895 from
  13749. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13750. revisions 401896 from
  13751. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13752. revisions 401897 from
  13753. http://svn.asterisk.org/svn/asterisk/branches/12
  13754. 2013-10-25 16:09 +0000 [r401886] Kevin Harwell <kharwell@digium.com>
  13755. * /, channels/chan_sip.c: chan_sip: Allow a sip peer to accept both
  13756. AVP and AVPF calls Adapts the behaviour of avpf to only impact
  13757. the format of outgoing calls. For inbound calls, both AVP and
  13758. AVPF calls will be accepted regardless of the value of avpf in
  13759. the configuration. (closes issue ASTERISK-22005) Reported by:
  13760. Torrey Searle Patches: optional_avpf_trunk.patch uploaded by
  13761. tsearle (license 5334) ........ Merged revisions 401884 from
  13762. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13763. revisions 401885 from
  13764. http://svn.asterisk.org/svn/asterisk/branches/12
  13765. 2013-10-25 13:49 +0000 [r401873] David M. Lee <dlee@digium.com>
  13766. * tests/test_json.c, /: test_json: Fix deprecation warnings After a
  13767. series of upgrades over recent weeks, I've discovered that
  13768. test_json.c won't compile in dev mode any more for me. One of
  13769. gcc-4.8.2, OS X Mavericks or Xcode 5 has decided to deprecate
  13770. tempnam. Which, in general, is a good thing. But for test code
  13771. that just needs a temporary file, it's just annoying. This patch
  13772. replaces usage of tempname with mkstemp, avoiding the deprecation
  13773. warning. It also removes the temporary files when the test is
  13774. complete, which apparently we weren't doing before (oops).
  13775. Review: https://reviewboard.asterisk.org/r/2957/ ........ Merged
  13776. revisions 401872 from
  13777. http://svn.asterisk.org/svn/asterisk/branches/12
  13778. 2013-10-24 21:06 +0000 [r401836] Kevin Harwell <kharwell@digium.com>
  13779. * /, main/logger.c: Logging: Logging types ignored after specifying
  13780. a verbose level If one specified a verbose level within a logging
  13781. facility in logger.conf then any component after it was ignored.
  13782. Fixed so all values are correctly read. (closes issue
  13783. ASTERISK-22456) Reported by: Kevin Harwell ........ Merged
  13784. revisions 401833 from
  13785. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13786. revisions 401835 from
  13787. http://svn.asterisk.org/svn/asterisk/branches/12
  13788. 2013-10-24 20:48 +0000 [r401834] David M. Lee <dlee@digium.com>
  13789. * rest-api-templates/models.wiki.mustache,
  13790. rest-api/api-docs/events.json, /,
  13791. rest-api-templates/swagger_model.py,
  13792. rest-api-templates/ari_model_validators.c.mustache: The Swagger
  13793. 1.2 specification for type extension ended up being slightly
  13794. different than my proposal. Instead of putting an 'extends' field
  13795. on the subtype, the base type has a 'subTypes' field, which is a
  13796. list of the subTypes. Given that its a messaging model and not an
  13797. object model, kinda makes sense. This patch changes the
  13798. events.json api-doc, and the python translators to take the new
  13799. format into account. Other changes that are in Swagger 1.2 were
  13800. not adopted, since the spec is still in flux, and could change
  13801. before it's finalized. A summary of changes to the Swagger-1.2
  13802. spec can be found at
  13803. https://github.com/wordnik/swagger-core/wiki/1.2-transition.
  13804. (closes issue ASTERISK-22440) Review:
  13805. https://reviewboard.asterisk.org/r/2909/ ........ Merged
  13806. revisions 401701 from
  13807. http://svn.asterisk.org/svn/asterisk/branches/12
  13808. 2013-10-24 20:34 +0000 [r401622-401832] Jonathan Rose <jrose@digium.com>
  13809. * /, main/utils.c: utils: Fix memory leaks and missed
  13810. unregistration of CLI commands on shutdown Final set of patches
  13811. in a series of memory leak/cleanup patches by Corey Farrell
  13812. (closes issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  13813. main-utils-1.8.patch uploaded by coreyfarrell (license 5909)
  13814. main-utils-11.patch uploaded by coreyfarrell (license 5909)
  13815. main-utils-12up.patch uploaded by coreyfarrell (license 5909)
  13816. ........ Merged revisions 401829 from
  13817. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13818. revisions 401830 from
  13819. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13820. revisions 401831 from
  13821. http://svn.asterisk.org/svn/asterisk/branches/12
  13822. * /, tests/test_linkedlists.c: test_linkedlists: Fix memory leak
  13823. (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  13824. test_linkedlists-1.8.patch uploaded by coreyfarrell (license
  13825. 5909) test_linkedlists-11up.patch uploaded by coreyfarrell
  13826. (license 5909) ........ Merged revisions 401790 from
  13827. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13828. revisions 401791 from
  13829. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13830. revisions 401792 from
  13831. http://svn.asterisk.org/svn/asterisk/branches/12
  13832. * /, main/jitterbuf.c: jitterbuf: Fix memory leak on jitter buffer
  13833. reset (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  13834. jitterbuf-jb_reset-leak-1.8.patch
  13835. jitterbuf-jb_reset-leak-11up.patch ........ Merged revisions
  13836. 401786 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  13837. ........ Merged revisions 401787 from
  13838. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13839. revisions 401788 from
  13840. http://svn.asterisk.org/svn/asterisk/branches/12
  13841. * main/astobj2.c, /: astobj2: Unregister debug CLI commands at exit
  13842. (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  13843. astobj2-clean-debug-cli-1.8-11.patch uploaded by coreyfarrell
  13844. (license 5909) astobj2-clean-debug-cli-12up.patch uploaded by
  13845. coreyfarrell (license 5909) ........ Merged revisions 401781 from
  13846. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13847. revisions 401783 from
  13848. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13849. revisions 401784 from
  13850. http://svn.asterisk.org/svn/asterisk/branches/12
  13851. * apps/app_voicemail.c, /: app_voicemail: Memory Leaks against
  13852. tests (issue ASTERISK-22467) Reported by: Corey Farrell Patches:
  13853. app_voicemail-1.8.patch uploaded by coreyfarrell (license 5909)
  13854. app_voicemail-11up.patch uploaded by coreyfarrell (license 5909)
  13855. ........ Merged revisions 401743 from
  13856. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13857. revisions 401744 from
  13858. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13859. revisions 401745 from
  13860. http://svn.asterisk.org/svn/asterisk/branches/12
  13861. * main/app.c, main/asterisk.c, utils/clicompat.c,
  13862. channels/chan_dahdi.c, codecs/ilbc/doCPLC.c, main/data.c, /:
  13863. memory leaks: Memory leak cleanup patch by Corey Farrell (second
  13864. set) Also covers ast_app_parse_timelen-fail-zero-length.patch,
  13865. but the patch was replaced with one of my own. (issue
  13866. ASTERISK-22467) Reported by: Corey Farrell Patches:
  13867. chan_dahdi-cleanup_push.patch uploaded by coreyfarrell (license
  13868. 5909) clicompat-r2.patch uploaded by coreyfarrell (license 5909)
  13869. codecs-ilbc-doCPLC.patch uploaded by coreyfarrell (license 5909)
  13870. data-cleanup-test-registration.patch uploaded by coreyfarrell
  13871. (license 5909) main-asterisk-kill-listener.patch uploaded by
  13872. coreyfarrell (license 5909) ........ Merged revisions 401704 from
  13873. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13874. revisions 401705 from
  13875. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13876. revisions 401706 from
  13877. http://svn.asterisk.org/svn/asterisk/branches/12
  13878. * /, tests/test_dlinklists.c, funcs/func_math.c,
  13879. channels/sip/reqresp_parser.c, main/test.c,
  13880. main/editline/readline.c: memory leaks: Memory leak cleanup patch
  13881. by Corey Farrell (first set) (issue ASTERSIK-22467) Reported by:
  13882. Corey Farrell Patches:
  13883. chan_sip-parse_contact_header_test-free-contacts.patch uploaded
  13884. by coreyfarrell (license 5909) cli-filename-completion-leak.patch
  13885. uploaded by coreyfarrell (license 5909) func_math.patch uploaded
  13886. by corefarrell (license 5909) main-test-cleanup.patch uploaded by
  13887. coreyfarrell (license 5909) test_dlinklists.patch uploaded by
  13888. coreyfarrell (license 5909) ........ Merged revisions 401660 from
  13889. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13890. revisions 401661 from
  13891. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13892. revisions 401662 from
  13893. http://svn.asterisk.org/svn/asterisk/branches/12
  13894. * /, main/translate.c, res/res_rtp_asterisk.c: res_rtp_asterisk:
  13895. Address jittery DTMF events in RTP streams (closes issue
  13896. ASTERISK-21170) Reported by: NITESH BANSAL Patches:
  13897. dtmf-timestamp.patch uploaded by NITESH BANSAL (license 6418)
  13898. Review: https://reviewboard.asterisk.org/r/2938/ ........ Merged
  13899. revisions 401619 from
  13900. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13901. revisions 401620 from
  13902. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13903. revisions 401621 from
  13904. http://svn.asterisk.org/svn/asterisk/branches/12
  13905. 2013-10-23 16:52 +0000 [r401582] Richard Mudgett <rmudgett@digium.com>
  13906. * /, cdr/cdr_adaptive_odbc.c: cdr_adaptive_odbc: Also apply a
  13907. filter when the CDR value is empty. Extra CDR records are written
  13908. if a filtered CDR value is empty because the filter is not
  13909. checked. (closes issue ASTERISK-22272) Reported by: Jordi Llull
  13910. Chavarria ........ Merged revisions 401577 from
  13911. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13912. revisions 401579 from
  13913. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13914. revisions 401581 from
  13915. http://svn.asterisk.org/svn/asterisk/branches/12
  13916. 2013-10-23 16:48 +0000 [r401580] John Bigelow <jbigelow@digium.com>
  13917. * /, main/bridge_channel.c: Add a test suite event to indicate when
  13918. the atxfer 3-way feature is detected This adds a test suite event
  13919. that indicates to tests when the attended transfer three-way call
  13920. feature is detected. Review:
  13921. https://reviewboard.asterisk.org/r/2912/ ........ Merged
  13922. revisions 401578 from
  13923. http://svn.asterisk.org/svn/asterisk/branches/12
  13924. 2013-10-23 15:23 +0000 [r401540] Kinsey Moore <kmoore@digium.com>
  13925. * channels/chan_mgcp.c, /: chan_mgcp: Properly handle malformed
  13926. media lines This corrects a situation in which a media line was
  13927. not parsed properly and resulted in a crash. (closes issue
  13928. ASTERISK-21190) Reported by: adomjan Patches:
  13929. chan_mgcp.c-sscnaf_fix uploaded by adomjan (License 5448)
  13930. ........ Merged revisions 401537 from
  13931. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13932. revisions 401538 from
  13933. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13934. revisions 401539 from
  13935. http://svn.asterisk.org/svn/asterisk/branches/12
  13936. 2013-10-23 11:16 +0000 [r401500] Joshua Colp <jcolp@digium.com>
  13937. * /, channels/chan_sip.c: chan_sip: Fix an issue where an
  13938. incompatible audio format may be added to SDP. If preferred
  13939. codecs included any non-audio format the code would mistakenly
  13940. add the audio format, even if it was not a joint capability with
  13941. the remote side. (closes issue ASTERISK-21131) Reported by:
  13942. nbougues Patches: patch_unsupported_codec_1.8.patch uploaded by
  13943. nbougues (license 6470) ........ Merged revisions 401497 from
  13944. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13945. revisions 401498 from
  13946. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13947. revisions 401499 from
  13948. http://svn.asterisk.org/svn/asterisk/branches/12
  13949. 2013-10-23 02:36 +0000 [r401489] Michael L. Young <elgueromexicano@gmail.com>
  13950. * channels/chan_iax2.c, configs/iax.conf.sample, /: chan_iax2: Fix
  13951. Binding To Multiple Addresses Again When reworking chan_iax2 for
  13952. IPv6, the ability to bind to multiple addresses was removed by
  13953. mistake. This patch restores this functionality and adds notes
  13954. about IPv6 addresses in the sample config. (closes issue
  13955. ASTERISK-22741) Reported by: Joshua Colp Tested by: Michael L.
  13956. Young Patches: asterisk-22741-fix-binding-multiple-addr.diff
  13957. uploaded by Michael L. Young (license 5026) Review:
  13958. https://reviewboard.asterisk.org/r/2945/ ........ Merged
  13959. revisions 401488 from
  13960. http://svn.asterisk.org/svn/asterisk/branches/12
  13961. 2013-10-22 23:10 +0000 [r401450] Matthew Jordan <mjordan@digium.com>
  13962. * /, res/res_rtp_asterisk.c: res_rtp_asterisk: Fix crash when RTCP
  13963. is not available during SSRC change In r400089, a patch was put
  13964. in to correct erroneous RTCP statistic resets. Unfortunately,
  13965. ast_rtp_read can be called on an RTP instance that does not have
  13966. RTCP information. This patch prevents that crash by only
  13967. resetting the statistics if we do actually have an RTCP instance.
  13968. (issue AST-1174) (closes issue ASTERISK-22667) Reported by: John
  13969. Bigelow ........ Merged revisions 401445 from
  13970. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  13971. revisions 401446 from
  13972. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13973. revisions 401447 from
  13974. http://svn.asterisk.org/svn/asterisk/branches/12
  13975. 2013-10-22 19:04 +0000 [r401421-401435] Richard Mudgett <rmudgett@digium.com>
  13976. * apps/app_queue.c, /: app_queue: Fix CLI "queue remove member"
  13977. queue_log entry. The queue_log entry resulting from CLI "queue
  13978. remove member" when log_membername_as_agent is enabled is wrong.
  13979. It always uses the interface name instead of the member name in
  13980. the queue_log entry. * Get the queue member before removing it
  13981. from the queue so the member name is available for the queue_log
  13982. entry. (closes issue ASTERISK-21826) Reported by: Oscar Esteve
  13983. Patches: fix_membername.diff (license #6505) patch uploaded by
  13984. Oscar Esteve (modified to fix potential ref leak) ........ Merged
  13985. revisions 401433 from
  13986. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  13987. revisions 401434 from
  13988. http://svn.asterisk.org/svn/asterisk/branches/12
  13989. * main/bridge_channel.c,
  13990. include/asterisk/bridge_channel_internal.h, /, main/bridge.c:
  13991. Bridging: Fix orphaned bridge if neither of the joining channels
  13992. can join. The original issue noted that the bridge is orphaned
  13993. when res_parking.so is not loaded and a call uses the dial kK
  13994. flags. A similar issue happens when only one of the park flags is
  13995. used. In this case you have the bridge with one or the other
  13996. channel left in it. The channel and bridge will stay around until
  13997. the channel hangs up. * Fixed the initial bridge channel push
  13998. failure to act as if the channel were kicked out of the bridge.
  13999. The bridge then decides if it needs to be dissolved. (closes
  14000. issue ASTERISK-22629) Reported by: Kevin Harwell Review:
  14001. https://reviewboard.asterisk.org/r/2928/ ........ Merged
  14002. revisions 401424 from
  14003. http://svn.asterisk.org/svn/asterisk/branches/12
  14004. * res/parking/parking_bridge_features.c,
  14005. res/parking/parking_bridge.c, /: res_parking: Give parking
  14006. timeout comebacktoorigin channel DTMF features. Parking timeouts
  14007. did not set any DTMF features for the channel calling the parker
  14008. back. * Added code to set the parkedcalltransfers,
  14009. parkedcallreparking, parkedcallhangup, and parkedcallrecording
  14010. options appropriately for the channels when a parking timeout
  14011. occurs. The recall channel DTMF options are set using the
  14012. BRIDGE_FEATURES channel variable to allow the other timeout
  14013. options to have the DTMF features available. (closes issue
  14014. ASTERISK-22630) Reported by: Kevin Harwell Review:
  14015. https://reviewboard.asterisk.org/r/2942/ ........ Merged
  14016. revisions 401422 from
  14017. http://svn.asterisk.org/svn/asterisk/branches/12
  14018. * /, res/res_parking.c: res_parking: Update XML documention for
  14019. DTMF features after parking timeout. * Updated the XML
  14020. documentation to indicate that the parkedcalltransfers,
  14021. parkedcallreparking, parkedcallhangup, and parkedcallrecording
  14022. configuration options also apply to parking timeouts. (issue
  14023. ASTERISK-22630) Reported by: Kevin Harwell Review:
  14024. https://reviewboard.asterisk.org/r/2942/ ........ Merged
  14025. revisions 401420 from
  14026. http://svn.asterisk.org/svn/asterisk/branches/12
  14027. 2013-10-22 15:17 +0000 [r401411] Joshua Colp <jcolp@digium.com>
  14028. * apps/app_dial.c: Add an 'R' option to Dial which sends ringing
  14029. until early media has been received. (closes issue
  14030. ASTERISK-10487) Reported by: Gaspar Zoltan Patches: 10487.patch
  14031. uploaded by n8ideas (license 6075)
  14032. 2013-10-21 21:06 +0000 [r401365] Mark Michelson <mmichelson@digium.com>
  14033. * /, main/bridge_channel.c: Remove a noisy debug message from
  14034. bridging code. This particular debug message, during a stress
  14035. test, was logged so often that it appeared that there may be a
  14036. memory leak in the logger code. In actuality, there was no memory
  14037. leak, but the logger thread was having a hard time keeping up
  14038. with the demands of the rest of the system. Since this debug
  14039. message has no value at all, the best way to fix the problem was
  14040. to just remove the message. (closes issue AST-1225) reported by
  14041. John Bigelow Patches: spammy_log.diff uploaded by Mark Michelson
  14042. (License #5049) ........ Merged revisions 401364 from
  14043. http://svn.asterisk.org/svn/asterisk/branches/12
  14044. 2013-10-21 19:50 +0000 [r401328] Kevin Harwell <kharwell@digium.com>
  14045. * /, main/editline/term.c: Segfault in LIBEDIT_INTERNAL after
  14046. tgetstr(), when libncurses5-dev isn't installed Include the
  14047. appropriate declarations when not using termcap, but term+curses
  14048. and [n]curses do not exist. (closes issue ASTERISK-22351)
  14049. Reported by: A. Iglesias Patches:
  14050. issueA22351_libedit_internal_without_ncurses_dev.patch uploaded
  14051. by wdoekes (license 5674) ........ Merged revisions 401325 from
  14052. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14053. revisions 401326 from
  14054. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14055. revisions 401327 from
  14056. http://svn.asterisk.org/svn/asterisk/branches/12
  14057. 2013-10-21 18:59 +0000 [r401316-401317] David M. Lee <dlee@digium.com>
  14058. * rest-api/api-docs/channels.json, /: Fixing r401281; the model
  14059. name is Channel, with a capital C ........ Merged revisions
  14060. 401315 from http://svn.asterisk.org/svn/asterisk/branches/12
  14061. * res/res_ari.c, /: Fixed malformed Access-Control-Allow-Methods
  14062. header. Was causing Safari to barf on POST and DELETE. ........
  14063. Merged revisions 401106 from
  14064. http://svn.asterisk.org/svn/asterisk/branches/12
  14065. 2013-10-19 21:57 +0000 [r401292] Kinsey Moore <kmoore@digium.com>
  14066. * /, channels/chan_iax2.c: Fix IAX2 incoming call address lookups
  14067. This fixes address lookup for incoming calls without a peer
  14068. definition. The address family was unset instead of being set to
  14069. AST_AF_UNSPEC which was causing lookup failures on "127.0.0.1".
  14070. This is one of the causes of the current failure of the app_page
  14071. integration test. Review:
  14072. https://reviewboard.asterisk.org/r/2933/ ........ Merged
  14073. revisions 401291 from
  14074. http://svn.asterisk.org/svn/asterisk/branches/12
  14075. 2013-10-19 14:45 +0000 [r401282] Joshua Colp <jcolp@digium.com>
  14076. * res/ari/resource_channels.h, main/pbx.c, /,
  14077. rest-api/api-docs/channels.json, res/ari/resource_channels.c,
  14078. res/res_ari_channels.c: Return a channel snapshot when
  14079. originating using ARI, and subscribe the Stasis application to
  14080. it. This change allows a user of ARI to know what channel it has
  14081. originated and also follow any progress. If a Stasis application
  14082. is provided it will be automatically subscribed to the originated
  14083. channel immediately. (closes issue ASTERISK-22485) Reported by:
  14084. David Lee Review: https://reviewboard.asterisk.org/r/2910/
  14085. ........ Merged revisions 401281 from
  14086. http://svn.asterisk.org/svn/asterisk/branches/12
  14087. 2013-10-18 22:52 +0000 [r401272] Richard Mudgett <rmudgett@digium.com>
  14088. * /, res/parking/parking_controller.c: res_parking: Remove setting
  14089. useless flag. ........ Merged revisions 401271 from
  14090. http://svn.asterisk.org/svn/asterisk/branches/12
  14091. 2013-10-18 21:51 +0000 [r401263] David M. Lee <dlee@digium.com>
  14092. * contrib/scripts/get_swagger_ui.sh (added), Makefile, /,
  14093. static-http: This is just a quick script for dumping swagger-ui
  14094. into static-http, so that it can be served by the Asterisk web
  14095. server. I had to change the Makefile in order to recursively
  14096. install content from the static-http directory, hence the code
  14097. review instead of just putting it in. Review:
  14098. https://reviewboard.asterisk.org/r/2924/ ........ Merged
  14099. revisions 401261 from
  14100. http://svn.asterisk.org/svn/asterisk/branches/12
  14101. 2013-10-18 18:44 +0000 [r401249] Mark Michelson <mmichelson@digium.com>
  14102. * main/sorcery.c, main/cli.c, main/manager.c, /, main/bridge.c,
  14103. main/bucket.c: Resolve some memory leaks due to incorrect for
  14104. loop / ao2 ref usage. A common idiom in Asterisk is to due
  14105. something like: for (ao2_obj = list_beginning; ao2_obj =
  14106. next_item; ao2_ref(ao2_obj, -1)) { ...do stuff... } This is nice
  14107. because it automatically takes care of the object references for
  14108. you. However, there is a pitfall here. If a break statement is in
  14109. the for loop, then the current reference is not cleaned up. In
  14110. some cases, this is on purpose, but in others there is a leak.
  14111. This commit fixes the leak cases. ........ Merged revisions
  14112. 401248 from http://svn.asterisk.org/svn/asterisk/branches/12
  14113. 2013-10-18 16:59 +0000 [r401233-401240] Richard Mudgett <rmudgett@digium.com>
  14114. * /, res/res_fax.c, include/asterisk/channel.h, apps/app_dial.c,
  14115. main/channel.c: Add channel lock protection around translation
  14116. path setup. Most callers of ast_channel_make_compatible() happen
  14117. before the channels enter a two party bridge. With the new
  14118. bridging framework, two party bridging technologies may also call
  14119. ast_channel_make_compatible() when there is more than one thread
  14120. involved with the two channels. * Added channel lock protection
  14121. in set_format() and ast_channel_make_compatible_helper() when
  14122. dealing with the channel's native formats while setting up a
  14123. translation path. * Fixed best_src_fmt and best_dst_fmt usage
  14124. consistency in ast_channel_make_compatible_helper(). The call to
  14125. ast_translator_best_choice() got them backwards. * Updated some
  14126. callers of ast_channel_make_compatible() and the function
  14127. documentation. There is actually a difference between the two
  14128. channels passed in. * Fixed the deadlock potential in res_fax.c
  14129. dealing with ast_channel_make_compatible(). The deadlock
  14130. potential was already there anyway because res_fax called
  14131. ast_channel_make_compatible() with chan locked. (closes issue
  14132. ASTERISK-22542) Reported by: Matt Jordan Review:
  14133. https://reviewboard.asterisk.org/r/2915/ ........ Merged
  14134. revisions 401239 from
  14135. http://svn.asterisk.org/svn/asterisk/branches/12
  14136. * /, include/asterisk/bridge.h: Tweak ast_bridge_depart() doxygen.
  14137. ........ Merged revisions 401232 from
  14138. http://svn.asterisk.org/svn/asterisk/branches/12
  14139. 2013-10-18 16:06 +0000 [r401216-401224] Mark Michelson <mmichelson@digium.com>
  14140. * include/asterisk/bridge.h, /: Remove the bit about requiring
  14141. ast_bridge_depart() to be called before ast_bridge_destroy().
  14142. ........ Merged revisions 401223 from
  14143. http://svn.asterisk.org/svn/asterisk/branches/12
  14144. * include/asterisk/bridge.h, /: Clarify in ast_bridge_destroy()
  14145. about how departable channels must be handled. ........ Merged
  14146. revisions 401212 from
  14147. http://svn.asterisk.org/svn/asterisk/branches/12
  14148. 2013-10-18 15:14 +0000 [r401184] Michael L. Young <elgueromexicano@gmail.com>
  14149. * /, channels/chan_sip.c: Remove Port Restriction When Checking For
  14150. NAT When trying to determine if a peer is behind NAT, we should
  14151. not be using the ports when comparing addresses. This patch
  14152. removes the port from being checked and just useds the addresses
  14153. now. (closes issue ASTERISK-22729) Reported by: Michael L. Young
  14154. Tested by: Michael L. Young Patches:
  14155. asterisk-remove-using-port-for-nat-check.diff uploaded by Michael
  14156. L. Young (license 5026) Review:
  14157. https://reviewboard.asterisk.org/r/2927/ ........ Merged
  14158. revisions 401182 from
  14159. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14160. revisions 401183 from
  14161. http://svn.asterisk.org/svn/asterisk/branches/12
  14162. 2013-10-18 14:50 +0000 [r401181] Walter Doekes <walter+asterisk@wjd.nu>
  14163. * main/channel.c, /: Properly copy/remove the device state cache
  14164. flag over a masquerade. In r378303 the
  14165. AST_FLAG_DISABLE_DEVSTATE_CACHE flag was added that tells the
  14166. devstate system to not cache states for non-real devices.
  14167. However, when optimizing away channels (ast_do_masquerade), that
  14168. flag wasn't copied. In my case, using Local devices as queue
  14169. members created a situation where the endpoint was considered in
  14170. use, but the state change of the device being available again was
  14171. ignored (not cached). The endpoint channel was optimized into the
  14172. (previously) Local channel, but kept the do-not-cache flag. The
  14173. end result being that the queue member apparently stayed in use
  14174. forever. (closes issue ASTERISK-22718) Reported by: Walter Doekes
  14175. Review: https://reviewboard.asterisk.org/r/2925/ ........ Merged
  14176. revisions 401178 from
  14177. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14178. revisions 401179 from
  14179. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14180. revisions 401180 from
  14181. http://svn.asterisk.org/svn/asterisk/branches/12
  14182. 2013-10-17 20:39 +0000 [r401169] Michael L. Young <elgueromexicano@gmail.com>
  14183. * /, channels/chan_sip.c: Fix Setting A chan_sip Dialog's
  14184. SIP_NAT_FORCE_RPORT Flag A condition was added in a commit to fix
  14185. ASTERISK-21374, that, if the SIP_PAGE3_NAT_AUTO_RPORT flag was
  14186. set, to then copy a peer's SIP_NAT_FORCE_RPORT flag to the
  14187. dialog. This condition should not have been there since it
  14188. assumed that if Asterisk is in an environment where NAT is
  14189. involved, that the auto_* nat settings or force_rport setting
  14190. would be on in the global settings. If the nat setting in the
  14191. global setting is set to 'nat=no' and then turned on for peers
  14192. (which is not quite the recommended way, although it is allowed)
  14193. this flag is never copied to the dialog resulting in problems
  14194. like, REGISTER replies going to the wrong port. This patch
  14195. removes this conditional check and will now always use the peer's
  14196. flag which by this point in the code the checks on whether the
  14197. peer is behind NAT or not (if using auto_force_rport) have
  14198. already been run. (closes issue ASTERISK-22236) Reported by:
  14199. Filip Frank Tested by: Michael L. Young Patches:
  14200. asterisk-2236-always-set-rport.diff uploaded by Michael L. Young
  14201. (license 5026) Review: https://reviewboard.asterisk.org/r/2919/
  14202. ........ Merged revisions 401167 from
  14203. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14204. revisions 401168 from
  14205. http://svn.asterisk.org/svn/asterisk/branches/12
  14206. 2013-10-17 18:25 +0000 [r401159] Jonathan Rose <jrose@digium.com>
  14207. * res/res_parking.c, /: res_parking: Fix bug where reloading
  14208. immediately wipes new parkpos extensions (closes issue
  14209. ASTERISK-22631) Reported by: Kevin Harwell ........ Merged
  14210. revisions 401158 from
  14211. http://svn.asterisk.org/svn/asterisk/branches/12
  14212. 2013-10-17 15:41 +0000 [r401122] Kinsey Moore <kmoore@digium.com>
  14213. * /, res/res_xmpp.c, res/res_jabber.c: Reduce log level of a
  14214. non-pubsub error message Drop an error log message to debug level
  14215. 1 since distributed device state functions correctly when
  14216. receiving this message and it spams the logs. (closes issue
  14217. ASTERISK-22410) Reported by: abelbeck Patches:
  14218. asterisk-1.8-res_jabber-log-nonpubsub-error-to-debug.patch
  14219. uploaded by abelbeck (License 5903)
  14220. asterisk-11-res_xmpp-log-nonpubsub-error-to-debug.patch uploaded
  14221. by abelbeck (License 5903) ........ Merged revisions 401119 from
  14222. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14223. revisions 401120 from
  14224. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14225. revisions 401121 from
  14226. http://svn.asterisk.org/svn/asterisk/branches/12
  14227. 2013-10-16 21:22 +0000 [r401108] Richard Mudgett <rmudgett@digium.com>
  14228. * /, res/ari/resource_playback.c: ARI: Fix crash when POST
  14229. /playback/{id}/control does not have an operation parameter.
  14230. (closes issue ASTERISK-22680) Reported by: John Bigelow ........
  14231. Merged revisions 401107 from
  14232. http://svn.asterisk.org/svn/asterisk/branches/12
  14233. 2013-10-16 17:01 +0000 [r401097] David M. Lee <dlee@digium.com>
  14234. * rest-api/resources.json, /: Oops. Leftover /stasis reference
  14235. ........ Merged revisions 401096 from
  14236. http://svn.asterisk.org/svn/asterisk/branches/12
  14237. 2013-10-16 14:02 +0000 [r401088] Kinsey Moore <kmoore@digium.com>
  14238. * rest-api/api-docs/bridges.json, res/ari/resource_channels.h, /,
  14239. res/ari/resource_bridges.h, rest-api/api-docs/channels.json:
  14240. Clarify documentation for channel and bridge list This makes it
  14241. clear that the ARI API calls for listing channels and bridges
  14242. will list all channels or bridges in the system and not just
  14243. those that are in or are controlled by a Stasis application.
  14244. (closes issue ASTERISK-22635) Reported by: Kevin Harwell ........
  14245. Merged revisions 401087 from
  14246. http://svn.asterisk.org/svn/asterisk/branches/12
  14247. 2013-10-16 12:19 +0000 [r401079] Walter Doekes <walter+asterisk@wjd.nu>
  14248. * /, apps/app_queue.c: Don't check all realtime queues when doing
  14249. "queue show some_queue". When using realtime queues, queues have
  14250. to be fetched from the database every now and then to see if any
  14251. info has been changed or to see if the queue has been removed.
  14252. When fetching info for an individual queue, the pruning of other
  14253. queues is unnecessarily costly. Review:
  14254. https://reviewboard.asterisk.org/r/2907/ ........ Merged
  14255. revisions 401049 from
  14256. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14257. revisions 401076 from
  14258. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14259. revisions 401077 from
  14260. http://svn.asterisk.org/svn/asterisk/branches/12
  14261. 2013-10-16 00:12 +0000 [r401041] Paul Belanger <paul.belanger@polybeacon.com>
  14262. * /, rest-api/api-docs/bridges.json, res/res_ari_bridges.c: Use
  14263. POST / DELETE to toggle ARI bridge moh Review:
  14264. https://reviewboard.asterisk.org/r/2911/ ........ Merged
  14265. revisions 401040 from
  14266. http://svn.asterisk.org/svn/asterisk/branches/12
  14267. 2013-10-15 23:44 +0000 [r401020-401039] Richard Mudgett <rmudgett@digium.com>
  14268. * main/translate.c: translate.c: Some minor code tweaks. *
  14269. Consistently compare format2index() return value so matrix_get()
  14270. cannot get passed negative values. * Optimize
  14271. ast_translator_best_choice() to defer initializing things until
  14272. needed. Also cached the matrix_get() return value rather than
  14273. repeatedly calling it.
  14274. * /, channels/dahdi/bridge_native_dahdi.c: bridge_native_dahdi:
  14275. Return channel join failure if could not make the channels
  14276. compatible. ........ Merged revisions 401030 from
  14277. http://svn.asterisk.org/svn/asterisk/branches/12
  14278. * /, channels/chan_iax2.c: chan_iax2: Fix channel left locked in
  14279. off nominal code path. ........ Merged revisions 401016 from
  14280. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14281. revisions 401017 from
  14282. http://svn.asterisk.org/svn/asterisk/branches/12
  14283. 2013-10-15 20:03 +0000 [r401019] Kinsey Moore <kmoore@digium.com>
  14284. * rest-api/api-docs/bridges.json, res/res_ari_bridges.c, /: Ensure
  14285. bridge record error responses validate This adds the list of
  14286. expected errors to the /bridges/{bridgeId}/record ARI
  14287. documentation so that outbound 4xx errors validate properly.
  14288. Previously, this would result in a response validation failure.
  14289. (closes issue ASTERISK-22627) Reported by: Joshua Colp ........
  14290. Merged revisions 401018 from
  14291. http://svn.asterisk.org/svn/asterisk/branches/12
  14292. 2013-10-15 15:30 +0000 [r401007] Paul Belanger <paul.belanger@polybeacon.com>
  14293. * rest-api/api-docs/channels.json, res/res_ari_channels.c, /: Use
  14294. POST / DELETE to toggle hold / moh for ARI channels This change
  14295. updates how we handle toggle events, rather then create two
  14296. different function names, we'll just use POST / DELETE from HTTP
  14297. to handle it. Review: https://reviewboard.asterisk.org/r/2906/
  14298. ........ Merged revisions 400999 from
  14299. http://svn.asterisk.org/svn/asterisk/branches/12
  14300. 2013-10-15 15:26 +0000 [r400998] Mark Michelson <mmichelson@digium.com>
  14301. * /, channels/chan_sip.c: Prevent chan_sip from sending duplicate
  14302. BYEs. When a 200 OK for an initial INVITE is received, we were
  14303. doing the right thing by ACKing and sending an immediate BYE.
  14304. However, we also were doing the wrong thing and queuing an answer
  14305. frame, thus causing the call to be answered. This would cause the
  14306. call to be hung up by the channel thread, thus resulting in a
  14307. second BYE being sent out. In this fix, I also have set the
  14308. hangupcause to be correct since the initial BYE being sent by
  14309. Asterisk had an unknown hangup cause. I have changed to using
  14310. "Bearer capabilty not available" since the call was hung up due
  14311. to an SDP offer/answer error. (closes issue ASTERISK-22621)
  14312. reported by Kinsey Moore ........ Merged revisions 400970 from
  14313. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14314. revisions 400971 from
  14315. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14316. revisions 400984 from
  14317. http://svn.asterisk.org/svn/asterisk/branches/12
  14318. 2013-10-15 13:44 +0000 [r400959] David M. Lee <dlee@digium.com>
  14319. * /, rest-api-templates/asterisk_processor.py: My doc correction in
  14320. r400842 had a silly bug. Because I added a wiki_description to
  14321. models and not their properties, the rendered wiki page had the
  14322. model description instead of the property descriptions, which
  14323. looks very silly indeed. (closes issue ASTERISK-22705) ........
  14324. Merged revisions 400958 from
  14325. http://svn.asterisk.org/svn/asterisk/branches/12
  14326. 2013-10-14 22:52 +0000 [r400913-400950] Richard Mudgett <rmudgett@digium.com>
  14327. * channels/chan_dahdi.c, configs/chan_dahdi.conf.sample,
  14328. channels/chan_dahdi.h: chan_dahdi: Add config support for hwgain
  14329. settings. * Add hwtxgain and hwrxgain config options to
  14330. chan_dahdi.conf with documentation in chan_dahdi.conf.sample.
  14331. (closes issue ASTERISK-22429) Reported by: Jaco Kroon Patches:
  14332. jira_asterisk_22429_hwgain_trunk.patch (license #5621) patch
  14333. uploaded by rmudgett
  14334. * channels/chan_dahdi.c, /, channels/chan_dahdi.h: chan_dahdi:
  14335. Reflect the set software gain in the CLI "dahdi show channel"
  14336. output. * Remember the swgain setting from CLI "dahdi set swgain"
  14337. command so the CLI "dahdi show channel" output will reflect the
  14338. current setting. * Updated CLI "dahdi set hwgain" and "dahdi set
  14339. swgain" documentation. (issue ASTERISK-22429) Reported by: Jaco
  14340. Kroon Patches: jira_asterisk_22429_v1.8_v2.patch (license #5621)
  14341. patch uploaded by rmudgett ........ Merged revisions 400907 from
  14342. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14343. revisions 400909 from
  14344. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14345. revisions 400911 from
  14346. http://svn.asterisk.org/svn/asterisk/branches/12
  14347. 2013-10-14 22:03 +0000 [r400912] Mark Michelson <mmichelson@digium.com>
  14348. * /, channels/chan_sip.c: chan_sip: Do not increment the SDP
  14349. version between 183 and 200 responses. Bumping the SDP version
  14350. number can cause interoperability problems since receivers of the
  14351. responses will expect that a 200 SDP will be identical to a
  14352. previous 183 SDP. (closes issue ASTERISK-21204) reported by
  14353. NITESH BANSAL Patches:
  14354. dont-increment-session-version-in-2xx-after-183.patch uploaded by
  14355. NITESH BANSAL (License #6418) ........ Merged revisions 400906
  14356. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  14357. Merged revisions 400908 from
  14358. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14359. revisions 400910 from
  14360. http://svn.asterisk.org/svn/asterisk/branches/12
  14361. 2013-10-14 15:54 +0000 [r400891] Kevin Harwell <kharwell@digium.com>
  14362. * /, res/res_pjsip_outbound_registration.c: pjsip outbound
  14363. registration: Log message says received a 408 when we didn't If
  14364. the server didn't exist that we are trying to register to the log
  14365. message would say that a 408 was received from that server when
  14366. in reality one wasn't. Added log messages stating no response was
  14367. received if the response does not exist. (closes issue
  14368. ASTERISK-22554) Reported by: Rusty Newton Review:
  14369. https://reviewboard.asterisk.org/r/2893/ ........ Merged
  14370. revisions 400890 from
  14371. http://svn.asterisk.org/svn/asterisk/branches/12
  14372. 2013-10-14 15:01 +0000 [r400882] Matthew Jordan <mjordan@digium.com>
  14373. * res/res_pjsip_mwi.c, /: Remove duplicate module info block The
  14374. module info block was repeated twice. Once is sufficient.
  14375. ........ Merged revisions 400881 from
  14376. http://svn.asterisk.org/svn/asterisk/branches/12
  14377. 2013-10-13 15:42 +0000 [r400873] Joshua Colp <jcolp@digium.com>
  14378. * res/res_pjsip_session.c, /: Fix a race condition in
  14379. res_pjsip_session with rapidly terminating the session. The
  14380. INVITE session state callback wrongly assumes that a session will
  14381. always exist, but when rapidly terminating the session this
  14382. assumption goes out the window. As all handler code for the
  14383. INVITE session state callback requires the session it will now
  14384. just exit immediately if no session exists. (closes issue
  14385. ASTERISK-22668) Reported by: John Bigelow ........ Merged
  14386. revisions 400872 from
  14387. http://svn.asterisk.org/svn/asterisk/branches/12
  14388. 2013-10-12 16:53 +0000 [r400864] Kinsey Moore <kmoore@digium.com>
  14389. * /, res/res_pjsip_outbound_authenticator_digest.c: Fix realm
  14390. comparison for outbound auth When generating the list of
  14391. authentication credentials to pass to PJSIP, Asterisk was using
  14392. the raw pointer of a pj_str_t which is not always
  14393. NULL-terminated. This sometimes resulted in incorrect text for
  14394. the realm and a failure to match the realm for authentication
  14395. purposes which was causing the outbound nominal auth pjsip basic
  14396. call test to bounce. This now uses the pj_str_t that contains the
  14397. realm instead of generating a new one. Thanks to John Bigelow for
  14398. helping to narrow this down. ........ Merged revisions 400863
  14399. from http://svn.asterisk.org/svn/asterisk/branches/12
  14400. 2013-10-11 17:05 +0000 [r400855] Richard Mudgett <rmudgett@digium.com>
  14401. * include/asterisk/channel.h, /: channel.h: whitespace changes.
  14402. ........ Merged revisions 400854 from
  14403. http://svn.asterisk.org/svn/asterisk/branches/12
  14404. 2013-10-11 16:36 +0000 [r400851-400852] David M. Lee <dlee@digium.com>
  14405. * /, res/ari/resource_bridges.h, rest-api/api-docs/playback.json,
  14406. rest-api-templates/api.wiki.mustache, res/res_ari_playback.c,
  14407. rest-api/api-docs/channels.json, res/ari/resource_playback.h,
  14408. rest-api/api-docs/bridges.json,
  14409. rest-api-templates/asterisk_processor.py,
  14410. res/ari/resource_channels.h,
  14411. rest-api-templates/models.wiki.mustache: Multiple revisions
  14412. 400508,400842-400843,400848 ........ r400508 | dlee | 2013-10-03
  14413. 23:54:51 -0500 (Thu, 03 Oct 2013) | 1 line Corrected response
  14414. class for stopPlayback ........ r400842 | dlee | 2013-10-10
  14415. 14:23:24 -0500 (Thu, 10 Oct 2013) | 1 line Correct some ARI wiki
  14416. rendering errors ........ r400843 | dlee | 2013-10-10 14:26:19
  14417. -0500 (Thu, 10 Oct 2013) | 1 line Updated /play resource docs.
  14418. The playback of http: resources isn't implemented... yet ........
  14419. r400848 | dlee | 2013-10-11 11:18:46 -0500 (Fri, 11 Oct 2013) | 5
  14420. lines Fix a stupid copy/paste error in ARI docs. Patches:
  14421. ari-doc-patch.txt uploaded by jbigelow (license 5091) ........
  14422. Merged revisions 400508,400842-400843,400848 from
  14423. http://svn.asterisk.org/svn/asterisk/branches/12
  14424. * /: Fixed merge tracking for r400360, which was somehow lost
  14425. 2013-10-11 16:28 +0000 [r400850] Richard Mudgett <rmudgett@digium.com>
  14426. * bridges/bridge_softmix.c, /: Softmix: Fix crash when switching
  14427. from softmix to another bridge technology. The crash is caused by
  14428. a race condition when switching between native RTP and softmix
  14429. bridging technologies. In this situation, the bridging technology
  14430. is switched from native RTP to softmix, and then back to native
  14431. RTP fast enough that the softmix private data gets destroyed
  14432. before the softmix mixing thread gets started. Thanks to Kinsey
  14433. Moore for the crash analysis. * Fix race condition when starting
  14434. the softmix mixing thread and switching to another bridge
  14435. technology. (closes issue ASTERISK-22678) Reported by: John
  14436. Bigelow Patches: jira_asterisk_22678_v12.patch (license #5621)
  14437. patch uploaded by rmudgett Tested by: John Bigelow ........
  14438. Merged revisions 400849 from
  14439. http://svn.asterisk.org/svn/asterisk/branches/12
  14440. 2013-10-10 18:21 +0000 [r400825-400834] Joshua Colp <jcolp@digium.com>
  14441. * /, res/res_pjsip/location.c: Perform validation of permanent
  14442. contacts on AORs in res_pjsip. ........ Merged revisions 400833
  14443. from http://svn.asterisk.org/svn/asterisk/branches/12
  14444. * /, res/res_pjsip/pjsip_configuration.c, res/res_pjsip.c: Fix an
  14445. assertion in res_pjsip when specifying an invalid outbound proxy.
  14446. This change fixes two issues when setting an outbound proxy: 1.
  14447. The outbound proxy URI was not parsed and validated during
  14448. configuration. 2. If an outgoing dialog was created and the
  14449. outbound proxy could not be set an assertion would occur because
  14450. the usage count on the dialog was not decremented. The
  14451. documentation has also been updated to specify that a full URI
  14452. must be specified for the outbound proxy. (closes issue
  14453. ASTERISK-22672) Reported by: Antti Yrjola ........ Merged
  14454. revisions 400824 from
  14455. http://svn.asterisk.org/svn/asterisk/branches/12
  14456. 2013-10-09 11:02 +0000 [r400772-400813] Matthew Jordan <mjordan@digium.com>
  14457. * res/res_pjsip_header_funcs.c, /: Use 'z' as the format specifier
  14458. for size_t Using 'lu' will produce a compiler warning for some
  14459. versions of gcc and on some architectures. 'z' should be portable
  14460. as a format specifier for size_t. ........ Merged revisions
  14461. 400812 from http://svn.asterisk.org/svn/asterisk/branches/12
  14462. * res/res_pjsip_header_funcs.c (added), /: Add PJSIP_HEADER
  14463. function for manipulation of SIP headers in the PJSIP stack This
  14464. patch adds support to the PJSIP stack in Asterisk for SIP header
  14465. manipulation. Note that this is analagous to
  14466. SIPAddHeader/SIPRemoveHeader. For PJSIP_HEADER, an incoming
  14467. supplemental session callback is registered that takes the
  14468. pjsip_hdrs from the incoming session and stores them in a linked
  14469. list in the session datastore. Calls to PJSIP_HEADER traverse
  14470. over the list and return the nth matching header where 'n' is the
  14471. 'number' argument to the function. When adding a header, the
  14472. first call creates a datastore and linked list and adds the
  14473. datastore to the session. The header is then created as a
  14474. pjsip_hdr and added to the list. An outgoing supplemental session
  14475. callback then traverses the list and adds the headers to the
  14476. outgoing pjsip_msg. When removing a header, the list created with
  14477. PJSIP_HEADER(add,...) is traversed and all matching entries are
  14478. removed. (closes issue ASTERISK-22498) Reported by: George Joseph
  14479. patch: res_pjsip_header_funcs_v1.patch uploaded by george.joseph
  14480. (License 6322) ........ Merged revisions 400771 from
  14481. http://svn.asterisk.org/svn/asterisk/branches/12
  14482. 2013-10-08 22:33 +0000 [r400770] Kinsey Moore <kmoore@digium.com>
  14483. * /, configure, configure.ac: Add warning when compiling with iODBC
  14484. support When running configure, libiodbc2 development headers
  14485. will fulfill the requirement for ODBC development headers, but
  14486. will not function properly. This adds a warning when libiodbc2
  14487. development headers are detected instead of unixodbc development
  14488. headers. (closes issue ASTERISK-22459) Reported by: Patrick
  14489. Maille Tested by: Walter Doekes Patches:
  14490. issueA22459_warn_when_using_iodbc.patch uploaded by Walter Doekes
  14491. (License 5674) ........ Merged revisions 400767 from
  14492. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14493. revisions 400768 from
  14494. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14495. revisions 400769 from
  14496. http://svn.asterisk.org/svn/asterisk/branches/12
  14497. 2013-10-08 21:20 +0000 [r400759] Richard Mudgett <rmudgett@digium.com>
  14498. * apps/app_agent_pool.c, /: app_agent_pool: Fix AMI/CLI AgentLogoff
  14499. soft preventing agents from logging back in. * Clear the
  14500. deferred_logoff flag when an agent logs in. (closes issue
  14501. ASTERISK-22669) Reported by: John Bigelow ........ Merged
  14502. revisions 400754 from
  14503. http://svn.asterisk.org/svn/asterisk/branches/12
  14504. 2013-10-08 20:52 +0000 [r400750] Mark Michelson <mmichelson@digium.com>
  14505. * /, res/res_pjsip.c, res/res_pjsip/config_transport.c: Switch from
  14506. using pjsip_strerror to pj_strerror. pjsip_strerror is only aware
  14507. of PJSIP-specific error codes. pj_strerror() is aware of all
  14508. PJProject error codes and OS-specific error codes. This
  14509. specifically fixes an oft-seen error in transport configuration
  14510. code where EADDRINUSE would result in "Unknown PJSIP error
  14511. 120098" instead of a useful message. ........ Merged revisions
  14512. 400749 from http://svn.asterisk.org/svn/asterisk/branches/12
  14513. 2013-10-08 20:18 +0000 [r400728-400744] Richard Mudgett <rmudgett@digium.com>
  14514. * configs/confbridge.conf.sample, /,
  14515. apps/confbridge/include/confbridge.h, apps/app_confbridge.c,
  14516. CHANGES, apps/confbridge/conf_config_parser.c: app_confbridge:
  14517. Can now set the language used for announcements to the
  14518. conference. ConfBridge now has the ability to set the language of
  14519. announcements to the conference. The language can be set on a
  14520. bridge profile in confbridge.conf or by the dialplan function
  14521. CONFBRIDGE(bridge,language)=en. (closes issue ASTERISK-19983)
  14522. Reported by: Jonathan White Patches: M19983_rev2.diff (license
  14523. #5138) patch uploaded by junky (modified) Tested by: rmudgett
  14524. ........ Merged revisions 400741 from
  14525. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14526. revisions 400742 from
  14527. http://svn.asterisk.org/svn/asterisk/branches/12
  14528. * apps/confbridge/conf_config_parser.c, /: app_confbridge: Fix
  14529. duplicate default_user profile. * Fixed looking in the wrong
  14530. profiles container to see if the default_user profile is already
  14531. created in verify_default_profiles(). The bridge profile
  14532. container is never going to hold user profiles. :) ........
  14533. Merged revisions 400723 from
  14534. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14535. revisions 400724 from
  14536. http://svn.asterisk.org/svn/asterisk/branches/12
  14537. 2013-10-08 18:19 +0000 [r400684-400704] Kinsey Moore <kmoore@digium.com>
  14538. * funcs/func_config.c, /: Fix func_config list entry allocation The
  14539. AST_CONFIG dialplan function defined in func_config.c allocates
  14540. its config file list entries using ast_malloc. List entry
  14541. allocations destined for use with Asterisk's linked list API must
  14542. be ast_calloc()d or otherwise initialized so that list pointers
  14543. are set to NULL. These uses of ast_malloc have been replaced by
  14544. ast_calloc to prevent dereferencing of uninitialized pointer
  14545. values when traversing the list. (closes issue ASTERISK-22483)
  14546. Reported by: Brian Scott ........ Merged revisions 400694 from
  14547. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14548. revisions 400697 from
  14549. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14550. revisions 400701 from
  14551. http://svn.asterisk.org/svn/asterisk/branches/12
  14552. * res/res_rtp_asterisk.c, /: Fix STUN crash when using IPv6 any
  14553. address Ensure that when chan_sip binds to the IPv6 any address
  14554. ([::]), IPv4 candidates are also added. (closes issue
  14555. ASTERISK-21917) Reported by: Torrey Searle Patches:
  14556. 0023_ipv6_stun_crash.patch uploaded by Torrey Searle (License
  14557. 5334) ........ Merged revisions 400681 from
  14558. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14559. revisions 400682 from
  14560. http://svn.asterisk.org/svn/asterisk/branches/12
  14561. 2013-10-08 15:44 +0000 [r400683] Mark Michelson <mmichelson@digium.com>
  14562. * res/res_pjsip/pjsip_options.c, /: Push CLI qualify into the
  14563. threadpool. If you run Asterisk in the background and then
  14564. connect to it through a separate console, the thread that runs
  14565. CLI commands is not registered with PJLIB. Thus PJLIB does not
  14566. like it when you attempt to send OPTIONS requests from that
  14567. thread. So now we push the task into the threadpool, which we
  14568. know to be registered with PJLIB. Thanks to Antti Yrjola for
  14569. reporting this. ........ Merged revisions 400680 from
  14570. http://svn.asterisk.org/svn/asterisk/branches/12
  14571. 2013-10-08 15:12 +0000 [r400662-400672] Richard Mudgett <rmudgett@digium.com>
  14572. * /, res/res_agi.c, apps/app_queue.c: Make app_queue and res_agi
  14573. independent of AMI being enabled. The
  14574. https://reviewboard.asterisk.org/r/2888/ review changes manager
  14575. to not subscribe to stasis when it is disabled for performance
  14576. reasons. When manager is disabled app_queue and res_agi decline
  14577. to load and fail to clean up what they have already allocated. *
  14578. Made app_queue and res_agi clean up allocated resources when they
  14579. decline to load. * Made app_queue and res_agi use their own
  14580. subscriptions to the stasis topics instead of borrowing manager's
  14581. message router structure inappropriately. (closes issue
  14582. ASTERISK-22604) Reported by: rmudgett Review:
  14583. https://reviewboard.asterisk.org/r/2902/ ........ Merged
  14584. revisions 400671 from
  14585. http://svn.asterisk.org/svn/asterisk/branches/12
  14586. * /, include/asterisk/stasis.h, apps/app_queue.c,
  14587. include/asterisk/manager.h: Miscellaneous stand alone comment
  14588. cleanups. ........ Merged revisions 400661 from
  14589. http://svn.asterisk.org/svn/asterisk/branches/12
  14590. 2013-10-06 17:13 +0000 [r400625] Michael L. Young <elgueromexicano@gmail.com>
  14591. * /, apps/app_queue.c: app_queue: Fix Queuelog EXITWITHKEY only
  14592. logging two of four fields Commit r62462 added two extra fields
  14593. for logging "the original position the caller entered the queue
  14594. at, and the amount of time the caller was waiting in the queue."
  14595. But when r75969 was merged from 1.4 into trunk (r75977), these
  14596. two fields disappeared. Those two extra fields were not logged in
  14597. 1.4 and when the patch was merged, those fields went away.
  14598. Therefore, this is a regression and was caught by the reporter
  14599. because he was reading the awesome "Asterisk: The Definitive
  14600. Guide" book. (closes issue ASTERISK-22197) Reported by: Dalius M.
  14601. Tested by: Dalius M. Patches:
  14602. asterisk-22197-q-log-exitwithkey.diff uploaded by Michael L.
  14603. Young (license 5026) Review:
  14604. https://reviewboard.asterisk.org/r/2901/ ........ Merged
  14605. revisions 400622 from
  14606. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14607. revisions 400623 from
  14608. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14609. revisions 400624 from
  14610. http://svn.asterisk.org/svn/asterisk/branches/12
  14611. 2013-10-05 00:59 +0000 [r400593] Richard Mudgett <rmudgett@digium.com>
  14612. * /, channels/iax2/include/parser.h: chan_iax2: Fix compile error.
  14613. ........ Merged revisions 400588 from
  14614. http://svn.asterisk.org/svn/asterisk/branches/12
  14615. 2013-10-04 21:41 +0000 [r400568] Michael L. Young <elgueromexicano@gmail.com>
  14616. * main/acl.c, include/asterisk/netsock2.h, CHANGES,
  14617. channels/chan_iax2.c, channels/iax2/parser.c, main/netsock.c,
  14618. main/netsock2.c, /, channels/iax2/include/parser.h: Add IPv6
  14619. Support To chan_iax2 This patch adds IPv6 support to chan_iax2.
  14620. Yay! (closes issue ASTERISK-22025) Patches:
  14621. iax2-ipv6-v5-reviewboard.diff by Michael L. Young (license 5026)
  14622. Review: https://reviewboard.asterisk.org/r/2660/ ........ Merged
  14623. revisions 400567 from
  14624. http://svn.asterisk.org/svn/asterisk/branches/12
  14625. 2013-10-04 19:32 +0000 [r400553] David M. Lee <dlee@digium.com>
  14626. * rest-api/api-docs/applications.json (added), /: Added missing
  14627. file from r400522 ........ Merged revisions 400552 from
  14628. http://svn.asterisk.org/svn/asterisk/branches/12
  14629. 2013-10-04 19:11 +0000 [r400533-400543] Jonathan Rose <jrose@digium.com>
  14630. * res/res_pjsip_logger.c, /: chan_pjsip: Make logger togglable
  14631. without loading/unloading This patch makes the res_pjsip_logger
  14632. do a few things... First, it will be built and installed by
  14633. default now, so end users won't need to enable it in menuselect.
  14634. Second, while it is loaded, it no longer will immediately issue
  14635. log messages. Upon loading, it is in the disabled state and must
  14636. be turned on with the new CLI command. The CLI command 'pjsip set
  14637. logger <on/off/host> has been added and can be used to do the
  14638. following: pjsip set logger on: Enables logger for all PJSIP
  14639. traffic pjsip set logger off: Disables logger for all PJSIP
  14640. traffic pjsip set logger host <host>: Enables logger for the
  14641. specific host Review: https://reviewboard.asterisk.org/r/2900/
  14642. ........ Merged revisions 400542 from
  14643. http://svn.asterisk.org/svn/asterisk/branches/12
  14644. * /,
  14645. contrib/ast-db-manage/config/versions/43956d550a44_add_tables_for_pjsip.py
  14646. (added), configs/extconfig.conf.sample,
  14647. configs/sorcery.conf.sample,
  14648. contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:
  14649. chan_pjsip: Add alembic scripts for generating db tables for
  14650. PJSIP Also updates sample configurations for sorcery and
  14651. extconfig to demonstrate how to use databases created by that
  14652. alembic script. (closes issue ASTERISK-22133) Reported by: Matt
  14653. Jordan Review: https://reviewboard.asterisk.org/r/2892/ ........
  14654. Merged revisions 400532 from
  14655. http://svn.asterisk.org/svn/asterisk/branches/12
  14656. 2013-10-04 16:01 +0000 [r400523] Matthew Jordan <mjordan@digium.com>
  14657. * res/res_stasis.c, main/asterisk.c,
  14658. rest-api/api-docs/endpoints.json, rest-api/api-docs/events.json,
  14659. res/stasis/app.c, /,
  14660. rest-api-templates/ari_model_validators.h.mustache,
  14661. include/asterisk/endpoints.h, res/res_ari_applications.c (added),
  14662. res/ari/resource_endpoints.h, include/asterisk/stasis_app.h,
  14663. res/stasis/app.h, rest-api/resources.json,
  14664. include/asterisk/_private.h, res/ari/ari_model_validators.c,
  14665. main/endpoints.c, res/ari/ari_model_validators.h, main/json.c,
  14666. res/res_ari_model.c, res/ari.make,
  14667. res/ari/resource_applications.c (added),
  14668. res/ari/resource_applications.h (added): ARI: Add subscription
  14669. support This patch adds an /applications API to ARI, allowing
  14670. explicit management of Stasis applications. * GET /applications -
  14671. list current applications * GET /applications/{applicationName} -
  14672. get details of a specific application * POST
  14673. /applications/{applicationName}/subscription - explicitly
  14674. subscribe to a channel, bridge or endpoint * DELETE
  14675. /applications/{applicationName}/subscription - explicitly
  14676. unsubscribe from a channel, bridge or endpoint Subscriptions work
  14677. by a reference counting mechanism: if you subscript to an event
  14678. source X number of times, you must unsubscribe X number of times
  14679. to stop receiveing events for that event source. Review:
  14680. https://reviewboard.asterisk.org/r/2862 (issue ASTERISK-22451)
  14681. Reported by: Matt Jordan ........ Merged revisions 400522 from
  14682. http://svn.asterisk.org/svn/asterisk/branches/12
  14683. 2013-10-04 15:49 +0000 [r400511-400521] Joshua Colp <jcolp@digium.com>
  14684. * /, res/res_pjsip.c: Enclose the To URI and update its user
  14685. portion if a request user has been specified. ........ Merged
  14686. revisions 400520 from
  14687. http://svn.asterisk.org/svn/asterisk/branches/12
  14688. * res/res_pjsip_session.c, /: Replace the connection address at the
  14689. SDP level if altering the SDP with the external media address.
  14690. ........ Merged revisions 400510 from
  14691. http://svn.asterisk.org/svn/asterisk/branches/12
  14692. 2013-10-03 23:20 +0000 [r400482] Jonathan Rose <jrose@digium.com>
  14693. * /, channels/chan_sip.c: chan_sip: Don't ignore expires value in
  14694. contact header if it lacks semicolon (closes issue
  14695. ASTERISK-22574) Reported by: Filip Jenicek Patches:
  14696. chan_sip_expires.patch uploaded by Filip Jenicek (license 6277)
  14697. ........ Merged revisions 400469 from
  14698. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14699. revisions 400470 from
  14700. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14701. revisions 400471 from
  14702. http://svn.asterisk.org/svn/asterisk/branches/12
  14703. 2013-10-03 21:46 +0000 [r400461] Matthew Jordan <mjordan@digium.com>
  14704. * /, main/channel_internal_api.c: Remove publication of a channel
  14705. snapshot when the technology is set This patch removes said
  14706. publication for a few reasons: (1) It is unnecessary. Association
  14707. of the channel technology with a specific channel is an
  14708. implementation detail that should be assumed to "just happen",
  14709. and consumers of Stasis don't need to be informed about it. (2)
  14710. Publication of said message can now cause crashes, as the actual
  14711. creation of a channel in normal locations now stages its
  14712. messages. As a result, things that create dummy channels (such as
  14713. the SIP RTP QOS unit test) and associate them with a channel
  14714. technology were now crashing, as the channel itself was not known
  14715. by Stasis. ........ Merged revisions 400460 from
  14716. http://svn.asterisk.org/svn/asterisk/branches/12
  14717. 2013-10-03 20:22 +0000 [r400452] Mark Michelson <mmichelson@digium.com>
  14718. * bridges/bridge_native_rtp.c, /,
  14719. include/asterisk/bridge_technology.h: Fix assumption in
  14720. bridge_native_rtp.c regarding number of participants in a bridge.
  14721. When a party leaves a bridge, there may be more participants in
  14722. the bridge than expected. As such, it is important not to make
  14723. assumptions regarding the list of channels in a bridge. This
  14724. change makes it so that when a party leaves a native RTP bridge,
  14725. we unbridge it and the party it was bridged with. Previously, the
  14726. first and last channels in the list were unbridged since it was
  14727. assumed that these were the two channels that had been bridged.
  14728. As previously stated, a new party had been inserted into the
  14729. bridge, so this logic did not work properly. (closes issue
  14730. ASTERISK-22615) reported by Matt Jordan Review:
  14731. https://reviewboard.asterisk.org/r/2899 ........ Merged revisions
  14732. 400403 from http://svn.asterisk.org/svn/asterisk/branches/12
  14733. 2013-10-03 19:32 +0000 [r400443] Joshua Colp <jcolp@digium.com>
  14734. * /, main/cdr.c: When serializing CDR variables (like for "core
  14735. show channels") don't output an error if CDRs aren't enabled.
  14736. ........ Merged revisions 400442 from
  14737. http://svn.asterisk.org/svn/asterisk/branches/12
  14738. 2013-10-03 19:30 +0000 [r400441] Kinsey Moore <kmoore@digium.com>
  14739. * /, main/security_events.c: Fix security events for AMI invalid
  14740. password In r337595, additional security events were added for
  14741. chan_sip authentication failures. The new IEs added to the
  14742. existing invalid password event were defined as required IEs, but
  14743. existing users of the event did not set the new IEs and could not
  14744. since they didn't apply to existing uses. They are now marked as
  14745. optional IEs. (closes issue ASTERISK-22578) Reported by: Matt
  14746. Jordan ........ Merged revisions 400421 from
  14747. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14748. revisions 400440 from
  14749. http://svn.asterisk.org/svn/asterisk/branches/12
  14750. 2013-10-03 19:06 +0000 [r400402] Joshua Colp <jcolp@digium.com>
  14751. * res/ari/resource_channels.c, /: Fix a crash caused by muting and
  14752. unmuting a channel in ARI without specifying a direction. (closes
  14753. issue ASTERISK-22637) Reported by: Scott Griepentrog Patch by
  14754. Matt Jordan, whose office I have taken over in the name of
  14755. Canada. ........ Merged revisions 400401 from
  14756. http://svn.asterisk.org/svn/asterisk/branches/12
  14757. 2013-10-03 18:51 +0000 [r400399] Richard Mudgett <rmudgett@digium.com>
  14758. * /, main/cel.c: cel: Some whitespace cleanups ........ Merged
  14759. revisions 400398 from
  14760. http://svn.asterisk.org/svn/asterisk/branches/12
  14761. 2013-10-03 18:32 +0000 [r400385-400397] Kinsey Moore <kmoore@digium.com>
  14762. * res/res_rtp_multicast.c, /: res_rtp_multicast: Ensure SSRC is set
  14763. properly This fixes a bug where the SSRC field on multicast RTP
  14764. can be stuck at 0 which can cause problems for endpoints trying
  14765. to make sense of incoming streams. (closes issue ASTERISK-22567)
  14766. Reported by: Simone Camporeale Patches:
  14767. 22567_res_mulitcast_ssrc.patch uploaded by Simone Camporeale
  14768. (License 6536) ........ Merged revisions 400393 from
  14769. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14770. revisions 400394 from
  14771. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14772. revisions 400395 from
  14773. http://svn.asterisk.org/svn/asterisk/branches/12
  14774. * /, configure, include/asterisk/autoconfig.h.in, configure.ac,
  14775. main/xml.c: Detect and use xsltCleanupGlobals when available This
  14776. introduces usage of an additional libxslt cleanup function,
  14777. xsltCleanupGlobals, when the configure script detects that it is
  14778. available. Early versions of the library did not include this
  14779. function. (closes issue ASTERISK-22570) Reported by: Corey
  14780. Farrell Patches: xsltCleanupGlobals.patch uploaded by Corey
  14781. Farrell (License 5909) ........ Merged revisions 400384 from
  14782. http://svn.asterisk.org/svn/asterisk/branches/12
  14783. 2013-10-03 16:28 +0000 [r400374] Richard Mudgett <rmudgett@digium.com>
  14784. * channels/chan_vpb.cc, /: chan_vpb: Make compile again. ........
  14785. Merged revisions 400373 from
  14786. http://svn.asterisk.org/svn/asterisk/branches/12
  14787. 2013-10-03 14:59 +0000 [r400363-400364] Mark Michelson <mmichelson@digium.com>
  14788. * tests/test_cel.c, /: Get rid of uses of stasis_topic_wait()
  14789. ........ Merged revisions 400362 from
  14790. http://svn.asterisk.org/svn/asterisk/branches/12
  14791. * pbx/pbx_spool.c, main/manager.c, main/format_cap.c,
  14792. channels/chan_skinny.c, res/res_agi.c, channels/chan_motif.c,
  14793. channels/chan_alsa.c, apps/app_confbridge.c,
  14794. addons/chan_mobile.c, channels/chan_mgcp.c,
  14795. res/res_clioriginate.c, channels/chan_bridge_media.c,
  14796. channels/chan_sip.c, tests/test_format_api.c,
  14797. res/res_pjsip_sdp_rtp.c, bridges/bridge_simple.c,
  14798. apps/app_originate.c, res/parking/parking_applications.c,
  14799. main/core_local.c, channels/chan_console.c, channels/chan_oss.c,
  14800. include/asterisk/format_cap.h, res/res_pjsip_session.c,
  14801. res/ari/resource_bridges.c, channels/chan_jingle.c,
  14802. channels/chan_misdn.c, channels/dahdi/bridge_native_dahdi.c,
  14803. res/res_pjsip/pjsip_configuration.c, main/file.c,
  14804. channels/chan_h323.c, channels/chan_nbs.c,
  14805. bridges/bridge_native_rtp.c, tests/test_config.c,
  14806. res/res_stasis.c, channels/chan_pjsip.c, channels/chan_unistim.c,
  14807. channels/chan_multicast_rtp.c, addons/chan_ooh323.c,
  14808. main/rtp_engine.c, /, main/ccss.c, apps/app_meetme.c,
  14809. bridges/bridge_holding.c, main/bridge_basic.c,
  14810. bridges/bridge_softmix.c, channels/chan_gtalk.c,
  14811. channels/chan_iax2.c, main/media_index.c, main/channel.c,
  14812. channels/chan_phone.c, channels/chan_dahdi.c, main/dial.c: Cache
  14813. string values of formats on ast_format_cap() to save processing.
  14814. Channel snapshots have string representations of the channel's
  14815. native formats. Prior to this change, the format strings were
  14816. re-created on ever channel snapshot creation. Since channel
  14817. native formats rarely change, this was very wasteful. Now, string
  14818. representations of formats may optionally be stored on the
  14819. ast_format_cap for cases where string representations may be
  14820. requested frequently. When formats are altered, the string cache
  14821. is marked as invalid. When strings are requested, the cache
  14822. validity is checked. If the cache is valid, then the cached
  14823. strings are copied. If the cache is invalid, then the string
  14824. cache is rebuilt and copied, and the cache is marked as being
  14825. valid again. Review: https://reviewboard.asterisk.org/r/2879
  14826. ........ Merged revisions 400356 from
  14827. http://svn.asterisk.org/svn/asterisk/branches/12
  14828. 2013-10-03 14:52 +0000 [r400361] Joshua Colp <jcolp@digium.com>
  14829. * res/res_pjsip_sdp_rtp.c, res/res_pjsip_t38.c, /: Fix crashes in
  14830. res_pjsip_sdp_rtp and res_pjsip_t38 when a stream is rejected and
  14831. external_media_address is set. The callback function for changing
  14832. the media address in streams wrongly assumes that a connection
  14833. line will always be present. This is false as no line is present
  14834. if a stream has been rejected. (closes issue ASTERISK-22645)
  14835. Reported by: Rusty Newton ........ Merged revisions 400360 from
  14836. http://svn.asterisk.org/svn/asterisk/branches/12
  14837. 2013-10-02 22:22 +0000 [r400335] Mark Michelson <mmichelson@digium.com>
  14838. * main/stasis_wait.c (removed), res/ari/resource_endpoints.c, /,
  14839. include/asterisk/stasis.h, tests/test_cel.c,
  14840. include/asterisk/stasis_endpoints.h, channels/chan_pjsip.c,
  14841. main/stasis.c, main/stasis_endpoints.c: Multiple revisions
  14842. 400318-400319 ........ r400318 | mmichelson | 2013-10-02 17:08:49
  14843. -0500 (Wed, 02 Oct 2013) | 12 lines Remove unnecessary waits from
  14844. stasis. Since caches are updated on publisher threads, there is
  14845. no need to wait for the cache updates to occur after a stasis
  14846. message is published. In the case of chan_pjsip device state
  14847. changes, this set of changes caused an improvement to
  14848. performance. Review: https://reviewboard.asterisk.org/r/2890
  14849. ........ r400319 | mmichelson | 2013-10-02 17:10:54 -0500 (Wed,
  14850. 02 Oct 2013) | 3 lines Remove svn:mergeinfo property. ........
  14851. Merged revisions 400318-400319 from
  14852. http://svn.asterisk.org/svn/asterisk/branches/12
  14853. 2013-10-02 21:33 +0000 [r400317] Michael L. Young <elgueromexicano@gmail.com>
  14854. * channels/chan_iax2.c, /: Cast Integer Argument To Unsigned Char
  14855. The member reg in the peercnt structure is an unsigned char and
  14856. peercnt_modify() is expecting an unsigned char argument which
  14857. gets assigned to peercnt->reg. This patch fixes that by casting
  14858. the integer argument being passed to peercnt_modify to unsigned
  14859. char. ........ Merged revisions 400314 from
  14860. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  14861. revisions 400315 from
  14862. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14863. revisions 400316 from
  14864. http://svn.asterisk.org/svn/asterisk/branches/12
  14865. 2013-10-02 21:26 +0000 [r400313] Matthew Jordan <mjordan@digium.com>
  14866. * main/cdr.c, main/manager.c, /, main/cel.c: Only create Stasis
  14867. subscriptions when enabled Subscribing to Stasis isn't free. As
  14868. such, this patch makes AMI, CDR, and CEL - the "big 3" - only
  14869. subscribe when enabled. Toggling their availability via a .conf
  14870. file will unsubscribe/subscribe as appropriate. Review:
  14871. https://reviewboard.asterisk.org/r/2888/ ........ Merged
  14872. revisions 400312 from
  14873. http://svn.asterisk.org/svn/asterisk/branches/12
  14874. 2013-10-02 20:31 +0000 [r400304] Richard Mudgett <rmudgett@digium.com>
  14875. * main/pbx.c, /: Originate: Make setting caller id on outgoing call
  14876. use either name or number. Previous code was requiring both name
  14877. and number to be available. Also restored a comment block on why
  14878. caller id is also set on an outgoing call leg in addition to
  14879. connected line from earlier versions of Asterisk. ........ Merged
  14880. revisions 400303 from
  14881. http://svn.asterisk.org/svn/asterisk/branches/12
  14882. 2013-10-02 19:20 +0000 [r400295] Kinsey Moore <kmoore@digium.com>
  14883. * /, rest-api/api-docs/asterisk.json: Correct allowable values for
  14884. ARI general information filter ........ Merged revisions 400291
  14885. from http://svn.asterisk.org/svn/asterisk/branches/12
  14886. 2013-10-02 19:17 +0000 [r400287] Matthew Jordan <mjordan@digium.com>
  14887. * main/cdr.c, /: Fix the CDR CLI command 'cdr show active
  14888. {channel}' When the switch from channel names to channel unique
  14889. IDs happened, the poor CLI command got left in the dust. This
  14890. fixes the command so that users can once again see how Asterisk
  14891. is messing up your billing information. ........ Merged revisions
  14892. 400286 from http://svn.asterisk.org/svn/asterisk/branches/12
  14893. 2013-10-02 18:44 +0000 [r400285] Joshua Colp <jcolp@digium.com>
  14894. * /, res/res_pjsip_t38.c: Fix a crash in res_pjsip_t38 caused by
  14895. the wrong assumption that a session will always have a channel.
  14896. When starting up or shutting down this assumption is false.
  14897. ........ Merged revisions 400284 from
  14898. http://svn.asterisk.org/svn/asterisk/branches/12
  14899. 2013-10-02 18:28 +0000 [r400282] Tzafrir Cohen <tzafrir.cohen@xorcom.com>
  14900. * Makefile, doc/astdb2sqlite3.8 (added), /, doc/astdb2bdb.8
  14901. (added): man pages for astdb2bdb and astdb2sqlite3 Review:
  14902. https://reviewboard.asterisk.org/r/2898/ ........ Merged
  14903. revisions 400279 from
  14904. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  14905. revisions 400281 from
  14906. http://svn.asterisk.org/svn/asterisk/branches/12
  14907. 2013-10-02 17:12 +0000 [r400269-400271] Richard Mudgett <rmudgett@digium.com>
  14908. * apps/app_stack.c, res/stasis_recording/stored.c, main/json.c,
  14909. main/stasis_cache.c, res/res_ari.c, /, main/utils.c:
  14910. MALLOC_DEBUG: Fix some misuses of free() when MALLOC_DEBUG is
  14911. enabled. * There were several places in ARI where an external
  14912. library was mallocing memory that must always be released with
  14913. free(). When MALLOC_DEBUG is enabled, free() is redirected to the
  14914. MALLOC_DEBUG version. Since the external library call still uses
  14915. the normal malloc(), MALLOC_DEBUG complains that the freed memory
  14916. block is not registered and will not free it. These cases must
  14917. use ast_std_free(). * Changed calls to asprintf() and vasprintf()
  14918. to the equivalent ast_asprintf() and ast_vasprintf() versions
  14919. respectively. ........ Merged revisions 400270 from
  14920. http://svn.asterisk.org/svn/asterisk/branches/12
  14921. * channels/sig_ss7.c, /: sig_ss7: Fix compiler warnings. ........
  14922. Merged revisions 400268 from
  14923. http://svn.asterisk.org/svn/asterisk/branches/12
  14924. 2013-10-02 16:23 +0000 [r400246-400266] Joshua Colp <jcolp@digium.com>
  14925. * channels/chan_alsa.c, main/stasis_channels.c, channels/sig_ss7.c,
  14926. channels/chan_pjsip.c, channels/chan_mgcp.c,
  14927. channels/chan_unistim.c, apps/app_dial.c, main/pbx.c, /,
  14928. channels/chan_sip.c, main/bridge.c, include/asterisk/channel.h,
  14929. channels/chan_gtalk.c, channels/chan_console.c,
  14930. channels/sig_pri.c, channels/chan_iax2.c, channels/chan_jingle.c,
  14931. main/channel.c, channels/chan_dahdi.c, main/dial.c,
  14932. include/asterisk/stasis_channels.h, channels/chan_skinny.c,
  14933. channels/chan_motif.c: Reduce channel snapshot creation and
  14934. publishing by up to 50%. This change introduces the ability to
  14935. stage channel snapshot creation and publishing by suppressing the
  14936. implicit creation and publishing that some functions have. Once
  14937. all operations are executed the staging is marked as done and a
  14938. single snapshot is created and published. Review:
  14939. https://reviewboard.asterisk.org/r/2889/ ........ Merged
  14940. revisions 400265 from
  14941. http://svn.asterisk.org/svn/asterisk/branches/12
  14942. * res/res_pjsip_session.c, /: Fix a random one way audio issue in
  14943. PJSIP. Due to the asynchronous design of the PJMEDIA SDP
  14944. negotiator it was possible for the SDP to be negotiated *after* a
  14945. channel was created and after it was being wait on by an
  14946. application. It is only after negotiation occurs that the file
  14947. descriptors for RTP are placed on the channel. Since the channel
  14948. was already being waited on these file descriptors were not
  14949. monitored, causing incoming media to never be read. This change
  14950. wakes up any application waiting on the channel so that added
  14951. file descriptors end up being monitored. (closes issue AST-1227)
  14952. Reported by: John Bigelow ........ Merged revisions 400256 from
  14953. http://svn.asterisk.org/svn/asterisk/branches/12
  14954. * /, res/stasis/control.c, include/asterisk/stasis_app.h,
  14955. res/ari/resource_channels.c: Allow specifying a channel to dial
  14956. an extension and context in an ARI dial operation. (issue
  14957. ASTERISK-22625) Reported by: Scott Griepentrog ........ Merged
  14958. revisions 400254 from
  14959. http://svn.asterisk.org/svn/asterisk/branches/12
  14960. * /, res/res_pjsip_session.c: Retrieve and store the hostname only
  14961. once so multiple threads do not potentially initialize it at the
  14962. same time. ........ Merged revisions 400245 from
  14963. http://svn.asterisk.org/svn/asterisk/branches/12
  14964. 2013-10-01 21:19 +0000 [r400228-400237] Richard Mudgett <rmudgett@digium.com>
  14965. * channels/chan_dahdi.c, channels/sig_analog.c, /: chan_dahdi: Fix
  14966. analog parking using flash-hook. Transferring an analog call
  14967. using a flash-hook to parking would fail to park the call and
  14968. result in an invalid ao2 object unref. * Park the correct bridged
  14969. channel. ........ Merged revisions 400236 from
  14970. http://svn.asterisk.org/svn/asterisk/branches/12
  14971. * main/features_config.c, /: Features: Rearm the parking config
  14972. options have moved warning for each reload. ........ Merged
  14973. revisions 400227 from
  14974. http://svn.asterisk.org/svn/asterisk/branches/12
  14975. 2013-10-01 15:54 +0000 [r400218] Matthew Jordan <mjordan@digium.com>
  14976. * main/cdr.c, /: Filter out internal channels for bridge leave
  14977. messages and parked call messages Granted, if you manage to park
  14978. a Conference announcer channel, something has gone horrifically
  14979. wrong. ........ Merged revisions 400217 from
  14980. http://svn.asterisk.org/svn/asterisk/branches/12
  14981. 2013-09-30 21:40 +0000 [r400206] Jonathan Rose <jrose@digium.com>
  14982. * configs/features.conf.sample, /, configs/res_parking.conf.sample:
  14983. configuration samples: Pull all parking related stuff out of
  14984. features.conf This patch also adds documentation for parking from
  14985. features.conf to res_parking.conf ........ Merged revisions
  14986. 400205 from http://svn.asterisk.org/svn/asterisk/branches/12
  14987. 2013-09-30 19:58 +0000 [r400195-400197] Matthew Jordan <mjordan@digium.com>
  14988. * /, funcs/func_cdr.c: Parse arguments passed to the CDR_PROP
  14989. function correctly I can only blame this on a bad merge, because
  14990. this in no way worked properly the way it was written. Mea culpa.
  14991. The function should now parse its arguments correctly and
  14992. function properly. (Note that the API used by the CDR_PROP
  14993. function has working unit tests... this was merely bad coding of
  14994. the actual registered function) (closes issue ASTERISK-22613)
  14995. Reported by: Private Name ........ Merged revisions 400196 from
  14996. http://svn.asterisk.org/svn/asterisk/branches/12
  14997. * main/cdr.c, /: Remove spurious event raised when CDRs are
  14998. reloaded The Reload event is now raised by the module loading
  14999. core. As such, the Reload event in the CDR engine was a duplicate
  15000. and not needed. ........ Merged revisions 400194 from
  15001. http://svn.asterisk.org/svn/asterisk/branches/12
  15002. 2013-09-30 18:55 +0000 [r400186] David M. Lee <dlee@digium.com>
  15003. * tests/test_devicestate.c, include/asterisk/sem.h (added),
  15004. tests/test_taskprocessor.c, res/res_pjsip_mwi.c,
  15005. res/res_pjsip/include/res_pjsip_private.h, tests/test_stasis.c,
  15006. res/parking/parking_manager.c, res/res_security_log.c,
  15007. channels/chan_mgcp.c, main/stasis_cache_pattern.c, main/pbx.c,
  15008. include/asterisk/vector.h (added), /, main/ccss.c,
  15009. apps/app_meetme.c, include/asterisk/taskprocessor.h,
  15010. configs/stasis.conf.sample (removed), configure.ac,
  15011. res/parking/parking_applications.c, channels/sig_pri.c,
  15012. apps/app_queue.c, main/cel.c, main/stasis.c,
  15013. channels/chan_dahdi.c, funcs/func_presencestate.c,
  15014. main/stasis_message_router.c, configure,
  15015. apps/confbridge/confbridge_manager.c, res/res_agi.c,
  15016. main/manager_system.c, res/res_stasis_test.c, main/sem.c (added),
  15017. main/manager_channels.c, res/res_pjsip_refer.c,
  15018. main/manager_mwi.c, apps/app_voicemail.c, main/stasis_cache.c,
  15019. main/stasis_wait.c, main/stasis_config.c (removed),
  15020. include/asterisk/stasis_internal.h, res/stasis/app.c,
  15021. channels/chan_sip.c, include/asterisk/autoconfig.h.in,
  15022. main/manager_endpoints.c, main/channel_internal_api.c,
  15023. include/asterisk/stasis.h, main/devicestate.c,
  15024. main/taskprocessor.c, res/res_xmpp.c, main/sounds_index.c,
  15025. include/asterisk/stasis_message_router.h, channels/chan_iax2.c,
  15026. res/res_jabber.c, main/endpoints.c, main/astobj2.c,
  15027. res/res_chan_stats.c, res/parking/parking_bridge_features.c,
  15028. tests/test_stasis_endpoints.c, main/cdr.c, main/channel.c,
  15029. main/manager_bridges.c, main/manager.c, channels/chan_skinny.c:
  15030. Multiple revisions 399887,400138,400178,400180-400181 ........
  15031. r399887 | dlee | 2013-09-26 10:41:47 -0500 (Thu, 26 Sep 2013) | 1
  15032. line Minor performance bump by not allocate manager variable
  15033. struct if we don't need it ........ r400138 | dlee | 2013-09-30
  15034. 10:24:00 -0500 (Mon, 30 Sep 2013) | 23 lines Stasis performance
  15035. improvements This patch addresses several performance problems
  15036. that were found in the initial performance testing of Asterisk
  15037. 12. The Stasis dispatch object was allocated as an AO2 object,
  15038. even though it has a very confined lifecycle. This was replaced
  15039. with a straight ast_malloc(). The Stasis message router was
  15040. spending an inordinate amount of time searching hash tables. In
  15041. this case, most of our routers had 6 or fewer routes in them to
  15042. begin with. This was replaced with an array that's searched
  15043. linearly for the route. We more heavily rely on AO2 objects in
  15044. Asterisk 12, and the memset() in ao2_ref() actually became
  15045. noticeable on the profile. This was #ifdef'ed to only run when
  15046. AO2_DEBUG was enabled. After being misled by an erroneous comment
  15047. in taskprocessor.c during profiling, the wrong comment was
  15048. removed. Review: https://reviewboard.asterisk.org/r/2873/
  15049. ........ r400178 | dlee | 2013-09-30 13:26:27 -0500 (Mon, 30 Sep
  15050. 2013) | 24 lines Taskprocessor optimization; switch Stasis to use
  15051. taskprocessors This patch optimizes taskprocessor to use a
  15052. semaphore for signaling, which the OS can do a better job at
  15053. managing contention and waiting that we can with a mutex and
  15054. condition. The taskprocessor execution was also slightly
  15055. optimized to reduce the number of locks taken. The only
  15056. observable difference in the taskprocessor implementation is that
  15057. when the final reference to the taskprocessor goes away, it will
  15058. execute all tasks to completion instead of discarding the
  15059. unexecuted tasks. For systems where unnamed semaphores are not
  15060. supported, a really simple semaphore implementation is provided.
  15061. (Which gives identical performance as the original taskprocessor
  15062. implementation). The way we ended up implementing Stasis caused
  15063. the threadpool to be a burden instead of a boost to performance.
  15064. This was switched to just use taskprocessors directly for
  15065. subscriptions. Review: https://reviewboard.asterisk.org/r/2881/
  15066. ........ r400180 | dlee | 2013-09-30 13:39:34 -0500 (Mon, 30 Sep
  15067. 2013) | 28 lines Optimize how Stasis forwards are dispatched This
  15068. patch optimizes how forwards are dispatched in Stasis.
  15069. Originally, forwards were dispatched as subscriptions that are
  15070. invoked on the publishing thread. This did not account for the
  15071. vast number of forwards we would end up having in the system, and
  15072. the amount of work it would take to walk though the forward
  15073. subscriptions. This patch modifies Stasis so that rather than
  15074. walking the tree of forwards on every dispatch, when forwards and
  15075. subscriptions are changed, the subscriber list for every topic in
  15076. the tree is changed. This has a couple of benefits. First, this
  15077. reduces the workload of dispatching messages. It also reduces
  15078. contention when dispatching to different topics that happen to
  15079. forward to the same aggregation topic (as happens with all of the
  15080. channel, bridge and endpoint topics). Since forwards are no
  15081. longer subscriptions, the bulk of this patch is simply changing
  15082. stasis_subscription objects to stasis_forward objects (which,
  15083. admittedly, I should have done in the first place.) Since this
  15084. required me to yet again put in a growing array, I finally
  15085. abstracted that out into a set of ast_vector macros in
  15086. asterisk/vector.h. Review:
  15087. https://reviewboard.asterisk.org/r/2883/ ........ r400181 | dlee
  15088. | 2013-09-30 13:48:57 -0500 (Mon, 30 Sep 2013) | 28 lines Remove
  15089. dispatch object allocation from Stasis publishing While looking
  15090. for areas for performance improvement, I realized that an unused
  15091. feature in Stasis was negatively impacting performance. When a
  15092. message is sent to a subscriber, a dispatch object is allocated
  15093. for the dispatch, containing the topic the message was published
  15094. to, the subscriber the message is being sent to, and the message
  15095. itself. The topic is actually unused by any subscriber in
  15096. Asterisk today. And the subscriber is associated with the
  15097. taskprocessor the message is being dispatched to. First, this
  15098. patch removes the unused topic parameter from Stasis subscription
  15099. callbacks. Second, this patch introduces the concept of
  15100. taskprocessor local data, data that may be set on a taskprocessor
  15101. and provided along with the data pointer when a task is pushed
  15102. using the ast_taskprocessor_push_local() call. This allows the
  15103. task to have both data specific to that taskprocessor, in
  15104. addition to data specific to that invocation. With those two
  15105. changes, the dispatch object can be removed completely, and the
  15106. message is simply refcounted and sent directly to the
  15107. taskprocessor. Review: https://reviewboard.asterisk.org/r/2884/
  15108. ........ Merged revisions 399887,400138,400178,400180-400181 from
  15109. http://svn.asterisk.org/svn/asterisk/branches/12
  15110. 2013-09-30 15:57 +0000 [r400142] Kinsey Moore <kmoore@digium.com>
  15111. * /, channels/chan_sip.c, configs/pjsip.conf.sample,
  15112. res/res_pjsip_outbound_registration.c, configs/sip.conf.sample,
  15113. CHANGES: chan_sip: Allow Asterisk to retry after 403 on register
  15114. This adds a global option in chan_sip to allow it to continue
  15115. attempting registration if a 403 is received, clearing the cached
  15116. nonce and treating it as a non-fatal response. Normally, this
  15117. would cause registration attempts to that endpoint to stop. This
  15118. also adds a similar per-outbound-registration option to
  15119. chan_pjsip which allows the retry interval to be altered for 403
  15120. responses to REGISTER requests. (closes issue ASTERISK-17138)
  15121. Review: https://reviewboard.asterisk.org/r/2874/ Reported by:
  15122. Rudi ........ Merged revisions 400137 from
  15123. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15124. revisions 400140 from
  15125. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15126. revisions 400141 from
  15127. http://svn.asterisk.org/svn/asterisk/branches/12
  15128. 2013-09-28 22:57 +0000 [r400059-400122] Matthew Jordan <mjordan@digium.com>
  15129. * /, res/res_pjsip_notify.c, configs/pjsip_notify.conf.sample
  15130. (added): res_pjsip_notify: Add documentation We forgot to add
  15131. documentation for res_pjsip_notify, which would prevent it from
  15132. being loaded. Whoops. This patch also updates res_pjsip_notify to
  15133. use pjsip_notify.conf, which now has its own sample file in the
  15134. configs directory as well. Review:
  15135. https://reviewboard.asterisk.org/r/2835/ ........ Merged
  15136. revisions 400121 from
  15137. http://svn.asterisk.org/svn/asterisk/branches/12
  15138. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Correct erroneous
  15139. lost packet information in RTCP reports RTCP's calculation of the
  15140. number of lost packets in an RTP stream is based on that stream's
  15141. sequence number count, the number of received packets, and how
  15142. many packets we expect to receive. When the SSRC for an RTP
  15143. stream changes, there can - and almost always will be - a large
  15144. jump in the next packet's timestamp and sequence number. If we
  15145. don't reset the number of received packets, sequence number
  15146. count, and other metrics used by RTCP, the next RR/SR report will
  15147. use the previous SSRC's values to calculate the lost packet count
  15148. for the new SSRC - resulting in a very large number of lost
  15149. packets. This patch modifies res_rtp_asterisk such that, if it
  15150. detects a SSRC change, it will reset the various values used by
  15151. the RTCP calculations. From the perspective of RTCP, this appears
  15152. as a new media stream - which is what it is. Review:
  15153. https://reviewboard.asterisk.org/r/2886/ (closes issue AST-1174)
  15154. Reported by: Thomas Arimont ........ Merged revisions 400089 from
  15155. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15156. revisions 400093 from
  15157. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15158. revisions 400108 from
  15159. http://svn.asterisk.org/svn/asterisk/branches/12
  15160. * /, configure, configure.ac: Add check for openSUSE when detecting
  15161. bfd library In ASTERISK-17842, some additional library checks
  15162. were added to the configure script so that the bfd library could
  15163. be found on CentOS and Fedora systems. As it turns out, openSUSE
  15164. requires an additional library. This patch adds another check to
  15165. the configure script for openSUSE that will add that library.
  15166. Review: https://reviewboard.asterisk.org/r/2885/ (closes issue
  15167. AST-1169) Reported by: Guenther Kelleter ........ Merged
  15168. revisions 400073 from
  15169. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15170. revisions 400075 from
  15171. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15172. revisions 400077 from
  15173. http://svn.asterisk.org/svn/asterisk/branches/12
  15174. * main/cdr.c, /: CDR: Improve handling of parking; resolve
  15175. assertion when originating into park This patch covers two
  15176. problems: 1) Currently, when a call is transferred into a parking
  15177. lot from a bridge (using either the blind transfer or one touch
  15178. parking mechanisms), the application fails to be set to "Park" in
  15179. the resulting CDR record for the parked channel. This is due to
  15180. the ParkedCall message arriving before the BridgeEnter for the
  15181. channel entering the parking bridge. The ParkedCall message isn't
  15182. handled as the CDR for the channel has already been finalized
  15183. (due to the channel having left its two party bridge), and the
  15184. BridgeEnter - which creates the new CDR - doesn't have the
  15185. parking information. This patch modifies the behavior so that
  15186. reception of a ParkedCall message will - if not handled by a CDR
  15187. chain - cause a new CDR to be created and put into the Parking
  15188. state. 2) It fixes a FRACK that occurred when a channel is
  15189. originated into a parking space. The DialedPending state - which
  15190. occurs for both Dialed and Originated channels - assumed that it
  15191. couldn't handle the parking transitions due to it having a Party
  15192. B; however, Originated channels don't have a Party B. As such,
  15193. the existing CDR needs to transition into the parking state -
  15194. this patch does that. Review:
  15195. https://reviewboard.asterisk.org/r/2877/ (closes issue
  15196. ASTERISK-22482) Reported by: Richard Mudgett ........ Merged
  15197. revisions 400062 from
  15198. http://svn.asterisk.org/svn/asterisk/branches/12
  15199. * /, apps/app_queue.c: app_queue: Make manager events tolerant of
  15200. Local channel shenanigans app_queue currently attempts to handle
  15201. Local channel optimizations in an effort to provide accurate
  15202. information in Stasis messages (and their corresponding AMI
  15203. events) as well as the Queue log. Sometimes, however, things
  15204. don't go as planned. Consider the following scenario: SIP/foo <->
  15205. L;1 <-> L;2 <-> SIP/agent SIP/agent answers, triggering a Local
  15206. channel optimization. app_queue will normally do the following: *
  15207. Listen for the Local optimization events and update our agent
  15208. accordingly to SIP/agent in the queue log and messages * When we
  15209. get a hangup, publish the AgentComplete event based on our
  15210. information (SIP/foo and SIP/agent) However, as with all things
  15211. that depend on sanity from something as capricious as Local
  15212. channels, things can go wrong: (1) SIP/agent immediately hangs up
  15213. upon answering. This triggers a race condition between
  15214. termination messages coming from SIP/agent and the ongoing Local
  15215. channel optimization messages. (Note that this can also occur
  15216. with SIP/foo) (2) In a race condition, Asterisk can (rarely)
  15217. deliver the hangup messages prior to the Local channel
  15218. optimization. In that case, the messages *may* arrive to
  15219. app_queue in the following order: * Hangup SIP/Agent * Hangup
  15220. SIP/foo * Optimize L;1/L;2 * Hangup L;2 * Hangup L;1 When
  15221. app_queue receives the hangup of the agent or the caller, it will
  15222. attempt to publish the AgentComplete event. However, it now has a
  15223. problem - it thinks its agent is the ;1 side of the Local
  15224. channel, as it never received the optimization event. At the same
  15225. time, that channel is already gone. This results in getting NULL
  15226. from the Stasis cache. What's more, we can't really wait for the
  15227. optimization message, as we are currently handling the hangup of
  15228. the channel that the optimization event would tell us to use.
  15229. This patch modifies the behavior in app_queue such that, since we
  15230. still have a lot of pertinent queue information (interface, queue
  15231. name, etc.), we now raise the event with what information we
  15232. know. The channels involved now may or may not be present. Users
  15233. will still at least get the "AgentComplete" event, which
  15234. "completes" the known Agent information. Review:
  15235. https://reviewboard.asterisk.org/r/2878/ (closes issue
  15236. ASTERISK-22507) Reported by: Richard Mudgett ........ Merged
  15237. revisions 400060 from
  15238. http://svn.asterisk.org/svn/asterisk/branches/12
  15239. * main/manager.c, /: manager: Fix crash when appending a manager
  15240. channel variable In r399887, a minor performance improvement was
  15241. introduced by not allocating the manager variable struct if it
  15242. wasn't used. Unfortunately, when directly accessing an
  15243. ast_channel struct, manager assumed that the struct was always
  15244. allocated. Since this was no longer the case, things got a bit
  15245. crashy. This fixes that problem by simply bypassing appending
  15246. variables if the manager channel variable struct isn't there.
  15247. ........ Merged revisions 400058 from
  15248. http://svn.asterisk.org/svn/asterisk/branches/12
  15249. 2013-09-27 21:58 +0000 [r400016-400021] Richard Mudgett <rmudgett@digium.com>
  15250. * apps/app_cdr.c, res/res_parking.c, /: app_cdr and res_parking:
  15251. Fix some resource leaks. * app_cdr left the ResetCDR application
  15252. registered. * res_parking leaked a ref to config global. (closes
  15253. issue ASTERISK-22566) Reported by: Corey Farrell Patches:
  15254. ASTERISK-22566-r2.patch (license #5909) patch uploaded by Corey
  15255. Farrell ........ Merged revisions 400020 from
  15256. http://svn.asterisk.org/svn/asterisk/branches/12
  15257. * channels/sip/reqresp_parser.c, /, channels/chan_sip.c: chan_sip:
  15258. Increase some scratch buffer sizes dealing with caller id. *
  15259. Eliminated an unnecessary initialization in check_user_full().
  15260. (closes issue ASTERISK-22477) Reported by: Michael Shepelev
  15261. ........ Merged revisions 400013 from
  15262. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15263. revisions 400014 from
  15264. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15265. revisions 400015 from
  15266. http://svn.asterisk.org/svn/asterisk/branches/12
  15267. 2013-09-27 19:18 +0000 [r400000] Sean Bright <sean@malleable.com>
  15268. * configs/sip.conf.sample: Remove some trailing whitespace and
  15269. steal revision 400000.
  15270. 2013-09-27 18:28 +0000 [r399991] Kevin Harwell <kharwell@digium.com>
  15271. * /, res/res_pjsip.c, res/res_pjsip_session.c,
  15272. include/asterisk/res_pjsip.h, res/res_pjsip.exports.in:
  15273. res_pjsip: crash when using localnet and
  15274. external_signaling_address options There was a collision of
  15275. mod_data use on the transaction between using a nat hook and an
  15276. session response callback. During state change it was assumed
  15277. what was in the mod_data was nothing or the response callback.
  15278. However, it was possible for it to also contain a nat hook thus
  15279. resulting in a bad cast and a crash. Added the ability to store
  15280. multiple data elements in mod_data via a hash table. In this
  15281. instance, mod_data now stores a hash table of the two values that
  15282. can be retrieved using an associated string key. (closes issue
  15283. ASTERISK-22394) Reported by: Rusty Newton Review:
  15284. https://reviewboard.asterisk.org/r/2843/ ........ Merged
  15285. revisions 399990 from
  15286. http://svn.asterisk.org/svn/asterisk/branches/12
  15287. 2013-09-27 17:46 +0000 [r399978] Jonathan Rose <jrose@digium.com>
  15288. * channels/sip/include/sip.h, /, channels/chan_sip.c: chan_sip:
  15289. Reject calls on 200 OKs if no SDP has been received When Asterisk
  15290. receives a 200 OK in response to an invite, that peer should have
  15291. sent an SDP at some point by then. If the channel has never
  15292. received an SDP, media won't have been set and the remote address
  15293. won't be known. Endpoints in general should not be doing this.
  15294. This patch makes it so that Asterisk will simply hang up a call
  15295. if it sends a 200 OK at this point. So far this odd behavior for
  15296. endpoints has only been observed in tests which involved manually
  15297. created SIP transactions in SIPp. (closes issue ASTERISK-22424)
  15298. Reported by: Jonathan Rose Review:
  15299. https://reviewboard.asterisk.org/r/2827/ ........ Merged
  15300. revisions 399939 from
  15301. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15302. revisions 399962 from
  15303. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15304. revisions 399976 from
  15305. http://svn.asterisk.org/svn/asterisk/branches/12
  15306. 2013-09-27 17:11 +0000 [r399938] Richard Mudgett <rmudgett@digium.com>
  15307. * include/asterisk/astobj2.h, tests/test_astobj2.c, main/astobj2.c,
  15308. /: astobj2: Remove OBJ_CONTINUE support. OBJ_CONTINUE was a
  15309. strange feature that came into the world under suspicious
  15310. circumstances to support an abuse of the ao2_container by
  15311. chan_iax2. Since chan_iax2 no longer uses OBJ_CONTINUE, it is
  15312. safe to remove it. The simplified code should help performance
  15313. slightly and make understanding the code easier. Review:
  15314. https://reviewboard.asterisk.org/r/2887/ ........ Merged
  15315. revisions 399937 from
  15316. http://svn.asterisk.org/svn/asterisk/branches/12
  15317. 2013-09-27 14:35 +0000 [r399925] Mark Michelson <mmichelson@digium.com>
  15318. * /, bridges/bridge_native_rtp.c: Fix refleaks of ast_rtp_instance
  15319. structures. These refleaks were causing bridged calls not to
  15320. close their RTP ports. Thus a call would leave open 4 ports (RTP
  15321. for party A, RTCP for party A, RTP for party B, and RTCP for
  15322. party B). This led to an eventual depletion of available RTP
  15323. ports. ........ Merged revisions 399924 from
  15324. http://svn.asterisk.org/svn/asterisk/branches/12
  15325. 2013-09-27 14:08 +0000 [r399913] Kinsey Moore <kmoore@digium.com>
  15326. * tests/test_cel.c, main/cel.c, /, include/asterisk/cel.h: Restore
  15327. usefulness of the CEL Peer field This change makes the CEL peer
  15328. field useful again for BRIDGE_ENTER and BRIDGE_EXIT events and
  15329. fills the field with a comma-separated list of all channels in
  15330. the bridge other than the channel that is entering or exiting the
  15331. bridge. Review: https://reviewboard.asterisk.org/r/2840/ (closes
  15332. issue ASTERISK-22393) ........ Merged revisions 399912 from
  15333. http://svn.asterisk.org/svn/asterisk/branches/12
  15334. 2013-09-26 18:51 +0000 [r399898] Kevin Harwell <kharwell@digium.com>
  15335. * res/res_pjsip_registrar.c, include/asterisk/res_pjsip.h,
  15336. res/res_pjsip.exports.in, /, res/res_pjsip/security_events.c:
  15337. pjsip: race condition in registrar While handling a registration
  15338. request a race condition could occur if/when two+ clients
  15339. registered at the same time. This happened when one request
  15340. obtained a copy of the current contacts for an AOR and another
  15341. request did the same before the first request updated. Thus the
  15342. second would update and overwrite the first (or vice-versa
  15343. depending on which actually updated first). In the case of it
  15344. being the same contact two "add" events would be raised. pjsip
  15345. registration handling is now serialized to alleviate this issue.
  15346. (closes issue AST-1213) Reported by: John Bigelow Review:
  15347. https://reviewboard.asterisk.org/r/2860/ ........ Merged
  15348. revisions 399897 from
  15349. http://svn.asterisk.org/svn/asterisk/branches/12
  15350. 2013-09-26 14:13 +0000 [r399875] Rusty Newton <rnewton@digium.com>
  15351. * /, apps/app_dial.c: Adding a few words to the Dial option 'r'
  15352. help text to clarify its tone argument description ........
  15353. Merged revisions 399874 from
  15354. http://svn.asterisk.org/svn/asterisk/branches/12
  15355. 2013-09-25 20:38 +0000 [r399844] Richard Mudgett <rmudgett@digium.com>
  15356. * channels/sig_ss7.c, channels/chan_dahdi.c, /: chan_dahdi: CLI
  15357. "core stop gracefully" has needless delay for PRI and SS7. The
  15358. PRI and SS7 link control threads are not stopped correctly when
  15359. the chan_dahdi.so module is unloaded. The link control threads
  15360. pri_dchannel() and ss7_linkset() are not awakened from a poll()
  15361. to cancel the thread. * Added a SIGURG signal after requesting
  15362. the thread cancel to break the link control thread poll()
  15363. immediately. For SS7 it was slightly worse, the link poll()
  15364. timeout would always be whatever was the last libss7 scheduled
  15365. event time used. If no libss7 scheduled event was pending, the
  15366. thread could run more often than necessary. * Set nextms to 60
  15367. seconds for the ss7_linkset() poll() if there is no other libss7
  15368. scheduled event. ........ Merged revisions 399818 from
  15369. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15370. revisions 399834 from
  15371. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15372. revisions 399842 from
  15373. http://svn.asterisk.org/svn/asterisk/branches/12
  15374. 2013-09-25 19:43 +0000 [r399799] Rusty Newton <rnewton@digium.com>
  15375. * /, res/res_pjsip.c: Broke the build - Fixing XML DTD violation
  15376. added in r399782, missing <para> tags inside a <note> ........
  15377. Merged revisions 399798 from
  15378. http://svn.asterisk.org/svn/asterisk/branches/12
  15379. 2013-09-25 19:29 +0000 [r399797] Michael L. Young <elgueromexicano@gmail.com>
  15380. * /, channels/chan_sip.c: chan_sip: Fix Realtime Peer Update
  15381. Problem When Un-registering And Expires Header In 200ok 1st Issue
  15382. When a realtime peer sends an un-REGISTER request, Asterisk
  15383. un-registers the peer but the database table record still has
  15384. regseconds and fullcontact for the peer. This results in calls
  15385. attempting to be routed to the peer which is no longer
  15386. registered. The expected behavior is to get busy/congested when
  15387. attempting to call an un-registered peer through the dialplan.
  15388. What was discovered is that we are clearing out the peer's
  15389. registration in the database in parse_register_contact() when
  15390. calling expire_register() but then upon returning from
  15391. parse_register_contact(), update_peer() is run which stores back
  15392. in the database table regseconds and fullcontact. 2nd Issue The
  15393. reporter pointed out that the 200 ok being returned by Asterisk
  15394. after un-registering a peer contains a Contact header with
  15395. ;expires= and the Expires header is not set to 0. This is
  15396. actually a regression. Tests were created for this second issue
  15397. (ASTERISK-22548). The tests have been reviewed and a Ship It! was
  15398. received on those tests. This patch does the following: * Do not
  15399. ignore the Expires header value even when it is set to 0. The
  15400. patch sets the pvt->expiry earlier on in the function so that it
  15401. is set properly and used. * If pvt->expiry is 0, do not call
  15402. update_peer since that means the peer has already been
  15403. un-registered and there is no need to update the database record
  15404. again since nothing has changed. (closes issue ASTERISK-22428)
  15405. Reported by: Ben Smithurst Tested by: Ben Smithurst, Michael L.
  15406. Young Patches:
  15407. asterisk-22428-rt-peer-update-and-expires-header.diff by Michael
  15408. L. Young (license 5026) Review:
  15409. https://reviewboard.asterisk.org/r/2869/ ........ Merged
  15410. revisions 399794 from
  15411. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15412. revisions 399795 from
  15413. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15414. revisions 399796 from
  15415. http://svn.asterisk.org/svn/asterisk/branches/12
  15416. 2013-09-25 18:38 +0000 [r399782] Rusty Newton <rnewton@digium.com>
  15417. * /, res/res_pjsip.c: Fixing documentation for the configOption
  15418. "external_media_address" of both Endpoints and Transports
  15419. Re-using some of Mark Michelson's text from an E-mail discussion
  15420. for: * Modifying synopsis for both options * Adding description
  15421. to both options * Changing name of "external_media_address" for
  15422. Endpoint configuration to "media_address" in anticipation of the
  15423. option name being changed. (As it is not really specific to
  15424. external destinations) (issue ASTERISK-22405) (closes issue
  15425. ASTERISK-22405) Reported by: Rusty Newton Review:
  15426. https://reviewboard.asterisk.org/r/2850/ ........ Merged
  15427. revisions 399781 from
  15428. http://svn.asterisk.org/svn/asterisk/branches/12
  15429. 2013-09-24 22:55 +0000 [r399737-399750] Richard Mudgett <rmudgett@digium.com>
  15430. * /, main/astobj2.c: astobj2: Made use OBJ_SEARCH_xxx identifiers
  15431. as field enum values internally. * Made ao2_unlink to protect
  15432. itself from stray OBJ_SEARCH_xxx values passed in. ........
  15433. Merged revisions 399749 from
  15434. http://svn.asterisk.org/svn/asterisk/branches/12
  15435. * channels/chan_iax2.c, /: chan_iax2: Prevent some needless
  15436. breaking of the native IAX2 bridge. * Clean up some twisted code
  15437. in the iax2_bridge() loop. * Add AST_CONTROL_VIDUPDATE and
  15438. AST_CONTROL_SRCCHANGE to a list of frames to prevent the native
  15439. bridge loop from breaking. * Passing the
  15440. AST_CONTROL_T38_PARAMETERS frame should also allow FAX over a
  15441. native IAX2 bridge. (issue ABE-2912) Review:
  15442. https://reviewboard.asterisk.org/r/2870/ ........ Merged
  15443. revisions 399697 from
  15444. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15445. revisions 399708 from
  15446. http://svn.asterisk.org/svn/asterisk/branches/11 For v12 and
  15447. above this is really just documentation until IAX2 native
  15448. bridging is restored. ........ Merged revisions 399736 from
  15449. http://svn.asterisk.org/svn/asterisk/branches/12
  15450. 2013-09-24 19:22 +0000 [r399667-399696] Matthew Jordan <mjordan@digium.com>
  15451. * apps/app_queue.c, /: app_queue: Don't be quite so aggressive in
  15452. initializing the array We only need the first character. ........
  15453. Merged revisions 399695 from
  15454. http://svn.asterisk.org/svn/asterisk/branches/12
  15455. * apps/app_queue.c, /: app_queue: Initialize array holding
  15456. MixMonitor exec options If the channel variable MONITOR_EXEC is
  15457. set, app_queue will pass the specified execution parameters to
  15458. the MixMonitor application when a queue is recorded. If that
  15459. channel variable is not set, the buffer that holds the escaped
  15460. value was not being initialized to NULL, and so would be passed
  15461. to the MixMonitor application with garbage. Hilarity ensued as
  15462. app_mixmonitor attempted to execute gobeldy-gook. ........ Merged
  15463. revisions 399681 from
  15464. http://svn.asterisk.org/svn/asterisk/branches/12
  15465. * main/stasis_bridges.c, tests/test_cdr.c, main/cdr.c, /: Fix a
  15466. performance problem CDRs There is a large performance price
  15467. currently in the CDR engine. We currently perform two
  15468. ao2_callback calls on a container that has an entry for every
  15469. channel in the system. This is done to create matching pairs
  15470. between channels in a bridge. As such, the portion of the CDR
  15471. logic that this patch deals with is how we make pairings when a
  15472. channel enters a mixing bridge. In general, when a channel enters
  15473. such a bridge, we need to do two things: (1) Figure out if anyone
  15474. in the bridge can be this channel's Party B. (2) Make pairings
  15475. with every other channel in the bridge that is not already our
  15476. Party B. This is a two step process. In the first step, we look
  15477. through everyone in the bridge and see if they can be our Party B
  15478. (single_state_process_bridge_enter). If they can - yay! We mark
  15479. our CDR as having gotten a Party B. If not, we keep searching. If
  15480. we don't find one, we wait until someone joins who can be our
  15481. Party B. Step 2 is where we changed the logic
  15482. (handle_bridge_pairings and bridge_candidate_process).
  15483. Previously, we would first find candidates - those channels in
  15484. the bridge with us - from the active_cdrs_by_channel container.
  15485. Because a channel could be a candidate if it was Party B to an
  15486. item in the container, the code implemented multiple
  15487. ao2_container callbacks to get all the candidates. We also had to
  15488. store them in another container with some other meta information.
  15489. This was rather complex and costly, particularly if you have 300
  15490. Local channels (600 channels!) going at once. Luckily, none of it
  15491. is needed: when a channel enters a bridge (which is when we're
  15492. figuring all this stuff out), the bridge snapshot tells us the
  15493. unique IDs of everyone already in the bridge. All we need to do
  15494. is: For all channels in the bridge: If the channel is us or our
  15495. Party B that we got in step 1, skip it Compare us and the
  15496. candidate to figure out who is Party A (based on some specific
  15497. rules) If we are Party A: Make a new CDR for us, append it to our
  15498. chain, and set the candidate as Party B If they are Party A: If
  15499. they don't have a Party B: Make a new CDR for them, append us to
  15500. their chain, and us as Party B Otherwise: Copy us over as Party B
  15501. on their existing CDR. This patch does that. Because we now use
  15502. channel unique IDs to find the candidates during bridging,
  15503. active_cdrs_by_channel now looks up things using uniqueid instead
  15504. of channel name. This makes the more complex code simpler; it
  15505. does, however, have the drawback that dialplan applications and
  15506. functions will be slightly slower as they have to iterate through
  15507. the container looking for the CDR by name. That's a small price
  15508. to pay however as the bridging code will be called a lot more
  15509. often. This patch also does two other minor changes: (1) It
  15510. reduces the container size of the channels in a bridge snapshot
  15511. to 1. In order to be predictable for multi-party bridges, the
  15512. order of the channels in the container must be stable; that is,
  15513. it must always devolve to a linked list. (2) CDRs and the
  15514. multi-party test was updated to show the relationship between two
  15515. dialed channels. You still want to know if they talked -
  15516. previously, dialed channels were always ignored, which is wrong
  15517. when they have managed to get a Party B. (closes issue
  15518. ASTERISK-22488) Reported by: Richard Mudgett Review:
  15519. https://reviewboard.asterisk.org/r/2861/ ........ Merged
  15520. revisions 399666 from
  15521. http://svn.asterisk.org/svn/asterisk/branches/12
  15522. 2013-09-23 12:03 +0000 [r399625] Joshua Colp <jcolp@digium.com>
  15523. * res/res_pjsip.c, res/res_pjsip_session.c, /: Fix crash in
  15524. res_pjsip on load if error occurs, and prevent unloading of
  15525. res_pjsip and res_pjsip_session. During load time in res_pjsip if
  15526. an error occurred the operation would attempt to rollback all
  15527. operations done during load. This is not permitted by PJSIP as it
  15528. will assert if the operation has not been done. This fix changes
  15529. the code so it will only rollback what has been initialized
  15530. already. Further changes also prevent res_pjsip and
  15531. res_pjsip_session from being unloaded. This is due to limitations
  15532. within PJSIP itself. The library environment can only be changed
  15533. to a certain extent and does not provide the ability, currently,
  15534. to deinitialize certain required functionality. (closes issue
  15535. ASTERISK-22474) Reported by: Corey Farrell ........ Merged
  15536. revisions 399624 from
  15537. http://svn.asterisk.org/svn/asterisk/branches/12
  15538. 2013-09-21 04:49 +0000 [r399578-399608] Richard Mudgett <rmudgett@digium.com>
  15539. * res/res_rtp_asterisk.c, /: res_rtp_asterisk: Fix ref leaks in
  15540. ast_rtcp_read(). Moved rtcp_report RAII_VAR declaration into the
  15541. loop so it is unref'ed after every loop. Moved message_blob to
  15542. loop and switched it to a regular variable. The regular variable
  15543. was used since message_blob is used in a very contained way.
  15544. (closes issue ASTERISK-22565) Reported by: Corey Farrell Patches:
  15545. rtcp_report-leak.patch (license #5909) patch uploaded by Corey
  15546. Farrell Tested by: Corey Farrell ........ Merged revisions 399607
  15547. from http://svn.asterisk.org/svn/asterisk/branches/12
  15548. * /, main/media_index.c: media_index: Fix
  15549. process_description_file() memory leak of file_id_persist.
  15550. ........ Merged revisions 399596 from
  15551. http://svn.asterisk.org/svn/asterisk/branches/12
  15552. * /, main/features_config.c: features_config: Fix config ref leak
  15553. of parkinglots. This leak happend for just about every channel
  15554. created. ........ Merged revisions 399585 from
  15555. http://svn.asterisk.org/svn/asterisk/branches/12
  15556. * /, apps/app_queue.c: app_queue: Fix json blob ref leak. The json
  15557. ref from queue_member_blob_create() was never released. ........
  15558. Merged revisions 399583 from
  15559. http://svn.asterisk.org/svn/asterisk/branches/12
  15560. * main/json.c, /: json: Make it obvious that ast_json_unref() is
  15561. NULL safe. It looked like the safety check was done after the
  15562. NULL pointer was used. ........ Merged revisions 399576 from
  15563. http://svn.asterisk.org/svn/asterisk/branches/12
  15564. 2013-09-20 22:44 +0000 [r399566] Kinsey Moore <kmoore@digium.com>
  15565. * main/config_options.c, /: Ensure global types in the config
  15566. framework are initialized If a config object was allocated but
  15567. one of its global objects was never encountered, then the global
  15568. object's defaults were never applied. Ensure that global objects
  15569. are initialized properly upon allocation instead of on
  15570. configuration. Review: https://reviewboard.asterisk.org/r/2866/
  15571. ........ Merged revisions 399564 from
  15572. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15573. revisions 399565 from
  15574. http://svn.asterisk.org/svn/asterisk/branches/12
  15575. 2013-09-20 22:06 +0000 [r399554] Jonathan Rose <jrose@digium.com>
  15576. * main/dial.c, /: originate/call forwarding: Fix a crash when
  15577. forwarding a call from originate (closes issue ASTERISK-22487)
  15578. Reported by: David M. Lee Review:
  15579. https://reviewboard.asterisk.org/r/2868/ ........ Merged
  15580. revisions 399553 from
  15581. http://svn.asterisk.org/svn/asterisk/branches/12
  15582. 2013-09-20 16:18 +0000 [r399533] Joshua Colp <jcolp@digium.com>
  15583. * /, channels/chan_pjsip.c: Add a missing session supplement
  15584. unregistration in chan_pjsip for ACKs. (closes issue
  15585. ASTERISK-22453) Reported by: Corey Farrell Patches:
  15586. chan_pjsip_session_unregister_supplement.patch uploaded by Corey
  15587. Farrell (license 5909) ........ Merged revisions 399531 from
  15588. http://svn.asterisk.org/svn/asterisk/branches/12
  15589. 2013-09-20 14:26 +0000 [r399515] Kevin Harwell <kharwell@digium.com>
  15590. * /, main/logger.c: Fix memory leak in logger. Fixed a memory leak
  15591. discovered in the logger where a temporary string buffer was not
  15592. being freed. (closes issue ASTERISK-22540) Reported by: John
  15593. Hardin ........ Merged revisions 399513 from
  15594. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15595. revisions 399514 from
  15596. http://svn.asterisk.org/svn/asterisk/branches/12
  15597. 2013-09-19 23:20 +0000 [r399503] Richard Mudgett <rmudgett@digium.com>
  15598. * /, main/optional_api.c: optional_api: Make always use the
  15599. standard malloc functions even with MALLOC_DEBUG. ........ Merged
  15600. revisions 399501 from
  15601. http://svn.asterisk.org/svn/asterisk/branches/12
  15602. 2013-09-19 17:01 +0000 [r399459] Jonathan Rose <jrose@digium.com>
  15603. * /, channels/chan_sip.c: chan_sip: Make direct media reinvites for
  15604. T38 put Asterisk in the media path Prior to this patch, Asterisk
  15605. would incorrectly use the previous endpoint addresses in SDP in
  15606. spite of providing its own port. T38 is never meant to be done
  15607. through directmedia and Asterisk should always be in the media
  15608. path for these streams. (closes issue ASTERISK-17273) Reported
  15609. by: Kevin Stewart (closes issue ASTERISK-18706) Reported by:
  15610. Jeremy Kister Review: https://reviewboard.asterisk.org/r/2853/
  15611. ........ Merged revisions 399456 from
  15612. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15613. revisions 399457 from
  15614. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15615. revisions 399458 from
  15616. http://svn.asterisk.org/svn/asterisk/branches/12
  15617. 2013-09-18 20:04 +0000 [r399405] Kinsey Moore <kmoore@digium.com>
  15618. * /, main/abstract_jb.c: Fix jitter buffer log file creation This
  15619. adjusts '/'-to-'#' replacement to replace all instances of '/'
  15620. instead of just the first to ensure that the jitter buffer log
  15621. file gets the correct name as per Richard Kenner's suggestion.
  15622. (closes issue ASTERISK-21036) Reported by: Richard Kenner
  15623. ........ Merged revisions 399402 from
  15624. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15625. revisions 399403 from
  15626. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15627. revisions 399404 from
  15628. http://svn.asterisk.org/svn/asterisk/branches/12
  15629. 2013-09-18 17:23 +0000 [r399368-399378] Matthew Jordan <mjordan@digium.com>
  15630. * /, build_tools/prep_tarball: Update prep_tarball with new
  15631. documentation files on the Asterisk wiki This will now pull both
  15632. a command reference for the version being prepared, as well as an
  15633. Admin Guide that applies to all versions of Asterisk. (issue
  15634. ASTERISK-22439) Reported by: Olle Johansson ........ Merged
  15635. revisions 399351 from
  15636. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15637. revisions 399373 from
  15638. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15639. revisions 399376 from
  15640. http://svn.asterisk.org/svn/asterisk/branches/12
  15641. * /, bridges/bridge_softmix.c: Add a WARNING in bridge_softmix when
  15642. a timing module isn't loaded If bridge_softmix fails to be
  15643. created because no timing source is present in Asterisk, this
  15644. will currently fail gracefully but with (most likely) a generic
  15645. error message by whatever module tried to create the softmix
  15646. bridge. This patch adds a more explicit warning so you can
  15647. actually diagnose and fix the problem. Review:
  15648. https://reviewboard.asterisk.org/r/2857/ ........ Merged
  15649. revisions 399353 from
  15650. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15651. revisions 399365 from
  15652. http://svn.asterisk.org/svn/asterisk/branches/12
  15653. 2013-09-18 17:15 +0000 [r399352] Richard Mudgett <rmudgett@digium.com>
  15654. * main/config_options.c: Make config framework able to reload
  15655. module configs with multiple config files. The config framework
  15656. is supposed to be able to load configs that come from multiple
  15657. config files. The principle example is chan_sip's sip.conf and
  15658. users.conf. Unfortunately, it only does this correctly on initial
  15659. load. This patch causes the module's config to be reloaded
  15660. entirely if any of the config files change. (closes issue
  15661. ASTERISK-22009) Reported by: Richard Mudgett Review:
  15662. https://reviewboard.asterisk.org/r/2859/
  15663. 2013-09-18 14:56 +0000 [r399340] Kevin Harwell <kharwell@digium.com>
  15664. * res/res_pjsip_messaging.c, /: res_pjsip_messaging: Register
  15665. message technology as pjsip pjsip's message technology was being
  15666. registered as 'sip', which was causing it to not load due it
  15667. conflicting with chan_sip's registered 'sip' technology for
  15668. messaging. It now registers as 'pjsip'. However, due to this
  15669. change the "to" field for outgoing pjsip messages need to be
  15670. prefixed with 'pjsip:' instead of 'sip:'. Incoming messages to
  15671. res_pjsip_messaging will automatically have their "to" fields
  15672. altered in order to accommodate the change. Outgoing messages
  15673. also handle changing it back to 'sip' before being sent so the
  15674. pjsip library will properly handle it. (closes issue
  15675. ASTERISK-22445) Reported by: Matt Jordan Review:
  15676. https://reviewboard.asterisk.org/r/2833/ ........ Merged
  15677. revisions 399339 from
  15678. http://svn.asterisk.org/svn/asterisk/branches/12
  15679. 2013-09-18 00:13 +0000 [r399295] Michael L. Young <elgueromexicano@gmail.com>
  15680. * /, main/features_config.c: Fix Segfault In features-config.c When
  15681. Application Has No Arguments Some applications do not require
  15682. arguments. Therefore, when parsing application maps in
  15683. features.conf, it is possible that app_data will be set to NULL.
  15684. * This patch sets app_data to "" if it is NULL. Review:
  15685. https://reviewboard.asterisk.org/r/2804 ........ Merged revisions
  15686. 399294 from http://svn.asterisk.org/svn/asterisk/branches/12
  15687. 2013-09-17 23:10 +0000 [r399284] Mark Michelson <mmichelson@digium.com>
  15688. * res/res_pjsip_sdp_rtp.c, res/res_pjsip/pjsip_configuration.c,
  15689. res/res_pjsip_t38.c, include/asterisk/res_pjsip.h, /: Change the
  15690. "external_media_address" PJSIP endpoint option to
  15691. "media_address". The endpoint option does not apply to
  15692. communication with external entities. Rather, the option is
  15693. applied to all communications with the endpoint. The
  15694. external_media_address transport configuration option may
  15695. override the endpoint option if it turns out that we are going to
  15696. be communicating with an external entity. Two things of note: 1)
  15697. I have not updated the XML documentation. This is being taken
  15698. care of by Rusty as part of his work on issue ASTERISK-22405 2)
  15699. This commit is likely to cause testsuite failures since there are
  15700. tests that use the external_media_address endpoint option, and
  15701. they will need to be changed over. Well, I'm planning to get that
  15702. updated ASAP after this commit. (closes issue ASTERISK-22528)
  15703. reported by Rusty Newton ........ Merged revisions 399283 from
  15704. http://svn.asterisk.org/svn/asterisk/branches/12
  15705. 2013-09-17 18:44 +0000 [r399269] Kevin Harwell <kharwell@digium.com>
  15706. * main/logger.c, main/asterisk.c, /: Remote console: more output
  15707. discrepancies The remote console continued to have issues with
  15708. its output. In this case CLI command output would either not show
  15709. up (if verbose level = 0) or would contain verbose prefixes (if
  15710. verbose level > 0) once log messages were sent to the remote
  15711. console. The fix now now adds verbose prefix data to all new
  15712. lines contained in a verbose log string. (closes issue
  15713. ASTERISK-22450) Reported by: David Brillert (closes issue
  15714. AST-1193) Reported by: Guenther Kelleter Review:
  15715. https://reviewboard.asterisk.org/r/2825/ ........ Merged
  15716. revisions 399267 from
  15717. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15718. revisions 399268 from
  15719. http://svn.asterisk.org/svn/asterisk/branches/12
  15720. 2013-09-17 17:55 +0000 [r399258] Richard Mudgett <rmudgett@digium.com>
  15721. * /, include/asterisk/features_config.h: Fix doxygen to use correct
  15722. units of features.conf options. ........ Merged revisions 399257
  15723. from http://svn.asterisk.org/svn/asterisk/branches/12
  15724. 2013-09-17 17:10 +0000 [r399238-399248] Mark Michelson <mmichelson@digium.com>
  15725. * main/bridge_basic.c, main/features_config.c, /: Fix other
  15726. timeouts (atxferloopdelay and atxfernoanswertimeout) to use
  15727. seconds instead of milliseconds. Thanks to Richard Mudgett for
  15728. pointing this out. ........ Merged revisions 399247 from
  15729. http://svn.asterisk.org/svn/asterisk/branches/12
  15730. * main/features_config.c, /, include/asterisk/features_config.h,
  15731. main/bridge_basic.c: Switch transferdigittimeout to be configured
  15732. as seconds instead of milliseconds. This was an unintentional
  15733. consequence of the update of features.conf to use the config
  15734. framework in Asterisk 12. Thanks to Marco Signorini on the
  15735. Asterisk developers list for pointing out the problem. ........
  15736. Merged revisions 399237 from
  15737. http://svn.asterisk.org/svn/asterisk/branches/12
  15738. 2013-09-17 14:58 +0000 [r399226] Kevin Harwell <kharwell@digium.com>
  15739. * apps/confbridge/conf_state_multi_marked.c, /: Confbridge: empty
  15740. conference not being torn down Confbridge would not properly tear
  15741. down an empty conference bridge when all users were kicked via
  15742. end_marked=yes and at least one user was also set to wait_marked.
  15743. This occurred because while end_marked users were being kicked
  15744. and at least one was also set to wait_marked then the leave
  15745. wait_marked handler would be called on that user, but there would
  15746. be no waiting user (still considered active). The waiting users
  15747. would decrement and now be negative. The conference would remain,
  15748. but be put into an inactive state. The solution was to move from
  15749. the active list to the wait list, those users with wait_marked
  15750. set right before kicking. This allows both the active and wait
  15751. users to decrement correctly and the confbridge to tear down
  15752. properly. A crashed also occurred when trying to list the
  15753. specific conference from the CLI. This happened because the
  15754. conference specified was invalid. Since the conference properly
  15755. tears down now there is no way to reference it thus alleviating
  15756. the crash as well. (closes issue ASTERISK-21859) Reported by:
  15757. Chris Gentle Review: https://reviewboard.asterisk.org/r/2848/
  15758. ........ Merged revisions 399222 from
  15759. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15760. revisions 399225 from
  15761. http://svn.asterisk.org/svn/asterisk/branches/12
  15762. 2013-09-16 18:36 +0000 [r399161-399208] Richard Mudgett <rmudgett@digium.com>
  15763. * tests/test_ari_model.c, /: Fix module load errors for
  15764. test_ari_model.so. You cannot use a function pointer variable
  15765. with an external function from another dynamically loaded module
  15766. because data variables are always resolved even with RTLD_LAZY. *
  15767. Added wrapper functions for ast_ari_validate_int() and
  15768. ast_ari_validate_string() to use instead for the function pointer
  15769. variable. (closes issue ASTERISK-22457) Reported by: David M. Lee
  15770. ........ Merged revisions 399207 from
  15771. http://svn.asterisk.org/svn/asterisk/branches/12
  15772. * apps/app_speech_utils.c, /, res/res_speech.exports.in:
  15773. app_speech_utils: Fix unresolved symbol ast_speech_get_setting().
  15774. Fixes regression introduced by -r374096. * Made
  15775. res_speech.export.in export ast_* symbols instead of specific
  15776. functions. * Made app_speech_utils.c declare that it is dependent
  15777. upon res_speech. (issue ASTERISK-17136) Reported by: Richard
  15778. Kenner ........ Merged revisions 399197 from
  15779. http://svn.asterisk.org/svn/asterisk/branches/12
  15780. * channels/chan_iax2.c, /: chan_iax2: Fix saving the wrong expiry
  15781. time in astdb. When a new IAX2 client registers, the astdb
  15782. database is updated with the value of minregexpire defined in
  15783. iax.conf instead of using the expiry time that is provided by the
  15784. client. The provided expiry time of the client is updated after
  15785. inserting the astdb entry. As a consequence, restarting or
  15786. reloading asterisk creates clients whose registration may expire
  15787. before they reregister. The clients are therefore unavailable
  15788. after minregexpire seconds until they reregister. * Move updating
  15789. of the expiry time to before inserting into the astdb. (closes
  15790. issue ASTERISK-22504) Reported by: Stefan Wachtler Patches:
  15791. chan_iax2.c.patch (license #6533) patch uploaded by Stefan
  15792. Wachtler ........ Merged revisions 399158 from
  15793. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15794. revisions 399159 from
  15795. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15796. revisions 399160 from
  15797. http://svn.asterisk.org/svn/asterisk/branches/12
  15798. 2013-09-16 02:37 +0000 [r399147] Matthew Jordan <mjordan@digium.com>
  15799. * main/cdr.c, /: Filter internal channels out of bridge enter/leave
  15800. message handling Some channels exist merely as an implementation
  15801. detail in Asterisk, such as ConfBridge's announcer/recorder
  15802. channels. These channels should never be exposed to the outside
  15803. world, or to interfaces that report on Asterisk. We already
  15804. filter out such channels in snapshot processing; however, we
  15805. failed to filter out bridge related messages that involved these
  15806. channels. This patch filters out bridge related messages that are
  15807. for such channels. This prevents a spurious WARNING message from
  15808. being displayed when those channels move in and out of bridges.
  15809. ........ Merged revisions 399146 from
  15810. http://svn.asterisk.org/svn/asterisk/branches/12
  15811. 2013-09-13 22:19 +0000 [r399138] Richard Mudgett <rmudgett@digium.com>
  15812. * res/parking/parking_bridge_features.c, apps/app_agent_pool.c,
  15813. include/asterisk/features.h, main/channel.c,
  15814. res/parking/parking_tests.c, include/asterisk/bridge_channel.h,
  15815. main/features.c, tests/test_cel.c, main/bridge_channel.c,
  15816. tests/test_cdr.c, apps/confbridge/conf_chan_announce.c,
  15817. include/asterisk/bridge.h, res/res_pjsip_refer.c, /,
  15818. channels/chan_sip.c, res/stasis/control.c, main/bridge.c,
  15819. main/bridge_basic.c, main/core_unreal.c,
  15820. res/parking/parking_applications.c, main/core_local.c: Restore
  15821. Dial, Queue, and FollowMe 'I' option support. The Dial, Queue,
  15822. and FollowMe applications need to inhibit the bridging initial
  15823. connected line exchange in order to support the 'I' option. *
  15824. Replaced the pass_reference flag on ast_bridge_join() with a
  15825. flags parameter to pass other flags defined by enum
  15826. ast_bridge_join_flags. * Replaced the independent flag on
  15827. ast_bridge_impart() with a flags parameter to pass other flags
  15828. defined by enum ast_bridge_impart_flags. * Since the Dial, Queue,
  15829. and FollowMe applications are now the only callers of
  15830. ast_bridge_call() and ast_bridge_call_with_flags(), changed the
  15831. calling contract to require the initial COLP exchange to already
  15832. have been done by the caller. * Made all callers of
  15833. ast_bridge_impart() check the return value. It is important. As a
  15834. precaution, I also made the compiler complain now if it is not
  15835. checked. * Did some cleanup in parking_tests.c as a result of
  15836. checking the ast_bridge_impart() return value. An independent,
  15837. but associated change is: * Reduce stack usage in
  15838. ast_indicate_data() and add a dropping redundant connected line
  15839. verbose message. (closes issue ASTERISK-22072) Reported by:
  15840. Joshua Colp Review: https://reviewboard.asterisk.org/r/2845/
  15841. ........ Merged revisions 399136 from
  15842. http://svn.asterisk.org/svn/asterisk/branches/12
  15843. 2013-09-13 20:55 +0000 [r399101] David M. Lee <dlee@digium.com>
  15844. * /, main/astobj2.c: Don't write to /tmp/refs when REF_DEBUG is not
  15845. defined. If MALLOC_DEBUG is enabled, then the debug destructor
  15846. for the container is used, which would erroneously write to
  15847. /tmp/refs. This patch only uses the debug destructor if ref_debug
  15848. is used. (closes issue ASTERISK-22536) ........ Merged revisions
  15849. 399098 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  15850. ........ Merged revisions 399099 from
  15851. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15852. revisions 399100 from
  15853. http://svn.asterisk.org/svn/asterisk/branches/12
  15854. 2013-09-13 14:50 +0000 [r399082-399084] Mark Michelson <mmichelson@digium.com>
  15855. * res/res_pjsip.c, res/res_pjsip_pubsub.c, res/res_pjsip_session.c,
  15856. include/asterisk/res_pjsip.h, res/res_pjsip.exports.in, /: Create
  15857. more accurate Contact headers for dialogs when we are the UAS.
  15858. (closes issue AST-1207) reported by John Bigelow Review:
  15859. https://reviewboard.asterisk.org/r/2842 ........ Merged revisions
  15860. 399083 from http://svn.asterisk.org/svn/asterisk/branches/12
  15861. * res/res_pjsip/config_auth.c, /,
  15862. res/res_pjsip_outbound_authenticator_digest.c,
  15863. res/res_pjsip_authenticator_digest.c: Change how realms are
  15864. handled for outbound authentication. With this change, if no
  15865. realm is specified in an outbound auth section, then we will
  15866. simply match the realm that was present in the 401/407 challenge.
  15867. (closes issue ASTERISK-22471) Reported by George Joseph (closes
  15868. issue ASTERISK-22386) Reported by Rusty Newton Patches:
  15869. outbound_auth_realm_v4.patch uploaded by George Joseph (License
  15870. #6322) ........ Merged revisions 399059 from
  15871. http://svn.asterisk.org/svn/asterisk/branches/12
  15872. 2013-09-13 14:43 +0000 [r399080-399081] David M. Lee <dlee@digium.com>
  15873. * /: Recorded merge of revisions 399035,399049 from
  15874. http://svn.asterisk.org/svn/asterisk/branches/12 These were lost
  15875. in r399071
  15876. * /: Put merge tracking for r399039 back.
  15877. 2013-09-13 14:27 +0000 [r399071] Rusty Newton <rnewton@digium.com>
  15878. * /, res/res_pjsip_endpoint_identifier_ip.c: Broke the build!
  15879. Forgot para tags within my description.
  15880. https://bamboo.asterisk.org/bamboo/browse/AST-ATRUNKBUILD-304
  15881. ........ Merged revisions 399064 from
  15882. http://svn.asterisk.org/svn/asterisk/branches/12
  15883. 2013-09-13 14:22 +0000 [r399042-399051] David M. Lee <dlee@digium.com>
  15884. * res/res_pjsip_log_forwarder.c (added), res/res_pjsip_logger.c,
  15885. res/res_rtp_asterisk.c, /: res_pjsip: Forward PJSIP logging to
  15886. Asterisk logging This patch uses PJSIP's pj_log_set_log_func() to
  15887. forward PJSIP's log messages to Asterisk's logger. This is done
  15888. in a new module: res_pjsip_log_forwarder.so. This patch sets
  15889. defaultenabled on the existing res_pjsip_logger.so to no, since
  15890. logging every SIP packet seems a bit odd to do by default, and is
  15891. (hopefully) less necessary with regular PJSIP logging. It also
  15892. removes res_rtp_asterisk's disabling of PJSIP logging. (closes
  15893. issue ASTERISK-22360) Reported by: Joshua Colp Review:
  15894. https://reviewboard.asterisk.org/r/2830/ ........ Merged
  15895. revisions 399049 from
  15896. http://svn.asterisk.org/svn/asterisk/branches/12
  15897. * /, res/res_http_websocket.c: ARI: Fix WebSocket response when
  15898. subprotocol isn't specified When I moved the ARI WebSocket from
  15899. /ws to /ari/events, I added code to allow a WebSocket to connect
  15900. without specifying the subprotocol if there's only one
  15901. subprotocol handler registered for the WebSocket. Naively, I
  15902. coded it to always respond with the subprotocol in use.
  15903. Unfortunately, according to RFC 6455, if the server's response
  15904. includes a subprotocol header field that "indicates the use of a
  15905. subprotocol that was not present in the client's handshake [...],
  15906. the client MUST _Fail the WebSocket Connection_.", emphasis
  15907. theirs. This patch correctly omits the Sec-WebSocket-Protocol if
  15908. one is not specified by the client. (closes issue ASTERISK-22441)
  15909. Review: https://reviewboard.asterisk.org/r/2828/ ........ Merged
  15910. revisions 399039 from
  15911. http://svn.asterisk.org/svn/asterisk/branches/12
  15912. 2013-09-13 14:17 +0000 [r399036] Kinsey Moore <kmoore@digium.com>
  15913. * /, apps/app_meetme.c: Fix several crashes in MeetMeAdmin This
  15914. change ensures that MeetMeAdmin commands requiring a user
  15915. actually get a user and fixes another issue where an extra
  15916. dereference could occur for a last-entered user being ejected if
  15917. a user identifier was also provided. (closes issue
  15918. ASTERISK-21907) Reported by: Alex Epshteyn Review:
  15919. https://reviewboard.asterisk.org/r/2844/ ........ Merged
  15920. revisions 399033 from
  15921. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15922. revisions 399034 from
  15923. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15924. revisions 399035 from
  15925. http://svn.asterisk.org/svn/asterisk/branches/12
  15926. 2013-09-13 13:28 +0000 [r399032] Rusty Newton <rnewton@digium.com>
  15927. * /, res/res_pjsip_endpoint_identifier_ip.c: 'identify'
  15928. configObject doesn't have a synopsis Add a straightforward
  15929. synopsis and description to the identify config object in XML
  15930. documentation. (issue ASTERISK-22311) (closes issue
  15931. ASTERISK-22311) Reported By: Rusty Newton ........ Merged
  15932. revisions 399031 from
  15933. http://svn.asterisk.org/svn/asterisk/branches/12
  15934. 2013-09-12 23:42 +0000 [r399020-399022] Richard Mudgett <rmudgett@digium.com>
  15935. * /, main/bridge.c: CLI bridge: Fix "bridge destroy <id>" and
  15936. "bridge kick <id> <chan>" tab completion. These two commands must
  15937. deal with the live bridges container for tab completion and not
  15938. the stasis cache. ........ Merged revisions 399021 from
  15939. http://svn.asterisk.org/svn/asterisk/branches/12
  15940. * main/bridge.c, /: astobj2: Register the bridges container for
  15941. debug inspection. ........ Merged revisions 399019 from
  15942. http://svn.asterisk.org/svn/asterisk/branches/12
  15943. 2013-09-12 23:23 +0000 [r399018] Rusty Newton <rnewton@digium.com>
  15944. * /, res/res_pjsip_acl.c: Documentation fix and improvements to XML
  15945. configuration help res_pjsip_acl * One bug fix. Made the synopsis
  15946. for "type" to accurate. * changing the usage of "IP-domains" to
  15947. "IP addresses" * clarifying the usage for the options, by adding
  15948. a relevant description for each * modified other areas of the XML
  15949. help for clarity, such as the module description and a few
  15950. synopsis changes here and there. See the patch. (issue
  15951. ASTERISK-22458) (closes issue ASTERISK-22458) Reported By: Rusty
  15952. Newton Review: https://reviewboard.asterisk.org/r/2823/ ........
  15953. Merged revisions 399017 from
  15954. http://svn.asterisk.org/svn/asterisk/branches/12
  15955. 2013-09-12 20:27 +0000 [r399006] Jonathan Rose <jrose@digium.com>
  15956. * channels/sip/include/sip.h, /, channels/chan_sip.c: chan_sip:
  15957. Revert r398835 due to failing tests involving originate (issue
  15958. ASTERISK-22424) Reported by: Jonathan Rose ........ Merged
  15959. revisions 398977 from
  15960. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15961. revisions 398986 from
  15962. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  15963. revisions 398991 from
  15964. http://svn.asterisk.org/svn/asterisk/branches/12
  15965. 2013-09-12 16:44 +0000 [r398939] Richard Mudgett <rmudgett@digium.com>
  15966. * main/core_unreal.c, /: core_local: Fix memory corruption race
  15967. condition. The masquerade super test is failing on v12 with high
  15968. fence violations and crashing. The fence violations are showing
  15969. that party id allocated memory strings are somehow getting
  15970. corrupted in the bridge_reconfigured_connected_line_update()
  15971. function. The invalid string values happen to be the freed memory
  15972. fill pattern. After much puzzling, I deduced that the
  15973. bridge_reconfigured_connected_line_update() is copying a string
  15974. out of the source channel's caller party id struct just as
  15975. another thread is updating it with a new value. The copying
  15976. thread is using the old string pointer being freed by the
  15977. updating thread. A search of the code found the
  15978. unreal_colp_redirect_indicate() routine updating the caller party
  15979. id's without holding the channel lock. A latent bug in v1.8 and
  15980. v11 hatched in v12 because of the bridging and connected line
  15981. changes. :) (issue ASTERISK-22221) Reported by: Matt Jordan
  15982. Review: https://reviewboard.asterisk.org/r/2839/ ........ Merged
  15983. revisions 398938 from
  15984. http://svn.asterisk.org/svn/asterisk/branches/12
  15985. 2013-09-12 15:23 +0000 [r398928] David M. Lee <dlee@digium.com>
  15986. * res/res_pjsip.c, /: Fix symbol collision with pjsua. We shouldn't
  15987. be exporting any symbols that start with pjsip_. ........ Merged
  15988. revisions 398927 from
  15989. http://svn.asterisk.org/svn/asterisk/branches/12
  15990. 2013-09-12 00:04 +0000 [r398883-398887] Rusty Newton <rnewton@digium.com>
  15991. * /, apps/app_queue.c: 'queue add member' help text correction You
  15992. are adding dial strings to the queue, not channels. An aribitrary
  15993. string could be used, but you are typically referencing a
  15994. channel. Correcting the command help text. (issue ASTERISK-22263)
  15995. (closes issue ASTERISK-22263) Reported By: Rusty Newton ........
  15996. Merged revisions 398884 from
  15997. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  15998. revisions 398885 from
  15999. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16000. revisions 398886 from
  16001. http://svn.asterisk.org/svn/asterisk/branches/12
  16002. * configs/chan_dahdi.conf.sample, /: Documentation fix -
  16003. waitfordialtone is not boolean, it's time in milliseconds
  16004. Changing text in chan_dahdi.conf sample to be accurate. (issue
  16005. ASTERISK-22308) (closes issue ASTERISK-22308) Reported By:
  16006. Malcolm Davenport ........ Merged revisions 398880 from
  16007. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16008. revisions 398881 from
  16009. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16010. revisions 398882 from
  16011. http://svn.asterisk.org/svn/asterisk/branches/12
  16012. 2013-09-11 20:03 +0000 [r398838] Jonathan Rose <jrose@digium.com>
  16013. * /, channels/chan_sip.c, channels/sip/include/sip.h: chan_sip:
  16014. Reject calls without prior SDP on 200 OK If we receive a 200 OK
  16015. without SDP, we will now check to see if the remote address has
  16016. been established for that channel's RTP session and if the to tag
  16017. for that channel has changed from the most recent to tag in a
  16018. response less than 200. If either a change has been made since
  16019. the last to-tag was received or the remote address is unset, then
  16020. we will drop the call. (closes issue ASTERISK-22424) Reported by:
  16021. Jonathan Rose Review:
  16022. https://reviewboard.asterisk.org/r/2827/diff/#index_header
  16023. ........ Merged revisions 398835 from
  16024. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16025. revisions 398836 from
  16026. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16027. revisions 398837 from
  16028. http://svn.asterisk.org/svn/asterisk/branches/12
  16029. 2013-09-11 18:03 +0000 [r398822] Russell Bryant <russell@russellbryant.com>
  16030. * configs/confbridge.conf.sample, /: Fix typo in
  16031. confbridge.conf.sample The denoise filter requires func_speex,
  16032. not codec_speex. Fix this in the description of the denoise=yes
  16033. option in confbridge.conf. ........ Merged revisions 398820 from
  16034. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16035. revisions 398821 from
  16036. http://svn.asterisk.org/svn/asterisk/branches/12
  16037. 2013-09-11 14:23 +0000 [r398808] Kevin Harwell <kharwell@digium.com>
  16038. * res/res_pjsip_caller_id.c, channels/chan_pjsip.c, /: pjsip:
  16039. reinvite for connected line updates occurs when it should not
  16040. Connected line updates are now only sent out if an actual update
  16041. needs to occur. This happens under the following conditions: 1.
  16042. The endpoint we are sending to is trusted. 2. Either a
  16043. P-Asserted-Identity or Remote Party-ID header needs to be
  16044. added/sent. 3. The connected id's number and name are valid. Also
  16045. added an SDP when an update is sent out. (closes issue AST-1212)
  16046. Reported by: John Bigelow Review:
  16047. https://reviewboard.asterisk.org/r/2831/ ........ Merged
  16048. revisions 398806 from
  16049. http://svn.asterisk.org/svn/asterisk/branches/12
  16050. 2013-09-10 18:05 +0000 [r398760] Richard Mudgett <rmudgett@digium.com>
  16051. * main/event.c, res/res_musiconhold.c, main/indications.c,
  16052. main/asterisk.c, main/xmldoc.c, main/cli.c, /,
  16053. funcs/func_dialgroup.c, main/heap.c,
  16054. res/res_pjsip/pjsip_configuration.c: Fix incorrect usages of
  16055. ast_realloc(). There are several locations in the code base where
  16056. this is done: buf = ast_realloc(buf, new_size); This is going to
  16057. leak the original buf contents if the realloc fails. Review:
  16058. https://reviewboard.asterisk.org/r/2832/ ........ Merged
  16059. revisions 398757 from
  16060. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16061. revisions 398758 from
  16062. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16063. revisions 398759 from
  16064. http://svn.asterisk.org/svn/asterisk/branches/12
  16065. 2013-09-10 17:50 +0000 [r398751-398755] David M. Lee <dlee@digium.com>
  16066. * utils/check_expr.c, /: Fixed utils directory breakage from
  16067. r398748, this time with extra hate. ........ Merged revisions
  16068. 398752 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  16069. ........ Merged revisions 398753 from
  16070. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16071. revisions 398754 from
  16072. http://svn.asterisk.org/svn/asterisk/branches/12
  16073. * utils/check_expr.c, /, utils/ael_main.c, utils/conf2ael.c: Fixed
  16074. utils directory breakage from r398648 ........ Merged revisions
  16075. 398748 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  16076. ........ Merged revisions 398749 from
  16077. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16078. revisions 398750 from
  16079. http://svn.asterisk.org/svn/asterisk/branches/12
  16080. 2013-09-09 23:29 +0000 [r398732] Richard Mudgett <rmudgett@digium.com>
  16081. * main/astmm.c, /: MALLOC_DEBUG: Change fence magic number to be
  16082. completely different from the freed magic number. Race conditions
  16083. between freeing a nul terminated string and ast_strdup()'ing it
  16084. are more likely to be detected if the fence and freed magic
  16085. numbers are completely different. ........ Merged revisions
  16086. 398703 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  16087. ........ Merged revisions 398721 from
  16088. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16089. revisions 398726 from
  16090. http://svn.asterisk.org/svn/asterisk/branches/12
  16091. 2013-09-09 22:00 +0000 [r398695] Mark Michelson <mmichelson@digium.com>
  16092. * res/res_pjsip_endpoint_identifier_ip.c, /: Add extra debugging to
  16093. res_pjsip_endpoint_identifier_ip ........ Merged revisions 398694
  16094. from http://svn.asterisk.org/svn/asterisk/branches/12
  16095. 2013-09-09 20:13 +0000 [r398641-398652] David M. Lee <dlee@digium.com>
  16096. * /, main/utils.c, include/asterisk/lock.h, main/lock.c: Fix
  16097. DEBUG_THREADS when lock is acquired in __constructor__ This patch
  16098. fixes some long-standing bugs in debug threads that were
  16099. exacerbated with recent Optional API work in Asterisk 12. With
  16100. debug threads enabled, on some systems, there's a lock ordering
  16101. problem between our mutex and glibc's mutex protecting its module
  16102. list (Ubuntu Lucid, glibc 2.11.1 in this instance). In one
  16103. thread, the module list will be locked before acquiring our
  16104. mutex. In another thread, our mutex will be locked before locking
  16105. the module list (which happens in the depths of calling
  16106. backtrace()). This patch fixes this issue by moving backtrace()
  16107. calls outside of critical sections that have the mutex acquired.
  16108. The bigger change was to reentrancy tracking for
  16109. ast_cond_{timed,}wait, which wrongly assumed that waiting on the
  16110. mutex was equivalent to a single unlock (it actually suspends all
  16111. recursive locks on the mutex). (closes issue ASTERISK-22455)
  16112. Review: https://reviewboard.asterisk.org/r/2824/ ........ Merged
  16113. revisions 398648 from
  16114. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16115. revisions 398649 from
  16116. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16117. revisions 398651 from
  16118. http://svn.asterisk.org/svn/asterisk/branches/12
  16119. * res/ari/resource_channels.h, /, rest-api/api-docs/channels.json:
  16120. Multiple revisions 398638-398639 ........ r398638 | dlee |
  16121. 2013-09-09 14:01:54 -0500 (Mon, 09 Sep 2013) | 1 line Added note
  16122. about expected behavior of originate ........ r398639 | dlee |
  16123. 2013-09-09 14:02:27 -0500 (Mon, 09 Sep 2013) | 1 line Added note
  16124. about expected behavior of originate (the rest of the commit)
  16125. ........ Merged revisions 398638-398639 from
  16126. http://svn.asterisk.org/svn/asterisk/branches/12
  16127. 2013-09-08 23:30 +0000 [r398629] Matthew Jordan <mjordan@digium.com>
  16128. * tests/test_cdr.c, /: Update CDR Unit tests to reflect container
  16129. changes in r398579 When a channel joins a multi-party bridge, the
  16130. ordering of the CDRs that is created is determined by the
  16131. ordering of the channels who happen to be in that bridge. When
  16132. r398579 changed the number of buckets in the container to
  16133. something sensible, it changed the ordering that the CDRs was
  16134. created in, causing one of the multiparty tests to fail. This
  16135. fixes the test with the now expected ordering. ........ Merged
  16136. revisions 398628 from
  16137. http://svn.asterisk.org/svn/asterisk/branches/12
  16138. 2013-09-07 01:03 +0000 [r398603-398620] Kinsey Moore <kmoore@digium.com>
  16139. * /, res/res_xmpp.c: Prevent XMPP timeout on blank responses
  16140. Sometimes the Google Voice servers have a bad habit of sending
  16141. out 1 byte replies to the xmpp resource. When a blank 1 byte
  16142. reply is received from the socket the buffer attempts to wait
  16143. (endlessly) for the rest of the reply from google which
  16144. effectively blocks the socket and google voice calls will no
  16145. longer come into the server. This patch allows the xmpp module to
  16146. correctly detect empty packets and send out ping replies to
  16147. google. It also sets a socket timeout on the default socket which
  16148. prevents the xmpp socket from closing and preventing future
  16149. google voice calls from coming into the server. Furthermore
  16150. instead of sending an empty reply back to google we send a proper
  16151. xmpp ping reply back. This also adds several more socket
  16152. messages. (closes issue ASTERISK-22347) Reported by: Andrew Nagy
  16153. Review: https://reviewboard.asterisk.org/r/2771 Patches:
  16154. xmpp_fix_1.diff uploaded by Andrew Nagy (License #6524) ........
  16155. Merged revisions 398618 from
  16156. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16157. revisions 398619 from
  16158. http://svn.asterisk.org/svn/asterisk/branches/12
  16159. * /, res/res_xmpp.c, res/res_jabber.c: Multiple revisions
  16160. 398558,398577 ........ r398558 | kmoore | 2013-09-06 14:28:16
  16161. -0500 (Fri, 06 Sep 2013) | 17 lines Fix Jabber/XMPP distributed
  16162. MWI The mailbox and context are swapped on the receiving end for
  16163. all users of Jabber and XMPP distributed MWI in Asterisk 1.8 and
  16164. all more recent versions. This swaps those values to be correct
  16165. when publishing to the internal event system from Jabber/XMPP
  16166. distributed MWI state. (closes issue ASTERISK-22435) Reported by:
  16167. abelbeck Tested by: Michael Keuter Patches:
  16168. asterisk-1.8-res_jabber-aji_handle_pubsub_event.patch uploaded by
  16169. abelbeck asterisk-11-res_xmpp-xmpp_pubsub_handle_event.patch
  16170. uploaded by abelbeck ........ Merged revisions 398523 from
  16171. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  16172. r398577 | kmoore | 2013-09-06 16:00:56 -0500 (Fri, 06 Sep 2013) |
  16173. 10 lines Commit the remainder of r398523 This is a missing part
  16174. of the commit in revision 398523 that corrects the name of a
  16175. variable. (issue ASTERISK-22435) ........ Merged revisions 398576
  16176. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  16177. Merged revisions 398558,398577 from
  16178. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16179. revisions 398580 from
  16180. http://svn.asterisk.org/svn/asterisk/branches/12
  16181. 2013-09-06 21:17 +0000 [r398557-398583] Richard Mudgett <rmudgett@digium.com>
  16182. * main/cdr.c, /: cdr: Change the number of container buckets to be
  16183. similar to the channels container. * Fix the temporary cdr
  16184. candidate containers to use a prime number of buckets. ........
  16185. Merged revisions 398579 from
  16186. http://svn.asterisk.org/svn/asterisk/branches/12
  16187. * main/core_local.c, /: core_local: Fix LocalOptimizationBegin AMI
  16188. event missing Source channel snapshot. * Fix the
  16189. LocalOptimizationBegin AMI event by eliminating an artificial
  16190. buffer size limitation that is too small anyway. ........ Merged
  16191. revisions 398572 from
  16192. http://svn.asterisk.org/svn/asterisk/branches/12
  16193. * main/cdr.c, /: cdr: Fix some ref leaks. * Added missing
  16194. unregister of the cdr container in cdr_engine_shutdown(). * Fixed
  16195. ref leak in off nominal path of cdr_object_alloc(). * Removed
  16196. some unnecessary NULL checks in cdr_object_dtor(). ........
  16197. Merged revisions 398562 from
  16198. http://svn.asterisk.org/svn/asterisk/branches/12
  16199. * include/asterisk/astobj2.h, main/cel.c, main/features_config.c,
  16200. apps/app_agent_pool.c, main/cdr.c, main/udptl.c, /,
  16201. main/parking.c, main/stasis_config.c: astobj2: Add warn unused
  16202. attribute to some functions. * Fixed resulting warnings with
  16203. improper use of ao2_global_obj_replace(). * Made a couple uses of
  16204. ao2_global_obj_replace_unref(x, NULL) into the equivalent and
  16205. more appropriate ao2_global_obj_release() call. ........ Merged
  16206. revisions 398533 from
  16207. http://svn.asterisk.org/svn/asterisk/branches/12
  16208. 2013-09-06 18:53 +0000 [r398512-398522] Kinsey Moore <kmoore@digium.com>
  16209. * main/http.c, /, res/stasis/app.c: Fix build warnings When
  16210. AST_DEVMODE is not defined, ast_asserts are not compiled into the
  16211. binary. In some cases, this means variables are not referenced or
  16212. are set but unused which causes warnings to show up. (closes
  16213. issue ASTERISK-22446) Reported by: Jason Parker (qwell) ........
  16214. Merged revisions 398521 from
  16215. http://svn.asterisk.org/svn/asterisk/branches/12
  16216. * /, channels/chan_h323.c: Fix chan_h323 compilation This fixes the
  16217. things in chan_h323 that were missed or ignored in the great
  16218. channel opaquification and gets chan_h323 back into a compiling
  16219. state. (closes issue ASTERISK-22365) Reported by: Dmitry Melekhov
  16220. Patches: chan_h323.patch uploaded by Dmitry Melekhov ........
  16221. Merged revisions 398510 from
  16222. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16223. revisions 398511 from
  16224. http://svn.asterisk.org/svn/asterisk/branches/12
  16225. 2013-09-05 21:48 +0000 [r398384-398499] Richard Mudgett <rmudgett@digium.com>
  16226. * /, main/astobj2.c: astobj2: Only define ao2_bt() once. * Make
  16227. ao2_bt() not use single char variable names. * Fix ao2_bt()
  16228. formatting. ........ Merged revisions 398498 from
  16229. http://svn.asterisk.org/svn/asterisk/branches/12
  16230. * channels/chan_iax2.c, /: chan_iax2: Reduce indentation in
  16231. __attempt_transmit(). * Reduce indentation in
  16232. __attempt_transmit(). * Don't update the static last error time
  16233. variable every time in __schedule_action() and socket_read().
  16234. ........ Merged revisions 398456 from
  16235. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16236. revisions 398457 from
  16237. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16238. revisions 398458 from
  16239. http://svn.asterisk.org/svn/asterisk/branches/12
  16240. * channels/chan_iax2.c, /: chan_iax2: Fix stray reference to worker
  16241. thread idle_list. * Fix stray reference to idle_list in
  16242. cleanup_thread_list(). This may be the reason for the note in
  16243. iax2_process_thread() about threads not being removed from the
  16244. task lists. * Move cleanup_thread_list(&idle_list) to after the
  16245. other lists are cleaned up. ........ Merged revisions 398416 from
  16246. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16247. revisions 398417 from
  16248. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16249. revisions 398418 from
  16250. http://svn.asterisk.org/svn/asterisk/branches/12
  16251. * channels/chan_iax2.c, /: chan_iax2: Fix bridgecallno deadlock
  16252. avoidance. * Fix bridgecallno deadlock avoidance. When doing
  16253. deadlock avoidance, you need to retest the status of values for
  16254. each loop to see if you still need the lock for bridgecallno. *
  16255. As a safety check, after acquiring the bridgecallno lock you
  16256. should check if iaxs[bridgecallno] is NULL just like the current
  16257. callno checks. * Move setting thread->iostate to IAX_IOSTATE_IDLE
  16258. to after processing any deferred frames to ensure that the
  16259. iostate is IDLE when it is placed back into the idle list.
  16260. defer_full_frame() tries to ensure iax2_process_thread() wakes up
  16261. to process the frame. ........ Merged revisions 398379 from
  16262. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16263. revisions 398380 from
  16264. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16265. revisions 398381 from
  16266. http://svn.asterisk.org/svn/asterisk/branches/12
  16267. 2013-09-05 14:10 +0000 [r398369] Mark Michelson <mmichelson@digium.com>
  16268. * /, res/res_pjsip_outbound_registration.c: Clarify server_uri and
  16269. client_uri registration settings. Used some of Rusty's suggested
  16270. language plus also included more SIPesque descriptions of where
  16271. the URIs are actually used in an outgoing REGISTER. (closes issue
  16272. ASTERISK-22390) reported by Rusty Newton ........ Merged
  16273. revisions 398368 from
  16274. http://svn.asterisk.org/svn/asterisk/branches/12
  16275. 2013-09-04 23:07 +0000 [r398304] Richard Mudgett <rmudgett@digium.com>
  16276. * channels/iax2/parser.c, /: chan_iax2: Add missing control frame
  16277. names to debug frame decode output. ........ Merged revisions
  16278. 398301 from http://svn.asterisk.org/svn/asterisk/branches/1.8
  16279. ........ Merged revisions 398302 from
  16280. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16281. revisions 398303 from
  16282. http://svn.asterisk.org/svn/asterisk/branches/12
  16283. 2013-09-04 22:49 +0000 [r398300] Mark Michelson <mmichelson@digium.com>
  16284. * /, res/res_pjsip_outbound_authenticator_digest.c: Give more
  16285. detail regarding failures to create request with auth
  16286. credentials. (issue ASTERISK-22386) ........ Merged revisions
  16287. 398299 from http://svn.asterisk.org/svn/asterisk/branches/12
  16288. 2013-09-04 21:37 +0000 [r398284-398287] Jonathan Rose <jrose@digium.com>
  16289. * /, tests/test_voicemail_api.c: unit tests: test_voicemail_api
  16290. leaks stringfields from snapshots (closes issue ASTERISK-22414)
  16291. Reported by: Corey Farrell Patches:
  16292. test_voicemail_api-leaks-11.patch uploaded by coreyfarrell
  16293. (license 5909) ........ Merged revisions 398285 from
  16294. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16295. revisions 398286 from
  16296. http://svn.asterisk.org/svn/asterisk/branches/12
  16297. * apps/app_voicemail.c, /: app_voicemail: Fix leaking config
  16298. objects when msg_id doesn't match (issues ASTERISK-22414)
  16299. Reported by: Corey Farrell Patch:
  16300. test_voicemail_api-leaks-11.patch uploaded by coreyfarrell
  16301. (license 5909) ........ Merged revisions 398281 from
  16302. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16303. revisions 398283 from
  16304. http://svn.asterisk.org/svn/asterisk/branches/12
  16305. 2013-09-04 16:03 +0000 [r398238] Richard Mudgett <rmudgett@digium.com>
  16306. * channels/chan_misdn.c, /: chan_misdn: Fix misdn debug output
  16307. printed with arbitrary verbose levels. Fix the misdn debug output
  16308. to remote consoles. chan_misdn uses ast_console_puts() which
  16309. doesn't know about verbose levels. Better to use ast_verbose()
  16310. instead. Without this patch the misdn debug messages are appended
  16311. to the verbose level which ever was set by the message sent to
  16312. the console before, i.e. any undefined level. (closes issue
  16313. AST-1218) Reported by: Guenther Kelleter Patches: misdnlog.patch
  16314. (license #6372) patch uploaded by Guenther Kelleter ........
  16315. Merged revisions 398235 from
  16316. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16317. revisions 398236 from
  16318. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16319. revisions 398237 from
  16320. http://svn.asterisk.org/svn/asterisk/branches/12
  16321. 2013-09-04 14:32 +0000 [r398227] Kevin Harwell <kharwell@digium.com>
  16322. * /, res/res_pjsip_outbound_registration.c: Debug messages for
  16323. pjsip outbound registration Added debug messages indicating that
  16324. an outbound registration attempt was made and it was successful
  16325. in pjsip. (closes issue ASTERISK-22388) Reported by: Rusty Newton
  16326. ........ Merged revisions 398226 from
  16327. http://svn.asterisk.org/svn/asterisk/branches/12
  16328. 2013-09-03 20:28 +0000 [r398217] Alexandr Anikin <may@telecom-service.ru>
  16329. * /, addons/ooh323c/src/ooh245.c: Fix remote tcs sequence handling
  16330. on empty tcs received ........ Merged revisions 398214 from
  16331. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16332. revisions 398215 from
  16333. http://svn.asterisk.org/svn/asterisk/branches/12
  16334. 2013-09-03 18:09 +0000 [r398207] Kinsey Moore <kmoore@digium.com>
  16335. * res/res_pjsip_dtmf_info.c, /: Prevent a crash in
  16336. res_pjsip_dtmf_info.c This change makes sure that a content type
  16337. header exists before checking the contents of the header against
  16338. known SIP INFO DTMF content types. ........ Merged revisions
  16339. 398206 from http://svn.asterisk.org/svn/asterisk/branches/12
  16340. 2013-09-03 17:19 +0000 [r398205] David M. Lee <dlee@digium.com>
  16341. * Makefile, /: Fixed 'make clean' for wiki docs ........ Merged
  16342. revisions 398198 from
  16343. http://svn.asterisk.org/svn/asterisk/branches/12
  16344. 2013-09-03 14:29 +0000 [r398197] Walter Doekes <walter+asterisk@wjd.nu>
  16345. * /, cel/cel_custom.c: Be a little more verbose when loading
  16346. cel_custom.conf. Review: https://reviewboard.asterisk.org/r/2805/
  16347. ........ Merged revisions 398167 from
  16348. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16349. revisions 398168 from
  16350. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16351. revisions 398196 from
  16352. http://svn.asterisk.org/svn/asterisk/branches/12
  16353. 2013-08-30 20:58 +0000 [r398150] David M. Lee <dlee@digium.com>
  16354. * main/asterisk.c, include/asterisk/optional_api.h, /,
  16355. main/optional_api.c: Fix graceful shutdown crash. The cleanup
  16356. code for optional_api needs to happen after all of the optional
  16357. API users and providers have unused/unprovided. Unfortunately,
  16358. regsitering the atexit() handler at the beginning of main() isn't
  16359. soon enough, since module destructors run after that. ........
  16360. Merged revisions 398149 from
  16361. http://svn.asterisk.org/svn/asterisk/branches/12
  16362. 2013-08-30 20:37 +0000 [r398148] Rusty Newton <rnewton@digium.com>
  16363. * /, configs/pjsip.conf.sample: New pjsip.conf.sample (issue
  16364. ASTERISK-22145) (closes issue ASTERISK-22145) Reported By: Matt
  16365. Jordan Review: https://reviewboard.asterisk.org/r/2811/ ........
  16366. Merged revisions 398147 from
  16367. http://svn.asterisk.org/svn/asterisk/branches/12
  16368. 2013-08-30 19:55 +0000 [r398124-398140] Kevin Harwell <kharwell@digium.com>
  16369. * /, res/res_pjsip_outbound_registration.c,
  16370. include/asterisk/sorcery.h, res/res_pjsip.c,
  16371. res/res_pjsip/config_transport.c, main/sorcery.c: Add a
  16372. reloadable option for sorcery type objects Some configuration
  16373. objects currently won't place nice if reloaded. Specifically, in
  16374. this case the pjsip transport objects. Now when registering an
  16375. object in sorcery one may specify that the object is allowed to
  16376. be reloaded or not. If the object is set to not reload then upon
  16377. reloading of the configuration the objects of that type will not
  16378. be reloaded. The initially loaded objects of that type however
  16379. will remain. While the transport objects will not longer be
  16380. reloaded it is still possible for a user to configure an endpoint
  16381. to an invalid transport. A couple of log messages were added to
  16382. help diagnose this problem if it occurs. (closes issue
  16383. ASTERISK-22382) Reported by: Rusty Newton (closes issue
  16384. ASTERISK-22384) Reported by: Rusty Newton Review:
  16385. https://reviewboard.asterisk.org/r/2807/ ........ Merged
  16386. revisions 398139 from
  16387. http://svn.asterisk.org/svn/asterisk/branches/12
  16388. * main/config.c, res/res_security_log.c, /, channels/chan_sip.c,
  16389. main/translate.c, main/named_acl.c, main/indications.c: Fix
  16390. various memory leaks main/config.c - cleanup cache fie includes
  16391. res/res_security_log.c - unregister logger level
  16392. channesl/chan_sip.c - cleanup io context and notify_types
  16393. main/translator.c - cleanup at shutdown main/named_acl.c -
  16394. cleanup cli commands main/indications.c -
  16395. ast_get_indication_tone() unref default_tone_zone if used (closes
  16396. issues ASTERISK-22378) Reported by: Corey Farrell Patches:
  16397. config_shutdown.patch uploaded by coreyfarrell (license 5909)
  16398. res_security_log.patch uploaded by coreyfarrell (license 5909)
  16399. chan_sip-11.patch uploaded by coreyfarrell (license 5909)
  16400. indications_refleak.patch uploaded by coreyfarrell (license 5909)
  16401. named_acl-cli_unreg-trunk.patch uploaded by coreyfarrell (license
  16402. 5909) translate_shutdown.patch uploaded by coreyfarrell (license
  16403. 5909) ........ Merged revisions 398102 from
  16404. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16405. revisions 398103 from
  16406. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16407. revisions 398116 from
  16408. http://svn.asterisk.org/svn/asterisk/branches/12
  16409. 2013-08-30 18:38 +0000 [r398101] Matthew Jordan <mjordan@digium.com>
  16410. * /, UPGRADE-12.txt (added), UPGRADE.txt: Update UPGRADE.txt file
  16411. for Asterisk 12 This simply pulls in the changes that were
  16412. breaking from the CHANGES file and updates a few other areas
  16413. accordingly. It also removes the 10 => 11 notes, which are
  16414. traditionally removed from each major version and stored in the
  16415. appropriate UPGRADE-X.txt file. ........ Merged revisions 398100
  16416. from http://svn.asterisk.org/svn/asterisk/branches/12
  16417. 2013-08-30 18:30 +0000 [r398064-398099] Jonathan Rose <jrose@digium.com>
  16418. * main/features_config.c, /, main/config_options.c:
  16419. features_config: Ignore parkinglots in features.conf instead of
  16420. failing to load Parkinglots are defined in res_features.conf now,
  16421. but this patch fixes features_config so that features don't fail
  16422. to load when parkinglots are present in features.conf Review:
  16423. https://reviewboard.asterisk.org/r/2801/ ........ Merged
  16424. revisions 398068 from
  16425. http://svn.asterisk.org/svn/asterisk/branches/12
  16426. * main/features_config.c, main/udptl.c, /: features_config: Don't
  16427. require features.conf to be present for Asterisk to load (closes
  16428. issue ASTERISK-22426) Reported by: Matt Jordan Review:
  16429. https://reviewboard.asterisk.org/r/2806/ ........ Merged
  16430. revisions 398020 from
  16431. http://svn.asterisk.org/svn/asterisk/branches/12
  16432. 2013-08-30 17:59 +0000 [r398063] Kevin Harwell <kharwell@digium.com>
  16433. * main/manager.c, /, res/res_agi.c: Memory leak fix
  16434. ast_xmldoc_printable returns an allocated block that must be
  16435. freed by the caller. Fixed manager.c and res_agi.c to stop
  16436. leaking these results. (closes issue ASTERISK-22395) Reported by:
  16437. Corey Farrell Patches: manager-leaks-12.patch uploaded by
  16438. coreyfarrell (license 5909) res_agi-xmldoc-leaks.patch uploaded
  16439. by coreyfarrell (license 5909) ........ Merged revisions 398060
  16440. from http://svn.asterisk.org/svn/asterisk/branches/1.8 ........
  16441. Merged revisions 398061 from
  16442. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16443. revisions 398062 from
  16444. http://svn.asterisk.org/svn/asterisk/branches/12
  16445. 2013-08-30 17:11 +0000 [r398024-398026] Richard Mudgett <rmudgett@digium.com>
  16446. * tests/test_substitution.c, /: test_substitution: Fix failing
  16447. test. Revert the -r392190 change. The original test was correct.
  16448. The CDR code was actually returning an unititialized buffer.
  16449. ........ Merged revisions 398025 from
  16450. http://svn.asterisk.org/svn/asterisk/branches/12
  16451. * tests/test_substitution.c, /: test_substituition: Fix failed test
  16452. reporting to actually report failure. You cannot put the "Testing
  16453. <blah> pass/fail" on a single line before actually performing the
  16454. test. Now any additional failure information is logged before the
  16455. test pass/fail announcement. * Added an additional CDR(answer,u)
  16456. test. ........ Merged revisions 398018 from
  16457. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16458. revisions 398019 from
  16459. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16460. revisions 398023 from
  16461. http://svn.asterisk.org/svn/asterisk/branches/12
  16462. 2013-08-30 16:27 +0000 [r398003-398017] Kevin Harwell <kharwell@digium.com>
  16463. * /, apps/app_mixmonitor.c: Fix memory leaks (closes issue
  16464. ASTERISK-22368) Reported by: Corey Farrell Patches:
  16465. issueA22368_mixmonitor_free_filename.patch uploaded by wdoekes
  16466. (license 5674) ........ Merged revisions 398004 from
  16467. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  16468. revisions 398011 from
  16469. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16470. revisions 398016 from
  16471. http://svn.asterisk.org/svn/asterisk/branches/12
  16472. * main/asterisk.c, /: Check return value on fwrite ........ Merged
  16473. revisions 398000 from
  16474. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16475. revisions 398002 from
  16476. http://svn.asterisk.org/svn/asterisk/branches/12
  16477. 2013-08-30 13:40 +0000 [r397987-397990] David M. Lee <dlee@digium.com>
  16478. * rest-api-templates/swagger_model.py, res/ari/ari_websockets.c,
  16479. channels/sip/include/sip.h, main/asterisk.c, res/res_ari.c,
  16480. tests/test_optional_api.c (added), /, channels/chan_sip.c,
  16481. include/asterisk/autoconfig.h.in, configure.ac,
  16482. rest-api-templates/res_ari_resource.c.mustache,
  16483. res/ari/internal.h, res/res_http_websocket.c, CHANGES,
  16484. include/asterisk/compiler.h, include/asterisk/ari.h,
  16485. main/loader.c, include/asterisk/optional_api.h,
  16486. build_tools/cflags.xml, configure, res/res_ari_events.c,
  16487. include/asterisk/http_websocket.h, main/optional_api.c (added):
  16488. optional_api: Fix linking problems between modules that export
  16489. global symbols With the new work in Asterisk 12, there are some
  16490. uses of the optional_api that are prone to failure. The details
  16491. are rather involved, and captured on [the wiki][1]. This patch
  16492. addresses the issue by removing almost all of the magic from the
  16493. optional API implementation. Instead of relying on weak symbol
  16494. resolution, a new optional_api.c module was added to Asterisk
  16495. core. For modules providing an optional API, the pointer to the
  16496. implementation function is registered with the core. For modules
  16497. that use an optional API, a pointer to a stub function, along
  16498. with a optional_ref function pointer are registered with the
  16499. core. The optional_ref function pointers is set to the
  16500. implementation function when it's provided, or the stub function
  16501. when it's now. Since the implementation no longer relies on
  16502. magic, it is now supported on all platforms. In the spirit of
  16503. choice, an OPTIONAL_API flag was added, so we can disable the
  16504. optional_api if needed (maybe it's buggy on some bizarre platform
  16505. I haven't tested on) The AST_OPTIONAL_API*() macros themselves
  16506. remained unchanged, so existing code could remain unchanged. But
  16507. to help with debugging the optional_api, the patch limits the
  16508. #include of optional API's to just the modules using the API.
  16509. This also reduces resource waste maintaining optional_ref
  16510. pointers that aren't used. Other changes made as a part of this
  16511. patch: * The stubs for http_websocket that wrap system calls set
  16512. errno to ENOSYS. * res_http_websocket now properly increments
  16513. module use count. * In loader.c, the while() wrappers around
  16514. dlclose() were removed. The while(!dlclose()) is actually an
  16515. anti-pattern, which can lead to infinite loops if the module
  16516. you're attempting to unload exports a symbol that was directly
  16517. linked to. * The special handling of nonoptreq on systems without
  16518. weak symbol support was removed, since we no longer rely on weak
  16519. symbols for optional_api. [1]:
  16520. https://wiki.asterisk.org/wiki/x/wACUAQ (closes issue
  16521. ASTERISK-22296) Reported by: Matt Jordan Review:
  16522. https://reviewboard.asterisk.org/r/2797/ ........ Merged
  16523. revisions 397989 from
  16524. http://svn.asterisk.org/svn/asterisk/branches/12
  16525. * res/res_stasis_playback.c, /,
  16526. include/asterisk/stasis_app_recording.h,
  16527. res/ari/resource_recordings.h, res/res_stasis_recording.c,
  16528. res/Makefile, res/ari/ari_model_validators.c,
  16529. rest-api/api-docs/recordings.json, res/stasis_recording (added),
  16530. res/ari/resource_recordings.c, res/ari/ari_model_validators.h,
  16531. res/res_ari_recordings.c: ARI: Implement /recordings/stored API's
  16532. his patch implements the ARI API's for stored recordings. While
  16533. the original task only specified deleting a recording, it was
  16534. simple enough to implement the GET for all recordings, and for an
  16535. individual recording. The recording playback operation was
  16536. modified to use the same code for accessing the recording as the
  16537. REST API, so that they will behave consistently. There were
  16538. several problems with the api-docs that were also fixed, bringing
  16539. the ARI spec in line with the implementation. There were some
  16540. 'wishful thinking' fields on the stored recording model (duration
  16541. and timestamp) that were removed, because I ended up not
  16542. implementing a metadata file to go along with the recording to
  16543. store such information. The GET /recordings/live operation was
  16544. removed, since it's not really that useful to get a list of all
  16545. recordings that are currently going on in the system. (At least,
  16546. if we did that, we'd probably want to also list all of the
  16547. current playbacks. Which seems weird.) (closes issue
  16548. ASTERISK-21582) Review: https://reviewboard.asterisk.org/r/2693/
  16549. ........ Merged revisions 397985 from
  16550. http://svn.asterisk.org/svn/asterisk/branches/12
  16551. * /: Multiple revisions 397975-397976 ........ r397975 | rmudgett |
  16552. 2013-08-29 20:00:00 -0500 (Thu, 29 Aug 2013) | 1 line pbx.c: Make
  16553. ast_str_substitute_variables_full() not mask variables. ........
  16554. r397976 | rmudgett | 2013-08-29 20:00:41 -0500 (Thu, 29 Aug 2013)
  16555. | 1 line Revert last commit. ........ Merged revisions
  16556. 397975-397976 from
  16557. http://svn.asterisk.org/svn/asterisk/branches/12
  16558. 2013-08-30 01:20 +0000 [r397978] Richard Mudgett <rmudgett@digium.com>
  16559. * main/pbx.c, /: pbx.c: Make pbx_substitute_variables_helper_full()
  16560. not mask variables. ........ Merged revisions 397977 from
  16561. http://svn.asterisk.org/svn/asterisk/branches/12
  16562. 2013-08-30 00:11 +0000 [r397962-397969] Mark Michelson <mmichelson@digium.com>
  16563. * res/res_pjsip_pidf.c, /: Sanitize XML output for PIDF bodies.
  16564. PJSIP's PIDF API does not replace angle brackets with their
  16565. appropriate counterparts for XML. So we have to do it ourself. In
  16566. this particular case, the problem had to do with attempting to
  16567. place an unsanitized SIP URI into an XML node. Now we don't get a
  16568. 488 from recipients of our PIDF NOTIFYs. ........ Merged
  16569. revisions 397968 from
  16570. http://svn.asterisk.org/svn/asterisk/branches/12
  16571. * res/res_pjsip_pidf.c, /: Fix method for creating activities
  16572. string in PIDF bodies. The previous method did not allocate
  16573. enough space to create the entire string, but adjusted the
  16574. string's slen value to be larger than the actual allocation. This
  16575. resulted in garbled text in NOTIFY requests from Asterisk. This
  16576. method allocates the proper amount of space first and then writes
  16577. the content into the buffer. ........ Merged revisions 397960
  16578. from http://svn.asterisk.org/svn/asterisk/branches/12
  16579. 2013-08-29 22:49 +0000 [r397959] Kevin Harwell <kharwell@digium.com>
  16580. * apps/app_dumpchan.c, main/logger.c, apps/app_verbose.c,
  16581. main/asterisk.c, channels/chan_misdn.c, /: Verbose logging
  16582. discrepancies Refactored cases where a combination of
  16583. ast_verbose/options_verbose were present. Also in general tried
  16584. to eliminate, in as many places as possible, where the
  16585. options_verbose global variable was being used. Refactored the
  16586. way local and remote consoles handle verbose message logging in
  16587. an attempt to solve the various discrepancies that sometimes
  16588. would show between the two. (closes issue AST-1193) Reported by:
  16589. Guenther Kelleter Review:
  16590. https://reviewboard.asterisk.org/r/2798/ ........ Merged
  16591. revisions 397948 from
  16592. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16593. revisions 397958 from
  16594. http://svn.asterisk.org/svn/asterisk/branches/12
  16595. 2013-08-29 22:26 +0000 [r397956-397957] Mark Michelson <mmichelson@digium.com>
  16596. * /, res/res_pjsip_pubsub.c: Fix when the subscription_terminated
  16597. callback is called for subscription handlers. The previous
  16598. placement would result in the resubscribe() callback called
  16599. instead of the subscription_terminated() callback being called
  16600. when a subscription was ended via a SUBSCRIBE request. This would
  16601. result in confusing PJSIP and having it throw an assertion.
  16602. ........ Merged revisions 397955 from
  16603. http://svn.asterisk.org/svn/asterisk/branches/12
  16604. * res/res_pjsip_session.c, /: Fix a race condition where a canceled
  16605. call was answered. RFC 5407 section 3.1.2 details a scenario
  16606. where a UAC sends a CANCEL at the same time that a UAS sends a
  16607. 200 OK for the INVITE that the UAC is canceling. When this
  16608. occurs, it is the role of the UAC to immediately send a BYE to
  16609. terminate the call. This scenario was reproducible by have a
  16610. Digium phone with two lines place a call to a second phone that
  16611. forwarded the call to the second line on the original phone. The
  16612. Digium phone, upon realizing that it was connecting to itself,
  16613. would attempt to cancel the call. The timing of this happened to
  16614. trigger the aforementioned race condition about 80% of the time.
  16615. Asterisk was not doing its job of sending a BYE when receiving a
  16616. 200 OK on a cancelled INVITE. The result was that the ast_channel
  16617. structure was destroyed but the underlying SIP session, as well
  16618. as the PJSIP inv_session and dialog, were still alive. Attempting
  16619. to perform an action such as a transfer, once in this state,
  16620. would result in Asterisk crashing. The circumstances are now
  16621. detected properly and the session is ended as recommended in RFC
  16622. 5407. (closes issue AST-1209) reported by John Bigelow ........
  16623. Merged revisions 397945 from
  16624. http://svn.asterisk.org/svn/asterisk/branches/12
  16625. 2013-08-29 21:37 +0000 [r397947] Kevin Harwell <kharwell@digium.com>
  16626. * main/file.c, main/app.c, main/config_options.c, main/cel.c,
  16627. main/asterisk.c, main/cdr.c, main/manager.c, /,
  16628. main/stasis_config.c: Memory leaks fix (closes ASTERISK-22376)
  16629. Reported by: John Hardin Patches: memleak.patch uploaded by
  16630. jhardin (license 6512) memleak2.patch uploaded by jhardin
  16631. (license 6512) ........ Merged revisions 397946 from
  16632. http://svn.asterisk.org/svn/asterisk/branches/12
  16633. 2013-08-29 20:22 +0000 [r397939] Matthew Jordan <mjordan@digium.com>
  16634. * configs/safe_asterisk.conf.sample (removed), /, CHANGES,
  16635. contrib/scripts/safe_asterisk, Makefile: Revert r394939 due to
  16636. (numerous) objections The patch from ASTERISK-21965 was committed
  16637. perhaps a bit too hastily. Walter and Tzafrir have pointed out
  16638. numerous issues with the approach and have propsed an alternative
  16639. in r/2757. Since it's not a time critical issue and is not worth
  16640. holding up the release of 12 for it, I've gone ahead and reverted
  16641. r394939 from 12/trunk and re-opened ASTERISK-21965. ........
  16642. Merged revisions 397938 from
  16643. http://svn.asterisk.org/svn/asterisk/branches/12
  16644. 2013-08-29 16:21 +0000 [r397932] David M. Lee <dlee@digium.com>
  16645. * rest-api-templates/make_ari_stubs.py, /,
  16646. rest-api-templates/api.wiki.mustache,
  16647. rest-api-templates/asterisk_processor.py: Account for {} in
  16648. Swagger notes ........ Merged revisions 397927 from
  16649. http://svn.asterisk.org/svn/asterisk/branches/12
  16650. 2013-08-29 16:05 +0000 [r397925] Matthew Jordan <mjordan@digium.com>
  16651. * Makefile, /: Recursively search for '.c' files when making
  16652. documentation with 'make full' Without this, documentation
  16653. defined in sub-folders is ignored. Since having properly
  16654. generated documentation is especially important in Asterisk 12 -
  16655. not having it can cause a module to not load - 'make full' needs
  16656. to look in all .c files. ........ Merged revisions 397924 from
  16657. http://svn.asterisk.org/svn/asterisk/branches/12
  16658. 2013-08-29 15:43 +0000 [r397923] Mark Michelson <mmichelson@digium.com>
  16659. * /, apps/app_queue.c, main/cel.c, main/stasis_bridges.c: Multiple
  16660. revisions 397921-397922 ........ r397921 | mmichelson |
  16661. 2013-08-29 10:42:10 -0500 (Thu, 29 Aug 2013) | 6 lines Resolve
  16662. assumptions that bridge snapshots would be non-NULL for transfer
  16663. stasis events. Attempting to transfer an unbridged call would
  16664. result in crashes in either CEL code or in the conversion to AMI
  16665. messages. ........ r397922 | mmichelson | 2013-08-29 10:42:29
  16666. -0500 (Thu, 29 Aug 2013) | 3 lines Remove extra debug message.
  16667. ........ Merged revisions 397921-397922 from
  16668. http://svn.asterisk.org/svn/asterisk/branches/12
  16669. 2013-08-29 12:30 +0000 [r397912] Matthew Jordan <mjordan@digium.com>
  16670. * contrib/ast-db-manage/config,
  16671. contrib/ast-db-manage/config/script.py.mako,
  16672. contrib/ast-db-manage/voicemail.ini.sample,
  16673. contrib/ast-db-manage/voicemail/env.py,
  16674. contrib/ast-db-manage/voicemail,
  16675. contrib/ast-db-manage/voicemail/script.py.mako,
  16676. contrib/ast-db-manage/README.md,
  16677. contrib/ast-db-manage/config/versions,
  16678. contrib/ast-db-manage/voicemail/versions/a2e9769475e_create_tables.py,
  16679. contrib/ast-db-manage (added),
  16680. contrib/ast-db-manage/voicemail/versions, /,
  16681. contrib/ast-db-manage/config.ini.sample,
  16682. contrib/ast-db-manage/config/env.py,
  16683. contrib/ast-db-manage/config/versions/4da0c5f79a9c_create_tables.py:
  16684. Actually *add* the database schema management utilities In
  16685. r397874, the scripts were removed... but not replaced. Thanks to
  16686. Michael Young for noticing this! ........ Merged revisions 397911
  16687. from http://svn.asterisk.org/svn/asterisk/branches/12
  16688. 2013-08-28 23:15 +0000 [r397886-397903] Richard Mudgett <rmudgett@digium.com>
  16689. * main/cdr.c, /, funcs/func_cdr.c, main/stdtime/localtime.c: Fix
  16690. some uninitialized buffers for CDR handling valgrind found. *
  16691. Made ast_strftime_locale() ensure that the output buffer is
  16692. initialized. The std library strftime() returns 0 and does not
  16693. touch the buffer if it has an error. However, the function can
  16694. also return 0 without an error. (closes issue ASTERISK-22412)
  16695. Reported by: rmudgett ........ Merged revisions 397902 from
  16696. http://svn.asterisk.org/svn/asterisk/branches/12
  16697. * main/cdr.c, /: Fixed problems with ast_cdr_serialize_variables().
  16698. * Fixed return value of ast_cdr_serialize_variables() on error.
  16699. It needs to return 0 indicating no CDR variables found. * Made
  16700. ast_cdr_serialize_variables() check the return value of
  16701. cdr_object_format_property() and assert if nonzero. A member of
  16702. the cdr_readonly_vars[] was not handled. * Removed unused
  16703. elements from cdr_readonly_vars[]: total_duration, total_billsec,
  16704. first_start, and first_answer. ........ Merged revisions 397900
  16705. from http://svn.asterisk.org/svn/asterisk/branches/12
  16706. * main/cdr.c, /: Made the on/off in CLI "cdr set debug [on|off]"
  16707. case insensitive. ........ Merged revisions 397898 from
  16708. http://svn.asterisk.org/svn/asterisk/branches/12
  16709. * main/cdr.c, /: Make CDR variable name chandling consistently case
  16710. insensitive. ........ Merged revisions 397896 from
  16711. http://svn.asterisk.org/svn/asterisk/branches/12
  16712. * /, main/cdr.c: Make CDR code deal with channel names case
  16713. insensitively. ........ Merged revisions 397894 from
  16714. http://svn.asterisk.org/svn/asterisk/branches/12
  16715. * /, funcs/func_cdr.c, main/cdr.c: Some CDR code optimization.
  16716. ........ Merged revisions 397892 from
  16717. http://svn.asterisk.org/svn/asterisk/branches/12
  16718. * /, funcs/func_cdr.c: Whitespace and curly braces. ........ Merged
  16719. revisions 397885 from
  16720. http://svn.asterisk.org/svn/asterisk/branches/12
  16721. 2013-08-28 21:09 +0000 [r397877] Mark Michelson <mmichelson@digium.com>
  16722. * /, res/res_pjsip_refer.c: Improve detection of answer on SIP
  16723. blind transfer. A problem encountered during testing was that
  16724. res_pjsip_refer would not ever send a NOTIFY with a 200 OK
  16725. sipfrag. This is because the framehook that was supposed to send
  16726. the NOTIFY would never be told that an answer had occurred. This
  16727. happened for two reasons: 1) The transferee channel on which the
  16728. framehook was on was already up. 2) Answers are rarely if ever
  16729. written to channels. Rather, the ast_answer() or ast_raw_answer()
  16730. function is used to answer channels. Thanks to a suggestion by
  16731. Matt Jordan, the best way to detect that the call had been
  16732. answered was to find out when the transferee channel joined a
  16733. bridge. With stasis this is an easy task. So now, in addition to
  16734. the framehook logic, there is a stasis subscription used to
  16735. determine when the transferee has entered a bridge. Once it has
  16736. entered, an appropriate NOTIFY is sent. ........ Merged revisions
  16737. 397876 from http://svn.asterisk.org/svn/asterisk/branches/12
  16738. 2013-08-28 20:55 +0000 [r397872-397875] Matthew Jordan <mjordan@digium.com>
  16739. * contrib/realtime/mysql/queue_log.sql,
  16740. contrib/realtime/mysql/voicemail.sql,
  16741. contrib/realtime/mysql/sippeers.sql, /,
  16742. contrib/realtime/mysql/iaxfriends.sql,
  16743. contrib/realtime/mysql/meetme.sql,
  16744. contrib/realtime/mysql/voicemail_messages.sql,
  16745. contrib/realtime/postgresql/realtime.sql,
  16746. contrib/realtime/mysql/voicemail_data.sql, CHANGES,
  16747. contrib/realtime/mysql/musiconhold.sql: Add database schema
  16748. management using Alembic This patch replaces contrib/realtime/
  16749. with a new setup for managing the database schema required for
  16750. database integration with Asterisk. In addition to initializing a
  16751. database with the proper schema, alembic can do a database
  16752. migration to assist with upgrading Asterisk in the future.
  16753. Hopefully this helps make setting up and operating Asterisk with
  16754. a database easier. With this the schema only needs to be
  16755. maintained in one place instead of once per database. The schemas
  16756. I have added here have a bit of improvement over the examples
  16757. that were there before (some added consistency and added some
  16758. missing indexes). Managing the schema in one place here also
  16759. applies to all databases supported by SQLAlchemy. See
  16760. contrib/ast-db-manage/README.md for more details. Review:
  16761. https://reviewboard.asterisk.org/r/2731 patch by Russell Bryant
  16762. (license 6300) ........ Merged revisions 397874 from
  16763. http://svn.asterisk.org/svn/asterisk/branches/12
  16764. * CHANGES, /: Update CHANGES file for Asterisk 12 This updates the
  16765. Asterisk 12 CHANGES file with the things that were missed during
  16766. the development cycle. Review:
  16767. https://reviewboard.asterisk.org/r/2795/ ........ Merged
  16768. revisions 397870 from
  16769. http://svn.asterisk.org/svn/asterisk/branches/12
  16770. 2013-08-28 16:13 +0000 [r397857-397860] Richard Mudgett <rmudgett@digium.com>
  16771. * /, main/pbx.c: pbx.c: Make ast_str_substitute_variables_full()
  16772. not mask variables. ........ Merged revisions 397859 from
  16773. http://svn.asterisk.org/svn/asterisk/branches/12
  16774. * main/chanvars.c: ast_free() is null tollerant.
  16775. * include/asterisk/threadstorage.h, /: Match use of ast_free() with
  16776. ast_calloc() and add some curly braces. ........ Merged revisions
  16777. 397856 from http://svn.asterisk.org/svn/asterisk/branches/12
  16778. 2013-08-28 15:43 +0000 [r397855] Mark Michelson <mmichelson@digium.com>
  16779. * res/res_pjsip/pjsip_distributor.c, /: Fix dialog matching in the
  16780. SIP distributor. Dialog matching is performed in the distributor
  16781. for the sole purpose of retrieving an associated serializer so
  16782. the request may be serialized. This patch fixes two problems.
  16783. First, incoming CANCEL requests that had no to-tag (which really
  16784. should be *all* CANCEL requests) would not match with a dialog.
  16785. An earlier bug fix to deal with early CANCEL requests would
  16786. result in the CANCEL being replied to with a 481. The fix for
  16787. this is to find the matching INVITE transaction and get the
  16788. dialog from that transaction. Second, no SIP responses were
  16789. matching dialogs. This is because we were inverting the tags that
  16790. we were passing into PJSIP's dialog finding function. This logic
  16791. has been corrected by setting local and remote tag variables
  16792. based on whether the incoming message is a request or response.
  16793. ........ Merged revisions 397854 from
  16794. http://svn.asterisk.org/svn/asterisk/branches/12
  16795. 2013-08-27 19:19 +0000 [r397820] David M. Lee <dlee@digium.com>
  16796. * rest-api-templates/param_parsing.mustache, res/res_ari_bridges.c,
  16797. /, res/stasis/app.c, res/res_ari_events.c,
  16798. res/res_ari_asterisk.c,
  16799. rest-api-templates/res_ari_resource.c.mustache, res/stasis/app.h,
  16800. res/res_stasis.c, main/stasis_bridges.c: ARI: WebSocket event
  16801. cleanup Stasis events (which get distributed over the ARI
  16802. WebSocket) are created by subscribing to the channel_all_cached
  16803. and bridge_all_cached topics, filtering out events for
  16804. channels/bridges currently subscribed to. There are two issues
  16805. with that. First was a race condition, where messages in-flight
  16806. to the master subscribe-to-all-things topic would get sent out,
  16807. even though the events happened before the channel was put into
  16808. Stasis. Secondly, as the number of channels and bridges grow in
  16809. the system, the work spent filtering messages becomes excessive.
  16810. Since r395954, individual channels and bridges have caching
  16811. topics, and can be subscribed to individually. This patch takes
  16812. advantage, so that channels and bridges are subscribed to on
  16813. demand, instead of filtering the global topics. The one case
  16814. where filtering is still required is handling BridgeMerge
  16815. messages, which are published directly to the bridge_all topic.
  16816. Other than the change to how subscriptions work, this patch
  16817. mostly just moves code around. Most of the work generating JSON
  16818. objects from messages was moved to .to_json handlers on the
  16819. message types. The callback functions handling app subscriptions
  16820. were moved from res_stasis (b/c they were global to the model) to
  16821. stasis/app.c (b/c they are local to the app now). (closes issue
  16822. ASTERISK-21969) Reported by: Matt Jordan Review:
  16823. https://reviewboard.asterisk.org/r/2754/ ........ Merged
  16824. revisions 397816 from
  16825. http://svn.asterisk.org/svn/asterisk/branches/12
  16826. 2013-08-27 18:52 +0000 [r397811] Richard Mudgett <rmudgett@digium.com>
  16827. * /, main/astmm.c: Made MALLOC_DEBUG less CPU intensive by default.
  16828. Storing a backtrace for each allocation in anticipation of a
  16829. memory management problem is very CPU intensive. * Added the CLI
  16830. "memory backtrace {on|off}" command to request that the backtrace
  16831. be gathered only on request. The backtrace is off by default.
  16832. (issue ASTERISK-22221) Reported by: Matt Jordan ........ Merged
  16833. revisions 397809 from
  16834. http://svn.asterisk.org/svn/asterisk/branches/12
  16835. 2013-08-27 18:10 +0000 [r397753-397760] Matthew Jordan <mjordan@digium.com>
  16836. * /, channels/chan_sip.c: AST-2013-005: Fix crash caused by invalid
  16837. SDP If the SIP channel driver processes an invalid SDP that
  16838. defines media descriptions before connection information, it may
  16839. attempt to reference the socket address information even though
  16840. that information has not yet been set. This will cause a crash.
  16841. This patch adds checks when handling the various media
  16842. descriptions that ensures the media descriptions are handled only
  16843. if we have connection information suitable for that media. Thanks
  16844. to Walter Doekes, OSSO B.V., for reporting, testing, and
  16845. providing the solution to this problem. (closes issue
  16846. ASTERISK-22007) Reported by: wdoekes Tested by: wdoekes patches:
  16847. issueA22007_sdp_without_c_death.patch uploaded by wdoekes
  16848. (License 5674) ........ Merged revisions 397756 from
  16849. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16850. revisions 397757 from
  16851. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  16852. revisions 397758 from
  16853. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16854. revisions 397759 from
  16855. http://svn.asterisk.org/svn/asterisk/branches/12
  16856. * /, channels/chan_sip.c: AST-2013-004: Fix crash when handling ACK
  16857. on dialog that has no channel A remote exploitable crash
  16858. vulnerability exists in the SIP channel driver if an ACK with SDP
  16859. is received after the channel has been terminated. The handling
  16860. code incorrectly assumed that the channel would always be
  16861. present. This patch adds a check such that the SDP will only be
  16862. parsed and applied if Asterisk has a channel present that is
  16863. associated with the dialog. Note that the patch being applied was
  16864. modified only slightly from the patch provided by Walter Doekes
  16865. of OSSO B.V. (closes issue ASTERISK-21064) Reported by: Colin
  16866. Cuthbertson Tested by: wdoekes, Colin Cutherbertson patches:
  16867. issueA21064_fix.patch uploaded by wdoekes (License 5674) ........
  16868. Merged revisions 397710 from
  16869. http://svn.asterisk.org/svn/asterisk/branches/1.8 ........ Merged
  16870. revisions 397711 from
  16871. http://svn.asterisk.org/svn/asterisk/branches/10 ........ Merged
  16872. revisions 397712 from
  16873. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16874. revisions 397713 from
  16875. http://svn.asterisk.org/svn/asterisk/branches/12
  16876. 2013-08-27 16:51 +0000 [r397746] Richard Mudgett <rmudgett@digium.com>
  16877. * channels/chan_iax2.c, channels/sig_pri.c, channels/sig_ss7.c,
  16878. channels/chan_dahdi.c, channels/sig_analog.c, /,
  16879. channels/chan_sip.c, channels/chan_motif.c: Fix uninitialized
  16880. value in struct ast_control_pvt_cause_code usage. ........ Merged
  16881. revisions 397744 from
  16882. http://svn.asterisk.org/svn/asterisk/branches/11 ........ Merged
  16883. revisions 397745 from
  16884. http://svn.asterisk.org/svn/asterisk/branches/12
  16885. 2013-08-26 23:48 +0000 [r397691] Matthew Jordan <mjordan@digium.com>
  16886. * /, main/bridge_channel.c: Better handle clearing the OUTGOING
  16887. flag when a channel leaves a bridge When a channel with the
  16888. OUTGOING flag leaves a bridge, and it will survive being pulled
  16889. from the bridge (either because it will execute dialplan, go into
  16890. another bridge, or live in a friendly autoloop), we have to clear
  16891. the OUTGOING flag. This is the signal to the CDR engine that this
  16892. channel is no longer a second class citizen, i.e., it is not
  16893. "dialed". The soft hangup flags are only half the picture. If a
  16894. channel is being moved from one bridge to another, the soft
  16895. hangup flags aren't set; however, the state of the bridge_channel
  16896. will not be hung up. Since the channel does not have one of the
  16897. two hang up states, that implies that the channel is still
  16898. technically alive. This patch modifies the check so that it
  16899. checks both the soft hangup flags as well as the bridge_channel
  16900. state. If either suggests that the channel is going to persist,
  16901. we clear the OUTGOING flag. ........ Merged revisions 397690 from
  16902. http://svn.asterisk.org/svn/asterisk/branches/12
  16903. 2013-08-26 21:32 +0000 [r397674] David M. Lee <dlee@digium.com>
  16904. * /, main/bucket.c: Fixed bucket.c for systems where tv_usec is not
  16905. an unsigned long. ........ Merged revisions 397673 from
  16906. http://svn.asterisk.org/svn/asterisk/branches/12
  16907. 2013-08-26 16:25 +0000 [r397644-397651] Richard Mudgett <rmudgett@digium.com>
  16908. * /, include/asterisk/bridge_channel.h, main/bridge_channel.c:
  16909. bridging: Fix a livelock with local channel optimization. Use a
  16910. better means of waking up the bridge channel thread. ........
  16911. Merged revisions 397650 from
  16912. http://svn.asterisk.org/svn/asterisk/branches/12
  16913. * channels/Makefile, /: chan_dahdi: Add some missing build cleanup.
  16914. ........ Merged revisions 397643 from
  16915. http://svn.asterisk.org/svn/asterisk/branches/12
  16916. 2013-08-25 18:12 +0000 [r397622-397631] Matthew Jordan <mjordan@digium.com>
  16917. * tests/test_bucket.c, /: Fix bucket unit tests After the review
  16918. for buckets was completed (r2715), the handling of names in the
  16919. bucket core was deferred to the wizards. As such, the bucket unit
  16920. tests cannot expect that passing a URI with a scheme specified
  16921. but no actual resource name will automatically fail. The tests
  16922. have been updated to not make this check. ........ Merged
  16923. revisions 397630 from
  16924. http://svn.asterisk.org/svn/asterisk/branches/12
  16925. * include/asterisk/config_options.h, /, main/config_options.c,
  16926. tests/test_config.c: Fix the config_options_test The config
  16927. options test requires the entire configuration item to be
  16928. transparent from the documentation system. So we let it do that
  16929. too. As an aside, please do not use this power for evil.
  16930. Documentation is your friend, and you really should document your
  16931. configurations. Hiding your module's configuration information
  16932. from the system attempting to enforce some sanity in the universe
  16933. is something only a Bond villain would contemplate. ........
  16934. Merged revisions 397628 from
  16935. http://svn.asterisk.org/svn/asterisk/branches/12
  16936. * /, res/res_pjsip/pjsip_configuration.c: Add rtpengine
  16937. configuration parameter The rtpengine configuration parameter was
  16938. documented in the XML documentation, but it was not actually
  16939. registered with the sorcery object. This adds the parameter with
  16940. a default of "asterisk", such that res_rtp_asterisk is chosen as
  16941. the default RTP implementation. (closes issue ASTERISK-22380)
  16942. Reported by: Rusty Newton Tested by: Rusty Newton ........ Merged
  16943. revisions 397621 from
  16944. http://svn.asterisk.org/svn/asterisk/branches/12
  16945. 2013-08-23 22:40 +0000 [r397615] Matthew Jordan <mjordan@digium.com>
  16946. * /: Set new merge properties on 12
  16947. 2013-08-23 22:20 +0000 [r397613] Joshua Colp <jcolp@digium.com>
  16948. * main/bucket.c: Fix building of trunk. Note: This is why I commit
  16949. on the weekend.