#12 lps_gen.py: Update the timeslot regex to make the name optional

Closed
mmu_man wants to merge 1 commits from mmu_man/timeslot_re into rsd/master
mmu_man commented 6 years ago

This seems to fix the ical generation.

This seems to fix the ical generation.

@mmu_man, Thanks for the patch!

Looking at the current year's program, the time slots that have a description are separated from the time interval by a -. Would it be possible to modify the time slot regex to accommodate this too?

Something like this:

self.timeslot_re = re.compile(r'(\d+:\d+).+?(\d+:\d+)'
                              r'\s*[:-]?\s*(.+\b)?')

will work.

@mmu_man, Thanks for the patch! Looking at the [current year's program](https://www.libreplanet.org/2018/program/), the time slots that have a description are separated from the time interval by a `-`. Would it be possible to modify the time slot regex to accommodate this too? Something like this: ```python self.timeslot_re = re.compile(r'(\d+:\d+).+?(\d+:\d+)' r'\s*[:-]?\s*(.+\b)?') ``` will work.
mmu_man commented 6 years ago
Poster

The current regex will match anyway, but will eat the - as part of the name field, which is not used. Yeah the one you propose should work.

The current regex will match anyway, but will eat the - as part of the name field, which is not used. Yeah the one you propose should work.

@mmu_man, Merged your patch and made some minor tweaks. Thanks again!

@mmu_man, Merged [your patch](commit/8f83f1b38c108615e39c697c08f2172b8cafd8f8) and made some minor tweaks. Thanks again!
Please reopen this pull request to perform merge operation.
Sign in to join this conversation.
No Milestone
2 Participants
Loading...
Cancel
Save
There is no content yet.