01-fix-configure-ac.diff 4.6 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177
  1. From: Yann E. MORIN <yann.morin.1998@free.fr>
  2. Subject: [PATCH 1/2] configure.ac + Makefile.am: fix the imlib2 detection
  3. Although imlib2 is correctly checked for, the variables used to get
  4. the CFLAGS and LIBS are wrong (perhaps a remnant of the pre-imlib2
  5. era, when giblib was using imlib).
  6. Fix some iunder-quoting in configure.ac.
  7. Remove legacy configure.in.
  8. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
  9. ---
  10. configure.ac | 22 ++++++++--------------
  11. configure.in | 51 ---------------------------------------------------
  12. giblib-config.in | 4 ++--
  13. giblib.pc.in | 4 ++--
  14. giblib/Makefile.am | 4 ++--
  15. 5 files changed, 14 insertions(+), 71 deletions(-)
  16. diff --git a/configure.ac b/configure.ac
  17. index 6807d86..eef29fd 100644
  18. --- a/configure.ac
  19. +++ b/configure.ac
  20. @@ -2,8 +2,8 @@ dnl Process this file with autoconf to produce a configure script.
  21. AC_INIT
  22. AC_CONFIG_SRCDIR([giblib/gib_list.c])
  23. -AM_CONFIG_HEADER(giblib/giblib_config.h)
  24. -AM_INIT_AUTOMAKE(giblib, 1.2.4, no-define)
  25. +AM_CONFIG_HEADER([giblib/giblib_config.h])
  26. +AM_INIT_AUTOMAKE([giblib], [1.2.4], [no-define])
  27. AC_ISC_POSIX
  28. AC_PROG_CC
  29. @@ -17,16 +17,10 @@ AM_SANITY_CHECK
  30. AM_MAINTAINER_MODE
  31. AM_WITH_DMALLOC
  32. -AC_PATH_GENERIC(imlib2, 1.0.0, [
  33. - AC_SUBST(IMLIB_LIBS)
  34. - AC_SUBST(IMLIB_CFLAGS) ],
  35. - AC_MSG_ERROR(Cannot find imlib2: Is imlib2-config in the path?) )
  36. -
  37. -dnl the above doesn't work for some reason :/
  38. -IMLIB_LIBS=`imlib2-config --libs`
  39. -IMLIB_CFLAGS=`imlib2-config --cflags`
  40. -AC_SUBST(IMLIB_LIBS)
  41. -AC_SUBST(IMLIB_CFLAGS)
  42. +AC_PATH_GENERIC([imlib2], [1.0.0], [
  43. + AC_SUBST([IMLIB2_LIBS])
  44. + AC_SUBST([IMLIB2_CFLAGS]) ],
  45. + [AC_MSG_ERROR([Cannot find imlib2: Is imlib2-config in the path?])])
  46. LIBS="$LIBS -lm"
  47. CFLAGS="$CFLAGS -Wall"
  48. @@ -48,7 +42,7 @@ $PACKAGE $VERSION
  49. Configuration:
  50. --------------
  51. -Imlib2 libs: $IMLIB_LIBS
  52. -Imlib2 cflags: $IMLIB_CFLAGS
  53. +Imlib2 libs: $IMLIB2_LIBS
  54. +Imlib2 cflags: $IMLIB2_CFLAGS
  55. CFLAGS: $CFLAGS
  56. "
  57. diff --git a/configure.in b/configure.in
  58. deleted file mode 100644
  59. index 432cb16..0000000
  60. --- a/configure.in
  61. +++ /dev/null
  62. @@ -1,51 +0,0 @@
  63. -dnl Process this file with autoconf to produce a configure script.
  64. -
  65. -AC_INIT(giblib/gib_list.c)
  66. -AM_INIT_AUTOMAKE(giblib, 1.2.4, no-define)
  67. -AM_CONFIG_HEADER(giblib/giblib_config.h)
  68. -
  69. -AC_ISC_POSIX
  70. -AC_PROG_CC
  71. -AM_PROG_CC_STDC
  72. -AC_HEADER_STDC
  73. -AM_PROG_LIBTOOL
  74. -AC_PROG_INSTALL
  75. -AC_PROG_MAKE_SET
  76. -AM_SANITY_CHECK
  77. -
  78. -AM_MAINTAINER_MODE
  79. -AM_WITH_DMALLOC
  80. -
  81. -AC_PATH_GENERIC(imlib2, 1.0.0, [
  82. - AC_SUBST(IMLIB_LIBS)
  83. - AC_SUBST(IMLIB_CFLAGS) ],
  84. - AC_MSG_ERROR(Cannot find imlib2: Is imlib2-config in the path?) )
  85. -
  86. -dnl the above doesn't work for some reason :/
  87. -IMLIB_LIBS=`imlib2-config --libs`
  88. -IMLIB_CFLAGS=`imlib2-config --cflags`
  89. -AC_SUBST(IMLIB_LIBS)
  90. -AC_SUBST(IMLIB_CFLAGS)
  91. -
  92. -LIBS="$LIBS -lm"
  93. -CFLAGS="$CFLAGS -Wall"
  94. -
  95. -
  96. -AC_OUTPUT([
  97. -Makefile
  98. -giblib-config
  99. -giblib.pc
  100. -giblib/Makefile
  101. -], [
  102. -chmod +x giblib-config
  103. -])
  104. -
  105. -echo "
  106. -$PACKAGE $VERSION
  107. -Configuration:
  108. ---------------
  109. -
  110. -Imlib2 libs: $IMLIB_LIBS
  111. -Imlib2 cflags: $IMLIB_CFLAGS
  112. -CFLAGS: $CFLAGS
  113. -"
  114. diff --git a/giblib-config.in b/giblib-config.in
  115. index f3a7db6..cef1620 100644
  116. --- a/giblib-config.in
  117. +++ b/giblib-config.in
  118. @@ -42,11 +42,11 @@ while test $# -gt 0; do
  119. if test @includedir@ != /usr/include ; then
  120. includes=-I@includedir@
  121. fi
  122. - echo $includes -I$prefix/include/giblib @IMLIB_CFLAGS@
  123. + echo $includes -I$prefix/include/giblib @IMLIB2_CFLAGS@
  124. ;;
  125. --libs)
  126. libdirs=-L@libdir@
  127. - echo $libdirs -lgiblib @LDFLAGS@ @IMLIB_LIBS@
  128. + echo $libdirs -lgiblib @LDFLAGS@ @IMLIB2_LIBS@
  129. ;;
  130. *)
  131. echo "${usage}" 1>&2
  132. diff --git a/giblib.pc.in b/giblib.pc.in
  133. index df520ae..783e6e1 100644
  134. --- a/giblib.pc.in
  135. +++ b/giblib.pc.in
  136. @@ -6,6 +6,6 @@ includedir=@includedir@
  137. Name: giblib
  138. Description: wrapper library for imlib2, and other stuff
  139. Version: @VERSION@
  140. -Libs: -L${libdir} -lgiblib @LDFLAGS@ @IMLIB_LIBS@
  141. -Cflags: -I${includedir} -I${includedir}/giblib @IMLIB_CFLAGS@
  142. +Libs: -L${libdir} -lgiblib @LDFLAGS@ @IMLIB2_LIBS@
  143. +Cflags: -I${includedir} -I${includedir}/giblib @IMLIB2_CFLAGS@
  144. diff --git a/giblib/Makefile.am b/giblib/Makefile.am
  145. index d1edc09..49d8ac4 100644
  146. --- a/giblib/Makefile.am
  147. +++ b/giblib/Makefile.am
  148. @@ -3,7 +3,7 @@ MAINTAINERCLEANFILES = Makefile.in
  149. INCLUDES = \
  150. -I. -I$(top_srcdir) \
  151. --DPREFIX=\""$(prefix)"\" @IMLIB_CFLAGS@
  152. +-DPREFIX=\""$(prefix)"\" @IMLIB2_CFLAGS@
  153. lib_LTLIBRARIES = libgiblib.la
  154. @@ -24,7 +24,7 @@ libgiblib_la_SOURCES = \
  155. gib_utils.c gib_utils.h \
  156. gib_queue.c gib_queue.h
  157. -libgiblib_la_LIBADD = @IMLIB_LIBS@
  158. +libgiblib_la_LIBADD = @IMLIB2_LIBS@
  159. libgiblib_la_DEPENDENCIES = giblib_config.h
  160. libgiblib_la_LDFLAGS = -version-info 1:6:0