#4 Suggestion: White toolbar icon + setting

Closed
opened 4 years ago by fireglow · 2 comments
fireglow commented 4 years ago

The extensions icon on the toolbar is hard to make out on dark themes. (see attached sceenshot)

It would be nice if there was a setting to choose between a black or a white icon.

Example in FixedZoom: https://github.com/Enchufadoo/fixedzoom/blob/master/background.js#L122

The extensions icon on the toolbar is hard to make out on dark themes. (see attached sceenshot) It would be nice if there was a setting to choose between a black or a white icon. Example in FixedZoom: https://github.com/Enchufadoo/fixedzoom/blob/master/background.js#L122
Niklas Poslovski commented 4 years ago
Owner

Thank you for reporting this problem. It will be fixed with the next release. I'll do some research if it's possible to change the icon color automatically depending on the theme. If not,I'll add a switch to the settings as you suggested.

Thank you for reporting this problem. It will be fixed with the next release. I'll do some research if it's possible to change the icon color automatically depending on the theme. If not,I'll add a switch to the settings as you suggested.
Niklas Poslovski commented 4 years ago
Owner

I fixed it now by defining theme_icons in the manifest.json as described here: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_action Unfortunately these changes will only take effect on Firefox dark themes and not on the operating system dark theme but that is a limitation/bug of Firefox and I can't do anything about it (Tested in version 66). The fix will go online with the next release.

I fixed it now by defining theme_icons in the manifest.json as described here: https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_action Unfortunately these changes will only take effect on Firefox dark themes and not on the operating system dark theme but that is a limitation/bug of Firefox and I can't do anything about it (Tested in version 66). The fix will go online with the next release.
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.