addr.c 33 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273747576777879808182838485868788899091929394959697989910010110210310410510610710810911011111211311411511611711811912012112212312412512612712812913013113213313413513613713813914014114214314414514614714814915015115215315415515615715815916016116216316416516616716816917017117217317417517617717817918018118218318418518618718818919019119219319419519619719819920020120220320420520620720820921021121221321421521621721821922022122222322422522622722822923023123223323423523623723823924024124224324424524624724824925025125225325425525625725825926026126226326426526626726826927027127227327427527627727827928028128228328428528628728828929029129229329429529629729829930030130230330430530630730830931031131231331431531631731831932032132232332432532632732832933033133233333433533633733833934034134234334434534634734834935035135235335435535635735835936036136236336436536636736836937037137237337437537637737837938038138238338438538638738838939039139239339439539639739839940040140240340440540640740840941041141241341441541641741841942042142242342442542642742842943043143243343443543643743843944044144244344444544644744844945045145245345445545645745845946046146246346446546646746846947047147247347447547647747847948048148248348448548648748848949049149249349449549649749849950050150250350450550650750850951051151251351451551651751851952052152252352452552652752852953053153253353453553653753853954054154254354454554654754854955055155255355455555655755855956056156256356456556656756856957057157257357457557657757857958058158258358458558658758858959059159259359459559659759859960060160260360460560660760860961061161261361461561661761861962062162262362462562662762862963063163263363463563663763863964064164264364464564664764864965065165265365465565665765865966066166266366466566666766866967067167267367467567667767867968068168268368468568668768868969069169269369469569669769869970070170270370470570670770870971071171271371471571671771871972072172272372472572672772872973073173273373473573673773873974074174274374474574674774874975075175275375475575675775875976076176276376476576676776876977077177277377477577677777877978078178278378478578678778878979079179279379479579679779879980080180280380480580680780880981081181281381481581681781881982082182282382482582682782882983083183283383483583683783883984084184284384484584684784884985085185285385485585685785885986086186286386486586686786886987087187287387487587687787887988088188288388488588688788888989089189289389489589689789889990090190290390490590690790890991091191291391491591691791891992092192292392492592692792892993093193293393493593693793893994094194294394494594694794894995095195295395495595695795895996096196296396496596696796896997097197297397497597697797897998098198298398498598698798898999099199299399499599699799899910001001100210031004100510061007100810091010101110121013101410151016101710181019102010211022102310241025102610271028102910301031103210331034103510361037103810391040104110421043104410451046104710481049105010511052105310541055105610571058105910601061106210631064106510661067106810691070107110721073107410751076107710781079108010811082108310841085108610871088108910901091109210931094109510961097109810991100110111021103110411051106110711081109111011111112111311141115111611171118111911201121112211231124112511261127112811291130113111321133113411351136113711381139114011411142114311441145114611471148114911501151115211531154115511561157115811591160116111621163116411651166116711681169117011711172117311741175117611771178117911801181118211831184118511861187118811891190119111921193119411951196119711981199120012011202120312041205120612071208120912101211121212131214121512161217121812191220122112221223122412251226122712281229123012311232123312341235123612371238123912401241124212431244124512461247124812491250
  1. #include <linux/ceph/ceph_debug.h>
  2. #include <linux/backing-dev.h>
  3. #include <linux/fs.h>
  4. #include <linux/mm.h>
  5. #include <linux/pagemap.h>
  6. #include <linux/writeback.h> /* generic_writepages */
  7. #include <linux/slab.h>
  8. #include <linux/pagevec.h>
  9. #include <linux/task_io_accounting_ops.h>
  10. #include "super.h"
  11. #include "mds_client.h"
  12. #include <linux/ceph/osd_client.h>
  13. /*
  14. * Ceph address space ops.
  15. *
  16. * There are a few funny things going on here.
  17. *
  18. * The page->private field is used to reference a struct
  19. * ceph_snap_context for _every_ dirty page. This indicates which
  20. * snapshot the page was logically dirtied in, and thus which snap
  21. * context needs to be associated with the osd write during writeback.
  22. *
  23. * Similarly, struct ceph_inode_info maintains a set of counters to
  24. * count dirty pages on the inode. In the absence of snapshots,
  25. * i_wrbuffer_ref == i_wrbuffer_ref_head == the dirty page count.
  26. *
  27. * When a snapshot is taken (that is, when the client receives
  28. * notification that a snapshot was taken), each inode with caps and
  29. * with dirty pages (dirty pages implies there is a cap) gets a new
  30. * ceph_cap_snap in the i_cap_snaps list (which is sorted in ascending
  31. * order, new snaps go to the tail). The i_wrbuffer_ref_head count is
  32. * moved to capsnap->dirty. (Unless a sync write is currently in
  33. * progress. In that case, the capsnap is said to be "pending", new
  34. * writes cannot start, and the capsnap isn't "finalized" until the
  35. * write completes (or fails) and a final size/mtime for the inode for
  36. * that snap can be settled upon.) i_wrbuffer_ref_head is reset to 0.
  37. *
  38. * On writeback, we must submit writes to the osd IN SNAP ORDER. So,
  39. * we look for the first capsnap in i_cap_snaps and write out pages in
  40. * that snap context _only_. Then we move on to the next capsnap,
  41. * eventually reaching the "live" or "head" context (i.e., pages that
  42. * are not yet snapped) and are writing the most recently dirtied
  43. * pages.
  44. *
  45. * Invalidate and so forth must take care to ensure the dirty page
  46. * accounting is preserved.
  47. */
  48. #define CONGESTION_ON_THRESH(congestion_kb) (congestion_kb >> (PAGE_SHIFT-10))
  49. #define CONGESTION_OFF_THRESH(congestion_kb) \
  50. (CONGESTION_ON_THRESH(congestion_kb) - \
  51. (CONGESTION_ON_THRESH(congestion_kb) >> 2))
  52. static inline struct ceph_snap_context *page_snap_context(struct page *page)
  53. {
  54. if (PagePrivate(page))
  55. return (void *)page->private;
  56. return NULL;
  57. }
  58. /*
  59. * Dirty a page. Optimistically adjust accounting, on the assumption
  60. * that we won't race with invalidate. If we do, readjust.
  61. */
  62. static int ceph_set_page_dirty(struct page *page)
  63. {
  64. struct address_space *mapping = page->mapping;
  65. struct inode *inode;
  66. struct ceph_inode_info *ci;
  67. int undo = 0;
  68. struct ceph_snap_context *snapc;
  69. if (unlikely(!mapping))
  70. return !TestSetPageDirty(page);
  71. if (TestSetPageDirty(page)) {
  72. dout("%p set_page_dirty %p idx %lu -- already dirty\n",
  73. mapping->host, page, page->index);
  74. return 0;
  75. }
  76. inode = mapping->host;
  77. ci = ceph_inode(inode);
  78. /*
  79. * Note that we're grabbing a snapc ref here without holding
  80. * any locks!
  81. */
  82. snapc = ceph_get_snap_context(ci->i_snap_realm->cached_context);
  83. /* dirty the head */
  84. spin_lock(&ci->i_ceph_lock);
  85. if (ci->i_head_snapc == NULL)
  86. ci->i_head_snapc = ceph_get_snap_context(snapc);
  87. ++ci->i_wrbuffer_ref_head;
  88. if (ci->i_wrbuffer_ref == 0)
  89. ihold(inode);
  90. ++ci->i_wrbuffer_ref;
  91. dout("%p set_page_dirty %p idx %lu head %d/%d -> %d/%d "
  92. "snapc %p seq %lld (%d snaps)\n",
  93. mapping->host, page, page->index,
  94. ci->i_wrbuffer_ref-1, ci->i_wrbuffer_ref_head-1,
  95. ci->i_wrbuffer_ref, ci->i_wrbuffer_ref_head,
  96. snapc, snapc->seq, snapc->num_snaps);
  97. spin_unlock(&ci->i_ceph_lock);
  98. /* now adjust page */
  99. spin_lock_irq(&mapping->tree_lock);
  100. if (page->mapping) { /* Race with truncate? */
  101. WARN_ON_ONCE(!PageUptodate(page));
  102. account_page_dirtied(page, page->mapping);
  103. radix_tree_tag_set(&mapping->page_tree,
  104. page_index(page), PAGECACHE_TAG_DIRTY);
  105. /*
  106. * Reference snap context in page->private. Also set
  107. * PagePrivate so that we get invalidatepage callback.
  108. */
  109. page->private = (unsigned long)snapc;
  110. SetPagePrivate(page);
  111. } else {
  112. dout("ANON set_page_dirty %p (raced truncate?)\n", page);
  113. undo = 1;
  114. }
  115. spin_unlock_irq(&mapping->tree_lock);
  116. if (undo)
  117. /* whoops, we failed to dirty the page */
  118. ceph_put_wrbuffer_cap_refs(ci, 1, snapc);
  119. __mark_inode_dirty(mapping->host, I_DIRTY_PAGES);
  120. BUG_ON(!PageDirty(page));
  121. return 1;
  122. }
  123. /*
  124. * If we are truncating the full page (i.e. offset == 0), adjust the
  125. * dirty page counters appropriately. Only called if there is private
  126. * data on the page.
  127. */
  128. static void ceph_invalidatepage(struct page *page, unsigned long offset)
  129. {
  130. struct inode *inode;
  131. struct ceph_inode_info *ci;
  132. struct ceph_snap_context *snapc = page_snap_context(page);
  133. BUG_ON(!PageLocked(page));
  134. BUG_ON(!PagePrivate(page));
  135. BUG_ON(!page->mapping);
  136. inode = page->mapping->host;
  137. /*
  138. * We can get non-dirty pages here due to races between
  139. * set_page_dirty and truncate_complete_page; just spit out a
  140. * warning, in case we end up with accounting problems later.
  141. */
  142. if (!PageDirty(page))
  143. pr_err("%p invalidatepage %p page not dirty\n", inode, page);
  144. if (offset == 0)
  145. ClearPageChecked(page);
  146. ci = ceph_inode(inode);
  147. if (offset == 0) {
  148. dout("%p invalidatepage %p idx %lu full dirty page %lu\n",
  149. inode, page, page->index, offset);
  150. ceph_put_wrbuffer_cap_refs(ci, 1, snapc);
  151. ceph_put_snap_context(snapc);
  152. page->private = 0;
  153. ClearPagePrivate(page);
  154. } else {
  155. dout("%p invalidatepage %p idx %lu partial dirty page\n",
  156. inode, page, page->index);
  157. }
  158. }
  159. /* just a sanity check */
  160. static int ceph_releasepage(struct page *page, gfp_t g)
  161. {
  162. struct inode *inode = page->mapping ? page->mapping->host : NULL;
  163. dout("%p releasepage %p idx %lu\n", inode, page, page->index);
  164. WARN_ON(PageDirty(page));
  165. WARN_ON(PagePrivate(page));
  166. return 0;
  167. }
  168. /*
  169. * read a single page, without unlocking it.
  170. */
  171. static int readpage_nounlock(struct file *filp, struct page *page)
  172. {
  173. struct inode *inode = filp->f_dentry->d_inode;
  174. struct ceph_inode_info *ci = ceph_inode(inode);
  175. struct ceph_osd_client *osdc =
  176. &ceph_inode_to_client(inode)->client->osdc;
  177. int err = 0;
  178. u64 len = PAGE_CACHE_SIZE;
  179. dout("readpage inode %p file %p page %p index %lu\n",
  180. inode, filp, page, page->index);
  181. err = ceph_osdc_readpages(osdc, ceph_vino(inode), &ci->i_layout,
  182. (u64) page_offset(page), &len,
  183. ci->i_truncate_seq, ci->i_truncate_size,
  184. &page, 1, 0);
  185. if (err == -ENOENT)
  186. err = 0;
  187. if (err < 0) {
  188. SetPageError(page);
  189. goto out;
  190. } else {
  191. if (err < PAGE_CACHE_SIZE) {
  192. /* zero fill remainder of page */
  193. zero_user_segment(page, err, PAGE_CACHE_SIZE);
  194. } else {
  195. flush_dcache_page(page);
  196. }
  197. }
  198. SetPageUptodate(page);
  199. out:
  200. return err < 0 ? err : 0;
  201. }
  202. static int ceph_readpage(struct file *filp, struct page *page)
  203. {
  204. int r = readpage_nounlock(filp, page);
  205. unlock_page(page);
  206. return r;
  207. }
  208. /*
  209. * Finish an async read(ahead) op.
  210. */
  211. static void finish_read(struct ceph_osd_request *req, struct ceph_msg *msg)
  212. {
  213. struct inode *inode = req->r_inode;
  214. struct ceph_osd_reply_head *replyhead;
  215. int rc, bytes;
  216. int i;
  217. /* parse reply */
  218. replyhead = msg->front.iov_base;
  219. WARN_ON(le32_to_cpu(replyhead->num_ops) == 0);
  220. rc = le32_to_cpu(replyhead->result);
  221. bytes = le32_to_cpu(msg->hdr.data_len);
  222. dout("finish_read %p req %p rc %d bytes %d\n", inode, req, rc, bytes);
  223. /* unlock all pages, zeroing any data we didn't read */
  224. for (i = 0; i < req->r_num_pages; i++, bytes -= PAGE_CACHE_SIZE) {
  225. struct page *page = req->r_pages[i];
  226. if (bytes < (int)PAGE_CACHE_SIZE) {
  227. /* zero (remainder of) page */
  228. int s = bytes < 0 ? 0 : bytes;
  229. zero_user_segment(page, s, PAGE_CACHE_SIZE);
  230. }
  231. dout("finish_read %p uptodate %p idx %lu\n", inode, page,
  232. page->index);
  233. flush_dcache_page(page);
  234. SetPageUptodate(page);
  235. unlock_page(page);
  236. page_cache_release(page);
  237. }
  238. kfree(req->r_pages);
  239. }
  240. static void ceph_unlock_page_vector(struct page **pages, int num_pages)
  241. {
  242. int i;
  243. for (i = 0; i < num_pages; i++)
  244. unlock_page(pages[i]);
  245. }
  246. /*
  247. * start an async read(ahead) operation. return nr_pages we submitted
  248. * a read for on success, or negative error code.
  249. */
  250. static int start_read(struct inode *inode, struct list_head *page_list, int max)
  251. {
  252. struct ceph_osd_client *osdc =
  253. &ceph_inode_to_client(inode)->client->osdc;
  254. struct ceph_inode_info *ci = ceph_inode(inode);
  255. struct page *page = list_entry(page_list->prev, struct page, lru);
  256. struct ceph_osd_request *req;
  257. u64 off;
  258. u64 len;
  259. int i;
  260. struct page **pages;
  261. pgoff_t next_index;
  262. int nr_pages = 0;
  263. int ret;
  264. off = (u64) page_offset(page);
  265. /* count pages */
  266. next_index = page->index;
  267. list_for_each_entry_reverse(page, page_list, lru) {
  268. if (page->index != next_index)
  269. break;
  270. nr_pages++;
  271. next_index++;
  272. if (max && nr_pages == max)
  273. break;
  274. }
  275. len = nr_pages << PAGE_CACHE_SHIFT;
  276. dout("start_read %p nr_pages %d is %lld~%lld\n", inode, nr_pages,
  277. off, len);
  278. req = ceph_osdc_new_request(osdc, &ci->i_layout, ceph_vino(inode),
  279. off, &len,
  280. CEPH_OSD_OP_READ, CEPH_OSD_FLAG_READ,
  281. NULL, 0,
  282. ci->i_truncate_seq, ci->i_truncate_size,
  283. NULL, false, 1, 0);
  284. if (IS_ERR(req))
  285. return PTR_ERR(req);
  286. /* build page vector */
  287. nr_pages = len >> PAGE_CACHE_SHIFT;
  288. pages = kmalloc(sizeof(*pages) * nr_pages, GFP_NOFS);
  289. ret = -ENOMEM;
  290. if (!pages)
  291. goto out;
  292. for (i = 0; i < nr_pages; ++i) {
  293. page = list_entry(page_list->prev, struct page, lru);
  294. BUG_ON(PageLocked(page));
  295. list_del(&page->lru);
  296. dout("start_read %p adding %p idx %lu\n", inode, page,
  297. page->index);
  298. if (add_to_page_cache_lru(page, &inode->i_data, page->index,
  299. GFP_NOFS)) {
  300. page_cache_release(page);
  301. dout("start_read %p add_to_page_cache failed %p\n",
  302. inode, page);
  303. nr_pages = i;
  304. goto out_pages;
  305. }
  306. pages[i] = page;
  307. }
  308. req->r_pages = pages;
  309. req->r_num_pages = nr_pages;
  310. req->r_callback = finish_read;
  311. req->r_inode = inode;
  312. dout("start_read %p starting %p %lld~%lld\n", inode, req, off, len);
  313. ret = ceph_osdc_start_request(osdc, req, false);
  314. if (ret < 0)
  315. goto out_pages;
  316. ceph_osdc_put_request(req);
  317. return nr_pages;
  318. out_pages:
  319. ceph_unlock_page_vector(pages, nr_pages);
  320. ceph_release_page_vector(pages, nr_pages);
  321. out:
  322. ceph_osdc_put_request(req);
  323. return ret;
  324. }
  325. /*
  326. * Read multiple pages. Leave pages we don't read + unlock in page_list;
  327. * the caller (VM) cleans them up.
  328. */
  329. static int ceph_readpages(struct file *file, struct address_space *mapping,
  330. struct list_head *page_list, unsigned nr_pages)
  331. {
  332. struct inode *inode = file->f_dentry->d_inode;
  333. struct ceph_fs_client *fsc = ceph_inode_to_client(inode);
  334. int rc = 0;
  335. int max = 0;
  336. if (fsc->mount_options->rsize >= PAGE_CACHE_SIZE)
  337. max = (fsc->mount_options->rsize + PAGE_CACHE_SIZE - 1)
  338. >> PAGE_SHIFT;
  339. dout("readpages %p file %p nr_pages %d max %d\n", inode, file, nr_pages,
  340. max);
  341. while (!list_empty(page_list)) {
  342. rc = start_read(inode, page_list, max);
  343. if (rc < 0)
  344. goto out;
  345. BUG_ON(rc == 0);
  346. }
  347. out:
  348. dout("readpages %p file %p ret %d\n", inode, file, rc);
  349. return rc;
  350. }
  351. /*
  352. * Get ref for the oldest snapc for an inode with dirty data... that is, the
  353. * only snap context we are allowed to write back.
  354. */
  355. static struct ceph_snap_context *get_oldest_context(struct inode *inode,
  356. u64 *snap_size)
  357. {
  358. struct ceph_inode_info *ci = ceph_inode(inode);
  359. struct ceph_snap_context *snapc = NULL;
  360. struct ceph_cap_snap *capsnap = NULL;
  361. spin_lock(&ci->i_ceph_lock);
  362. list_for_each_entry(capsnap, &ci->i_cap_snaps, ci_item) {
  363. dout(" cap_snap %p snapc %p has %d dirty pages\n", capsnap,
  364. capsnap->context, capsnap->dirty_pages);
  365. if (capsnap->dirty_pages) {
  366. snapc = ceph_get_snap_context(capsnap->context);
  367. if (snap_size)
  368. *snap_size = capsnap->size;
  369. break;
  370. }
  371. }
  372. if (!snapc && ci->i_wrbuffer_ref_head) {
  373. snapc = ceph_get_snap_context(ci->i_head_snapc);
  374. dout(" head snapc %p has %d dirty pages\n",
  375. snapc, ci->i_wrbuffer_ref_head);
  376. }
  377. spin_unlock(&ci->i_ceph_lock);
  378. return snapc;
  379. }
  380. /*
  381. * Write a single page, but leave the page locked.
  382. *
  383. * If we get a write error, set the page error bit, but still adjust the
  384. * dirty page accounting (i.e., page is no longer dirty).
  385. */
  386. static int writepage_nounlock(struct page *page, struct writeback_control *wbc)
  387. {
  388. struct inode *inode;
  389. struct ceph_inode_info *ci;
  390. struct ceph_fs_client *fsc;
  391. struct ceph_osd_client *osdc;
  392. loff_t page_off = page_offset(page);
  393. int len = PAGE_CACHE_SIZE;
  394. loff_t i_size;
  395. int err = 0;
  396. struct ceph_snap_context *snapc, *oldest;
  397. u64 snap_size = 0;
  398. long writeback_stat;
  399. dout("writepage %p idx %lu\n", page, page->index);
  400. if (!page->mapping || !page->mapping->host) {
  401. dout("writepage %p - no mapping\n", page);
  402. return -EFAULT;
  403. }
  404. inode = page->mapping->host;
  405. ci = ceph_inode(inode);
  406. fsc = ceph_inode_to_client(inode);
  407. osdc = &fsc->client->osdc;
  408. /* verify this is a writeable snap context */
  409. snapc = page_snap_context(page);
  410. if (snapc == NULL) {
  411. dout("writepage %p page %p not dirty?\n", inode, page);
  412. goto out;
  413. }
  414. oldest = get_oldest_context(inode, &snap_size);
  415. if (snapc->seq > oldest->seq) {
  416. dout("writepage %p page %p snapc %p not writeable - noop\n",
  417. inode, page, snapc);
  418. /* we should only noop if called by kswapd */
  419. WARN_ON((current->flags & PF_MEMALLOC) == 0);
  420. ceph_put_snap_context(oldest);
  421. goto out;
  422. }
  423. ceph_put_snap_context(oldest);
  424. /* is this a partial page at end of file? */
  425. if (snap_size)
  426. i_size = snap_size;
  427. else
  428. i_size = i_size_read(inode);
  429. if (i_size < page_off + len)
  430. len = i_size - page_off;
  431. dout("writepage %p page %p index %lu on %llu~%u snapc %p\n",
  432. inode, page, page->index, page_off, len, snapc);
  433. writeback_stat = atomic_long_inc_return(&fsc->writeback_count);
  434. if (writeback_stat >
  435. CONGESTION_ON_THRESH(fsc->mount_options->congestion_kb))
  436. set_bdi_congested(&fsc->backing_dev_info, BLK_RW_ASYNC);
  437. set_page_writeback(page);
  438. err = ceph_osdc_writepages(osdc, ceph_vino(inode),
  439. &ci->i_layout, snapc,
  440. page_off, len,
  441. ci->i_truncate_seq, ci->i_truncate_size,
  442. &inode->i_mtime,
  443. &page, 1, 0, 0, true);
  444. if (err < 0) {
  445. dout("writepage setting page/mapping error %d %p\n", err, page);
  446. SetPageError(page);
  447. mapping_set_error(&inode->i_data, err);
  448. if (wbc)
  449. wbc->pages_skipped++;
  450. } else {
  451. dout("writepage cleaned page %p\n", page);
  452. err = 0; /* vfs expects us to return 0 */
  453. }
  454. page->private = 0;
  455. ClearPagePrivate(page);
  456. end_page_writeback(page);
  457. ceph_put_wrbuffer_cap_refs(ci, 1, snapc);
  458. ceph_put_snap_context(snapc); /* page's reference */
  459. out:
  460. return err;
  461. }
  462. static int ceph_writepage(struct page *page, struct writeback_control *wbc)
  463. {
  464. int err;
  465. struct inode *inode = page->mapping->host;
  466. BUG_ON(!inode);
  467. ihold(inode);
  468. err = writepage_nounlock(page, wbc);
  469. unlock_page(page);
  470. iput(inode);
  471. return err;
  472. }
  473. /*
  474. * lame release_pages helper. release_pages() isn't exported to
  475. * modules.
  476. */
  477. static void ceph_release_pages(struct page **pages, int num)
  478. {
  479. struct pagevec pvec;
  480. int i;
  481. pagevec_init(&pvec, 0);
  482. for (i = 0; i < num; i++) {
  483. if (pagevec_add(&pvec, pages[i]) == 0)
  484. pagevec_release(&pvec);
  485. }
  486. pagevec_release(&pvec);
  487. }
  488. /*
  489. * async writeback completion handler.
  490. *
  491. * If we get an error, set the mapping error bit, but not the individual
  492. * page error bits.
  493. */
  494. static void writepages_finish(struct ceph_osd_request *req,
  495. struct ceph_msg *msg)
  496. {
  497. struct inode *inode = req->r_inode;
  498. struct ceph_osd_reply_head *replyhead;
  499. struct ceph_osd_op *op;
  500. struct ceph_inode_info *ci = ceph_inode(inode);
  501. unsigned wrote;
  502. struct page *page;
  503. int i;
  504. struct ceph_snap_context *snapc = req->r_snapc;
  505. struct address_space *mapping = inode->i_mapping;
  506. __s32 rc = -EIO;
  507. u64 bytes = 0;
  508. struct ceph_fs_client *fsc = ceph_inode_to_client(inode);
  509. long writeback_stat;
  510. unsigned issued = ceph_caps_issued(ci);
  511. /* parse reply */
  512. replyhead = msg->front.iov_base;
  513. WARN_ON(le32_to_cpu(replyhead->num_ops) == 0);
  514. op = (void *)(replyhead + 1);
  515. rc = le32_to_cpu(replyhead->result);
  516. bytes = le64_to_cpu(op->extent.length);
  517. if (rc >= 0) {
  518. /*
  519. * Assume we wrote the pages we originally sent. The
  520. * osd might reply with fewer pages if our writeback
  521. * raced with a truncation and was adjusted at the osd,
  522. * so don't believe the reply.
  523. */
  524. wrote = req->r_num_pages;
  525. } else {
  526. wrote = 0;
  527. mapping_set_error(mapping, rc);
  528. }
  529. dout("writepages_finish %p rc %d bytes %llu wrote %d (pages)\n",
  530. inode, rc, bytes, wrote);
  531. /* clean all pages */
  532. for (i = 0; i < req->r_num_pages; i++) {
  533. page = req->r_pages[i];
  534. BUG_ON(!page);
  535. WARN_ON(!PageUptodate(page));
  536. writeback_stat =
  537. atomic_long_dec_return(&fsc->writeback_count);
  538. if (writeback_stat <
  539. CONGESTION_OFF_THRESH(fsc->mount_options->congestion_kb))
  540. clear_bdi_congested(&fsc->backing_dev_info,
  541. BLK_RW_ASYNC);
  542. ceph_put_snap_context(page_snap_context(page));
  543. page->private = 0;
  544. ClearPagePrivate(page);
  545. dout("unlocking %d %p\n", i, page);
  546. end_page_writeback(page);
  547. /*
  548. * We lost the cache cap, need to truncate the page before
  549. * it is unlocked, otherwise we'd truncate it later in the
  550. * page truncation thread, possibly losing some data that
  551. * raced its way in
  552. */
  553. if ((issued & (CEPH_CAP_FILE_CACHE|CEPH_CAP_FILE_LAZYIO)) == 0)
  554. generic_error_remove_page(inode->i_mapping, page);
  555. unlock_page(page);
  556. }
  557. dout("%p wrote+cleaned %d pages\n", inode, wrote);
  558. ceph_put_wrbuffer_cap_refs(ci, req->r_num_pages, snapc);
  559. ceph_release_pages(req->r_pages, req->r_num_pages);
  560. if (req->r_pages_from_pool)
  561. mempool_free(req->r_pages,
  562. ceph_sb_to_client(inode->i_sb)->wb_pagevec_pool);
  563. else
  564. kfree(req->r_pages);
  565. ceph_osdc_put_request(req);
  566. }
  567. /*
  568. * allocate a page vec, either directly, or if necessary, via a the
  569. * mempool. we avoid the mempool if we can because req->r_num_pages
  570. * may be less than the maximum write size.
  571. */
  572. static void alloc_page_vec(struct ceph_fs_client *fsc,
  573. struct ceph_osd_request *req)
  574. {
  575. req->r_pages = kmalloc(sizeof(struct page *) * req->r_num_pages,
  576. GFP_NOFS);
  577. if (!req->r_pages) {
  578. req->r_pages = mempool_alloc(fsc->wb_pagevec_pool, GFP_NOFS);
  579. req->r_pages_from_pool = 1;
  580. WARN_ON(!req->r_pages);
  581. }
  582. }
  583. /*
  584. * initiate async writeback
  585. */
  586. static int ceph_writepages_start(struct address_space *mapping,
  587. struct writeback_control *wbc)
  588. {
  589. struct inode *inode = mapping->host;
  590. struct ceph_inode_info *ci = ceph_inode(inode);
  591. struct ceph_fs_client *fsc;
  592. pgoff_t index, start, end;
  593. int range_whole = 0;
  594. int should_loop = 1;
  595. pgoff_t max_pages = 0, max_pages_ever = 0;
  596. struct ceph_snap_context *snapc = NULL, *last_snapc = NULL, *pgsnapc;
  597. struct pagevec pvec;
  598. int done = 0;
  599. int rc = 0;
  600. unsigned wsize = 1 << inode->i_blkbits;
  601. struct ceph_osd_request *req = NULL;
  602. int do_sync;
  603. u64 snap_size = 0;
  604. /*
  605. * Include a 'sync' in the OSD request if this is a data
  606. * integrity write (e.g., O_SYNC write or fsync()), or if our
  607. * cap is being revoked.
  608. */
  609. do_sync = wbc->sync_mode == WB_SYNC_ALL;
  610. if (ceph_caps_revoking(ci, CEPH_CAP_FILE_BUFFER))
  611. do_sync = 1;
  612. dout("writepages_start %p dosync=%d (mode=%s)\n",
  613. inode, do_sync,
  614. wbc->sync_mode == WB_SYNC_NONE ? "NONE" :
  615. (wbc->sync_mode == WB_SYNC_ALL ? "ALL" : "HOLD"));
  616. fsc = ceph_inode_to_client(inode);
  617. if (fsc->mount_state == CEPH_MOUNT_SHUTDOWN) {
  618. pr_warning("writepage_start %p on forced umount\n", inode);
  619. return -EIO; /* we're in a forced umount, don't write! */
  620. }
  621. if (fsc->mount_options->wsize && fsc->mount_options->wsize < wsize)
  622. wsize = fsc->mount_options->wsize;
  623. if (wsize < PAGE_CACHE_SIZE)
  624. wsize = PAGE_CACHE_SIZE;
  625. max_pages_ever = wsize >> PAGE_CACHE_SHIFT;
  626. pagevec_init(&pvec, 0);
  627. /* where to start/end? */
  628. if (wbc->range_cyclic) {
  629. start = mapping->writeback_index; /* Start from prev offset */
  630. end = -1;
  631. dout(" cyclic, start at %lu\n", start);
  632. } else {
  633. start = wbc->range_start >> PAGE_CACHE_SHIFT;
  634. end = wbc->range_end >> PAGE_CACHE_SHIFT;
  635. if (wbc->range_start == 0 && wbc->range_end == LLONG_MAX)
  636. range_whole = 1;
  637. should_loop = 0;
  638. dout(" not cyclic, %lu to %lu\n", start, end);
  639. }
  640. index = start;
  641. retry:
  642. /* find oldest snap context with dirty data */
  643. ceph_put_snap_context(snapc);
  644. snapc = get_oldest_context(inode, &snap_size);
  645. if (!snapc) {
  646. /* hmm, why does writepages get called when there
  647. is no dirty data? */
  648. dout(" no snap context with dirty data?\n");
  649. goto out;
  650. }
  651. dout(" oldest snapc is %p seq %lld (%d snaps)\n",
  652. snapc, snapc->seq, snapc->num_snaps);
  653. if (last_snapc && snapc != last_snapc) {
  654. /* if we switched to a newer snapc, restart our scan at the
  655. * start of the original file range. */
  656. dout(" snapc differs from last pass, restarting at %lu\n",
  657. index);
  658. index = start;
  659. }
  660. last_snapc = snapc;
  661. while (!done && index <= end) {
  662. unsigned i;
  663. int first;
  664. pgoff_t next;
  665. int pvec_pages, locked_pages;
  666. struct page *page;
  667. int want;
  668. u64 offset, len;
  669. struct ceph_osd_request_head *reqhead;
  670. struct ceph_osd_op *op;
  671. long writeback_stat;
  672. next = 0;
  673. locked_pages = 0;
  674. max_pages = max_pages_ever;
  675. get_more_pages:
  676. first = -1;
  677. want = min(end - index,
  678. min((pgoff_t)PAGEVEC_SIZE,
  679. max_pages - (pgoff_t)locked_pages) - 1)
  680. + 1;
  681. pvec_pages = pagevec_lookup_tag(&pvec, mapping, &index,
  682. PAGECACHE_TAG_DIRTY,
  683. want);
  684. dout("pagevec_lookup_tag got %d\n", pvec_pages);
  685. if (!pvec_pages && !locked_pages)
  686. break;
  687. for (i = 0; i < pvec_pages && locked_pages < max_pages; i++) {
  688. page = pvec.pages[i];
  689. dout("? %p idx %lu\n", page, page->index);
  690. if (locked_pages == 0)
  691. lock_page(page); /* first page */
  692. else if (!trylock_page(page))
  693. break;
  694. /* only dirty pages, or our accounting breaks */
  695. if (unlikely(!PageDirty(page)) ||
  696. unlikely(page->mapping != mapping)) {
  697. dout("!dirty or !mapping %p\n", page);
  698. unlock_page(page);
  699. break;
  700. }
  701. if (!wbc->range_cyclic && page->index > end) {
  702. dout("end of range %p\n", page);
  703. done = 1;
  704. unlock_page(page);
  705. break;
  706. }
  707. if (next && (page->index != next)) {
  708. dout("not consecutive %p\n", page);
  709. unlock_page(page);
  710. break;
  711. }
  712. if (wbc->sync_mode != WB_SYNC_NONE) {
  713. dout("waiting on writeback %p\n", page);
  714. wait_on_page_writeback(page);
  715. }
  716. if ((snap_size && page_offset(page) > snap_size) ||
  717. (!snap_size &&
  718. page_offset(page) > i_size_read(inode))) {
  719. dout("%p page eof %llu\n", page, snap_size ?
  720. snap_size : i_size_read(inode));
  721. done = 1;
  722. unlock_page(page);
  723. break;
  724. }
  725. if (PageWriteback(page)) {
  726. dout("%p under writeback\n", page);
  727. unlock_page(page);
  728. break;
  729. }
  730. /* only if matching snap context */
  731. pgsnapc = page_snap_context(page);
  732. if (pgsnapc->seq > snapc->seq) {
  733. dout("page snapc %p %lld > oldest %p %lld\n",
  734. pgsnapc, pgsnapc->seq, snapc, snapc->seq);
  735. unlock_page(page);
  736. if (!locked_pages)
  737. continue; /* keep looking for snap */
  738. break;
  739. }
  740. if (!clear_page_dirty_for_io(page)) {
  741. dout("%p !clear_page_dirty_for_io\n", page);
  742. unlock_page(page);
  743. break;
  744. }
  745. /* ok */
  746. if (locked_pages == 0) {
  747. /* prepare async write request */
  748. offset = (u64) page_offset(page);
  749. len = wsize;
  750. req = ceph_osdc_new_request(&fsc->client->osdc,
  751. &ci->i_layout,
  752. ceph_vino(inode),
  753. offset, &len,
  754. CEPH_OSD_OP_WRITE,
  755. CEPH_OSD_FLAG_WRITE |
  756. CEPH_OSD_FLAG_ONDISK,
  757. snapc, do_sync,
  758. ci->i_truncate_seq,
  759. ci->i_truncate_size,
  760. &inode->i_mtime, true, 1, 0);
  761. if (IS_ERR(req)) {
  762. rc = PTR_ERR(req);
  763. unlock_page(page);
  764. break;
  765. }
  766. max_pages = req->r_num_pages;
  767. alloc_page_vec(fsc, req);
  768. req->r_callback = writepages_finish;
  769. req->r_inode = inode;
  770. }
  771. /* note position of first page in pvec */
  772. if (first < 0)
  773. first = i;
  774. dout("%p will write page %p idx %lu\n",
  775. inode, page, page->index);
  776. writeback_stat =
  777. atomic_long_inc_return(&fsc->writeback_count);
  778. if (writeback_stat > CONGESTION_ON_THRESH(
  779. fsc->mount_options->congestion_kb)) {
  780. set_bdi_congested(&fsc->backing_dev_info,
  781. BLK_RW_ASYNC);
  782. }
  783. set_page_writeback(page);
  784. req->r_pages[locked_pages] = page;
  785. locked_pages++;
  786. next = page->index + 1;
  787. }
  788. /* did we get anything? */
  789. if (!locked_pages)
  790. goto release_pvec_pages;
  791. if (i) {
  792. int j;
  793. BUG_ON(!locked_pages || first < 0);
  794. if (pvec_pages && i == pvec_pages &&
  795. locked_pages < max_pages) {
  796. dout("reached end pvec, trying for more\n");
  797. pagevec_reinit(&pvec);
  798. goto get_more_pages;
  799. }
  800. /* shift unused pages over in the pvec... we
  801. * will need to release them below. */
  802. for (j = i; j < pvec_pages; j++) {
  803. dout(" pvec leftover page %p\n",
  804. pvec.pages[j]);
  805. pvec.pages[j-i+first] = pvec.pages[j];
  806. }
  807. pvec.nr -= i-first;
  808. }
  809. /* submit the write */
  810. offset = req->r_pages[0]->index << PAGE_CACHE_SHIFT;
  811. len = min((snap_size ? snap_size : i_size_read(inode)) - offset,
  812. (u64)locked_pages << PAGE_CACHE_SHIFT);
  813. dout("writepages got %d pages at %llu~%llu\n",
  814. locked_pages, offset, len);
  815. /* revise final length, page count */
  816. req->r_num_pages = locked_pages;
  817. reqhead = req->r_request->front.iov_base;
  818. op = (void *)(reqhead + 1);
  819. op->extent.length = cpu_to_le64(len);
  820. op->payload_len = cpu_to_le32(len);
  821. req->r_request->hdr.data_len = cpu_to_le32(len);
  822. rc = ceph_osdc_start_request(&fsc->client->osdc, req, true);
  823. BUG_ON(rc);
  824. req = NULL;
  825. /* continue? */
  826. index = next;
  827. wbc->nr_to_write -= locked_pages;
  828. if (wbc->nr_to_write <= 0)
  829. done = 1;
  830. release_pvec_pages:
  831. dout("pagevec_release on %d pages (%p)\n", (int)pvec.nr,
  832. pvec.nr ? pvec.pages[0] : NULL);
  833. pagevec_release(&pvec);
  834. if (locked_pages && !done)
  835. goto retry;
  836. }
  837. if (should_loop && !done) {
  838. /* more to do; loop back to beginning of file */
  839. dout("writepages looping back to beginning of file\n");
  840. should_loop = 0;
  841. index = 0;
  842. goto retry;
  843. }
  844. if (wbc->range_cyclic || (range_whole && wbc->nr_to_write > 0))
  845. mapping->writeback_index = index;
  846. out:
  847. if (req)
  848. ceph_osdc_put_request(req);
  849. ceph_put_snap_context(snapc);
  850. dout("writepages done, rc = %d\n", rc);
  851. return rc;
  852. }
  853. /*
  854. * See if a given @snapc is either writeable, or already written.
  855. */
  856. static int context_is_writeable_or_written(struct inode *inode,
  857. struct ceph_snap_context *snapc)
  858. {
  859. struct ceph_snap_context *oldest = get_oldest_context(inode, NULL);
  860. int ret = !oldest || snapc->seq <= oldest->seq;
  861. ceph_put_snap_context(oldest);
  862. return ret;
  863. }
  864. /*
  865. * We are only allowed to write into/dirty the page if the page is
  866. * clean, or already dirty within the same snap context.
  867. *
  868. * called with page locked.
  869. * return success with page locked,
  870. * or any failure (incl -EAGAIN) with page unlocked.
  871. */
  872. static int ceph_update_writeable_page(struct file *file,
  873. loff_t pos, unsigned len,
  874. struct page *page)
  875. {
  876. struct inode *inode = file->f_dentry->d_inode;
  877. struct ceph_inode_info *ci = ceph_inode(inode);
  878. struct ceph_mds_client *mdsc = ceph_inode_to_client(inode)->mdsc;
  879. loff_t page_off = pos & PAGE_CACHE_MASK;
  880. int pos_in_page = pos & ~PAGE_CACHE_MASK;
  881. int end_in_page = pos_in_page + len;
  882. loff_t i_size;
  883. int r;
  884. struct ceph_snap_context *snapc, *oldest;
  885. retry_locked:
  886. /* writepages currently holds page lock, but if we change that later, */
  887. wait_on_page_writeback(page);
  888. /* check snap context */
  889. BUG_ON(!ci->i_snap_realm);
  890. down_read(&mdsc->snap_rwsem);
  891. BUG_ON(!ci->i_snap_realm->cached_context);
  892. snapc = page_snap_context(page);
  893. if (snapc && snapc != ci->i_head_snapc) {
  894. /*
  895. * this page is already dirty in another (older) snap
  896. * context! is it writeable now?
  897. */
  898. oldest = get_oldest_context(inode, NULL);
  899. up_read(&mdsc->snap_rwsem);
  900. if (snapc->seq > oldest->seq) {
  901. ceph_put_snap_context(oldest);
  902. dout(" page %p snapc %p not current or oldest\n",
  903. page, snapc);
  904. /*
  905. * queue for writeback, and wait for snapc to
  906. * be writeable or written
  907. */
  908. snapc = ceph_get_snap_context(snapc);
  909. unlock_page(page);
  910. ceph_queue_writeback(inode);
  911. r = wait_event_interruptible(ci->i_cap_wq,
  912. context_is_writeable_or_written(inode, snapc));
  913. ceph_put_snap_context(snapc);
  914. if (r == -ERESTARTSYS)
  915. return r;
  916. return -EAGAIN;
  917. }
  918. ceph_put_snap_context(oldest);
  919. /* yay, writeable, do it now (without dropping page lock) */
  920. dout(" page %p snapc %p not current, but oldest\n",
  921. page, snapc);
  922. if (!clear_page_dirty_for_io(page))
  923. goto retry_locked;
  924. r = writepage_nounlock(page, NULL);
  925. if (r < 0)
  926. goto fail_nosnap;
  927. goto retry_locked;
  928. }
  929. if (PageUptodate(page)) {
  930. dout(" page %p already uptodate\n", page);
  931. return 0;
  932. }
  933. /* full page? */
  934. if (pos_in_page == 0 && len == PAGE_CACHE_SIZE)
  935. return 0;
  936. /* past end of file? */
  937. i_size = inode->i_size; /* caller holds i_mutex */
  938. if (i_size + len > inode->i_sb->s_maxbytes) {
  939. /* file is too big */
  940. r = -EINVAL;
  941. goto fail;
  942. }
  943. if (page_off >= i_size ||
  944. (pos_in_page == 0 && (pos+len) >= i_size &&
  945. end_in_page - pos_in_page != PAGE_CACHE_SIZE)) {
  946. dout(" zeroing %p 0 - %d and %d - %d\n",
  947. page, pos_in_page, end_in_page, (int)PAGE_CACHE_SIZE);
  948. zero_user_segments(page,
  949. 0, pos_in_page,
  950. end_in_page, PAGE_CACHE_SIZE);
  951. return 0;
  952. }
  953. /* we need to read it. */
  954. up_read(&mdsc->snap_rwsem);
  955. r = readpage_nounlock(file, page);
  956. if (r < 0)
  957. goto fail_nosnap;
  958. goto retry_locked;
  959. fail:
  960. up_read(&mdsc->snap_rwsem);
  961. fail_nosnap:
  962. unlock_page(page);
  963. return r;
  964. }
  965. /*
  966. * We are only allowed to write into/dirty the page if the page is
  967. * clean, or already dirty within the same snap context.
  968. */
  969. static int ceph_write_begin(struct file *file, struct address_space *mapping,
  970. loff_t pos, unsigned len, unsigned flags,
  971. struct page **pagep, void **fsdata)
  972. {
  973. struct inode *inode = file->f_dentry->d_inode;
  974. struct page *page;
  975. pgoff_t index = pos >> PAGE_CACHE_SHIFT;
  976. int r;
  977. do {
  978. /* get a page */
  979. page = grab_cache_page_write_begin(mapping, index, 0);
  980. if (!page)
  981. return -ENOMEM;
  982. *pagep = page;
  983. dout("write_begin file %p inode %p page %p %d~%d\n", file,
  984. inode, page, (int)pos, (int)len);
  985. r = ceph_update_writeable_page(file, pos, len, page);
  986. } while (r == -EAGAIN);
  987. return r;
  988. }
  989. /*
  990. * we don't do anything in here that simple_write_end doesn't do
  991. * except adjust dirty page accounting and drop read lock on
  992. * mdsc->snap_rwsem.
  993. */
  994. static int ceph_write_end(struct file *file, struct address_space *mapping,
  995. loff_t pos, unsigned len, unsigned copied,
  996. struct page *page, void *fsdata)
  997. {
  998. struct inode *inode = file->f_dentry->d_inode;
  999. struct ceph_fs_client *fsc = ceph_inode_to_client(inode);
  1000. struct ceph_mds_client *mdsc = fsc->mdsc;
  1001. unsigned from = pos & (PAGE_CACHE_SIZE - 1);
  1002. int check_cap = 0;
  1003. dout("write_end file %p inode %p page %p %d~%d (%d)\n", file,
  1004. inode, page, (int)pos, (int)copied, (int)len);
  1005. /* zero the stale part of the page if we did a short copy */
  1006. if (copied < len)
  1007. zero_user_segment(page, from+copied, len);
  1008. /* did file size increase? */
  1009. /* (no need for i_size_read(); we caller holds i_mutex */
  1010. if (pos+copied > inode->i_size)
  1011. check_cap = ceph_inode_set_size(inode, pos+copied);
  1012. if (!PageUptodate(page))
  1013. SetPageUptodate(page);
  1014. set_page_dirty(page);
  1015. unlock_page(page);
  1016. up_read(&mdsc->snap_rwsem);
  1017. page_cache_release(page);
  1018. if (check_cap)
  1019. ceph_check_caps(ceph_inode(inode), CHECK_CAPS_AUTHONLY, NULL);
  1020. return copied;
  1021. }
  1022. /*
  1023. * we set .direct_IO to indicate direct io is supported, but since we
  1024. * intercept O_DIRECT reads and writes early, this function should
  1025. * never get called.
  1026. */
  1027. static ssize_t ceph_direct_io(int rw, struct kiocb *iocb,
  1028. const struct iovec *iov,
  1029. loff_t pos, unsigned long nr_segs)
  1030. {
  1031. WARN_ON(1);
  1032. return -EINVAL;
  1033. }
  1034. const struct address_space_operations ceph_aops = {
  1035. .readpage = ceph_readpage,
  1036. .readpages = ceph_readpages,
  1037. .writepage = ceph_writepage,
  1038. .writepages = ceph_writepages_start,
  1039. .write_begin = ceph_write_begin,
  1040. .write_end = ceph_write_end,
  1041. .set_page_dirty = ceph_set_page_dirty,
  1042. .invalidatepage = ceph_invalidatepage,
  1043. .releasepage = ceph_releasepage,
  1044. .direct_IO = ceph_direct_io,
  1045. };
  1046. /*
  1047. * vm ops
  1048. */
  1049. /*
  1050. * Reuse write_begin here for simplicity.
  1051. */
  1052. static int ceph_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
  1053. {
  1054. struct inode *inode = vma->vm_file->f_dentry->d_inode;
  1055. struct page *page = vmf->page;
  1056. struct ceph_mds_client *mdsc = ceph_inode_to_client(inode)->mdsc;
  1057. loff_t off = page_offset(page);
  1058. loff_t size, len;
  1059. int ret;
  1060. size = i_size_read(inode);
  1061. if (off + PAGE_CACHE_SIZE <= size)
  1062. len = PAGE_CACHE_SIZE;
  1063. else
  1064. len = size & ~PAGE_CACHE_MASK;
  1065. dout("page_mkwrite %p %llu~%llu page %p idx %lu\n", inode,
  1066. off, len, page, page->index);
  1067. lock_page(page);
  1068. ret = VM_FAULT_NOPAGE;
  1069. if ((off > size) ||
  1070. (page->mapping != inode->i_mapping))
  1071. goto out;
  1072. ret = ceph_update_writeable_page(vma->vm_file, off, len, page);
  1073. if (ret == 0) {
  1074. /* success. we'll keep the page locked. */
  1075. set_page_dirty(page);
  1076. up_read(&mdsc->snap_rwsem);
  1077. ret = VM_FAULT_LOCKED;
  1078. } else {
  1079. if (ret == -ENOMEM)
  1080. ret = VM_FAULT_OOM;
  1081. else
  1082. ret = VM_FAULT_SIGBUS;
  1083. }
  1084. out:
  1085. dout("page_mkwrite %p %llu~%llu = %d\n", inode, off, len, ret);
  1086. if (ret != VM_FAULT_LOCKED)
  1087. unlock_page(page);
  1088. return ret;
  1089. }
  1090. static struct vm_operations_struct ceph_vmops = {
  1091. .fault = filemap_fault,
  1092. .page_mkwrite = ceph_page_mkwrite,
  1093. .remap_pages = generic_file_remap_pages,
  1094. };
  1095. int ceph_mmap(struct file *file, struct vm_area_struct *vma)
  1096. {
  1097. struct address_space *mapping = file->f_mapping;
  1098. if (!mapping->a_ops->readpage)
  1099. return -ENOEXEC;
  1100. file_accessed(file);
  1101. vma->vm_ops = &ceph_vmops;
  1102. return 0;
  1103. }