#14 Make find.thing() accept only the relevant subset of wiki data

Suljettu
2 vuotta sitten avasi towerofnix · 1 kommenttia

Right now it expects the full wikiData object, which is useful for not always remembering which data key goes with which find function... but there are a couple straightforward workarounds which make this less relevant today:

1) Data functions don't really work on wikiData at all anymore—they already take specialized subsets of the data.

2) Page generation functions operate on bound versions of every function anyway, so we can bind each find function to the appropriate data subset only once, at the start of upd8.js page generation code.

This change would also continue in making functions more agnostic towards the overall data structure, which is good, because we shouldn't expect it to look the same under every circumstance/fork/project/etc!

Right now it expects the full `wikiData` object, which is useful for not always remembering which data key goes with which `find` function... but there are a couple straightforward workarounds which make this less relevant today: 1) Data functions don't really work on `wikiData` at all anymore—they already take specialized subsets of the data. 2) Page generation functions operate on bound versions of every function anyway, so we can bind each `find` function to the appropriate data subset only once, at the start of `upd8.js` page generation code. This change would also continue in making functions more agnostic towards the overall data structure, which is good, because we shouldn't expect it to look the same under every circumstance/fork/project/etc!
(quasar) nebula kommentoitu 2 vuotta sitten
Omistaja

This is done now! Yay.

This is done now! Yay.
Kirjaudu sisään osallistuaksesi tähän keskusteluun.
Ei merkkipaalua
Ei osoitettua
1 osallistujaa
Ladataan...
Peruuta
Tallenna
Sisältöä ei vielä ole.