#95 Missing Notes?

Hi. First of all, the app is great and very useful to all students.

I just noticed that the app does not show the information from the last column "Notes" ("Bemerk."). I tried all app's layouts in the preferences, but the info is still not available.

For example, I can see that my class has been canceled, but in some cases teachers use the Notes column to inform the students about something (e.g. homeworks, exams, etc.).

Please take a look to the attached images with an example about class 10c.

Can you please add/show the Notes information too? That would be really nice, without switching to the "other" app... :)

Thanks.

Bye Chris

Oh, it looks like that my response did not reach you.

Sure, I can add it, things are way easier if you can click the "request parser" button in the settings menu, then I get a complete html copy and can write a test for it.

Its always possible to disable the parser in the settings, then you can look at the html content, just like in the original app.

Thanks for the feedback in general, but I think nobody of "us" is using the app anymore, we all got our degree :)

Moritz

Hi Moritz, thanks for your reply, I really appreciate it.

I'm glad you graduated: luckily many students can still use your useful app, nothing has changed in the school system since your days :) Right now I'm not home, I'll send you a message as soon as the school will start again...

As far as I know, no need to write a brand-new parser: the format is still Untis, the only difference is the last column label. This time the label is "Bemerk." (see previous picture) instead of "Bemerkung".

I guess this is an old problem because in the source code (file Untis.java) I've found a Java "switch" statement to manage some variants for the label "Bemerkung".

I tried to add the new "case" but unfortunately I can't compile the project, my fault.

Thanks again!

@dif1754 Yes, that should solve it indeed. Unfortunately hardcoding these values is not sustainable because they can be configured freely, so in theory we'd need a way for users to configure the matching freely as well.

@diff1754: Yes, I see it, but I can not test any changes that I made if I don't have the html file. Thats the purpose.

And yes, adding the Bemerk. should fix the problem, I will PR it tomorrow?

@fynngodau: I think its more like a most common thing and adding them to the code makes all users benefit from it. But maybe some kind of pattern matching might be useful. Maybe we should collect more html files and just start writing tests? Probably to late :(

Hi to all.

Right now I cannot send you a sample html from the app itself (request parser), schools are closed for the Easter holidays and there's no data available right now.

But before schools closed I managed to download an html snippet from my web browser (file attached) to see some info (including the "Bemerk." column)..

e.g.

<tr class="list"><th class="list" align="center"><b>Klasse</b></th><th class="list" align="center">Std.</th><th class="list" align="center">Fach</th><th class="list" align="center">Raum</th><th class="list" align="center">(Fach)</th><th class="list" align="center" width="7">Art</th><th class="list" align="center">statt</th><th class="list" align="center">Bemerk.</th></tr>

Sorry bothering you... :)

Thanks again.

You are not bothering us, I already implemented a fix: https://notabug.org/fynngodau/DSBDirect/pulls/96

Waiting for @fynngodau to merge it :)

Thanks to both of you!

Hi Moritz, I've just sent you the "Vertretungplan" html (last available from the school) directly from from your app. Some classes have the "Bemerk." column with some text. Please remove any info about the school name inside the html file :)

Thanks

Thanks, wrote a small test for it (and fixed the old subject column). The file is called issue_95.html (https://notabug.org/Bixilon/DSBDirect/src/af50769322e9432f0b1a93eb347964b8b65d63bb/app/src/test/resources/issue_95.htm), I removed the school information. All other information is already in your screenshot.

Thanks Moritz! Well done. Cannot wait to see the upcoming release.

Hi Moritz, it seems to me that Fynn has accepted your pull request, in fact I can see the changes at least in the file Untis.java .

I've downloaded the Dsbdirect app from F-Droid repository but it seems there are no new features, maybe it's still the old app ;)

I'm not expert, how does it work? Should I recompile the new source code by myself or should I wait for the new APK to be built e published on F-Droid or somewhere else?

Thanks!

There is no new release yet. Compiling the app yourself should work, other than that will probably make a release soon.

Thanks Fynn. Cannot wait to see your new release ;)

Hi Moritz and Fynn.

I managed to compile the latest DSBdirect source (3.4.1) after the latest merge .

Moritz, I can confirm that the "Bemerk." label management works. ;)

But, if I'm not wrong, last time you also introduced a new label, "statt", as an alias of "(Fach)" (switch/case in Java, see attachment).

Obviously "(Fach)" and "statt" are two different columns that can contain different info, like you can see in the attachment for the class 8b (see attachment).

Unfortunately the app does not show the "statt" info, but just the new "Fach" info.

I just wonder if the "statt" column needs to be managed in the app independently, showing both the new "Fach" and the "statt" info (when the info is available...).

What is your opinion on this?

Bye Chris

sorry, one more screenshot :)

@dif1754 In this case, the column "statt" should have been matched to OLD_TIME instead. Unfortunately it is ambiguos what many of the words mean, but I suppose we can change it (at least until someone complains to the contrary).

@fynngodau It looks better ;)