#18 Added necessary build files

Merged
fynngodau merged 2 commits from theonewiththebraid/essentials into fynngodau/master 4 years ago

I added the necessary settings.gradle as well as a .gitignore.

These files allow Android Studio to build the App without any hacking.

I added the necessary `settings.gradle` as well as a `.gitignore`. These files allow Android Studio to build the App without any hacking.
fynngodau commented 4 years ago
Owner

Adding settings.gradle makes sense, I appreciate your pull request. However, I don't believe it is necessary to commit gradlew and gradlew.bat into the repository and would rather add them to .gitignore.

Furthermore, you have added a line in .gitignore for Crashlytics configurations. Is that really any use when the project doesn't include Crashlytics? Also, when is the .signing folder generated?

Adding `settings.gradle` makes sense, I appreciate your pull request. However, I don't believe it is necessary to commit `gradlew` and `gradlew.bat` into the repository and would rather add them to `.gitignore`. Furthermore, you have added a line in `.gitignore` for `Crashlytics configurations`. Is that really any use when the project doesn't include Crashlytics? Also, when is the `.signing` folder generated?

Okay, I updated the .gitignore and removed gradlew*. My gitignore errors were caused by copy paste. Sorry.

Okay, I updated the `.gitignore` and removed `gradlew*`. My gitignore errors were caused by copy paste. Sorry.
fynngodau commented 4 years ago
Owner

Thank you!

Thank you!
This pull request has been merged successfully!
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.