#4 [RFC] Community plugins integration

Closed
opened 4 years ago by postblue · 2 comments

We can see links in the plugins directory to community updated ones.

  1. These plugins are lacking a valid .gitmodules file
  2. Community plugins can be put in the local repository

Related upstream issue: https://git.gnu.io/gnu/gnu-social/issues/324

In nightly branch, some community plugins are available as submodules in the plugins directory. But the .gitmodules file is missing, so running a command like git submodule update --init --recursive fails with fatal: No url found for submodule path 'plugins/EmbedNotice' in .gitmodules.

To do:

  • provide a .gitmodules file with up-to-date remote URL
We can see links in the `plugins` directory to community updated ones. 1. These plugins are lacking a valid .gitmodules file 2. Community plugins can be put in the `local` repository Related upstream issue: https://git.gnu.io/gnu/gnu-social/issues/324 > In `nightly` branch, some community plugins are available as submodules in the `plugins` directory. But the `.gitmodules` file is missing, so running a command like `git submodule update --init --recursive` fails with `fatal: No url found for submodule path 'plugins/EmbedNotice' in .gitmodules`. > To do: > * provide a `.gitmodules` file with up-to-date remote URL
Diogo Cordeiro commented 4 years ago
Owner

As a matter of fact, that needs some revision. There's also a broken link in plugins/README.md for community plugins that should maybe point to https://git.gnu.io/gnu/gnu-social/wikis/GNU-Social-Community-Plugins instead.

In postActiv they have created a modules directory for core functionality and left plugins for other functionalities. I believe it is better for us to do like you've suggested (and is usually being recommended in existing community plugins's README), that is, to have a local directory for community stuff.

I guess we should just remove those git submodules from the repository as they are extras/further functionality that doesn't come pre-activated and add a README.md on local/plugins/README.md with a list of existing community plugins instead.

As a matter of fact, that needs some revision. There's also a broken link in `plugins/README.md` for community plugins that should maybe point to https://git.gnu.io/gnu/gnu-social/wikis/GNU-Social-Community-Plugins instead. In postActiv they have created a `modules` directory for core functionality and left `plugins` for other functionalities. I believe it is better for us to do like you've suggested (and is usually being recommended in existing community plugins's README), that is, to have a `local` directory for community stuff. I guess we should just remove those git submodules from the repository as they are extras/further functionality that doesn't come pre-activated and add a `README.md` on `local/plugins/README.md` with a list of existing community plugins instead.
Diogo Cordeiro commented 4 years ago
Owner

Just noticed that gitea doesn't link mentions... This issue was solved with Guillaume's MR: https://notabug.org/diogo/gnu-social/pulls/5

Just noticed that gitea doesn't link mentions... This issue was solved with Guillaume's MR: https://notabug.org/diogo/gnu-social/pulls/5
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.