#17 Broken TagSub plugin

Closed
opened 1 year ago by diogo · 1 comments

Reported on https://gnusocial.club/conversation/804379

A quick fix was: 981e8ce7ac

First I thought this could have been caused by 6d9f390b

But then I read this:

@gnusocialgnu Looks like something has broken the overload which allows following a hashtag. Basically normal subscriptions were designed to be just a person's stream. That plugin allows following a hashtag, but has malfunctioned. It worked before I forked postActiv from GNU social, so I can only guess that some recent change has broken it.

It couldn't therefore have been that commit, after reviewing the changes again, I now believe it could have been this: 9a92b58057

As soon as I have the time I will go through the issue again, identify the exact commit where it stopped working, and come up with a good solution and not just something that works.

(These are just notes to myself)

Reported on https://gnusocial.club/conversation/804379 A quick fix was: https://notabug.org/diogo/gnu-social/commit/981e8ce7acb5f27f22bd0f1b336c7fbe52c9ba2b First I thought this could have been caused by https://notabug.org/diogo/gnu-social/commit/6d9f390b But then I read this: > @gnusocialgnu Looks like something has broken the overload which allows following a hashtag. Basically normal subscriptions were designed to be just a person's stream. That plugin allows following a hashtag, but has malfunctioned. **It worked before I forked postActiv from GNU social, so I can only guess that some recent change has broken it.** It couldn't therefore have been that commit, after reviewing the changes again, I now believe it could have been this: https://notabug.org/diogo/gnu-social/commit/9a92b58057fb3a6ae5a6da6d37d2cd3ff4d84bd7 As soon as I have the time I will go through the issue again, identify the exact commit where it stopped working, and come up with a good solution and not just something that works. (These are just notes to myself)
Diogo Cordeiro commented 1 year ago
Owner

Solved with a55d6402ff and merged.

Solved with https://notabug.org/diogo/gnu-social/commit/a55d6402ff39ac744607fc34fb1b27adfafd8d11 and merged.
Sign in to join this conversation.
No Milestone
No assignee
1 Participants
Loading...
Cancel
Save
There is no content yet.