| 1234567891011121314151617181920212223242526272829303132333435363738394041 |
- $OpenBSD: patch-list_c,v 1.1 2017/03/23 17:26:17 bluhm Exp $
- Fix: increase size of cfactorstr array to avoid buffer overflow
- https://bugs.debian.org/741384
- Fix CVE-2014-9913: buffer overflow in unzip
- https://sourceforge.net/p/infozip/bugs/27/
- https://bugs.debian.org/847485
- https://launchpad.net/bugs/387350
- --- list.c.orig Sun Feb 8 18:11:34 2009
- +++ list.c Tue Mar 21 16:10:27 2017
- @@ -97,7 +97,7 @@ int list_files(__G) /* return PK-type error code */
- {
- int do_this_file=FALSE, cfactor, error, error_in_archive=PK_COOL;
- #ifndef WINDLL
- - char sgn, cfactorstr[10];
- + char sgn, cfactorstr[12];
- int longhdr=(uO.vflag>1);
- #endif
- int date_format;
- @@ -339,7 +339,18 @@ int list_files(__G) /* return PK-type error code */
- G.crec.compression_method == ENHDEFLATED) {
- methbuf[5] = dtype[(G.crec.general_purpose_bit_flag>>1) & 3];
- } else if (methnum >= NUM_METHODS) {
- - sprintf(&methbuf[4], "%03u", G.crec.compression_method);
- + /* 2013-02-26 SMS.
- + * http://sourceforge.net/p/infozip/bugs/27/ CVE-2014-9913.
- + * Unexpectedly large compression methods overflow
- + * &methbuf[]. Use the old, three-digit decimal format
- + * for values which fit. Otherwise, sacrifice the
- + * colon, and use four-digit hexadecimal.
- + */
- + if (G.crec.compression_method <= 999) {
- + sprintf( &methbuf[ 4], "%03u", G.crec.compression_method);
- + } else {
- + sprintf( &methbuf[ 3], "%04X", G.crec.compression_method);
- + }
- }
-
- #if 0 /* GRR/Euro: add this? */
|
