ChangeLog-2012-05-22 2.9 MB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982983984985986987988989990991992993994995996997998999100010011002100310041005100610071008100910101011101210131014101510161017101810191020102110221023102410251026102710281029103010311032103310341035103610371038103910401041104210431044104510461047104810491050105110521053105410551056105710581059106010611062106310641065106610671068106910701071107210731074107510761077107810791080108110821083108410851086108710881089109010911092109310941095109610971098109911001101110211031104110511061107110811091110111111121113111411151116111711181119112011211122112311241125112611271128112911301131113211331134113511361137113811391140114111421143114411451146114711481149115011511152115311541155115611571158115911601161116211631164116511661167116811691170117111721173117411751176117711781179118011811182118311841185118611871188118911901191119211931194119511961197119811991200120112021203120412051206120712081209121012111212121312141215121612171218121912201221122212231224122512261227122812291230123112321233123412351236123712381239124012411242124312441245124612471248124912501251125212531254125512561257125812591260126112621263126412651266126712681269127012711272127312741275127612771278127912801281128212831284128512861287128812891290129112921293129412951296129712981299130013011302130313041305130613071308130913101311131213131314131513161317131813191320132113221323132413251326132713281329133013311332133313341335133613371338133913401341134213431344134513461347134813491350135113521353135413551356135713581359136013611362136313641365136613671368136913701371137213731374137513761377137813791380138113821383138413851386138713881389139013911392139313941395139613971398139914001401140214031404140514061407140814091410141114121413141414151416141714181419142014211422142314241425142614271428142914301431143214331434143514361437143814391440144114421443144414451446144714481449145014511452145314541455145614571458145914601461146214631464146514661467146814691470147114721473147414751476147714781479148014811482148314841485148614871488148914901491149214931494149514961497149814991500150115021503150415051506150715081509151015111512151315141515151615171518151915201521152215231524152515261527152815291530153115321533153415351536153715381539154015411542154315441545154615471548154915501551155215531554155515561557155815591560156115621563156415651566156715681569157015711572157315741575157615771578157915801581158215831584158515861587158815891590159115921593159415951596159715981599160016011602160316041605160616071608160916101611161216131614161516161617161816191620162116221623162416251626162716281629163016311632163316341635163616371638163916401641164216431644164516461647164816491650165116521653165416551656165716581659166016611662166316641665166616671668166916701671167216731674167516761677167816791680168116821683168416851686168716881689169016911692169316941695169616971698169917001701170217031704170517061707170817091710171117121713171417151716171717181719172017211722172317241725172617271728172917301731173217331734173517361737173817391740174117421743174417451746174717481749175017511752175317541755175617571758175917601761176217631764176517661767176817691770177117721773177417751776177717781779178017811782178317841785178617871788178917901791179217931794179517961797179817991800180118021803180418051806180718081809181018111812181318141815181618171818181918201821182218231824182518261827182818291830183118321833183418351836183718381839184018411842184318441845184618471848184918501851185218531854185518561857185818591860186118621863186418651866186718681869187018711872187318741875187618771878187918801881188218831884188518861887188818891890189118921893189418951896189718981899190019011902190319041905190619071908190919101911191219131914191519161917191819191920192119221923192419251926192719281929193019311932193319341935193619371938193919401941194219431944194519461947194819491950195119521953195419551956195719581959196019611962196319641965196619671968196919701971197219731974197519761977197819791980198119821983198419851986198719881989199019911992199319941995199619971998199920002001200220032004200520062007200820092010201120122013201420152016201720182019202020212022202320242025202620272028202920302031203220332034203520362037203820392040204120422043204420452046204720482049205020512052205320542055205620572058205920602061206220632064206520662067206820692070207120722073207420752076207720782079208020812082208320842085208620872088208920902091209220932094209520962097209820992100210121022103210421052106210721082109211021112112211321142115211621172118211921202121212221232124212521262127212821292130213121322133213421352136213721382139214021412142214321442145214621472148214921502151215221532154215521562157215821592160216121622163216421652166216721682169217021712172217321742175217621772178217921802181218221832184218521862187218821892190219121922193219421952196219721982199220022012202220322042205220622072208220922102211221222132214221522162217221822192220222122222223222422252226222722282229223022312232223322342235223622372238223922402241224222432244224522462247224822492250225122522253225422552256225722582259226022612262226322642265226622672268226922702271227222732274227522762277227822792280228122822283228422852286228722882289229022912292229322942295229622972298229923002301230223032304230523062307230823092310231123122313231423152316231723182319232023212322232323242325232623272328232923302331233223332334233523362337233823392340234123422343234423452346234723482349235023512352235323542355235623572358235923602361236223632364236523662367236823692370237123722373237423752376237723782379238023812382238323842385238623872388238923902391239223932394239523962397239823992400240124022403240424052406240724082409241024112412241324142415241624172418241924202421242224232424242524262427242824292430243124322433243424352436243724382439244024412442244324442445244624472448244924502451245224532454245524562457245824592460246124622463246424652466246724682469247024712472247324742475247624772478247924802481248224832484248524862487248824892490249124922493249424952496249724982499250025012502250325042505250625072508250925102511251225132514251525162517251825192520252125222523252425252526252725282529253025312532253325342535253625372538253925402541254225432544254525462547254825492550255125522553255425552556255725582559256025612562256325642565256625672568256925702571257225732574257525762577257825792580258125822583258425852586258725882589259025912592259325942595259625972598259926002601260226032604260526062607260826092610261126122613261426152616261726182619262026212622262326242625262626272628262926302631263226332634263526362637263826392640264126422643264426452646264726482649265026512652265326542655265626572658265926602661266226632664266526662667266826692670267126722673267426752676267726782679268026812682268326842685268626872688268926902691269226932694269526962697269826992700270127022703270427052706270727082709271027112712271327142715271627172718271927202721272227232724272527262727272827292730273127322733273427352736273727382739274027412742274327442745274627472748274927502751275227532754275527562757275827592760276127622763276427652766276727682769277027712772277327742775277627772778277927802781278227832784278527862787278827892790279127922793279427952796279727982799280028012802280328042805280628072808280928102811281228132814281528162817281828192820282128222823282428252826282728282829283028312832283328342835283628372838283928402841284228432844284528462847284828492850285128522853285428552856285728582859286028612862286328642865286628672868286928702871287228732874287528762877287828792880288128822883288428852886288728882889289028912892289328942895289628972898289929002901290229032904290529062907290829092910291129122913291429152916291729182919292029212922292329242925292629272928292929302931293229332934293529362937293829392940294129422943294429452946294729482949295029512952295329542955295629572958295929602961296229632964296529662967296829692970297129722973297429752976297729782979298029812982298329842985298629872988298929902991299229932994299529962997299829993000300130023003300430053006300730083009301030113012301330143015301630173018301930203021302230233024302530263027302830293030303130323033303430353036303730383039304030413042304330443045304630473048304930503051305230533054305530563057305830593060306130623063306430653066306730683069307030713072307330743075307630773078307930803081308230833084308530863087308830893090309130923093309430953096309730983099310031013102310331043105310631073108310931103111311231133114311531163117311831193120312131223123312431253126312731283129313031313132313331343135313631373138313931403141314231433144314531463147314831493150315131523153315431553156315731583159316031613162316331643165316631673168316931703171317231733174317531763177317831793180318131823183318431853186318731883189319031913192319331943195319631973198319932003201320232033204320532063207320832093210321132123213321432153216321732183219322032213222322332243225322632273228322932303231323232333234323532363237323832393240324132423243324432453246324732483249325032513252325332543255325632573258325932603261326232633264326532663267326832693270327132723273327432753276327732783279328032813282328332843285328632873288328932903291329232933294329532963297329832993300330133023303330433053306330733083309331033113312331333143315331633173318331933203321332233233324332533263327332833293330333133323333333433353336333733383339334033413342334333443345334633473348334933503351335233533354335533563357335833593360336133623363336433653366336733683369337033713372337333743375337633773378337933803381338233833384338533863387338833893390339133923393339433953396339733983399340034013402340334043405340634073408340934103411341234133414341534163417341834193420342134223423342434253426342734283429343034313432343334343435343634373438343934403441344234433444344534463447344834493450345134523453345434553456345734583459346034613462346334643465346634673468346934703471347234733474347534763477347834793480348134823483348434853486348734883489349034913492349334943495349634973498349935003501350235033504350535063507350835093510351135123513351435153516351735183519352035213522352335243525352635273528352935303531353235333534353535363537353835393540354135423543354435453546354735483549355035513552355335543555355635573558355935603561356235633564356535663567356835693570357135723573357435753576357735783579358035813582358335843585358635873588358935903591359235933594359535963597359835993600360136023603360436053606360736083609361036113612361336143615361636173618361936203621362236233624362536263627362836293630363136323633363436353636363736383639364036413642364336443645364636473648364936503651365236533654365536563657365836593660366136623663366436653666366736683669367036713672367336743675367636773678367936803681368236833684368536863687368836893690369136923693369436953696369736983699370037013702370337043705370637073708370937103711371237133714371537163717371837193720372137223723372437253726372737283729373037313732373337343735373637373738373937403741374237433744374537463747374837493750375137523753375437553756375737583759376037613762376337643765376637673768376937703771377237733774377537763777377837793780378137823783378437853786378737883789379037913792379337943795379637973798379938003801380238033804380538063807380838093810381138123813381438153816381738183819382038213822382338243825382638273828382938303831383238333834383538363837383838393840384138423843384438453846384738483849385038513852385338543855385638573858385938603861386238633864386538663867386838693870387138723873387438753876387738783879388038813882388338843885388638873888388938903891389238933894389538963897389838993900390139023903390439053906390739083909391039113912391339143915391639173918391939203921392239233924392539263927392839293930393139323933393439353936393739383939394039413942394339443945394639473948394939503951395239533954395539563957395839593960396139623963396439653966396739683969397039713972397339743975397639773978397939803981398239833984398539863987398839893990399139923993399439953996399739983999400040014002400340044005400640074008400940104011401240134014401540164017401840194020402140224023402440254026402740284029403040314032403340344035403640374038403940404041404240434044404540464047404840494050405140524053405440554056405740584059406040614062406340644065406640674068406940704071407240734074407540764077407840794080408140824083408440854086408740884089409040914092409340944095409640974098409941004101410241034104410541064107410841094110411141124113411441154116411741184119412041214122412341244125412641274128412941304131413241334134413541364137413841394140414141424143414441454146414741484149415041514152415341544155415641574158415941604161416241634164416541664167416841694170417141724173417441754176417741784179418041814182418341844185418641874188418941904191419241934194419541964197419841994200420142024203420442054206420742084209421042114212421342144215421642174218421942204221422242234224422542264227422842294230423142324233423442354236423742384239424042414242424342444245424642474248424942504251425242534254425542564257425842594260426142624263426442654266426742684269427042714272427342744275427642774278427942804281428242834284428542864287428842894290429142924293429442954296429742984299430043014302430343044305430643074308430943104311431243134314431543164317431843194320432143224323432443254326432743284329433043314332433343344335433643374338433943404341434243434344434543464347434843494350435143524353435443554356435743584359436043614362436343644365436643674368436943704371437243734374437543764377437843794380438143824383438443854386438743884389439043914392439343944395439643974398439944004401440244034404440544064407440844094410441144124413441444154416441744184419442044214422442344244425442644274428442944304431443244334434443544364437443844394440444144424443444444454446444744484449445044514452445344544455445644574458445944604461446244634464446544664467446844694470447144724473447444754476447744784479448044814482448344844485448644874488448944904491449244934494449544964497449844994500450145024503450445054506450745084509451045114512451345144515451645174518451945204521452245234524452545264527452845294530453145324533453445354536453745384539454045414542454345444545454645474548454945504551455245534554455545564557455845594560456145624563456445654566456745684569457045714572457345744575457645774578457945804581458245834584458545864587458845894590459145924593459445954596459745984599460046014602460346044605460646074608460946104611461246134614461546164617461846194620462146224623462446254626462746284629463046314632463346344635463646374638463946404641464246434644464546464647464846494650465146524653465446554656465746584659466046614662466346644665466646674668466946704671467246734674467546764677467846794680468146824683468446854686468746884689469046914692469346944695469646974698469947004701470247034704470547064707470847094710471147124713471447154716471747184719472047214722472347244725472647274728472947304731473247334734473547364737473847394740474147424743474447454746474747484749475047514752475347544755475647574758475947604761476247634764476547664767476847694770477147724773477447754776477747784779478047814782478347844785478647874788478947904791479247934794479547964797479847994800480148024803480448054806480748084809481048114812481348144815481648174818481948204821482248234824482548264827482848294830483148324833483448354836483748384839484048414842484348444845484648474848484948504851485248534854485548564857485848594860486148624863486448654866486748684869487048714872487348744875487648774878487948804881488248834884488548864887488848894890489148924893489448954896489748984899490049014902490349044905490649074908490949104911491249134914491549164917491849194920492149224923492449254926492749284929493049314932493349344935493649374938493949404941494249434944494549464947494849494950495149524953495449554956495749584959496049614962496349644965496649674968496949704971497249734974497549764977497849794980498149824983498449854986498749884989499049914992499349944995499649974998499950005001500250035004500550065007500850095010501150125013501450155016501750185019502050215022502350245025502650275028502950305031503250335034503550365037503850395040504150425043504450455046504750485049505050515052505350545055505650575058505950605061506250635064506550665067506850695070507150725073507450755076507750785079508050815082508350845085508650875088508950905091509250935094509550965097509850995100510151025103510451055106510751085109511051115112511351145115511651175118511951205121512251235124512551265127512851295130513151325133513451355136513751385139514051415142514351445145514651475148514951505151515251535154515551565157515851595160516151625163516451655166516751685169517051715172517351745175517651775178517951805181518251835184518551865187518851895190519151925193519451955196519751985199520052015202520352045205520652075208520952105211521252135214521552165217521852195220522152225223522452255226522752285229523052315232523352345235523652375238523952405241524252435244524552465247524852495250525152525253525452555256525752585259526052615262526352645265526652675268526952705271527252735274527552765277527852795280528152825283528452855286528752885289529052915292529352945295529652975298529953005301530253035304530553065307530853095310531153125313531453155316531753185319532053215322532353245325532653275328532953305331533253335334533553365337533853395340534153425343534453455346534753485349535053515352535353545355535653575358535953605361536253635364536553665367536853695370537153725373537453755376537753785379538053815382538353845385538653875388538953905391539253935394539553965397539853995400540154025403540454055406540754085409541054115412541354145415541654175418541954205421542254235424542554265427542854295430543154325433543454355436543754385439544054415442544354445445544654475448544954505451545254535454545554565457545854595460546154625463546454655466546754685469547054715472547354745475547654775478547954805481548254835484548554865487548854895490549154925493549454955496549754985499550055015502550355045505550655075508550955105511551255135514551555165517551855195520552155225523552455255526552755285529553055315532553355345535553655375538553955405541554255435544554555465547554855495550555155525553555455555556555755585559556055615562556355645565556655675568556955705571557255735574557555765577557855795580558155825583558455855586558755885589559055915592559355945595559655975598559956005601560256035604560556065607560856095610561156125613561456155616561756185619562056215622562356245625562656275628562956305631563256335634563556365637563856395640564156425643564456455646564756485649565056515652565356545655565656575658565956605661566256635664566556665667566856695670567156725673567456755676567756785679568056815682568356845685568656875688568956905691569256935694569556965697569856995700570157025703570457055706570757085709571057115712571357145715571657175718571957205721572257235724572557265727572857295730573157325733573457355736573757385739574057415742574357445745574657475748574957505751575257535754575557565757575857595760576157625763576457655766576757685769577057715772577357745775577657775778577957805781578257835784578557865787578857895790579157925793579457955796579757985799580058015802580358045805580658075808580958105811581258135814581558165817581858195820582158225823582458255826582758285829583058315832583358345835583658375838583958405841584258435844584558465847584858495850585158525853585458555856585758585859586058615862586358645865586658675868586958705871587258735874587558765877587858795880588158825883588458855886588758885889589058915892589358945895589658975898589959005901590259035904590559065907590859095910591159125913591459155916591759185919592059215922592359245925592659275928592959305931593259335934593559365937593859395940594159425943594459455946594759485949595059515952595359545955595659575958595959605961596259635964596559665967596859695970597159725973597459755976597759785979598059815982598359845985598659875988598959905991599259935994599559965997599859996000600160026003600460056006600760086009601060116012601360146015601660176018601960206021602260236024602560266027602860296030603160326033603460356036603760386039604060416042604360446045604660476048604960506051605260536054605560566057605860596060606160626063606460656066606760686069607060716072607360746075607660776078607960806081608260836084608560866087608860896090609160926093609460956096609760986099610061016102610361046105610661076108610961106111611261136114611561166117611861196120612161226123612461256126612761286129613061316132613361346135613661376138613961406141614261436144614561466147614861496150615161526153615461556156615761586159616061616162616361646165616661676168616961706171617261736174617561766177617861796180618161826183618461856186618761886189619061916192619361946195619661976198619962006201620262036204620562066207620862096210621162126213621462156216621762186219622062216222622362246225622662276228622962306231623262336234623562366237623862396240624162426243624462456246624762486249625062516252625362546255625662576258625962606261626262636264626562666267626862696270627162726273627462756276627762786279628062816282628362846285628662876288628962906291629262936294629562966297629862996300630163026303630463056306630763086309631063116312631363146315631663176318631963206321632263236324632563266327632863296330633163326333633463356336633763386339634063416342634363446345634663476348634963506351635263536354635563566357635863596360636163626363636463656366636763686369637063716372637363746375637663776378637963806381638263836384638563866387638863896390639163926393639463956396639763986399640064016402640364046405640664076408640964106411641264136414641564166417641864196420642164226423642464256426642764286429643064316432643364346435643664376438643964406441644264436444644564466447644864496450645164526453645464556456645764586459646064616462646364646465646664676468646964706471647264736474647564766477647864796480648164826483648464856486648764886489649064916492649364946495649664976498649965006501650265036504650565066507650865096510651165126513651465156516651765186519652065216522652365246525652665276528652965306531653265336534653565366537653865396540654165426543654465456546654765486549655065516552655365546555655665576558655965606561656265636564656565666567656865696570657165726573657465756576657765786579658065816582658365846585658665876588658965906591659265936594659565966597659865996600660166026603660466056606660766086609661066116612661366146615661666176618661966206621662266236624662566266627662866296630663166326633663466356636663766386639664066416642664366446645664666476648664966506651665266536654665566566657665866596660666166626663666466656666666766686669667066716672667366746675667666776678667966806681668266836684668566866687668866896690669166926693669466956696669766986699670067016702670367046705670667076708670967106711671267136714671567166717671867196720672167226723672467256726672767286729673067316732673367346735673667376738673967406741674267436744674567466747674867496750675167526753675467556756675767586759676067616762676367646765676667676768676967706771677267736774677567766777677867796780678167826783678467856786678767886789679067916792679367946795679667976798679968006801680268036804680568066807680868096810681168126813681468156816681768186819682068216822682368246825682668276828682968306831683268336834683568366837683868396840684168426843684468456846684768486849685068516852685368546855685668576858685968606861686268636864686568666867686868696870687168726873687468756876687768786879688068816882688368846885688668876888688968906891689268936894689568966897689868996900690169026903690469056906690769086909691069116912691369146915691669176918691969206921692269236924692569266927692869296930693169326933693469356936693769386939694069416942694369446945694669476948694969506951695269536954695569566957695869596960696169626963696469656966696769686969697069716972697369746975697669776978697969806981698269836984698569866987698869896990699169926993699469956996699769986999700070017002700370047005700670077008700970107011701270137014701570167017701870197020702170227023702470257026702770287029703070317032703370347035703670377038703970407041704270437044704570467047704870497050705170527053705470557056705770587059706070617062706370647065706670677068706970707071707270737074707570767077707870797080708170827083708470857086708770887089709070917092709370947095709670977098709971007101710271037104710571067107710871097110711171127113711471157116711771187119712071217122712371247125712671277128712971307131713271337134713571367137713871397140714171427143714471457146714771487149715071517152715371547155715671577158715971607161716271637164716571667167716871697170717171727173717471757176717771787179718071817182718371847185718671877188718971907191719271937194719571967197719871997200720172027203720472057206720772087209721072117212721372147215721672177218721972207221722272237224722572267227722872297230723172327233723472357236723772387239724072417242724372447245724672477248724972507251725272537254725572567257725872597260726172627263726472657266726772687269727072717272727372747275727672777278727972807281728272837284728572867287728872897290729172927293729472957296729772987299730073017302730373047305730673077308730973107311731273137314731573167317731873197320732173227323732473257326732773287329733073317332733373347335733673377338733973407341734273437344734573467347734873497350735173527353735473557356735773587359736073617362736373647365736673677368736973707371737273737374737573767377737873797380738173827383738473857386738773887389739073917392739373947395739673977398739974007401740274037404740574067407740874097410741174127413741474157416741774187419742074217422742374247425742674277428742974307431743274337434743574367437743874397440744174427443744474457446744774487449745074517452745374547455745674577458745974607461746274637464746574667467746874697470747174727473747474757476747774787479748074817482748374847485748674877488748974907491749274937494749574967497749874997500750175027503750475057506750775087509751075117512751375147515751675177518751975207521752275237524752575267527752875297530753175327533753475357536753775387539754075417542754375447545754675477548754975507551755275537554755575567557755875597560756175627563756475657566756775687569757075717572757375747575757675777578757975807581758275837584758575867587758875897590759175927593759475957596759775987599760076017602760376047605760676077608760976107611761276137614761576167617761876197620762176227623762476257626762776287629763076317632763376347635763676377638763976407641764276437644764576467647764876497650765176527653765476557656765776587659766076617662766376647665766676677668766976707671767276737674767576767677767876797680768176827683768476857686768776887689769076917692769376947695769676977698769977007701770277037704770577067707770877097710771177127713771477157716771777187719772077217722772377247725772677277728772977307731773277337734773577367737773877397740774177427743774477457746774777487749775077517752775377547755775677577758775977607761776277637764776577667767776877697770777177727773777477757776777777787779778077817782778377847785778677877788778977907791779277937794779577967797779877997800780178027803780478057806780778087809781078117812781378147815781678177818781978207821782278237824782578267827782878297830783178327833783478357836783778387839784078417842784378447845784678477848784978507851785278537854785578567857785878597860786178627863786478657866786778687869787078717872787378747875787678777878787978807881788278837884788578867887788878897890789178927893789478957896789778987899790079017902790379047905790679077908790979107911791279137914791579167917791879197920792179227923792479257926792779287929793079317932793379347935793679377938793979407941794279437944794579467947794879497950795179527953795479557956795779587959796079617962796379647965796679677968796979707971797279737974797579767977797879797980798179827983798479857986798779887989799079917992799379947995799679977998799980008001800280038004800580068007800880098010801180128013801480158016801780188019802080218022802380248025802680278028802980308031803280338034803580368037803880398040804180428043804480458046804780488049805080518052805380548055805680578058805980608061806280638064806580668067806880698070807180728073807480758076807780788079808080818082808380848085808680878088808980908091809280938094809580968097809880998100810181028103810481058106810781088109811081118112811381148115811681178118811981208121812281238124812581268127812881298130813181328133813481358136813781388139814081418142814381448145814681478148814981508151815281538154815581568157815881598160816181628163816481658166816781688169817081718172817381748175817681778178817981808181818281838184818581868187818881898190819181928193819481958196819781988199820082018202820382048205820682078208820982108211821282138214821582168217821882198220822182228223822482258226822782288229823082318232823382348235823682378238823982408241824282438244824582468247824882498250825182528253825482558256825782588259826082618262826382648265826682678268826982708271827282738274827582768277827882798280828182828283828482858286828782888289829082918292829382948295829682978298829983008301830283038304830583068307830883098310831183128313831483158316831783188319832083218322832383248325832683278328832983308331833283338334833583368337833883398340834183428343834483458346834783488349835083518352835383548355835683578358835983608361836283638364836583668367836883698370837183728373837483758376837783788379838083818382838383848385838683878388838983908391839283938394839583968397839883998400840184028403840484058406840784088409841084118412841384148415841684178418841984208421842284238424842584268427842884298430843184328433843484358436843784388439844084418442844384448445844684478448844984508451845284538454845584568457845884598460846184628463846484658466846784688469847084718472847384748475847684778478847984808481848284838484848584868487848884898490849184928493849484958496849784988499850085018502850385048505850685078508850985108511851285138514851585168517851885198520852185228523852485258526852785288529853085318532853385348535853685378538853985408541854285438544854585468547854885498550855185528553855485558556855785588559856085618562856385648565856685678568856985708571857285738574857585768577857885798580858185828583858485858586858785888589859085918592859385948595859685978598859986008601860286038604860586068607860886098610861186128613861486158616861786188619862086218622862386248625862686278628862986308631863286338634863586368637863886398640864186428643864486458646864786488649865086518652865386548655865686578658865986608661866286638664866586668667866886698670867186728673867486758676867786788679868086818682868386848685868686878688868986908691869286938694869586968697869886998700870187028703870487058706870787088709871087118712871387148715871687178718871987208721872287238724872587268727872887298730873187328733873487358736873787388739874087418742874387448745874687478748874987508751875287538754875587568757875887598760876187628763876487658766876787688769877087718772877387748775877687778778877987808781878287838784878587868787878887898790879187928793879487958796879787988799880088018802880388048805880688078808880988108811881288138814881588168817881888198820882188228823882488258826882788288829883088318832883388348835883688378838883988408841884288438844884588468847884888498850885188528853885488558856885788588859886088618862886388648865886688678868886988708871887288738874887588768877887888798880888188828883888488858886888788888889889088918892889388948895889688978898889989008901890289038904890589068907890889098910891189128913891489158916891789188919892089218922892389248925892689278928892989308931893289338934893589368937893889398940894189428943894489458946894789488949895089518952895389548955895689578958895989608961896289638964896589668967896889698970897189728973897489758976897789788979898089818982898389848985898689878988898989908991899289938994899589968997899889999000900190029003900490059006900790089009901090119012901390149015901690179018901990209021902290239024902590269027902890299030903190329033903490359036903790389039904090419042904390449045904690479048904990509051905290539054905590569057905890599060906190629063906490659066906790689069907090719072907390749075907690779078907990809081908290839084908590869087908890899090909190929093909490959096909790989099910091019102910391049105910691079108910991109111911291139114911591169117911891199120912191229123912491259126912791289129913091319132913391349135913691379138913991409141914291439144914591469147914891499150915191529153915491559156915791589159916091619162916391649165916691679168916991709171917291739174917591769177917891799180918191829183918491859186918791889189919091919192919391949195919691979198919992009201920292039204920592069207920892099210921192129213921492159216921792189219922092219222922392249225922692279228922992309231923292339234923592369237923892399240924192429243924492459246924792489249925092519252925392549255925692579258925992609261926292639264926592669267926892699270927192729273927492759276927792789279928092819282928392849285928692879288928992909291929292939294929592969297929892999300930193029303930493059306930793089309931093119312931393149315931693179318931993209321932293239324932593269327932893299330933193329333933493359336933793389339934093419342934393449345934693479348934993509351935293539354935593569357935893599360936193629363936493659366936793689369937093719372937393749375937693779378937993809381938293839384938593869387938893899390939193929393939493959396939793989399940094019402940394049405940694079408940994109411941294139414941594169417941894199420942194229423942494259426942794289429943094319432943394349435943694379438943994409441944294439444944594469447944894499450945194529453945494559456945794589459946094619462946394649465946694679468946994709471947294739474947594769477947894799480948194829483948494859486948794889489949094919492949394949495949694979498949995009501950295039504950595069507950895099510951195129513951495159516951795189519952095219522952395249525952695279528952995309531953295339534953595369537953895399540954195429543954495459546954795489549955095519552955395549555955695579558955995609561956295639564956595669567956895699570957195729573957495759576957795789579958095819582958395849585958695879588958995909591959295939594959595969597959895999600960196029603960496059606960796089609961096119612961396149615961696179618961996209621962296239624962596269627962896299630963196329633963496359636963796389639964096419642964396449645964696479648964996509651965296539654965596569657965896599660966196629663966496659666966796689669967096719672967396749675967696779678967996809681968296839684968596869687968896899690969196929693969496959696969796989699970097019702970397049705970697079708970997109711971297139714971597169717971897199720972197229723972497259726972797289729973097319732973397349735973697379738973997409741974297439744974597469747974897499750975197529753975497559756975797589759976097619762976397649765976697679768976997709771977297739774977597769777977897799780978197829783978497859786978797889789979097919792979397949795979697979798979998009801980298039804980598069807980898099810981198129813981498159816981798189819982098219822982398249825982698279828982998309831983298339834983598369837983898399840984198429843984498459846984798489849985098519852985398549855985698579858985998609861986298639864986598669867986898699870987198729873987498759876987798789879988098819882988398849885988698879888988998909891989298939894989598969897989898999900990199029903990499059906990799089909991099119912991399149915991699179918991999209921992299239924992599269927992899299930993199329933993499359936993799389939994099419942994399449945994699479948994999509951995299539954995599569957995899599960996199629963996499659966996799689969997099719972997399749975997699779978997999809981998299839984998599869987998899899990999199929993999499959996999799989999100001000110002100031000410005100061000710008100091001010011100121001310014100151001610017100181001910020100211002210023100241002510026100271002810029100301003110032100331003410035100361003710038100391004010041100421004310044100451004610047100481004910050100511005210053100541005510056100571005810059100601006110062100631006410065100661006710068100691007010071100721007310074100751007610077100781007910080100811008210083100841008510086100871008810089100901009110092100931009410095100961009710098100991010010101101021010310104101051010610107101081010910110101111011210113101141011510116101171011810119101201012110122101231012410125101261012710128101291013010131101321013310134101351013610137101381013910140101411014210143101441014510146101471014810149101501015110152101531015410155101561015710158101591016010161101621016310164101651016610167101681016910170101711017210173101741017510176101771017810179101801018110182101831018410185101861018710188101891019010191101921019310194101951019610197101981019910200102011020210203102041020510206102071020810209102101021110212102131021410215102161021710218102191022010221102221022310224102251022610227102281022910230102311023210233102341023510236102371023810239102401024110242102431024410245102461024710248102491025010251102521025310254102551025610257102581025910260102611026210263102641026510266102671026810269102701027110272102731027410275102761027710278102791028010281102821028310284102851028610287102881028910290102911029210293102941029510296102971029810299103001030110302103031030410305103061030710308103091031010311103121031310314103151031610317103181031910320103211032210323103241032510326103271032810329103301033110332103331033410335103361033710338103391034010341103421034310344103451034610347103481034910350103511035210353103541035510356103571035810359103601036110362103631036410365103661036710368103691037010371103721037310374103751037610377103781037910380103811038210383103841038510386103871038810389103901039110392103931039410395103961039710398103991040010401104021040310404104051040610407104081040910410104111041210413104141041510416104171041810419104201042110422104231042410425104261042710428104291043010431104321043310434104351043610437104381043910440104411044210443104441044510446104471044810449104501045110452104531045410455104561045710458104591046010461104621046310464104651046610467104681046910470104711047210473104741047510476104771047810479104801048110482104831048410485104861048710488104891049010491104921049310494104951049610497104981049910500105011050210503105041050510506105071050810509105101051110512105131051410515105161051710518105191052010521105221052310524105251052610527105281052910530105311053210533105341053510536105371053810539105401054110542105431054410545105461054710548105491055010551105521055310554105551055610557105581055910560105611056210563105641056510566105671056810569105701057110572105731057410575105761057710578105791058010581105821058310584105851058610587105881058910590105911059210593105941059510596105971059810599106001060110602106031060410605106061060710608106091061010611106121061310614106151061610617106181061910620106211062210623106241062510626106271062810629106301063110632106331063410635106361063710638106391064010641106421064310644106451064610647106481064910650106511065210653106541065510656106571065810659106601066110662106631066410665106661066710668106691067010671106721067310674106751067610677106781067910680106811068210683106841068510686106871068810689106901069110692106931069410695106961069710698106991070010701107021070310704107051070610707107081070910710107111071210713107141071510716107171071810719107201072110722107231072410725107261072710728107291073010731107321073310734107351073610737107381073910740107411074210743107441074510746107471074810749107501075110752107531075410755107561075710758107591076010761107621076310764107651076610767107681076910770107711077210773107741077510776107771077810779107801078110782107831078410785107861078710788107891079010791107921079310794107951079610797107981079910800108011080210803108041080510806108071080810809108101081110812108131081410815108161081710818108191082010821108221082310824108251082610827108281082910830108311083210833108341083510836108371083810839108401084110842108431084410845108461084710848108491085010851108521085310854108551085610857108581085910860108611086210863108641086510866108671086810869108701087110872108731087410875108761087710878108791088010881108821088310884108851088610887108881088910890108911089210893108941089510896108971089810899109001090110902109031090410905109061090710908109091091010911109121091310914109151091610917109181091910920109211092210923109241092510926109271092810929109301093110932109331093410935109361093710938109391094010941109421094310944109451094610947109481094910950109511095210953109541095510956109571095810959109601096110962109631096410965109661096710968109691097010971109721097310974109751097610977109781097910980109811098210983109841098510986109871098810989109901099110992109931099410995109961099710998109991100011001110021100311004110051100611007110081100911010110111101211013110141101511016110171101811019110201102111022110231102411025110261102711028110291103011031110321103311034110351103611037110381103911040110411104211043110441104511046110471104811049110501105111052110531105411055110561105711058110591106011061110621106311064110651106611067110681106911070110711107211073110741107511076110771107811079110801108111082110831108411085110861108711088110891109011091110921109311094110951109611097110981109911100111011110211103111041110511106111071110811109111101111111112111131111411115111161111711118111191112011121111221112311124111251112611127111281112911130111311113211133111341113511136111371113811139111401114111142111431114411145111461114711148111491115011151111521115311154111551115611157111581115911160111611116211163111641116511166111671116811169111701117111172111731117411175111761117711178111791118011181111821118311184111851118611187111881118911190111911119211193111941119511196111971119811199112001120111202112031120411205112061120711208112091121011211112121121311214112151121611217112181121911220112211122211223112241122511226112271122811229112301123111232112331123411235112361123711238112391124011241112421124311244112451124611247112481124911250112511125211253112541125511256112571125811259112601126111262112631126411265112661126711268112691127011271112721127311274112751127611277112781127911280112811128211283112841128511286112871128811289112901129111292112931129411295112961129711298112991130011301113021130311304113051130611307113081130911310113111131211313113141131511316113171131811319113201132111322113231132411325113261132711328113291133011331113321133311334113351133611337113381133911340113411134211343113441134511346113471134811349113501135111352113531135411355113561135711358113591136011361113621136311364113651136611367113681136911370113711137211373113741137511376113771137811379113801138111382113831138411385113861138711388113891139011391113921139311394113951139611397113981139911400114011140211403114041140511406114071140811409114101141111412114131141411415114161141711418114191142011421114221142311424114251142611427114281142911430114311143211433114341143511436114371143811439114401144111442114431144411445114461144711448114491145011451114521145311454114551145611457114581145911460114611146211463114641146511466114671146811469114701147111472114731147411475114761147711478114791148011481114821148311484114851148611487114881148911490114911149211493114941149511496114971149811499115001150111502115031150411505115061150711508115091151011511115121151311514115151151611517115181151911520115211152211523115241152511526115271152811529115301153111532115331153411535115361153711538115391154011541115421154311544115451154611547115481154911550115511155211553115541155511556115571155811559115601156111562115631156411565115661156711568115691157011571115721157311574115751157611577115781157911580115811158211583115841158511586115871158811589115901159111592115931159411595115961159711598115991160011601116021160311604116051160611607116081160911610116111161211613116141161511616116171161811619116201162111622116231162411625116261162711628116291163011631116321163311634116351163611637116381163911640116411164211643116441164511646116471164811649116501165111652116531165411655116561165711658116591166011661116621166311664116651166611667116681166911670116711167211673116741167511676116771167811679116801168111682116831168411685116861168711688116891169011691116921169311694116951169611697116981169911700117011170211703117041170511706117071170811709117101171111712117131171411715117161171711718117191172011721117221172311724117251172611727117281172911730117311173211733117341173511736117371173811739117401174111742117431174411745117461174711748117491175011751117521175311754117551175611757117581175911760117611176211763117641176511766117671176811769117701177111772117731177411775117761177711778117791178011781117821178311784117851178611787117881178911790117911179211793117941179511796117971179811799118001180111802118031180411805118061180711808118091181011811118121181311814118151181611817118181181911820118211182211823118241182511826118271182811829118301183111832118331183411835118361183711838118391184011841118421184311844118451184611847118481184911850118511185211853118541185511856118571185811859118601186111862118631186411865118661186711868118691187011871118721187311874118751187611877118781187911880118811188211883118841188511886118871188811889118901189111892118931189411895118961189711898118991190011901119021190311904119051190611907119081190911910119111191211913119141191511916119171191811919119201192111922119231192411925119261192711928119291193011931119321193311934119351193611937119381193911940119411194211943119441194511946119471194811949119501195111952119531195411955119561195711958119591196011961119621196311964119651196611967119681196911970119711197211973119741197511976119771197811979119801198111982119831198411985119861198711988119891199011991119921199311994119951199611997119981199912000120011200212003120041200512006120071200812009120101201112012120131201412015120161201712018120191202012021120221202312024120251202612027120281202912030120311203212033120341203512036120371203812039120401204112042120431204412045120461204712048120491205012051120521205312054120551205612057120581205912060120611206212063120641206512066120671206812069120701207112072120731207412075120761207712078120791208012081120821208312084120851208612087120881208912090120911209212093120941209512096120971209812099121001210112102121031210412105121061210712108121091211012111121121211312114121151211612117121181211912120121211212212123121241212512126121271212812129121301213112132121331213412135121361213712138121391214012141121421214312144121451214612147121481214912150121511215212153121541215512156121571215812159121601216112162121631216412165121661216712168121691217012171121721217312174121751217612177121781217912180121811218212183121841218512186121871218812189121901219112192121931219412195121961219712198121991220012201122021220312204122051220612207122081220912210122111221212213122141221512216122171221812219122201222112222122231222412225122261222712228122291223012231122321223312234122351223612237122381223912240122411224212243122441224512246122471224812249122501225112252122531225412255122561225712258122591226012261122621226312264122651226612267122681226912270122711227212273122741227512276122771227812279122801228112282122831228412285122861228712288122891229012291122921229312294122951229612297122981229912300123011230212303123041230512306123071230812309123101231112312123131231412315123161231712318123191232012321123221232312324123251232612327123281232912330123311233212333123341233512336123371233812339123401234112342123431234412345123461234712348123491235012351123521235312354123551235612357123581235912360123611236212363123641236512366123671236812369123701237112372123731237412375123761237712378123791238012381123821238312384123851238612387123881238912390123911239212393123941239512396123971239812399124001240112402124031240412405124061240712408124091241012411124121241312414124151241612417124181241912420124211242212423124241242512426124271242812429124301243112432124331243412435124361243712438124391244012441124421244312444124451244612447124481244912450124511245212453124541245512456124571245812459124601246112462124631246412465124661246712468124691247012471124721247312474124751247612477124781247912480124811248212483124841248512486124871248812489124901249112492124931249412495124961249712498124991250012501125021250312504125051250612507125081250912510125111251212513125141251512516125171251812519125201252112522125231252412525125261252712528125291253012531125321253312534125351253612537125381253912540125411254212543125441254512546125471254812549125501255112552125531255412555125561255712558125591256012561125621256312564125651256612567125681256912570125711257212573125741257512576125771257812579125801258112582125831258412585125861258712588125891259012591125921259312594125951259612597125981259912600126011260212603126041260512606126071260812609126101261112612126131261412615126161261712618126191262012621126221262312624126251262612627126281262912630126311263212633126341263512636126371263812639126401264112642126431264412645126461264712648126491265012651126521265312654126551265612657126581265912660126611266212663126641266512666126671266812669126701267112672126731267412675126761267712678126791268012681126821268312684126851268612687126881268912690126911269212693126941269512696126971269812699127001270112702127031270412705127061270712708127091271012711127121271312714127151271612717127181271912720127211272212723127241272512726127271272812729127301273112732127331273412735127361273712738127391274012741127421274312744127451274612747127481274912750127511275212753127541275512756127571275812759127601276112762127631276412765127661276712768127691277012771127721277312774127751277612777127781277912780127811278212783127841278512786127871278812789127901279112792127931279412795127961279712798127991280012801128021280312804128051280612807128081280912810128111281212813128141281512816128171281812819128201282112822128231282412825128261282712828128291283012831128321283312834128351283612837128381283912840128411284212843128441284512846128471284812849128501285112852128531285412855128561285712858128591286012861128621286312864128651286612867128681286912870128711287212873128741287512876128771287812879128801288112882128831288412885128861288712888128891289012891128921289312894128951289612897128981289912900129011290212903129041290512906129071290812909129101291112912129131291412915129161291712918129191292012921129221292312924129251292612927129281292912930129311293212933129341293512936129371293812939129401294112942129431294412945129461294712948129491295012951129521295312954129551295612957129581295912960129611296212963129641296512966129671296812969129701297112972129731297412975129761297712978129791298012981129821298312984129851298612987129881298912990129911299212993129941299512996129971299812999130001300113002130031300413005130061300713008130091301013011130121301313014130151301613017130181301913020130211302213023130241302513026130271302813029130301303113032130331303413035130361303713038130391304013041130421304313044130451304613047130481304913050130511305213053130541305513056130571305813059130601306113062130631306413065130661306713068130691307013071130721307313074130751307613077130781307913080130811308213083130841308513086130871308813089130901309113092130931309413095130961309713098130991310013101131021310313104131051310613107131081310913110131111311213113131141311513116131171311813119131201312113122131231312413125131261312713128131291313013131131321313313134131351313613137131381313913140131411314213143131441314513146131471314813149131501315113152131531315413155131561315713158131591316013161131621316313164131651316613167131681316913170131711317213173131741317513176131771317813179131801318113182131831318413185131861318713188131891319013191131921319313194131951319613197131981319913200132011320213203132041320513206132071320813209132101321113212132131321413215132161321713218132191322013221132221322313224132251322613227132281322913230132311323213233132341323513236132371323813239132401324113242132431324413245132461324713248132491325013251132521325313254132551325613257132581325913260132611326213263132641326513266132671326813269132701327113272132731327413275132761327713278132791328013281132821328313284132851328613287132881328913290132911329213293132941329513296132971329813299133001330113302133031330413305133061330713308133091331013311133121331313314133151331613317133181331913320133211332213323133241332513326133271332813329133301333113332133331333413335133361333713338133391334013341133421334313344133451334613347133481334913350133511335213353133541335513356133571335813359133601336113362133631336413365133661336713368133691337013371133721337313374133751337613377133781337913380133811338213383133841338513386133871338813389133901339113392133931339413395133961339713398133991340013401134021340313404134051340613407134081340913410134111341213413134141341513416134171341813419134201342113422134231342413425134261342713428134291343013431134321343313434134351343613437134381343913440134411344213443134441344513446134471344813449134501345113452134531345413455134561345713458134591346013461134621346313464134651346613467134681346913470134711347213473134741347513476134771347813479134801348113482134831348413485134861348713488134891349013491134921349313494134951349613497134981349913500135011350213503135041350513506135071350813509135101351113512135131351413515135161351713518135191352013521135221352313524135251352613527135281352913530135311353213533135341353513536135371353813539135401354113542135431354413545135461354713548135491355013551135521355313554135551355613557135581355913560135611356213563135641356513566135671356813569135701357113572135731357413575135761357713578135791358013581135821358313584135851358613587135881358913590135911359213593135941359513596135971359813599136001360113602136031360413605136061360713608136091361013611136121361313614136151361613617136181361913620136211362213623136241362513626136271362813629136301363113632136331363413635136361363713638136391364013641136421364313644136451364613647136481364913650136511365213653136541365513656136571365813659136601366113662136631366413665136661366713668136691367013671136721367313674136751367613677136781367913680136811368213683136841368513686136871368813689136901369113692136931369413695136961369713698136991370013701137021370313704137051370613707137081370913710137111371213713137141371513716137171371813719137201372113722137231372413725137261372713728137291373013731137321373313734137351373613737137381373913740137411374213743137441374513746137471374813749137501375113752137531375413755137561375713758137591376013761137621376313764137651376613767137681376913770137711377213773137741377513776137771377813779137801378113782137831378413785137861378713788137891379013791137921379313794137951379613797137981379913800138011380213803138041380513806138071380813809138101381113812138131381413815138161381713818138191382013821138221382313824138251382613827138281382913830138311383213833138341383513836138371383813839138401384113842138431384413845138461384713848138491385013851138521385313854138551385613857138581385913860138611386213863138641386513866138671386813869138701387113872138731387413875138761387713878138791388013881138821388313884138851388613887138881388913890138911389213893138941389513896138971389813899139001390113902139031390413905139061390713908139091391013911139121391313914139151391613917139181391913920139211392213923139241392513926139271392813929139301393113932139331393413935139361393713938139391394013941139421394313944139451394613947139481394913950139511395213953139541395513956139571395813959139601396113962139631396413965139661396713968139691397013971139721397313974139751397613977139781397913980139811398213983139841398513986139871398813989139901399113992139931399413995139961399713998139991400014001140021400314004140051400614007140081400914010140111401214013140141401514016140171401814019140201402114022140231402414025140261402714028140291403014031140321403314034140351403614037140381403914040140411404214043140441404514046140471404814049140501405114052140531405414055140561405714058140591406014061140621406314064140651406614067140681406914070140711407214073140741407514076140771407814079140801408114082140831408414085140861408714088140891409014091140921409314094140951409614097140981409914100141011410214103141041410514106141071410814109141101411114112141131411414115141161411714118141191412014121141221412314124141251412614127141281412914130141311413214133141341413514136141371413814139141401414114142141431414414145141461414714148141491415014151141521415314154141551415614157141581415914160141611416214163141641416514166141671416814169141701417114172141731417414175141761417714178141791418014181141821418314184141851418614187141881418914190141911419214193141941419514196141971419814199142001420114202142031420414205142061420714208142091421014211142121421314214142151421614217142181421914220142211422214223142241422514226142271422814229142301423114232142331423414235142361423714238142391424014241142421424314244142451424614247142481424914250142511425214253142541425514256142571425814259142601426114262142631426414265142661426714268142691427014271142721427314274142751427614277142781427914280142811428214283142841428514286142871428814289142901429114292142931429414295142961429714298142991430014301143021430314304143051430614307143081430914310143111431214313143141431514316143171431814319143201432114322143231432414325143261432714328143291433014331143321433314334143351433614337143381433914340143411434214343143441434514346143471434814349143501435114352143531435414355143561435714358143591436014361143621436314364143651436614367143681436914370143711437214373143741437514376143771437814379143801438114382143831438414385143861438714388143891439014391143921439314394143951439614397143981439914400144011440214403144041440514406144071440814409144101441114412144131441414415144161441714418144191442014421144221442314424144251442614427144281442914430144311443214433144341443514436144371443814439144401444114442144431444414445144461444714448144491445014451144521445314454144551445614457144581445914460144611446214463144641446514466144671446814469144701447114472144731447414475144761447714478144791448014481144821448314484144851448614487144881448914490144911449214493144941449514496144971449814499145001450114502145031450414505145061450714508145091451014511145121451314514145151451614517145181451914520145211452214523145241452514526145271452814529145301453114532145331453414535145361453714538145391454014541145421454314544145451454614547145481454914550145511455214553145541455514556145571455814559145601456114562145631456414565145661456714568145691457014571145721457314574145751457614577145781457914580145811458214583145841458514586145871458814589145901459114592145931459414595145961459714598145991460014601146021460314604146051460614607146081460914610146111461214613146141461514616146171461814619146201462114622146231462414625146261462714628146291463014631146321463314634146351463614637146381463914640146411464214643146441464514646146471464814649146501465114652146531465414655146561465714658146591466014661146621466314664146651466614667146681466914670146711467214673146741467514676146771467814679146801468114682146831468414685146861468714688146891469014691146921469314694146951469614697146981469914700147011470214703147041470514706147071470814709147101471114712147131471414715147161471714718147191472014721147221472314724147251472614727147281472914730147311473214733147341473514736147371473814739147401474114742147431474414745147461474714748147491475014751147521475314754147551475614757147581475914760147611476214763147641476514766147671476814769147701477114772147731477414775147761477714778147791478014781147821478314784147851478614787147881478914790147911479214793147941479514796147971479814799148001480114802148031480414805148061480714808148091481014811148121481314814148151481614817148181481914820148211482214823148241482514826148271482814829148301483114832148331483414835148361483714838148391484014841148421484314844148451484614847148481484914850148511485214853148541485514856148571485814859148601486114862148631486414865148661486714868148691487014871148721487314874148751487614877148781487914880148811488214883148841488514886148871488814889148901489114892148931489414895148961489714898148991490014901149021490314904149051490614907149081490914910149111491214913149141491514916149171491814919149201492114922149231492414925149261492714928149291493014931149321493314934149351493614937149381493914940149411494214943149441494514946149471494814949149501495114952149531495414955149561495714958149591496014961149621496314964149651496614967149681496914970149711497214973149741497514976149771497814979149801498114982149831498414985149861498714988149891499014991149921499314994149951499614997149981499915000150011500215003150041500515006150071500815009150101501115012150131501415015150161501715018150191502015021150221502315024150251502615027150281502915030150311503215033150341503515036150371503815039150401504115042150431504415045150461504715048150491505015051150521505315054150551505615057150581505915060150611506215063150641506515066150671506815069150701507115072150731507415075150761507715078150791508015081150821508315084150851508615087150881508915090150911509215093150941509515096150971509815099151001510115102151031510415105151061510715108151091511015111151121511315114151151511615117151181511915120151211512215123151241512515126151271512815129151301513115132151331513415135151361513715138151391514015141151421514315144151451514615147151481514915150151511515215153151541515515156151571515815159151601516115162151631516415165151661516715168151691517015171151721517315174151751517615177151781517915180151811518215183151841518515186151871518815189151901519115192151931519415195151961519715198151991520015201152021520315204152051520615207152081520915210152111521215213152141521515216152171521815219152201522115222152231522415225152261522715228152291523015231152321523315234152351523615237152381523915240152411524215243152441524515246152471524815249152501525115252152531525415255152561525715258152591526015261152621526315264152651526615267152681526915270152711527215273152741527515276152771527815279152801528115282152831528415285152861528715288152891529015291152921529315294152951529615297152981529915300153011530215303153041530515306153071530815309153101531115312153131531415315153161531715318153191532015321153221532315324153251532615327153281532915330153311533215333153341533515336153371533815339153401534115342153431534415345153461534715348153491535015351153521535315354153551535615357153581535915360153611536215363153641536515366153671536815369153701537115372153731537415375153761537715378153791538015381153821538315384153851538615387153881538915390153911539215393153941539515396153971539815399154001540115402154031540415405154061540715408154091541015411154121541315414154151541615417154181541915420154211542215423154241542515426154271542815429154301543115432154331543415435154361543715438154391544015441154421544315444154451544615447154481544915450154511545215453154541545515456154571545815459154601546115462154631546415465154661546715468154691547015471154721547315474154751547615477154781547915480154811548215483154841548515486154871548815489154901549115492154931549415495154961549715498154991550015501155021550315504155051550615507155081550915510155111551215513155141551515516155171551815519155201552115522155231552415525155261552715528155291553015531155321553315534155351553615537155381553915540155411554215543155441554515546155471554815549155501555115552155531555415555155561555715558155591556015561155621556315564155651556615567155681556915570155711557215573155741557515576155771557815579155801558115582155831558415585155861558715588155891559015591155921559315594155951559615597155981559915600156011560215603156041560515606156071560815609156101561115612156131561415615156161561715618156191562015621156221562315624156251562615627156281562915630156311563215633156341563515636156371563815639156401564115642156431564415645156461564715648156491565015651156521565315654156551565615657156581565915660156611566215663156641566515666156671566815669156701567115672156731567415675156761567715678156791568015681156821568315684156851568615687156881568915690156911569215693156941569515696156971569815699157001570115702157031570415705157061570715708157091571015711157121571315714157151571615717157181571915720157211572215723157241572515726157271572815729157301573115732157331573415735157361573715738157391574015741157421574315744157451574615747157481574915750157511575215753157541575515756157571575815759157601576115762157631576415765157661576715768157691577015771157721577315774157751577615777157781577915780157811578215783157841578515786157871578815789157901579115792157931579415795157961579715798157991580015801158021580315804158051580615807158081580915810158111581215813158141581515816158171581815819158201582115822158231582415825158261582715828158291583015831158321583315834158351583615837158381583915840158411584215843158441584515846158471584815849158501585115852158531585415855158561585715858158591586015861158621586315864158651586615867158681586915870158711587215873158741587515876158771587815879158801588115882158831588415885158861588715888158891589015891158921589315894158951589615897158981589915900159011590215903159041590515906159071590815909159101591115912159131591415915159161591715918159191592015921159221592315924159251592615927159281592915930159311593215933159341593515936159371593815939159401594115942159431594415945159461594715948159491595015951159521595315954159551595615957159581595915960159611596215963159641596515966159671596815969159701597115972159731597415975159761597715978159791598015981159821598315984159851598615987159881598915990159911599215993159941599515996159971599815999160001600116002160031600416005160061600716008160091601016011160121601316014160151601616017160181601916020160211602216023160241602516026160271602816029160301603116032160331603416035160361603716038160391604016041160421604316044160451604616047160481604916050160511605216053160541605516056160571605816059160601606116062160631606416065160661606716068160691607016071160721607316074160751607616077160781607916080160811608216083160841608516086160871608816089160901609116092160931609416095160961609716098160991610016101161021610316104161051610616107161081610916110161111611216113161141611516116161171611816119161201612116122161231612416125161261612716128161291613016131161321613316134161351613616137161381613916140161411614216143161441614516146161471614816149161501615116152161531615416155161561615716158161591616016161161621616316164161651616616167161681616916170161711617216173161741617516176161771617816179161801618116182161831618416185161861618716188161891619016191161921619316194161951619616197161981619916200162011620216203162041620516206162071620816209162101621116212162131621416215162161621716218162191622016221162221622316224162251622616227162281622916230162311623216233162341623516236162371623816239162401624116242162431624416245162461624716248162491625016251162521625316254162551625616257162581625916260162611626216263162641626516266162671626816269162701627116272162731627416275162761627716278162791628016281162821628316284162851628616287162881628916290162911629216293162941629516296162971629816299163001630116302163031630416305163061630716308163091631016311163121631316314163151631616317163181631916320163211632216323163241632516326163271632816329163301633116332163331633416335163361633716338163391634016341163421634316344163451634616347163481634916350163511635216353163541635516356163571635816359163601636116362163631636416365163661636716368163691637016371163721637316374163751637616377163781637916380163811638216383163841638516386163871638816389163901639116392163931639416395163961639716398163991640016401164021640316404164051640616407164081640916410164111641216413164141641516416164171641816419164201642116422164231642416425164261642716428164291643016431164321643316434164351643616437164381643916440164411644216443164441644516446164471644816449164501645116452164531645416455164561645716458164591646016461164621646316464164651646616467164681646916470164711647216473164741647516476164771647816479164801648116482164831648416485164861648716488164891649016491164921649316494164951649616497164981649916500165011650216503165041650516506165071650816509165101651116512165131651416515165161651716518165191652016521165221652316524165251652616527165281652916530165311653216533165341653516536165371653816539165401654116542165431654416545165461654716548165491655016551165521655316554165551655616557165581655916560165611656216563165641656516566165671656816569165701657116572165731657416575165761657716578165791658016581165821658316584165851658616587165881658916590165911659216593165941659516596165971659816599166001660116602166031660416605166061660716608166091661016611166121661316614166151661616617166181661916620166211662216623166241662516626166271662816629166301663116632166331663416635166361663716638166391664016641166421664316644166451664616647166481664916650166511665216653166541665516656166571665816659166601666116662166631666416665166661666716668166691667016671166721667316674166751667616677166781667916680166811668216683166841668516686166871668816689166901669116692166931669416695166961669716698166991670016701167021670316704167051670616707167081670916710167111671216713167141671516716167171671816719167201672116722167231672416725167261672716728167291673016731167321673316734167351673616737167381673916740167411674216743167441674516746167471674816749167501675116752167531675416755167561675716758167591676016761167621676316764167651676616767167681676916770167711677216773167741677516776167771677816779167801678116782167831678416785167861678716788167891679016791167921679316794167951679616797167981679916800168011680216803168041680516806168071680816809168101681116812168131681416815168161681716818168191682016821168221682316824168251682616827168281682916830168311683216833168341683516836168371683816839168401684116842168431684416845168461684716848168491685016851168521685316854168551685616857168581685916860168611686216863168641686516866168671686816869168701687116872168731687416875168761687716878168791688016881168821688316884168851688616887168881688916890168911689216893168941689516896168971689816899169001690116902169031690416905169061690716908169091691016911169121691316914169151691616917169181691916920169211692216923169241692516926169271692816929169301693116932169331693416935169361693716938169391694016941169421694316944169451694616947169481694916950169511695216953169541695516956169571695816959169601696116962169631696416965169661696716968169691697016971169721697316974169751697616977169781697916980169811698216983169841698516986169871698816989169901699116992169931699416995169961699716998169991700017001170021700317004170051700617007170081700917010170111701217013170141701517016170171701817019170201702117022170231702417025170261702717028170291703017031170321703317034170351703617037170381703917040170411704217043170441704517046170471704817049170501705117052170531705417055170561705717058170591706017061170621706317064170651706617067170681706917070170711707217073170741707517076170771707817079170801708117082170831708417085170861708717088170891709017091170921709317094170951709617097170981709917100171011710217103171041710517106171071710817109171101711117112171131711417115171161711717118171191712017121171221712317124171251712617127171281712917130171311713217133171341713517136171371713817139171401714117142171431714417145171461714717148171491715017151171521715317154171551715617157171581715917160171611716217163171641716517166171671716817169171701717117172171731717417175171761717717178171791718017181171821718317184171851718617187171881718917190171911719217193171941719517196171971719817199172001720117202172031720417205172061720717208172091721017211172121721317214172151721617217172181721917220172211722217223172241722517226172271722817229172301723117232172331723417235172361723717238172391724017241172421724317244172451724617247172481724917250172511725217253172541725517256172571725817259172601726117262172631726417265172661726717268172691727017271172721727317274172751727617277172781727917280172811728217283172841728517286172871728817289172901729117292172931729417295172961729717298172991730017301173021730317304173051730617307173081730917310173111731217313173141731517316173171731817319173201732117322173231732417325173261732717328173291733017331173321733317334173351733617337173381733917340173411734217343173441734517346173471734817349173501735117352173531735417355173561735717358173591736017361173621736317364173651736617367173681736917370173711737217373173741737517376173771737817379173801738117382173831738417385173861738717388173891739017391173921739317394173951739617397173981739917400174011740217403174041740517406174071740817409174101741117412174131741417415174161741717418174191742017421174221742317424174251742617427174281742917430174311743217433174341743517436174371743817439174401744117442174431744417445174461744717448174491745017451174521745317454174551745617457174581745917460174611746217463174641746517466174671746817469174701747117472174731747417475174761747717478174791748017481174821748317484174851748617487174881748917490174911749217493174941749517496174971749817499175001750117502175031750417505175061750717508175091751017511175121751317514175151751617517175181751917520175211752217523175241752517526175271752817529175301753117532175331753417535175361753717538175391754017541175421754317544175451754617547175481754917550175511755217553175541755517556175571755817559175601756117562175631756417565175661756717568175691757017571175721757317574175751757617577175781757917580175811758217583175841758517586175871758817589175901759117592175931759417595175961759717598175991760017601176021760317604176051760617607176081760917610176111761217613176141761517616176171761817619176201762117622176231762417625176261762717628176291763017631176321763317634176351763617637176381763917640176411764217643176441764517646176471764817649176501765117652176531765417655176561765717658176591766017661176621766317664176651766617667176681766917670176711767217673176741767517676176771767817679176801768117682176831768417685176861768717688176891769017691176921769317694176951769617697176981769917700177011770217703177041770517706177071770817709177101771117712177131771417715177161771717718177191772017721177221772317724177251772617727177281772917730177311773217733177341773517736177371773817739177401774117742177431774417745177461774717748177491775017751177521775317754177551775617757177581775917760177611776217763177641776517766177671776817769177701777117772177731777417775177761777717778177791778017781177821778317784177851778617787177881778917790177911779217793177941779517796177971779817799178001780117802178031780417805178061780717808178091781017811178121781317814178151781617817178181781917820178211782217823178241782517826178271782817829178301783117832178331783417835178361783717838178391784017841178421784317844178451784617847178481784917850178511785217853178541785517856178571785817859178601786117862178631786417865178661786717868178691787017871178721787317874178751787617877178781787917880178811788217883178841788517886178871788817889178901789117892178931789417895178961789717898178991790017901179021790317904179051790617907179081790917910179111791217913179141791517916179171791817919179201792117922179231792417925179261792717928179291793017931179321793317934179351793617937179381793917940179411794217943179441794517946179471794817949179501795117952179531795417955179561795717958179591796017961179621796317964179651796617967179681796917970179711797217973179741797517976179771797817979179801798117982179831798417985179861798717988179891799017991179921799317994179951799617997179981799918000180011800218003180041800518006180071800818009180101801118012180131801418015180161801718018180191802018021180221802318024180251802618027180281802918030180311803218033180341803518036180371803818039180401804118042180431804418045180461804718048180491805018051180521805318054180551805618057180581805918060180611806218063180641806518066180671806818069180701807118072180731807418075180761807718078180791808018081180821808318084180851808618087180881808918090180911809218093180941809518096180971809818099181001810118102181031810418105181061810718108181091811018111181121811318114181151811618117181181811918120181211812218123181241812518126181271812818129181301813118132181331813418135181361813718138181391814018141181421814318144181451814618147181481814918150181511815218153181541815518156181571815818159181601816118162181631816418165181661816718168181691817018171181721817318174181751817618177181781817918180181811818218183181841818518186181871818818189181901819118192181931819418195181961819718198181991820018201182021820318204182051820618207182081820918210182111821218213182141821518216182171821818219182201822118222182231822418225182261822718228182291823018231182321823318234182351823618237182381823918240182411824218243182441824518246182471824818249182501825118252182531825418255182561825718258182591826018261182621826318264182651826618267182681826918270182711827218273182741827518276182771827818279182801828118282182831828418285182861828718288182891829018291182921829318294182951829618297182981829918300183011830218303183041830518306183071830818309183101831118312183131831418315183161831718318183191832018321183221832318324183251832618327183281832918330183311833218333183341833518336183371833818339183401834118342183431834418345183461834718348183491835018351183521835318354183551835618357183581835918360183611836218363183641836518366183671836818369183701837118372183731837418375183761837718378183791838018381183821838318384183851838618387183881838918390183911839218393183941839518396183971839818399184001840118402184031840418405184061840718408184091841018411184121841318414184151841618417184181841918420184211842218423184241842518426184271842818429184301843118432184331843418435184361843718438184391844018441184421844318444184451844618447184481844918450184511845218453184541845518456184571845818459184601846118462184631846418465184661846718468184691847018471184721847318474184751847618477184781847918480184811848218483184841848518486184871848818489184901849118492184931849418495184961849718498184991850018501185021850318504185051850618507185081850918510185111851218513185141851518516185171851818519185201852118522185231852418525185261852718528185291853018531185321853318534185351853618537185381853918540185411854218543185441854518546185471854818549185501855118552185531855418555185561855718558185591856018561185621856318564185651856618567185681856918570185711857218573185741857518576185771857818579185801858118582185831858418585185861858718588185891859018591185921859318594185951859618597185981859918600186011860218603186041860518606186071860818609186101861118612186131861418615186161861718618186191862018621186221862318624186251862618627186281862918630186311863218633186341863518636186371863818639186401864118642186431864418645186461864718648186491865018651186521865318654186551865618657186581865918660186611866218663186641866518666186671866818669186701867118672186731867418675186761867718678186791868018681186821868318684186851868618687186881868918690186911869218693186941869518696186971869818699187001870118702187031870418705187061870718708187091871018711187121871318714187151871618717187181871918720187211872218723187241872518726187271872818729187301873118732187331873418735187361873718738187391874018741187421874318744187451874618747187481874918750187511875218753187541875518756187571875818759187601876118762187631876418765187661876718768187691877018771187721877318774187751877618777187781877918780187811878218783187841878518786187871878818789187901879118792187931879418795187961879718798187991880018801188021880318804188051880618807188081880918810188111881218813188141881518816188171881818819188201882118822188231882418825188261882718828188291883018831188321883318834188351883618837188381883918840188411884218843188441884518846188471884818849188501885118852188531885418855188561885718858188591886018861188621886318864188651886618867188681886918870188711887218873188741887518876188771887818879188801888118882188831888418885188861888718888188891889018891188921889318894188951889618897188981889918900189011890218903189041890518906189071890818909189101891118912189131891418915189161891718918189191892018921189221892318924189251892618927189281892918930189311893218933189341893518936189371893818939189401894118942189431894418945189461894718948189491895018951189521895318954189551895618957189581895918960189611896218963189641896518966189671896818969189701897118972189731897418975189761897718978189791898018981189821898318984189851898618987189881898918990189911899218993189941899518996189971899818999190001900119002190031900419005190061900719008190091901019011190121901319014190151901619017190181901919020190211902219023190241902519026190271902819029190301903119032190331903419035190361903719038190391904019041190421904319044190451904619047190481904919050190511905219053190541905519056190571905819059190601906119062190631906419065190661906719068190691907019071190721907319074190751907619077190781907919080190811908219083190841908519086190871908819089190901909119092190931909419095190961909719098190991910019101191021910319104191051910619107191081910919110191111911219113191141911519116191171911819119191201912119122191231912419125191261912719128191291913019131191321913319134191351913619137191381913919140191411914219143191441914519146191471914819149191501915119152191531915419155191561915719158191591916019161191621916319164191651916619167191681916919170191711917219173191741917519176191771917819179191801918119182191831918419185191861918719188191891919019191191921919319194191951919619197191981919919200192011920219203192041920519206192071920819209192101921119212192131921419215192161921719218192191922019221192221922319224192251922619227192281922919230192311923219233192341923519236192371923819239192401924119242192431924419245192461924719248192491925019251192521925319254192551925619257192581925919260192611926219263192641926519266192671926819269192701927119272192731927419275192761927719278192791928019281192821928319284192851928619287192881928919290192911929219293192941929519296192971929819299193001930119302193031930419305193061930719308193091931019311193121931319314193151931619317193181931919320193211932219323193241932519326193271932819329193301933119332193331933419335193361933719338193391934019341193421934319344193451934619347193481934919350193511935219353193541935519356193571935819359193601936119362193631936419365193661936719368193691937019371193721937319374193751937619377193781937919380193811938219383193841938519386193871938819389193901939119392193931939419395193961939719398193991940019401194021940319404194051940619407194081940919410194111941219413194141941519416194171941819419194201942119422194231942419425194261942719428194291943019431194321943319434194351943619437194381943919440194411944219443194441944519446194471944819449194501945119452194531945419455194561945719458194591946019461194621946319464194651946619467194681946919470194711947219473194741947519476194771947819479194801948119482194831948419485194861948719488194891949019491194921949319494194951949619497194981949919500195011950219503195041950519506195071950819509195101951119512195131951419515195161951719518195191952019521195221952319524195251952619527195281952919530195311953219533195341953519536195371953819539195401954119542195431954419545195461954719548195491955019551195521955319554195551955619557195581955919560195611956219563195641956519566195671956819569195701957119572195731957419575195761957719578195791958019581195821958319584195851958619587195881958919590195911959219593195941959519596195971959819599196001960119602196031960419605196061960719608196091961019611196121961319614196151961619617196181961919620196211962219623196241962519626196271962819629196301963119632196331963419635196361963719638196391964019641196421964319644196451964619647196481964919650196511965219653196541965519656196571965819659196601966119662196631966419665196661966719668196691967019671196721967319674196751967619677196781967919680196811968219683196841968519686196871968819689196901969119692196931969419695196961969719698196991970019701197021970319704197051970619707197081970919710197111971219713197141971519716197171971819719197201972119722197231972419725197261972719728197291973019731197321973319734197351973619737197381973919740197411974219743197441974519746197471974819749197501975119752197531975419755197561975719758197591976019761197621976319764197651976619767197681976919770197711977219773197741977519776197771977819779197801978119782197831978419785197861978719788197891979019791197921979319794197951979619797197981979919800198011980219803198041980519806198071980819809198101981119812198131981419815198161981719818198191982019821198221982319824198251982619827198281982919830198311983219833198341983519836198371983819839198401984119842198431984419845198461984719848198491985019851198521985319854198551985619857198581985919860198611986219863198641986519866198671986819869198701987119872198731987419875198761987719878198791988019881198821988319884198851988619887198881988919890198911989219893198941989519896198971989819899199001990119902199031990419905199061990719908199091991019911199121991319914199151991619917199181991919920199211992219923199241992519926199271992819929199301993119932199331993419935199361993719938199391994019941199421994319944199451994619947199481994919950199511995219953199541995519956199571995819959199601996119962199631996419965199661996719968199691997019971199721997319974199751997619977199781997919980199811998219983199841998519986199871998819989199901999119992199931999419995199961999719998199992000020001200022000320004200052000620007200082000920010200112001220013200142001520016200172001820019200202002120022200232002420025200262002720028200292003020031200322003320034200352003620037200382003920040200412004220043200442004520046200472004820049200502005120052200532005420055200562005720058200592006020061200622006320064200652006620067200682006920070200712007220073200742007520076200772007820079200802008120082200832008420085200862008720088200892009020091200922009320094200952009620097200982009920100201012010220103201042010520106201072010820109201102011120112201132011420115201162011720118201192012020121201222012320124201252012620127201282012920130201312013220133201342013520136201372013820139201402014120142201432014420145201462014720148201492015020151201522015320154201552015620157201582015920160201612016220163201642016520166201672016820169201702017120172201732017420175201762017720178201792018020181201822018320184201852018620187201882018920190201912019220193201942019520196201972019820199202002020120202202032020420205202062020720208202092021020211202122021320214202152021620217202182021920220202212022220223202242022520226202272022820229202302023120232202332023420235202362023720238202392024020241202422024320244202452024620247202482024920250202512025220253202542025520256202572025820259202602026120262202632026420265202662026720268202692027020271202722027320274202752027620277202782027920280202812028220283202842028520286202872028820289202902029120292202932029420295202962029720298202992030020301203022030320304203052030620307203082030920310203112031220313203142031520316203172031820319203202032120322203232032420325203262032720328203292033020331203322033320334203352033620337203382033920340203412034220343203442034520346203472034820349203502035120352203532035420355203562035720358203592036020361203622036320364203652036620367203682036920370203712037220373203742037520376203772037820379203802038120382203832038420385203862038720388203892039020391203922039320394203952039620397203982039920400204012040220403204042040520406204072040820409204102041120412204132041420415204162041720418204192042020421204222042320424204252042620427204282042920430204312043220433204342043520436204372043820439204402044120442204432044420445204462044720448204492045020451204522045320454204552045620457204582045920460204612046220463204642046520466204672046820469204702047120472204732047420475204762047720478204792048020481204822048320484204852048620487204882048920490204912049220493204942049520496204972049820499205002050120502205032050420505205062050720508205092051020511205122051320514205152051620517205182051920520205212052220523205242052520526205272052820529205302053120532205332053420535205362053720538205392054020541205422054320544205452054620547205482054920550205512055220553205542055520556205572055820559205602056120562205632056420565205662056720568205692057020571205722057320574205752057620577205782057920580205812058220583205842058520586205872058820589205902059120592205932059420595205962059720598205992060020601206022060320604206052060620607206082060920610206112061220613206142061520616206172061820619206202062120622206232062420625206262062720628206292063020631206322063320634206352063620637206382063920640206412064220643206442064520646206472064820649206502065120652206532065420655206562065720658206592066020661206622066320664206652066620667206682066920670206712067220673206742067520676206772067820679206802068120682206832068420685206862068720688206892069020691206922069320694206952069620697206982069920700207012070220703207042070520706207072070820709207102071120712207132071420715207162071720718207192072020721207222072320724207252072620727207282072920730207312073220733207342073520736207372073820739207402074120742207432074420745207462074720748207492075020751207522075320754207552075620757207582075920760207612076220763207642076520766207672076820769207702077120772207732077420775207762077720778207792078020781207822078320784207852078620787207882078920790207912079220793207942079520796207972079820799208002080120802208032080420805208062080720808208092081020811208122081320814208152081620817208182081920820208212082220823208242082520826208272082820829208302083120832208332083420835208362083720838208392084020841208422084320844208452084620847208482084920850208512085220853208542085520856208572085820859208602086120862208632086420865208662086720868208692087020871208722087320874208752087620877208782087920880208812088220883208842088520886208872088820889208902089120892208932089420895208962089720898208992090020901209022090320904209052090620907209082090920910209112091220913209142091520916209172091820919209202092120922209232092420925209262092720928209292093020931209322093320934209352093620937209382093920940209412094220943209442094520946209472094820949209502095120952209532095420955209562095720958209592096020961209622096320964209652096620967209682096920970209712097220973209742097520976209772097820979209802098120982209832098420985209862098720988209892099020991209922099320994209952099620997209982099921000210012100221003210042100521006210072100821009210102101121012210132101421015210162101721018210192102021021210222102321024210252102621027210282102921030210312103221033210342103521036210372103821039210402104121042210432104421045210462104721048210492105021051210522105321054210552105621057210582105921060210612106221063210642106521066210672106821069210702107121072210732107421075210762107721078210792108021081210822108321084210852108621087210882108921090210912109221093210942109521096210972109821099211002110121102211032110421105211062110721108211092111021111211122111321114211152111621117211182111921120211212112221123211242112521126211272112821129211302113121132211332113421135211362113721138211392114021141211422114321144211452114621147211482114921150211512115221153211542115521156211572115821159211602116121162211632116421165211662116721168211692117021171211722117321174211752117621177211782117921180211812118221183211842118521186211872118821189211902119121192211932119421195211962119721198211992120021201212022120321204212052120621207212082120921210212112121221213212142121521216212172121821219212202122121222212232122421225212262122721228212292123021231212322123321234212352123621237212382123921240212412124221243212442124521246212472124821249212502125121252212532125421255212562125721258212592126021261212622126321264212652126621267212682126921270212712127221273212742127521276212772127821279212802128121282212832128421285212862128721288212892129021291212922129321294212952129621297212982129921300213012130221303213042130521306213072130821309213102131121312213132131421315213162131721318213192132021321213222132321324213252132621327213282132921330213312133221333213342133521336213372133821339213402134121342213432134421345213462134721348213492135021351213522135321354213552135621357213582135921360213612136221363213642136521366213672136821369213702137121372213732137421375213762137721378213792138021381213822138321384213852138621387213882138921390213912139221393213942139521396213972139821399214002140121402214032140421405214062140721408214092141021411214122141321414214152141621417214182141921420214212142221423214242142521426214272142821429214302143121432214332143421435214362143721438214392144021441214422144321444214452144621447214482144921450214512145221453214542145521456214572145821459214602146121462214632146421465214662146721468214692147021471214722147321474214752147621477214782147921480214812148221483214842148521486214872148821489214902149121492214932149421495214962149721498214992150021501215022150321504215052150621507215082150921510215112151221513215142151521516215172151821519215202152121522215232152421525215262152721528215292153021531215322153321534215352153621537215382153921540215412154221543215442154521546215472154821549215502155121552215532155421555215562155721558215592156021561215622156321564215652156621567215682156921570215712157221573215742157521576215772157821579215802158121582215832158421585215862158721588215892159021591215922159321594215952159621597215982159921600216012160221603216042160521606216072160821609216102161121612216132161421615216162161721618216192162021621216222162321624216252162621627216282162921630216312163221633216342163521636216372163821639216402164121642216432164421645216462164721648216492165021651216522165321654216552165621657216582165921660216612166221663216642166521666216672166821669216702167121672216732167421675216762167721678216792168021681216822168321684216852168621687216882168921690216912169221693216942169521696216972169821699217002170121702217032170421705217062170721708217092171021711217122171321714217152171621717217182171921720217212172221723217242172521726217272172821729217302173121732217332173421735217362173721738217392174021741217422174321744217452174621747217482174921750217512175221753217542175521756217572175821759217602176121762217632176421765217662176721768217692177021771217722177321774217752177621777217782177921780217812178221783217842178521786217872178821789217902179121792217932179421795217962179721798217992180021801218022180321804218052180621807218082180921810218112181221813218142181521816218172181821819218202182121822218232182421825218262182721828218292183021831218322183321834218352183621837218382183921840218412184221843218442184521846218472184821849218502185121852218532185421855218562185721858218592186021861218622186321864218652186621867218682186921870218712187221873218742187521876218772187821879218802188121882218832188421885218862188721888218892189021891218922189321894218952189621897218982189921900219012190221903219042190521906219072190821909219102191121912219132191421915219162191721918219192192021921219222192321924219252192621927219282192921930219312193221933219342193521936219372193821939219402194121942219432194421945219462194721948219492195021951219522195321954219552195621957219582195921960219612196221963219642196521966219672196821969219702197121972219732197421975219762197721978219792198021981219822198321984219852198621987219882198921990219912199221993219942199521996219972199821999220002200122002220032200422005220062200722008220092201022011220122201322014220152201622017220182201922020220212202222023220242202522026220272202822029220302203122032220332203422035220362203722038220392204022041220422204322044220452204622047220482204922050220512205222053220542205522056220572205822059220602206122062220632206422065220662206722068220692207022071220722207322074220752207622077220782207922080220812208222083220842208522086220872208822089220902209122092220932209422095220962209722098220992210022101221022210322104221052210622107221082210922110221112211222113221142211522116221172211822119221202212122122221232212422125221262212722128221292213022131221322213322134221352213622137221382213922140221412214222143221442214522146221472214822149221502215122152221532215422155221562215722158221592216022161221622216322164221652216622167221682216922170221712217222173221742217522176221772217822179221802218122182221832218422185221862218722188221892219022191221922219322194221952219622197221982219922200222012220222203222042220522206222072220822209222102221122212222132221422215222162221722218222192222022221222222222322224222252222622227222282222922230222312223222233222342223522236222372223822239222402224122242222432224422245222462224722248222492225022251222522225322254222552225622257222582225922260222612226222263222642226522266222672226822269222702227122272222732227422275222762227722278222792228022281222822228322284222852228622287222882228922290222912229222293222942229522296222972229822299223002230122302223032230422305223062230722308223092231022311223122231322314223152231622317223182231922320223212232222323223242232522326223272232822329223302233122332223332233422335223362233722338223392234022341223422234322344223452234622347223482234922350223512235222353223542235522356223572235822359223602236122362223632236422365223662236722368223692237022371223722237322374223752237622377223782237922380223812238222383223842238522386223872238822389223902239122392223932239422395223962239722398223992240022401224022240322404224052240622407224082240922410224112241222413224142241522416224172241822419224202242122422224232242422425224262242722428224292243022431224322243322434224352243622437224382243922440224412244222443224442244522446224472244822449224502245122452224532245422455224562245722458224592246022461224622246322464224652246622467224682246922470224712247222473224742247522476224772247822479224802248122482224832248422485224862248722488224892249022491224922249322494224952249622497224982249922500225012250222503225042250522506225072250822509225102251122512225132251422515225162251722518225192252022521225222252322524225252252622527225282252922530225312253222533225342253522536225372253822539225402254122542225432254422545225462254722548225492255022551225522255322554225552255622557225582255922560225612256222563225642256522566225672256822569225702257122572225732257422575225762257722578225792258022581225822258322584225852258622587225882258922590225912259222593225942259522596225972259822599226002260122602226032260422605226062260722608226092261022611226122261322614226152261622617226182261922620226212262222623226242262522626226272262822629226302263122632226332263422635226362263722638226392264022641226422264322644226452264622647226482264922650226512265222653226542265522656226572265822659226602266122662226632266422665226662266722668226692267022671226722267322674226752267622677226782267922680226812268222683226842268522686226872268822689226902269122692226932269422695226962269722698226992270022701227022270322704227052270622707227082270922710227112271222713227142271522716227172271822719227202272122722227232272422725227262272722728227292273022731227322273322734227352273622737227382273922740227412274222743227442274522746227472274822749227502275122752227532275422755227562275722758227592276022761227622276322764227652276622767227682276922770227712277222773227742277522776227772277822779227802278122782227832278422785227862278722788227892279022791227922279322794227952279622797227982279922800228012280222803228042280522806228072280822809228102281122812228132281422815228162281722818228192282022821228222282322824228252282622827228282282922830228312283222833228342283522836228372283822839228402284122842228432284422845228462284722848228492285022851228522285322854228552285622857228582285922860228612286222863228642286522866228672286822869228702287122872228732287422875228762287722878228792288022881228822288322884228852288622887228882288922890228912289222893228942289522896228972289822899229002290122902229032290422905229062290722908229092291022911229122291322914229152291622917229182291922920229212292222923229242292522926229272292822929229302293122932229332293422935229362293722938229392294022941229422294322944229452294622947229482294922950229512295222953229542295522956229572295822959229602296122962229632296422965229662296722968229692297022971229722297322974229752297622977229782297922980229812298222983229842298522986229872298822989229902299122992229932299422995229962299722998229992300023001230022300323004230052300623007230082300923010230112301223013230142301523016230172301823019230202302123022230232302423025230262302723028230292303023031230322303323034230352303623037230382303923040230412304223043230442304523046230472304823049230502305123052230532305423055230562305723058230592306023061230622306323064230652306623067230682306923070230712307223073230742307523076230772307823079230802308123082230832308423085230862308723088230892309023091230922309323094230952309623097230982309923100231012310223103231042310523106231072310823109231102311123112231132311423115231162311723118231192312023121231222312323124231252312623127231282312923130231312313223133231342313523136231372313823139231402314123142231432314423145231462314723148231492315023151231522315323154231552315623157231582315923160231612316223163231642316523166231672316823169231702317123172231732317423175231762317723178231792318023181231822318323184231852318623187231882318923190231912319223193231942319523196231972319823199232002320123202232032320423205232062320723208232092321023211232122321323214232152321623217232182321923220232212322223223232242322523226232272322823229232302323123232232332323423235232362323723238232392324023241232422324323244232452324623247232482324923250232512325223253232542325523256232572325823259232602326123262232632326423265232662326723268232692327023271232722327323274232752327623277232782327923280232812328223283232842328523286232872328823289232902329123292232932329423295232962329723298232992330023301233022330323304233052330623307233082330923310233112331223313233142331523316233172331823319233202332123322233232332423325233262332723328233292333023331233322333323334233352333623337233382333923340233412334223343233442334523346233472334823349233502335123352233532335423355233562335723358233592336023361233622336323364233652336623367233682336923370233712337223373233742337523376233772337823379233802338123382233832338423385233862338723388233892339023391233922339323394233952339623397233982339923400234012340223403234042340523406234072340823409234102341123412234132341423415234162341723418234192342023421234222342323424234252342623427234282342923430234312343223433234342343523436234372343823439234402344123442234432344423445234462344723448234492345023451234522345323454234552345623457234582345923460234612346223463234642346523466234672346823469234702347123472234732347423475234762347723478234792348023481234822348323484234852348623487234882348923490234912349223493234942349523496234972349823499235002350123502235032350423505235062350723508235092351023511235122351323514235152351623517235182351923520235212352223523235242352523526235272352823529235302353123532235332353423535235362353723538235392354023541235422354323544235452354623547235482354923550235512355223553235542355523556235572355823559235602356123562235632356423565235662356723568235692357023571235722357323574235752357623577235782357923580235812358223583235842358523586235872358823589235902359123592235932359423595235962359723598235992360023601236022360323604236052360623607236082360923610236112361223613236142361523616236172361823619236202362123622236232362423625236262362723628236292363023631236322363323634236352363623637236382363923640236412364223643236442364523646236472364823649236502365123652236532365423655236562365723658236592366023661236622366323664236652366623667236682366923670236712367223673236742367523676236772367823679236802368123682236832368423685236862368723688236892369023691236922369323694236952369623697236982369923700237012370223703237042370523706237072370823709237102371123712237132371423715237162371723718237192372023721237222372323724237252372623727237282372923730237312373223733237342373523736237372373823739237402374123742237432374423745237462374723748237492375023751237522375323754237552375623757237582375923760237612376223763237642376523766237672376823769237702377123772237732377423775237762377723778237792378023781237822378323784237852378623787237882378923790237912379223793237942379523796237972379823799238002380123802238032380423805238062380723808238092381023811238122381323814238152381623817238182381923820238212382223823238242382523826238272382823829238302383123832238332383423835238362383723838238392384023841238422384323844238452384623847238482384923850238512385223853238542385523856238572385823859238602386123862238632386423865238662386723868238692387023871238722387323874238752387623877238782387923880238812388223883238842388523886238872388823889238902389123892238932389423895238962389723898238992390023901239022390323904239052390623907239082390923910239112391223913239142391523916239172391823919239202392123922239232392423925239262392723928239292393023931239322393323934239352393623937239382393923940239412394223943239442394523946239472394823949239502395123952239532395423955239562395723958239592396023961239622396323964239652396623967239682396923970239712397223973239742397523976239772397823979239802398123982239832398423985239862398723988239892399023991239922399323994239952399623997239982399924000240012400224003240042400524006240072400824009240102401124012240132401424015240162401724018240192402024021240222402324024240252402624027240282402924030240312403224033240342403524036240372403824039240402404124042240432404424045240462404724048240492405024051240522405324054240552405624057240582405924060240612406224063240642406524066240672406824069240702407124072240732407424075240762407724078240792408024081240822408324084240852408624087240882408924090240912409224093240942409524096240972409824099241002410124102241032410424105241062410724108241092411024111241122411324114241152411624117241182411924120241212412224123241242412524126241272412824129241302413124132241332413424135241362413724138241392414024141241422414324144241452414624147241482414924150241512415224153241542415524156241572415824159241602416124162241632416424165241662416724168241692417024171241722417324174241752417624177241782417924180241812418224183241842418524186241872418824189241902419124192241932419424195241962419724198241992420024201242022420324204242052420624207242082420924210242112421224213242142421524216242172421824219242202422124222242232422424225242262422724228242292423024231242322423324234242352423624237242382423924240242412424224243242442424524246242472424824249242502425124252242532425424255242562425724258242592426024261242622426324264242652426624267242682426924270242712427224273242742427524276242772427824279242802428124282242832428424285242862428724288242892429024291242922429324294242952429624297242982429924300243012430224303243042430524306243072430824309243102431124312243132431424315243162431724318243192432024321243222432324324243252432624327243282432924330243312433224333243342433524336243372433824339243402434124342243432434424345243462434724348243492435024351243522435324354243552435624357243582435924360243612436224363243642436524366243672436824369243702437124372243732437424375243762437724378243792438024381243822438324384243852438624387243882438924390243912439224393243942439524396243972439824399244002440124402244032440424405244062440724408244092441024411244122441324414244152441624417244182441924420244212442224423244242442524426244272442824429244302443124432244332443424435244362443724438244392444024441244422444324444244452444624447244482444924450244512445224453244542445524456244572445824459244602446124462244632446424465244662446724468244692447024471244722447324474244752447624477244782447924480244812448224483244842448524486244872448824489244902449124492244932449424495244962449724498244992450024501245022450324504245052450624507245082450924510245112451224513245142451524516245172451824519245202452124522245232452424525245262452724528245292453024531245322453324534245352453624537245382453924540245412454224543245442454524546245472454824549245502455124552245532455424555245562455724558245592456024561245622456324564245652456624567245682456924570245712457224573245742457524576245772457824579245802458124582245832458424585245862458724588245892459024591245922459324594245952459624597245982459924600246012460224603246042460524606246072460824609246102461124612246132461424615246162461724618246192462024621246222462324624246252462624627246282462924630246312463224633246342463524636246372463824639246402464124642246432464424645246462464724648246492465024651246522465324654246552465624657246582465924660246612466224663246642466524666246672466824669246702467124672246732467424675246762467724678246792468024681246822468324684246852468624687246882468924690246912469224693246942469524696246972469824699247002470124702247032470424705247062470724708247092471024711247122471324714247152471624717247182471924720247212472224723247242472524726247272472824729247302473124732247332473424735247362473724738247392474024741247422474324744247452474624747247482474924750247512475224753247542475524756247572475824759247602476124762247632476424765247662476724768247692477024771247722477324774247752477624777247782477924780247812478224783247842478524786247872478824789247902479124792247932479424795247962479724798247992480024801248022480324804248052480624807248082480924810248112481224813248142481524816248172481824819248202482124822248232482424825248262482724828248292483024831248322483324834248352483624837248382483924840248412484224843248442484524846248472484824849248502485124852248532485424855248562485724858248592486024861248622486324864248652486624867248682486924870248712487224873248742487524876248772487824879248802488124882248832488424885248862488724888248892489024891248922489324894248952489624897248982489924900249012490224903249042490524906249072490824909249102491124912249132491424915249162491724918249192492024921249222492324924249252492624927249282492924930249312493224933249342493524936249372493824939249402494124942249432494424945249462494724948249492495024951249522495324954249552495624957249582495924960249612496224963249642496524966249672496824969249702497124972249732497424975249762497724978249792498024981249822498324984249852498624987249882498924990249912499224993249942499524996249972499824999250002500125002250032500425005250062500725008250092501025011250122501325014250152501625017250182501925020250212502225023250242502525026250272502825029250302503125032250332503425035250362503725038250392504025041250422504325044250452504625047250482504925050250512505225053250542505525056250572505825059250602506125062250632506425065250662506725068250692507025071250722507325074250752507625077250782507925080250812508225083250842508525086250872508825089250902509125092250932509425095250962509725098250992510025101251022510325104251052510625107251082510925110251112511225113251142511525116251172511825119251202512125122251232512425125251262512725128251292513025131251322513325134251352513625137251382513925140251412514225143251442514525146251472514825149251502515125152251532515425155251562515725158251592516025161251622516325164251652516625167251682516925170251712517225173251742517525176251772517825179251802518125182251832518425185251862518725188251892519025191251922519325194251952519625197251982519925200252012520225203252042520525206252072520825209252102521125212252132521425215252162521725218252192522025221252222522325224252252522625227252282522925230252312523225233252342523525236252372523825239252402524125242252432524425245252462524725248252492525025251252522525325254252552525625257252582525925260252612526225263252642526525266252672526825269252702527125272252732527425275252762527725278252792528025281252822528325284252852528625287252882528925290252912529225293252942529525296252972529825299253002530125302253032530425305253062530725308253092531025311253122531325314253152531625317253182531925320253212532225323253242532525326253272532825329253302533125332253332533425335253362533725338253392534025341253422534325344253452534625347253482534925350253512535225353253542535525356253572535825359253602536125362253632536425365253662536725368253692537025371253722537325374253752537625377253782537925380253812538225383253842538525386253872538825389253902539125392253932539425395253962539725398253992540025401254022540325404254052540625407254082540925410254112541225413254142541525416254172541825419254202542125422254232542425425254262542725428254292543025431254322543325434254352543625437254382543925440254412544225443254442544525446254472544825449254502545125452254532545425455254562545725458254592546025461254622546325464254652546625467254682546925470254712547225473254742547525476254772547825479254802548125482254832548425485254862548725488254892549025491254922549325494254952549625497254982549925500255012550225503255042550525506255072550825509255102551125512255132551425515255162551725518255192552025521255222552325524255252552625527255282552925530255312553225533255342553525536255372553825539255402554125542255432554425545255462554725548255492555025551255522555325554255552555625557255582555925560255612556225563255642556525566255672556825569255702557125572255732557425575255762557725578255792558025581255822558325584255852558625587255882558925590255912559225593255942559525596255972559825599256002560125602256032560425605256062560725608256092561025611256122561325614256152561625617256182561925620256212562225623256242562525626256272562825629256302563125632256332563425635256362563725638256392564025641256422564325644256452564625647256482564925650256512565225653256542565525656256572565825659256602566125662256632566425665256662566725668256692567025671256722567325674256752567625677256782567925680256812568225683256842568525686256872568825689256902569125692256932569425695256962569725698256992570025701257022570325704257052570625707257082570925710257112571225713257142571525716257172571825719257202572125722257232572425725257262572725728257292573025731257322573325734257352573625737257382573925740257412574225743257442574525746257472574825749257502575125752257532575425755257562575725758257592576025761257622576325764257652576625767257682576925770257712577225773257742577525776257772577825779257802578125782257832578425785257862578725788257892579025791257922579325794257952579625797257982579925800258012580225803258042580525806258072580825809258102581125812258132581425815258162581725818258192582025821258222582325824258252582625827258282582925830258312583225833258342583525836258372583825839258402584125842258432584425845258462584725848258492585025851258522585325854258552585625857258582585925860258612586225863258642586525866258672586825869258702587125872258732587425875258762587725878258792588025881258822588325884258852588625887258882588925890258912589225893258942589525896258972589825899259002590125902259032590425905259062590725908259092591025911259122591325914259152591625917259182591925920259212592225923259242592525926259272592825929259302593125932259332593425935259362593725938259392594025941259422594325944259452594625947259482594925950259512595225953259542595525956259572595825959259602596125962259632596425965259662596725968259692597025971259722597325974259752597625977259782597925980259812598225983259842598525986259872598825989259902599125992259932599425995259962599725998259992600026001260022600326004260052600626007260082600926010260112601226013260142601526016260172601826019260202602126022260232602426025260262602726028260292603026031260322603326034260352603626037260382603926040260412604226043260442604526046260472604826049260502605126052260532605426055260562605726058260592606026061260622606326064260652606626067260682606926070260712607226073260742607526076260772607826079260802608126082260832608426085260862608726088260892609026091260922609326094260952609626097260982609926100261012610226103261042610526106261072610826109261102611126112261132611426115261162611726118261192612026121261222612326124261252612626127261282612926130261312613226133261342613526136261372613826139261402614126142261432614426145261462614726148261492615026151261522615326154261552615626157261582615926160261612616226163261642616526166261672616826169261702617126172261732617426175261762617726178261792618026181261822618326184261852618626187261882618926190261912619226193261942619526196261972619826199262002620126202262032620426205262062620726208262092621026211262122621326214262152621626217262182621926220262212622226223262242622526226262272622826229262302623126232262332623426235262362623726238262392624026241262422624326244262452624626247262482624926250262512625226253262542625526256262572625826259262602626126262262632626426265262662626726268262692627026271262722627326274262752627626277262782627926280262812628226283262842628526286262872628826289262902629126292262932629426295262962629726298262992630026301263022630326304263052630626307263082630926310263112631226313263142631526316263172631826319263202632126322263232632426325263262632726328263292633026331263322633326334263352633626337263382633926340263412634226343263442634526346263472634826349263502635126352263532635426355263562635726358263592636026361263622636326364263652636626367263682636926370263712637226373263742637526376263772637826379263802638126382263832638426385263862638726388263892639026391263922639326394263952639626397263982639926400264012640226403264042640526406264072640826409264102641126412264132641426415264162641726418264192642026421264222642326424264252642626427264282642926430264312643226433264342643526436264372643826439264402644126442264432644426445264462644726448264492645026451264522645326454264552645626457264582645926460264612646226463264642646526466264672646826469264702647126472264732647426475264762647726478264792648026481264822648326484264852648626487264882648926490264912649226493264942649526496264972649826499265002650126502265032650426505265062650726508265092651026511265122651326514265152651626517265182651926520265212652226523265242652526526265272652826529265302653126532265332653426535265362653726538265392654026541265422654326544265452654626547265482654926550265512655226553265542655526556265572655826559265602656126562265632656426565265662656726568265692657026571265722657326574265752657626577265782657926580265812658226583265842658526586265872658826589265902659126592265932659426595265962659726598265992660026601266022660326604266052660626607266082660926610266112661226613266142661526616266172661826619266202662126622266232662426625266262662726628266292663026631266322663326634266352663626637266382663926640266412664226643266442664526646266472664826649266502665126652266532665426655266562665726658266592666026661266622666326664266652666626667266682666926670266712667226673266742667526676266772667826679266802668126682266832668426685266862668726688266892669026691266922669326694266952669626697266982669926700267012670226703267042670526706267072670826709267102671126712267132671426715267162671726718267192672026721267222672326724267252672626727267282672926730267312673226733267342673526736267372673826739267402674126742267432674426745267462674726748267492675026751267522675326754267552675626757267582675926760267612676226763267642676526766267672676826769267702677126772267732677426775267762677726778267792678026781267822678326784267852678626787267882678926790267912679226793267942679526796267972679826799268002680126802268032680426805268062680726808268092681026811268122681326814268152681626817268182681926820268212682226823268242682526826268272682826829268302683126832268332683426835268362683726838268392684026841268422684326844268452684626847268482684926850268512685226853268542685526856268572685826859268602686126862268632686426865268662686726868268692687026871268722687326874268752687626877268782687926880268812688226883268842688526886268872688826889268902689126892268932689426895268962689726898268992690026901269022690326904269052690626907269082690926910269112691226913269142691526916269172691826919269202692126922269232692426925269262692726928269292693026931269322693326934269352693626937269382693926940269412694226943269442694526946269472694826949269502695126952269532695426955269562695726958269592696026961269622696326964269652696626967269682696926970269712697226973269742697526976269772697826979269802698126982269832698426985269862698726988269892699026991269922699326994269952699626997269982699927000270012700227003270042700527006270072700827009270102701127012270132701427015270162701727018270192702027021270222702327024270252702627027270282702927030270312703227033270342703527036270372703827039270402704127042270432704427045270462704727048270492705027051270522705327054270552705627057270582705927060270612706227063270642706527066270672706827069270702707127072270732707427075270762707727078270792708027081270822708327084270852708627087270882708927090270912709227093270942709527096270972709827099271002710127102271032710427105271062710727108271092711027111271122711327114271152711627117271182711927120271212712227123271242712527126271272712827129271302713127132271332713427135271362713727138271392714027141271422714327144271452714627147271482714927150271512715227153271542715527156271572715827159271602716127162271632716427165271662716727168271692717027171271722717327174271752717627177271782717927180271812718227183271842718527186271872718827189271902719127192271932719427195271962719727198271992720027201272022720327204272052720627207272082720927210272112721227213272142721527216272172721827219272202722127222272232722427225272262722727228272292723027231272322723327234272352723627237272382723927240272412724227243272442724527246272472724827249272502725127252272532725427255272562725727258272592726027261272622726327264272652726627267272682726927270272712727227273272742727527276272772727827279272802728127282272832728427285272862728727288272892729027291272922729327294272952729627297272982729927300273012730227303273042730527306273072730827309273102731127312273132731427315273162731727318273192732027321273222732327324273252732627327273282732927330273312733227333273342733527336273372733827339273402734127342273432734427345273462734727348273492735027351273522735327354273552735627357273582735927360273612736227363273642736527366273672736827369273702737127372273732737427375273762737727378273792738027381273822738327384273852738627387273882738927390273912739227393273942739527396273972739827399274002740127402274032740427405274062740727408274092741027411274122741327414274152741627417274182741927420274212742227423274242742527426274272742827429274302743127432274332743427435274362743727438274392744027441274422744327444274452744627447274482744927450274512745227453274542745527456274572745827459274602746127462274632746427465274662746727468274692747027471274722747327474274752747627477274782747927480274812748227483274842748527486274872748827489274902749127492274932749427495274962749727498274992750027501275022750327504275052750627507275082750927510275112751227513275142751527516275172751827519275202752127522275232752427525275262752727528275292753027531275322753327534275352753627537275382753927540275412754227543275442754527546275472754827549275502755127552275532755427555275562755727558275592756027561275622756327564275652756627567275682756927570275712757227573275742757527576275772757827579275802758127582275832758427585275862758727588275892759027591275922759327594275952759627597275982759927600276012760227603276042760527606276072760827609276102761127612276132761427615276162761727618276192762027621276222762327624276252762627627276282762927630276312763227633276342763527636276372763827639276402764127642276432764427645276462764727648276492765027651276522765327654276552765627657276582765927660276612766227663276642766527666276672766827669276702767127672276732767427675276762767727678276792768027681276822768327684276852768627687276882768927690276912769227693276942769527696276972769827699277002770127702277032770427705277062770727708277092771027711277122771327714277152771627717277182771927720277212772227723277242772527726277272772827729277302773127732277332773427735277362773727738277392774027741277422774327744277452774627747277482774927750277512775227753277542775527756277572775827759277602776127762277632776427765277662776727768277692777027771277722777327774277752777627777277782777927780277812778227783277842778527786277872778827789277902779127792277932779427795277962779727798277992780027801278022780327804278052780627807278082780927810278112781227813278142781527816278172781827819278202782127822278232782427825278262782727828278292783027831278322783327834278352783627837278382783927840278412784227843278442784527846278472784827849278502785127852278532785427855278562785727858278592786027861278622786327864278652786627867278682786927870278712787227873278742787527876278772787827879278802788127882278832788427885278862788727888278892789027891278922789327894278952789627897278982789927900279012790227903279042790527906279072790827909279102791127912279132791427915279162791727918279192792027921279222792327924279252792627927279282792927930279312793227933279342793527936279372793827939279402794127942279432794427945279462794727948279492795027951279522795327954279552795627957279582795927960279612796227963279642796527966279672796827969279702797127972279732797427975279762797727978279792798027981279822798327984279852798627987279882798927990279912799227993279942799527996279972799827999280002800128002280032800428005280062800728008280092801028011280122801328014280152801628017280182801928020280212802228023280242802528026280272802828029280302803128032280332803428035280362803728038280392804028041280422804328044280452804628047280482804928050280512805228053280542805528056280572805828059280602806128062280632806428065280662806728068280692807028071280722807328074280752807628077280782807928080280812808228083280842808528086280872808828089280902809128092280932809428095280962809728098280992810028101281022810328104281052810628107281082810928110281112811228113281142811528116281172811828119281202812128122281232812428125281262812728128281292813028131281322813328134281352813628137281382813928140281412814228143281442814528146281472814828149281502815128152281532815428155281562815728158281592816028161281622816328164281652816628167281682816928170281712817228173281742817528176281772817828179281802818128182281832818428185281862818728188281892819028191281922819328194281952819628197281982819928200282012820228203282042820528206282072820828209282102821128212282132821428215282162821728218282192822028221282222822328224282252822628227282282822928230282312823228233282342823528236282372823828239282402824128242282432824428245282462824728248282492825028251282522825328254282552825628257282582825928260282612826228263282642826528266282672826828269282702827128272282732827428275282762827728278282792828028281282822828328284282852828628287282882828928290282912829228293282942829528296282972829828299283002830128302283032830428305283062830728308283092831028311283122831328314283152831628317283182831928320283212832228323283242832528326283272832828329283302833128332283332833428335283362833728338283392834028341283422834328344283452834628347283482834928350283512835228353283542835528356283572835828359283602836128362283632836428365283662836728368283692837028371283722837328374283752837628377283782837928380283812838228383283842838528386283872838828389283902839128392283932839428395283962839728398283992840028401284022840328404284052840628407284082840928410284112841228413284142841528416284172841828419284202842128422284232842428425284262842728428284292843028431284322843328434284352843628437284382843928440284412844228443284442844528446284472844828449284502845128452284532845428455284562845728458284592846028461284622846328464284652846628467284682846928470284712847228473284742847528476284772847828479284802848128482284832848428485284862848728488284892849028491284922849328494284952849628497284982849928500285012850228503285042850528506285072850828509285102851128512285132851428515285162851728518285192852028521285222852328524285252852628527285282852928530285312853228533285342853528536285372853828539285402854128542285432854428545285462854728548285492855028551285522855328554285552855628557285582855928560285612856228563285642856528566285672856828569285702857128572285732857428575285762857728578285792858028581285822858328584285852858628587285882858928590285912859228593285942859528596285972859828599286002860128602286032860428605286062860728608286092861028611286122861328614286152861628617286182861928620286212862228623286242862528626286272862828629286302863128632286332863428635286362863728638286392864028641286422864328644286452864628647286482864928650286512865228653286542865528656286572865828659286602866128662286632866428665286662866728668286692867028671286722867328674286752867628677286782867928680286812868228683286842868528686286872868828689286902869128692286932869428695286962869728698286992870028701287022870328704287052870628707287082870928710287112871228713287142871528716287172871828719287202872128722287232872428725287262872728728287292873028731287322873328734287352873628737287382873928740287412874228743287442874528746287472874828749287502875128752287532875428755287562875728758287592876028761287622876328764287652876628767287682876928770287712877228773287742877528776287772877828779287802878128782287832878428785287862878728788287892879028791287922879328794287952879628797287982879928800288012880228803288042880528806288072880828809288102881128812288132881428815288162881728818288192882028821288222882328824288252882628827288282882928830288312883228833288342883528836288372883828839288402884128842288432884428845288462884728848288492885028851288522885328854288552885628857288582885928860288612886228863288642886528866288672886828869288702887128872288732887428875288762887728878288792888028881288822888328884288852888628887288882888928890288912889228893288942889528896288972889828899289002890128902289032890428905289062890728908289092891028911289122891328914289152891628917289182891928920289212892228923289242892528926289272892828929289302893128932289332893428935289362893728938289392894028941289422894328944289452894628947289482894928950289512895228953289542895528956289572895828959289602896128962289632896428965289662896728968289692897028971289722897328974289752897628977289782897928980289812898228983289842898528986289872898828989289902899128992289932899428995289962899728998289992900029001290022900329004290052900629007290082900929010290112901229013290142901529016290172901829019290202902129022290232902429025290262902729028290292903029031290322903329034290352903629037290382903929040290412904229043290442904529046290472904829049290502905129052290532905429055290562905729058290592906029061290622906329064290652906629067290682906929070290712907229073290742907529076290772907829079290802908129082290832908429085290862908729088290892909029091290922909329094290952909629097290982909929100291012910229103291042910529106291072910829109291102911129112291132911429115291162911729118291192912029121291222912329124291252912629127291282912929130291312913229133291342913529136291372913829139291402914129142291432914429145291462914729148291492915029151291522915329154291552915629157291582915929160291612916229163291642916529166291672916829169291702917129172291732917429175291762917729178291792918029181291822918329184291852918629187291882918929190291912919229193291942919529196291972919829199292002920129202292032920429205292062920729208292092921029211292122921329214292152921629217292182921929220292212922229223292242922529226292272922829229292302923129232292332923429235292362923729238292392924029241292422924329244292452924629247292482924929250292512925229253292542925529256292572925829259292602926129262292632926429265292662926729268292692927029271292722927329274292752927629277292782927929280292812928229283292842928529286292872928829289292902929129292292932929429295292962929729298292992930029301293022930329304293052930629307293082930929310293112931229313293142931529316293172931829319293202932129322293232932429325293262932729328293292933029331293322933329334293352933629337293382933929340293412934229343293442934529346293472934829349293502935129352293532935429355293562935729358293592936029361293622936329364293652936629367293682936929370293712937229373293742937529376293772937829379293802938129382293832938429385293862938729388293892939029391293922939329394293952939629397293982939929400294012940229403294042940529406294072940829409294102941129412294132941429415294162941729418294192942029421294222942329424294252942629427294282942929430294312943229433294342943529436294372943829439294402944129442294432944429445294462944729448294492945029451294522945329454294552945629457294582945929460294612946229463294642946529466294672946829469294702947129472294732947429475294762947729478294792948029481294822948329484294852948629487294882948929490294912949229493294942949529496294972949829499295002950129502295032950429505295062950729508295092951029511295122951329514295152951629517295182951929520295212952229523295242952529526295272952829529295302953129532295332953429535295362953729538295392954029541295422954329544295452954629547295482954929550295512955229553295542955529556295572955829559295602956129562295632956429565295662956729568295692957029571295722957329574295752957629577295782957929580295812958229583295842958529586295872958829589295902959129592295932959429595295962959729598295992960029601296022960329604296052960629607296082960929610296112961229613296142961529616296172961829619296202962129622296232962429625296262962729628296292963029631296322963329634296352963629637296382963929640296412964229643296442964529646296472964829649296502965129652296532965429655296562965729658296592966029661296622966329664296652966629667296682966929670296712967229673296742967529676296772967829679296802968129682296832968429685296862968729688296892969029691296922969329694296952969629697296982969929700297012970229703297042970529706297072970829709297102971129712297132971429715297162971729718297192972029721297222972329724297252972629727297282972929730297312973229733297342973529736297372973829739297402974129742297432974429745297462974729748297492975029751297522975329754297552975629757297582975929760297612976229763297642976529766297672976829769297702977129772297732977429775297762977729778297792978029781297822978329784297852978629787297882978929790297912979229793297942979529796297972979829799298002980129802298032980429805298062980729808298092981029811298122981329814298152981629817298182981929820298212982229823298242982529826298272982829829298302983129832298332983429835298362983729838298392984029841298422984329844298452984629847298482984929850298512985229853298542985529856298572985829859298602986129862298632986429865298662986729868298692987029871298722987329874298752987629877298782987929880298812988229883298842988529886298872988829889298902989129892298932989429895298962989729898298992990029901299022990329904299052990629907299082990929910299112991229913299142991529916299172991829919299202992129922299232992429925299262992729928299292993029931299322993329934299352993629937299382993929940299412994229943299442994529946299472994829949299502995129952299532995429955299562995729958299592996029961299622996329964299652996629967299682996929970299712997229973299742997529976299772997829979299802998129982299832998429985299862998729988299892999029991299922999329994299952999629997299982999930000300013000230003300043000530006300073000830009300103001130012300133001430015300163001730018300193002030021300223002330024300253002630027300283002930030300313003230033300343003530036300373003830039300403004130042300433004430045300463004730048300493005030051300523005330054300553005630057300583005930060300613006230063300643006530066300673006830069300703007130072300733007430075300763007730078300793008030081300823008330084300853008630087300883008930090300913009230093300943009530096300973009830099301003010130102301033010430105301063010730108301093011030111301123011330114301153011630117301183011930120301213012230123301243012530126301273012830129301303013130132301333013430135301363013730138301393014030141301423014330144301453014630147301483014930150301513015230153301543015530156301573015830159301603016130162301633016430165301663016730168301693017030171301723017330174301753017630177301783017930180301813018230183301843018530186301873018830189301903019130192301933019430195301963019730198301993020030201302023020330204302053020630207302083020930210302113021230213302143021530216302173021830219302203022130222302233022430225302263022730228302293023030231302323023330234302353023630237302383023930240302413024230243302443024530246302473024830249302503025130252302533025430255302563025730258302593026030261302623026330264302653026630267302683026930270302713027230273302743027530276302773027830279302803028130282302833028430285302863028730288302893029030291302923029330294302953029630297302983029930300303013030230303303043030530306303073030830309303103031130312303133031430315303163031730318303193032030321303223032330324303253032630327303283032930330303313033230333303343033530336303373033830339303403034130342303433034430345303463034730348303493035030351303523035330354303553035630357303583035930360303613036230363303643036530366303673036830369303703037130372303733037430375303763037730378303793038030381303823038330384303853038630387303883038930390303913039230393303943039530396303973039830399304003040130402304033040430405304063040730408304093041030411304123041330414304153041630417304183041930420304213042230423304243042530426304273042830429304303043130432304333043430435304363043730438304393044030441304423044330444304453044630447304483044930450304513045230453304543045530456304573045830459304603046130462304633046430465304663046730468304693047030471304723047330474304753047630477304783047930480304813048230483304843048530486304873048830489304903049130492304933049430495304963049730498304993050030501305023050330504305053050630507305083050930510305113051230513305143051530516305173051830519305203052130522305233052430525305263052730528305293053030531305323053330534305353053630537305383053930540305413054230543305443054530546305473054830549305503055130552305533055430555305563055730558305593056030561305623056330564305653056630567305683056930570305713057230573305743057530576305773057830579305803058130582305833058430585305863058730588305893059030591305923059330594305953059630597305983059930600306013060230603306043060530606306073060830609306103061130612306133061430615306163061730618306193062030621306223062330624306253062630627306283062930630306313063230633306343063530636306373063830639306403064130642306433064430645306463064730648306493065030651306523065330654306553065630657306583065930660306613066230663306643066530666306673066830669306703067130672306733067430675306763067730678306793068030681306823068330684306853068630687306883068930690306913069230693306943069530696306973069830699307003070130702307033070430705307063070730708307093071030711307123071330714307153071630717307183071930720307213072230723307243072530726307273072830729307303073130732307333073430735307363073730738307393074030741307423074330744307453074630747307483074930750307513075230753307543075530756307573075830759307603076130762307633076430765307663076730768307693077030771307723077330774307753077630777307783077930780307813078230783307843078530786307873078830789307903079130792307933079430795307963079730798307993080030801308023080330804308053080630807308083080930810308113081230813308143081530816308173081830819308203082130822308233082430825308263082730828308293083030831308323083330834308353083630837308383083930840308413084230843308443084530846308473084830849308503085130852308533085430855308563085730858308593086030861308623086330864308653086630867308683086930870308713087230873308743087530876308773087830879308803088130882308833088430885308863088730888308893089030891308923089330894308953089630897308983089930900309013090230903309043090530906309073090830909309103091130912309133091430915309163091730918309193092030921309223092330924309253092630927309283092930930309313093230933309343093530936309373093830939309403094130942309433094430945309463094730948309493095030951309523095330954309553095630957309583095930960309613096230963309643096530966309673096830969309703097130972309733097430975309763097730978309793098030981309823098330984309853098630987309883098930990309913099230993309943099530996309973099830999310003100131002310033100431005310063100731008310093101031011310123101331014310153101631017310183101931020310213102231023310243102531026310273102831029310303103131032310333103431035310363103731038310393104031041310423104331044310453104631047310483104931050310513105231053310543105531056310573105831059310603106131062310633106431065310663106731068310693107031071310723107331074310753107631077310783107931080310813108231083310843108531086310873108831089310903109131092310933109431095310963109731098310993110031101311023110331104311053110631107311083110931110311113111231113311143111531116311173111831119311203112131122311233112431125311263112731128311293113031131311323113331134311353113631137311383113931140311413114231143311443114531146311473114831149311503115131152311533115431155311563115731158311593116031161311623116331164311653116631167311683116931170311713117231173311743117531176311773117831179311803118131182311833118431185311863118731188311893119031191311923119331194311953119631197311983119931200312013120231203312043120531206312073120831209312103121131212312133121431215312163121731218312193122031221312223122331224312253122631227312283122931230312313123231233312343123531236312373123831239312403124131242312433124431245312463124731248312493125031251312523125331254312553125631257312583125931260312613126231263312643126531266312673126831269312703127131272312733127431275312763127731278312793128031281312823128331284312853128631287312883128931290312913129231293312943129531296312973129831299313003130131302313033130431305313063130731308313093131031311313123131331314313153131631317313183131931320313213132231323313243132531326313273132831329313303133131332313333133431335313363133731338313393134031341313423134331344313453134631347313483134931350313513135231353313543135531356313573135831359313603136131362313633136431365313663136731368313693137031371313723137331374313753137631377313783137931380313813138231383313843138531386313873138831389313903139131392313933139431395313963139731398313993140031401314023140331404314053140631407314083140931410314113141231413314143141531416314173141831419314203142131422314233142431425314263142731428314293143031431314323143331434314353143631437314383143931440314413144231443314443144531446314473144831449314503145131452314533145431455314563145731458314593146031461314623146331464314653146631467314683146931470314713147231473314743147531476314773147831479314803148131482314833148431485314863148731488314893149031491314923149331494314953149631497314983149931500315013150231503315043150531506315073150831509315103151131512315133151431515315163151731518315193152031521315223152331524315253152631527315283152931530315313153231533315343153531536315373153831539315403154131542315433154431545315463154731548315493155031551315523155331554315553155631557315583155931560315613156231563315643156531566315673156831569315703157131572315733157431575315763157731578315793158031581315823158331584315853158631587315883158931590315913159231593315943159531596315973159831599316003160131602316033160431605316063160731608316093161031611316123161331614316153161631617316183161931620316213162231623316243162531626316273162831629316303163131632316333163431635316363163731638316393164031641316423164331644316453164631647316483164931650316513165231653316543165531656316573165831659316603166131662316633166431665316663166731668316693167031671316723167331674316753167631677316783167931680316813168231683316843168531686316873168831689316903169131692316933169431695316963169731698316993170031701317023170331704317053170631707317083170931710317113171231713317143171531716317173171831719317203172131722317233172431725317263172731728317293173031731317323173331734317353173631737317383173931740317413174231743317443174531746317473174831749317503175131752317533175431755317563175731758317593176031761317623176331764317653176631767317683176931770317713177231773317743177531776317773177831779317803178131782317833178431785317863178731788317893179031791317923179331794317953179631797317983179931800318013180231803318043180531806318073180831809318103181131812318133181431815318163181731818318193182031821318223182331824318253182631827318283182931830318313183231833318343183531836318373183831839318403184131842318433184431845318463184731848318493185031851318523185331854318553185631857318583185931860318613186231863318643186531866318673186831869318703187131872318733187431875318763187731878318793188031881318823188331884318853188631887318883188931890318913189231893318943189531896318973189831899319003190131902319033190431905319063190731908319093191031911319123191331914319153191631917319183191931920319213192231923319243192531926319273192831929319303193131932319333193431935319363193731938319393194031941319423194331944319453194631947319483194931950319513195231953319543195531956319573195831959319603196131962319633196431965319663196731968319693197031971319723197331974319753197631977319783197931980319813198231983319843198531986319873198831989319903199131992319933199431995319963199731998319993200032001320023200332004320053200632007320083200932010320113201232013320143201532016320173201832019320203202132022320233202432025320263202732028320293203032031320323203332034320353203632037320383203932040320413204232043320443204532046320473204832049320503205132052320533205432055320563205732058320593206032061320623206332064320653206632067320683206932070320713207232073320743207532076320773207832079320803208132082320833208432085320863208732088320893209032091320923209332094320953209632097320983209932100321013210232103321043210532106321073210832109321103211132112321133211432115321163211732118321193212032121321223212332124321253212632127321283212932130321313213232133321343213532136321373213832139321403214132142321433214432145321463214732148321493215032151321523215332154321553215632157321583215932160321613216232163321643216532166321673216832169321703217132172321733217432175321763217732178321793218032181321823218332184321853218632187321883218932190321913219232193321943219532196321973219832199322003220132202322033220432205322063220732208322093221032211322123221332214322153221632217322183221932220322213222232223322243222532226322273222832229322303223132232322333223432235322363223732238322393224032241322423224332244322453224632247322483224932250322513225232253322543225532256322573225832259322603226132262322633226432265322663226732268322693227032271322723227332274322753227632277322783227932280322813228232283322843228532286322873228832289322903229132292322933229432295322963229732298322993230032301323023230332304323053230632307323083230932310323113231232313323143231532316323173231832319323203232132322323233232432325323263232732328323293233032331323323233332334323353233632337323383233932340323413234232343323443234532346323473234832349323503235132352323533235432355323563235732358323593236032361323623236332364323653236632367323683236932370323713237232373323743237532376323773237832379323803238132382323833238432385323863238732388323893239032391323923239332394323953239632397323983239932400324013240232403324043240532406324073240832409324103241132412324133241432415324163241732418324193242032421324223242332424324253242632427324283242932430324313243232433324343243532436324373243832439324403244132442324433244432445324463244732448324493245032451324523245332454324553245632457324583245932460324613246232463324643246532466324673246832469324703247132472324733247432475324763247732478324793248032481324823248332484324853248632487324883248932490324913249232493324943249532496324973249832499325003250132502325033250432505325063250732508325093251032511325123251332514325153251632517325183251932520325213252232523325243252532526325273252832529325303253132532325333253432535325363253732538325393254032541325423254332544325453254632547325483254932550325513255232553325543255532556325573255832559325603256132562325633256432565325663256732568325693257032571325723257332574325753257632577325783257932580325813258232583325843258532586325873258832589325903259132592325933259432595325963259732598325993260032601326023260332604326053260632607326083260932610326113261232613326143261532616326173261832619326203262132622326233262432625326263262732628326293263032631326323263332634326353263632637326383263932640326413264232643326443264532646326473264832649326503265132652326533265432655326563265732658326593266032661326623266332664326653266632667326683266932670326713267232673326743267532676326773267832679326803268132682326833268432685326863268732688326893269032691326923269332694326953269632697326983269932700327013270232703327043270532706327073270832709327103271132712327133271432715327163271732718327193272032721327223272332724327253272632727327283272932730327313273232733327343273532736327373273832739327403274132742327433274432745327463274732748327493275032751327523275332754327553275632757327583275932760327613276232763327643276532766327673276832769327703277132772327733277432775327763277732778327793278032781327823278332784327853278632787327883278932790327913279232793327943279532796327973279832799328003280132802328033280432805328063280732808328093281032811328123281332814328153281632817328183281932820328213282232823328243282532826328273282832829328303283132832328333283432835328363283732838328393284032841328423284332844328453284632847328483284932850328513285232853328543285532856328573285832859328603286132862328633286432865328663286732868328693287032871328723287332874328753287632877328783287932880328813288232883328843288532886328873288832889328903289132892328933289432895328963289732898328993290032901329023290332904329053290632907329083290932910329113291232913329143291532916329173291832919329203292132922329233292432925329263292732928329293293032931329323293332934329353293632937329383293932940329413294232943329443294532946329473294832949329503295132952329533295432955329563295732958329593296032961329623296332964329653296632967329683296932970329713297232973329743297532976329773297832979329803298132982329833298432985329863298732988329893299032991329923299332994329953299632997329983299933000330013300233003330043300533006330073300833009330103301133012330133301433015330163301733018330193302033021330223302333024330253302633027330283302933030330313303233033330343303533036330373303833039330403304133042330433304433045330463304733048330493305033051330523305333054330553305633057330583305933060330613306233063330643306533066330673306833069330703307133072330733307433075330763307733078330793308033081330823308333084330853308633087330883308933090330913309233093330943309533096330973309833099331003310133102331033310433105331063310733108331093311033111331123311333114331153311633117331183311933120331213312233123331243312533126331273312833129331303313133132331333313433135331363313733138331393314033141331423314333144331453314633147331483314933150331513315233153331543315533156331573315833159331603316133162331633316433165331663316733168331693317033171331723317333174331753317633177331783317933180331813318233183331843318533186331873318833189331903319133192331933319433195331963319733198331993320033201332023320333204332053320633207332083320933210332113321233213332143321533216332173321833219332203322133222332233322433225332263322733228332293323033231332323323333234332353323633237332383323933240332413324233243332443324533246332473324833249332503325133252332533325433255332563325733258332593326033261332623326333264332653326633267332683326933270332713327233273332743327533276332773327833279332803328133282332833328433285332863328733288332893329033291332923329333294332953329633297332983329933300333013330233303333043330533306333073330833309333103331133312333133331433315333163331733318333193332033321333223332333324333253332633327333283332933330333313333233333333343333533336333373333833339333403334133342333433334433345333463334733348333493335033351333523335333354333553335633357333583335933360333613336233363333643336533366333673336833369333703337133372333733337433375333763337733378333793338033381333823338333384333853338633387333883338933390333913339233393333943339533396333973339833399334003340133402334033340433405334063340733408334093341033411334123341333414334153341633417334183341933420334213342233423334243342533426334273342833429334303343133432334333343433435334363343733438334393344033441334423344333444334453344633447334483344933450334513345233453334543345533456334573345833459334603346133462334633346433465334663346733468334693347033471334723347333474334753347633477334783347933480334813348233483334843348533486334873348833489334903349133492334933349433495334963349733498334993350033501335023350333504335053350633507335083350933510335113351233513335143351533516335173351833519335203352133522335233352433525335263352733528335293353033531335323353333534335353353633537335383353933540335413354233543335443354533546335473354833549335503355133552335533355433555335563355733558335593356033561335623356333564335653356633567335683356933570335713357233573335743357533576335773357833579335803358133582335833358433585335863358733588335893359033591335923359333594335953359633597335983359933600336013360233603336043360533606336073360833609336103361133612336133361433615336163361733618336193362033621336223362333624336253362633627336283362933630336313363233633336343363533636336373363833639336403364133642336433364433645336463364733648336493365033651336523365333654336553365633657336583365933660336613366233663336643366533666336673366833669336703367133672336733367433675336763367733678336793368033681336823368333684336853368633687336883368933690336913369233693336943369533696336973369833699337003370133702337033370433705337063370733708337093371033711337123371333714337153371633717337183371933720337213372233723337243372533726337273372833729337303373133732337333373433735337363373733738337393374033741337423374333744337453374633747337483374933750337513375233753337543375533756337573375833759337603376133762337633376433765337663376733768337693377033771337723377333774337753377633777337783377933780337813378233783337843378533786337873378833789337903379133792337933379433795337963379733798337993380033801338023380333804338053380633807338083380933810338113381233813338143381533816338173381833819338203382133822338233382433825338263382733828338293383033831338323383333834338353383633837338383383933840338413384233843338443384533846338473384833849338503385133852338533385433855338563385733858338593386033861338623386333864338653386633867338683386933870338713387233873338743387533876338773387833879338803388133882338833388433885338863388733888338893389033891338923389333894338953389633897338983389933900339013390233903339043390533906339073390833909339103391133912339133391433915339163391733918339193392033921339223392333924339253392633927339283392933930339313393233933339343393533936339373393833939339403394133942339433394433945339463394733948339493395033951339523395333954339553395633957339583395933960339613396233963339643396533966339673396833969339703397133972339733397433975339763397733978339793398033981339823398333984339853398633987339883398933990339913399233993339943399533996339973399833999340003400134002340033400434005340063400734008340093401034011340123401334014340153401634017340183401934020340213402234023340243402534026340273402834029340303403134032340333403434035340363403734038340393404034041340423404334044340453404634047340483404934050340513405234053340543405534056340573405834059340603406134062340633406434065340663406734068340693407034071340723407334074340753407634077340783407934080340813408234083340843408534086340873408834089340903409134092340933409434095340963409734098340993410034101341023410334104341053410634107341083410934110341113411234113341143411534116341173411834119341203412134122341233412434125341263412734128341293413034131341323413334134341353413634137341383413934140341413414234143341443414534146341473414834149341503415134152341533415434155341563415734158341593416034161341623416334164341653416634167341683416934170341713417234173341743417534176341773417834179341803418134182341833418434185341863418734188341893419034191341923419334194341953419634197341983419934200342013420234203342043420534206342073420834209342103421134212342133421434215342163421734218342193422034221342223422334224342253422634227342283422934230342313423234233342343423534236342373423834239342403424134242342433424434245342463424734248342493425034251342523425334254342553425634257342583425934260342613426234263342643426534266342673426834269342703427134272342733427434275342763427734278342793428034281342823428334284342853428634287342883428934290342913429234293342943429534296342973429834299343003430134302343033430434305343063430734308343093431034311343123431334314343153431634317343183431934320343213432234323343243432534326343273432834329343303433134332343333433434335343363433734338343393434034341343423434334344343453434634347343483434934350343513435234353343543435534356343573435834359343603436134362343633436434365343663436734368343693437034371343723437334374343753437634377343783437934380343813438234383343843438534386343873438834389343903439134392343933439434395343963439734398343993440034401344023440334404344053440634407344083440934410344113441234413344143441534416344173441834419344203442134422344233442434425344263442734428344293443034431344323443334434344353443634437344383443934440344413444234443344443444534446344473444834449344503445134452344533445434455344563445734458344593446034461344623446334464344653446634467344683446934470344713447234473344743447534476344773447834479344803448134482344833448434485344863448734488344893449034491344923449334494344953449634497344983449934500345013450234503345043450534506345073450834509345103451134512345133451434515345163451734518345193452034521345223452334524345253452634527345283452934530345313453234533345343453534536345373453834539345403454134542345433454434545345463454734548345493455034551345523455334554345553455634557345583455934560345613456234563345643456534566345673456834569345703457134572345733457434575345763457734578345793458034581345823458334584345853458634587345883458934590345913459234593345943459534596345973459834599346003460134602346033460434605346063460734608346093461034611346123461334614346153461634617346183461934620346213462234623346243462534626346273462834629346303463134632346333463434635346363463734638346393464034641346423464334644346453464634647346483464934650346513465234653346543465534656346573465834659346603466134662346633466434665346663466734668346693467034671346723467334674346753467634677346783467934680346813468234683346843468534686346873468834689346903469134692346933469434695346963469734698346993470034701347023470334704347053470634707347083470934710347113471234713347143471534716347173471834719347203472134722347233472434725347263472734728347293473034731347323473334734347353473634737347383473934740347413474234743347443474534746347473474834749347503475134752347533475434755347563475734758347593476034761347623476334764347653476634767347683476934770347713477234773347743477534776347773477834779347803478134782347833478434785347863478734788347893479034791347923479334794347953479634797347983479934800348013480234803348043480534806348073480834809348103481134812348133481434815348163481734818348193482034821348223482334824348253482634827348283482934830348313483234833348343483534836348373483834839348403484134842348433484434845348463484734848348493485034851348523485334854348553485634857348583485934860348613486234863348643486534866348673486834869348703487134872348733487434875348763487734878348793488034881348823488334884348853488634887348883488934890348913489234893348943489534896348973489834899349003490134902349033490434905349063490734908349093491034911349123491334914349153491634917349183491934920349213492234923349243492534926349273492834929349303493134932349333493434935349363493734938349393494034941349423494334944349453494634947349483494934950349513495234953349543495534956349573495834959349603496134962349633496434965349663496734968349693497034971349723497334974349753497634977349783497934980349813498234983349843498534986349873498834989349903499134992349933499434995349963499734998349993500035001350023500335004350053500635007350083500935010350113501235013350143501535016350173501835019350203502135022350233502435025350263502735028350293503035031350323503335034350353503635037350383503935040350413504235043350443504535046350473504835049350503505135052350533505435055350563505735058350593506035061350623506335064350653506635067350683506935070350713507235073350743507535076350773507835079350803508135082350833508435085350863508735088350893509035091350923509335094350953509635097350983509935100351013510235103351043510535106351073510835109351103511135112351133511435115351163511735118351193512035121351223512335124351253512635127351283512935130351313513235133351343513535136351373513835139351403514135142351433514435145351463514735148351493515035151351523515335154351553515635157351583515935160351613516235163351643516535166351673516835169351703517135172351733517435175351763517735178351793518035181351823518335184351853518635187351883518935190351913519235193351943519535196351973519835199352003520135202352033520435205352063520735208352093521035211352123521335214352153521635217352183521935220352213522235223352243522535226352273522835229352303523135232352333523435235352363523735238352393524035241352423524335244352453524635247352483524935250352513525235253352543525535256352573525835259352603526135262352633526435265352663526735268352693527035271352723527335274352753527635277352783527935280352813528235283352843528535286352873528835289352903529135292352933529435295352963529735298352993530035301353023530335304353053530635307353083530935310353113531235313353143531535316353173531835319353203532135322353233532435325353263532735328353293533035331353323533335334353353533635337353383533935340353413534235343353443534535346353473534835349353503535135352353533535435355353563535735358353593536035361353623536335364353653536635367353683536935370353713537235373353743537535376353773537835379353803538135382353833538435385353863538735388353893539035391353923539335394353953539635397353983539935400354013540235403354043540535406354073540835409354103541135412354133541435415354163541735418354193542035421354223542335424354253542635427354283542935430354313543235433354343543535436354373543835439354403544135442354433544435445354463544735448354493545035451354523545335454354553545635457354583545935460354613546235463354643546535466354673546835469354703547135472354733547435475354763547735478354793548035481354823548335484354853548635487354883548935490354913549235493354943549535496354973549835499355003550135502355033550435505355063550735508355093551035511355123551335514355153551635517355183551935520355213552235523355243552535526355273552835529355303553135532355333553435535355363553735538355393554035541355423554335544355453554635547355483554935550355513555235553355543555535556355573555835559355603556135562355633556435565355663556735568355693557035571355723557335574355753557635577355783557935580355813558235583355843558535586355873558835589355903559135592355933559435595355963559735598355993560035601356023560335604356053560635607356083560935610356113561235613356143561535616356173561835619356203562135622356233562435625356263562735628356293563035631356323563335634356353563635637356383563935640356413564235643356443564535646356473564835649356503565135652356533565435655356563565735658356593566035661356623566335664356653566635667356683566935670356713567235673356743567535676356773567835679356803568135682356833568435685356863568735688356893569035691356923569335694356953569635697356983569935700357013570235703357043570535706357073570835709357103571135712357133571435715357163571735718357193572035721357223572335724357253572635727357283572935730357313573235733357343573535736357373573835739357403574135742357433574435745357463574735748357493575035751357523575335754357553575635757357583575935760357613576235763357643576535766357673576835769357703577135772357733577435775357763577735778357793578035781357823578335784357853578635787357883578935790357913579235793357943579535796357973579835799358003580135802358033580435805358063580735808358093581035811358123581335814358153581635817358183581935820358213582235823358243582535826358273582835829358303583135832358333583435835358363583735838358393584035841358423584335844358453584635847358483584935850358513585235853358543585535856358573585835859358603586135862358633586435865358663586735868358693587035871358723587335874358753587635877358783587935880358813588235883358843588535886358873588835889358903589135892358933589435895358963589735898358993590035901359023590335904359053590635907359083590935910359113591235913359143591535916359173591835919359203592135922359233592435925359263592735928359293593035931359323593335934359353593635937359383593935940359413594235943359443594535946359473594835949359503595135952359533595435955359563595735958359593596035961359623596335964359653596635967359683596935970359713597235973359743597535976359773597835979359803598135982359833598435985359863598735988359893599035991359923599335994359953599635997359983599936000360013600236003360043600536006360073600836009360103601136012360133601436015360163601736018360193602036021360223602336024360253602636027360283602936030360313603236033360343603536036360373603836039360403604136042360433604436045360463604736048360493605036051360523605336054360553605636057360583605936060360613606236063360643606536066360673606836069360703607136072360733607436075360763607736078360793608036081360823608336084360853608636087360883608936090360913609236093360943609536096360973609836099361003610136102361033610436105361063610736108361093611036111361123611336114361153611636117361183611936120361213612236123361243612536126361273612836129361303613136132361333613436135361363613736138361393614036141361423614336144361453614636147361483614936150361513615236153361543615536156361573615836159361603616136162361633616436165361663616736168361693617036171361723617336174361753617636177361783617936180361813618236183361843618536186361873618836189361903619136192361933619436195361963619736198361993620036201362023620336204362053620636207362083620936210362113621236213362143621536216362173621836219362203622136222362233622436225362263622736228362293623036231362323623336234362353623636237362383623936240362413624236243362443624536246362473624836249362503625136252362533625436255362563625736258362593626036261362623626336264362653626636267362683626936270362713627236273362743627536276362773627836279362803628136282362833628436285362863628736288362893629036291362923629336294362953629636297362983629936300363013630236303363043630536306363073630836309363103631136312363133631436315363163631736318363193632036321363223632336324363253632636327363283632936330363313633236333363343633536336363373633836339363403634136342363433634436345363463634736348363493635036351363523635336354363553635636357363583635936360363613636236363363643636536366363673636836369363703637136372363733637436375363763637736378363793638036381363823638336384363853638636387363883638936390363913639236393363943639536396363973639836399364003640136402364033640436405364063640736408364093641036411364123641336414364153641636417364183641936420364213642236423364243642536426364273642836429364303643136432364333643436435364363643736438364393644036441364423644336444364453644636447364483644936450364513645236453364543645536456364573645836459364603646136462364633646436465364663646736468364693647036471364723647336474364753647636477364783647936480364813648236483364843648536486364873648836489364903649136492364933649436495364963649736498364993650036501365023650336504365053650636507365083650936510365113651236513365143651536516365173651836519365203652136522365233652436525365263652736528365293653036531365323653336534365353653636537365383653936540365413654236543365443654536546365473654836549365503655136552365533655436555365563655736558365593656036561365623656336564365653656636567365683656936570365713657236573365743657536576365773657836579365803658136582365833658436585365863658736588365893659036591365923659336594365953659636597365983659936600366013660236603366043660536606366073660836609366103661136612366133661436615366163661736618366193662036621366223662336624366253662636627366283662936630366313663236633366343663536636366373663836639366403664136642366433664436645366463664736648366493665036651366523665336654366553665636657366583665936660366613666236663366643666536666366673666836669366703667136672366733667436675366763667736678366793668036681366823668336684366853668636687366883668936690366913669236693366943669536696366973669836699367003670136702367033670436705367063670736708367093671036711367123671336714367153671636717367183671936720367213672236723367243672536726367273672836729367303673136732367333673436735367363673736738367393674036741367423674336744367453674636747367483674936750367513675236753367543675536756367573675836759367603676136762367633676436765367663676736768367693677036771367723677336774367753677636777367783677936780367813678236783367843678536786367873678836789367903679136792367933679436795367963679736798367993680036801368023680336804368053680636807368083680936810368113681236813368143681536816368173681836819368203682136822368233682436825368263682736828368293683036831368323683336834368353683636837368383683936840368413684236843368443684536846368473684836849368503685136852368533685436855368563685736858368593686036861368623686336864368653686636867368683686936870368713687236873368743687536876368773687836879368803688136882368833688436885368863688736888368893689036891368923689336894368953689636897368983689936900369013690236903369043690536906369073690836909369103691136912369133691436915369163691736918369193692036921369223692336924369253692636927369283692936930369313693236933369343693536936369373693836939369403694136942369433694436945369463694736948369493695036951369523695336954369553695636957369583695936960369613696236963369643696536966369673696836969369703697136972369733697436975369763697736978369793698036981369823698336984369853698636987369883698936990369913699236993369943699536996369973699836999370003700137002370033700437005370063700737008370093701037011370123701337014370153701637017370183701937020370213702237023370243702537026370273702837029370303703137032370333703437035370363703737038370393704037041370423704337044370453704637047370483704937050370513705237053370543705537056370573705837059370603706137062370633706437065370663706737068370693707037071370723707337074370753707637077370783707937080370813708237083370843708537086370873708837089370903709137092370933709437095370963709737098370993710037101371023710337104371053710637107371083710937110371113711237113371143711537116371173711837119371203712137122371233712437125371263712737128371293713037131371323713337134371353713637137371383713937140371413714237143371443714537146371473714837149371503715137152371533715437155371563715737158371593716037161371623716337164371653716637167371683716937170371713717237173371743717537176371773717837179371803718137182371833718437185371863718737188371893719037191371923719337194371953719637197371983719937200372013720237203372043720537206372073720837209372103721137212372133721437215372163721737218372193722037221372223722337224372253722637227372283722937230372313723237233372343723537236372373723837239372403724137242372433724437245372463724737248372493725037251372523725337254372553725637257372583725937260372613726237263372643726537266372673726837269372703727137272372733727437275372763727737278372793728037281372823728337284372853728637287372883728937290372913729237293372943729537296372973729837299373003730137302373033730437305373063730737308373093731037311373123731337314373153731637317373183731937320373213732237323373243732537326373273732837329373303733137332373333733437335373363733737338373393734037341373423734337344373453734637347373483734937350373513735237353373543735537356373573735837359373603736137362373633736437365373663736737368373693737037371373723737337374373753737637377373783737937380373813738237383373843738537386373873738837389373903739137392373933739437395373963739737398373993740037401374023740337404374053740637407374083740937410374113741237413374143741537416374173741837419374203742137422374233742437425374263742737428374293743037431374323743337434374353743637437374383743937440374413744237443374443744537446374473744837449374503745137452374533745437455374563745737458374593746037461374623746337464374653746637467374683746937470374713747237473374743747537476374773747837479374803748137482374833748437485374863748737488374893749037491374923749337494374953749637497374983749937500375013750237503375043750537506375073750837509375103751137512375133751437515375163751737518375193752037521375223752337524375253752637527375283752937530375313753237533375343753537536375373753837539375403754137542375433754437545375463754737548375493755037551375523755337554375553755637557375583755937560375613756237563375643756537566375673756837569375703757137572375733757437575375763757737578375793758037581375823758337584375853758637587375883758937590375913759237593375943759537596375973759837599376003760137602376033760437605376063760737608376093761037611376123761337614376153761637617376183761937620376213762237623376243762537626376273762837629376303763137632376333763437635376363763737638376393764037641376423764337644376453764637647376483764937650376513765237653376543765537656376573765837659376603766137662376633766437665376663766737668376693767037671376723767337674376753767637677376783767937680376813768237683376843768537686376873768837689376903769137692376933769437695376963769737698376993770037701377023770337704377053770637707377083770937710377113771237713377143771537716377173771837719377203772137722377233772437725377263772737728377293773037731377323773337734377353773637737377383773937740377413774237743377443774537746377473774837749377503775137752377533775437755377563775737758377593776037761377623776337764377653776637767377683776937770377713777237773377743777537776377773777837779377803778137782377833778437785377863778737788377893779037791377923779337794377953779637797377983779937800378013780237803378043780537806378073780837809378103781137812378133781437815378163781737818378193782037821378223782337824378253782637827378283782937830378313783237833378343783537836378373783837839378403784137842378433784437845378463784737848378493785037851378523785337854378553785637857378583785937860378613786237863378643786537866378673786837869378703787137872378733787437875378763787737878378793788037881378823788337884378853788637887378883788937890378913789237893378943789537896378973789837899379003790137902379033790437905379063790737908379093791037911379123791337914379153791637917379183791937920379213792237923379243792537926379273792837929379303793137932379333793437935379363793737938379393794037941379423794337944379453794637947379483794937950379513795237953379543795537956379573795837959379603796137962379633796437965379663796737968379693797037971379723797337974379753797637977379783797937980379813798237983379843798537986379873798837989379903799137992379933799437995379963799737998379993800038001380023800338004380053800638007380083800938010380113801238013380143801538016380173801838019380203802138022380233802438025380263802738028380293803038031380323803338034380353803638037380383803938040380413804238043380443804538046380473804838049380503805138052380533805438055380563805738058380593806038061380623806338064380653806638067380683806938070380713807238073380743807538076380773807838079380803808138082380833808438085380863808738088380893809038091380923809338094380953809638097380983809938100381013810238103381043810538106381073810838109381103811138112381133811438115381163811738118381193812038121381223812338124381253812638127381283812938130381313813238133381343813538136381373813838139381403814138142381433814438145381463814738148381493815038151381523815338154381553815638157381583815938160381613816238163381643816538166381673816838169381703817138172381733817438175381763817738178381793818038181381823818338184381853818638187381883818938190381913819238193381943819538196381973819838199382003820138202382033820438205382063820738208382093821038211382123821338214382153821638217382183821938220382213822238223382243822538226382273822838229382303823138232382333823438235382363823738238382393824038241382423824338244382453824638247382483824938250382513825238253382543825538256382573825838259382603826138262382633826438265382663826738268382693827038271382723827338274382753827638277382783827938280382813828238283382843828538286382873828838289382903829138292382933829438295382963829738298382993830038301383023830338304383053830638307383083830938310383113831238313383143831538316383173831838319383203832138322383233832438325383263832738328383293833038331383323833338334383353833638337383383833938340383413834238343383443834538346383473834838349383503835138352383533835438355383563835738358383593836038361383623836338364383653836638367383683836938370383713837238373383743837538376383773837838379383803838138382383833838438385383863838738388383893839038391383923839338394383953839638397383983839938400384013840238403384043840538406384073840838409384103841138412384133841438415384163841738418384193842038421384223842338424384253842638427384283842938430384313843238433384343843538436384373843838439384403844138442384433844438445384463844738448384493845038451384523845338454384553845638457384583845938460384613846238463384643846538466384673846838469384703847138472384733847438475384763847738478384793848038481384823848338484384853848638487384883848938490384913849238493384943849538496384973849838499385003850138502385033850438505385063850738508385093851038511385123851338514385153851638517385183851938520385213852238523385243852538526385273852838529385303853138532385333853438535385363853738538385393854038541385423854338544385453854638547385483854938550385513855238553385543855538556385573855838559385603856138562385633856438565385663856738568385693857038571385723857338574385753857638577385783857938580385813858238583385843858538586385873858838589385903859138592385933859438595385963859738598385993860038601386023860338604386053860638607386083860938610386113861238613386143861538616386173861838619386203862138622386233862438625386263862738628386293863038631386323863338634386353863638637386383863938640386413864238643386443864538646386473864838649386503865138652386533865438655386563865738658386593866038661386623866338664386653866638667386683866938670386713867238673386743867538676386773867838679386803868138682386833868438685386863868738688386893869038691386923869338694386953869638697386983869938700387013870238703387043870538706387073870838709387103871138712387133871438715387163871738718387193872038721387223872338724387253872638727387283872938730387313873238733387343873538736387373873838739387403874138742387433874438745387463874738748387493875038751387523875338754387553875638757387583875938760387613876238763387643876538766387673876838769387703877138772387733877438775387763877738778387793878038781387823878338784387853878638787387883878938790387913879238793387943879538796387973879838799388003880138802388033880438805388063880738808388093881038811388123881338814388153881638817388183881938820388213882238823388243882538826388273882838829388303883138832388333883438835388363883738838388393884038841388423884338844388453884638847388483884938850388513885238853388543885538856388573885838859388603886138862388633886438865388663886738868388693887038871388723887338874388753887638877388783887938880388813888238883388843888538886388873888838889388903889138892388933889438895388963889738898388993890038901389023890338904389053890638907389083890938910389113891238913389143891538916389173891838919389203892138922389233892438925389263892738928389293893038931389323893338934389353893638937389383893938940389413894238943389443894538946389473894838949389503895138952389533895438955389563895738958389593896038961389623896338964389653896638967389683896938970389713897238973389743897538976389773897838979389803898138982389833898438985389863898738988389893899038991389923899338994389953899638997389983899939000390013900239003390043900539006390073900839009390103901139012390133901439015390163901739018390193902039021390223902339024390253902639027390283902939030390313903239033390343903539036390373903839039390403904139042390433904439045390463904739048390493905039051390523905339054390553905639057390583905939060390613906239063390643906539066390673906839069390703907139072390733907439075390763907739078390793908039081390823908339084390853908639087390883908939090390913909239093390943909539096390973909839099391003910139102391033910439105391063910739108391093911039111391123911339114391153911639117391183911939120391213912239123391243912539126391273912839129391303913139132391333913439135391363913739138391393914039141391423914339144391453914639147391483914939150391513915239153391543915539156391573915839159391603916139162391633916439165391663916739168391693917039171391723917339174391753917639177391783917939180391813918239183391843918539186391873918839189391903919139192391933919439195391963919739198391993920039201392023920339204392053920639207392083920939210392113921239213392143921539216392173921839219392203922139222392233922439225392263922739228392293923039231392323923339234392353923639237392383923939240392413924239243392443924539246392473924839249392503925139252392533925439255392563925739258392593926039261392623926339264392653926639267392683926939270392713927239273392743927539276392773927839279392803928139282392833928439285392863928739288392893929039291392923929339294392953929639297392983929939300393013930239303393043930539306393073930839309393103931139312393133931439315393163931739318393193932039321393223932339324393253932639327393283932939330393313933239333393343933539336393373933839339393403934139342393433934439345393463934739348393493935039351393523935339354393553935639357393583935939360393613936239363393643936539366393673936839369393703937139372393733937439375393763937739378393793938039381393823938339384393853938639387393883938939390393913939239393393943939539396393973939839399394003940139402394033940439405394063940739408394093941039411394123941339414394153941639417394183941939420394213942239423394243942539426394273942839429394303943139432394333943439435394363943739438394393944039441394423944339444394453944639447394483944939450394513945239453394543945539456394573945839459394603946139462394633946439465394663946739468394693947039471394723947339474394753947639477394783947939480394813948239483394843948539486394873948839489394903949139492394933949439495394963949739498394993950039501395023950339504395053950639507395083950939510395113951239513395143951539516395173951839519395203952139522395233952439525395263952739528395293953039531395323953339534395353953639537395383953939540395413954239543395443954539546395473954839549395503955139552395533955439555395563955739558395593956039561395623956339564395653956639567395683956939570395713957239573395743957539576395773957839579395803958139582395833958439585395863958739588395893959039591395923959339594395953959639597395983959939600396013960239603396043960539606396073960839609396103961139612396133961439615396163961739618396193962039621396223962339624396253962639627396283962939630396313963239633396343963539636396373963839639396403964139642396433964439645396463964739648396493965039651396523965339654396553965639657396583965939660396613966239663396643966539666396673966839669396703967139672396733967439675396763967739678396793968039681396823968339684396853968639687396883968939690396913969239693396943969539696396973969839699397003970139702397033970439705397063970739708397093971039711397123971339714397153971639717397183971939720397213972239723397243972539726397273972839729397303973139732397333973439735397363973739738397393974039741397423974339744397453974639747397483974939750397513975239753397543975539756397573975839759397603976139762397633976439765397663976739768397693977039771397723977339774397753977639777397783977939780397813978239783397843978539786397873978839789397903979139792397933979439795397963979739798397993980039801398023980339804398053980639807398083980939810398113981239813398143981539816398173981839819398203982139822398233982439825398263982739828398293983039831398323983339834398353983639837398383983939840398413984239843398443984539846398473984839849398503985139852398533985439855398563985739858398593986039861398623986339864398653986639867398683986939870398713987239873398743987539876398773987839879398803988139882398833988439885398863988739888398893989039891398923989339894398953989639897398983989939900399013990239903399043990539906399073990839909399103991139912399133991439915399163991739918399193992039921399223992339924399253992639927399283992939930399313993239933399343993539936399373993839939399403994139942399433994439945399463994739948399493995039951399523995339954399553995639957399583995939960399613996239963399643996539966399673996839969399703997139972399733997439975399763997739978399793998039981399823998339984399853998639987399883998939990399913999239993399943999539996399973999839999400004000140002400034000440005400064000740008400094001040011400124001340014400154001640017400184001940020400214002240023400244002540026400274002840029400304003140032400334003440035400364003740038400394004040041400424004340044400454004640047400484004940050400514005240053400544005540056400574005840059400604006140062400634006440065400664006740068400694007040071400724007340074400754007640077400784007940080400814008240083400844008540086400874008840089400904009140092400934009440095400964009740098400994010040101401024010340104401054010640107401084010940110401114011240113401144011540116401174011840119401204012140122401234012440125401264012740128401294013040131401324013340134401354013640137401384013940140401414014240143401444014540146401474014840149401504015140152401534015440155401564015740158401594016040161401624016340164401654016640167401684016940170401714017240173401744017540176401774017840179401804018140182401834018440185401864018740188401894019040191401924019340194401954019640197401984019940200402014020240203402044020540206402074020840209402104021140212402134021440215402164021740218402194022040221402224022340224402254022640227402284022940230402314023240233402344023540236402374023840239402404024140242402434024440245402464024740248402494025040251402524025340254402554025640257402584025940260402614026240263402644026540266402674026840269402704027140272402734027440275402764027740278402794028040281402824028340284402854028640287402884028940290402914029240293402944029540296402974029840299403004030140302403034030440305403064030740308403094031040311403124031340314403154031640317403184031940320403214032240323403244032540326403274032840329403304033140332403334033440335403364033740338403394034040341403424034340344403454034640347403484034940350403514035240353403544035540356403574035840359403604036140362403634036440365403664036740368403694037040371403724037340374403754037640377403784037940380403814038240383403844038540386403874038840389403904039140392403934039440395403964039740398403994040040401404024040340404404054040640407404084040940410404114041240413404144041540416404174041840419404204042140422404234042440425404264042740428404294043040431404324043340434404354043640437404384043940440404414044240443404444044540446404474044840449404504045140452404534045440455404564045740458404594046040461404624046340464404654046640467404684046940470404714047240473404744047540476404774047840479404804048140482404834048440485404864048740488404894049040491404924049340494404954049640497404984049940500405014050240503405044050540506405074050840509405104051140512405134051440515405164051740518405194052040521405224052340524405254052640527405284052940530405314053240533405344053540536405374053840539405404054140542405434054440545405464054740548405494055040551405524055340554405554055640557405584055940560405614056240563405644056540566405674056840569405704057140572405734057440575405764057740578405794058040581405824058340584405854058640587405884058940590405914059240593405944059540596405974059840599406004060140602406034060440605406064060740608406094061040611406124061340614406154061640617406184061940620406214062240623406244062540626406274062840629406304063140632406334063440635406364063740638406394064040641406424064340644406454064640647406484064940650406514065240653406544065540656406574065840659406604066140662406634066440665406664066740668406694067040671406724067340674406754067640677406784067940680406814068240683406844068540686406874068840689406904069140692406934069440695406964069740698406994070040701407024070340704407054070640707407084070940710407114071240713407144071540716407174071840719407204072140722407234072440725407264072740728407294073040731407324073340734407354073640737407384073940740407414074240743407444074540746407474074840749407504075140752407534075440755407564075740758407594076040761407624076340764407654076640767407684076940770407714077240773407744077540776407774077840779407804078140782407834078440785407864078740788407894079040791407924079340794407954079640797407984079940800408014080240803408044080540806408074080840809408104081140812408134081440815408164081740818408194082040821408224082340824408254082640827408284082940830408314083240833408344083540836408374083840839408404084140842408434084440845408464084740848408494085040851408524085340854408554085640857408584085940860408614086240863408644086540866408674086840869408704087140872408734087440875408764087740878408794088040881408824088340884408854088640887408884088940890408914089240893408944089540896408974089840899409004090140902409034090440905409064090740908409094091040911409124091340914409154091640917409184091940920409214092240923409244092540926409274092840929409304093140932409334093440935409364093740938409394094040941409424094340944409454094640947409484094940950409514095240953409544095540956409574095840959409604096140962409634096440965409664096740968409694097040971409724097340974409754097640977409784097940980409814098240983409844098540986409874098840989409904099140992409934099440995409964099740998409994100041001410024100341004410054100641007410084100941010410114101241013410144101541016410174101841019410204102141022410234102441025410264102741028410294103041031410324103341034410354103641037410384103941040410414104241043410444104541046410474104841049410504105141052410534105441055410564105741058410594106041061410624106341064410654106641067410684106941070410714107241073410744107541076410774107841079410804108141082410834108441085410864108741088410894109041091410924109341094410954109641097410984109941100411014110241103411044110541106411074110841109411104111141112411134111441115411164111741118411194112041121411224112341124411254112641127411284112941130411314113241133411344113541136411374113841139411404114141142411434114441145411464114741148411494115041151411524115341154411554115641157411584115941160411614116241163411644116541166411674116841169411704117141172411734117441175411764117741178411794118041181411824118341184411854118641187411884118941190411914119241193411944119541196411974119841199412004120141202412034120441205412064120741208412094121041211412124121341214412154121641217412184121941220412214122241223412244122541226412274122841229412304123141232412334123441235412364123741238412394124041241412424124341244412454124641247412484124941250412514125241253412544125541256412574125841259412604126141262412634126441265412664126741268412694127041271412724127341274412754127641277412784127941280412814128241283412844128541286412874128841289412904129141292412934129441295412964129741298412994130041301413024130341304413054130641307413084130941310413114131241313413144131541316413174131841319413204132141322413234132441325413264132741328413294133041331413324133341334413354133641337413384133941340413414134241343413444134541346413474134841349413504135141352413534135441355413564135741358413594136041361413624136341364413654136641367413684136941370413714137241373413744137541376413774137841379413804138141382413834138441385413864138741388413894139041391413924139341394413954139641397413984139941400414014140241403414044140541406414074140841409414104141141412414134141441415414164141741418414194142041421414224142341424414254142641427414284142941430414314143241433414344143541436414374143841439414404144141442414434144441445414464144741448414494145041451414524145341454414554145641457414584145941460414614146241463414644146541466414674146841469414704147141472414734147441475414764147741478414794148041481414824148341484414854148641487414884148941490414914149241493414944149541496414974149841499415004150141502415034150441505415064150741508415094151041511415124151341514415154151641517415184151941520415214152241523415244152541526415274152841529415304153141532415334153441535415364153741538415394154041541415424154341544415454154641547415484154941550415514155241553415544155541556415574155841559415604156141562415634156441565415664156741568415694157041571415724157341574415754157641577415784157941580415814158241583415844158541586415874158841589415904159141592415934159441595415964159741598415994160041601416024160341604416054160641607416084160941610416114161241613416144161541616416174161841619416204162141622416234162441625416264162741628416294163041631416324163341634416354163641637416384163941640416414164241643416444164541646416474164841649416504165141652416534165441655416564165741658416594166041661416624166341664416654166641667416684166941670416714167241673416744167541676416774167841679416804168141682416834168441685416864168741688416894169041691416924169341694416954169641697416984169941700417014170241703417044170541706417074170841709417104171141712417134171441715417164171741718417194172041721417224172341724417254172641727417284172941730417314173241733417344173541736417374173841739417404174141742417434174441745417464174741748417494175041751417524175341754417554175641757417584175941760417614176241763417644176541766417674176841769417704177141772417734177441775417764177741778417794178041781417824178341784417854178641787417884178941790417914179241793417944179541796417974179841799418004180141802418034180441805418064180741808418094181041811418124181341814418154181641817418184181941820418214182241823418244182541826418274182841829418304183141832418334183441835418364183741838418394184041841418424184341844418454184641847418484184941850418514185241853418544185541856418574185841859418604186141862418634186441865418664186741868418694187041871418724187341874418754187641877418784187941880418814188241883418844188541886418874188841889418904189141892418934189441895418964189741898418994190041901419024190341904419054190641907419084190941910419114191241913419144191541916419174191841919419204192141922419234192441925419264192741928419294193041931419324193341934419354193641937419384193941940419414194241943419444194541946419474194841949419504195141952419534195441955419564195741958419594196041961419624196341964419654196641967419684196941970419714197241973419744197541976419774197841979419804198141982419834198441985419864198741988419894199041991419924199341994419954199641997419984199942000420014200242003420044200542006420074200842009420104201142012420134201442015420164201742018420194202042021420224202342024420254202642027420284202942030420314203242033420344203542036420374203842039420404204142042420434204442045420464204742048420494205042051420524205342054420554205642057420584205942060420614206242063420644206542066420674206842069420704207142072420734207442075420764207742078420794208042081420824208342084420854208642087420884208942090420914209242093420944209542096420974209842099421004210142102421034210442105421064210742108421094211042111421124211342114421154211642117421184211942120421214212242123421244212542126421274212842129421304213142132421334213442135421364213742138421394214042141421424214342144421454214642147421484214942150421514215242153421544215542156421574215842159421604216142162421634216442165421664216742168421694217042171421724217342174421754217642177421784217942180421814218242183421844218542186421874218842189421904219142192421934219442195421964219742198421994220042201422024220342204422054220642207422084220942210422114221242213422144221542216422174221842219422204222142222422234222442225422264222742228422294223042231422324223342234422354223642237422384223942240422414224242243422444224542246422474224842249422504225142252422534225442255422564225742258422594226042261422624226342264422654226642267422684226942270422714227242273422744227542276422774227842279422804228142282422834228442285422864228742288422894229042291422924229342294422954229642297422984229942300423014230242303423044230542306423074230842309423104231142312423134231442315423164231742318423194232042321423224232342324423254232642327423284232942330423314233242333423344233542336423374233842339423404234142342423434234442345423464234742348423494235042351423524235342354423554235642357423584235942360423614236242363423644236542366423674236842369423704237142372423734237442375423764237742378423794238042381423824238342384423854238642387423884238942390423914239242393423944239542396423974239842399424004240142402424034240442405424064240742408424094241042411424124241342414424154241642417424184241942420424214242242423424244242542426424274242842429424304243142432424334243442435424364243742438424394244042441424424244342444424454244642447424484244942450424514245242453424544245542456424574245842459424604246142462424634246442465424664246742468424694247042471424724247342474424754247642477424784247942480424814248242483424844248542486424874248842489424904249142492424934249442495424964249742498424994250042501425024250342504425054250642507425084250942510425114251242513425144251542516425174251842519425204252142522425234252442525425264252742528425294253042531425324253342534425354253642537425384253942540425414254242543425444254542546425474254842549425504255142552425534255442555425564255742558425594256042561425624256342564425654256642567425684256942570425714257242573425744257542576425774257842579425804258142582425834258442585425864258742588425894259042591425924259342594425954259642597425984259942600426014260242603426044260542606426074260842609426104261142612426134261442615426164261742618426194262042621426224262342624426254262642627426284262942630426314263242633426344263542636426374263842639426404264142642426434264442645426464264742648426494265042651426524265342654426554265642657426584265942660426614266242663426644266542666426674266842669426704267142672426734267442675426764267742678426794268042681426824268342684426854268642687426884268942690426914269242693426944269542696426974269842699427004270142702427034270442705427064270742708427094271042711427124271342714427154271642717427184271942720427214272242723427244272542726427274272842729427304273142732427334273442735427364273742738427394274042741427424274342744427454274642747427484274942750427514275242753427544275542756427574275842759427604276142762427634276442765427664276742768427694277042771427724277342774427754277642777427784277942780427814278242783427844278542786427874278842789427904279142792427934279442795427964279742798427994280042801428024280342804428054280642807428084280942810428114281242813428144281542816428174281842819428204282142822428234282442825428264282742828428294283042831428324283342834428354283642837428384283942840428414284242843428444284542846428474284842849428504285142852428534285442855428564285742858428594286042861428624286342864428654286642867428684286942870428714287242873428744287542876428774287842879428804288142882428834288442885428864288742888428894289042891428924289342894428954289642897428984289942900429014290242903429044290542906429074290842909429104291142912429134291442915429164291742918429194292042921429224292342924429254292642927429284292942930429314293242933429344293542936429374293842939429404294142942429434294442945429464294742948429494295042951429524295342954429554295642957429584295942960429614296242963429644296542966429674296842969429704297142972429734297442975429764297742978429794298042981429824298342984429854298642987429884298942990429914299242993429944299542996429974299842999430004300143002430034300443005430064300743008430094301043011430124301343014430154301643017430184301943020430214302243023430244302543026430274302843029430304303143032430334303443035430364303743038430394304043041430424304343044430454304643047430484304943050430514305243053430544305543056430574305843059430604306143062430634306443065430664306743068430694307043071430724307343074430754307643077430784307943080430814308243083430844308543086430874308843089430904309143092430934309443095430964309743098430994310043101431024310343104431054310643107431084310943110431114311243113431144311543116431174311843119431204312143122431234312443125431264312743128431294313043131431324313343134431354313643137431384313943140431414314243143431444314543146431474314843149431504315143152431534315443155431564315743158431594316043161431624316343164431654316643167431684316943170431714317243173431744317543176431774317843179431804318143182431834318443185431864318743188431894319043191431924319343194431954319643197431984319943200432014320243203432044320543206432074320843209432104321143212432134321443215432164321743218432194322043221432224322343224432254322643227432284322943230432314323243233432344323543236432374323843239432404324143242432434324443245432464324743248432494325043251432524325343254432554325643257432584325943260432614326243263432644326543266432674326843269432704327143272432734327443275432764327743278432794328043281432824328343284432854328643287432884328943290432914329243293432944329543296432974329843299433004330143302433034330443305433064330743308433094331043311433124331343314433154331643317433184331943320433214332243323433244332543326433274332843329433304333143332433334333443335433364333743338433394334043341433424334343344433454334643347433484334943350433514335243353433544335543356433574335843359433604336143362433634336443365433664336743368433694337043371433724337343374433754337643377433784337943380433814338243383433844338543386433874338843389433904339143392433934339443395433964339743398433994340043401434024340343404434054340643407434084340943410434114341243413434144341543416434174341843419434204342143422434234342443425434264342743428434294343043431434324343343434434354343643437434384343943440434414344243443434444344543446434474344843449434504345143452434534345443455434564345743458434594346043461434624346343464434654346643467434684346943470434714347243473434744347543476434774347843479434804348143482434834348443485434864348743488434894349043491434924349343494434954349643497434984349943500435014350243503435044350543506435074350843509435104351143512435134351443515435164351743518435194352043521435224352343524435254352643527435284352943530435314353243533435344353543536435374353843539435404354143542435434354443545435464354743548435494355043551435524355343554435554355643557435584355943560435614356243563435644356543566435674356843569435704357143572435734357443575435764357743578435794358043581435824358343584435854358643587435884358943590435914359243593435944359543596435974359843599436004360143602436034360443605436064360743608436094361043611436124361343614436154361643617436184361943620436214362243623436244362543626436274362843629436304363143632436334363443635436364363743638436394364043641436424364343644436454364643647436484364943650436514365243653436544365543656436574365843659436604366143662436634366443665436664366743668436694367043671436724367343674436754367643677436784367943680436814368243683436844368543686436874368843689436904369143692436934369443695436964369743698436994370043701437024370343704437054370643707437084370943710437114371243713437144371543716437174371843719437204372143722437234372443725437264372743728437294373043731437324373343734437354373643737437384373943740437414374243743437444374543746437474374843749437504375143752437534375443755437564375743758437594376043761437624376343764437654376643767437684376943770437714377243773437744377543776437774377843779437804378143782437834378443785437864378743788437894379043791437924379343794437954379643797437984379943800438014380243803438044380543806438074380843809438104381143812438134381443815438164381743818438194382043821438224382343824438254382643827438284382943830438314383243833438344383543836438374383843839438404384143842438434384443845438464384743848438494385043851438524385343854438554385643857438584385943860438614386243863438644386543866438674386843869438704387143872438734387443875438764387743878438794388043881438824388343884438854388643887438884388943890438914389243893438944389543896438974389843899439004390143902439034390443905439064390743908439094391043911439124391343914439154391643917439184391943920439214392243923439244392543926439274392843929439304393143932439334393443935439364393743938439394394043941439424394343944439454394643947439484394943950439514395243953439544395543956439574395843959439604396143962439634396443965439664396743968439694397043971439724397343974439754397643977439784397943980439814398243983439844398543986439874398843989439904399143992439934399443995439964399743998439994400044001440024400344004440054400644007440084400944010440114401244013440144401544016440174401844019440204402144022440234402444025440264402744028440294403044031440324403344034440354403644037440384403944040440414404244043440444404544046440474404844049440504405144052440534405444055440564405744058440594406044061440624406344064440654406644067440684406944070440714407244073440744407544076440774407844079440804408144082440834408444085440864408744088440894409044091440924409344094440954409644097440984409944100441014410244103441044410544106441074410844109441104411144112441134411444115441164411744118441194412044121441224412344124441254412644127441284412944130441314413244133441344413544136441374413844139441404414144142441434414444145441464414744148441494415044151441524415344154441554415644157441584415944160441614416244163441644416544166441674416844169441704417144172441734417444175441764417744178441794418044181441824418344184441854418644187441884418944190441914419244193441944419544196441974419844199442004420144202442034420444205442064420744208442094421044211442124421344214442154421644217442184421944220442214422244223442244422544226442274422844229442304423144232442334423444235442364423744238442394424044241442424424344244442454424644247442484424944250442514425244253442544425544256442574425844259442604426144262442634426444265442664426744268442694427044271442724427344274442754427644277442784427944280442814428244283442844428544286442874428844289442904429144292442934429444295442964429744298442994430044301443024430344304443054430644307443084430944310443114431244313443144431544316443174431844319443204432144322443234432444325443264432744328443294433044331443324433344334443354433644337443384433944340443414434244343443444434544346443474434844349443504435144352443534435444355443564435744358443594436044361443624436344364443654436644367443684436944370443714437244373443744437544376443774437844379443804438144382443834438444385443864438744388443894439044391443924439344394443954439644397443984439944400444014440244403444044440544406444074440844409444104441144412444134441444415444164441744418444194442044421444224442344424444254442644427444284442944430444314443244433444344443544436444374443844439444404444144442444434444444445444464444744448444494445044451444524445344454444554445644457444584445944460444614446244463444644446544466444674446844469444704447144472444734447444475444764447744478444794448044481444824448344484444854448644487444884448944490444914449244493444944449544496444974449844499445004450144502445034450444505445064450744508445094451044511445124451344514445154451644517445184451944520445214452244523445244452544526445274452844529445304453144532445334453444535445364453744538445394454044541445424454344544445454454644547445484454944550445514455244553445544455544556445574455844559445604456144562445634456444565445664456744568445694457044571445724457344574445754457644577445784457944580445814458244583445844458544586445874458844589445904459144592445934459444595445964459744598445994460044601446024460344604446054460644607446084460944610446114461244613446144461544616446174461844619446204462144622446234462444625446264462744628446294463044631446324463344634446354463644637446384463944640446414464244643446444464544646446474464844649446504465144652446534465444655446564465744658446594466044661446624466344664446654466644667446684466944670446714467244673446744467544676446774467844679446804468144682446834468444685446864468744688446894469044691446924469344694446954469644697446984469944700447014470244703447044470544706447074470844709447104471144712447134471444715447164471744718447194472044721447224472344724447254472644727447284472944730447314473244733447344473544736447374473844739447404474144742447434474444745447464474744748447494475044751447524475344754447554475644757447584475944760447614476244763447644476544766447674476844769447704477144772447734477444775447764477744778447794478044781447824478344784447854478644787447884478944790447914479244793447944479544796447974479844799448004480144802448034480444805448064480744808448094481044811448124481344814448154481644817448184481944820448214482244823448244482544826448274482844829448304483144832448334483444835448364483744838448394484044841448424484344844448454484644847448484484944850448514485244853448544485544856448574485844859448604486144862448634486444865448664486744868448694487044871448724487344874448754487644877448784487944880448814488244883448844488544886448874488844889448904489144892448934489444895448964489744898448994490044901449024490344904449054490644907449084490944910449114491244913449144491544916449174491844919449204492144922449234492444925449264492744928449294493044931449324493344934449354493644937449384493944940449414494244943449444494544946449474494844949449504495144952449534495444955449564495744958449594496044961449624496344964449654496644967449684496944970449714497244973449744497544976449774497844979449804498144982449834498444985449864498744988449894499044991449924499344994449954499644997449984499945000450014500245003450044500545006450074500845009450104501145012450134501445015450164501745018450194502045021450224502345024450254502645027450284502945030450314503245033450344503545036450374503845039450404504145042450434504445045450464504745048450494505045051450524505345054450554505645057450584505945060450614506245063450644506545066450674506845069450704507145072450734507445075450764507745078450794508045081450824508345084450854508645087450884508945090450914509245093450944509545096450974509845099451004510145102451034510445105451064510745108451094511045111451124511345114451154511645117451184511945120451214512245123451244512545126451274512845129451304513145132451334513445135451364513745138451394514045141451424514345144451454514645147451484514945150451514515245153451544515545156451574515845159451604516145162451634516445165451664516745168451694517045171451724517345174451754517645177451784517945180451814518245183451844518545186451874518845189451904519145192451934519445195451964519745198451994520045201452024520345204452054520645207452084520945210452114521245213452144521545216452174521845219452204522145222452234522445225452264522745228452294523045231452324523345234452354523645237452384523945240452414524245243452444524545246452474524845249452504525145252452534525445255452564525745258452594526045261452624526345264452654526645267452684526945270452714527245273452744527545276452774527845279452804528145282452834528445285452864528745288452894529045291452924529345294452954529645297452984529945300453014530245303453044530545306453074530845309453104531145312453134531445315453164531745318453194532045321453224532345324453254532645327453284532945330453314533245333453344533545336453374533845339453404534145342453434534445345453464534745348453494535045351453524535345354453554535645357453584535945360453614536245363453644536545366453674536845369453704537145372453734537445375453764537745378453794538045381453824538345384453854538645387453884538945390453914539245393453944539545396453974539845399454004540145402454034540445405454064540745408454094541045411454124541345414454154541645417454184541945420454214542245423454244542545426454274542845429454304543145432454334543445435454364543745438454394544045441454424544345444454454544645447454484544945450454514545245453454544545545456454574545845459454604546145462454634546445465454664546745468454694547045471454724547345474454754547645477454784547945480454814548245483454844548545486454874548845489454904549145492454934549445495454964549745498454994550045501455024550345504455054550645507455084550945510455114551245513455144551545516455174551845519455204552145522455234552445525455264552745528455294553045531455324553345534455354553645537455384553945540455414554245543455444554545546455474554845549455504555145552455534555445555455564555745558455594556045561455624556345564455654556645567455684556945570455714557245573455744557545576455774557845579455804558145582455834558445585455864558745588455894559045591455924559345594455954559645597455984559945600456014560245603456044560545606456074560845609456104561145612456134561445615456164561745618456194562045621456224562345624456254562645627456284562945630456314563245633456344563545636456374563845639456404564145642456434564445645456464564745648456494565045651456524565345654456554565645657456584565945660456614566245663456644566545666456674566845669456704567145672456734567445675456764567745678456794568045681456824568345684456854568645687456884568945690456914569245693456944569545696456974569845699457004570145702457034570445705457064570745708457094571045711457124571345714457154571645717457184571945720457214572245723457244572545726457274572845729457304573145732457334573445735457364573745738457394574045741457424574345744457454574645747457484574945750457514575245753457544575545756457574575845759457604576145762457634576445765457664576745768457694577045771457724577345774457754577645777457784577945780457814578245783457844578545786457874578845789457904579145792457934579445795457964579745798457994580045801458024580345804458054580645807458084580945810458114581245813458144581545816458174581845819458204582145822458234582445825458264582745828458294583045831458324583345834458354583645837458384583945840458414584245843458444584545846458474584845849458504585145852458534585445855458564585745858458594586045861458624586345864458654586645867458684586945870458714587245873458744587545876458774587845879458804588145882458834588445885458864588745888458894589045891458924589345894458954589645897458984589945900459014590245903459044590545906459074590845909459104591145912459134591445915459164591745918459194592045921459224592345924459254592645927459284592945930459314593245933459344593545936459374593845939459404594145942459434594445945459464594745948459494595045951459524595345954459554595645957459584595945960459614596245963459644596545966459674596845969459704597145972459734597445975459764597745978459794598045981459824598345984459854598645987459884598945990459914599245993459944599545996459974599845999460004600146002460034600446005460064600746008460094601046011460124601346014460154601646017460184601946020460214602246023460244602546026460274602846029460304603146032460334603446035460364603746038460394604046041460424604346044460454604646047460484604946050460514605246053460544605546056460574605846059460604606146062460634606446065460664606746068460694607046071460724607346074460754607646077460784607946080460814608246083460844608546086460874608846089460904609146092460934609446095460964609746098460994610046101461024610346104461054610646107461084610946110461114611246113461144611546116461174611846119461204612146122461234612446125461264612746128461294613046131461324613346134461354613646137461384613946140461414614246143461444614546146461474614846149461504615146152461534615446155461564615746158461594616046161461624616346164461654616646167461684616946170461714617246173461744617546176461774617846179461804618146182461834618446185461864618746188461894619046191461924619346194461954619646197461984619946200462014620246203462044620546206462074620846209462104621146212462134621446215462164621746218462194622046221462224622346224462254622646227462284622946230462314623246233462344623546236462374623846239462404624146242462434624446245462464624746248462494625046251462524625346254462554625646257462584625946260462614626246263462644626546266462674626846269462704627146272462734627446275462764627746278462794628046281462824628346284462854628646287462884628946290462914629246293462944629546296462974629846299463004630146302463034630446305463064630746308463094631046311463124631346314463154631646317463184631946320463214632246323463244632546326463274632846329463304633146332463334633446335463364633746338463394634046341463424634346344463454634646347463484634946350463514635246353463544635546356463574635846359463604636146362463634636446365463664636746368463694637046371463724637346374463754637646377463784637946380463814638246383463844638546386463874638846389463904639146392463934639446395463964639746398463994640046401464024640346404464054640646407464084640946410464114641246413464144641546416464174641846419464204642146422464234642446425464264642746428464294643046431464324643346434464354643646437464384643946440464414644246443464444644546446464474644846449464504645146452464534645446455464564645746458464594646046461464624646346464464654646646467464684646946470464714647246473464744647546476464774647846479464804648146482464834648446485464864648746488464894649046491464924649346494464954649646497464984649946500465014650246503465044650546506465074650846509465104651146512465134651446515465164651746518465194652046521465224652346524465254652646527465284652946530465314653246533465344653546536465374653846539465404654146542465434654446545465464654746548465494655046551465524655346554465554655646557465584655946560465614656246563465644656546566465674656846569465704657146572465734657446575465764657746578465794658046581465824658346584465854658646587465884658946590465914659246593465944659546596465974659846599466004660146602466034660446605466064660746608466094661046611466124661346614466154661646617466184661946620466214662246623466244662546626466274662846629466304663146632466334663446635466364663746638466394664046641466424664346644466454664646647466484664946650466514665246653466544665546656466574665846659466604666146662466634666446665466664666746668466694667046671466724667346674466754667646677466784667946680466814668246683466844668546686466874668846689466904669146692466934669446695466964669746698466994670046701467024670346704467054670646707467084670946710467114671246713467144671546716467174671846719467204672146722467234672446725467264672746728467294673046731467324673346734467354673646737467384673946740467414674246743467444674546746467474674846749467504675146752467534675446755467564675746758467594676046761467624676346764467654676646767467684676946770467714677246773467744677546776467774677846779467804678146782467834678446785467864678746788467894679046791467924679346794467954679646797467984679946800468014680246803468044680546806468074680846809468104681146812468134681446815468164681746818468194682046821468224682346824468254682646827468284682946830468314683246833468344683546836468374683846839468404684146842468434684446845468464684746848468494685046851468524685346854468554685646857468584685946860468614686246863468644686546866468674686846869468704687146872468734687446875468764687746878468794688046881468824688346884468854688646887468884688946890468914689246893468944689546896468974689846899469004690146902469034690446905469064690746908469094691046911469124691346914469154691646917469184691946920469214692246923469244692546926469274692846929469304693146932469334693446935469364693746938469394694046941469424694346944469454694646947469484694946950469514695246953469544695546956469574695846959469604696146962469634696446965469664696746968469694697046971469724697346974469754697646977469784697946980469814698246983469844698546986469874698846989469904699146992469934699446995469964699746998469994700047001470024700347004470054700647007470084700947010470114701247013470144701547016470174701847019470204702147022470234702447025470264702747028470294703047031470324703347034470354703647037470384703947040470414704247043470444704547046470474704847049470504705147052470534705447055470564705747058470594706047061470624706347064470654706647067470684706947070470714707247073470744707547076470774707847079470804708147082470834708447085470864708747088470894709047091470924709347094470954709647097470984709947100471014710247103471044710547106471074710847109471104711147112471134711447115471164711747118471194712047121471224712347124471254712647127471284712947130471314713247133471344713547136471374713847139471404714147142471434714447145471464714747148471494715047151471524715347154471554715647157471584715947160471614716247163471644716547166471674716847169471704717147172471734717447175471764717747178471794718047181471824718347184471854718647187471884718947190471914719247193471944719547196471974719847199472004720147202472034720447205472064720747208472094721047211472124721347214472154721647217472184721947220472214722247223472244722547226472274722847229472304723147232472334723447235472364723747238472394724047241472424724347244472454724647247472484724947250472514725247253472544725547256472574725847259472604726147262472634726447265472664726747268472694727047271472724727347274472754727647277472784727947280472814728247283472844728547286472874728847289472904729147292472934729447295472964729747298472994730047301473024730347304473054730647307473084730947310473114731247313473144731547316473174731847319473204732147322473234732447325473264732747328473294733047331473324733347334473354733647337473384733947340473414734247343473444734547346473474734847349473504735147352473534735447355473564735747358473594736047361473624736347364473654736647367473684736947370473714737247373473744737547376473774737847379473804738147382473834738447385473864738747388473894739047391473924739347394473954739647397473984739947400474014740247403474044740547406474074740847409474104741147412474134741447415474164741747418474194742047421474224742347424474254742647427474284742947430474314743247433474344743547436474374743847439474404744147442474434744447445474464744747448474494745047451474524745347454474554745647457474584745947460474614746247463474644746547466474674746847469474704747147472474734747447475474764747747478474794748047481474824748347484474854748647487474884748947490474914749247493474944749547496474974749847499475004750147502475034750447505475064750747508475094751047511475124751347514475154751647517475184751947520475214752247523475244752547526475274752847529475304753147532475334753447535475364753747538475394754047541475424754347544475454754647547475484754947550475514755247553475544755547556475574755847559475604756147562475634756447565475664756747568475694757047571475724757347574475754757647577475784757947580475814758247583475844758547586475874758847589475904759147592475934759447595475964759747598475994760047601476024760347604476054760647607476084760947610476114761247613476144761547616476174761847619476204762147622476234762447625476264762747628476294763047631476324763347634476354763647637476384763947640476414764247643476444764547646476474764847649476504765147652476534765447655476564765747658476594766047661476624766347664476654766647667476684766947670476714767247673476744767547676476774767847679476804768147682476834768447685476864768747688476894769047691476924769347694476954769647697476984769947700477014770247703477044770547706477074770847709477104771147712477134771447715477164771747718477194772047721477224772347724477254772647727477284772947730477314773247733477344773547736477374773847739477404774147742477434774447745477464774747748477494775047751477524775347754477554775647757477584775947760477614776247763477644776547766477674776847769477704777147772477734777447775477764777747778477794778047781477824778347784477854778647787477884778947790477914779247793477944779547796477974779847799478004780147802478034780447805478064780747808478094781047811478124781347814478154781647817478184781947820478214782247823478244782547826478274782847829478304783147832478334783447835478364783747838478394784047841478424784347844478454784647847478484784947850478514785247853478544785547856478574785847859478604786147862478634786447865478664786747868478694787047871478724787347874478754787647877478784787947880478814788247883478844788547886478874788847889478904789147892478934789447895478964789747898478994790047901479024790347904479054790647907479084790947910479114791247913479144791547916479174791847919479204792147922479234792447925479264792747928479294793047931479324793347934479354793647937479384793947940479414794247943479444794547946479474794847949479504795147952479534795447955479564795747958479594796047961479624796347964479654796647967479684796947970479714797247973479744797547976479774797847979479804798147982479834798447985479864798747988479894799047991479924799347994479954799647997479984799948000480014800248003480044800548006480074800848009480104801148012480134801448015480164801748018480194802048021480224802348024480254802648027480284802948030480314803248033480344803548036480374803848039480404804148042480434804448045480464804748048480494805048051480524805348054480554805648057480584805948060480614806248063480644806548066480674806848069480704807148072480734807448075480764807748078480794808048081480824808348084480854808648087480884808948090480914809248093480944809548096480974809848099481004810148102481034810448105481064810748108481094811048111481124811348114481154811648117481184811948120481214812248123481244812548126481274812848129481304813148132481334813448135481364813748138481394814048141481424814348144481454814648147481484814948150481514815248153481544815548156481574815848159481604816148162481634816448165481664816748168481694817048171481724817348174481754817648177481784817948180481814818248183481844818548186481874818848189481904819148192481934819448195481964819748198481994820048201482024820348204482054820648207482084820948210482114821248213482144821548216482174821848219482204822148222482234822448225482264822748228482294823048231482324823348234482354823648237482384823948240482414824248243482444824548246482474824848249482504825148252482534825448255482564825748258482594826048261482624826348264482654826648267482684826948270482714827248273482744827548276482774827848279482804828148282482834828448285482864828748288482894829048291482924829348294482954829648297482984829948300483014830248303483044830548306483074830848309483104831148312483134831448315483164831748318483194832048321483224832348324483254832648327483284832948330483314833248333483344833548336483374833848339483404834148342483434834448345483464834748348483494835048351483524835348354483554835648357483584835948360483614836248363483644836548366483674836848369483704837148372483734837448375483764837748378483794838048381483824838348384483854838648387483884838948390483914839248393483944839548396483974839848399484004840148402484034840448405484064840748408484094841048411484124841348414484154841648417484184841948420484214842248423484244842548426484274842848429484304843148432484334843448435484364843748438484394844048441484424844348444484454844648447484484844948450484514845248453484544845548456484574845848459484604846148462484634846448465484664846748468484694847048471484724847348474484754847648477484784847948480484814848248483484844848548486484874848848489484904849148492484934849448495484964849748498484994850048501485024850348504485054850648507485084850948510485114851248513485144851548516485174851848519485204852148522485234852448525485264852748528485294853048531485324853348534485354853648537485384853948540485414854248543485444854548546485474854848549485504855148552485534855448555485564855748558485594856048561485624856348564485654856648567485684856948570485714857248573485744857548576485774857848579485804858148582485834858448585485864858748588485894859048591485924859348594485954859648597485984859948600486014860248603486044860548606486074860848609486104861148612486134861448615486164861748618486194862048621486224862348624486254862648627486284862948630486314863248633486344863548636486374863848639486404864148642486434864448645486464864748648486494865048651486524865348654486554865648657486584865948660486614866248663486644866548666486674866848669486704867148672486734867448675486764867748678486794868048681486824868348684486854868648687486884868948690486914869248693486944869548696486974869848699487004870148702487034870448705487064870748708487094871048711487124871348714487154871648717487184871948720487214872248723487244872548726487274872848729487304873148732487334873448735487364873748738487394874048741487424874348744487454874648747487484874948750487514875248753487544875548756487574875848759487604876148762487634876448765487664876748768487694877048771487724877348774487754877648777487784877948780487814878248783487844878548786487874878848789487904879148792487934879448795487964879748798487994880048801488024880348804488054880648807488084880948810488114881248813488144881548816488174881848819488204882148822488234882448825488264882748828488294883048831488324883348834488354883648837488384883948840488414884248843488444884548846488474884848849488504885148852488534885448855488564885748858488594886048861488624886348864488654886648867488684886948870488714887248873488744887548876488774887848879488804888148882488834888448885488864888748888488894889048891488924889348894488954889648897488984889948900489014890248903489044890548906489074890848909489104891148912489134891448915489164891748918489194892048921489224892348924489254892648927489284892948930489314893248933489344893548936489374893848939489404894148942489434894448945489464894748948489494895048951489524895348954489554895648957489584895948960489614896248963489644896548966489674896848969489704897148972489734897448975489764897748978489794898048981489824898348984489854898648987489884898948990489914899248993489944899548996489974899848999490004900149002490034900449005490064900749008490094901049011490124901349014490154901649017490184901949020490214902249023490244902549026490274902849029490304903149032490334903449035490364903749038490394904049041490424904349044490454904649047490484904949050490514905249053490544905549056490574905849059490604906149062490634906449065490664906749068490694907049071490724907349074490754907649077490784907949080490814908249083490844908549086490874908849089490904909149092490934909449095490964909749098490994910049101491024910349104491054910649107491084910949110491114911249113491144911549116491174911849119491204912149122491234912449125491264912749128491294913049131491324913349134491354913649137491384913949140491414914249143491444914549146491474914849149491504915149152491534915449155491564915749158491594916049161491624916349164491654916649167491684916949170491714917249173491744917549176491774917849179491804918149182491834918449185491864918749188491894919049191491924919349194491954919649197491984919949200492014920249203492044920549206492074920849209492104921149212492134921449215492164921749218492194922049221492224922349224492254922649227492284922949230492314923249233492344923549236492374923849239492404924149242492434924449245492464924749248492494925049251492524925349254492554925649257492584925949260492614926249263492644926549266492674926849269492704927149272492734927449275492764927749278492794928049281492824928349284492854928649287492884928949290492914929249293492944929549296492974929849299493004930149302493034930449305493064930749308493094931049311493124931349314493154931649317493184931949320493214932249323493244932549326493274932849329493304933149332493334933449335493364933749338493394934049341493424934349344493454934649347493484934949350493514935249353493544935549356493574935849359493604936149362493634936449365493664936749368493694937049371493724937349374493754937649377493784937949380493814938249383493844938549386493874938849389493904939149392493934939449395493964939749398493994940049401494024940349404494054940649407494084940949410494114941249413494144941549416494174941849419494204942149422494234942449425494264942749428494294943049431494324943349434494354943649437494384943949440494414944249443494444944549446494474944849449494504945149452494534945449455494564945749458494594946049461494624946349464494654946649467494684946949470494714947249473494744947549476494774947849479494804948149482494834948449485494864948749488494894949049491494924949349494494954949649497494984949949500495014950249503495044950549506495074950849509495104951149512495134951449515495164951749518495194952049521495224952349524495254952649527495284952949530495314953249533495344953549536495374953849539495404954149542495434954449545495464954749548495494955049551495524955349554495554955649557495584955949560495614956249563495644956549566495674956849569495704957149572495734957449575495764957749578495794958049581495824958349584495854958649587495884958949590495914959249593495944959549596495974959849599496004960149602496034960449605496064960749608496094961049611496124961349614496154961649617496184961949620496214962249623496244962549626496274962849629496304963149632496334963449635496364963749638496394964049641496424964349644496454964649647496484964949650496514965249653496544965549656496574965849659496604966149662496634966449665496664966749668496694967049671496724967349674496754967649677496784967949680496814968249683496844968549686496874968849689496904969149692496934969449695496964969749698496994970049701497024970349704497054970649707497084970949710497114971249713497144971549716497174971849719497204972149722497234972449725497264972749728497294973049731497324973349734497354973649737497384973949740497414974249743497444974549746497474974849749497504975149752497534975449755497564975749758497594976049761497624976349764497654976649767497684976949770497714977249773497744977549776497774977849779497804978149782497834978449785497864978749788497894979049791497924979349794497954979649797497984979949800498014980249803498044980549806498074980849809498104981149812498134981449815498164981749818498194982049821498224982349824498254982649827498284982949830498314983249833498344983549836498374983849839498404984149842498434984449845498464984749848498494985049851498524985349854498554985649857498584985949860498614986249863498644986549866498674986849869498704987149872498734987449875498764987749878498794988049881498824988349884498854988649887498884988949890498914989249893498944989549896498974989849899499004990149902499034990449905499064990749908499094991049911499124991349914499154991649917499184991949920499214992249923499244992549926499274992849929499304993149932499334993449935499364993749938499394994049941499424994349944499454994649947499484994949950499514995249953499544995549956499574995849959499604996149962499634996449965499664996749968499694997049971499724997349974499754997649977499784997949980499814998249983499844998549986499874998849989499904999149992499934999449995499964999749998499995000050001500025000350004500055000650007500085000950010500115001250013500145001550016500175001850019500205002150022500235002450025500265002750028500295003050031500325003350034500355003650037500385003950040500415004250043500445004550046500475004850049500505005150052500535005450055500565005750058500595006050061500625006350064500655006650067500685006950070500715007250073500745007550076500775007850079500805008150082500835008450085500865008750088500895009050091500925009350094500955009650097500985009950100501015010250103501045010550106501075010850109501105011150112501135011450115501165011750118501195012050121501225012350124501255012650127501285012950130501315013250133501345013550136501375013850139501405014150142501435014450145501465014750148501495015050151501525015350154501555015650157501585015950160501615016250163501645016550166501675016850169501705017150172501735017450175501765017750178501795018050181501825018350184501855018650187501885018950190501915019250193501945019550196501975019850199502005020150202502035020450205502065020750208502095021050211502125021350214502155021650217502185021950220502215022250223502245022550226502275022850229502305023150232502335023450235502365023750238502395024050241502425024350244502455024650247502485024950250502515025250253502545025550256502575025850259502605026150262502635026450265502665026750268502695027050271502725027350274502755027650277502785027950280502815028250283502845028550286502875028850289502905029150292502935029450295502965029750298502995030050301503025030350304503055030650307503085030950310503115031250313503145031550316503175031850319503205032150322503235032450325503265032750328503295033050331503325033350334503355033650337503385033950340503415034250343503445034550346503475034850349503505035150352503535035450355503565035750358503595036050361503625036350364503655036650367503685036950370503715037250373503745037550376503775037850379503805038150382503835038450385503865038750388503895039050391503925039350394503955039650397503985039950400504015040250403504045040550406504075040850409504105041150412504135041450415504165041750418504195042050421504225042350424504255042650427504285042950430504315043250433504345043550436504375043850439504405044150442504435044450445504465044750448504495045050451504525045350454504555045650457504585045950460504615046250463504645046550466504675046850469504705047150472504735047450475504765047750478504795048050481504825048350484504855048650487504885048950490504915049250493504945049550496504975049850499505005050150502505035050450505505065050750508505095051050511505125051350514505155051650517505185051950520505215052250523505245052550526505275052850529505305053150532505335053450535505365053750538505395054050541505425054350544505455054650547505485054950550505515055250553505545055550556505575055850559505605056150562505635056450565505665056750568505695057050571505725057350574505755057650577505785057950580505815058250583505845058550586505875058850589505905059150592505935059450595505965059750598505995060050601506025060350604506055060650607506085060950610506115061250613506145061550616506175061850619506205062150622506235062450625506265062750628506295063050631506325063350634506355063650637506385063950640506415064250643506445064550646506475064850649506505065150652506535065450655506565065750658506595066050661506625066350664506655066650667506685066950670506715067250673506745067550676506775067850679506805068150682506835068450685506865068750688506895069050691506925069350694506955069650697506985069950700507015070250703507045070550706507075070850709507105071150712507135071450715507165071750718507195072050721507225072350724507255072650727507285072950730507315073250733507345073550736507375073850739507405074150742507435074450745507465074750748507495075050751507525075350754507555075650757507585075950760507615076250763507645076550766507675076850769507705077150772507735077450775507765077750778507795078050781507825078350784507855078650787507885078950790507915079250793507945079550796507975079850799508005080150802508035080450805508065080750808508095081050811508125081350814508155081650817508185081950820508215082250823508245082550826508275082850829508305083150832508335083450835508365083750838508395084050841508425084350844508455084650847508485084950850508515085250853508545085550856508575085850859508605086150862508635086450865508665086750868508695087050871508725087350874508755087650877508785087950880508815088250883508845088550886508875088850889508905089150892508935089450895508965089750898508995090050901509025090350904509055090650907509085090950910509115091250913509145091550916509175091850919509205092150922509235092450925509265092750928509295093050931509325093350934509355093650937509385093950940509415094250943509445094550946509475094850949509505095150952509535095450955509565095750958509595096050961509625096350964509655096650967509685096950970509715097250973509745097550976509775097850979509805098150982509835098450985509865098750988509895099050991509925099350994509955099650997509985099951000510015100251003510045100551006510075100851009510105101151012510135101451015510165101751018510195102051021510225102351024510255102651027510285102951030510315103251033510345103551036510375103851039510405104151042510435104451045510465104751048510495105051051510525105351054510555105651057510585105951060510615106251063510645106551066510675106851069510705107151072510735107451075510765107751078510795108051081510825108351084510855108651087510885108951090510915109251093510945109551096510975109851099511005110151102511035110451105511065110751108511095111051111511125111351114511155111651117511185111951120511215112251123511245112551126511275112851129511305113151132511335113451135511365113751138511395114051141511425114351144511455114651147511485114951150511515115251153511545115551156511575115851159511605116151162511635116451165511665116751168511695117051171511725117351174511755117651177511785117951180511815118251183511845118551186511875118851189511905119151192511935119451195511965119751198511995120051201512025120351204512055120651207512085120951210512115121251213512145121551216512175121851219512205122151222512235122451225512265122751228512295123051231512325123351234512355123651237512385123951240512415124251243512445124551246512475124851249512505125151252512535125451255512565125751258512595126051261512625126351264512655126651267512685126951270512715127251273512745127551276512775127851279512805128151282512835128451285512865128751288512895129051291512925129351294512955129651297512985129951300513015130251303513045130551306513075130851309513105131151312513135131451315513165131751318513195132051321513225132351324513255132651327513285132951330513315133251333513345133551336513375133851339513405134151342513435134451345513465134751348513495135051351513525135351354513555135651357513585135951360513615136251363513645136551366513675136851369513705137151372513735137451375513765137751378513795138051381513825138351384513855138651387513885138951390513915139251393513945139551396513975139851399514005140151402514035140451405514065140751408514095141051411514125141351414514155141651417514185141951420514215142251423514245142551426514275142851429514305143151432514335143451435514365143751438514395144051441514425144351444514455144651447514485144951450514515145251453514545145551456514575145851459514605146151462514635146451465514665146751468514695147051471514725147351474514755147651477514785147951480514815148251483514845148551486514875148851489514905149151492514935149451495514965149751498514995150051501515025150351504515055150651507515085150951510515115151251513515145151551516515175151851519515205152151522515235152451525515265152751528515295153051531515325153351534515355153651537515385153951540515415154251543515445154551546515475154851549515505155151552515535155451555515565155751558515595156051561515625156351564515655156651567515685156951570515715157251573515745157551576515775157851579515805158151582515835158451585515865158751588515895159051591515925159351594515955159651597515985159951600516015160251603516045160551606516075160851609516105161151612516135161451615516165161751618516195162051621516225162351624516255162651627516285162951630516315163251633516345163551636516375163851639516405164151642516435164451645516465164751648516495165051651516525165351654516555165651657516585165951660516615166251663516645166551666516675166851669516705167151672516735167451675516765167751678516795168051681516825168351684516855168651687516885168951690516915169251693516945169551696516975169851699517005170151702517035170451705517065170751708517095171051711517125171351714517155171651717517185171951720517215172251723517245172551726517275172851729517305173151732517335173451735517365173751738517395174051741517425174351744517455174651747517485174951750517515175251753517545175551756517575175851759517605176151762517635176451765517665176751768517695177051771517725177351774517755177651777517785177951780517815178251783517845178551786517875178851789517905179151792517935179451795517965179751798517995180051801518025180351804518055180651807518085180951810518115181251813518145181551816518175181851819518205182151822518235182451825518265182751828518295183051831518325183351834518355183651837518385183951840518415184251843518445184551846518475184851849518505185151852518535185451855518565185751858518595186051861518625186351864518655186651867518685186951870518715187251873518745187551876518775187851879518805188151882518835188451885518865188751888518895189051891518925189351894518955189651897518985189951900519015190251903519045190551906519075190851909519105191151912519135191451915519165191751918519195192051921519225192351924519255192651927519285192951930519315193251933519345193551936519375193851939519405194151942519435194451945519465194751948519495195051951519525195351954519555195651957519585195951960519615196251963519645196551966519675196851969519705197151972519735197451975519765197751978519795198051981519825198351984519855198651987519885198951990519915199251993519945199551996519975199851999520005200152002520035200452005520065200752008520095201052011520125201352014520155201652017520185201952020520215202252023520245202552026520275202852029520305203152032520335203452035520365203752038520395204052041520425204352044520455204652047520485204952050520515205252053520545205552056520575205852059520605206152062520635206452065520665206752068520695207052071520725207352074520755207652077520785207952080520815208252083520845208552086520875208852089520905209152092520935209452095520965209752098520995210052101521025210352104521055210652107521085210952110521115211252113521145211552116521175211852119521205212152122521235212452125521265212752128521295213052131521325213352134521355213652137521385213952140521415214252143521445214552146521475214852149521505215152152521535215452155521565215752158521595216052161521625216352164521655216652167521685216952170521715217252173521745217552176521775217852179521805218152182521835218452185521865218752188521895219052191521925219352194521955219652197521985219952200522015220252203522045220552206522075220852209522105221152212522135221452215522165221752218522195222052221522225222352224522255222652227522285222952230522315223252233522345223552236522375223852239522405224152242522435224452245522465224752248522495225052251522525225352254522555225652257522585225952260522615226252263522645226552266522675226852269522705227152272522735227452275522765227752278522795228052281522825228352284522855228652287522885228952290522915229252293522945229552296522975229852299523005230152302523035230452305523065230752308523095231052311523125231352314523155231652317523185231952320523215232252323523245232552326523275232852329523305233152332523335233452335523365233752338523395234052341523425234352344523455234652347523485234952350523515235252353523545235552356523575235852359523605236152362523635236452365523665236752368523695237052371523725237352374523755237652377523785237952380523815238252383523845238552386523875238852389523905239152392523935239452395523965239752398523995240052401524025240352404524055240652407524085240952410524115241252413524145241552416524175241852419524205242152422524235242452425524265242752428524295243052431524325243352434524355243652437524385243952440524415244252443524445244552446524475244852449524505245152452524535245452455524565245752458524595246052461524625246352464524655246652467524685246952470524715247252473524745247552476524775247852479524805248152482524835248452485524865248752488524895249052491524925249352494524955249652497524985249952500525015250252503525045250552506525075250852509525105251152512525135251452515525165251752518525195252052521525225252352524525255252652527525285252952530525315253252533525345253552536525375253852539525405254152542525435254452545525465254752548525495255052551525525255352554525555255652557525585255952560525615256252563525645256552566525675256852569525705257152572525735257452575525765257752578525795258052581525825258352584525855258652587525885258952590525915259252593525945259552596525975259852599526005260152602526035260452605526065260752608526095261052611526125261352614526155261652617526185261952620526215262252623526245262552626526275262852629526305263152632526335263452635526365263752638526395264052641526425264352644526455264652647526485264952650526515265252653526545265552656526575265852659526605266152662526635266452665526665266752668526695267052671526725267352674526755267652677526785267952680526815268252683526845268552686526875268852689526905269152692526935269452695526965269752698526995270052701527025270352704527055270652707527085270952710527115271252713527145271552716527175271852719527205272152722527235272452725527265272752728527295273052731527325273352734527355273652737527385273952740527415274252743527445274552746527475274852749527505275152752527535275452755527565275752758527595276052761527625276352764527655276652767527685276952770527715277252773527745277552776527775277852779527805278152782527835278452785527865278752788527895279052791527925279352794527955279652797527985279952800528015280252803528045280552806528075280852809528105281152812528135281452815528165281752818528195282052821528225282352824528255282652827528285282952830528315283252833528345283552836528375283852839528405284152842528435284452845528465284752848528495285052851528525285352854528555285652857528585285952860528615286252863528645286552866528675286852869528705287152872528735287452875528765287752878528795288052881528825288352884528855288652887528885288952890528915289252893528945289552896528975289852899529005290152902529035290452905529065290752908529095291052911529125291352914529155291652917529185291952920529215292252923529245292552926529275292852929529305293152932529335293452935529365293752938529395294052941529425294352944529455294652947529485294952950529515295252953529545295552956529575295852959529605296152962529635296452965529665296752968529695297052971529725297352974529755297652977529785297952980529815298252983529845298552986529875298852989529905299152992529935299452995529965299752998529995300053001530025300353004530055300653007530085300953010530115301253013530145301553016530175301853019530205302153022530235302453025530265302753028530295303053031530325303353034530355303653037530385303953040530415304253043530445304553046530475304853049530505305153052530535305453055530565305753058530595306053061530625306353064530655306653067530685306953070530715307253073530745307553076530775307853079530805308153082530835308453085530865308753088530895309053091530925309353094530955309653097530985309953100531015310253103531045310553106531075310853109531105311153112531135311453115531165311753118531195312053121531225312353124531255312653127531285312953130531315313253133531345313553136531375313853139531405314153142531435314453145531465314753148531495315053151531525315353154531555315653157531585315953160531615316253163531645316553166531675316853169531705317153172531735317453175531765317753178531795318053181531825318353184531855318653187531885318953190531915319253193531945319553196531975319853199532005320153202532035320453205532065320753208532095321053211532125321353214532155321653217532185321953220532215322253223532245322553226532275322853229532305323153232532335323453235532365323753238532395324053241532425324353244532455324653247532485324953250532515325253253532545325553256532575325853259532605326153262532635326453265532665326753268532695327053271532725327353274532755327653277532785327953280532815328253283532845328553286532875328853289532905329153292532935329453295532965329753298532995330053301533025330353304533055330653307533085330953310533115331253313533145331553316533175331853319533205332153322533235332453325533265332753328533295333053331533325333353334533355333653337533385333953340533415334253343533445334553346533475334853349533505335153352533535335453355533565335753358533595336053361533625336353364533655336653367533685336953370533715337253373533745337553376533775337853379533805338153382533835338453385533865338753388533895339053391533925339353394533955339653397533985339953400534015340253403534045340553406534075340853409534105341153412534135341453415534165341753418534195342053421534225342353424534255342653427534285342953430534315343253433534345343553436534375343853439534405344153442534435344453445534465344753448534495345053451534525345353454534555345653457534585345953460534615346253463534645346553466534675346853469534705347153472534735347453475534765347753478534795348053481534825348353484534855348653487534885348953490534915349253493534945349553496534975349853499535005350153502535035350453505535065350753508535095351053511535125351353514535155351653517535185351953520535215352253523535245352553526535275352853529535305353153532535335353453535535365353753538535395354053541535425354353544535455354653547535485354953550535515355253553535545355553556535575355853559535605356153562535635356453565535665356753568535695357053571535725357353574535755357653577535785357953580535815358253583535845358553586535875358853589535905359153592535935359453595535965359753598535995360053601536025360353604536055360653607536085360953610536115361253613536145361553616536175361853619536205362153622536235362453625536265362753628536295363053631536325363353634536355363653637536385363953640536415364253643536445364553646536475364853649536505365153652536535365453655536565365753658536595366053661536625366353664536655366653667536685366953670536715367253673536745367553676536775367853679536805368153682536835368453685536865368753688536895369053691536925369353694536955369653697536985369953700537015370253703537045370553706537075370853709537105371153712537135371453715537165371753718537195372053721537225372353724537255372653727537285372953730537315373253733537345373553736537375373853739537405374153742537435374453745537465374753748537495375053751537525375353754537555375653757537585375953760537615376253763537645376553766537675376853769537705377153772537735377453775537765377753778537795378053781537825378353784537855378653787537885378953790537915379253793537945379553796537975379853799538005380153802538035380453805538065380753808538095381053811538125381353814538155381653817538185381953820538215382253823538245382553826538275382853829538305383153832538335383453835538365383753838538395384053841538425384353844538455384653847538485384953850538515385253853538545385553856538575385853859538605386153862538635386453865538665386753868538695387053871538725387353874538755387653877538785387953880538815388253883538845388553886538875388853889538905389153892538935389453895538965389753898538995390053901539025390353904539055390653907539085390953910539115391253913539145391553916539175391853919539205392153922539235392453925539265392753928539295393053931539325393353934539355393653937539385393953940539415394253943539445394553946539475394853949539505395153952539535395453955539565395753958539595396053961539625396353964539655396653967539685396953970539715397253973539745397553976539775397853979539805398153982539835398453985539865398753988539895399053991539925399353994539955399653997539985399954000540015400254003540045400554006540075400854009540105401154012540135401454015540165401754018540195402054021540225402354024540255402654027540285402954030540315403254033540345403554036540375403854039540405404154042540435404454045540465404754048540495405054051540525405354054540555405654057540585405954060540615406254063540645406554066540675406854069540705407154072540735407454075540765407754078540795408054081540825408354084540855408654087540885408954090540915409254093540945409554096540975409854099541005410154102541035410454105541065410754108541095411054111541125411354114541155411654117541185411954120541215412254123541245412554126541275412854129541305413154132541335413454135541365413754138541395414054141541425414354144541455414654147541485414954150541515415254153541545415554156541575415854159541605416154162541635416454165541665416754168541695417054171541725417354174541755417654177541785417954180541815418254183541845418554186541875418854189541905419154192541935419454195541965419754198541995420054201542025420354204542055420654207542085420954210542115421254213542145421554216542175421854219542205422154222542235422454225542265422754228542295423054231542325423354234542355423654237542385423954240542415424254243542445424554246542475424854249542505425154252542535425454255542565425754258542595426054261542625426354264542655426654267542685426954270542715427254273542745427554276542775427854279542805428154282542835428454285542865428754288542895429054291542925429354294542955429654297542985429954300543015430254303543045430554306543075430854309543105431154312543135431454315543165431754318543195432054321543225432354324543255432654327543285432954330543315433254333543345433554336543375433854339543405434154342543435434454345543465434754348543495435054351543525435354354543555435654357543585435954360543615436254363543645436554366543675436854369543705437154372543735437454375543765437754378543795438054381543825438354384543855438654387543885438954390543915439254393543945439554396543975439854399544005440154402544035440454405544065440754408544095441054411544125441354414544155441654417544185441954420544215442254423544245442554426544275442854429544305443154432544335443454435544365443754438544395444054441544425444354444544455444654447544485444954450544515445254453544545445554456544575445854459544605446154462544635446454465544665446754468544695447054471544725447354474544755447654477544785447954480544815448254483544845448554486544875448854489544905449154492544935449454495544965449754498544995450054501545025450354504545055450654507545085450954510545115451254513545145451554516545175451854519545205452154522545235452454525545265452754528545295453054531545325453354534545355453654537545385453954540545415454254543545445454554546545475454854549545505455154552545535455454555545565455754558545595456054561545625456354564545655456654567545685456954570545715457254573545745457554576545775457854579545805458154582545835458454585545865458754588545895459054591545925459354594545955459654597545985459954600546015460254603546045460554606546075460854609546105461154612546135461454615546165461754618546195462054621546225462354624546255462654627546285462954630546315463254633546345463554636546375463854639546405464154642546435464454645546465464754648546495465054651546525465354654546555465654657546585465954660546615466254663546645466554666546675466854669546705467154672546735467454675546765467754678546795468054681546825468354684546855468654687546885468954690546915469254693546945469554696546975469854699547005470154702547035470454705547065470754708547095471054711547125471354714547155471654717547185471954720547215472254723547245472554726547275472854729547305473154732547335473454735547365473754738547395474054741547425474354744547455474654747547485474954750547515475254753547545475554756547575475854759547605476154762547635476454765547665476754768547695477054771547725477354774547755477654777547785477954780547815478254783547845478554786547875478854789547905479154792547935479454795547965479754798547995480054801548025480354804548055480654807548085480954810548115481254813548145481554816548175481854819548205482154822548235482454825548265482754828548295483054831548325483354834548355483654837548385483954840548415484254843548445484554846548475484854849548505485154852548535485454855548565485754858548595486054861548625486354864548655486654867548685486954870548715487254873548745487554876548775487854879548805488154882548835488454885548865488754888548895489054891548925489354894548955489654897548985489954900549015490254903549045490554906549075490854909549105491154912549135491454915549165491754918549195492054921549225492354924549255492654927549285492954930549315493254933549345493554936549375493854939549405494154942549435494454945549465494754948549495495054951549525495354954549555495654957549585495954960549615496254963549645496554966549675496854969549705497154972549735497454975549765497754978549795498054981549825498354984549855498654987549885498954990549915499254993549945499554996549975499854999550005500155002550035500455005550065500755008550095501055011550125501355014550155501655017550185501955020550215502255023550245502555026550275502855029550305503155032550335503455035550365503755038550395504055041550425504355044550455504655047550485504955050550515505255053550545505555056550575505855059550605506155062550635506455065550665506755068550695507055071550725507355074550755507655077550785507955080550815508255083550845508555086550875508855089550905509155092550935509455095550965509755098550995510055101551025510355104551055510655107551085510955110551115511255113551145511555116551175511855119551205512155122551235512455125551265512755128551295513055131551325513355134551355513655137551385513955140551415514255143551445514555146551475514855149551505515155152551535515455155551565515755158551595516055161551625516355164551655516655167551685516955170551715517255173551745517555176551775517855179551805518155182551835518455185551865518755188551895519055191551925519355194551955519655197551985519955200552015520255203552045520555206552075520855209552105521155212552135521455215552165521755218552195522055221552225522355224552255522655227552285522955230552315523255233552345523555236552375523855239552405524155242552435524455245552465524755248552495525055251552525525355254552555525655257552585525955260552615526255263552645526555266552675526855269552705527155272552735527455275552765527755278552795528055281552825528355284552855528655287552885528955290552915529255293552945529555296552975529855299553005530155302553035530455305553065530755308553095531055311553125531355314553155531655317553185531955320553215532255323553245532555326553275532855329553305533155332553335533455335553365533755338553395534055341553425534355344553455534655347553485534955350553515535255353553545535555356553575535855359553605536155362553635536455365553665536755368553695537055371553725537355374553755537655377553785537955380553815538255383553845538555386553875538855389553905539155392553935539455395553965539755398553995540055401554025540355404554055540655407554085540955410554115541255413554145541555416554175541855419554205542155422554235542455425554265542755428554295543055431554325543355434554355543655437554385543955440554415544255443554445544555446554475544855449554505545155452554535545455455554565545755458554595546055461554625546355464554655546655467554685546955470554715547255473554745547555476554775547855479554805548155482554835548455485554865548755488554895549055491554925549355494554955549655497554985549955500555015550255503555045550555506555075550855509555105551155512555135551455515555165551755518555195552055521555225552355524555255552655527555285552955530555315553255533555345553555536555375553855539555405554155542555435554455545555465554755548555495555055551555525555355554555555555655557555585555955560555615556255563555645556555566555675556855569555705557155572555735557455575555765557755578555795558055581555825558355584555855558655587555885558955590555915559255593555945559555596555975559855599556005560155602556035560455605556065560755608556095561055611556125561355614556155561655617556185561955620556215562255623556245562555626556275562855629556305563155632556335563455635556365563755638556395564055641556425564355644556455564655647556485564955650556515565255653556545565555656556575565855659556605566155662556635566455665556665566755668556695567055671556725567355674556755567655677556785567955680556815568255683556845568555686556875568855689556905569155692556935569455695556965569755698556995570055701557025570355704557055570655707557085570955710557115571255713557145571555716557175571855719557205572155722557235572455725557265572755728557295573055731557325573355734557355573655737557385573955740557415574255743557445574555746557475574855749557505575155752557535575455755557565575755758557595576055761557625576355764557655576655767557685576955770557715577255773557745577555776557775577855779557805578155782557835578455785557865578755788557895579055791557925579355794557955579655797557985579955800558015580255803558045580555806558075580855809558105581155812558135581455815558165581755818558195582055821558225582355824558255582655827558285582955830558315583255833558345583555836558375583855839558405584155842558435584455845558465584755848558495585055851558525585355854558555585655857558585585955860558615586255863558645586555866558675586855869558705587155872558735587455875558765587755878558795588055881558825588355884558855588655887558885588955890558915589255893558945589555896558975589855899559005590155902559035590455905559065590755908559095591055911559125591355914559155591655917559185591955920559215592255923559245592555926559275592855929559305593155932559335593455935559365593755938559395594055941559425594355944559455594655947559485594955950559515595255953559545595555956559575595855959559605596155962559635596455965559665596755968559695597055971559725597355974559755597655977559785597955980559815598255983559845598555986559875598855989559905599155992559935599455995559965599755998559995600056001560025600356004560055600656007560085600956010560115601256013560145601556016560175601856019560205602156022560235602456025560265602756028560295603056031560325603356034560355603656037560385603956040560415604256043560445604556046560475604856049560505605156052560535605456055560565605756058560595606056061560625606356064560655606656067560685606956070560715607256073560745607556076560775607856079560805608156082560835608456085560865608756088560895609056091560925609356094560955609656097560985609956100561015610256103561045610556106561075610856109561105611156112561135611456115561165611756118561195612056121561225612356124561255612656127561285612956130561315613256133561345613556136561375613856139561405614156142561435614456145561465614756148561495615056151561525615356154561555615656157561585615956160561615616256163561645616556166561675616856169561705617156172561735617456175561765617756178561795618056181561825618356184561855618656187561885618956190561915619256193561945619556196561975619856199562005620156202562035620456205562065620756208562095621056211562125621356214562155621656217562185621956220562215622256223562245622556226562275622856229562305623156232562335623456235562365623756238562395624056241562425624356244562455624656247562485624956250562515625256253562545625556256562575625856259562605626156262562635626456265562665626756268562695627056271562725627356274562755627656277562785627956280562815628256283562845628556286562875628856289562905629156292562935629456295562965629756298562995630056301563025630356304563055630656307563085630956310563115631256313563145631556316563175631856319563205632156322563235632456325563265632756328563295633056331563325633356334563355633656337563385633956340563415634256343563445634556346563475634856349563505635156352563535635456355563565635756358563595636056361563625636356364563655636656367563685636956370563715637256373563745637556376563775637856379563805638156382563835638456385563865638756388563895639056391563925639356394563955639656397563985639956400564015640256403564045640556406564075640856409564105641156412564135641456415564165641756418564195642056421564225642356424564255642656427564285642956430564315643256433564345643556436564375643856439564405644156442564435644456445564465644756448564495645056451564525645356454564555645656457564585645956460564615646256463564645646556466564675646856469564705647156472564735647456475564765647756478564795648056481564825648356484564855648656487564885648956490564915649256493564945649556496564975649856499565005650156502565035650456505565065650756508565095651056511565125651356514565155651656517565185651956520565215652256523565245652556526565275652856529565305653156532565335653456535565365653756538565395654056541565425654356544565455654656547565485654956550565515655256553565545655556556565575655856559565605656156562565635656456565565665656756568565695657056571565725657356574565755657656577565785657956580565815658256583565845658556586565875658856589565905659156592565935659456595565965659756598565995660056601566025660356604566055660656607566085660956610566115661256613566145661556616566175661856619566205662156622566235662456625566265662756628566295663056631566325663356634566355663656637566385663956640566415664256643566445664556646566475664856649566505665156652566535665456655566565665756658566595666056661566625666356664566655666656667566685666956670566715667256673566745667556676566775667856679566805668156682566835668456685566865668756688566895669056691566925669356694566955669656697566985669956700567015670256703567045670556706567075670856709567105671156712567135671456715567165671756718567195672056721567225672356724567255672656727567285672956730567315673256733567345673556736567375673856739567405674156742567435674456745567465674756748567495675056751567525675356754567555675656757567585675956760567615676256763567645676556766567675676856769567705677156772567735677456775567765677756778567795678056781567825678356784567855678656787567885678956790567915679256793567945679556796567975679856799568005680156802568035680456805568065680756808568095681056811568125681356814568155681656817568185681956820568215682256823568245682556826568275682856829568305683156832568335683456835568365683756838568395684056841568425684356844568455684656847568485684956850568515685256853568545685556856568575685856859568605686156862568635686456865568665686756868568695687056871568725687356874568755687656877568785687956880568815688256883568845688556886568875688856889568905689156892568935689456895568965689756898568995690056901569025690356904569055690656907569085690956910569115691256913569145691556916569175691856919569205692156922569235692456925569265692756928569295693056931569325693356934569355693656937569385693956940569415694256943569445694556946569475694856949569505695156952569535695456955569565695756958569595696056961569625696356964569655696656967569685696956970569715697256973569745697556976569775697856979569805698156982569835698456985569865698756988569895699056991569925699356994569955699656997569985699957000570015700257003570045700557006570075700857009570105701157012570135701457015570165701757018570195702057021570225702357024570255702657027570285702957030570315703257033570345703557036570375703857039570405704157042570435704457045570465704757048570495705057051570525705357054570555705657057570585705957060570615706257063570645706557066570675706857069570705707157072570735707457075570765707757078570795708057081570825708357084570855708657087570885708957090570915709257093570945709557096570975709857099571005710157102571035710457105571065710757108571095711057111571125711357114571155711657117571185711957120571215712257123571245712557126571275712857129571305713157132571335713457135571365713757138571395714057141571425714357144571455714657147571485714957150571515715257153571545715557156571575715857159571605716157162571635716457165571665716757168571695717057171571725717357174571755717657177571785717957180571815718257183571845718557186571875718857189571905719157192571935719457195571965719757198571995720057201572025720357204572055720657207572085720957210572115721257213572145721557216572175721857219572205722157222572235722457225572265722757228572295723057231572325723357234572355723657237572385723957240572415724257243572445724557246572475724857249572505725157252572535725457255572565725757258572595726057261572625726357264572655726657267572685726957270572715727257273572745727557276572775727857279572805728157282572835728457285572865728757288572895729057291572925729357294572955729657297572985729957300573015730257303573045730557306573075730857309573105731157312573135731457315573165731757318573195732057321573225732357324573255732657327573285732957330573315733257333573345733557336573375733857339573405734157342573435734457345573465734757348573495735057351573525735357354573555735657357573585735957360573615736257363573645736557366573675736857369573705737157372573735737457375573765737757378573795738057381573825738357384573855738657387573885738957390573915739257393573945739557396573975739857399574005740157402574035740457405574065740757408574095741057411574125741357414574155741657417574185741957420574215742257423574245742557426574275742857429574305743157432574335743457435574365743757438574395744057441574425744357444574455744657447574485744957450574515745257453574545745557456574575745857459574605746157462574635746457465574665746757468574695747057471574725747357474574755747657477574785747957480574815748257483574845748557486574875748857489574905749157492574935749457495574965749757498574995750057501575025750357504575055750657507575085750957510575115751257513575145751557516575175751857519575205752157522575235752457525575265752757528575295753057531575325753357534575355753657537575385753957540575415754257543575445754557546575475754857549575505755157552575535755457555575565755757558575595756057561575625756357564575655756657567575685756957570575715757257573575745757557576575775757857579575805758157582575835758457585575865758757588575895759057591575925759357594575955759657597575985759957600576015760257603576045760557606576075760857609576105761157612576135761457615576165761757618576195762057621576225762357624576255762657627576285762957630576315763257633576345763557636576375763857639576405764157642576435764457645576465764757648576495765057651576525765357654576555765657657576585765957660576615766257663576645766557666576675766857669576705767157672576735767457675576765767757678576795768057681576825768357684576855768657687576885768957690576915769257693576945769557696576975769857699577005770157702577035770457705577065770757708577095771057711577125771357714577155771657717577185771957720577215772257723577245772557726577275772857729577305773157732577335773457735577365773757738577395774057741577425774357744577455774657747577485774957750577515775257753577545775557756577575775857759577605776157762577635776457765577665776757768577695777057771577725777357774577755777657777577785777957780577815778257783577845778557786577875778857789577905779157792577935779457795577965779757798577995780057801578025780357804578055780657807578085780957810578115781257813578145781557816578175781857819578205782157822578235782457825578265782757828578295783057831578325783357834578355783657837578385783957840578415784257843578445784557846578475784857849578505785157852578535785457855578565785757858578595786057861578625786357864578655786657867578685786957870578715787257873578745787557876578775787857879578805788157882578835788457885578865788757888578895789057891578925789357894578955789657897578985789957900579015790257903579045790557906579075790857909579105791157912579135791457915579165791757918579195792057921579225792357924579255792657927579285792957930579315793257933579345793557936579375793857939579405794157942579435794457945579465794757948579495795057951579525795357954579555795657957579585795957960579615796257963579645796557966579675796857969579705797157972579735797457975579765797757978579795798057981579825798357984579855798657987579885798957990579915799257993579945799557996579975799857999580005800158002580035800458005580065800758008580095801058011580125801358014580155801658017580185801958020580215802258023580245802558026580275802858029580305803158032580335803458035580365803758038580395804058041580425804358044580455804658047580485804958050580515805258053580545805558056580575805858059580605806158062580635806458065580665806758068580695807058071580725807358074580755807658077580785807958080580815808258083580845808558086580875808858089580905809158092580935809458095580965809758098580995810058101581025810358104581055810658107581085810958110581115811258113581145811558116581175811858119581205812158122581235812458125581265812758128581295813058131581325813358134581355813658137581385813958140581415814258143581445814558146581475814858149581505815158152581535815458155581565815758158581595816058161581625816358164581655816658167581685816958170581715817258173581745817558176581775817858179581805818158182581835818458185581865818758188581895819058191581925819358194581955819658197581985819958200582015820258203582045820558206582075820858209582105821158212582135821458215582165821758218582195822058221582225822358224582255822658227582285822958230582315823258233582345823558236582375823858239582405824158242582435824458245582465824758248582495825058251582525825358254582555825658257582585825958260582615826258263582645826558266582675826858269582705827158272582735827458275582765827758278582795828058281582825828358284582855828658287582885828958290582915829258293582945829558296582975829858299583005830158302583035830458305583065830758308583095831058311583125831358314583155831658317583185831958320583215832258323583245832558326583275832858329583305833158332583335833458335583365833758338583395834058341583425834358344583455834658347583485834958350583515835258353583545835558356583575835858359583605836158362583635836458365583665836758368583695837058371583725837358374583755837658377583785837958380583815838258383583845838558386583875838858389583905839158392583935839458395583965839758398583995840058401584025840358404584055840658407584085840958410584115841258413584145841558416584175841858419584205842158422584235842458425584265842758428584295843058431584325843358434584355843658437584385843958440584415844258443584445844558446584475844858449584505845158452584535845458455584565845758458584595846058461584625846358464584655846658467584685846958470584715847258473584745847558476584775847858479584805848158482584835848458485584865848758488584895849058491584925849358494584955849658497584985849958500585015850258503585045850558506585075850858509585105851158512585135851458515585165851758518585195852058521585225852358524585255852658527585285852958530585315853258533585345853558536585375853858539585405854158542585435854458545585465854758548585495855058551585525855358554585555855658557585585855958560585615856258563585645856558566585675856858569585705857158572585735857458575585765857758578585795858058581585825858358584585855858658587585885858958590585915859258593585945859558596585975859858599586005860158602586035860458605586065860758608586095861058611586125861358614586155861658617586185861958620586215862258623586245862558626586275862858629586305863158632586335863458635586365863758638586395864058641586425864358644586455864658647586485864958650586515865258653586545865558656586575865858659586605866158662586635866458665586665866758668586695867058671586725867358674586755867658677586785867958680586815868258683586845868558686586875868858689586905869158692586935869458695586965869758698586995870058701587025870358704587055870658707587085870958710587115871258713587145871558716587175871858719587205872158722587235872458725587265872758728587295873058731587325873358734587355873658737587385873958740587415874258743587445874558746587475874858749587505875158752587535875458755587565875758758587595876058761587625876358764587655876658767587685876958770587715877258773587745877558776587775877858779587805878158782587835878458785587865878758788587895879058791587925879358794587955879658797587985879958800588015880258803588045880558806588075880858809588105881158812588135881458815588165881758818588195882058821588225882358824588255882658827588285882958830588315883258833588345883558836588375883858839588405884158842588435884458845588465884758848588495885058851588525885358854588555885658857588585885958860588615886258863588645886558866588675886858869588705887158872588735887458875588765887758878588795888058881588825888358884588855888658887588885888958890588915889258893588945889558896588975889858899589005890158902589035890458905589065890758908589095891058911589125891358914589155891658917589185891958920589215892258923589245892558926589275892858929589305893158932589335893458935589365893758938589395894058941589425894358944589455894658947589485894958950589515895258953589545895558956589575895858959589605896158962589635896458965589665896758968589695897058971589725897358974589755897658977589785897958980589815898258983589845898558986589875898858989589905899158992589935899458995589965899758998589995900059001590025900359004590055900659007590085900959010590115901259013590145901559016590175901859019590205902159022590235902459025590265902759028590295903059031590325903359034590355903659037590385903959040590415904259043590445904559046590475904859049590505905159052590535905459055590565905759058590595906059061590625906359064590655906659067590685906959070590715907259073590745907559076590775907859079590805908159082590835908459085590865908759088590895909059091590925909359094590955909659097590985909959100591015910259103591045910559106591075910859109591105911159112591135911459115591165911759118591195912059121591225912359124591255912659127591285912959130591315913259133591345913559136591375913859139591405914159142591435914459145591465914759148591495915059151591525915359154591555915659157591585915959160591615916259163591645916559166591675916859169591705917159172591735917459175591765917759178591795918059181591825918359184591855918659187591885918959190591915919259193591945919559196591975919859199592005920159202592035920459205592065920759208592095921059211592125921359214592155921659217592185921959220592215922259223592245922559226592275922859229592305923159232592335923459235592365923759238592395924059241592425924359244592455924659247592485924959250592515925259253592545925559256592575925859259592605926159262592635926459265592665926759268592695927059271592725927359274592755927659277592785927959280592815928259283592845928559286592875928859289592905929159292592935929459295592965929759298592995930059301593025930359304593055930659307593085930959310593115931259313593145931559316593175931859319593205932159322593235932459325593265932759328593295933059331593325933359334593355933659337593385933959340593415934259343593445934559346593475934859349593505935159352593535935459355593565935759358593595936059361593625936359364593655936659367593685936959370593715937259373593745937559376593775937859379593805938159382593835938459385593865938759388593895939059391593925939359394593955939659397593985939959400594015940259403594045940559406594075940859409594105941159412594135941459415594165941759418594195942059421594225942359424594255942659427594285942959430594315943259433594345943559436594375943859439594405944159442594435944459445594465944759448594495945059451594525945359454594555945659457594585945959460594615946259463594645946559466594675946859469594705947159472594735947459475594765947759478594795948059481594825948359484594855948659487594885948959490594915949259493594945949559496594975949859499595005950159502595035950459505595065950759508595095951059511595125951359514595155951659517595185951959520595215952259523595245952559526595275952859529595305953159532595335953459535595365953759538595395954059541595425954359544595455954659547595485954959550595515955259553595545955559556595575955859559595605956159562595635956459565595665956759568595695957059571595725957359574595755957659577595785957959580595815958259583595845958559586595875958859589595905959159592595935959459595595965959759598595995960059601596025960359604596055960659607596085960959610596115961259613596145961559616596175961859619596205962159622596235962459625596265962759628596295963059631596325963359634596355963659637596385963959640596415964259643596445964559646596475964859649596505965159652596535965459655596565965759658596595966059661596625966359664596655966659667596685966959670596715967259673596745967559676596775967859679596805968159682596835968459685596865968759688596895969059691596925969359694596955969659697596985969959700597015970259703597045970559706597075970859709597105971159712597135971459715597165971759718597195972059721597225972359724597255972659727597285972959730597315973259733597345973559736597375973859739597405974159742597435974459745597465974759748597495975059751597525975359754597555975659757597585975959760597615976259763597645976559766597675976859769597705977159772597735977459775597765977759778597795978059781597825978359784597855978659787597885978959790597915979259793597945979559796597975979859799598005980159802598035980459805598065980759808598095981059811598125981359814598155981659817598185981959820598215982259823598245982559826598275982859829598305983159832598335983459835598365983759838598395984059841598425984359844598455984659847598485984959850598515985259853598545985559856598575985859859598605986159862598635986459865598665986759868598695987059871598725987359874598755987659877598785987959880598815988259883598845988559886598875988859889598905989159892598935989459895598965989759898598995990059901599025990359904599055990659907599085990959910599115991259913599145991559916599175991859919599205992159922599235992459925599265992759928599295993059931599325993359934599355993659937599385993959940599415994259943599445994559946599475994859949599505995159952599535995459955599565995759958599595996059961599625996359964599655996659967599685996959970599715997259973599745997559976599775997859979599805998159982599835998459985599865998759988599895999059991599925999359994599955999659997599985999960000600016000260003600046000560006600076000860009600106001160012600136001460015600166001760018600196002060021600226002360024600256002660027600286002960030600316003260033600346003560036600376003860039600406004160042600436004460045600466004760048600496005060051600526005360054600556005660057600586005960060600616006260063600646006560066600676006860069600706007160072600736007460075600766007760078600796008060081600826008360084600856008660087600886008960090600916009260093600946009560096600976009860099601006010160102601036010460105601066010760108601096011060111601126011360114601156011660117601186011960120601216012260123601246012560126601276012860129601306013160132601336013460135601366013760138601396014060141601426014360144601456014660147601486014960150601516015260153601546015560156601576015860159601606016160162601636016460165601666016760168601696017060171601726017360174601756017660177601786017960180601816018260183601846018560186601876018860189601906019160192601936019460195601966019760198601996020060201602026020360204602056020660207602086020960210602116021260213602146021560216602176021860219602206022160222602236022460225602266022760228602296023060231602326023360234602356023660237602386023960240602416024260243602446024560246602476024860249602506025160252602536025460255602566025760258602596026060261602626026360264602656026660267602686026960270602716027260273602746027560276602776027860279602806028160282602836028460285602866028760288602896029060291602926029360294602956029660297602986029960300603016030260303603046030560306603076030860309603106031160312603136031460315603166031760318603196032060321603226032360324603256032660327603286032960330603316033260333603346033560336603376033860339603406034160342603436034460345603466034760348603496035060351603526035360354603556035660357603586035960360603616036260363603646036560366603676036860369603706037160372603736037460375603766037760378603796038060381603826038360384603856038660387603886038960390603916039260393603946039560396603976039860399604006040160402604036040460405604066040760408604096041060411604126041360414604156041660417604186041960420604216042260423604246042560426604276042860429604306043160432604336043460435604366043760438604396044060441604426044360444604456044660447604486044960450604516045260453604546045560456604576045860459604606046160462604636046460465604666046760468604696047060471604726047360474604756047660477604786047960480604816048260483604846048560486604876048860489604906049160492604936049460495604966049760498604996050060501605026050360504605056050660507605086050960510605116051260513605146051560516605176051860519605206052160522605236052460525605266052760528605296053060531605326053360534605356053660537605386053960540605416054260543605446054560546605476054860549605506055160552605536055460555605566055760558605596056060561605626056360564605656056660567605686056960570605716057260573605746057560576605776057860579605806058160582605836058460585605866058760588605896059060591605926059360594605956059660597605986059960600606016060260603606046060560606606076060860609606106061160612606136061460615606166061760618606196062060621606226062360624606256062660627606286062960630606316063260633606346063560636606376063860639606406064160642606436064460645606466064760648606496065060651606526065360654606556065660657606586065960660606616066260663606646066560666606676066860669606706067160672606736067460675606766067760678606796068060681606826068360684606856068660687606886068960690606916069260693606946069560696606976069860699607006070160702607036070460705607066070760708607096071060711607126071360714607156071660717607186071960720607216072260723607246072560726607276072860729607306073160732607336073460735607366073760738607396074060741607426074360744607456074660747607486074960750607516075260753607546075560756607576075860759607606076160762607636076460765607666076760768607696077060771607726077360774607756077660777607786077960780607816078260783607846078560786607876078860789607906079160792607936079460795607966079760798607996080060801608026080360804608056080660807608086080960810608116081260813608146081560816608176081860819608206082160822608236082460825608266082760828608296083060831608326083360834608356083660837608386083960840608416084260843608446084560846608476084860849608506085160852608536085460855608566085760858608596086060861608626086360864608656086660867608686086960870608716087260873608746087560876608776087860879608806088160882608836088460885608866088760888608896089060891608926089360894608956089660897608986089960900609016090260903609046090560906609076090860909609106091160912609136091460915609166091760918609196092060921609226092360924609256092660927609286092960930609316093260933609346093560936609376093860939609406094160942609436094460945609466094760948609496095060951609526095360954609556095660957609586095960960609616096260963609646096560966609676096860969609706097160972609736097460975609766097760978609796098060981609826098360984609856098660987609886098960990609916099260993609946099560996609976099860999610006100161002610036100461005610066100761008610096101061011610126101361014610156101661017610186101961020610216102261023610246102561026610276102861029610306103161032610336103461035610366103761038610396104061041610426104361044610456104661047610486104961050610516105261053610546105561056610576105861059610606106161062610636106461065610666106761068610696107061071610726107361074610756107661077610786107961080610816108261083610846108561086610876108861089610906109161092610936109461095610966109761098610996110061101611026110361104611056110661107611086110961110611116111261113611146111561116611176111861119611206112161122611236112461125611266112761128611296113061131611326113361134611356113661137611386113961140611416114261143611446114561146611476114861149611506115161152611536115461155611566115761158611596116061161611626116361164611656116661167611686116961170611716117261173611746117561176611776117861179611806118161182611836118461185611866118761188611896119061191611926119361194611956119661197611986119961200612016120261203612046120561206612076120861209612106121161212612136121461215612166121761218612196122061221612226122361224612256122661227612286122961230612316123261233612346123561236612376123861239612406124161242612436124461245612466124761248612496125061251612526125361254612556125661257612586125961260612616126261263612646126561266612676126861269612706127161272612736127461275612766127761278612796128061281612826128361284612856128661287612886128961290612916129261293612946129561296612976129861299613006130161302613036130461305613066130761308613096131061311613126131361314613156131661317613186131961320613216132261323613246132561326613276132861329613306133161332613336133461335613366133761338613396134061341613426134361344613456134661347613486134961350613516135261353613546135561356613576135861359613606136161362613636136461365613666136761368613696137061371613726137361374613756137661377613786137961380613816138261383613846138561386613876138861389613906139161392613936139461395613966139761398613996140061401614026140361404614056140661407614086140961410614116141261413614146141561416614176141861419614206142161422614236142461425614266142761428614296143061431614326143361434614356143661437614386143961440614416144261443614446144561446614476144861449614506145161452614536145461455614566145761458614596146061461614626146361464614656146661467614686146961470614716147261473614746147561476614776147861479614806148161482614836148461485614866148761488614896149061491614926149361494614956149661497614986149961500615016150261503615046150561506615076150861509615106151161512615136151461515615166151761518615196152061521615226152361524615256152661527615286152961530615316153261533615346153561536615376153861539615406154161542615436154461545615466154761548615496155061551615526155361554615556155661557615586155961560615616156261563615646156561566615676156861569615706157161572615736157461575615766157761578615796158061581615826158361584615856158661587615886158961590615916159261593615946159561596615976159861599616006160161602616036160461605616066160761608616096161061611616126161361614616156161661617616186161961620616216162261623616246162561626616276162861629616306163161632616336163461635616366163761638616396164061641616426164361644616456164661647616486164961650616516165261653616546165561656616576165861659616606166161662616636166461665616666166761668616696167061671616726167361674616756167661677616786167961680616816168261683616846168561686616876168861689616906169161692616936169461695616966169761698616996170061701617026170361704617056170661707617086170961710617116171261713617146171561716617176171861719617206172161722617236172461725617266172761728617296173061731617326173361734617356173661737617386173961740617416174261743617446174561746617476174861749617506175161752617536175461755617566175761758617596176061761617626176361764617656176661767617686176961770617716177261773617746177561776617776177861779617806178161782617836178461785617866178761788617896179061791617926179361794617956179661797617986179961800618016180261803618046180561806618076180861809618106181161812618136181461815618166181761818618196182061821618226182361824618256182661827618286182961830618316183261833618346183561836618376183861839618406184161842618436184461845618466184761848618496185061851618526185361854618556185661857618586185961860618616186261863618646186561866618676186861869618706187161872618736187461875618766187761878618796188061881618826188361884618856188661887618886188961890618916189261893618946189561896618976189861899619006190161902619036190461905619066190761908619096191061911619126191361914619156191661917619186191961920619216192261923619246192561926619276192861929619306193161932619336193461935619366193761938619396194061941619426194361944619456194661947619486194961950619516195261953619546195561956619576195861959619606196161962619636196461965619666196761968619696197061971619726197361974619756197661977619786197961980619816198261983619846198561986619876198861989619906199161992619936199461995619966199761998619996200062001620026200362004620056200662007620086200962010620116201262013620146201562016620176201862019620206202162022620236202462025620266202762028620296203062031620326203362034620356203662037620386203962040620416204262043620446204562046620476204862049620506205162052620536205462055620566205762058620596206062061620626206362064620656206662067620686206962070620716207262073620746207562076620776207862079620806208162082620836208462085620866208762088620896209062091620926209362094620956209662097620986209962100621016210262103621046210562106621076210862109621106211162112621136211462115621166211762118621196212062121621226212362124621256212662127621286212962130621316213262133621346213562136621376213862139621406214162142621436214462145621466214762148621496215062151621526215362154621556215662157621586215962160621616216262163621646216562166621676216862169621706217162172621736217462175621766217762178621796218062181621826218362184621856218662187621886218962190621916219262193621946219562196621976219862199622006220162202622036220462205622066220762208622096221062211622126221362214622156221662217622186221962220622216222262223622246222562226622276222862229622306223162232622336223462235622366223762238622396224062241622426224362244622456224662247622486224962250622516225262253622546225562256622576225862259622606226162262622636226462265622666226762268622696227062271622726227362274622756227662277622786227962280622816228262283622846228562286622876228862289622906229162292622936229462295622966229762298622996230062301623026230362304623056230662307623086230962310623116231262313623146231562316623176231862319623206232162322623236232462325623266232762328623296233062331623326233362334623356233662337623386233962340623416234262343623446234562346623476234862349623506235162352623536235462355623566235762358623596236062361623626236362364623656236662367623686236962370623716237262373623746237562376623776237862379623806238162382623836238462385623866238762388623896239062391623926239362394623956239662397623986239962400624016240262403624046240562406624076240862409624106241162412624136241462415624166241762418624196242062421624226242362424624256242662427624286242962430624316243262433624346243562436624376243862439624406244162442624436244462445624466244762448624496245062451624526245362454624556245662457624586245962460624616246262463624646246562466624676246862469624706247162472624736247462475624766247762478624796248062481624826248362484624856248662487624886248962490624916249262493624946249562496624976249862499625006250162502625036250462505625066250762508625096251062511625126251362514625156251662517625186251962520625216252262523625246252562526625276252862529625306253162532625336253462535625366253762538625396254062541625426254362544625456254662547625486254962550625516255262553625546255562556625576255862559625606256162562625636256462565625666256762568625696257062571625726257362574625756257662577625786257962580625816258262583625846258562586625876258862589625906259162592625936259462595625966259762598625996260062601626026260362604626056260662607626086260962610626116261262613626146261562616626176261862619626206262162622626236262462625626266262762628626296263062631626326263362634626356263662637626386263962640626416264262643626446264562646626476264862649626506265162652626536265462655626566265762658626596266062661626626266362664626656266662667626686266962670626716267262673626746267562676626776267862679626806268162682626836268462685626866268762688626896269062691626926269362694626956269662697626986269962700627016270262703627046270562706627076270862709627106271162712627136271462715627166271762718627196272062721627226272362724627256272662727627286272962730627316273262733627346273562736627376273862739627406274162742627436274462745627466274762748627496275062751627526275362754627556275662757627586275962760627616276262763627646276562766627676276862769627706277162772627736277462775627766277762778627796278062781627826278362784627856278662787627886278962790627916279262793627946279562796627976279862799628006280162802628036280462805628066280762808628096281062811628126281362814628156281662817628186281962820628216282262823628246282562826628276282862829628306283162832628336283462835628366283762838628396284062841628426284362844628456284662847628486284962850628516285262853628546285562856628576285862859628606286162862628636286462865628666286762868628696287062871628726287362874628756287662877628786287962880628816288262883628846288562886628876288862889628906289162892628936289462895628966289762898628996290062901629026290362904629056290662907629086290962910629116291262913629146291562916629176291862919629206292162922629236292462925629266292762928629296293062931629326293362934629356293662937629386293962940629416294262943629446294562946629476294862949629506295162952629536295462955629566295762958629596296062961629626296362964629656296662967629686296962970629716297262973629746297562976629776297862979629806298162982629836298462985629866298762988629896299062991629926299362994629956299662997629986299963000630016300263003630046300563006630076300863009630106301163012630136301463015630166301763018630196302063021630226302363024630256302663027630286302963030630316303263033630346303563036630376303863039630406304163042630436304463045630466304763048630496305063051630526305363054630556305663057630586305963060630616306263063630646306563066630676306863069630706307163072630736307463075630766307763078630796308063081630826308363084630856308663087630886308963090630916309263093630946309563096630976309863099631006310163102631036310463105631066310763108631096311063111631126311363114631156311663117631186311963120631216312263123631246312563126631276312863129631306313163132631336313463135631366313763138631396314063141631426314363144631456314663147631486314963150631516315263153631546315563156631576315863159631606316163162631636316463165631666316763168631696317063171631726317363174631756317663177631786317963180631816318263183631846318563186631876318863189631906319163192631936319463195631966319763198631996320063201632026320363204632056320663207632086320963210632116321263213632146321563216632176321863219632206322163222632236322463225632266322763228632296323063231632326323363234632356323663237632386323963240632416324263243632446324563246632476324863249632506325163252632536325463255632566325763258632596326063261632626326363264632656326663267632686326963270632716327263273632746327563276632776327863279632806328163282632836328463285632866328763288632896329063291632926329363294632956329663297632986329963300633016330263303633046330563306633076330863309633106331163312633136331463315633166331763318633196332063321633226332363324633256332663327633286332963330633316333263333633346333563336633376333863339633406334163342633436334463345633466334763348633496335063351633526335363354633556335663357633586335963360633616336263363633646336563366633676336863369633706337163372633736337463375633766337763378633796338063381633826338363384633856338663387633886338963390633916339263393633946339563396633976339863399634006340163402634036340463405634066340763408634096341063411634126341363414634156341663417634186341963420634216342263423634246342563426634276342863429634306343163432634336343463435634366343763438634396344063441634426344363444634456344663447634486344963450634516345263453634546345563456634576345863459634606346163462634636346463465634666346763468634696347063471634726347363474634756347663477634786347963480634816348263483634846348563486634876348863489634906349163492634936349463495634966349763498634996350063501635026350363504635056350663507635086350963510635116351263513635146351563516635176351863519635206352163522635236352463525635266352763528635296353063531635326353363534635356353663537635386353963540635416354263543635446354563546635476354863549635506355163552635536355463555635566355763558635596356063561635626356363564635656356663567635686356963570635716357263573635746357563576635776357863579635806358163582635836358463585635866358763588635896359063591635926359363594635956359663597635986359963600636016360263603636046360563606636076360863609636106361163612636136361463615636166361763618636196362063621636226362363624636256362663627636286362963630636316363263633636346363563636636376363863639636406364163642636436364463645636466364763648636496365063651636526365363654636556365663657636586365963660636616366263663636646366563666636676366863669636706367163672636736367463675636766367763678636796368063681636826368363684636856368663687636886368963690636916369263693636946369563696636976369863699637006370163702637036370463705637066370763708637096371063711637126371363714637156371663717637186371963720637216372263723637246372563726637276372863729637306373163732637336373463735637366373763738637396374063741637426374363744637456374663747637486374963750637516375263753637546375563756637576375863759637606376163762637636376463765637666376763768637696377063771637726377363774637756377663777637786377963780637816378263783637846378563786637876378863789637906379163792637936379463795637966379763798637996380063801638026380363804638056380663807638086380963810638116381263813638146381563816638176381863819638206382163822638236382463825638266382763828638296383063831638326383363834638356383663837638386383963840638416384263843638446384563846638476384863849638506385163852638536385463855638566385763858638596386063861638626386363864638656386663867638686386963870638716387263873638746387563876638776387863879638806388163882638836388463885638866388763888638896389063891638926389363894638956389663897638986389963900639016390263903639046390563906639076390863909639106391163912639136391463915639166391763918639196392063921639226392363924639256392663927639286392963930639316393263933639346393563936639376393863939639406394163942639436394463945639466394763948639496395063951639526395363954639556395663957639586395963960639616396263963639646396563966639676396863969639706397163972639736397463975639766397763978639796398063981639826398363984639856398663987639886398963990639916399263993639946399563996639976399863999640006400164002640036400464005640066400764008640096401064011640126401364014640156401664017640186401964020640216402264023640246402564026640276402864029640306403164032640336403464035640366403764038640396404064041640426404364044640456404664047640486404964050640516405264053640546405564056640576405864059640606406164062640636406464065640666406764068640696407064071640726407364074640756407664077640786407964080640816408264083640846408564086640876408864089640906409164092640936409464095640966409764098640996410064101641026410364104641056410664107641086410964110641116411264113641146411564116641176411864119641206412164122641236412464125641266412764128641296413064131641326413364134641356413664137641386413964140641416414264143641446414564146641476414864149641506415164152641536415464155641566415764158641596416064161641626416364164641656416664167641686416964170641716417264173641746417564176641776417864179641806418164182641836418464185641866418764188641896419064191641926419364194641956419664197641986419964200642016420264203642046420564206642076420864209642106421164212642136421464215642166421764218642196422064221642226422364224642256422664227642286422964230642316423264233642346423564236642376423864239642406424164242642436424464245642466424764248642496425064251642526425364254642556425664257642586425964260642616426264263642646426564266642676426864269642706427164272642736427464275642766427764278642796428064281642826428364284642856428664287642886428964290642916429264293642946429564296642976429864299643006430164302643036430464305643066430764308643096431064311643126431364314643156431664317643186431964320643216432264323643246432564326643276432864329643306433164332643336433464335643366433764338643396434064341643426434364344643456434664347643486434964350643516435264353643546435564356643576435864359643606436164362643636436464365643666436764368643696437064371643726437364374643756437664377643786437964380643816438264383643846438564386643876438864389643906439164392643936439464395643966439764398643996440064401644026440364404644056440664407644086440964410644116441264413644146441564416644176441864419644206442164422644236442464425644266442764428644296443064431644326443364434644356443664437644386443964440644416444264443644446444564446644476444864449644506445164452644536445464455644566445764458644596446064461644626446364464644656446664467644686446964470644716447264473644746447564476644776447864479644806448164482644836448464485644866448764488644896449064491644926449364494644956449664497644986449964500645016450264503645046450564506645076450864509645106451164512645136451464515645166451764518645196452064521645226452364524645256452664527645286452964530645316453264533645346453564536645376453864539645406454164542645436454464545645466454764548645496455064551645526455364554645556455664557645586455964560645616456264563645646456564566645676456864569645706457164572645736457464575645766457764578645796458064581645826458364584645856458664587645886458964590645916459264593645946459564596645976459864599646006460164602646036460464605646066460764608646096461064611646126461364614646156461664617646186461964620646216462264623646246462564626646276462864629646306463164632646336463464635646366463764638646396464064641646426464364644646456464664647646486464964650646516465264653646546465564656646576465864659646606466164662646636466464665646666466764668646696467064671646726467364674646756467664677646786467964680646816468264683646846468564686646876468864689646906469164692646936469464695646966469764698646996470064701647026470364704647056470664707647086470964710647116471264713647146471564716647176471864719647206472164722647236472464725647266472764728647296473064731647326473364734647356473664737647386473964740647416474264743647446474564746647476474864749647506475164752647536475464755647566475764758647596476064761647626476364764647656476664767647686476964770647716477264773647746477564776647776477864779647806478164782647836478464785647866478764788647896479064791647926479364794647956479664797647986479964800648016480264803648046480564806648076480864809648106481164812648136481464815648166481764818648196482064821648226482364824648256482664827648286482964830648316483264833648346483564836648376483864839648406484164842648436484464845648466484764848648496485064851648526485364854648556485664857648586485964860648616486264863648646486564866648676486864869648706487164872648736487464875648766487764878648796488064881648826488364884648856488664887648886488964890648916489264893648946489564896648976489864899649006490164902649036490464905649066490764908649096491064911649126491364914649156491664917649186491964920649216492264923649246492564926649276492864929649306493164932649336493464935649366493764938649396494064941649426494364944649456494664947649486494964950649516495264953649546495564956649576495864959649606496164962649636496464965649666496764968649696497064971649726497364974649756497664977649786497964980649816498264983649846498564986649876498864989649906499164992649936499464995649966499764998649996500065001650026500365004650056500665007650086500965010650116501265013650146501565016650176501865019650206502165022650236502465025650266502765028650296503065031650326503365034650356503665037650386503965040650416504265043650446504565046650476504865049650506505165052650536505465055650566505765058650596506065061650626506365064650656506665067650686506965070650716507265073650746507565076650776507865079650806508165082650836508465085650866508765088650896509065091650926509365094650956509665097650986509965100651016510265103651046510565106651076510865109651106511165112651136511465115651166511765118651196512065121651226512365124651256512665127651286512965130651316513265133651346513565136651376513865139651406514165142651436514465145651466514765148651496515065151651526515365154651556515665157651586515965160651616516265163651646516565166651676516865169651706517165172651736517465175651766517765178651796518065181651826518365184651856518665187651886518965190651916519265193651946519565196651976519865199652006520165202652036520465205652066520765208652096521065211652126521365214652156521665217652186521965220652216522265223652246522565226652276522865229652306523165232652336523465235652366523765238652396524065241652426524365244652456524665247652486524965250652516525265253652546525565256652576525865259652606526165262652636526465265652666526765268652696527065271652726527365274652756527665277652786527965280652816528265283652846528565286652876528865289652906529165292652936529465295652966529765298652996530065301653026530365304653056530665307653086530965310653116531265313653146531565316653176531865319653206532165322653236532465325653266532765328653296533065331653326533365334653356533665337653386533965340653416534265343653446534565346653476534865349653506535165352653536535465355653566535765358653596536065361653626536365364653656536665367653686536965370653716537265373653746537565376653776537865379653806538165382653836538465385653866538765388653896539065391653926539365394653956539665397653986539965400654016540265403654046540565406654076540865409654106541165412654136541465415654166541765418654196542065421654226542365424654256542665427654286542965430654316543265433654346543565436654376543865439654406544165442654436544465445654466544765448654496545065451654526545365454654556545665457654586545965460654616546265463654646546565466654676546865469654706547165472654736547465475654766547765478654796548065481654826548365484654856548665487654886548965490654916549265493654946549565496654976549865499655006550165502655036550465505655066550765508655096551065511655126551365514655156551665517655186551965520655216552265523655246552565526655276552865529655306553165532655336553465535655366553765538655396554065541655426554365544655456554665547655486554965550655516555265553655546555565556655576555865559655606556165562655636556465565655666556765568655696557065571655726557365574655756557665577655786557965580655816558265583655846558565586655876558865589655906559165592655936559465595655966559765598655996560065601656026560365604656056560665607656086560965610656116561265613656146561565616656176561865619656206562165622656236562465625656266562765628656296563065631656326563365634656356563665637656386563965640656416564265643656446564565646656476564865649656506565165652656536565465655656566565765658656596566065661656626566365664656656566665667656686566965670656716567265673656746567565676656776567865679656806568165682656836568465685656866568765688656896569065691656926569365694656956569665697656986569965700657016570265703657046570565706657076570865709657106571165712657136571465715657166571765718657196572065721657226572365724657256572665727657286572965730657316573265733657346573565736657376573865739657406574165742657436574465745657466574765748657496575065751657526575365754657556575665757657586575965760657616576265763657646576565766657676576865769657706577165772657736577465775657766577765778657796578065781657826578365784657856578665787657886578965790657916579265793657946579565796657976579865799658006580165802658036580465805658066580765808658096581065811658126581365814658156581665817658186581965820658216582265823658246582565826658276582865829658306583165832658336583465835658366583765838658396584065841658426584365844658456584665847658486584965850658516585265853658546585565856658576585865859658606586165862658636586465865658666586765868658696587065871658726587365874658756587665877658786587965880658816588265883658846588565886658876588865889658906589165892658936589465895658966589765898658996590065901659026590365904659056590665907659086590965910659116591265913659146591565916659176591865919659206592165922659236592465925659266592765928659296593065931659326593365934659356593665937659386593965940659416594265943659446594565946659476594865949659506595165952659536595465955659566595765958659596596065961659626596365964659656596665967659686596965970659716597265973659746597565976659776597865979659806598165982659836598465985659866598765988659896599065991659926599365994659956599665997659986599966000660016600266003660046600566006660076600866009660106601166012660136601466015660166601766018660196602066021660226602366024660256602666027660286602966030660316603266033660346603566036660376603866039660406604166042660436604466045660466604766048660496605066051660526605366054660556605666057660586605966060660616606266063660646606566066660676606866069660706607166072660736607466075660766607766078660796608066081660826608366084660856608666087660886608966090660916609266093660946609566096660976609866099661006610166102661036610466105661066610766108661096611066111661126611366114661156611666117661186611966120661216612266123661246612566126661276612866129661306613166132661336613466135661366613766138661396614066141661426614366144661456614666147661486614966150661516615266153661546615566156661576615866159661606616166162661636616466165661666616766168661696617066171661726617366174661756617666177661786617966180661816618266183661846618566186661876618866189661906619166192661936619466195661966619766198661996620066201662026620366204662056620666207662086620966210662116621266213662146621566216662176621866219662206622166222662236622466225662266622766228662296623066231662326623366234662356623666237662386623966240662416624266243662446624566246662476624866249662506625166252662536625466255662566625766258662596626066261662626626366264662656626666267662686626966270662716627266273662746627566276662776627866279662806628166282662836628466285662866628766288662896629066291662926629366294662956629666297662986629966300663016630266303663046630566306663076630866309663106631166312663136631466315663166631766318663196632066321663226632366324663256632666327663286632966330663316633266333663346633566336663376633866339663406634166342663436634466345663466634766348663496635066351663526635366354663556635666357663586635966360663616636266363663646636566366663676636866369663706637166372663736637466375663766637766378663796638066381663826638366384663856638666387663886638966390663916639266393663946639566396663976639866399664006640166402664036640466405664066640766408664096641066411664126641366414664156641666417664186641966420664216642266423664246642566426664276642866429664306643166432664336643466435664366643766438664396644066441664426644366444664456644666447664486644966450664516645266453664546645566456664576645866459664606646166462664636646466465664666646766468664696647066471664726647366474664756647666477664786647966480664816648266483664846648566486664876648866489664906649166492664936649466495664966649766498664996650066501665026650366504665056650666507665086650966510665116651266513665146651566516665176651866519665206652166522665236652466525665266652766528665296653066531665326653366534665356653666537665386653966540665416654266543665446654566546665476654866549665506655166552665536655466555665566655766558665596656066561665626656366564665656656666567665686656966570665716657266573665746657566576665776657866579665806658166582665836658466585665866658766588665896659066591665926659366594665956659666597665986659966600666016660266603666046660566606666076660866609666106661166612666136661466615666166661766618666196662066621666226662366624666256662666627666286662966630666316663266633666346663566636666376663866639666406664166642666436664466645666466664766648666496665066651666526665366654666556665666657666586665966660666616666266663666646666566666666676666866669666706667166672666736667466675666766667766678666796668066681666826668366684666856668666687666886668966690666916669266693666946669566696666976669866699667006670166702667036670466705667066670766708667096671066711667126671366714667156671666717667186671966720667216672266723667246672566726667276672866729667306673166732667336673466735667366673766738667396674066741667426674366744667456674666747667486674966750667516675266753667546675566756667576675866759667606676166762667636676466765667666676766768667696677066771667726677366774667756677666777667786677966780667816678266783667846678566786667876678866789667906679166792667936679466795667966679766798667996680066801668026680366804668056680666807668086680966810668116681266813668146681566816668176681866819668206682166822668236682466825668266682766828668296683066831668326683366834668356683666837668386683966840668416684266843668446684566846668476684866849668506685166852668536685466855668566685766858668596686066861668626686366864668656686666867668686686966870668716687266873668746687566876668776687866879668806688166882668836688466885668866688766888668896689066891668926689366894668956689666897668986689966900669016690266903669046690566906669076690866909669106691166912669136691466915669166691766918669196692066921669226692366924669256692666927669286692966930669316693266933669346693566936669376693866939669406694166942669436694466945669466694766948669496695066951669526695366954669556695666957669586695966960669616696266963669646696566966669676696866969669706697166972669736697466975669766697766978669796698066981669826698366984669856698666987669886698966990669916699266993669946699566996669976699866999670006700167002670036700467005670066700767008670096701067011670126701367014670156701667017670186701967020670216702267023670246702567026670276702867029670306703167032670336703467035670366703767038670396704067041670426704367044670456704667047670486704967050670516705267053670546705567056670576705867059670606706167062670636706467065670666706767068670696707067071670726707367074670756707667077670786707967080670816708267083670846708567086670876708867089670906709167092670936709467095670966709767098670996710067101671026710367104671056710667107671086710967110671116711267113671146711567116671176711867119671206712167122671236712467125671266712767128671296713067131671326713367134671356713667137671386713967140671416714267143671446714567146671476714867149671506715167152671536715467155671566715767158671596716067161671626716367164671656716667167671686716967170671716717267173671746717567176671776717867179671806718167182671836718467185671866718767188671896719067191671926719367194671956719667197671986719967200672016720267203672046720567206672076720867209672106721167212672136721467215672166721767218672196722067221672226722367224672256722667227672286722967230672316723267233672346723567236672376723867239672406724167242672436724467245672466724767248672496725067251672526725367254672556725667257672586725967260672616726267263672646726567266672676726867269672706727167272672736727467275672766727767278672796728067281672826728367284672856728667287672886728967290672916729267293672946729567296672976729867299673006730167302673036730467305673066730767308673096731067311673126731367314673156731667317673186731967320673216732267323673246732567326673276732867329673306733167332673336733467335673366733767338673396734067341673426734367344673456734667347673486734967350673516735267353673546735567356673576735867359673606736167362673636736467365673666736767368673696737067371673726737367374673756737667377673786737967380673816738267383673846738567386673876738867389673906739167392673936739467395673966739767398673996740067401674026740367404674056740667407674086740967410674116741267413674146741567416674176741867419674206742167422674236742467425674266742767428674296743067431674326743367434674356743667437674386743967440674416744267443674446744567446674476744867449674506745167452674536745467455674566745767458674596746067461674626746367464674656746667467674686746967470674716747267473674746747567476674776747867479674806748167482674836748467485674866748767488674896749067491674926749367494674956749667497674986749967500675016750267503675046750567506675076750867509675106751167512675136751467515675166751767518675196752067521675226752367524675256752667527675286752967530675316753267533675346753567536675376753867539675406754167542675436754467545675466754767548675496755067551675526755367554675556755667557675586755967560675616756267563675646756567566675676756867569675706757167572675736757467575675766757767578675796758067581675826758367584675856758667587675886758967590675916759267593675946759567596675976759867599676006760167602676036760467605676066760767608676096761067611676126761367614676156761667617676186761967620676216762267623676246762567626676276762867629676306763167632676336763467635676366763767638676396764067641676426764367644676456764667647676486764967650676516765267653676546765567656676576765867659676606766167662676636766467665676666766767668676696767067671676726767367674676756767667677676786767967680676816768267683676846768567686676876768867689676906769167692676936769467695676966769767698676996770067701677026770367704677056770667707677086770967710677116771267713677146771567716677176771867719677206772167722677236772467725677266772767728677296773067731677326773367734677356773667737677386773967740677416774267743677446774567746677476774867749677506775167752677536775467755677566775767758677596776067761677626776367764677656776667767677686776967770677716777267773677746777567776677776777867779677806778167782677836778467785677866778767788677896779067791677926779367794677956779667797677986779967800678016780267803678046780567806678076780867809678106781167812678136781467815678166781767818678196782067821678226782367824678256782667827678286782967830678316783267833678346783567836678376783867839678406784167842678436784467845678466784767848678496785067851678526785367854678556785667857678586785967860678616786267863678646786567866678676786867869678706787167872678736787467875678766787767878678796788067881678826788367884678856788667887678886788967890678916789267893678946789567896678976789867899679006790167902679036790467905679066790767908679096791067911679126791367914679156791667917679186791967920679216792267923679246792567926679276792867929679306793167932679336793467935679366793767938679396794067941679426794367944679456794667947679486794967950679516795267953679546795567956679576795867959679606796167962679636796467965679666796767968679696797067971679726797367974679756797667977679786797967980679816798267983679846798567986679876798867989679906799167992679936799467995679966799767998679996800068001680026800368004680056800668007680086800968010680116801268013680146801568016680176801868019680206802168022680236802468025680266802768028680296803068031680326803368034680356803668037680386803968040680416804268043680446804568046680476804868049680506805168052680536805468055680566805768058680596806068061680626806368064680656806668067680686806968070680716807268073680746807568076680776807868079680806808168082680836808468085680866808768088680896809068091680926809368094680956809668097680986809968100681016810268103681046810568106681076810868109681106811168112681136811468115681166811768118681196812068121681226812368124681256812668127681286812968130681316813268133681346813568136681376813868139681406814168142681436814468145681466814768148681496815068151681526815368154681556815668157681586815968160681616816268163681646816568166681676816868169681706817168172681736817468175681766817768178681796818068181681826818368184681856818668187681886818968190681916819268193681946819568196681976819868199682006820168202682036820468205682066820768208682096821068211682126821368214682156821668217682186821968220682216822268223682246822568226682276822868229682306823168232682336823468235682366823768238682396824068241682426824368244682456824668247682486824968250682516825268253682546825568256682576825868259682606826168262682636826468265682666826768268682696827068271682726827368274682756827668277682786827968280682816828268283682846828568286682876828868289682906829168292682936829468295682966829768298682996830068301683026830368304683056830668307683086830968310683116831268313683146831568316683176831868319683206832168322683236832468325683266832768328683296833068331683326833368334683356833668337683386833968340683416834268343683446834568346683476834868349683506835168352683536835468355683566835768358683596836068361683626836368364683656836668367683686836968370683716837268373683746837568376683776837868379683806838168382683836838468385683866838768388683896839068391683926839368394683956839668397683986839968400684016840268403684046840568406684076840868409684106841168412684136841468415684166841768418684196842068421684226842368424684256842668427684286842968430684316843268433684346843568436684376843868439684406844168442684436844468445684466844768448684496845068451684526845368454684556845668457684586845968460684616846268463684646846568466684676846868469684706847168472684736847468475684766847768478684796848068481684826848368484684856848668487684886848968490684916849268493684946849568496684976849868499685006850168502685036850468505685066850768508685096851068511685126851368514685156851668517685186851968520685216852268523685246852568526685276852868529685306853168532685336853468535685366853768538685396854068541685426854368544685456854668547685486854968550685516855268553685546855568556685576855868559685606856168562685636856468565685666856768568685696857068571685726857368574685756857668577685786857968580685816858268583685846858568586685876858868589685906859168592685936859468595685966859768598685996860068601686026860368604686056860668607686086860968610686116861268613686146861568616686176861868619686206862168622686236862468625686266862768628686296863068631686326863368634686356863668637686386863968640686416864268643686446864568646686476864868649686506865168652686536865468655686566865768658686596866068661686626866368664686656866668667686686866968670686716867268673686746867568676686776867868679686806868168682686836868468685686866868768688686896869068691686926869368694686956869668697686986869968700687016870268703687046870568706687076870868709687106871168712687136871468715687166871768718687196872068721687226872368724687256872668727687286872968730687316873268733687346873568736687376873868739687406874168742687436874468745687466874768748687496875068751687526875368754687556875668757687586875968760687616876268763687646876568766687676876868769687706877168772687736877468775687766877768778687796878068781687826878368784687856878668787687886878968790687916879268793687946879568796687976879868799688006880168802688036880468805688066880768808688096881068811688126881368814688156881668817688186881968820688216882268823688246882568826688276882868829688306883168832688336883468835688366883768838688396884068841688426884368844688456884668847688486884968850688516885268853688546885568856688576885868859688606886168862688636886468865688666886768868688696887068871688726887368874688756887668877688786887968880688816888268883688846888568886688876888868889688906889168892688936889468895688966889768898688996890068901689026890368904689056890668907689086890968910689116891268913689146891568916689176891868919689206892168922689236892468925689266892768928689296893068931689326893368934689356893668937689386893968940689416894268943689446894568946689476894868949689506895168952689536895468955689566895768958689596896068961689626896368964689656896668967689686896968970689716897268973689746897568976689776897868979689806898168982689836898468985689866898768988689896899068991689926899368994689956899668997689986899969000690016900269003690046900569006690076900869009690106901169012690136901469015690166901769018690196902069021690226902369024690256902669027690286902969030690316903269033690346903569036690376903869039690406904169042690436904469045690466904769048690496905069051690526905369054690556905669057690586905969060690616906269063690646906569066690676906869069690706907169072690736907469075690766907769078690796908069081690826908369084690856908669087690886908969090690916909269093690946909569096690976909869099691006910169102691036910469105691066910769108691096911069111691126911369114691156911669117691186911969120691216912269123691246912569126691276912869129691306913169132691336913469135691366913769138691396914069141691426914369144691456914669147691486914969150691516915269153691546915569156691576915869159691606916169162691636916469165691666916769168691696917069171691726917369174691756917669177691786917969180691816918269183691846918569186691876918869189691906919169192691936919469195691966919769198691996920069201692026920369204692056920669207692086920969210692116921269213692146921569216692176921869219692206922169222692236922469225692266922769228692296923069231692326923369234692356923669237692386923969240692416924269243692446924569246692476924869249692506925169252692536925469255692566925769258692596926069261692626926369264692656926669267692686926969270692716927269273692746927569276692776927869279692806928169282692836928469285692866928769288692896929069291692926929369294692956929669297692986929969300693016930269303693046930569306693076930869309693106931169312693136931469315693166931769318693196932069321693226932369324693256932669327693286932969330693316933269333693346933569336693376933869339693406934169342693436934469345693466934769348693496935069351693526935369354693556935669357693586935969360693616936269363693646936569366693676936869369693706937169372693736937469375693766937769378693796938069381693826938369384693856938669387693886938969390693916939269393693946939569396693976939869399694006940169402694036940469405694066940769408694096941069411694126941369414694156941669417694186941969420694216942269423694246942569426694276942869429694306943169432694336943469435694366943769438694396944069441694426944369444694456944669447694486944969450694516945269453694546945569456694576945869459694606946169462694636946469465694666946769468694696947069471694726947369474694756947669477694786947969480694816948269483694846948569486694876948869489694906949169492694936949469495694966949769498694996950069501695026950369504695056950669507695086950969510695116951269513695146951569516695176951869519695206952169522695236952469525695266952769528695296953069531695326953369534695356953669537695386953969540695416954269543695446954569546695476954869549695506955169552695536955469555695566955769558695596956069561695626956369564695656956669567695686956969570695716957269573695746957569576695776957869579695806958169582695836958469585695866958769588695896959069591695926959369594695956959669597695986959969600696016960269603696046960569606696076960869609696106961169612696136961469615696166961769618696196962069621696226962369624696256962669627696286962969630696316963269633696346963569636696376963869639696406964169642696436964469645696466964769648696496965069651696526965369654696556965669657696586965969660696616966269663696646966569666696676966869669696706967169672696736967469675696766967769678696796968069681696826968369684696856968669687696886968969690696916969269693696946969569696696976969869699697006970169702697036970469705697066970769708697096971069711697126971369714697156971669717697186971969720697216972269723697246972569726697276972869729697306973169732697336973469735697366973769738697396974069741697426974369744697456974669747697486974969750697516975269753697546975569756697576975869759697606976169762697636976469765697666976769768697696977069771697726977369774697756977669777697786977969780697816978269783697846978569786697876978869789697906979169792697936979469795697966979769798697996980069801698026980369804698056980669807698086980969810698116981269813698146981569816698176981869819698206982169822698236982469825698266982769828698296983069831698326983369834698356983669837698386983969840698416984269843698446984569846698476984869849698506985169852698536985469855698566985769858698596986069861698626986369864698656986669867698686986969870698716987269873698746987569876698776987869879698806988169882698836988469885698866988769888698896989069891698926989369894698956989669897698986989969900699016990269903699046990569906699076990869909699106991169912699136991469915699166991769918699196992069921699226992369924699256992669927699286992969930699316993269933699346993569936699376993869939699406994169942699436994469945699466994769948699496995069951699526995369954699556995669957699586995969960699616996269963699646996569966699676996869969699706997169972699736997469975699766997769978699796998069981699826998369984699856998669987699886998969990699916999269993699946999569996699976999869999700007000170002700037000470005700067000770008700097001070011700127001370014700157001670017700187001970020700217002270023700247002570026700277002870029700307003170032700337003470035700367003770038700397004070041700427004370044700457004670047700487004970050700517005270053700547005570056700577005870059700607006170062700637006470065700667006770068700697007070071700727007370074700757007670077700787007970080700817008270083700847008570086700877008870089700907009170092700937009470095700967009770098700997010070101701027010370104701057010670107701087010970110701117011270113701147011570116701177011870119701207012170122701237012470125701267012770128701297013070131701327013370134701357013670137701387013970140701417014270143701447014570146701477014870149701507015170152701537015470155701567015770158701597016070161701627016370164701657016670167701687016970170701717017270173701747017570176701777017870179701807018170182701837018470185701867018770188701897019070191701927019370194701957019670197701987019970200702017020270203702047020570206702077020870209702107021170212702137021470215702167021770218702197022070221702227022370224702257022670227702287022970230702317023270233702347023570236702377023870239702407024170242702437024470245702467024770248702497025070251702527025370254702557025670257702587025970260702617026270263702647026570266702677026870269702707027170272702737027470275702767027770278702797028070281702827028370284702857028670287702887028970290702917029270293702947029570296702977029870299703007030170302703037030470305703067030770308703097031070311703127031370314703157031670317703187031970320703217032270323703247032570326703277032870329703307033170332703337033470335703367033770338703397034070341703427034370344703457034670347703487034970350703517035270353703547035570356703577035870359703607036170362703637036470365703667036770368703697037070371703727037370374703757037670377703787037970380703817038270383703847038570386703877038870389703907039170392703937039470395703967039770398703997040070401704027040370404704057040670407704087040970410704117041270413704147041570416704177041870419704207042170422704237042470425704267042770428704297043070431704327043370434704357043670437704387043970440704417044270443704447044570446704477044870449704507045170452704537045470455704567045770458704597046070461704627046370464704657046670467704687046970470704717047270473704747047570476704777047870479704807048170482704837048470485704867048770488704897049070491704927049370494704957049670497704987049970500705017050270503705047050570506705077050870509705107051170512705137051470515705167051770518705197052070521705227052370524705257052670527705287052970530705317053270533705347053570536705377053870539705407054170542705437054470545705467054770548705497055070551705527055370554705557055670557705587055970560705617056270563705647056570566705677056870569705707057170572705737057470575705767057770578705797058070581705827058370584705857058670587705887058970590705917059270593705947059570596705977059870599706007060170602706037060470605706067060770608706097061070611706127061370614706157061670617706187061970620706217062270623706247062570626706277062870629706307063170632706337063470635706367063770638706397064070641706427064370644706457064670647706487064970650706517065270653706547065570656706577065870659706607066170662706637066470665706667066770668706697067070671706727067370674706757067670677706787067970680706817068270683706847068570686706877068870689706907069170692706937069470695706967069770698706997070070701707027070370704707057070670707707087070970710707117071270713707147071570716707177071870719707207072170722707237072470725707267072770728707297073070731707327073370734707357073670737707387073970740707417074270743707447074570746707477074870749707507075170752707537075470755707567075770758707597076070761707627076370764707657076670767707687076970770707717077270773707747077570776707777077870779707807078170782707837078470785707867078770788707897079070791707927079370794707957079670797707987079970800708017080270803708047080570806708077080870809708107081170812708137081470815708167081770818708197082070821708227082370824708257082670827708287082970830708317083270833708347083570836708377083870839708407084170842708437084470845708467084770848708497085070851708527085370854708557085670857708587085970860708617086270863708647086570866708677086870869708707087170872708737087470875708767087770878708797088070881708827088370884708857088670887708887088970890708917089270893708947089570896708977089870899709007090170902709037090470905709067090770908709097091070911709127091370914709157091670917709187091970920709217092270923709247092570926709277092870929709307093170932709337093470935709367093770938709397094070941709427094370944709457094670947709487094970950709517095270953709547095570956709577095870959709607096170962709637096470965709667096770968709697097070971709727097370974709757097670977709787097970980709817098270983709847098570986709877098870989709907099170992709937099470995709967099770998709997100071001710027100371004710057100671007710087100971010710117101271013710147101571016710177101871019710207102171022710237102471025710267102771028710297103071031710327103371034710357103671037710387103971040710417104271043710447104571046710477104871049710507105171052710537105471055710567105771058710597106071061710627106371064710657106671067710687106971070710717107271073710747107571076710777107871079710807108171082710837108471085710867108771088710897109071091710927109371094710957109671097710987109971100711017110271103711047110571106711077110871109711107111171112711137111471115711167111771118711197112071121711227112371124711257112671127711287112971130711317113271133711347113571136711377113871139711407114171142711437114471145711467114771148711497115071151711527115371154711557115671157711587115971160711617116271163711647116571166711677116871169711707117171172711737117471175711767117771178711797118071181711827118371184711857118671187711887118971190711917119271193711947119571196711977119871199712007120171202712037120471205712067120771208712097121071211712127121371214712157121671217712187121971220712217122271223712247122571226712277122871229712307123171232712337123471235712367123771238712397124071241712427124371244712457124671247712487124971250712517125271253712547125571256712577125871259712607126171262712637126471265712667126771268712697127071271712727127371274712757127671277712787127971280712817128271283712847128571286712877128871289712907129171292712937129471295712967129771298712997130071301713027130371304713057130671307713087130971310713117131271313713147131571316713177131871319713207132171322713237132471325713267132771328713297133071331713327133371334713357133671337713387133971340713417134271343713447134571346713477134871349713507135171352713537135471355713567135771358713597136071361713627136371364713657136671367713687136971370713717137271373713747137571376713777137871379713807138171382713837138471385713867138771388713897139071391713927139371394713957139671397713987139971400714017140271403714047140571406714077140871409714107141171412714137141471415714167141771418714197142071421714227142371424714257142671427714287142971430714317143271433714347143571436714377143871439714407144171442714437144471445714467144771448714497145071451714527145371454714557145671457714587145971460714617146271463714647146571466714677146871469714707147171472714737147471475714767147771478714797148071481714827148371484714857148671487714887148971490714917149271493714947149571496714977149871499715007150171502715037150471505715067150771508715097151071511715127151371514715157151671517715187151971520715217152271523715247152571526715277152871529715307153171532715337153471535715367153771538715397154071541715427154371544715457154671547715487154971550715517155271553715547155571556715577155871559715607156171562715637156471565715667156771568715697157071571715727157371574715757157671577715787157971580715817158271583715847158571586715877158871589715907159171592715937159471595715967159771598715997160071601716027160371604716057160671607716087160971610716117161271613716147161571616716177161871619716207162171622716237162471625716267162771628716297163071631716327163371634716357163671637716387163971640716417164271643716447164571646716477164871649716507165171652716537165471655716567165771658716597166071661716627166371664716657166671667716687166971670716717167271673716747167571676716777167871679716807168171682716837168471685716867168771688716897169071691716927169371694716957169671697716987169971700717017170271703717047170571706717077170871709717107171171712717137171471715717167171771718717197172071721717227172371724717257172671727717287172971730717317173271733717347173571736717377173871739717407174171742717437174471745717467174771748717497175071751717527175371754717557175671757717587175971760717617176271763717647176571766717677176871769717707177171772717737177471775717767177771778717797178071781717827178371784717857178671787717887178971790717917179271793717947179571796717977179871799718007180171802718037180471805718067180771808718097181071811718127181371814718157181671817718187181971820718217182271823718247182571826718277182871829718307183171832718337183471835718367183771838718397184071841718427184371844718457184671847718487184971850718517185271853718547185571856718577185871859718607186171862718637186471865718667186771868718697187071871718727187371874718757187671877718787187971880718817188271883718847188571886718877188871889718907189171892718937189471895718967189771898718997190071901719027190371904719057190671907719087190971910719117191271913719147191571916719177191871919719207192171922719237192471925719267192771928719297193071931719327193371934719357193671937719387193971940719417194271943719447194571946719477194871949719507195171952719537195471955719567195771958719597196071961719627196371964719657196671967719687196971970719717197271973719747197571976719777197871979719807198171982719837198471985719867198771988719897199071991719927199371994719957199671997719987199972000720017200272003720047200572006720077200872009720107201172012720137201472015720167201772018720197202072021720227202372024720257202672027720287202972030720317203272033720347203572036720377203872039720407204172042720437204472045720467204772048720497205072051720527205372054720557205672057720587205972060720617206272063720647206572066720677206872069720707207172072720737207472075720767207772078720797208072081720827208372084720857208672087720887208972090720917209272093720947209572096720977209872099721007210172102721037210472105721067210772108721097211072111721127211372114721157211672117721187211972120721217212272123721247212572126721277212872129721307213172132721337213472135721367213772138721397214072141721427214372144721457214672147721487214972150721517215272153721547215572156721577215872159721607216172162721637216472165721667216772168721697217072171721727217372174721757217672177721787217972180721817218272183721847218572186721877218872189721907219172192721937219472195721967219772198721997220072201722027220372204722057220672207722087220972210722117221272213722147221572216722177221872219722207222172222722237222472225722267222772228722297223072231722327223372234722357223672237722387223972240722417224272243722447224572246722477224872249722507225172252722537225472255722567225772258722597226072261722627226372264722657226672267722687226972270722717227272273722747227572276722777227872279722807228172282722837228472285722867228772288722897229072291722927229372294722957229672297722987229972300723017230272303723047230572306723077230872309723107231172312723137231472315723167231772318723197232072321723227232372324723257232672327723287232972330723317233272333723347233572336723377233872339723407234172342723437234472345723467234772348723497235072351723527235372354723557235672357723587235972360723617236272363723647236572366723677236872369723707237172372723737237472375723767237772378723797238072381723827238372384723857238672387723887238972390723917239272393723947239572396723977239872399724007240172402724037240472405724067240772408724097241072411724127241372414724157241672417724187241972420724217242272423724247242572426724277242872429724307243172432724337243472435724367243772438724397244072441724427244372444724457244672447724487244972450724517245272453724547245572456724577245872459724607246172462724637246472465724667246772468724697247072471724727247372474724757247672477724787247972480724817248272483724847248572486724877248872489724907249172492724937249472495724967249772498724997250072501725027250372504725057250672507725087250972510725117251272513725147251572516725177251872519725207252172522725237252472525725267252772528725297253072531725327253372534725357253672537725387253972540725417254272543725447254572546725477254872549725507255172552725537255472555725567255772558725597256072561725627256372564725657256672567725687256972570725717257272573725747257572576725777257872579725807258172582725837258472585725867258772588725897259072591725927259372594725957259672597725987259972600726017260272603726047260572606726077260872609726107261172612726137261472615726167261772618726197262072621726227262372624726257262672627726287262972630726317263272633726347263572636726377263872639726407264172642726437264472645726467264772648726497265072651726527265372654726557265672657726587265972660726617266272663726647266572666726677266872669726707267172672726737267472675726767267772678726797268072681726827268372684726857268672687726887268972690726917269272693726947269572696726977269872699727007270172702727037270472705727067270772708727097271072711727127271372714727157271672717727187271972720727217272272723727247272572726727277272872729727307273172732727337273472735727367273772738727397274072741727427274372744727457274672747727487274972750727517275272753727547275572756727577275872759727607276172762727637276472765727667276772768727697277072771727727277372774727757277672777727787277972780727817278272783727847278572786727877278872789727907279172792727937279472795727967279772798727997280072801728027280372804728057280672807728087280972810728117281272813728147281572816728177281872819728207282172822728237282472825728267282772828728297283072831728327283372834728357283672837728387283972840728417284272843728447284572846728477284872849728507285172852728537285472855728567285772858728597286072861728627286372864728657286672867728687286972870
  1. 2012-05-21 Gavin Barraclough <barraclough@apple.com>
  2. Disable private names by default in WebCore
  3. https://bugs.webkit.org/show_bug.cgi?id=87088
  4. Reviewed by Geoff Garen.
  5. r117859 introduced a preliminary implementation of ES6-like private name objects to JSC.
  6. These are probably not yet ready to be web-facing, so disabling by default in WebCore.
  7. Opting-in for JSC & DumpRenderTree so that we can still run the fast/js/names.html test.
  8. * DumpRenderTree/mac/DumpRenderTree.mm:
  9. (resetDefaultsToConsistentValues):
  10. - Enable private name support in DRT.
  11. * WebKitTestRunner/TestController.cpp:
  12. (WTR::TestController::resetStateToConsistentValues):
  13. - Enable private name support in WKTR.
  14. 2012-05-22 Martin Robinson <mrobinson@igalia.com>
  15. Fix a small syntax error in the GTK+ API test runner.
  16. Reviewed by Gustavo Noronha Silva.
  17. * gtk/run-api-tests:
  18. (TestRunner._setup_testing_environment): When reporting the error use
  19. the correct Python format string syntax.
  20. 2012-05-22 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  21. [GTK][DRT] Wrong cache model is taken in LayoutTestController's setCacheModel()
  22. https://bugs.webkit.org/show_bug.cgi?id=86962
  23. Reviewed by Gustavo Noronha Silva.
  24. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  25. (LayoutTestController::setCacheModel): Sets WEBKIT_CACHE_MODEL_WEB_BROWSER if argument is 2.
  26. 2012-05-22 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  27. [EFL][DRT] Key modifier bit flags have enum type.
  28. https://bugs.webkit.org/show_bug.cgi?id=86838
  29. Reviewed by Antonio Gomes.
  30. Refactoring. Key modifier flags are unsigned int.
  31. Key modifier bit flags used have enum type. It caused problems as a key can have several modifiers
  32. at the same time and the union of modifiers (i.e. EvasKeyModifierControl | EvasKeyModifierShift)
  33. would have been out of EvasKeyModifier enum.
  34. * DumpRenderTree/efl/EventSender.cpp:
  35. (KeyEventInfo::KeyEventInfo):
  36. (KeyEventInfo):
  37. (MouseEventInfo::MouseEventInfo):
  38. (MouseEventInfo):
  39. (setEvasModifiers):
  40. (modifiersFromJSValue):
  41. (mouseDownCallback):
  42. (mouseUpCallback):
  43. (keyPadNameFromJSValue):
  44. (keyNameFromJSValue):
  45. (createKeyEventInfo):
  46. (sendKeyDown):
  47. 2012-05-22 Takashi Sakamoto <tasak@google.com>
  48. Implement DOM_KEY_LOCATION_LEFT and RIGHT of KeyboardEvent's location property
  49. https://bugs.webkit.org/show_bug.cgi?id=86694
  50. Modify keyDown to create left- and right- control, shift, and alt
  51. keyevent for a test to check that keyLocation property can have
  52. DOM_KEY_LOCATION_LEFT for left-control, shift, and alt, and
  53. DOM_KEY_LOCATION_RIGHT for right-control, shift, and alt.
  54. Reviewed by Alexey Proskuryakov.
  55. * DumpRenderTree/chromium/EventSender.cpp:
  56. (EventSender::keyDown):
  57. * DumpRenderTree/mac/EventSendingController.mm:
  58. (-[EventSendingController keyDown:withModifiers:withLocation:]):
  59. 2012-05-22 Christophe Dumez <christophe.dumez@intel.com>
  60. [EFL] EFL's DRT needs to print information about received Web Intents
  61. https://bugs.webkit.org/show_bug.cgi?id=86864
  62. Reviewed by Adam Barth.
  63. Catch "intent,new" signal in EFL's DumpRenderTree and dump information
  64. about the intent. This output is expected by several webintents test
  65. cases.
  66. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  67. (DumpRenderTreeChrome::createView):
  68. (DumpRenderTreeChrome::onFrameCreated):
  69. (DumpRenderTreeChrome::onFrameIntentNew):
  70. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  71. (DumpRenderTreeChrome):
  72. 2012-05-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  73. [EFL] Add support to enable/disable DOM paste
  74. https://bugs.webkit.org/show_bug.cgi?id=85040
  75. Reviewed by Gustavo Noronha Silva.
  76. Enable JavascriptCanAccessClipboard setting on each test startup so
  77. that test cases which rely on clipboard can be unskipped.
  78. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  79. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  80. 2012-05-22 Hugo Parente Lima <hugo.lima@openbossa.org>
  81. [Qt][WK2] EventSenderProxy::keyDown doesn't use the helper functions to send events
  82. https://bugs.webkit.org/show_bug.cgi?id=87044
  83. Reviewed by Alexis Menard.
  84. Use sendOrQueueEvent instead of m_testController->mainWebView()->sendEvent
  85. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  86. (WTR::EventSenderProxy::keyDown):
  87. 2012-05-22 Zan Dobersek <zandobersek@gmail.com>
  88. [Gtk][LayoutTests] Repaint the complete WebKitWebView before dumping pixel results
  89. https://bugs.webkit.org/show_bug.cgi?id=86284
  90. Reviewed by Martin Robinson.
  91. Paint the current dirty regions of the web view once more before
  92. dumping pixel results.
  93. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  94. (dump):
  95. 2012-05-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  96. GCC 4.7 and C++11 support.
  97. https://bugs.webkit.org/show_bug.cgi?id=86465
  98. Reviewed by Darin Adler.
  99. Update detection of C++11 mode in GCC.
  100. * qmake/mkspecs/features/unix/default_post.prf:
  101. 2012-05-22 Hao Zheng <zhenghao@chromium.org>
  102. [chromium] WebViewHost should use ENABLE guards for some features.
  103. https://bugs.webkit.org/show_bug.cgi?id=87087
  104. Reviewed by Kent Tamura.
  105. These features are disabled on OS(ANDROID) and so shouldn't be
  106. compiled when the feature is off.
  107. * DumpRenderTree/chromium/WebViewHost.cpp:
  108. (WebViewHost::reset):
  109. * DumpRenderTree/chromium/WebViewHost.h:
  110. (WebViewHost):
  111. 2012-05-21 Christophe Dumez <christophe.dumez@intel.com>
  112. [EFL] EFL's DumpRenderTree does not print didReceiveTitle messages
  113. https://bugs.webkit.org/show_bug.cgi?id=85971
  114. Reviewed by Antonio Gomes.
  115. Listen for the "title,changed" signal on the frames instead of the
  116. view so that we get notified for other frame than the main one.
  117. Print out the didReceiveTitle messages which are expected if
  118. LayoutTestController's dumpFrameLoadCallbacks() returns true.
  119. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  120. (DumpRenderTreeChrome::createView):
  121. (DumpRenderTreeChrome::onFrameTitleChanged):
  122. (DumpRenderTreeChrome::onFrameCreated):
  123. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  124. (DumpRenderTreeChrome):
  125. 2012-05-21 Raphael Kubo da Costa <rakuco@webkit.org>
  126. [EFL] Unreviewed, reverting r116461.
  127. r116461 caused a regression in the pixel tests, as scrollbars
  128. stopped being rendered in the PNGs.
  129. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
  130. (createBitmapContextFromWebView):
  131. 2012-05-21 Brady Eidson <beidson@apple.com>
  132. <rdar://problem/11460336> and https://bugs.webkit.org/show_bug.cgi?id=87061
  133. WKPageGetScaleFactor can return 0.0 after a session is restored
  134. Reviewed by Beth Dakin.
  135. Loads a simple page, creates a session from it, restores that session, then
  136. queries the page scale factor for the appropriate value of 1.0.
  137. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  138. * TestWebKitAPI/Tests/WebKit2/WKPageGetScaleFactorNotZero.cpp: Added.
  139. (TestWebKitAPI):
  140. (TestWebKitAPI::didFinishLoadForFrame):
  141. (TestWebKitAPI::setPageLoaderClient):
  142. (TestWebKitAPI::createSessionState):
  143. (TestWebKitAPI::TEST):
  144. 2012-05-21 Hugo Parente Lima <hugo.lima@openbossa.org>
  145. [WK2] Remove a useless #if on Tools/WebKitTestRunner/TestController.cpp
  146. https://bugs.webkit.org/show_bug.cgi?id=87047
  147. Reviewed by Alexis Menard.
  148. * WebKitTestRunner/TestController.cpp:
  149. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  150. 2012-05-21 Dirk Pranke <dpranke@chromium.org>
  151. webkitpy: clean up the TestExpectations constructor
  152. https://bugs.webkit.org/show_bug.cgi?id=86926
  153. Reviewed by Ojan Vafai.
  154. The TestExpectations constructor was attempting to pretend
  155. it didn't need to get stuff from the Port, and as a result we
  156. had a complicated constructor with a bunch of arguments, and
  157. calling it was too complicated (although it made testing a
  158. little easier and simplified the style checker).
  159. This patch has the constructor pull all the data it needs from
  160. the port directly, and allows us to delete a bunch of code.
  161. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  162. (Manager.parse_expectations):
  163. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  164. (ManagerTest.test_update_summary_with_result):
  165. (ResultSummaryTest.get_result_summary):
  166. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  167. (TestExpectations.__init__):
  168. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  169. (parse_exp):
  170. (SkippedTests.check):
  171. (RemoveConfigurationsTest.test_remove):
  172. (test_remove_line):
  173. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  174. (lint):
  175. (run):
  176. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  177. (LintTest.test_all_configurations.FakePort.__init__):
  178. (LintTest.test_all_configurations.FakePort.test_expectations):
  179. (LintTest.test_all_configurations.FakePort.skipped_layout_tests):
  180. (LintTest.test_all_configurations.FakePort):
  181. (LintTest.test_all_configurations.FakePort.all_test_configurations):
  182. (LintTest.test_all_configurations.FakePort.configuration_specifier_macros):
  183. (LintTest.test_all_configurations.FakePort.path_from_webkit_base):
  184. (LintTest.test_all_configurations.FakePort.get_option):
  185. (LintTest.test_all_configurations.FakeFactory.__init__):
  186. (LintTest.test_all_configurations.FakeFactory.all_port_names):
  187. (LintTest.test_all_configurations):
  188. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  189. (Testprinter.get_result_summary):
  190. * Scripts/webkitpy/style/checkers/test_expectations.py:
  191. (TestExpectationsChecker.check_test_expectations):
  192. * Scripts/webkitpy/tool/commands/queries.py:
  193. (PrintExpectations._model):
  194. * Scripts/webkitpy/tool/commands/rebaseline.py:
  195. (RebaselineTest._update_expectations_file):
  196. (RebaselineExpectations._expectations):
  197. 2012-05-21 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  198. [GTK] DRT support for layoutTestController.setSerializeHTTPLoads
  199. https://bugs.webkit.org/show_bug.cgi?id=86653
  200. Reviewed by Gustavo Noronha Silva.
  201. Add missing implementation setSerializeHTTPLoads to allow
  202. testing resource load order.
  203. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  204. (resetDefaultsToConsistentValues):
  205. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  206. (LayoutTestController::setSerializeHTTPLoads):
  207. 2012-05-21 Elliot Poger <epoger@chromium.org>
  208. add skia_test_expectations override file to chromium NRWT
  209. https://bugs.webkit.org/show_bug.cgi?id=86749
  210. Reviewed by Dirk Pranke
  211. * Scripts/webkitpy/layout_tests/port/base.py:
  212. (Port.test_expectations_overrides):
  213. * Scripts/webkitpy/layout_tests/port/chromium.py:
  214. (ChromiumPort.test_expectations_overrides):
  215. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  216. (ChromiumPortTest.test_overrides_and_builder_names):
  217. 2012-05-21 Thiago Marcos P. Santos <thiago.santos@intel.com>
  218. webkitdirs.pm: Fix undefined CXXFLAGS variable
  219. https://bugs.webkit.org/show_bug.cgi?id=87000
  220. Reviewed by Martin Robinson.
  221. Fixes a warning on Autotools and CMake buildsystem when
  222. CXXFLAGS is not defined.
  223. * Scripts/webkitdirs.pm:
  224. (runAutogenForAutotoolsProjectIfNecessary):
  225. (generateBuildSystemFromCMakeProject):
  226. 2012-05-21 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  227. Move setEditingBehavior() from layoutTestController to window.internals
  228. https://bugs.webkit.org/show_bug.cgi?id=42689
  229. Reviewed by Hajime Morita and Kenneth Rohde Christiansen.
  230. Remove code that implements setEditingBehavior() for each platform. Note that
  231. During the InternalsObject reset the behavior is changed back to the platform
  232. default.
  233. Qt and Chromium ports set a default editing behavior for running tests different
  234. from the platform default, so they still keep code for resetting to the desired
  235. editing behavior. Other ports use the their defaults, that are restored by
  236. internals object.
  237. * DumpRenderTree/LayoutTestController.cpp:
  238. (LayoutTestController::staticFunctions):
  239. * DumpRenderTree/LayoutTestController.h:
  240. (LayoutTestController):
  241. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  242. (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
  243. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  244. * DumpRenderTree/chromium/LayoutTestController.cpp:
  245. (LayoutTestController::LayoutTestController):
  246. * DumpRenderTree/chromium/LayoutTestController.h:
  247. (LayoutTestController):
  248. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  249. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  250. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  251. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  252. * DumpRenderTree/mac/DumpRenderTree.mm:
  253. (resetDefaultsToConsistentValues):
  254. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  255. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  256. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  257. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  258. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  259. (LayoutTestController):
  260. * DumpRenderTree/win/DumpRenderTree.cpp:
  261. (resetDefaultsToConsistentValues):
  262. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  263. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  264. 2012-05-21 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  265. [EFL] PlatformKeyboardEventEfl is missing ESC key handling.
  266. https://bugs.webkit.org/show_bug.cgi?id=86837
  267. Reviewed by Kenneth Rohde Christiansen.
  268. * DumpRenderTree/efl/EventSender.cpp:
  269. (keyNameFromJSValue): Added ESC key handling.
  270. 2012-05-20 Carlos Garcia Campos <cgarcia@igalia.com>
  271. [GTK] Add GCancellable parameter to all methods using gio async pattern
  272. https://bugs.webkit.org/show_bug.cgi?id=86843
  273. Reviewed by Gustavo Noronha Silva.
  274. * MiniBrowser/gtk/BrowserWindow.c:
  275. (browser_window_load_uri):
  276. 2012-05-20 Daniel Bates <dbates@webkit.org>
  277. svn-apply cannot apply patches to files that contain space
  278. characters in their path
  279. https://bugs.webkit.org/show_bug.cgi?id=85742
  280. Reviewed by Eric Seidel.
  281. Fixes an issue where svn-apply cannot apply a patch to a file
  282. if there is a space in its file path.
  283. The regular expression we were using to fix up +++/--- lines
  284. was too strict; it only matched file paths that contained non-
  285. whitespace characters. Instead, it's sufficient to match file
  286. paths whose characters aren't in the set {\t, \n, \r}.
  287. * Scripts/VCSUtils.pm:
  288. (parseSvnDiffHeader):
  289. (runCommand): Added.
  290. * Scripts/svn-apply:
  291. (scmWillDeleteFile): Modified to call runCommand() so as to
  292. handle querying git for a file whose path may contain a space
  293. character.
  294. * Scripts/webkitperl/VCSUtils_unittest/parseSvnDiffHeader.pl:
  295. - Added test case "new file with spaces in its name".
  296. * Scripts/webkitperl/VCSUtils_unittest/runCommand.pl: Added.
  297. 2012-05-20 Daniel Bates <dbates@webkit.org>
  298. svn-apply fails to apply a patch that moves files from directory A to A/B
  299. https://bugs.webkit.org/show_bug.cgi?id=86973
  300. Reviewed by Eric Seidel.
  301. Fixes an issue where svn-apply fails to apply a patch that moves files in a
  302. directory A to some sub-directory B in A with a Git checkout of WebKit.
  303. Currently, svn-apply only creates new directories along a file system path that
  304. it hasn't already processed. That is, if svn-apply creates/traverses all the
  305. intermediate directories along the path A/B then it will assume the directory A/B
  306. exists for all subsequent requests to create sub-directories in A/B (e.g. A/B/C).
  307. When moving a file F in directory A to directory A/B using a Git checkout, Git
  308. may remove directory A if F is the last file in A. Therefore, svn-apply will fail
  309. to create sub-directory B in A (since A no longer exists).
  310. * Scripts/svn-apply:
  311. (addDirectoriesIfNeeded):
  312. 2012-05-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  313. [Chromium] Print layout test result on buildbot
  314. https://bugs.webkit.org/show_bug.cgi?id=86965
  315. Reviewed by Eric Seidel.
  316. * Scripts/run-webkit-tests: Add chrome-bot to buildbot user list.
  317. (runningOnBuildBot):
  318. 2012-05-19 Kevin Ollivier <kevino@theolliviers.com>
  319. [wx] Unreviewed build fix. Don't stop the build if a build system update check fails.
  320. * waf/build/build_utils.py:
  321. (download_if_newer):
  322. 2012-05-19 Ryosuke Niwa <rniwa@webkit.org>
  323. Build fix. Sometimes --suffixes isn't supplied.
  324. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  325. (GardeningHTTPRequestHandler.rebaseline):
  326. (GardeningHTTPRequestHandler.optimizebaselines):
  327. 2012-05-19 Ryosuke Niwa <rniwa@webkit.org>
  328. Add "Lion" -> "mac-lion" to the builder port map.
  329. * Scripts/webkitpy/layout_tests/port/builders.py:
  330. 2012-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
  331. Unreviewed, rolling out r117675.
  332. http://trac.webkit.org/changeset/117675
  333. https://bugs.webkit.org/show_bug.cgi?id=86938
  334. Broke builds. You can't initialize members by members
  335. themselves (Requested by rniwa on #webkit).
  336. * DumpRenderTree/chromium/LayoutTestController.cpp:
  337. (LayoutTestController::numberOfPages):
  338. * DumpRenderTree/chromium/WebViewHost.cpp:
  339. (WebViewHost::printPage):
  340. 2012-05-18 Kausalya Madhusudhanan <kmadhusu@chromium.org>
  341. [chromium] User overloaded printBegin() webkit API to support auto fit to page functionality.
  342. https://bugs.webkit.org/show_bug.cgi?id=86684
  343. Reviewed by Darin Fisher.
  344. * DumpRenderTree/chromium/LayoutTestController.cpp:
  345. (LayoutTestController::numberOfPages):
  346. * DumpRenderTree/chromium/WebViewHost.cpp:
  347. (WebViewHost::printPage):
  348. 2012-05-18 Raphael Kubo da Costa <rakuco@webkit.org>
  349. [EFL][DRT] Make it possible to enable CSS Grid Layout.
  350. https://bugs.webkit.org/show_bug.cgi?id=86921
  351. Reviewed by Tony Chang.
  352. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  353. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  354. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  355. (LayoutTestController::overridePreference):
  356. 2012-05-18 Dirk Pranke <dpranke@chromium.org>
  357. scm.add() doesn't work properly with svn 1.7
  358. https://bugs.webkit.org/show_bug.cgi?id=86779
  359. Reviewed by Eric Seidel.
  360. Re-land the change in r117526 with a fix to maintain
  361. compatibility with SVN 1.4.4 (yay Leopard!); turns out
  362. that "svn info foo" works correctly in 1.4.4 but
  363. "svn info" from the directory "foo" doesn't if foo is
  364. not part of a checkout. in_working_directory() and
  365. value_from_svn_info() were using the arguments inconsistently,
  366. leading to weird errors.
  367. * Scripts/webkitpy/common/checkout/scm/scm.py:
  368. (SCM):
  369. (SCM.in_working_directory):
  370. * Scripts/webkitpy/common/checkout/scm/svn.py:
  371. (SVN):
  372. (SVN.in_working_directory):
  373. 2012-05-18 Levi Weintraub <leviw@chromium.org>
  374. Unreviewed. Moving myself from committer to reviewer.
  375. * Scripts/webkitpy/common/config/committers.py:
  376. 2012-05-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
  377. [EFL] Buildbot output does not print result stats anymore
  378. https://bugs.webkit.org/show_bug.cgi?id=85366
  379. Reviewed by Ryosuke Niwa.
  380. Make run-webkit-tests pass --verbose to new-run-webkit-tests
  381. on EFL Debug bot.
  382. * Scripts/run-webkit-tests:
  383. (runningOnBuildBot):
  384. 2012-05-18 Tony Chang <tony@chromium.org>
  385. remove the CSS_GRID_LAYOUT compiler define, but default grid layout to off
  386. https://bugs.webkit.org/show_bug.cgi?id=86767
  387. Reviewed by Ojan Vafai.
  388. * DumpRenderTree/chromium/LayoutTestController.cpp:
  389. (LayoutTestController::overridePreference):
  390. * DumpRenderTree/chromium/WebPreferences.cpp:
  391. (WebPreferences::reset):
  392. (WebPreferences::applyTo):
  393. * DumpRenderTree/chromium/WebPreferences.h:
  394. (WebPreferences):
  395. * Scripts/webkitperl/FeatureList.pm:
  396. 2012-05-18 Hugo Parente Lima <hugo.lima@openbossa.org>
  397. [Qt][WK2] fast/events/page-visibility-iframe-move-test.html fails
  398. https://bugs.webkit.org/show_bug.cgi?id=86731
  399. Reviewed by Simon Hausmann.
  400. Set the page visibility on a single page instead of on all pages
  401. from the page group.
  402. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  403. (WTR::LayoutTestController::setPageVisibility):
  404. (WTR::LayoutTestController::resetPageVisibility):
  405. 2012-05-18 Yi Shen <yi.4.shen@nokia.com>
  406. REGRESSION (r102553): Smart links do not work
  407. https://bugs.webkit.org/show_bug.cgi?id=85463
  408. Reviewed by Ryosuke Niwa.
  409. Add LayoutTestController::setAutomaticLinkDetectionEnabled().
  410. * DumpRenderTree/LayoutTestController.cpp:
  411. (setAutomaticLinkDetectionEnabledCallback):
  412. (LayoutTestController::staticFunctions):
  413. * DumpRenderTree/LayoutTestController.h:
  414. (LayoutTestController):
  415. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  416. (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
  417. * DumpRenderTree/chromium/LayoutTestController.cpp:
  418. (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
  419. * DumpRenderTree/chromium/LayoutTestController.h:
  420. (LayoutTestController):
  421. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  422. (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
  423. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  424. (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
  425. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  426. (LayoutTestController::setAutomaticLinkDetectionEnabled): Set automatic link detection enabled.
  427. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  428. (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
  429. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  430. (LayoutTestController):
  431. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  432. (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
  433. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  434. (LayoutTestController::setAutomaticLinkDetectionEnabled): Not implemented.
  435. 2012-05-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
  436. [EFL] Add shortcut to dump Security Origin and Web Database information
  437. https://bugs.webkit.org/show_bug.cgi?id=86521
  438. Reviewed by Gustavo Noronha Silva.
  439. Added key combination (CTRL+s) to dump information about the
  440. security origin and databases of the main frame. Useful for API
  441. testing and debugging.
  442. * EWebLauncher/main.c:
  443. (on_key_down):
  444. 2012-05-18 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  445. [EFL] DRT needs an implementation of layoutTestController.setSerializeHTTPLoads
  446. https://bugs.webkit.org/show_bug.cgi?id=86101
  447. Reviewed by Ryosuke Niwa.
  448. Add missing implementation setSerializeHTTPLoads to allow
  449. testing resource load order.
  450. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  451. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  452. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  453. (LayoutTestController::setSerializeHTTPLoads):
  454. 2012-05-18 Jochen Eisinger <jochen@chromium.org>
  455. [chromium] plumb the frame for which a drag was initiated to the WebViewClient
  456. https://bugs.webkit.org/show_bug.cgi?id=86670
  457. Reviewed by Kent Tamura.
  458. * DumpRenderTree/chromium/WebViewHost.cpp:
  459. (WebViewHost::startDragging):
  460. * DumpRenderTree/chromium/WebViewHost.h:
  461. (WebViewHost):
  462. 2012-05-18 Christophe Dumez <christophe.dumez@intel.com>
  463. [EFL] appcache tests are flaky
  464. https://bugs.webkit.org/show_bug.cgi?id=86619
  465. Reviewed by Ryosuke Niwa.
  466. Correctly set the application cache database path in EFL's
  467. DumpRenderTree initialization code.
  468. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  469. (DumpRenderTreeChrome::initialize):
  470. 2012-05-17 Raphael Kubo da Costa <rakuco@webkit.org>
  471. [EFL][DRT] Call resetInternalsObject() after each test.
  472. https://bugs.webkit.org/show_bug.cgi?id=86793
  473. Reviewed by Antonio Gomes.
  474. We need to reset the internals object's settings after running
  475. each test so that there are no interferences between each test's
  476. results.
  477. * DumpRenderTree/efl/DumpRenderTree.cpp:
  478. (runTest):
  479. 2012-05-17 Sheriff Bot <webkit.review.bot@gmail.com>
  480. Unreviewed, rolling out r117526.
  481. http://trac.webkit.org/changeset/117526
  482. https://bugs.webkit.org/show_bug.cgi?id=86801
  483. broke Chromium Mac 10.5 layout test canaries (Requested by
  484. pkasting on #webkit).
  485. * Scripts/webkitpy/common/checkout/scm/scm.py:
  486. (SCM):
  487. (SCM.in_working_directory):
  488. * Scripts/webkitpy/common/checkout/scm/svn.py:
  489. (SVN):
  490. (SVN.in_working_directory):
  491. 2012-05-17 Dirk Pranke <dpranke@chromium.org>
  492. scm.add() doesn't work properly with svn 1.7
  493. https://bugs.webkit.org/show_bug.cgi?id=86779
  494. Reviewed by Ojan Vafai.
  495. The code relied on '.svn' directories being present
  496. in order to tell if a directory had already been added to the
  497. repository; this is no longer true in SVN 1.7.
  498. * Scripts/webkitpy/common/checkout/scm/scm.py:
  499. (SCM):
  500. (SCM.in_working_directory):
  501. * Scripts/webkitpy/common/checkout/scm/svn.py:
  502. (SVN):
  503. (SVN.in_working_directory):
  504. 2012-05-17 Jon Lee <jonlee@apple.com>
  505. Update Apple buildbots to prioritize latest changelists
  506. https://bugs.webkit.org/show_bug.cgi?id=86766
  507. Reviewed by Brady Eidson.
  508. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  509. (pickLatestBuild): Function to get the most pick the most recent build request.
  510. (loadBuilderConfig): Configure builders in the AppleMac and AppleWin categories to
  511. use the pickLatestBuild function when choosing which request to build next.
  512. 2012-05-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  513. [Qt] Fix MiniBrowser by using correct syntax for qrc URLs
  514. https://bugs.webkit.org/show_bug.cgi?id=86761
  515. Reviewed by Alexis Menard.
  516. * MiniBrowser/qt/BrowserWindow.cpp:
  517. (BrowserWindow::BrowserWindow):
  518. (BrowserWindow::updateVisualMockTouchPoints):
  519. 2012-05-17 Thiago Marcos P. Santos <thiago.santos@intel.com>
  520. [EFL] Add API for Web Database handling
  521. https://bugs.webkit.org/show_bug.cgi?id=85178
  522. Reviewed by Antonio Gomes.
  523. Use the newly introduced Web Database API in EFL's DRT.
  524. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  525. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  526. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  527. (LayoutTestController::clearAllDatabases):
  528. 2012-05-17 Dan Bernstein <mitz@apple.com>
  529. REGRESSION (r117428): WebKit API/SPI was removed
  530. https://bugs.webkit.org/show_bug.cgi?id=86748
  531. Reverted r117428.
  532. * DumpRenderTree/LayoutTestController.cpp:
  533. (setDomainRelaxationForbiddenForURLSchemeCallback):
  534. (LayoutTestController::staticFunctions):
  535. * DumpRenderTree/LayoutTestController.h:
  536. (LayoutTestController):
  537. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  538. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  539. * DumpRenderTree/chromium/LayoutTestController.cpp:
  540. (LayoutTestController::LayoutTestController):
  541. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  542. * DumpRenderTree/chromium/LayoutTestController.h:
  543. (LayoutTestController):
  544. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  545. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  546. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  547. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  548. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  549. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  550. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  551. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  552. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  553. (LayoutTestController):
  554. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  555. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  556. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  557. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  558. 2012-05-17 Li Yin <li.yin@intel.com>
  559. [chromium] run-webkit-tests can't work on ubuntu 12.04
  560. https://bugs.webkit.org/show_bug.cgi?id=86565
  561. Reviewed by Kent Tamura.
  562. On ubuntu 12.04, the package ttf-thai-tlwg install the Garuda.ttf
  563. into /usr/share/fonts/truetype/tlwg/Garuda.ttf, not /usr/share/fonts/truetype/thai/Garuda.ttf
  564. * DumpRenderTree/chromium/TestShellLinux.cpp:
  565. (checkAndLoadFontFile):
  566. (setupFontconfig):
  567. 2012-05-17 Elliot Poger <epoger@chromium.org>
  568. Add setting of additional_expectations option to
  569. chromium_unittest.test_overrides_and_builder_names(),
  570. so we can test order in which the base and chromium expectations files
  571. are combined.
  572. https://bugs.webkit.org/show_bug.cgi?id=86642
  573. Reviewed by Dirk Pranke.
  574. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  575. (ChromiumPortTest.test_overrides_and_builder_names):
  576. 2012-05-17 Balazs Kelemen <kbalazs@webkit.org>
  577. [Qt] Web process hangs while waiting for plugin process connection during layouttests
  578. https://bugs.webkit.org/show_bug.cgi?id=86620
  579. Reviewed by Csaba Osztrogonác.
  580. Reenable TestNetscapePlugin with Qt 4.
  581. * Tools.pro:
  582. 2012-05-17 Hugo Parente Lima <hugo.lima@openbossa.org>
  583. [Qt][WK2] fast/events/page-visibility-* tests fail
  584. https://bugs.webkit.org/show_bug.cgi?id=83263
  585. Reviewed by Kenneth Rohde Christiansen.
  586. Handle "preview" state and avoid string conversion.
  587. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  588. (WTR::LayoutTestController::setPageVisibility):
  589. 2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  590. Convert setDomainRelaxationForbiddenForURLScheme to use InternalSettings interface
  591. https://bugs.webkit.org/show_bug.cgi?id=86704
  592. Reviewed by Eric Seidel.
  593. Remove setDomainRelaxationForbiddenForURLScheme functions, because it is able to work in the
  594. cross-port way through the InternalSettings interface.
  595. * DumpRenderTree/LayoutTestController.cpp:
  596. (LayoutTestController::staticFunctions):
  597. * DumpRenderTree/LayoutTestController.h:
  598. (LayoutTestController):
  599. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  600. * DumpRenderTree/chromium/LayoutTestController.cpp:
  601. (LayoutTestController::LayoutTestController):
  602. * DumpRenderTree/chromium/LayoutTestController.h:
  603. (LayoutTestController):
  604. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  605. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  606. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  607. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  608. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  609. (LayoutTestController):
  610. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  611. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  612. 2012-05-17 Mariusz Grzegorczyk <mariusz.g@samsung.com>
  613. [EFL] [DRT] EFL's DumpRenderTree should support LayoutTestController's dumpEditingCallbacks()
  614. https://bugs.webkit.org/show_bug.cgi?id=84835
  615. Reviewed by Eric Seidel.
  616. Added editing callbacks implementation.
  617. * DumpRenderTree/efl/CMakeLists.txt: Add EditingCallbacks.cpp to compilation.
  618. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Invoke connectEditingCallbacks.
  619. (DumpRenderTreeChrome::createView):
  620. * DumpRenderTree/efl/EditingCallbacks.cpp: Added. Dump editing callbacks.
  621. (dumpPath):
  622. (dumpRange):
  623. (insertActionString):
  624. (selectionAffinityString):
  625. (shouldBeginEditing):
  626. (shouldEndEditing):
  627. (shouldInsertNode):
  628. (shouldInsertText):
  629. (shouldDeleteRange):
  630. (shouldChangeSelectedRange):
  631. (shouldApplyStyle):
  632. (editingBegan):
  633. (userChangedContents):
  634. (editingEnded):
  635. (selectionChanged):
  636. (connectEditingCallbacks):
  637. * DumpRenderTree/efl/EditingCallbacks.h: Added.
  638. 2012-05-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  639. Unreviewed. Roll out r117382 because of layout test crashes on EFL debug buildbot.
  640. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  641. (DumpRenderTreeChrome::initialize):
  642. 2012-05-17 Kentaro Hara <haraken@chromium.org>
  643. [Performance test] In perftest.py, do not include 'description' in 'results'
  644. https://bugs.webkit.org/show_bug.cgi?id=86696
  645. Reviewed by Csaba Osztrogoná.
  646. 'results' in perftest.py should not include any data that is not expected
  647. by the perf bot server. We do not need to send 'description' to the perf bot
  648. server since 'description' is always the same.
  649. Thus this patch just removes 'description' from 'results'.
  650. * Scripts/webkitpy/performance_tests/perftest.py:
  651. (PerfTest.parse_output):
  652. (PerfTest.output_statistics):
  653. (ChromiumStylePerfTest.parse_output):
  654. (PageLoadingPerfTest.run):
  655. 2012-05-17 Kentaro Hara <haraken@chromium.org>
  656. [Performance test] Always fill results['description'] in perftest.py
  657. https://bugs.webkit.org/show_bug.cgi?id=86696
  658. Reviewed by Ryosuke Niwa.
  659. This is a follow-up patch for r117397 to fix perf bot failures.
  660. This patch fills results['description'] always.
  661. * Scripts/webkitpy/performance_tests/perftest.py:
  662. (PageLoadingPerfTest.run):
  663. 2012-05-16 Kentaro Hara <haraken@chromium.org>
  664. [Performance test] Support "description" for PerfTestRunner.run and PerfTestRunner.runPerSecond
  665. https://bugs.webkit.org/show_bug.cgi?id=86696
  666. Reviewed by Ryosuke Niwa.
  667. We want to add some description for each PerfTestRunner.run and
  668. PerfTestRunner.runPerSecond, so that people can know what each
  669. run is testing.
  670. Output example:
  671. $ ./Tools/Scripts/run-perf-tests Bindings/first-child.html
  672. Running Bindings/first-child.html (1 of 1)
  673. DESCRIPTION: Benchmark for DOM attributes that return a Node object.
  674. RESULT Bindings: first-child= 788.359076534 runs/s
  675. median= 797.508097751 runs/s, stdev= 19.0972905207 runs/s, min= 746.666666667 runs/s, max= 801.001251564 runs/s
  676. * Scripts/webkitpy/performance_tests/perftest.py:
  677. (PerfTest):
  678. (PerfTest.parse_output):
  679. (PerfTest.output_statistics):
  680. 2012-05-16 Christophe Dumez <christophe.dumez@intel.com>
  681. [EFL] appcache tests are flaky
  682. https://bugs.webkit.org/show_bug.cgi?id=86619
  683. Reviewed by Gustavo Noronha Silva.
  684. Correctly set the application cache database path in EFL's
  685. DumpRenderTree initialization code.
  686. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  687. (DumpRenderTreeChrome::initialize):
  688. 2012-05-16 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  689. Add new build slave for EFL port.
  690. https://bugs.webkit.org/show_bug.cgi?id=86567
  691. Reviewed by Ryosuke Niwa.
  692. Add a build slave for EFL 32-bit linux build.
  693. * BuildSlaveSupport/build.webkit.org-config/config.json:
  694. 2012-05-16 Kihong Kwon <kihong.kwon@samsung.com>
  695. [EFL] Support for Battery Status API on the WebKit-Efl
  696. https://bugs.webkit.org/show_bug.cgi?id=83254
  697. Reviewed by Chang Shu.
  698. Add e_dbus libraries to jhbuild's modules list.
  699. * efl/jhbuild.modules:
  700. 2012-05-16 Christophe Dumez <christophe.dumez@intel.com>
  701. [EFL] Rounding errors on 32-bit machines causes tests to fail
  702. https://bugs.webkit.org/show_bug.cgi?id=86194
  703. Reviewed by Martin Robinson.
  704. Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
  705. point values between 32-bit and 64-bit architectures.
  706. Same flags are already used by Qt and GTK ports.
  707. * Scripts/webkitdirs.pm:
  708. (determineArchitecture):
  709. (generateBuildSystemFromCMakeProject):
  710. 2012-05-16 Balazs Kelemen <kbalazs@webkit.org>
  711. [Qt] Web process hangs while waiting for plugin process connection during layouttests
  712. https://bugs.webkit.org/show_bug.cgi?id=86620
  713. Reviewed by Csaba Osztrogonác.
  714. Temporary workaround not to fail layout tests.
  715. * Tools.pro: Disable TestNetscapePlugin.
  716. 2012-05-16 Dinu Jacob <dinu.jacob@nokia.com>
  717. Add didFinishProgress BundleUIClient callback
  718. https://bugs.webkit.org/show_bug.cgi?id=86541
  719. Reviewed by Kenneth Rohde Christiansen.
  720. Added support for dumpProgressFinishedCallback.
  721. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  722. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  723. (WTR::InjectedBundlePage::InjectedBundlePage):
  724. (WTR::InjectedBundlePage::didFinishProgress):
  725. (WTR):
  726. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  727. (InjectedBundlePage):
  728. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  729. (WTR::LayoutTestController::LayoutTestController):
  730. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  731. (WTR::LayoutTestController::dumpProgressFinishedCallback):
  732. (WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
  733. (WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
  734. (LayoutTestController):
  735. 2012-05-15 Pierre Rossi <pierre.rossi@gmail.com>
  736. [Qt] Enable SVG Fonts by default
  737. https://bugs.webkit.org/show_bug.cgi?id=86463
  738. Reviewed by Nikolas Zimmermann.
  739. * qmake/mkspecs/features/features.pri:
  740. 2012-05-16 Christophe Dumez <christophe.dumez@intel.com>
  741. [EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
  742. https://bugs.webkit.org/show_bug.cgi?id=85585
  743. Reviewed by Gustavo Noronha Silva.
  744. Implement setApplicationCacheOriginQuota in EFL's
  745. LayoutTestController.
  746. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  747. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  748. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  749. (onExceededApplicationCacheQuota):
  750. (drtViewAdd):
  751. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  752. (LayoutTestController::setApplicationCacheOriginQuota):
  753. 2012-05-16 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  754. [EFL] EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation
  755. https://bugs.webkit.org/show_bug.cgi?id=83776
  756. Reviewed by Tor Arne Vestbø.
  757. Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().
  758. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  759. (LayoutTestController::evaluateScriptInIsolatedWorld):
  760. 2012-05-16 Grzegorz Czajkowski <g.czajkowski@samsung.com>
  761. Unreviewed. Add myself as a committer.
  762. * Scripts/webkitpy/common/config/committers.py:
  763. 2012-05-15 Kangil Han <kangil.han@samsung.com>
  764. [EFL][DRT] Fix eventSender key providing
  765. https://bugs.webkit.org/show_bug.cgi?id=84710
  766. Reviewed by Andreas Kling.
  767. Currently eventSender doesn't provide key event correctly.
  768. For example, 'Right' will be visible when 'right arrow' key event is fired.
  769. Given circumstance, nothing has to be shown.
  770. Therefore, this patch fixed incorrectly provided key event.
  771. * DumpRenderTree/efl/EventSender.cpp:
  772. (KeyEventInfo::KeyEventInfo):
  773. (KeyEventInfo):
  774. (keyPadNameFromJSValue):
  775. (keyNameFromJSValue):
  776. (createKeyEventInfo):
  777. (sendKeyDown):
  778. 2012-05-15 Dan Bernstein <mitz@apple.com>
  779. Fixed a typo.
  780. * Scripts/copy-webkitlibraries-to-product-directory:
  781. 2012-05-15 Kihong Kwon <kihong.kwon@samsung.com>
  782. [EFL] Enable Fullscreen API
  783. https://bugs.webkit.org/show_bug.cgi?id=85870
  784. Reviewed by Antonio Gomes.
  785. Enable full screen api feature on the EFL port.
  786. There are two failed test cases under LayoutTests/fullscreen.
  787. They are going to be fixed with other patch.
  788. * Scripts/webkitperl/FeatureList.pm:
  789. 2012-05-15 James Robinson <jamesr@chromium.org>
  790. [chromium] Chromium port never sets USE(CG) so code behind it is dead
  791. https://bugs.webkit.org/show_bug.cgi?id=86537
  792. Reviewed by Adrienne Walker.
  793. Deletes code behind USE(CG) in chromium-specific code and removes unneeded USE(SKIA) guards.
  794. * DumpRenderTree/chromium/WebViewHost.cpp:
  795. (WebViewHost::paintRect):
  796. 2012-05-15 James Robinson <jamesr@chromium.org>
  797. [chromium] Remove WEBKIT_USING_(SKIA|CG) #defines
  798. https://bugs.webkit.org/show_bug.cgi?id=86536
  799. Reviewed by Adam Barth.
  800. Deletes dead WEBKIT_USING_CG code and #ifdefs guarding it.
  801. * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  802. (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
  803. (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
  804. * DumpRenderTree/chromium/WebViewHost.cpp:
  805. (WebViewHost::paintPagesWithBoundaries):
  806. 2012-05-15 James Robinson <jamesr@chromium.org>
  807. [chromium] Unreviewed build fix.
  808. Partial revert of r117166 - it appears making DumpRenderTree depend on webkit_platform causes crashes in the
  809. component build, at least on linux. This restores Tools/DumpRenderTree to its pre-r117166 state.
  810. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  811. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  812. (TestWebPlugin::initialize):
  813. 2012-05-15 Elliot Poger <epoger@google.com>
  814. add unit test for NRWT's --additional-expectations option
  815. https://bugs.webkit.org/show_bug.cgi?id=86501
  816. Reviewed by Ojan Vafai.
  817. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  818. (PortTest.test_additional_expectations):
  819. 2012-05-15 James Robinson <jamesr@chromium.org>
  820. [chromium] Move createOffscreenGraphicsContext3D() from WebKitPlatformSupport to Platform
  821. https://bugs.webkit.org/show_bug.cgi?id=86524
  822. Reviewed by Adam Barth.
  823. Updates TestWebPlugin to use the Platform headers and updates the build dependencies so it can.
  824. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  825. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  826. (TestWebPlugin::initialize):
  827. 2012-05-15 Jessie Berlin <jberlin@apple.com>
  828. WKContextSetCacheModel(contextref, kWKCacheModelDocumentViewer) doesn't prevent pages from
  829. going into the PageCache.
  830. https://bugs.webkit.org/show_bug.cgi?id=85891
  831. Reviewed by Brady Eidson.
  832. Set the cache model in DOMWindowExtensionNoCache so that the page cache is not used. This is
  833. better than using pages with unload handlers because we may find a way to make pages with
  834. unload handlers cacheable in the future.
  835. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  836. Remove simple-iframe-unload.html and simple-unload.html, since they are no longer used.
  837. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp:
  838. (TestWebKitAPI::TEST):
  839. Set the cache model to kWKCacheModelDocumentViewer.
  840. * TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Removed.
  841. * TestWebKitAPI/Tests/WebKit2/simple-unload.html: Removed.
  842. 2012-05-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
  843. [Qt] Add infra for testing double-tap to zoom functionality etc
  844. https://bugs.webkit.org/show_bug.cgi?id=86474
  845. Reviewed by Simon Hausmann.
  846. The WebViewportInfo class was renamed to QWebKitTest in preparation
  847. of becoming a separate module. Adapt the use API.
  848. * MiniBrowser/qt/qml/BrowserWindow.qml:
  849. * MiniBrowser/qt/qml/ViewportInfoItem.qml:
  850. 2012-05-15 Csaba Osztrogonác <ossy@webkit.org>
  851. Introduce ENABLE_CSS_VARIABLES compile flag.
  852. https://bugs.webkit.org/show_bug.cgi?id=86338
  853. Reviewed by Hajime Morita.
  854. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Unittest fix after r117028.
  855. (WebKitPortTest.test_skipped_directories_for_symbols):
  856. 2012-05-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  857. Teach webkit-patch to gracefully handle writes of raw utf-8 encoded strings to sys.stdout
  858. https://bugs.webkit.org/show_bug.cgi?id=85809
  859. webkit-patch overrides sys.stdout with a StreamWriter that ensures we write utf8
  860. output to stdout, but StreamWriter will by default always encode the object that's
  861. passed to write(). This blows up when the object is a raw string, already encoded
  862. as utf8, and does not match the default behavior of sys.stdout.
  863. To solve this in one place, instead of every single call-site that might write
  864. raw strings, we extend the stdout-wrapper to assume raw strings are utf8 before
  865. passing them on to StreamWriter.write(). This has the benefit of also making the
  866. stacktrace easy to read in the case where this assumption does not hold.
  867. The source of this particular bug was that Executive.run_and_throw_if_fail() will
  868. tee the output of the subprocess, and in the case of running prepare-ChangeLog this
  869. might produce non-ascii output, which gets written directly to sys.stdout as raw
  870. utf8-encoded strings.
  871. Reviewed by Dirk Pranke.
  872. * Scripts/webkit-patch:
  873. 2012-05-15 Tomasz Morawski <t.morawski@samsung.com>
  874. [EFL][DRT] Split ewk_private.h file to multiple private files.
  875. https://bugs.webkit.org/show_bug.cgi?id=84572
  876. Reviewed by Antonio Gomes.
  877. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  878. 2012-05-15 Michael Brüning <michael.bruning@nokia.com>
  879. [Qt][WK2] http/tests/navigation/https-in-page-cache.html fails with timeout
  880. https://bugs.webkit.org/show_bug.cgi?id=83576
  881. Reviewed by Simon Hausmann.
  882. Set the PlatformWebView for the Qt port to accept all SSL certificates.
  883. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  884. (WTR::PlatformWebView::PlatformWebView):
  885. 2012-05-14 Luke Macpherson <macpherson@chromium.org>
  886. Introduce ENABLE_CSS_VARIABLES compile flag.
  887. https://bugs.webkit.org/show_bug.cgi?id=86338
  888. Reviewed by Dimitri Glazkov.
  889. Add a configuration option for CSS Variables support, disabling it by default.
  890. * Scripts/webkitperl/FeatureList.pm:
  891. * Scripts/webkitpy/layout_tests/port/webkit.py:
  892. (WebKitPort._missing_symbol_to_skipped_tests):
  893. * qmake/mkspecs/features/features.pri:
  894. 2012-05-14 Nate Chapin <japhet@chromium.org>
  895. Add end-of-life test cases for https://bugs.webkit.org/show_bug.cgi?id=86131.
  896. Reviewed by Adam Barth.
  897. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  898. (callDeletePlugin):
  899. (pluginHasProperty):
  900. (pluginHasMethod):
  901. (pluginGetProperty):
  902. (pluginSetProperty):
  903. (pluginInvoke):
  904. 2012-05-14 Dirk Pranke <dpranke@chromium.org>
  905. Re-enable "drt mode" on chromium-mac-leopard
  906. https://bugs.webkit.org/show_bug.cgi?id=83076
  907. Unreviewed, build fix (change?).
  908. This change is another attempt to gather data on
  909. the flakiness and timeouts we're seeing on Mac SL
  910. now that we have another bot.
  911. * Scripts/webkitpy/layout_tests/port/chromium.py:
  912. (ChromiumDriver.__init__):
  913. 2012-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
  914. Unreviewed, rolling out r116981.
  915. http://trac.webkit.org/changeset/116981
  916. https://bugs.webkit.org/show_bug.cgi?id=86402
  917. Caused compositing and mathml tests to fail. (Requested by
  918. rakuco on #webkit).
  919. * Scripts/webkitpy/layout_tests/port/efl.py:
  920. (EflPort._path_to_webcore_library):
  921. 2012-05-14 Dirk Pranke <dpranke@chromium.org>
  922. Fix regressions in garden-o-matic after r116988.
  923. Unreviewed, build fix.
  924. I had a typo in a field name in checkout.js, and unfortunately
  925. the unittests had the same typo :(.
  926. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  927. (.):
  928. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  929. 2012-05-14 Dirk Pranke <dpranke@chromium.org>
  930. garden-o-matic should specify which types of baselines to rebaseline
  931. https://bugs.webkit.org/show_bug.cgi?id=86242
  932. Reviewed by Adam Barth.
  933. This change modifies garden-o-matic so that we are explicit
  934. about whether to rebaseline the text file, the image file, or
  935. both. This should prevent us from pulling incorrect or
  936. unexpected baselines off the bots.
  937. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  938. (.):
  939. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  940. (.):
  941. * Scripts/webkitpy/tool/commands/rebaseline.py:
  942. (AbstractRebaseliningCommand):
  943. (AbstractRebaseliningCommand.__init__):
  944. (RebaselineTest):
  945. (RebaselineTest._rebaseline_test_and_update_expectations):
  946. (RebaselineTest.execute):
  947. (OptimizeBaselines):
  948. (OptimizeBaselines._optimize_baseline):
  949. (OptimizeBaselines.execute):
  950. (AnalyzeBaselines):
  951. (AnalyzeBaselines._analyze_baseline):
  952. (AnalyzeBaselines.execute):
  953. (RebaselineExpectations._rebaseline_port):
  954. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  955. (GardeningHTTPRequestHandler.rebaseline):
  956. (GardeningHTTPRequestHandler.optimizebaselines):
  957. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  958. (GardeningServerTest.test_rebaseline):
  959. (GardeningServerTest.test_rebaseline_new_port):
  960. (GardeningServerTest.test_optimizebaselines):
  961. 2012-05-14 Kangil Han <kangil.han@samsung.com>
  962. [EFL][DRT] Fix WebCore library path
  963. https://bugs.webkit.org/show_bug.cgi?id=86355
  964. Reviewed by Dirk Pranke.
  965. Currently EFL DRT uses wrong WebCore library path when running DRT.
  966. This patch simply adjusted it.
  967. * Scripts/webkitpy/layout_tests/port/efl.py:
  968. (EflPort._path_to_webcore_library):
  969. 2012-05-14 Wei James <james.wei@intel.com>
  970. [Chromium] ImageDiff should be build for host on Android
  971. https://bugs.webkit.org/show_bug.cgi?id=82039
  972. Reviewed by Adam Barth.
  973. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  974. 2012-05-14 Joone Hur <joone@webkit.org>
  975. Unreviewed. Updating email for committers.py script.
  976. * Scripts/webkitpy/common/config/committers.py:
  977. 2012-05-14 Carlos Garcia Campos <cgarcia@igalia.com>
  978. Unreviewed. Fix make distcheck.
  979. * GNUmakefile.am: Add run-api-tests script to EXTRA_DIST.
  980. * gtk/run-api-tests:
  981. (TestRunner._lookup_atspi2_binary): Handle the case when
  982. pkg_config_file_variable() return None.
  983. 2012-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
  984. Unreviewed, rolling out r116935.
  985. http://trac.webkit.org/changeset/116935
  986. https://bugs.webkit.org/show_bug.cgi?id=86373
  987. Something is still broken (Requested by Ossy on #webkit).
  988. * Scripts/webkitpy/common/checksvnconfigfile.py: Removed.
  989. * Scripts/webkitpy/style/checkers/png.py:
  990. (PNGChecker.check):
  991. (PNGChecker):
  992. (PNGChecker._config_file_path):
  993. * Scripts/webkitpy/tool/commands/download.py:
  994. (Land):
  995. * Scripts/webkitpy/tool/steps/__init__.py:
  996. * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Removed.
  997. * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Removed.
  998. 2012-05-14 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  999. [Qt] Doesn't build with ENABLE_INSPECTOR=0
  1000. https://bugs.webkit.org/show_bug.cgi?id=85056
  1001. Reviewed by Tor Arne Vestbø.
  1002. * WebKitTestRunner/TestInvocation.cpp: Ifdef otherwise unused static function.
  1003. * qmake/mkspecs/features/features.prf:
  1004. * qmake/mkspecs/features/features.pri:
  1005. 2012-05-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1006. [Qt] Make sure dialogs have their parent and attached properties set before Component.onCompleted
  1007. https://bugs.webkit.org/show_bug.cgi?id=86222
  1008. The WebView QML api for dialogs is based on delegates for each dialog, which
  1009. are implemented as components. Since there's no explicit API to show the dialog,
  1010. the natural place to allow the dialog to choose how to display itself is in
  1011. Component.onCompleted.
  1012. The issue was that we were using QQmlComponent::create() when instantiating the
  1013. component, at which point the component did not have a parent or it's attached
  1014. WebView property set. That meant that we had to do some ugly workaround in our
  1015. test, using a 1ms timer, to get a callback once the parent was there.
  1016. We now use the QQmlComponent::beginCreate() -> QQmlComponent::completeCreate()
  1017. pair, which allows us to set the relevant properties before triggering the
  1018. Component.onCompleted callback. We were already doing this for the context
  1019. menus (except for setting the parent, which we did afterwards).
  1020. Reviewed by Simon Hausmann.
  1021. * MiniBrowser/qt/qml/BrowserWindow.qml:
  1022. * MiniBrowser/qt/qml/Dialog.qml:
  1023. 2012-05-14 Balazs Ankes <bank@inf.u-szeged.hu>
  1024. webkit-patch land should automatically add svn:mime-type for .png files
  1025. https://bugs.webkit.org/show_bug.cgi?id=75825
  1026. I refactored the png.py to avoid code duplication.
  1027. Reviewed by Dirk Pranke.
  1028. * Scripts/webkitpy/common/checksvnconfigfile.py: Added.
  1029. (check):
  1030. (_config_file_path):
  1031. (errorstr_autoprop):
  1032. (errorstr_png):
  1033. * Scripts/webkitpy/style/checkers/png.py:
  1034. (PNGChecker.check):
  1035. * Scripts/webkitpy/tool/commands/download.py:
  1036. (Land):
  1037. * Scripts/webkitpy/tool/steps/__init__.py:
  1038. * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng.py: Added.
  1039. (AddSvnMimetypeForPng):
  1040. (AddSvnMimetypeForPng.__init__):
  1041. (AddSvnMimetypeForPng.run):
  1042. (AddSvnMimetypeForPng._check_pngs):
  1043. * Scripts/webkitpy/tool/steps/addsvnmimetypeforpng_unittest.py: Added.
  1044. (MockSCMDetector):
  1045. (MockSCMDetector.__init__):
  1046. (MockSCMDetector.display_name):
  1047. (AddSvnMimetypeForPngTest):
  1048. (AddSvnMimetypeForPngTest.test_run):
  1049. 2012-05-14 David Kilzer <ddkilzer@apple.com>
  1050. webkit-patch apply-attachment is very slow for big patches
  1051. https://bugs.webkit.org/show_bug.cgi?id=74929
  1052. Add "excludefield=attachmentdata" to the URL everywhere
  1053. "ctype=xml" is used to exclude this field from the XML.
  1054. Reviewed by Adam Barth.
  1055. * Scripts/prepare-ChangeLog:
  1056. (fetchBugDescriptionFromURL):
  1057. * Scripts/webkitpy/common/config/urls.py:
  1058. * Scripts/webkitpy/common/config/urls_unittest.py:
  1059. (URLsTest.test_parse_bug_id):
  1060. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  1061. (Bugzilla.bug_url_for_bug_id):
  1062. 2012-05-13 Ryosuke Niwa <rniwa@webkit.org>
  1063. performance tests should be able to measure runs/sec rather than time
  1064. https://bugs.webkit.org/show_bug.cgi?id=86021
  1065. Reviewed by Ojan Vafai.
  1066. Allow " runs/s" or " ms" to appear after numerical values in tests.
  1067. * Scripts/webkitpy/performance_tests/perftest.py:
  1068. (PerfTest):
  1069. 2012-05-12 Tim Horton <timothy_horton@apple.com>
  1070. run-safari and co. should support --guard-malloc command line argument
  1071. https://bugs.webkit.org/show_bug.cgi?id=86287
  1072. Reviewed by Dan Bernstein.
  1073. Add setUpGuardMallocIfNeeded(), which consults the argument --guard-malloc on OS X,
  1074. setting DYLD_INSERT_LIBRARIES="/usr/lib/libgmalloc.dylib" if it's enabled.
  1075. Use setUpGuardMallocIfNeeded() before running a WebKit app (whether standalone or
  1076. in the debugger). This will cause gmalloc to be loaded for gdb as well, but this
  1077. tends to be harmless.
  1078. Change "malloc guard" to the more common "Guard Malloc" in run-webkit-tests.
  1079. * Scripts/old-run-webkit-tests:
  1080. * Scripts/webkitdirs.pm:
  1081. (appendToEnvironmentVariableList):
  1082. (setUpGuardMallocIfNeeded):
  1083. (printHelpAndExitForRunAndDebugWebKitAppIfNeeded):
  1084. (runMacWebKitApp):
  1085. (execMacWebKitAppForDebugging):
  1086. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  1087. (parse_args):
  1088. 2012-05-11 Ojan Vafai <ojan@chromium.org>
  1089. Add previous/next buttons the garden-o-matics perf panel
  1090. https://bugs.webkit.org/show_bug.cgi?id=86280
  1091. Reviewed by Dimitri Glazkov.
  1092. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js:
  1093. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js:
  1094. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css:
  1095. 2012-05-11 Kevin Ollivier <kevino@theolliviers.com>
  1096. [wx] Unreviewed build fix. Fix memory exhausted errors from 32-bit ld on *nix.
  1097. * waf/build/settings.py:
  1098. (common_configure):
  1099. 2012-05-11 Dirk Pranke <dpranke@chromium.org>
  1100. webkit-patch rebaseline should fetch stale expectations :)
  1101. https://bugs.webkit.org/show_bug.cgi?id=86231
  1102. Unreviewed, build fix.
  1103. This change reverts r115492 and goes back to fetching individual
  1104. baselines from the layout tests directory, rather than fetching
  1105. entire zip files. The performance hit over networks for people
  1106. far away from the bots has turned out to be severe, so we need a
  1107. better solution to this.
  1108. * Scripts/webkitpy/tool/commands/rebaseline.py:
  1109. (RebaselineTest._results_url):
  1110. (RebaselineTest._file_name_for_expected_result):
  1111. (RebaselineTest._rebaseline_test):
  1112. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  1113. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  1114. (test_rebaseline_updates_expectations_file):
  1115. (test_rebaseline_test):
  1116. (test_rebaseline_and_copy_test):
  1117. (test_rebaseline_and_copy_test_no_existing_result):
  1118. (test_rebaseline_and_copy_test_with_lion_result):
  1119. (test_rebaseline_and_copy_no_overwrite_test):
  1120. 2012-05-11 Christophe Dumez <christophe.dumez@intel.com>
  1121. [GTK] LayoutTests/svg/batik/text/verticalText.svg fails to display Chinese characters
  1122. https://bugs.webkit.org/show_bug.cgi?id=86198
  1123. Reviewed by Martin Robinson.
  1124. Update webkitgtk-fonts package to v0.0.3 in order to get new Kochi
  1125. Mincho / Gothic fonts to display Japanese and Chinese characters.
  1126. * gtk/jhbuild.modules:
  1127. 2012-05-11 Christophe Dumez <christophe.dumez@intel.com>
  1128. [EFL][DRT] SVG Batik test fails to display Chinese characters
  1129. https://bugs.webkit.org/show_bug.cgi?id=84461
  1130. Reviewed by Martin Robinson.
  1131. Update webkitgtk-fonts package from v0.0.1 to v0.0.3 in order to get
  1132. new Kochi Mincho / Gothic fonts to display Japanese and Chinese
  1133. characters.
  1134. * DumpRenderTree/efl/CMakeLists.txt:
  1135. * efl/jhbuild.modules:
  1136. 2012-05-11 Philippe Normand <pnormand@igalia.com>
  1137. Unreviewed, GTK 64-bit Debug bot fix attempt.
  1138. * Scripts/webkitpy/layout_tests/port/gtk.py:
  1139. (GtkPort._get_gdb_output): Ignore unicode decoding errors when
  1140. processing gdb output.
  1141. 2012-05-11 Gustavo Noronha Silva <gns@gnome.org>
  1142. REGRESSION(r116205): [GTK]: build no longer supports thin archives
  1143. https://bugs.webkit.org/show_bug.cgi?id=86207
  1144. * GNUmakefile.am: link libWebCoreModules to DRT.
  1145. 2012-05-10 Ojan Vafai <ojan@chromium.org>
  1146. Add a perf tab to garden-o-matic
  1147. https://bugs.webkit.org/show_bug.cgi?id=86169
  1148. Reviewed by Dimitri Glazkov.
  1149. This is a first stab at making it easier to view the Chromium WebKit canary
  1150. perf graphs. For now, it's just a couple select elements and an iframe.
  1151. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  1152. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  1153. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  1154. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  1155. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  1156. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  1157. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf.js: Added.
  1158. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/perf_unittests.js: Added.
  1159. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  1160. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/perf.css: Added.
  1161. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  1162. 2012-05-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  1163. Move resumeAnimations to use Internals interface
  1164. https://bugs.webkit.org/show_bug.cgi?id=86063
  1165. Reviewed by Alexey Proskuryakov.
  1166. Remove resumeAnimations functions, because it is able to work in the
  1167. cross-port way through the Internals interface.
  1168. * DumpRenderTree/LayoutTestController.cpp:
  1169. (LayoutTestController::staticFunctions):
  1170. * DumpRenderTree/LayoutTestController.h:
  1171. (LayoutTestController):
  1172. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  1173. * DumpRenderTree/chromium/LayoutTestController.cpp:
  1174. (LayoutTestController::LayoutTestController):
  1175. * DumpRenderTree/chromium/LayoutTestController.h:
  1176. (LayoutTestController):
  1177. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  1178. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  1179. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  1180. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  1181. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  1182. (LayoutTestController):
  1183. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  1184. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  1185. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  1186. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  1187. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  1188. (LayoutTestController):
  1189. 2012-05-10 Alexey Proskuryakov <ap@apple.com>
  1190. Crash in 3rd party WebKit apps that disable cache at a wrong time
  1191. https://bugs.webkit.org/show_bug.cgi?id=86027
  1192. <rdar://problem/10615880>
  1193. Reviewed by Antti Koivisto.
  1194. Added a test that's very similar to MemoryCachePruneWithinResourceLoadDelegate,
  1195. but for disabling the cache instead of triggering a prune.
  1196. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  1197. * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.html: Added.
  1198. * TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm: Added.
  1199. (-[MemoryCacheDisableTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
  1200. (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  1201. (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
  1202. (-[MemoryCacheDisableTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
  1203. (TestWebKitAPI::TEST):
  1204. 2012-05-10 Anders Carlsson <andersca@apple.com>
  1205. WebKit2: Add a way to blacklist specific plug-ins/plug-in versions
  1206. https://bugs.webkit.org/show_bug.cgi?id=86164
  1207. <rdar://problem/9551196>
  1208. Reviewed by Sam Weinig.
  1209. Update for WK2 API changes.
  1210. * MiniBrowser/mac/BrowserWindowController.m:
  1211. (-[BrowserWindowController awakeFromNib]):
  1212. * WebKitTestRunner/TestController.cpp:
  1213. (WTR::TestController::createOtherPage):
  1214. (WTR::TestController::initialize):
  1215. 2012-05-10 Dirk Pranke <dpranke@chromium.org>
  1216. nrwt: [chromium] fix path to asan symbolize script
  1217. https://bugs.webkit.org/show_bug.cgi?id=86161
  1218. Reviewed by Abhishek Arya.
  1219. * Scripts/webkitpy/layout_tests/port/chromium.py:
  1220. (ChromiumPort._get_crash_log):
  1221. 2012-05-10 Lei Zhang <thestig@chromium.org>
  1222. [chromium] Set Valgrind environment variables for layout tests.
  1223. https://bugs.webkit.org/show_bug.cgi?id=86156
  1224. Reviewed by Dirk Pranke.
  1225. * Scripts/webkitpy/layout_tests/port/chromium.py:
  1226. (ChromiumPort.setup_environ_for_server):
  1227. 2012-05-10 Raphael Kubo da Costa <rakuco@webkit.org>
  1228. [webkitpy][EFL] It should be possible to use a wrapper command for ImageDiff.
  1229. https://bugs.webkit.org/show_bug.cgi?id=86145
  1230. Reviewed by Dirk Pranke.
  1231. The GTK+ and EFL ports use jhbuild to build a few base libraries
  1232. which are then used when building the port itself. Programs such
  1233. as DRT and ImageDiff are then supposed to be run with the
  1234. `run-with-jhbuild' wrapper so that the libraries are properly
  1235. found and loaded.
  1236. This was already the case for DumpRenderTree (EflPort defines the
  1237. 'wrapper' option for that), but it was not possible to do the same
  1238. with ImageDiff so far.
  1239. The code which created the ImageDiff command-line call has been
  1240. moved to a separate method, _image_diff_command, which is then
  1241. overridden by EflPort to add the jhbuild wrapper.
  1242. * Scripts/webkitpy/layout_tests/port/efl.py:
  1243. (EflPort.__init__):
  1244. (EflPort._image_diff_command):
  1245. * Scripts/webkitpy/layout_tests/port/webkit.py:
  1246. (WebKitPort):
  1247. (WebKitPort._image_diff_command):
  1248. (WebKitPort._start_image_diff_process):
  1249. 2012-05-10 Zan Dobersek <zandobersek@gmail.com>
  1250. [GTK] ENABLE_IFRAME_SEAMLESS support
  1251. https://bugs.webkit.org/show_bug.cgi?id=85843
  1252. Reviewed by Eric Seidel.
  1253. Add the iframe-seamless option to the options list. This makes it
  1254. possible to enable the iframe seamless support through build-webkit
  1255. script. Enabled by default for all the ports.
  1256. * Scripts/webkitperl/FeatureList.pm:
  1257. 2012-05-10 Raphael Kubo da Costa <rakuco@webkit.org>
  1258. [EFL][webkitpy] Do not redefine check_build() in EflPort.
  1259. https://bugs.webkit.org/show_bug.cgi?id=86124
  1260. Reviewed by Dirk Pranke.
  1261. Remove an old FIXME and do not redefine check_build in EflPort;
  1262. once build-dumprendertree recognizes --efl, we can use the
  1263. check_build implementation in WebKitPort.
  1264. * Scripts/build-dumprendertree:
  1265. * Scripts/webkitpy/layout_tests/port/efl.py:
  1266. (EflPort.check_build):
  1267. 2012-05-10 Tommy Widenflycht <tommyw@google.com>
  1268. [chromium] MediaStream API: Fix the ExtraData functionality in WebMediaStreamDescriptor
  1269. https://bugs.webkit.org/show_bug.cgi?id=86087
  1270. Reviewed by Adam Barth.
  1271. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  1272. (MockExtraData):
  1273. (WebKit):
  1274. (WebKit::WebUserMediaClientMock::requestUserMedia):
  1275. 2012-05-10 Varun Jain <varunjain@google.com>
  1276. [chromium] Trigger context menu for long press gesture
  1277. https://bugs.webkit.org/show_bug.cgi?id=85919
  1278. Reviewed by Adam Barth.
  1279. * DumpRenderTree/chromium/EventSender.cpp:
  1280. (EventSender::EventSender):
  1281. (EventSender::gestureLongPress):
  1282. (EventSender::gestureEvent):
  1283. * DumpRenderTree/chromium/EventSender.h:
  1284. (EventSender):
  1285. 2012-05-10 Takashi Toyoshima <toyoshim@chromium.org>
  1286. don't use autoinstall to import pywebsocket but check it in WebKit directly.
  1287. https://bugs.webkit.org/show_bug.cgi?id=86107
  1288. Reviewed by Adam Barth.
  1289. This change removes pywebsocket from webkitpy's autoinstall list and
  1290. imports pywebsocket 0.7.4 directly into webkitpy/thirparty.
  1291. * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  1292. (PyWebSocket._prepare_config):
  1293. * Scripts/webkitpy/thirdparty/__init__.py:
  1294. (AutoinstallImportHook.find_module):
  1295. (AutoinstallImportHook._install_irc):
  1296. * Scripts/webkitpy/thirdparty/__init___unittest.py:
  1297. (ThirdpartyTest.test_import_hook.MockImportHook.__init__):
  1298. (ThirdpartyTest.test_import_hook.MockImportHook._install_eliza):
  1299. (ThirdpartyTest):
  1300. (ThirdpartyTest.test_import_hook):
  1301. * Scripts/webkitpy/thirdparty/mod_pywebsocket/COPYING: Added.
  1302. * Scripts/webkitpy/thirdparty/mod_pywebsocket/__init__.py: Added.
  1303. * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_base.py: Added.
  1304. (ConnectionTerminatedException):
  1305. (InvalidFrameException):
  1306. (BadOperationException):
  1307. (UnsupportedFrameException):
  1308. (InvalidUTF8Exception):
  1309. (StreamBase):
  1310. (StreamBase.__init__):
  1311. (StreamBase._read):
  1312. (StreamBase._write):
  1313. (StreamBase.receive_bytes):
  1314. (StreamBase._read_until):
  1315. * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hixie75.py: Added.
  1316. (for):
  1317. (StreamHixie75):
  1318. (StreamHixie75.for):
  1319. (StreamHixie75.__init__):
  1320. (StreamHixie75.send_message):
  1321. (StreamHixie75._read_payload_length_hixie75):
  1322. (StreamHixie75.receive_message):
  1323. (StreamHixie75._send_closing_handshake):
  1324. (StreamHixie75.close_connection):
  1325. (StreamHixie75.send_ping):
  1326. * Scripts/webkitpy/thirdparty/mod_pywebsocket/_stream_hybi.py: Added.
  1327. (Frame):
  1328. (Frame.__init__):
  1329. (create_length_header):
  1330. (create_header):
  1331. (_build_frame):
  1332. (_filter_and_format_frame_object):
  1333. (create_binary_frame):
  1334. (create_text_frame):
  1335. (FragmentedFrameBuilder):
  1336. (FragmentedFrameBuilder.to):
  1337. (FragmentedFrameBuilder.__init__):
  1338. (FragmentedFrameBuilder.build):
  1339. (_create_control_frame):
  1340. (create_ping_frame):
  1341. (create_pong_frame):
  1342. (create_close_frame):
  1343. (StreamOptions):
  1344. (StreamOptions.__init__):
  1345. (Stream):
  1346. (Stream.for):
  1347. (Stream.__init__):
  1348. (Stream._receive_frame):
  1349. (Stream._receive_frame_as_frame_object):
  1350. (Stream.send_message):
  1351. (Stream.receive_message):
  1352. (Stream._send_closing_handshake):
  1353. (Stream.close_connection):
  1354. (Stream.send_ping):
  1355. (Stream._send_pong):
  1356. (Stream._drain_received_data):
  1357. * Scripts/webkitpy/thirdparty/mod_pywebsocket/common.py: Added.
  1358. (is_control_opcode):
  1359. (ExtensionParameter):
  1360. (ExtensionParameter.__init__):
  1361. (ExtensionParameter.name):
  1362. (ExtensionParameter.add_parameter):
  1363. (ExtensionParameter.get_parameters):
  1364. (ExtensionParameter.get_parameter_names):
  1365. (ExtensionParameter.has_parameter):
  1366. (ExtensionParameter.get_parameter_value):
  1367. * Scripts/webkitpy/thirdparty/mod_pywebsocket/dispatch.py: Added.
  1368. (DispatchException):
  1369. (DispatchException.__init__):
  1370. (_default_passive_closing_handshake_handler):
  1371. (_normalize_path):
  1372. (_create_path_to_resource_converter):
  1373. (_create_path_to_resource_converter.converter):
  1374. (_enumerate_handler_file_paths):
  1375. (_HandlerSuite):
  1376. (_HandlerSuite.__init__):
  1377. (_source_handler_file):
  1378. (_extract_handler):
  1379. (Dispatcher):
  1380. (Dispatcher.maintains):
  1381. (Dispatcher.__init__):
  1382. (Dispatcher.add_resource_path_alias):
  1383. (Dispatcher.source_warnings):
  1384. (Dispatcher.do_extra_handshake):
  1385. (Dispatcher.transfer_data):
  1386. (Dispatcher.passive_closing_handshake):
  1387. (Dispatcher.get_handler_suite):
  1388. (Dispatcher._source_handler_files_in_dir):
  1389. * Scripts/webkitpy/thirdparty/mod_pywebsocket/extensions.py: Added.
  1390. (ExtensionProcessorInterface):
  1391. (ExtensionProcessorInterface.get_extension_response):
  1392. (ExtensionProcessorInterface.setup_stream_options):
  1393. (DeflateStreamExtensionProcessor):
  1394. (DeflateStreamExtensionProcessor.__init__):
  1395. (DeflateStreamExtensionProcessor.get_extension_response):
  1396. (DeflateStreamExtensionProcessor.setup_stream_options):
  1397. (DeflateFrameExtensionProcessor):
  1398. (DeflateFrameExtensionProcessor.__init__):
  1399. (DeflateFrameExtensionProcessor.get_extension_response):
  1400. (DeflateFrameExtensionProcessor.setup_stream_options):
  1401. (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter):
  1402. (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.__init__):
  1403. (DeflateFrameExtensionProcessor.setup_stream_options._OutgoingFilter.filter):
  1404. (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter):
  1405. (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.__init__):
  1406. (DeflateFrameExtensionProcessor.setup_stream_options._IncomingFilter.filter):
  1407. (DeflateFrameExtensionProcessor.set_response_window_bits):
  1408. (DeflateFrameExtensionProcessor.set_response_no_context_takeover):
  1409. (DeflateFrameExtensionProcessor.enable_outgoing_compression):
  1410. (DeflateFrameExtensionProcessor.disable_outgoing_compression):
  1411. (DeflateFrameExtensionProcessor._outgoing_filter):
  1412. (DeflateFrameExtensionProcessor._incoming_filter):
  1413. (get_extension_processor):
  1414. (get_extension_processor.is):
  1415. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/__init__.py: Added.
  1416. (try):
  1417. (do_handshake):
  1418. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/_base.py: Added.
  1419. (AbortedByUserException):
  1420. (HandshakeException):
  1421. (HandshakeException.__init__):
  1422. (VersionException):
  1423. (VersionException.__init__):
  1424. (get_default_port):
  1425. (validate_subprotocol):
  1426. (parse_host_header):
  1427. (format_header):
  1428. (build_location):
  1429. (get_mandatory_header):
  1430. (validate_mandatory_header):
  1431. (check_request_line):
  1432. (check_header_lines):
  1433. (parse_token_list):
  1434. (_parse_extension_param):
  1435. (_parse_extension):
  1436. (parse_extensions):
  1437. (format_extensions):
  1438. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/draft75.py: Added.
  1439. (Handshaker):
  1440. (Handshaker.performs):
  1441. (Handshaker.__init__):
  1442. (Handshaker.do_handshake):
  1443. (Handshaker._set_resource):
  1444. (Handshaker._set_origin):
  1445. (Handshaker._set_location):
  1446. (Handshaker._set_subprotocol):
  1447. (Handshaker._set_protocol_version):
  1448. (Handshaker._sendall):
  1449. (Handshaker._send_handshake):
  1450. (Handshaker._check_header_lines):
  1451. (Handshaker._check_first_lines):
  1452. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi.py: Added.
  1453. (compute_accept):
  1454. (Handshaker):
  1455. (Handshaker.__init__):
  1456. (Handshaker._validate_connection_header):
  1457. (Handshaker.do_handshake):
  1458. (Handshaker._get_origin):
  1459. (Handshaker._check_version):
  1460. (Handshaker._set_protocol):
  1461. (Handshaker._parse_extensions):
  1462. (Handshaker._validate_key):
  1463. (Handshaker._get_key):
  1464. (Handshaker._send_handshake):
  1465. * Scripts/webkitpy/thirdparty/mod_pywebsocket/handshake/hybi00.py: Added.
  1466. (Handshaker):
  1467. (Handshaker.__init__):
  1468. (Handshaker.do_handshake):
  1469. (Handshaker._set_resource):
  1470. (Handshaker._set_subprotocol):
  1471. (Handshaker._set_location):
  1472. (Handshaker._set_origin):
  1473. (Handshaker._set_protocol_version):
  1474. (Handshaker._set_challenge_response):
  1475. (Handshaker._get_key_value):
  1476. (Handshaker._get_challenge):
  1477. (Handshaker._send_handshake):
  1478. * Scripts/webkitpy/thirdparty/mod_pywebsocket/headerparserhandler.py: Added.
  1479. (ApacheLogHandler):
  1480. (ApacheLogHandler.__init__):
  1481. (ApacheLogHandler.emit):
  1482. (_configure_logging):
  1483. (_parse_option):
  1484. (_create_dispatcher):
  1485. (headerparserhandler):
  1486. * Scripts/webkitpy/thirdparty/mod_pywebsocket/http_header_util.py: Added.
  1487. (_is_char):
  1488. (_is_ctl):
  1489. (ParsingState):
  1490. (ParsingState.__init__):
  1491. (peek):
  1492. (consume):
  1493. (consume_string):
  1494. (consume_lws):
  1495. (consume_lwses):
  1496. (consume_token):
  1497. (consume_token_or_quoted_string):
  1498. (quote_if_necessary):
  1499. (parse_uri):
  1500. * Scripts/webkitpy/thirdparty/mod_pywebsocket/memorizingfile.py: Added.
  1501. (MemorizingFile):
  1502. (MemorizingFile.__init__):
  1503. (MemorizingFile.__getattribute__):
  1504. (MemorizingFile.readline):
  1505. (MemorizingFile.get_memorized_lines):
  1506. * Scripts/webkitpy/thirdparty/mod_pywebsocket/msgutil.py: Added.
  1507. (close_connection):
  1508. (send_message):
  1509. (receive_message):
  1510. (send_ping):
  1511. (MessageReceiver):
  1512. (MessageReceiver.receives):
  1513. (MessageReceiver.provides):
  1514. (MessageReceiver.should):
  1515. (MessageReceiver.__init__):
  1516. (MessageReceiver.run):
  1517. (MessageReceiver.receive):
  1518. (MessageReceiver.receive_nowait):
  1519. (MessageReceiver.stop):
  1520. (MessageSender):
  1521. (MessageSender.sends):
  1522. (MessageSender.provides):
  1523. (MessageSender.should):
  1524. (MessageSender.__init__):
  1525. (MessageSender.run):
  1526. (MessageSender.send):
  1527. (MessageSender.send_nowait):
  1528. * Scripts/webkitpy/thirdparty/mod_pywebsocket/standalone.py: Added.
  1529. (_StandaloneConnection):
  1530. (_StandaloneConnection.__init__):
  1531. (_StandaloneConnection.get_local_addr):
  1532. (_StandaloneConnection.get_remote_addr):
  1533. (_StandaloneConnection.write):
  1534. (_StandaloneConnection.read):
  1535. (_StandaloneConnection.get_memorized_lines):
  1536. (_StandaloneRequest):
  1537. (_StandaloneRequest.__init__):
  1538. (_StandaloneRequest.get_uri):
  1539. (_StandaloneRequest.get_method):
  1540. (_StandaloneRequest.is_https):
  1541. (_StandaloneRequest._drain_received_data):
  1542. (_StandaloneSSLConnection):
  1543. (_StandaloneSSLConnection.for):
  1544. (_StandaloneSSLConnection.__init__):
  1545. (_StandaloneSSLConnection.__getattribute__):
  1546. (_StandaloneSSLConnection.__setattr__):
  1547. (_StandaloneSSLConnection.makefile):
  1548. (WebSocketServer):
  1549. (WebSocketServer.__init__):
  1550. (WebSocketServer._create_sockets):
  1551. (WebSocketServer.server_bind):
  1552. (WebSocketServer.server_activate):
  1553. (WebSocketServer.server_close):
  1554. (WebSocketServer.fileno):
  1555. (WebSocketServer.handle_error):
  1556. (WebSocketServer.get_request):
  1557. (WebSocketServer.serve_forever):
  1558. (WebSocketServer.shutdown):
  1559. (WebSocketRequestHandler):
  1560. (WebSocketRequestHandler.setup):
  1561. (WebSocketRequestHandler.setup.SocketServer):
  1562. (WebSocketRequestHandler.__init__):
  1563. (WebSocketRequestHandler.parse_request):
  1564. (WebSocketRequestHandler.log_request):
  1565. (WebSocketRequestHandler.log_error):
  1566. (WebSocketRequestHandler.is_cgi):
  1567. (_configure_logging):
  1568. (_alias_handlers):
  1569. (_build_option_parser):
  1570. (ThreadMonitor):
  1571. (ThreadMonitor.__init__):
  1572. (ThreadMonitor.run):
  1573. (_parse_args_and_config):
  1574. (_main):
  1575. (_main.if):
  1576. (_main.if.__check_script):
  1577. * Scripts/webkitpy/thirdparty/mod_pywebsocket/stream.py: Copied from Tools/Scripts/webkitpy/thirdparty/__init___unittest.py.
  1578. * Scripts/webkitpy/thirdparty/mod_pywebsocket/util.py: Added.
  1579. (get_stack_trace):
  1580. (prepend_message_to_exception):
  1581. (__translate_interp):
  1582. (get_script_interp):
  1583. (wrap_popen3_for_win):
  1584. (wrap_popen3_for_win.__wrap_popen3):
  1585. (hexify):
  1586. (get_class_logger):
  1587. (NoopMasker):
  1588. (NoopMasker.__init__):
  1589. (NoopMasker.mask):
  1590. (RepeatedXorMasker):
  1591. (RepeatedXorMasker.__init__):
  1592. (RepeatedXorMasker.mask):
  1593. (DeflateRequest):
  1594. (DeflateRequest.for):
  1595. (DeflateRequest.__init__):
  1596. (DeflateRequest.__getattribute__):
  1597. (DeflateRequest.__setattr__):
  1598. (_Deflater):
  1599. (_Deflater.__init__):
  1600. (_Deflater.compress_and_flush):
  1601. (_Inflater):
  1602. (_Inflater.__init__):
  1603. (_Inflater.decompress):
  1604. (_Inflater.append):
  1605. (_Inflater.reset):
  1606. (_RFC1979Deflater):
  1607. (_RFC1979Deflater.that):
  1608. (_RFC1979Deflater.__init__):
  1609. (_RFC1979Deflater.filter):
  1610. (_RFC1979Inflater):
  1611. (_RFC1979Inflater.for):
  1612. (_RFC1979Inflater.__init__):
  1613. (_RFC1979Inflater.filter):
  1614. (DeflateSocket):
  1615. (DeflateSocket.for):
  1616. (DeflateSocket.__init__):
  1617. (DeflateSocket.recv):
  1618. (DeflateSocket.sendall):
  1619. (DeflateSocket.send):
  1620. (DeflateConnection):
  1621. (DeflateConnection.for):
  1622. (DeflateConnection.__init__):
  1623. (DeflateConnection.get_remote_addr):
  1624. (DeflateConnection.put_bytes):
  1625. (DeflateConnection.read):
  1626. (DeflateConnection.write):
  1627. (_is_ewouldblock_errno):
  1628. (drain_received_data):
  1629. 2012-05-10 Raphael Kubo da Costa <rakuco@webkit.org>
  1630. [EFL][webkitpy] Define the 'wrapper' option in EflPort instead of creating a EflDriver.
  1631. https://bugs.webkit.org/show_bug.cgi?id=86117
  1632. Reviewed by Adam Barth.
  1633. Simplify the code used to wrap driver calls with jhbuild: we can
  1634. just define the 'wrapper' option instead of having to create a
  1635. Driver class just for that.
  1636. * Scripts/webkitpy/layout_tests/port/efl.py:
  1637. (EflPort.__init__):
  1638. (EflPort._port_flag_for_scripts):
  1639. 2012-05-10 Sheriff Bot <webkit.review.bot@gmail.com>
  1640. Unreviewed, rolling out r116633.
  1641. http://trac.webkit.org/changeset/116633
  1642. https://bugs.webkit.org/show_bug.cgi?id=86093
  1643. Breaks EFL tests (Requested by kov on #webkit).
  1644. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  1645. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  1646. * DumpRenderTree/efl/EventSender.cpp:
  1647. (keyDownCallback):
  1648. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  1649. (LayoutTestController::setTabKeyCyclesThroughElements):
  1650. 2012-05-10 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  1651. [EFL] Memory leaks found in EFL DRT
  1652. https://bugs.webkit.org/show_bug.cgi?id=85889
  1653. Reviewed by Gustavo Noronha Silva.
  1654. Fix two memory leaks in EFL's DRT by using JSRetainPtr for JSString
  1655. created with JSStringCreateWithUTF8CString.
  1656. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  1657. (DumpRenderTreeChrome::onWindowObjectCleared):
  1658. * DumpRenderTree/efl/EventSender.cpp:
  1659. (modifiersFromJSValue):
  1660. 2012-05-10 Alexander Shalamov <alexander.shalamov@intel.com>
  1661. [EFL] LayoutTestController needs implementation of setTabKeyCyclesThroughElements
  1662. https://bugs.webkit.org/show_bug.cgi?id=82864
  1663. Reviewed by Gustavo Noronha Silva.
  1664. Add missing implementation for setTabKeyCyclesThroughElements to EFL's LayoutTestController
  1665. in order to unskip fast/events/keypress-insert-tab.html
  1666. * DumpRenderTree/efl/EventSender.cpp:
  1667. (keyDownCallback):
  1668. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  1669. (LayoutTestController::setTabKeyCyclesThroughElements):
  1670. 2012-05-10 Alexander Shalamov <alexander.shalamov@intel.com>
  1671. [EFL][DRT] EventSender - set delayed event information if it was not set before
  1672. https://bugs.webkit.org/show_bug.cgi?id=85972
  1673. Reviewed by Gustavo Noronha Silva.
  1674. Reset delayed event information if it is missing.
  1675. * DumpRenderTree/efl/EventSender.cpp:
  1676. (feedOrQueueMouseEvent):
  1677. 2012-05-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  1678. WebPageProxy::activeURL() should return the pending API request, even when there's no main frame
  1679. https://bugs.webkit.org/show_bug.cgi?id=85806
  1680. The m_pendingAPIRequestURL member is used (presumably) to mask over the async
  1681. nature of WebKit2, so that starting a load of a URL will reflect that URL
  1682. immedeatly from activeURL, even if the request has not been passed over to
  1683. the web process yet and reflected there.
  1684. This works well, except in the case of the initial request, where the main
  1685. frame creation happens on the web process side and is notified back to the
  1686. UI process. Until we've recived the notification we don't know about the main
  1687. frame, and this race condition will potentially give us an empty url instead
  1688. of the pending request.
  1689. To solve this we always return the pending API request if it's set, even
  1690. when there's no mainframe yet (that we known about).
  1691. Reviewed by Simon Hausmann.
  1692. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  1693. 2012-05-10 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  1694. [EFL][DRT] Clear added user style sheets before a new testcase execution.
  1695. https://bugs.webkit.org/show_bug.cgi?id=84792
  1696. Reviewed Gustavo Noronha Silva.
  1697. The added user style sheets from the previous testcases are cleared in order to avoid
  1698. flaky results.
  1699. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  1700. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  1701. 2012-05-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  1702. Move suspendAnimations to use Internals interface.
  1703. https://bugs.webkit.org/show_bug.cgi?id=85986
  1704. Reviewed by Ryosuke Niwa.
  1705. Remove suspendAnimations functions, because it is able to work in the
  1706. cross-port way through the Internals interface
  1707. * DumpRenderTree/LayoutTestController.cpp:
  1708. (LayoutTestController::staticFunctions):
  1709. * DumpRenderTree/LayoutTestController.h:
  1710. (LayoutTestController):
  1711. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  1712. * DumpRenderTree/chromium/LayoutTestController.cpp:
  1713. (LayoutTestController::LayoutTestController):
  1714. * DumpRenderTree/chromium/LayoutTestController.h:
  1715. (LayoutTestController):
  1716. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  1717. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  1718. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  1719. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  1720. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  1721. (LayoutTestController):
  1722. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  1723. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  1724. 2012-05-09 Kent Tamura <tkent@chromium.org>
  1725. [Chromium] Attempt to fix an Android build error.
  1726. https://bugs.webkit.org/show_bug.cgi?id=86045
  1727. * DumpRenderTree/DumpRenderTree.gypi:
  1728. 2012-05-09 Ojan Vafai <ojan@chromium.org>
  1729. Don't show partytime if there are non-layout test failures.
  1730. https://bugs.webkit.org/show_bug.cgi?id=86056
  1731. Reviewed by Dimitri Glazkov.
  1732. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  1733. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
  1734. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  1735. 2012-05-09 Hayato Ito <hayato@chromium.org>
  1736. Improve a warning message for a reftest having an unused expectation file.
  1737. https://bugs.webkit.org/show_bug.cgi?id=85975
  1738. Reviewed by Adam Barth.
  1739. The current warning message is not intuitive. It might be better to update the message
  1740. so that it encourage users to remove unused expectation files.
  1741. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  1742. (SingleTestRunner.__init__):
  1743. 2012-05-09 Ojan Vafai <ojan@chromium.org>
  1744. Change "losing test coverage" to cover all non-layout test problems in garden-o-matic
  1745. https://bugs.webkit.org/show_bug.cgi?id=86043
  1746. Reviewed by Adam Barth.
  1747. -Get rid of the gtest iframe.
  1748. -Cover all non-layout test problems. Before we wouldn't catch compile failures
  1749. or gtest failures since they were not on the webkit testing bots.
  1750. -Include the list of failing steps next to the builder name. This is a lot less
  1751. cluttered than you'd expect and already helped me find a compile failure early.
  1752. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  1753. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  1754. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  1755. Delete unused map.
  1756. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  1757. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  1758. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  1759. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  1760. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  1761. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  1762. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  1763. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  1764. 2012-05-09 Jessie Berlin <jberlin@apple.com>
  1765. Crash using the new WKBundleDOMWindowExtensions APIs.
  1766. https://bugs.webkit.org/show_bug.cgi?id=85888
  1767. Reviewed by Brady Eidson.
  1768. Cached frames can live slightly longer than the page, but most clients unregister themselves
  1769. and do other cleanup in the willDestroyPage callback, making them miss the
  1770. willDestroyGlobalObjectForDOMWindowExtension callbacks.
  1771. The calls to willDestroyGlobalObjectForDOMWindowExtension in the DOMWindowExtensionBasic
  1772. test were all being invoked underneath WebPage::close. This is unrealistic. Update that test
  1773. to destroy the BundleDOMWindowExtensions in response to the willDestroyPage callback.
  1774. Add a test to verify that willDestroyGlobalObjectForDOMWindowExtension is being called for
  1775. pages that don't go into the page cache.
  1776. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  1777. Add DOMWindowExtensionNoCache.cpp, DOMWindowExtensionNoCache_Bundle.cpp, simple-unload.html
  1778. and simple-iframe-unload.html
  1779. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
  1780. (TestWebKitAPI):
  1781. Remove the expected messages for willDestroyGlobalObjectForDOMWindowExtension.
  1782. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  1783. Do not bother to keep track of the live extension count - all of them are expected to be
  1784. live until the test completes.
  1785. (TestWebKitAPI::TEST):
  1786. Fix the calls to EXPECT to pass the expected value first, and use EXPECT_WK_STREQ so that
  1787. message failures will be clearer.
  1788. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  1789. (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyPage):
  1790. Clean up the BundleDOMWindowExtensions.
  1791. (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
  1792. Add an ASSERT_NOT_REACHED.
  1793. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache.cpp: Added.
  1794. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  1795. Keep track of the messages received so they can be checked at the end of the test.
  1796. (TestWebKitAPI::TEST):
  1797. Navigate to uncacheable pages and back.
  1798. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionNoCache_Bundle.cpp: Copied from Tools/TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp.
  1799. (DOMWindowExtensionNoCache):
  1800. (TestWebKitAPI::DOMWindowExtensionNoCache::DOMWindowExtensionNoCache):
  1801. Set up all the states for each BundleDOMWindowExtension.
  1802. (TestWebKitAPI::DOMWindowExtensionNoCache::frameLoadFinished):
  1803. Tell the UI Process about the states of the BundleDOMWindowExtensions.
  1804. (TestWebKitAPI::DOMWindowExtensionNoCache::sendExtensionStateMessage):
  1805. (TestWebKitAPI::DOMWindowExtensionNoCache::initialize):
  1806. (TestWebKitAPI::DOMWindowExtensionNoCache::didCreatePage):
  1807. (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyPage):
  1808. Remvoe the remaining BundleDOMWindowExtensions, send the updated state, and finish the test.
  1809. (TestWebKitAPI::DOMWindowExtensionNoCache::updateExtensionStateRecord):
  1810. (TestWebKitAPI::DOMWindowExtensionNoCache::sendBundleMessage):
  1811. (TestWebKitAPI::DOMWindowExtensionNoCache::globalObjectIsAvailableForFrame):
  1812. (TestWebKitAPI::DOMWindowExtensionNoCache::willDisconnectDOMWindowExtensionFromGlobalObject):
  1813. ASSERT that these pages not going into the page cache are not getting disconnected to go into
  1814. the page cache.
  1815. (TestWebKitAPI::DOMWindowExtensionNoCache::didReconnectDOMWindowExtensionToGlobalObject):
  1816. Ditto about getting reconnected when coming out of the page cache.
  1817. (TestWebKitAPI::DOMWindowExtensionNoCache::willDestroyGlobalObjectForDOMWindowExtension):
  1818. Tell the UI Process, update the state, and get rid of the BundleDOMWindowExtension.
  1819. (TestWebKitAPI::didFinishLoadForFrameCallback):
  1820. (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
  1821. (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
  1822. (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
  1823. (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
  1824. * TestWebKitAPI/Tests/WebKit2/simple-iframe-unload.html: Added.
  1825. * TestWebKitAPI/Tests/WebKit2/simple-unload.html: Added.
  1826. 2012-05-09 Adam Barth <abarth@webkit.org>
  1827. [Chromium] Android's DRT doesn't want to build WebUserMediaClientMock
  1828. https://bugs.webkit.org/show_bug.cgi?id=86045
  1829. Reviewed by Eric Seidel.
  1830. * DumpRenderTree/DumpRenderTree.gypi:
  1831. 2012-05-09 Adam Barth <abarth@webkit.org>
  1832. [Chromium] MockWebSpeechInputController.cpp should be guarded by ENABLE(INPUT_SPEECH)
  1833. https://bugs.webkit.org/show_bug.cgi?id=86041
  1834. Reviewed by Eric Seidel.
  1835. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  1836. 2012-05-09 Adam Barth <abarth@webkit.org>
  1837. [Chromium] Android needs to swizzle pixel dumps in order to get the same hash as other platforms
  1838. https://bugs.webkit.org/show_bug.cgi?id=86040
  1839. Reviewed by Kent Tamura.
  1840. * DumpRenderTree/chromium/TestShell.cpp:
  1841. (TestShell::dumpImage):
  1842. 2012-05-09 Raphael Kubo da Costa <rakuco@webkit.org>
  1843. [EFL] Build fix after r116464.
  1844. `ulong' is a type defined by glibc, so it is not very
  1845. portable. Use `unsigned long' instead.
  1846. * DumpRenderTree/efl/EventSender.cpp:
  1847. (DelayedEvent::DelayedEvent):
  1848. (DelayedEvent):
  1849. (leapForwardCallback):
  1850. 2012-05-09 Adam Barth <abarth@webkit.org>
  1851. [Chromium] LayoutTestController should use ENABLE guards for some features
  1852. https://bugs.webkit.org/show_bug.cgi?id=86030
  1853. Reviewed by Eric Seidel.
  1854. These features are disabled on OS(ANDROID) and so shouldn't be compiled
  1855. when the feature is off.
  1856. * DumpRenderTree/chromium/LayoutTestController.cpp:
  1857. (LayoutTestController::LayoutTestController):
  1858. * DumpRenderTree/chromium/LayoutTestController.h:
  1859. (LayoutTestController):
  1860. * DumpRenderTree/chromium/TestShell.h:
  1861. (TestShell):
  1862. 2012-05-09 Tom Zakrajsek <tomz@codeaurora.org>
  1863. Fix overzealous re-opened since blocked by... message
  1864. https://bugs.webkit.org/show_bug.cgi?id=86020
  1865. Reviewed by Adam Barth.
  1866. Changed CreateBug behavior to only re-open a blocked bug if it
  1867. was RESOLVED. Also had to update the test infrastructure slightly
  1868. to allow for distinct mock commit revisions, so one could point
  1869. to a RESOLVED bug for testing while another pointed to an OPEN bug.
  1870. Also moved default created mock bug to be 60001 instead of 50004
  1871. which already exists as a reference mock bug.
  1872. * Scripts/webkitpy/common/checkout/checkout_mock.py:
  1873. (MockCheckout.__init__):
  1874. (MockCheckout.commit_info_for_revision):
  1875. * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  1876. (MockBugzilla.create_bug):
  1877. * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  1878. * Scripts/webkitpy/tool/commands/download_unittest.py:
  1879. (test_create_rollout_resolved):
  1880. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  1881. (FailureReasonTest.test_blame_line_for_revision):
  1882. * Scripts/webkitpy/tool/steps/createbug.py:
  1883. (CreateBug.run):
  1884. 2012-05-09 Hugo Parente Lima <hugo.lima@openbossa.org>
  1885. Use suitable viewport values on XHTML-MP pages.
  1886. https://bugs.webkit.org/show_bug.cgi?id=85425
  1887. Reviewed by Kenneth Rohde Christiansen.
  1888. Enable LEGACY_VIEWPORT_ADAPTION on Qt port.
  1889. * qmake/mkspecs/features/features.prf:
  1890. 2012-05-09 Jochen Eisinger <jochen@chromium.org>
  1891. When creating a new page during a navigation, prime the initial document with the correct referrer policy
  1892. https://bugs.webkit.org/show_bug.cgi?id=86001
  1893. Reviewed by Adam Barth.
  1894. Store the referrer policy in the request, so the network stack can comply with it.
  1895. * DumpRenderTree/chromium/WebViewHost.cpp:
  1896. (WebViewHost::willSendRequest):
  1897. 2012-05-09 Vivek Galatage <vivekgalatage@gmail.com>
  1898. Remove CYGWIN=tty from environment variable as its no longer supported
  1899. https://bugs.webkit.org/show_bug.cgi?id=85791
  1900. The CYGWIN=tty environment variable is no longer supported from Cygwin
  1901. version 1.7.10. This fix avoids addition of this environment variable
  1902. for Cygwin versions greater than 1.7.9. For supporting older versions
  1903. i.e. 1.7.9 or older, the script takes care of retaining the environment
  1904. variable.
  1905. Reviewed by Adam Roben.
  1906. * Scripts/webkitdirs.pm:
  1907. (setupAppleWinEnv):
  1908. 2012-05-09 Dirk Pranke <dpranke@chromium.org>
  1909. nrwt: --skip-failing-tests should also skip flaky tests
  1910. https://bugs.webkit.org/show_bug.cgi?id=85941
  1911. Reviewed by Ojan Vafai.
  1912. This changes --skip-failing-tests so that we skip tests that
  1913. are believed to pass sometimes as well as tests that are
  1914. believed to always fail.
  1915. In addition, in testing this I discovered that we had lousy
  1916. test coverage of the details of retrying test failures and
  1917. --clobber-old-results, so I wrote some more tests.
  1918. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  1919. (Manager.prepare_lists_and_print_output):
  1920. * Scripts/webkitpy/layout_tests/port/test.py:
  1921. (unit_test_list):
  1922. (TestPort.__init__):
  1923. (TestDriver.run_test):
  1924. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  1925. (MainTest.test_skip_failing_tests):
  1926. (MainTest.test_retrying_and_flaky_tests):
  1927. 2012-05-09 Christophe Dumez <christophe.dumez@intel.com>
  1928. [EFL][DRT] EFL's DRT needs to support LayoutTestController.dumpIconChanges()
  1929. https://bugs.webkit.org/show_bug.cgi?id=84435
  1930. Reviewed by Antonio Gomes.
  1931. Catch the "icon,changed" signal on the frames in EFL's DumpRenderTree
  1932. to support LayoutTestController's dumpIconChanges().
  1933. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  1934. (DumpRenderTreeChrome::createView):
  1935. (DumpRenderTreeChrome::onFrameIconChanged):
  1936. (DumpRenderTreeChrome::onFrameCreated):
  1937. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  1938. (DumpRenderTreeChrome):
  1939. 2012-05-09 Dominik Röttsches <dominik.rottsches@intel.com>
  1940. webkit-patch upload Fails Behind Load-balancing Proxies
  1941. https://bugs.webkit.org/show_bug.cgi?id=85980
  1942. Reviewed by Adam Barth.
  1943. Unchecking the login restriction to IP to allow the tool
  1944. to function behind load-balancing proxies that use multiple
  1945. outgoing IPs.
  1946. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  1947. (Bugzilla.authenticate):
  1948. 2012-05-09 Hao Zheng <zhenghao@chromium.org>
  1949. [Chromium-android] Add unit test for Android layout test script (chromium_android.py)
  1950. https://bugs.webkit.org/show_bug.cgi?id=80852
  1951. Reviewed by Adam Barth.
  1952. Add some tests to ensure that chromium android port works to some
  1953. extent. Some methods is hard to test, as they rely on the actual
  1954. behavior on device, e.g. pushing files to device.
  1955. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  1956. (ChromiumAndroidPort.get_last_stacktrace): Check if dir exists.
  1957. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  1958. (ChromiumAndroidPortTest):
  1959. (ChromiumAndroidPortTest.test_attributes):
  1960. (ChromiumAndroidPortTest.test_get_last_stacktrace):
  1961. (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_dir):
  1962. (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_no_file):
  1963. (ChromiumAndroidPortTest.test_get_last_stacktrace.mock_run_command_non_empty):
  1964. (ChromiumAndroidDriverTest):
  1965. (ChromiumAndroidDriverTest.setUp):
  1966. (ChromiumAndroidDriverTest.test_get_drt_return_value):
  1967. (ChromiumAndroidDriverTest.test_has_crash_hint):
  1968. (ChromiumAndroidDriverTest.test_read_prompt):
  1969. (ChromiumAndroidDriverTest.test_test_shell_command):
  1970. (ChromiumAndroidDriverTest.test_write_command_and_read_line):
  1971. 2012-05-09 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  1972. [Qt] ORWT fails with Qt 5 and WK2.
  1973. https://bugs.webkit.org/show_bug.cgi?id=85968
  1974. Reviewed by Csaba Osztrogonác.
  1975. The Qt5 binary does not have a -style argument, so avoid using it.
  1976. * Scripts/old-run-webkit-tests:
  1977. 2012-05-09 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  1978. [EFL][DRT] LayoutTestController addUserScript implementation
  1979. https://bugs.webkit.org/show_bug.cgi?id=84718
  1980. Reviewed by Antonio Gomes.
  1981. Added implementation of addUserScript() to LayoutTestController.
  1982. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  1983. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): clear added user scripts
  1984. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  1985. (LayoutTestController::addUserScript): added implementation
  1986. 2012-05-09 Dan Bernstein <mitz@apple.com>
  1987. Made build-webkit copy WebKitLibraries to the right location again after r116257
  1988. Reviewed by Mark Rowe.
  1989. * Scripts/build-webkit: Pass the built product directory to copy-webkitlibraries-to-product-directory.
  1990. * Scripts/copy-webkitlibraries-to-product-directory: Use the first argument, if present, as the
  1991. product directory.
  1992. 2012-05-08 Ojan Vafai <ojan@chromium.org>
  1993. Show the chromium non-layout test bots in garden-o-matic
  1994. https://bugs.webkit.org/show_bug.cgi?id=85903
  1995. Reviewed by Eric Seidel.
  1996. This is just a single-line high-level overview of the chromium non-layout test bots.
  1997. This means that Chromium WebKit gardeners only need to keep garden-o-matic open in
  1998. order to do their job.
  1999. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  2000. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  2001. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  2002. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
  2003. (#chromium-gtests iframe):
  2004. (#chromium-gtests):
  2005. (#gtest-label):
  2006. 2012-05-08 Kangil Han <kangil.han@samsung.com>
  2007. [EFL][DRT] Implement TextInputController.
  2008. https://bugs.webkit.org/show_bug.cgi?id=78559
  2009. Reviewed by Martin Robinson.
  2010. TextInputController has been created for an input emulation purpose in DRT.
  2011. However, not like other ports, EFL doesn't have it.
  2012. Therefore, this patch will enable EFL port to have an input emulation in DRT.
  2013. * DumpRenderTree/efl/CMakeLists.txt:
  2014. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2015. (DumpRenderTreeChrome::onWindowObjectCleared):
  2016. * DumpRenderTree/efl/TextInputController.cpp: Added.
  2017. (setMarkedTextCallback):
  2018. (hasMarkedTextCallback):
  2019. (markedRangeCallback):
  2020. (insertTextCallback):
  2021. (unmarkTextCallback):
  2022. (firstRectForCharacterRangeCallback):
  2023. (selectedRangeCallback):
  2024. (makeTextInputController):
  2025. * DumpRenderTree/efl/TextInputController.h: Added.
  2026. 2012-04-23 Raphael Kubo da Costa <rakuco@webkit.org>
  2027. [EFL] Pass a WTF::String directly from DRT to ewebkit when possible
  2028. https://bugs.webkit.org/show_bug.cgi?id=84634
  2029. Reviewed by Gustavo Noronha Silva.
  2030. Drop unnecessary const char* -> WTF::String conversions by
  2031. creating String objects directly in LayoutTestController out of
  2032. JSStringRef's and passing them to DumpRenderTreeSupportEfl.
  2033. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  2034. (LayoutTestController::queueLoad):
  2035. (LayoutTestController::setValueForUser):
  2036. (LayoutTestController::findString):
  2037. (LayoutTestController::addUserStyleSheet):
  2038. 2012-05-08 Alexander Shalamov <alexander.shalamov@intel.com>
  2039. [EFL][DRT] EventSender needs implementation of leapForward function
  2040. https://bugs.webkit.org/show_bug.cgi?id=83486
  2041. Reviewed by Eric Seidel.
  2042. Implemented leapForward function in Efl's DRT. This function is required
  2043. to delay and queue event execution and simulate real user behavior.
  2044. * DumpRenderTree/efl/EventSender.cpp:
  2045. (DelayedEvent):
  2046. (MouseEventInfo::MouseEventInfo):
  2047. (MouseEventInfo):
  2048. (sendClick):
  2049. (mouseDownCallback):
  2050. (mouseUpCallback):
  2051. (mouseMoveToCallback):
  2052. (leapForwardCallback):
  2053. (mouseScrollByCallback):
  2054. (feedOrQueueMouseEvent):
  2055. (feedMouseEvent):
  2056. (feedQueuedMouseEvents):
  2057. 2012-05-08 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  2058. [GTK] Memory leak in DRT EventSender.cpp
  2059. https://bugs.webkit.org/show_bug.cgi?id=85886
  2060. Reviewed by Martin Robinson.
  2061. Fix a memory leak in gdkModifersFromJSValue() by using JSRetainPtr for
  2062. JSString created with JSStringCreateWithUTF8CString.
  2063. * DumpRenderTree/gtk/EventSender.cpp:
  2064. (gdkModifersFromJSValue):
  2065. 2012-05-08 Christophe Dumez <christophe.dumez@intel.com>
  2066. [EFL] glib dependency needs to be updated in jhbuild
  2067. https://bugs.webkit.org/show_bug.cgi?id=85878
  2068. Reviewed by Martin Robinson.
  2069. Bump glib version from 2.31.8 to 2.32.2 in jhbuild.modules. This
  2070. addresses flakiness in media tests due to possible deadlock with the
  2071. following output on stderr:
  2072. GStreamer-WARNING **: wrong STREAM_LOCK count 0
  2073. The bug was fixed upstream by:
  2074. http://git.gnome.org/browse/glib/commit/?id=265f265c677bc5399dbb1cfa449cb4b915a6459f
  2075. * efl/jhbuild.modules:
  2076. 2012-05-07 Alexis Menard <alexis.menard@openbossa.org>
  2077. [Qt] Unbreak debugging of WebKit2.
  2078. https://bugs.webkit.org/show_bug.cgi?id=85839
  2079. Reviewed by Simon Hausmann.
  2080. When you attach GDB to a running process, it stops it.
  2081. http://trac.webkit.org/changeset/115958 introduced a pause()
  2082. call to wait the debugger to be attached to then continue
  2083. the execution of the WebProcess. Unfortunately the pause()
  2084. function does not return unless a signal handler is called.
  2085. This patch introduce an event handler to exit from the paused
  2086. state when the debugger send the signal SIGCONT. The old code
  2087. works with older version of GDB (<7.0) but not with newer
  2088. versions where the behavior of pause() is correct.
  2089. * WebKitTestRunner/qt/main.cpp:
  2090. (sigcontHandler):
  2091. (main):
  2092. 2012-05-08 Christophe Dumez <christophe.dumez@intel.com>
  2093. [EFL][DRT] EFL's DRT does not fully support page visibility
  2094. https://bugs.webkit.org/show_bug.cgi?id=85032
  2095. Reviewed by Antonio Gomes.
  2096. * DumpRenderTree/LayoutTestController.cpp:
  2097. (resetPageVisibilityCallback): Fix incorrect argumentCount check.
  2098. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2099. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Properly
  2100. reset page visibility setting between tests.
  2101. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  2102. (LayoutTestController::setPageVisibility): Add support for "preview"
  2103. visibility state.
  2104. 2012-05-08 Gavin Peters <gavinp@chromium.org>
  2105. [webkit-patch] Return meaningful results from single-result queries.
  2106. https://bugs.webkit.org/show_bug.cgi?id=85367
  2107. Reviewed by Dirk Pranke.
  2108. Sometimes a quicksearch returns a single result by just redirecting to the page for that single
  2109. bug. This patch hacks around that by noticing the redirect target is a single page, and constructing
  2110. a result list consisting of that one bug.
  2111. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  2112. (BugzillaQueries._fetch_bugs_from_advanced_query):
  2113. 2012-05-08 Gavin Peters <gavinp@chromium.org>
  2114. [webkit-patch] Add new chrome-channels command to track down current chrome release channels for a committed bug.
  2115. https://bugs.webkit.org/show_bug.cgi?id=85368
  2116. Reviewed by Eric Seidel.
  2117. * Scripts/webkitpy/common/config/urls.py:
  2118. * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
  2119. (MockBugzillaQueries.fetch_bugs_matching_quicksearch):
  2120. * Scripts/webkitpy/common/net/omahaproxy.py: Added.
  2121. (OmahaProxy):
  2122. (OmahaProxy.__init__):
  2123. (OmahaProxy.set_url):
  2124. (OmahaProxy._json_url):
  2125. (OmahaProxy._get_json):
  2126. (OmahaProxy.get_revisions):
  2127. * Scripts/webkitpy/common/net/omahaproxy_unittest.py: Added.
  2128. (MockOmahaProxy):
  2129. (MockOmahaProxy.__init__):
  2130. (OmahaProxyTest):
  2131. (OmahaProxyTest.test_get_revisions):
  2132. * Scripts/webkitpy/tool/commands/__init__.py:
  2133. * Scripts/webkitpy/tool/commands/bugsearch.py:
  2134. (BugSearch):
  2135. * Scripts/webkitpy/tool/commands/chromechannels.py: Added.
  2136. (ChromeChannels):
  2137. (__init__):
  2138. (execute):
  2139. * Scripts/webkitpy/tool/commands/chromechannels_unittest.py: Added.
  2140. (MockOmahaProxy):
  2141. (MockOmahaProxy.get_revisions):
  2142. (TestableChromeChannels):
  2143. (TestableChromeChannels.__init__):
  2144. (ChromeChannelsTest):
  2145. (ChromeChannelsTest.test_single_bug):
  2146. (ChromeChannelsTest.test_with_query):
  2147. 2012-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
  2148. Unreviewed. Fix GTK+ unit tests.
  2149. * gtk/common.py:
  2150. (pkg_config_file_variable):
  2151. 2012-05-08 Carlos Garcia Campos <cgarcia@igalia.com>
  2152. [GTK] Google tests that time out are leaked
  2153. https://bugs.webkit.org/show_bug.cgi?id=84973
  2154. Reviewed by Philippe Normand.
  2155. Move Tools/Scripts/run-gtk-tests to Tools/gtk/run-api-tests
  2156. leaving run-gtk-tests as simple wrapper that runs run-api-tests in
  2157. a jhbuild environment when jhbuild is available.
  2158. * Scripts/run-gtk-tests: Run Tools/gtk/run-api-tests directly or
  2159. with jhbuild if present.
  2160. * gtk/common.py:
  2161. (pkg_config_file_variable): Generic function to get a variable
  2162. from a pkg-config file.
  2163. (prefix_of_pkg_config_file): Use pkg_config_file_variable with 'prefix'.
  2164. * gtk/run-api-tests: Copied from Tools/Scripts/run-gtk-tests.
  2165. (TestRunner.__init__): Use common.build_path() to get the programs path.
  2166. (TestRunner._lookup_atspi2_binary): Use
  2167. common.pkg_config_file_variable() to get the 'exec_prefix'.
  2168. (TestRunner._start_accessibility_daemons): Use subprocess.Popen()
  2169. directly instead of helper _create_process that has been removed.
  2170. (TestRunner._setup_testing_environment): Use subprocess.Popen()
  2171. directly instead of helper _create_process that has been
  2172. removed. Use common.top_level_path() and common.build_path()
  2173. instead of custom methods that have been removed too.
  2174. (TestRunner._run_test_command): Use subprocess.Popen() directly
  2175. instead of helper _create_process that has been removed.
  2176. 2012-05-08 Thiago Marcos P. Santos <thiago.santos@intel.com>
  2177. [EFL] [DRT] Clear extra views before setting a blank page
  2178. https://bugs.webkit.org/show_bug.cgi?id=85608
  2179. Reviewed by Kenneth Rohde Christiansen.
  2180. We need to clear the extra views before setting a blank page,
  2181. otherwise it will cause more events interactions and sometimes
  2182. trigger a unload(). This was causing frame-crash-with-page-cache.html
  2183. to leak events to the next test causing any subsequent test to
  2184. fail.
  2185. * DumpRenderTree/efl/DumpRenderTree.cpp:
  2186. (runTest):
  2187. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2188. (DumpRenderTreeChrome::clearExtraViews):
  2189. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  2190. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  2191. (DumpRenderTreeChrome):
  2192. 2012-05-08 Balazs Kelemen <kbalazs@webkit.org>
  2193. [Qt] X11 plugins need to be reworked for Qt5+WK1
  2194. https://bugs.webkit.org/show_bug.cgi?id=80691
  2195. Reviewed by Simon Hausmann.
  2196. Implement basic windowless plugin support with Qt5.
  2197. * qmake/mkspecs/features/features.prf:
  2198. Enable NPAPI plugins if X11 libraries are available.
  2199. * qmake/mkspecs/features/functions.prf:
  2200. Added a convenience function to determine availability
  2201. of X11 libraries.
  2202. 2012-05-07 Raphael Kubo da Costa <rakuco@webkit.org>
  2203. [webkitpy] Remove Python 2.5-specific workaround from http_server_base.py.
  2204. https://bugs.webkit.org/show_bug.cgi?id=85852
  2205. Reviewed by Dirk Pranke.
  2206. * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
  2207. (HttpServerBase._is_server_running_on_all_ports): Revert the part
  2208. of r89412 which was a workaround for an issue with Python 2.5 on
  2209. Mac 10.5.
  2210. 2012-05-07 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  2211. webkitdirs.pm: Make determineNumberOfCPUs work on FreeBSD.
  2212. https://bugs.webkit.org/show_bug.cgi?id=81481
  2213. Reviewed by Dirk Pranke.
  2214. FreeBSD has the same sysctl interface present in Darwin to query
  2215. the number of CPUs available, so use that too.
  2216. * Scripts/webkitdirs.pm:
  2217. (determineNumberOfCPUs): Share the sysctl call with Darwin.
  2218. (isFreeBSD): Added.
  2219. 2012-05-07 Alexis Menard <alexis.menard@openbossa.org>
  2220. Unreviewed Qt build fix in Debug.
  2221. We need some system includes here for getpid() to be recognized.
  2222. * WebKitTestRunner/qt/main.cpp:
  2223. 2012-05-07 Ojan Vafai <ojan@chromium.org>
  2224. When embedding the flakiness dashboard, hide popups when the frame is blurred.
  2225. https://bugs.webkit.org/show_bug.cgi?id=85684
  2226. Reviewed by Dirk Pranke.
  2227. If you show a popup, then click elsewhere in garden-o-matic, it will now
  2228. properly hide it.
  2229. * TestResultServer/static-dashboards/dashboard_base.js:
  2230. (showPopup):
  2231. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  2232. (showPopupForBuild):
  2233. (generatePageForIndividualTests.if):
  2234. (generatePageForIndividualTests):
  2235. * TestResultServer/static-dashboards/flakiness_dashboard_embedded_unittests.js: Added.
  2236. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2237. * TestResultServer/static-dashboards/run-embedded-unittests.html: Added.
  2238. 2012-05-07 Ian Vollick <vollick@chromium.org>
  2239. [chromium] WebViewHost should setCompositorSurfaceReady
  2240. https://bugs.webkit.org/show_bug.cgi?id=85418
  2241. Reviewed by James Robinson.
  2242. * DumpRenderTree/chromium/WebViewHost.cpp:
  2243. (WebViewHost::setWebWidget):
  2244. 2012-05-07 Jon Lee <jonlee@apple.com>
  2245. WebKitTestRunner needs layoutTestController.dumpFrameLoadCallbacks
  2246. https://bugs.webkit.org/show_bug.cgi?id=42331
  2247. <rdar://problem/8193641>
  2248. Reviewed by Darin Adler.
  2249. This patch sets up the framework for supporting dumpFrameLoadCallbacks, as well as
  2250. outputting some of the required strings. As tests become unskipped the other callbacks
  2251. can be supported.
  2252. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Add dumpFrameLoadCallbacks()
  2253. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  2254. (WTR::InjectedBundle::didReceiveMessage): pass in the dictionary containing keys needed to initialize
  2255. dump callbacks for the layoutTestController.
  2256. (WTR::InjectedBundle::booleanForKey): Helper function to extract boolean value from key in WKDictionaryRef.
  2257. Output some warning if we are trying to extract a value that is not a boolean.
  2258. (WTR::InjectedBundle::beginTesting): Update to take in the dictionary passed in by the TestController.
  2259. We cannot set the bits on the layoutTestController until it has been created in beginTesting().
  2260. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  2261. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  2262. (WTR::InjectedBundle::didReceiveMessage):
  2263. (WTR):
  2264. (WTR::InjectedBundle::beginTesting):
  2265. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  2266. (InjectedBundle):
  2267. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2268. (WTR):
  2269. (WTR::dumpFrameDescriptionSuitableForTestResult): Static function similar to
  2270. -[WebFrame _drt_descriptionSuitableForTestResult] in DumpRenderTree.
  2271. (WTR::InjectedBundlePage::didStartProvisionalLoadForFrame): Output string.
  2272. (WTR::InjectedBundlePage::didCommitLoadForFrame): Output string.
  2273. (WTR::InjectedBundlePage::didFinishLoadForFrame): Output string.
  2274. (WTR::InjectedBundlePage::didReceiveTitleForFrame): Output string.
  2275. (WTR::InjectedBundlePage::didCancelClientRedirectForFrame): Output string.
  2276. (WTR::InjectedBundlePage::willPerformClientRedirectForFrame): Output string. In WK1 it's
  2277. "willPerformClientRedirectToURL" so we will have to use that value here.
  2278. (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame): Output string.
  2279. (WTR::InjectedBundlePage::didHandleOnloadEventsForFrame): Output string.
  2280. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  2281. (WTR::LayoutTestController::LayoutTestController): Initialize to not dump frame load callbacks.
  2282. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  2283. (WTR::LayoutTestController::dumpFrameLoadCallbacks): Change to use setShouldDumpFrameLoadCallbacks.
  2284. (WTR::LayoutTestController::setShouldDumpFrameLoadCallbacks): Set bit.
  2285. (WTR::LayoutTestController::shouldDumpFrameLoadCallbacks): Return bit.
  2286. (LayoutTestController): Added m_dumpFrameLoadCallbacks to track whether to dump the output.
  2287. * WebKitTestRunner/TestInvocation.cpp:
  2288. (WTR::shouldLogFrameLoadDelegates): Similar to DRT.
  2289. (WTR::TestInvocation::invoke): Based on the URL loaded, set the bit in the dictionary that gets passed
  2290. to the injected bundle.
  2291. 2012-05-07 Tommy Widenflycht <tommyw@google.com>
  2292. [chromium] MediaStream API: Enhance WebUserMediaClientMock and add a test for it
  2293. https://bugs.webkit.org/show_bug.cgi?id=85618
  2294. Reviewed by Adam Barth.
  2295. Adding the capability to control which MediaStreamTracks actually get created,
  2296. and adding a test that exercises the JS api using that capability.
  2297. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  2298. (WebKit::WebUserMediaClientMock::requestUserMedia):
  2299. * DumpRenderTree/chromium/WebUserMediaClientMock.h:
  2300. * DumpRenderTree/chromium/WebViewHost.cpp:
  2301. (WebViewHost::testMediaStreamClient):
  2302. * DumpRenderTree/chromium/WebViewHost.h:
  2303. (WebViewHost):
  2304. 2012-05-07 Zan Dobersek <zandobersek@gmail.com>
  2305. [Gtk] WebGL feature is not built anymore through build-webkit after r116251
  2306. https://bugs.webkit.org/show_bug.cgi?id=85788
  2307. Reviewed by Martin Robinson.
  2308. Enable WebGL by default for the Gtk port. The feature is already enabled by
  2309. default in configure.ac, so there's no reason it shouldn't be enabled when
  2310. building through build-webkit.
  2311. * Scripts/webkitperl/FeatureList.pm:
  2312. 2012-05-07 Csaba Osztrogonác <ossy@webkit.org>
  2313. Unittest fix after r116288, because now there are more than 5 hit for the 'Eric' word.
  2314. We have only 2 'Gavin', so it is a better choice than 'Eric' for unit testing.
  2315. Reviewed by Tor Arne Vestbø.
  2316. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  2317. (IRCCommandTest.test_whois):
  2318. 2012-05-07 Sheriff Bot <webkit.review.bot@gmail.com>
  2319. Unreviewed, rolling out r116299, r116301, and r116303.
  2320. http://trac.webkit.org/changeset/116299
  2321. http://trac.webkit.org/changeset/116301
  2322. http://trac.webkit.org/changeset/116303
  2323. https://bugs.webkit.org/show_bug.cgi?id=85795
  2324. Build is still broken (Requested by Ossy on #webkit).
  2325. * DumpRenderTree/qt/DumpRenderTree.pro:
  2326. * DumpRenderTree/qt/main.cpp:
  2327. (main):
  2328. * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Removed.
  2329. * QtTestPlatformPlugin/TestIntegration.cpp: Removed.
  2330. * QtTestPlatformPlugin/TestIntegration.h: Removed.
  2331. * QtTestPlatformPlugin/mac/TestFontDatabase.h: Removed.
  2332. * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Removed.
  2333. * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Removed.
  2334. * QtTestPlatformPlugin/main.cpp: Removed.
  2335. * QtTestPlatformPlugin/testplatform.json: Removed.
  2336. * Tools.pro:
  2337. * WebKitTestRunner/Target.pri:
  2338. * WebKitTestRunner/qt/main.cpp:
  2339. (main):
  2340. 2012-05-07 Balazs Kelemen <kbalazs@webkit.org>
  2341. Unreviewed Qt build fix.
  2342. One more try to learn how to use
  2343. const with a pointer array.
  2344. * DumpRenderTree/qt/main.cpp:
  2345. (initializeTestPlatformPlugin):
  2346. 2012-05-07 Balazs Kelemen <kbalazs@webkit.org>
  2347. Unreviewed build fix after r116299.
  2348. * DumpRenderTree/qt/main.cpp:
  2349. (initializeTestPlatformPlugin):
  2350. 2012-05-07 Balazs Kelemen <kbalazs@webkit.org>
  2351. [Qt] Add test specific platform plugin to achieve unified layout test results
  2352. https://bugs.webkit.org/show_bug.cgi?id=80996
  2353. Reviewed by Simon Hausmann.
  2354. Added QtTestPlatformPlugin as a new project under Tools.
  2355. This is a Qt5-ish platform plugin that can be used to tweak the
  2356. platform support interfaces in order to unify layout test results.
  2357. For now it only overrides the font database on Mac and redirects
  2358. everything else to the real platform plugin. The font database it
  2359. provides mimics the way how we set up test fonts with fontconfig on Linux.
  2360. Make DumpRenderTree and WebKitTestRunner use this platform plugin.
  2361. * DumpRenderTree/qt/DumpRenderTree.pro:
  2362. * DumpRenderTree/qt/main.cpp:
  2363. (initializeTestPlatformPlugin):
  2364. (main):
  2365. * QtTestPlatformPlugin/QtTestPlatformPlugin.pro: Added.
  2366. * QtTestPlatformPlugin/TestIntegration.cpp: Added.
  2367. (TestIntegration::TestIntegration):
  2368. (TestIntegration::fontDatabase):
  2369. * QtTestPlatformPlugin/TestIntegration.h: Added.
  2370. (TestIntegration):
  2371. (TestIntegration::hasCapability):
  2372. (TestIntegration::createPlatformPixmap):
  2373. (TestIntegration::createPlatformWindow):
  2374. (TestIntegration::createPlatformBackingStore):
  2375. (TestIntegration::createPlatformOpenGLContext):
  2376. (TestIntegration::createPlatformSharedGraphicsCache):
  2377. (TestIntegration::guiThreadEventDispatcher):
  2378. (TestIntegration::clipboard):
  2379. (TestIntegration::drag):
  2380. (TestIntegration::inputContext):
  2381. (TestIntegration::accessibility):
  2382. (TestIntegration::nativeInterface):
  2383. (TestIntegration::services):
  2384. (TestIntegration::styleHint):
  2385. (TestIntegration::platformTheme):
  2386. * QtTestPlatformPlugin/mac/TestFontDatabase.h: Added.
  2387. (TestFontDatabase):
  2388. * QtTestPlatformPlugin/mac/TestFontDatabase.mm: Added.
  2389. (TestFontDatabase::populateFontDatabase):
  2390. * QtTestPlatformPlugin/mac/TestIntegrationMac.mm: Added.
  2391. (TestIntegration::fontDatabase):
  2392. * QtTestPlatformPlugin/main.cpp: Added.
  2393. (TestIntegrationPlugin::keys):
  2394. (TestIntegrationPlugin::create):
  2395. (TestIntegrationPlugin::initialize):
  2396. * QtTestPlatformPlugin/testplatform.json: Added.
  2397. * Tools.pro:
  2398. * WebKitTestRunner/Target.pri:
  2399. * WebKitTestRunner/qt/main.cpp:
  2400. (main):
  2401. 2012-05-07 Christophe Dumez <christophe.dumez@intel.com>
  2402. [EFL] media/video-poster-blocked-by-willsendrequest.html is flaky
  2403. https://bugs.webkit.org/show_bug.cgi?id=85609
  2404. Reviewed by Simon Hausmann.
  2405. Flakiness was caused by the fact that
  2406. media/crash-closing-page-with-media-as-plugin-fallback.html and
  2407. media/video-poster-blocked-by-willsendrequest.html use the same PNG
  2408. file as poster attribute in the video tag. The PNG file gets cached
  2409. when the first test is executed and this somehow causes the second
  2410. test to fail.
  2411. The flakiness was addressed by clearing the memory and page caches
  2412. between tests.
  2413. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2414. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  2415. 2012-05-07 Eric Seidel <eric@webkit.org>
  2416. Add values for all features to Qt's features.pri
  2417. https://bugs.webkit.org/show_bug.cgi?id=85746
  2418. Reviewed by Tor Arne Vestbø.
  2419. When generate-feature-files generates features.pri it provides a value
  2420. for every possible ENABLE_. In prepration for landing generate-feature-files
  2421. it seems appropriate to add a value for all possible ENABLEs to the existing
  2422. features.pri. This lets me make sure that I'm getting them all right!
  2423. * qmake/mkspecs/features/features.pri:
  2424. 2012-05-07 Adam Bergkvist <adam.bergkvist@ericsson.com>
  2425. Added myself as a committer.
  2426. Not reviewed.
  2427. * Scripts/webkitpy/common/config/committers.py:
  2428. 2012-05-07 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  2429. [EFL][DRT] Implement LayoutTestController::execCommand
  2430. https://bugs.webkit.org/show_bug.cgi?id=82286
  2431. Reviewed by Antonio Gomes.
  2432. Add missing implementation execCommand and isCommandEnabled to EFL's
  2433. LayoutTestController.
  2434. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  2435. (LayoutTestController::execCommand):
  2436. (LayoutTestController::isCommandEnabled):
  2437. 2012-05-06 Hayato Ito <hayato@chromium.org>
  2438. [prepare-ChangeLog] Excludes a reference file used by reftests from test files.
  2439. https://bugs.webkit.org/show_bug.cgi?id=74268
  2440. Reviewed by Ryosuke Niwa.
  2441. * Scripts/prepare-ChangeLog:
  2442. (generateFileList):
  2443. 2012-05-06 Mary Wu <mary.wu@torchmobile.com.cn>
  2444. Add a contributor to committers.py
  2445. https://bugs.webkit.org/show_bug.cgi?id=85761
  2446. Reviewed by Unreviewed.
  2447. Add myself to committers.py contributor.
  2448. * Scripts/webkitpy/common/config/committers.py:
  2449. 2012-05-06 Dan Bernstein <mitz@apple.com>
  2450. Tools part of: Building and debugging WebKit in the Xcode IDE requires a lot of setup
  2451. https://bugs.webkit.org/show_bug.cgi?id=85739
  2452. Reviewed by Daniel Bates.
  2453. * Scripts/build-webkit: Moved code that copies from WebKitLibraries to the product directory
  2454. from here...
  2455. * Scripts/copy-webkitlibraries-to-product-directory: ...to this new script.
  2456. 2012-05-06 Andy Estes <aestes@apple.com>
  2457. Fix the build after r116246.
  2458. * DumpRenderTree/LayoutTestController.cpp: Remove an unused function.
  2459. 2012-05-06 Eric Seidel <eric@webkit.org>
  2460. Update several build-webkit options to match the #defines they toggle
  2461. https://bugs.webkit.org/show_bug.cgi?id=85744
  2462. Reviewed by Adam Barth.
  2463. Most notable here is fixing --3d-canvas to be --webgl these days --
  2464. the define was renamed 15 months ago!
  2465. * Scripts/webkitperl/FeatureList.pm:
  2466. 2012-05-06 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  2467. [EFL] EFL's LayoutTestController setJavaScriptCanAccessClipboard implementation
  2468. https://bugs.webkit.org/show_bug.cgi?id=83687
  2469. Reviewed by Antonio Gomes.
  2470. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  2471. (LayoutTestController::setJavaScriptCanAccessClipboard):
  2472. 2012-05-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  2473. Convert isPageBoxVisible to use Internals interface.
  2474. https://bugs.webkit.org/show_bug.cgi?id=85692
  2475. Reviewed by Darin Adler.
  2476. Remove isPageBoxVisible functions, because it is able to work in the
  2477. cross-port way through the Internals interface.
  2478. * DumpRenderTree/LayoutTestController.cpp:
  2479. (LayoutTestController::staticFunctions):
  2480. * DumpRenderTree/LayoutTestController.h:
  2481. (LayoutTestController):
  2482. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  2483. * DumpRenderTree/chromium/LayoutTestController.cpp:
  2484. (LayoutTestController::LayoutTestController):
  2485. * DumpRenderTree/chromium/LayoutTestController.h:
  2486. (LayoutTestController):
  2487. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  2488. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  2489. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  2490. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  2491. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  2492. (LayoutTestController):
  2493. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  2494. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  2495. 2012-05-06 Tom Zakrajsek <tomz@codeaurora.org>
  2496. sheriffbot isn't reopening patches after it lands rollouts
  2497. https://bugs.webkit.org/show_bug.cgi?id=64418
  2498. Reviewed by Adam Barth.
  2499. * Scripts/webkitpy/tool/commands/download_unittest.py:
  2500. * Scripts/webkitpy/tool/steps/createbug.py:
  2501. (CreateBug.run):
  2502. 2012-05-04 Raphael Kubo da Costa <rakuco@webkit.org>
  2503. webkitpy: Use os.pathsep instead of manually finding out the path separator in NRWT.
  2504. https://bugs.webkit.org/show_bug.cgi?id=85697
  2505. Reviewed by Eric Seidel.
  2506. * Scripts/new-run-webkit-tests: Instead of manually detecting whether
  2507. the path separator should be ':' or ';' by checking sys.platform, rely
  2508. on os.pathsep which has exactly the same information (os.pathsep is
  2509. ':' for Cygwin, from what I could check in Python's sources).
  2510. 2012-05-05 Sheriff Bot <webkit.review.bot@gmail.com>
  2511. Unreviewed, rolling out r116223.
  2512. http://trac.webkit.org/changeset/116223
  2513. https://bugs.webkit.org/show_bug.cgi?id=85718
  2514. The bots need to set XDG_DATA_DIRS (Requested by rakuco on
  2515. #webkit).
  2516. * efl/jhbuildrc:
  2517. * gtk/jhbuildrc:
  2518. 2012-05-05 Raphael Kubo da Costa <rakuco@webkit.org>
  2519. [jhbuild] Do not set XDG_DATA_DIRS in jhbuildrc.
  2520. https://bugs.webkit.org/show_bug.cgi?id=85717
  2521. Reviewed by Martin Robinson.
  2522. After r116209, the XDG_DATA_DIRS environment variable is now
  2523. passed by webkitpy's layout_tests code to run-with-jhbuild, so
  2524. instead of setting a few defaults in jhbuildrc we can now rely on
  2525. the values set and really used by each system.
  2526. * efl/jhbuildrc:
  2527. * gtk/jhbuildrc:
  2528. 2012-05-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2529. [Qt] Buildfix for --minimal build after r116107.
  2530. Reviewed by Csaba Osztrogonác.
  2531. * qmake/mkspecs/features/features.prf:
  2532. 2012-05-05 Zan Dobersek <zandobersek@gmail.com>
  2533. [Gtk] GtkDriver is not required anymore after r116134
  2534. https://bugs.webkit.org/show_bug.cgi?id=85699
  2535. Reviewed by Csaba Osztrogonác.
  2536. Remove GtkDriver as it was replaced by the XvfbDriver and is
  2537. no longer needed.
  2538. * Scripts/webkitpy/layout_tests/port/gtk.py:
  2539. 2012-05-05 Zan Dobersek <zandobersek@gmail.com>
  2540. Increase the display ID for the Xvfb process to use if pixel_tests argument
  2541. is true rather than if pixel_tests option is present. This fixes the
  2542. XvfbDriver in the same way r115825 fixed the now-redundant GtkDriver.
  2543. Rubber-stamped by Csaba Osztrogonác.
  2544. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
  2545. (XvfbDriver._start):
  2546. 2012-05-04 Raphael Kubo da Costa <rakuco@webkit.org>
  2547. webkitpy: Preserve XDG_DATA_DIRS in the environment passed to ServerProcess.
  2548. https://bugs.webkit.org/show_bug.cgi?id=85694
  2549. Reviewed by Martin Robinson.
  2550. This is sort of a follow-up to r100674: $XDG_DATA_DIRS should be
  2551. preserved, as it is particularly useful for Linux/Unix
  2552. environments. As a real use case, if shared-mime-info is
  2553. installed into a non-trivial prefix, Glib and other libraries will
  2554. have trouble to properly identify mimetypes (in ResourceResponses,
  2555. for example) as the base freedesktop.org mimetype file will not be
  2556. found.
  2557. * Scripts/webkitpy/layout_tests/port/base.py:
  2558. (Port.to.setup_environ_for_server):
  2559. 2012-05-04 Gustavo Noronha Silva <gns@gnome.org>
  2560. [GTK] Simplify how libWebCoreModules is linked in, and fix WebKit2 build
  2561. https://bugs.webkit.org/show_bug.cgi?id=85691
  2562. * GNUmakefile.am: no longer link libWebCoreModules to DumpRenderTree.
  2563. 2012-05-04 Eric Seidel <eric@webkit.org>
  2564. Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
  2565. https://bugs.webkit.org/show_bug.cgi?id=85583
  2566. Reviewed by Daniel Bates.
  2567. * Scripts/webkitperl/FeatureList.pm:
  2568. 2012-05-04 Eric Seidel <eric@webkit.org>
  2569. Sort entries in FeaturesList.pm to make them easier to autogenerate
  2570. https://bugs.webkit.org/show_bug.cgi?id=85584
  2571. Reviewed by Daniel Bates.
  2572. No functional changes, only sorting.
  2573. * Scripts/webkitperl/FeatureList.pm:
  2574. 2012-05-04 Andy Estes <aestes@apple.com>
  2575. REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
  2576. https://bugs.webkit.org/show_bug.cgi?id=85675
  2577. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
  2578. (TestWebKitAPI::TEST): Disable the test.
  2579. 2012-04-30 Jer Noble <jer.noble@apple.com>
  2580. Full screen will exit during a provisional load of a non-ancestor iframe.
  2581. https://bugs.webkit.org/show_bug.cgi?id=85230
  2582. Reviewed by Maciej Stachowiak .
  2583. Add support for the new UIDelegate webView:closeFullScreenWithListener: method:
  2584. * DumpRenderTree/mac/UIDelegate.mm:
  2585. (-[UIDelegate webView:closeFullScreenWithListener:]):
  2586. Add support for the new closeFullScreen injected bundle method:
  2587. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  2588. (WTR::InjectedBundlePage::InjectedBundlePage):
  2589. (WTR::InjectedBundlePage::closeFullScreen):
  2590. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  2591. 2012-05-04 Ojan Vafai <ojan@chromium.org>
  2592. Fix test naming to be camel-case like the methods they are testing.
  2593. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2594. (test):
  2595. 2012-05-04 Ojan Vafai <ojan@chromium.org>
  2596. Show the results links in the embedded flakiness dashboard
  2597. https://bugs.webkit.org/show_bug.cgi?id=85660
  2598. Reviewed by Adam Barth.
  2599. Turns out these links don't add much visual noise and it's annoying
  2600. to have to go to the dashboard from garden-o-matic just to view the
  2601. results for a test.
  2602. This is useful for cases where garden-o-matic doesn't properly show the
  2603. results (e.g. missing tests). If we address all those cases, then
  2604. we could easily hide the results links again if we wanted to.
  2605. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  2606. (showUpdateInfoForTest):
  2607. (htmlForIndividualTestOnAllBuildersWithResultsLinks):
  2608. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2609. (test):
  2610. 2012-05-04 Dirk Pranke <dpranke@chromium.org>
  2611. Revert to using chromium --test-shell mode on SL in NRWT
  2612. https://bugs.webkit.org/show_bug.cgi?id=83076
  2613. Unreviewed, build fix.
  2614. We seem to be seeing a lot more flakiness on the bot since
  2615. I switched NRWT to "DRT" mode. We'll try reverting back and
  2616. see if this helps things.
  2617. * Scripts/webkitpy/layout_tests/port/chromium.py:
  2618. (ChromiumDriver.__init__):
  2619. 2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
  2620. [EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
  2621. https://bugs.webkit.org/show_bug.cgi?id=84941
  2622. Reviewed by Martin Robinson.
  2623. Print MIME type detection messages in EFL's DumpRenderTree if
  2624. LayoutTestController's dumpResourceResponseMIMETypes() returns true.
  2625. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2626. (DumpRenderTreeChrome::onResponseReceived):
  2627. 2012-05-04 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  2628. [GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
  2629. https://bugs.webkit.org/show_bug.cgi?id=85134
  2630. Reviewed by Martin Robinson.
  2631. Add missing implementation setDefersLoading and goBack to GTK's
  2632. LayoutTestController so that the test case rely on these methods
  2633. can be enabled.
  2634. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  2635. (resetDefaultsToConsistentValues):
  2636. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  2637. (LayoutTestController::goBack):
  2638. (LayoutTestController::setDefersLoading):
  2639. 2012-05-04 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  2640. [Qt][NRWT] Run each DRT in it's own xvfb
  2641. https://bugs.webkit.org/show_bug.cgi?id=77335
  2642. Reviewed by Dirk Pranke.
  2643. * Scripts/webkitpy/layout_tests/port/gtk.py:
  2644. (GtkPort._driver_class):
  2645. * Scripts/webkitpy/layout_tests/port/qt.py:
  2646. (QtPort._driver_class):
  2647. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
  2648. (XvfbDriver):
  2649. (XvfbDriver._start):
  2650. (XvfbDriver._start.x_filter):
  2651. (XvfbDriver.stop):
  2652. 2012-05-04 Zan Dobersek <zandobersek@gmail.com>
  2653. Use destructuring assingment for the return values of the
  2654. port.diff_image() method call.
  2655. Rubber-stamped by Dirk Pranke.
  2656. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  2657. (write_test_result):
  2658. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2659. Store fewer runs by default in the flakiness dashboard
  2660. https://bugs.webkit.org/show_bug.cgi?id=85568
  2661. Reviewed by Dirk Pranke.
  2662. This will greatly shrink the size of the json files we load,
  2663. resulting in a much faster initial load. People rarely care
  2664. about more than 100 runs. For the cases they do, they can still click
  2665. the show all runs checkbox to show 500 runs.
  2666. * TestResultServer/model/jsonresults.py:
  2667. 2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
  2668. [EFL] Frame load callbacks output is missing for redirections
  2669. https://bugs.webkit.org/show_bug.cgi?id=85173
  2670. Reviewed by Antonio Gomes.
  2671. Catch the new ewk_frame signals to print the expected output in case
  2672. of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
  2673. returns true.
  2674. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2675. (DumpRenderTreeChrome::createView):
  2676. (DumpRenderTreeChrome::onWillSendRequest):
  2677. (DumpRenderTreeChrome::onFrameCreated):
  2678. (DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
  2679. (DumpRenderTreeChrome::onFrameRedirectRequested):
  2680. (DumpRenderTreeChrome::onResponseReceived):
  2681. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  2682. (DumpRenderTreeChrome):
  2683. 2012-05-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2684. [Qt] Fix up warning about missing GLib/Gio/GStreamer
  2685. We don't actually fall back.
  2686. Rubber-stamped by Csaba Osztrogonác.
  2687. * qmake/mkspecs/features/features.prf:
  2688. 2012-05-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2689. [Qt] Clarify warning about missing GLib/Gio/GStreamer for media support
  2690. And only print it once.
  2691. Reviewed by Csaba Osztrogonác.
  2692. * qmake/mkspecs/features/features.prf:
  2693. 2012-05-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  2694. [Qt] Clean up and split features.prf into a static list of defaults
  2695. The static list of feature defaults is used as a fallback for any
  2696. feature that's not dynamically detected or overriden on the command
  2697. line (though build-webkit or passing DEFINES+= to qmake).
  2698. The static list is complete, which allows for auto-generation based
  2699. on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)
  2700. https://bugs.webkit.org/show_bug.cgi?id=85611
  2701. Reviewed by Simon Hausmann.
  2702. * Scripts/build-webkit:
  2703. * Tools.pro:
  2704. * qmake/mkspecs/features/features.prf:
  2705. * qmake/mkspecs/features/features.pri: Added.
  2706. 2012-05-04 Sheriff Bot <webkit.review.bot@gmail.com>
  2707. Unreviewed, rolling out r116085, r116091, and r116095.
  2708. http://trac.webkit.org/changeset/116085
  2709. http://trac.webkit.org/changeset/116091
  2710. http://trac.webkit.org/changeset/116095
  2711. https://bugs.webkit.org/show_bug.cgi?id=85628
  2712. We are not ready with dependencies on all platform yet (mac) +
  2713. problems with debug builds. (Requested by Zoltan on #webkit).
  2714. * qmake/mkspecs/features/features.prf:
  2715. 2012-05-04 Christophe Dumez <christophe.dumez@intel.com>
  2716. [EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
  2717. https://bugs.webkit.org/show_bug.cgi?id=85171
  2718. Reviewed by Andreas Kling.
  2719. Implement support for overriding "WebKitLoadSiteIconsKey" setting in
  2720. EFL's LayoutTestController.
  2721. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2722. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  2723. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  2724. (LayoutTestController::overridePreference):
  2725. 2012-05-03 Alexis Menard <alexis.menard@openbossa.org>
  2726. [Qt] Enable fullscreen API for WebKit2.
  2727. https://bugs.webkit.org/show_bug.cgi?id=85498
  2728. Reviewed by Simon Hausmann.
  2729. Enable the fullscreen API on the MiniBrowser and turn
  2730. it default on WebKit2, disable it on WK1.
  2731. * MiniBrowser/qt/BrowserWindow.cpp:
  2732. (BrowserWindow::BrowserWindow):
  2733. * MiniBrowser/qt/qml/BrowserWindow.qml:
  2734. * Scripts/webkitperl/FeatureList.pm:
  2735. * qmake/mkspecs/features/features.prf:
  2736. 2012-05-04 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  2737. REGRESSION(r116008) old-run-webkit-tests broken
  2738. https://bugs.webkit.org/show_bug.cgi?id=85597
  2739. Reviewed by Simon Hausmann.
  2740. Reinstate libraryContainsSymbol.
  2741. * Scripts/webkitperl/features.pm:
  2742. (libraryContainsSymbol):
  2743. 2012-05-04 Zoltan Horvath <zoltan@webkit.org>
  2744. [Qt] Set WebCore imagedecoders as default and add fallback to QImageDecoder
  2745. https://bugs.webkit.org/show_bug.cgi?id=80400
  2746. Remove WTF_USE_QT_IMAGE_DECODER macro.
  2747. Reviewed by Simon Hausmann.
  2748. * qmake/mkspecs/features/features.prf:
  2749. 2012-05-03 Christophe Dumez <christophe.dumez@intel.com>
  2750. [EFL] DRT should obey layoutTestController's addURLToRedirect()
  2751. https://bugs.webkit.org/show_bug.cgi?id=82722
  2752. Reviewed by Maciej Stachowiak.
  2753. Implement support for layoutTestController's addURLToRedirect()
  2754. in EFL's DRT so that it redirects properly when indicated.
  2755. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2756. (DumpRenderTreeChrome::onWillSendRequest):
  2757. 2012-05-03 Christophe Dumez <christophe.dumez@intel.com>
  2758. [EFL] DRT should support LayoutTestController's willSendRequestReturnsNullOnRedirect()
  2759. https://bugs.webkit.org/show_bug.cgi?id=82704
  2760. Reviewed by Antonio Gomes.
  2761. EFL's DRT needs to obey LayoutTestController's
  2762. willSendRequestReturnsNullOnRedirect().
  2763. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  2764. (DumpRenderTreeChrome::onWillSendRequest):
  2765. 2012-05-03 Raphael Kubo da Costa <rakuco@webkit.org>
  2766. git-add-reviewer: Do not put the bug title and its URL in the same line in the commit message.
  2767. https://bugs.webkit.org/show_bug.cgi?id=85570
  2768. Reviewed by Adam Roben.
  2769. The standard format of commit messages and ChangeLog entries has a
  2770. short summary in the first line, followed by the bug URL in
  2771. Bugzilla. Passing "%s" in the pretty format line to git-rev-list
  2772. merges these two lines into a single one separated by a space
  2773. character, which is not what we want.
  2774. Since "%s%n%n%b" is in practice "%B" (raw message), use it
  2775. instead, as the first two lines do not end up being merged
  2776. together.
  2777. * Scripts/git-add-reviewer:
  2778. (writeCommitMessageToFile):
  2779. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2780. Improve UI for garden-o-matic examine view when there are fewer than 5 tests.
  2781. https://bugs.webkit.org/show_bug.cgi?id=85566
  2782. Reviewed by Adam Barth.
  2783. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  2784. (.):
  2785. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  2786. (.):
  2787. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  2788. 2012-05-03 Raphael Kubo da Costa <rakuco@webkit.org>
  2789. webkitpy: Recognize FreeBSD as a valid platform.
  2790. https://bugs.webkit.org/show_bug.cgi?id=81467
  2791. Reviewed by Adam Barth.
  2792. Add PlatformInfo.is_freebsd() so that trying to use webkit-patch
  2793. on FreeBSD does not raise an "unrecognized platform" exception.
  2794. Most of this patch contains some unit tests for the mentioned
  2795. method, as currently platform-specific code is needed only on
  2796. Windows.
  2797. * Scripts/webkitpy/common/system/platforminfo.py:
  2798. (PlatformInfo.__init__):
  2799. (PlatformInfo.is_freebsd):
  2800. (PlatformInfo._determine_os_name):
  2801. * Scripts/webkitpy/common/system/platforminfo_mock.py:
  2802. (MockPlatformInfo.is_freebsd):
  2803. * Scripts/webkitpy/common/system/platforminfo_unittest.py:
  2804. (fake_platform):
  2805. (fake_platform.FakePlatformModule.release):
  2806. (TestPlatformInfo.test_real_code):
  2807. (TestPlatformInfo.test_os_name_and_wrappers):
  2808. (TestPlatformInfo.test_os_version):
  2809. (TestPlatformInfo.test_display_name):
  2810. (TestPlatformInfo.test_total_bytes_memory):
  2811. (TestPlatformInfo.test_free_bytes_memory):
  2812. * Scripts/webkitpy/layout_tests/port/factory.py:
  2813. (PortFactory._default_port):
  2814. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2815. Make the table headers white-space:nowrap. This decreases the vertical size,
  2816. which makes for more minimal embedding in garden-o-matic.
  2817. * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
  2818. (.table-header-content *):
  2819. 2012-05-03 Eric Seidel <eric@webkit.org>
  2820. Split build-webkit's feature option list off into its own module in preparation for autogeneration
  2821. https://bugs.webkit.org/show_bug.cgi?id=85548
  2822. Reviewed by Daniel Bates.
  2823. My Perl-fu is very weak. This moves the feature option list off into a separate module
  2824. file so that I can easily autogenerate just that file with the fancy new generate-feature-files command.
  2825. It's a bit odd to have an array which we return out to build-webkit to modify, but it turns out
  2826. not to matter. Also, build-webkit doesn't actually use any of the variables we're using to
  2827. store the results from the option parse, so those end up inaccessible from build-webkit (except by reference)
  2828. which is actually cleaner. Callers can't assume that they would get a new array every time, but someone
  2829. with more Perl-fu than I could create something fancier than this if we need in the future.
  2830. * Scripts/build-webkit:
  2831. * Scripts/webkitperl/FeatureList.pm: Added.
  2832. (getFeatureOptionList):
  2833. 2012-05-03 Dirk Pranke <dpranke@chromium.org>
  2834. REGRESSION: run-webkit-tests failing on Chromium Mac
  2835. https://bugs.webkit.org/show_bug.cgi?id=85459
  2836. Unreviewed, build fix.
  2837. Turns out select doesn't throw IOErrors, it has it's own kind of
  2838. error :(. Trap that instead.
  2839. * Scripts/webkitpy/layout_tests/port/server_process.py:
  2840. (ServerProcess._wait_for_data_and_update_buffers_using_select):
  2841. 2012-05-03 Raphael Kubo da Costa <rakuco@webkit.org>
  2842. [CMake] Rewrite FindCairo.cmake.
  2843. https://bugs.webkit.org/show_bug.cgi?id=84895
  2844. Reviewed by Daniel Bates.
  2845. The old approach relied on pkg-config for finding Cairo (which
  2846. introduced a dependency on pkg-config that could be avoided), used
  2847. the LibFindMacros code that we should probably remove in the
  2848. future and did not use the FindPackageHandleStandardArguments
  2849. module.
  2850. Change all that by rewriting the module.
  2851. - Use the pkg-config output optionally instead of requiring it
  2852. like LibFindMacros did.
  2853. - Remove the implicit dependency on FreeType which often found it
  2854. the wrong way via pkg-config and without considering
  2855. CMAKE_PREFIX_PATH.
  2856. - Retrieve the Cairo version by looking at cairo-version.h instead
  2857. of relying on pkg-config. It requires some additional code for
  2858. checking if the desired version has been found, but that will not
  2859. be needed once we start depending on CMake 2.8.3 or later.
  2860. The only downside is that FPHSA sets <UPPERCASED_NAME>_FOUND
  2861. instead of <Name>_FOUND, and to keep things consistent
  2862. Cairo_LIBRARIES and Cairo_INCLUDE_DIRS have become CAIRO_LIBRARIES
  2863. and CAIRO_INCLUDE_DIRS.
  2864. * DumpRenderTree/efl/CMakeLists.txt: Use CAIRO_FOO instead of
  2865. Cairo_FOO.
  2866. * EWebLauncher/CMakeLists.txt: Ditto.
  2867. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2868. Fix modifier and bug sorting on the flakiness dashboard
  2869. https://bugs.webkit.org/show_bug.cgi?id=85554
  2870. Reviewed by Dirk Pranke.
  2871. The sorting assumes that the column header name matches a field
  2872. in the testResults object and uses that field for sorting.
  2873. Filter the bugs out of the modifiers list and put them in a bugs field
  2874. and only put the non-bug modifiers in the modifiers list.
  2875. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  2876. (populateExpectationsData):
  2877. (htmlForSingleTestRow):
  2878. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2879. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2880. Fix some state resetting when running unittests. HtmlForSingleTestRow
  2881. was flaky.
  2882. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  2883. (htmlForSingleTestRow):
  2884. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2885. (resetGlobals):
  2886. 2012-05-03 Raphael Kubo da Costa <rakuco@webkit.org>
  2887. webkitpy: Use PlatformInfo wherever possible in the User class.
  2888. https://bugs.webkit.org/show_bug.cgi?id=85549
  2889. Reviewed by Dirk Pranke.
  2890. Instead of relying on sys.platform to detect whether the current
  2891. platform is a Mac, use the PlatformInfo class instead.
  2892. * Scripts/webkitpy/common/system/user.py:
  2893. (User.__init__):
  2894. (User.edit_changelog):
  2895. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2896. Remove the percent failed column from the flakiness dashboard
  2897. https://bugs.webkit.org/show_bug.cgi?id=85552
  2898. Reviewed by Dirk Pranke.
  2899. This column isn't useful enough to justify the visual noise.
  2900. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  2901. (processMissingAndExtraExpectations):
  2902. (tableHeaders):
  2903. (htmlForSingleTestRow):
  2904. (sortTests):
  2905. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2906. (test):
  2907. 2012-05-03 Eric Seidel <eric@webkit.org>
  2908. --coverage should not not use the "feature" options system in build-webkit, similarly remove special-casing for WTF_URL
  2909. https://bugs.webkit.org/show_bug.cgi?id=85542
  2910. Reviewed by Daniel Bates.
  2911. Remove these last two odd-men-out, so that we can generate the default feature options
  2912. for build-webkit using the new generate-feature-files command.
  2913. The Mac build system has some special casing for ENABLE_ defines which gets them
  2914. defined as -D on the build command, even though initially they start out as
  2915. environment variables ENABLE_FOO = ENABLE_FOO. The Feature options in build-webkit
  2916. depend on this support, but it doesn't work for WTF_USE_ defines like WTF_USE_WTF_URL.
  2917. I'm told that WTF_URL is not actively being worked on, so just removing it for now.
  2918. It should probably come back to life as an ENABLE_, or build-webkit or the Xcode projects
  2919. should be made generically smarter about these USE_WTF defines.
  2920. (There is still WTF_USE_TILED_BACKING_STORE in the feature list, but it only seems
  2921. used by Qt. If someone tried build-webkit --tiled-backing-store on Mac today it
  2922. would not work!)
  2923. * Scripts/build-webkit:
  2924. 2012-05-03 Eric Seidel <eric@webkit.org>
  2925. Remove the last bits of Leopard support from our perl scripts
  2926. https://bugs.webkit.org/show_bug.cgi?id=85545
  2927. Reviewed by Daniel Bates.
  2928. Chromium still supports Leopard (for a little while yet), but AppleMacWebKit dropped
  2929. Leopard support several months ago. Remove the last bits of isLeopard() branching
  2930. in our Perl scripts, since no one is using this (Chromium has never used this Perl code).
  2931. * Scripts/build-webkit:
  2932. * Scripts/old-run-webkit-tests:
  2933. (countAndPrintLeaks):
  2934. (captureSavedCrashLog):
  2935. * Scripts/webkitdirs.pm:
  2936. (determineArchitecture):
  2937. (argumentsForRunAndDebugMacWebKitApp):
  2938. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2939. [Chromium] Don't show the WebKit Linux ASAN bot on the flakiness dashboard.
  2940. https://bugs.webkit.org/show_bug.cgi?id=85551
  2941. Reviewed by Dirk Pranke.
  2942. It's not uploading results and in the short term we don't plan to have it start.
  2943. * TestResultServer/static-dashboards/builders.js:
  2944. (isChromiumWebkitTipOfTreeTestRunner):
  2945. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2946. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2947. Show the test name in the dashboard if showChrome==false and we're showing multiple tests
  2948. https://bugs.webkit.org/show_bug.cgi?id=85243
  2949. Reviewed by Dirk Pranke.
  2950. This happens for cases where a test name matches multiple tests.
  2951. In practice, this only happens for virtual test suites (e.g. the canvas tests).
  2952. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  2953. (htmlForIndividualTestOnAllBuildersWithChrome):
  2954. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2955. (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
  2956. (testHtmlForIndividualTestOnAllBuildersWithChrome):
  2957. (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
  2958. (testHtmlForIndividualTests):
  2959. 2012-05-03 Ojan Vafai <ojan@chromium.org>
  2960. Port the flakiness dashboard unittests to qunit
  2961. https://bugs.webkit.org/show_bug.cgi?id=85544
  2962. Reviewed by Adam Barth.
  2963. * TestResultServer/static-dashboards/dashboard_base.js:
  2964. (appendJSONScriptElements):
  2965. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  2966. (resetGlobals):
  2967. (runExpectationsTest):
  2968. (test):
  2969. * TestResultServer/static-dashboards/run-unittests.html: Added.
  2970. 2012-05-03 Raphael Kubo da Costa <rakuco@webkit.org>
  2971. webkitpy: Remove check for readline on Mac.
  2972. https://bugs.webkit.org/show_bug.cgi?id=85547
  2973. Reviewed by Eric Seidel.
  2974. Python 2.5 is not supported by the WebKit project anymore, and
  2975. Python's readline documentation does not mention the module not
  2976. being available in the supported versions.
  2977. * Scripts/webkitpy/common/system/user.py:
  2978. 2012-05-03 Thiago Marcos P. Santos <thiago.santos@intel.com>
  2979. [NRWT] Run performance tests with lock
  2980. https://bugs.webkit.org/show_bug.cgi?id=78628
  2981. Reviewed by Tony Chang.
  2982. Locking performance tests (like we do for http tests) will force them
  2983. to run in serial. This reduces the load of the machine when running perf
  2984. tests and minimizes the chances of the tests to fail, specially
  2985. timeouts.
  2986. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  2987. (Manager.__init__):
  2988. (Manager._is_perf_test):
  2989. (Manager._test_requires_lock):
  2990. * Scripts/webkitpy/layout_tests/port/http_lock.py:
  2991. 2012-05-03 Dirk Pranke <dpranke@chromium.org>
  2992. Attempt to fix a crash on SL ...
  2993. Unreviewed, build fix.
  2994. It looks like we may be getting an IOError raised during
  2995. select() on chromium mac, and that error isn't being caught.
  2996. Pushing it into the try/catch block will hopefully catch this
  2997. and allow us to see why the subprocess is crashing.
  2998. * Scripts/webkitpy/layout_tests/port/server_process.py:
  2999. (ServerProcess._wait_for_data_and_update_buffers_using_select):
  3000. 2012-05-02 Jon Honeycutt <jhoneycutt@apple.com>
  3001. WebFrameLoaderClient::dispatchWillSendSubmitEvent() needs to be
  3002. implemented for WebKit2
  3003. https://bugs.webkit.org/show_bug.cgi?id=84304
  3004. Reviewed by Jessie Berlin.
  3005. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  3006. Added new files to project.
  3007. * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent.cpp: Added.
  3008. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  3009. Look for the "DidReceiveWillSendSubmitEvent" message. The message body
  3010. will be the dictionary of form control names and values passed to the
  3011. injected bundle's willSendSubmitEvent handler; look for the pairs
  3012. "textField" -> "text field" and "passwordField" -> "password field".
  3013. Check that "hiddenField" is not included.
  3014. (TestWebKitAPI::setInjectedBundleClient):
  3015. (TestWebKitAPI::TEST):
  3016. * TestWebKitAPI/Tests/WebKit2/WillSendSubmitEvent_Bundle.cpp: Added.
  3017. (TestWebKitAPI::willSendSubmitEvent):
  3018. Post a message to the TestWebKitAPI process with the dictionary of form
  3019. control names and values that we received.
  3020. (TestWebKitAPI::WillSendSubmitEventTest::WillSendSubmitEventTest):
  3021. (TestWebKitAPI::WillSendSubmitEventTest::didCreatePage):
  3022. Set up the page's form client.
  3023. * TestWebKitAPI/Tests/WebKit2/auto-submitting-form.html: Added.
  3024. 2012-05-03 Eric Seidel <eric@webkit.org>
  3025. Remove dead code from build-webkit for working around old XCode dependency bug
  3026. https://bugs.webkit.org/show_bug.cgi?id=85535
  3027. Reviewed by Adam Barth.
  3028. Xcode used to have a bug whereby it didn't notice if you changed the #defines
  3029. passed on the command line to xcodebuild. I wrote code to work around this
  3030. while bringing up SVG support 5-6 years ago. I think we can finally remove this
  3031. code from build-webkit, since SVG is the only feature flag to ever use it
  3032. (modern in-progress features like MathML don't seem to be using the support)
  3033. an I suspect the XCode bug has long been fixed.
  3034. * Scripts/build-webkit:
  3035. * Scripts/webkitperl/features.pm:
  3036. 2012-05-03 Andy Estes <aestes@apple.com>
  3037. InjectedBundleControllerMac.mm needs to include config.h
  3038. https://bugs.webkit.org/show_bug.cgi?id=85531
  3039. Reviewed by Andreas Kling.
  3040. * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
  3041. 2012-05-03 Raphael Kubo da Costa <rakuco@webkit.org>
  3042. webkitpy: Use PlatformInfo whenever possible in server_process.py.
  3043. https://bugs.webkit.org/show_bug.cgi?id=85516
  3044. Reviewed by Eric Seidel.
  3045. Eliminate direct access to sys.platform wherever possible by using
  3046. PlatformInfo.is_win() instead.
  3047. * Scripts/webkitpy/layout_tests/port/server_process.py:
  3048. (ServerProcess.__init__): Remove the executive parameter as it was
  3049. not passed by any caller, obtain a SystemHost from port_obj
  3050. instead.
  3051. (ServerProcess._log): Style, remove extra empty line.
  3052. (ServerProcess._start):
  3053. (ServerProcess.stop):
  3054. (ServerProcess.kill):
  3055. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  3056. (TrivialMockPort.__init__): Create a MockSystemHost used by
  3057. ServerProcess.
  3058. (TestServerProcess.test_broken_pipe): Test different platforms.
  3059. 2012-05-03 Thiago Marcos P. Santos <thiago.santos@intel.com>
  3060. webkitpy: Style checker broken when committing a PNG
  3061. https://bugs.webkit.org/show_bug.cgi?id=85504
  3062. Reviewed by Dirk Pranke.
  3063. * Scripts/webkitpy/style/checkers/png.py:
  3064. (PNGChecker.__init__):
  3065. 2012-05-03 Philippe Normand <pnormand@igalia.com>
  3066. Unreviewed, fix another call to join(), similar to the ones landed
  3067. in r115975.
  3068. * Scripts/webkitdirs.pm:
  3069. (jhbuildConfigurationChanged):
  3070. 2012-05-03 Raphael Kubo da Costa <rakuco@webkit.org>
  3071. webkitpy: Remove sys.platform accesses in CrashLogs.
  3072. https://bugs.webkit.org/show_bug.cgi?id=85436
  3073. Reviewed by Dirk Pranke.
  3074. Instead of directly checking for sys.platform == 'darwin', use a
  3075. SystemHost and call PlatformInfo.is_mac().
  3076. * Scripts/webkitpy/common/system/crashlogs.py:
  3077. (CrashLogs.__init__):
  3078. (CrashLogs.find_newest_log):
  3079. (CrashLogs._log_directory_darwin):
  3080. (CrashLogs._find_newest_log_darwin):
  3081. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  3082. (CrashLogsTest.test_find_log_darwin):
  3083. * Scripts/webkitpy/layout_tests/port/mac.py:
  3084. (MacPort._get_crash_log):
  3085. * Scripts/webkitpy/layout_tests/port/test.py:
  3086. (TestDriver.run_test):
  3087. * Scripts/webkitpy/tool/commands/queries.py:
  3088. (execute):
  3089. 2012-05-03 Philippe Normand <pnormand@igalia.com>
  3090. [GTK] join() is wrongly used in webkitdirs.pm since r115532
  3091. https://bugs.webkit.org/show_bug.cgi?id=85501
  3092. Reviewed by Martin Robinson.
  3093. * Scripts/webkitdirs.pm:
  3094. (getJhbuildPath):
  3095. (buildAutotoolsProject):
  3096. 2012-05-03 Zan Dobersek <zandobersek@gmail.com>
  3097. [Gtk] ImageDiff crashes when it can't open a display
  3098. https://bugs.webkit.org/show_bug.cgi?id=85476
  3099. Reviewed by Martin Robinson.
  3100. Replace gdk_init() initialization call with the g_type_init()
  3101. call. GdkPixbufLoader doesn't actually need the current call to be
  3102. made and this change will also remove crashes when ImageDiff
  3103. is started in an environment without a DISPLAY env.
  3104. * DumpRenderTree/gtk/ImageDiff.cpp:
  3105. (main):
  3106. 2012-05-03 Zan Dobersek <zandobersek@gmail.com>
  3107. ImageDiff should be run inside a properly established environment
  3108. https://bugs.webkit.org/show_bug.cgi?id=85292
  3109. Reviewed by Martin Robinson.
  3110. When creating the ImageDiff server process, pass along a freshly-set-up environment
  3111. in which the process should be executed in.
  3112. * Scripts/webkitpy/layout_tests/port/webkit.py:
  3113. (WebKitPort._start_image_diff_process):
  3114. 2012-05-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3115. [Qt] Allow the web process and WTR to be paused on startup
  3116. Makes it easier to debug the web process or run-webkit-tests -2, as you
  3117. have ample time to attach gdb to the process.
  3118. Reviewed by Simon Hausmann.
  3119. * Scripts/webkitpy/layout_tests/port/qt.py:
  3120. (QtPort.setup_environ_for_server):
  3121. * WebKitTestRunner/qt/main.cpp:
  3122. (main):
  3123. 2012-05-03 Csaba Osztrogonác <ossy@webkit.org>
  3124. Password protect "Stop build" button
  3125. https://bugs.webkit.org/show_bug.cgi?id=81982
  3126. Reviewed by Ryosuke Niwa.
  3127. Only authenticated users should be able to use stopBuild, stopAllBuilds, cancelPendingBuild
  3128. features to prevent killing builds on build.webkit.org by SPAM bots.
  3129. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  3130. 2012-05-03 Dongwoo Im <dw.im@samsung.com>
  3131. [DRT] Remove the name of parameter, visibility, from the setPageVisibility stub implementations.
  3132. https://bugs.webkit.org/show_bug.cgi?id=85468
  3133. Reviewed by Nikolas Zimmermann.
  3134. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  3135. (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
  3136. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  3137. (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
  3138. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  3139. (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
  3140. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  3141. (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
  3142. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  3143. (LayoutTestController::setPageVisibility): Remove the name of parameter, visibility.
  3144. 2012-05-03 Stephanie Lewis <slewis@apple.com>
  3145. https://bugs.webkit.org/show_bug.cgi?id=85450 unbounded growth of JSDOMWindowShells loading pages in the same window
  3146. <rdar://problem/11320059> REGRESSION (r115083): PLT3 shows linear memory growth and gets slower with each run
  3147. Reviewed by Brady Eidson.
  3148. The API added for DOMWindowExtension, didCreateGlobalObjectForFrame, would create a global object
  3149. for every world, even those that did not need the callback. This had the side effect of creating a
  3150. JSDOMWindowShell that the associated world didn't necessarily know to clean up. Instead of creating
  3151. unnecessary objects change the API to globalObjectIsAvailableForFrame and do not pass the global object
  3152. in the API. The object can be accessed later by those worlds which require it.
  3153. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp:
  3154. (TestWebKitAPI):
  3155. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  3156. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp:
  3157. (TestWebKitAPI):
  3158. (DOMWindowExtensionBasic):
  3159. (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
  3160. (TestWebKitAPI::DOMWindowExtensionBasic::globalObjectIsAvailableForFrame):
  3161. (TestWebKitAPI::globalObjectIsAvailableForFrameCallback):
  3162. 2012-05-03 Nikolas Zimmermann <nzimmermann@rim.com>
  3163. Not reviewed. Fix mac build, it was missing setPageVisibility/resetPageVisibility stub implementations.
  3164. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  3165. (LayoutTestController::resetPageVisibility):
  3166. (LayoutTestController::setPageVisibility):
  3167. 2012-05-02 Alexander Færøy <ahf@0x90.dk>
  3168. Rename deviceDPI to devicePixelRatio
  3169. https://bugs.webkit.org/show_bug.cgi?id=85049
  3170. Reviewed by Kenneth Rohde Christiansen.
  3171. Use 1.5 as device pixel ratio for the Qt MiniBrowser.
  3172. * MiniBrowser/qt/qml/BrowserWindow.qml:
  3173. 2012-05-03 Dongwoo Im <dw.im@samsung.com>
  3174. [EFL][DRT] Implement the LayoutTestController's methods related to the Page Visibility API.
  3175. https://bugs.webkit.org/show_bug.cgi?id=85347
  3176. Reviewed by Nikolas Zimmermann.
  3177. * DumpRenderTree/LayoutTestController.h:
  3178. (LayoutTestController):
  3179. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  3180. (LayoutTestController::resetPageVisibility): Not implemented.
  3181. (LayoutTestController::setPageVisibility): Not implemented.
  3182. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  3183. (LayoutTestController::resetPageVisibility): Reset the page visibility.
  3184. (LayoutTestController::setPageVisibility): Set the page visibility.
  3185. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  3186. (LayoutTestController::resetPageVisibility): Not implemented.
  3187. (LayoutTestController::setPageVisibility): Not implemented.
  3188. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  3189. (LayoutTestController::resetPageVisibility): Not implemented.
  3190. (LayoutTestController::setPageVisibility): Not implemented.
  3191. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  3192. (LayoutTestController::resetPageVisibility): Not implemented.
  3193. (LayoutTestController::setPageVisibility): Not implemented.
  3194. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  3195. (LayoutTestController::resetPageVisibility): Not implemented.
  3196. (LayoutTestController::setPageVisibility): Not implemented.
  3197. 2012-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
  3198. Unreviewed, rolling out r115918.
  3199. http://trac.webkit.org/changeset/115918
  3200. https://bugs.webkit.org/show_bug.cgi?id=85452
  3201. "Broke test-webkitpy on Apple Lion bots" (Requested by estes
  3202. on #webkit).
  3203. * Scripts/webkitpy/common/system/crashlogs.py:
  3204. (CrashLogs.__init__):
  3205. (CrashLogs.find_newest_log):
  3206. (CrashLogs._log_directory_darwin):
  3207. (CrashLogs._find_newest_log_darwin):
  3208. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  3209. (CrashLogsTest.test_find_log_darwin):
  3210. * Scripts/webkitpy/layout_tests/port/mac.py:
  3211. (MacPort._get_crash_log):
  3212. * Scripts/webkitpy/layout_tests/port/test.py:
  3213. (TestDriver.run_test):
  3214. * Scripts/webkitpy/tool/commands/queries.py:
  3215. (execute):
  3216. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3217. webkitpy: Remove sys.platform accesses in CrashLogs.
  3218. https://bugs.webkit.org/show_bug.cgi?id=85436
  3219. Reviewed by Dirk Pranke.
  3220. Instead of directly checking for sys.platform == 'darwin', use a
  3221. SystemHost and call PlatformInfo.is_mac().
  3222. * Scripts/webkitpy/common/system/crashlogs.py:
  3223. (CrashLogs.__init__):
  3224. (CrashLogs.find_newest_log):
  3225. (CrashLogs._log_directory_darwin):
  3226. (CrashLogs._find_newest_log_darwin):
  3227. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  3228. (CrashLogsTest.test_find_log_darwin):
  3229. * Scripts/webkitpy/layout_tests/port/mac.py:
  3230. (MacPort._get_crash_log):
  3231. * Scripts/webkitpy/layout_tests/port/test.py:
  3232. (TestDriver.run_test):
  3233. * Scripts/webkitpy/tool/commands/queries.py:
  3234. (execute):
  3235. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3236. webkitpy: Special-case win32 calls in file_lock and executive.
  3237. https://bugs.webkit.org/show_bug.cgi?id=85431
  3238. Reviewed by Dirk Pranke.
  3239. Simplify accesses to sys.platform by only checking if sys.platform
  3240. is "win32" and removing explicit checks for the else case.
  3241. * Scripts/webkitpy/common/system/executive.py:
  3242. (Executive.check_running_pid):
  3243. * Scripts/webkitpy/common/system/file_lock.py:
  3244. (FileLock._create_lock):
  3245. (FileLock._remove_lock):
  3246. 2012-05-02 Ojan Vafai <ojan@chromium.org>
  3247. Remove pink from flakiness dashboard
  3248. https://bugs.webkit.org/show_bug.cgi?id=85422
  3249. Reviewed by Dirk Pranke.
  3250. The pink indicates that the test doesn't match it's listing in test_expectations.txt.
  3251. In practice, this just added noise and confused people.
  3252. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  3253. (htmlForSingleTestRow):
  3254. (showLegend):
  3255. * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
  3256. (#legend-contents *):
  3257. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  3258. (testHtmlForSingleTestRow):
  3259. 2012-05-02 Gustavo Noronha Silva <gns@gnome.org>
  3260. Unreviewed. Fix mistake I committed when applying review comments.
  3261. * jhbuild/jhbuild-wrapper: dependencies_path was getting 'Root'
  3262. appended to its path, so jhbuild itself was being cloned and
  3263. installed in the wrong place when using WEBKITOUTPUTDIR.
  3264. 2012-05-02 Dirk Pranke <dpranke@chromium.org>
  3265. nrwt: make ServerProcess work on chromium win
  3266. https://bugs.webkit.org/show_bug.cgi?id=85333
  3267. Reviewed by Ojan Vafai.
  3268. This change implements a poor man's select() that will
  3269. slow-spin doing non-blocking reads on the stdout and stderr
  3270. named pipes connecting the worker to the driver. Seems to work
  3271. and I have yet to see much overhead or ill effects but it
  3272. probably needs more testing.
  3273. * Scripts/webkitpy/layout_tests/port/chromium.py:
  3274. (ChromiumDriver.__init__):
  3275. * Scripts/webkitpy/layout_tests/port/server_process.py:
  3276. (ServerProcess._start):
  3277. (ServerProcess._wait_for_data_and_update_buffers_using_select):
  3278. (ServerProcess._wait_for_data_and_update_buffers_using_win32_apis):
  3279. (ServerProcess):
  3280. (ServerProcess._non_blocking_read_win32):
  3281. (ServerProcess._read):
  3282. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  3283. (TestServerProcess.test_basic): Added.
  3284. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3285. webkitpy: Use a SystemHost instead of PlatformInfo in the PNG checker.
  3286. https://bugs.webkit.org/show_bug.cgi?id=85426
  3287. Reviewed by Dirk Pranke.
  3288. r115880 replaced the direct use of sys.platform with a
  3289. PlatformInfo object. Dirk Pranke later told me SystemHost objects
  3290. should be preferred, as nothing out of webkitpy.common.system
  3291. should create its own PlatformInfo instances.
  3292. * Scripts/webkitpy/common/system/systemhost_mock.py:
  3293. (MockSystemHost.__init__): Make it possible to specify a custom
  3294. filesystem object.
  3295. * Scripts/webkitpy/style/checkers/png.py:
  3296. (PNGChecker.__init__): Accept a host object instead of a
  3297. filesystem one, which is now obtained from host.
  3298. (PNGChecker._config_file_path): Retrieve PlatformInfo from
  3299. SystemHost.
  3300. * Scripts/webkitpy/style/checkers/png_unittest.py:
  3301. (PNGCheckerTest.test_init): Adjust calls to PNGChecker to its new
  3302. constructor signature.
  3303. (PNGCheckerTest.test_check): Ditto.
  3304. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3305. webkitpy: Remove direct checks for sys.platform == 'darwin' in the layout test classes.
  3306. https://bugs.webkit.org/show_bug.cgi?id=85424
  3307. Reviewed by Tony Chang.
  3308. We should reduce direct usage of sys.platform in webkitpy and use
  3309. PlatformInfo instead.
  3310. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  3311. (Lighttpd._prepare_config): Call PlatformInfo.is_mac() instead of
  3312. checking for 'darwin' directly.
  3313. * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
  3314. (HttpServerBase.__init__): Ditto.
  3315. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3316. webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
  3317. https://bugs.webkit.org/show_bug.cgi?id=85419
  3318. Reviewed by Dirk Pranke.
  3319. As pointed out by Dirk Pranke, a PlatformInfo is not supposed to
  3320. be created directly, we should should a SystemHost instead.
  3321. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  3322. (MainTest.setUp): Create a SystemHost and obtain the PlatformInfo
  3323. object from it instead of creating PlatformInfo directly.
  3324. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3325. webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
  3326. https://bugs.webkit.org/show_bug.cgi?id=85419
  3327. Rubber-stamped by Dirk Pranke.
  3328. Follow-up patch to r115887 which fixes some capitalization problems
  3329. pointed out in comments 2 and 4.
  3330. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  3331. (MainTest.setUp):
  3332. (MainTest.test_child_processes_2):
  3333. (MainTest.test_child_processes_min):
  3334. (MainTest.test_exception_raised):
  3335. (MainTest.test_keyboard_interrupt):
  3336. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3337. webkitpy: Remove direct sys.platform usage in run_webkit_tests_integrationtest.
  3338. https://bugs.webkit.org/show_bug.cgi?id=85419
  3339. Reviewed by Dirk Pranke.
  3340. Another part of the work towards replacing direct sys.platform
  3341. usage with PlatformInfo.
  3342. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  3343. (MainTest.setUp): Move the setting of SHOULD_TEST_PROCESSES
  3344. here. Even though it is costlier, unittest.setUpClass was
  3345. introduced in Python 2.7.
  3346. (MainTest.test_child_processes_2): Use self.SHOULD_TEST_PROCESSES.
  3347. (MainTest.test_child_processes_min): Ditto.
  3348. (MainTest.test_exception_raised): Ditto.
  3349. (MainTest.test_keyboard_interrupt): Ditto.
  3350. (MainTest.test_crash_log): Check for PlatformInfo.is_mac().
  3351. (MainTest.test_web_process_crash_log): Ditto, and remove duplicate
  3352. check at the end.
  3353. (MainTest.test_no_http_tests): Remove check for (cygwin && Python
  3354. 2.5.2), as we only support Python 2.6+.
  3355. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3356. webkitpy: Remove direct sys.platform usage in the PNG checker.
  3357. https://bugs.webkit.org/show_bug.cgi?id=85407
  3358. Reviewed by Tony Chang.
  3359. Work towards replacing direct sys.platform usage with
  3360. PlatformInfo.
  3361. * Scripts/webkitpy/common/system/platforminfo_mock.py:
  3362. (MockPlatformInfo.__init__): Accept os_name and os_version as
  3363. arguments.
  3364. * Scripts/webkitpy/style/checkers/png.py:
  3365. (PNGChecker.__init__): Create a PlatformInfo object instead of
  3366. using sys.platform when needed.
  3367. (PNGChecker._config_file_path): Check for the current platform via
  3368. PlatformInfo.
  3369. * Scripts/webkitpy/style/checkers/png_unittest.py:
  3370. (PNGCheckerTest.test_check): Update tests after the changes above.
  3371. 2012-05-02 Raphael Kubo da Costa <rakuco@webkit.org>
  3372. [watchlist] Update watchlist rules for EFL-related patches.
  3373. http://bugs.webkit.org/show_bug.cgi?id=85160
  3374. Reviewed by Eric Seidel.
  3375. * Scripts/webkitpy/common/config/watchlist: Monitor
  3376. Source/WTF/wtf/efl and LayoutTests/platform/efl as well.
  3377. 2012-05-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  3378. Revert r115191 - "Make the web view's url property follow the active url"
  3379. It uncovered/caused issues in the icon-implementation that can't be
  3380. easily fixed, so rolling out instead.
  3381. https://bugs.webkit.org/show_bug.cgi?id=77554
  3382. Rubber-stamped by Simon Hausmann.
  3383. * MiniBrowser/qt/qml/BrowserWindow.qml:
  3384. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  3385. (TestWebKitAPI::TEST):
  3386. 2012-05-02 Zan Dobersek <zandobersek@gmail.com>
  3387. Reftest mismatches are providing undefined diff percent in results.html
  3388. https://bugs.webkit.org/show_bug.cgi?id=85283
  3389. Reviewed by Ojan Vafai.
  3390. When writing test results for a reftest mismatch, also take into account the
  3391. difference percent that is produced when generating image diff. This value is
  3392. then used when creating test results in the form of dictionaries, stored under
  3393. the 'image_diff_percent' key. It ultimately ends up in JSON results data,
  3394. providing additional information about the reftest difference.
  3395. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  3396. (interpret_test_failures): Store the diff percent for reftest failure under the
  3397. 'image_diff_percent' key.
  3398. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  3399. (write_test_result): Also set the new diff_percent attribute of the reftest
  3400. mismatch failure to the value of the difference percent ImageDiff outputs.
  3401. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  3402. (FailureReftestMismatch.__init__): Add the new diff_percent attribute with the
  3403. default value of None.
  3404. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  3405. (EndToEndTest.test_reftest_with_two_notrefs): Update the test case expected results.
  3406. 2012-05-02 Terry Anderson <tdanderson@chromium.org>
  3407. Addition of a contributor to committers.py
  3408. https://bugs.webkit.org/show_bug.cgi?id=85324
  3409. Reviewed by Unreviewed.
  3410. * Scripts/webkitpy/common/config/committers.py:
  3411. 2012-05-02 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  3412. [EFL] EFL's LayoutTestController overridePreference implementation
  3413. https://bugs.webkit.org/show_bug.cgi?id=83007
  3414. Reviewed by Antonio Gomes.
  3415. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  3416. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  3417. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  3418. (toBool): aux function converting JSStringRef to bool
  3419. (toInt): aux function converting JSStringRef to int
  3420. (LayoutTestController::overridePreference): added implementation
  3421. 2012-05-01 Raphael Kubo da Costa <rakuco@webkit.org>
  3422. webkitpy: Fix sys.platform check in find_files_unittest.
  3423. https://bugs.webkit.org/show_bug.cgi?id=85339
  3424. Reviewed by Ryosuke Niwa.
  3425. Follow-up to r101618 -- 'win' is not a valid sys.platform value,
  3426. 'win32' should be used instead. The check always returned false
  3427. due to this, so assert_normalize() was never called.
  3428. * Scripts/webkitpy/common/find_files_unittest.py:
  3429. (TestWinNormalize.test_win): Add the missing import for the
  3430. FileSystem class and fix the sys.platform check.
  3431. 2012-05-02 Zan Dobersek <zandobersek@gmail.com>
  3432. [GTK] drag&drop related failures
  3433. https://bugs.webkit.org/show_bug.cgi?id=84675
  3434. Reviewed by Philippe Normand.
  3435. Rather than checking options to see whether we're running pixel tests
  3436. the pixel_tests argument passed to GtkDriver._start should be used as
  3437. it also covers cases when pixel tests should be run because of testing
  3438. reftests. This again creates different Xvfb processes with proper
  3439. display IDs for a worker that's performing both ordinary and pixel
  3440. tests, as was the case before changes made in r114788.
  3441. * Scripts/webkitpy/layout_tests/port/gtk.py:
  3442. (GtkDriver._start):
  3443. 2012-05-02 Simon Hausmann <simon.hausmann@nokia.com>
  3444. [Qt] Enable device orientation/motion with Qt 5
  3445. Reviewed by Tor Arne Vestbø.
  3446. Enable device orientation/motion features with Qt 5 if Qt Sensors is available.
  3447. * qmake/mkspecs/features/features.prf:
  3448. 2012-05-01 Raphael Kubo da Costa <rakuco@webkit.org>
  3449. webkitpy: Remove unused platform imports.
  3450. https://bugs.webkit.org/show_bug.cgi?id=85341
  3451. Reviewed by Eric Seidel.
  3452. Remove a few uses of `import platform' which were either rendered
  3453. unneeded after r105931 or were never needed at all.
  3454. * Scripts/webkitpy/common/system/executive.py:
  3455. * Scripts/webkitpy/tool/bot/flakytestreporter.py:
  3456. 2012-05-01 Terry Anderson <tdanderson@chromium.org>
  3457. [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
  3458. https://bugs.webkit.org/show_bug.cgi?id=85289
  3459. Reviewed by Eric Seidel.
  3460. * DumpRenderTree/chromium/EventSender.cpp:
  3461. (EventSender::gestureEvent):
  3462. This change will allow for testing of WK85101. Currently
  3463. no tests use the extra parameters deltaX and deltaY. Added
  3464. a check for the size of |arguments|.
  3465. 2012-05-01 Eric Seidel <eric@webkit.org>
  3466. Add myself to the watchlist to watch all rendering changes, as well as sort the watchers in the list
  3467. https://bugs.webkit.org/show_bug.cgi?id=85305
  3468. Reviewed by Adam Barth.
  3469. * Scripts/webkitpy/common/config/watchlist:
  3470. 2012-05-01 Sheriff Bot <webkit.review.bot@gmail.com>
  3471. Unreviewed, rolling out r115735.
  3472. http://trac.webkit.org/changeset/115735
  3473. https://bugs.webkit.org/show_bug.cgi?id=85314
  3474. cause two tests to crash due to an ASSERTION failure
  3475. (Requested by zhenyao on #webkit).
  3476. * DumpRenderTree/chromium/EventSender.cpp:
  3477. (EventSender::gestureEvent):
  3478. 2012-05-01 Terry Anderson <tdanderson@chromium.org>
  3479. [chromium] Accept four parameters when dispatching a WebInputEvent::GestureTap in chromium DRT eventSender
  3480. https://bugs.webkit.org/show_bug.cgi?id=85289
  3481. Reviewed by Eric Seidel.
  3482. * DumpRenderTree/chromium/EventSender.cpp:
  3483. (EventSender::gestureEvent):
  3484. This change will allow for testing of WK85101. Currently no tests use the extra
  3485. parameters deltaX and deltaY.
  3486. 2012-05-01 Zan Dobersek <zandobersek@gmail.com>
  3487. Print out stderr output of ImageDiff if it is present
  3488. https://bugs.webkit.org/show_bug.cgi?id=85285
  3489. Reviewed by Philippe Normand.
  3490. Log the stderr output of ImageDiff as a warning if present. This is
  3491. especially helpful when ImageDiff crashes and stderr data might contain
  3492. relevant information about what caused the crash.
  3493. * Scripts/webkitpy/layout_tests/port/webkit.py:
  3494. (WebKitPort._read_image_diff):
  3495. 2012-05-01 Kenneth Rohde Christiansen <kenneth@webkit.org>
  3496. [Qt] Add an experimental extension to set the min. contents width
  3497. https://bugs.webkit.org/show_bug.cgi?id=85281
  3498. Reviewed by Antonio Gomes.
  3499. * MiniBrowser/qt/qml/BrowserWindow.qml:
  3500. Set the value of preferredMinimumContentsWidth to 980.
  3501. 2012-04-30 Ojan Vafai <ojan@chromium.org>
  3502. Fix tests to not depend on the actual list of builders at build.chromium.org.
  3503. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  3504. (testHtmlForIndividualTestOnAllBuildersWithChrome):
  3505. (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
  3506. 2012-04-29 Sam Weinig <sam@webkit.org>
  3507. Remove BlobBuilder
  3508. https://bugs.webkit.org/show_bug.cgi?id=84036
  3509. Reviewed by Anders Carlsson.
  3510. * Scripts/build-webkit:
  3511. * qmake/mkspecs/features/features.prf:
  3512. Make exposing the WebKitBlobBuilder JS object conditional on a new
  3513. ENABLE_LEGACY_WEBKIT_BLOB_BUILDER flag. Don't enable this for the Mac,
  3514. but do for everyone else.
  3515. 2012-04-30 Amruth Raj Padmanabhuni <amruthraj@motorola.com>
  3516. [GTK] Add glib as a dependency to build glib-networking
  3517. https://bugs.webkit.org/show_bug.cgi?id=85181
  3518. Reviewed by Martin Robinson.
  3519. * gtk/jhbuild.modules:
  3520. 2012-04-30 Alexis Menard <alexis.menard@openbossa.org>
  3521. Move myself to reviewers.
  3522. Reviewed by Andreas Kling.
  3523. * Scripts/webkitpy/common/config/committers.py:
  3524. 2012-04-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  3525. Unreviewed, move myself to reviewers
  3526. * Scripts/webkitpy/common/config/committers.py:
  3527. 2012-04-30 Carlos Garcia Campos <cgarcia@igalia.com>
  3528. Unreviewed. Fix make distcheck.
  3529. * TestWebKitAPI/GNUmakefile.am: Add missing headers to compilation
  3530. and resources to EXTRA_DIST.
  3531. 2012-04-30 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  3532. [GTK] DRT support for layoutTestController.removeOriginAccessWhitelistEntry
  3533. https://bugs.webkit.org/show_bug.cgi?id=85156
  3534. Reviewed by Martin Robinson.
  3535. Add missing implementation removeOriginAccessWhitelistEntry to
  3536. GTK's LayoutTestController.
  3537. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  3538. (LayoutTestController::removeOriginAccessWhitelistEntry):
  3539. 2012-04-29 Maciej Stachowiak <mjs@apple.com>
  3540. REGRESSION: On Lion, run-webkit-tests changes the display color profile even when not running pixel tests
  3541. https://bugs.webkit.org/show_bug.cgi?id=81729
  3542. Reviewed by Dan Bernstein.
  3543. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  3544. (Manager._set_up_run): Only launch LayoutTestHelper when running pixel tests.
  3545. 2012-04-29 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  3546. [GTK] DRT needs an implementation of layoutTestController.setDomainRelaxationForbiddenForURLScheme
  3547. https://bugs.webkit.org/show_bug.cgi?id=85131
  3548. Reviewed by Martin Robinson.
  3549. Add missing implementation setDomainRelaxationForbiddenForURLScheme to
  3550. GTK's LayoutTestController.
  3551. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  3552. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  3553. 2012-04-28 Sam Weinig <sam@webkit.org>
  3554. Smooth scrolling needs a new key
  3555. <rdar://problem/11331632>
  3556. Reviewed by Dan Bernstein.
  3557. * DumpRenderTree/mac/DumpRenderTree.mm:
  3558. (resetDefaultsToConsistentValues):
  3559. * TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
  3560. (TestWebKitAPI::InjectedBundleController::platformInitialize):
  3561. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  3562. (WTR::InjectedBundle::platformInitialize):
  3563. Update for new key.
  3564. 2012-04-28 Zan Dobersek <zandobersek@gmail.com>
  3565. [WK2] http/tests/navigation/anchor-frames-gbk.html fails
  3566. https://bugs.webkit.org/show_bug.cgi?id=76896
  3567. Reviewed by Darin Adler.
  3568. Only dump as text if currently dumping render tree. This ensures that
  3569. calling dumpAsText in a test with dumpChildFramesAsText already being
  3570. called doesn't override the first decision, possibly making tests fail.
  3571. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  3572. (WTR::LayoutTestController::dumpAsText):
  3573. 2012-04-28 Dan Winship <danw@gnome.org>
  3574. Unreviewed; Add me to the SoupNetwork watchlist
  3575. * Scripts/webkitpy/common/config/watchlist:
  3576. 2012-04-27 Gustavo Noronha Silva <gns@gnome.org>
  3577. [GTK] jhbuild cloning is not following WEBKITOUTPUTDIR.
  3578. https://bugs.webkit.org/show_bug.cgi?id=76161
  3579. Reviewed by Martin Robinson.
  3580. * Scripts/webkitdirs.pm:
  3581. (getJhbuildPath): New method to obtain the jhbuild base directory,
  3582. using the product base directory
  3583. (jhbuildConfigurationChanged): Use the new method
  3584. (buildAutotoolsProject): Ditto.
  3585. * efl/jhbuildrc: Use WEBKITOUTPUTDIR when calculating the path.
  3586. * gtk/jhbuildrc: Ditto.
  3587. * jhbuild/jhbuild-wrapper: Ditto.
  3588. 2012-04-27 Scott Graham <scottmg@chromium.org>
  3589. [chromium] make case of npTestNetscapePlugIn.dll match case in copy rule
  3590. https://bugs.webkit.org/show_bug.cgi?id=85083
  3591. Reviewed by Dirk Pranke.
  3592. Make output product_name for npTestNetscapePlugIn.dll match the case
  3593. of the copy_TestNetscapePlugIn rule. This is required for ninja, which
  3594. is more particular about case matching in rules than the VS build.
  3595. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  3596. 2012-04-27 Dirk Pranke <dpranke@chromium.org>
  3597. [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
  3598. https://bugs.webkit.org/show_bug.cgi?id=84917
  3599. Unreviewed, build fix.
  3600. Reland the change in r115453 with a fix for chromium win.
  3601. The logic in ChromiumDriver was busted on windows, causing DRT
  3602. to get launched without the --test-shell flag.
  3603. * Scripts/webkitpy/layout_tests/port/chromium.py:
  3604. (ChromiumDriver):
  3605. (ChromiumDriver.__init__):
  3606. (ChromiumDriver._wrapper_options):
  3607. (ChromiumDriver.cmd_line):
  3608. (ChromiumDriver._start):
  3609. (ChromiumDriver.has_crashed):
  3610. (ChromiumDriver.run_test):
  3611. (ChromiumDriver.stop):
  3612. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  3613. (ChromiumDriverTest.setUp):
  3614. (ChromiumDriverTest.test_stop):
  3615. (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
  3616. (ChromiumDriverTest.test_two_drivers):
  3617. 2012-04-27 Peter Beverloo <peter@chromium.org>
  3618. Add John Grabowski as a non-committer to committers.py
  3619. https://bugs.webkit.org/show_bug.cgi?id=85080
  3620. Reviewed by Dirk Pranke.
  3621. He's being CC'ed often enough because of his involvement in the Chromium
  3622. side of Chrome for Android upstreaming.
  3623. * Scripts/webkitpy/common/config/committers.py:
  3624. add jrg@chromium.org
  3625. 2012-04-27 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  3626. [Qt] Fix minimal build.
  3627. https://bugs.webkit.org/show_bug.cgi?id=85045
  3628. Reviewed by Tor Arne Vestbø.
  3629. Do not set conflicting values of ENABLE_XSLT.
  3630. * qmake/mkspecs/features/features.prf:
  3631. 2012-04-27 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  3632. [EFL][DRT] EFL should sanitize pulseaudio module configuration too
  3633. https://bugs.webkit.org/show_bug.cgi?id=85047
  3634. Reviewed by Dirk Pranke.
  3635. PulseAudio test setup sanitization shared between EFL and GTK.
  3636. * Scripts/webkitpy/layout_tests/port/efl.py:
  3637. (EflPort):
  3638. (EflPort.setup_test_run):
  3639. (EflPort.clean_up_test_run):
  3640. * Scripts/webkitpy/layout_tests/port/gtk.py:
  3641. (GtkPort): Moving pulseaudio unload/restore out to shared class.
  3642. * Scripts/webkitpy/layout_tests/port/pulseaudio_sanitizer.py: Added.
  3643. (PulseAudioSanitizer):
  3644. (PulseAudioSanitizer._unload_pulseaudio_module):
  3645. (PulseAudioSanitizer._restore_pulseaudio_module):
  3646. 2012-04-27 Dirk Pranke <dpranke@chromium.org>
  3647. Unreviewed, revert r115453 - broke chromium win bots
  3648. * Scripts/webkitpy/layout_tests/port/chromium.py:
  3649. (ChromiumPort._path_to_image_diff):
  3650. (ChromiumDriver):
  3651. (ChromiumDriver.__init__):
  3652. (ChromiumDriver._wrapper_options):
  3653. (ChromiumDriver.cmd_line):
  3654. (ChromiumDriver.stop):
  3655. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  3656. (ChromiumDriverTest.setUp):
  3657. (ChromiumDriverTest.test_stop):
  3658. (ChromiumDriverTest.test_two_drivers):
  3659. (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
  3660. 2012-04-27 Ryosuke Niwa <rniwa@webkit.org>
  3661. Chromium Windows Perf bots timeout due to not output
  3662. https://bugs.webkit.org/show_bug.cgi?id=84940
  3663. Reviewed by Dirk Pranke.
  3664. Dirk and I investigated the issue on the bot but we couldn't figure out what is going wrong.
  3665. Since we run-perf-tests don't need any of fancy feature printer provides, just use python's
  3666. built-in logging module instead. Printing out to stdout and stderr seem to work so hopefully
  3667. this will fix the issue on the bot.
  3668. * Scripts/run-perf-tests:
  3669. * Scripts/webkitpy/performance_tests/perftest.py:
  3670. (PerfTest.run):
  3671. (PerfTest.run_failed):
  3672. (PerfTest.parse_output):
  3673. (PerfTest.output_statistics):
  3674. (ChromiumStylePerfTest.parse_output):
  3675. (PageLoadingPerfTest.run):
  3676. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  3677. (MainTest.test_parse_output):
  3678. (MainTest.test_parse_output_with_failing_line):
  3679. (TestPageLoadingPerfTest):
  3680. (TestPageLoadingPerfTest.test_run):
  3681. (TestPageLoadingPerfTest.test_run_with_bad_output):
  3682. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  3683. (PerfTestsRunner.__init__):
  3684. (PerfTestsRunner._parse_args):
  3685. (PerfTestsRunner.run):
  3686. (PerfTestsRunner._upload_json):
  3687. (PerfTestsRunner._print_status):
  3688. (PerfTestsRunner._run_tests_set):
  3689. (PerfTestsRunner._run_single_test):
  3690. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  3691. (create_runner):
  3692. (test_run_test_set):
  3693. (test_run_test_set_kills_drt_per_run):
  3694. (test_run_test_pause_before_testing):
  3695. (test_run_test_set_for_parser_tests):
  3696. (test_run_test_set_with_json_output):
  3697. (test_run_test_set_with_json_source):
  3698. (test_run_test_set_with_multiple_repositories):
  3699. (test_upload_json):
  3700. (test_parse_args):
  3701. 2012-04-27 Dirk Pranke <dpranke@chromium.org>
  3702. [chromium] use "drt-style" output, not "test-shell-style" output, on mac and linux DRT
  3703. https://bugs.webkit.org/show_bug.cgi?id=84917
  3704. Reviewed by Ojan Vafai.
  3705. This change changes the chromium new-run-webkit-tests
  3706. implementation to use the code in WebKitDriver and ServerProcess
  3707. by default on Mac and Linux, instead of using the old-style
  3708. Chromium/test_shell style of output.
  3709. We will still use the test_shell style on Windows for now
  3710. and you can still get the old style of behavior with
  3711. new-run-webkit-tests --additional-drt-flag --test-shell
  3712. * Scripts/webkitpy/layout_tests/port/chromium.py:
  3713. (ChromiumDriver):
  3714. (ChromiumDriver.__init__):
  3715. (ChromiumDriver._wrapper_options):
  3716. (ChromiumDriver.cmd_line):
  3717. (ChromiumDriver._start):
  3718. (ChromiumDriver.has_crashed):
  3719. (ChromiumDriver.run_test):
  3720. (ChromiumDriver.stop):
  3721. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  3722. (ChromiumDriverTest.setUp):
  3723. (ChromiumDriverTest.test_stop):
  3724. (ChromiumDriverTest.test_two_drivers.MockDriver.__init__):
  3725. (ChromiumDriverTest.test_two_drivers):
  3726. 2012-04-27 Dirk Pranke <dpranke@chromium.org>
  3727. webkitpy: fix race in unit tests for manager_worker_broker
  3728. https://bugs.webkit.org/show_bug.cgi?id=84925
  3729. Reviewed by Ojan Vafai.
  3730. I have been intermittently seeing hangs when running
  3731. test-webkitpy on Mac SL; it appears that there's a bug (?) in
  3732. the multiprocessing module where queue references are getting
  3733. leaked or not cleaned up somehow. By explicitly closing the
  3734. queues, things seem to be happy, so this patch adds a cleanup()
  3735. method to the message broker and modifies the manager (and the
  3736. unit tests) to call it. This may get rid of the intermittent
  3737. error on shutdown on Linux I've seen as well.
  3738. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  3739. (Manager._run_tests):
  3740. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  3741. (_Broker.__del__):
  3742. (_Broker):
  3743. (_Broker.cleanup):
  3744. (_BrokerConnection.cleanup):
  3745. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  3746. (_TestsMixin.test_name):
  3747. (_TestsMixin.test_cancel):
  3748. (_TestsMixin.test_done):
  3749. (_TestsMixin.test_unknown_message):
  3750. 2012-04-27 Gavin Peters <gavinp@chromium.org>
  3751. Add new ENABLE_LINK_PRERENDER define to control the Prerendering API
  3752. https://bugs.webkit.org/show_bug.cgi?id=84871
  3753. Reviewed by Adam Barth.
  3754. Prerendering is currently covered by the ENABLE_LINK_PREFETCH macro, but the new Prerendering
  3755. API separates it from prefetching. Having separate include guards lets ports enable prefetching,
  3756. a relatively easy change, without needing to build the infrastructure for prerendering, which
  3757. is considerably more complicated.
  3758. 2012-04-27 Philippe Normand <pnormand@igalia.com>
  3759. Unreviewed, GTK gardening.
  3760. * Scripts/run-gtk-tests:
  3761. (TestRunner): Skip flaky WebKit2 API test.
  3762. 2012-04-27 Philippe Normand <pnormand@igalia.com>
  3763. Unreviewed, GTK gardening.
  3764. * Scripts/run-gtk-tests:
  3765. (TestRunner): Fix another typo. So easy to get confused by a Test
  3766. name and the actual name of the executable...
  3767. 2012-04-27 Philippe Normand <pnormand@igalia.com>
  3768. Unreviewed, GTK gardening.
  3769. * Scripts/run-gtk-tests:
  3770. (TestRunner): Skip failing WebKit2 API test.
  3771. 2012-04-27 Christophe Dumez <christophe.dumez@intel.com>
  3772. [EFL] DRT should support LayoutTestController's dumpResourceLoadCallbacks()
  3773. https://bugs.webkit.org/show_bug.cgi?id=81891
  3774. Reviewed by Philippe Normand.
  3775. Implement support for LayoutTestController's
  3776. dumpResourceLoadCallbacks() in EFL's DumpRenderTree by catching new
  3777. ewk_view signals about resource loading and print out the expected
  3778. information. This allows for several test cases to be removed from the
  3779. skip list.
  3780. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  3781. (DumpRenderTreeChrome::createView):
  3782. (descriptionSuitableForTestResult):
  3783. (DumpRenderTreeChrome::onResponseReceived):
  3784. (DumpRenderTreeChrome::onResourceLoadFinished):
  3785. (DumpRenderTreeChrome::onResourceLoadFailed):
  3786. (DumpRenderTreeChrome::onNewResourceRequest):
  3787. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  3788. (DumpRenderTreeChrome):
  3789. 2012-04-27 Philippe Normand <pnormand@igalia.com>
  3790. Unreviewed, GTK typo fix.
  3791. * Scripts/run-gtk-tests:
  3792. (TestRunner): Fix-up skipped WebKit2 API test name TestWKConnection.
  3793. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  3794. [SOUP] Add a way to register custom uri schemes in WebKit2
  3795. https://bugs.webkit.org/show_bug.cgi?id=84130
  3796. Reviewed by Martin Robinson.
  3797. * Scripts/webkitpy/style/checkers/cpp.py:
  3798. (check_identifier_name_in_declaration): Add webkit_soup prefix to
  3799. the list of exceptions to the underscores in identifiers rule.
  3800. 2012-04-26 Ryosuke Niwa <rniwa@webkit.org>
  3801. Extract PerfTestFactory
  3802. https://bugs.webkit.org/show_bug.cgi?id=83944
  3803. Reviewed by Dirk Pranke.
  3804. Extracted PerfTestFactory out of PerfTest. This class creates appropriate PerfTest object given
  3805. a test name and a path. Also removed dirname from the constructors of PerfTest and its subclasses.
  3806. Also added simple test cases to sanity check PerfTestFactory.
  3807. * Scripts/webkitpy/performance_tests/perftest.py:
  3808. (PerfTest.__init__):
  3809. (PerfTest.test_name):
  3810. (ChromiumStylePerfTest.__init__):
  3811. (PageLoadingPerfTest.__init__):
  3812. (PageLoadingPerfTest.run):
  3813. (PerfTestFactory):
  3814. (PerfTestFactory.create_perf_test):
  3815. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  3816. (MainTest.test_parse_output):
  3817. (MainTest.test_parse_output_with_failing_line):
  3818. (TestPageLoadingPerfTest.test_run):
  3819. (TestPageLoadingPerfTest.test_run_with_bad_output):
  3820. (TestPerfTestFactory):
  3821. (TestPerfTestFactory.test_regular_test):
  3822. (TestPerfTestFactory.test_inspector_test):
  3823. (TestPerfTestFactory.test_page_loading_test):
  3824. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  3825. (PerfTestsRunner):
  3826. (PerfTestsRunner._collect_tests):
  3827. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  3828. (run_test):
  3829. (_tests_for_runner):
  3830. 2012-04-26 Dirk Pranke <dpranke@chromium.org>
  3831. nrwt: clean up server process, webkit driver so chromium can use it
  3832. https://bugs.webkit.org/show_bug.cgi?id=84910
  3833. Reviewed by Ojan Vafai.
  3834. This change moves the "sample a process" logic out of
  3835. server_process.py and into a port-specific class (where really
  3836. only the mac has an implementation), and also preemptively kills
  3837. DRT when a test times out in WebKitDriver (rather than waiting through the
  3838. additional delays caused by calling stop() when we would want to
  3839. restart the driver generically in worker.py).
  3840. These changes will make it possible for the chromium port to
  3841. switch over to the stock WebKitDriver implementation, at least
  3842. on mac and linux.
  3843. * Scripts/webkitpy/layout_tests/port/base.py:
  3844. (Port.sample_process):
  3845. * Scripts/webkitpy/layout_tests/port/mac.py:
  3846. (MacPort.sample_process):
  3847. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  3848. (test_helper_fails_to_stop):
  3849. (test_sample_process):
  3850. (test_sample_process.logging_run_command):
  3851. (test_sample_process_throws_exception):
  3852. (test_sample_process_throws_exception.throwing_run_command):
  3853. * Scripts/webkitpy/layout_tests/port/server_process.py:
  3854. (ServerProcess._log):
  3855. (ServerProcess._handle_timeout):
  3856. (ServerProcess.stop):
  3857. (ServerProcess):
  3858. (ServerProcess.kill): Here we add a method to immediately stop
  3859. the process rather than trying to shut it down cleanly.
  3860. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  3861. (TestServerProcess.test_broken_pipe):
  3862. * Scripts/webkitpy/layout_tests/port/webkit.py:
  3863. (WebKitDriver.run_test): Fix an issue where we weren't passing
  3864. along any per-test args (only needed for Chromium, but still).
  3865. Also, kill the driver immediately if we time out a test.
  3866. 2012-04-26 Benjamin Poulain <bpoulain@apple.com>
  3867. ObjcClass::methodsNamed() can leak if buffer is dynamically allocated
  3868. https://bugs.webkit.org/show_bug.cgi?id=84668
  3869. Reviewed by Alexey Proskuryakov.
  3870. Extend ObjCPlugin to support the new layout tests of the Objective-C bridge.
  3871. * DumpRenderTree/mac/ObjCPlugin.m:
  3872. (+[ObjCPlugin isSelectorExcludedFromWebScript:]):
  3873. (+[ObjCPlugin webScriptNameForSelector:]):
  3874. (-[ObjCPlugin methodMappedToLongName]):
  3875. (-[ObjCPlugin testConversionColon:]):
  3876. (-[ObjCPlugin _:]):
  3877. 2012-04-26 Dimitri Glazkov <dglazkov@chromium.org>
  3878. Unreviewed, rolling out r115340.
  3879. http://trac.webkit.org/changeset/115340
  3880. https://bugs.webkit.org/show_bug.cgi?id=83048
  3881. Does not work with Windows.
  3882. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  3883. (SingleTestRunner._run_reftest):
  3884. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  3885. (copy_file):
  3886. * Scripts/webkitpy/layout_tests/port/base.py:
  3887. (Port._parse_reftest_list):
  3888. (Port.reference_files):
  3889. (Port._real_tests):
  3890. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  3891. (PortTest.test_reference_files):
  3892. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  3893. (ChromiumDriverTest.test_write_command_and_read_line):
  3894. 2012-04-26 Christophe Dumez <christophe.dumez@intel.com>
  3895. [EFL] Enable VIDEO_TRACK feature
  3896. https://bugs.webkit.org/show_bug.cgi?id=84830
  3897. Reviewed by Gustavo Noronha Silva.
  3898. Enable VIDEO_TRACK by default on EFL port whenever build-webkit is
  3899. used.
  3900. * Scripts/build-webkit:
  3901. 2012-04-08 Robert Hogan <robert@webkit.org>
  3902. new-webkit-run-tests: handle ref tests from the CSS test suite
  3903. https://bugs.webkit.org/show_bug.cgi?id=83048
  3904. Reviewed by Ryosuke Niwa.
  3905. This allows new-run-webkit-tests to run reference tests created for the CSS test suite. It removes a big swathe
  3906. of pixel and text results that are no longer required now that the reference results are used and adds in the support
  3907. files from the CSS test suite that allow the ref tests to run.
  3908. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  3909. (SingleTestRunner._run_reftest): Assert that the reference result exists. Previously the test would
  3910. run without it and report a pass!
  3911. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  3912. (copy_file): ensure the output directory exists, it may not if the reference test is
  3913. contained in a folder that contains nothing but reference tests.
  3914. * Scripts/webkitpy/layout_tests/port/base.py:
  3915. (Port.available_reference_files): Add as a helper. Handle embedded relative paths, e.g: some/../path
  3916. (Port.reference_files): Only return reference results in the reftest list that actually exist on
  3917. disk. Also, don't ignore potential reference results on disk that are not in the reftest list, and
  3918. don't ignore them just because we have a reftest list for the test's directory.
  3919. (Port._real_tests): ignore anything that looks like a test in a 'support' directory, this semantic
  3920. is used by the CSS 2.1 test suite.
  3921. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  3922. (PortTest.test_reference_files_when_reftestlist_and_reference_file_present): Ensure that a test with a reference result
  3923. on disk but no reference result listed in the directory's reftest list picks up its reference result.
  3924. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  3925. (ChromiumDriverTest.test_strip_uri): Test that some/test.html and some/other/../test.html are treated
  3926. as the same file.
  3927. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  3928. Unreviewed. Fix GTK+ build after r115314.
  3929. For some reason it fails while bulding GtkVersioning for WTR, but
  3930. it didn't fail neither in EWS nor in my laptop. We don't really
  3931. need GtkVersioning in WTR since it already depends on GTK+3
  3932. unconditionally.
  3933. * WebKitTestRunner/GNUmakefile.am: Remove GtkVersioning.c from
  3934. compilation.
  3935. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
  3936. (WTR::EventSenderProxy::createMouseButtonEvent): Use GTK+ 3 API
  3937. directly instead of getDefaultGDKPointerDevice() helper.
  3938. (WTR::EventSenderProxy::keyDown): Ditto.
  3939. (WTR::EventSenderProxy::mouseMoveTo): Ditto.
  3940. 2012-04-24 Ojan Vafai <ojan@chromium.org>
  3941. Show flakiness dashboard data in garden-o-matic
  3942. https://bugs.webkit.org/show_bug.cgi?id=83716
  3943. Reviewed by Dimitri Glazkov.
  3944. Put an iframe below the expected/actual results in the Results view.
  3945. Size the iframe to it's height.
  3946. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  3947. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  3948. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  3949. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  3950. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  3951. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  3952. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  3953. 2012-04-26 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  3954. [EFL] [DRT] LayoutTestController needs implementation of setJavaScriptProfilingEnabled
  3955. https://bugs.webkit.org/show_bug.cgi?id=84576
  3956. Reviewed by Martin Robinson.
  3957. Add missing implementation setJavaScriptProfilingEnabled to EFL's
  3958. LayoutTestController in order to unskip tests rely on this setting.
  3959. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  3960. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  3961. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  3962. (LayoutTestController::setJavaScriptProfilingEnabled):
  3963. 2012-04-26 Xianzhu Wang <wangxianzhu@chromium.org>
  3964. Add Jing Zhao, Min Qin, Tien-Ren Chen and Hao Zheng into contributors list.
  3965. Not reviewed.
  3966. * Scripts/webkitpy/common/config/committers.py:
  3967. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  3968. [GTK] Test TestWebKitAPI/WebKit2/TestNewFirstVisuallyNonEmptyLayout times out
  3969. https://bugs.webkit.org/show_bug.cgi?id=84957
  3970. Reviewed by Martin Robinson.
  3971. * Scripts/run-gtk-tests:
  3972. (TestRunner): Unskip TestNewFirstVisuallyNonEmptyLayout and
  3973. TestNewFirstVisuallyNonEmptyLayoutForImages.
  3974. * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
  3975. (TestWebKitAPI::PlatformWebView::PlatformWebView): Show the
  3976. toplevel window containing the web view to make sure events are
  3977. received.
  3978. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  3979. Unreviewed. Add bug numbers to skipped tests.
  3980. * Scripts/run-gtk-tests:
  3981. (TestRunner):
  3982. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  3983. [GTK] Build and run TestWebKitAPI WebKit2 unit tests
  3984. https://bugs.webkit.org/show_bug.cgi?id=84446
  3985. Reviewed by Philippe Normand.
  3986. * Scripts/run-gtk-tests:
  3987. (TestRunner): Add TestWebKitAPI/WebKit2 to the list of directories
  3988. containing tests. Unskip FunctionalTest.RefCountedStorage, since
  3989. we are now using a custom main that initializes WTF threading.
  3990. (TestRunner._setup_testing_environment): Set environment variables
  3991. required to run WebKit2 tests.
  3992. * TestWebKitAPI/GNUmakefile.am:
  3993. * TestWebKitAPI/JavaScriptTest.cpp: Use
  3994. JavaScriptCore/JSContextRef.h instead of
  3995. JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
  3996. unconditionally.
  3997. * TestWebKitAPI/PlatformWebView.h: Define PlatformWKView and
  3998. PlatformWindow for GTK.
  3999. * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Remove
  4000. unneded header that breaks the build of GTK port.
  4001. * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp: Use
  4002. JavaScriptCore/JSContextRef.h instead of
  4003. JavaScriptCore/JavaScriptCore.h since it includes JSStringRefCF.h
  4004. unconditionally.
  4005. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  4006. (TestWebKitAPI::TEST): Add expected values for GTK+ port.
  4007. * TestWebKitAPI/gtk/InjectedBundleControllerGtk.cpp:
  4008. (TestWebKitAPI):
  4009. (TestWebKitAPI::InjectedBundleController::platformInitialize):
  4010. * TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp: Added.
  4011. (TestWebKitAPI::Util::checkTestFinished):
  4012. (TestWebKitAPI::Util::run):
  4013. (TestWebKitAPI::Util::sleep):
  4014. (TestWebKitAPI::Util::getFilenameFromEnvironmentVariableAsUTF8):
  4015. (TestWebKitAPI::Util::createInjectedBundlePath):
  4016. (TestWebKitAPI::Util::createURLForResource):
  4017. (TestWebKitAPI::Util::URLForNonExistentResource):
  4018. (TestWebKitAPI::Util::isKeyDown):
  4019. * TestWebKitAPI/gtk/PlatformWebViewGtk.cpp: Added.
  4020. (TestWebKitAPI::PlatformWebView::PlatformWebView):
  4021. (TestWebKitAPI::PlatformWebView::~PlatformWebView):
  4022. (TestWebKitAPI::PlatformWebView::page):
  4023. (TestWebKitAPI::PlatformWebView::resizeTo):
  4024. (TestWebKitAPI::doKeyStroke):
  4025. (TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
  4026. (TestWebKitAPI::PlatformWebView::simulateAltKeyPress):
  4027. (TestWebKitAPI::doMouseButtonEvent):
  4028. (TestWebKitAPI::PlatformWebView::simulateRightClick):
  4029. (TestWebKitAPI::PlatformWebView::simulateMouseMove):
  4030. * TestWebKitAPI/gtk/main.cpp:
  4031. (main):
  4032. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  4033. [GTK] run-gtk-tests: Use a timeout per test instead of a global timeout
  4034. https://bugs.webkit.org/show_bug.cgi?id=84695
  4035. Reviewed by Philippe Normand.
  4036. It also adds a command line option to be able to pass a custom
  4037. timeout value, instead of hard-coding it. The default timeout is 10
  4038. seconds if no other value is passed to the script.
  4039. * Scripts/run-gtk-tests:
  4040. (TestTimeout): Exception raised when a test times out.
  4041. (TestRunner._get_child_pid_from_test_output): Helper function to
  4042. get the pid of the running test from gtester output.
  4043. (TestRunner._kill_process): Helper funtion ot kill a process
  4044. ignoring exceptions if the process is already died.
  4045. (TestRunner._run_test_command): Run the test command raising
  4046. TestTimeout exception if the test doesn't finish before the given
  4047. timeout in seconds.
  4048. (TestRunner._run_test_command.alarm_handler): Alarm handler that
  4049. raises TestTimeout exception.
  4050. (TestRunner._run_test_glib): Use _run_test_command() to run the test.
  4051. (TestRunner._run_test_google): Ditto.
  4052. (TestRunner.run_tests): Add current test to the list of timed out
  4053. test if TestTimeout exception is raised. Show the list of timed
  4054. out test at the end.
  4055. 2012-04-26 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  4056. [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
  4057. https://bugs.webkit.org/show_bug.cgi?id=83880
  4058. Reviewed by Antonio Gomes.
  4059. Add missing implementation addOriginAccessWhitelistEntry and
  4060. removeOriginAccessWhitelistEntry to EFL's LayoutTestController
  4061. in order to unskip tests which rely on this.
  4062. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4063. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  4064. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  4065. (LayoutTestController::addOriginAccessWhitelistEntry):
  4066. (LayoutTestController::removeOriginAccessWhitelistEntry):
  4067. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  4068. [GTK] Add downloads support to MiniBrowser
  4069. https://bugs.webkit.org/show_bug.cgi?id=73662
  4070. Reviewed by Philippe Normand.
  4071. * MiniBrowser/gtk/BrowserDownloadsBar.c: Added.
  4072. (browserDownloadsBarChildRemoved): Close the downloads bar if
  4073. there aren't active downloads.
  4074. (browserDownloadsBarResponse): Destroy the downloads bar when
  4075. closed.
  4076. (browser_downloads_bar_init):
  4077. (browser_downloads_bar_class_init):
  4078. (browser_downloads_bar_new): Create a new downloads bar.
  4079. (actionButtonClicked): Cancel the download if cancel button was
  4080. clicked, or open the downloaded file if the download finished.
  4081. (browserDownloadFinalize):
  4082. (browser_download_init):
  4083. (browser_download_class_init):
  4084. (downloadReceivedResponse): Update download message using the
  4085. response URI.
  4086. (remainingTime): Helper function to get human readable remaining
  4087. time.
  4088. (downloadProgress): Update downloads progress.
  4089. (downloadReceivedData):
  4090. (downloadFinished): Update download message and turn download
  4091. button into open.
  4092. (downloadFailed): Show error message or destroy the download UI if
  4093. it was cancelled.
  4094. (browserDownloadNew): Create a new download widget for the given
  4095. WebKitDownload.
  4096. (browser_downloads_bar_add_download): Add download widget to the
  4097. downloads bar.
  4098. * MiniBrowser/gtk/BrowserDownloadsBar.h: Added.
  4099. * MiniBrowser/gtk/BrowserWindow.c:
  4100. (downloadStarted): Create a download widget and add it to the
  4101. downloads bar when a new download is started.
  4102. (browserWindowConstructed): Connect to
  4103. WebKitWebContext::download-started signal.
  4104. * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
  4105. 2012-04-26 Carlos Garcia Campos <cgarcia@igalia.com>
  4106. Unreviewed. Skip unit test failing in debug bot.
  4107. * Scripts/run-gtk-tests:
  4108. (TestRunner):
  4109. 2012-04-26 Christophe Dumez <christophe.dumez@intel.com>
  4110. [EFL][DRT] "resource,request,willsend" signal needs to provide more information
  4111. https://bugs.webkit.org/show_bug.cgi?id=84670
  4112. Reviewed by Andreas Kling.
  4113. Handle in EFL's DumpRenderTree the new Ewk_Frame_Resource_Messages now
  4114. passed with the "resource,request,willsend" signal and dump
  4115. information about the network request and the possible network
  4116. response if LayoutTestController's dumpResourceLoadCallbacks() returns
  4117. true.
  4118. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4119. (pathSuitableForTestResult):
  4120. (urlSuitableForTestResult):
  4121. (descriptionSuitableForTestResult):
  4122. (DumpRenderTreeChrome::onWillSendRequest):
  4123. 2012-04-25 Csaba Osztrogonác <ossy@webkit.org>
  4124. [Qt][WK2] Unreviewed, rolling out r113703 because of crashing tests.
  4125. http://trac.webkit.org/changeset/113703
  4126. https://bugs.webkit.org/show_bug.cgi?id=83024
  4127. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  4128. * Tools.pro:
  4129. * qmake/mkspecs/features/features.prf:
  4130. * qmake/mkspecs/features/functions.prf:
  4131. 2012-04-25 Maciej Stachowiak <mjs@apple.com>
  4132. Teach LayoutTestHelper to correctly restore the color profile when it's a factory profile
  4133. https://bugs.webkit.org/show_bug.cgi?id=84931
  4134. Reviewed by Filip Pizlo.
  4135. * DumpRenderTree/mac/LayoutTestHelper.m:
  4136. (installLayoutTestColorProfile): Account for the possibility of the default
  4137. profile being a factory profile.
  4138. 2012-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
  4139. Unreviewed, rolling out r115240.
  4140. http://trac.webkit.org/changeset/115240
  4141. https://bugs.webkit.org/show_bug.cgi?id=84928
  4142. It broke everything (Requested by Ossy_HOME on #webkit).
  4143. * Scripts/webkitpy/layout_tests/port/gtk.py:
  4144. (GtkDriver):
  4145. (GtkDriver._start):
  4146. (GtkDriver._start.x_filter):
  4147. (GtkDriver.stop):
  4148. (GtkPort._driver_class):
  4149. * Scripts/webkitpy/layout_tests/port/qt.py:
  4150. (QtPort._build_driver):
  4151. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Removed.
  4152. 2012-04-25 Dirk Pranke <dpranke@chromium.org>
  4153. [chromium] change DRT's "DRT" output to match the other ports
  4154. https://bugs.webkit.org/show_bug.cgi?id=84904
  4155. Reviewed by Kent Tamura.
  4156. Since we run Chromium's DRT in --test-shell mode, the
  4157. non-test-shell output has never been really beaten on to make
  4158. sure it's right. This fixes a few issues and will be tested
  4159. with upcoming NRWT changes that'll land in a separate patch.
  4160. In particular we should never output framing text like "\n"
  4161. or "#EOF" outside of something outside of TestEventPrinter,
  4162. and we weren't handling audio output properly at all.
  4163. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  4164. (DRTPrinter):
  4165. (TestShellPrinter):
  4166. (DRTPrinter::handleTextFooter):
  4167. (DRTPrinter::handleAudioFooter):
  4168. (DRTPrinter::handleTestFooter):
  4169. (TestShellPrinter::handleAudioFooter):
  4170. * DumpRenderTree/chromium/TestEventPrinter.h:
  4171. (TestEventPrinter):
  4172. * DumpRenderTree/chromium/TestShell.cpp:
  4173. (TestShell::TestShell):
  4174. (TestShell::dump):
  4175. 2012-04-25 Joshua Bell <jsbell@chromium.org>
  4176. Unreviewed: Adding Alec Flett as a contributor (non-committer).
  4177. * Scripts/webkitpy/common/config/committers.py:
  4178. 2012-04-25 Abhishek Arya <inferno@chromium.org>
  4179. Mark myself as a reviewer.
  4180. https://bugs.webkit.org/show_bug.cgi?id=84902
  4181. Reviewed by Dimitri Glazkov.
  4182. * Scripts/webkitpy/common/config/committers.py:
  4183. 2012-04-25 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  4184. [Qt][NRWT] Run each DRT in it's own xvfb
  4185. https://bugs.webkit.org/show_bug.cgi?id=77335
  4186. Reviewed by Dirk Pranke.
  4187. * Scripts/webkitpy/layout_tests/port/gtk.py:
  4188. (GtkPort._driver_class):
  4189. * Scripts/webkitpy/layout_tests/port/qt.py:
  4190. (QtPort._driver_class):
  4191. * Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
  4192. (XvfbDriver):
  4193. (XvfbDriver._start):
  4194. (XvfbDriver._start.x_filter):
  4195. (XvfbDriver.stop):
  4196. 2012-04-25 Sheriff Bot <webkit.review.bot@gmail.com>
  4197. Unreviewed, rolling out r115222.
  4198. http://trac.webkit.org/changeset/115222
  4199. https://bugs.webkit.org/show_bug.cgi?id=84874
  4200. Caused test regressions on the EFL build (Requested by rakuco
  4201. on #webkit).
  4202. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  4203. (LayoutTestController::addOriginAccessWhitelistEntry):
  4204. (LayoutTestController::removeOriginAccessWhitelistEntry):
  4205. 2012-04-25 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  4206. [EFL] [DRT] LayoutTestController needs implementation of addOriginAccessWhitelistEntry and removeOriginAccessWhitelistEntry
  4207. https://bugs.webkit.org/show_bug.cgi?id=83880
  4208. Reviewed by Antonio Gomes.
  4209. Add missing implementation addOriginAccessWhitelistEntry and
  4210. removeOriginAccessWhitelistEntry to EFL's LayoutTestController
  4211. in order to unskip tests which rely on this.
  4212. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  4213. (LayoutTestController::addOriginAccessWhitelistEntry):
  4214. (LayoutTestController::removeOriginAccessWhitelistEntry):
  4215. 2012-04-25 Thiago Marcos P. Santos <thiago.santos@intel.com>
  4216. [EFL] [DRT] Reset text zoom factor before running a test
  4217. https://bugs.webkit.org/show_bug.cgi?id=84861
  4218. Reviewed by Antonio Gomes.
  4219. This fix eliminates most of the current flakiness on EFL build
  4220. bots, although some CSS tests will now need rebasiling.
  4221. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4222. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  4223. 2012-04-25 Milian Wolff <milian.wolff@kdab.com>
  4224. [Qt] add LayoutTestController::setPrinting support to Qt unit tests
  4225. https://bugs.webkit.org/show_bug.cgi?id=84246
  4226. Reviewed by Simon Hausmann.
  4227. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  4228. (WebCore::DumpRenderTree::dump):
  4229. 2012-04-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  4230. [Qt] Make the web view's url property follow the active url
  4231. https://bugs.webkit.org/show_bug.cgi?id=77554
  4232. Update the location bar in the minibrowser to behave
  4233. a bit more like normal browsers in terms of when the url will change
  4234. and how active focus is handled.
  4235. Reviewed by Simon Hausmann.
  4236. * MiniBrowser/qt/qml/BrowserWindow.qml:
  4237. 2012-04-25 Philippe Normand <pnormand@igalia.com>
  4238. Webkit build fails due to missing gstreamer include file on Kubuntu 8.04
  4239. https://bugs.webkit.org/show_bug.cgi?id=81913
  4240. Reviewed by Tor Arne Vestbø.
  4241. * qmake/mkspecs/features/features.prf: Check for gstreamer-0.10
  4242. and gstreamer-plugins-base >= 0.10.30 just like the GTK port
  4243. does. 0.10.27 is unfortunately not recent enough to get the media
  4244. player working reliably.
  4245. 2012-04-25 Xiaobo Wang <xbwang@torchmobile.com.cn>
  4246. [BlackBerry] Run tests in '/http/tests/local' with local URI
  4247. https://bugs.webkit.org/show_bug.cgi?id=84820
  4248. Reviewed by Nikolas Zimmermann.
  4249. Currently we run all tests under folder "/http/tests/" as HTTP
  4250. tests (http://...). However in WebKit ORWT and NRWT scripts, tests in
  4251. 'http/tests/local' are run with local path (like '/developer/LayoutTests
  4252. /http/tests/local/absolute-url-strip-whitespace.html').
  4253. With this patch we can keep the same behaviour as other portings.
  4254. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  4255. (BlackBerry::WebKit::DumpRenderTree::isHTTPTest):
  4256. 2012-04-25 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  4257. [EFL][DRT] Reset DRT settings to their default values after a testcase was executed.
  4258. https://bugs.webkit.org/show_bug.cgi?id=84709
  4259. Reviewed by Eric Seidel.
  4260. Not all the settings that can be changed by layout testcases through a JS API were
  4261. reset in DumpRenderTreeChrome::resetDefaultsToConsistentValues().
  4262. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4263. (defaultEditingBehavior): returns editing behavior depending on current platform.
  4264. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): reset some missed DRT settings
  4265. 2012-04-24 Dirk Pranke <dpranke@chromium.org>
  4266. nrwt: add ASAN handling to chromium crash logs
  4267. https://bugs.webkit.org/show_bug.cgi?id=84664
  4268. Reviewed by Ojan Vafai.
  4269. * Scripts/webkitpy/layout_tests/port/chromium.py:
  4270. (ChromiumPort._get_crash_log):
  4271. 2012-04-24 Dirk Pranke <dpranke@chromium.org>
  4272. webkit-patch rebaseline-test is retrieving stale expectations
  4273. https://bugs.webkit.org/show_bug.cgi?id=84762
  4274. Reviewed by Ojan Vafai.
  4275. webkit-patch rebaseline-expectations is fetching files directly
  4276. from the layout-test-results directory on the buildbots, rather
  4277. than fetching them from the archive. This is problematic because
  4278. we don't clobber the directory after each run and so you can end
  4279. up fetching stale failing results.
  4280. This change temporarily changes the code to fetch the zip file
  4281. instead -- making things much slower -- until I can confer w/
  4282. abarth and ojan over the best way to fix this for the long-term.
  4283. * Scripts/webkitpy/tool/commands/rebaseline.py:
  4284. (RebaselineTest.__init__):
  4285. (RebaselineTest._zip_file_set):
  4286. (RebaselineTest):
  4287. (RebaselineTest._fetch_baseline):
  4288. (RebaselineTest._rebaseline_test):
  4289. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  4290. (TestRebaseline.stub_rebaseline_test_command_and_tool):
  4291. (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet):
  4292. (TestRebaseline.stub_rebaseline_test_command_and_tool.FakeZipFileSet.read):
  4293. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  4294. (test_rebaseline_updates_expectations_file):
  4295. (test_rebaseline_test):
  4296. (test_rebaseline_and_copy_test):
  4297. (test_rebaseline_and_copy_test_no_existing_result):
  4298. (test_rebaseline_and_copy_test_with_lion_result):
  4299. (test_rebaseline_and_copy_no_overwrite_test):
  4300. 2012-04-24 Ojan Vafai <ojan@chromium.org>
  4301. Improve code for embedding flakiness dashboard as an iframe
  4302. https://bugs.webkit.org/show_bug.cgi?id=84782
  4303. Reviewed by Dirk Pranke.
  4304. -Include the horizontal scrollbar height in the measured height of the page.
  4305. -Post a message everytime the height changes instead of in response to a queryContentHeight message.
  4306. This way, the embedder doesn't need to poll.
  4307. No new tests. This is hard to test because it involves postMessage and iframes.
  4308. Once we switch the dashboard tests over to qunit, we should be able to write an
  4309. asyncTest for this.
  4310. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  4311. (generatePage):
  4312. (appendHTML):
  4313. (appendExpectations):
  4314. (postHeightChangedMessage):
  4315. (generatePageForIndividualTests.if):
  4316. (generatePageForIndividualTests):
  4317. * TestResultServer/static-dashboards/flakiness_dashboard_embedded.html: Added.
  4318. 2012-04-16 Ojan Vafai <ojan@chromium.org>
  4319. Replace garden-o-matic accordion UI with a panel UI
  4320. https://bugs.webkit.org/show_bug.cgi?id=84081
  4321. Reviewed by Dimitri Glazkov.
  4322. This is a nicer UI to work with and makes it easier to embed the flakiness dashboard,
  4323. since we can reuse the same iframe without moving it in the DOM.
  4324. Also, excise unnecessary jquery-isms.
  4325. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  4326. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  4327. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  4328. 2012-04-24 Peter Beverloo <peter@chromium.org>
  4329. [Chromium] DumpRenderTree should depend on base.gyp:test_support_base
  4330. https://bugs.webkit.org/show_bug.cgi?id=84729
  4331. Reviewed by Dirk Pranke.
  4332. This dependency is necessary for Android since it'll soon be
  4333. calling InitAndroidOSPathStub() in it's platform support. The
  4334. TestWebKitAPI and webkit_unit_tests already have this dependency.
  4335. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  4336. 2012-04-24 Ojan Vafai <ojan@chromium.org>
  4337. Replace vague informative statement with the list of builders where the test isn't listed
  4338. https://bugs.webkit.org/show_bug.cgi?id=84779
  4339. Reviewed by Dirk Pranke.
  4340. This is more informative and more likely to be noticed. With the old UI, people never
  4341. read the line and if they did, they didn't really understand what it meant. Hopefully
  4342. have the list of builders will be more clear.
  4343. * TestResultServer/static-dashboards/flakiness_dashboard.js:
  4344. * TestResultServer/static-dashboards/flakiness_dashboard_tests.css:
  4345. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  4346. 2012-04-24 Tommy Widenflycht <tommyw@google.com>
  4347. MediaStream API: Create a new flag for PeerConnection
  4348. https://bugs.webkit.org/show_bug.cgi?id=84723
  4349. Reviewed by Dimitri Glazkov.
  4350. To allow Chrome to make the GetUserMedia functionality available by default we
  4351. need another flag for the PeerConnection related parts. This new flag is in
  4352. addition to the general media stream flag, and both need to be enabled for
  4353. PeerConnection object creation.
  4354. * DumpRenderTree/chromium/TestShell.cpp:
  4355. (TestShell::TestShell):
  4356. 2012-04-24 Joe Mason <jmason@rim.com>
  4357. [BlackBerry] Revert broken changes to authentication dialog
  4358. https://bugs.webkit.org/show_bug.cgi?id=80135
  4359. Reviewed by Antonio Gomes.
  4360. The previous patches from this bug caused an infinite loop when using digest auth;
  4361. apparently they were only tested with basic.
  4362. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  4363. * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
  4364. (WebCore):
  4365. 2012-04-24 Zan Dobersek <zandobersek@gmail.com>
  4366. [TestResultsServer] Add a unit test for changes in r114868
  4367. https://bugs.webkit.org/show_bug.cgi?id=84713
  4368. Reviewed by Ojan Vafai.
  4369. Add a new unit test to test the isToTWebKit attribute of a BuilderGroup object
  4370. that is created for either DEPS or ToT builder groups. The unit test covers changes
  4371. made in r114868.
  4372. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
  4373. (testBuilderGroupIsToTWebKitAttribute.g_handleBuildersListLoaded):
  4374. (testBuilderGroupIsToTWebKitAttribute.assertEquals):
  4375. 2012-04-24 Brady Eidson <beidson@apple.com>
  4376. <rdar://problem/10120155> and https://bugs.webkit.org/show_bug.cgi?id=82664
  4377. Need DOMWindow mechanism to supplement UserScripts for page cache notifications
  4378. Reviewed by Sam Weinig.
  4379. Add a new bundle test that stresses the basics of the WKBundleDOMWindowExtension API.
  4380. It makes sure new extensions can be added at the right times, and that all of the expected
  4381. callbacks are made.
  4382. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic.cpp: Added.
  4383. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record all messages sent from the bundle.
  4384. (TestWebKitAPI::TEST): Run a page through some basic exercises, then compared messages sent from the
  4385. bundle to a set of known expected messages.
  4386. Listen to all the new client callbacks, create some extensions, and monitor their lifetimes:
  4387. * TestWebKitAPI/Tests/WebKit2/DOMWindowExtensionBasic_Bundle.cpp: Added.
  4388. (TestWebKitAPI::DOMWindowExtensionBasic::DOMWindowExtensionBasic):
  4389. (TestWebKitAPI::DOMWindowExtensionBasic::frameLoadFinished):
  4390. (TestWebKitAPI::DOMWindowExtensionBasic::sendExtensionStateMessage):
  4391. (TestWebKitAPI::DOMWindowExtensionBasic::initialize):
  4392. (TestWebKitAPI::DOMWindowExtensionBasic::didCreatePage):
  4393. (TestWebKitAPI::DOMWindowExtensionBasic::updateExtensionStateRecord):
  4394. (TestWebKitAPI::DOMWindowExtensionBasic::sendBundleMessage):
  4395. (TestWebKitAPI::DOMWindowExtensionBasic::didCreateGlobalObjectForFrame):
  4396. (TestWebKitAPI::DOMWindowExtensionBasic::willDisconnectDOMWindowExtensionFromGlobalObject):
  4397. (TestWebKitAPI::DOMWindowExtensionBasic::didReconnectDOMWindowExtensionToGlobalObject):
  4398. (TestWebKitAPI::DOMWindowExtensionBasic::willDestroyGlobalObjectForDOMWindowExtension):
  4399. (TestWebKitAPI::didFinishLoadForFrameCallback):
  4400. (TestWebKitAPI::didCreateGlobalObjectForFrameCallback):
  4401. (TestWebKitAPI::willDisconnectDOMWindowExtensionFromGlobalObjectCallback):
  4402. (TestWebKitAPI::didReconnectDOMWindowExtensionToGlobalObjectCallback):
  4403. (TestWebKitAPI::willDestroyGlobalObjectForDOMWindowExtensionCallback):
  4404. * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  4405. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Make this method static, as it always should have been.
  4406. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  4407. 2012-04-24 Carlos Garcia Campos <cgarcia@igalia.com>
  4408. [GTK] Build and run TestWebKitAPI unit tests
  4409. https://bugs.webkit.org/show_bug.cgi?id=84325
  4410. Reviewed by Philippe Normand.
  4411. We only build WTF unit tests for now. WebKit2 tests will be
  4412. enabled in a follow up patch.
  4413. * Scripts/run-gtk-tests:
  4414. (TestRunner): Add TestWebKitAPI/WTF to the list of directories
  4415. containing unit tests.
  4416. (TestRunner._run_test_glib): Run glib tests using gtester.
  4417. (TestRunner._run_test_google): Run google tests.
  4418. (TestRunner._run_test): Use _run_test_glib or _run_test_google
  4419. depending on whether given test is glib or google test
  4420. * TestWebKitAPI/GNUmakefile.am: Added.
  4421. * TestWebKitAPI/config.h: Use #ifdef instead of # to fix a compile
  4422. warning with -Wundef. Include WebKit2 headers only when building
  4423. WebKit2.
  4424. 2012-04-24 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  4425. [Qt][WK2] Convert touch-point area
  4426. https://bugs.webkit.org/show_bug.cgi?id=84434
  4427. Reviewed by Kenneth Rohde Christiansen.
  4428. Fix failing test after r114917 by also adding the new EventSender API
  4429. to WebKitTestRunner.
  4430. * WebKitTestRunner/EventSenderProxy.h:
  4431. (EventSenderProxy):
  4432. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  4433. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  4434. (WTR::EventSendingController::setTouchPointRadius):
  4435. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  4436. (EventSendingController):
  4437. * WebKitTestRunner/TestController.cpp:
  4438. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  4439. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  4440. (WTR::EventSenderProxy::addTouchPoint):
  4441. (WTR::EventSenderProxy::updateTouchPoint):
  4442. (WTR::EventSenderProxy::setTouchPointRadius):
  4443. (WTR::EventSenderProxy::clearTouchPoints):
  4444. 2012-04-24 Mikhail Naganov <mnaganov@chromium.org>
  4445. [Chromium] Unreviewed test expectations update.
  4446. https://bugs.webkit.org/show_bug.cgi?id=84726
  4447. Mark webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_start_cmd as failing on Windows.
  4448. * Scripts/webkitpy/test/test_finder.py:
  4449. (TestFinder._default_names):
  4450. 2012-04-24 Christophe Dumez <christophe.dumez@intel.com>
  4451. [EFL] Enable Web Timing
  4452. https://bugs.webkit.org/show_bug.cgi?id=84705
  4453. Reviewed by Tony Gentilcore.
  4454. Enable web timing by default whenever build-webkit is used.
  4455. * Scripts/build-webkit:
  4456. 2012-04-23 Eriq Augustine <eaugusti@chromium.org>
  4457. Return value from executed script in Chromium.
  4458. https://bugs.webkit.org/show_bug.cgi?id=79851
  4459. Reviewed by Adam Barth.
  4460. Adding a function to LayoutTestController that evaluates a script in
  4461. an isolated wold an returns the result of the evaluation.
  4462. * DumpRenderTree/LayoutTestController.cpp:
  4463. (evaluateScriptInIsolatedWorldAndReturnValue):
  4464. (LayoutTestController::staticFunctions):
  4465. * DumpRenderTree/LayoutTestController.h:
  4466. (LayoutTestController):
  4467. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  4468. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4469. * DumpRenderTree/chromium/LayoutTestController.cpp:
  4470. (LayoutTestController::LayoutTestController):
  4471. (LayoutTestController::setXSSAuditorEnabled):
  4472. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4473. * DumpRenderTree/chromium/LayoutTestController.h:
  4474. (LayoutTestController):
  4475. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  4476. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4477. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  4478. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4479. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  4480. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4481. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  4482. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4483. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  4484. (LayoutTestController):
  4485. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  4486. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4487. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  4488. (LayoutTestController::evaluateScriptInIsolatedWorldAndReturnValue):
  4489. 2012-04-23 Dirk Pranke <dpranke@chromium.org>
  4490. run-perf-tests fail intermittently with an exception
  4491. https://bugs.webkit.org/show_bug.cgi?id=83532
  4492. Reviewed by Ryosuke Niwa.
  4493. This bulletproofs port.get_option('child_processes')
  4494. against the case where the option wasn't set.
  4495. * Scripts/webkitpy/layout_tests/port/mac.py:
  4496. (MacPort._get_crash_log):
  4497. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  4498. (test_get_crash_log):
  4499. (test_get_crash_log.fake_time_cb):
  4500. 2012-04-23 Balazs Kelemen <kbalazs@webkit.org>
  4501. [Qt] Add desktop zooming support for QQuickWebView
  4502. https://bugs.webkit.org/show_bug.cgi?id=82337
  4503. Unreviewed typo fix after r114900.
  4504. * MiniBrowser/qt/BrowserWindow.cpp:
  4505. (BrowserWindow::BrowserWindow): Fix the mistyped
  4506. value of a zoom level.
  4507. 2012-04-23 Hao Zheng <zhenghao@chromium.org>
  4508. [chromium-android] Get rid of the trick that replaces system fallback font with DejaVuSans.
  4509. https://bugs.webkit.org/show_bug.cgi?id=84580
  4510. Reviewed by Ojan Vafai.
  4511. Android's first fallback font is changed to DroidSansArabic.ttf in JB.
  4512. Take the opportunity to get rid of the trick.
  4513. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  4514. (ChromiumAndroidPort.start_helper):
  4515. (ChromiumAndroidPort._push_fonts):
  4516. 2012-04-23 Dirk Pranke <dpranke@chromium.org>
  4517. test-webkitpy is failing
  4518. https://bugs.webkit.org/show_bug.cgi?id=84617
  4519. Reviewed by Eric Seidel.
  4520. * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  4521. (HttpLockTestWithRealFileSystem.clean_all_lockfile):
  4522. 2012-04-23 Ojan Vafai <ojan@chromium.org>
  4523. Split up flakiness_dashboard.html into multiple files. This is a step in the direction
  4524. of making the code more maintainable (e.g. being able to use qunit for testing).
  4525. * TestResultServer/static-dashboards/dashboard_base.js:
  4526. * TestResultServer/static-dashboards/flakiness_dashboard.css: Added.
  4527. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  4528. * TestResultServer/static-dashboards/flakiness_dashboard.js: Copied from Tools/TestResultServer/static-dashboards/flakiness_dashboard.html.
  4529. * TestResultServer/static-dashboards/flakiness_dashboard_tests.css: Added.
  4530. * TestResultServer/static-dashboards/flakiness_dashboard_unittests.js: Renamed from Tools/TestResultServer/static-dashboards/flakiness_dashboard_tests.js.
  4531. 2012-04-23 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  4532. [Qt][WK2] Convert touch-point area.
  4533. https://bugs.webkit.org/show_bug.cgi?id=84434
  4534. Reviewed by Kenneth Rohde Christiansen.
  4535. Add feature to set touch-point radius for emitted touch-events.
  4536. * DumpRenderTree/qt/EventSenderQt.cpp:
  4537. (EventSender::addTouchPoint):
  4538. (EventSender::updateTouchPoint):
  4539. (EventSender::setTouchPointRadius):
  4540. (EventSender::clearTouchPoints):
  4541. * DumpRenderTree/qt/EventSenderQt.h:
  4542. (EventSender):
  4543. 2012-04-23 Christophe Dumez <christophe.dumez@intel.com>
  4544. [EFL] EFL's LayoutTestController does not implement elementDoesAutoCompleteForElementWithId
  4545. https://bugs.webkit.org/show_bug.cgi?id=84425
  4546. Reviewed by Antonio Gomes.
  4547. Use the new helper in DumpRenderTreeSupportEfl to properly
  4548. test whether an element performs autocompletion.
  4549. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  4550. (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  4551. 2012-04-23 Csaba Osztrogonác <ossy@webkit.org>
  4552. master.cfg cleanup, remove dead codes after r92792.
  4553. https://bugs.webkit.org/show_bug.cgi?id=84433
  4554. Relanding r114881 after typo fix in UploadBuiltProduct.
  4555. Reviewed by Ryosuke Niwa.
  4556. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  4557. 2012-04-23 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  4558. [EFL][DRT] Need to support requestAnimationFrame
  4559. https://bugs.webkit.org/show_bug.cgi?id=84585
  4560. Reviewed by Martin Robinson.
  4561. Making requestAnimationFrame() support a default on the EFL build.
  4562. * Scripts/build-webkit:
  4563. 2012-04-23 Balazs Kelemen <kbalazs@webkit.org>
  4564. [Qt] Add desktop zooming support for QQuickWebView
  4565. https://bugs.webkit.org/show_bug.cgi?id=82337
  4566. Reviewed by Simon Hausmann.
  4567. Add zooming support for MiniBrowser to
  4568. test the new API.
  4569. * MiniBrowser/qt/BrowserWindow.cpp:
  4570. (BrowserWindow::BrowserWindow):
  4571. (BrowserWindow::zoomIn):
  4572. (BrowserWindow::zoomOut):
  4573. (BrowserWindow::keyPressEvent):
  4574. (BrowserWindow::wheelEvent):
  4575. * MiniBrowser/qt/BrowserWindow.h:
  4576. (BrowserWindow):
  4577. 2012-04-23 Csaba Osztrogonác <ossy@webkit.org>
  4578. Unreviewed rolling out r114881, because it broke upload buildstep.
  4579. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  4580. (ConfigureBuild.__init__):
  4581. (ConfigureBuild.start):
  4582. (CompileWebKit.start):
  4583. (UploadBuiltProduct):
  4584. (UploadBuiltProduct.determineExtraFeatures):
  4585. (Factory.__init__):
  4586. (BuildFactory.__init__):
  4587. (TestFactory.__init__):
  4588. (loadBuilderConfig):
  4589. 2012-04-23 Csaba Osztrogonác <ossy@webkit.org>
  4590. master.cfg cleanup, remove dead codes after r92792.
  4591. https://bugs.webkit.org/show_bug.cgi?id=84433
  4592. Reviewed by Ryosuke Niwa.
  4593. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  4594. 2012-04-23 Milian Wolff <mail@milianw.de>
  4595. [Qt] Make DRT not dump pixel results if test is calling layoutTestController.dumpAsText()
  4596. https://bugs.webkit.org/show_bug.cgi?id=84327
  4597. Reviewed by Csaba Osztrogonác.
  4598. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  4599. (WebCore::DumpRenderTree::dump):
  4600. 2012-04-22 Sriram Neelakandan <sriram.neelakandan@gmail.com>
  4601. [Gtk] Added MOZ_X11 build flag for TARGET_X11
  4602. https://bugs.webkit.org/show_bug.cgi?id=40785
  4603. Reviewed by Anders Carlsson.
  4604. * GNUmakefile.am:
  4605. 2012-04-22 Zan Dobersek <zandobersek@gmail.com>
  4606. [TestResultsServer] Impossible to inspect builds on non-Chromium builders
  4607. https://bugs.webkit.org/show_bug.cgi?id=84544
  4608. Reviewed by Ryosuke Niwa.
  4609. Use the groupEnum parameter that is passed through to the onBuilderListLoad
  4610. function rather than an undefined attribute of the BuilderGroup object. This
  4611. makes it again possible to inspect builds on non-Chromium builders in the
  4612. test results server by not trying to always add Chromium revision links.
  4613. * TestResultServer/static-dashboards/builders.js:
  4614. 2012-04-20 Martin Robinson <mrobinson@igalia.com>
  4615. [GTK] Revert changes that disabled Cairo fonts metrics hinting
  4616. https://bugs.webkit.org/show_bug.cgi?id=84502
  4617. Reviewed by Daniel Bates.
  4618. Re-enable Cairo metrics hinting, which seems to ensure consistent results in
  4619. reference and pixel test results. This makes our font metrics a bit different
  4620. than the Mac port's, but it's a decent price to pay for consistent results.
  4621. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  4622. (initializeGtkFontSettings):
  4623. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  4624. (WTR::initializeGtkSettings):
  4625. 2012-04-04 Jer Noble <jer.noble@apple.com>
  4626. apple.com top navigation bar appears inside video during full screen exit animation
  4627. https://bugs.webkit.org/show_bug.cgi?id=83095
  4628. Reviewed by Eric Carlson.
  4629. Add a new LayoutTestController function, setHasCustomFullScreenBehavior(), which allows scripts to
  4630. disable the standard full screen behavior, and replace it with explicit callbacks to the relevant
  4631. Document methods from within the script. This allows subtle timing bugs to be consistently reproduced
  4632. from within LayoutTests.
  4633. Add the new methods, hasCustomFullScreenBehavior() and setHasCustomFullScreenBehavior():
  4634. * DumpRenderTree/LayoutTestController.cpp:
  4635. (setHasCustomFullScreenBehaviorCallback):
  4636. (LayoutTestController::staticFunctions):
  4637. * DumpRenderTree/LayoutTestController.h:
  4638. (LayoutTestController::setHasCustomFullScreenBehavior):
  4639. (LayoutTestController::hasCustomFullScreenBehavior):
  4640. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  4641. (WTR::InjectedBundlePage::enterFullScreenForElement):
  4642. (WTR::InjectedBundlePage::exitFullScreenForElement):
  4643. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  4644. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  4645. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  4646. (WTR::LayoutTestController::setHasCustomFullScreenBehavior):
  4647. (WTR::LayoutTestController::hasCustomFullScreenBehavior):
  4648. * DumpRenderTree/chromium/LayoutTestController.cpp:
  4649. (LayoutTestController::LayoutTestController):
  4650. (LayoutTestController::reset):
  4651. * DumpRenderTree/chromium/LayoutTestController.h:
  4652. (LayoutTestController::setHasCustomFullScreenBehavior):
  4653. (LayoutTestController::hasCustomFullScreenBehavior):
  4654. Query the new methods before calling will/did/Enter/ExitFullScreen:
  4655. * DumpRenderTree/chromium/WebViewHost.cpp:
  4656. (WebViewHost::enterFullScreenNow):
  4657. (WebViewHost::exitFullScreenNow):
  4658. * DumpRenderTree/mac/UIDelegate.mm:
  4659. (-[UIDelegate webView:enterFullScreenForElement:listener:]):
  4660. (-[UIDelegate webView:exitFullScreenForElement:listener:]):
  4661. 2012-04-20 Nandor Huszka <hnandor@inf.u-szeged.hu>
  4662. NRWT: option --skip-pixel-test-if-no-baseline support on DRT
  4663. https://bugs.webkit.org/show_bug.cgi?id=72841
  4664. Reviewed by Dirk Pranke
  4665. This patch implements support for --skip-pixel-test-if-no-baseline generically in NRWT,
  4666. instead of in every DRT and WTR implementation. We add 'should_run_pixel_test'
  4667. and 'reference_files' fields to the TestInput objects, and use those flags
  4668. to select the right driver to use in the DriverProxy.
  4669. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  4670. (SingleTestRunner.__init__):
  4671. (SingleTestRunner._driver_input):
  4672. (SingleTestRunner._run_reftest):
  4673. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  4674. (Worker.handle_test_list):
  4675. (Worker._update_test_input):
  4676. * Scripts/webkitpy/layout_tests/models/test_input.py:
  4677. (TestInput):
  4678. (TestInput.__init__):
  4679. (TestInput.__repr__):
  4680. * Scripts/webkitpy/layout_tests/port/chromium.py:
  4681. (ChromiumDriver._wrapper_options):
  4682. (ChromiumDriver.run_test):
  4683. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  4684. (ChromiumDriverTest.test_crash_log):
  4685. * Scripts/webkitpy/layout_tests/port/driver.py:
  4686. (DriverInput.__init__):
  4687. (Driver.__init__):
  4688. (DriverProxy.__init__):
  4689. (DriverProxy.run_test):
  4690. (DriverProxy.start):
  4691. (DriverProxy.cmd_line):
  4692. * Scripts/webkitpy/layout_tests/port/gtk.py:
  4693. (GtkDriver._start):
  4694. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  4695. (MockDRT.run):
  4696. (MockDRT.input_from_line):
  4697. (MockDRT.output_for_test):
  4698. (MockDRT.write_test_output):
  4699. (MockChromiumDRT.input_from_line):
  4700. (MockChromiumDRT.output_for_test):
  4701. (MockChromiumDRT.write_test_output):
  4702. * Scripts/webkitpy/layout_tests/port/webkit.py:
  4703. (WebKitDriver.cmd_line):
  4704. (WebKitDriver.run_test):
  4705. * WebKitTestRunner/TestController.cpp:
  4706. (WTR::TestController::TestController):
  4707. (WTR::TestController::initialize):
  4708. (WTR::TestController::runTest):
  4709. * WebKitTestRunner/TestController.h:
  4710. (TestController):
  4711. * WebKitTestRunner/TestInvocation.cpp:
  4712. (WTR::TestInvocation::TestInvocation):
  4713. (WTR::TestInvocation::setIsPixelTest):
  4714. * WebKitTestRunner/TestInvocation.h:
  4715. (TestInvocation):
  4716. 2012-04-20 Thiago Marcos P. Santos <thiago.santos@intel.com>
  4717. [EFL] Make it possible to define offline storage quota per origin
  4718. https://bugs.webkit.org/show_bug.cgi?id=84170
  4719. Improved LayoutTestController::setDatabaseQuota to set quota based on
  4720. origin which was causing some tests to fail. Also align the default
  4721. quota for testing (5MB) with others ports.
  4722. When dumpDatabaseCallbacks is set to true by, also dump some database
  4723. information when quota is exceed, which is also required by some tests.
  4724. Reviewed by Antonio Gomes.
  4725. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4726. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  4727. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  4728. (onExceededDatabaseQuota):
  4729. (drtViewAdd):
  4730. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  4731. (LayoutTestController::setDatabaseQuota):
  4732. 2012-04-20 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  4733. [EFL] [DRT] Send double click event from EventSender
  4734. https://bugs.webkit.org/show_bug.cgi?id=82867
  4735. Reviewed by Daniel Bates.
  4736. Add support for EFL DumpRenderTree EventSender to send
  4737. double click events.
  4738. * DumpRenderTree/efl/EventSender.cpp:
  4739. (sendMouseEvent):
  4740. 2012-04-20 Sergio Villar Senin <svillar@igalia.com>
  4741. [GTK] Enable Web Timing
  4742. https://bugs.webkit.org/show_bug.cgi?id=42432
  4743. Reviewed by Gustavo Noronha Silva.
  4744. Build web timing by default whenever build-webkit is used.
  4745. * Scripts/build-webkit:
  4746. 2012-04-20 Kamil Blank <k.blank@samsung.com>
  4747. [EFL] Add missing reset for setAuthorAndUserStylesEnabled inside DRT.
  4748. https://bugs.webkit.org/show_bug.cgi?id=84430
  4749. Reviewed by Daniel Bates.
  4750. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4751. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  4752. 2012-04-20 Ryosuke Niwa <rniwa@webkit.org>
  4753. REGRESSION(r112781): Windows build slaves are no longer including .pdb files in archives handed to testers
  4754. https://bugs.webkit.org/show_bug.cgi?id=84424
  4755. Reviewed by Mark Rowe.
  4756. Let Windows and Chromium have their own list of files to copy.
  4757. * BuildSlaveSupport/built-product-archive:
  4758. (removeDirectoryIfExists):
  4759. (copyBuildFiles):
  4760. (archiveBuiltProduct):
  4761. 2012-04-20 Kamil Blank <k.blank@samsung.com>
  4762. [EFL] Add setting API for author and user styles.
  4763. https://bugs.webkit.org/show_bug.cgi?id=82860
  4764. Reviewed by Daniel Bates.
  4765. Implementation of setAuthorAndUserStylesEnabled.
  4766. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  4767. (LayoutTestController::setAuthorAndUserStylesEnabled):
  4768. 2012-04-19 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  4769. [EFL] Missing keycode translation for space key
  4770. https://bugs.webkit.org/show_bug.cgi?id=84153
  4771. Reviewed by Antonio Gomes.
  4772. Set keyname for space key before dispatching event.
  4773. * DumpRenderTree/efl/EventSender.cpp:
  4774. (keyNameFromJSValue):
  4775. 2012-04-19 Carlos Garcia Campos <cgarcia@igalia.com>
  4776. [GTK] Allow to use WebInspector in GtkLauncher
  4777. https://bugs.webkit.org/show_bug.cgi?id=84143
  4778. Reviewed by Martin Robinson.
  4779. * GNUmakefile.am: Add new files to compilation.
  4780. * GtkLauncher/LauncherInspectorWindow.c: Added.
  4781. (launcherInspectorWindowFinalize):
  4782. (launcher_inspector_window_init):
  4783. (launcher_inspector_window_class_init):
  4784. (inspectedURIChanged): Update the window title based on current
  4785. inspected URI.
  4786. (showInspectorWindow): Show inspector window.
  4787. (closeInspectorWindow): Hide inspector window.
  4788. (launcherInspectorWindowNew): Create an inspector window.
  4789. (launcherInspectorWindowGetWebView): Return the inspected web view.
  4790. * GtkLauncher/LauncherInspectorWindow.h: Added.
  4791. * GtkLauncher/main.c:
  4792. (inspectorInspectWebViewCb): Create an inspector window.
  4793. (createBrowser): Connect to inspect-web-view signal of the view
  4794. inspector.
  4795. 2012-04-19 Jeremy Mao <yujie.mao@intel.com>
  4796. Media Stream API: Piece of code cleanup for the chromium port
  4797. https://bugs.webkit.org/show_bug.cgi?id=84328
  4798. Reviewed by Kent Tamura.
  4799. WebUserMediaClientMock use an old requestUserMedia interface and
  4800. Replace it with the new interface.
  4801. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  4802. (WebKit::WebUserMediaClientMock::requestUserMedia):
  4803. Remove the old requestUserMedia and replace it with the new.
  4804. * DumpRenderTree/chromium/WebUserMediaClientMock.h:
  4805. (WebUserMediaClientMock):
  4806. 2012-04-19 Christophe Dumez <christophe.dumez@intel.com>
  4807. [EFL] DRT console messages should contain only the file name part of local URIs
  4808. https://bugs.webkit.org/show_bug.cgi?id=84236
  4809. Reviewed by Kentaro Hara.
  4810. Process console messages before printing them in EFL's DumpRenderTree
  4811. them so that they contain only the file name part of local URIs. This
  4812. is what is expected by test cases.
  4813. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  4814. (urlSuitableForTestResult):
  4815. (onConsoleMessage):
  4816. 2012-04-19 Thiago Marcos P. Santos <thiago.santos@intel.com>
  4817. [EFL] [DRT] Should create offline storage inside DUMPRENDERTREE_TEMP
  4818. https://bugs.webkit.org/show_bug.cgi?id=84169
  4819. All databases were being created inside ~/.webkit which was causing
  4820. flaky tests when running multiple tests in parallel, specially timeouts
  4821. due to concurrency.
  4822. Reviewed by Eric Seidel.
  4823. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4824. (DumpRenderTreeChrome::initialize):
  4825. 2012-04-19 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  4826. [GTK] 3 fast/ layout tests failing after upgrading libsoup to 2.37.92
  4827. https://bugs.webkit.org/show_bug.cgi?id=82484
  4828. Reviewed by Martin Robinson.
  4829. Bumping libsoup to version 2.38.1 which fixes the above WebKit bug.
  4830. * efl/jhbuild.modules:
  4831. * gtk/jhbuild.modules:
  4832. 2012-04-19 Lucas Forschler <lforschler@apple.com>
  4833. Move apple-xserve-10 from Lion Test to SnowLeopard Debug Build
  4834. * BuildSlaveSupport/build.webkit.org-config/config.json:
  4835. 2012-04-19 Christophe Dumez <christophe.dumez@intel.com>
  4836. [EFL] dispatchDidCancelClientRedirect needs implementation
  4837. https://bugs.webkit.org/show_bug.cgi?id=83669
  4838. Reviewed by Antonio Gomes.
  4839. Catch the new ewk_frame "redirect,cancelled" signal in EFL's DRT and
  4840. and print out information that is expected by several test cases if
  4841. LayoutTestController's dumpFrameLoadCallback() returns true.
  4842. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  4843. (DumpRenderTreeChrome::createView):
  4844. (DumpRenderTreeChrome::onFrameCreated):
  4845. (DumpRenderTreeChrome::onFrameRedirectCancelled):
  4846. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  4847. (DumpRenderTreeChrome):
  4848. 2012-04-18 Hironori Bono <hbono@chromium.org>
  4849. Split SpellChecker::didCheck() to SpellChecker::didCheckSucceeded() and SpellChecker::didCheckCanceled()
  4850. https://bugs.webkit.org/show_bug.cgi?id=83748
  4851. Reviewed by Ryosuke Niwa.
  4852. This change replaces a call for SpellChecker::didCheck() with one for
  4853. SpellChecker::didCheckCenceled() because didCheck() has been split into
  4854. didCheckSucceeded() and didCheckCanceled().
  4855. * DumpRenderTree/chromium/WebViewHost.cpp:
  4856. (WebViewHost::requestCheckingOfText): Replaced didCheck with didCheckCanceled.
  4857. 2012-04-18 Dirk Pranke <dpranke@chromium.org>
  4858. Fix failure in test-webkitpy after r114583.
  4859. Unreviewed, build fix.
  4860. Updating the call site in r114583 w/o updating the test caused
  4861. the test to fail. Somehow I forgot to run the unit tests :(.
  4862. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  4863. (ChromiumDriverTest.test_crash_log):
  4864. 2012-04-18 Filip Pizlo <fpizlo@apple.com>
  4865. JSC testing should have complete coverage over typed array types
  4866. https://bugs.webkit.org/show_bug.cgi?id=84302
  4867. Reviewed by Geoff Garen.
  4868. Made run-fast-jsc print something and a newline if jsc threw an exception or
  4869. otherwise returned with an error code, but did not crash.
  4870. * Scripts/run-fast-jsc:
  4871. 2012-04-18 Dirk Pranke <dpranke@chromium.org>
  4872. Fix crash in chromium.py after r114877.
  4873. Unreviewed, build fix.
  4874. Missed updating one call site for get_crash_log() :(.
  4875. * Scripts/webkitpy/layout_tests/port/chromium.py:
  4876. (ChromiumDriver.run_test):
  4877. 2012-04-18 Philippe Normand <pnormand@igalia.com>
  4878. [GTK] NRWT bails out if more than one X server runs on the machine
  4879. https://bugs.webkit.org/show_bug.cgi?id=84276
  4880. Reviewed by Dirk Pranke.
  4881. Set up GTK driver's Xvfb display number based on Xorg servers
  4882. currently running.
  4883. * Scripts/webkitpy/layout_tests/port/gtk.py:
  4884. (GtkDriver._start):
  4885. (GtkDriver._start.x_filter):
  4886. 2012-04-18 Dirk Pranke <dpranke@chromium.org>
  4887. run-webkit-tests picked up an old crash log
  4888. https://bugs.webkit.org/show_bug.cgi?id=84196
  4889. Reviewed by Ryosuke Niwa.
  4890. Modify the crash log-finding code so that we can
  4891. limit our search to logs newer than X - this prevents
  4892. us from finding old crash logs for a given process/pid
  4893. combination even when the PIDs might've wrapped.
  4894. Also fix a bug in filesystem_mock where files_under() would
  4895. return paths that didn't exist.
  4896. * Scripts/webkitpy/common/system/crashlogs.py:
  4897. (CrashLogs.find_newest_log):
  4898. (CrashLogs._find_newest_log_darwin):
  4899. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  4900. (CrashLogsTest.test_find_log_darwin):
  4901. (CrashLogsTest.test_find_log_darwin.bad_read):
  4902. (CrashLogsTest):
  4903. * Scripts/webkitpy/common/system/filesystem_mock.py:
  4904. (MockFileSystem.files_under):
  4905. * Scripts/webkitpy/layout_tests/port/base.py:
  4906. (Port._get_crash_log):
  4907. * Scripts/webkitpy/layout_tests/port/gtk.py:
  4908. (GtkPort._get_crash_log):
  4909. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  4910. * Scripts/webkitpy/layout_tests/port/mac.py:
  4911. (MacPort._get_crash_log):
  4912. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  4913. (PortTestCase.test_get_crash_log):
  4914. * Scripts/webkitpy/layout_tests/port/webkit.py:
  4915. (WebKitDriver.run_test):
  4916. 2012-04-18 Dirk Pranke <dpranke@chromium.org>
  4917. nrwt: support additional test expectations files
  4918. https://bugs.webkit.org/show_bug.cgi?id=84222
  4919. Reviewed by Ojan Vafai.
  4920. This patch adds an --additional-expectations flag that can be
  4921. used to point to more files that will override the default set
  4922. of expectations. This will allow us to remove the
  4923. 'google_chrome' ports and eventually help to clean up override
  4924. handling in the chromium ports and unify expectations files and
  4925. Skipped files; this can also be used to specify overrides for
  4926. tests that run differently on a given machine.
  4927. * Scripts/webkitpy/layout_tests/port/base.py:
  4928. (Port.test_expectations_overrides):
  4929. * Scripts/webkitpy/layout_tests/port/chromium.py:
  4930. (ChromiumPort.test_expectations_overrides):
  4931. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  4932. (parse_args):
  4933. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  4934. (MainTest.test_additional_expectations):
  4935. 2012-04-18 Jer Noble <jer.noble@apple.com>
  4936. Lion Production Test failing with error: "Failed to stop httpd: pid file still exists"
  4937. https://bugs.webkit.org/show_bug.cgi?id=84177
  4938. Reviewed by Dirk Pranke.
  4939. Try to delete the pid file left by Apache in the case it was killed forcefully.
  4940. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  4941. (LayoutTestApacheHttpd._stop_running_server):
  4942. 2012-04-18 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  4943. Clean-up WheelEvent Conversion.
  4944. https://bugs.webkit.org/show_bug.cgi?id=84243
  4945. Reviewed by Simon Hausmann.
  4946. Calculate proper wheel-delta from pixel-delta given.
  4947. * DumpRenderTree/qt/EventSenderQt.cpp:
  4948. (EventSender::EventSender):
  4949. (EventSender::mouseScrollBy):
  4950. (EventSender::continuousMouseScrollBy):
  4951. 2012-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
  4952. Unreviewed, rolling out r114506.
  4953. http://trac.webkit.org/changeset/114506
  4954. https://bugs.webkit.org/show_bug.cgi?id=84254
  4955. Seems to be making gtk's DumpRenderTree crash occasionally
  4956. (Requested by tomz on #webkit).
  4957. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  4958. (resetDefaultsToConsistentValues):
  4959. 2012-04-18 Thiago Marcos P. Santos <thiago.santos@intel.com>
  4960. [CMake] Use jsc target instead of ONLY_BUILD_JAVASCRIPTCORE
  4961. https://bugs.webkit.org/show_bug.cgi?id=84229
  4962. CMake caches ONLY_BUILD_JAVASCRIPTCORE=1 and will reuse the setting for
  4963. subsequent builds, stopping WebCore from being built ever again.
  4964. Instead of trying to emulate a build target using command line options,
  4965. just build the existing jsc target directly.
  4966. Reviewed by Rob Buis.
  4967. * Scripts/build-jsc:
  4968. 2012-04-18 Simon Pena <spena@igalia.com>
  4969. [GTK] r114021 triggered media flakyness
  4970. https://bugs.webkit.org/show_bug.cgi?id=83874
  4971. Reviewed by Philippe Normand.
  4972. Now that there is gtk API to update the
  4973. MediaPlaybackRequiresUserGesture property, set it to false from the
  4974. DumpRenderTree tool when resetting defaults to consistent values.
  4975. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  4976. (resetDefaultsToConsistentValues):
  4977. 2012-04-18 Vivek Galatage <vivekgalatage@gmail.com>
  4978. Web Inspector: Disabling Inspector causes build failure on Windows
  4979. https://bugs.webkit.org/show_bug.cgi?id=83557
  4980. Reviewed by Pavel Feldman.
  4981. The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
  4982. This change brings all such API calls under the guard.
  4983. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  4984. (WTR::LayoutTestController::showWebInspector):
  4985. (WTR::LayoutTestController::closeWebInspector):
  4986. (WTR::LayoutTestController::evaluateInWebInspector):
  4987. (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
  4988. * WebKitTestRunner/TestInvocation.cpp:
  4989. (WTR::TestInvocation::invoke):
  4990. 2012-04-18 Mario Sanchez Prada <msanchez@igalia.com>
  4991. [GTK] atk/textChangedNotifications API test fails
  4992. https://bugs.webkit.org/show_bug.cgi?id=84010
  4993. Unreviewed, unskipping test after bug being fixed by r114311.
  4994. * Scripts/run-gtk-tests:
  4995. (TestRunner): Unskip now passing test.
  4996. 2012-04-17 Jacky Jiang <zhajiang@rim.com>
  4997. [BlackBerry] Viewport metatag doesn't disable double-tap zoom
  4998. https://bugs.webkit.org/show_bug.cgi?id=84199
  4999. Reviewed by George Staikos.
  5000. Revert a part of the change master_32/SHA:fa0f8ee9 and use
  5001. WebPage::setUserScalable instead.
  5002. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  5003. (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
  5004. 2012-04-17 Dirk Pranke <dpranke@chromium.org>
  5005. build-webkit: make ninja work with chromium linux
  5006. https://bugs.webkit.org/show_bug.cgi?id=84213
  5007. Reviewed by Eric Seidel.
  5008. Fix typos so that build-webkit will use ninja to
  5009. build chromium if a build.ninja file exists and is up-to-date.
  5010. * Scripts/webkitdirs.pm:
  5011. (determineIsChromiumNinja):
  5012. 2012-04-17 Ojan Vafai <ojan@chromium.org>
  5013. Add caching to the flakiness dashboard json files
  5014. https://bugs.webkit.org/show_bug.cgi?id=84198
  5015. Reviewed by Dirk Pranke.
  5016. * TestResultServer/handlers/testfilehandler.py:
  5017. (GetFile._get_file_list):
  5018. (GetFile._get_file_content):
  5019. (GetFile._get_file_content_from_key):
  5020. (GetFile._get_test_list_json):
  5021. (GetFile._serve_json):
  5022. Add a Last-Modified header and handle If-Modified-Since headers.
  5023. (GetFile.get):
  5024. 2012-04-17 Anders Carlsson <andersca@apple.com>
  5025. Need a client callback for when the user tries to interact with an already unresponsive page
  5026. https://bugs.webkit.org/show_bug.cgi?id=84201
  5027. <rdar://problem/11140862>
  5028. Reviewed by Andreas Kling.
  5029. Add new client functions.
  5030. * MiniBrowser/mac/BrowserWindowController.m:
  5031. (-[BrowserWindowController awakeFromNib]):
  5032. * WebKitTestRunner/TestController.cpp:
  5033. (WTR::TestController::initialize):
  5034. 2012-04-17 Dirk Pranke <dpranke@chromium.org>
  5035. nrwt: handle stopping layout test helper after a ctrl-c cleanly on the chromium port
  5036. https://bugs.webkit.org/show_bug.cgi?id=84190
  5037. Reviewed by Ojan Vafai.
  5038. LayoutTestHelper would exit when the user typed ctrl-c, but we
  5039. would attempt to write to it to shut it down, generating an
  5040. IOError.
  5041. * Scripts/webkitpy/layout_tests/port/chromium.py:
  5042. (ChromiumPort.stop_helper):
  5043. 2012-04-17 Dirk Pranke <dpranke@chromium.org>
  5044. rename --experimental-fully-parallel
  5045. https://bugs.webkit.org/show_bug.cgi?id=84188
  5046. Reviewed by Ojan Vafai.
  5047. I thought this was done long ago; rename
  5048. --experimental-fully-parallel to just --fully-parallel and
  5049. remove the --no- switch that AFAIK no one uses.
  5050. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  5051. (Manager._run_tests):
  5052. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  5053. (parse_args):
  5054. 2012-04-17 Christophe Dumez <christophe.dumez@intel.com>
  5055. EFL's LayoutTestController does not implement callShouldCloseOnWebView
  5056. https://bugs.webkit.org/show_bug.cgi?id=82301
  5057. Reviewed by Martin Robinson.
  5058. Implement callShouldCloseOnWebView in EFL's LayoutTestController by
  5059. calling shouldClose() on the FrameLoader, allowing the related test
  5060. to be removed from the skip list.
  5061. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  5062. (LayoutTestController::callShouldCloseOnWebView):
  5063. 2012-04-17 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  5064. [EFL] Add setting API to enable/disable XSSAuditor
  5065. https://bugs.webkit.org/show_bug.cgi?id=83281
  5066. Add missing implementation setXSSAuditorEnabled to EFL's LayoutTestController
  5067. in order to unskip tests in http/tests/security/xssAuditor. Also, catch the signal
  5068. 'xss,detected' in DRT to enable a test, which is expecting a line containing
  5069. 'didDetectXSS' in the output when reflected XSS is encountered in the page.
  5070. Reviewed by Antonio Gomes.
  5071. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  5072. (DumpRenderTreeChrome::createView):
  5073. (DumpRenderTreeChrome::onFrameCreated):
  5074. (DumpRenderTreeChrome::onDidDetectXSS):
  5075. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  5076. (DumpRenderTreeChrome):
  5077. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  5078. (LayoutTestController::setXSSAuditorEnabled):
  5079. 2012-04-17 Nandor Huszka <hnandor@inf.u-szeged.hu>
  5080. [Qt] JSC build should handle --no-webkit2 option to avoid unwanted clean-builds
  5081. https://bugs.webkit.org/show_bug.cgi?id=77533
  5082. Reviewed by Simon Hausmann.
  5083. Pick up the --no-webkit2 option from BUILD_WEBKIT_ARGS and pass on
  5084. the corresponding parameter to the buildQMakeProjects function.
  5085. * Scripts/build-jsc:
  5086. 2012-04-17 Christophe Dumez <christophe.dumez@intel.com>
  5087. [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
  5088. https://bugs.webkit.org/show_bug.cgi?id=83030
  5089. Reviewed by Antonio Gomes.
  5090. Implement support for LayoutTestController's dumpFrameLoadCallbacks()
  5091. in EFL's DumpRenderTree. Make use of the new frame argument passed to
  5092. the "load,started" and "load,finished" signals.
  5093. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  5094. (DumpRenderTreeChrome::createView):
  5095. (DumpRenderTreeChrome::onLoadStarted):
  5096. (DumpRenderTreeChrome::processWork):
  5097. (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
  5098. (DumpRenderTreeChrome::onWebViewOnloadEvent):
  5099. (DumpRenderTreeChrome::onInsecureContentRun):
  5100. (DumpRenderTreeChrome::onInsecureContentDisplayed):
  5101. (DumpRenderTreeChrome::onFrameCreated):
  5102. (DumpRenderTreeChrome::onFrameProvisionalLoad):
  5103. (DumpRenderTreeChrome::onFrameLoadCommitted):
  5104. (DumpRenderTreeChrome::onFrameLoadFinished):
  5105. (DumpRenderTreeChrome::onFrameLoadError):
  5106. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  5107. (DumpRenderTreeChrome):
  5108. 2012-04-17 Sheriff Bot <webkit.review.bot@gmail.com>
  5109. Unreviewed, rolling out r114376.
  5110. http://trac.webkit.org/changeset/114376
  5111. https://bugs.webkit.org/show_bug.cgi?id=84155
  5112. Wrong patch version committed, asked by the patch author.
  5113. (Requested by rakuco on #webkit).
  5114. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  5115. (DumpRenderTreeChrome::createView):
  5116. (DumpRenderTreeChrome::processWork):
  5117. (DumpRenderTreeChrome::onLoadFinished):
  5118. (DumpRenderTreeChrome::onWillSendRequest):
  5119. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  5120. (DumpRenderTreeChrome):
  5121. 2012-04-17 Christophe Dumez <christophe.dumez@intel.com>
  5122. [EFL] DRT should support LayoutTestController's dumpFrameLoadCallbacks()
  5123. https://bugs.webkit.org/show_bug.cgi?id=83030
  5124. Reviewed by Antonio Gomes.
  5125. Implement support for LayoutTestController's dumpFrameLoadCallbacks()
  5126. in EFL's DumpRenderTree.
  5127. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  5128. (DumpRenderTreeChrome::createView):
  5129. (DumpRenderTreeChrome::processWork):
  5130. (DumpRenderTreeChrome::topLoadingFrameLoadFinished):
  5131. (DumpRenderTreeChrome::onWebViewOnloadEvent):
  5132. (DumpRenderTreeChrome::onInsecureContentRun):
  5133. (DumpRenderTreeChrome::onInsecureContentDisplayed):
  5134. (DumpRenderTreeChrome::onFrameCreated):
  5135. (DumpRenderTreeChrome::onFrameProvisionalLoad):
  5136. (DumpRenderTreeChrome::onFrameLoadCommitted):
  5137. (DumpRenderTreeChrome::onFrameLoadFinished):
  5138. (DumpRenderTreeChrome::onFrameLoadError):
  5139. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  5140. (DumpRenderTreeChrome):
  5141. 2012-04-17 Michael Brüning <michael.bruning@nokia.com>
  5142. [Qt] Fix builds with force_static_libs_as_shared for non-linux builds.
  5143. https://bugs.webkit.org/show_bug.cgi?id=83035
  5144. Reviewed by Simon Hausmann.
  5145. The force_static_libs_as_shared feature for the Qt port will remove
  5146. hide_symbols from Qt's CONFIG in order to make them visible to other
  5147. libraries again.
  5148. Due to an evaluation order problem in qmake, the flags for the C++ compiler
  5149. that are set by adding hide_symbols to the CONFIG variables get applied
  5150. to qmake's C++ compiler flags directly and hence trying to remove these
  5151. later will not work and cause build failures when using the force_static_libs_as_shared
  5152. feature of the Qt port.
  5153. This is fixed by removing the flags that hide the exports from the compiler flags directly.
  5154. * qmake/mkspecs/features/force_static_libs_as_shared.prf:
  5155. 2012-04-16 Ryosuke Niwa <rniwa@webkit.org>
  5156. Remove CreateWebKitBuildDirectory step to fix Chromium Windows Perf bot
  5157. https://bugs.webkit.org/show_bug.cgi?id=84068
  5158. Reviewed by Eric Seidel.
  5159. Remove CreateWebKitBuildDirectory from master.cfg since download-built-product
  5160. automatically creates the build directory if needed.
  5161. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  5162. (DownloadAndPerfTestFactory.__init__):
  5163. (DownloadAndPerfTestWebKit2Factory.__init__):
  5164. 2012-04-16 Gustavo Noronha Silva <gns@gnome.org>
  5165. [GTK] Use configure instead of autogen.sh for gtk+
  5166. https://bugs.webkit.org/show_bug.cgi?id=84112
  5167. Rubber-stamped by Martin Robinson.
  5168. * gtk/jhbuild.modules: GTK+'s autogen requires gobject-introspection;
  5169. we don't want to depend on that for now, so run configure instead - we
  5170. can, since we are using a tarball
  5171. 2012-04-16 Gustavo Noronha Silva <gns@gnome.org>
  5172. Unreviewed, rolling out r114322.
  5173. http://trac.webkit.org/changeset/114322
  5174. https://bugs.webkit.org/show_bug.cgi?id=84096
  5175. Didn't make the debug bot happy, so back out
  5176. * gtk/jhbuild.modules:
  5177. 2012-04-16 Gustavo Noronha Silva <gns@gnome.org>
  5178. [GTK] Try to fix debug bot by adding gobject-introspection to the build
  5179. https://bugs.webkit.org/show_bug.cgi?id=84096
  5180. Unreviewed speculative build fix.
  5181. * gtk/jhbuild.modules: Added gobject-introspection, since modules need
  5182. an up-to-date introspection m4 for running autogen.
  5183. 2012-04-16 Gustavo Noronha Silva <gns@gnome.org>
  5184. [GTK] Add pango to jhbuild
  5185. https://bugs.webkit.org/show_bug.cgi?id=84086
  5186. Unreviewed build fix.
  5187. * gtk/jhbuild.modules: Add pango's latest stable release, 1.30, to our
  5188. jhbuild environment. It's required for latest stable GTK+ and some
  5189. systems may lack it.
  5190. 2012-04-16 Gustavo Noronha Silva <gns@gnome.org>
  5191. [GTK] fonts jhbuild module needs an empty clean target
  5192. https://bugs.webkit.org/show_bug.cgi?id=84085
  5193. Rubber-stamped by Martin Robinson.
  5194. * gtk/jhbuild.modules: update to webkitgtk-test-fonts 0.0.2, which
  5195. includes a phony clean target that should make warnings and errors go
  5196. away.
  5197. 2012-04-16 Gustavo Noronha Silva <gns@gnome.org>
  5198. [GTK] Bump dependency on GTK+ 3.x to match reality
  5199. https://bugs.webkit.org/show_bug.cgi?id=84060
  5200. Rubber-stamped by Martin Robinson.
  5201. * gtk/jhbuild.modules: Bump GTK+ to 3.4.0, plus glib and gdk-pixbuf
  5202. to their GNOME 3.4 versions.
  5203. * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Removed. This patch
  5204. is applied upstream.
  5205. 2012-04-16 Vincent Scheib <scheib@chromium.org>
  5206. Adding Contributors Brian Salomon and Tom Hudson to committers.py.
  5207. Unreviewed.
  5208. * Scripts/webkitpy/common/config/committers.py:
  5209. 2012-04-16 Jonathan Dong <jonathan.dong@torchmobile.com.cn>
  5210. [BlackBerry] Add ability for DRT to handle HTTP authentication challenges.
  5211. https://bugs.webkit.org/show_bug.cgi?id=84031
  5212. Reviewed by Rob Buis.
  5213. Implemented interface function didReceiveAuthenticationChallenge in class
  5214. DumpRenderTree.
  5215. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  5216. (drtCredentialDescription):
  5217. (BlackBerry::WebKit::DumpRenderTree::didReceiveAuthenticationChallenge):
  5218. (WebKit):
  5219. * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
  5220. (WebCore):
  5221. (DumpRenderTree):
  5222. 2012-04-16 Philippe Normand <pnormand@igalia.com>
  5223. build-webkit --gtk --no-webkit2 builds WK2
  5224. https://bugs.webkit.org/show_bug.cgi?id=83977
  5225. Reviewed by Martin Robinson.
  5226. * Scripts/build-webkit: Fixup ./configure option to disable
  5227. WebKit2 build.
  5228. 2012-04-16 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  5229. [EFL] [DRT] Feeding key events with invalid keyName
  5230. https://bugs.webkit.org/show_bug.cgi?id=83797
  5231. Keep the keyName valid within scope of KeyEventInfo to avoid
  5232. feeding key events with invalid keyName.
  5233. Reviewed by Philippe Normand.
  5234. * DumpRenderTree/efl/EventSender.cpp:
  5235. (KeyEventInfo::KeyEventInfo):
  5236. (KeyEventInfo):
  5237. (keyPadNameFromJSValue):
  5238. (keyNameFromJSValue):
  5239. (createKeyEventInfo):
  5240. (sendKeyDown):
  5241. 2012-04-16 Andras Piroska <pandras@inf.u-szeged.hu>
  5242. [Qt] Replace QtXmlPatterns usage with libxslt dependency
  5243. <https://bugs.webkit.org/show_bug.cgi?id=76820>
  5244. Reviewed by Simon Hausmann.
  5245. The features.prf file was modified, in order to use libxml and libxslt by default.
  5246. This modification only work at Qt5.
  5247. * qmake/config.tests/libxml2/libxml2.cpp: Added.
  5248. (main):
  5249. * qmake/config.tests/libxml2/libxml2.pro: Added.
  5250. * qmake/config.tests/libxslt/libxslt.cpp: Added.
  5251. (main):
  5252. * qmake/config.tests/libxslt/libxslt.pro: Added.
  5253. * qmake/mkspecs/features/features.prf:
  5254. * qmake/sync.profile:
  5255. 2012-04-16 Seokju Kwon <seokju.kwon@samsung.com>
  5256. [EFL] EWebLaucher : Fix wrong parameter order in function call for multiple windows.
  5257. https://bugs.webkit.org/show_bug.cgi?id=83862
  5258. Reviewed by Kenneth Rohde Christiansen.
  5259. EWebLauncher creates multiple windows, like multiple tabs when pressing F9 key.
  5260. It doesn't work properly because of wrong parameter order in function call.
  5261. * EWebLauncher/main.c:
  5262. 2012-04-16 Philippe Normand <pnormand@igalia.com>
  5263. Unreviewed, GTK gardening.
  5264. * Scripts/run-gtk-tests:
  5265. (TestRunner): Skip /webkit/atk/textChangedNotifications.
  5266. 2012-04-13 Ryosuke Niwa <rniwa@webkit.org>
  5267. Chromium perf bots should not build
  5268. https://bugs.webkit.org/show_bug.cgi?id=83641
  5269. Reviewed by Eric Seidel.
  5270. Don't build on perf bots to improve the cycle time.
  5271. * BuildSlaveSupport/build.webkit.org-config/config.json:
  5272. 2012-04-14 Zalan Bujtas <zbujtas@gmail.com>
  5273. [WK2] Set WebKitTestRunner's WebProcess cache model to DocumentBrowser.
  5274. https://bugs.webkit.org/show_bug.cgi?id=81945
  5275. Reviewed by Dan Bernstein.
  5276. WebProcess's default cache model is DocumentViewer. When DocumentViewer model is on,
  5277. the PageCache's capacity is set to 0. Tests that are enabling 'WebKitUsesPageCachePreferenceKey' expect
  5278. PageCache to be functional.
  5279. * WebKitTestRunner/TestController.cpp:
  5280. (WTR::TestController::resetStateToConsistentValues):
  5281. 2012-04-11 James Robinson <jamesr@chromium.org>
  5282. [chromium] Remove unused compositeToTexture / compositeOffscreen setting
  5283. https://bugs.webkit.org/show_bug.cgi?id=83733
  5284. Reviewed by Adrienne Walker.
  5285. Remove compositeOffscreen / compositeToTexture setting. This was an experiment that is no longer needed.
  5286. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  5287. (main):
  5288. * DumpRenderTree/chromium/TestShell.cpp:
  5289. (TestShell::TestShell):
  5290. (TestShell::resetWebSettings):
  5291. * DumpRenderTree/chromium/TestShell.h:
  5292. (TestShell):
  5293. * DumpRenderTree/chromium/WebPreferences.cpp:
  5294. (WebPreferences::reset):
  5295. (WebPreferences::applyTo):
  5296. * DumpRenderTree/chromium/WebPreferences.h:
  5297. (WebPreferences):
  5298. 2012-04-13 Ryosuke Niwa <rniwa@webkit.org>
  5299. webkitpy build fix. Revert the debug change (number of runs was 2 instead of 20),
  5300. and also rebaseline the test results since we ignore the first run now.
  5301. * Scripts/webkitpy/performance_tests/perftest.py:
  5302. (PageLoadingPerfTest.run):
  5303. * Scripts/webkitpy/performance_tests/perftest_unittest.py:
  5304. (TestPageLoadingPerfTest.test_run):
  5305. 2012-04-12 Ryosuke Niwa <rniwa@webkit.org>
  5306. Enable SVG page loading performance tests
  5307. https://bugs.webkit.org/show_bug.cgi?id=83861
  5308. Reviewed by Adam Barth.
  5309. Add support for page loading tests. These are tests without any test running harnesses, and we use
  5310. DriverOutput's test_timeout to measure the loading time.
  5311. Extracted PerfTest.run and PerfTest.run_failed from PerfTestRunner._run_single_test.
  5312. * Scripts/webkitpy/performance_tests/perftest.py:
  5313. (PerfTest.run):
  5314. (PerfTest):
  5315. (PerfTest.run_failed):
  5316. (PerfTest.parse_output):
  5317. (PerfTest.output_statistics):
  5318. (ChromiumStylePerfTest.parse_output):
  5319. (PageLoadingPerfTest): Added.
  5320. (PageLoadingPerfTest.__init__):
  5321. (PageLoadingPerfTest.run): Run the driver 20 times to get the statistics for the loading time.
  5322. * Scripts/webkitpy/performance_tests/perftest_unittest.py: Added.
  5323. (MockPrinter):
  5324. (MockPrinter.__init__):
  5325. (MockPrinter.write):
  5326. (MainTest):
  5327. (MainTest.test_parse_output):
  5328. (MainTest.test_parse_output_with_failing_line):
  5329. (TestPageLoadingPerfTest):
  5330. (TestPageLoadingPerfTest.assertWritten):
  5331. (TestPageLoadingPerfTest.MockDriver):
  5332. (TestPageLoadingPerfTest.MockDriver.__init__):
  5333. (TestPageLoadingPerfTest.MockDriver.run_test):
  5334. (TestPageLoadingPerfTest.test_run):
  5335. (TestPageLoadingPerfTest.test_run_with_bad_output):
  5336. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  5337. (PerfTestsRunner):
  5338. (PerfTestsRunner._collect_tests._is_test_file): Now recognizes svg tests.
  5339. (PerfTestsRunner._collect_tests):
  5340. (PerfTestsRunner._run_tests_set):
  5341. (PerfTestsRunner._run_single_test):
  5342. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  5343. (test_collect_tests_with_page_load_svg):
  5344. (test_collect_tests_with_page_load_svg.add_file):
  5345. 2012-04-10 Brady Eidson <beidson@apple.com>
  5346. <rdar://problem/11176921> and https://bugs.webkit.org/show_bug.cgi?id=83600
  5347. Need WebKit2 API to notify whether history loads are in the page cache
  5348. Add a test ShouldGoToBackForwardListItem that exercises the new BundlePageLoaderClient
  5349. callback as well as the new WKBundleBackForwardListItemIsInPageCache() API.
  5350. Reviewed by Darin Adler.
  5351. * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp: Added.
  5352. (TestWebKitAPI::didFinishLoadForFrame):
  5353. (TestWebKitAPI::willGoToBackForwardListItem):
  5354. (TestWebKitAPI::setPageLoaderClient):
  5355. (TestWebKitAPI::TEST):
  5356. * TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem_Bundle.cpp: Added.
  5357. (ShouldGoToBackForwardListItemTest):
  5358. (TestWebKitAPI::shouldGoToBackForwardListItemCallback):
  5359. (TestWebKitAPI::ShouldGoToBackForwardListItemTest::ShouldGoToBackForwardListItemTest):
  5360. (TestWebKitAPI::ShouldGoToBackForwardListItemTest::didCreatePage):
  5361. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  5362. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  5363. (WTR::InjectedBundlePage::InjectedBundlePage): Update for the new client.
  5364. 2012-04-13 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  5365. Group EFL bots into a category on the buildbot master
  5366. https://bugs.webkit.org/show_bug.cgi?id=82712
  5367. Reviewed by Adam Roben.
  5368. Creating a new category definition on the buildbot frontend.
  5369. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  5370. (loadBuilderConfig): Determine category for EFL bots
  5371. * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Add links to EFL category
  5372. 2012-04-13 Sheriff Bot <webkit.review.bot@gmail.com>
  5373. Unreviewed, rolling out r113714.
  5374. http://trac.webkit.org/changeset/113714
  5375. https://bugs.webkit.org/show_bug.cgi?id=83887
  5376. It is behaving strange on the bots and needs more
  5377. investigation. (Requested by jeez_ on #webkit).
  5378. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  5379. (WTR::PlatformWebView::PlatformWebView):
  5380. 2012-04-11 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  5381. webkit-tools-completion: Support bugzilla email completion for webkit-patch upload --cc
  5382. https://bugs.webkit.org/show_bug.cgi?id=83690
  5383. Reviewed by Tor Arne Vestbø.
  5384. Typing part of an email and pressing <TAB> will bash-complete it using the list in
  5385. Tools/Scripts/webkitpy/common/config/committers.py
  5386. * Scripts/webkit-tools-completion.sh:
  5387. 2012-04-13 Thiago Marcos P. Santos <thiago.santos@intel.com>
  5388. [EFL] Add API for color chooser
  5389. https://bugs.webkit.org/show_bug.cgi?id=83692
  5390. Enables INPUT_TYPE_COLOR by default on the EFL port.
  5391. Reviewed by Kenneth Rohde Christiansen.
  5392. * Scripts/build-webkit:
  5393. 2012-04-12 Ryosuke Niwa <rniwa@webkit.org>
  5394. Extract PerfTest class from PerfTestRunner
  5395. https://bugs.webkit.org/show_bug.cgi?id=83847
  5396. Reviewed by Hajime Morita.
  5397. Extracted PerfTest and ChromiumStylePerfTest from PerfTestRunner. This class abstracts a test
  5398. that was previously represented by a tuple.
  5399. Also moved the logic to determine whether a given test is chromium style or not from run() to
  5400. _collect_tests(). And moved the output parsing algorithms for parser style and chromium style
  5401. tests from PerfTestRunner to PerfTest and ChromiumStylePerfTest respectively so that we may
  5402. add new types of tests more easily.
  5403. * Scripts/webkitpy/performance_tests/perftest.py: Added.
  5404. (PerfTest):
  5405. (PerfTest.__init__):
  5406. (PerfTest.test_name):
  5407. (PerfTest.dirname):
  5408. (PerfTest.path_or_url):
  5409. (PerfTest._should_ignore_line_in_parser_test_result):
  5410. (PerfTest.parse_output):
  5411. (ChromiumStylePerfTest):
  5412. (ChromiumStylePerfTest.__init__):
  5413. (ChromiumStylePerfTest.parse_output):
  5414. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  5415. (PerfTestsRunner._collect_tests):
  5416. (PerfTestsRunner.run):
  5417. (PerfTestsRunner._run_tests_set):
  5418. (PerfTestsRunner._run_single_test):
  5419. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  5420. (run_test):
  5421. (_tests_for_runner):
  5422. (test_run_test_set_with_json_output):
  5423. (test_run_test_set_with_json_source):
  5424. (test_run_test_set_with_multiple_repositories):
  5425. (_collect_tests_and_sort_test_name):
  5426. (test_collect_tests):
  5427. (test_collect_tests_with_skipped_list):
  5428. 2012-04-12 Balazs Kelemen <kbalazs@webkit.org>
  5429. [Qt] Fix WebKit1 build with V8
  5430. https://bugs.webkit.org/show_bug.cgi?id=83322
  5431. Reviewed by Adam Barth.
  5432. * DumpRenderTree/qt/DumpRenderTree.pro:
  5433. * qmake/mkspecs/features/default_post.prf:
  5434. * qmake/mkspecs/features/default_pre.prf:
  5435. * qmake/mkspecs/features/features.prf:
  5436. 2012-04-12 Dirk Pranke <dpranke@chromium.org>
  5437. test-webkitpy fails on metered_stream_unittest for non-US West Coast Time Zones
  5438. https://bugs.webkit.org/show_bug.cgi?id=83583
  5439. Reviewed by Philippe Normand
  5440. Updated the unit test to ignore the hours and minutes of the
  5441. localtime for time(0), since we can't easily guarantee which
  5442. timezone we're in or what timezone rules were in effect on
  5443. 1/1/1970; this should be mostly fine since we can trust that
  5444. time.localtime() will work, although there is the possibility
  5445. that we'll screw up the time formatting of which field is the
  5446. hours and which is the minutes.
  5447. * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  5448. (VerboseTest):
  5449. (VerboseTest.test_basic):
  5450. (VerboseTest.test_log_after_update):
  5451. 2012-04-12 Dominik Rottsches <dominik.rottsches@linux.intel.com>
  5452. Add an EFL Debug Buildbot to the master configuration
  5453. https://bugs.webkit.org/show_bug.cgi?id=82711
  5454. Forgot to add EFL Linux Debug to scheduler.
  5455. Reviewed by Philippe Normand.
  5456. * BuildSlaveSupport/build.webkit.org-config/config.json:
  5457. 2012-04-12 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  5458. Add an EFL Debug Buildbot to the master configuration
  5459. https://bugs.webkit.org/show_bug.cgi?id=82711
  5460. Reviewed by Philippe Normand.
  5461. Hooking up our EFL Linux 64bit debug configuration buildbot to the buildbot master.
  5462. * BuildSlaveSupport/build.webkit.org-config/config.json: EFL Debug builder added
  5463. 2012-04-12 George Staikos <staikos@webkit.org>
  5464. Enable the fullscreen API for BlackBerry.
  5465. https://bugs.webkit.org/show_bug.cgi?id=83757
  5466. Reviewed by Antonio Gomes.
  5467. * Scripts/build-webkit:
  5468. 2012-04-12 Simon Pena <spena@igalia.com>
  5469. [GTK] Test runner crashes without recent versions of pulseaudio-utils
  5470. https://bugs.webkit.org/show_bug.cgi?id=83774
  5471. Reviewed by Philippe Normand.
  5472. Besides checking that pactl is available, check also that its output
  5473. is the expected one, and handle gracefully when it isn't, when
  5474. trying to unload pulseaudio modules.
  5475. * Scripts/webkitpy/layout_tests/port/gtk.py:
  5476. (GtkPort._unload_pulseaudio_module):
  5477. (GtkPort._restore_pulseaudio_module):
  5478. 2012-03-05 Pierre Rossi <pierre.rossi@gmail.com>
  5479. [Qt] Use QRawFont when building with Qt 5
  5480. https://bugs.webkit.org/show_bug.cgi?id=78001
  5481. Flip the QRawFont switch for Qt 5.
  5482. Reviewed by Simon Hausmann.
  5483. * qmake/mkspecs/features/features.prf:
  5484. 2012-04-11 Vivek Galatage <vivekgalatage@gmail.com>
  5485. Web Inspector: Disabling Inspector causes build failure on Windows
  5486. https://bugs.webkit.org/show_bug.cgi?id=83557
  5487. Reviewed by Pavel Feldman.
  5488. The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
  5489. This change brings all such API calls under the guard.
  5490. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  5491. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  5492. (WTR):
  5493. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  5494. (LayoutTestController):
  5495. * WebKitTestRunner/TestInvocation.cpp:
  5496. (WTR::TestInvocation::invoke):
  5497. 2012-04-11 Dirk Pranke <dpranke@chromium.org>
  5498. Fix regression introduced in r113927.
  5499. Unreviewed, build fix.
  5500. I failed to rename skipped_tests() to skipped_layout_tests()
  5501. everywhere it needed to be renamed. The unit tests didn't catch
  5502. this because the TestPort was one of the places that didn't get
  5503. renamed :(.
  5504. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  5505. (Manager.parse_expectations):
  5506. * Scripts/webkitpy/layout_tests/port/test.py:
  5507. (TestPort.skipped_layout_tests):
  5508. * Scripts/webkitpy/tool/commands/queries.py:
  5509. (PrintExpectations._model):
  5510. 2012-04-11 Dirk Pranke <dpranke@chromium.org>
  5511. new-run-webkit-tests: 'webkit-patch skipped-ports' introduced bad layering
  5512. https://bugs.webkit.org/show_bug.cgi?id=47528
  5513. Reviewed by Adam Barth.
  5514. The skipped-ports command has been replaced by 'webkit-patch
  5515. print-expectations', which offers the equivalent functionality
  5516. via 'webkit-patch print-expectations --platform \* -t skip'
  5517. (and other features, of course).
  5518. This also allows me to fix a nasty layering violation where the
  5519. chromium port had to know about the TestExpectations objects in
  5520. order to implement the command properly.
  5521. Lastly, this allows me to rename skipped_tests() to
  5522. skipped_layout_tests() to more consistent with
  5523. skipped_perf_tests().
  5524. This patch removes skips_layout_test() from the Port interface,
  5525. because that can't be implemented without the port knowing about
  5526. Expectations objects (and skipped-ports was the only thing using it).
  5527. * Scripts/webkitpy/layout_tests/port/base.py:
  5528. (Port.skipped_layout_tests):
  5529. (Port.skipped_perf_tests):
  5530. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  5531. (PortTest.test_default_configuration_notfound):
  5532. * Scripts/webkitpy/layout_tests/port/chromium.py:
  5533. (ChromiumPort.test_expectations_overrides):
  5534. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  5535. (ChromiumPortTest.test_path_to_image_diff):
  5536. * Scripts/webkitpy/layout_tests/port/webkit.py:
  5537. (WebKitPort.skipped_layout_tests):
  5538. * Scripts/webkitpy/tool/commands/queries.py:
  5539. (execute):
  5540. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  5541. (QueryCommandsTest.test_tree_status):
  5542. 2012-04-11 Mark Rowe <mrowe@apple.com>
  5543. Remove a fprintf from LayoutTestController.
  5544. This fprintf is causing 100+MB of data to be written to stderr during a single run of the tests.
  5545. It was added for no apparent reason by Ryosuke in r113651.
  5546. * DumpRenderTree/LayoutTestController.cpp:
  5547. (LayoutTestController::redirectionDestinationForURL):
  5548. 2012-04-11 Nico Weber <thakis@chromium.org>
  5549. [mac] Suppress deprecation warning for GlobalToLocal in the carbon parts of the test plugin.
  5550. https://bugs.webkit.org/show_bug.cgi?id=83709
  5551. Reviewed by Anders Carlsson.
  5552. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  5553. (handleEventCarbon):
  5554. 2012-04-11 Rafael Brandao <rafael.lobo@openbossa.org>
  5555. Adding myself to committers.py
  5556. https://bugs.webkit.org/show_bug.cgi?id=83711
  5557. Unreviewed update to committers.py.
  5558. * Scripts/webkitpy/common/config/committers.py:
  5559. 2012-04-11 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  5560. [EFL] LayoutTestController needs implementation of pageProperty
  5561. https://bugs.webkit.org/show_bug.cgi?id=82449
  5562. Add missing implementation pageProperty to EFL's LayoutTestController
  5563. in order to unskip printing/page-rule-selection.html
  5564. Reviewed by Antonio Gomes.
  5565. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  5566. (LayoutTestController::pageProperty):
  5567. 2012-04-11 Sheriff Bot <webkit.review.bot@gmail.com>
  5568. Unreviewed, rolling out r113836.
  5569. http://trac.webkit.org/changeset/113836
  5570. https://bugs.webkit.org/show_bug.cgi?id=83705
  5571. Broke all the WebKit2 inspector tests (Requested by andersca
  5572. on #webkit).
  5573. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  5574. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  5575. (WTR::LayoutTestController::showWebInspector):
  5576. (WTR::LayoutTestController::closeWebInspector):
  5577. (WTR::LayoutTestController::evaluateInWebInspector):
  5578. (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
  5579. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  5580. (LayoutTestController):
  5581. * WebKitTestRunner/TestInvocation.cpp:
  5582. (WTR::TestInvocation::invoke):
  5583. 2012-04-11 Vivek Galatage <vivekgalatage@gmail.com>
  5584. Web Inspector: Disabling Inspector causes build failure on Windows
  5585. https://bugs.webkit.org/show_bug.cgi?id=83557
  5586. Reviewed by Pavel Feldman.
  5587. The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
  5588. This change brings all such API calls under the guard.
  5589. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  5590. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  5591. (WTR):
  5592. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  5593. (LayoutTestController):
  5594. * WebKitTestRunner/TestInvocation.cpp:
  5595. (WTR::TestInvocation::invoke):
  5596. 2012-04-11 No'am Rosenthal <noam.rosenthal@nokia.com>
  5597. [Qt][WK2] Manage graphics buffers in the web process
  5598. https://bugs.webkit.org/show_bug.cgi?id=78675
  5599. Make graphics surface available only for Qt 5, attempting to fix
  5600. the Qt-mac build.
  5601. Unreviewed build fix.
  5602. * qmake/mkspecs/features/features.prf:
  5603. 2012-04-11 Philippe Normand <pnormand@igalia.com>
  5604. Unreviewed, GTK NRWT follow-up fix after r113849.
  5605. * Scripts/webkitpy/layout_tests/port/gtk.py:
  5606. (GtkPort._unload_pulseaudio_module): Exit early if pactl is not found.
  5607. 2012-04-11 Simon Pena <spena@igalia.com>
  5608. [GTK] media/event-attributes.html fails
  5609. https://bugs.webkit.org/show_bug.cgi?id=71662
  5610. Reviewed by Philippe Normand.
  5611. PulseAudio's module "module-stream-restore" allows saving the volume
  5612. of a stream, restoring it the next time it runs.
  5613. This affects the tests, since DumpRenderTree's volume settings are
  5614. saved between test runs, and tests relying on specific volume values
  5615. would miss some volumeChange events (or get additional ones).
  5616. This patch hooks on the existing GtkPort setup_test_run method and
  5617. creates a new clean_up_test_run method, so PulseAudio's module is
  5618. unloaded (if found) before running the tests, and restored (if it
  5619. was there previously) after they finished, ensuring the tests run in
  5620. the right environment.
  5621. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  5622. (Manager._clean_up_run): Invoke the port implementation of
  5623. clean_up_test_run.
  5624. * Scripts/webkitpy/layout_tests/port/base.py:
  5625. (Port.clean_up_test_run): Add an empty implementation of
  5626. clean_up_test_run.
  5627. * Scripts/webkitpy/layout_tests/port/gtk.py:
  5628. (GtkPort._unload_pulseaudio_module): Unloads the offending
  5629. pulseaudio module, if found.
  5630. (GtkPort):
  5631. (GtkPort._restore_pulseaudio_module): Restores the offending
  5632. pulseaudio module, if it was there previously.
  5633. (GtkPort.setup_test_run): Calls _unload_pulseaudio_module.
  5634. (GtkPort.clean_up_test_run): Calls _restore_pulseaudio_module.
  5635. 2012-04-11 Andras Becsi <andras.becsi@nokia.com>
  5636. Fix the build with gcc 4.7.0
  5637. https://bugs.webkit.org/show_bug.cgi?id=83584
  5638. Reviewed by Alexey Proskuryakov.
  5639. * qmake/mkspecs/features/unix/default_post.prf:
  5640. The -fuse-ld=gold option is not supported with upstream gcc.
  5641. 2012-04-11 Ryosuke Niwa <rniwa@webkit.org>
  5642. Refactor PerfTestRunner to include file extensions in test names
  5643. https://bugs.webkit.org/show_bug.cgi?id=83677
  5644. Reviewed by Hajime Morita.
  5645. Move the logic that extracts the test name from _process_parser_test_result to _collect_tests.
  5646. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  5647. (PerfTestsRunner._collect_tests):
  5648. (PerfTestsRunner._run_tests_set):
  5649. (PerfTestsRunner._process_parser_test_result): Still replace "/" by ": " to keep the output format.
  5650. We can make the said behavior change by simply removing "test_name = re.sub(r'\.\w+$', '', test_name)" here.
  5651. (PerfTestsRunner._run_single_test):
  5652. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  5653. (run_test):
  5654. (_tests_for_runner):
  5655. (test_run_test_set):
  5656. (test_run_test_set_kills_drt_per_run):
  5657. (test_run_test_pause_before_testing):
  5658. (test_run_test_set_for_parser_tests):
  5659. (test_collect_tests):
  5660. (test_collect_tests_with_skipped_list):
  5661. 2012-04-11 Vivek Galatage <vivekgalatage@gmail.com>
  5662. Web Inspector: Disabling Inspector causes build failure on Windows
  5663. https://bugs.webkit.org/show_bug.cgi?id=83557
  5664. Reviewed by Pavel Feldman.
  5665. The calls to inspector APIs are not put under ENABLE(INSPECTOR) guard.
  5666. This change brings all such API calls under the guard.
  5667. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  5668. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  5669. (WTR):
  5670. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  5671. (LayoutTestController):
  5672. * WebKitTestRunner/TestInvocation.cpp:
  5673. (WTR::TestInvocation::invoke):
  5674. 2012-04-10 Kent Tamura <tkent@chromium.org>
  5675. Unreviewed. Using tkent+wkapi@ for ChromiumPublicApi notifications.
  5676. * Scripts/webkitpy/common/config/watchlist:
  5677. * Scripts/webkitpy/common/config/committers.py: Add tkent+wkapi@ to pass the style checker.
  5678. 2012-04-10 Dirk Pranke <dpranke@chromium.org>
  5679. If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
  5680. https://bugs.webkit.org/show_bug.cgi?id=82799
  5681. Reviewed by Ojan Vafai.
  5682. The tests we were skipping in _mark_interrupted_tests_as_skipped
  5683. had incorrectly-constructed TestResults, and so they were not
  5684. being treated as failures. The JSON generator doesn't record
  5685. tests that are passed or skiped in incremental_results, so you
  5686. couldn't tell these tests were being skipped at all.
  5687. This change changes _mark_interrupted_tests_as_skipped() to
  5688. treat the skipped tests as failures; this is arguably still
  5689. incorrect but is minimally invasive for now. We probably need to
  5690. revisit how we are uploading information about tests that are
  5691. skipped and passed altogether in a separate change.
  5692. This change also cleans up a couple of other nits that were
  5693. unnecessary or broken in this same code path.
  5694. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  5695. (Manager._mark_interrupted_tests_as_skipped):
  5696. (Manager._upload_json_files): Deletes the check for
  5697. chromium-mac-leopard (as it is no longer necessary).
  5698. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  5699. (JSONLayoutResultsGenerator.__init__): Here we were
  5700. recalculating the failure type unnecessarily.
  5701. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  5702. (determine_result_type):
  5703. (FailureEarlyExit): Adds a new failure type so we can tell what
  5704. happened.
  5705. (FailureEarlyExit.message):
  5706. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  5707. (MainTest.test_exit_after_n_failures_upload): Add more checks to
  5708. ensure that we are recording the SKIP correctly; this is less
  5709. than ideal, because we can't actually test the contents of
  5710. incremental_results.json. We should fix that at some point.
  5711. 2012-04-10 Dirk Pranke <dpranke@chromium.org>
  5712. make chromium layout tests not depend on platform/win, platform/mac-leopard, or platform/mac-snowleopard
  5713. https://bugs.webkit.org/show_bug.cgi?id=83401
  5714. Reviewed by Adam Barth.
  5715. Last patch in the series - no longer look in mac-leopard,
  5716. mac-snowleopard, or mac-lion.
  5717. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  5718. (ChromiumMacPort):
  5719. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  5720. 2012-04-10 Dirk Pranke <dpranke@chromium.org>
  5721. webkit-patch: add a print-expectations command
  5722. https://bugs.webkit.org/show_bug.cgi?id=83347
  5723. Reviewed by Adam Barth.
  5724. This command will print the expected results for a given set of
  5725. tests on a given set of ports matching a given set of keywords.
  5726. Example output (printing all the tests not expected to pass, and their
  5727. expected results, on a Mac):
  5728. $ webkit-patch print-expectations -x pass fast/html
  5729. // For mac-snowleopard
  5730. fast/html/details-open4.html = TEXT
  5731. fast/html/details-open2.html = TEXT
  5732. fast/html/details-no-summary4.html = TEXT
  5733. fast/html/details-open-javascript.html = TEXT
  5734. $
  5735. You can also print full test-expectatons.txt lines using --full and a
  5736. CSV-style report (which can be useful for post-processing) using --csv.
  5737. It will replace the 'skipped-files' command (which will be
  5738. removed in a subsequent patch) and is a more general (and
  5739. cleaner and properly layered) solution.
  5740. Also add an update() command to MockOptions() to make overriding keywords easier.
  5741. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  5742. (TestExpectationSerializer.to_string):
  5743. (TestExpectationSerializer):
  5744. (TestExpectationSerializer.to_csv):
  5745. (TestExpectationSerializer._format_result):
  5746. (TestExpectationLine.create_passing_expectation):
  5747. (TestExpectationsModel.get_test_set_for_keyword):
  5748. (TestExpectationsModel.has_keyword):
  5749. (TestExpectations.model):
  5750. * Scripts/webkitpy/tool/commands/queries.py:
  5751. (execute):
  5752. (PrintExpectations):
  5753. (PrintExpectations.__init__):
  5754. (PrintExpectations.execute):
  5755. (PrintExpectations._filter_tests):
  5756. (PrintExpectations._format_lines):
  5757. (PrintExpectations._model):
  5758. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  5759. (TestPrintExpectations): Added.
  5760. * Scripts/webkitpy/tool/mocktool.py:
  5761. (MockOptions):
  5762. (MockOptions.__init__):
  5763. (MockOptions.update): Added.
  5764. 2012-04-10 Dirk Pranke <dpranke@chromium.org>
  5765. webkitpy: refactor handling of --platform and related options
  5766. https://bugs.webkit.org/show_bug.cgi?id=83525
  5767. Reviewed by Adam Barth.
  5768. This change moves to centralize handling of --platform, --debug,
  5769. --gtk, and other similar flags into a central place next to the
  5770. code that actually uses those flags in PortFactory to get the
  5771. right Port object.
  5772. * Scripts/webkitpy/layout_tests/port/__init__.py:
  5773. * Scripts/webkitpy/layout_tests/port/factory.py:
  5774. (port_options):
  5775. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  5776. (parse_args):
  5777. * Scripts/webkitpy/tool/commands/queries.py:
  5778. (PrintBaselines.__init__):
  5779. 2012-04-10 Ojan Vafai <ojan@chromium.org>
  5780. Add a chromeless view to the individual tests view
  5781. https://bugs.webkit.org/show_bug.cgi?id=83541
  5782. Reviewed by Daniel Bates.
  5783. This is the view suitable to inlining in other contexts (e.g. garden-o-matic).
  5784. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  5785. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  5786. (testHtmlForIndividualTestOnAllBuilders):
  5787. (testHtmlForIndividualTestOnAllBuildersWithChromeNonexistant):
  5788. (testHtmlForIndividualTestOnAllBuildersWithChrome):
  5789. (testHtmlForIndividualTestOnAllBuildersWithChromeWebkitMaster):
  5790. (testHtmlForIndividualTests):
  5791. (htmlEscape):
  5792. (runTests):
  5793. 2012-04-10 Dirk Pranke <dpranke@chromium.org>
  5794. remove 'win' from chromium-win, chromium-linux fallback paths
  5795. https://bugs.webkit.org/show_bug.cgi?id=83613
  5796. Reviewed by Ojan Vafai.
  5797. The chromium ports no longer need to look at the apple 'win'
  5798. directory for baseline results.
  5799. Also remove the old '-gpu-' entries from the flakiness dashboard
  5800. map since I'm touching lines nearby.
  5801. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  5802. (ChromiumLinuxPort):
  5803. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  5804. (ChromiumWinPort):
  5805. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  5806. 2012-04-10 No'am Rosenthal <noam.rosenthal@nokia.com>
  5807. [Qt][WK2] Manage graphics buffers in the web process
  5808. https://bugs.webkit.org/show_bug.cgi?id=78675
  5809. Enable graphics surfaces on Mac for Qt.
  5810. Reviewed by Kenneth Rohde Christiansen.
  5811. * qmake/mkspecs/features/features.prf:
  5812. 2012-04-10 Patrick Gansterer <paroga@webkit.org>
  5813. [CMake] Enable USE_FOLDERS property
  5814. https://bugs.webkit.org/show_bug.cgi?id=83571
  5815. Reviewed by Daniel Bates.
  5816. Setting the FOLDER property on targets gives more structure
  5817. to the generated Visual Studio solutions.
  5818. This does not affect other CMake generators.
  5819. * DumpRenderTree/efl/CMakeLists.txt:
  5820. * EWebLauncher/CMakeLists.txt:
  5821. * WinCELauncher/CMakeLists.txt:
  5822. 2012-04-10 David Dorwin <ddorwin@chromium.org>
  5823. Add Encrypted Media Extensions methods to HTMLMediaElement
  5824. https://bugs.webkit.org/show_bug.cgi?id=82971
  5825. Reviewed by Adam Barth.
  5826. The extensions are behind the ENABLE(ENCRYPTED_MEDIA) feature define.
  5827. Implementation is based on v0.1 of the draft proposal at
  5828. http://dvcs.w3.org/hg/html-media/raw-file/tip/encrypted-media/encrypted-media.html.
  5829. * DumpRenderTree/chromium/TestShell.cpp:
  5830. (TestShell::TestShell):
  5831. 2012-04-10 Christophe Dumez <christophe.dumez@intel.com>
  5832. [EFL][DRT] Catch the "title,changed" signal
  5833. https://bugs.webkit.org/show_bug.cgi?id=82174
  5834. Reviewed by Gustavo Noronha Silva.
  5835. EFL's DumpRenderTree now catches the "title,changed" signal, and
  5836. prints out the needed information.
  5837. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  5838. (DumpRenderTreeChrome::onTitleChanged):
  5839. 2012-04-10 Christophe Dumez <christophe.dumez@intel.com>
  5840. [EFL] DRT should support LayoutTestController's willSendRequestReturnsNull()
  5841. https://bugs.webkit.org/show_bug.cgi?id=82443
  5842. Reviewed by Philippe Normand.
  5843. EFL's DRT needs to support LayoutTestController's
  5844. willSendRequestReturnsNull() and return NULL when expected. This
  5845. allows for several tests to be removed from the skip list.
  5846. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  5847. (DumpRenderTreeChrome::onWillSendRequest):
  5848. 2012-04-10 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  5849. [EFL] LayoutTestController needs implementation of addUserStyleSheet
  5850. https://bugs.webkit.org/show_bug.cgi?id=82446
  5851. Adding missing implementation addUserStyleSheet to EFL's LayoutTestController
  5852. so that we can unskip related tests from the skip list.
  5853. Reviewed by Antonio Gomes.
  5854. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  5855. (LayoutTestController::addUserStyleSheet): Implemented.
  5856. 2012-04-10 Philip Rogers <pdr@google.com>
  5857. Adding myself to committers.py!
  5858. Unreviewed update to committers.py.
  5859. * Scripts/webkitpy/common/config/committers.py:
  5860. 2012-04-10 Dinu Jacob <dinu.jacob@nokia.com>
  5861. [Qt][WK2] Title in MiniBrowser is not updated for a page with no title
  5862. https://bugs.webkit.org/show_bug.cgi?id=82483
  5863. Reviewed by Kenneth Rohde Christiansen.
  5864. Set window title to default if there is no page title.
  5865. * MiniBrowser/qt/BrowserWindow.cpp:
  5866. (BrowserWindow::BrowserWindow):
  5867. (BrowserWindow::onTitleChanged):
  5868. * MiniBrowser/qt/BrowserWindow.h:
  5869. (BrowserWindow):
  5870. 2012-03-23 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  5871. [Qt][WK2] Implement PageClient::isViewWindowActive()
  5872. https://bugs.webkit.org/show_bug.cgi?id=81143
  5873. Reviewed by Kenneth Rohde Christiansen.
  5874. Fix the WrapperWindow from our PlatformWebView
  5875. so it correctly creates the platform related
  5876. stuff for QWindow, which is not created unless
  5877. QWindow::setVisible() or QWindow::show() are called.
  5878. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  5879. (WTR::PlatformWebView::PlatformWebView):
  5880. 2012-04-10 Balazs Kelemen <kbalazs@webkit.org>
  5881. [Qt][WK2] TestNetscapePlugin is broken
  5882. https://bugs.webkit.org/show_bug.cgi?id=83024
  5883. Reviewed by Csaba Osztrogonác.
  5884. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  5885. Fix X11 availability check. embedded is always true with QPA.
  5886. * Tools.pro:
  5887. Build the test plugin if plugins are enabled for WebKit2.
  5888. * qmake/mkspecs/features/features.prf:
  5889. * qmake/mkspecs/features/functions.prf:
  5890. Added a convenience function to determine availability
  5891. of X11 libraries.
  5892. 2012-04-10 Patrick Gansterer <paroga@webkit.org>
  5893. [WIN] Fix build without precompiled header.
  5894. * DumpRenderTree/cg/ImageDiffCG.cpp: Define max as max as we do for min.
  5895. 2012-04-10 Arko Saha <arko@motorola.com>
  5896. Unreviewed: adding myself to committers.py.
  5897. * Scripts/webkitpy/common/config/committers.py:
  5898. 2012-04-09 Kaustubh Atrawalkar <kaustubh@motorola.com>
  5899. Unreviewed: adding myself to committers.py.
  5900. * Scripts/webkitpy/common/config/committers.py:
  5901. 2012-04-09 Sheriff Bot <webkit.review.bot@gmail.com>
  5902. Unreviewed, rolling out r113656.
  5903. http://trac.webkit.org/changeset/113656
  5904. https://bugs.webkit.org/show_bug.cgi?id=83542
  5905. test is broken on chromium-win (Requested by simonjam on
  5906. #webkit).
  5907. * DumpRenderTree/chromium/WebViewHost.cpp:
  5908. (WebViewHost::dispatchIntent):
  5909. 2012-04-09 Takashi Toyoshima <toyoshim@chromium.org>
  5910. Update pywebsocket to 0.7.4.
  5911. https://bugs.webkit.org/show_bug.cgi?id=83461
  5912. Reviewed by Kent Tamura.
  5913. This version supports TLS by using ssl in addition to pyOpenSSL.
  5914. Other functional difrerences from 0.7.2 are:
  5915. - strict Sec-WebSocket-Key validation conforming RFC 4648
  5916. - compression ratio logging in debug
  5917. * Scripts/webkitpy/thirdparty/__init__.py:
  5918. (AutoinstallImportHook._install_pywebsocket):
  5919. 2012-04-09 Dirk Pranke <dpranke@chromium.org>
  5920. add a webkit-patch print-baselines command
  5921. https://bugs.webkit.org/show_bug.cgi?id=83348
  5922. Reviewed by Adam Barth.
  5923. This adds a simple 'print-baselines' command to webkit-patch
  5924. that can be used in one of two forms: to print where the
  5925. baselines for a given test (or set of tests) on a single port
  5926. will be found, or to generate a report for multiple ports.
  5927. Example of the former:
  5928. $ webkit-patch print-baselines fast/html/keygen.html
  5929. // For mac-snowleopard
  5930. platform/mac/fast/html/keygen-expected.txt
  5931. platform/mac/fast/html/keygen-expected.png
  5932. $
  5933. The latter is most useful for finding out which fallback dirs are
  5934. used by which ports for which tests, for example,
  5935. 'chromium-mac-leopard' uses 100 results from 'platform/mac/leopard'.
  5936. No example output is given because the reports are pretty wordy :).
  5937. * Scripts/webkitpy/layout_tests/port/base.py:
  5938. (Port.baseline_extensions): Added.
  5939. (Port.expected_baseline_dict): Added.
  5940. * Scripts/webkitpy/tool/commands/queries.py:
  5941. (PrintBaselines):
  5942. (PrintBaselines.__init__):
  5943. (PrintBaselines.execute):
  5944. (PrintBaselines._print_baselines):
  5945. (PrintBaselines._platform_for_path):
  5946. 2012-04-09 Florin Malita <fmalita@chromium.org>
  5947. Unreviewed: adding myself to committers.py.
  5948. * Scripts/webkitpy/common/config/committers.py:
  5949. 2012-04-09 Ming Xie <mxie@rim.com>
  5950. [BlackBerry] Allow simulator to use GLES2 acceleration
  5951. https://bugs.webkit.org/show_bug.cgi?id=81672
  5952. Reviewed by Rob Buis.
  5953. * Scripts/webkitdirs.pm:
  5954. (blackberryCMakeArguments):
  5955. 2012-04-09 Dana Jansens <danakj@chromium.org>
  5956. Mark myself as a committer
  5957. https://bugs.webkit.org/show_bug.cgi?id=83510
  5958. Reviewed by Adrienne Walker.
  5959. * Scripts/webkitpy/common/config/committers.py:
  5960. 2012-04-09 Dirk Pranke <dpranke@chromium.org>
  5961. nrwt is failing to upload test results on the chromium-mac-leopard bots
  5962. https://bugs.webkit.org/show_bug.cgi?id=83230
  5963. Unreviewed, build fix.
  5964. It looks like the change in r113399 to use the per-request
  5965. timeout variable didn't actually work, so I am removing the
  5966. timeout code altogether and counting on the idea that upload
  5967. just isn't likely to take that long and the timeouts and
  5968. retransmits are largely unused and largely unnecessary. We'll
  5969. see if this breaks anywhere else.
  5970. * Scripts/webkitpy/common/net/file_uploader.py:
  5971. (FileUploader.__init__):
  5972. (FileUploader._upload_data.callback):
  5973. (FileUploader):
  5974. 2012-04-09 Rob Buis <rbuis@rim.com>
  5975. [BlackBerry] Cleanup LayoutTestControllerBlackBerry.cpp
  5976. https://bugs.webkit.org/show_bug.cgi?id=83469
  5977. Reviewed by Dirk Schulze.
  5978. Remove WTF:: prefixes and fix a warning with the length variable.
  5979. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  5980. (jsStringRefToWebCoreString):
  5981. (LayoutTestController::execCommand):
  5982. (LayoutTestController::isCommandEnabled):
  5983. (LayoutTestController::setUserStyleSheetLocation):
  5984. (LayoutTestController::counterValueForElementById):
  5985. (LayoutTestController::overridePreference):
  5986. (LayoutTestController::setMockGeolocationError):
  5987. (LayoutTestController::findString):
  5988. 2012-04-09 Patrick Gansterer <paroga@webkit.org>
  5989. Build fix for WinCE after r113570.
  5990. * Scripts/build-webkit: Do not use FastMalloc for WinCE.
  5991. 2012-04-09 Eric Carlson <eric.carlson@apple.com>
  5992. Subscribe eric.carlson@apple.com to Media-related changes
  5993. https://bugs.webkit.org/show_bug.cgi?id=83421
  5994. Reviewed by Dan Bernstein.
  5995. * Scripts/webkitpy/common/config/watchlist:
  5996. 2012-04-09 Martin Robinson <mrobinson@igalia.com>
  5997. check-webkit-style should ignore NULL usage in gtk_style_context_get_style
  5998. https://bugs.webkit.org/show_bug.cgi?id=83412
  5999. Reviewed by David Levin.
  6000. Accept NULL as an argument for gtk_style_context_get_style, because it's
  6001. used as a sentinel in a variable argument list.
  6002. * Scripts/webkitpy/style/checkers/cpp.py:
  6003. (check_for_null): Add an exception.
  6004. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  6005. (WebKitStyleTest.test_null_false_zero): Add a test for the exception.
  6006. 2012-04-09 Dirk Pranke <dpranke@chromium.org>
  6007. webkitpy: use the filesystem object properly in fileuploader
  6008. https://bugs.webkit.org/show_bug.cgi?id=83326
  6009. Reviewed by Adam Barth.
  6010. We should be using the filesystem object rather than the codecs
  6011. object.
  6012. * Scripts/webkitpy/common/net/file_uploader.py:
  6013. (FileUploader.upload_as_multipart_form_data):
  6014. 2012-04-09 Eric Seidel <eric@webkit.org>
  6015. Enable webkit_unit_tests for commit queue and EWS while tracking failures
  6016. https://bugs.webkit.org/show_bug.cgi?id=83329
  6017. Unreviewed. Add a missing import to unbreak all the Chromium EWS/CQ bots. :)
  6018. line 62, in _create_unit_test_results
  6019. return UnitTestResults.results_from_string(results_xml)
  6020. NameError: global name 'UnitTestResults' is not defined
  6021. * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
  6022. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  6023. (LayoutTestResultsReaderTest.test_create_unit_test_results):
  6024. 2012-04-08 Adam Barth <abarth@webkit.org>
  6025. The port object is missing unit_tests_results_path
  6026. https://bugs.webkit.org/show_bug.cgi?id=83448
  6027. Unreviewed.
  6028. This is causing the cr-linux-ews to throw an exception.
  6029. * Scripts/webkitpy/common/config/ports.py:
  6030. (DeprecatedPort.unit_tests_results_path):
  6031. 2012-04-07 Patrick Gansterer <paroga@webkit.org>
  6032. [CMake] Cleanup WTF include directories
  6033. https://bugs.webkit.org/show_bug.cgi?id=82716
  6034. Reviewed by Eric Seidel.
  6035. * DumpRenderTree/efl/CMakeLists.txt:
  6036. * WinCELauncher/CMakeLists.txt:
  6037. 2012-04-07 Rob Buis <rbuis@rim.com>
  6038. [BlackBerry] Add Battery Status API support
  6039. https://bugs.webkit.org/show_bug.cgi?id=82615
  6040. Reviewed by George Staikos.
  6041. Enable BATTERY_STATUS.
  6042. * Scripts/build-webkit:
  6043. 2012-04-06 Ami Fischman <fischman@chromium.org>
  6044. Subscribe feature-media-reviews@c.o to Media-related changes.
  6045. https://bugs.webkit.org/show_bug.cgi?id=83397
  6046. Reviewed by David Levin.
  6047. * Scripts/webkitpy/common/config/committers.py:
  6048. * Scripts/webkitpy/common/config/watchlist:
  6049. 2012-04-06 Adrienne Walker <enne@google.com>
  6050. [chromium] Add virtual test suite for threaded compositing
  6051. https://bugs.webkit.org/show_bug.cgi?id=82263
  6052. Reviewed by James Robinson.
  6053. Add compositing/visibility as a virtual test suites to test threaded
  6054. compositing with. This is a reasonable smoke test of 9 tests, none of
  6055. which have any expectations in the non-threaded case.
  6056. To fix many of the remaining tests in this virtual test suite, there
  6057. will need to be some serious refactoring to merge the conflict between
  6058. the way CCScheduler wants to draw frames and the way DRT also wants to
  6059. control things. So, in the short term, enable a few simple tests that
  6060. are known to be passing.
  6061. * Scripts/webkitpy/layout_tests/port/chromium.py:
  6062. (ChromiumPort.virtual_test_suites):
  6063. 2012-04-06 Enrica Casucci <enrica@apple.com>
  6064. Provide Obj-C private API to simplify markup.
  6065. https://bugs.webkit.org/show_bug.cgi?id=83334
  6066. <rdar://problem/11033861>
  6067. Reviewed by Sam Weinig.
  6068. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  6069. * TestWebKitAPI/Tests/mac/SimplifyMarkup.mm: Added.
  6070. (-[SimplifyMarkupTest webView:didFinishLoadForFrame:]):
  6071. * TestWebKitAPI/Tests/mac/verboseMarkup.html: Added.
  6072. 2012-04-06 Dirk Pranke <dpranke@chromium.org>
  6073. new-run-webkit-tests: fix bugs in 'mock' drt implementation
  6074. https://bugs.webkit.org/show_bug.cgi?id=83341
  6075. Reviewed by Eric Seidel.
  6076. The current implementation crashed in some circumstances for
  6077. reference tests and files that were missing expected results.
  6078. This patch fixes those cases and adds more unit tests; it is a
  6079. precursor to adding unit tests each port that actually uses this
  6080. code, in order to get better coverage of the port/*
  6081. implementations.
  6082. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  6083. (parse_options):
  6084. (MockDRT.input_from_line):
  6085. (MockDRT.output_for_test):
  6086. (MockDRT.run_one_test):
  6087. (MockChromiumDRT.input_from_line):
  6088. (MockChromiumDRT.output_for_test):
  6089. (MockChromiumDRT.run_one_test):
  6090. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  6091. (MockDRTTest.make_input_output):
  6092. (MockDRTTest.expected_output):
  6093. (MockDRTTest):
  6094. (MockDRTTest.assertTest):
  6095. (MockDRTTest.test_missing_image):
  6096. (MockDRTTest.test_missing_text):
  6097. (MockDRTTest.test_reftest_match):
  6098. (MockDRTTest.test_reftest_mismatch):
  6099. (MockChromiumDRTTest.expected_output):
  6100. 2012-04-06 James Robinson <jamesr@chromium.org>
  6101. Enable webkit_unit_tests for commit queue and EWS while tracking failures
  6102. https://bugs.webkit.org/show_bug.cgi?id=83329
  6103. Reviewed by Adam Barth.
  6104. This adds a step to parse XML output from webkit_unit_tests and consider regressions in the PatchAnalysisTask so
  6105. the commit queue and EWS can reject patches that cause regressions.
  6106. * Scripts/webkitpy/common/config/ports.py:
  6107. (ChromiumPort.run_webkit_unit_tests_command):
  6108. * Scripts/webkitpy/common/config/ports_mock.py:
  6109. (MockPort.unit_tests_results_path):
  6110. * Scripts/webkitpy/common/net/layouttestresults.py:
  6111. (LayoutTestResults.__init__):
  6112. (LayoutTestResults.failing_tests):
  6113. (LayoutTestResults):
  6114. (LayoutTestResults.add_unit_test_failures):
  6115. * Scripts/webkitpy/common/net/unittestresults.py: Copied from Tools/Scripts/webkitpy/tool/steps/runtests_unittest.py.
  6116. (UnitTestResults):
  6117. (UnitTestResults.results_from_string):
  6118. * Scripts/webkitpy/common/net/unittestresults_unittest.py: Added.
  6119. (UnitTestResultsTest):
  6120. (UnitTestResultsTest.test_nostring):
  6121. (UnitTestResultsTest.test_emptystring):
  6122. (UnitTestResultsTest.test_nofailures):
  6123. (test_onefailure):
  6124. (test_multiple_failures_per_test):
  6125. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  6126. (MockCommitQueue.test_results):
  6127. (MockCommitQueue.archive_last_test_results):
  6128. (FailingTestCommitQueue.test_results):
  6129. (test_flaky_test_failure):
  6130. (test_failed_archive):
  6131. * Scripts/webkitpy/tool/bot/layouttestresultsreader.py:
  6132. (LayoutTestResultsReader._create_unit_test_results):
  6133. (LayoutTestResultsReader.results):
  6134. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  6135. (LayoutTestResultsReaderTest.test_missing_layout_test_results):
  6136. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  6137. (PatchAnalysisTaskDelegate.test_results):
  6138. (PatchAnalysisTaskDelegate.archive_last_test_results):
  6139. (PatchAnalysisTask._test):
  6140. (PatchAnalysisTask._build_and_test_without_patch):
  6141. (PatchAnalysisTask._test_patch):
  6142. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  6143. (AbstractEarlyWarningSystem.test_results):
  6144. (AbstractEarlyWarningSystem.archive_last_test_results):
  6145. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  6146. (EarlyWarningSytemTest._test_testing_ews):
  6147. * Scripts/webkitpy/tool/commands/queues.py:
  6148. (CommitQueue.test_results):
  6149. (CommitQueue.archive_last_test_results):
  6150. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  6151. (CommitQueueTest.test_commit_queue):
  6152. (test_rollout):
  6153. (test_manual_reject_during_processing):
  6154. * Scripts/webkitpy/tool/steps/runtests.py:
  6155. (RunTests.run):
  6156. * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  6157. (RunTestsTest.test_webkit_run_unit_tests):
  6158. 2012-04-06 Aaron Colwell <acolwell@chromium.org>
  6159. Enable MediaSource feature for DumpRenderTree so
  6160. MediaSource LayoutTests will pass for Chromium.
  6161. https://bugs.webkit.org/show_bug.cgi?id=83053
  6162. Reviewed by Dimitri Glazkov.
  6163. * DumpRenderTree/chromium/TestShell.cpp:
  6164. (TestShell::TestShell):
  6165. 2012-04-06 George Staikos <staikos@webkit.org>
  6166. Turn on vibration support for BlackBerry.
  6167. Reviewed by Rob Buis.
  6168. * Scripts/build-webkit:
  6169. 2012-04-06 Dan Bernstein <mitz@apple.com>
  6170. <rdar://problem/10912476> HiDPI: Have canvas use a hidpi backing store, but downsample upon access
  6171. Reviewed by Sam Weinig.
  6172. * Scripts/build-webkit: Added high-dpi-canvas option to control ENABLE_HIGH_DPI_CANVAS.
  6173. 2012-04-05 Dirk Pranke <dpranke@chromium.org>
  6174. nrwt is failing to upload test results on the chromium-mac-leopard bots
  6175. https://bugs.webkit.org/show_bug.cgi?id=83230
  6176. Reviewed by Ojan Vafai.
  6177. This should fix things properly; FileUploader() was setting the
  6178. socket default timeout value, and apparently that doesn't work
  6179. properly with urllib. Also, the class had a bad try/finally
  6180. block that was causing the exceptions to be swallowed :(.
  6181. * Scripts/webkitpy/common/net/file_uploader.py:
  6182. (FileUploader.__init__):
  6183. (FileUploader._upload_data.callback):
  6184. (FileUploader):
  6185. (FileUploader._upload_data):
  6186. * Scripts/webkitpy/common/net/networktransaction.py:
  6187. (NetworkTimeout.__str__):
  6188. (NetworkTransaction.run):
  6189. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  6190. (JSONResultsGeneratorBase.upload_json_files):
  6191. 2012-04-05 Patrick Gansterer <paroga@webkit.org>
  6192. [Qt] Correct <wtf/*.h> include paths.
  6193. https://bugs.webkit.org/show_bug.cgi?id=83270
  6194. Reviewed by Eric Seidel.
  6195. Modify the #include declerations so that the
  6196. wtf types are included using the full path.
  6197. * WebKitTestRunner/qt/TestInvocationQt.cpp:
  6198. 2012-04-05 Philippe Normand <pnormand@igalia.com>
  6199. gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
  6200. https://bugs.webkit.org/show_bug.cgi?id=83176
  6201. Reviewed by Tony Chang.
  6202. Refactored the test to use os.path.join() to specify the
  6203. core_pattern value of the empty crash log mock.
  6204. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  6205. (GtkPortTest):
  6206. (GtkPortTest.assertLinesEqual):
  6207. (GtkPortTest.test_get_crash_log):
  6208. (_mock_gdb_output):
  6209. 2012-04-05 Csaba Osztrogonác <ossy@webkit.org>
  6210. [Qt] Fix includes after QtDeclarative -> QtQML renaming
  6211. https://bugs.webkit.org/show_bug.cgi?id=82195
  6212. Relanding r112651, because Qt5 is updated everywhere.
  6213. * MiniBrowser/qt/BrowserWindow.cpp:
  6214. (BrowserWindow::updateVisualMockTouchPoints):
  6215. * MiniBrowser/qt/main.cpp:
  6216. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  6217. (WTR::WrapperWindow::handleStatusChanged):
  6218. * qmake/mkspecs/features/unix/default_post.prf:
  6219. 2012-04-05 Pierre Rossi <pierre.rossi@gmail.com>
  6220. [Qt] WK1/WK2 layout test results are diverging
  6221. https://bugs.webkit.org/show_bug.cgi?id=82720
  6222. The resolving of default font families was altered in Qt5.
  6223. This directly affects the font picked by DRT for layout
  6224. tests. Since we want to keep the Qt4 and Qt5 results in line,
  6225. we can trick DRT in picking the same font as before for now.
  6226. Reviewed by Csaba Osztrogonác.
  6227. * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  6228. (WebKit::initializeTestFonts):
  6229. 2012-04-05 Kinuko Yasuda <kinuko@chromium.org>
  6230. Expose DataTransferItem.getAsEntry() to allow users access dropped files as FileEntry
  6231. https://bugs.webkit.org/show_bug.cgi?id=82592
  6232. Reviewed by David Levin.
  6233. Added filesystem hook support in EventSender.beginDragWithFiles() for DumpRenderTree.
  6234. * DumpRenderTree/chromium/EventSender.cpp:
  6235. (EventSender::beginDragWithFiles):
  6236. 2012-04-04 Tim Horton <timothy_horton@apple.com>
  6237. [mac] WKTR should always keep its windows offscreen
  6238. https://bugs.webkit.org/show_bug.cgi?id=83244
  6239. <rdar://problem/11188764>
  6240. Reviewed by Simon Fraser.
  6241. We don't want to allow windows onto the main display; intercept attempts to
  6242. change WebKitTestRunnerWindow's frame origin and prevent it from happening.
  6243. Also keep around and respond with a new "fake" origin, in case someone is
  6244. expecting it to change (I couldn't find any tests that expected this, however).
  6245. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  6246. (-[WebKitTestRunnerWindow setFrameOrigin:]):
  6247. (-[WebKitTestRunnerWindow setFrame:display:animate:]):
  6248. (-[WebKitTestRunnerWindow setFrame:display:]):
  6249. (-[WebKitTestRunnerWindow frame]):
  6250. 2012-04-04 Dirk Pranke <dpranke@chromium.org>
  6251. Fix typo introduced in r113271.
  6252. Unreviewed, build fix.
  6253. * Scripts/webkitpy/common/net/file_uploader.py:
  6254. (FileUploader._upload_data.callback):
  6255. (FileUploader):
  6256. 2012-04-04 Scott Graham <scottmg@google.com>
  6257. [Chromium, DRT] Bounds check indices on gamepadController
  6258. https://bugs.webkit.org/show_bug.cgi?id=83192
  6259. Invalid test data would cause bad array accesses. Add simple checks to
  6260. ignore such invalid data.
  6261. Reviewed by Kent Tamura.
  6262. * DumpRenderTree/chromium/GamepadController.cpp:
  6263. (GamepadController::connect):
  6264. (GamepadController::disconnect):
  6265. (GamepadController::setId):
  6266. (GamepadController::setButtonCount):
  6267. (GamepadController::setButtonData):
  6268. (GamepadController::setAxisCount):
  6269. (GamepadController::setAxisData):
  6270. 2012-04-04 Dirk Pranke <dpranke@chromium.org>
  6271. nrwt is failing to upload test results on the chromium-mac-leopard bots
  6272. https://bugs.webkit.org/show_bug.cgi?id=83230
  6273. Reviewed by Ojan Vafai.
  6274. More debugging info and a possible fix - stop messing with the
  6275. default network timeout, and don't swallow URLErrors.
  6276. * Scripts/webkitpy/common/net/file_uploader.py:
  6277. (FileUploader._upload_data):
  6278. * Scripts/webkitpy/common/net/networktransaction.py:
  6279. (NetworkTransaction.run):
  6280. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  6281. (JSONResultsGeneratorBase.upload_json_files):
  6282. 2012-04-04 Dirk Pranke <dpranke@chromium.org>
  6283. nrwt is failing to upload test results on the chromium-mac-leopard bots
  6284. https://bugs.webkit.org/show_bug.cgi?id=83230
  6285. Reviewed by Ojan Vafai.
  6286. * Scripts/webkitpy/common/net/file_uploader.py:
  6287. (FileUploader.__init__):
  6288. (FileUploader._upload_data.callback):
  6289. (FileUploader):
  6290. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  6291. (Manager._upload_json_files):
  6292. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  6293. (JSONResultsGeneratorBase.upload_json_files):
  6294. 2012-04-04 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  6295. WKTR needs to implement layoutTestController.setPageVisibility()
  6296. https://bugs.webkit.org/show_bug.cgi?id=69554
  6297. Reviewed by Simon Fraser.
  6298. This patch implements the layoutTestController.setPageVisibility
  6299. so WKTR supports the Page Visibility API implementation by using InjectedBundle
  6300. to set the visibility state directly to Page.
  6301. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  6302. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  6303. (WTR::LayoutTestController::setPageVisibility):
  6304. (WTR):
  6305. (WTR::LayoutTestController::resetPageVisibility):
  6306. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  6307. (LayoutTestController):
  6308. 2012-04-04 Adam Barth <abarth@webkit.org>
  6309. [Chromium] TestWebKitAPI links in WebCore twice
  6310. https://bugs.webkit.org/show_bug.cgi?id=83177
  6311. Reviewed by Dimitri Glazkov.
  6312. This is causing link errors in the Windows component build. This patch
  6313. moves the dependencies a bit lower down in the dependency diagram in
  6314. the hopes of removing the duplicate symbols.
  6315. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:
  6316. 2012-04-04 Christophe Dumez <christophe.dumez@intel.com>
  6317. [EFL][DRT] Catch the "resource,request,willsend" signal
  6318. https://bugs.webkit.org/show_bug.cgi?id=82192
  6319. Reviewed by Gustavo Noronha Silva.
  6320. EFL's DumpRenderTree now catches the "resource,request,willsend"
  6321. signal in order to implement the "Blocked access to external URL"
  6322. behavior and avoid potential network-related timeouts in the tests.
  6323. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  6324. (DumpRenderTreeChrome::createView):
  6325. (DumpRenderTreeChrome::onWillSendRequest):
  6326. * DumpRenderTree/efl/DumpRenderTreeChrome.h:
  6327. (DumpRenderTreeChrome):
  6328. 2012-04-04 Patrick Gansterer <paroga@webkit.org>
  6329. [EFL][DRT] Correct <wtf/*.h> include paths.
  6330. https://bugs.webkit.org/show_bug.cgi?id=83168
  6331. Reviewed by Eric Seidel.
  6332. Modify the #include declarations so that the
  6333. wtf types are included using the full path.
  6334. * DumpRenderTree/efl/DumpRenderTree.cpp:
  6335. 2012-04-04 Philippe Normand <pnormand@igalia.com>
  6336. gtk_unittest.GtkPortTest.test_get_crash_log failing on windows
  6337. https://bugs.webkit.org/show_bug.cgi?id=83176
  6338. Reviewed by Tony Chang.
  6339. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  6340. (test_get_crash_log): Skip the test on non-linux platforms.
  6341. 2012-04-04 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  6342. [EFL] DRT support for computedStyleIncludingVisitedInfo
  6343. https://bugs.webkit.org/show_bug.cgi?id=82190
  6344. Adding missing implementation computedStyleIncludingVisitedInfo to EFL's
  6345. LayoutTestController so that we can unskip related tests from the skip list.
  6346. Reviewed by Antonio Gomes.
  6347. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  6348. (LayoutTestController::computedStyleIncludingVisitedInfo):
  6349. 2012-04-04 Raphael Kubo da Costa <rakuco@webkit.org>
  6350. Unreviewed; update my email address once again in the committers
  6351. and watch list.
  6352. * Scripts/webkitpy/common/config/committers.py: Prefer my
  6353. webkit.org email over my FreeBSD.org one.
  6354. * Scripts/webkitpy/common/config/watchlist: Ditto.
  6355. 2012-04-04 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  6356. [Qt][WK2] QtWebKit2 should support Page Visibility API
  6357. https://bugs.webkit.org/show_bug.cgi?id=81164
  6358. Reviewed by Kenneth Rohde Christiansen.
  6359. Enabling Page Visiblity API for Qt WebKit2.
  6360. * qmake/mkspecs/features/features.prf:
  6361. 2012-04-04 Andras Becsi <andras.becsi@nokia.com>
  6362. [Qt][WK2] Make the WebView a subclass of Flickable
  6363. https://bugs.webkit.org/show_bug.cgi?id=83033
  6364. Reviewed by Kenneth Rohde Christiansen.
  6365. Remove workaround in MiniBrowser and the ScrollIndicator
  6366. now that the WebView is a Flickable.
  6367. * MiniBrowser/qt/MiniBrowser.pro:
  6368. * MiniBrowser/qt/qml/BrowserWindow.qml:
  6369. * MiniBrowser/qt/qml/ScrollIndicator.qml:
  6370. * WebKitTestRunner/Target.pri:
  6371. 2012-04-04 Csaba Osztrogonác <ossy@webkit.org>
  6372. REGRESSION(r113144): It made run-webkit-tests always fail
  6373. https://bugs.webkit.org/show_bug.cgi?id=83142
  6374. Unreviewed trivial fix after r113144.
  6375. * Scripts/run-webkit-tests:
  6376. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6377. I really hope this is the last build fix. Apparently exec doesn't quite arguments with
  6378. double quotations on Windows. Use system instead.
  6379. Hopefully, this won't break anything.
  6380. * Scripts/run-webkit-tests:
  6381. 2012-04-03 Keishi Hattori <keishi@webkit.org>
  6382. Disable ENABLE_DATALIST for now
  6383. https://bugs.webkit.org/show_bug.cgi?id=82871
  6384. Reviewed by Kent Tamura.
  6385. * Scripts/build-webkit: Disabled ENABLE_DATALIST.
  6386. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6387. Sigh... this isn't going well. I can't even reproduce this issue locally.
  6388. Another speculative fix.
  6389. * Scripts/run-webkit-tests:
  6390. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6391. I don't know why I'm so sloppy today. Another build fix.
  6392. * Scripts/run-webkit-tests:
  6393. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6394. Hopefully the last build fix for Chromium Windows.
  6395. Explicitly execute new-run-webkit-tests and old-run-webkit-tests by python and perl.
  6396. * Scripts/run-webkit-tests:
  6397. 2012-04-03 Dirk Pranke <dpranke@chromium.org>
  6398. [Chromium] Lots of timeouts causing Mac10.6 to exit early.
  6399. https://bugs.webkit.org/show_bug.cgi?id=83076
  6400. Unreviewed, build fix (slightly reviewed by Simon Fraser and Eric Seidel, but not approved).
  6401. Add logic to the apple mac and chromium mac code to not use
  6402. too many workers; it looks like the xserves (and possibly mac
  6403. pros) count hyperthreaded cores when they really shouldn't and
  6404. we end up using too many workers at a time; this leads to tests
  6405. thrashing and timing out.
  6406. This change is a temporary fix to make the bots happy while I
  6407. look into more profiling and other fixes.
  6408. * Scripts/webkitpy/layout_tests/port/mac.py:
  6409. (ChromiumMacPort.default_child_processes):
  6410. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  6411. (ChromiumMacPort.default_child_processes):
  6412. 2012-04-03 Simon Fraser <simon.fraser@apple.com>
  6413. WebKitTestRunner's EventSender is leaky
  6414. https://bugs.webkit.org/show_bug.cgi?id=83099
  6415. Reviewed by Beth Dakin.
  6416. Fix leaks of WKNumbers by using the adoptWK idiom, and make
  6417. all the code consistent.
  6418. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  6419. (WTR::EventSendingController::mouseDown):
  6420. (WTR::EventSendingController::mouseUp):
  6421. (WTR::EventSendingController::mouseMoveTo):
  6422. (WTR::EventSendingController::leapForward):
  6423. (WTR::EventSendingController::keyDown):
  6424. (WTR::EventSendingController::mouseScrollBy):
  6425. (WTR::EventSendingController::addTouchPoint):
  6426. (WTR::EventSendingController::updateTouchPoint):
  6427. (WTR::EventSendingController::setTouchModifier):
  6428. (WTR::EventSendingController::releaseTouchPoint):
  6429. (WTR::EventSendingController::cancelTouchPoint):
  6430. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6431. Another build fix. Don't use old-run-webkit-tests on Chromium Windows bots.
  6432. * Scripts/run-webkit-tests:
  6433. (useNewRunWebKitTests):
  6434. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6435. kill-old-processes should kill apache2 and httpd
  6436. https://bugs.webkit.org/show_bug.cgi?id=83065
  6437. Reviewed by Tony Chang.
  6438. Kill apache2 and httpd on Mac and Linux (Windows uses lighttpd) to free up port 8000.
  6439. * BuildSlaveSupport/kill-old-processes:
  6440. 2012-04-03 Tony Chang <tony@chromium.org>
  6441. run the same test steps on test only bots as on build-and-test bots
  6442. https://bugs.webkit.org/show_bug.cgi?id=83090
  6443. Reviewed by Ryosuke Niwa.
  6444. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  6445. (TestFactory.__init__):
  6446. 2012-04-03 Ami Fischman <fischman@chromium.org>
  6447. Add a Media watchlist.
  6448. https://bugs.webkit.org/show_bug.cgi?id=83071
  6449. Reviewed by David Levin.
  6450. * Scripts/webkitpy/common/config/watchlist:
  6451. 2012-04-03 Simon Fraser <simon.fraser@apple.com>
  6452. Fix large leak in WebKitTestRunner
  6453. https://bugs.webkit.org/show_bug.cgi?id=83084
  6454. Reviewed by Beth Dakin.
  6455. Fix a leak of the bimap backing store created when doing pixel and
  6456. ref tests. This leak was causing serious thrash on the test bots.
  6457. We don't need to allocate memory for CGBitmapContextCreate(); if we
  6458. pass NULL, it will allocate and manage its own backing store.
  6459. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  6460. (WTR::createCGContextFromImage):
  6461. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6462. Another build fix after r113067. Close the zipfile after extracting all files so that we can remove it.
  6463. * BuildSlaveSupport/built-product-archive:
  6464. (unzipArchive):
  6465. 2012-04-03 Ojan Vafai <ojan@chromium.org>
  6466. Give more human friendly error message when builders fail to load or have stale data.
  6467. https://bugs.webkit.org/show_bug.cgi?id=83058
  6468. Reviewed by Eric Seidel.
  6469. * TestResultServer/static-dashboards/dashboard_base.js:
  6470. (addError):
  6471. (addBuilderLoadErrors):
  6472. (handleLocationChange):
  6473. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  6474. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6475. Again, a build fix after r113067. Don't call r113067 twice on the configuration build directory.
  6476. * BuildSlaveSupport/built-product-archive:
  6477. (extractBuiltProduct):
  6478. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6479. Yet another build fix after r113067. Don't trigger Chromium testers right away
  6480. since they're now triggered by builders.
  6481. * BuildSlaveSupport/build.webkit.org-config/config.json:
  6482. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6483. Another build fix after r113067 for Mac port.
  6484. It turned out that archiving the entire build directory doesn't work.
  6485. * BuildSlaveSupport/built-product-archive:
  6486. (createZipManually):
  6487. (createZip):
  6488. (archiveBuiltProduct):
  6489. 2012-04-03 Mike Lattanzio <mlattanzio@rim.com>
  6490. [BlackBerry] Expose CaseSensitive, Wrap, and HighlightAllMatches in WebPage::findNextString()
  6491. https://bugs.webkit.org/show_bug.cgi?id=82643
  6492. Update LayoutTestController to accomodate the new find API.
  6493. It now provides caseSensitive functionality to DRT.
  6494. Internal Review by Andy Chen.
  6495. Reviewed by Rob Buis.
  6496. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  6497. (LayoutTestController::findString):
  6498. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6499. Another build fix after r113067. CreateWebKitBuildDirectory step is no longer needed
  6500. because download-built-product creates the build directory as needed.
  6501. This step fails on Chromium Windows due to -p option not supported by Windows' native mkdir.
  6502. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  6503. (TestFactory.__init__):
  6504. 2012-04-03 Ryosuke Niwa <rniwa@webkit.org>
  6505. Build fix after r113067. Don't delete the build directory.
  6506. * BuildSlaveSupport/built-product-archive:
  6507. (extractBuiltProduct):
  6508. 2012-04-02 Ojan Vafai <ojan@chromium.org>
  6509. Load all builder lists from the buildbot json
  6510. https://bugs.webkit.org/show_bug.cgi?id=82998
  6511. Reviewed by Adam Barth.
  6512. Also, remove an unnecessary list of test types. Now we don't hard-code
  6513. builder names anywhere and we only have a single hard-coded list of
  6514. test types.
  6515. * TestResultServer/static-dashboards/builders.js:
  6516. (BuilderMaster.prototype.logPath):
  6517. (BuilderMaster.prototype.builderJsonPath):
  6518. (requestBuilderList.xhr.onload):
  6519. (requestBuilderList.xhr.onerror):
  6520. (isChromiumDepsFyiGpuTestRunner):
  6521. (isChromiumTipOfTreeGpuTestRunner):
  6522. (isChromiumDepsGTestRunner):
  6523. (isChromiumDepsCrosGTestRunner):
  6524. (isChromiumTipOfTreeGTestRunner):
  6525. (onBuilderListLoad):
  6526. (loadBuildersList):
  6527. * TestResultServer/static-dashboards/dashboard_base.js:
  6528. (parseCrossDashboardParameters):
  6529. (currentBuilderGroupCategory):
  6530. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  6531. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  6532. (testHtmlForTestsWithExpectationsButNoFailures):
  6533. (testGenerateChromiumTipOfTreeGpuBuildersFromBuilderList):
  6534. (testGenerateChromiumDepsGTestBuildersFromBuilderList):
  6535. (testGenerateChromiumDepsCrosGTestBuildersFromBuilderList):
  6536. (testGenerateChromiumTipOfTreeGTestBuildersFromBuilderList):
  6537. * TestResultServer/static-dashboards/timeline_explorer.html:
  6538. 2012-04-02 Ryosuke Niwa <rniwa@webkit.org>
  6539. Chromium testers should extract builds instead of building on their own
  6540. https://bugs.webkit.org/show_bug.cgi?id=82996
  6541. Reviewed by Tony Chang.
  6542. Make Chromium builders triggger Chromium testers and make testers download and extract builds
  6543. from the buildbot master instead of building binaries on their own.
  6544. Add download-built-product to wrap curl used in the download-built-product step since Windows
  6545. does not provide "curl" natively.
  6546. * BuildSlaveSupport/build.webkit.org-config/config.json: Add new triggerables for Chromium testers and make
  6547. Chromium builders trigger them. Also change the type of Chromium testers from NewBuildAndTest to Test.
  6548. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  6549. (DownloadBuiltProduct): Call download-built-product instead of curl.
  6550. * BuildSlaveSupport/built-product-archive:
  6551. (createZip): Don't zip the parent configuration build directory like "release" and "debug". While Mac port
  6552. needs this behavior for compatibility reasons, Chromium Mac port doesn't want this behavior.
  6553. (archiveBuiltProduct): Zip the configuration build directory on Mac port.
  6554. (unzipArchive): Extracted. Use ditto on Mac, unzip on linux and cygwin, and zipfile package on Windows.
  6555. (extractBuiltProduct): Refactor the code to use removeDirectoryIfExists and unzipArchive. Support Chromium.
  6556. * BuildSlaveSupport/download-built-product: Added to wrap curl which isn't available on Windows.
  6557. 2012-04-03 Martin Robinson <mrobinson@igalia.com>
  6558. [GTK] Tools/Scripts/run-gtk-tests should not force you to use the WebKit jhbuild
  6559. https://bugs.webkit.org/show_bug.cgi?id=82473
  6560. Reviewed by Philippe Normand.
  6561. Only use jhbuild if WebKitBuild/Dependencies exists (if update-webkitgtk-libs)
  6562. was ever run.
  6563. * gtk/run-with-jhbuild: Instead of using jhbuild unconditionally, first
  6564. check if the user has ever run update-gtk-libs and, if so, then use jhbuild.
  6565. 2012-04-03 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  6566. [EFL] DRT support for setInteractiveFormValidationEnabled
  6567. https://bugs.webkit.org/show_bug.cgi?id=82050
  6568. Enable interactive form validation and unskip tests from the
  6569. skip list.
  6570. Reviewed by Antonio Gomes.
  6571. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  6572. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  6573. 2012-04-03 Philippe Normand <pnormand@igalia.com>
  6574. Unreviewed, another test-webkitpy fix-up after r113037.
  6575. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Adapt mock
  6576. crash dump depending on current environment.
  6577. 2012-04-03 Philippe Normand <pnormand@igalia.com>
  6578. Unreviewed, test-webkitpy build fix after r113037.
  6579. * Scripts/webkitpy/layout_tests/port/gtk.py:
  6580. (GtkPort._get_crash_log):
  6581. 2012-04-03 Philippe Normand <pnormand@igalia.com>
  6582. [GTK] crash log reports support
  6583. https://bugs.webkit.org/show_bug.cgi?id=81659
  6584. Reviewed by Martin Robinson.
  6585. Removed the daemontools crashmon/xvfb scripts and implemented the crash
  6586. log reporting in the NRWT Gtk port. To get proper crash logs one
  6587. needs to set the core pattern like this:
  6588. echo "/path/to/cores/core-pid_%p-_-process_%e" > /proc/sys/kernel/core_pattern
  6589. Then enable coredumps with "ulimit -c unlimited" and set the WEBKIT_CORE_DUMPS_DIRECTORY
  6590. environment variable.
  6591. * BuildSlaveSupport/gtk/README:
  6592. * BuildSlaveSupport/gtk/crashmon/crashmon: Removed.
  6593. * BuildSlaveSupport/gtk/crashmon/log/run: Removed.
  6594. * BuildSlaveSupport/gtk/crashmon/run: Removed.
  6595. * BuildSlaveSupport/gtk/daemontools-buildbot.conf:
  6596. * BuildSlaveSupport/gtk/xvfb/log/run: Removed.
  6597. * BuildSlaveSupport/gtk/xvfb/run: Removed.
  6598. * Scripts/new-run-webkit-tests:
  6599. * Scripts/webkitpy/layout_tests/port/gtk.py:
  6600. (GtkDriver.stop):
  6601. (GtkPort.show_results_html_file):
  6602. (GtkPort):
  6603. (GtkPort._get_gdb_output):
  6604. (GtkPort._get_crash_log):
  6605. (GtkPort._get_crash_log.match_filename):
  6606. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  6607. (GtkPortTest):
  6608. (test_show_results_html_file):
  6609. (assertLinesEqual):
  6610. (_mock_gdb_output):
  6611. (test_get_crash_log):
  6612. 2012-04-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  6613. Enable and connect the WebInspectorServer with WebKit2 pages.
  6614. https://bugs.webkit.org/show_bug.cgi?id=73094
  6615. Reviewed by Simon Hausmann.
  6616. Enable developer extras on pages in MiniBrowser for Qt.
  6617. * MiniBrowser/qt/qml/BrowserWindow.qml:
  6618. 2012-04-03 Christophe Dumez <christophe.dumez@intel.com>
  6619. [EFL] LayoutTestController needs implementation of setDefersLoading
  6620. https://bugs.webkit.org/show_bug.cgi?id=82890
  6621. Reviewed by Philippe Normand.
  6622. Implement setDefersLoading() in EFL's LayoutTestController so that the
  6623. corresponding test case can be removed from the skip list.
  6624. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  6625. (LayoutTestController::setDefersLoading):
  6626. 2012-04-03 Christophe Dumez <christophe.dumez@intel.com>
  6627. [EFL] LayoutTestController needs implementation of goBack
  6628. https://bugs.webkit.org/show_bug.cgi?id=81914
  6629. Reviewed by Philippe Normand.
  6630. Implement goBack() in EFL's LayoutTestController by calling
  6631. ewk_frame_back().
  6632. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  6633. (LayoutTestController::goBack):
  6634. 2012-04-03 Alexander Shalamov <alexander.shalamov@intel.com>
  6635. [EFL] LayoutTestController needs implementation of pageSizeAndMarginsInPixels
  6636. https://bugs.webkit.org/show_bug.cgi?id=82589
  6637. Add missing implementation for pageSizeAndMarginsInPixels to EFL's LayoutTestController
  6638. in order to unskip printing/page-format-data.html
  6639. Reviewed by Philippe Normand.
  6640. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  6641. (LayoutTestController::pageSizeAndMarginsInPixels):
  6642. 2012-04-03 Simon Pena <spena@igalia.com>
  6643. [GTK] DRT missing didRunInsecureContent notification
  6644. https://bugs.webkit.org/show_bug.cgi?id=59367
  6645. Reviewed by Philippe Normand.
  6646. Connect DumpRenderTree to WebFrame's "insecure-content-run", in both
  6647. the main WebFrame or any other WebFrame created later. Added
  6648. "didRunInsecureContent" notification in the callback in order to
  6649. get the LayoutTests passing.
  6650. * DumpRenderTree/gtk/DumpRenderTree.cpp: Connect
  6651. to WebFrame's "insecure-content-run" signal and add
  6652. didRunInsecureContent notification in the callback to get the
  6653. LayoutTests passing.
  6654. (didRunInsecureContent):
  6655. (createWebView):
  6656. 2012-04-03 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  6657. rebaseline-server: Make it possible to not launch a browser with the server.
  6658. https://bugs.webkit.org/show_bug.cgi?id=82999
  6659. Reviewed by Adam Barth.
  6660. Add the `--no-show-results' option, which lets one decide not to
  6661. launch a web browser when running the rebaseline server. This is
  6662. especially useful if the default browser is not the wanted one, or
  6663. if the rebaseline server page is already open.
  6664. * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
  6665. (AbstractLocalServerCommand.__init__):
  6666. (AbstractLocalServerCommand.execute):
  6667. 2012-04-02 Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com>
  6668. EFL's LayoutTestController disableImageLoading implementation.
  6669. https://bugs.webkit.org/show_bug.cgi?id=82848
  6670. Reviewed by Hajime Morita.
  6671. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  6672. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  6673. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  6674. (LayoutTestController::disableImageLoading):
  6675. 2012-04-02 Alexander Shalamov <alexander.shalamov@intel.com>
  6676. [EFL] LayoutTestController needs implementation of isPageBoxVisible
  6677. https://bugs.webkit.org/show_bug.cgi?id=82591
  6678. Add missing implementation to isPageBoxVisible to EFL's LayoutTestController
  6679. in order to unskip printing/page-format-data.html
  6680. Reviewed by Hajime Morita.
  6681. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  6682. (LayoutTestController::isPageBoxVisible):
  6683. 2012-04-02 Simon Fraser <simon.fraser@apple.com>
  6684. run-webkit-tests with a relative --root causes tests to fail because DYLD_LIBRARY_PATH is not set
  6685. https://bugs.webkit.org/show_bug.cgi?id=82962
  6686. Reviewed by Dirk Pranke.
  6687. Ensure that _build_path() returns an absolute path.
  6688. Eric Seidel also had to deploy MockConfig in a bunch of places
  6689. in order to correct previous testing errors where we were
  6690. pretending that "Mock Output from child process" (returned by MockExecutive.run_command)
  6691. was a real path. The real Config object calls run_command("webkit-build-directory")
  6692. to read the WebKit build directory from the webkitdirs.pm perl code.
  6693. MockConfig abstracts this away and always returns "/mock-build" during
  6694. testing. This change is much larger than one would think necessary
  6695. because of needing to deploy this MockConfig class.
  6696. * Scripts/webkitpy/layout_tests/port/webkit.py:
  6697. (WebKitPort._build_path):
  6698. 2012-04-02 Ojan Vafai <ojan@chromium.org>
  6699. Fix snafu in r112971. We were never calling parseParameter for builder.
  6700. * TestResultServer/static-dashboards/dashboard_base.js:
  6701. 2012-04-02 Ojan Vafai <ojan@chromium.org>
  6702. Generate the lists of all layout test builders from the buildbot json
  6703. https://bugs.webkit.org/show_bug.cgi?id=82924
  6704. Reviewed by Mihai Parparita.
  6705. In order to make this work, cleaned up a lot of existing technical debt.
  6706. -Got rid of expectations builder. This concept is outdated and just dead code.
  6707. -Split hash parameter parsing into two functions. One for dashboard_base
  6708. (crossDashboardParameters) and one for the specific dashboard html file
  6709. (dashboardSpecificParameters). In the old world, parseParameters needed to
  6710. be called twice and depended on it's own output the first time through.
  6711. Now we only need to parse crossDashboardParameters first and crossDashboardParameters
  6712. doesn't depend on the output of crossDashboardParameters.
  6713. -Lots of variable/method renames due to the above.
  6714. -g_defaultDashboardSpecificStateValues now has to list all possible hash parameters
  6715. for that dashboard.
  6716. * TestResultServer/static-dashboards/aggregate_results.html:
  6717. * TestResultServer/static-dashboards/builders.js:
  6718. (BuilderGroup):
  6719. (BuilderGroup.prototype.setup):
  6720. (jsonRequest.xhr.onload):
  6721. (jsonRequest.xhr.onerror):
  6722. (isWebkitTestRunner):
  6723. (isChromiumWebkitTipOfTreeTestRunner):
  6724. (isChromiumWebkitDepsTestRunner):
  6725. (generateBuildersFromBuilderList):
  6726. (onLayoutTestBuilderListLoad):
  6727. (onErrorLoadingBuilderList):
  6728. (loadBuildersList):
  6729. * TestResultServer/static-dashboards/dashboard_base.js:
  6730. (handleValidHashParameterWrapper):
  6731. (queryHashAsMap):
  6732. (parseParameter):
  6733. (parseCrossDashboardParameters):
  6734. (parseDashboardSpecificParameters):
  6735. (parseParameters):
  6736. (diffStates):
  6737. (defaultValue):
  6738. (isLayoutTestResults):
  6739. (isGPUTestResults):
  6740. (currentBuilderGroupCategory):
  6741. (currentBuilderGroup):
  6742. (initBuilders):
  6743. Now that we've split parameter parseing, these methods no longer need
  6744. to take an optional state. They can always just use the global cross-dashboard state.
  6745. (pathToBuilderResultsFile):
  6746. (appendJSONScriptElementFor):
  6747. (appendJSONScriptElements):
  6748. (handleResourceLoadError):
  6749. (haveJsonFilesLoaded):
  6750. (combinedDashboardState):
  6751. (setQueryParameter):
  6752. (permaLinkURLHash):
  6753. (toggleQueryParameter):
  6754. (queryParameterValue):
  6755. (selectHTML):
  6756. (htmlForTestTypeSwitcher):
  6757. (g_handleBuildersListLoaded):
  6758. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  6759. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  6760. (testPlatformAndBuildType):
  6761. (testSubstringList):
  6762. (testHtmlForTestTypeSwitcherGroup):
  6763. (testLookupVirtualTestSuite):
  6764. (testBaseTest):
  6765. (generateBuildersFromBuilderListHelper):
  6766. (testGenerateChromiumWebkitTipOfTreeBuildersFromBuilderList):
  6767. (testGenerateChromiumWebkitDepsBuildersFromBuilderList):
  6768. (assertObjectsDeepEqual):
  6769. (testQueryHashAsMap):
  6770. (testDiffStates):
  6771. * TestResultServer/static-dashboards/timeline_explorer.html:
  6772. * TestResultServer/static-dashboards/treemap.html:
  6773. 2012-04-02 Tony Chang <tony@chromium.org>
  6774. check-webkit-style errors when removing .png files
  6775. https://bugs.webkit.org/show_bug.cgi?id=82933
  6776. Reviewed by David Levin.
  6777. * Scripts/webkitpy/style/patchreader.py:
  6778. (PatchReader.check): Make sure the file exists and pass in a FileSystem() object (for mocking).
  6779. * Scripts/webkitpy/style/patchreader_unittest.py:
  6780. (test_check_patch_with_png_deletion):
  6781. 2012-04-02 Sheriff Bot <webkit.review.bot@gmail.com>
  6782. Unreviewed, rolling out r112948.
  6783. http://trac.webkit.org/changeset/112948
  6784. https://bugs.webkit.org/show_bug.cgi?id=82961
  6785. Someone else already checked in a similar change (Requested by
  6786. sundiamonde on #webkit).
  6787. * Scripts/webkitpy/layout_tests/port/webkit.py:
  6788. (WebKitDriver._start):
  6789. 2012-04-02 Adam Barth <abarth@webkit.org>
  6790. garden-o-matic isn't able to rebaseline audio failures
  6791. https://bugs.webkit.org/show_bug.cgi?id=82957
  6792. Reviewed by Chris Rogers.
  6793. This patch just adds "wav" to the list of test suffixes and updates the
  6794. unit tests to show that we're rebaselining audio tests results now too.
  6795. * Scripts/webkitpy/tool/commands/rebaseline.py:
  6796. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  6797. (test_rebaseline_updates_expectations_file):
  6798. 2012-04-02 Adam Barth <abarth@webkit.org>
  6799. garden-o-matic should let you listen to audio failures
  6800. https://bugs.webkit.org/show_bug.cgi?id=82953
  6801. Reviewed by Chris Rogers.
  6802. Now that we've actually got an audio failure on the bots, we can clean
  6803. up the last stray bugs. This patch doesn't have any tests because I'm
  6804. lame.
  6805. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  6806. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  6807. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  6808. (.):
  6809. 2012-04-02 Stephanie Lewis <slewis@apple.com>
  6810. run-webkit-tests --root fails if /usr/local/lib/libWebCoreTestSupport.dylib is not installed.
  6811. https://bugs.webkit.org/show_bug.cgi?id=82552
  6812. Reviewed by Dirk Pranke.
  6813. Use DYLD_LIBRARY_PATH so we pick up the libWebCoreTestSupport.dylib located in the root.
  6814. * Scripts/webkitpy/layout_tests/port/webkit.py:
  6815. (WebKitDriver._start):
  6816. 2012-04-02 Dirk Pranke <dpranke@chromium.org>
  6817. NRWT is not printing out the builder it's uploading JSON files for
  6818. https://bugs.webkit.org/show_bug.cgi?id=82834
  6819. Reviewed by Ojan Vafai.
  6820. Handle log messages of the form log.info("%s", arg) properly ...
  6821. I didn't even know you could do that :).
  6822. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  6823. (_LogHandler.emit):
  6824. * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  6825. (RegularTest.test_log_args):
  6826. (VerboseTest.test_log_args):
  6827. 2012-04-02 Tim Horton <timothy_horton@apple.com>
  6828. [mac] LayoutTestHelper crashes if there is no main display
  6829. https://bugs.webkit.org/show_bug.cgi?id=82944
  6830. <rdar://problem/11162954>
  6831. Reviewed by Simon Fraser.
  6832. If there's no main display attached, ColorSyncDeviceCopyDeviceInfo returns
  6833. a null dictionary, so we shouldn't go ahead and try to read from it.
  6834. * DumpRenderTree/mac/LayoutTestHelper.m:
  6835. (installLayoutTestColorProfile):
  6836. 2012-04-02 Balazs Kelemen <kbalazs@webkit.org>
  6837. [Qt][WK2] Set up plugin process on Unix
  6838. https://bugs.webkit.org/show_bug.cgi?id=72121
  6839. Reviewed by Simon Hausmann.
  6840. * qmake/mkspecs/features/features.prf: Reenable plugins
  6841. and turn on plugin process.
  6842. 2012-04-02 Sheriff Bot <webkit.review.bot@gmail.com>
  6843. Unreviewed, rolling out r112868, r112879, and r112881.
  6844. http://trac.webkit.org/changeset/112868
  6845. http://trac.webkit.org/changeset/112879
  6846. http://trac.webkit.org/changeset/112881
  6847. https://bugs.webkit.org/show_bug.cgi?id=82901
  6848. "Build fail on bots." (Requested by kbalazs on #webkit).
  6849. * MiniBrowser/gtk/GNUmakefile.am:
  6850. * qmake/mkspecs/features/features.prf:
  6851. 2012-04-02 Philippe Normand <pnormand@igalia.com>
  6852. [GTK] Enable shadow-dom in build-webkit.
  6853. Rubber-stamped by Gustavo Noronha Silva.
  6854. * Scripts/build-webkit: Enable shadow-dom build, this is need to
  6855. have a working build currently.
  6856. 2012-04-02 Andreas Kling <kling@webkit.org>
  6857. Adding Zalan Bujtas to committers list.
  6858. * Scripts/webkitpy/common/config/committers.py:
  6859. 2012-04-02 Balazs Kelemen <kbalazs@webkit.org>
  6860. [Qt][WK2] Set up plugin process on Unix
  6861. https://bugs.webkit.org/show_bug.cgi?id=72121
  6862. Reviewed by Simon Hausmann.
  6863. * qmake/mkspecs/features/features.prf: Reenable plugins
  6864. and turn on plugin process.
  6865. 2012-04-02 Sheriff Bot <webkit.review.bot@gmail.com>
  6866. Unreviewed, rolling out r112651.
  6867. http://trac.webkit.org/changeset/112651
  6868. https://bugs.webkit.org/show_bug.cgi?id=82887
  6869. It doesn't work with older Qt5 (Requested by Ossy on #webkit).
  6870. * MiniBrowser/qt/BrowserWindow.cpp:
  6871. (BrowserWindow::updateVisualMockTouchPoints):
  6872. * MiniBrowser/qt/main.cpp:
  6873. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  6874. (WTR::WrapperWindow::handleStatusChanged):
  6875. * qmake/mkspecs/features/unix/default_post.prf:
  6876. 2012-04-02 Carlos Garcia Campos <cgarcia@igalia.com>
  6877. [GTK] Fix names of failed unit tests in Tools/Scripts/run-gtk-tests
  6878. https://bugs.webkit.org/show_bug.cgi?id=82877
  6879. Reviewed by Philippe Normand.
  6880. * Scripts/run-gtk-tests:
  6881. (TestRunner.run_tests): Use replace instead of lstrip to remove
  6882. the programs_path from the full path of unit tests.
  6883. 2012-04-02 Carlos Garcia Campos <cgarcia@igalia.com>
  6884. Unreviewed. Skip flaky unit tests.
  6885. * Scripts/run-gtk-tests:
  6886. (TestRunner):
  6887. 2012-04-02 Ryosuke Niwa <rniwa@webkit.org>
  6888. webkitpy rebaseline.
  6889. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  6890. (test_run_test_set_with_json_output):
  6891. (test_run_test_set_with_json_source):
  6892. 2012-04-01 Ryosuke Niwa <rniwa@webkit.org>
  6893. perf-o-matic should store test results' units
  6894. https://bugs.webkit.org/show_bug.cgi?id=82852
  6895. Reviewed by Kentaro Hara.
  6896. Include units in the results JSON.
  6897. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  6898. (PerfTestsRunner._process_chromium_style_test_result):
  6899. (PerfTestsRunner._process_parser_test_result):
  6900. 2012-04-01 Tony Tseung <tseung@apple.com>
  6901. Composite Font References is a new established standard (ISO/IEC 14496-28:2012) for specifying
  6902. composite fonts from existing physical fonts.
  6903. <rdar://problem/10717370>
  6904. https://bugs.webkit.org/show_bug.cgi?id=82810
  6905. A new test font of this kind as been added to the test tools for running the webkit-tests
  6906. Reviewed by Dan Bernstein.
  6907. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  6908. Added new dependency SampleFont.sfont
  6909. * DumpRenderTree/fonts/SampleFont.sfont: Added.
  6910. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  6911. * DumpRenderTree/mac/DumpRenderTree.mm:
  6912. (allowedFontFamilySet):
  6913. Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
  6914. (activateTestingFonts):
  6915. Added the registration of the Composite Font Referene sample font
  6916. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  6917. (WTR::allowedFontFamilySet):
  6918. Added the Composite Font Referene sample font "Hiragino Maru Gothic Monospaced" entry to the fonts white-list
  6919. (WTR::activateFonts):
  6920. Added the registration of the Composite Font Referene sample font
  6921. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  6922. Added new dependency SampleFont.sfont
  6923. * WebKitTestRunner/fonts/SampleFont.sfont: Added.
  6924. 2012-04-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  6925. Support the Network Information API
  6926. https://bugs.webkit.org/show_bug.cgi?id=73528
  6927. Reviewed by Adam Barth.
  6928. Add network information API feature to build script.
  6929. * Scripts/build-webkit:
  6930. 2012-03-31 Ojan Vafai <ojan@chromium.org>
  6931. Generate the flakiness dashboard's list of webkit.org builders from the buildbot JSON
  6932. https://bugs.webkit.org/show_bug.cgi?id=82839
  6933. Reviewed by Adam Barth.
  6934. Also, update various hard-coded lists for WIN7 and Lion ports.
  6935. This is necessary since the new list of builders grabbed off the
  6936. buildbot includes Lion.
  6937. * TestResultServer/static-dashboards/builders.js:
  6938. (generateWebkitBuildersFromBuilderList):
  6939. (xhr.onreadystatechange):
  6940. Don't use dashboard_base's request method to avoid layering violation.
  6941. * TestResultServer/static-dashboards/dashboard_base.js:
  6942. (parseParameters):
  6943. (initBuilders):
  6944. (haveJsonFilesLoaded):
  6945. (g_handleBuildersListLoaded):
  6946. Block loading the JSON files for each builder until we actually have a list of builders.
  6947. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  6948. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  6949. (testPlatformAndBuildType):
  6950. (testGenerateWebkitBuildersFromBuilderList):
  6951. * TestResultServer/static-dashboards/timeline_explorer.html:
  6952. * TestResultServer/static-dashboards/treemap.html:
  6953. Delay generating the page until the builder list has loaded.
  6954. 2012-03-31 Ojan Vafai <ojan@chromium.org>
  6955. If NRWT gets killed halfway through a run, it incorrectly reports tests that weren't run as passes
  6956. https://bugs.webkit.org/show_bug.cgi?id=82799
  6957. Reviewed by Eric Seidel.
  6958. If we don't run a test, mark it as skipped.
  6959. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  6960. (Manager._mark_interrupted_tests_as_skipped):
  6961. (Manager._interrupt_if_at_failure_limits.interrupt_if_at_failure_limit):
  6962. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  6963. (ManagerTest.test_interrupt_if_at_failure_limits):
  6964. 2012-03-31 Ryosuke Niwa <rniwa@webkit.org>
  6965. One more build fix after r112781 for Chromium Windows.
  6966. Don't copy zip .idb files.
  6967. * BuildSlaveSupport/built-product-archive:
  6968. (copyBuildFiles):
  6969. 2012-03-31 Ryosuke Niwa <rniwa@webkit.org>
  6970. Yet another build fix after r112781 for Chromium Windows.
  6971. Run webkit-build-directory by perl explicitly.
  6972. * BuildSlaveSupport/built-product-archive:
  6973. (determineWebKitBuildDirectory):
  6974. 2012-03-31 Ryosuke Niwa <rniwa@webkit.org>
  6975. Fix the syntax error in master.cfg after r112734.
  6976. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  6977. (unitTestsSupported):
  6978. 2012-03-31 Ryosuke Niwa <rniwa@webkit.org>
  6979. Another build fix after r112781.
  6980. * BuildSlaveSupport/built-product-archive:
  6981. (createZip):
  6982. 2012-03-31 Ryosuke Niwa <rniwa@webkit.org>
  6983. Build fix after r112781.
  6984. * BuildSlaveSupport/built-product-archive:
  6985. (createZipManually):
  6986. (createZip):
  6987. 2012-03-30 Ryosuke Niwa <rniwa@webkit.org>
  6988. Chromium bots should upload archived built files
  6989. https://bugs.webkit.org/show_bug.cgi?id=82666
  6990. Reviewed by Tony Chang.
  6991. * BuildSlaveSupport/build.webkit.org-config/config.json:
  6992. * BuildSlaveSupport/built-product-archive:
  6993. (main):
  6994. (determineWebKitBuildDirectory): Instead of hard-coding WebKitBuild as the build outout directory,
  6995. call out to webkit-build-directory.
  6996. (removeDirectoryIfExists): Extracted.
  6997. (copyBuildFiles): Added to avoid archiving useless intermedinate files.
  6998. (createZipManually): Used in Chromium Windows where we don't execute python scripts inside cygwin.
  6999. (createZipManually.addToArchive):
  7000. (createZip): Extracted. Calls out to appropraite command line scripts or createZipManually.
  7001. (archiveBuiltProduct): Add support for Chromium port.
  7002. * Scripts/webkit-build-directory: Add support for --platform options.
  7003. 2012-03-30 Dan Bernstein <mitz@apple.com>
  7004. Reverted r112767, because it caused many vertical text tests to fail.
  7005. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  7006. * DumpRenderTree/fonts/SampleFont.sfont: Removed.
  7007. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  7008. * DumpRenderTree/mac/DumpRenderTree.mm:
  7009. (allowedFontFamilySet):
  7010. (activateTestingFonts):
  7011. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  7012. (WTR::allowedFontFamilySet):
  7013. (WTR::activateFonts):
  7014. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  7015. * WebKitTestRunner/fonts/SampleFont.sfont: Removed.
  7016. 2012-03-30 Malcolm MacLeod <malcolm.macleod@tshwanedje.com>
  7017. [wx] Move wxWebKit API into WebKit namespace.
  7018. https://bugs.webkit.org/show_bug.cgi?id=82740
  7019. Reviewed by Kevin Ollivier.
  7020. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  7021. (LayoutWebViewEventHandler::LayoutWebViewEventHandler):
  7022. (LayoutWebViewEventHandler::bindEvents):
  7023. (LayoutWebViewEventHandler::OnLoadEvent):
  7024. (LayoutWebViewEventHandler::OnAlertEvent):
  7025. (LayoutWebViewEventHandler::OnConfirmEvent):
  7026. (LayoutWebViewEventHandler::OnPromptEvent):
  7027. (LayoutWebViewEventHandler::OnConsoleMessageEvent):
  7028. (LayoutWebViewEventHandler::OnReceivedTitleEvent):
  7029. (LayoutWebViewEventHandler::OnWindowObjectClearedEvent):
  7030. (LayoutWebViewEventHandler):
  7031. (dumpFramesAsText):
  7032. (dump):
  7033. (MyApp::OnInit):
  7034. * wx/browser/browser.cpp:
  7035. (MyApp::OnInit):
  7036. 2012-03-30 Eli Fidler <efidler@rim.com>
  7037. Enable OpenType Sanitizer for BlackBerry port.
  7038. https://bugs.webkit.org/show_bug.cgi?id=82782
  7039. Reviewed by Eric Seidel.
  7040. * Scripts/webkitdirs.pm:
  7041. (blackberryCMakeArguments): add OTS to include path
  7042. 2012-03-30 Simon Fraser <simon.fraser@apple.com>
  7043. run-webkit-tests needs to set DYLD_LIBRARY_PATH as well
  7044. as DYLD_FRAMEWORK_PATH, so that libWebCoreTestSupport.dylib
  7045. is found.
  7046. <rdar://problem/11158581>
  7047. Reviewed by Mark Rowe.
  7048. * Scripts/webkitpy/layout_tests/port/webkit.py:
  7049. (WebKitDriver._start):
  7050. 2012-03-30 Simon Fraser <simon.fraser@apple.com>
  7051. Disable run-api-tests on release mac builds
  7052. https://bugs.webkit.org/show_bug.cgi?id=82788
  7053. Reviewed by Ryosuke Niwa.
  7054. TestWebKitAPI crashes every time in release builds currently
  7055. (https://bugs.webkit.org/show_bug.cgi?id=82652) so disable
  7056. run-api-tests on mac release builders.
  7057. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7058. (unitTestsSupported):
  7059. 2012-03-30 Chang Shu <cshu@webkit.org>
  7060. Unreviewed. Update my email.
  7061. * Scripts/webkitpy/common/config/committers.py:
  7062. 2012-03-30 Chris Fleizach <cfleizach@apple.com>
  7063. AX: Crash at WebCore::renderObjectContainsPosition(WebCore::RenderObject*, WebCore::Position const&)
  7064. https://bugs.webkit.org/show_bug.cgi?id=82745
  7065. Reviewed by Simon Fraser.
  7066. * DumpRenderTree/AccessibilityUIElement.cpp:
  7067. (rangeForPositionCallback):
  7068. (AccessibilityUIElement::rangeForPosition):
  7069. (AccessibilityUIElement::getJSClass):
  7070. * DumpRenderTree/AccessibilityUIElement.h:
  7071. (AccessibilityUIElement):
  7072. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  7073. (AccessibilityUIElement::rangeForPosition):
  7074. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  7075. (WTR::AccessibilityUIElement::rangeForPosition):
  7076. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  7077. (AccessibilityUIElement):
  7078. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  7079. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  7080. (WTR::AccessibilityUIElement::rangeForPosition):
  7081. (WTR):
  7082. 2012-03-30 David Barr <davidbarr@chromium.org>
  7083. Split up top-level .gitignore and .gitattributes
  7084. https://bugs.webkit.org/show_bug.cgi?id=82687
  7085. Reviewed by Tor Arne Vestbø.
  7086. * .gitattributes: Added.
  7087. * .gitignore: Added.
  7088. * DumpRenderTree/DumpRenderTree.gyp/.gitignore: Added.
  7089. * TestWebKitAPI/TestWebKitAPI.gyp/.gitignore: Added.
  7090. 2012-03-30 Mihai Parparita <mihaip@chromium.org>
  7091. Actually remove the ChromiumOS GTK builder, like r112673 said it would.
  7092. * TestResultServer/static-dashboards/builders.js:
  7093. 2012-03-30 Mihai Parparita <mihaip@chromium.org>
  7094. Update ChromiumOS bot names in builders.js to reflect changes made by
  7095. http://crrev.com/129835
  7096. Also removes the ChromiumOS GTK builder, which was removed by
  7097. http://crrev.com/129835
  7098. * TestResultServer/static-dashboards/builders.js:
  7099. 2012-03-30 Vineet Chaudhary <rgf748@motorola.com>
  7100. [GTK] Disable introspection build in the at-spi2-core module.
  7101. https://bugs.webkit.org/show_bug.cgi?id=82729
  7102. Reviewed by Philippe Normand.
  7103. This change is a follow-up of bug 82395 which initially disabled for other modules of the set.
  7104. * gtk/jhbuild.modules: Disable introspection.
  7105. 2012-03-30 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  7106. Add a "preview" state to Page Visibility API implementation
  7107. https://bugs.webkit.org/show_bug.cgi?id=81355
  7108. Reviewed by Adam Barth.
  7109. Updating the Page Visibility API implementation to the current spec version.
  7110. * DumpRenderTree/chromium/LayoutTestController.cpp:
  7111. (LayoutTestController::setPageVisibility):
  7112. 2012-03-30 Keishi Hattori <keishi@webkit.org>
  7113. Change ENABLE_INPUT_COLOR to ENABLE_INPUT_TYPE_COLOR and enable it for chromium
  7114. https://bugs.webkit.org/show_bug.cgi?id=80972
  7115. Reviewed by Kent Tamura.
  7116. * Scripts/build-webkit:
  7117. * qmake/mkspecs/features/features.prf:
  7118. 2012-03-29 Ádám Kallai <kadam@inf.u-szeged.hu>
  7119. [Qt] Build fix by renameing QtDeclarative to QtQml in header calls.
  7120. https://bugs.webkit.org/show_bug.cgi?id=82195
  7121. Reviewed by Simon Hausmann.
  7122. * MiniBrowser/qt/BrowserWindow.cpp:
  7123. (BrowserWindow::updateVisualMockTouchPoints):
  7124. * MiniBrowser/qt/main.cpp:
  7125. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  7126. (WTR::WrapperWindow::handleStatusChanged):
  7127. * qmake/mkspecs/features/unix/default_post.prf:
  7128. 2012-03-30 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  7129. [EFL] Implement LayoutTestController::setMinimumTimerInterval
  7130. https://bugs.webkit.org/show_bug.cgi?id=81220
  7131. Add missing implementation setMinimumTimerInterval to EFL's
  7132. LayoutTestController so that we can unskip related tests from the skip list.
  7133. Reviewed by Philippe Normand.
  7134. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  7135. (LayoutTestController::setMinimumTimerInterval):
  7136. 2012-03-29 Dan Bernstein <mitz@apple.com>
  7137. Removed “Intel” from the Lion builders’ names.
  7138. Rubber-stamped by Mark Rowe.
  7139. * BuildSlaveSupport/build.webkit.org-config/config.json:
  7140. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
  7141. (LeaksViewer._displayURLPrompt):
  7142. 2012-03-29 Mihai Parparita <mihaip@chromium.org>
  7143. [Chromium] Add sharded ChromiumOS debug bots to builders.js
  7144. https://bugs.webkit.org/show_bug.cgi?id=82639
  7145. Reviewed by Eric Seidel.
  7146. The bots were sharded by http://crrev.com/129613, update builders.js
  7147. to reflect this.
  7148. * TestResultServer/static-dashboards/builders.js:
  7149. 2012-03-29 Dirk Pranke <dpranke@chromium.org>
  7150. remove support for junit-style xml output from test-webkitpy
  7151. https://bugs.webkit.org/show_bug.cgi?id=82279
  7152. Reviewed by Eric Seidel.
  7153. This was added when we were looking into integrating w/ Jenkins
  7154. rather than buildbot, but I believe that project got shelved, so
  7155. this is unused. We can always add it back in later as necessary.
  7156. * Scripts/webkitpy/test/main.py:
  7157. (Tester._parse_args):
  7158. (Tester._run_tests):
  7159. * Scritps/webkitpy/thirdparty/__init__.py:
  7160. 2012-03-29 Dirk Pranke <dpranke@chromium.org>
  7161. new-run-webkit-tests: crashes when it fails to decode a stack trace
  7162. https://bugs.webkit.org/show_bug.cgi?id=82673
  7163. Unreviewed, build fix.
  7164. We are assuming the stdout/stderr output from the driver is utf-8
  7165. encoded when we get stack traces; this may not be a valid
  7166. assumption generally, but if we do get strings that aren't valid
  7167. utf-8, we would crash. Now we will ignore any decoding errors.
  7168. * Scripts/webkitpy/layout_tests/port/base.py:
  7169. (Port._get_crash_log):
  7170. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  7171. (PortTestCase.test_get_crash_log):
  7172. 2012-03-29 Simon Fraser <simon.fraser@apple.com>
  7173. Scripts fail to detect when a tool crashes
  7174. https://bugs.webkit.org/show_bug.cgi?id=82659
  7175. Reviewed by Mark Rowe.
  7176. Have exitStatus() detect when the process fail to exit cleanly
  7177. (possibly because of a crash), and return a non-zero exit code
  7178. in that case.
  7179. * Scripts/VCSUtils.pm:
  7180. (exitStatus):
  7181. 2012-03-29 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  7182. [GTK][EFL] run-javascriptcore-tests should be run through jhbuild
  7183. https://bugs.webkit.org/show_bug.cgi?id=82581
  7184. Reviewed by Martin Robinson.
  7185. Running Javascriptcore tests through jhbuild
  7186. for consistency with run-webkit-tests and in order to
  7187. avoid confusing libraries when facing regressions.
  7188. * Scripts/run-javascriptcore-tests:
  7189. 2012-03-29 Dirk Pranke <dpranke@chromium.org>
  7190. test-webkitpy: add --timing
  7191. https://bugs.webkit.org/show_bug.cgi?id=82550
  7192. Reviewed by Eric Seidel.
  7193. This patch adds a --timing option that will display the time
  7194. each test takes. It also removes the --silent option, since
  7195. probably no one ever used it, and cleans up the logging
  7196. option parsing code to be easier to follow.
  7197. * Scripts/webkitpy/test/main.py:
  7198. (Tester._parse_args):
  7199. (Tester._configure):
  7200. * Scripts/webkitpy/test/runner.py:
  7201. (TestRunner.write_result):
  7202. * Scripts/webkitpy/test/runner_unittest.py:
  7203. (RunnerTest.test_regular):
  7204. (RunnerTest.test_verbose):
  7205. (RunnerTest):
  7206. (RunnerTest.test_timing):
  7207. 2012-03-29 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  7208. HashMap<>::add should return a more descriptive object
  7209. https://bugs.webkit.org/show_bug.cgi?id=71063
  7210. Reviewed by Ryosuke Niwa.
  7211. Update code to use AddResult instead of a pair.
  7212. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  7213. (LayoutTestController::evaluateScriptInIsolatedWorld):
  7214. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  7215. (LayoutTestController::evaluateScriptInIsolatedWorld):
  7216. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  7217. (WTR::LayoutTestController::evaluateScriptInIsolatedWorld):
  7218. 2012-03-29 Ilya Tikhonovsky <loislo@chromium.org>
  7219. Web Inspector: chromium: DRT --no-timeout option doesn't work.
  7220. https://bugs.webkit.org/show_bug.cgi?id=82608
  7221. Initial value for m_timeout was initialized in constructor and was overwritten in DRT::main.
  7222. This was broken by r112354 and the sequence became opposite.
  7223. Reviewed by Yury Semikhatsky.
  7224. * DumpRenderTree/chromium/TestShell.cpp:
  7225. (TestShell::TestShell):
  7226. (TestShell::initialize):
  7227. 2012-03-29 Vineet Chaudhary <rgf748@motorola.com>
  7228. Remove custom bindings form Internals.idl of attribute type Array.
  7229. https://bugs.webkit.org/show_bug.cgi?id=82319
  7230. Reviewed by Kentaro Hara.
  7231. Remove JSInternalsCustom.cpp and V8InternalsCustom.cpp as no longer required.
  7232. * GNUmakefile.am:
  7233. 2012-03-28 Mark Rowe <mrowe@apple.com>
  7234. Fix --no-saved-state.
  7235. Ignore the flag before Lion, rather than making it specific to Lion.
  7236. Rubber-stamped by Dan Bernstein.
  7237. * Scripts/webkitdirs.pm:
  7238. (argumentsForRunAndDebugMacWebKitApp):
  7239. 2012-03-28 Dave Tharp <dtharp@codeaurora.org>
  7240. Add dtharp to contributors list
  7241. https://bugs.webkit.org/show_bug.cgi?id=82545
  7242. Reviewed by Adam Barth.
  7243. Adding dtharp as Contributor.
  7244. * Scripts/webkitpy/common/config/committers.py:
  7245. 2012-03-28 Stuart Eichert <stuart.eichert@palm.com>
  7246. build-webkit : the word "pass" is spelled incorrectly as "passs"
  7247. https://bugs.webkit.org/show_bug.cgi?id=82532
  7248. Reviewed by Julien Chaffraix.
  7249. Corrected spelling of the word "pass" in build-webkit.
  7250. * Scripts/build-webkit:
  7251. 2012-03-28 Dirk Pranke <dpranke@chromium.org>
  7252. new-run-webkit-tests doesn't log correctly after retrying failures
  7253. https://bugs.webkit.org/show_bug.cgi?id=82541
  7254. Unreviewed, build fix.
  7255. r112189 introduced a regression where we would accidentally
  7256. delete the log handler after we retried any failing tests - that
  7257. meant that any log messages around uploading the results got
  7258. dropped.
  7259. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  7260. (Manager._run_tests):
  7261. 2012-03-28 Kevin Ollivier <kevino@theolliviers.com>
  7262. [wx] Unreviewed. Build fix, move WTF back into JSCore target
  7263. until issues with JSCore not linking in all WTF symbols are resolved.
  7264. * waf/build/settings.py:
  7265. 2012-03-28 Simon Fraser <simon.fraser@apple.com>
  7266. download-built-product build step should detect 404 errors
  7267. https://bugs.webkit.org/show_bug.cgi?id=82491
  7268. Reviewed by Ryosuke Niwa.
  7269. Pass --fail to curl so that it reports 404 errors.
  7270. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7271. (DownloadBuiltProduct): Pass --fail to curl so that it reports errors.
  7272. * BuildSlaveSupport/built-product-archive:
  7273. (extractBuiltProduct): Remove trailing whitespace.
  7274. 2012-03-28 Dirk Pranke <dpranke@chromium.org>
  7275. flakiness dashboard should only keep the last 500 runs
  7276. https://bugs.webkit.org/show_bug.cgi?id=82530
  7277. Reviewed by Ojan Vafai.
  7278. If a bot has an overly large amount of failing tests, then
  7279. storing 750 runs' worth takes a lot of memory and CPU time to
  7280. process and we end up getting killed by AppEngine; this cases
  7281. data corruption and confusion down the road when we have to
  7282. retry the upload of the data and the tests show up as multiple
  7283. runs.
  7284. * TestResultServer/model/jsonresults.py:
  7285. (JsonResults.update_file):
  7286. 2012-03-28 Ryosuke Niwa <rniwa@webkit.org>
  7287. extract-built-product build step should fail if unzipping fails
  7288. https://bugs.webkit.org/show_bug.cgi?id=82493
  7289. Reviewed by Simon Fraser.
  7290. Forward non-zero exit code from subprocesses so that the master can detect any failures
  7291. and bail out early.
  7292. * BuildSlaveSupport/built-product-archive:
  7293. (main):
  7294. 2012-03-28 Dirk Pranke <dpranke@chromium.org>
  7295. test-webkitpy should support files, directories, and packages as command line args
  7296. https://bugs.webkit.org/show_bug.cgi?id=76765
  7297. Reviewed by Adam Barth.
  7298. This patch adds support for specifying files, directories, and
  7299. packages to test-webkitpy along with the already existing
  7300. support for modules, test classes, and individual test names.
  7301. Also, fix a bug in filesystem_mock where we wouldn't normalize a
  7302. path containing a reference to the current directory properly,
  7303. for example, '/foo/./bar.py'.
  7304. * Scripts/webkitpy/common/system/filesystem_mock.py:
  7305. (MockFileSystem.normpath):
  7306. * Scripts/webkitpy/test/main.py:
  7307. (Tester._configure_logging):
  7308. (Tester._run_tests):
  7309. * Scripts/webkitpy/test/test_finder.py:
  7310. (TestDirectoryTree.find_modules):
  7311. (TestDirectoryTree.subpath):
  7312. (TestFinder.is_dotted_name):
  7313. (TestFinder.find_names):
  7314. (TestFinder):
  7315. (TestFinder._find_names_for_arg):
  7316. (TestFinder._find_in_trees):
  7317. (TestFinder._default_names):
  7318. * Scripts/webkitpy/test/test_finder_unittest.py:
  7319. (TestFinderTest.setUp):
  7320. (TestFinderTest.tearDown):
  7321. (TestFinderTest.check_names):
  7322. (TestFinderTest.test_default_names):
  7323. (TestFinderTest):
  7324. (TestFinderTest.test_paths):
  7325. 2012-03-28 Simon Fraser <simon.fraser@apple.com>
  7326. Fix inspector tests when running in internal builds.
  7327. <rdar://problem/11050694>
  7328. Reviewed by Tim Hatcher.
  7329. * DumpRenderTree/mac/DumpRenderTree.mm:
  7330. (resetDefaultsToConsistentValues):
  7331. * WebKitTestRunner/TestController.cpp:
  7332. (WTR::TestController::resetStateToConsistentValues):
  7333. 2012-03-28 David Kilzer <ddkilzer@apple.com>
  7334. Use xcrun to find nm and ranlib on OS X builds
  7335. <http://webkit.org/b/82466>
  7336. Reviewed by Dan Bernstein.
  7337. * Scripts/build-webkit: Use xcrun to find ranlib.
  7338. * Scripts/webkitdirs.pm:
  7339. (determineNmPath): Added. Use xcrun to find nm on OS X.
  7340. (nmPath): Added.
  7341. * Scripts/webkitperl/features.pm:
  7342. (libraryContainsSymbol): Use nmPath().
  7343. 2012-03-28 Ojan Vafai <ojan@chromium.org>
  7344. Add history navigation to garden-o-matic
  7345. https://bugs.webkit.org/show_bug.cgi?id=82495
  7346. Reviewed by Dimitri Glazkov.
  7347. Also, maintain scroll offsets when returning to a tab. This makes addressing
  7348. expected failures considerably easier when dealing with below-the-fold tests.
  7349. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  7350. -Store the scrollTop before switching to a new tab and restore the appropriate scrollTop after
  7351. switching.
  7352. -Modify window.location with the tabName in the hash. Can't use pushState because this is served
  7353. from a file URL and Chrome puts each different file URL in it's own origin.
  7354. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  7355. Remove the href so that clicking on the accordion item does not modify window.location.hash.
  7356. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  7357. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  7358. 2012-03-28 Philippe Normand <pnormand@igalia.com>
  7359. [GTK] generate-gtk-doc doesn't cope with custom build directory
  7360. https://bugs.webkit.org/show_bug.cgi?id=82448
  7361. Reviewed by Martin Robinson.
  7362. Pass the product directory in generate-gtkdoc arguments from
  7363. build-webkit.
  7364. * Scripts/webkitdirs.pm:
  7365. (buildAutotoolsProject):
  7366. * gtk/common.py:
  7367. (get_build_path):
  7368. 2012-03-28 Carlos Garcia Campos <cgarcia@igalia.com>
  7369. [GTK] Add --skipped command line option to Tools/Scripts/run-gtk-tests
  7370. https://bugs.webkit.org/show_bug.cgi?id=82341
  7371. Reviewed by Martin Robinson.
  7372. Add --skipped=skip|ignore|only command line option.
  7373. * Scripts/run-gtk-tests:
  7374. (TestRunner._test_cases_to_skip): Return the list of test cases
  7375. to skip for the given test depending on the skipped action.
  7376. (TestRunner._should_run_test): Decide whether to run the test or
  7377. not depending on the skipped action.
  7378. (TestRunner.run_tests): Only show the list of skipped tests when
  7379. skipped action is 'skip'.
  7380. 2012-03-28 Carlos Garcia Campos <cgarcia@igalia.com>
  7381. [GTK] Use gtester -s to skip individual test cases instead of unit tests as a whole
  7382. https://bugs.webkit.org/show_bug.cgi?id=82333
  7383. Reviewed by Martin Robinson.
  7384. * Scripts/run-gtk-tests:
  7385. (TestRunner.SkippedTest): Add SkippedTest class to store more
  7386. information about skipped tests.
  7387. (TestRunner._setup_testing_environment): Use SkippedTest to add
  7388. TestWebKitAccessibility to the skipped list.
  7389. (TestRunner._find_skipped_test): Return the SkippedTest object for
  7390. a given test path.
  7391. (TestRunner._test_cases_to_skip): Returns the list of test cases
  7392. that should be skipped for a given test path.
  7393. (TestRunner._should_run_test): Helper funtion to decide whether
  7394. the given test path should be run or not. Tests in the skipped
  7395. list that don't have a list of failing test cases are not run at
  7396. all. Tests in the skipped list that contain a list of test cases
  7397. are run with gtester -s to skip the individual test cases.
  7398. (TestRunner._run_test): Helper funtion to run a given test.
  7399. (TestRunner.run_tests): Build the list of tests to run based on
  7400. _should_run_test() and use helper function _run_test() to run
  7401. every test.
  7402. 2012-03-28 Csaba Osztrogonác <ossy@webkit.org>
  7403. [Qt] Couple of tests have different results on 64 bit and/or in debug mode compared to 32 bit and/or release mode
  7404. https://bugs.webkit.org/show_bug.cgi?id=52810
  7405. Reviewed by Simon Hausmann.
  7406. Use SSE2 floating point math on 32 bit instead of the default
  7407. 387 to make layout test result same on 32 and on 64 bit builds.
  7408. * qmake/mkspecs/features/unix/default_post.prf:
  7409. 2012-03-28 Sergio Villar Senin <svillar@igalia.com>
  7410. [Soup] DNS prefetching spams resolver, shoots self in the foot
  7411. https://bugs.webkit.org/show_bug.cgi?id=41630
  7412. Reviewed by Martin Robinson.
  7413. Bump libsoup and glib dependencies.
  7414. * efl/jhbuild.modules:
  7415. * gtk/jhbuild.modules:
  7416. 2012-03-28 Gustavo Noronha Silva <gns@gnome.org>
  7417. [GTK] Disable introspection for jhbuild modules
  7418. https://bugs.webkit.org/show_bug.cgi?id=82395
  7419. Reviewed by Philippe Normand.
  7420. * efl/jhbuild.modules: add --disable-introspection to all modules
  7421. that support it
  7422. * gtk/jhbuild.modules: ditto.
  7423. 2012-03-28 Csaba Osztrogonác <ossy@webkit.org>
  7424. [Qt] Unreviewed, fix API tests after adding full platforms. (r111658)
  7425. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7426. (BuildAndTestFactory.__init__):
  7427. 2012-03-28 Csaba Osztrogonác <ossy@webkit.org>
  7428. [Qt] Unreviewed typo fix after r112383.
  7429. * Scripts/run-qtwebkit-tests:
  7430. (Main.check_crash_occurences):
  7431. 2012-03-28 Ádám Kallai <kadam@inf.u-szeged.hu>
  7432. [Qt] run-qtwebkit-tests should report crashes
  7433. https://bugs.webkit.org/show_bug.cgi?id=76905
  7434. Added checking of crashing tests. Now final summary includes the total number of crashing tests too.
  7435. Made unit test for this modification by János Badics <jbadics@inf.u-szeged.hu>.
  7436. Reviewed by Csaba Osztrogonác.
  7437. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7438. (RunQtAPITests.commandComplete):
  7439. (RunQtAPITests.evaluateCommand):
  7440. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  7441. (RunQtAPITestsTest):
  7442. (test_failure):
  7443. (test_crash):
  7444. * Scripts/run-qtwebkit-tests:
  7445. (Main.announce_results_html):
  7446. (Main):
  7447. (Main.check_crash_occurences):
  7448. (Main.convert_to_stdout):
  7449. (Main.convert_to_html):
  7450. 2012-03-28 Kwonjin Jeong <gram@company100.net>
  7451. Add support for Intel compiler on Linux QT port.
  7452. https://bugs.webkit.org/show_bug.cgi?id=81077
  7453. Reviewed by Tor Arne Vestbø.
  7454. * qmake/mkspecs/features/default_post.prf:
  7455. Don't hide symbols when building with Intel compiler.
  7456. The symbols are needed when building QtWebKit tests.
  7457. * qmake/mkspecs/features/unix/icc.prf:
  7458. Added to ignore icc-specific warnings.
  7459. This feature is used with command-line arguments for build-webkit script.
  7460. 2012-03-28 Philippe Normand <pnormand@igalia.com>
  7461. Unreviewed, trivial update-webkit-libs-jhbuild system call fix.
  7462. * Scripts/update-webkitgtk-libs: This script is written in
  7463. Perl. Not Python. So use perl vocabulary to refer to command line arguments.
  7464. 2012-03-28 Ryosuke Niwa <rniwa@webkit.org>
  7465. kill-old-processes doesn't do anything on linux
  7466. https://bugs.webkit.org/show_bug.cgi?id=82388
  7467. Reviewed by Tony Chang.
  7468. Kill cc1plus, ld, etc... on linux. Also ps aux + grep to kill old run-webkit-tests processes.
  7469. This should help stabilizing Chromium linux bots.
  7470. * BuildSlaveSupport/kill-old-processes:
  7471. 2012-03-28 Philippe Normand <pnormand@igalia.com>
  7472. [GTK] jhbuild wrongly tricked into clean-up
  7473. https://bugs.webkit.org/show_bug.cgi?id=82216
  7474. Reviewed by Gustavo Noronha Silva.
  7475. Save jhbuild{rc,.modules}.md5sum in Dependencies instead of the
  7476. build tree. Also when checking if the jhbuild configuration
  7477. changed use absolute md5sum paths.
  7478. * Scripts/webkitdirs.pm:
  7479. (runAutogenForAutotoolsProjectIfNecessary):
  7480. (jhbuildConfigurationChanged):
  7481. (buildAutotoolsProject):
  7482. 2012-03-28 Csaba Osztrogonác <ossy@webkit.org>
  7483. kill-old-processes doesn't do anything on linux
  7484. https://bugs.webkit.org/show_bug.cgi?id=82388
  7485. One more attempt to disable kill-old-processes on the Qt bots not to kill each others.
  7486. The platform in Factory comes from config.json, accordingly platform is fullplatform,
  7487. for example: qt-4.8, qt-5.0-wk2. We have to check only the prefix of platform.
  7488. Reviewed by Ryosuke Niwa.
  7489. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7490. (Factory.__init__):
  7491. 2012-03-28 Hao Zheng <zhenghao@chromium.org>
  7492. Make Chromium port for Android use hardware gpu path default.
  7493. https://bugs.webkit.org/show_bug.cgi?id=82033
  7494. Reviewed by Dirk Pranke.
  7495. Skip canvas tests, which are run in virtual gpu test suites.
  7496. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  7497. (ChromiumAndroidPort.__init__):
  7498. (ChromiumAndroidPort.skipped_tests):
  7499. 2012-03-27 Csaba Osztrogonác <ossy@webkit.org>
  7500. kill-old-processes doesn't do anything on linux
  7501. https://bugs.webkit.org/show_bug.cgi?id=82388
  7502. Disable kill-old-processes on the Qt bots not to kill each others.
  7503. Reviewed by Ryosuke Niwa.
  7504. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  7505. (Factory.__init__):
  7506. 2012-03-27 Hao Zheng <zhenghao@chromium.org>
  7507. Handle DRT crash caused by Android OOM.
  7508. https://bugs.webkit.org/show_bug.cgi?id=82310
  7509. Reviewed by Tony Chang.
  7510. When Android is OOM, it sends a SIGKILL (137) signal to DRT. DRT
  7511. is stopped silently and regarded as crashed. Re-run the test for
  7512. such crash.
  7513. Add some debug log to NRWT.
  7514. * Scripts/webkitpy/layout_tests/port/chromium.py:
  7515. (ChromiumDriver.run_test):
  7516. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  7517. (ChromiumAndroidPort.__init__):
  7518. (ChromiumAndroidPort.get_last_stacktrace):
  7519. (ChromiumAndroidDriver.__init__):
  7520. (ChromiumAndroidDriver._start):
  7521. (ChromiumAndroidDriver.run_test):
  7522. (ChromiumAndroidDriver._get_drt_return_value):
  7523. 2012-03-27 Ojan Vafai <ojan@chromium.org>
  7524. Fix expected results for some unittest failures.
  7525. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  7526. 2012-03-27 Adrienne Walker <enne@google.com>
  7527. [chromium] Fix --enabled-threaded-compositing flag in DRT
  7528. https://bugs.webkit.org/show_bug.cgi?id=82405
  7529. Reviewed by James Robinson.
  7530. --enable-threaded-compositing wasn't working because there was no way
  7531. to set the value before it was used in the TestShell constructor.
  7532. To avoid adding yet another boolean parameter to TestShell's
  7533. constructor, add an explicit initialize function that can operate on
  7534. any boolean settings that are set post-constructor.
  7535. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  7536. (main):
  7537. * DumpRenderTree/chromium/TestShell.cpp:
  7538. (TestShell::TestShell):
  7539. (TestShell::initialize):
  7540. * DumpRenderTree/chromium/TestShell.h:
  7541. (TestShell):
  7542. (TestShell::setTestShellMode):
  7543. 2012-03-27 Dirk Pranke <dpranke@chromium.org>
  7544. new-run-webkit-tests: suppress debug output from run-safari on results file
  7545. https://bugs.webkit.org/show_bug.cgi?id=82400
  7546. Reviewed by Ryosuke Niwa.
  7547. Send the run-safari output to /dev/null rather than the console.
  7548. * Scripts/webkitpy/layout_tests/port/mac.py:
  7549. (MacPort.show_results_html_file):
  7550. 2012-03-27 Simon Fraser <simon.fraser@apple.com>
  7551. Improve error reporting in run-javascriptcore-tests
  7552. https://bugs.webkit.org/show_bug.cgi?id=82379
  7553. Reviewed by Jessie Berlin.
  7554. When the script dies, have it print out the reason for dying.
  7555. * Scripts/run-javascriptcore-tests:
  7556. 2012-03-27 Eric Seidel <eric@webkit.org>
  7557. Add Dave Barton to the Contributors list so I can more easily CC him on bugs
  7558. https://bugs.webkit.org/show_bug.cgi?id=82373
  7559. Reviewed by Ryosuke Niwa.
  7560. Dave's committer-status in in-progress, so until then
  7561. list him as a Contributor so at least I can more easily CC him on bugs.
  7562. * Scripts/webkitpy/common/config/committers.py:
  7563. 2012-03-26 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  7564. [jhbuild] Prepend jhbuildrc's directory to sys.path instead of appending.
  7565. https://bugs.webkit.org/show_bug.cgi?id=82252
  7566. Reviewed by Gustavo Noronha Silva.
  7567. Appending the directory containing common.py may be problematic if
  7568. another path in sys.path also contains either a common.py or a
  7569. common/ module, so prepend to select our version instead. This is
  7570. the case with fail2ban, which has a common/ directory which may
  7571. end up being in Python's default path.
  7572. * efl/jhbuildrc:
  7573. * gtk/jhbuildrc:
  7574. 2012-03-27 Dirk Pranke <dpranke@chromium.org>
  7575. test-webkitpy: prepare for better test run output
  7576. https://bugs.webkit.org/show_bug.cgi?id=82290
  7577. Reviewed by Adam Barth.
  7578. This code basically re-implements the output of the TextTestRunner default
  7579. runner code from unittest, although the implementation is quite
  7580. different, in preparation for changing the test output to be
  7581. metered and possibly running in parallel.
  7582. The output is almost identical to before, except that instead of
  7583. logging "test_regular (webkitpy.main.RunnerTest) passed" we log
  7584. "webkitpy.main.RunnerTest.test_regular passed". It has always
  7585. annoyed me that they invert the names to be harder to read and
  7586. so that you can't copy & paste back to the input for
  7587. test-webkitpy.
  7588. This patch is provided to add a skeleton for unit tests and for
  7589. comparison to an upcoming patch that will actually add new
  7590. functionality.
  7591. * Scripts/webkitpy/test/main.py:
  7592. (Tester.__init__):
  7593. (Tester._configure_logging):
  7594. (Tester._run_tests):
  7595. * Scripts/webkitpy/test/runner.py: Added.
  7596. (TestRunner):
  7597. (TestRunner.__init__):
  7598. (TestRunner.test_name):
  7599. (TestRunner.all_test_names):
  7600. (TestRunner.run):
  7601. (TestRunner.write_result):
  7602. (TestRunner.write_summary):
  7603. * Scripts/webkitpy/test/runner_unittest.py: Added.
  7604. (FakeModuleSuite):
  7605. (FakeModuleSuite.__init__):
  7606. (FakeModuleSuite.__str__):
  7607. (FakeModuleSuite.run):
  7608. (FakeTopSuite):
  7609. (FakeTopSuite.__init__):
  7610. (FakeLoader):
  7611. (FakeLoader.__init__):
  7612. (FakeLoader.top_suite):
  7613. (FakeLoader.loadTestsFromName):
  7614. (RunnerTest):
  7615. (RunnerTest.test_regular):
  7616. (RunnerTest.test_verbose):
  7617. 2012-03-27 Gustavo Noronha Silva <gns@gnome.org>
  7618. [GTK] Build gnutls without p11-kit support
  7619. https://bugs.webkit.org/show_bug.cgi?id=82212
  7620. Reviewed by Martin Robinson.
  7621. * gtk/jhbuild.modules: pass --without-p11-kit to gnutls'
  7622. configure, to avoid requiring that dependency, which is not used
  7623. by libsoup and WebKit anyway
  7624. 2012-03-27 Csaba Osztrogonác <ossy@webkit.org>
  7625. [Qt] Make debug build work on 32 bit
  7626. https://bugs.webkit.org/show_bug.cgi?id=82331
  7627. Use --no-keep-memory option of ld not to cache the symbol tables of input files in
  7628. memory to avoid memory exhaustion during the linking phase for x86-debug builds.
  7629. Reviewed by Tor Arne Vestbø.
  7630. * qmake/mkspecs/features/unix/default_post.prf:
  7631. * qmake/mkspecs/features/unix/default_pre.prf:
  7632. 2012-03-23 Balazs Ankes <bank@inf.u-szeged.hu>
  7633. Add png checking to check-webkit-style
  7634. https://bugs.webkit.org/show_bug.cgi?id=75824
  7635. Reviewed by NOBODY Tony Chang.
  7636. * Scripts/webkitpy/style/checker.py:
  7637. (_all_categories):
  7638. (FileType):
  7639. (CheckerDispatcher._should_skip_file_path):
  7640. (CheckerDispatcher._file_type):
  7641. (CheckerDispatcher._create_checker):
  7642. * Scripts/webkitpy/style/checker_unittest.py:
  7643. (CheckerDispatcherDispatchTest.test_none_paths):
  7644. * Scripts/webkitpy/style/checkers/png.py: Added.
  7645. (PNGChecker):
  7646. (PNGChecker.__init__):
  7647. (PNGChecker.check):
  7648. (PNGChecker._config_file_path):
  7649. * Scripts/webkitpy/style/checkers/png_unittest.py: Added.
  7650. (MockSCMDetector):
  7651. (MockSCMDetector.__init__):
  7652. (MockSCMDetector.display_name):
  7653. (MockSCMDetector.propget):
  7654. (PNGCheckerTest):
  7655. (PNGCheckerTest.test_init):
  7656. (PNGCheckerTest.test_init.mock_handle_style_error):
  7657. (PNGCheckerTest.test_check):
  7658. (PNGCheckerTest.test_check.mock_handle_style_error):
  7659. * Scripts/webkitpy/style/patchreader.py:
  7660. (PatchReader.check):
  7661. 2012-03-27 Carlos Garcia Campos <cgarcia@igalia.com>
  7662. Unreviewed. Skip GTK+ unit tests that fail in the bots
  7663. * Scripts/run-gtk-tests:
  7664. (TestRunner): Add failing tests to the skipped list.
  7665. 2012-03-27 Carlos Garcia Campos <cgarcia@igalia.com>
  7666. Unreviewed. Unskip all GTK+ unit test.
  7667. Currently, skipped tests contains the list of unit tests that have
  7668. failed in one or more bots. In this moment it's not possible to
  7669. skip just the test cases that fail, so the complete unit test is
  7670. skipped when a single test case fails. For that reason, we don't
  7671. know which test cases are actually failing for every skipped
  7672. test. We are planning to land a patch to allow skipping individual
  7673. test cases, but first we need to know which test cases are
  7674. currently failing in the bots to skip them. So, this patch simply
  7675. unskips all unit tests in order to watch the bots and get the list
  7676. of test cases failing. Failing tests will be skipped again as soon
  7677. as we have the new list of failing test cases.
  7678. * Scripts/run-gtk-tests:
  7679. (TestRunner): Reset the list of skipped tests.
  7680. 2012-03-26 Scott Byer <scottbyer@chromium.org>
  7681. Enable layout testing of the scroll animator.
  7682. https://bugs.webkit.org/show_bug.cgi?id=81858
  7683. Add a call to the InternalSettings that layout tests can use to
  7684. turn on scroll animation. Enable animation updates for the
  7685. Chromium platform DRT when scroll animation has been turned on in
  7686. a test. This should be a no-op for all current layout tests.
  7687. Reviewed by James Robinson.
  7688. * DumpRenderTree/chromium/WebViewHost.cpp:
  7689. (WebViewHost::serviceAnimation):
  7690. (WebViewHost::scheduleAnimation):
  7691. * DumpRenderTree/chromium/WebViewHost.h:
  7692. (WebViewHost):
  7693. 2012-03-26 Dinu Jacob <dinu.jacob@nokia.com>
  7694. [Qt][WK2] Support multi-file upload
  7695. https://bugs.webkit.org/show_bug.cgi?id=81589
  7696. Reviewed by Simon Hausmann.
  7697. Modified filePicker to support multi-file upload.
  7698. * MiniBrowser/qt/MiniBrowser.qrc:
  7699. * MiniBrowser/qt/icons/checkbox_checked.png: Added.
  7700. * MiniBrowser/qt/icons/checkbox_unchecked.png: Added.
  7701. * MiniBrowser/qt/js/MultiSelect.js: Added.
  7702. (values):
  7703. (isSelected):
  7704. (removeValue):
  7705. * MiniBrowser/qt/qml/CheckBox.qml: Added.
  7706. * MiniBrowser/qt/qml/FilePicker.qml:
  7707. 2012-03-26 Mark Hahnenberg <mhahnenberg@apple.com>
  7708. Retry crashing tests serially at the end of NRWT on Apple Mac
  7709. https://bugs.webkit.org/show_bug.cgi?id=82233
  7710. Reviewed by Dirk Pranke.
  7711. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  7712. (Manager.run):
  7713. * Scripts/webkitpy/layout_tests/port/base.py:
  7714. (Port.should_retry_crashes):
  7715. * Scripts/webkitpy/layout_tests/port/mac.py:
  7716. (MacPort.should_retry_crashes):
  7717. 2012-03-26 Mark Hahnenberg <mhahnenberg@apple.com>
  7718. NRWT should retry failures serially
  7719. https://bugs.webkit.org/show_bug.cgi?id=82241
  7720. Reviewed by Dirk Pranke.
  7721. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  7722. (Manager._run_tests): Add another parameter to specify the number of workers to use.
  7723. (Manager.run): Run the failures serially.
  7724. 2012-03-26 Adrienne Walker <enne@google.com>
  7725. Allow expectations on directories in virtual test suites
  7726. https://bugs.webkit.org/show_bug.cgi?id=82250
  7727. Reviewed by Dirk Pranke.
  7728. lookup_virtual_test_base was only returning valid results for files
  7729. and not directories. Fix by falling back to the virtual test suite
  7730. mapping if possible.
  7731. * Scripts/webkitpy/layout_tests/port/base.py:
  7732. (Port.lookup_virtual_test_base):
  7733. * Scripts/webkitpy/layout_tests/port/test.py:
  7734. (TestPort.skipped_tests):
  7735. (TestPort.virtual_test_suites):
  7736. 2012-03-26 Dirk Pranke <dpranke@chromium.org>
  7737. Fix duplicated ChangeLog entry from r112171.
  7738. Unreviewed, build fix.
  7739. 2012-03-26 Dirk Pranke <dpranke@chromium.org>
  7740. nrwt: remove --worker-model flag
  7741. https://bugs.webkit.org/show_bug.cgi?id=82112
  7742. Reviewed by Adam Barth.
  7743. The --worker-model=inline flag is basically redundant with the
  7744. --child-processes=1 flag (technically, you could one run child
  7745. process, but this is only useful for testing); this patch
  7746. removes this flag, which simplifies things and enables more
  7747. cleanup down the road.
  7748. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  7749. (Manager._run_tests):
  7750. (Manager.print_config):
  7751. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  7752. (get):
  7753. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  7754. (make_broker):
  7755. (FunctionTests.test_get__inline):
  7756. (FunctionTests.test_get__processes):
  7757. (_TestsMixin.setUp):
  7758. (_TestsMixin.make_broker):
  7759. (InlineBrokerTests.setUp):
  7760. (MultiProcessBrokerTests.setUp):
  7761. * Scripts/webkitpy/layout_tests/port/base.py:
  7762. (Port.default_child_processes):
  7763. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  7764. (ChromiumAndroidPort.check_sys_deps):
  7765. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  7766. (ChromiumAndroidPortTest):
  7767. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  7768. (MockDRTPortTest.make_port):
  7769. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  7770. (PortTestCase):
  7771. (PortTestCase.make_port):
  7772. * Scripts/webkitpy/layout_tests/port/test.py:
  7773. (TestPort.default_child_processes):
  7774. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  7775. (_set_up_derived_options):
  7776. (parse_args):
  7777. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  7778. (parse_args):
  7779. (MainTest.test_batch_size):
  7780. (MainTest.test_child_processes_2):
  7781. (MainTest.test_child_processes_min):
  7782. (MainTest.test_exception_raised):
  7783. (MainTest.test_keyboard_interrupt):
  7784. (MainTest.test_exit_after_n_crashes):
  7785. (MainTest.assert_run_order):
  7786. (MainTest.test_run_order__inline):
  7787. (MainTest.test_virtual):
  7788. 2012-03-26 Dirk Pranke <dpranke@chromium.org>
  7789. test-webkitpy: split test-finding code into a different module
  7790. https://bugs.webkit.org/show_bug.cgi?id=82253
  7791. Reviewed by Adam Barth.
  7792. Per suggestion from abarth, this change splits all the
  7793. filesystem-crawling, test-finding code in test-webkitpy out into
  7794. a separate module and switches to using a FileSystem object.
  7795. This makes things much more testable, so we also add tests :).
  7796. We also add a realpath() method to the Filesystem object, since
  7797. test-webkitpy needs that in order to be able to resolve symlinks
  7798. properly to determine whether a file is under a particular tree
  7799. or not.
  7800. * Scripts/webkitpy/common/system/filesystem.py:
  7801. (FileSystem.realpath):
  7802. * Scripts/webkitpy/common/system/filesystem_mock.py:
  7803. (MockFileSystem.realpath):
  7804. * Scripts/webkitpy/test/main.py:
  7805. (Tester.__init__):
  7806. (Tester.add_tree):
  7807. (Tester.run):
  7808. (Tester._run_tests):
  7809. (Tester._log_exception):
  7810. * Scripts/webkitpy/test/test_finder.py: Added.
  7811. (TestDirectoryTree):
  7812. (TestDirectoryTree.__init__):
  7813. (TestDirectoryTree.find_modules):
  7814. (TestDirectoryTree.find_modules.file_filter):
  7815. (TestDirectoryTree.to_module):
  7816. (TestDirectoryTree.clean):
  7817. (TestFinder):
  7818. (TestFinder.__init__):
  7819. (TestFinder.add_tree):
  7820. (TestFinder.additional_paths):
  7821. (TestFinder.clean_trees):
  7822. (TestFinder.is_module):
  7823. (TestFinder.to_module):
  7824. (TestFinder.find_names):
  7825. (TestFinder._exclude):
  7826. * Scripts/webkitpy/test/test_finder_unittest.py: Added.
  7827. (TestFinderTest):
  7828. (TestFinderTest.setUp):
  7829. (TestFinderTest.tearDown):
  7830. (TestFinderTest.test_additional_system_paths):
  7831. (TestFinderTest.test_is_module):
  7832. (TestFinderTest.test_to_module):
  7833. (TestFinderTest.test_clean):
  7834. (TestFinderTest.test_find_names):
  7835. 2012-03-26 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  7836. [jhbuild] Use $MAKE if it is defined to build jhbuild itself.
  7837. https://bugs.webkit.org/show_bug.cgi?id=82209
  7838. Reviewed by Martin Robinson.
  7839. Respecting the $MAKE environment variable when it is defined makes
  7840. building jhbuild more portable, as some platforms may have GNU
  7841. make as gmake, for example.
  7842. * jhbuild/jhbuild-wrapper:
  7843. (install_jhbuild):
  7844. 2012-03-26 Dirk Pranke <dpranke@chromium.org>
  7845. add a Tree abstraction to test-webkitpy to better encapsulate things
  7846. https://bugs.webkit.org/show_bug.cgi?id=82158
  7847. Reviewed by Adam Barth.
  7848. There are no functional changes in this patch, but adding a
  7849. basic abstraction for the trees we are looking in for python
  7850. tests will allow me to add some features later on more easily
  7851. (like ignoring certain directories like webkitpy/thirdparty),
  7852. and it makes things slightly less hard-coded.
  7853. * Scripts/test-webkitpy:
  7854. * Scripts/webkitpy/test/main.py:
  7855. (Tester.__init__):
  7856. (Tester):
  7857. (Tester.add_tree):
  7858. (Tester._parse_args):
  7859. (Tester._configure):
  7860. (Tester.run):
  7861. (Tester._find_modules):
  7862. (Tester._run_tests):
  7863. (Tester._is_module):
  7864. (Tester._log_exception):
  7865. (TestDirectoryTree):
  7866. (TestDirectoryTree.__init__):
  7867. (TestDirectoryTree.find_modules):
  7868. (TestDirectoryTree.clean):
  7869. 2012-03-26 Ojan Vafai <ojan@chromium.org>
  7870. garden-o-matic should special case reftests
  7871. https://bugs.webkit.org/show_bug.cgi?id=81812
  7872. Reviewed by Adam Barth.
  7873. On the examine page, don't show a rebaseline button for reftests.
  7874. We still show it on the failure summary page because tests are grouped
  7875. together. Long-term, we should make sure webkit-patch rebaseline-test
  7876. never tries to rebaseline reftests.
  7877. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  7878. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  7879. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  7880. 2012-03-26 Dirk Pranke <dpranke@chromium.org>
  7881. clean up NRWT logging/metering, be less verbose
  7882. https://bugs.webkit.org/show_bug.cgi?id=73846
  7883. Reviewed by Ojan Vafai.
  7884. Re-land r112014 with a build fix for Python 2.6 compatibility.
  7885. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  7886. (ManagerTest.test_http_locking):
  7887. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  7888. (AbstractWorker.run):
  7889. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  7890. (Worker.__init__):
  7891. (Worker._set_up_logging):
  7892. (Worker):
  7893. (Worker._set_up_host_and_port):
  7894. (Worker.run):
  7895. (Worker.cleanup):
  7896. * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
  7897. (WorkerTest.test_default_platform_in_worker):
  7898. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  7899. (run):
  7900. (main):
  7901. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  7902. (MeteredStream):
  7903. (MeteredStream.implements):
  7904. (MeteredStream._erasure):
  7905. (MeteredStream._ensure_newline):
  7906. (MeteredStream.__init__):
  7907. (MeteredStream.__del__):
  7908. (MeteredStream.cleanup):
  7909. (MeteredStream.write_throttled_update):
  7910. (MeteredStream.write_update):
  7911. (MeteredStream.write):
  7912. (MeteredStream.writeln):
  7913. (MeteredStream._erase_last_partial_line):
  7914. (_LogHandler):
  7915. (_LogHandler.__init__):
  7916. (_LogHandler.emit):
  7917. * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  7918. (RegularTest):
  7919. (RegularTest.setUp):
  7920. (RegularTest.tearDown):
  7921. (RegularTest.time_fn):
  7922. (RegularTest.test_logging_not_included):
  7923. (RegularTest._basic):
  7924. (RegularTest.test_basic):
  7925. (RegularTest._log_after_update):
  7926. (RegularTest.test_log_after_update):
  7927. (TtyTest):
  7928. (TtyTest.test_basic):
  7929. (TtyTest.test_log_after_update):
  7930. (VerboseTest):
  7931. (VerboseTest.test_basic):
  7932. (VerboseTest.test_log_after_update):
  7933. * Scripts/webkitpy/layout_tests/views/printing.py:
  7934. (parse_print_options):
  7935. (Printer.__init__):
  7936. (Printer.cleanup):
  7937. (Printer.print_progress):
  7938. (Printer.print_update):
  7939. (Printer._write):
  7940. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  7941. (Testprinter.get_printer):
  7942. (Testprinter.test_print_progress):
  7943. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  7944. (PerfTestsRunner.__init__):
  7945. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  7946. (test_run_test_pause_before_testing):
  7947. 2012-03-26 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  7948. [jhbuild] Revert $MAKE environment hack introduced in r101929.
  7949. https://bugs.webkit.org/show_bug.cgi?id=82234
  7950. Reviewed by Martin Robinson.
  7951. The problem it was supposedly fixing was fixed in jhbuild itself
  7952. in git revision da8944d8ca987ca48c91b350257a530050406092, so we
  7953. can remove the workaround added to the script.
  7954. * jhbuild/jhbuild-wrapper:
  7955. (install_jhbuild):
  7956. 2012-03-26 Leo Yang <leo.yang@torchmobile.com.cn>
  7957. [BlackBerry] Skeleton code of AsyncFileSystemBlackBerry.cpp
  7958. https://bugs.webkit.org/show_bug.cgi?id=82157
  7959. Reviewed by Rob Buis.
  7960. * Scripts/build-webkit:
  7961. Make ENABLE_FILE_SYSTEM default on for blackberry.
  7962. 2012-03-26 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  7963. [jhbuild] Explicitly disable DTrace when building glib.
  7964. https://bugs.webkit.org/show_bug.cgi?id=82145
  7965. Reviewed by Gustavo Noronha Silva.
  7966. DTrace support is not really needed by WebKit, so disabling it
  7967. helps avoid some build errors on more exotic platforms (such as
  7968. FreeBSD).
  7969. * efl/jhbuild.modules:
  7970. * gtk/jhbuild.modules:
  7971. 2012-03-26 Sheriff Bot <webkit.review.bot@gmail.com>
  7972. Unreviewed, rolling out r111993.
  7973. http://trac.webkit.org/changeset/111993
  7974. https://bugs.webkit.org/show_bug.cgi?id=82184
  7975. It broke layout and API tests and made WTR crash (Requested by
  7976. Ossy on #webkit).
  7977. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  7978. (WTR::PlatformWebView::PlatformWebView):
  7979. 2012-03-25 Kevin Ollivier <kevino@theolliviers.com>
  7980. [wx] Unreviewed build fix. Move WTF to its own static lib build.
  7981. * waf/build/settings.py:
  7982. (common_configure):
  7983. 2012-03-24 Chris Fleizach <cfleizach@apple.com>
  7984. AX: Support solution to handle invalid ax text marker
  7985. https://bugs.webkit.org/show_bug.cgi?id=82023
  7986. Reviewed by Oliver Hunt.
  7987. * DumpRenderTree/AccessibilityUIElement.cpp:
  7988. (indexForTextMarkerCallback):
  7989. (isTextMarkerValidCallback):
  7990. (textMarkerForIndexCallback):
  7991. (AccessibilityUIElement::indexForTextMarker):
  7992. (AccessibilityUIElement::isTextMarkerValid):
  7993. (AccessibilityUIElement::textMarkerForIndex):
  7994. (AccessibilityUIElement::getJSClass):
  7995. * DumpRenderTree/AccessibilityUIElement.h:
  7996. (AccessibilityUIElement):
  7997. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  7998. (AccessibilityUIElement::indexForTextMarker):
  7999. (AccessibilityUIElement::textMarkerForIndex):
  8000. (AccessibilityUIElement::isTextMarkerValid):
  8001. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  8002. (WTR::AccessibilityUIElement::indexForTextMarker):
  8003. (WTR::AccessibilityUIElement::isTextMarkerValid):
  8004. (WTR::AccessibilityUIElement::textMarkerForIndex):
  8005. (WTR):
  8006. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  8007. (AccessibilityUIElement):
  8008. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  8009. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  8010. (WTR):
  8011. (WTR::AccessibilityUIElement::indexForTextMarker):
  8012. (WTR::AccessibilityUIElement::isTextMarkerValid):
  8013. (WTR::AccessibilityUIElement::textMarkerForIndex):
  8014. 2012-03-24 Sheriff Bot <webkit.review.bot@gmail.com>
  8015. Unreviewed, rolling out r112014.
  8016. http://trac.webkit.org/changeset/112014
  8017. https://bugs.webkit.org/show_bug.cgi?id=82138
  8018. Broke SnowLeopard, Chromium and GTK+ bots (Requested by kov on
  8019. #webkit).
  8020. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  8021. (ManagerTest.test_http_locking):
  8022. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  8023. (AbstractWorker.run):
  8024. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  8025. (Worker.__init__):
  8026. (Worker.safe_init):
  8027. (Worker.run):
  8028. (Worker.cleanup):
  8029. * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
  8030. (WorkerTest.test_default_platform_in_worker):
  8031. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  8032. (run):
  8033. (main):
  8034. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  8035. (MeteredStream):
  8036. (MeteredStream.is):
  8037. (MeteredStream.__init__):
  8038. (MeteredStream.write):
  8039. (MeteredStream.update):
  8040. (MeteredStream._overwrite):
  8041. (MeteredStream._reset):
  8042. * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  8043. (TestMeteredStream):
  8044. (TestMeteredStream.test_regular):
  8045. * Scripts/webkitpy/layout_tests/views/printing.py:
  8046. (_configure_logging):
  8047. (_restore_logging):
  8048. (Printer.__init__):
  8049. (Printer.cleanup):
  8050. (Printer.print_progress):
  8051. (Printer.print_update):
  8052. (Printer._write):
  8053. (Printer):
  8054. (Printer._update):
  8055. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  8056. (TestUtilityFunctions.assertEmpty):
  8057. (TestUtilityFunctions):
  8058. (TestUtilityFunctions.assertNotEmpty):
  8059. (TestUtilityFunctions.assertWritten):
  8060. (TestUtilityFunctions.test_configure_logging):
  8061. (Testprinter.get_printer):
  8062. (Testprinter.test_print_progress):
  8063. (Testprinter.test_print_progress.mock_time):
  8064. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  8065. (PerfTestsRunner.__init__):
  8066. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  8067. (test_run_test_pause_before_testing):
  8068. 2012-03-24 Kevin Ollivier <kevino@theolliviers.com>
  8069. [wx] Unreviewed. Fix the build after WTF move.
  8070. * waf/build/build_utils.py:
  8071. (get_excludes):
  8072. (get_excludes_in_dirs):
  8073. * waf/build/settings.py:
  8074. (get_port_excludes):
  8075. (common_configure):
  8076. 2012-03-24 Dirk Pranke <dpranke@chromium.org>
  8077. clean up NRWT logging/metering, be less verbose
  8078. https://bugs.webkit.org/show_bug.cgi?id=73846
  8079. Reviewed by Ojan Vafai.
  8080. This patch totally rewrites the metered_stream module and
  8081. changes the way it and the printing module now interact with the
  8082. logging subsystem.
  8083. The printing module becomes a dumb layout_tests-specific wrapper around
  8084. the metered stream. All of the intelligence of how and when to
  8085. actually write (or erase) lines and how things interact with
  8086. logging moves into the metered stream.
  8087. As of now, anything written to the metered stream *bypasses the
  8088. logging system*. If a logger is passed to the meter constructor,
  8089. the metered stream will also attach a log handler so that all
  8090. messages fed to the logger will also be written to the metered
  8091. stream. This detangles the logic that used to exist where
  8092. sometimes the meter would write to the logger and sometimes the
  8093. logger would write to the meter.
  8094. All of this makes the logic generic and reusable for
  8095. test-webkitpy (coming in another patch). It also helps clarify
  8096. what the mysterious "configure_logging" parameter to the printer
  8097. constructor used to do (that parameter itself is gone now, and
  8098. by default the printer and metered_stream will not ever touch
  8099. the logging system; this makes a bunch of tests less fragile).
  8100. All of the above should produce no user-visible changes.
  8101. However, to also fix the bug in question, we change the message
  8102. format in --verbose mode to %H:%M:%S.%frac %pid %message,
  8103. eliminating the date, file:lineno, and level parameters. I am
  8104. making this change at the same time because it would be
  8105. difficult to write things consistently between the logs and the
  8106. metered stream if we were still logging the file:lineno.
  8107. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  8108. Remove the configure_logging parameter
  8109. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  8110. Use metered stream to configure the logging (we don't need a printer)
  8111. and be careful about when and how we manipulate the log level
  8112. and handlers on the root logger.
  8113. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  8114. Pass in the root logger so that log messages are formatted
  8115. properly, and set the log level outside of any routines called
  8116. by unit tests so as to not interfere.
  8117. * Scripts/webkitpy/layout_tests/views/manager_worker_broker.py:
  8118. remove a duplicate log message.
  8119. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  8120. complete rewrite :).
  8121. * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  8122. complete rewrite :).
  8123. * Scripts/webkitpy/layout_tests/views/printing.py:
  8124. move the logging configuration into metered_stream, and also
  8125. move the "when should I log progress messages" into metered stream.
  8126. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  8127. remove tests that are no longer necessary.
  8128. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  8129. remove the configure_logging parameter.
  8130. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  8131. update the test; since the printer no longer writes to the log,
  8132. we need to check what is written to the regular_output instead.
  8133. (test_run_test_pause_before_testing):
  8134. 2012-03-24 Gustavo Noronha Silva <gns@gnome.org>
  8135. Add myself and Martin Robinson to:
  8136. * GStreamerGraphics
  8137. * GtkWebKit2PublicAPI
  8138. * SoupNetwork
  8139. and to the newly created WebKitGTKTranslations.
  8140. Rubber-stamped by Martin Robinson.
  8141. * Scripts/webkitpy/common/config/watchlist:
  8142. 2012-03-24 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  8143. [Qt][WK2] Implement PageClient::isViewWindowActive()
  8144. https://bugs.webkit.org/show_bug.cgi?id=81143
  8145. Reviewed by Kenneth Rohde Christiansen.
  8146. Fix the WrapperWindow from our PlatformWebView
  8147. so it correctly creates the platform related
  8148. stuff for QWindow, which is not created unless
  8149. QWindow::setVisible() or QWindow::show() are called.
  8150. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  8151. (WTR::PlatformWebView::PlatformWebView):
  8152. 2012-03-23 Dirk Pranke <dpranke@chromium.org>
  8153. nrwt: don't wait for safari to exit before exiting after showing the results file
  8154. https://bugs.webkit.org/show_bug.cgi?id=81845
  8155. Reviewed by Ryosuke Niwa.
  8156. Prior to this change, if you ran new-run-webkit-tests and
  8157. displayed the HTML results file at the end, we would block
  8158. waiting for the user to quit the browser. There doesn't seem to
  8159. be a need for that, and the Chromium ports don't do this.
  8160. Also, update the mac tests to capture the output and be quiet :).
  8161. * Scripts/webkitpy/common/system/executive_mock.py:
  8162. Make popen() testable, implement should_log for it.
  8163. * Scripts/webkitpy/layout_tests/port/mac.py:
  8164. (MacPort.show_results_html_file):
  8165. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  8166. Silence some of the tests via outputcapture.
  8167. 2012-03-23 Gustavo Noronha Silva <gns@gnome.org>
  8168. [GTK] libgcrypt and p11-kit should not be in jhbuild modules
  8169. https://bugs.webkit.org/show_bug.cgi?id=82073
  8170. Reviewed by Martin Robinson.
  8171. * Scripts/webkitdirs.pm:
  8172. (jhbuildConfigurationChanged): new function that isolates the
  8173. jhbuild configuration change checking from the autogen logic.
  8174. (mustReRunAutogen): code for the new function lived here.
  8175. (buildAutotoolsProject): now calls jhbuildConfigurationChanged
  8176. itself, and cleans up the jhbuild root if configuration has
  8177. changed; it also forces autogen to be run in that case, to
  8178. make sure the new libraries are used.
  8179. * gtk/jhbuild.modules: removed libgcrypt and p11-kit.
  8180. * jhbuild/jhbuild-wrapper:
  8181. (ensure_jhbuild): this might be run inside a jhbuild environment,
  8182. in which case aclocal fails when trying to use the now deleted
  8183. aclocal directory in the jhbuild prefix, so work around that.
  8184. 2012-03-23 Ojan Vafai <ojan@chromium.org>
  8185. garden-o-matic scrolls to the top of the page when you click an accordion item
  8186. https://bugs.webkit.org/show_bug.cgi?id=82088
  8187. Reviewed by Adam Barth.
  8188. Check the scroll position and make sure that the clicked accordion item is visible.
  8189. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  8190. 2012-03-23 Dirk Pranke <dpranke@chromium.org>
  8191. LayoutTestHelper could get torn down earlier (mostly to reset color profile)
  8192. https://bugs.webkit.org/show_bug.cgi?id=80567
  8193. Reviewed by Ryosuke Niwa.
  8194. Move clean_up_run to occur right after we finish testing and
  8195. before we start processing the results. Also makes set_up_run()
  8196. and clean_up_run() private since there's no real need for
  8197. callers to be aware of them.
  8198. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  8199. (Manager._set_up_run):
  8200. (Manager.run):
  8201. (Manager._clean_up_run):
  8202. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  8203. (ManagerTest.test_http_locking):
  8204. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  8205. (run):
  8206. 2012-03-23 Dean Jackson <dino@apple.com>
  8207. Disable CSS_SHADERS in Apple builds
  8208. https://bugs.webkit.org/show_bug.cgi?id=81996
  8209. Reviewed by Simon Fraser.
  8210. Default enableCSSShaders to be 0 on all builds that use
  8211. this script. Use the flag to turn it back on.
  8212. * Scripts/build-webkit:
  8213. 2012-03-23 Tony Chang <tony@chromium.org>
  8214. [chromium] rename newwtf target back to wtf
  8215. https://bugs.webkit.org/show_bug.cgi?id=82064
  8216. Reviewed by Adam Barth.
  8217. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  8218. 2012-03-23 Jessie Berlin <jberlin@apple.com>
  8219. Assertion failure in PlatformPasteboardMac constructor causing multiple tests to "crash" on
  8220. the Lion Intel WebKit2 Debug bots.
  8221. https://bugs.webkit.org/show_bug.cgi?id=81012.
  8222. Rubber-stamped by Dan Bernstein.
  8223. Add a step to kill the pasteboard server while we investigate what is causing these
  8224. assertion failures (to get the bots green).
  8225. * BuildSlaveSupport/kill-old-processes:
  8226. 2012-03-22 Martin Robinson <mrobinson@igalia.com>
  8227. [check-webkit-style] Alphabetical sorting errors in headers are reported for the line after the first out of order header
  8228. https://bugs.webkit.org/show_bug.cgi?id=81986
  8229. Reviewed by David Levin.
  8230. Track whether or not errors are filtered in error handlers. If an
  8231. alphabetical sorting error is reported for a header and filtered, try
  8232. reporting it for the other potential source of the error. This ensures
  8233. that the style bot can still find new sorting errors in both potential
  8234. situations:
  8235. #include <foo.h> <-- 1. edited line
  8236. #include <baz.h> <-- 2. edited line
  8237. * Scripts/webkitpy/style/checkers/cpp.py:
  8238. (check_include_line): Potentially report the error for both lines,
  8239. if the first error is filtered.
  8240. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Implement a new style of
  8241. test that allows only reporting errors for certain lines. This verifies that
  8242. when one line of an ordering error is filtered, the error is reported on the
  8243. other line.
  8244. (ErrorCollector.__init__):
  8245. (ErrorCollector.__call__):
  8246. (CppStyleTestBase.perform_lint):
  8247. (CppStyleTestBase.perform_language_rules_check):
  8248. (CppStyleTestBase.assert_language_rules_check):
  8249. (OrderOfIncludesTest.test_check_alphabetical_include_order_errors_reported_for_both_lines):
  8250. Added a new test that verifies that when one line of the two lines of an ordering
  8251. error occur, the error is reported on the other line.
  8252. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py:
  8253. (MockErrorHandler.__call__): Report True because the error is handled.
  8254. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  8255. (ErrorCollector.__call__): Ditto.
  8256. * Scripts/webkitpy/style/checkers/watchlist_unittest.py:
  8257. (MockErrorHandler.__call__): Ditto.
  8258. * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py:
  8259. (TestErrorHandler.__call__): Ditto.
  8260. * Scripts/webkitpy/style/checkers/xml_unittest.py:
  8261. (MockErrorHandler.__call__): Ditto.
  8262. * Scripts/webkitpy/style/error_handlers.py:
  8263. (DefaultStyleErrorHandler.__call__): Report True if the error is handled
  8264. and False if it is filtered.
  8265. 2012-03-23 Patrick Gansterer <paroga@webkit.org>
  8266. Build fix for WinCE after r111778.
  8267. * WinCELauncher/CMakeLists.txt:
  8268. 2012-03-23 Peter Beverloo <peter@chromium.org>
  8269. Unreviewed buildfix for the Chromium Android builder.
  8270. Disable the ImageDiff target for now. Android needs to build this for
  8271. host rather than for target (as other configurations do), but since the
  8272. WTF move the dependency chain got significantly more complicated.
  8273. I'll work out a proper fix in the following bug, but since several
  8274. things are broken due to this, this buildfix should be landed first.
  8275. https://bugs.webkit.org/show_bug.cgi?id=82039
  8276. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  8277. 2012-03-23 Grzegorz Czajkowski <g.czajkowski@samsung.com>
  8278. [EFL][DRT] Implement LayoutTestController's methods related with editing.
  8279. https://bugs.webkit.org/show_bug.cgi?id=80136
  8280. Reviewed by Ryosuke Niwa.
  8281. Implements EFL's LayoutTestController methods e.i. setSmartInsertDeleteEnabled,
  8282. setSelectTrailingWhitespaceEnabled.
  8283. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  8284. (LayoutTestController::setSmartInsertDeleteEnabled):
  8285. (LayoutTestController::setSelectTrailingWhitespaceEnabled):
  8286. 2012-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  8287. Convert hasGrammarMarker to use Internals interface
  8288. https://bugs.webkit.org/show_bug.cgi?id=82004
  8289. Reviewed by Ryosuke Niwa.
  8290. Remove hasGrammarMarker functions, because it is able to work in the
  8291. cross-port way through the Internals interface.
  8292. * DumpRenderTree/LayoutTestController.cpp:
  8293. (LayoutTestController::staticFunctions):
  8294. * DumpRenderTree/LayoutTestController.h:
  8295. (LayoutTestController):
  8296. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  8297. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  8298. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  8299. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  8300. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  8301. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  8302. 2012-03-22 Adam Barth <abarth@webkit.org>
  8303. sync-master-with-upstream creates non-linear git history
  8304. https://bugs.webkit.org/show_bug.cgi?id=82006
  8305. Reviewed by Julien Chaffraix.
  8306. Previously this script would create a merge commit at the HEAD of
  8307. origin/master, causing your fork of WebKit to diverge from upstream.
  8308. The new version of this script pushes directly from upstream to origin
  8309. (without round-tripping through any local branches), avoiding this
  8310. problem.
  8311. * Scripts/sync-master-with-upstream:
  8312. 2012-03-22 Gustavo Noronha Silva <gns@gnome.org>
  8313. Unreviewed build fix. Add knowledge of the WTF project to
  8314. the autotools build system scripts so that build-jsc works
  8315. correctly for GTK+.
  8316. * Scripts/webkitdirs.pm:
  8317. (buildAutotoolsProject): handle the WTF project, build the
  8318. libWTF.la target.
  8319. (buildGtkProject): add WTF to the list of supported projects.
  8320. 2012-03-22 Eric Seidel <eric@webkit.org>
  8321. Make svn-apply re-write JavaScriptCore/wtf to WTF/wtf
  8322. https://bugs.webkit.org/show_bug.cgi?id=81984
  8323. Reviewed by Adam Barth.
  8324. * Scripts/VCSUtils.pm:
  8325. (adjustPathForRecentRenamings):
  8326. 2012-03-22 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  8327. [CMake] Fix build-jsc after r111778 and r111797.
  8328. https://bugs.webkit.org/show_bug.cgi?id=82001
  8329. Reviewed by Filip Pizlo.
  8330. Contrary to the comment in build-jsc, buildCMakeProjectOrExit()
  8331. does return if no error occurred, and build-jsc failed with
  8332. "building not defined for this platform".
  8333. * Scripts/build-jsc: Always exit after caling
  8334. buildCMakeProjectOrExit().
  8335. * Scripts/webkitdirs.pm:
  8336. (buildCMakeProjectOrExit): Return 0 if no error occurred.
  8337. 2012-03-22 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  8338. [CMake] Unreviewed build fix after r111778.
  8339. * DumpRenderTree/efl/CMakeLists.txt: Replace
  8340. ${JAVASCRIPTCORE_DIR}/wtf with ${WTF_DIR}/wtf in the include
  8341. paths.
  8342. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Use the right
  8343. wtf include.
  8344. * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Ditto.
  8345. * WinCELauncher/CMakeLists.txt: Replace ${JAVASCRIPTCORE_DIR}/wtf
  8346. with ${WTF_DIR}/wtf in the include paths.
  8347. 2012-03-22 Filip Pizlo <fpizlo@apple.com>
  8348. Tools/Scripts/build-jsc doesn't work after WTF move
  8349. https://bugs.webkit.org/show_bug.cgi?id=81999
  8350. Reviewed by Eric Seidel.
  8351. For ports that require WTF and JSC to be built as two projects and where
  8352. the machinery to build both does not already exist, teach the tool to do
  8353. so for us.
  8354. * Scripts/build-jsc:
  8355. (buildMyProject):
  8356. 2012-03-22 Ojan Vafai <ojan@chromium.org>
  8357. Fix accidental missing line in r111793.
  8358. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  8359. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  8360. Remove base.values. It was unused and duplicates the builtin Object.values.
  8361. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  8362. Accidentally deleted this line before committing r111793.
  8363. 2012-03-22 Ojan Vafai <ojan@chromium.org>
  8364. Move garden-o-matic progress feedback from non-modal dialogs to a status console anchored to the bottom of the page
  8365. https://bugs.webkit.org/show_bug.cgi?id=81983
  8366. Reviewed by Adam Barth.
  8367. The dialogs get in the way if you are doing multiple rebaselines. Also,
  8368. a number of people didn't realize that you could do multiple rebaselines
  8369. in parallel. A non-modal dialog is just confusing.
  8370. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  8371. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  8372. If we're only rebaselining 1 test, show the test name in the initial message. Otherwise,
  8373. show the number of tests being rebaselined.
  8374. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  8375. Turn MessageBox into StatusArea. StatusArea is a singleton and messages in the StatusArea are grouped
  8376. by ID. That way, the results of each UI action (e.g. clicking rebaseline) are grouped together
  8377. into a single area.
  8378. Once addFinalMessage has been called for all IDs, we show the close button. Clicking close
  8379. also serves to clear all teh content in the StatusArea.
  8380. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  8381. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  8382. 2012-03-22 Tony Chang <tony@chromium.org>
  8383. Unreviewed, fix chromium build after wtf move.
  8384. Only use newwtf, remove references to wtf.
  8385. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  8386. 2012-03-22 Csaba Osztrogonác <ossy@webkit.org>
  8387. Actually move WTF files to their new home
  8388. https://bugs.webkit.org/show_bug.cgi?id=81844
  8389. [Qt] Unreviewed buildfix after r111778.
  8390. * DumpRenderTree/qt/DumpRenderTree.pro:
  8391. 2012-03-22 Dan Bernstein <mitz@apple.com>
  8392. Font fallback in WebKitTestRunner depends on user settings
  8393. https://bugs.webkit.org/show_bug.cgi?id=81978
  8394. Reviewed by Jessie Berlin.
  8395. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  8396. (WTR::InjectedBundle::platformInitialize): Added an AppleLanguages key
  8397. with a value consisting of the array ("en") to the override defaults
  8398. dictionary. This is the same value used in DumpRenderTree, and it
  8399. ensures that font fallback follows a consistent path that is not
  8400. affected by the language preferences of the user running the test.
  8401. 2012-03-22 Andy Estes <aestes@apple.com>
  8402. check-for-inappropriate-objc-class-names should ignore the class defined by libarclite.
  8403. https://bugs.webkit.org/show_bug.cgi?id=81971
  8404. Reviewed by Dan Bernstein.
  8405. Xcode will automatically link ObjC binaries against libarclite in some
  8406. cases, which defines a class called __ARCLite__.
  8407. check-for-inappropriate-objc-class-names shouldn't complain about this
  8408. class name.
  8409. * Scripts/check-for-inappropriate-objc-class-names:
  8410. 2012-03-22 Dirk Pranke <dpranke@chromium.org>
  8411. new-run-webkit-tests blames the wrong test for crashing
  8412. https://bugs.webkit.org/show_bug.cgi?id=81951
  8413. Reviewed by Adam Barth.
  8414. NRWT wasn't extracting the WebProcess pid correct; should've
  8415. used re.search instead of re.match :(. Add more tests!
  8416. * Scripts/webkitpy/layout_tests/port/mac.py:
  8417. (MacPort._get_crash_log):
  8418. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8419. (WebKitDriver.has_crashed):
  8420. (WebKitDriver._check_for_driver_crash):
  8421. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  8422. (WebKitDriverTest.test_no_timeout):
  8423. (WebKitDriverTest):
  8424. (WebKitDriverTest.test_check_for_driver_crash):
  8425. (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess):
  8426. (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.__init__):
  8427. (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.pid):
  8428. (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.name):
  8429. (WebKitDriverTest.test_check_for_driver_crash.FakeServerProcess.has_crashed):
  8430. (WebKitDriverTest.test_check_for_driver_crash.assert_crash):
  8431. 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  8432. [EFL] [DRT] Implement LayoutTestController::markerTextForListItem()
  8433. https://bugs.webkit.org/show_bug.cgi?id=81512
  8434. Adding missing implementation markerTextForListItem to EFL's
  8435. LayoutTestController so that we can unskip related tests from
  8436. the skip list.
  8437. Reviewed by Antonio Gomes.
  8438. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  8439. (LayoutTestController::markerTextForListItem): Implemented.
  8440. 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  8441. [EFL] Enable view mode media feature layout tests
  8442. https://bugs.webkit.org/show_bug.cgi?id=81205
  8443. Adding missing implementation setViewModeMediaFeature to EFL's
  8444. LayoutTestController so that we can unskip view mode
  8445. media feature layout tests.
  8446. Reviewed by Antonio Gomes.
  8447. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  8448. (LayoutTestController::setViewModeMediaFeature): Implemented.
  8449. 2012-03-22 Dirk Pranke <dpranke@chromium.org>
  8450. nrwt: crash while stopping layout test helper on apple mac lion
  8451. https://bugs.webkit.org/show_bug.cgi?id=81949
  8452. Reviewed by Eric Seidel.
  8453. stop_helper() didn't work right if the helper process wasn't
  8454. still running or didn't respond properly to being shut down. Fix
  8455. this and add some tests. Also add code to MockExecutive() to be
  8456. able to mock executive.popen() properly.
  8457. * Scripts/webkitpy/common/system/executive_mock.py:
  8458. (MockProcess.__init__):
  8459. (MockProcess.wait):
  8460. (MockExecutive.__init__):
  8461. (MockExecutive.popen):
  8462. * Scripts/webkitpy/common/system/systemhost_mock.py:
  8463. (MockSystemHost.__init__):
  8464. * Scripts/webkitpy/layout_tests/port/mac.py:
  8465. (MacPort.start_helper):
  8466. (MacPort.stop_helper):
  8467. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  8468. (test_get_crash_log):
  8469. (test_helper_starts):
  8470. (test_helper_fails_to_start):
  8471. (test_helper_fails_to_stop):
  8472. (test_helper_fails_to_stop.bad_waiter):
  8473. 2012-03-22 Gustavo Noronha Silva <gns@gnome.org>
  8474. [GTK] Add make to the jhbuild moduleset
  8475. https://bugs.webkit.org/show_bug.cgi?id=81769
  8476. Reviewed by Martin Robinson.
  8477. Mostly based on a patch by Carlos Garcia Campos <cgarcia@igalia.com>.
  8478. Add GNU make with custom patches to fix several issues:
  8479. - make-3.82-arg-list-length.patch: Patch by Ralf Wildenhues to
  8480. fix the argument list limit of GNU make when running make
  8481. distcheck.
  8482. - make-3.82-parallel-build.patch: Patch by Kamil Mierzejewski
  8483. and Jeremy Devenport to fix parallel build issues present in
  8484. GNU make 3.82
  8485. * gtk/jhbuild.modules: Added make with patches.
  8486. * gtk/patches/make-3.82-arg-list-length.patch: Added.
  8487. * gtk/patches/make-3.82-parallel-build.patch: Added.
  8488. 2012-03-22 Kevin Ollivier <kevino@theolliviers.com>
  8489. [wx] Unreviewed. Adding Source/WTF to the build and updating
  8490. waf port list.
  8491. * DumpRenderTree/wscript:
  8492. * waf/build/settings.py:
  8493. 2012-03-22 Dirk Pranke <dpranke@chromium.org>
  8494. Re-land fix for r81603 yet again (!) with latest build fix.
  8495. https://bugs.webkit.org/show_bug.cgi?id=81603
  8496. Unreviewed, build fix.
  8497. The latest problem was a bad sprintf() in
  8498. BasePort._get_crash_log(). I've reworked that routine and added
  8499. unit tests for coverage.
  8500. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  8501. (SingleTestRunner._handle_error):
  8502. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  8503. (write_test_result):
  8504. (TestResultWriter.write_crash_log):
  8505. * Scripts/webkitpy/layout_tests/port/base.py:
  8506. (Port.diff_text):
  8507. (Port._get_crash_log):
  8508. * Scripts/webkitpy/layout_tests/port/chromium.py:
  8509. (ChromiumDriver.run_test):
  8510. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  8511. (ChromiumDriverTest.test_crash_log):
  8512. * Scripts/webkitpy/layout_tests/port/driver.py:
  8513. (DriverOutput.__init__):
  8514. * Scripts/webkitpy/layout_tests/port/mac.py:
  8515. (MacPort.is_lion):
  8516. (MacPort._get_crash_log):
  8517. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  8518. (test_default_child_processes):
  8519. (test_get_crash_log):
  8520. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  8521. (MockDRTPortTest.test_get_crash_log):
  8522. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  8523. (PortTestCase.test_get_crash_log):
  8524. * Scripts/webkitpy/layout_tests/port/test.py:
  8525. (TestDriver.run_test):
  8526. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8527. (WebKitDriver.__init__):
  8528. (WebKitDriver._start):
  8529. (WebKitDriver.has_crashed):
  8530. (WebKitDriver._check_for_driver_crash):
  8531. (WebKitDriver.run_test):
  8532. 2012-03-22 Alexander Færøy <alexander.faeroy@nokia.com>
  8533. [Qt] Enable support for handling database quota's in the MiniBrowser
  8534. https://bugs.webkit.org/show_bug.cgi?id=81928
  8535. Reviewed by Simon Hausmann.
  8536. * MiniBrowser/qt/qml/BrowserWindow.qml:
  8537. 2012-03-22 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  8538. [EFL] Implement LayoutTestController::setEditingBehavior
  8539. https://bugs.webkit.org/show_bug.cgi?id=81124
  8540. Adding missing implementation setEditingBehavior to EFL's
  8541. LayoutTestController. This implementation allows us to
  8542. unskip some tests from the skip list.
  8543. Reviewed by Martin Robinson.
  8544. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  8545. (LayoutTestController::setEditingBehavior): Implemented.
  8546. 2012-03-22 Carlos Garcia Campos <cgarcia@bb-webkit-rel-64.local.igalia.com>
  8547. [GTK] Use the angle-bracket form to include wtf headers
  8548. https://bugs.webkit.org/show_bug.cgi?id=81884
  8549. Reviewed by Eric Seidel.
  8550. Use #include <wtf/foo> instead of #include "foo".
  8551. * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
  8552. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  8553. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  8554. * DumpRenderTree/gtk/EditingCallbacks.cpp:
  8555. * DumpRenderTree/gtk/WorkQueueItemGtk.cpp:
  8556. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
  8557. 2012-03-22 Alexander Færøy <alexander.faeroy@nokia.com>
  8558. Unreviewed, add Michael Brüning and Allan Jensen to committers.py.
  8559. * Scripts/webkitpy/common/config/committers.py:
  8560. 2012-03-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  8561. [Qt] Enable FAST_MOBILE_SCROLLING when scrolling is delegated.
  8562. https://bugs.webkit.org/show_bug.cgi?id=81889
  8563. Reviewed by Kenneth Rohde Christiansen.
  8564. Enable FAST_MOBILE_SCROLLING feature.
  8565. * qmake/mkspecs/features/features.prf:
  8566. 2012-03-22 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  8567. [EFL] DRT: Do not pass a relative path to DOWNLOADED_FONTS_DIR.
  8568. https://bugs.webkit.org/show_bug.cgi?id=81900
  8569. Reviewed by Gustavo Noronha Silva.
  8570. r111598 added the DOWNLOADED_FONTS_DIR define, but it used a relative
  8571. path which assumed a certain directory structure for the build
  8572. directory which may noy be true.
  8573. Instead, hardcode the path to the downloaded fonts starting from the
  8574. top-level source directory. While this solution is also far from
  8575. perfect, it makes it more consistent and reliable, and easier to
  8576. tackle at once with the rest of bug 81475.
  8577. * DumpRenderTree/efl/CMakeLists.txt:
  8578. 2012-03-22 Carlos Garcia Campos <cgarcia@igalia.com>
  8579. [GTK] Allow to run any jhbuild command with jhbuild-wrapper script
  8580. https://bugs.webkit.org/show_bug.cgi?id=81888
  8581. Reviewed by Philippe Normand.
  8582. * Scripts/update-webkit-libs-jhbuild:
  8583. (runJhbuild): Helper function to run jhbuild with a given command.
  8584. Instead of running jhbuild directly, use the jhbuild-wrapper, so
  8585. that we don't need to run it first to check whether jhbuild is
  8586. installed or not.
  8587. * efl/run-with-jhbuild: Call jhbuild-wrapper with run command.
  8588. * gtk/run-with-jhbuild: Ditto.
  8589. * jhbuild/jhbuild-wrapper: Allow to execute any jhbuild command,
  8590. not only run.
  8591. 2012-03-22 Philippe Normand <pnormand@igalia.com>
  8592. Unreviewed, test-webkitpy fix after r111661.
  8593. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  8594. (MainTest.test_crash_log):
  8595. (MainTest.test_web_process_crash_log):
  8596. 2012-03-22 Philippe Normand <pnormand@igalia.com>
  8597. Unreviewed, test-webkitpy fix after r111642.
  8598. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  8599. (ChromiumDriverTest.setUp):
  8600. (ChromiumDriverTest.test_two_drivers):
  8601. 2012-03-22 Csaba Osztrogonác <ossy@webkit.org>
  8602. webkitpy: clean up actually getting crash logs from DRT/WTR crashes
  8603. https://bugs.webkit.org/show_bug.cgi?id=81603
  8604. Unreviewed rolling out r111609 and part of r111615,
  8605. because it broke NRWT on Qt-WK2 platform.
  8606. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  8607. (SingleTestRunner._handle_error):
  8608. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  8609. (write_test_result):
  8610. (TestResultWriter.write_crash_report):
  8611. * Scripts/webkitpy/layout_tests/port/base.py:
  8612. (Port.is_crash_reporter):
  8613. (Port._driver_class):
  8614. * Scripts/webkitpy/layout_tests/port/chromium.py:
  8615. (ChromiumDriver.run_test):
  8616. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  8617. (ChromiumDriverTest.test_crashed_process_name):
  8618. * Scripts/webkitpy/layout_tests/port/driver.py:
  8619. (DriverOutput.__init__):
  8620. * Scripts/webkitpy/layout_tests/port/mac.py:
  8621. (MacPort):
  8622. (MacPort.is_crash_reporter):
  8623. (MacPort.release_http_lock):
  8624. * Scripts/webkitpy/layout_tests/port/test.py:
  8625. (TestDriver.run_test):
  8626. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8627. (WebKitDriver.__init__):
  8628. (WebKitDriver._start):
  8629. (WebKitDriver.has_crashed):
  8630. (WebKitDriver._check_for_driver_crash):
  8631. (WebKitDriver.run_test):
  8632. 2012-03-22 Csaba Osztrogonác <ossy@webkit.org>
  8633. [Qt] Add full platforms to Qt buildslaves
  8634. https://bugs.webkit.org/show_bug.cgi?id=81877
  8635. Reviewed by Ryosuke Niwa.
  8636. * BuildSlaveSupport/build.webkit.org-config/config.json:
  8637. 2012-03-21 Johnny Ding <jnd@chromium.org>
  8638. Customize layout test timeout value for different ports.
  8639. https://bugs.webkit.org/show_bug.cgi?id=79859
  8640. Reviewed by Ojan Vafai.
  8641. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  8642. (Manager):
  8643. * Scripts/webkitpy/layout_tests/port/base.py:
  8644. (Port.default_test_timeout_ms):
  8645. * Scripts/webkitpy/layout_tests/port/chromium.py:
  8646. (ChromiumDriver.stop):
  8647. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  8648. (ChromiumAndroidPort.default_test_timeout_ms):
  8649. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  8650. (_set_up_derived_options):
  8651. 2012-03-21 Mark Rowe <mrowe@apple.com>
  8652. Fix the build.
  8653. Ensure that our test tools don't try and use RTTI unnecessarily.
  8654. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  8655. * TestWebKitAPI/Configurations/Base.xcconfig:
  8656. * WebKitTestRunner/Configurations/Base.xcconfig:
  8657. 2012-03-21 Adam Barth <abarth@webkit.org>
  8658. WebKit should have some scripts to smooth interactions with GitHub
  8659. https://bugs.webkit.org/show_bug.cgi?id=81842
  8660. Reviewed by Eric Seidel.
  8661. These scripts support the workflow in
  8662. https://trac.webkit.org/wiki/UsingGitHub by automating the
  8663. configuration and syncing operations needed for a GitHub fork of WebKit
  8664. to track the main WebKit repository.
  8665. * Scripts/configure-github-as-upstream: Added.
  8666. * Scripts/sync-master-with-upstream: Added.
  8667. 2012-03-21 Dirk Pranke <dpranke@chromium.org>
  8668. WTR - log the pid of a crashing WebProcess
  8669. https://bugs.webkit.org/show_bug.cgi?id=81575
  8670. Reviewed by Alexey Proskuryakov.
  8671. This allows run-webkit-tests to find the right crash log for a
  8672. given crashed WebProcess in WebKit2.
  8673. * WebKitTestRunner/TestController.cpp:
  8674. (WTR::exceededDatabaseQuota):
  8675. (WTR::TestController::createOtherPage):
  8676. (WTR::TestController::initialize):
  8677. (WTR::TestController::resetStateToConsistentValues):
  8678. (WTR::TestController::runTest):
  8679. (WTR::TestController::processDidCrash):
  8680. 2012-03-21 Enrica Casucci <enrica@apple.com>
  8681. WebKitURLWithTitles pasteboard format should support URLs containing Emoji characters.
  8682. https://bugs.webkit.org/show_bug.cgi?id=81835
  8683. <rdar://problem/11082749>
  8684. Reviewed by Brady Eidson.
  8685. * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html:
  8686. * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
  8687. (TestWebKitAPI::contextMenuCopyLink):
  8688. 2012-03-21 Alexandru Chiculita <achicu@adobe.com>
  8689. [CSS Shaders] Make CSS Shaders compile on Chromium
  8690. https://bugs.webkit.org/show_bug.cgi?id=81435
  8691. Reviewed by Stephen White.
  8692. I've added WebKitCSSCustomFilterEnabled support for the layoutTestController.overridePreference function.
  8693. * DumpRenderTree/chromium/LayoutTestController.cpp:
  8694. (LayoutTestController::overridePreference):
  8695. * DumpRenderTree/chromium/WebPreferences.cpp:
  8696. (WebPreferences::reset):
  8697. (WebPreferences::applyTo):
  8698. * DumpRenderTree/chromium/WebPreferences.h:
  8699. (WebPreferences):
  8700. 2012-03-21 Dirk Pranke <dpranke@chromium.org>
  8701. fix regression on gtk port introduced by r111609
  8702. https://bugs.webkit.org/show_bug.cgi?id=81839
  8703. Reviewed by Philippe Normand.
  8704. r111609 should've initialized a couple of missing fields in
  8705. WebKitDriver, and also should've checked for method overrides
  8706. in the other ports :(.
  8707. * Scripts/webkitpy/layout_tests/port/gtk.py:
  8708. (GtkDriver._start):
  8709. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8710. (WebKitDriver.__init__):
  8711. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  8712. (MainTest.test_crash_log):
  8713. (MainTest.test_web_process_crash_log):
  8714. 2012-03-21 Dirk Pranke <dpranke@chromium.org>
  8715. webkitpy: clean up actually getting crash logs from DRT/WTR crashes
  8716. https://bugs.webkit.org/show_bug.cgi?id=81603
  8717. Reviewed by Adam Barth.
  8718. Add a new _get_crash_log() overridable method on the Port
  8719. object to customize how we fetch crash logs per port.
  8720. Mac will now slow-spin with a timeout waiting for the crash log, rather
  8721. than waiting for the ReportCrash process to exit (it appears
  8722. that the mac will manage multiple crashes with a single
  8723. ReportCrash process, the process waits around longer than
  8724. necessary, presumably to avoid thrashing if processes are
  8725. repeatedly crashing).
  8726. Also, add the DriverOutput should contain the crash log and other info,
  8727. which is created in a port-specific manner but can then be
  8728. treated generically. Previously single_test_runner would get
  8729. told that something crashed and attempt to do something to get
  8730. the crash log, but it didn't have the information it needed to
  8731. od the right thing; better to make the driver hand back the
  8732. right info.
  8733. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  8734. (SingleTestRunner._handle_error):
  8735. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  8736. (write_test_result):
  8737. (TestResultWriter.write_crash_log):
  8738. * Scripts/webkitpy/layout_tests/port/base.py:
  8739. (Port.diff_text):
  8740. (Port._get_crash_log):
  8741. * Scripts/webkitpy/layout_tests/port/chromium.py:
  8742. (ChromiumDriver.run_test):
  8743. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  8744. (ChromiumDriverTest.test_crash_log):
  8745. * Scripts/webkitpy/layout_tests/port/driver.py:
  8746. (DriverOutput.__init__):
  8747. * Scripts/webkitpy/layout_tests/port/mac.py:
  8748. (MacPort.is_lion):
  8749. (MacPort._get_crash_log):
  8750. * Scripts/webkitpy/layout_tests/port/test.py:
  8751. (TestDriver.run_test):
  8752. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8753. (WebKitDriver.__init__):
  8754. (WebKitDriver._start):
  8755. (WebKitDriver.has_crashed):
  8756. (WebKitDriver._check_for_driver_crash):
  8757. (WebKitDriver.run_test):
  8758. 2012-03-21 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  8759. [EFL] Use jhbuild downloaded fonts instead of hardcoded system font paths
  8760. https://bugs.webkit.org/show_bug.cgi?id=81507
  8761. Now that we're only loading from one directory, no need to
  8762. iterate over a list of directories anymore.
  8763. Reviewed by Martin Robinson.
  8764. * DumpRenderTree/efl/CMakeLists.txt:
  8765. * DumpRenderTree/efl/FontManagement.cpp:
  8766. (addFontDirectory):
  8767. (addFontsToEnvironment):
  8768. 2012-03-21 Dirk Pranke <dpranke@chromium.org>
  8769. webkitpy: get ServerProcess out of the reportcrash business
  8770. https://bugs.webkit.org/show_bug.cgi?id=81600
  8771. Unreviewed, build fix.
  8772. Re-land r111307 and r111293 with another fix for a crash in NRWT;
  8773. we need to check if the driver has crashed before attempting to
  8774. read from it.
  8775. * Scripts/webkitpy/layout_tests/port/server_process.py:
  8776. (ServerProcess._reset):
  8777. (ServerProcess._handle_possible_interrupt):
  8778. (ServerProcess.write):
  8779. (ServerProcess.read_stdout):
  8780. (ServerProcess.has_crashed):
  8781. (ServerProcess._read):
  8782. (ServerProcess.stop):
  8783. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  8784. (TrivialMockPort.check_for_leaks):
  8785. (TestServerProcess.test_broken_pipe):
  8786. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8787. (WebKitPort._read_image_diff):
  8788. (WebKitDriver.has_crashed):
  8789. (WebKitDriver._check_for_driver_crash):
  8790. (WebKitDriver.run_test):
  8791. (WebKitDriver._read_block):
  8792. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  8793. (MockServerProcess.__init__):
  8794. (MockServerProcess):
  8795. (MockServerProcess.has_crashed):
  8796. 2012-03-21 Zeno Albisser <zeno@webkit.org>
  8797. [Qt][Mac] ranlib segfaults when creating symbol tables for libWebCore.a.
  8798. https://bugs.webkit.org/show_bug.cgi?id=81750
  8799. Building WebCore on mac currently creates an archive that is bigger than
  8800. 4GB. But ranlib fails to create a symbol table for such a big archive,
  8801. even on 64bit machines.
  8802. Therefore we start using SVGAllInOne.cpp when building debug
  8803. on mac. This reduces the size of the archive by about 300MB.
  8804. Reviewed by Tor Arne Vestbø.
  8805. * qmake/mkspecs/features/mac/default_pre.prf:
  8806. 2012-03-21 Szilard Ledan <szledan@inf.u-szeged.hu>
  8807. Updated the address list of committers.py.
  8808. Reviewed by Csaba Osztrogonác.
  8809. * Scripts/webkitpy/common/config/committers.py:
  8810. 2012-03-21 W. James MacLean <wjmaclean@chromium.org>
  8811. Updating my nick in committers file.
  8812. Unreviewed.
  8813. * Scripts/webkitpy/common/config/committers.py:
  8814. 2012-03-21 Peter Beverloo <peter@chromium.org>
  8815. [Chromium] Remove Android build-fix when the proper fix rolled into WebKit
  8816. https://bugs.webkit.org/show_bug.cgi?id=80861
  8817. Reviewed by Tony Chang.
  8818. Remove most Android-specific logic from webkitdirs.pm in favor of
  8819. handling this during project generation time.
  8820. * Scripts/webkitdirs.pm:
  8821. (buildChromiumMakefile):
  8822. 2012-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
  8823. [GTK] Allow running javascript from location bar in MiniBrowser
  8824. https://bugs.webkit.org/show_bug.cgi?id=81331
  8825. Reviewed by Martin Robinson.
  8826. * MiniBrowser/gtk/BrowserWindow.c:
  8827. (activateUriEntryCallback): Use browser_window_load_uri().
  8828. (browser_window_load_uri): Check whether uri starts with
  8829. javascript: and run the given script, or just call
  8830. webkit_web_view_load_uri() to load the given uri.
  8831. * MiniBrowser/gtk/BrowserWindow.h:
  8832. * MiniBrowser/gtk/main.c:
  8833. (createBrowserWindow): Use browser_window_load_uri().
  8834. 2012-03-21 Carlos Garcia Campos <cgarcia@igalia.com>
  8835. [GTK] Add webkit_web_view_run_javascript() to WebKit2 GTK+
  8836. https://bugs.webkit.org/show_bug.cgi?id=75543
  8837. Reviewed by Martin Robinson.
  8838. * MiniBrowser/gtk/GNUmakefile.am: Add javascriptcore_cppflags to
  8839. MiniBrowser CPP flags.
  8840. 2012-03-20 Eric Seidel <eric@webkit.org>
  8841. Move wtf/Platform.h from JavaScriptCore to Source/WTF/wtf
  8842. https://bugs.webkit.org/show_bug.cgi?id=80911
  8843. Reviewed by Adam Barth.
  8844. Update include paths for Source/WTF.
  8845. * DumpRenderTree/efl/CMakeLists.txt:
  8846. * DumpRenderTree/qt/DumpRenderTree.pro:
  8847. * QtTestBrowser/QtTestBrowser.pro:
  8848. * Scripts/build-webkit: Build Source/WTF on AppleWin as well.
  8849. 2012-03-20 Adam Barth <abarth@webkit.org>
  8850. svn-apply should move inflight patches from WebCore/webaudio to WebCore/Modules/webaudio
  8851. https://bugs.webkit.org/show_bug.cgi?id=81567
  8852. Reviewed by Eric Seidel.
  8853. This temporary measure should help us avoid disrupting the folks
  8854. working on WebAudio when we move the webaudio directory to Modules.
  8855. * Scripts/VCSUtils.pm:
  8856. (adjustPathForRecentRenamings):
  8857. (parseGitDiffHeader):
  8858. (parseSvnDiffHeader):
  8859. 2012-03-20 Dirk Pranke <dpranke@chromium.org>
  8860. Unreviewed, rolling out r111453.
  8861. http://trac.webkit.org/changeset/111453
  8862. https://bugs.webkit.org/show_bug.cgi?id=81600
  8863. still broken
  8864. * Scripts/webkitpy/layout_tests/port/server_process.py:
  8865. (ServerProcess._reset):
  8866. (ServerProcess.handle_interrupt):
  8867. (ServerProcess.write):
  8868. (ServerProcess._check_for_crash):
  8869. (ServerProcess._handle_timeout):
  8870. (ServerProcess._check_for_abort):
  8871. (ServerProcess._read):
  8872. (ServerProcess.stop):
  8873. (ServerProcess):
  8874. (ServerProcess.set_crashed):
  8875. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  8876. (TrivialMockPort.is_crash_reporter):
  8877. (TestServerProcess.test_broken_pipe):
  8878. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8879. (WebKitPort._read_image_diff):
  8880. (WebKitDriver.has_crashed):
  8881. (WebKitDriver._check_for_driver_crash):
  8882. (WebKitDriver):
  8883. (WebKitDriver._detected_crash):
  8884. (WebKitDriver._subprocess_crashed):
  8885. (WebKitDriver._crashed_process_name):
  8886. (WebKitDriver.run_test):
  8887. (WebKitDriver._read_block):
  8888. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  8889. (MockServerProcess.__init__):
  8890. 2012-03-20 Dirk Pranke <dpranke@chromium.org>
  8891. webkitpy: get ServerProcess out of the reportcrash business
  8892. https://bugs.webkit.org/show_bug.cgi?id=81600
  8893. Unreviewed, build fix.
  8894. Re-land r111307 and r111293 with fix for crash in NRWT; I
  8895. was failing to set the crashing process name.
  8896. * Scripts/webkitpy/layout_tests/port/server_process.py:
  8897. (ServerProcess._reset):
  8898. (ServerProcess._handle_possible_interrupt):
  8899. (ServerProcess.write):
  8900. (ServerProcess.read_stdout):
  8901. (ServerProcess.has_crashed):
  8902. (ServerProcess._read):
  8903. (ServerProcess.stop):
  8904. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  8905. (TrivialMockPort.check_for_leaks):
  8906. (TestServerProcess.test_broken_pipe):
  8907. * Scripts/webkitpy/layout_tests/port/webkit.py:
  8908. (WebKitPort._read_image_diff):
  8909. (WebKitDriver.has_crashed):
  8910. (WebKitDriver._check_for_driver_crash):
  8911. (WebKitDriver.run_test):
  8912. (WebKitDriver._read_block):
  8913. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  8914. (MockServerProcess.__init__):
  8915. (MockServerProcess):
  8916. (MockServerProcess.has_crashed):
  8917. 2012-03-20 Tim Horton <timothy_horton@apple.com>
  8918. [mac] Restore color space switching code to run-webkit-tests
  8919. https://bugs.webkit.org/show_bug.cgi?id=80571
  8920. <rdar://problem/11008529>
  8921. Reviewed by Simon Fraser.
  8922. http://trac.webkit.org/changeset/111429 broke tools build on Snow Leopard.
  8923. Use the old CM* API on Snow Leopard, since CGDisplayCreateUUIDFromDisplayID
  8924. didn't exist until Lion.
  8925. * DumpRenderTree/mac/LayoutTestHelper.m:
  8926. (installLayoutTestColorProfile):
  8927. (restoreUserColorProfile):
  8928. 2012-03-20 Adele Peterson <adele@apple.com>
  8929. Update the last test to use EXPECT_WK_STREQ.
  8930. Reviewed by Dan Bernstein.
  8931. * TestWebKitAPI/Tests/mac/AttributedString.mm: (TestWebKitAPI::TEST):
  8932. 2012-03-20 Adele Peterson <adele@apple.com>
  8933. "Attempt to insert nil value " exception when calling attributed string APIs on content with a custom font
  8934. https://bugs.webkit.org/show_bug.cgi?id=81630
  8935. <rdar://problem/10650660>
  8936. Reviewed by Alexey Proskuryakov.
  8937. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  8938. * TestWebKitAPI/Tests/mac/Ahem.ttf: Added.
  8939. * TestWebKitAPI/Tests/mac/AttributedString.mm: Added.
  8940. (-[AttributedStringTest webView:didFinishLoadForFrame:]):
  8941. (TestWebKitAPI):
  8942. (TestWebKitAPI::didFinishLoadForFrame):
  8943. (TestWebKitAPI::TEST):
  8944. * TestWebKitAPI/Tests/mac/attributedStringCustomFont.html: Added.
  8945. 2012-03-20 Eric Seidel <eric@webkit.org>
  8946. Add link on queues.webkit.org to kov's fancy queue-depth graph
  8947. https://bugs.webkit.org/show_bug.cgi?id=81690
  8948. Reviewed by Adam Barth.
  8949. * QueueStatusServer/templates/recentstatus.html:
  8950. 2012-03-20 Tim Horton <timothy_horton@apple.com>
  8951. [mac] Restore color space switching code to run-webkit-tests
  8952. https://bugs.webkit.org/show_bug.cgi?id=80571
  8953. <rdar://problem/11008529>
  8954. Reviewed by Simon Fraser.
  8955. Make use of the layout test helper hooks to restore the Mac system-wide
  8956. color profile switching code. This makes WkTR and DRT results match, and
  8957. causes the main display's color profile to not affect results on Lion.
  8958. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  8959. * DumpRenderTree/mac/LayoutTestHelper.m: Added.
  8960. (installLayoutTestColorProfile):
  8961. (restoreUserColorProfile):
  8962. (simpleSignalHandler):
  8963. (main):
  8964. * Scripts/webkitpy/layout_tests/port/mac.py:
  8965. (MacPort.release_http_lock):
  8966. (MacPort):
  8967. (MacPort._path_to_helper):
  8968. (MacPort.start_helper):
  8969. (MacPort.stop_helper):
  8970. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  8971. (WTR::PlatformWebView::PlatformWebView):
  8972. (WTR::PlatformWebView::windowSnapshotImage):
  8973. 2012-02-24 Darin Fisher <darin@chromium.org>
  8974. Add more Chromium WebKit API reviewers
  8975. https://bugs.webkit.org/show_bug.cgi?id=81576
  8976. Reviewed by Adam Barth and David Levin.
  8977. Simplify watchlist to lump all WebKit API into one.
  8978. * Scripts/webkitpy/common/config/watchlist:
  8979. 2012-03-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  8980. Convert hasSpellingMarker to use Internals interface.
  8981. https://bugs.webkit.org/show_bug.cgi?id=81300
  8982. Reviewed by Ryosuke Niwa.
  8983. Remove hasSpellingMarker functions, because it is able to work in the
  8984. cross-port way through the Internals interface.
  8985. * DumpRenderTree/LayoutTestController.cpp:
  8986. (LayoutTestController::staticFunctions):
  8987. * DumpRenderTree/LayoutTestController.h:
  8988. (LayoutTestController):
  8989. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  8990. * DumpRenderTree/chromium/LayoutTestController.cpp:
  8991. (LayoutTestController::LayoutTestController):
  8992. * DumpRenderTree/chromium/LayoutTestController.h:
  8993. (LayoutTestController):
  8994. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  8995. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  8996. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  8997. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  8998. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  8999. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  9000. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  9001. 2012-03-20 Csaba Osztrogonác <ossy@webkit.org>
  9002. Add new Qt-WK2 performance tester bot to build.webkit.org
  9003. https://bugs.webkit.org/show_bug.cgi?id=80842
  9004. Reviewed by Ryosuke Niwa.
  9005. * BuildSlaveSupport/build.webkit.org-config/config.json:
  9006. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  9007. (RunAndUploadPerfTestsWebKit2):
  9008. (RunAndUploadPerfTestsWebKit2.start):
  9009. (BuildAndPerfTestWebKit2Factory):
  9010. (BuildAndPerfTestWebKit2Factory.__init__):
  9011. (DownloadAndPerfTestWebKit2Factory):
  9012. (DownloadAndPerfTestWebKit2Factory.__init__):
  9013. 2012-03-20 Peter Beverloo <peter@chromium.org>
  9014. [Chromium] Update to Android NDK r7b
  9015. https://bugs.webkit.org/show_bug.cgi?id=81005
  9016. Reviewed by Adam Barth.
  9017. Update to version r7b of the Android NDK, release notes of which are
  9018. available on the following page:
  9019. http://developer.android.com/sdk/ndk/index.html
  9020. * Scripts/update-webkit-chromium:
  9021. 2012-03-20 Csaba Osztrogonác <ossy@webkit.org>
  9022. x86 GCC bug triggers a compilation error in generated copy constructor of CollapsedBorderValue
  9023. https://bugs.webkit.org/show_bug.cgi?id=81502
  9024. Unreviewed.
  9025. * qmake/mkspecs/features/unix/default_post.prf: Reenable Werror after r111171.
  9026. 2012-03-19 Jessie Berlin <jberlin@apple.com>
  9027. Unreviewed; roll out http://trac.webkit.org/changeset/111307 and http://trac.webkit.org/changeset/111293
  9028. because they broke running the layout tests on mac.
  9029. * Scripts/webkitpy/layout_tests/port/webkit.py:
  9030. (WebKitDriver._check_for_driver_crash):
  9031. 2012-03-16 Martin Robinson <mrobinson@igalia.com>
  9032. [GTK] Allow running run-gtk-tests during 'make distcheck'
  9033. https://bugs.webkit.org/show_bug.cgi?id=81415
  9034. Reviewed by Philippe Normand.
  9035. Modify the build and run-gtk-tests so that it can run during 'make distcheck'
  9036. * GNUmakefile.am: Distribute run-gtk-tests during 'make dist' and make it the
  9037. main command run during 'make check.'
  9038. * Scripts/run-gtk-tests: Refactored run-gtk-tests so that jhbuild is no longer
  9039. a requirement to run it. If jhbuild isn't around it will simply not start the
  9040. SPI daemons and skip the WebKit2 accessibility test. Remove test runs from the
  9041. main loop and simply use the main loop in a synchronous method to start SPI
  9042. daemons. Did a bunch of general cleanup around these tasks.
  9043. 2012-03-19 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  9044. jhbuild: Use the multiprocessing module to get the number of CPUs.
  9045. https://bugs.webkit.org/show_bug.cgi?id=81585
  9046. Reviewed by Martin Robinson.
  9047. Now that support for Python 2.5 has been dropped, we can safely
  9048. use multiprocessing.cpu_count() to obtain the current number of
  9049. CPUs in the system instead of running a webkitperl script for
  9050. that.
  9051. * efl/common.py:
  9052. (top_level_path):
  9053. * efl/jhbuildrc:
  9054. * gtk/common.py:
  9055. (build_path):
  9056. * gtk/jhbuildrc:
  9057. 2012-03-19 Ojan Vafai <ojan@chromium.org>
  9058. We should only add a live event listener once, not once per TestSelector.
  9059. Adding one per TestSelector would cause accordion('option', 'active') to
  9060. incorrectly be "false" if you examine multiple sets of tests.
  9061. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  9062. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9063. Fix typo introduced in r111293.
  9064. Unreviewed, build fix.
  9065. * Scripts/webkitpy/layout_tests/port/webkit.py:
  9066. (WebKitDriver._check_for_driver_crash):
  9067. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9068. webkitpy: get ServerProcess out of the reportcrash business
  9069. https://bugs.webkit.org/show_bug.cgi?id=81600
  9070. Reviewed by Adam Barth.
  9071. ServerProcess was half-aware that ReportCrash might run
  9072. sometimes, and that the process ServerProcess was talking to
  9073. might have its own crashing subprocesses; neither of these
  9074. things really worked right and it made the logic convoluted, so
  9075. this change makes handling crashes completely separate from the
  9076. server_process code, so that it can focus on just I/O to the
  9077. subprocess.
  9078. There should be no functional changes resulting from this patch.
  9079. * Scripts/webkitpy/layout_tests/port/server_process.py:
  9080. (ServerProcess._reset):
  9081. (ServerProcess._handle_possible_interrupt):
  9082. (ServerProcess.write):
  9083. (ServerProcess.read_stdout):
  9084. (ServerProcess.has_crashed):
  9085. (ServerProcess._read):
  9086. (ServerProcess.stop):
  9087. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  9088. (TrivialMockPort.check_for_leaks):
  9089. (TestServerProcess.test_broken_pipe):
  9090. * Scripts/webkitpy/layout_tests/port/webkit.py:
  9091. (WebKitPort._read_image_diff):
  9092. (WebKitDriver.has_crashed):
  9093. (WebKitDriver._check_for_driver_crash):
  9094. (WebKitDriver.run_test):
  9095. (WebKitDriver._read_block):
  9096. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  9097. (MockServerProcess.__init__):
  9098. (MockServerProcess):
  9099. (MockServerProcess.has_crashed):
  9100. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9101. webkitpy: crashlog parsing is broken
  9102. https://bugs.webkit.org/show_bug.cgi?id=81586
  9103. Reviewed by Adam Barth.
  9104. Seeking on a file opened through codecs() appears to not work
  9105. correctly (at least on SL).
  9106. The code was more complicated than it needed to be, so I have
  9107. revamped it to just read a full crashlog at once and then look
  9108. for matches.
  9109. I have also added the ability to optionally propagate
  9110. errors back (which can be helpful to debug races when ReportCrash is
  9111. still running and you need to see that you couldn't open some
  9112. files, rather than just ignoring them).
  9113. * Scripts/webkitpy/common/system/crashlogs.py:
  9114. (CrashLogs.find_newest_log):
  9115. (CrashLogs._find_newest_log_darwin):
  9116. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  9117. (CrashLogsTest.test_find_log_darwin):
  9118. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9119. webkitpy: clean up some port._filesystem references to not reference private members
  9120. https://bugs.webkit.org/show_bug.cgi?id=81595
  9121. Reviewed by Eric Seidel.
  9122. There should be no functional changes in this patch, just some
  9123. refactoring. Also, fixes a minor nit in write_image_diff_files(()
  9124. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  9125. (SingleTestRunner.__init__):
  9126. (SingleTestRunner._run_compare_test):
  9127. (SingleTestRunner._run_rebaseline):
  9128. (SingleTestRunner._save_baseline_data):
  9129. (SingleTestRunner._handle_error):
  9130. (SingleTestRunner._run_reftest):
  9131. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  9132. (write_test_result):
  9133. (TestResultWriter.__init__):
  9134. (TestResultWriter._make_output_directory):
  9135. (TestResultWriter.output_filename):
  9136. (TestResultWriter._output_testname):
  9137. (TestResultWriter.write_output_files):
  9138. (TestResultWriter.write_stderr):
  9139. (TestResultWriter.write_crash_report):
  9140. (TestResultWriter.create_text_diff_and_write_result):
  9141. (TestResultWriter.write_image_diff_files):
  9142. (copy_file):
  9143. * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
  9144. (TestResultWriterTest.test_reftest_diff_image):
  9145. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9146. webkitpy: fix nit - incorrect reference to DRT in test_expectations.py
  9147. https://bugs.webkit.org/show_bug.cgi?id=81598
  9148. Reviewed by Eric Seidel.
  9149. "DumpRenderTree" shouldn't be hard-coded here, since some other
  9150. process may actually be crashing (WebKitTestRunner, WebProcess, etc.)
  9151. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  9152. (TestExpectations):
  9153. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9154. webkitpy: allow instance data in TestFailure objects
  9155. https://bugs.webkit.org/show_bug.cgi?id=81580
  9156. Reviewed by Tony Chang.
  9157. Current TestFailures are basically enums, but it would be nice,
  9158. especially for crashes, if they contained the name and pid of
  9159. the process that crashed.
  9160. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  9161. (TestFailure.message):
  9162. (FailureTimeout.message):
  9163. (FailureCrash):
  9164. (FailureCrash.__init__):
  9165. (FailureCrash.message):
  9166. (FailureMissingResult.message):
  9167. (FailureTextMismatch.message):
  9168. (FailureMissingImageHash.message):
  9169. (FailureMissingImage.message):
  9170. (FailureImageHashMismatch.message):
  9171. (FailureImageHashIncorrect.message):
  9172. (FailureReftestMismatch.message):
  9173. (FailureReftestMismatchDidNotOccur.message):
  9174. (FailureReftestNoImagesGenerated.message):
  9175. (FailureMissingAudio.message):
  9176. (FailureAudioMismatch.message):
  9177. * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py:
  9178. (TestFailuresTest.test_equals):
  9179. (TestFailuresTest):
  9180. (TestFailuresTest.test_crashes):
  9181. 2012-03-19 Brady Eidson <beidson@apple.com>
  9182. <rdar://problem/10917120> and https://bugs.webkit.org/show_bug.cgi?id=81066
  9183. Crash in 3rd party WebKit apps under XHR/Cache code
  9184. Reviewed by Antti Koivisto.
  9185. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  9186. * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.html: Added.
  9187. * TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm: Added.
  9188. (-[MemoryCachePruneTestResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
  9189. (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  9190. (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFinishLoadingFromDataSource:]):
  9191. (-[MemoryCachePruneTestResourceLoadDelegate webView:resource:didFailLoadingWithError:fromDataSource:]):
  9192. (TestWebKitAPI):
  9193. (TestWebKitAPI::TEST):
  9194. 2012-03-19 Brady Eidson <beidson@apple.com>
  9195. <rdar://problem/10848575> and https://bugs.webkit.org/show_bug.cgi?id=81516
  9196. REGRESSION (r107435) URLs copied from WebKit apps aren't in the right pasteboard format
  9197. Reviewed by Enrica Casucci.
  9198. Bring up a context menu on a link, copy the link, then verify the pasteboard contents
  9199. are in the correct format.
  9200. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  9201. * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.html: Added.
  9202. * TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm: Added.
  9203. (-[ContextMenuCanCopyURLDelegate webView:didFinishLoadForFrame:]):
  9204. (TestWebKitAPI::contextMenuCopyLink):
  9205. (TestWebKitAPI::TEST):
  9206. 2012-03-19 Ojan Vafai <ojan@chromium.org>
  9207. Make the selected item in the accordion a link to the flakiness dashboard
  9208. https://bugs.webkit.org/show_bug.cgi?id=81571
  9209. Reviewed by Dimitri Glazkov.
  9210. Also, make it so that you can select the text of the link, instead of the current behavior
  9211. of acting as if you had clicked on the accordion header.
  9212. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  9213. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  9214. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9215. NRWT runs some tests that are skipped with -i command line option
  9216. https://bugs.webkit.org/show_bug.cgi?id=81535
  9217. Reviewed by Ojan Vafai.
  9218. This change modifies the interaction of Skipped files and
  9219. test_expectations files so that entries in Skipped files (and
  9220. the -i command line) override *everything* in the expectations
  9221. file.
  9222. Specifically, a directory in a Skipped file will cause all of
  9223. the tests in the dir to be skipped even if individual tests in
  9224. the dir are listed in the test_expectations.txt.
  9225. Skipped files also override anything in an overrides files.
  9226. This seems to make more intuitive sense, since if you list
  9227. something in the Skips file (and even more specify it on the
  9228. command line) you probably want it to be universally applied.
  9229. Theoretically we could add more precedence levels and have full
  9230. paths in an expectations file override dirs in a Skipped file
  9231. (but not the command line), but I don't know yet that that level
  9232. of complexity is justified.
  9233. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  9234. (TestExpectations.__init__):
  9235. (TestExpectations._add_skipped_tests):
  9236. (TestExpectations._add_test):
  9237. (TestExpectations._add_expectations):
  9238. (TestExpectations._add_expectation_line):
  9239. (TestExpectations._already_seen_better_match):
  9240. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  9241. (test_more_specific_override_resets_skip):
  9242. (SkippedTests):
  9243. (SkippedTests.get_exp):
  9244. (SkippedTests.assert_exp):
  9245. (SkippedTests.test_skipped_tests_work):
  9246. (SkippedTests.test_duplicate_skipped_test_fails_lint):
  9247. (SkippedTests.test_skipped_file_overrides_expectations):
  9248. (SkippedTests.test_skipped_dir_overrides_expectations):
  9249. (SkippedTests.test_skipped_file_overrides_overrides):
  9250. (SkippedTests.test_skipped_dir_overrides_overrides):
  9251. 2012-03-19 Eric Seidel <eric@webkit.org>
  9252. Fix WTF header include discipline in Chromium WebKit
  9253. https://bugs.webkit.org/show_bug.cgi?id=81281
  9254. Reviewed by James Robinson.
  9255. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  9256. * Scripts/update-webkit-chromium: Made it possible to run this from a directory other than the root.
  9257. 2012-03-19 Andy Chen <andchen@rim.com>
  9258. [BlackBerry] Add new layout test for text match marker
  9259. https://bugs.webkit.org/show_bug.cgi?id=81531
  9260. Make the LayoutTestControllerBlackBerry::findString to test the
  9261. BlackBerry port implementation.
  9262. Reviewed by Rob Buis.
  9263. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  9264. (LayoutTestController::findString):
  9265. 2012-03-19 Ojan Vafai <ojan@chromium.org>
  9266. Don't show WONTFIX tests in garden-o-matic
  9267. https://bugs.webkit.org/show_bug.cgi?id=81554
  9268. Reviewed by Dimitri Glazkov.
  9269. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  9270. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  9271. 2012-03-19 Chris Fleizach <cfleizach@apple.com>
  9272. platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
  9273. https://bugs.webkit.org/show_bug.cgi?id=81530
  9274. Reviewed by Jessie Berlin.
  9275. Add rowAtIndex to WebKitTestRunner.
  9276. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  9277. (WTR::AccessibilityUIElement::rowAtIndex):
  9278. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  9279. (AccessibilityUIElement):
  9280. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  9281. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  9282. (WTR):
  9283. (WTR::AccessibilityUIElement::rowAtIndex):
  9284. 2012-03-19 Ojan Vafai <ojan@chromium.org>
  9285. Change garden-o-matic All Failures tab to Expected Failures
  9286. https://bugs.webkit.org/show_bug.cgi?id=81540
  9287. Reviewed by Dimitri Glazkov.
  9288. Also, fix some broken unittests that had just gotten stale.
  9289. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  9290. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
  9291. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  9292. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  9293. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  9294. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  9295. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  9296. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  9297. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  9298. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  9299. 2012-03-19 Hao Zheng <zhenghao@chromium.org>
  9300. [chromium] DRT crashes at shutdown.
  9301. https://bugs.webkit.org/show_bug.cgi?id=81504
  9302. Reviewed by James Robinson.
  9303. WebCompositor must be destroyed after WebView is properly destroyed,
  9304. or some compositor objects like CCLayerTreeHost may not be destroyed.
  9305. However, it is really hard to make the destruction order correct
  9306. explicitly in ~TestShell. So move it out to DumpRenderTree.
  9307. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  9308. (main):
  9309. * DumpRenderTree/chromium/TestShell.cpp:
  9310. (TestShell::~TestShell):
  9311. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9312. add dpranke to webkitpy watchlist
  9313. https://bugs.webkit.org/show_bug.cgi?id=81433
  9314. Reviewed by Benjamin Poulain.
  9315. * Scripts/webkitpy/common/config/watchlist:
  9316. 2012-03-19 Dirk Pranke <dpranke@chromium.org>
  9317. test-webkitpy is failing on SL/Python 2.6.1
  9318. https://bugs.webkit.org/show_bug.cgi?id=81533
  9319. Reviewed by Ojan Vafai.
  9320. It appears that itertools.combinations() is buggy in 2.6.1; this
  9321. backports the implementation from 2.7.
  9322. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  9323. (TestConfigurationConverter.collapse_macros):
  9324. (TestConfigurationConverter):
  9325. (TestConfigurationConverter.combinations):
  9326. 2012-03-19 David Michael Barr <davidbarr@google.com>
  9327. Optimize the cleanup sequence in the start-queue.sh script
  9328. https://github.com/abarth/webkit/pull/1
  9329. Reviewed by Adam Barth.
  9330. Updating the working copy is an expensive operation
  9331. for a repository the size of WebKit.
  9332. Attempt to reset only to the target revision.
  9333. * EWSTools/start-queue.sh:
  9334. 2012-03-19 Raphael Kubo da Costa <kubo@profusion.mobi>
  9335. Adjust architecture type of the EFL build bot.
  9336. https://bugs.webkit.org/show_bug.cgi?id=81452
  9337. Reviewed by Tony Chang.
  9338. * BuildSlaveSupport/build.webkit.org-config/config.json: The
  9339. buildslave is a 64-bit machine, therefore describe it as being
  9340. x86_64, not i386.
  9341. 2012-03-19 Alexander Færøy <alexander.faeroy@nokia.com>
  9342. [Qt] printLoadedUrls prints "Object" instead of the actual URL.
  9343. https://bugs.webkit.org/show_bug.cgi?id=81514
  9344. Reviewed by Simon Hausmann.
  9345. * MiniBrowser/qt/qml/BrowserWindow.qml:
  9346. 2012-03-19 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  9347. [EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
  9348. https://bugs.webkit.org/show_bug.cgi?id=81491
  9349. Reviewed by Philippe Normand.
  9350. For the find_path(), find_library() etc CMake calls to find the
  9351. dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
  9352. set, otherwise CMake cannot know the dependencies exist and will only
  9353. look in the standard directories.
  9354. * efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
  9355. the jhbuild Root directory.
  9356. 2012-03-19 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  9357. [EFL] Add XDG env vars to jhbuildrc
  9358. https://bugs.webkit.org/show_bug.cgi?id=81510
  9359. Needed to ensure correct glib behaviour in jhbuild environment.
  9360. Reviewed by Philippe Normand.
  9361. * efl/jhbuildrc:
  9362. 2012-03-19 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  9363. Select best target for tap gesture.
  9364. https://bugs.webkit.org/show_bug.cgi?id=78801
  9365. Reviewed by Kenneth Rohde Christiansen.
  9366. Add TOUCH_ADJUSTMENT to enabled features.
  9367. * qmake/mkspecs/features/features.prf:
  9368. 2012-03-19 Robert Kroeger <rjkroege@chromium.org>
  9369. [chromium] synthesize wheel events for fling on main thread
  9370. https://bugs.webkit.org/show_bug.cgi?id=81458
  9371. Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.
  9372. Reviewed by James Robinson.
  9373. * DumpRenderTree/chromium/EventSender.cpp:
  9374. (EventSender::EventSender):
  9375. (EventSender::gestureFlingCancel):
  9376. (EventSender::gestureFlingStart):
  9377. * DumpRenderTree/chromium/EventSender.h:
  9378. (EventSender):
  9379. 2012-03-19 Alexander Færøy <alexander.faeroy@nokia.com>
  9380. [Qt] Add command line option to set the user agent in the MiniBrowser
  9381. https://bugs.webkit.org/show_bug.cgi?id=81508
  9382. Reviewed by Simon Hausmann.
  9383. * MiniBrowser/qt/BrowserWindow.cpp:
  9384. (BrowserWindow::BrowserWindow):
  9385. (BrowserWindow::webViewExperimental):
  9386. * MiniBrowser/qt/BrowserWindow.h:
  9387. (BrowserWindow):
  9388. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  9389. (printHelp):
  9390. (MiniBrowserApplication::handleUserOptions):
  9391. * MiniBrowser/qt/MiniBrowserApplication.h:
  9392. (WindowOptions::WindowOptions):
  9393. (WindowOptions::setUserAgent):
  9394. (WindowOptions::userAgent):
  9395. (WindowOptions):
  9396. 2012-03-19 Alexander Færøy <alexander.faeroy@nokia.com>
  9397. [Qt] Remove dead user agent code from the MiniBrowser.
  9398. Reviewed by Simon Hausmann.
  9399. * MiniBrowser/qt/BrowserWindow.cpp:
  9400. * MiniBrowser/qt/BrowserWindow.h:
  9401. (BrowserWindow):
  9402. * MiniBrowser/qt/MiniBrowser.qrc:
  9403. * MiniBrowser/qt/useragentlist.txt: Removed.
  9404. 2012-03-19 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  9405. jhbuild: Call jhbuild's autogen.sh via bash.
  9406. https://bugs.webkit.org/show_bug.cgi?id=81485
  9407. Reviewed by Philippe Normand.
  9408. jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
  9409. this is usually true only on Linux systems, and even then bash for
  9410. some reason might not be available in that location. It is safer to
  9411. call bash directly and pass autogen.sh to it instead.
  9412. * jhbuild/jhbuild-wrapper:
  9413. (install_jhbuild):
  9414. 2012-03-19 Philippe Normand <pnormand@igalia.com>
  9415. [GTK] Prefix run-launcher with run-with-jhbuild
  9416. https://bugs.webkit.org/show_bug.cgi?id=81503
  9417. Reviewed by Hajime Morita.
  9418. * Scripts/run-launcher:
  9419. 2012-03-19 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  9420. [EFL] Prefix run-launcher with run-with-jhbuild
  9421. https://bugs.webkit.org/show_bug.cgi?id=80026
  9422. Reviewed by Hajime Morita.
  9423. * Scripts/run-launcher:
  9424. 2012-03-18 Csaba Osztrogonác <ossy@webkit.org>
  9425. [Qt] Unreviewed. Disable -Werror on x86 until proper fix.
  9426. https://bugs.webkit.org/show_bug.cgi?id=81498
  9427. * qmake/mkspecs/features/unix/default_post.prf:
  9428. 2012-03-17 Raphael Kubo da Costa <rakuco@FreeBSD.org>
  9429. Unreviewed; switch to using my FreeBSD.org email address, the
  9430. other one is going to disappear soon.
  9431. * Scripts/webkitpy/common/config/committers.py:
  9432. * Scripts/webkitpy/common/config/watchlist:
  9433. 2012-03-17 Raphael Kubo da Costa <kubo@profusion.mobi>
  9434. Unreviewed; fix webkitpy unit test failures after r111116.
  9435. It turns out that cmd_line in the patch in bug 80025 had the right
  9436. signature when it was submitted, but r109242 added a few more
  9437. required parameters, and since the method (and EflDriver) did not
  9438. exist at the time we ended up committing a broken method.
  9439. * Scripts/webkitpy/layout_tests/port/efl.py:
  9440. (EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
  9441. arguments.
  9442. 2012-03-17 Charles Wei <charles.wei@torchmobile.com.cn>
  9443. [BlackBerry] Enable Web Timing for performance profiling and improvement.
  9444. https://bugs.webkit.org/show_bug.cgi?id=81085
  9445. Reviewed by Rob Buis.
  9446. * Scripts/build-webkit:
  9447. 2012-03-17 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  9448. Add a dependencies installation step for EFL to buildbot master.cfg
  9449. https://bugs.webkit.org/show_bug.cgi?id=81337
  9450. Reviewed by Gustavo Noronha Silva.
  9451. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  9452. (InstallEflDependencies):
  9453. (Factory.__init__):
  9454. 2012-03-17 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  9455. [EFL] Prefixing run-webkit-tests with run-with-jhbuild
  9456. https://bugs.webkit.org/show_bug.cgi?id=80025
  9457. Reviewed by Gustavo Noronha Silva.
  9458. * Scripts/webkitpy/layout_tests/port/efl.py:
  9459. (EflDriver):
  9460. (EflDriver.cmd_line):
  9461. (EflPort._driver_class):
  9462. 2012-03-17 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  9463. [EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
  9464. https://bugs.webkit.org/show_bug.cgi?id=79904
  9465. build-webkit --efl will use jhbuild for fetching and building dependencies.
  9466. Reviewed by Gustavo Noronha Silva.
  9467. * Scripts/update-webkitefl-libs: Added.
  9468. * Scripts/webkitdirs.pm:
  9469. (jhbuildWrapperPrefixIfNeeded):
  9470. (generateBuildSystemFromCMakeProject):
  9471. (buildCMakeGeneratedProject):
  9472. * efl/common.py: Added.
  9473. (script_path):
  9474. (top_level_path):
  9475. (number_of_cpus):
  9476. * efl/jhbuild.modules: Added.
  9477. * efl/jhbuildrc: Added.
  9478. * efl/run-with-jhbuild: Added.
  9479. 2012-03-16 Stephanie Lewis <slewis@apple.com>
  9480. https://bugs.webkit.org/show_bug.cgi?id=81065
  9481. <rdar://problem/10944309> CrashTracer: [USER] 111 crashes in WebProcess at WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::done + 142
  9482. Fix crash preventing WebKitTestRunner from working in Release.
  9483. WebKitTestRunner used ostringstream to collect output from the test. ostringstream is incompatible with our
  9484. FastMalloc overrides. When copying strings out ostringstream a new string is allocated with FastMalloc because
  9485. the allocation is inlined. When that string is freed is uses the system malloc because that call is not inlined.
  9486. I removed ostringstream in favor of StringBuilder.
  9487. Properly set NDEBUG on Release builds so we don't crash when when we free the strings StringBuilder created.
  9488. Reviewed by Geoff Garen.
  9489. Add DEBUG_DEFINES to set NDEBUG on release builds.
  9490. * WebKitTestRunner/Configurations/Base.xcconfig:
  9491. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  9492. Remove ostringstream member in favor of StringBuilder.
  9493. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  9494. (WTR::InjectedBundle::initialize):
  9495. (WTR::InjectedBundle::beginTesting):
  9496. (WTR::InjectedBundle::done):
  9497. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  9498. (WTF):
  9499. (WTR::InjectedBundle::stringBuilder):
  9500. (InjectedBundle):
  9501. Append output to StringBuilder.
  9502. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  9503. (WTR::hasPrefix):
  9504. (WTR::dumpPath):
  9505. (WTR::rangeToStr):
  9506. (WTR::styleDecToStr):
  9507. (WTR::frameToStr):
  9508. (WTR::dumpFrameScrollPosition):
  9509. (WTR::dumpFrameText):
  9510. (WTR::dumpDescendantFramesText):
  9511. (WTR::InjectedBundlePage::dump):
  9512. (WTR::InjectedBundlePage::didReceiveTitleForFrame):
  9513. (WTR::InjectedBundlePage::didFinishDocumentLoadForFrame):
  9514. (WTR::InjectedBundlePage::willSendRequestForFrame):
  9515. (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
  9516. (WTR::lastFileURLPathComponent):
  9517. (WTR::InjectedBundlePage::willAddMessageToConsole):
  9518. (WTR::InjectedBundlePage::willSetStatusbarText):
  9519. (WTR::InjectedBundlePage::willRunJavaScriptAlert):
  9520. (WTR::InjectedBundlePage::willRunJavaScriptConfirm):
  9521. (WTR::InjectedBundlePage::willRunJavaScriptPrompt):
  9522. (WTR::InjectedBundlePage::shouldBeginEditing):
  9523. (WTR::InjectedBundlePage::shouldEndEditing):
  9524. (WTR::InjectedBundlePage::shouldInsertNode):
  9525. (WTR::InjectedBundlePage::shouldInsertText):
  9526. (WTR::InjectedBundlePage::shouldDeleteRange):
  9527. (WTR::InjectedBundlePage::shouldChangeSelectedRange):
  9528. (WTR::InjectedBundlePage::shouldApplyStyle):
  9529. (WTR::InjectedBundlePage::didBeginEditing):
  9530. (WTR::InjectedBundlePage::didEndEditing):
  9531. (WTR::InjectedBundlePage::didChange):
  9532. (WTR::InjectedBundlePage::didChangeSelection):
  9533. (WTR::InjectedBundlePage::supportsFullScreen):
  9534. (WTR::InjectedBundlePage::enterFullScreenForElement):
  9535. (WTR::InjectedBundlePage::exitFullScreenForElement):
  9536. (WTR::InjectedBundlePage::beganEnterFullScreen):
  9537. (WTR::InjectedBundlePage::beganExitFullScreen):
  9538. (WTR::dumpBackForwardListItem):
  9539. (WTR::InjectedBundlePage::dumpBackForwardList):
  9540. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  9541. (WTR::LayoutTestController::waitToDumpWatchdogTimerFired):
  9542. (WTR::LayoutTestController::dumpConfigurationForViewport):
  9543. Convert between WTF::String and WKStringRef.
  9544. * WebKitTestRunner/StringFunctions.h:
  9545. (WTR::toWTFString):
  9546. (WTR):
  9547. * WebKitTestRunner/TestInvocation.cpp:
  9548. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  9549. 2012-03-16 Eric Seidel <eric@webkit.org>
  9550. Add a land-from-url command
  9551. https://bugs.webkit.org/show_bug.cgi?id=81411
  9552. Reviewed by Adam Barth.
  9553. Very basic so far. The goal is to make it landing smarter
  9554. so that users don't have to bother to parse out the ids out of the urls.
  9555. * Scripts/webkitpy/common/config/urls.py:
  9556. (parse_bug_id):
  9557. (parse_attachment_id):
  9558. * Scripts/webkitpy/common/config/urls_unittest.py:
  9559. (URLsTest.test_parse_bug_id):
  9560. (URLsTest):
  9561. (URLsTest.test_parse_attachment_id):
  9562. * Scripts/webkitpy/tool/commands/download.py:
  9563. (ProcessURLsMixin):
  9564. (ProcessURLsMixin._fetch_list_of_patches_to_process):
  9565. (LandFromURL):
  9566. * Scripts/webkitpy/tool/commands/download_unittest.py:
  9567. (test_land_from_bug):
  9568. (test_land_from_url):
  9569. 2012-03-16 Dave Tharp <dtharp@codeaurora.org>
  9570. build-webkit launcher instructions use wrong relative path for Qt
  9571. https://bugs.webkit.org/show_bug.cgi?id=81357
  9572. Reviewed by Eric Seidel.
  9573. Ensure we are at the proper directory before generating run-launcher
  9574. instructions.
  9575. * Scripts/build-webkit:
  9576. 2012-03-16 Brady Eidson <beidson@apple.com>
  9577. <rdar://problem/11027997> and https://bugs.webkit.org/show_bug.cgi?id=81412
  9578. REGRESSION (r107435) Copy a link and paste to Mail: Nothing is pasted
  9579. Reviewed by Geoff Garen.
  9580. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  9581. * TestWebKitAPI/Tests/mac/WebViewCanPasteURL.mm: Added.
  9582. 2012-03-16 Ojan Vafai <ojan@chromium.org>
  9583. Mark wontfix tests in full_results.json so we can ignore them in garden-o-matic
  9584. https://bugs.webkit.org/show_bug.cgi?id=81407
  9585. Reviewed by Adam Barth.
  9586. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  9587. (summarize_results):
  9588. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  9589. (ResultSummaryTest.summarized_results):
  9590. (ResultSummaryTest.test_no_svn_revision):
  9591. (ResultSummaryTest.test_svn_revision):
  9592. (ResultSummaryTest):
  9593. (ResultSummaryTest.test_summarized_results_wontfix):
  9594. 2012-03-16 Ojan Vafai <ojan@chromium.org>
  9595. Have webkit-patch rebaseline-test update test_expectations.txt
  9596. https://bugs.webkit.org/show_bug.cgi?id=81054
  9597. Recommit http://trac.webkit.org/changeset/110783 now that
  9598. http://trac.webkit.org/changeset/111034 has landed.
  9599. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  9600. (TestExpectations.remove_configuration_from_test):
  9601. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  9602. (RemoveConfigurationsTest):
  9603. (RemoveConfigurationsTest.test_remove):
  9604. (test_remove_line):
  9605. * Scripts/webkitpy/tool/commands/rebaseline.py:
  9606. (RebaselineTest._update_expectations_file):
  9607. (RebaselineTest._rebaseline_test_and_update_expectations):
  9608. (RebaselineTest):
  9609. (RebaselineTest.execute):
  9610. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  9611. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  9612. (test_rebaseline_updates_expectations_file):
  9613. 2012-03-15 Ojan Vafai <ojan@chromium.org>
  9614. Specifier collapsing when writing test expectations lines gets a number of cases wrong
  9615. https://bugs.webkit.org/show_bug.cgi?id=81309
  9616. Reviewed by Dimitri Glazkov.
  9617. I've run this over all the lines in the current Chromium test_expectations.txt file,
  9618. so I'm relatively confident we now cover all the cases.
  9619. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  9620. (TestConfigurationConverter.__init__):
  9621. (TestConfigurationConverter.collapse_macros):
  9622. (TestConfigurationConverter.collapse_macros.collapse_individual_specifier_set):
  9623. (TestConfigurationConverter):
  9624. (TestConfigurationConverter.intersect_combination):
  9625. (TestConfigurationConverter.symmetric_difference):
  9626. (TestConfigurationConverter.to_specifiers_list):
  9627. (TestConfigurationConverter.to_specifiers_list.try_collapsing):
  9628. (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
  9629. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  9630. (make_mock_all_test_configurations_set):
  9631. (TestConfigurationConverterTest.test_symmetric_difference):
  9632. (TestConfigurationConverterTest.test_to_config_set):
  9633. (TestConfigurationConverterTest.test_macro_expansion):
  9634. (TestConfigurationConverterTest.test_to_specifier_lists):
  9635. (TestConfigurationConverterTest.test_converter_macro_collapsing):
  9636. * Scripts/webkitpy/layout_tests/port/chromium.py:
  9637. (ChromiumPort):
  9638. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  9639. (ChromiumAndroidPort.__init__):
  9640. The android port uses "arm" as it's architecture, which is technically correct,
  9641. but considerably complicates making collapsing work. We probably should kill
  9642. the concept of architecture entirely. The benefits are not worth the code
  9643. complexity.
  9644. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  9645. (ChromiumPortTest.test_all_test_configurations):
  9646. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  9647. (TestRebaseline.test_rebaseline_updates_expectations_file_noop):
  9648. (test_rebaseline_updates_expectations_file):
  9649. 2012-03-16 Dinu Jacob <dinu.jacob@nokia.com>
  9650. [Qt][Wk2] Assertion Failure and crash on file upload
  9651. https://bugs.webkit.org/show_bug.cgi?id=80854
  9652. Reviewed by Simon Hausmann.
  9653. Added filePicker to WebView using experimental API.
  9654. * MiniBrowser/qt/MiniBrowser.qrc:
  9655. * MiniBrowser/qt/icons/folder.png: Added.
  9656. * MiniBrowser/qt/icons/titlebar.png: Added.
  9657. * MiniBrowser/qt/icons/up.png: Added.
  9658. * MiniBrowser/qt/qml/BrowserWindow.qml:
  9659. * MiniBrowser/qt/qml/FilePicker.qml: Added.
  9660. 2012-03-16 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  9661. Updating email for committer.py script.
  9662. * Scripts/webkitpy/common/config/committers.py:
  9663. 2012-03-16 Robert Kroeger <rjkroege@chromium.org>
  9664. [chromium] DRT: Add support for sending gesture scrolls without a begin
  9665. https://bugs.webkit.org/show_bug.cgi?id=81292
  9666. Reviewed by Kent Tamura.
  9667. * DumpRenderTree/chromium/EventSender.cpp:
  9668. (EventSender::EventSender):
  9669. (EventSender::gestureScrollFirstPoint):
  9670. * DumpRenderTree/chromium/EventSender.h:
  9671. (EventSender):
  9672. 2012-03-02 Carlos Garcia Campos <cgarcia@igalia.com> and Sergio Villar Senin <svillar@igalia.com>
  9673. [GTK] WebKitIconDatabase doesn't keep icons cached
  9674. https://bugs.webkit.org/show_bug.cgi?id=56200
  9675. Reviewed by Martin Robinson.
  9676. Add support for favicons in GtkLauncher.
  9677. * GtkLauncher/main.c:
  9678. (activateUriEntryCb):
  9679. (iconLoadedCb):
  9680. (createBrowser):
  9681. 2012-03-16 Adam Barth <abarth@webkit.org>
  9682. Remove sheriff-bot's last-green-revision command
  9683. https://bugs.webkit.org/show_bug.cgi?id=81314
  9684. Reviewed by Eric Seidel.
  9685. This command is a cruel joke. WebKit doesn't really ever have a
  9686. last-green-revision.
  9687. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  9688. (BuildBot._find_green_revision):
  9689. * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
  9690. (MockBuildBot.builder_statuses):
  9691. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  9692. (test_find_green_revision):
  9693. * Scripts/webkitpy/tool/bot/irc_command.py:
  9694. (IRCCommand.execute):
  9695. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  9696. (SheriffIRCBotTest.test_help):
  9697. * Scripts/webkitpy/tool/commands/queries.py:
  9698. (PatchesToReview.execute):
  9699. 2012-03-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  9700. [Qt] Make gccdepends test aware of broken icecream deps generation
  9701. Icecream seems to build the files without passing -o to gcc with
  9702. the original destination path, which means the target name in the
  9703. dependency file is wrong.
  9704. Also, echo something to the final file instead of just touching it,
  9705. so it's not deleted on every build.
  9706. Reviewed by Simon Hausmann.
  9707. * qmake/config.tests/gccdepends/gccdepends.pro:
  9708. 2012-03-16 Kihong Kwon <kihong.kwon@samsung.com>
  9709. Support for Battery Status API
  9710. https://bugs.webkit.org/show_bug.cgi?id=62698
  9711. Add include directory and file.
  9712. http://www.w3.org/TR/battery-status/
  9713. Reviewed by Adam Barth.
  9714. * Scripts/build-webkit:
  9715. 2012-03-16 Kishore Bolisetty <kbolisetty@innominds.com>
  9716. check-webkit-style fails on LayoutTests/platform/efl/test_expectations.txt
  9717. https://bugs.webkit.org/show_bug.cgi?id=81007
  9718. Reviewed by Adam Barth.
  9719. A dedidcated build slave is available for efl on build.webkit.org.
  9720. This change add's an entry for the elf port in list of available port builders.
  9721. This is required because test_expectations.py when triggered, looks for a valid port object for the specified port.
  9722. * Scripts/webkitpy/layout_tests/port/builders.py:
  9723. 2012-03-16 Adam Barth <abarth@webkit.org>
  9724. [webkitpy] StatusServer.next_work_item has an incorrectly named local variable
  9725. https://bugs.webkit.org/show_bug.cgi?id=81302
  9726. Reviewed by Eric Seidel.
  9727. This is a trivial patch, but the variable name turned up in a grep of
  9728. webkitpy and looks like copy pasta.
  9729. * Scripts/webkitpy/common/net/statusserver.py:
  9730. (StatusServer.next_work_item):
  9731. 2012-03-16 Andrew Lo <anlo@rim.com>
  9732. [BlackBerry] Enable PAGE_VISIBILITY_API
  9733. https://bugs.webkit.org/show_bug.cgi?id=81257
  9734. Enable Page Visibility API for BlackBerry.
  9735. Reviewed by Rob Buis.
  9736. * Scripts/build-webkit:
  9737. 2012-03-16 Zan Dobersek <zandobersek@gmail.com>
  9738. [Gtk] Add computedStyleIncludingVisitedInfo to DumpRenderTreeSupport
  9739. https://bugs.webkit.org/show_bug.cgi?id=81232
  9740. Reviewed by Philippe Normand.
  9741. Use the newly-added helper method in DumpRenderTreeSupportGtk.
  9742. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  9743. (LayoutTestController::computedStyleIncludingVisitedInfo):
  9744. 2012-03-15 Eric Seidel <eric@webkit.org>
  9745. Move parse_bug_id into config/urls in preparation for re-use elsewhere.
  9746. https://bugs.webkit.org/show_bug.cgi?id=81313
  9747. Reviewed by Adam Barth.
  9748. * Scripts/webkitpy/common/checkout/changelog.py:
  9749. (parse_bug_id_from_changelog):
  9750. * Scripts/webkitpy/common/config/urls.py:
  9751. (parse_bug_id):
  9752. * Scripts/webkitpy/common/config/urls_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/urls.py.
  9753. (URLsTest):
  9754. (URLsTest.test_parse_bug_id):
  9755. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  9756. (test_parse_bug_id):
  9757. * Scripts/webkitpy/tool/bot/irc_command.py:
  9758. (_post_error_and_check_for_bug_url):
  9759. * Scripts/webkitpy/tool/bot/sheriff.py:
  9760. (Sheriff.post_rollout_patch):
  9761. (Sheriff.post_chromium_deps_roll):
  9762. 2012-03-15 Adam Barth <abarth@webkit.org>
  9763. The commit-queue should fast-track patches that have already passed the testing EWS bots
  9764. https://bugs.webkit.org/show_bug.cgi?id=81305
  9765. Reviewed by Eric Seidel.
  9766. If a patch has already passed the testing EWS bots (currently only the
  9767. chromium-ews bot), we should be able to land the patch without running
  9768. the tests again. This patch is somewhat risky in that the tests might
  9769. have been broken between when the EWS bots ran and when the
  9770. commit-queue is processing the patch. If that turns out to be a
  9771. problem in practice, we'll tighten up this fast-track in some way,
  9772. likely by making sure that the pass status is recent.
  9773. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  9774. (CommitQueueTaskDelegate.did_pass_testing_ews):
  9775. (CommitQueueTask._did_pass_tests_recently):
  9776. (CommitQueueTask.run):
  9777. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  9778. (MockCommitQueue.did_pass_testing_ews):
  9779. (test_fast_success_case):
  9780. * Scripts/webkitpy/tool/commands/queues.py:
  9781. (CommitQueue.did_pass_testing_ews):
  9782. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  9783. (test_did_pass_testing_ews):
  9784. 2012-03-15 Kentaro Hara <haraken@chromium.org>
  9785. [PerformanceTests] run-perf-tests should output correct units
  9786. https://bugs.webkit.org/show_bug.cgi?id=78303
  9787. Reviewed by Ryosuke Niwa.
  9788. Previously run-perf-tests just supported "ms" for units.
  9789. Consequently, Dromaeo perf tests had been reporting runs/s as "ms".
  9790. This patch fixes run-perf-tests so that they can support custom units.
  9791. The default unit is "ms".
  9792. The test result looks like this:
  9793. $ ./Tools/Scripts/run-perf-tests Dromaeo/dom-attr.html
  9794. RESULT Dromaeo: dom-attr= 6465.9525483 runs/s
  9795. median= 0.0 runs/s, stdev= 24.2983433436 runs/s, min= 6435.87649402 runs/s, max= 6515.63693392 runs/s
  9796. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  9797. (PerfTestsRunner._process_parser_test_result):
  9798. 2012-03-15 Brent Fulgham <bfulgham@webkit.org>
  9799. [WinCairo] Unreviewed build change after wtf path changes.
  9800. * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Updated include
  9801. directories to look at the private header directory to find 'wtf'.
  9802. 2012-03-15 Kent Tamura <tkent@chromium.org>
  9803. REGRESSION(r110595): webkit-patch suggest-reviewers doesn't work
  9804. https://bugs.webkit.org/show_bug.cgi?id=81293
  9805. Reviewed by Adam Barth.
  9806. r110595 introduced new format of the author field of ChangeLog entry:
  9807. "Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>"
  9808. Updte chanelog.py to support it.
  9809. * Scripts/webkitpy/common/checkout/changelog.py:
  9810. (ChangeLogEntry._split_contributor_names):
  9811. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  9812. (test_parse_authors):
  9813. 2012-03-15 Lynn Neir <lynn.neir@skype.net>
  9814. Implement LayoutTestController::setValueForUser on Windows https://bugs.webkit.org/show_bug.cgi?id=55834
  9815. Implemented setValueForUser in both DumpRenderTree and WebKitTestRunner.
  9816. Reviewed by Jessie Berlin.
  9817. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  9818. (LayoutTestController::setValueForUser):
  9819. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  9820. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  9821. (WTR::LayoutTestController::setValueForUser):
  9822. (WTR):
  9823. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  9824. (LayoutTestController):
  9825. 2012-03-15 Adam Barth <abarth@webkit.org>
  9826. Update the start-queue.sh script to match what we're using on the bots
  9827. https://bugs.webkit.org/show_bug.cgi?id=81277
  9828. Reviewed by Eric Seidel.
  9829. Over time we've added more magic git commands to clean up the local repo after
  9830. it has been borked in various ways. The idea behind this sequence is to clear
  9831. out any changes in the working copy and then to rebuild the master branch from
  9832. origin/master.
  9833. This patch also removes the watchdog timer that we've stopped using on the
  9834. bots.
  9835. This patch was reviewed on <https://github.com/eseidel/webkit/pull/1>.
  9836. Note: Eric and I are experimenting with GitHub to see if it might be
  9837. useful for WebKit. If you have thoughts on this topic, please feel
  9838. free to grab Eric or me on #webkit to chat. I assume that he and I are
  9839. the only ones who care about this file so using this alternative
  9840. process for this patch shouldn't cause any trouble.
  9841. * EWSTools/start-queue.sh:
  9842. 2012-03-15 Adam Barth <abarth@webkit.org>
  9843. The commit-queue can hang when the test_expectations.txt style check fails during commit
  9844. https://bugs.webkit.org/show_bug.cgi?id=81251
  9845. Reviewed by Eric Seidel.
  9846. We forgot to check the --non-interactive flag, so we end up prompting
  9847. the "user" who doesn't exist on the bot. We might consider teaching
  9848. the User class about non-interactive if we have this sort of bug again.
  9849. * Scripts/webkitpy/tool/steps/commit.py:
  9850. (Commit.options):
  9851. (Commit._check_test_expectations):
  9852. (Commit.run):
  9853. * Scripts/webkitpy/tool/steps/commit_unittest.py:
  9854. (CommitTest.test_check_test_expectations):
  9855. 2012-03-15 Jessie Berlin <jberlin@apple.com>
  9856. fast/dom/Window/window-properties.html and fast/dom/prototype-inheritance-2.html failing on
  9857. Mac WK2 because WebAudio is not enabled
  9858. https://bugs.webkit.org/show_bug.cgi?id=81259
  9859. Reviewed by Dan Bernstein.
  9860. Enable WebAudio so that it appears in the window object in the tests.
  9861. The webaudio tests are all still skipped in the Mac Skipped list.
  9862. * WebKitTestRunner/TestController.cpp:
  9863. (WTR::TestController::resetStateToConsistentValues):
  9864. 2012-03-15 David Levin <levin@chromium.org>
  9865. Various autoresize fixes.
  9866. https://bugs.webkit.org/show_bug.cgi?id=81199
  9867. Reviewed by Darin Fisher.
  9868. * DumpRenderTree/chromium/LayoutTestController.cpp:
  9869. (LayoutTestController::reset): Stop using the deprecated api that was removed.
  9870. 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
  9871. [GTK] Actually use --release and --debug command line options in run-gtk-test
  9872. https://bugs.webkit.org/show_bug.cgi?id=81234
  9873. Reviewed by Philippe Normand.
  9874. Actually handle --release and --debug command line options to
  9875. create the build directory, falling back to current hack to detect
  9876. whether it's a Release or Debug build when both options are missed.
  9877. * Scripts/run-gtk-tests:
  9878. (TestRunner.__init__): Receive options too.
  9879. (TestRunner._get_top_level_directory): Helper function to get the
  9880. top level directory.
  9881. (TestRunner._get_build_directory): Helper function to get the
  9882. build directory depending on --release/--debug command line
  9883. options or gessing it if both options are missing.
  9884. (TestRunner._ensure_accessibility_daemon_is_running): Use
  9885. self-options now.
  9886. (TestRunner.run): Ditto.
  9887. (TestRunner.run.run_tests): Pass options to the constructor
  9888. instead of run().
  9889. 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
  9890. [GTK] Run unit tests with --verbose in the bots
  9891. https://bugs.webkit.org/show_bug.cgi?id=81230
  9892. Reviewed by Martin Robinson.
  9893. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  9894. (RunGtkAPITests): Add --verbose to run-gtk-test command.
  9895. 2012-03-15 Kevin Ollivier <kevino@theolliviers.com>
  9896. Move wx port to using export macros
  9897. https://bugs.webkit.org/show_bug.cgi?id=77279
  9898. Reviewed by Hajime Morita.
  9899. * waf/build/settings.py:
  9900. (common_configure):
  9901. 2012-03-15 Philippe Normand <pnormand@igalia.com>
  9902. Unreviewed, GTK build fix attempt after r110845.
  9903. * Scripts/run-gtk-tests: Added --release and --debug options.
  9904. 2012-03-15 Dominik Röttsches <dominik.rottsches@linux.intel.com>
  9905. Parametrize run-with-jhbuild and update-webkitgtk-libs with platform --gtk/--efl
  9906. https://bugs.webkit.org/show_bug.cgi?id=79673
  9907. Preparatory work for bringing jhbuild enabled build to EFL port.
  9908. Reviewed by Philippe Normand.
  9909. * Scripts/update-webkit-libs-jhbuild: Copied from Tools/Scripts/update-webkitgtk-libs.
  9910. * Scripts/update-webkitgtk-libs:
  9911. * gtk/run-with-jhbuild:
  9912. * jhbuild/jhbuild-wrapper: Copied from Tools/gtk/run-with-jhbuild.
  9913. (top_level_path):
  9914. (jhbuild_installed):
  9915. (jhbuild_cloned):
  9916. (jhbuild_at_expected_revision):
  9917. (update_jhbuild):
  9918. (clone_jhbuild):
  9919. (install_jhbuild):
  9920. (update_webkit_libs_jhbuild):
  9921. (determine_platform):
  9922. (ensure_jhbuild):
  9923. 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
  9924. [GTK] Add command line options to run-gtk-tests script
  9925. https://bugs.webkit.org/show_bug.cgi?id=81218
  9926. Reviewed by Philippe Normand.
  9927. Following command line options have been added:
  9928. -v, --verbose: to run gtester with --verbose. That would be used
  9929. by the bots to make it easier to know which test case it failing.
  9930. --display: to use a different display for Xvfb
  9931. It's also possible to pass one or more tests as arguments.
  9932. * Scripts/run-gtk-tests:
  9933. (TestRunner.__init__): Receive command line arguments.
  9934. (TestRunner._get_tests): Get all the tests or the ones passed by
  9935. command line arguments.
  9936. (TestRunner._ensure_accessibility_daemon_is_running): Use display
  9937. command line argument.
  9938. (TestRunner.run): Pas command line options.
  9939. (TestRunner.run.run_tests): Pass command line arguments.
  9940. 2012-03-15 Carlos Garcia Campos <cgarcia@igalia.com>
  9941. [GTK] WebKit2APITests/TestPrinting timeout in the bots
  9942. https://bugs.webkit.org/show_bug.cgi?id=81211
  9943. Reviewed by Philippe Normand.
  9944. Add gtk+ patch to fix timeout in the bots. A similar patch has
  9945. already landed in updatream gtk+, see
  9946. http://git.gnome.org/browse/gtk+/commit/?id=5ebfad5d091f4c9d9c6e60364fad4c60842f027f
  9947. * gtk/jhbuild.modules:
  9948. * gtk/patches/gtk+-3.0.12-gtkprinter.patch: Added.
  9949. 2012-03-14 Gustavo Noronha Silva <gns@gnome.org>
  9950. sheriffbot should also be addressable with a comma in addition to colon
  9951. https://bugs.webkit.org/show_bug.cgi?id=81101
  9952. Reviewed by Adam Barth.
  9953. * Scripts/webkitpy/common/net/irc/ircbot.py:
  9954. (IRCBot.on_pubmsg):
  9955. 2012-03-15 Alexander Færøy <alexander.faeroy@nokia.com>
  9956. [Qt] MiniBrowser scroll indicators should not scroll out of view
  9957. https://bugs.webkit.org/show_bug.cgi?id=81131
  9958. Reviewed by Kenneth Rohde Christiansen.
  9959. * MiniBrowser/qt/qml/ScrollIndicator.qml:
  9960. 2012-03-14 Chris Fleizach <cfleizach@apple.com>
  9961. AX: ARIA tables need to support selected rows attribute/select rows changed notification
  9962. https://bugs.webkit.org/show_bug.cgi?id=79821
  9963. Reviewed by Beth Dakin.
  9964. * DumpRenderTree/AccessibilityUIElement.cpp:
  9965. (rowAtIndexCallback):
  9966. (AccessibilityUIElement::getJSClass):
  9967. * DumpRenderTree/AccessibilityUIElement.h:
  9968. (AccessibilityUIElement):
  9969. * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
  9970. (AccessibilityUIElement::rowAtIndex):
  9971. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  9972. (AccessibilityUIElement::rowAtIndex):
  9973. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  9974. (AccessibilityUIElement::rowAtIndex):
  9975. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  9976. (AccessibilityUIElement::rowAtIndex):
  9977. 2012-03-14 Tim Horton <timothy_horton@apple.com>
  9978. NRWT should respect --additional-platform-directory's Skipped list
  9979. https://bugs.webkit.org/show_bug.cgi?id=81172
  9980. Reviewed by Timothy Hatcher.
  9981. Respect the Skipped file inside all paths included via the --additional-platform-directory option. Test results
  9982. from said path are already used, but the Skipped file is ignored.
  9983. * Scripts/webkitpy/layout_tests/port/webkit.py:
  9984. (WebKitPort._skipped_file_search_paths):
  9985. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  9986. (test_skipped_file_search_paths):
  9987. 2012-03-14 Ojan Vafai <ojan@chromium.org>
  9988. Unreviewed, rolling out r110783.
  9989. http://trac.webkit.org/changeset/110783
  9990. https://bugs.webkit.org/show_bug.cgi?id=81054
  9991. Caused existing test expectation lines to expand to one for
  9992. each test configuration.
  9993. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  9994. (TestExpectations.has_warnings):
  9995. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  9996. (test_macro_overrides):
  9997. * Scripts/webkitpy/tool/commands/rebaseline.py:
  9998. (RebaselineTest._save_baseline):
  9999. (RebaselineTest._rebaseline_test):
  10000. (RebaselineTest.execute):
  10001. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  10002. (TestRebaseline.test_tests_to_update):
  10003. 2012-03-13 Jon Lee <jonlee@apple.com>
  10004. Separate NOTIFICATIONS and LEGACY_NOTIFICATIONS
  10005. https://bugs.webkit.org/show_bug.cgi?id=80922
  10006. <rdar://problem/11035082>
  10007. Reviewed by Jian Li.
  10008. You can include either NOTIFICATIONS or LEGACY_NOTIFICATIONS and have a complete API.
  10009. LEGACY_NOTIFICATIONS should cover all of the previous functionality, and NOTIFICATIONS will cover the
  10010. new API. Therefore, APIs that are common between the two will have:
  10011. #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
  10012. This patch initially sets both to be exactly the same. As other bugs with patches begin to migrate to
  10013. the new API, the defines will begin to split. This allows ports to decide which set of APIs to include.
  10014. Update everything to be #if ENABLE(NOTIFICATIONS) || ENABLE(LEGACY_NOTIFICATIONS)
  10015. * DumpRenderTree/chromium/LayoutTestController.cpp:
  10016. (LayoutTestController::grantDesktopNotificationPermission):
  10017. (LayoutTestController::simulateDesktopNotificationClick):
  10018. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  10019. * DumpRenderTree/chromium/TestShell.cpp:
  10020. (TestShell::TestShell):
  10021. (TestShell::resetTestController):
  10022. * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  10023. (DRTDesktopNotificationPresenter::checkNotificationPermission):
  10024. 2012-03-13 Ojan Vafai <ojan@chromium.org>
  10025. Have webkit-patch rebaseline-test update test_expectations.txt
  10026. https://bugs.webkit.org/show_bug.cgi?id=81054
  10027. Reviewed by Dirk Pranke.
  10028. This will allow us to use the All Failures tab in garden-o-matic
  10029. to rebaseline tests without making test_expectations.txt stale.
  10030. It's conservative and only removes lines if the test is
  10031. not flaky and fails in a way the rebaseline would fix (e.g.
  10032. CRASH/TIMEOUT will not be touched).
  10033. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  10034. (TestExpectations.remove_configuration_from_test):
  10035. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  10036. (RemoveConfigurationsTest):
  10037. (RemoveConfigurationsTest.test_remove):
  10038. (test_remove_line):
  10039. * Scripts/webkitpy/tool/commands/rebaseline.py:
  10040. (RebaselineTest._is_supported_port):
  10041. (RebaselineTest):
  10042. (RebaselineTest._update_expectations_file):
  10043. (RebaselineTest._rebaseline_test_and_update_expectations):
  10044. (RebaselineTest.execute):
  10045. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  10046. (TestRebaseline.test_rebaseline_updates_expectations_file):
  10047. 2012-03-14 Jessie Berlin <jberlin@apple.com>
  10048. Crash in WKTR under addChromeInputField due to using 0 as a key in a HashMap
  10049. https://bugs.webkit.org/show_bug.cgi?id=81167
  10050. Reviewed by Sam Weinig.
  10051. Do not use 0 as a key in a HashMap.
  10052. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  10053. cacheLayoutTestControllerCallback uses the enum as keys for the callback map.
  10054. 2012-03-14 Ojan Vafai <ojan@chromium.org>
  10055. Add the chromium lion bot to garden-o-matic and remove
  10056. the platform_move_to in builders.py since the Chromium Lion
  10057. port is now a normal port.
  10058. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  10059. * Scripts/webkitpy/layout_tests/port/builders.py:
  10060. 2012-03-14 Dirk Pranke <dpranke@chromium.org>
  10061. Fix regression/crash introduced in r110724 - bad type passed from skipped_tests() by default.
  10062. Unreviewed, build fix.
  10063. * Scripts/webkitpy/layout_tests/port/base.py:
  10064. (Port.skipped_tests):
  10065. 2012-03-14 Dirk Pranke <dpranke@chromium.org>
  10066. Please add a way to manually skip some tests in NRWT
  10067. https://bugs.webkit.org/show_bug.cgi?id=81019
  10068. Reviewed by Ojan Vafai.
  10069. This patch implements the -i / --ignore-tests flag from ORWT
  10070. and refactors the test_expectations.py code slightly to handle
  10071. it.
  10072. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  10073. (Manager.parse_expectations):
  10074. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  10075. (TestExpectations.__init__):
  10076. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  10077. (test_add_skipped_tests):
  10078. (test_add_skipped_tests_duplicate):
  10079. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  10080. (parse_args):
  10081. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  10082. (MainTest.test_ignore_tests):
  10083. (MainTest.test_ignore_tests.assert_ignored):
  10084. 2012-03-14 Dirk Pranke <dpranke@chromium.org>
  10085. nrwt: run with no args on lion, is putting baselines in platform/mac-lion, not platform/mac
  10086. https://bugs.webkit.org/show_bug.cgi?id=81028
  10087. Reviewed by Ojan Vafai.
  10088. The mac port had incorrect lookups for 'mac-lion' and
  10089. 'mac-future' in some places. This patch fixes that and adds a
  10090. bunch of tests.
  10091. * Scripts/webkitpy/layout_tests/port/mac.py:
  10092. (MacPort.baseline_path):
  10093. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  10094. (MacTest.assert_skipped_file_search_paths):
  10095. (MacTest.test_skipped_file_search_paths):
  10096. (_assert_search_path):
  10097. (test_baseline_search_path):
  10098. * Scripts/webkitpy/layout_tests/port/webkit.py:
  10099. (WebKitPort._skipped_file_search_paths):
  10100. 2012-03-13 Jer Noble <jer.noble@apple.com>
  10101. Lion Intel Debug WebKit2 Tests crashing under [WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]
  10102. https://bugs.webkit.org/show_bug.cgi?id=81056
  10103. Reviewed by Jessie Berlin.
  10104. Intercept beganEnterFullScreen and beganExitFullScreen and turn them into no-ops (plus logging).
  10105. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  10106. (WTR::InjectedBundlePage::InjectedBundlePage):
  10107. (WTR::InjectedBundlePage::beganEnterFullScreen):
  10108. (WTR::InjectedBundlePage::beganExitFullScreen):
  10109. 2012-03-14 Alexander Færøy <alexander.faeroy@nokia.com>
  10110. The width and height of the scroll indicators in the MiniBrowser does
  10111. not consider the offset margins.
  10112. https://bugs.webkit.org/show_bug.cgi?id=81112
  10113. Reviewed by Kenneth Rohde Christiansen.
  10114. This patch fixes the issue by withdrawing two times the anchor
  10115. margins.
  10116. * MiniBrowser/qt/qml/ScrollIndicator.qml:
  10117. 2012-03-14 Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com>
  10118. [EFL] Implement LayoutTestController::clearBackForwardList
  10119. https://bugs.webkit.org/show_bug.cgi?id=80142
  10120. Adding missing implementation clearBackForwardList to EFL's
  10121. LayoutTestController. This implementation allows us to unskip
  10122. tests connected with history.
  10123. Reviewed by Antonio Gomes.
  10124. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  10125. (LayoutTestController::clearBackForwardList): Implemented.
  10126. 2012-03-13 Thiago Marcos P. Santos <thiago.santos@intel.com>
  10127. [EFL][DRT] Expose window.internals object
  10128. https://bugs.webkit.org/show_bug.cgi?id=79900
  10129. Exposes window.internals for EFL's DRT. Makes possible to
  10130. remove some tests from the skip list.
  10131. Reviewed by Antonio Gomes.
  10132. * DumpRenderTree/efl/CMakeLists.txt:
  10133. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  10134. (DumpRenderTreeChrome::onWindowObjectCleared):
  10135. 2012-03-13 Adam Barth <abarth@webkit.org> && Benjamin Poulain <bpoulain@apple.com>
  10136. Always enable ENABLE(CLIENT_BASED_GEOLOCATION)
  10137. https://bugs.webkit.org/show_bug.cgi?id=78853
  10138. Reviewed by Adam Barth.
  10139. * Scripts/build-webkit:
  10140. * qmake/mkspecs/features/features.prf:
  10141. 2012-03-12 Antonio Gomes <agomes@rim.com>
  10142. Convert nodesFromRect tests to use Internals interface
  10143. https://bugs.webkit.org/show_bug.cgi?id=80886
  10144. Reviewed by Ryosuke Niwa.
  10145. This clean up allows to remove port specific bits of each
  10146. DRT implementation that supports testing Document::nodesFromRect,
  10147. in favor of making use of the 'Internals' interface to test it.
  10148. This makes its code conveniently more expansible and cleaner.
  10149. Also removed stubs from Win and EFL DRTs.
  10150. * DumpRenderTree/LayoutTestController.cpp:
  10151. (LayoutTestController::staticFunctions):
  10152. * DumpRenderTree/LayoutTestController.h:
  10153. (LayoutTestController):
  10154. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  10155. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  10156. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  10157. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  10158. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  10159. (LayoutTestController):
  10160. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  10161. 2012-03-13 Ojan Vafai <ojan@chromium.org>
  10162. Rebaselining for a new port doesn't work right with multiple fallback ports
  10163. https://bugs.webkit.org/show_bug.cgi?id=80932
  10164. Reviewed by Adam Barth.
  10165. Since chromium-leopard also falls back to mac-leopard, we need to
  10166. copy the existing result for both chromium-leopard and chromium-snowleopard
  10167. before doing lion rebaselines.
  10168. * Scripts/webkitpy/layout_tests/port/builders.py:
  10169. (fallback_port_names_for_new_port):
  10170. * Scripts/webkitpy/tool/commands/rebaseline.py:
  10171. (RebaselineTest):
  10172. (RebaselineTest._copy_existing_baseline):
  10173. (RebaselineTest._rebaseline_test):
  10174. (RebaselineTest.execute):
  10175. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  10176. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  10177. (GardeningHTTPRequestHandler.rebaseline):
  10178. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  10179. (GardeningServerTest.test_rebaseline_new_port):
  10180. 2012-03-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  10181. [Qt] Tweak minibrowser UI
  10182. Add some margins to the scroll indicators, and set a dark background
  10183. color so you see the page dimensions.
  10184. Reviewed by Antonio Gomes.
  10185. * MiniBrowser/qt/qml/BrowserWindow.qml:
  10186. * MiniBrowser/qt/qml/ScrollIndicator.qml:
  10187. 2012-03-13 ChangSeok Oh <shivamidow@gmail.com>
  10188. [EFL] [DRT] Implement scheduleAsynchronousKeyDown.
  10189. https://bugs.webkit.org/show_bug.cgi?id=79601
  10190. Reviewed by Gustavo Noronha Silva.
  10191. Extracted shareable code from keyDownCallback and then added createKeyEventInfo.
  10192. createKeyEventInfo creates a new structure KeyEventInfo that has keyName and modifiers
  10193. and is taken over to sendKeyDown.
  10194. Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
  10195. and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
  10196. * DumpRenderTree/efl/EventSender.cpp:
  10197. (KeyEventInfo::KeyEventInfo):
  10198. (KeyEventInfo):
  10199. (createKeyEventInfo):
  10200. (sendKeyDown):
  10201. (keyDownCallback):
  10202. (sendAsynchronousKeyDown):
  10203. (scheduleAsynchronousKeyDownCallback):
  10204. 2012-03-12 Ojan Vafai <ojan@chromium.org>
  10205. webkit-patch optimize-baselines sometimes creates a mac-future result
  10206. https://bugs.webkit.org/show_bug.cgi?id=80717
  10207. Reviewed by Adam Barth.
  10208. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  10209. (_baseline_search_hypergraph):
  10210. (BaselineOptimizer._find_optimal_result_placement):
  10211. (BaselineOptimizer._filter_virtual_ports):
  10212. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  10213. (BaselineOptimizerTest.test_no_add_mac_future):
  10214. 2012-03-12 Jessie Berlin <jberlin@apple.com>
  10215. More Windows build fixing.
  10216. * DumpRenderTree/win/WorkQueueItemWin.cpp:
  10217. 2012-03-12 Jessie Berlin <jberlin@apple.com>
  10218. More Windows build fixing.
  10219. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  10220. * DumpRenderTree/win/EditingDelegate.cpp:
  10221. * DumpRenderTree/win/EventSender.cpp:
  10222. * DumpRenderTree/win/FrameLoadDelegate.cpp:
  10223. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  10224. * DumpRenderTree/win/UIDelegate.cpp:
  10225. 2012-03-12 Dirk Pranke <dpranke@chromium.org>
  10226. remove the 'gpu' group from the flakiness dashboard
  10227. https://bugs.webkit.org/show_bug.cgi?id=80353
  10228. Reviewed by Adam Barth.
  10229. Since those bots are obsolete, we don't need this any more.
  10230. * TestResultServer/static-dashboards/builders.js:
  10231. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  10232. (testPlatformAndBuildType):
  10233. (testHtmlForTestTypeSwitcherGroup):
  10234. 2012-03-12 Dirk Pranke <dpranke@chromium.org>
  10235. remove graphics_type from webkitpy.layout_tests.models.test_configuration
  10236. https://bugs.webkit.org/show_bug.cgi?id=80643
  10237. Reviewed by Ojan Vafai.
  10238. Now that the chromium-gpu ports are gone, there's no need for
  10239. the graphics_type CPU/GPU distinction. Most of this change is
  10240. just updating tests accordingly.
  10241. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  10242. (TestExpectationEditorTests):
  10243. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  10244. (TestConfiguration.__init__):
  10245. (TestConfiguration.category_order):
  10246. (TestConfiguration.__str__):
  10247. (TestConfiguration.__repr__):
  10248. (TestConfiguration.__hash__):
  10249. (TestConfigurationConverter.to_specifiers_list):
  10250. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  10251. (make_mock_all_test_configurations_set):
  10252. (TestConfigurationTest.test_items):
  10253. (TestConfigurationTest.test_keys):
  10254. (TestConfigurationTest.test_str):
  10255. (TestConfigurationTest.test_repr):
  10256. (TestConfigurationTest.test_hash):
  10257. (TestConfigurationTest.test_hash.query_unknown_key):
  10258. (TestConfigurationTest.test_eq):
  10259. (TestConfigurationTest.test_values):
  10260. (SpecifierSorterTest.test_specifier_priority):
  10261. (SpecifierSorterTest.test_sort_specifiers):
  10262. (TestConfigurationConverterTest.test_to_config_set):
  10263. (TestConfigurationConverterTest.test_macro_expansion):
  10264. (TestConfigurationConverterTest.test_to_specifier_lists):
  10265. (TestConfigurationConverterTest.test_converter_macro_collapsing):
  10266. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  10267. (test_error_on_different_build_type):
  10268. (TestExpectationSerializerTests.test_parsed_to_string):
  10269. (TestExpectationSerializerTests.test_reconstitute_only_these):
  10270. * Scripts/webkitpy/layout_tests/port/apple.py:
  10271. (ApplePort._generate_all_test_configurations):
  10272. * Scripts/webkitpy/layout_tests/port/base.py:
  10273. (Port.__init__):
  10274. (Port.name):
  10275. (Port.version):
  10276. (Port.test_configuration):
  10277. * Scripts/webkitpy/layout_tests/port/builders.py:
  10278. * Scripts/webkitpy/layout_tests/port/chromium.py:
  10279. (ChromiumPort):
  10280. (ChromiumPort._generate_all_test_configurations):
  10281. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  10282. (ChromiumLinuxPort.__init__):
  10283. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  10284. (ChromiumLinuxPortTest.test_check_illegal_port_names):
  10285. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  10286. (ChromiumMacPortTest.test_baseline_path):
  10287. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  10288. (ChromiumPortTest.test_all_test_configurations):
  10289. * Scripts/webkitpy/layout_tests/port/efl.py:
  10290. (EflPort._generate_all_test_configurations):
  10291. * Scripts/webkitpy/layout_tests/port/gtk.py:
  10292. (GtkPort._generate_all_test_configurations):
  10293. * Scripts/webkitpy/layout_tests/port/qt.py:
  10294. (QtPort._generate_all_test_configurations):
  10295. * Scripts/webkitpy/layout_tests/port/test.py:
  10296. (TestPort.all_test_configurations):
  10297. (TestPort._all_build_types):
  10298. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  10299. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  10300. (BuildCoverageExtrapolatorTest.test_extrapolate):
  10301. (GardeningExpectationsUpdaterTest.test_unknown_failure_type):
  10302. (GardeningExpectationsUpdaterTest.test_add_new_expectation):
  10303. (GardeningExpectationsUpdaterTest.test_replace_old_expectation):
  10304. (GardeningExpectationsUpdaterTest.test_pass_expectation):
  10305. (GardeningExpectationsUpdaterTest.test_supplement_old_expectation):
  10306. (GardeningExpectationsUpdaterTest.test_spurious_updates):
  10307. 2012-03-12 Dirk Pranke <dpranke@chromium.org>
  10308. _runtime_feature_list isn't supported on Apple Mac DRT
  10309. https://bugs.webkit.org/show_bug.cgi?id=80906
  10310. Reviewed by Eric Seidel.
  10311. It looks like this feature is actually only supported on the Win
  10312. DRT port, so this patch reworks the code to make that clearer
  10313. and reduce unnecessary overrides.
  10314. * Scripts/webkitpy/layout_tests/port/efl.py:
  10315. (EflPort._path_to_webcore_library):
  10316. * Scripts/webkitpy/layout_tests/port/gtk.py:
  10317. (GtkPort._path_to_webcore_library):
  10318. * Scripts/webkitpy/layout_tests/port/qt.py:
  10319. (QtPort._skipped_file_search_paths):
  10320. * Scripts/webkitpy/layout_tests/port/webkit.py:
  10321. (WebKitPort._runtime_feature_list):
  10322. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  10323. (TestWebKitPort.__init__):
  10324. (TestWebKitPort.all_test_configurations):
  10325. (test_skipped_directories_for_features):
  10326. * Scripts/webkitpy/layout_tests/port/win.py:
  10327. (WinPort):
  10328. (WinPort._runtime_feature_list):
  10329. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  10330. (WinPortTest.test_operating_system):
  10331. (WinPortTest):
  10332. (WinPortTest.test_runtime_feature_list):
  10333. 2012-03-12 Peter Beverloo <peter@chromium.org>
  10334. [Chromium] Temporary build-fix for the Android bot
  10335. https://bugs.webkit.org/show_bug.cgi?id=80862
  10336. Reviewed by Adam Barth.
  10337. Manually set the environmental variables required to compile source
  10338. files through the Android NDK instead of relying on the envsetup.sh
  10339. script. A proper fix will be landed to Chromium ASAP, and following
  10340. a Chromium roll into WebKit this code will be removed.
  10341. * Scripts/webkitdirs.pm:
  10342. (buildChromiumMakefile):
  10343. 2012-03-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  10344. [Qt] Use right construct to detect config_test_gccdepends
  10345. Reviewed by Andreas Kling.
  10346. * qmake/mkspecs/features/default_pre.prf:
  10347. 2012-03-12 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  10348. [Qt] Expose location of WebKit's bin and imports dir through module file
  10349. Reviewed by Andreas Kling.
  10350. * qmake/qt_webkit.pri:
  10351. 2012-03-12 Andras Becsi <andras.becsi@nokia.com>
  10352. [Qt][WK2] Add support for rudimentary scroll indicators in MiniBrowser
  10353. https://bugs.webkit.org/show_bug.cgi?id=80832
  10354. Reviewed by Tor Arne Vestbø.
  10355. Add a basic scroll indicator component to MiniBrowser so that it
  10356. behaves similar to the ScrollDecorator QML component.
  10357. * MiniBrowser/qt/MiniBrowser.qrc:
  10358. * MiniBrowser/qt/qml/BrowserWindow.qml:
  10359. * MiniBrowser/qt/qml/ScrollIndicator.qml: Added.
  10360. 2012-03-12 C Anthony Risinger <anthony@xtfx.me>
  10361. [GTK] r110296 included an extra $ in @$(AM_V_GEN)
  10362. https://bugs.webkit.org/show_bug.cgi?id=80809
  10363. Reviewed by Philippe Normand.
  10364. * GNUmakefile.am: Add `$` to @(AM_V_GEN), else /bin/sh syntax error
  10365. 2012-03-12 Ming Xie <mxie@rim.com>
  10366. [BlackBerry] build-webkit doesn't recognize "--cmakearg" for the BlackBerry port
  10367. https://bugs.webkit.org/show_bug.cgi?id=80812
  10368. Reviewed by Rob Buis.
  10369. * Scripts/build-webkit: Add $cmakeArgs to buildCMakeProjectOrExit()
  10370. * Scripts/webkitdirs.pm:
  10371. (blackberryCMakeArguments): Remove "PUBLIC_BUILD=0" define
  10372. 2012-03-12 Simon Hausmann <simon.hausmann@nokia.com>
  10373. [Qt] Fix build with newer Qt 5.
  10374. Reviewed by Tor Arne Vestbø.
  10375. Newer Qt 5 renames QDeclarativeFoo to QQmlFoo and provides backwards compatible
  10376. renames, which however do trigger a #warning. Until we _require_ a newer Qt 5
  10377. we should disable -Werror.
  10378. Also load(moc) for the availability of QMAKE_MOC in various derived sources. The
  10379. implicit load was removed recently.
  10380. * qmake/mkspecs/features/default_pre.prf:
  10381. * qmake/mkspecs/features/unix/default_post.prf:
  10382. 2012-03-11 Maciej Stachowiak <mjs@apple.com>
  10383. Add --instruments option to sunspider to profile with Instruments
  10384. https://bugs.webkit.org/show_bug.cgi?id=80783
  10385. Reviewed by Filip Pizlo.
  10386. * Scripts/run-sunspider:
  10387. 2012-03-11 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
  10388. [Qt] [WK2] Support threaded renderer in WK2
  10389. https://bugs.webkit.org/show_bug.cgi?id=76661
  10390. Remove disabling of threaded rendering.
  10391. Reviewed by Noam Rosenthal.
  10392. * MiniBrowser/qt/main.cpp:
  10393. (main):
  10394. 2012-03-09 Zan Dobersek <zandobersek@gmail.com>
  10395. [WK2] run-perf-tests should be able to run with WTR
  10396. https://bugs.webkit.org/show_bug.cgi?id=80042
  10397. Reviewed by Martin Robinson.
  10398. Add an option to PerfTestRunner to use WebKitTestRunner instead of
  10399. DumpRenderTree and add the '--no-timeout' flag to WebKitTestRunner
  10400. to avoid timing out when running performance tests.
  10401. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  10402. (PerfTestsRunner._parse_args):
  10403. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  10404. (WTR::InjectedBundle::InjectedBundle): Initialize m_useWaitToDumpWatchdogTimer
  10405. to true.
  10406. (WTR::InjectedBundle::didReceiveMessage): Unpack the 'BeginTest' message
  10407. as a dictionary containing DumpPixels and UseWaitToDumpWatchdogTimer keys.
  10408. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  10409. (WTR::InjectedBundle::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
  10410. publicly accessible.
  10411. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  10412. (WTR::LayoutTestController::waitUntilDone): Only initialize the watchdog if it
  10413. is required.
  10414. * WebKitTestRunner/TestController.cpp:
  10415. (WTR::TestController::TestController): Initialize m_useWaitToDumpWatchdogTimer
  10416. to true.
  10417. (WTR::TestController::initialize): Set m_useWaitToDumpWatchdogTimer to false
  10418. if '--no-timeout' option is present.
  10419. (WTR::TestController::runUntil): Translate TimeoutDuration to a proper timeout
  10420. value, or -1.0 if timeout should not occur.
  10421. * WebKitTestRunner/TestController.h:
  10422. (WTR::TestController::useWaitToDumpWatchdogTimer): Make m_useWaitToDumpWatchdogTimer
  10423. publicly accessible.
  10424. * WebKitTestRunner/TestInvocation.cpp:
  10425. (WTR::TestInvocation::invoke): Pack the 'BeginTest' message as a dictionary,
  10426. containing DumpPixels and UseWaitToDumpWatchdogTimer keys and corresponding values.
  10427. Waiting for final message should not time out if not necessary.
  10428. * WebKitTestRunner/gtk/TestControllerGtk.cpp:
  10429. (WTR::TestController::platformRunUntil): Only set up a timeout if necessary.
  10430. * WebKitTestRunner/qt/TestControllerQt.cpp:
  10431. (WTR::TestController::platformRunUntil): Ditto.
  10432. * WebKitTestRunner/mac/TestControllerMac.mm:
  10433. (WTR::TestController::platformRunUntil): Add a FIXME, indicating functionality
  10434. is missing.
  10435. * WebKitTestRunner/win/TestControllerWin.cpp:
  10436. (WTR::TestController::platformRunUntil): Ditto.
  10437. 2012-03-09 Jon Lee <jonlee@apple.com>
  10438. Rename NotificationPresenter to NotificationClient
  10439. https://bugs.webkit.org/show_bug.cgi?id=80488
  10440. <rdar://problem/10965558>
  10441. Reviewed by Kentaro Hara.
  10442. Refactor to use renamed WebCore::NotificationClient.
  10443. * DumpRenderTree/win/DRTDesktopNotificationPresenter.cpp:
  10444. (DRTDesktopNotificationPresenter::checkNotificationPermission):
  10445. 2012-03-07 James Robinson <jamesr@chromium.org>
  10446. [chromium] Deprecate renderDirectlyToWebView parameter of WebViewClient::createGraphicsContext3D()
  10447. https://bugs.webkit.org/show_bug.cgi?id=80523
  10448. Reviewed by Darin Fisher.
  10449. * DumpRenderTree/chromium/WebViewHost.cpp:
  10450. (WebViewHost::createGraphicsContext3D):
  10451. * DumpRenderTree/chromium/WebViewHost.h:
  10452. (WebViewHost):
  10453. 2012-03-09 Eric Seidel <eric@webkit.org>
  10454. build-webkit should build Source/WTF on Mac
  10455. https://bugs.webkit.org/show_bug.cgi?id=80728
  10456. Reviewed by Adam Barth.
  10457. We'll add other ports to this list in future commits.
  10458. * Scripts/build-webkit:
  10459. 2012-03-09 Jon Lee <jonlee@apple.com>
  10460. Add support for ENABLE(LEGACY_NOTIFICATIONS)
  10461. https://bugs.webkit.org/show_bug.cgi?id=80497
  10462. Reviewed by Adam Barth.
  10463. Prep for b80472: Update API for Web Notifications
  10464. * Scripts/build-webkit:
  10465. * qmake/mkspecs/features/features.prf:
  10466. 2012-03-09 Ashod Nakashian <ashodnakashian@yahoo.com>
  10467. Bash scripts should support LF endings only
  10468. https://bugs.webkit.org/show_bug.cgi?id=79509
  10469. Reviewed by David Kilzer.
  10470. * EWSTools/boot.sh: Added properties svn:executable and svn:eol-style.
  10471. * EWSTools/start-queue.sh: Added property svn:eol-style.
  10472. * Scripts/webkit-tools-completion.sh: Added properties svn:executable and svn:eol-style.
  10473. * WebKitTestRunner/win/build-generated-files.sh: Added properties svn:executable and svn:eol-style.
  10474. * iExploder/iexploder-1.7.2/tools/release_src.sh: Added property svn:eol-style.
  10475. * iExploder/iexploder-1.7.2/tools/update_html_tags_from_sources.sh: Added property svn:eol-style.
  10476. 2012-03-09 Ionut Biru <ibiru@archlinux.org>
  10477. [BUILD] use detected python to run generate-gtkdoc
  10478. https://bugs.webkit.org/show_bug.cgi?id=80695
  10479. Reviewed by Gustavo Noronha Silva.
  10480. * GNUmakefile.am: Use $(PYTHON) instead of plain `python`
  10481. 2012-03-09 Nat Duca <nduca@chromium.org>
  10482. Make check-webkit-style complain about "no new tests" lines in changelogs
  10483. https://bugs.webkit.org/show_bug.cgi?id=80582
  10484. Reviewed by David Levin.
  10485. * Scripts/webkitpy/style/checkers/changelog.py:
  10486. (ChangeLogChecker.check_entry):
  10487. * Scripts/webkitpy/style/checkers/changelog_unittest.py:
  10488. (ChangeLogCheckerTest.test_no_new_tests):
  10489. 2012-03-09 Sheriff Bot <webkit.review.bot@gmail.com>
  10490. Unreviewed, rolling out r110250.
  10491. http://trac.webkit.org/changeset/110250
  10492. https://bugs.webkit.org/show_bug.cgi?id=80682
  10493. It made NRWT ignore test_expectations.txt on Qt-WK2 and ignore
  10494. qt-linux at all. (Requested by Ossy on #webkit).
  10495. * Scripts/old-run-webkit-tests:
  10496. * Scripts/webkitpy/layout_tests/port/qt.py:
  10497. (QtPort):
  10498. (QtPort.determine_full_port_name):
  10499. (QtPort.baseline_search_path):
  10500. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  10501. (QtPortTest):
  10502. (QtPortTest._assert_search_path):
  10503. (QtPortTest.test_baseline_search_path):
  10504. 2012-03-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  10505. [Qt] Use Qt's module system for install rules and depending on QtWebKit
  10506. Instead of rolling our own install rules we now use the same approach as
  10507. every other Qt module, by loading qt_module.prf and qt_module_config.prf.
  10508. This ensures that we follow the same semantics as the rest of Qt on
  10509. what sort of config options are enabled by default (create_cmake eg.).
  10510. It also allows us to use QT += webkit instead of the workaround we had
  10511. with CONFIG += qtwebkit.
  10512. We do however force Qt to always treat our build as a non-developer build,
  10513. so the libraries will end up in the WebKit lib directory instead of the
  10514. qtbase directory (as with a normal developer-build). This allows us to
  10515. keep the webkit-build self-contained. If Qt is a developer build we still
  10516. copy the module file manually to Qt, so that you don't have to install
  10517. WebKit to make it available.
  10518. For non-developer builds of Qt, it is still possible to use the built
  10519. WebKit libraries without having to install them, by having the variable
  10520. QMAKE_EXTRA_MODULE_FORWARDS set in the project's .qmake.cache file,
  10521. pointing to $WEBKITOUTUTDIR/$CONFIGURATION/modules.
  10522. https://bugs.webkit.org/show_bug.cgi?id=80590
  10523. Reviewed by Simon Hausmann.
  10524. * DumpRenderTree/qt/DumpRenderTree.pro:
  10525. * MiniBrowser/qt/BrowserWindow.cpp:
  10526. * MiniBrowser/qt/MiniBrowser.pro:
  10527. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  10528. * MiniBrowser/qt/UrlLoader.cpp:
  10529. * QtTestBrowser/QtTestBrowser.pro:
  10530. * Tools.pro:
  10531. * WebKitTestRunner/InjectedBundle/Target.pri:
  10532. * WebKitTestRunner/Target.pri:
  10533. * qmake/mkspecs/features/default_post.prf:
  10534. * qmake/mkspecs/features/default_pre.prf:
  10535. * qmake/mkspecs/features/functions.prf:
  10536. * qmake/mkspecs/features/qtwebkit-private.prf: Removed.
  10537. * qmake/mkspecs/features/qtwebkit.prf:
  10538. * qmake/mkspecs/features/rpath.prf:
  10539. * qmake/mkspecs/modules/qt_webkit.pri: Removed.
  10540. * qmake/qt_webkit.pri: Added.
  10541. 2012-03-08 Igor Oliveira <igor.o@sisa.samsung.com>
  10542. Unreviewed. Update my email.
  10543. * Scripts/webkitpy/common/config/committers.py:
  10544. 2012-03-08 Xianzhu Wang <wangxianzhu@chromium.org>
  10545. Recent changes to chromium.py etc. broke chromium_android.py
  10546. https://bugs.webkit.org/show_bug.cgi?id=80623
  10547. Reviewed by Dirk Pranke.
  10548. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  10549. (ChromiumAndroidDriver.__init__):
  10550. (ChromiumAndroidDriver._start):
  10551. 2012-03-08 Xianzhu Wang <wangxianzhu@chromium.org>
  10552. [Chromium] Exception running reftest with --no-pixel-tests
  10553. https://bugs.webkit.org/show_bug.cgi?id=80642
  10554. Reviewed by Dirk Pranke.
  10555. * Scripts/webkitpy/layout_tests/port/chromium.py:
  10556. (ChromiumDriver.__init__):
  10557. (ChromiumDriver._wrapper_options):
  10558. 2012-03-08 Rafael Brandao <rafael.lobo@openbossa.org>
  10559. [NRWT] Fix --platform=qt-5.0 --new-baseline combo
  10560. https://bugs.webkit.org/show_bug.cgi?id=72489
  10561. Reviewed by Dirk Pranke.
  10562. NRWT: The default platform name for Qt combined with --webkit-test-runner is now
  10563. "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
  10564. --platform will override the platform name and then we'll use it.
  10565. ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
  10566. than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
  10567. override it in the end.
  10568. * Scripts/old-run-webkit-tests:
  10569. * Scripts/webkitpy/layout_tests/port/qt.py:
  10570. (QtPort):
  10571. (QtPort.determine_full_port_name):
  10572. (QtPort.baseline_search_path):
  10573. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  10574. (QtPortTest):
  10575. (QtPortTest._assert_search_path):
  10576. (QtPortTest.test_baseline_search_path):
  10577. 2012-03-08 Beth Dakin <bdakin@apple.com>
  10578. https://bugs.webkit.org/show_bug.cgi?id=80463
  10579. RenderImage is using the wrong origin when calling addRelevantRepaintedObject
  10580. -and corresponding-
  10581. <rdar://problem/10970221>
  10582. Reviewed by Dan Bernstein.
  10583. New test!
  10584. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  10585. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages.cpp: Added.
  10586. (TestWebKitAPI):
  10587. (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
  10588. (TestWebKitAPI::setPageLoaderClient):
  10589. (TestWebKitAPI::TEST):
  10590. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutForImages_Bundle.cpp: Added.
  10591. (TestWebKitAPI):
  10592. (NewFirstVisuallyNonEmptyLayoutForImagesTest):
  10593. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::NewFirstVisuallyNonEmptyLayoutForImagesTest):
  10594. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutForImagesTest::didCreatePage):
  10595. * TestWebKitAPI/Tests/WebKit2/lots-of-images.html: Added.
  10596. 2012-03-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  10597. [Qt] Prospective Windows build fix
  10598. Don't assume that windows-builds will always run inside a cmd.exe shell.
  10599. * qmake/mkspecs/features/default_pre.prf:
  10600. 2012-03-08 Dan Bernstein <mitz@apple.com>
  10601. <rdar://problem/10981173> Dashboard regions should not be in device space
  10602. Reviewed by John Sullivan.
  10603. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  10604. * TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm: Added.
  10605. (-[DeviceScaleFactorInDashboardRegionsUIDelegate webView:dashboardRegionsChanged:]):
  10606. (TestWebKitAPI):
  10607. (TestWebKitAPI::TEST):
  10608. 2012-03-08 Dirk Pranke <dpranke@chromium.org>
  10609. webkit-patch works oddly on local Git branches
  10610. https://bugs.webkit.org/show_bug.cgi?id=76958
  10611. Reviewed by Ojan Vafai.
  10612. This change makes the '-g' flag to webkit-patch behave a
  10613. little more consistently with git. The 'HEAD..' syntax
  10614. is changed to 'HEAD....' (four dots), so as to not
  10615. collide with the underlying git syntax. We also generalize
  10616. the syntax to support any refname, so 'foo....' means
  10617. diff against foo and include working copy changes.
  10618. This change also adds the 'UPSTREAM' shortcut to identify
  10619. whatever the current upstream/tracking branch is; this is
  10620. useful if you have multiple local branches stacked up.
  10621. * Scripts/webkitpy/common/checkout/scm/git.py:
  10622. (Git._branch_from_ref):
  10623. (Git):
  10624. (Git._current_branch):
  10625. (Git._upstream_branch):
  10626. (Git.merge_base):
  10627. (Git._commit_on_branch):
  10628. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  10629. (GitSVNTest._second_local_commit):
  10630. (GitSVNTest._two_local_commits):
  10631. (GitSVNTest.test_commit_with_message_git_commit_range):
  10632. (GitSVNTest.test_upstream_branch):
  10633. (GitSVNTest.test_create_patch_working_copy_only):
  10634. (GitSVNTest.test_changed_files_local_plus_working_copy):
  10635. (GitSVNTest.test_changed_files_working_copy_only):
  10636. (GitSVNTest.test_changed_files_upstream):
  10637. * Scripts/webkitpy/tool/steps/options.py:
  10638. (Options):
  10639. 2012-03-08 John Sullivan <sullivan@apple.com>
  10640. Made extract-localizable-strings ignore NSLocalizedFileSizeDescription
  10641. Reviewed by Eric Carlson.
  10642. * Scripts/extract-localizable-strings:
  10643. Added NSLocalizedFileSizeDescription to allowed list of tokens that start
  10644. with NSLocalized. Also improved an error message to include the troublesome token.
  10645. 2012-03-08 Sheriff Bot <webkit.review.bot@gmail.com>
  10646. Unreviewed, rolling out r110115.
  10647. http://trac.webkit.org/changeset/110115
  10648. https://bugs.webkit.org/show_bug.cgi?id=80581
  10649. broke test-webkitpy (Requested by philn-tp on #webkit).
  10650. * Scripts/old-run-webkit-tests:
  10651. * Scripts/webkitpy/layout_tests/port/qt.py:
  10652. (QtPort):
  10653. (QtPort.determine_full_port_name):
  10654. (QtPort.baseline_search_path):
  10655. 2012-03-08 Kentaro Hara <haraken@chromium.org>
  10656. Unreviewed. Added myself to watchlist.
  10657. * Scripts/webkitpy/common/config/watchlist:
  10658. 2012-03-07 Jessie Berlin <jberlin@apple.com>
  10659. Clean Windows build fails after r110033
  10660. https://bugs.webkit.org/show_bug.cgi?id=80553
  10661. Rubber-stamped by Jon Honeycutt and Eric Seidel.
  10662. Add the new JavaScriptCore include directory to some more vsprops files.
  10663. * DumpRenderTree/win/ImageDiffCommon.vsprops:
  10664. * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  10665. * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  10666. 2012-03-07 Rafael Brandao <rafael.lobo@openbossa.org>
  10667. [NRWT] Fix --platform=qt-5.0 --new-baseline combo
  10668. https://bugs.webkit.org/show_bug.cgi?id=72489
  10669. Reviewed by Dirk Pranke.
  10670. NRWT: The default platform name for Qt combined with --webkit-test-runner is now
  10671. "qt-5.0-wk2" instead of "qt-linux" and that name is now prefered for tests.
  10672. --platform will override the platform name and then we'll use it.
  10673. ORWT: We check for qt version and use platform name "qt-4.8" if the version is lower
  10674. than 5.0.0, and then we choose between "qt-5.0-wk1" and "qt-5.0-wk2". --platform will
  10675. override it in the end.
  10676. * Scripts/old-run-webkit-tests:
  10677. * Scripts/webkitpy/layout_tests/port/qt.py:
  10678. (QtPort):
  10679. (QtPort.determine_full_port_name):
  10680. (QtPort.baseline_search_path):
  10681. 2012-03-07 Hugo Parente Lima <hugo.lima@openbossa.org>
  10682. [Qt][WK2] MiniBrowser on desktop does not react to click events
  10683. https://bugs.webkit.org/show_bug.cgi?id=80314
  10684. Reviewed by Kenneth Rohde Christiansen.
  10685. Do not enable touch mocking on desktop mode.
  10686. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  10687. (MiniBrowserApplication::handleUserOptions):
  10688. 2012-03-07 Ojan Vafai <ojan@chromium.org>
  10689. Automatically move to the next test after rebaseline in the results view
  10690. https://bugs.webkit.org/show_bug.cgi?id=80527
  10691. Reviewed by Dimitri Glazkov.
  10692. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  10693. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  10694. 2012-03-07 Ojan Vafai <ojan@chromium.org>
  10695. garden-o-matic rebaseline is broken for ports that don't have a fallback port
  10696. https://bugs.webkit.org/show_bug.cgi?id=80526
  10697. Reviewed by Adam Barth.
  10698. Passing "None" as the fallback port throws an error in "webkit-patch rebaseline-test"
  10699. since there is no "None" port.
  10700. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  10701. (GardeningHTTPRequestHandler.rebaseline):
  10702. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  10703. (GardeningServerTest.test_rebaseline):
  10704. 2012-03-07 James Robinson <jamesr@chromium.org>
  10705. [chromium] Remove the TestWebPlugin's use of implicit FBO for offscreen contexts
  10706. https://bugs.webkit.org/show_bug.cgi?id=80521
  10707. Reviewed by Kenneth Russell.
  10708. Switches TestWebPlugin from using a context created by WebViewClient::createGraphicsContext3D(..., false) over
  10709. to an explicitly offscreen context with explicitly managed texture / FBO, so we can deprecate the
  10710. renderDirectlyToHostWindow flag from WebViewClient::createGraphicsContext3D.
  10711. Covered by platform/chromium/compositing/plugins/*
  10712. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  10713. (TestWebPlugin::TestWebPlugin):
  10714. (TestWebPlugin::initialize):
  10715. (TestWebPlugin::updateGeometry):
  10716. (TestWebPlugin::initScene):
  10717. (TestWebPlugin::destroyScene):
  10718. * DumpRenderTree/chromium/TestWebPlugin.h:
  10719. (TestWebPlugin):
  10720. * DumpRenderTree/chromium/WebViewHost.cpp:
  10721. (WebViewHost::createPlugin):
  10722. 2012-03-07 Philippe Normand <pnormand@igalia.com>
  10723. [GTK] remove webkitpy dependency in run-gtk-tests
  10724. https://bugs.webkit.org/show_bug.cgi?id=80500
  10725. Reviewed by Martin Robinson.
  10726. Replace Executive calls with bare subprocess calls.
  10727. * Scripts/run-gtk-tests:
  10728. (TestRunner):
  10729. (TestRunner._lookup_atspi2_binary):
  10730. (TestRunner.run):
  10731. (TestRunner.run.run_for_real):
  10732. 2012-03-07 Philippe Normand <pnormand@igalia.com>
  10733. Unreviewed, GTK build fix after r110059.
  10734. * Scripts/run-gtk-tests:
  10735. (TestRunner._check_if_tests_have_timed_out):
  10736. (TestRunner.run.run_tests):
  10737. (TestRunner):
  10738. 2012-03-07 Philippe Normand <pnormand@igalia.com>
  10739. [GTK] race condition in run-gtk-tests
  10740. https://bugs.webkit.org/show_bug.cgi?id=80495
  10741. Reviewed by Martin Robinson.
  10742. Refactored the script to wait the a11y dbus service becomes
  10743. available before starting the tests.
  10744. * Scripts/run-gtk-tests:
  10745. (TestRunner._lookup_atspi2_binary):
  10746. (TestRunner):
  10747. (TestRunner._wait_dbus_service_and_run):
  10748. (TestRunner._wait_dbus_service_and_run.on_name_appeared):
  10749. (TestRunner._wait_dbus_service_and_run.on_name_vanished):
  10750. (TestRunner.run):
  10751. (TestRunner.run.bailout):
  10752. (TestRunner.run.run_for_real):
  10753. 2012-03-07 Dinu Jacob <dinu.jacob@nokia.com>
  10754. [Qt] REGRESSION(r109575) Broke tap-to-zoom gesture
  10755. https://bugs.webkit.org/show_bug.cgi?id=80425
  10756. Reviewed by Simon Hausmann.
  10757. Set startScreenPos in mock touch point
  10758. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  10759. (MiniBrowserApplication::notify):
  10760. * MiniBrowser/qt/MiniBrowserApplication.h:
  10761. (MiniBrowserApplication):
  10762. 2012-03-07 Simon Hausmann <simon.hausmann@nokia.com>
  10763. [Qt] Windows build fix.
  10764. Reviewed by Tor Arne Vestbø.
  10765. Pass the -j parameter only to "make", not "nmake".
  10766. * Scripts/webkitdirs.pm:
  10767. (buildQMakeProjects):
  10768. 2012-03-07 Simon Hausmann <simon.hausmann@nokia.com>
  10769. [Qt] Fix compilation without QtQuick1
  10770. https://bugs.webkit.org/show_bug.cgi?id=80503
  10771. Reviewed by Tor Arne Vestbø.
  10772. Introduce HAVE_QQUICK1 as feature and added haveQtModule
  10773. as convenience function.
  10774. * qmake/mkspecs/features/features.prf:
  10775. * qmake/mkspecs/features/functions.prf:
  10776. 2012-03-07 Zoltan Horvath <zoltan@webkit.org>
  10777. [Qt] Add qmake config tests for JPEG and PNG library
  10778. https://bugs.webkit.org/show_bug.cgi?id=80398
  10779. Add JPEG and PNG library tests to config.tests and
  10780. add error() abort to WebCore.pri if tests don't work.
  10781. Reviewed by Tor Arne Vestbø.
  10782. * qmake/config.tests/libjpeg/libjpeg.cpp: Added.
  10783. (main):
  10784. * qmake/config.tests/libjpeg/libjpeg.pro: Added.
  10785. * qmake/config.tests/libpng/libpng.cpp: Added.
  10786. (main):
  10787. * qmake/config.tests/libpng/libpng.pro: Added.
  10788. * qmake/sync.profile:
  10789. 2012-03-07 Byungwoo Lee <bw80.lee@samsung.com>
  10790. [EFL] Build warning: Fix warn_unused_result warnings.
  10791. https://bugs.webkit.org/show_bug.cgi?id=79194
  10792. Reviewed by Filip Pizlo.
  10793. Fixed build warning which is getting generated when not using return
  10794. value of a fuction, especially declared with warn_unused_result
  10795. attribute.
  10796. * DumpRenderTree/efl/ImageDiff.cpp:
  10797. (printImage):
  10798. 2012-03-07 Kangil Han <kangil.han@samsung.com>
  10799. [DRT] Remove PlainTextController implementations.
  10800. https://bugs.webkit.org/show_bug.cgi?id=79959
  10801. Reviewed by Hajime Morita.
  10802. PlainTextController usages in existing tests have been
  10803. replaced by internals API by bug 78570.
  10804. So this patch will remove PlainTextController implementations
  10805. to avoid further usage in new tests.
  10806. * DumpRenderTree/DumpRenderTree.gypi:
  10807. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  10808. * DumpRenderTree/chromium/PlainTextController.cpp: Removed.
  10809. * DumpRenderTree/chromium/PlainTextController.h: Removed.
  10810. * DumpRenderTree/chromium/TestShell.cpp:
  10811. (TestShell::TestShell):
  10812. (TestShell::bindJSObjectsToWindow):
  10813. * DumpRenderTree/chromium/TestShell.h:
  10814. (TestShell):
  10815. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  10816. (webViewWindowObjectCleared):
  10817. * DumpRenderTree/gtk/PlainTextController.cpp: Removed.
  10818. * DumpRenderTree/gtk/PlainTextController.h: Removed.
  10819. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  10820. (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
  10821. * DumpRenderTree/mac/PlainTextController.h: Removed.
  10822. * DumpRenderTree/mac/PlainTextController.mm: Removed.
  10823. * DumpRenderTree/qt/DumpRenderTree.pro:
  10824. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  10825. (WebCore::DumpRenderTree::DumpRenderTree):
  10826. (WebCore::DumpRenderTree::initJSObjects):
  10827. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  10828. (DumpRenderTree):
  10829. * DumpRenderTree/qt/PlainTextControllerQt.cpp: Removed.
  10830. * DumpRenderTree/qt/PlainTextControllerQt.h: Removed.
  10831. * GNUmakefile.am:
  10832. 2012-03-06 Grzegorz Czajkowski <g.czajkowski@samsung.com>
  10833. [EFL][DRT] Implements LayoutTestController's setPopupBlockingEnabled.
  10834. https://bugs.webkit.org/show_bug.cgi?id=80137
  10835. Reviewed by Eric Seidel.
  10836. Adds implementation LayoutTestController's setPopupBlockingEnabled.
  10837. To pass popup-blocking-click-in-iframe.html EventSender should not
  10838. repeat click events in idler's function. EventSender allows to
  10839. asynchronously send click event through ecore_idler_add.
  10840. This event will be called repeatedly as long as it return true.
  10841. Click event should be called only once by returning ECORE_CALLBACK_CANCEL.
  10842. * DumpRenderTree/efl/EventSender.cpp:
  10843. (sendMouseEvent): Changed return value from bool to void because it always returns true.
  10844. (sendClick): Idler is deleted by returning ECORE_CALLBACK_CANCEL.
  10845. (mouseDownCallback): Remove unnecessary checking of return value.
  10846. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  10847. (LayoutTestController::setPopupBlockingEnabled):
  10848. 2012-03-06 Dirk Pranke <dpranke@chromium.org>
  10849. rebaseline_chromium_webkit_tests is obsolete and should be removed
  10850. https://bugs.webkit.org/show_bug.cgi?id=80347
  10851. Reviewed by Tony Chang.
  10852. * Scripts/rebaseline-chromium-webkit-tests: Removed.
  10853. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Removed.
  10854. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Removed.
  10855. 2012-03-06 Dirk Pranke <dpranke@chromium.org>
  10856. test_start_cmd (webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer) is broken
  10857. https://bugs.webkit.org/show_bug.cgi?id=80468
  10858. Unreviewed, build fix.
  10859. Fixing a bug revealed by r80443 when we fixed filesystem.copyfile().
  10860. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  10861. (Lighttpd._prepare_config):
  10862. 2012-03-06 Dirk Pranke <dpranke@chromium.org>
  10863. remove chromium_gpu ports
  10864. https://bugs.webkit.org/show_bug.cgi?id=80345
  10865. Reviewed by Ojan Vafai.
  10866. This change leaves in the 'graphics_type' distinction in the
  10867. test_expectations; removing that will require more updates and a
  10868. pass over test_expectations.txt, so I'm separating that out.
  10869. * Scripts/webkitpy/layout_tests/port/builders.py:
  10870. * Scripts/webkitpy/layout_tests/port/chromium.py:
  10871. (ChromiumPort):
  10872. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py: Removed.
  10873. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py: Removed.
  10874. * Scripts/webkitpy/layout_tests/port/factory.py:
  10875. (PortFactory):
  10876. (PortFactory.get):
  10877. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  10878. (FactoryTest.test_qt):
  10879. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  10880. (TestRebaseline.test_rebaseline_expectations):
  10881. 2012-03-06 Raphael Kubo da Costa <kubo@profusion.mobi>
  10882. undefined reference to JSC::IdentifierTable::~IdentifierTable() on EFL port
  10883. https://bugs.webkit.org/show_bug.cgi?id=80282
  10884. Reviewed by Antonio Gomes.
  10885. Remove transitive library dependencies; they are especially
  10886. dangerous when one ends up linking against WTF, JSC and then WTF
  10887. again, since some symbols will not be defined.
  10888. Passing --no-copy-dt-needed-entries and --as-needed to the linker
  10889. (which some recent Linux distros do by default) makes the issue
  10890. even more evident.
  10891. * DumpRenderTree/efl/CMakeLists.txt: Do not link directly to WTF,
  10892. as the other libraries have the needed symbols. Explicitly link
  10893. against fontconfig.
  10894. 2012-03-06 Dean Jackson <dino@apple.com>
  10895. filter-build-webkit needs more filters
  10896. https://bugs.webkit.org/show_bug.cgi?id=80440
  10897. Reviewed by Joseph Pecoraro.
  10898. Added as many missing filters as I could find for Apple
  10899. builds. Plus a few minor style updates.
  10900. * Scripts/filter-build-webkit:
  10901. (printLine):
  10902. 2012-03-06 Ojan Vafai <ojan@chromium.org>
  10903. Copying old baselines throws an error if the new directory doesn't exist
  10904. https://bugs.webkit.org/show_bug.cgi?id=80443
  10905. Reviewed by Adam Barth.
  10906. Existing tests cover the new code with the fix to filesystem_mock.
  10907. * Scripts/webkitpy/common/system/filesystem_mock.py:
  10908. (MockFileSystem.copyfile):
  10909. Fix the mock to better match python's copyfile semantics.
  10910. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  10911. (Rebaseliner._create_html_baseline_files):
  10912. * Scripts/webkitpy/tool/commands/rebaseline.py:
  10913. (RebaselineTest._copy_existing_baseline):
  10914. 2012-03-05 Ojan Vafai <ojan@chromium.org>
  10915. Add a mechanism to rebaseline new ports
  10916. https://bugs.webkit.org/show_bug.cgi?id=80355
  10917. Reviewed by Adam Barth.
  10918. For a test that's only failing on a new port, we want
  10919. to first copy the existing result into the location for the
  10920. port it's replacing in order to not break that port.
  10921. For example, bringing up the chromium-lion port, if we just
  10922. stick the results in the chromium-mac directory, the snow leopard
  10923. will start failing. Instead, we first copy the existing result
  10924. to the chromium-mac-snowleopard directory.
  10925. * Scripts/webkitpy/layout_tests/port/builders.py:
  10926. (builder_path_for_port_name):
  10927. (fallback_port_name_for_new_port):
  10928. * Scripts/webkitpy/tool/commands/rebaseline.py:
  10929. (RebaselineTest):
  10930. (RebaselineTest._copy_existing_baseline):
  10931. (RebaselineTest._rebaseline_test):
  10932. (RebaselineTest.execute):
  10933. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  10934. (TestRebaseline.test_rebaseline_test):
  10935. (TestRebaseline):
  10936. (TestRebaseline.test_rebaseline_and_copy_test):
  10937. (test_rebaseline_and_copy_test_no_existing_result):
  10938. (test_rebaseline_and_copy_test_with_lion_result):
  10939. (test_rebaseline_and_copy_no_overwrite_test):
  10940. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  10941. (GardeningHTTPRequestHandler.rebaseline):
  10942. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  10943. (GardeningServerTest.test_rebaseline):
  10944. (GardeningServerTest):
  10945. (GardeningServerTest.test_rebaseline_new_port):
  10946. 2012-03-06 Beth Dakin <bdakin@apple.com>
  10947. https://bugs.webkit.org/show_bug.cgi?id=80351
  10948. InlineTextBox is using the wrong origin when calling
  10949. addRelevantRepaintedObject
  10950. -and corresponding-
  10951. <rdar://problem/10970221>
  10952. Reviewed by Sam Weinig.
  10953. This test has actually been broken since revision 109273. This change makes
  10954. the test pass again, and it makes it specifically exercise the fix for this
  10955. bug.
  10956. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  10957. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
  10958. (TestWebKitAPI::TEST):
  10959. Adjust comments in the other tests to reflect the API changes from 109273.
  10960. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp:
  10961. (TestWebKitAPI::TEST):
  10962. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp:
  10963. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
  10964. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp:
  10965. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
  10966. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp:
  10967. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
  10968. * TestWebKitAPI/Tests/WebKit2/lots-of-text.html: Added.
  10969. 2012-03-06 Hans Wennborg <hans@chromium.org>
  10970. Speech JavaScript API: add SpeechRecognitionError
  10971. https://bugs.webkit.org/show_bug.cgi?id=80410
  10972. Chromium: enable the runtime flag for scripted speech so we can run
  10973. the layout tests for it.
  10974. Reviewed by Adam Barth.
  10975. * DumpRenderTree/chromium/TestShell.cpp:
  10976. (TestShell::TestShell):
  10977. 2012-03-06 Sami Kyostila <skyostil@chromium.org>
  10978. Enable universal newlines in chromium android layout test runner
  10979. https://bugs.webkit.org/show_bug.cgi?id=80418
  10980. Reviewed by Adam Barth.
  10981. The Chromium Android layout test runner uses the 'adb' program to
  10982. communicate with the Android device. Adb uses CRLF ('\r\n') to delimit
  10983. output lines from the test runner, while the test expectation files are
  10984. written with LF ('\n') delimiters. This causes the results to have
  10985. spurious whitespace differences, making them more difficult to
  10986. interpret.
  10987. The fix is to enable universal newlines for the DumpRenderTree pipe,
  10988. causing the output to only contain LF newlines like on other platforms.
  10989. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  10990. (ChromiumAndroidDriver._start):
  10991. 2012-03-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  10992. [Qt] Revert r109900, it was completly busted
  10993. HAVE_FOO does _not_ have a WTF_ prefix, go figure.
  10994. We still leave in the HAVE(FOO) in QtInitializeTestFonts.cpp, instead
  10995. of manual define checks.
  10996. Reviewed by Ossy.
  10997. * DumpRenderTree/qt/DumpRenderTree.pro:
  10998. * QtTestBrowser/QtTestBrowser.pro:
  10999. * WebKitTestRunner/InjectedBundle/Target.pri:
  11000. * qmake/mkspecs/features/features.prf:
  11001. 2012-03-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11002. [Qt] Use config test to determine if the compiler supports -MD
  11003. We used to assume that unix systems building against Qt5 would have
  11004. a compiler that supported -MD. Although this was usually the case,
  11005. we failed to take into account broken tools for distributed builds
  11006. (e.g. teambuilder or icecream) which would end up producing .d files
  11007. in the root of the build dir instead of along-side the object file.
  11008. Now that we use a config-test to determine the support, we'll capture
  11009. those cases, unless distributed builds are enabled after the initial
  11010. build-webkit run.
  11011. Reviewed by Csaba Osztrogonác.
  11012. * Tools.pro:
  11013. * qmake/config.tests/gccdepends/empty.cpp: Added.
  11014. * qmake/config.tests/gccdepends/gccdepends.pro: Added.
  11015. * qmake/mkspecs/features/default_pre.prf:
  11016. * qmake/mkspecs/features/features.prf:
  11017. * qmake/mkspecs/features/unix/default_pre.prf:
  11018. * qmake/sync.profile:
  11019. 2012-03-06 Csaba Osztrogonác <ossy@webkit.org>
  11020. REGRESSION(r109294): It broke the unittest of master.cfg
  11021. https://bugs.webkit.org/show_bug.cgi?id=80253
  11022. Reviewed by Tor Arne Vestbø.
  11023. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Use json instead of simplejson.
  11024. (BuildBotConfigLoader._create_mock_passwords_dict):
  11025. (BuildBotConfigLoader._mock_open):
  11026. (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
  11027. (BuildBotConfigLoader.load_config):
  11028. 2012-03-06 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  11029. Qt API test buildstep throws exception after buildmaster update
  11030. https://bugs.webkit.org/show_bug.cgi?id=80249
  11031. This patch based on Peter Gal's work.
  11032. Reviewed by Csaba Osztrogonác.
  11033. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  11034. (RunQtAPITests):
  11035. (BuildAndTestFactory.__init__): Enable API tests on the Qt platform again.
  11036. 2012-03-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11037. [Qt] Use correct define names for HAVE(FOO) style optional dependencies
  11038. Reviewed by Simon Hausmann.
  11039. Reviewed by Ossy.
  11040. * DumpRenderTree/qt/DumpRenderTree.pro:
  11041. * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  11042. (WebKit::initializeTestFonts):
  11043. * QtTestBrowser/QtTestBrowser.pro:
  11044. * WebKitTestRunner/InjectedBundle/Target.pri:
  11045. * qmake/mkspecs/features/features.prf:
  11046. 2012-03-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11047. [Qt] Don't add recursive qmake_all target if there are no subdirs to recurse
  11048. Reviewed by Ossy.
  11049. * qmake/mkspecs/features/default_post.prf:
  11050. 2012-03-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11051. [Qt] Make sure clean builds are followed by make qmake && make if needed
  11052. On non-GNUmake systems we have to run make qmake so that the generated
  11053. sources are generated before we run qmake on the target pro files. This
  11054. is achieved by using the 'incremental' target.
  11055. Reviewed by Ossy.
  11056. * Scripts/webkitdirs.pm:
  11057. (buildQMakeProjects):
  11058. 2012-03-06 Filip Pizlo <fpizlo@apple.com>
  11059. DumpRenderTree should support preciseTime()
  11060. https://bugs.webkit.org/show_bug.cgi?id=80397
  11061. Reviewed by Gavin Barraclough.
  11062. * DumpRenderTree/LayoutTestController.cpp:
  11063. (preciseTimeCallback):
  11064. (LayoutTestController::staticFunctions):
  11065. 2012-03-06 Sheriff Bot <webkit.review.bot@gmail.com>
  11066. Unreviewed, rolling out r109887.
  11067. http://trac.webkit.org/changeset/109887
  11068. https://bugs.webkit.org/show_bug.cgi?id=80402
  11069. It broke the build (Requested by Ossy on #webkit).
  11070. * DumpRenderTree/qt/DumpRenderTree.pro:
  11071. * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  11072. (WebKit::initializeTestFonts):
  11073. * QtTestBrowser/QtTestBrowser.pro:
  11074. * WebKitTestRunner/InjectedBundle/Target.pri:
  11075. * qmake/mkspecs/features/features.prf:
  11076. 2012-03-06 Sheriff Bot <webkit.review.bot@gmail.com>
  11077. Unreviewed, rolling out r109837.
  11078. http://trac.webkit.org/changeset/109837
  11079. https://bugs.webkit.org/show_bug.cgi?id=80399
  11080. breaks Mac Productions builds, too late to try and fix it
  11081. tonight (Requested by eseidel on #webkit).
  11082. * Scripts/build-webkit:
  11083. 2012-03-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11084. [Qt] Use correct define names for HAVE(FOO) style optional dependencies
  11085. Reviewed by Simon Hausmann.
  11086. * DumpRenderTree/qt/DumpRenderTree.pro:
  11087. * DumpRenderTree/qt/QtInitializeTestFonts.cpp:
  11088. (WebKit::initializeTestFonts):
  11089. * QtTestBrowser/QtTestBrowser.pro:
  11090. * WebKitTestRunner/InjectedBundle/Target.pri:
  11091. * qmake/mkspecs/features/features.prf:
  11092. 2012-03-06 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  11093. [Qt] Create EWS to build WebKit2
  11094. https://bugs.webkit.org/show_bug.cgi?id=80277
  11095. Reviewed by Csaba Osztrogonác.
  11096. * QueueStatusServer/model/queues.py:
  11097. (Queue):
  11098. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  11099. (QtWK2EWS):
  11100. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  11101. (EarlyWarningSytemTest.test_builder_ewses):
  11102. 2012-03-05 Sheriff Bot <webkit.review.bot@gmail.com>
  11103. Unreviewed, rolling out r109733.
  11104. http://trac.webkit.org/changeset/109733
  11105. https://bugs.webkit.org/show_bug.cgi?id=80378
  11106. It broke Qt5 build system (Requested by Ossy on #webkit).
  11107. * Tools.pro:
  11108. * qmake/config.tests/gccdepends/empty.cpp: Removed.
  11109. * qmake/config.tests/gccdepends/gccdepends.pro: Removed.
  11110. * qmake/mkspecs/features/default_pre.prf:
  11111. * qmake/mkspecs/features/features.prf:
  11112. * qmake/mkspecs/features/unix/default_pre.prf:
  11113. * qmake/sync.profile:
  11114. 2012-03-05 Eric Seidel <eric@webkit.org>
  11115. Update JavaScriptCore files to use fully-qualified WTF include path
  11116. https://bugs.webkit.org/show_bug.cgi?id=79960
  11117. Reviewed by Adam Barth.
  11118. Build WTF/WTF.xcodeproj by default on Mac.
  11119. * Scripts/build-webkit:
  11120. 2012-03-05 Dirk Pranke <dpranke@chromium.org>
  11121. There should be a way to disable optimizer in webkit-patch rebaseline-expectations
  11122. https://bugs.webkit.org/show_bug.cgi?id=69590
  11123. Reviewed by Ryosuke Niwa.
  11124. Adds a --no-optimize flag to webkit-patch rebaseline-expectations
  11125. to skip the 'optimize-expectations' step.
  11126. * Scripts/webkitpy/tool/commands/rebaseline.py:
  11127. (RebaselineExpectations.__init__):
  11128. (RebaselineExpectations.execute):
  11129. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  11130. 2012-03-05 Kent Tamura <tkent@chromium.org>
  11131. [Chromium] Add new popup type: PagePopup
  11132. https://bugs.webkit.org/show_bug.cgi?id=80106
  11133. Reviewed by Darin Fisher.
  11134. * DumpRenderTree/chromium/WebViewHost.cpp:
  11135. (WebViewHost::createPopupMenu):
  11136. 2012-03-05 Jessie Berlin <jberlin@apple.com>
  11137. Add myself as a reviewer.
  11138. * Scripts/webkitpy/common/config/committers.py:
  11139. Also, add my IRC nick so it is easier to find and yell at me.
  11140. 2012-03-05 Robert Kroeger <rjkroege@chromium.org>
  11141. Correctly compute the positions of GestureScroll* events on
  11142. Chromium.
  11143. https://bugs.webkit.org/show_bug.cgi?id=80075
  11144. Reviewed by Adam Barth.
  11145. * DumpRenderTree/chromium/EventSender.cpp:
  11146. (EventSender::reset):
  11147. (EventSender::gestureEvent):
  11148. * DumpRenderTree/chromium/EventSender.h:
  11149. (EventSender):
  11150. 2012-03-05 Dirk Pranke <dpranke@chromium.org>
  11151. flakiness dashboard doesn't display baselines for virtual tests correctly
  11152. https://bugs.webkit.org/show_bug.cgi?id=80341
  11153. Reviewed by Ojan Vafai.
  11154. If the test is part of a virtual test suite, we need to look for
  11155. baselines in the underlying fallback path for the actual test
  11156. being run, as well as baselines for the virtual version.
  11157. This patch adds code to handle both branches and also pulls the
  11158. mapping of the test suites up into a constant.
  11159. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  11160. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  11161. (testLookupVirtualTestSuite):
  11162. (testBaseTest):
  11163. 2012-03-05 Sheriff Bot <webkit.review.bot@gmail.com>
  11164. Unreviewed, rolling out r109760.
  11165. http://trac.webkit.org/changeset/109760
  11166. https://bugs.webkit.org/show_bug.cgi?id=80320
  11167. Caused many GTK+ tests to crash (Requested by mrobinson on
  11168. #webkit).
  11169. * gtk/jhbuild.modules:
  11170. 2012-03-05 Charlie Reis <creis@chromium.org>
  11171. [chromium] Pass WebNavigationPolicy to WebViewClient::createView
  11172. https://bugs.webkit.org/show_bug.cgi?id=80057
  11173. Reviewed by Darin Fisher.
  11174. * DumpRenderTree/chromium/WebViewHost.cpp:
  11175. (WebViewHost::createView):
  11176. * DumpRenderTree/chromium/WebViewHost.h:
  11177. (WebViewHost):
  11178. 2012-03-05 Martin Robinson <mrobinson@igalia.com>
  11179. [soup] Crash while loading http://www.jusco.cn
  11180. https://bugs.webkit.org/show_bug.cgi?id=68238
  11181. Reviewed by Philippe Normand.
  11182. * gtk/jhbuild.modules: Bumped the libsoup and glib dependencies
  11183. in the jhbuild file.
  11184. 2012-03-05 Sheriff Bot <webkit.review.bot@gmail.com>
  11185. Unreviewed, rolling out r109748.
  11186. http://trac.webkit.org/changeset/109748
  11187. https://bugs.webkit.org/show_bug.cgi?id=80296
  11188. Made some tests crash, will fix and recommit (Requested by
  11189. noamr on #webkit).
  11190. * MiniBrowser/qt/main.cpp:
  11191. (main):
  11192. 2012-03-05 Zan Dobersek <zandobersek@gmail.com>
  11193. [GTK] plugins/netscape-plugin-page-cache-works.html fails
  11194. https://bugs.webkit.org/show_bug.cgi?id=74409
  11195. Reviewed by Martin Robinson.
  11196. Add support for overriding the page-cache-for-plugins preference
  11197. through DumpRenderTreeSupport.
  11198. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  11199. (booleanFromValue): A helper function to convert a string to boolean.
  11200. (LayoutTestController::overridePreference):
  11201. 2012-03-05 Rob Buis <rbuis@rim.com>
  11202. [BlackBerry] Update Tools/DumpRenderTree
  11203. https://bugs.webkit.org/show_bug.cgi?id=80287
  11204. Reviewed by Antonio Gomes.
  11205. Update so we are sure we can build our implementation of DRT.
  11206. * DumpRenderTree/DumpRenderTree.h: include DumpRenderTreeBlackBerry.h.
  11207. * DumpRenderTree/PixelDumpSupport.cpp: include PixelDumpSupportBlackBerry.h.
  11208. * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp:
  11209. (AccessibilityController::addNotificationListener): add missing hook.
  11210. (AccessibilityController::removeNotificationListener): add missing hook.
  11211. * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp:
  11212. (AccessibilityUIElement::isSelectedOptionActive): add missing hook.
  11213. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  11214. (LayoutTestController::setMockSpeechInputDumpRect): add missing hook.
  11215. (LayoutTestController::simulateDesktopNotificationClick): add missing hook.
  11216. 2012-03-05 No'am Rosenthal <noam.rosenthal@nokia.com>
  11217. [Qt] [WK2] Support threaded renderer in WK2
  11218. https://bugs.webkit.org/show_bug.cgi?id=76661
  11219. Remove the QML_NO_THREADED_RENDERER environment variable from MiniBrowser.
  11220. Reviewed by Kenneth Rohde Christiansen.
  11221. * MiniBrowser/qt/main.cpp:
  11222. (main):
  11223. 2012-03-05 Alexander Færøy <alexander.faeroy@nokia.com>
  11224. Unreviewed. Add myself to committer list.
  11225. * Scripts/webkitpy/common/config/committers.py:
  11226. 2012-03-05 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11227. [Qt] Use config test to determine if the compiler supports -MD
  11228. We used to assume that unix systems building against Qt5 would have
  11229. a compiler that supported -MD. Although this was usually the case,
  11230. we failed to take into account broken tools for distributed builds
  11231. (e.g. teambuilder or icecream) which would end up producing .d files
  11232. in the root of the build dir instead of along-side the object file.
  11233. Now that we use a config-test to determine the support, we'll capture
  11234. those cases, unless distributed builds are enabled after the initial
  11235. build-webkit run.
  11236. Reviewed by Csaba Osztrogonác.
  11237. * Tools.pro:
  11238. * qmake/config.tests/gccdepends/empty.cpp: Added.
  11239. * qmake/config.tests/gccdepends/gccdepends.pro: Added.
  11240. * qmake/mkspecs/features/default_pre.prf:
  11241. * qmake/mkspecs/features/features.prf:
  11242. * qmake/mkspecs/features/unix/default_pre.prf:
  11243. * qmake/sync.profile:
  11244. 2012-03-05 Csaba Osztrogonác <ossy@webkit.org>
  11245. Qt API test buildstep throws exception after buildmaster update
  11246. https://bugs.webkit.org/show_bug.cgi?id=80249
  11247. Reviewed by Zoltan Herczeg.
  11248. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Disable API tests on the Qt bot temporarily.
  11249. (BuildAndTestFactory.__init__):
  11250. 2012-03-04 Martin Robinson <mrobinson@igalia.com>
  11251. [GTK] Unit tests are noisy when run under jhbuild
  11252. https://bugs.webkit.org/show_bug.cgi?id=80241
  11253. Reviewed by Philippe Normand.
  11254. Force the 'memory' backend in GSettings so that each unit
  11255. test doesn't produce a warning when it's forced to fall back
  11256. to the 'memory' backend.
  11257. * Scripts/run-gtk-tests:
  11258. (TestRunner.run): Force the 'memory' backend.
  11259. 2012-03-04 Martin Robinson <mrobinson@igalia.com>
  11260. [GTK] "Console: undefined @0: ReferenceError: Can't find variable: WebInspector" during testwebinspector
  11261. https://bugs.webkit.org/show_bug.cgi?id=80235
  11262. Reviewed by Philippe Normand.
  11263. * Scripts/run-gtk-tests:
  11264. (TestRunner.run): Use the WEBKIT_INSPECTOR_PATH environment variable so that
  11265. inspector resources path determination is shared by all tests.
  11266. 2012-03-04 Martin Robinson <mrobinson@igalia.com>
  11267. [GTK] REGRESSION: r108278 broke some tests that expect focus
  11268. https://bugs.webkit.org/show_bug.cgi?id=79084
  11269. Reviewed by Philippe Normand.
  11270. Grab focus when dumping test results and also when sending
  11271. events. During the course of testing, the WebView may lose
  11272. focus and this seems to snap it back when tests demand it.
  11273. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  11274. (dump): Grab focus.
  11275. * DumpRenderTree/gtk/EventSender.cpp:
  11276. (dispatchEvent): Ditto.
  11277. 2012-03-04 Charles Wei <charles.wei@torchmobile.com.cn>
  11278. Unreviewed, Add myself to committer list.
  11279. https://bugs.webkit.org/show_bug.cgi?id=80232
  11280. * Scripts/webkitpy/common/config/committers.py:
  11281. 2012-03-04 Anders Carlsson <andersca@apple.com>
  11282. Newer versions of clang fail to compile WebKit.
  11283. Fix build.
  11284. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  11285. (descriptionOfValue):
  11286. (AccessibilityUIElement::rowIndexRange):
  11287. (AccessibilityUIElement::columnIndexRange):
  11288. (AccessibilityUIElement::selectedTextRange):
  11289. * DumpRenderTree/mac/EditingDelegate.mm:
  11290. (-[DOMRange dump]):
  11291. * DumpRenderTree/mac/PolicyDelegate.mm:
  11292. (-[PolicyDelegate webView:unableToImplementPolicyWithError:frame:]):
  11293. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  11294. (-[NSError _drt_descriptionSuitableForTestResult]):
  11295. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  11296. (WTR::descriptionOfValue):
  11297. (WTR::AccessibilityUIElement::rowIndexRange):
  11298. (WTR::AccessibilityUIElement::columnIndexRange):
  11299. (WTR::AccessibilityUIElement::selectedTextRange):
  11300. 2012-03-03 Simon Hausmann <simon.hausmann@nokia.com>
  11301. [Qt] Fix static_libs_as_shared build
  11302. https://bugs.webkit.org/show_bug.cgi?id=80214
  11303. Reviewed by Tor Arne Vestbø.
  11304. * WebKitTestRunner/qt/main.cpp:
  11305. (main): Set the correct environment variable for choosing the theme in the
  11306. web process.
  11307. 2012-03-03 Hans Wennborg <hans@chromium.org>
  11308. Implement Speech JavaScript API
  11309. https://bugs.webkit.org/show_bug.cgi?id=80019
  11310. Reviewed by Adam Barth.
  11311. Add ENABLE_SCRIPTED_SPEECH.
  11312. * Scripts/build-webkit:
  11313. * qmake/mkspecs/features/features.prf:
  11314. 2012-03-02 Alexey Proskuryakov <ap@apple.com>
  11315. Fix commit queue, remove duplicate entry.
  11316. * Scripts/webkitpy/common/config/committers.py:
  11317. 2012-03-02 Stephen Chenney <schenney@chromium.org>
  11318. Unreviewed, add myself as a committer
  11319. * Scripts/webkitpy/common/config/committers.py:
  11320. 2012-03-02 Ojan Vafai <ojan@chromium.org>
  11321. Add the Chromium Lion canary bot to the flakiness dashboard.
  11322. * TestResultServer/static-dashboards/builders.js:
  11323. 2012-03-02 Dirk Pranke <dpranke@chromium.org>
  11324. links for virtual tests are broken in the flakiness dashboard
  11325. https://bugs.webkit.org/show_bug.cgi?id=80180
  11326. Reviewed by Ojan Vafai.
  11327. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  11328. (linkHTMLToOpenWindow):
  11329. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  11330. (testLinkHTMLToOpenWindow): added.
  11331. 2012-03-02 Philippe Normand <pnormand@igalia.com>
  11332. [GTK] security/block-test.html baselines differ from mac
  11333. https://bugs.webkit.org/show_bug.cgi?id=78343
  11334. Reviewed by Martin Robinson.
  11335. Improved the FrameLoader error heuristics to match mac behavior a
  11336. bit more.
  11337. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  11338. (pathFromSoupURI): Handle ftp urls the same as http urls.
  11339. (descriptionSuitableForTestResult): Map WebKitPolicyError to WebKitErrorDomain.
  11340. 2012-03-02 Andras Becsi <andras.becsi@nokia.com>
  11341. [Qt][WK2] Fix typo in patch committed in r109575
  11342. Unreviewed typo fix.
  11343. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  11344. (MiniBrowserApplication::notify): Cache the position
  11345. in floating point coordinates.
  11346. 2012-03-02 Andras Becsi <andras.becsi@nokia.com>
  11347. [Qt][WK2] Infinite loop on history navigation, when panning
  11348. https://bugs.webkit.org/show_bug.cgi?id=79119
  11349. Reviewed by Simon Hausmann.
  11350. Make the touch mocking more robust by creating touch events
  11351. directly and sending them synchronously to the browser window.
  11352. If the sent touch event was not accepted we propagate the
  11353. original mouse event to its target.
  11354. This way we make sure we only send either a touch or a mouse
  11355. event and do not end up in an infinite loop between our mocking
  11356. code and the Qt5 automatic mouse event synthesizing.
  11357. * MiniBrowser/qt/BrowserWindow.cpp:
  11358. (BrowserWindow::updateVisualMockTouchPoints):
  11359. * MiniBrowser/qt/BrowserWindow.h:
  11360. (BrowserWindow):
  11361. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  11362. (touchRectForPosition):
  11363. (MiniBrowserApplication::notify):
  11364. (MiniBrowserApplication::sendTouchEvent):
  11365. * MiniBrowser/qt/MiniBrowserApplication.h:
  11366. (MiniBrowserApplication):
  11367. 2012-03-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11368. [Qt] Use 'all' as default target when debug_and_release is in effect
  11369. When debug_and_release is enabled, in combination with build_all,
  11370. qmake will generate an aggregate makefile that calls make on both
  11371. the debug and the release makefiles, but with the 'all' target.
  11372. In this case we can't use 'first' as the default target, as the
  11373. extra targets would then not be run, so we append extra targets
  11374. to 'all' instead.
  11375. Reviewed by Simon Hausmann.
  11376. * qmake/mkspecs/features/default_post.prf:
  11377. 2012-03-02 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11378. [Qt] Make sure activeBuildConfig() returns the right config
  11379. Using isActiveConfig fails, as that only checks if the given
  11380. argument is in CONFIG, not the order.
  11381. Reviewed by Simon Hausmann.
  11382. * qmake/mkspecs/features/functions.prf:
  11383. 2012-03-02 Simon Hausmann <simon.hausmann@nokia.com>
  11384. [Qt] Fix tests run with WTR not using QStyle theme
  11385. https://bugs.webkit.org/show_bug.cgi?id=80147
  11386. Reviewed by Csaba Osztrogonác.
  11387. * WebKitTestRunner/qt/main.cpp:
  11388. (main): Set environment variable for web process to use QStyle theme.
  11389. 2012-03-02 Philippe Normand <pnormand@igalia.com>
  11390. Unreviewed, remove debug print call.
  11391. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  11392. (descriptionSuitableForTestResult):
  11393. 2012-03-02 Robert Kroeger <rjkroege@chromium.org>
  11394. Updated EventSender to send complete gesture events.
  11395. https://bugs.webkit.org/show_bug.cgi?id=80075
  11396. Reviewed by Adam Barth.
  11397. * DumpRenderTree/chromium/EventSender.cpp:
  11398. (EventSender::gestureEvent): set additional parameters in sent events.
  11399. 2012-03-01 Kalev Lember <kalevlember@gmail.com>
  11400. WebKitTestRunner: Explicitly include unistd.h for gcc 4.7
  11401. https://bugs.webkit.org/show_bug.cgi?id=80033
  11402. Reviewed by Gustavo Noronha Silva.
  11403. GCC 4.7 no longer includes unistd.h from most of the standard C++
  11404. header files, so we need to explicitly include it for getcwd().
  11405. * WebKitTestRunner/TestInvocation.cpp: Make sure unistd.h gets included
  11406. not only on Mac, but on all Unix platforms.
  11407. 2012-03-01 Dirk Pranke <dpranke@chromium.org>
  11408. Actually look at the args in driver_input :(.
  11409. Unreviewed, build fix.
  11410. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11411. (ChromiumDriver.run_test):
  11412. 2012-03-01 Dirk Pranke <dpranke@chromium.org>
  11413. Fix typo in flag used to run gpu virtual suites.
  11414. Unreviewed, build fix.
  11415. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11416. (ChromiumPort.virtual_test_suites):
  11417. 2012-03-01 Adam Barth <abarth@webkit.org>
  11418. Unreviewed, rolling out r109317.
  11419. http://trac.webkit.org/changeset/109317
  11420. Let's try watchlists again now that we're using a pure git
  11421. working copy
  11422. * Scripts/webkitpy/tool/bot/stylequeuetask.py:
  11423. (StyleQueueTask.run):
  11424. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  11425. 2012-03-01 Dirk Pranke <dpranke@chromium.org>
  11426. webkitpy: test_run_test_pause_before_testing is failing after r109482
  11427. https://bugs.webkit.org/show_bug.cgi?id=80084
  11428. Unreviewed, build fix.
  11429. Fixes the test string compare to ignore the time spent running
  11430. the tests.
  11431. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  11432. (test_run_test_pause_before_testing):
  11433. 2012-03-01 Dirk Pranke <dpranke@chromium.org>
  11434. nrwt: virtual tests aren't being run
  11435. https://bugs.webkit.org/show_bug.cgi?id=80083
  11436. Reviewed by Eric Seidel.
  11437. If we tried to run all of the tests by default (and
  11438. didn't specify any paths), the virtual tests weren't
  11439. picked up.
  11440. * Scripts/webkitpy/layout_tests/port/base.py:
  11441. (Port._virtual_tests):
  11442. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  11443. (PortTest.test_tests):
  11444. * Scripts/webkitpy/layout_tests/port/test.py:
  11445. (TestPort.virtual_test_suites):
  11446. 2012-03-01 Ryosuke Niwa <rniwa@webkit.org>
  11447. run-perf-tests should report the test runtime
  11448. https://bugs.webkit.org/show_bug.cgi?id=80078
  11449. Reviewed by Hajime Morita.
  11450. Record and output the aggreated test run time.
  11451. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  11452. (PerfTestsRunner._run_single_test):
  11453. 2012-03-01 Michael Nordman <michaeln@google.com>
  11454. [chromium] Use webkit_support to create session storage namespaces in DRT.
  11455. https://bugs.webkit.org/show_bug.cgi?id=79933
  11456. Reviewed by Tony Chang.
  11457. * DumpRenderTree/chromium/WebViewHost.cpp:
  11458. (WebViewHost::createSessionStorageNamespace):
  11459. 2012-03-01 Dirk Pranke <dpranke@chromium.org>
  11460. nrwt: test_isfile, test_isdir, and test_exists don't work for virtual tests
  11461. https://bugs.webkit.org/show_bug.cgi?id=80048
  11462. Reviewed by Adam Barth.
  11463. * Scripts/webkitpy/layout_tests/port/base.py:
  11464. (Port.test_isfile):
  11465. (Port.test_isdir):
  11466. (Port):
  11467. (Port.test_exists):
  11468. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  11469. (PortTest.test_test_exists):
  11470. (PortTest):
  11471. (PortTest.test_test_isfile):
  11472. (PortTest.test_test_isdir):
  11473. * Scripts/webkitpy/layout_tests/port/test.py:
  11474. (TestPort.virtual_test_suites):
  11475. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  11476. (MainTest.test_virtual):
  11477. 2012-03-01 Kalev Lember <kalevlember@gmail.com>
  11478. [GTK] Avoid building any parts of WebKitTestRunner when WK2 is disabled
  11479. https://bugs.webkit.org/show_bug.cgi?id=80031
  11480. Reviewed by Gustavo Noronha Silva.
  11481. Only build the libTestRunnerInjectedBundle.la convenience library when
  11482. ENABLE_WEBKIT2 is defined.
  11483. * WebKitTestRunner/GNUmakefile.am:
  11484. 2012-03-01 Philippe Normand <pnormand@igalia.com>
  11485. Unreviewed, second attempt to fix GTK NRWT after r109242.
  11486. * Scripts/webkitpy/layout_tests/port/gtk.py:
  11487. (GtkDriver._start):
  11488. 2012-03-01 Philippe Normand <pnormand@igalia.com>
  11489. Unreviewed, GTK NRWT build fix attempt after r109242.
  11490. * Scripts/webkitpy/layout_tests/port/gtk.py:
  11491. (GtkDriver._start):
  11492. 2012-03-01 Kentaro Hara <haraken@chromium.org>
  11493. REGRESSION(r109036): run-bindings-tests fails because resolve-supplemental.pl was renamed
  11494. https://bugs.webkit.org/show_bug.cgi?id=80008
  11495. Reviewed by Adam Barth.
  11496. In r109036, I forgot to rename "resolve-supplemental.pl" in run-bindings-tests
  11497. to "preprocess-idls.pl". This patch renames it.
  11498. Test: Confirm that run-bindings-tests runs.
  11499. * Scripts/webkitpy/bindings/main.py:
  11500. (BindingsTests.generate_supplemental_dependency):
  11501. 2012-02-29 Simon Hausmann <simon.hausmann@nokia.com>
  11502. [Qt][WK2] QQuickWebView::event should lookup faster which events QQuickWebPage can handle
  11503. https://bugs.webkit.org/show_bug.cgi?id=78047
  11504. Reviewed by Kenneth Rohde Christiansen.
  11505. Send events for the webview through the QQuickCanvas instead of directly to the item. Direct
  11506. sending to the item requires the QObject::event re-implementation to dispatch to the correct
  11507. event handling function. However QQuickItem::event doesn't do that. Instead QQuickCanvas calls
  11508. the event handlers directly, and with the removal of our own dispatching we need to go through
  11509. that code path.
  11510. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  11511. (WTR::PlatformWebView::sendEvent):
  11512. (WTR::PlatformWebView::postEvent):
  11513. 2012-02-29 Adam Barth <abarth@webkit.org>
  11514. Disable watchlist. It's been spamming CCs.
  11515. * Scripts/webkitpy/tool/bot/stylequeuetask.py:
  11516. (StyleQueueTask.run):
  11517. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  11518. 2012-02-29 Dirk Pranke <dpranke@chromium.org>
  11519. need to clone the gpu baselines and expectations into the new "virtual" dir
  11520. https://bugs.webkit.org/show_bug.cgi?id=79956
  11521. Reviewed by Adam Barth.
  11522. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11523. (ChromiumPort.virtual_test_suites):
  11524. 2012-02-29 Mark Rowe <mrowe@apple.com>
  11525. Switch to using json rather than simplejson now that the master is using Python 2.7.
  11526. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  11527. (loadBuilderConfig):
  11528. 2012-02-29 David Levin <levin@chromium.org>
  11529. [chromium] Add the ability to turn off autoresize.
  11530. https://bugs.webkit.org/show_bug.cgi?id=77452
  11531. Reviewed by Darin Fisher.
  11532. * DumpRenderTree/chromium/LayoutTestController.cpp:
  11533. (LayoutTestController::LayoutTestController): Expose a way to turn off auto-resize.
  11534. (LayoutTestController::enableAutoResizeMode): Ditto and adjust to new WebKit api.
  11535. (LayoutTestController::disableAutoResizeMode): Ditto.
  11536. * DumpRenderTree/chromium/LayoutTestController.h: Ditto.
  11537. 2012-02-29 Dirk Pranke <dpranke@chromium.org>
  11538. nrwt: make --print trace work with virtual tests
  11539. https://bugs.webkit.org/show_bug.cgi?id=79952
  11540. Reviewed by Adam Barth.
  11541. * Scripts/webkitpy/layout_tests/views/printing.py:
  11542. (Printer._print_test_trace):
  11543. (Printer._print_baseline):
  11544. 2012-02-28 Brian Weinstein <bweinstein@apple.com>
  11545. WebKit2: didNewFirstVisuallyNonEmptyLayout should be sent to injected bundle
  11546. https://bugs.webkit.org/show_bug.cgi?id=79849
  11547. Reviewed by Beth Dakin.
  11548. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  11549. (WTR::InjectedBundlePage::InjectedBundlePage): Add an entry to the struct.
  11550. 2012-02-29 Lucas Forschler <lforschler@apple.com>
  11551. Removed unused Apple buildslaves from the master configuration
  11552. https://bugs.webkit.org/show_bug.cgi?id=79925
  11553. Reviewed by Stephanie Lewis.
  11554. * BuildSlaveSupport/build.webkit.org-config/config.json:
  11555. 2012-02-29 Dirk Pranke <dpranke@chromium.org>
  11556. nrwt: implement simple 'virtual test suite' support
  11557. https://bugs.webkit.org/show_bug.cgi?id=79737
  11558. Reviewed by Adam Barth.
  11559. Add very basic support for 'virtual test suites' to NRWT:
  11560. a virtual suite is a directory that may contain new baselines,
  11561. contains a pointer to a "base" directory of tests, and an
  11562. optional list of command line arguments to pass to DRT;
  11563. it gives us a way to run all of the tests in a given directory
  11564. multiple times with multiple (potentially differing) sets of
  11565. results and baselines.
  11566. This patch implements the support needed for this feature, and
  11567. some basic tests, but no actual port will use the feature yet.
  11568. This is probably the simplest implementation possible - the
  11569. list of virtual suites will be hard-coded into the port's
  11570. implementation. One can imagine a more data-driven approach
  11571. where the suite instructions are stored in a manifest file
  11572. either in LayoutTests (all suites in one file), or per-port,
  11573. or per-directory. If this feature ends up being useful we
  11574. should probably add something like that so people don't have
  11575. to hunt around in the code to add suites.
  11576. * Scripts/webkitpy/layout_tests/port/base.py:
  11577. (Port.__init__):
  11578. (Port.expected_filename):
  11579. (Port.tests):
  11580. (Port):
  11581. (Port._real_tests):
  11582. (Port._driver_class):
  11583. (Port.virtual_test_suites):
  11584. (Port.virtual_suite):
  11585. (Port.virtual_suite.VirtualTestSuite):
  11586. (Port.virtual_suite.VirtualTestSuite.__init__):
  11587. (Port.virtual_suite.VirtualTestSuite.__repr__):
  11588. (Port.populated_virtual_test_suites):
  11589. (Port._virtual_tests):
  11590. (Port.lookup_virtual_test_base):
  11591. (Port.lookup_virtual_test_args):
  11592. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  11593. (PortTest.test_find_with_skipped_directories):
  11594. * Scripts/webkitpy/layout_tests/port/driver.py:
  11595. (DriverInput.__init__):
  11596. (DriverProxy.run_test):
  11597. * Scripts/webkitpy/layout_tests/port/test.py:
  11598. (TestPort.virtual_test_suites):
  11599. (TestDriver.run_test):
  11600. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  11601. (MainTest.test_all):
  11602. (MainTest.test_virtual):
  11603. 2012-02-29 Dirk Pranke <dpranke@chromium.org>
  11604. nrwt: support more than two drivers in DriverProxy
  11605. https://bugs.webkit.org/show_bug.cgi?id=79736
  11606. Reviewed by Adam Barth.
  11607. Now that we can support per-test command lines for
  11608. Drivers, modify DriverProxy to keep a map of running
  11609. drivers for each needed command-line; this will allow
  11610. us to transparently maintain a pool of appropriately
  11611. configured DRTs without having to constantly start and stop
  11612. them.
  11613. Note that this potentially raises a garbage collection
  11614. problem - the number of running DRTs will grow with the
  11615. number of different sets of command line args. For now
  11616. this is no worse than the current code - if you're running
  11617. with pixel tests, you will only need one DRT per worker,
  11618. and if you aren't, you'll need two (one for text-only tests,
  11619. and one for reftests).
  11620. An alternative would be to only ever have one running driver,
  11621. and restart the driver as the command line changes, but this
  11622. might (?) slow down execution in the text-only case - we
  11623. should benchmark this because it would be simpler and possibly
  11624. allow us to eliminate DriverProxy altogether.
  11625. * Scripts/webkitpy/layout_tests/port/driver.py:
  11626. (DriverProxy.__init__):
  11627. (DriverProxy):
  11628. (DriverProxy._make_driver):
  11629. (DriverProxy.run_test):
  11630. (DriverProxy.has_crashed):
  11631. (DriverProxy.stop):
  11632. (DriverProxy.cmd_line):
  11633. (DriverProxy._cmd_line_as_key):
  11634. 2012-02-29 Adrienne Walker <enne@google.com>
  11635. Unreviewed, add myself as a reviewer
  11636. * Scripts/webkitpy/common/config/committers.py:
  11637. 2012-02-29 Greg Billock <gbillock@google.com>
  11638. Add more tests for web intents
  11639. https://bugs.webkit.org/show_bug.cgi?id=79527
  11640. Reviewed by Adam Barth.
  11641. * DumpRenderTree/chromium/LayoutTestController.cpp:
  11642. (LayoutTestController::LayoutTestController):
  11643. (LayoutTestController::sendWebIntentResponse):
  11644. * DumpRenderTree/chromium/LayoutTestController.h:
  11645. (LayoutTestController):
  11646. * DumpRenderTree/chromium/WebViewHost.h:
  11647. (WebViewHost):
  11648. (WebViewHost::currentIntentRequest):
  11649. 2012-02-29 Dirk Pranke <dpranke@chromium.org>
  11650. nrwt: port/Driver needs to support per-test command line args
  11651. https://bugs.webkit.org/show_bug.cgi?id=79733
  11652. Reviewed by Adam Barth.
  11653. As part of removing the 'gpu' configurations and adding support
  11654. for 'virtual test suites', the Driver classes need to support
  11655. per-test command lines (since different tests will need to be
  11656. run with different command line options).
  11657. The per-test args are not yet used, so this change should have
  11658. no visible effects and need no additional testing.
  11659. * Scripts/webkitpy/layout_tests/port/base.py:
  11660. (Port.driver_cmd_line):
  11661. * Scripts/webkitpy/layout_tests/port/chromium.py:
  11662. (ChromiumDriver.cmd_line):
  11663. (ChromiumDriver._start):
  11664. (ChromiumDriver.start):
  11665. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  11666. (ChromiumDriverTest.test_two_drivers.MockDriver.cmd_line):
  11667. (ChromiumDriverTest):
  11668. (ChromiumDriverTest.test_two_drivers):
  11669. * Scripts/webkitpy/layout_tests/port/driver.py:
  11670. (Driver.cmd_line):
  11671. (DriverProxy.__init__):
  11672. (DriverProxy.start):
  11673. (DriverProxy.cmd_line):
  11674. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  11675. (DriverTest.test_virtual_driver_methods):
  11676. * Scripts/webkitpy/layout_tests/port/gtk.py:
  11677. (GtkDriver.cmd_line):
  11678. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  11679. * Scripts/webkitpy/layout_tests/port/test.py:
  11680. (TestPort._path_to_driver):
  11681. (TestDriver.cmd_line):
  11682. (TestDriver.start):
  11683. * Scripts/webkitpy/layout_tests/port/webkit.py:
  11684. (WebKitDriver.cmd_line):
  11685. (WebKitDriver._start):
  11686. (WebKitDriver.run_test):
  11687. (WebKitDriver.start):
  11688. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  11689. (WebKitDriverTest.test_no_timeout):
  11690. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  11691. (PerfTestsRunner._run_tests_set):
  11692. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  11693. (test_run_test_pause_before_testing):
  11694. 2012-02-29 Dirk Pranke <dpranke@chromium.org>
  11695. perftestsrunner can call printer.write() after printer.cleanup()
  11696. https://bugs.webkit.org/show_bug.cgi?id=79872
  11697. Reviewed by Ryosuke Niwa.
  11698. This patch fixes a unittest that was incorrectly calling
  11699. PerfTestsRunner.run() twice (which led to a weird state in the
  11700. printer object).
  11701. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  11702. (MainTest.test_run_with_upload_json):
  11703. 2012-02-29 Balazs Kelemen <kbalazs@webkit.org>
  11704. [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
  11705. https://bugs.webkit.org/show_bug.cgi?id=76546
  11706. Reviewed by Simon Hausmann.
  11707. Revert the workaround introduced in r107868 and reintroduce
  11708. the qml binding so we can test the code path that we are more
  11709. interested in. The reason that it did not work before is that
  11710. we don't have an active platform window which we now workaround
  11711. by propagating the resize through QWindowSystemInterface.
  11712. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  11713. (WTR::WrapperWindow::handleStatusChanged):
  11714. (WTR::PlatformWebView::resizeTo):
  11715. 2012-02-29 Gabor Rapcsanyi <rgabor@webkit.org>
  11716. [GTK] Small fix for cross compilation to not generate gtkdoc.
  11717. Rubber-stamped by Csaba Osztrogonác.
  11718. * Scripts/webkitdirs.pm:
  11719. (isCrossCompilation):
  11720. 2012-02-28 Lucas Forschler <lforschler@apple.com>
  11721. Fix a typo in config.json
  11722. linx -> linux
  11723. * BuildSlaveSupport/build.webkit.org-config/config.json:
  11724. 2012-02-28 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  11725. [Qt] Allow read/write to the WebView.url property
  11726. https://bugs.webkit.org/show_bug.cgi?id=77554
  11727. Reviewed by Tor Arne Vestbø.
  11728. Fix MiniBrowser to use WebView.url property and remove WebView.load usage.
  11729. * MiniBrowser/qt/qml/BrowserWindow.qml:
  11730. 2012-02-28 Dan Winship <danw@gnome.org>
  11731. [GTK] make tests explicitly request GSettingsBackendMemory
  11732. https://bugs.webkit.org/show_bug.cgi?id=79788
  11733. Reviewed by Martin Robinson.
  11734. Explicitly request the fallback memory-based GSettings backend; if
  11735. other backends are available then we don't want to use them,
  11736. because they would make tests depend on the user's preferences.
  11737. And if other backends aren't available, we don't need glib to
  11738. print a warning about that fact.
  11739. * Scripts/webkitpy/layout_tests/port/gtk.py:
  11740. (GtkPort.setup_environ_for_server):
  11741. 2012-02-28 Sheriff Bot <webkit.review.bot@gmail.com>
  11742. Unreviewed, rolling out r109110.
  11743. http://trac.webkit.org/changeset/109110
  11744. https://bugs.webkit.org/show_bug.cgi?id=79806
  11745. webkitpy makes it too easy to add wkb.ug URLs to ChangeLogs
  11746. (Requested by aroben on #webkit).
  11747. * Scripts/webkitpy/common/checkout/changelog.py:
  11748. (parse_bug_id):
  11749. (parse_bug_id_from_changelog):
  11750. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  11751. * Scripts/webkitpy/common/config/urls.py:
  11752. 2012-02-28 Adam Roben <aroben@webkit.org>
  11753. Add my new email address
  11754. Fixes <http://wkb.ug/79797> Adam Roben's email address in webkitpy is soon to be incorrect
  11755. Reviewed by Anders Carlsson.
  11756. * Scripts/webkitpy/common/config/committers.py:
  11757. 2012-02-28 Adam Roben <aroben@apple.com>
  11758. Teach webkitpy about wkb.ug URLs
  11759. Fixes <http://wkb.ug/79799> webkit-patch can't find bug numbers from ChangeLog entries that
  11760. use wkb.ug URLs
  11761. Reviewed by Anders Carlsson.
  11762. * Scripts/webkitpy/common/checkout/changelog.py:
  11763. (parse_bug_id):
  11764. (parse_bug_id_from_changelog):
  11765. Fall back to the tiny URL format if neither the short nor long URL formats work.
  11766. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  11767. (ChangeLogTest.test_parse_bug_id_from_changelog): Added tests for the above changes.
  11768. * Scripts/webkitpy/common/config/urls.py: Added bug_url_tiny, which can be used to match
  11769. wkb.ug URLs.
  11770. 2012-02-28 János Badics <dicska@gmail.com>
  11771. [Qt] build-webkit does not detect the number of CPUs
  11772. https://bugs.webkit.org/show_bug.cgi?id=76445
  11773. Based on Seo Sanghyeon's work (modification:
  11774. Automatically determine the number of CPUs for make
  11775. only if -j make argument haven't already been specified.)
  11776. Reviewed by Csaba Osztrogonác.
  11777. * Scripts/webkitdirs.pm:
  11778. (buildQMakeProjects):
  11779. 2012-02-28 Kent Tamura <tkent@chromium.org>
  11780. Update a pattern for forms files of watchlist
  11781. https://bugs.webkit.org/show_bug.cgi?id=79767
  11782. Reviewed by Kentaro Hara.
  11783. * Scripts/webkitpy/common/config/watchlist:
  11784. Catches the following files with the "Forms" pattern.
  11785. - HTMLDatListElement.*
  11786. - HTMLKeygenElement.*
  11787. - HTMLLegendElement.*
  11788. - HTMLOutputElement.*
  11789. - FormAssociatedElement.*
  11790. - SliderThumbElement.*
  11791. - TextControlInnerElements.*
  11792. - RenderFileUploadControl.*
  11793. 2012-02-27 Sheriff Bot <webkit.review.bot@gmail.com>
  11794. Unreviewed, rolling out r109041.
  11795. http://trac.webkit.org/changeset/109041
  11796. https://bugs.webkit.org/show_bug.cgi?id=79741
  11797. Broke Chromium Win build (Requested by bashi on #webkit).
  11798. * DumpRenderTree/chromium/LayoutTestController.cpp:
  11799. (LayoutTestController::LayoutTestController):
  11800. * DumpRenderTree/chromium/LayoutTestController.h:
  11801. (LayoutTestController):
  11802. * DumpRenderTree/chromium/WebViewHost.h:
  11803. 2012-02-27 James Robinson <jamesr@chromium.org>
  11804. [chromium] Remove media tests from ChromiumGpu configurations
  11805. https://bugs.webkit.org/show_bug.cgi?id=79720
  11806. Reviewed by Adam Barth.
  11807. We no longer need to run the media/ tests in both GPU and non-GPU configurations since we can exercise the GPU
  11808. composited playback path via tests in the compositing/ directory.
  11809. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  11810. (_default_tests_paths):
  11811. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  11812. (ChromiumGpuTest.test_default_tests_paths):
  11813. (ChromiumGpuTest.test_test_files):
  11814. 2012-02-27 Dirk Pranke <dpranke@chromium.org>
  11815. nrwt: log multiline stderr/crash output properly
  11816. https://bugs.webkit.org/show_bug.cgi?id=79722
  11817. Reviewed by Adam Barth.
  11818. This cleans up some nits in the log output to make things
  11819. slightly easier to read (every line gets timestamped, etc.).
  11820. Also tweaks the log message for pixel hash mismatches.
  11821. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  11822. (SingleTestRunner._handle_error):
  11823. (SingleTestRunner._compare_image):
  11824. 2012-02-27 Ryosuke Niwa <rniwa@webkit.org>
  11825. Touch the master.cfg to force a reconfig.
  11826. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  11827. (BuildAndTestLeaksFactory):
  11828. (NewBuildAndTestFactory):
  11829. 2012-02-27 Jacky Jiang <zhajiang@rim.com>
  11830. [BlackBerry] Upstream BlackBerry API web page related files
  11831. https://bugs.webkit.org/show_bug.cgi?id=74380
  11832. Reviewed by Antonio Gomes.
  11833. Adapt to the removing of WebPage::mainFrame(), use
  11834. DumpRenderTreeSupport::corePage() and its mainFrame() instead.
  11835. No new tests as this patch doesn't change behavior.
  11836. * DumpRenderTree/blackberry/DumpRenderTree.cpp:
  11837. (BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
  11838. (BlackBerry::WebKit::DumpRenderTree::runTests):
  11839. 2012-02-27 Ryosuke Niwa <rniwa@webkit.org>
  11840. Add Windows and Linux Chromium perf bots
  11841. https://bugs.webkit.org/show_bug.cgi?id=79418
  11842. Reviewed by Tony Chang.
  11843. Add Chromium Win and Linux perf bots. Also replace Chromium Mac by
  11844. the dedicated perf bot slave (uses the same hardware).
  11845. * BuildSlaveSupport/build.webkit.org-config/config.json:
  11846. 2012-02-27 Xianzhu Wang <wangxianzhu@chromium.org>
  11847. Undefined variable 'current' when running chromium_android.py
  11848. https://bugs.webkit.org/show_bug.cgi?id=79696
  11849. Reviewed by Adam Barth.
  11850. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11851. (ChromiumAndroidDriver._read_prompt):
  11852. 2012-02-27 Greg Billock <gbillock@google.com>
  11853. Add more tests for web intents
  11854. https://bugs.webkit.org/show_bug.cgi?id=79527
  11855. Reviewed by Adam Barth.
  11856. * DumpRenderTree/chromium/LayoutTestController.cpp:
  11857. (LayoutTestController::LayoutTestController):
  11858. (LayoutTestController::sendWebIntentResponse):
  11859. * DumpRenderTree/chromium/LayoutTestController.h:
  11860. (LayoutTestController):
  11861. * DumpRenderTree/chromium/WebViewHost.h:
  11862. (WebViewHost):
  11863. (WebViewHost::currentIntentRequest):
  11864. 2012-02-27 Xianzhu Wang <wangxianzhu@chromium.org>
  11865. Chromium-Android layout test script: the adb shell prompt is not always '# '
  11866. https://bugs.webkit.org/show_bug.cgi?id=79506
  11867. Reviewed by Adam Barth.
  11868. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11869. (ChromiumAndroidDriver._start):
  11870. (ChromiumAndroidDriver._read_prompt):
  11871. 2012-02-27 Dan Bernstein <mitz@apple.com>
  11872. Added a test for <rdar://problem/9557598> REGRESSION (WebKit2): Non-activating links sometimes don’t work
  11873. https://bugs.webkit.org/show_bug.cgi?id=79607
  11874. Reviewed by Adele Peterson.
  11875. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  11876. * TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm: Added.
  11877. (TestWebKitAPI::AcceptsFirstMouse::url):
  11878. (TestWebKitAPI::AcceptsFirstMouse::didLoadURL):
  11879. (TestWebKitAPI::AcceptsFirstMouse::runTest):
  11880. (TestWebKitAPI::TEST_F):
  11881. * TestWebKitAPI/Tests/mac/acceptsFirstMouse.html: Added.
  11882. 2012-02-27 Carlos Garcia Campos <cgarcia@igalia.com>
  11883. Unreviewed. Fix make distcheck.
  11884. * GNUmakefile.am: Fix typo.
  11885. 2012-02-27 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  11886. [Qt] Use USE() macro instead of ENABLE() for using the Qt image decoder
  11887. Reviewed by Kenneth Rohde Christiansen..
  11888. * qmake/mkspecs/features/features.prf:
  11889. 2012-02-27 Hao Zheng <zhenghao@chromium.org>
  11890. Add a ChromiumGpuAndroid port.
  11891. https://bugs.webkit.org/show_bug.cgi?id=79628
  11892. Reviewed by Adam Barth.
  11893. Android does have a gpu port, so revert r107697.
  11894. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  11895. (ChromiumAndroidPort.__init__):
  11896. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  11897. (ChromiumGpuAndroidPort):
  11898. (ChromiumGpuAndroidPort.__init__):
  11899. (ChromiumGpuAndroidPort.baseline_search_path):
  11900. (ChromiumGpuAndroidPort.default_child_processes):
  11901. (ChromiumGpuAndroidPort.tests):
  11902. * Scripts/webkitpy/layout_tests/port/factory.py:
  11903. (PortFactory):
  11904. 2012-02-25 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  11905. Change Build bot with BuildAndTest bot for EFL port.
  11906. https://bugs.webkit.org/show_bug.cgi?id=77518
  11907. Reviewed by Ryosuke Niwa.
  11908. EFL build bot starts to support layout test.
  11909. * BuildSlaveSupport/build.webkit.org-config/config.json:
  11910. * BuildSlaveSupport/built-product-archive:
  11911. (archiveBuiltProduct):
  11912. (extractBuiltProduct):
  11913. * BuildSlaveSupport/test-result-archive:
  11914. (archiveTestResults):
  11915. * Scripts/webkitdirs.pm: Enable SHARED_CORE option when ENABLE_DRT is enable in EFL port.
  11916. (generateBuildSystemFromCMakeProject):
  11917. 2012-02-24 Darin Fisher <darin@chromium.org>
  11918. Add watchlist for ChromiumPlatformApi matching Source/Platform/chromium/public/
  11919. Reviewed by James Robinson.
  11920. * Scripts/webkitpy/common/config/watchlist:
  11921. 2012-02-24 Dirk Pranke <dpranke@chromium.org>
  11922. webkitpy: changelog_unittest test_fuzzy_reviewer_match is slow
  11923. https://bugs.webkit.org/show_bug.cgi?id=79258
  11924. Reviewed by Ryosuke Niwa.
  11925. Split the fuzzy matching into separate functions so that they
  11926. can be sharded and run in parallel.
  11927. Also, fix a bug in the svn_blame_regexp that was causing us
  11928. to require ChangeLog lines to have at least one space after the
  11929. author, making the code require trailing whitespace in the
  11930. changelog in some places (this was making my life harder because
  11931. I have my text editor set to strip trailing whitespace in python
  11932. files, and that was causing test_parse_log_entries_from_changelog() to fail
  11933. when the whitespace on line 275 was removed).
  11934. * Scripts/webkitpy/common/checkout/changelog.py:
  11935. (ChangeLog):
  11936. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  11937. (test_fuzzy_reviewer_match__none):
  11938. (test_fuzzy_reviewer_match_adam_barth):
  11939. (test_fuzzy_reviewer_match_darin_adler_et_al):
  11940. (test_fuzzy_reviewer_match_dimitri_glazkov):
  11941. (test_fuzzy_reviewer_match_george_staikos):
  11942. (test_fuzzy_reviewer_match_mark_rowe):
  11943. 2012-02-24 Dirk Pranke <dpranke@chromium.org>
  11944. webkitpy: committers_unittest fuzzy matching is really slow
  11945. https://bugs.webkit.org/show_bug.cgi?id=79179
  11946. Reviewed by Ryosuke Niwa.
  11947. Break the fuzzy matching tests into individual routines for
  11948. each contributor so that the intent is a little clearer, so
  11949. that it's easier to test individual names (and identify
  11950. duplicate tests), and so that we can eventually run
  11951. them in parallel.
  11952. Also, mark most of them as 'integration' tests so that they
  11953. can be skipped if we want to go fast (we leave a few as
  11954. regular tests for functional coverage).
  11955. * Scripts/webkitpy/common/config/committers_unittest.py:
  11956. (CommittersTest):
  11957. (CommittersTest.test_contributors_by_fuzzy_match):
  11958. (CommittersTest.integration_test_contributors__none):
  11959. (CommittersTest.integration_test_contributors__none_2):
  11960. (CommittersTest.integration_test_contributors__none_3):
  11961. (CommittersTest.integration_test_contributors_ada_chan):
  11962. (CommittersTest.integration_test_contributors_adele_peterson):
  11963. (CommittersTest.integration_test_contributors_alexey_proskuryakov):
  11964. (CommittersTest.integration_test_contributors_alice_liu):
  11965. (CommittersTest.integration_test_contributors_alp_toker):
  11966. (CommittersTest.integration_test_contributors_anders_carlsson):
  11967. (CommittersTest.integration_test_contributors_antti_koivisto):
  11968. (CommittersTest.integration_test_contributors_beth_dakin):
  11969. (CommittersTest.integration_test_contributors_brady_eidson):
  11970. (CommittersTest.integration_test_contributors_cameron_zwarich):
  11971. (CommittersTest.integration_test_contributors_chris_blumenberg):
  11972. (CommittersTest.integration_test_contributors_dan_bernstein):
  11973. (CommittersTest.integration_test_contributors_dan_bernstein_2):
  11974. (CommittersTest.integration_test_contributors_darin_adler):
  11975. (CommittersTest.integration_test_contributors_david_harrison):
  11976. (CommittersTest.integration_test_contributors_david_harrison_2):
  11977. (CommittersTest.integration_test_contributors_david_hyatt):
  11978. (CommittersTest.integration_test_contributors_david_kilzer):
  11979. (CommittersTest.integration_test_contributors_don_melton):
  11980. (CommittersTest.integration_test_contributors_eric_seidel):
  11981. (CommittersTest.integration_test_contributors_geoffrey_garen):
  11982. (CommittersTest.integration_test_contributors_greg_bolsinga):
  11983. (CommittersTest.integration_test_contributors_holger_freyther):
  11984. (CommittersTest.integration_test_contributors_jon_sullivan):
  11985. (CommittersTest.integration_test_contributors_jon_honeycutt):
  11986. (CommittersTest.integration_test_contributors_joseph_pecoraro):
  11987. (CommittersTest.integration_test_contributors_ken_kocienda):
  11988. (CommittersTest.integration_test_contributors_kenneth_russell):
  11989. (CommittersTest.integration_test_contributors_kevin_decker):
  11990. (CommittersTest.integration_test_contributors_kevin_mccullough):
  11991. (CommittersTest.integration_test_contributors_lars_knoll):
  11992. (CommittersTest.integration_test_contributors_lars_weintraub):
  11993. (CommittersTest.integration_test_contributors_maciej_stachowiak):
  11994. (CommittersTest.integration_test_contributors_mark_rowe):
  11995. (CommittersTest.integration_test_contributors_nikolas_zimmermann):
  11996. (CommittersTest.integration_test_contributors_oliver_hunt):
  11997. (CommittersTest.integration_test_contributors_rniwa):
  11998. (CommittersTest.disabled_integration_test_contributors_simon_fraser):
  11999. (CommittersTest.integration_test_contributors_steve_falkenburg):
  12000. (CommittersTest.integration_test_contributors_sam_weinig):
  12001. (CommittersTest.integration_test_contributors_tim_omernick):
  12002. (CommittersTest.integration_test_contributors_timothy_hatcher):
  12003. (CommittersTest.integration_test_contributors_tor_arne_vestbo):
  12004. (CommittersTest.integration_test_contributors_vicki_murley):
  12005. (CommittersTest.integration_test_contributors_zack_rusin):
  12006. 2012-02-24 Dirk Pranke <dpranke@chromium.org>
  12007. webkitpy: should autoinstall coverage
  12008. https://bugs.webkit.org/show_bug.cgi?id=79535
  12009. Reviewed by Eric Seidel.
  12010. We should automatically print the coverage report after the run, too.
  12011. * Scripts/webkitpy/test/main.py:
  12012. (Tester._run_tests):
  12013. * Scripts/webkitpy/thirdparty/__init__.py:
  12014. (AutoinstallImportHook.find_module):
  12015. (AutoinstallImportHook._install_coverage):
  12016. 2012-02-24 Pablo Flouret <pablof@motorola.com>
  12017. Fix copypasta in build-webkit's --vibration option description
  12018. https://bugs.webkit.org/show_bug.cgi?id=79528
  12019. Reviewed by Andreas Kling.
  12020. * Scripts/build-webkit:
  12021. 2012-02-24 Antonio Gomes <agomes@rim.com>
  12022. Adding myself to ScrollingCoordinator watchlist
  12023. https://bugs.webkit.org/show_bug.cgi?id=79525
  12024. Reviewed by Rob Buis.
  12025. * Scripts/webkitpy/common/config/watchlist:
  12026. 2012-02-24 Darin Fisher <darin@chromium.org>
  12027. Update watchlist for ChromiumPublicApi to include Platform/chromium/public/
  12028. Reviewed by Adam Barth.
  12029. * Scripts/webkitpy/common/config/watchlist:
  12030. 2012-02-24 Dirk Pranke <dpranke@chromium.org>
  12031. webkitpy: config_unittest is sensitive to other tests that might've already run
  12032. https://bugs.webkit.org/show_bug.cgi?id=79382
  12033. Reviewed by Adam Barth.
  12034. If another test runs prior to config_unittest and pokes the
  12035. cached configuration, the first test in config_unittest might
  12036. fail; the tearDown() will then allow subsequent tests to pass.
  12037. Clearing the configuration prior to each test makes things
  12038. slightly slower but safer.
  12039. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  12040. (ConfigTest.setUp):
  12041. 2012-02-24 David Kilzer <ddkilzer@apple.com>
  12042. Use xcrun to find compiler paths for Generate Derived Sources build phase script
  12043. <http://webkit.org/b/79512>
  12044. Reviewed by Dan Bernstein.
  12045. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  12046. (Generate Derived Sources): Use xcrun to find the path to the
  12047. compiler since that works on both iOS and OS X.
  12048. 2012-02-24 James Robinson <jamesr@chromium.org>
  12049. Create a watchlist for ScrollingCoordinator changes
  12050. https://bugs.webkit.org/show_bug.cgi?id=79511
  12051. Reviewed by Anders Carlsson.
  12052. * Scripts/webkitpy/common/config/watchlist:
  12053. 2012-02-24 Grzegorz Czajkowski <g.czajkowski@samsung.com>
  12054. [EFL][DRT] Implement setValueForUser and setAutofilled.
  12055. https://bugs.webkit.org/show_bug.cgi?id=79237
  12056. Reviewed by Andreas Kling.
  12057. Adds missing implementation setValueForUser and setAutofilled to EFL's LayoutTestController.
  12058. Those implementations are related with input fields and allow to pass following tests:
  12059. fast/forms/onchange-setvalueforuser.html
  12060. fast/forms/input-autofilled.html
  12061. fast/forms/reset-autofilled.html
  12062. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  12063. (LayoutTestController::setValueForUser):
  12064. (LayoutTestController::setAutofilled):
  12065. 2012-02-24 Zoltan Horvath <zoltan@webkit.org>
  12066. [Qt] Allow to use WebCore imagedecoders
  12067. https://bugs.webkit.org/show_bug.cgi?id=32410
  12068. Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
  12069. Reviewed by Simon Hausmann.
  12070. * qmake/mkspecs/features/features.prf:
  12071. 2012-02-24 Balazs Kelemen <kbalazs@webkit.org>
  12072. [Qt] Add Qt5 way to force 96 DPI for tests
  12073. https://bugs.webkit.org/show_bug.cgi?id=79364
  12074. Reviewed by Simon Hausmann.
  12075. * DumpRenderTree/qt/main.cpp:
  12076. (main):
  12077. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  12078. (WTR::activateFonts):
  12079. 2012-02-24 Carlos Garcia Campos <cgarcia@igalia.com>
  12080. [GTK] MiniBrowser should reload the view then the reload button is clicked
  12081. https://bugs.webkit.org/show_bug.cgi?id=79472
  12082. Reviewed by Philippe Normand.
  12083. * MiniBrowser/gtk/BrowserWindow.c:
  12084. (reloadCallback): Call webkit_web_view_reload().
  12085. (browser_window_init): Connect reload item clicked even to
  12086. reloadCallback instead of activateUriEntryCallback.
  12087. 2012-02-24 Kentaro Hara <haraken@chromium.org>
  12088. Add performance tests for DOM attribute getters and setters
  12089. https://bugs.webkit.org/show_bug.cgi?id=79208
  12090. Reviewed by Ryosuke Niwa.
  12091. We want to allow perf tests to output info messages
  12092. that do not affect the test results. To accomplish this,
  12093. this patch modifies perftestsrunner.py so that it ignores
  12094. a line that starts from "Info:".
  12095. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  12096. (PerfTestsRunner):
  12097. 2012-02-24 Andrew Lo <anlo@rim.com>
  12098. [BlackBerry] Enable requestAnimationFrame
  12099. https://bugs.webkit.org/show_bug.cgi?id=79408
  12100. Enable requestAnimationFrame for BlackBerry.
  12101. Reviewed by Rob Buis.
  12102. * Scripts/build-webkit:
  12103. 2012-02-24 Adam Barth <abarth@webkit.org>
  12104. style-queue tries to apply the patch twice
  12105. https://bugs.webkit.org/show_bug.cgi?id=79459
  12106. Reviewed by Eric Seidel.
  12107. Previously, we applied the patch using both apply-patch and
  12108. check-style. This patch introduces a check-style-local to mirror the
  12109. apply-watchlist-local, which operates on the current working diff.
  12110. This patch also cleans up some other bugs I found by running the queue
  12111. locally for a while. The queue still prints out a slightly
  12112. less-than-ideal message on the bugs when it find an error, but it's ok
  12113. for now. We'll need to iterate a bit.
  12114. * Scripts/webkitpy/tool/bot/stylequeuetask.py:
  12115. (StyleQueueTask.validate):
  12116. (StyleQueueTask._check_style):
  12117. * Scripts/webkitpy/tool/commands/download.py:
  12118. (CheckStyleLocal):
  12119. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  12120. (EarlyWarningSytemTest._default_expected_stderr):
  12121. (EarlyWarningSytemTest._test_testing_ews):
  12122. * Scripts/webkitpy/tool/commands/queues.py:
  12123. (AbstractReviewQueue.handle_script_error):
  12124. (StyleQueue.review_patch):
  12125. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  12126. * Scripts/webkitpy/tool/commands/queuestest.py:
  12127. (QueuesTest.assert_queue_outputs):
  12128. 2012-02-23 Adam Barth <abarth@webkit.org>
  12129. should_proceed_with_work_item is unused and can be removed
  12130. https://bugs.webkit.org/show_bug.cgi?id=79416
  12131. Reviewed by Eric Seidel.
  12132. We used to use this function to check whether the tree is red. Now, we
  12133. don't use external measures of whether to proceed with work items.
  12134. Instead, we analyze them with the idea in mind that the tree might be
  12135. red.
  12136. * Scripts/webkitpy/tool/bot/queueengine.py:
  12137. (QueueEngineDelegate.next_work_item):
  12138. (QueueEngine.run):
  12139. * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  12140. (LoggingDelegate):
  12141. (LoggingDelegate.next_work_item):
  12142. (RaisingDelegate.process_work_item):
  12143. (QueueEngineTest.test_terminating_error):
  12144. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  12145. (AbstractEarlyWarningSystem.__init__):
  12146. * Scripts/webkitpy/tool/commands/queues.py:
  12147. (AbstractQueue.next_work_item):
  12148. (FeederQueue.next_work_item):
  12149. (CommitQueue.next_work_item):
  12150. (AbstractReviewQueue.next_work_item):
  12151. (StyleQueue.__init__):
  12152. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  12153. (FeederQueueTest.test_feeder_queue):
  12154. (CommitQueueTest.test_commit_queue):
  12155. (test_commit_queue_failure):
  12156. (test_commit_queue_failure_with_failing_tests):
  12157. (test_rollout):
  12158. (test_rollout_lands):
  12159. (StyleQueueTest.test_style_queue_with_style_exception):
  12160. (test_style_queue_with_watch_list_exception):
  12161. * Scripts/webkitpy/tool/commands/queuestest.py:
  12162. (QueuesTest.assert_queue_outputs):
  12163. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  12164. (SheriffBot.next_work_item):
  12165. 2012-02-23 Adrienne Walker <enne@google.com>
  12166. Unreviewed, add Stephen Chenney to committers.py as a contributor.
  12167. * Scripts/webkitpy/common/config/committers.py:
  12168. 2012-02-23 Adam Barth <abarth@webkit.org>
  12169. style-queue logs bogus messages to the QueueStatusServer
  12170. https://bugs.webkit.org/show_bug.cgi?id=79424
  12171. Reviewed by Eric Seidel.
  12172. Copy/paste error.
  12173. * Scripts/webkitpy/tool/bot/stylequeuetask.py:
  12174. (StyleQueueTask._check_style):
  12175. (StyleQueueTask._apply_watch_list):
  12176. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  12177. 2012-02-23 Eric Seidel <eric@webkit.org>
  12178. Use self._filesystem in more places in the SCM classes
  12179. https://bugs.webkit.org/show_bug.cgi?id=79415
  12180. Reviewed by Adam Barth.
  12181. * Scripts/webkitpy/common/checkout/scm/detection_unittest.py:
  12182. (SCMDetectorTest.test_detect_scm_system):
  12183. * Scripts/webkitpy/common/checkout/scm/git.py:
  12184. (Git.find_checkout_root):
  12185. (Git.to_object_name):
  12186. * Scripts/webkitpy/common/checkout/scm/scm.py:
  12187. (SCM.__init__):
  12188. (SCM.in_working_directory):
  12189. * Scripts/webkitpy/common/checkout/scm/svn.py:
  12190. (SVN.find_uuid):
  12191. (SVN.find_checkout_root):
  12192. 2012-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
  12193. Unreviewed, rolling out r108685.
  12194. http://trac.webkit.org/changeset/108685
  12195. https://bugs.webkit.org/show_bug.cgi?id=79414
  12196. Broke Chromium builds (Requested by enne on #webkit).
  12197. * qmake/mkspecs/features/features.prf:
  12198. 2012-02-23 Adam Barth <abarth@webkit.org>
  12199. style-queue shouldn't spam bugs if it fails to update its working copy
  12200. https://bugs.webkit.org/show_bug.cgi?id=79412
  12201. Reviewed by Eric Seidel.
  12202. This patch moves style-queue over to the new PatchAnalysisTask
  12203. infrastructure, which is smarter about retrying patches when update
  12204. fails.
  12205. * Scripts/webkitpy/common/system/executive_mock.py:
  12206. (MockExecutive.run_and_throw_if_fail):
  12207. * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  12208. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  12209. (UnableToApplyPatch):
  12210. (UnableToApplyPatch.__init__):
  12211. (PatchAnalysisTask.__init__):
  12212. * Scripts/webkitpy/tool/bot/stylequeuetask.py: Added.
  12213. (StyleQueueTaskDelegate):
  12214. (StyleQueueTaskDelegate.parent_command):
  12215. (StyleQueueTask):
  12216. (StyleQueueTask.validate):
  12217. (StyleQueueTask._check_style):
  12218. (StyleQueueTask._apply_watch_list):
  12219. (StyleQueueTask.run):
  12220. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  12221. * Scripts/webkitpy/tool/commands/queues.py:
  12222. (StyleQueue):
  12223. (StyleQueue.should_proceed_with_work_item):
  12224. (StyleQueue.review_patch):
  12225. (StyleQueue.run_command):
  12226. (StyleQueue.command_passed):
  12227. (StyleQueue.command_failed):
  12228. (StyleQueue.expected_failures):
  12229. (StyleQueue.refetch_patch):
  12230. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  12231. (StyleQueueTest.test_style_queue_with_style_exception):
  12232. (test_style_queue_with_watch_list_exception):
  12233. 2012-02-23 Zoltan Horvath <zoltan@webkit.org>
  12234. [Qt] Allow to use WebCore imagedecoders
  12235. https://bugs.webkit.org/show_bug.cgi?id=32410
  12236. Add ENABLE_QT_IMAGE_DECODER macro, it's enabled by default.
  12237. Reviewed by Simon Hausmann.
  12238. * qmake/mkspecs/features/features.prf:
  12239. 2012-02-23 Eric Seidel <eric@webkit.org>
  12240. Remove old broken find_checkout_root tests now that find_checkout_root is gone
  12241. https://bugs.webkit.org/show_bug.cgi?id=79405
  12242. Reviewed by Adam Barth.
  12243. * Scripts/webkitpy/common/checkout/scm/detection_unittest.py: Added.
  12244. (SCMDetectorTest):
  12245. (SCMDetectorTest.test_find_checkout_root):
  12246. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  12247. (SVNTestRepository.tear_down):
  12248. 2012-02-23 Michael Brüning <michael.bruning@nokia.com>
  12249. [Qt][WK2] Implement proxy authentication dialog.
  12250. https://bugs.webkit.org/show_bug.cgi?id=79350
  12251. Reviewed by Simon Hausmann.
  12252. * MiniBrowser/qt/MiniBrowser.qrc:
  12253. * MiniBrowser/qt/qml/BrowserWindow.qml:
  12254. * MiniBrowser/qt/qml/ProxyAuthenticationDialog.qml: Added.
  12255. 2012-02-23 Kevin Ollivier <kevino@theolliviers.com>
  12256. [wx] Build fix, add recently added source dirs.
  12257. * waf/build/settings.py:
  12258. 2012-02-23 Simon Hausmann <simon.hausmann@nokia.com>
  12259. [Qt] Add support for touch cancellation
  12260. https://bugs.webkit.org/show_bug.cgi?id=79348
  12261. Reviewed by Kenneth Rohde Christiansen.
  12262. Added straight-forward touch cancellation event sending to Qt WK1 DRT
  12263. and WK2 WTR.
  12264. * DumpRenderTree/qt/EventSenderQt.cpp:
  12265. (EventSender::touchCancel):
  12266. (EventSender::cancelTouchPoint):
  12267. * DumpRenderTree/qt/EventSenderQt.h:
  12268. (EventSender):
  12269. * WebKitTestRunner/EventSenderProxy.h:
  12270. (EventSenderProxy):
  12271. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  12272. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  12273. (WTR::EventSendingController::touchCancel):
  12274. (WTR):
  12275. (WTR::EventSendingController::cancelTouchPoint):
  12276. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  12277. (EventSendingController):
  12278. * WebKitTestRunner/TestController.cpp:
  12279. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  12280. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  12281. (WTR::EventSenderProxy::touchCancel):
  12282. (WTR):
  12283. (WTR::EventSenderProxy::cancelTouchPoint):
  12284. 2012-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
  12285. Unreviewed, rolling out r108626.
  12286. http://trac.webkit.org/changeset/108626
  12287. https://bugs.webkit.org/show_bug.cgi?id=79370
  12288. broke qt-wk2 bot, somehow the workaround does not work on the
  12289. bot (Requested by Ossy on #webkit).
  12290. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  12291. (WTR::WrapperWindow::handleStatusChanged):
  12292. (WTR::PlatformWebView::resizeTo):
  12293. 2012-02-23 ChangSeok Oh <shivamidow@gmail.com>
  12294. [GTK] DRT doesn't support scheduleAsynchronousKeyDown.
  12295. https://bugs.webkit.org/show_bug.cgi?id=78481
  12296. Reviewed by Gustavo Noronha Silva.
  12297. Extracted shareable code from keyDownCallback and then added createKeyPressEvent
  12298. to create gdk press key event.
  12299. Added sendKeyDown and sendAsynchronousKeyDown to evaluate keyDown event directly
  12300. and asynchronously. Eventually, sendAsynchronousKeyDown calls sendKeyDown.
  12301. * DumpRenderTree/gtk/EventSender.cpp:
  12302. (scheduleAsynchronousClickCallback):
  12303. (createKeyPressEvent):
  12304. (sendKeyDown):
  12305. (keyDownCallback):
  12306. (sendAsynchronousKeyDown):
  12307. (scheduleAsynchronousKeyDownCallback):
  12308. 2012-02-23 Balazs Kelemen <kbalazs@webkit.org>
  12309. [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
  12310. https://bugs.webkit.org/show_bug.cgi?id=76546
  12311. Reviewed by Simon Hausmann.
  12312. Co-authored with Simon Hausmann.
  12313. Revert the workaround introduced in r107868 and reintroduce
  12314. the qml binding so we can test the code path that we are more
  12315. interested in. The reason that it did not work before is that
  12316. we don't have an active platform window which we now workaround
  12317. by propagating the resize through QWindowSystemInterface.
  12318. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  12319. (WTR::WrapperWindow::handleStatusChanged):
  12320. (WTR::PlatformWebView::resizeTo):
  12321. 2012-02-23 Sheriff Bot <webkit.review.bot@gmail.com>
  12322. Unreviewed, rolling out r108577.
  12323. http://trac.webkit.org/changeset/108577
  12324. https://bugs.webkit.org/show_bug.cgi?id=79359
  12325. It doesn't work as expected (Requested by Ossy on #webkit).
  12326. * DumpRenderTree/qt/EventSenderQt.cpp:
  12327. (EventSender::postEvent):
  12328. * DumpRenderTree/qt/EventSenderQt.h:
  12329. (EventSender):
  12330. 2012-02-23 Philippe Normand <pnormand@igalia.com>
  12331. [GTK] FullScreen signals
  12332. https://bugs.webkit.org/show_bug.cgi?id=76181
  12333. Reviewed by Martin Robinson.
  12334. Use the two new entering/leaving fullscreen signals to hide/show
  12335. the tool bar, the status bar and ask the user's permission before
  12336. entering fullscreen.
  12337. * GtkLauncher/main.c:
  12338. (webViewFullscreenMessageWindowClose):
  12339. (webViewWindowStateEvent):
  12340. (hide_widget):
  12341. (show_widget):
  12342. (webViewEnteringFullScreen):
  12343. (webViewLeavingFullScreen):
  12344. (createBrowser):
  12345. (createWindow):
  12346. 2012-02-22 Dongwoo Im <dw.im@samsung.com>
  12347. [EFL] Fix to launch the EWebLauncher using the script, run-launcher.
  12348. https://bugs.webkit.org/show_bug.cgi?id=79076
  12349. Reviewed by Andreas Kling.
  12350. * Scripts/webkitdirs.pm: Fix the path of libewebkit.so.
  12351. (builtDylibPathForName):
  12352. 2012-02-22 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  12353. [Qt] Add eventSender.gestureTap
  12354. https://bugs.webkit.org/show_bug.cgi?id=66173
  12355. Reviewed by Kenneth Rohde Christiansen.
  12356. * DumpRenderTree/qt/EventSenderQt.cpp:
  12357. (EventSender::gestureTap):
  12358. * DumpRenderTree/qt/EventSenderQt.h:
  12359. 2012-02-22 Brady Eidson <beidson@apple.com>
  12360. <rdar://problem/10406044> and https://bugs.webkit.org/show_bug.cgi?id=79279
  12361. Synchronous ShouldGoToBackForwardListItem causes lots of WebProcess hangs
  12362. Reviewed by Anders Carlsson.
  12363. Update our tools to the new form of the PageLoadClient.
  12364. * MiniBrowser/mac/BrowserWindowController.m:
  12365. (-[BrowserWindowController awakeFromNib]):
  12366. * WebKitTestRunner/TestController.cpp:
  12367. (WTR::TestController::initialize):
  12368. 2012-02-22 Daniel Bates <dbates@webkit.org>
  12369. new-run-webkit-tests shouldn't restore Safari state on Lion when showing results
  12370. https://bugs.webkit.org/show_bug.cgi?id=79277
  12371. Reviewed by Adam Barth.
  12372. Pass command line argument no-saved-state to run-safari to disable Safari
  12373. state restoration for the session on OS 10.7.
  12374. * Scripts/webkitpy/layout_tests/port/mac.py:
  12375. (MacPort.show_results_html_file):
  12376. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  12377. (test_show_results_html_file):
  12378. 2012-02-22 Kalev Lember <kalevlember@gmail.com>
  12379. Explicitly include unistd.h in TestNetscapePlugIn for GCC 4.7
  12380. https://bugs.webkit.org/show_bug.cgi?id=77759
  12381. Reviewed by Tony Chang.
  12382. Fixes build with gcc 4.7.
  12383. r100432 added the include only for ANDROID; this changes the ifdef to
  12384. also cover other unix platforms. On Fedora 17 the gcc 4.7 compiler no
  12385. longer implicitly includes unistd.h from standard headers and other
  12386. unix platforms are likely to get gcc 4.7 as well in the future.
  12387. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  12388. 2012-02-22 Philippe Normand <pnormand@igalia.com>
  12389. Unreviewed, rolling out r108522.
  12390. http://trac.webkit.org/changeset/108522
  12391. https://bugs.webkit.org/show_bug.cgi?id=76181
  12392. Broke 4 fullscreen tests on GTK.
  12393. * GtkLauncher/main.c:
  12394. (createBrowser):
  12395. (createWindow):
  12396. 2012-02-20 Philippe Normand <pnormand@igalia.com>
  12397. [GTK] FullScreen signals
  12398. https://bugs.webkit.org/show_bug.cgi?id=76181
  12399. Reviewed by Martin Robinson.
  12400. Use the two new entering/leaving fullscreen signals to hide/show
  12401. the tool bar, the status bar and ask the user's permission before
  12402. entering fullscreen.
  12403. * GtkLauncher/main.c:
  12404. (webViewFullscreenMessageWindowClose):
  12405. (webViewWindowStateEvent):
  12406. (hide_widget):
  12407. (show_widget):
  12408. (webViewEnteringFullScreen):
  12409. (webViewLeavingFullScreen):
  12410. (createBrowser):
  12411. (createWindow):
  12412. 2012-02-22 Rob Flack <flackr@chromium.org>
  12413. Update Linux ChromiumOS builders in flakiness dashboard.
  12414. https://bugs.webkit.org/show_bug.cgi?id=79238
  12415. Reviewed by Ojan Vafai.
  12416. * TestResultServer/static-dashboards/builders.js:
  12417. 2012-02-22 Dirk Pranke <dpranke@chromium.org>
  12418. webkitpy: test_function_length_check_definition_huge_lines is slow
  12419. https://bugs.webkit.org/show_bug.cgi?id=79185
  12420. Reviewed by Adam Barth.
  12421. This test takes ~3 seconds to run, apparently because we're
  12422. running a test on a 10,000 line function :). Dropping the
  12423. function length to 640 still exercises the code path and
  12424. provides a 10x speedup.
  12425. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  12426. (CppStyleTest):
  12427. (CheckForFunctionLengthsTest.test_function_length_check_definition_huge_lines):
  12428. 2012-02-22 Dirk Pranke <dpranke@chromium.org>
  12429. webkitpy: speed up FileLockTest.test_lock_lifecycle
  12430. https://bugs.webkit.org/show_bug.cgi?id=79189
  12431. Reviewed by Adam Barth.
  12432. The unit test had a second lock trying to acquire a
  12433. lock already held, and a hard-coded timeout of one second.
  12434. I have changed the timeouts to a tenth of a second (which
  12435. is probably still fine) and changed the hard-spin on
  12436. the lock to a slow-spin every hundredth of a second.
  12437. * Scripts/webkitpy/common/system/file_lock.py:
  12438. (FileLock.acquire_lock):
  12439. * Scripts/webkitpy/common/system/file_lock_integrationtest.py:
  12440. (FileLockTest.setUp):
  12441. (FileLockTest.test_stuck_lock):
  12442. 2012-02-22 Gabor Rapcsanyi <rgabor@webkit.org>
  12443. build-webkit should use environment variable at number of CPU
  12444. detection on all platform
  12445. https://bugs.webkit.org/show_bug.cgi?id=79227
  12446. Reviewed by Martin Robinson.
  12447. * Scripts/webkitdirs.pm:
  12448. (determineNumberOfCPUs):
  12449. 2012-02-22 Mihnea Ovidenie <mihnea@adobe.com>
  12450. [Qt] REGRESSION(r108108): It made 3 fast/repaint tests fail
  12451. https://bugs.webkit.org/show_bug.cgi?id=78960
  12452. Reviewed by Csaba Osztrogonác.
  12453. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  12454. (LayoutTestController::overridePreference):
  12455. 2012-02-22 Hao Zheng <zhenghao@chromium.org>
  12456. [chromium] Build WebKit with MEDIA_STREAM disabled.
  12457. https://bugs.webkit.org/show_bug.cgi?id=79214
  12458. Reviewed by Kent Tamura.
  12459. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp:
  12460. * DumpRenderTree/chromium/WebUserMediaClientMock.h:
  12461. * DumpRenderTree/chromium/WebViewHost.cpp:
  12462. (WebViewHost::createMediaPlayer):
  12463. * DumpRenderTree/chromium/WebViewHost.h:
  12464. (WebViewHost):
  12465. 2012-02-22 Zeno Albisser <zeno@webkit.org>
  12466. [Qt][WK2][Mac] WebKitTestRunner does not build with clang.
  12467. https://bugs.webkit.org/show_bug.cgi?id=79124
  12468. WebKitTestRunnerPrefix.h should also be included
  12469. when building with clang.
  12470. Reviewed by Kenneth Rohde Christiansen.
  12471. * WebKitTestRunner/Target.pri:
  12472. 2012-02-20 Roland Steiner <rolandsteiner@chromium.org>
  12473. <style scoped>: Add runtime-flag
  12474. https://bugs.webkit.org/show_bug.cgi?id=79074
  12475. Enable the runtime-flag for DRT.
  12476. Reviewed by Dimitri Glazkov.
  12477. * DumpRenderTree/chromium/TestShell.cpp:
  12478. (TestShell::TestShell):
  12479. 2012-02-22 Carlos Garcia Campos <cgarcia@igalia.com>
  12480. Unreviewed, rolling out r107351.
  12481. http://trac.webkit.org/changeset/107351
  12482. https://bugs.webkit.org/show_bug.cgi?id=53600
  12483. Several issues introduced in WebKitGTK+ API
  12484. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  12485. (createWebView):
  12486. * GtkLauncher/main.c:
  12487. (createWebViewCb):
  12488. (createBrowser):
  12489. (createWindow):
  12490. (main):
  12491. 2012-02-21 Filip Pizlo <fpizlo@apple.com>
  12492. JSC should be a triple-tier VM
  12493. https://bugs.webkit.org/show_bug.cgi?id=75812
  12494. <rdar://problem/10079694>
  12495. Reviewed by Gavin Barraclough.
  12496. Changed EFL's build system to include a new directory in JavaScriptCore.
  12497. * DumpRenderTree/efl/CMakeLists.txt:
  12498. 2012-02-21 Daniel Cheng <dcheng@chromium.org>
  12499. [chromium] Fix image drag out on Chromium
  12500. https://bugs.webkit.org/show_bug.cgi?id=79158
  12501. Reviewed by Tony Chang.
  12502. * DumpRenderTree/chromium/EventSender.cpp:
  12503. (EventSender::dumpFilenameBeingDragged):
  12504. (EventSender::beginDragWithFiles):
  12505. * DumpRenderTree/chromium/WebViewHost.cpp:
  12506. (addDRTFakeFileToDataObject):
  12507. 2012-02-21 Dirk Pranke <dpranke@chromium.org>
  12508. webkitpy: speed up hot filesystem_mock functions
  12509. https://bugs.webkit.org/show_bug.cgi?id=79159
  12510. Reviewed by Adam Barth.
  12511. Profiling run_webkit_tests_integrationtest.py revealed that
  12512. isdir(), normpath(), and join() are called a lot and were very
  12513. slow.This patch speeds them up substantially, shaving 20 seconds
  12514. off of the execution time.
  12515. * Scripts/webkitpy/common/system/filesystem_mock.py:
  12516. (MockFileSystem.isdir):
  12517. (MockFileSystem._slow_but_correct_join):
  12518. (MockFileSystem.join):
  12519. (MockFileSystem.listdir):
  12520. (MockFileSystem._slow_but_correct_normpath):
  12521. (MockFileSystem.normpath):
  12522. (MockFileSystem.write_binary_file):
  12523. * Scripts/webkitpy/common/system/filesystem_mock_unittest.py:
  12524. (MockFileSystemTest.quick_check):
  12525. (MockFileSystemTest):
  12526. (MockFileSystemTest.test_join):
  12527. (MockFileSystemTest.test_normpath):
  12528. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  12529. (get_test_config): Call write_binary_file() instead of updating
  12530. filesystem.files directly, so that we create directories as
  12531. needed.
  12532. 2012-02-21 Dirk Pranke <dpranke@chromium.org>
  12533. nrwt: make the delay between starting workers configurable per-port
  12534. https://bugs.webkit.org/show_bug.cgi?id=79148
  12535. Reviewed by Eric Seidel.
  12536. Because of bug 79147, we have to sleep a bit in between starting
  12537. DRTs; however, doing so across the board slows down the Test
  12538. port. Making this configurable shaves 10 seconds off of
  12539. run_webkit_tests_integrationtest.py
  12540. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12541. (Manager._run_tests):
  12542. * Scripts/webkitpy/layout_tests/port/base.py:
  12543. (Port.worker_startup_delay_secs):
  12544. * Scripts/webkitpy/layout_tests/port/test.py:
  12545. (TestPort.worker_startup_delay_secs):
  12546. 2012-02-21 Jon Lee <jonlee@apple.com>
  12547. Bring notifications support to WK1 mac
  12548. https://bugs.webkit.org/show_bug.cgi?id=78783
  12549. <rdar://problem/10610578>
  12550. Reviewed by Anders Carlsson.
  12551. * DumpRenderTree/mac/UIDelegate.mm: Refactor WebGeolocationPolicyListener to WebAllowDenyPolicyListener.
  12552. (-[UIDelegate webView:decidePolicyForGeolocationRequestFromOrigin:frame:listener:]):
  12553. (-[UIDelegate timerFired]):
  12554. 2012-02-21 Kentaro Hara <haraken@chromium.org>
  12555. Enable the IDL attribute checker in run-bindings-tests
  12556. https://bugs.webkit.org/show_bug.cgi?id=79091
  12557. Reviewed by Adam Barth.
  12558. We have enabled the IDL attribute checker in Chromium in r108322.
  12559. This patch enables the IDL attribute checker in run-bindings-tests.
  12560. No tests. I manually checked that [Custommm], [CallWith=],
  12561. [CallWith=ScriptExecutionContext|Foo] in TestObj.idl cause
  12562. run-bindings-tests failures.
  12563. * Scripts/webkitpy/bindings/main.py:
  12564. (BindingsTests.generate_supplemental_dependency):
  12565. 2012-02-21 Rafael Weinstein <rafaelw@chromium.org>
  12566. Add rafaelw as a committer.
  12567. Unreviewed.
  12568. * Scripts/webkitpy/common/config/committers.py:
  12569. 2012-02-21 Dirk Pranke <dpranke@chromium.org>
  12570. webkitpy: update names after deleting message_broker
  12571. https://bugs.webkit.org/show_bug.cgi?id=79000
  12572. Reviewed by Eric Seidel.
  12573. Part 3 of 3 in deleting message_broker.py; this change just
  12574. adjusts the names for the newly merged symbols so that they are
  12575. private as appropriate.
  12576. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  12577. (get):
  12578. (_Broker):
  12579. (_BrokerConnection):
  12580. (_BrokerConnection.__init__):
  12581. (AbstractWorker.__init__):
  12582. (_ManagerConnection):
  12583. (_ManagerConnection.__init__):
  12584. (_WorkerConnection):
  12585. (_WorkerConnection.__init__):
  12586. 2012-02-21 Dirk Pranke <dpranke@chromium.org>
  12587. webkitpy: merge message_broker.py into manager_worker_broker.py
  12588. https://bugs.webkit.org/show_bug.cgi?id=78999
  12589. Reviewed by Tony Chang.
  12590. This is pretty much a straight cut-and-paste of one file into
  12591. another (broken up so that docstrings and imports are in the
  12592. right place).
  12593. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  12594. (BrokerClient):
  12595. (BrokerClient.is_done):
  12596. (BrokerClient.name):
  12597. (Broker):
  12598. (Broker.__init__):
  12599. (Broker.add_topic):
  12600. (Broker._get_queue_for_topic):
  12601. (Broker.post_message):
  12602. (Broker.run_message_loop):
  12603. (Broker.run_all_pending):
  12604. (Broker._run_loop):
  12605. (Broker._dispatch_message):
  12606. (_Message):
  12607. (_Message.loads):
  12608. (_Message.__init__):
  12609. (_Message.dumps):
  12610. (_Message.__repr__):
  12611. (BrokerConnection):
  12612. (BrokerConnection.__init__):
  12613. (BrokerConnection.run_message_loop):
  12614. (BrokerConnection.post_message):
  12615. (BrokerConnection.raise_exception):
  12616. * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Removed.
  12617. 2012-02-21 Dirk Pranke <dpranke@chromium.org>
  12618. webkitpy: prepare to delete message_broker.py
  12619. https://bugs.webkit.org/show_bug.cgi?id=78997
  12620. Reviewed by Eric Seidel.
  12621. This is part 1 of 3 changes to fix bug 78187. This change
  12622. prepares the code for merging message_broker.py into
  12623. manager_worker_broker.py; the tests in message_broker_unittest
  12624. are merged into manager_worker_broker_unittest, the symbols
  12625. needed by the tests are exported from manager_worker_broker.py,
  12626. and manager_worker_broker itself is updated to refer to the
  12627. symbols directly (without the module prefix).
  12628. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  12629. (get):
  12630. (AbstractWorker):
  12631. (AbstractWorker.__init__):
  12632. (_ManagerConnection):
  12633. (_ManagerConnection.__init__):
  12634. (_WorkerConnection):
  12635. (_WorkerConnection.__init__):
  12636. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  12637. (InterfaceTest.test_brokerclient_is_abstract):
  12638. (InterfaceTest.test_brokerclient_is_abstract.methods):
  12639. (MessageTest):
  12640. (MessageTest.test__no_body):
  12641. (MessageTest.test__body):
  12642. * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Removed.
  12643. 2012-02-21 Sam Weinig <sam@webkit.org>
  12644. Attempt to fix the Snow Leopard build.
  12645. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  12646. * MiniBrowser/Configurations/Base.xcconfig:
  12647. * TestWebKitAPI/Configurations/Base.xcconfig:
  12648. * WebKitTestRunner/Configurations/Base.xcconfig:
  12649. 2012-02-21 Sam Weinig <sam@webkit.org>
  12650. Use libc++ when building with Clang on Mac
  12651. https://bugs.webkit.org/show_bug.cgi?id=78981
  12652. Reviewed by Dan Bernstein.
  12653. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  12654. * MiniBrowser/Configurations/Base.xcconfig:
  12655. * TestWebKitAPI/Configurations/Base.xcconfig:
  12656. * WebKitTestRunner/Configurations/Base.xcconfig:
  12657. 2012-02-21 Adam Roben <aroben@apple.com>
  12658. Roll out r108309, r108323, and r108326
  12659. They broke the 32-bit Lion build.
  12660. Original bugs is <http://webkit.org/b/75812> <rdar://problem/10079694>.
  12661. * DumpRenderTree/efl/CMakeLists.txt:
  12662. 2012-02-21 Andras Becsi <andras.becsi@nokia.com>
  12663. [Qt][WK2] Get rid of the dependency to QtWidgets
  12664. https://bugs.webkit.org/show_bug.cgi?id=76276
  12665. Reviewed by Simon Hausmann.
  12666. * MiniBrowser/qt/MiniBrowser.pro:
  12667. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  12668. (MiniBrowserApplication::MiniBrowserApplication):
  12669. (MiniBrowserApplication::notify):
  12670. (MiniBrowserApplication::sendTouchEvent):
  12671. * MiniBrowser/qt/MiniBrowserApplication.h:
  12672. (MiniBrowserApplication):
  12673. * QtTestBrowser/locationedit.h:
  12674. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  12675. (WTR::activateFonts):
  12676. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  12677. 2012-02-20 Adam Barth <abarth@webkit.org>
  12678. mastercfg_unittest.py fails without simplejson
  12679. https://bugs.webkit.org/show_bug.cgi?id=79070
  12680. Reviewed by Csaba Osztrogonác.
  12681. Now that we require Python 2.6 (and higher) we can import json rather
  12682. than simplejson. We still need to use the simplejson name because
  12683. that's what the master.cfg script expects.
  12684. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  12685. (BuildBotConfigLoader._add_dependant_modules_to_sys_modules):
  12686. 2012-02-20 Filip Pizlo <fpizlo@apple.com>
  12687. JSC should be a triple-tier VM
  12688. https://bugs.webkit.org/show_bug.cgi?id=75812
  12689. <rdar://problem/10079694>
  12690. Reviewed by Gavin Barraclough.
  12691. Changed EFL's build system to include a new directory in JavaScriptCore.
  12692. * DumpRenderTree/efl/CMakeLists.txt:
  12693. 2012-02-20 Kenichi Ishibashi <bashi@chromium.org>
  12694. Update pywebsocket to 0.7.2
  12695. https://bugs.webkit.org/show_bug.cgi?id=79066
  12696. This version includes vendor-prefixed deflate-frame extension support.
  12697. Reviewed by Kent Tamura.
  12698. * Scripts/webkitpy/thirdparty/__init__.py:
  12699. (AutoinstallImportHook._install_pywebsocket):
  12700. 2012-02-20 Martin Robinson <mrobinson@igalia.com>
  12701. [UNIX] Plugin information fields are not interpreted as UTF-8
  12702. https://bugs.webkit.org/show_bug.cgi?id=78635
  12703. Reviewed by Gustavo Noronha Silva.
  12704. Interpret plugin metadata as UTF8 aways. This matches the behavior
  12705. of Chromium and the Totem plugin.
  12706. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  12707. (NPP_GetValue): Include a UTF-8 character in the description string for testing purposes.
  12708. 2012-02-20 Martin Robinson <mrobinson@igalia.com>
  12709. [GTK] [Qt] Move the unix forwarding headers for TestNetscapePlugin to the TestNetscapePlugin directory
  12710. https://bugs.webkit.org/show_bug.cgi?id=78935
  12711. Reviewed by Gustavo Noronha Silva.
  12712. Move the TestNetscapePlugin headers to a more appropriate directory and update
  12713. the build files to match.
  12714. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npapi.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h.
  12715. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npfunctions.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npfunctions.h.
  12716. * DumpRenderTree/TestNetscapePlugIn/unix/ForwardingHeaders/WebKit/npruntime.h: Renamed from Tools/DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h.
  12717. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update build.
  12718. * GNUmakefile.am: Ditto.
  12719. 2012-02-20 Kihong Kwon <kihong.kwon@samsung.com>
  12720. Add a new API for the Vibration API(W3C).
  12721. https://bugs.webkit.org/show_bug.cgi?id=72010
  12722. Reviewed by Hajime Morita.
  12723. * Scripts/build-webkit: Enable ENABLE_VIBRATION feature.
  12724. 2012-02-20 János Badics <dicska@gmail.com>
  12725. [Qt] run-qtwebkit-tests doesn't consider timeouts as failures
  12726. https://bugs.webkit.org/show_bug.cgi?id=71816
  12727. RunQtAPITests will notify if a timeout occurs during testing.
  12728. Added unittest to the master.cfg
  12729. Reviewed by Csaba Osztrogonác.
  12730. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  12731. (RunQtAPITests.evaluateCommand):
  12732. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  12733. (RunQtAPITestsTest):
  12734. (RunQtAPITestsTest.assertResults):
  12735. (RunQtAPITestsTest.test_timeout):
  12736. (test_success):
  12737. (test_failure):
  12738. (test_timeout_and_failure):
  12739. 2012-02-20 Andy Wingo <wingo@igalia.com>
  12740. Add wingo as a committer.
  12741. Unreviewed.
  12742. * Scripts/webkitpy/common/config/committers.py: Add myself to the
  12743. committers list.
  12744. 2012-02-20 Jochen Eisinger <jochen@chromium.org>
  12745. [chromium] check that we're not running multiple modal dialogs at the same time
  12746. https://bugs.webkit.org/show_bug.cgi?id=78486
  12747. Reviewed by Kent Tamura.
  12748. * DumpRenderTree/chromium/TestShell.cpp:
  12749. (TestShell::TestShell):
  12750. * DumpRenderTree/chromium/TestShell.h:
  12751. (TestShell::setIsDisplayingModalDialog):
  12752. (TestShell::isDisplayingModalDialog):
  12753. (TestShell):
  12754. * DumpRenderTree/chromium/WebViewHost.cpp:
  12755. (WebViewHost::runModal):
  12756. 2012-02-20 Martin Robinson <mrobinson@igalia.com>
  12757. Fix WebKit2GTK+ for 'make distcheck'.
  12758. Instead of conditionally including WebKit2 GNUmakefiles, always
  12759. include them and conditionally activate the final targets.
  12760. * MiniBrowser/gtk/GNUmakefile.am:
  12761. * WebKitTestRunner/GNUmakefile.am:
  12762. 2012-02-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  12763. Enable video option for EFL port in build-webkit.
  12764. https://bugs.webkit.org/show_bug.cgi?id=79006
  12765. Reviewed by Daniel Bates.
  12766. * Scripts/build-webkit:
  12767. 2012-02-19 JungJik Lee <jungjik.lee@samsung.com>
  12768. [EFL] Use modifier keys to execute pre-rendering.
  12769. https://bugs.webkit.org/show_bug.cgi?id=77933
  12770. Reviewed by Chang Shu.
  12771. Use modifier key to execute pre-rendering instead of using reserved function keys.
  12772. * EWebLauncher/main.c:
  12773. (on_key_down):
  12774. 2012-02-18 Dirk Pranke <dpranke@chromium.org>
  12775. Fix one more dangling reference to worker_connection.name, delete unused code.
  12776. Unreviewed, build fix.
  12777. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12778. (Manager.update):
  12779. (_WorkerState.__init__):
  12780. 2012-02-18 Dirk Pranke <dpranke@chromium.org>
  12781. Add a change that should've been in r108005.
  12782. Unreviewed, build fix.
  12783. In the refactoring/cleanup in r108005 I should've changed the
  12784. implementation of WorkerConnection to make it match BrokerClient
  12785. (and everything else) so that objects had a name() method
  12786. instead of a name property.
  12787. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  12788. (Manager._run_tests):
  12789. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  12790. (_WorkerConnection.__init__):
  12791. (_WorkerConnection.name):
  12792. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  12793. (_TestWorker.__init__):
  12794. (_TestsMixin.name):
  12795. (_TestsMixin.test_name):
  12796. (_TestsMixin.test_cancel):
  12797. (_TestsMixin.test_unknown_message):
  12798. 2012-02-18 Dirk Pranke <dpranke@chromium.org>
  12799. webkitpy: remove webkitpy.common.array_stream
  12800. https://bugs.webkit.org/show_bug.cgi?id=78952
  12801. Reviewed by Eric Seidel.
  12802. Turns out array_stream didn't really do anything that StringIO
  12803. didn't do (at least as of Python 2.6). This change removes it
  12804. and updates all of the callers. Where possible, I changed the
  12805. test assertions in order to capture the intent more clearly,
  12806. e.g., instead of calling self.assertTrue('foo' in stream.get()),
  12807. we have self.assertContainsLine(stream, 'foo'), and instead of
  12808. self.assertTrue(stream.empty()), we have self.assertEmpty(stream) -
  12809. the latter isn't that much more readable, but StringIO doesn't
  12810. export an empty() method.
  12811. * Scripts/webkitpy/common/array_stream.py: Removed.
  12812. * Scripts/webkitpy/common/array_stream_unittest.py: Removed.
  12813. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  12814. (passing_run):
  12815. (run_and_capture):
  12816. (StreamTestingMixin):
  12817. (StreamTestingMixin.assertContains):
  12818. (StreamTestingMixin.assertContainsLine):
  12819. (StreamTestingMixin.assertEmpty):
  12820. (StreamTestingMixin.assertNotEmpty):
  12821. (LintTest):
  12822. (LintTest.test_lint_test_files):
  12823. (LintTest.test_lint_test_files__errors):
  12824. (MainTest):
  12825. (MainTest.test_child_process_1):
  12826. (MainTest.test_child_processes_2):
  12827. (MainTest.test_child_processes_min):
  12828. (MainTest.test_help_printing):
  12829. (MainTest.test_hung_thread):
  12830. (MainTest.test_no_tests_found):
  12831. (MainTest.test_no_tests_found_2):
  12832. (MainTest.test_repeat_each_iterations_num_tests):
  12833. (MainTest.test_test_list):
  12834. (MainTest.test_unexpected_failures):
  12835. (MainTest.test_worker_model__inline_with_child_processes):
  12836. (MainTest.test_additional_platform_directory):
  12837. (RebaselineTest):
  12838. (RebaselineTest.assertBaselines):
  12839. (RebaselineTest.test_reset_results):
  12840. (RebaselineTest.test_missing_results):
  12841. (RebaselineTest.test_new_baseline):
  12842. * Scripts/webkitpy/layout_tests/views/metered_stream.py:
  12843. (MeteredStream.update):
  12844. * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:
  12845. (TestMeteredStream.test_regular):
  12846. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  12847. (TestUtilityFunctions.assertEmpty):
  12848. (TestUtilityFunctions):
  12849. (TestUtilityFunctions.assertNotEmpty):
  12850. (TestUtilityFunctions.assertWritten):
  12851. (TestUtilityFunctions.test_configure_logging):
  12852. (Testprinter.assertEmpty):
  12853. (Testprinter):
  12854. (Testprinter.assertNotEmpty):
  12855. (Testprinter.assertWritten):
  12856. (Testprinter.reset):
  12857. (Testprinter.get_printer):
  12858. (Testprinter.test_help_printer):
  12859. (Testprinter.do_switch_tests.do_helper):
  12860. (Testprinter.test_print_one_line_summary):
  12861. (Testprinter.test_print_test_result):
  12862. (Testprinter.test_print_progress):
  12863. (Testprinter.test_write_nothing):
  12864. (Testprinter.test_write_misc):
  12865. (Testprinter.test_write_everything):
  12866. (Testprinter.test_write_verbose):
  12867. (Testprinter.test_print_unexpected_results):
  12868. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  12869. (MainTest.assertWritten):
  12870. (create_runner):
  12871. (test_run_test_set):
  12872. (test_run_test_set_kills_drt_per_run):
  12873. (test_run_test_set_for_parser_tests):
  12874. (test_run_test_set_with_json_output):
  12875. (test_run_test_set_with_json_source):
  12876. (test_run_test_set_with_multiple_repositories):
  12877. (test_upload_json):
  12878. 2012-02-18 Kevin Ollivier <kevino@theolliviers.com>
  12879. [wx] Add the WebCore/page/scrolling directory to the build dirs.
  12880. * waf/build/settings.py:
  12881. 2012-02-18 Kevin Ollivier <kevino@theolliviers.com>
  12882. [wx] Unreviewed build fix. Don't error out or hang if we have
  12883. downloaded dependencies but server update check fails.
  12884. * waf/build/build_utils.py:
  12885. (download_if_newer):
  12886. 2012-02-17 Dirk Pranke <dpranke@chromium.org>
  12887. The new run-webkit-tests needs to dump out pixel hash failures even if the pixel test passes.
  12888. https://bugs.webkit.org/show_bug.cgi?id=69444
  12889. Reviewed by Tony Chang.
  12890. Currently if a test's image checksum doesn't match the checksum
  12891. in the baseline, but the images themselves match according to
  12892. ImageDiff, new-run-webkit-tests ignores the problem. This is
  12893. probably bad, but it's not yet clear what the right thing to do
  12894. is. This patch will log a warning to stderr, at least (but the
  12895. test will still pass).
  12896. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  12897. (SingleTestRunner._compare_image):
  12898. (SingleTestRunner._run_reftest):
  12899. * Scripts/webkitpy/layout_tests/port/test.py:
  12900. (unit_test_list):
  12901. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  12902. 2012-02-17 Dirk Pranke <dpranke@chromium.org>
  12903. NRWT does not report failure for a skipped test
  12904. https://bugs.webkit.org/show_bug.cgi?id=78750
  12905. Reviewed by Eric Seidel.
  12906. If a test is listed in a Skipped file and you run it anyway
  12907. with --force, and the test fails, currently NRWT will print
  12908. "test ran as expected"; this is confusing, because you probably
  12909. expect the test to fail and yet this might lead you to think the
  12910. test passed. This patch changes the expected behavior to "PASS",
  12911. so tests that fail will be reported.
  12912. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  12913. (result_was_expected):
  12914. (TestExpectationParser):
  12915. (TestExpectationParser.expectation_for_skipped_test):
  12916. (TestExpectations):
  12917. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  12918. (test_add_skipped_tests):
  12919. * Scripts/webkitpy/layout_tests/port/test.py:
  12920. (unit_test_list): Add some tests that are expected to be in a Skipped file.
  12921. (TestPort.skipped_tests): This adds actual integration test coverage of Skipped files.
  12922. 2012-02-17 Dirk Pranke <dpranke@chromium.org>
  12923. webkitpy: fix test code after bug 78181
  12924. https://bugs.webkit.org/show_bug.cgi?id=78870
  12925. Reviewed by Adam Barth.
  12926. I forgot to update the test code as per Tony's suggestion in
  12927. bug 78181 (r108005). This change does that, and in doing so
  12928. it revealed a subtle bug in _InlineWorkerConnection.run() that
  12929. I am fixing as part of this (_alive would not be cleared if an
  12930. exception was thrown).
  12931. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  12932. (_InlineWorkerConnection.run):
  12933. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  12934. (_TestWorker.__init__):
  12935. (_TestWorker.handle_stop):
  12936. (_TestWorker.handle_test):
  12937. (_TestWorker.run):
  12938. (_TestsMixin.handle_exception):
  12939. (_TestsMixin.test_unknown_message):
  12940. 2012-02-17 Adam Roben <aroben@apple.com>
  12941. Mac build fix after r108119
  12942. * DumpRenderTree/mac/DumpRenderTree.mm:
  12943. (runThread):
  12944. (runPthread):
  12945. (testThreadIdentifierMap):
  12946. Updated to match current WTF threading APIs.
  12947. 2012-02-17 Dirk Pranke <dpranke@chromium.org>
  12948. revert r107147 - breaks webkit-patch on Mac SL
  12949. https://bugs.webkit.org/show_bug.cgi?id=78866
  12950. Reviewed by Adam Barth.
  12951. It appears that zipfile.ExtractAll is broken on Python 2.6.1,
  12952. which is the version that ships on Mac SL. Reverting this
  12953. change until we no longer have to worry about that version.
  12954. * Scripts/webkitpy/common/system/autoinstall.py:
  12955. (AutoInstaller):
  12956. (AutoInstaller._extract_all): Added a comment about SL.
  12957. (AutoInstaller._unzip):
  12958. 2012-02-17 Mihnea Ovidenie <mihnea@adobe.com>
  12959. CSS regions enabled by default
  12960. https://bugs.webkit.org/show_bug.cgi?id=78525
  12961. Reviewed by David Hyatt.
  12962. Add a runtime preference to enable/disable regions functionality at runtime(WebKitCSSRegionsEnabled).
  12963. CSSRegions are still enabled by default.
  12964. In DRT, use layoutTestController.overridePreference("WebKitCSSRegionsEnabled", "0") to disable the css regions functionality.
  12965. * DumpRenderTree/chromium/LayoutTestController.cpp:
  12966. (LayoutTestController::overridePreference):
  12967. * DumpRenderTree/chromium/WebPreferences.cpp:
  12968. (WebPreferences::reset):
  12969. (WebPreferences::applyTo):
  12970. * DumpRenderTree/chromium/WebPreferences.h:
  12971. (WebPreferences):
  12972. * DumpRenderTree/mac/DumpRenderTree.mm:
  12973. (resetDefaultsToConsistentValues):
  12974. 2012-02-17 Maciej Stachowiak <mjs@apple.com>
  12975. Some API tests erroneously use = instead of == (causing build failures)
  12976. https://bugs.webkit.org/show_bug.cgi?id=78915
  12977. Reviewed by Sam Weinig.
  12978. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  12979. (TestWebKitAPI::decidePolicyForNavigationAction): Replace an = with an ==
  12980. (TestWebKitAPI::decidePolicyForNewWindowAction): ditto
  12981. 2012-02-17 Peter Beverloo <peter@chromium.org>
  12982. [Chromium] Include TestShellLinux.cpp in the build for Android
  12983. https://bugs.webkit.org/show_bug.cgi?id=78865
  12984. Reviewed by Eric Seidel.
  12985. Android will be re-using the TestShellLinux.cpp file. I already
  12986. added this r104033, but it seems to have gotten lost in the
  12987. recent refactorings.
  12988. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  12989. 2012-02-17 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  12990. Unreviewed, disable video build on EFL until it can be
  12991. supported by EFL build bot.
  12992. * Scripts/build-webkit:
  12993. 2012-02-17 Carlos Garcia Campos <cgarcia@igalia.com>
  12994. [GTK] Implement zoom in/out in MiniBrowser
  12995. https://bugs.webkit.org/show_bug.cgi?id=75253
  12996. Reviewed by Gustavo Noronha Silva.
  12997. * MiniBrowser/gtk/BrowserWindow.c:
  12998. (browserWindowCanZoomIn):
  12999. (browserWindowCanZoomOut):
  13000. (browserWindowUpdateZoomActions):
  13001. (webViewZoomLevelChanged):
  13002. (zoomInCallback):
  13003. (zoomOutCallback):
  13004. (browser_window_init):
  13005. (browserWindowConstructed):
  13006. 2012-02-17 Nikolas Zimmermann <nzimmermann@rim.com>
  13007. layoutTestController.display() is flaky for SVG tests
  13008. https://bugs.webkit.org/show_bug.cgi?id=78021
  13009. Reviewed by Adam Roben.
  13010. Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
  13011. Size the web view before running the test, not when dumping.
  13012. All platforms handle this correctly now.
  13013. * DumpRenderTree/win/DumpRenderTree.cpp:
  13014. (dump):
  13015. (sizeWebViewForCurrentTest):
  13016. (runTest):
  13017. 2012-02-16 Carlos Garcia Campos <cgarcia@igalia.com>
  13018. [GTK] Make install is broken when building without --enable-gtk-doc
  13019. https://bugs.webkit.org/show_bug.cgi?id=78828
  13020. Reviewed by Martin Robinson.
  13021. * gtk/generate-gtkdoc:
  13022. (rebase_installed_docs): Check documentation has been generated
  13023. before trying to rebase it.
  13024. 2012-02-16 Dirk Pranke <dpranke@chromium.org>
  13025. nrwt: simplify worker interface
  13026. https://bugs.webkit.org/show_bug.cgi?id=78181
  13027. Reviewed by Tony Chang.
  13028. This change moves code in name(), is_done(), run(), and cancel()
  13029. from Worker to AbstractWorker, since the logic is pretty much
  13030. boilerplate code that any implementation would want to use.
  13031. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13032. (get.should):
  13033. (AbstractWorker.__init__):
  13034. (AbstractWorker):
  13035. (AbstractWorker.name):
  13036. (AbstractWorker.stop_handling_messages):
  13037. (AbstractWorker.run):
  13038. (AbstractWorker.is_done):
  13039. (AbstractWorker.cancel):
  13040. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  13041. (Worker.__init__):
  13042. (Worker.run):
  13043. (Worker.handle_stop):
  13044. 2012-02-16 Michael Saboff <msaboff@apple.com>
  13045. ENH: Add ability to run subset of JavaScript layout tests with JSC
  13046. https://bugs.webkit.org/show_bug.cgi?id=78764
  13047. Reviewed by Gavin Barraclough.
  13048. New simple test drive shell script that runs a defined
  13049. list of javascript tests using jsc and the standalone-{pre,post}.js
  13050. wrappers.
  13051. * Scripts/run-fast-jsc: Added.
  13052. 2012-02-16 Csaba Osztrogonác <ossy@webkit.org>
  13053. Add new Qt performance tester bot to build.webkit.org
  13054. https://bugs.webkit.org/show_bug.cgi?id=78795
  13055. Reviewed by Adam Roben.
  13056. * BuildSlaveSupport/build.webkit.org-config/config.json:
  13057. 2012-02-16 Patrick Gansterer <paroga@webkit.org>
  13058. Disable inspector on WinCE.
  13059. Avoid compiling InspectorBackendDispatcher.cpp, which causes an internal compiler error.
  13060. * Scripts/build-webkit:
  13061. 2012-02-16 Patrick Gansterer <paroga@webkit.org>
  13062. WinCE build fix after r107656.
  13063. Disable FTPDIR on WinCE, since it does not compile there.
  13064. * Scripts/build-webkit:
  13065. 2012-02-15 Leo Yang <leo.yang@torchmobile.com.cn>
  13066. Build fix after r107863.
  13067. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:
  13068. 2012-02-15 Tony Chang <tony@chromium.org>
  13069. [chromium] add linux dbg back to garden-o-matic
  13070. https://bugs.webkit.org/show_bug.cgi?id=78752
  13071. Reviewed by Adam Barth.
  13072. This reflects the current linux debug bot name (there's only one bot).
  13073. I'm also remove the mac clang builder since it doesn't exist (mac
  13074. always uses clang now).
  13075. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  13076. * Scripts/webkitpy/layout_tests/port/builders.py:
  13077. 2012-02-15 Sam Weinig <sam@webkit.org>
  13078. Add style check for ctype functions that are generally frowned upon in WebKit
  13079. https://bugs.webkit.org/show_bug.cgi?id=78748
  13080. Reviewed by Anders Carlsson.
  13081. Not every platform has DisallowCType.h to check for uses of the ctype.h
  13082. functions, so add a style check for them as well.
  13083. * Scripts/webkitpy/style/checkers/cpp.py:
  13084. (check_ctype_functions):
  13085. (check_style):
  13086. (CppChecker):
  13087. Add check.
  13088. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  13089. (WebKitStyleTest.test_ctype_fucntion):
  13090. Add checker.
  13091. 2012-02-15 Szilard Ledan <Ledan-Muntean.Szilard@stud.u-szeged.hu>
  13092. [Qt][WK2] WebKitTestRunner should use 480x360 sized view for W3C SVG tests
  13093. https://bugs.webkit.org/show_bug.cgi?id=76546
  13094. Reviewed by Simon Hausmann.
  13095. Resize the web view programatically because the declarative property binding
  13096. does not work. Seems like our qml environment is not initialized fully but it
  13097. needs more investigation.
  13098. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  13099. (WTR::WrapperWindow::handleStatusChanged):
  13100. (WTR::PlatformWebView::resizeTo):
  13101. 2012-02-15 Dirk Pranke <dpranke@chromium.org>
  13102. webkitpy: add a worker_args concept to start_worker()
  13103. https://bugs.webkit.org/show_bug.cgi?id=78572
  13104. Reviewed by Tony Chang.
  13105. This change replaces the three NRWT-specific arguments passed
  13106. through the broker to the worker with a generic WorkerArguments
  13107. wrapper class and a separate set_inline_arguments() call that can
  13108. be used to pass additional data to the worker when it is running
  13109. in the same process as the manager (this is needed for testing).
  13110. With the addition of set_inline_arguments() we also no longer
  13111. need to pass an optional argument to the worker.run() call.
  13112. Note that this method is *only* implemented on inline workers,
  13113. so calling this on a regular (child process) worker will result
  13114. in a runtime error.
  13115. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13116. (Manager._run_tests):
  13117. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13118. (AbstractWorker.__init__):
  13119. (AbstractWorker.run):
  13120. (_ManagerConnection.start_worker):
  13121. (_InlineManager.start_worker):
  13122. (_InlineManager.set_inline_arguments):
  13123. (_InlineManager.run_message_loop):
  13124. (_MultiProcessManager.start_worker): Reworked signature.
  13125. (_WorkerConnection.__init__):
  13126. (_InlineWorkerConnection.__init__):
  13127. (_InlineWorkerConnection.set_inline_arguments): New method.
  13128. (_InlineWorkerConnection):
  13129. (_InlineWorkerConnection.run):
  13130. (_Process.run):
  13131. (_MultiProcessWorkerConnection.__init__):
  13132. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  13133. (_TestWorker.__init__):
  13134. (_TestWorker.set_inline_arguments):
  13135. (_TestWorker.handle_test):
  13136. (_TestWorker.run):
  13137. (_TestsMixin.test_cancel):
  13138. (_TestsMixin.test_done):
  13139. (_TestsMixin.test_unknown_message):
  13140. (InlineBrokerTests): New class for more testing.
  13141. (InlineBrokerTests.setUp):
  13142. (InlineBrokerTests.test_inline_arguments): New test.
  13143. (InterfaceTest.test_managerconnection_is_abstract):
  13144. (InterfaceTest.test_workerconnection_is_abstract):
  13145. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  13146. (WorkerArguments):
  13147. (WorkerArguments.__init__):
  13148. (Worker.__init__):
  13149. (Worker.set_inline_arguments):
  13150. (Worker):
  13151. (Worker.run):
  13152. * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py:
  13153. (WorkerTest.test_default_platform_in_worker):
  13154. 2012-02-15 Adam Klein <adamk@chromium.org>
  13155. Unreviewed, rolling out r107704.
  13156. http://trac.webkit.org/changeset/107704
  13157. https://bugs.webkit.org/show_bug.cgi?id=78486
  13158. Caused layout test crashes in debug builds.
  13159. Specific crashing tests:
  13160. fast/events/show-modal-dialog-onblur-onfocus.html
  13161. fast/harness/show-modal-dialog.html
  13162. inspector/console/console-long-eval-crash.html
  13163. * DumpRenderTree/chromium/TestShell.cpp:
  13164. (TestShell::TestShell):
  13165. * DumpRenderTree/chromium/TestShell.h:
  13166. (TestShell):
  13167. * DumpRenderTree/chromium/WebViewHost.cpp:
  13168. (WebViewHost::runModal):
  13169. 2012-02-15 Michael Brüning <michael.bruning@nokia.com>
  13170. [Qt] Add UI for HTTP authentication in the Qt MiniBrowser
  13171. https://bugs.webkit.org/show_bug.cgi?id=76347
  13172. Reviewed by Kenneth Rohde Christiansen.
  13173. * MiniBrowser/qt/MiniBrowser.qrc:
  13174. * MiniBrowser/qt/qml/AuthenticationDialog.qml: Added.
  13175. * MiniBrowser/qt/qml/BrowserWindow.qml:
  13176. * MiniBrowser/qt/qml/DialogLineInput.qml:
  13177. 2012-02-15 Simon Hausmann <simon.hausmann@nokia.com>
  13178. [Qt] Fix WebGL in QtTestBrowser
  13179. Reviewed by Tor Arne Vestbø.
  13180. * QtTestBrowser/QtTestBrowser.pro: Set the OpenGL define so that when passing
  13181. the options for enabling GL we also pass them on properly.
  13182. 2012-02-14 Sam Weinig <sam@webkit.org>
  13183. Add #include of unistd.h on the mac for getcwd.
  13184. Reviewed by Anders Carlsson.
  13185. This is necessary when building with libc++.
  13186. * WebKitTestRunner/TestInvocation.cpp:
  13187. 2012-02-14 Sam Weinig <sam@webkit.org>
  13188. In DRT, don't #define min or max on non-Windows platforms, it just isn't needed
  13189. https://bugs.webkit.org/show_bug.cgi?id=78663
  13190. Reviewed by Anders Carlsson.
  13191. * DumpRenderTree/DumpRenderTreePrefix.h:
  13192. * DumpRenderTree/cg/ImageDiffCG.cpp:
  13193. 2012-02-14 Adam Barth <abarth@webkit.org>
  13194. Implement an adb-based driver for the ChromiumAndroidPort
  13195. https://bugs.webkit.org/show_bug.cgi?id=78627
  13196. Reviewed by Eric Seidel.
  13197. This driver mostly just wires up the ChromiumDriver through adb. In
  13198. some cases, it translates protocol elements, such as URIs, so that the
  13199. rest of webkitpy is insulated from the "remoteness" of the target device.
  13200. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13201. (ChromiumAndroidPort.start_helper):
  13202. (ChromiumAndroidPort._driver_class):
  13203. (ChromiumAndroidPort._update_version):
  13204. (ChromiumAndroidPort._get_stderr):
  13205. (ChromiumAndroidPort):
  13206. (ChromiumAndroidPort._get_last_stacktrace):
  13207. (ChromiumAndroidPort._teardown_performance):
  13208. (ChromiumAndroidDriver):
  13209. (ChromiumAndroidDriver.__init__):
  13210. (ChromiumAndroidDriver._start):
  13211. (ChromiumAndroidDriver.run_test):
  13212. (ChromiumAndroidDriver.stop):
  13213. (ChromiumAndroidDriver._test_shell_command):
  13214. (ChromiumAndroidDriver._write_command_and_read_line):
  13215. (ChromiumAndroidDriver._output_image):
  13216. (ChromiumAndroidDriver._has_crash_hint):
  13217. 2012-02-14 Dirk Pranke <dpranke@chromium.org>
  13218. webkitpy: the real_name() method in the Port class is no longer needed
  13219. https://bugs.webkit.org/show_bug.cgi?id=78651
  13220. Reviewed by Eric Seidel.
  13221. The change in bug 78565 / r107718 made it no longer necessary
  13222. (we can use options.platform instead).
  13223. * Scripts/webkitpy/layout_tests/port/base.py:
  13224. (Port.name):
  13225. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  13226. (MockDRTPort.__init__):
  13227. 2012-02-14 Dirk Pranke <dpranke@chromium.org>
  13228. webkitpy: clean up options, port handling in manager_worker_broker
  13229. https://bugs.webkit.org/show_bug.cgi?id=78568
  13230. Reviewed by Tony Chang.
  13231. manager_worker_broker no longer needs options or port objects
  13232. directly, so we make them only be passed in start_worker().
  13233. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13234. (Manager._run_tests):
  13235. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13236. (get):
  13237. (_ManagerConnection.__init__):
  13238. (_ManagerConnection.start_worker):
  13239. (_InlineManager.__init__):
  13240. (_InlineManager.start_worker):
  13241. (_InlineManager.run_message_loop):
  13242. (_MultiProcessManager.__init__):
  13243. (_MultiProcessManager):
  13244. (_MultiProcessManager.start_worker):
  13245. (_InlineWorkerConnection.__init__):
  13246. (_InlineWorkerConnection.run):
  13247. (_Process.__init__):
  13248. (_MultiProcessWorkerConnection.__init__):
  13249. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  13250. (make_broker):
  13251. (_TestWorker.run):
  13252. (_TestsMixin.test_cancel):
  13253. (_TestsMixin.test_done):
  13254. (_TestsMixin.test_unknown_message):
  13255. (MultiProcessBrokerTests.setUp):
  13256. (InterfaceTest.test_managerconnection_is_abstract):
  13257. * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
  13258. (Broker.__init__):
  13259. 2012-02-14 Dirk Pranke <dpranke@chromium.org>
  13260. nrwt: add a unit test for regression introduced in bug 78565
  13261. https://bugs.webkit.org/show_bug.cgi?id=78646
  13262. Reviewed by Tony Chang.
  13263. * Scripts/webkitpy/layout_tests/controllers/worker_unittest.py: Added.
  13264. (FakeConnection):
  13265. (FakeConnection.run_message_loop):
  13266. (FakeConnection.post_message):
  13267. (WorkerTest):
  13268. (WorkerTest.test_default_platform_in_worker):
  13269. 2012-02-14 Dirk Pranke <dpranke@chromium.org>
  13270. NRWT is broken for the default port
  13271. https://bugs.webkit.org/show_bug.cgi?id=78640
  13272. Reviewed by Tony Chang.
  13273. The change in r107718 (bug 78565) broke NRWT if you didn't
  13274. specify any sort of --platform flag or equivalent. I didn't
  13275. catch this because it's a full integration test (which we don't
  13276. have an automated test for) and I missed this command line
  13277. variant when testing interactively.
  13278. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  13279. (Worker.run):
  13280. 2012-02-14 Ramya Chandrasekaran <cramya@google.com>
  13281. Last character display for passwords in Android.
  13282. https://bugs.webkit.org/show_bug.cgi?id=78532
  13283. Reviewed by Adam Barth.
  13284. * DumpRenderTree/chromium/WebPreferences.cpp:
  13285. (WebPreferences::applyTo):
  13286. 2012-02-14 Adam Barth <abarth@webkit.org>
  13287. Finish implementing start_helper for ChromiumAndroidPort
  13288. https://bugs.webkit.org/show_bug.cgi?id=78582
  13289. Reviewed by Eric Seidel.
  13290. This patch contains the remaining odds and ends for the start_helper function.
  13291. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13292. (ChromiumAndroidPort.start_helper):
  13293. (ChromiumAndroidPort._synchronize_datetime):
  13294. (ChromiumAndroidPort):
  13295. (ChromiumAndroidPort._check_version):
  13296. (ChromiumAndroidPort._run_adb_command):
  13297. (ChromiumAndroidPort._copy_device_file):
  13298. 2012-02-14 Dirk Pranke <dpranke@chromium.org>
  13299. webkitpy: create ports in Workers, not in manager_worker_broker
  13300. https://bugs.webkit.org/show_bug.cgi?id=78565
  13301. Reviewed by Tony Chang.
  13302. We will now create the Port object (if necessary) in the Worker
  13303. directly, so that the manager_worker_broker module doesn't need
  13304. all of this layout_test-specific logic. Part of the fixes for
  13305. bug 78171.
  13306. These changes are all well-tested by the existing tests in
  13307. run_webkit_tests_integrationtest.py.
  13308. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13309. (_Process.run):
  13310. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  13311. (Worker.__init__):
  13312. (Worker.safe_init):
  13313. (Worker.run):
  13314. (Worker.cleanup):
  13315. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  13316. (parse_args):
  13317. (main): Fix a minor bug where running the 'mock-test' port didn't work right.
  13318. 2012-02-14 Jochen Eisinger <jochen@chromium.org>
  13319. [chromium] check that we're not running multiple modal dialogs at the same time
  13320. https://bugs.webkit.org/show_bug.cgi?id=78486
  13321. Reviewed by Kent Tamura.
  13322. * DumpRenderTree/chromium/TestShell.cpp:
  13323. (TestShell::TestShell):
  13324. * DumpRenderTree/chromium/TestShell.h:
  13325. (TestShell::setIsDisplayingModalDialog):
  13326. (TestShell::isDisplayingModalDialog):
  13327. (TestShell):
  13328. * DumpRenderTree/chromium/WebViewHost.cpp:
  13329. (WebViewHost::runModal):
  13330. 2012-02-14 Adam Barth <abarth@webkit.org>
  13331. Enable the GPU codepath in the chromium-android port
  13332. https://bugs.webkit.org/show_bug.cgi?id=78580
  13333. Reviewed by James Robinson.
  13334. Suprise! There is no ChromiumGpuAndroidPort! Instead, Chromium
  13335. Android always uses the GPU codepath, so we set the GPU flags on the
  13336. main chromium-android port instead.
  13337. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13338. (ChromiumAndroidPort.__init__):
  13339. 2012-02-14 Adam Barth <abarth@webkit.org>
  13340. NRWT should expose --adb-args flag for Android
  13341. https://bugs.webkit.org/show_bug.cgi?id=78579
  13342. Reviewed by Eric Seidel.
  13343. This flag is already wired up to the ChromiumAndroidPort.
  13344. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  13345. (parse_args):
  13346. 2012-02-14 Alexey Proskuryakov <ap@apple.com>
  13347. [Mac][Win][WK2] Switch to RFC 6455 protocol for WebSockets
  13348. https://bugs.webkit.org/show_bug.cgi?id=78541
  13349. <rdar://problem/10036695>
  13350. Reviewed by Kent Tamura.
  13351. * DumpRenderTree/mac/DumpRenderTree.mm: (resetDefaultsToConsistentValues):
  13352. * DumpRenderTree/win/DumpRenderTree.cpp: (resetDefaultsToConsistentValues):
  13353. After each test, reset to using new protocol.
  13354. 2012-02-11 Nikolas Zimmermann <nzimmermann@rim.com>
  13355. Convert svg/animations to use SMIL methods for driving the timeline
  13356. https://bugs.webkit.org/show_bug.cgi?id=78422
  13357. Reviewed by Dirk Schulze.
  13358. Remove no longer needed SVG specific animation sampling functionality from DRT.
  13359. Instead we switched the svg/animations tests to use SVGSVGElement.setCurrentTime.
  13360. * DumpRenderTree/LayoutTestController.cpp:
  13361. (LayoutTestController::staticFunctions):
  13362. * DumpRenderTree/LayoutTestController.h:
  13363. (LayoutTestController):
  13364. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
  13365. * DumpRenderTree/chromium/LayoutTestController.cpp:
  13366. (LayoutTestController::LayoutTestController):
  13367. * DumpRenderTree/chromium/LayoutTestController.h:
  13368. (LayoutTestController):
  13369. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  13370. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  13371. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  13372. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  13373. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  13374. (LayoutTestController):
  13375. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  13376. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  13377. 2012-02-13 Rob Flack <flackr@chromium.org>
  13378. Add Linux ChromiumOS test results to flakiness dashboard.
  13379. https://bugs.webkit.org/show_bug.cgi?id=78495
  13380. Reviewed by Ojan Vafai.
  13381. * TestResultServer/static-dashboards/builders.js:
  13382. * TestResultServer/static-dashboards/dashboard_base.js:
  13383. 2012-02-13 ChangSeok Oh <shivamidow@gmail.com>
  13384. [GTK] Mutation Observers build is broken
  13385. https://bugs.webkit.org/show_bug.cgi?id=78433
  13386. Reviewed by Martin Robinson.
  13387. Enabled mutation observers as a default feature for GTK port, too.
  13388. * Scripts/build-webkit:
  13389. 2012-02-13 Loïc Yhuel <loic.yhuel_ext@softathome.com>
  13390. Allow to configure ENABLE_FTPDIR in build-webkit
  13391. https://bugs.webkit.org/show_bug.cgi?id=65098
  13392. Reviewed by Eric Seidel.
  13393. Allow to disable ENABLE_FTPDIR by command line.
  13394. Remove ENABLE_FTPDIR from --minimal build
  13395. * Scripts/build-webkit: Add entries for ENABLE_FTPDIR (enabled by default)
  13396. * qmake/mkspecs/features/features.prf: ENABLE_FTPDIR must be set to match Platform.h,
  13397. as, for Qt platform, build-webkit does not add on command line what it thinks to be default values
  13398. 2012-02-13 Shinya Kawanaka <shinyak@chromium.org>
  13399. Add shinyak as committer.
  13400. Unreviewed.
  13401. * Scripts/webkitpy/common/config/committers.py:
  13402. 2012-02-13 Adam Barth <abarth@webkit.org>
  13403. Implement start/stop_helper for ChromiumAndroidPort
  13404. https://bugs.webkit.org/show_bug.cgi?id=78558
  13405. Reviewed by Dirk Pranke.
  13406. These functions (and their dependencies) set up the Android device for
  13407. testing.
  13408. This patch also includes a few tweaks on the previous patch recommended
  13409. by dpranke.
  13410. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13411. (ChromiumAndroidPort.__init__):
  13412. (ChromiumAndroidPort.start_helper):
  13413. (ChromiumAndroidPort.stop_helper):
  13414. (ChromiumAndroidPort._shut_down_http_server):
  13415. (ChromiumAndroidPort):
  13416. (ChromiumAndroidPort._push_executable):
  13417. (ChromiumAndroidPort._push_fonts):
  13418. (ChromiumAndroidPort._restore_system_font):
  13419. (ChromiumAndroidPort._push_test_resources):
  13420. (ChromiumAndroidPort._push_to_device):
  13421. (ChromiumAndroidPort._pull_from_device):
  13422. (ChromiumAndroidPort._kill_device_process):
  13423. (ChromiumAndroidPort._setup_performance):
  13424. (ChromiumAndroidPort._teardown_performance):
  13425. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  13426. (ChromiumAndroidPortTest):
  13427. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  13428. (PortTestCase):
  13429. (PortTestCase.make_port):
  13430. (PortTestCase.test_default_worker_model):
  13431. 2012-02-13 Adam Barth <abarth@webkit.org>
  13432. Implement enough of ChromiumAndroidPort to make ChromiumAndroidPortTest pass
  13433. https://bugs.webkit.org/show_bug.cgi?id=78550
  13434. Reviewed by Eric Seidel.
  13435. Much of this code just forwards to the "host" port, which seems like a
  13436. reasonable thing to do.
  13437. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13438. (ChromiumAndroidPort.__init__):
  13439. (ChromiumAndroidPort.stop_helper):
  13440. (ChromiumAndroidPort):
  13441. (ChromiumAndroidPort._build_path):
  13442. (ChromiumAndroidPort._path_to_apache):
  13443. (ChromiumAndroidPort._path_to_apache_config_file):
  13444. (ChromiumAndroidPort._path_to_driver):
  13445. (ChromiumAndroidPort._path_to_helper):
  13446. (ChromiumAndroidPort._path_to_image_diff):
  13447. (ChromiumAndroidPort._path_to_lighttpd):
  13448. (ChromiumAndroidPort._path_to_lighttpd_modules):
  13449. (ChromiumAndroidPort._path_to_lighttpd_php):
  13450. (ChromiumAndroidPort._path_to_wdiff):
  13451. (ChromiumAndroidPort._shut_down_http_server):
  13452. * Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
  13453. (ChromiumAndroidPortTest):
  13454. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  13455. (PortTestCase):
  13456. (PortTestCase.make_port):
  13457. (PortTestCase.test_default_worker_model):
  13458. 2012-02-13 Adam Barth <abarth@webkit.org>
  13459. chromium_android.py should implement "virtual" methods from ChromiumPort
  13460. https://bugs.webkit.org/show_bug.cgi?id=78545
  13461. Reviewed by Dirk Pranke.
  13462. This patch adds basic implementations that specialize a bunch of
  13463. functions from ChromiumPort.
  13464. * Scripts/webkitpy/layout_tests/port/chromium_android.py:
  13465. (ChromiumAndroidPort):
  13466. (ChromiumAndroidPort.__init__):
  13467. (ChromiumAndroidPort.default_child_processes):
  13468. (ChromiumAndroidPort.baseline_search_path):
  13469. (ChromiumAndroidPort.check_build):
  13470. (ChromiumAndroidPort.check_sys_deps):
  13471. (ChromiumAndroidPort.default_worker_model):
  13472. (ChromiumAndroidPort.test_expectations):
  13473. (ChromiumAndroidPort.start_http_server):
  13474. (ChromiumAndroidPort.stop_http_server):
  13475. (ChromiumAndroidPort.start_helper):
  13476. (ChromiumAndroidPort.stop_helper):
  13477. 2012-02-13 Adam Barth <abarth@webkit.org>
  13478. Add a skeleton ChromiumAndroid port to webkitpy
  13479. https://bugs.webkit.org/show_bug.cgi?id=78543
  13480. Reviewed by Eric Seidel.
  13481. This patch just adds an empty ChromiumAndroid port object to webkitpy
  13482. and wires it up to the factory objects. An actual implementation will
  13483. follow.
  13484. * Scripts/webkitpy/layout_tests/port/chromium.py:
  13485. (ChromiumPort):
  13486. * Scripts/webkitpy/layout_tests/port/chromium_android.py: Added.
  13487. (ChromiumAndroidPort):
  13488. (ChromiumAndroidPort.__init__):
  13489. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  13490. (ChromiumPortTest.test_all_test_configurations):
  13491. * Scripts/webkitpy/layout_tests/port/factory.py:
  13492. (PortFactory):
  13493. 2012-02-13 Adam Barth <abarth@webkit.org>
  13494. NRWT's HTTP servers should support additional directories for resources
  13495. https://bugs.webkit.org/show_bug.cgi?id=78528
  13496. Reviewed by Eric Seidel.
  13497. This functionality will be used by the Chromium-Android port.
  13498. * Scripts/webkitpy/layout_tests/port/base.py:
  13499. (Port.to.start_http_server):
  13500. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  13501. (LayoutTestApacheHttpd.__init__):
  13502. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  13503. (Lighttpd.__init__):
  13504. (Lighttpd._prepare_config):
  13505. 2012-02-13 Ami Fischman <fischman@chromium.org>
  13506. Add fischman as committer.
  13507. Unreviewed
  13508. * Scripts/webkitpy/common/config/committers.py:
  13509. 2012-02-06 Raphael Kubo da Costa <kubo@profusion.mobi>
  13510. [EFL] Drop support for the Curl network backend.
  13511. https://bugs.webkit.org/show_bug.cgi?id=77874
  13512. Reviewed by Eric Seidel.
  13513. Nobody seems to be maintaining the Curl backend in WebCore, the
  13514. EFL port developers all seem to be using the Soup backend and the
  13515. port itself has many features which are only implemented for the
  13516. latter.
  13517. * DumpRenderTree/efl/CMakeLists.txt: Always link to glib/libsoup
  13518. and always add the required include directories.
  13519. * EWebLauncher/CMakeLists.txt: Add the required glib/libsoup
  13520. include directories and link to them.
  13521. 2012-02-13 Kenichi Ishibashi <bashi@chromium.org>
  13522. [WebSocket] Update pywebsocket to 0.7.1
  13523. https://bugs.webkit.org/show_bug.cgi?id=78484
  13524. pywebsocket-0.7.1 follow the current draft of WebSocket deflate-frame extension.
  13525. Reviewed by Kent Tamura.
  13526. * Scripts/webkitpy/thirdparty/__init__.py:
  13527. (AutoinstallImportHook._install_pywebsocket):
  13528. 2012-02-12 Kangil Han <kangil.han@samsung.com>
  13529. [EFL][DRT] Implement zoomPage{In,Out} and textZoom{In,Out} events.
  13530. https://bugs.webkit.org/show_bug.cgi?id=78091
  13531. Reviewed by Hajime Morita.
  13532. Implemented zoomPageIn, zoomPageOut, textZoomIn and textZoomOut events on EFL DRT.
  13533. This patch will activate around 1,900 test cases from skipped list in EFL port.
  13534. * DumpRenderTree/efl/EventSender.cpp:
  13535. (textZoom):
  13536. (pageZoom):
  13537. (textZoomInCallback):
  13538. (textZoomOutCallback):
  13539. (zoomPageInCallback):
  13540. (zoomPageOutCallback):
  13541. 2012-02-12 Ashod Nakashian <ashodnakashian@yahoo.com>
  13542. KeywordLookupGenerator.py script fails in some cases
  13543. https://bugs.webkit.org/show_bug.cgi?id=77886
  13544. Reviewed by Benjamin Poulain.
  13545. * Scripts/webkitpy/style/checker.py: New rule for Keywords.table to not have CR.
  13546. * Scripts/webkitpy/style/checker_unittest.py: New UT for Keywords.table rule.
  13547. (GlobalVariablesTest.test_path_rules_specifier):
  13548. 2012-02-12 Joe Thomas <joethomas@motorola.com>
  13549. Add toText and isTextNode helpers in Text class.
  13550. https://bugs.webkit.org/show_bug.cgi?id=78140
  13551. Unit test case for the new style checker introduced.
  13552. Reviewed by Adam Barth.
  13553. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  13554. (CppStyleTest):
  13555. (CppStyleTest.test_static_cast_readability): Added a unit test case.
  13556. 2012-02-12 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  13557. Enable features supported by EFL port in build-webkit.
  13558. https://bugs.webkit.org/show_bug.cgi?id=78348
  13559. Reviewed by Ryosuke Niwa.
  13560. Sync build-webkit with OptionEfl.cmake, as some features enabled in
  13561. OptionEfl.cmake are not enabled in build-webkit.
  13562. * Scripts/build-webkit:
  13563. 2012-02-12 Joe Thomas <joethomas@motorola.com>
  13564. Add toText and isTextNode helpers in Text class.
  13565. https://bugs.webkit.org/show_bug.cgi?id=78140
  13566. Added a style checker to use toText rather than static_cast<Text*>.
  13567. Reviewed by Adam Barth.
  13568. * Scripts/webkitpy/style/checkers/cpp.py:
  13569. (check_language): Style checker for static_cast<Text*>.
  13570. 2012-02-12 Philippe Normand <pnormand@igalia.com>
  13571. Unreviewed, disable Mutation observers build on GTK until it can
  13572. actually build.
  13573. * Scripts/build-webkit:
  13574. 2012-02-11 Benjamin Poulain <benjamin@webkit.org>
  13575. Add back WTFURL to WebKit
  13576. https://bugs.webkit.org/show_bug.cgi?id=77291
  13577. Reviewed by Adam Barth.
  13578. Add a flag to build-webkit to easily build WebKit with WTFURL.
  13579. * Scripts/build-webkit:
  13580. 2012-02-10 Adam Klein <adamk@chromium.org>
  13581. Enable MUTATION_OBSERVERS by default on all platforms
  13582. https://bugs.webkit.org/show_bug.cgi?id=78196
  13583. Reviewed by Ojan Vafai.
  13584. * Scripts/build-webkit:
  13585. 2012-02-10 Adam Barth <abarth@webkit.org>
  13586. Move garden-o-matic's All Failures out of experimental
  13587. https://bugs.webkit.org/show_bug.cgi?id=78395
  13588. Reviewed by Dimitri Glazkov.
  13589. Several folks have tried this feature and found it useful.
  13590. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  13591. 2012-02-10 Tim Horton <timothy_horton@apple.com>
  13592. NRWT should categorize options in --help
  13593. https://bugs.webkit.org/show_bug.cgi?id=76221
  13594. Reviewed by Eric Seidel.
  13595. Use optparse's OptionGroup mechanism to logically group NRWT's options,
  13596. providing a better experience when scanning all the options.
  13597. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  13598. (parse_args):
  13599. 2012-02-10 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  13600. [Qt][WK2] Refactor on Qt5 Layout tests' structure
  13601. https://bugs.webkit.org/show_bug.cgi?id=77450
  13602. Reviewed by Csaba Osztrogonác.
  13603. Fix the scripts and related unittest due to the rename of qt-wk2 and qt-wk1
  13604. to qt-5.0-wk2 and qt-5.0-wk1.
  13605. * Scripts/old-run-webkit-tests:
  13606. (buildPlatformResultHierarchy):
  13607. (readSkippedFiles):
  13608. * Scripts/webkitpy/layout_tests/port/qt.py:
  13609. (QtPort._wk2_port_name):
  13610. (QtPort._skipped_file_search_paths):
  13611. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  13612. (QtPortTest.test_baseline_search_path):
  13613. * Scripts/webkitpy/layout_tests/port/webkit.py:
  13614. (WebKitPort._wk2_port_name):
  13615. 2012-02-09 Philippe Normand <pnormand@igalia.com>
  13616. [GTK] EWS command-line option to run the tests
  13617. https://bugs.webkit.org/show_bug.cgi?id=78211
  13618. Reviewed by Adam Barth.
  13619. New --run-tests option (defaults to False) for the EWS commands.
  13620. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  13621. (AbstractEarlyWarningSystem):
  13622. (AbstractEarlyWarningSystem.__init__):
  13623. (AbstractEarlyWarningSystem.review_patch):
  13624. (ChromiumLinuxEWS):
  13625. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  13626. (EarlyWarningSytemTest._test_builder_ews):
  13627. 2012-02-09 Eric Seidel <eric@webkit.org>
  13628. Rename compare_text and compare_audio to make it clear that they're !=
  13629. https://bugs.webkit.org/show_bug.cgi?id=78301
  13630. Reviewed by Adam Barth.
  13631. I also removed the maybe_create_directory function which was redundant.
  13632. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  13633. (Manager.set_up_run):
  13634. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  13635. (TestResultWriter._make_output_directory):
  13636. * Scripts/webkitpy/layout_tests/port/base.py:
  13637. (Port.do_text_results_differ):
  13638. (Port.do_audio_results_differ):
  13639. (Port.diff_text):
  13640. (Port.driver_name):
  13641. (Port.skips_perf_test):
  13642. * Scripts/webkitpy/layout_tests/port/win.py:
  13643. (WinPort.do_text_results_differ):
  13644. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  13645. (WinPortTest.test_do_text_results_differ):
  13646. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  13647. (LayoutTestApacheHttpd.__init__):
  13648. * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
  13649. (HttpServerBase.__init__):
  13650. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  13651. (Rebaseliner._diff_baselines):
  13652. 2012-02-09 Zan Dobersek <zandobersek@gmail.com>
  13653. [GTK] Add DRT support for modal dialogs
  13654. https://bugs.webkit.org/show_bug.cgi?id=53600
  13655. Reviewed by Martin Robinson.
  13656. Implement the modal dialogs handling in DumpRenderTree and GtkLauncher.
  13657. Most significantly, when creating a new web view in GtkLauncher, the window
  13658. of the web view opener is passed around. In DumpRenderTree, the window of
  13659. the main web view is always considered as the opener. This is required so
  13660. the modal dialog's toplevel can be made transient for the opener's toplevel.
  13661. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  13662. (webViewRunModalDialog):
  13663. (createWebView):
  13664. * GtkLauncher/main.c:
  13665. (createWebViewCb):
  13666. (runModalDialogCb):
  13667. (createBrowser):
  13668. (createWindow):
  13669. (main):
  13670. 2012-02-09 Zan Dobersek <zandobersek@gmail.com>
  13671. [Gtk] security/set-form-autocomplete-attribute.html fails
  13672. https://bugs.webkit.org/show_bug.cgi?id=78261
  13673. Reviewed by Martin Robinson.
  13674. Use the new helper in DumpRenderTreeSupportGtk to properly
  13675. test whether an element performs autocompletion.
  13676. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  13677. (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  13678. 2012-02-09 James Robinson <jamesr@chromium.org>
  13679. [chromium] Enable mock scrollbars for compositing layout tests
  13680. https://bugs.webkit.org/show_bug.cgi?id=78299
  13681. Reviewed by Dirk Pranke.
  13682. This enables mock scrollbars by default for compositing tests. These pixel tests are intended to test the
  13683. compositor behavior, not native theming, and having real scrollbars causes us to have to maintain significantly
  13684. more pngs than we should and expose weird alpha bugs in our theming that doesn't impact real users.
  13685. * DumpRenderTree/chromium/TestShell.cpp:
  13686. (TestShell::runFileTest):
  13687. * DumpRenderTree/chromium/WebPreferences.cpp:
  13688. (WebPreferences::reset):
  13689. (WebPreferences::applyTo):
  13690. * DumpRenderTree/chromium/WebPreferences.h:
  13691. (WebPreferences):
  13692. 2012-02-09 Eric Seidel <eric@webkit.org>
  13693. Remove more uses of "os" from our webkitpy code
  13694. https://bugs.webkit.org/show_bug.cgi?id=78292
  13695. Reviewed by Adam Barth.
  13696. * Scripts/webkitpy/common/checkout/checkout_mock.py:
  13697. (MockCheckout.__init__):
  13698. (MockCheckout.is_path_to_changelog):
  13699. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  13700. * Scripts/webkitpy/common/system/filesystem_mock.py:
  13701. (MockFileSystem._split):
  13702. * Scripts/webkitpy/common/system/zipfileset_unittest.py:
  13703. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  13704. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  13705. * Scripts/webkitpy/layout_tests/port/webkit.py:
  13706. * Scripts/webkitpy/tool/bot/queueengine.py:
  13707. * Scripts/webkitpy/tool/bot/sheriff_unittest.py:
  13708. * Scripts/webkitpy/tool/commands/download.py:
  13709. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  13710. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  13711. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  13712. * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  13713. * Scripts/webkitpy/tool/commands/upload.py:
  13714. (CreateBug.prompt_for_bug_title_and_comment):
  13715. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  13716. * Scripts/webkitpy/tool/steps/attachtobug.py:
  13717. (AttachToBug.run):
  13718. * Scripts/webkitpy/tool/steps/checkstyle.py:
  13719. * Scripts/webkitpy/tool/steps/cleanworkingdirectory.py:
  13720. * Scripts/webkitpy/tool/steps/commit_unittest.py:
  13721. * Scripts/webkitpy/tool/steps/editchangelog.py:
  13722. * Scripts/webkitpy/tool/steps/preparechangelog.py:
  13723. * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  13724. (PrepareChangeLogTest.test_ensure_bug_url):
  13725. * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
  13726. * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  13727. * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  13728. * Scripts/webkitpy/tool/steps/validatereviewer.py:
  13729. 2012-02-09 Eric Seidel <eric@webkit.org>
  13730. Remove the cr-mac-ews (it's long been dead)
  13731. https://bugs.webkit.org/show_bug.cgi?id=78267
  13732. Reviewed by Adam Barth.
  13733. * QueueStatusServer/model/queues.py:
  13734. (Queue):
  13735. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  13736. (ChromiumWindowsEWS):
  13737. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  13738. (EarlyWarningSytemTest._test_builder_ews):
  13739. (EarlyWarningSytemTest._test_testing_ews):
  13740. 2012-02-09 Dirk Pranke <dpranke@chromium.org>
  13741. some tests in webkitpy are being run three times
  13742. https://bugs.webkit.org/show_bug.cgi?id=78283
  13743. Reviewed by Ryosuke Niwa.
  13744. It turns out that if you import a class derived from
  13745. unittest.TestCase as a base name (e.g., from ... import ChangeLogTest),
  13746. the unittest framework treats it as if the class was defined in
  13747. the file (as well in the original file). This led us to running
  13748. the tests in ChangeLogTest three times.
  13749. * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  13750. (PrepareChangeLogTest):
  13751. * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
  13752. (_assert_message_for_revert_output):
  13753. 2012-02-09 Adam Barth <abarth@webkit.org>
  13754. Remove extraneous line in previous patch. I forgot to remove this
  13755. before landing.
  13756. * Scripts/webkitpy/layout_tests/port/driver.py:
  13757. (DriverProxy.start):
  13758. 2012-02-09 Adam Barth <abarth@webkit.org>
  13759. run-perf-tests should have an option to pause before running tests so we can attach Instruments
  13760. https://bugs.webkit.org/show_bug.cgi?id=78271
  13761. Reviewed by Ryosuke Niwa.
  13762. This lets me attach instruments to profile the performance of the test.
  13763. * Scripts/webkitpy/layout_tests/port/chromium.py:
  13764. (ChromiumDriver.start):
  13765. * Scripts/webkitpy/layout_tests/port/driver.py:
  13766. (Driver.start):
  13767. (DriverProxy.start):
  13768. * Scripts/webkitpy/layout_tests/port/server_process.py:
  13769. (ServerProcess.start):
  13770. * Scripts/webkitpy/layout_tests/port/test.py:
  13771. (TestDriver.start):
  13772. * Scripts/webkitpy/layout_tests/port/webkit.py:
  13773. (WebKitDriver.start):
  13774. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  13775. (get_tests_run.RecordingTestDriver.start):
  13776. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  13777. (PerfTestsRunner._parse_args):
  13778. (PerfTestsRunner._run_tests_set):
  13779. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  13780. (start):
  13781. (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
  13782. (test_run_test_set_kills_drt_per_run):
  13783. (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount):
  13784. (test_run_test_set_kills_drt_per_run.TestDriverWithStartCount.start):
  13785. 2012-02-09 Adam Barth <abarth@webkit.org>
  13786. run-perf-tests --chromium should run the chromium port
  13787. https://bugs.webkit.org/show_bug.cgi?id=78266
  13788. Reviewed by Ryosuke Niwa.
  13789. This patch makes run-perf-tests work more like run-webkit-tests.
  13790. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  13791. (PerfTestsRunner._parse_args):
  13792. 2012-02-09 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  13793. [Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
  13794. https://bugs.webkit.org/show_bug.cgi?id=77466
  13795. Reviewed by Dirk Pranke.
  13796. Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
  13797. is set or if we should raise an error. A unit test was added.
  13798. * Scripts/webkitpy/layout_tests/port/qt.py:
  13799. (QtPort.operating_system):
  13800. (QtPort):
  13801. (QtPort.check_sys_deps):
  13802. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  13803. (QtPortTest.test_operating_system):
  13804. (QtPortTest):
  13805. (QtPortTest.test_check_sys_deps):
  13806. 2012-02-09 Eric Seidel <eric@webkit.org>
  13807. Rename ports.WebKitPort to DeprecatedPort and make it stop being all class methods
  13808. https://bugs.webkit.org/show_bug.cgi?id=78263
  13809. Reviewed by Adam Barth.
  13810. * Scripts/webkitpy/common/config/ports.py:
  13811. (DeprecatedPort):
  13812. (DeprecatedPort.name):
  13813. (DeprecatedPort.flag):
  13814. (DeprecatedPort.script_path):
  13815. (DeprecatedPort.script_shell_command):
  13816. (DeprecatedPort.port):
  13817. (DeprecatedPort.makeArgs):
  13818. (DeprecatedPort.update_webkit_command):
  13819. (DeprecatedPort.check_webkit_style_command):
  13820. (DeprecatedPort.prepare_changelog_command):
  13821. (DeprecatedPort.build_webkit_command):
  13822. (DeprecatedPort.run_javascriptcore_tests_command):
  13823. (DeprecatedPort.run_webkit_unit_tests_command):
  13824. (DeprecatedPort.run_webkit_tests_command):
  13825. (DeprecatedPort.run_python_unittests_command):
  13826. (DeprecatedPort.run_perl_unittests_command):
  13827. (DeprecatedPort.layout_tests_results_path):
  13828. (MacPort):
  13829. (WinPort):
  13830. (GtkPort):
  13831. (GtkPort.build_webkit_command):
  13832. (GtkPort.run_webkit_tests_command):
  13833. (QtPort):
  13834. (QtPort.build_webkit_command):
  13835. (EflPort):
  13836. (EflPort.build_webkit_command):
  13837. (ChromiumPort):
  13838. (ChromiumPort.update_webkit_command):
  13839. (ChromiumPort.build_webkit_command):
  13840. (ChromiumPort.run_webkit_tests_command):
  13841. (ChromiumPort.run_javascriptcore_tests_command):
  13842. (ChromiumXVFBPort):
  13843. (ChromiumXVFBPort.run_webkit_tests_command):
  13844. * Scripts/webkitpy/common/config/ports_unittest.py:
  13845. (DeprecatedPortTest):
  13846. (DeprecatedPortTest.test_mac_port):
  13847. (DeprecatedPortTest.test_gtk_port):
  13848. (DeprecatedPortTest.test_qt_port):
  13849. (DeprecatedPortTest.test_chromium_port):
  13850. (DeprecatedPortTest.test_chromium_xvfb_port):
  13851. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  13852. (AbstractEarlyWarningSystem.__init__):
  13853. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  13854. * Scripts/webkitpy/tool/main.py:
  13855. (WebKitPatch):
  13856. (WebKitPatch.handle_global_options):
  13857. * Scripts/webkitpy/tool/steps/abstractstep.py:
  13858. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  13859. (StepsTest.test_runtests_args):
  13860. 2012-02-09 Jochen Eisinger <jochen@chromium.org>
  13861. [chromium] always initialize makeArgs in buildChromiumNinja
  13862. https://bugs.webkit.org/show_bug.cgi?id=78231
  13863. Reviewed by Tony Gentilcore.
  13864. * Scripts/webkitdirs.pm:
  13865. (buildChromiumNinja):
  13866. 2012-02-09 Carlos Garcia Campos <cgarcia@igalia.com>
  13867. [GTK] Show url of current hovered link in MiniBrowser
  13868. https://bugs.webkit.org/show_bug.cgi?id=78098
  13869. Reviewed by Martin Robinson.
  13870. * MiniBrowser/gtk/BrowserWindow.c:
  13871. (webViewMouseTargetChanged): Check whether hit test result is a
  13872. link and use the url to update the status bar text.
  13873. (browserWindowConstructed): Connect to
  13874. WebKitWebView::mouse-target-changed signal.
  13875. 2012-02-09 Rob Buis <rbuis@rim.com>
  13876. [BlackBerry] Upstream DumpRenderTreeBlackBerry
  13877. https://bugs.webkit.org/show_bug.cgi?id=78042
  13878. Reviewed by Antonio Gomes.
  13879. Upstream final part of our DRT implementation.
  13880. * DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp: Added.
  13881. * DumpRenderTree/blackberry/PNGImageEncoder.cpp: Added.
  13882. * DumpRenderTree/blackberry/PNGImageEncoder.h: Added.
  13883. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp: Added.
  13884. * DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.h: Added.
  13885. 2012-02-09 Ryosuke Niwa <rniwa@webkit.org>
  13886. kill-old-processes should kill gcc and clang
  13887. https://bugs.webkit.org/show_bug.cgi?id=78189
  13888. Reviewed by Eric Seidel.
  13889. Added a bunch of processes names of gcc and clang to the list.
  13890. * BuildSlaveSupport/kill-old-processes:
  13891. 2012-02-07 MORITA Hajime <morrita@google.com>
  13892. Replacement text should be available from the marker.
  13893. https://bugs.webkit.org/show_bug.cgi?id=77934
  13894. Made the mock requestCheckingOfText() implementation to return
  13895. a replacement text for each misspelled word if available.
  13896. Reviewed by Kent Tamura.
  13897. * DumpRenderTree/chromium/WebViewHost.cpp:
  13898. (WebViewHost::finishLastTextCheck):
  13899. 2012-02-08 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  13900. [Qt][DRT] DumpRenderTreeQt should support --no-timeout and --timeout options
  13901. https://bugs.webkit.org/show_bug.cgi?id=78146
  13902. Reviewed by Ryosuke Niwa.
  13903. Our DumpRenderTree should support --no-timeout and --timeout options in order
  13904. to be able to use run-perf-tests and have a Performance Bot.
  13905. This patch adds setTimeout and setShouldTimeout functions to our LayoutTestController
  13906. and the necessary code to handle such command line arguments to our DumpRenderTree.
  13907. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  13908. (WebCore::DumpRenderTree::setTimeout):
  13909. (WebCore):
  13910. (WebCore::DumpRenderTree::setShouldTimeout):
  13911. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  13912. (DumpRenderTree):
  13913. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  13914. (LayoutTestController::LayoutTestController):
  13915. (LayoutTestController::waitUntilDone):
  13916. (LayoutTestController::notifyDone):
  13917. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  13918. (LayoutTestController::setTimeout):
  13919. (LayoutTestController::setShouldTimeout):
  13920. (LayoutTestController):
  13921. * DumpRenderTree/qt/main.cpp:
  13922. (isOption):
  13923. (printUsage):
  13924. (main):
  13925. 2012-02-08 Gustavo Noronha Silva <gns@gnome.org>
  13926. Rubber-stamped by Martin Robinson.
  13927. * gtk/common.py:
  13928. (get_build_path): Move test for current directory being a valid
  13929. directory up so it takes precedence over WebKitBuild/Release and
  13930. WebKitBuild/Debug when they exist as well.
  13931. 2012-02-08 Gustavo Noronha Silva <gns@gnome.org>
  13932. [GTK] doc rebasing does not respect DESTDIR
  13933. https://bugs.webkit.org/show_bug.cgi?id=78177
  13934. Reviewed by Martin Robinson.
  13935. * GNUmakefile.am: Pass DESTDIR on to generate-gtkdoc, when
  13936. calling it for rebasing.
  13937. * gtk/generate-gtkdoc:
  13938. (get_common_options): Handle the new --virtual-root option.
  13939. * gtk/gtkdoc.py:
  13940. (GTKDoc.rebase_installed_docs): If a virtual-root has been given, pass
  13941. it on to gtkdoc-rebase as dest-dir, and prefix the htmldir with it.
  13942. 2012-02-08 Adam Barth <abarth@webkit.org>
  13943. Remove Python 2.5 support from WebKit
  13944. https://bugs.webkit.org/show_bug.cgi?id=71593
  13945. Reviewed by Eric Seidel.
  13946. This is the last vestige of our Python 2.5 support.
  13947. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  13948. (AbstractQueueTest.test_log_from_script_error_for_upload):
  13949. 2012-02-08 Adam Barth <abarth@webkit.org>
  13950. version_check.py should inform users that we don't support Python 2.5 anymore
  13951. https://bugs.webkit.org/show_bug.cgi?id=78179
  13952. Reviewed by Eric Seidel.
  13953. We don't support Python 2.5 anymore.
  13954. * Scripts/webkitpy/common/version_check.py:
  13955. 2012-02-08 Adam Barth <abarth@webkit.org>
  13956. test_configuration.py shouldn't re-implement itertools
  13957. https://bugs.webkit.org/show_bug.cgi?id=78178
  13958. Reviewed by Eric Seidel.
  13959. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  13960. (TestConfigurationConverter.to_specifiers_list):
  13961. (TestConfigurationConverter.to_specifiers_list.try_collapsing):
  13962. (TestConfigurationConverter.to_specifiers_list.try_abbreviating):
  13963. (TestConfigurationConverter):
  13964. 2012-02-08 Adam Barth <abarth@webkit.org>
  13965. webkitpy should reply upon the multiprocessing package existing
  13966. https://bugs.webkit.org/show_bug.cgi?id=78176
  13967. Reviewed by Eric Seidel.
  13968. Now that we don't support Python 2.5, this import can't fail.
  13969. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  13970. (get):
  13971. (_Process):
  13972. (_Process.__init__):
  13973. (_Process.run):
  13974. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  13975. (FunctionTests.test_get__processes):
  13976. (MultiProcessBrokerTests.setUp):
  13977. * Scripts/webkitpy/layout_tests/port/base.py:
  13978. (Port.__init__):
  13979. (Port.default_worker_model):
  13980. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  13981. (ChromiumMacPort.check_build):
  13982. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  13983. (PortTestCase.test_default_worker_model):
  13984. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  13985. 2012-02-08 Gustavo Noronha Silva <gns@gnome.org>
  13986. Unreviewed typo fix that makes docs build again for the gtk2-based
  13987. library.
  13988. * gtk/generate-gtkdoc:
  13989. 2012-02-08 Adam Barth <abarth@webkit.org>
  13990. Don't re-implement ZipFile.extractall
  13991. https://bugs.webkit.org/show_bug.cgi?id=78173
  13992. Reviewed by Eric Seidel.
  13993. We can use ZipFile.extractall now that we don't support Python 2.5.
  13994. * Scripts/webkitpy/common/system/autoinstall.py:
  13995. (AutoInstaller._extract_targz):
  13996. (AutoInstaller._unzip):
  13997. 2012-02-08 Adam Barth <abarth@webkit.org>
  13998. Remove the ospath compat shim from webkitpy
  13999. https://bugs.webkit.org/show_bug.cgi?id=78170
  14000. Reviewed by Eric Seidel.
  14001. We no longer need this compat shim now that we don't support Python 2.5.
  14002. * Scripts/webkitpy/common/checkout/scm/git.py:
  14003. * Scripts/webkitpy/common/checkout/scm/svn.py:
  14004. * Scripts/webkitpy/common/system/filesystem.py:
  14005. (FileSystem.relpath):
  14006. * Scripts/webkitpy/common/system/filesystem_mock.py:
  14007. (MockFileSystem.relpath):
  14008. * Scripts/webkitpy/common/system/ospath.py: Removed.
  14009. * Scripts/webkitpy/common/system/ospath_unittest.py: Removed.
  14010. 2012-02-08 Ryosuke Niwa <rniwa@webkit.org>
  14011. Build fix attempt after r107053.
  14012. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14013. (test_collect_tests):
  14014. 2012-02-08 Adam Barth <abarth@webkit.org>
  14015. Remove simplejson because it's no longer used by webkitpy
  14016. https://bugs.webkit.org/show_bug.cgi?id=78164
  14017. Reviewed by Eric Seidel.
  14018. All the importers of this code were removed in a previous patch.
  14019. * Scripts/webkitpy/thirdparty/simplejson: Removed.
  14020. * Scripts/webkitpy/thirdparty/simplejson/LICENSE.txt: Removed.
  14021. * Scripts/webkitpy/thirdparty/simplejson/README.txt: Removed.
  14022. * Scripts/webkitpy/thirdparty/simplejson/__init__.py: Removed.
  14023. * Scripts/webkitpy/thirdparty/simplejson/_speedups.c: Removed.
  14024. * Scripts/webkitpy/thirdparty/simplejson/decoder.py: Removed.
  14025. * Scripts/webkitpy/thirdparty/simplejson/encoder.py: Removed.
  14026. * Scripts/webkitpy/thirdparty/simplejson/jsonfilter.py: Removed.
  14027. * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Removed.
  14028. * Scripts/webkitpy/thirdparty/simplejson/scanner.py: Removed.
  14029. * Scripts/webkitpy/thirdparty/simplejson/tool.py: Removed.
  14030. 2012-02-08 Adam Barth <abarth@webkit.org>
  14031. webkitpy still imports simplejson
  14032. https://bugs.webkit.org/show_bug.cgi?id=78161
  14033. Reviewed by Eric Seidel.
  14034. We no longer support Python 2.5, so we can rely upon Python's built-in
  14035. JSON package.
  14036. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  14037. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  14038. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py:
  14039. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  14040. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  14041. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  14042. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14043. * Scripts/webkitpy/style/checkers/jsonchecker.py:
  14044. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  14045. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  14046. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  14047. 2012-02-08 Gustavo Noronha Silva <gns@gnome.org>
  14048. [GTK] Fails to build docs with non-standard build directories
  14049. https://bugs.webkit.org/show_bug.cgi?id=78118
  14050. * gtk/common.py:
  14051. (get_build_path): add comment to document changes done in r107098,
  14052. as requested by the reviewer and forgotten by me.
  14053. 2012-02-08 Adam Barth <abarth@webkit.org>
  14054. Stop importing with_statement from the mysterious future
  14055. https://bugs.webkit.org/show_bug.cgi?id=78156
  14056. Reviewed by Eric Seidel.
  14057. The future is now! (Well, at least 2008, when Python 2.6 was released,
  14058. is no longer the __future__.)
  14059. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  14060. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  14061. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  14062. * Scripts/webkitpy/common/net/credentials_unittest.py:
  14063. * Scripts/webkitpy/common/net/file_uploader.py:
  14064. * Scripts/webkitpy/common/newstringio_unittest.py:
  14065. * Scripts/webkitpy/common/system/autoinstall.py:
  14066. * Scripts/webkitpy/common/system/crashlogs.py:
  14067. * Scripts/webkitpy/common/system/fileset.py:
  14068. * Scripts/webkitpy/common/system/filesystem.py:
  14069. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  14070. * Scripts/webkitpy/common/system/path.py:
  14071. * Scripts/webkitpy/common/thread/threadedmessagequeue.py:
  14072. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  14073. * Scripts/webkitpy/layout_tests/port/base.py:
  14074. (of):
  14075. * Scripts/webkitpy/layout_tests/port/gtk.py:
  14076. * Scripts/webkitpy/layout_tests/port/test.py:
  14077. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14078. * Scripts/webkitpy/style/filereader_unittest.py:
  14079. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  14080. * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
  14081. * Scripts/webkitpy/tool/commands/analyzechangelog.py:
  14082. * Scripts/webkitpy/tool/commands/queues.py:
  14083. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  14084. * Scripts/webkitpy/tool/steps/preparechangelogforrevert_unittest.py:
  14085. 2012-02-08 Rob Buis <rbuis@rim.com>
  14086. [BlackBerry] Upstream DumpRenderTreeBlackBerry
  14087. https://bugs.webkit.org/show_bug.cgi?id=78042
  14088. Reviewed by Antonio Gomes.
  14089. Upstream more parts of our DRT implementation.
  14090. * DumpRenderTree/blackberry/AccessibilityControllerBlackBerry.cpp: Added.
  14091. * DumpRenderTree/blackberry/AccessibilityUIElementBlackBerry.cpp: Added.
  14092. * DumpRenderTree/blackberry/EventSender.cpp: Added.
  14093. * DumpRenderTree/blackberry/EventSender.h: Added.
  14094. * DumpRenderTree/blackberry/GCControllerBlackBerry.cpp: Added.
  14095. * DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp: Added.
  14096. 2012-02-08 Dirk Pranke <dpranke@chromium.org>
  14097. check-webkit-style failing with "Path does not exist."
  14098. https://bugs.webkit.org/show_bug.cgi?id=77873
  14099. Reviewed by Ojan Vafai.
  14100. This change fixes the way the style checker determines which
  14101. Port class to use for a given test_expectations.txt path; the
  14102. previous version used a heuristic that didn't really work in the
  14103. first place.
  14104. * Scripts/webkitpy/style/checkers/test_expectations.py:
  14105. (TestExpectationsChecker._determine_port_from_expectations_path):
  14106. (TestExpectationsChecker.__init__):
  14107. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  14108. (TestExpectationsTestCase._expect_port_for_expectations_path):
  14109. (TestExpectationsTestCase.test_determine_port_from_expectations_path):
  14110. 2012-02-08 Fehér Zsolt <feherzs@inf.u-szeged.hu>
  14111. nrwt: make --skip-pixel-test-if-no-baseline option
  14112. https://bugs.webkit.org/show_bug.cgi?id=70484
  14113. Reviewed by Dirk Pranke.
  14114. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  14115. (SingleTestRunner.__init__):
  14116. (SingleTestRunner._should_fetch_expected_checksum):
  14117. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  14118. (Worker.handle_test_list):
  14119. * Scripts/webkitpy/layout_tests/models/test_input.py:
  14120. (TestInput.__init__):
  14121. * Scripts/webkitpy/layout_tests/port/webkit.py:
  14122. (WebKitDriver.cmd_line):
  14123. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  14124. (_set_up_derived_options):
  14125. (parse_args):
  14126. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14127. (MainTest.test_skip_pixel_test_if_no_baseline_option):
  14128. * WebKitTestRunner/TestController.cpp:
  14129. (WTR::TestController::TestController):
  14130. (WTR::TestController::initialize):
  14131. (WTR::TestController::runTest):
  14132. * WebKitTestRunner/TestController.h:
  14133. (TestController):
  14134. * WebKitTestRunner/TestInvocation.cpp:
  14135. (WTR::TestInvocation::TestInvocation):
  14136. (WTR::TestInvocation::setIsPixelTest):
  14137. * WebKitTestRunner/TestInvocation.h:
  14138. (WTR::TestInvocation::setSkipPixelTestOption):
  14139. (TestInvocation):
  14140. 2012-02-08 Rob Buis <rbuis@rim.com>
  14141. [BlackBerry] Upstream DumpRenderTreeBlackBerry
  14142. https://bugs.webkit.org/show_bug.cgi?id=78042
  14143. Reviewed by Antonio Gomes.
  14144. Add implementation for our DumpRenderTree solution.
  14145. * DumpRenderTree/blackberry/DumpRenderTree.cpp: Added.
  14146. * DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h: Added.
  14147. 2012-02-08 Antti Koivisto <antti@apple.com>
  14148. REGRESSION (r106681): Null check missing in [WebFrame(WebInternal) _typingStyle]
  14149. https://bugs.webkit.org/show_bug.cgi?id=78080
  14150. Reviewed by Andreas Kling, Darin Adler and Dan Bernstein.
  14151. Add API test.
  14152. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  14153. * TestWebKitAPI/Tests/mac/TypingStyleCrash.mm: Added.
  14154. (TestWebKitAPI):
  14155. (TestWebKitAPI::TEST):
  14156. 2012-02-08 Gustavo Noronha Silva <gns@gnome.org>
  14157. [GTK] Fails to build docs with non-standard build directories
  14158. https://bugs.webkit.org/show_bug.cgi?id=78118
  14159. Reviewed by Martin Robinson.
  14160. * gtk/common.py:
  14161. (get_build_path): also try the current directory as a valid build
  14162. dir, which makes non-standard build directories such as build-2.0
  14163. and build-3.0 work
  14164. 2012-02-08 Carlos Garcia Campos <cgarcia@igalia.com>
  14165. [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
  14166. https://bugs.webkit.org/show_bug.cgi?id=78099
  14167. Reviewed by Martin Robinson.
  14168. * MiniBrowser/gtk/BrowserWindow.c:
  14169. (webViewDecidePolicy): Check whether it's a link clicked with the
  14170. middle mouse button and load the request in a new window.
  14171. (browserWindowConstructed): Connect to
  14172. WebKitWebView::decide-policy signal.
  14173. 2012-02-08 Ryosuke Niwa <rniwa@webkit.org>
  14174. Revert a part of the change in r106687 as a build fix.
  14175. Since Chromium port doesn't checkout the entire WebKit trunk,
  14176. we can't run "svn info" on webkit_base.
  14177. * Scripts/webkitpy/layout_tests/port/base.py:
  14178. (Port.repository_paths):
  14179. 2012-02-07 Ryosuke Niwa <rniwa@webkit.org>
  14180. run-perf-tests doesn't recognize paths that start with PerformanceTests
  14181. https://bugs.webkit.org/show_bug.cgi?id=78012
  14182. Reviewed by Adam Barth.
  14183. Use resolve paths using filesystem.relpath before passing it to find_files.find.
  14184. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14185. (PerfTestsRunner):
  14186. (PerfTestsRunner._collect_tests):
  14187. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14188. (test_collect_tests):
  14189. (test_collect_tests.add_file):
  14190. 2012-02-07 Justin Novosad <junov@chromium.org>
  14191. [Chromium] add option for 2d canvas defered rendering to DumpRenderTree
  14192. https://bugs.webkit.org/show_bug.cgi?id=78039
  14193. Reviewed by Stephen White.
  14194. Adding the --enable-deferred-2d-canvas switch to DumpRenderTree
  14195. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  14196. (main):
  14197. * DumpRenderTree/chromium/TestShell.cpp:
  14198. (TestShell::TestShell):
  14199. (TestShell::resetWebSettings):
  14200. (TestShell::runFileTest):
  14201. * DumpRenderTree/chromium/TestShell.h:
  14202. (TestShell::setDeferred2dCanvasEnabled):
  14203. (TestShell):
  14204. * DumpRenderTree/chromium/WebPreferences.cpp:
  14205. (WebPreferences::reset):
  14206. (WebPreferences::applyTo):
  14207. * DumpRenderTree/chromium/WebPreferences.h:
  14208. (WebPreferences):
  14209. 2012-02-07 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  14210. [CMAKE] Use *bin* and *lib* directories for executable and libraries.
  14211. https://bugs.webkit.org/show_bug.cgi?id=77928
  14212. Reviewed by Daniel Bates.
  14213. CMake has used *Programs* directory for executable. In addition, shared libraries are being
  14214. built in source directory. It is better to set common places in order to maintain executable
  14215. and libraries. *bin* is for executable and *lib* is for library.
  14216. * DumpRenderTree/efl/CMakeLists.txt:
  14217. * EWebLauncher/CMakeLists.txt:
  14218. * Scripts/run-launcher:
  14219. * Scripts/webkitdirs.pm:
  14220. (jscProductDir):
  14221. * Scripts/webkitpy/layout_tests/port/efl.py:
  14222. (EflPort._path_to_driver):
  14223. (EflPort._path_to_image_diff):
  14224. 2012-02-07 Adam Klein <adamk@chromium.org>
  14225. Add JSC support for delivering mutations when the outermost script context exits
  14226. https://bugs.webkit.org/show_bug.cgi?id=70289
  14227. Reviewed by Eric Seidel.
  14228. * DumpRenderTree/mac/EventSendingController.mm: Add support for
  14229. eventSender.scheduleAsynchronousKeyDown.
  14230. (+[EventSendingController isSelectorExcludedFromWebScript:]):
  14231. (+[EventSendingController webScriptNameForSelector:]):
  14232. (-[EventSendingController keyDownWrapper:withModifiers:withLocation:]):
  14233. (-[EventSendingController scheduleAsynchronousKeyDown:withModifiers:withLocation:]):
  14234. * Scripts/build-webkit: Properly alphabetize --mutation-observers in the --help output.
  14235. 2012-02-07 Chris Rogers <crogers@google.com>
  14236. Add Chris Rogers to reviewers section
  14237. https://bugs.webkit.org/show_bug.cgi?id=78016
  14238. Reviewed by Adam Barth.
  14239. * Scripts/webkitpy/common/config/committers.py:
  14240. 2012-02-07 Nikolas Zimmermann <nzimmermann@rim.com>
  14241. layoutTestController.display() is flaky for SVG tests
  14242. https://bugs.webkit.org/show_bug.cgi?id=78021
  14243. Reviewed by Dan Bernstein.
  14244. Fix race condition in repaint rect tracking. When running a test using the repaint.js
  14245. harness right after a test starting with "svg/W3C-SVG-1.1" the repaint test will fail,
  14246. the gray overlay isn't contained in the pixel dump anymore. This is because of a specific
  14247. hack that forces 480x360 instead of 800x600 pixel test dumps for any test starting with
  14248. svg/W3C-SVG-1.1. The resizing of the web view was done when dumping the render tree, after
  14249. the repaint test already run, thus invalidating the previously tracked repaint rects.
  14250. * DumpRenderTree/mac/DumpRenderTree.mm:
  14251. (dump):
  14252. (runTest):
  14253. 2012-02-07 Hans Wennborg <hans@chromium.org>
  14254. Chromium: remove WebSpeechInputResult::set
  14255. https://bugs.webkit.org/show_bug.cgi?id=77977
  14256. Reviewed by Darin Fisher.
  14257. It was renamed to assign() in r106475.
  14258. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  14259. (makeRectResult):
  14260. 2012-02-07 Allan Sandfeld Jensen <allan.jensen@nokia.com>
  14261. [Qt] Give emulated touch-point a radius
  14262. https://bugs.webkit.org/show_bug.cgi?id=77985
  14263. Increase the radius of touch-point and show the actual size of the touch point in the touch-point mockup.
  14264. Reviewed by Kenneth Rohde Christiansen.
  14265. * MiniBrowser/qt/BrowserWindow.cpp:
  14266. (BrowserWindow::updateVisualMockTouchPoints):
  14267. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  14268. (MiniBrowserApplication::notify):
  14269. * MiniBrowser/qt/qml/MockTouchPoint.qml:
  14270. 2012-02-07 Mario Sanchez Prada <msanchez@igalia.com>
  14271. [GTK] Include gdk-pixbuf in the jhbuild modules
  14272. https://bugs.webkit.org/show_bug.cgi?id=77980
  14273. Reviewed by Gustavo Noronha Silva.
  14274. * gtk/jhbuild.modules: Add gdk-pixbuf to the jhbuild moduleset.
  14275. 2012-02-07 Simon Hausmann <simon.hausmann@nokia.com>
  14276. [Qt] Prevent early test termination with newer Qt 5
  14277. https://bugs.webkit.org/show_bug.cgi?id=77945
  14278. Reviewed by Csaba Osztrogonác.
  14279. QTBUG-24120 tracks a regression in Qt that would make layout tests
  14280. terminate early. This patch works around it in a Qt 4 + 5 safe manner
  14281. by disabling the quitOnLastWindowClosed feature, which we don't want/need
  14282. for DRT anyway.
  14283. * DumpRenderTree/qt/main.cpp:
  14284. (main): Don't quit on last window closed.
  14285. 2012-02-06 Martin Robinson <mrobinson@igalia.com>
  14286. Fix some miscellaneous 'make dist' error for WebKitGTK+.
  14287. * MiniBrowser/gtk/GNUmakefile.am: The MiniBrowser generated
  14288. files should not be distributed.
  14289. 2012-02-02 Hajime Morrita <morrita@chromium.org>
  14290. [PerformanceTests] Each Dromaeo test needs its landing html.
  14291. https://bugs.webkit.org/show_bug.cgi?id=77504
  14292. Reviewed by Ryosuke Niwa.
  14293. Added an ignorable pattern which happens in some Dromaeo tests.
  14294. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14295. (PerfTestsRunner):
  14296. 2012-02-06 Kalev Lember <kalevlember@gmail.com>
  14297. [GTK] Add missing pango include dir to fix build
  14298. https://bugs.webkit.org/show_bug.cgi?id=77832
  14299. Reviewed by Martin Robinson.
  14300. * GNUmakefile.am: Added $(PANGO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
  14301. 2012-02-06 Martin Robinson <mrobinson@igalia.com>
  14302. [GTK] Fix remaining errors in GTK+ WebKit2 API
  14303. https://bugs.webkit.org/show_bug.cgi?id=77890
  14304. Reviewed by Gustavo Noronha Silva.
  14305. Verify that WebKit2 GTK+ test files are not skipped during style checks.
  14306. Skip soup_server_new when checking for NULL versus 0 usage.
  14307. * Scripts/webkitpy/style/checker_unittest.py:
  14308. (CheckerDispatcherSkipTest.test_should_skip_with_warning):
  14309. * Scripts/webkitpy/style/checkers/cpp.py:
  14310. (check_for_null):
  14311. 2012-02-06 Eric Seidel <eric@webkit.org>
  14312. webkit-patch apply-from-bug should be able to apply non-reviewed patches
  14313. https://bugs.webkit.org/show_bug.cgi?id=77883
  14314. Reviewed by Adam Barth.
  14315. This is very helpful if you use bugzilla as a replacement for git-stash.
  14316. Makes it simpler to re-apply the patch w/o having to look up the patch id.
  14317. * Scripts/webkitpy/tool/commands/download.py:
  14318. (ProcessBugsMixin._fetch_list_of_patches_to_process):
  14319. * Scripts/webkitpy/tool/commands/download_unittest.py:
  14320. (DownloadCommandsTest.test_apply_from_bug):
  14321. 2012-02-06 Philippe Normand <pnormand@igalia.com>
  14322. [webkitpy] cpp style-checker complains about readability/naming in GStreamer elements source files
  14323. https://bugs.webkit.org/show_bug.cgi?id=77866
  14324. Reviewed by Martin Robinson.
  14325. * Scripts/webkitpy/style/checker.py: Ignore readability/naming
  14326. errors in some gstreamer source code files defining new GStreamer elements.
  14327. * Scripts/webkitpy/style/checker_unittest.py:
  14328. (GlobalVariablesTest.test_path_rules_specifier):
  14329. 2012-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
  14330. [GTK] Make sure html_dir exists before calling gtkdoc-rebase
  14331. https://bugs.webkit.org/show_bug.cgi?id=77869
  14332. Reviewed by Philippe Normand.
  14333. * gtk/gtkdoc.py:
  14334. (GTKDoc.rebase_installed_docs): Check html_dir exists.
  14335. 2012-02-03 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  14336. [Qt] Don't version QtWebKit.experimental.
  14337. https://bugs.webkit.org/show_bug.cgi?id=77739
  14338. Reviewed by Tor Arne Vestbø.
  14339. * MiniBrowser/qt/qml/BrowserWindow.qml:
  14340. 2012-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
  14341. [GTK] Fix several gtkdoc-fixxref warnings
  14342. https://bugs.webkit.org/show_bug.cgi?id=77613
  14343. Reviewed by Martin Robinson.
  14344. * gtk/generate-gtkdoc:
  14345. (get_webkit1_options): Add webkitspellcheckerenchant.* to the list
  14346. of ignored files, since it's private.
  14347. * gtk/gtkdoc.py:
  14348. (GTKDoc._ignored_files_basenames): Helper function that returns a
  14349. string with the list of ignored files basenames separated by a
  14350. spaces, as expected by several gtkdoc commands.
  14351. (GTKDoc._run_gtkdoc_scan): Use _ignored_files_basenames for
  14352. --ignore-headers option.
  14353. (GTKDoc._run_gtkdoc_mkdb): Use _ignored_files_basenames for
  14354. --ignore-files option.
  14355. 2012-02-06 Carlos Garcia Campos <cgarcia@igalia.com>
  14356. [GTK] Fix xrefs after installing API documentation
  14357. https://bugs.webkit.org/show_bug.cgi?id=77551
  14358. Reviewed by Martin Robinson.
  14359. * GNUmakefile.am: Call generate-gtkdoc --rebase after installing
  14360. api docs.
  14361. * gtk/common.py:
  14362. (prefix_of_pkg_config_file): Get the prefix variable of the given
  14363. pkg-config file.
  14364. (gtk_version_of_pkg_config_file): Get the gtk version required by
  14365. the given pkg-config file.
  14366. * gtk/generate-gtkdoc: Add --rebase command line option to rebase
  14367. installed documentation.
  14368. (get_gtkdoc_module_paths): Get paths where API doc is installed
  14369. for the dependencies of the given pkg-config file.
  14370. (get_common_xref_deps): Get API doc directories of dependencies
  14371. common to WebKit1 and WebKit2.
  14372. (get_webkit2_options): Add cross_reference_deps option.
  14373. (get_webkit1_options): Ditto
  14374. (rebase_installed_docs): Helper function to create a generator for
  14375. the given pkg-config file and options and call rebase_installed_docs.
  14376. * gtk/gtkdoc.py:
  14377. (GTKDoc.__init__): Initialize cross_reference_deps.
  14378. (GTKDoc._run_gtkdoc_fixxref): Add API doc directories of
  14379. dependencies.
  14380. (GTKDoc.rebase_installed_docs): Call gtkdoc-rebase to fix xref
  14381. links of installed documentation.
  14382. (PkgConfigGTKDoc.__init__): Get the prefix from the pkg-config
  14383. file.
  14384. 2012-02-06 Sergio Villar Senin <svillar@igalia.com>
  14385. Incorrect statistics shown when running run-webkit-tests with --repeat-each or --iterations
  14386. https://bugs.webkit.org/show_bug.cgi?id=77672
  14387. Reviewed by Dirk Pranke.
  14388. Test repetitions must be taken into account when working out
  14389. the statistics shown by run-webkit-tests.
  14390. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  14391. (Manager.prepare_lists_and_print_output):
  14392. (Manager._print_result_summary):
  14393. * Scripts/webkitpy/layout_tests/models/result_summary.py:
  14394. (ResultSummary.__init__):
  14395. (ResultSummary.add):
  14396. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  14397. (MainTest.test_repeat_each_iterations_num_tests):
  14398. 2012-02-05 Dan Bernstein <mitz@apple.com>
  14399. <rdar://problem/10809525> WebKit2’s WebFrameLoaderClient::shouldUseCredentialStorage() always returns true
  14400. https://bugs.webkit.org/show_bug.cgi?id=77823
  14401. Reviewed by Anders Carlsson.
  14402. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  14403. (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
  14404. 2012-02-04 Dan Bernstein <mitz@apple.com>
  14405. <rdar://problem/10660698> Clients cannot prevent caching of individual responses
  14406. https://bugs.webkit.org/show_bug.cgi?id=77822
  14407. Reviewed by Sam Weinig.
  14408. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  14409. (WTR::InjectedBundlePage::InjectedBundlePage): Updated for the additional callback.
  14410. 2012-02-04 Sam Weinig <sam@webkit.org>
  14411. Add ability to send WKURLRequests in WebKit2 API user messages
  14412. https://bugs.webkit.org/show_bug.cgi?id=77819
  14413. Reviewed by Anders Carlsson.
  14414. Add testing for round-tripping WKTypes from the UIProcess,
  14415. to the WebProcess, and back.
  14416. - This commit adds a test fixture and tests for WKURLRequestRef, WKURLRef, and WKStringRef.
  14417. More can easily be added.
  14418. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  14419. * TestWebKitAPI/Tests/WebKit2/UserMessage.cpp: Added.
  14420. (TestWebKitAPI):
  14421. (WebKit2UserMessageRoundTripTest):
  14422. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::WebKit2UserMessageRoundTripTest):
  14423. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didReceiveMessageFromInjectedBundle):
  14424. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::didFinishLoadForFrame):
  14425. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setInjectedBundleClient):
  14426. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
  14427. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::SetUp):
  14428. (TestWebKitAPI::WebKit2UserMessageRoundTripTest::roundTrip):
  14429. (TestWebKitAPI::TEST_F):
  14430. * TestWebKitAPI/Tests/WebKit2/UserMessage_Bundle.cpp: Added.
  14431. (TestWebKitAPI):
  14432. (UserMessageTest):
  14433. (TestWebKitAPI::UserMessageTest::UserMessageTest):
  14434. (TestWebKitAPI::UserMessageTest::didReceiveMessage):
  14435. * TestWebKitAPI/mac/PlatformWebViewMac.mm:
  14436. (TestWebKitAPI::PlatformWebView::resizeTo):
  14437. (TestWebKitAPI):
  14438. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  14439. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  14440. 2012-02-04 Dan Bernstein <mitz@apple.com>
  14441. <rdar://problem/10772406> WKPreferences instances cannot be copied
  14442. https://bugs.webkit.org/show_bug.cgi?id=77816
  14443. Reviewed by Sam Weinig.
  14444. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  14445. (TestWebKitAPI::TEST):
  14446. 2012-02-04 Adam Barth <abarth@webkit.org>
  14447. garden-o-matic's All Failure tab should let you examine and rebaseline expected failures
  14448. https://bugs.webkit.org/show_bug.cgi?id=77802
  14449. Reviewed by Eric Seidel.
  14450. This patch refactors our directory grouping code into base.js where it
  14451. can be shared between failures.js and notifications.js. It then adds
  14452. an Examine action to each group of failures that triggers the "results"
  14453. view.
  14454. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  14455. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  14456. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  14457. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  14458. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  14459. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
  14460. 2012-02-04 Ojan Vafai <ojan@chromium.org>
  14461. check-webkit-style is throwing an exception
  14462. https://bugs.webkit.org/show_bug.cgi?id=77744
  14463. Reviewed by David Levin.
  14464. If the test_list is None, then we don't need to check for unsupported
  14465. feature tests to skip.
  14466. * Scripts/webkitpy/layout_tests/port/webkit.py:
  14467. (WebKitPort._has_test_in_directories):
  14468. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  14469. (test_skipped_tests_for_unsupported_features_empty_test_list):
  14470. 2012-02-03 Adam Barth <abarth@webkit.org>
  14471. List of all failures in garden-o-matic should actually list all the failures
  14472. https://bugs.webkit.org/show_bug.cgi?id=77796
  14473. Reviewed by Eric Seidel.
  14474. This patch wires a bit more data into the new "All Failures" tab. I've
  14475. also iterated on how we enable this experimental feature. The tab is
  14476. still just a dumb list, but we'll make it smarter.
  14477. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  14478. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  14479. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  14480. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  14481. 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
  14482. Windows build fix after r106692.
  14483. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  14484. (PortTest.test_reference_files):
  14485. 2012-02-03 Beth Dakin <bdakin@apple.com>
  14486. https://bugs.webkit.org/show_bug.cgi?id=77782
  14487. WebPageProxy::didNewFirstVisuallyNonEmptyLayout should is called more than
  14488. once on some pages with frames
  14489. -and corresponding-
  14490. <rdar://problem/10798474>
  14491. Reviewed by Sam Weinig.
  14492. One new test.
  14493. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  14494. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp: Added.
  14495. (TestWebKitAPI):
  14496. (TestWebKitAPI::didForceRepaint):
  14497. (TestWebKitAPI::didFinishLoadForFrame):
  14498. (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
  14499. (TestWebKitAPI::setPageLoaderClient):
  14500. (TestWebKitAPI::TEST):
  14501. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames_Bundle.cpp: Added.
  14502. (TestWebKitAPI):
  14503. (NewFirstVisuallyNonEmptyLayoutFramesTest):
  14504. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::NewFirstVisuallyNonEmptyLayoutFramesTest):
  14505. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFramesTest::didCreatePage):
  14506. * TestWebKitAPI/Tests/WebKit2/lots-of-iframes.html: Added.
  14507. 2012-02-03 Dirk Pranke <dpranke@chromium.org>
  14508. webkitpy: change exit() calls to sys.exit(), fix a leak in outputcapture
  14509. https://bugs.webkit.org/show_bug.cgi?id=77781
  14510. Reviewed by Eric Seidel.
  14511. This change fixes a couple of issues discovered while debugging
  14512. test-webkitpy; both calling exit() instead of sys.exit() --
  14513. which is discouraged in program code instead of the interpreter
  14514. -- and a particular usage of outputcapture were stdin to get whacked
  14515. and preventing debugging.
  14516. This change introduces a couple of common _exit() methods that
  14517. will standardize how webkit-patch exit's, in case we need to do
  14518. something different in the future.
  14519. * Scripts/webkitpy/common/system/deprecated_logging.py:
  14520. (error):
  14521. * Scripts/webkitpy/common/system/outputcapture.py:
  14522. (OutputCapture.assert_outputs):
  14523. * Scripts/webkitpy/tool/bot/queueengine.py:
  14524. (QueueEngine.exit_after_handled_error):
  14525. * Scripts/webkitpy/tool/commands/abstractsequencedcommand.py:
  14526. (AbstractSequencedCommand.execute):
  14527. * Scripts/webkitpy/tool/commands/queues.py:
  14528. (StyleQueue.handle_script_error):
  14529. * Scripts/webkitpy/tool/commands/upload.py:
  14530. (MarkBugFixed.execute):
  14531. * Scripts/webkitpy/tool/multicommandtool.py:
  14532. (Command._exit):
  14533. * Scripts/webkitpy/tool/steps/abstractstep.py:
  14534. (AbstractStep._exit):
  14535. * Scripts/webkitpy/tool/steps/checkstyle.py:
  14536. (CheckStyle.run):
  14537. * Scripts/webkitpy/tool/steps/commit.py:
  14538. (Commit._check_test_expectations):
  14539. * Scripts/webkitpy/tool/steps/confirmdiff.py:
  14540. (ConfirmDiff.run):
  14541. 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
  14542. Perf bot build fix.
  14543. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14544. (PerfTestsRunner._generate_json):
  14545. 2012-02-03 Adam Barth <abarth@webkit.org>
  14546. Add a blank "Expected Failures" tab to garden-o-matic
  14547. https://bugs.webkit.org/show_bug.cgi?id=77793
  14548. Reviewed by Eric Seidel.
  14549. This tab will help us explore and manage our expected failures. The
  14550. tab is hidden by default via a new "experimental features" flag.
  14551. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  14552. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  14553. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  14554. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  14555. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
  14556. (#unexpected):
  14557. (#onebar.partytime #unexpected):
  14558. 2012-02-03 Lucas Forschler <lforschler@apple.com>
  14559. update-webkit-support-libraries is broken with the change from http to https on developer.apple.com
  14560. https://bugs.webkit.org/show_bug.cgi?id=77785
  14561. Fix the build bots.
  14562. Pass the -k and --sslv3 keys to make curl work with https on https://developer.apple.com
  14563. * Scripts/update-webkit-support-libs:
  14564. (downloadExpectedVersionNumber):
  14565. 2012-02-03 Lucas Forschler <lforschler@apple.com>
  14566. Add a Mac Lion Performance bot.
  14567. https://bugs.webkit.org/show_bug.cgi?id=77765
  14568. Reviewed by Adam Roben.
  14569. This will update the master configuration in the following ways:
  14570. Add a new performance slave (apple-xseve-11)
  14571. Add a new Factory to download a build and run perf tests.
  14572. * BuildSlaveSupport/build.webkit.org-config/config.json:
  14573. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  14574. (DownloadAndPerfTestFactory):
  14575. (DownloadAndPerfTestFactory.__init__):
  14576. 2012-02-03 Dirk Pranke <dpranke@chromium.org>
  14577. Extra TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk in repository
  14578. https://bugs.webkit.org/show_bug.cgi?id=77752
  14579. Reviewed by James Robinson.
  14580. Delete unneeded file accidentally checked in in r106481.
  14581. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.target.chromium.mk: Removed.
  14582. 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
  14583. Ref Tests should support plain SVG files
  14584. https://bugs.webkit.org/show_bug.cgi?id=77685
  14585. Reviewed by Tony Chang.
  14586. Don't assume reference files always use .html as the extension.
  14587. Instead, use the list of supported extension to look for -expected.* and -mismatch.*
  14588. Also fix various bugs in MockFileSystem and TestPort.
  14589. * Scripts/webkitpy/common/system/filesystem_mock.py:
  14590. (MockFileSystem.isdir):
  14591. * Scripts/webkitpy/layout_tests/port/base.py:
  14592. (Port.reference_files):
  14593. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  14594. (PortTest.test_is_test_file):
  14595. (PortTest.test_reference_files):
  14596. * Scripts/webkitpy/layout_tests/port/test.py:
  14597. (TestInstance.__init__):
  14598. 2012-02-03 Ryosuke Niwa <rniwa@webkit.org>
  14599. perf-o-matic should store chromium svn revision
  14600. https://bugs.webkit.org/show_bug.cgi?id=77725
  14601. Reviewed by Dirk Pranke.
  14602. Report both WebKit and Chromium revisions to the graph server. Renamed test_repository_paths to
  14603. repository_paths since it's nothing to do with tests. Also refactored scm so that head_svn_revision
  14604. is implemented in terms of newly added svn_revision.
  14605. * Scripts/webkitpy/common/checkout/scm/git.py:
  14606. (Git.svn_revision):
  14607. * Scripts/webkitpy/common/checkout/scm/scm.py:
  14608. (SCM.head_svn_revision):
  14609. (SCM):
  14610. (SCM.svn_revision):
  14611. * Scripts/webkitpy/common/checkout/scm/scm_mock.py:
  14612. (MockSCM.svn_revision):
  14613. * Scripts/webkitpy/common/checkout/scm/svn.py:
  14614. (SVN.svn_revision):
  14615. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  14616. (JSONLayoutResultsGenerator.__init__):
  14617. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  14618. (JSONResultsGeneratorBase._insert_generic_metadata):
  14619. * Scripts/webkitpy/layout_tests/port/base.py:
  14620. (Port.repository_paths):
  14621. * Scripts/webkitpy/layout_tests/port/chromium.py:
  14622. (ChromiumPort.repository_paths):
  14623. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14624. (PerfTestsRunner._generate_json):
  14625. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14626. (test_run_test_set_with_json_output):
  14627. (test_run_test_set_with_json_source):
  14628. (test_run_test_set_with_multiple_repositories):
  14629. 2012-02-03 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  14630. [Qt] Split QQuickWebViewPrivate in two classes, for desktop and touch behavior.
  14631. https://bugs.webkit.org/show_bug.cgi?id=77632
  14632. Reviewed by Kenneth Rohde Christiansen.
  14633. * MiniBrowser/qt/BrowserWindow.cpp:
  14634. (BrowserWindow::BrowserWindow):
  14635. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  14636. (MiniBrowserApplication::sendTouchEvent):
  14637. (MiniBrowserApplication::handleUserOptions):
  14638. * MiniBrowser/qt/MiniBrowserApplication.h:
  14639. (WindowOptions):
  14640. (WindowOptions::WindowOptions):
  14641. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  14642. (WTR::PlatformWebView::PlatformWebView):
  14643. * WebKitTestRunner/qt/main.cpp:
  14644. (main):
  14645. * qmake/mkspecs/features/default_post.prf:
  14646. 2012-02-03 Simon Hausmann <simon.hausmann@nokia.com>
  14647. [Qt] Replace GNU linker script for exports with export macros in WTF/JSC
  14648. https://bugs.webkit.org/show_bug.cgi?id=77723
  14649. Reviewed by Tor Arne Vestbø.
  14650. * Tools.pro: Compile WTR again on all platforms with WK2.
  14651. 2012-02-03 Sriram Neelakandan <sriram.neelakandan@gmail.com>
  14652. Ensure that inspector disabled build works
  14653. https://bugs.webkit.org/show_bug.cgi?id=77604
  14654. Reviewed by Tor Arne Vestbø.
  14655. * qmake/mkspecs/features/features.prf:
  14656. 2012-02-02 Jochen Eisinger <jochen@chromium.org>
  14657. [chromium] add support for --makeargs to the ninja-based build
  14658. https://bugs.webkit.org/show_bug.cgi?id=77688
  14659. Reviewed by Adam Barth.
  14660. * Scripts/webkitdirs.pm:
  14661. (buildChromiumNinja):
  14662. 2012-02-02 Eric Seidel <eric@webkit.org>
  14663. Run tests in serial on SnowLeopard to avoid CFURLCache crashes
  14664. https://bugs.webkit.org/show_bug.cgi?id=75145
  14665. Reviewed by Dirk Pranke.
  14666. * Scripts/webkitpy/layout_tests/port/mac.py:
  14667. (MacPort.default_child_processes):
  14668. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  14669. (test_operating_system):
  14670. (test_default_child_processes):
  14671. 2012-02-02 Dirk Pranke <dpranke@chromium.org>
  14672. nrwt shouldn't blow up when there are errors in test_expectations.txt
  14673. https://bugs.webkit.org/show_bug.cgi?id=73603
  14674. Reviewed by Ojan Vafai.
  14675. This change removes the distinction between 'errors' and 'warnings'
  14676. in the test expectations parser. Now, any problem is a
  14677. 'warning', and if we are linting the file, warnings become fatal (errors).
  14678. This will allow a normal run-webkit-tests run to proceed even if
  14679. there are bad lines.
  14680. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  14681. (ParseError.__init__):
  14682. (ParseError.__str__):
  14683. (ParseError.__repr__):
  14684. (TestExpectationSerializer.to_string):
  14685. (TestExpectationParser._parse_modifiers):
  14686. (TestExpectationParser._parse_expectations):
  14687. (TestExpectationParser._check_modifiers_against_expectations):
  14688. (TestExpectationParser._tokenize):
  14689. (TestExpectationLine.__init__):
  14690. (TestExpectationLine.is_invalid):
  14691. (TestExpectationsModel.add_expectation_line):
  14692. (TestExpectationsModel._already_seen_better_match):
  14693. (TestExpectations.__init__):
  14694. (TestExpectations._report_warnings):
  14695. (TestExpectations.remove_rebaselined_tests.without_rebaseline_modifier):
  14696. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  14697. (assert_bad_expectations):
  14698. (test_parse_warning):
  14699. (test_overrides__duplicate):
  14700. (ExpectationSyntaxTests.test_missing_expectation):
  14701. (ExpectationSyntaxTests.test_missing_colon):
  14702. (ExpectationSyntaxTests.test_too_many_colons):
  14703. (ExpectationSyntaxTests.test_too_many_equals_signs):
  14704. (ExpectationSyntaxTests.test_unrecognized_expectation):
  14705. (SemanticTests.test_bug_format):
  14706. (SemanticTests.test_bad_bugid):
  14707. (SemanticTests.test_slow_and_timeout):
  14708. (test_ambiguous):
  14709. (test_more_modifiers):
  14710. (test_order_in_file):
  14711. (test_macro_overrides):
  14712. (RebaseliningTest.assertRemove):
  14713. (TestExpectationParserTests.test_tokenize_blank):
  14714. (TestExpectationParserTests.test_tokenize_missing_colon):
  14715. (TestExpectationParserTests.test_tokenize_extra_colon):
  14716. (TestExpectationParserTests.test_tokenize_empty_comment):
  14717. (TestExpectationParserTests.test_tokenize_comment):
  14718. (TestExpectationParserTests.test_tokenize_missing_equal):
  14719. (TestExpectationParserTests.test_tokenize_extra_equal):
  14720. (TestExpectationParserTests.test_tokenize_valid):
  14721. (TestExpectationParserTests.test_tokenize_valid_with_comment):
  14722. (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
  14723. (TestExpectationSerializerTests.test_unparsed_to_string):
  14724. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  14725. (lint):
  14726. * Scripts/webkitpy/style/checkers/test_expectations.py:
  14727. (TestExpectationsChecker.check_test_expectations):
  14728. 2012-02-02 Sheriff Bot <webkit.review.bot@gmail.com>
  14729. Unreviewed, rolling out r106543.
  14730. http://trac.webkit.org/changeset/106543
  14731. https://bugs.webkit.org/show_bug.cgi?id=77671
  14732. Made tests less stable (Requested by rniwa on #webkit).
  14733. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14734. (PerfTestsRunner):
  14735. (PerfTestsRunner.__init__):
  14736. (PerfTestsRunner._run_tests_set):
  14737. (PerfTestsRunner._run_single_test):
  14738. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14739. (MainTest.TestDriver.run_test):
  14740. (run_test):
  14741. 2012-02-02 Beth Dakin <bdakin@apple.com>
  14742. https://bugs.webkit.org/show_bug.cgi?id=77664
  14743. Add API tests for didNewFirstVisuallyNonEmptyLayout
  14744. Reviewed by Darin Adler.
  14745. Two new tests.
  14746. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  14747. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp: Added.
  14748. (TestWebKitAPI):
  14749. (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
  14750. (TestWebKitAPI::setPageLoaderClient):
  14751. (TestWebKitAPI::TEST):
  14752. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails.cpp: Added.
  14753. (TestWebKitAPI):
  14754. (TestWebKitAPI::didForceRepaint):
  14755. (TestWebKitAPI::didFinishLoadForFrame):
  14756. (TestWebKitAPI::didNewFirstVisuallyNonEmptyLayout):
  14757. (TestWebKitAPI::setPageLoaderClient):
  14758. (TestWebKitAPI::TEST):
  14759. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFails_Bundle.cpp: Added.
  14760. (TestWebKitAPI):
  14761. (NewFirstVisuallyNonEmptyLayoutFailsTest):
  14762. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::NewFirstVisuallyNonEmptyLayoutFailsTest):
  14763. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutFailsTest::didCreatePage):
  14764. * TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout_Bundle.cpp: Added.
  14765. (TestWebKitAPI):
  14766. (NewFirstVisuallyNonEmptyLayoutTest):
  14767. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::NewFirstVisuallyNonEmptyLayoutTest):
  14768. (TestWebKitAPI::NewFirstVisuallyNonEmptyLayoutTest::didCreatePage):
  14769. 2012-02-02 Michael Saboff <msaboff@apple.com>
  14770. Add Michael Saboff to reviewers list.
  14771. Rubber-stamped by Gavin Barraclough.
  14772. * Scripts/webkitpy/common/config/committers.py:
  14773. 2012-02-02 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  14774. Add myself as a committer
  14775. Unreviewed
  14776. * Scripts/webkitpy/common/config/committers.py:
  14777. 2012-02-02 Ryosuke Niwa <rniwa@webkit.org>
  14778. [PerformanceTests] tests have dependencies
  14779. https://bugs.webkit.org/show_bug.cgi?id=77506
  14780. Reviewed by Hajime Morita.
  14781. Load an initialization page before each test after starting a DRT so that
  14782. warming up DRT won't affect the performance test results.
  14783. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14784. (PerfTestsRunner):
  14785. (PerfTestsRunner.__init__):
  14786. (PerfTestsRunner._run_tests_set):
  14787. (PerfTestsRunner._run_single_test):
  14788. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14789. (MainTest.TestDriver.run_test):
  14790. (test_initial_page_loaded):
  14791. (test_initial_page_loaded.run_test):
  14792. 2012-02-02 Ryosuke Niwa <rniwa@webkit.org>
  14793. Re-land r106442 per Adam's suggestion. We'll do both restarting DRT and loading a fake test first.
  14794. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14795. (PerfTestsRunner._run_tests_set):
  14796. (PerfTestsRunner._run_single_test):
  14797. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14798. (create_runner):
  14799. (test_run_passing_test):
  14800. (test_run_silent_test):
  14801. (test_run_failed_test):
  14802. (test_run_tonguey_test):
  14803. (test_run_timeout_test):
  14804. (test_run_crash_test):
  14805. (test_run_test_set_kills_drt_per_run):
  14806. (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
  14807. (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
  14808. (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
  14809. 2012-02-01 Jacob Goldstein <jacobg@adobe.com>
  14810. Webkit generate-coverage-data script needs update to use new test script
  14811. https://bugs.webkit.org/show_bug.cgi?id=77597
  14812. Reviewed by Dirk Schulze.
  14813. * Scripts/generate-coverage-data:
  14814. 2012-02-01 Adam Barth <abarth@webkit.org>
  14815. Update the tests to show that the mac-ews processes patches from
  14816. non-committers.
  14817. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  14818. (EarlyWarningSytemTest.test_committer_only_ewses):
  14819. (EarlyWarningSytemTest.test_builder_ewses):
  14820. 2012-02-01 Adam Barth <abarth@webkit.org>
  14821. Mac-ews logs are huge
  14822. https://bugs.webkit.org/show_bug.cgi?id=77045
  14823. Reviewed by Eric Seidel.
  14824. In order to get the cr-linux-ews bot to run tests on EC2, we created
  14825. the chromium-xvfb port, which contained a number of tweaks to the
  14826. Chromium port's behavior. This patch refactors those tweaks so they
  14827. can be shared with the mac-ews, mostly by moving them into the
  14828. non-interactive mode of RunTests.
  14829. * Scripts/webkitpy/common/config/ports.py:
  14830. (WebKitPort):
  14831. (WebKitPort.layout_tests_results_path):
  14832. (ChromiumPort.run_javascriptcore_tests_command):
  14833. (ChromiumXVFBPort):
  14834. (ChromiumXVFBPort.run_webkit_tests_command):
  14835. * Scripts/webkitpy/common/config/ports_mock.py:
  14836. (MockPort):
  14837. (MockPort.layout_tests_results_path):
  14838. * Scripts/webkitpy/common/config/ports_unittest.py:
  14839. (WebKitPortTest.test_chromium_xvfb_port):
  14840. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  14841. (LayoutTestResultsReaderTest.test_missing_layout_test_results):
  14842. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  14843. (CommitQueueTest.test_commit_queue):
  14844. (test_rollout):
  14845. (test_manual_reject_during_processing):
  14846. * Scripts/webkitpy/tool/steps/runtests.py:
  14847. (RunTests.run):
  14848. * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  14849. (RunTestsTest.test_no_unit_tests):
  14850. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  14851. (StepsTest.test_runtests_args):
  14852. 2012-02-01 Ryosuke Niwa <rniwa@webkit.org>
  14853. Roll out r106442. It made some tests more stable but others less stable.
  14854. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14855. (PerfTestsRunner._run_tests_set):
  14856. (PerfTestsRunner._run_single_test):
  14857. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14858. (create_runner):
  14859. (test_run_passing_test):
  14860. (test_run_silent_test):
  14861. (test_run_failed_test):
  14862. (test_run_tonguey_test):
  14863. (test_run_timeout_test):
  14864. (test_run_crash_test):
  14865. (test_run_test_set):
  14866. 2012-02-01 Lucas Forschler <lforschler@apple.com>
  14867. Enable EWS for non-contributers.
  14868. https://bugs.webkit.org/show_bug.cgi?id=77576
  14869. Reviewed by Adam Barth.
  14870. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  14871. (MacEWS):
  14872. 2012-02-01 Beth Dakin <bdakin@apple.com>
  14873. https://bugs.webkit.org/show_bug.cgi?id=77383
  14874. Add a different didFirstVisuallNonEmptyLayout heuristic to experiment with
  14875. -and corresponding-
  14876. <rdar://problem/10709560>
  14877. Reviewed by Sam Weinig.
  14878. WebKit2's WebLoaderClient has a temporary new function that must be accounted
  14879. for.
  14880. * MiniBrowser/mac/BrowserWindowController.m:
  14881. (-[BrowserWindowController awakeFromNib]):
  14882. * WebKitTestRunner/TestController.cpp:
  14883. (WTR::TestController::initialize):
  14884. 2012-02-01 Dirk Pranke <dpranke@chromium.org>
  14885. TestWebKitAPI isn't being built on chromium bots any more
  14886. https://bugs.webkit.org/show_bug.cgi?id=77563
  14887. Reviewed by Dimitri Glazkov.
  14888. I accidentally dropped it in the refactoring in r105449.
  14889. * TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp: Added.
  14890. 2012-02-01 Hans Wennborg <hans@chromium.org>
  14891. Rename WebSpeechInputResult::set() to assign()
  14892. https://bugs.webkit.org/show_bug.cgi?id=77540
  14893. Reviewed by Darin Fisher.
  14894. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  14895. (MockWebSpeechInputController::addMockRecognitionResult):
  14896. (MockWebSpeechInputController::speechTaskFired):
  14897. 2012-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
  14898. [GTK] WebKit1 API documentation is not generated when building with gtk-2.0
  14899. https://bugs.webkit.org/show_bug.cgi?id=77542
  14900. Reviewed by Martin Robinson.
  14901. * gtk/generate-gtkdoc: Check first whether there's
  14902. webkitgtk-3.0.pc and if it doesn't exist use webkitgtk-1.0.pc
  14903. instead.
  14904. (get_webkit2_options): Return just the options since the
  14905. pkg_config_path doesn't depend on options
  14906. (get_webkit1_options): Ditto.
  14907. (generate_doc): Helper function to create a generator and generate
  14908. documentation for the given pkg-config file with the given options.
  14909. * gtk/gtkdoc.py:
  14910. (GTKDoc.__init__): Don't use ** for args parameter, since it's
  14911. used as a dict and never expanded.
  14912. (PkgConfigGTKDoc.__init__): Ditto.
  14913. 2012-02-01 Carlos Garcia Campos <cgarcia@igalia.com>
  14914. [GTK] API documentation is not installed even when building with --enable-gtk-doc
  14915. https://bugs.webkit.org/show_bug.cgi?id=77094
  14916. Reviewed by Martin Robinson.
  14917. * GNUmakefile.am: Add install-data-local and uninstall-local rules
  14918. to install/uninstall WebKit1 and WebKit2 API documentation.
  14919. 2012-02-01 Sheriff Bot <webkit.review.bot@gmail.com>
  14920. Unreviewed, rolling out r106460.
  14921. http://trac.webkit.org/changeset/106460
  14922. https://bugs.webkit.org/show_bug.cgi?id=77552
  14923. It break unit tests if WEBKIT_TESTFONTS isn't defined.
  14924. (Requested by Ossy on #webkit).
  14925. * Scripts/webkitpy/layout_tests/port/qt.py:
  14926. 2012-02-01 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
  14927. [Qt] Automatic clean build feature always do clean build with --no-webkit2
  14928. https://bugs.webkit.org/show_bug.cgi?id=74519
  14929. Reviewed by Tor Arne Vestbø.
  14930. Set the PLUGIN_ARCHITECTURE_UNSUPPORTED define always.
  14931. * qmake/mkspecs/features/features.prf:
  14932. 2012-02-01 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  14933. [Qt][WK2] run-webkit-tests --qt crashes if WEBKIT_TESTFONTS is not set
  14934. https://bugs.webkit.org/show_bug.cgi?id=77466
  14935. Reviewed by Kenneth Rohde Christiansen.
  14936. Replicate the behavior of old-run-webkit-tests and check if WEBKIT_TESTFONTS
  14937. is set or if we should raise an error.
  14938. * Scripts/webkitpy/layout_tests/port/qt.py:
  14939. (QtPort.setup_environ_for_server):
  14940. 2012-02-01 Philippe Normand <pnormand@igalia.com> and Sergio Villar Senin <svillar@igalia.com>
  14941. Reviewed by Martin Robinson.
  14942. [GTK] Improve FrameLoader signals. Resource loading
  14943. https://bugs.webkit.org/show_bug.cgi?id=49543
  14944. Support for the new loader signals in DRT.
  14945. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  14946. (urlPath):
  14947. (willSendRequestCallback):
  14948. (urlSuitableForTestResult):
  14949. (descriptionSuitableForTestResult):
  14950. (didReceiveResponse):
  14951. (didFinishLoading):
  14952. (didFailLoadingWithError):
  14953. (createWebView):
  14954. 2012-02-01 Ryosuke Niwa <rniwa@webkit.org>
  14955. run-perf-tests should restart DRT for each test
  14956. https://bugs.webkit.org/show_bug.cgi?id=77506
  14957. Reviewed by Adam Barth.
  14958. Always restart DRT when running performance tests in order to minimize the dependency between tests.
  14959. * Scripts/webkitpy/layout_tests/port/chromium.py:
  14960. (ChromiumDriver.stop):
  14961. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  14962. (PerfTestsRunner._run_tests_set):
  14963. (PerfTestsRunner._run_single_test):
  14964. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  14965. (create_runner):
  14966. (test_run_passing_test):
  14967. (test_run_silent_test):
  14968. (test_run_failed_test):
  14969. (test_run_tonguey_test):
  14970. (test_run_timeout_test):
  14971. (test_run_crash_test):
  14972. (test_run_test_set_kills_drt_per_run):
  14973. (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount):
  14974. (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.__init__):
  14975. (test_run_test_set_kills_drt_per_run.TestDriverWithStopCount.stop):
  14976. 2012-01-31 Hans Wennborg <hans@chromium.org>
  14977. Speech Input: Report speech element rect relative to window rather than frame
  14978. https://bugs.webkit.org/show_bug.cgi?id=76443
  14979. Reviewed by Darin Fisher.
  14980. Update LayoutTestController to allow for retrieving the speech
  14981. element's position used in a request.
  14982. In Chromium this is handled by the MockWebSpeechInputController;
  14983. adding stubs for the other implementations.
  14984. * DumpRenderTree/LayoutTestController.cpp:
  14985. (setMockSpeechInputDumpRectCallback):
  14986. (LayoutTestController::staticFunctions):
  14987. * DumpRenderTree/LayoutTestController.h:
  14988. (LayoutTestController):
  14989. * DumpRenderTree/chromium/LayoutTestController.cpp:
  14990. (LayoutTestController::LayoutTestController):
  14991. (LayoutTestController::setMockSpeechInputDumpRect):
  14992. * DumpRenderTree/chromium/LayoutTestController.h:
  14993. (LayoutTestController):
  14994. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp:
  14995. (MockWebSpeechInputController::setDumpRect):
  14996. (MockWebSpeechInputController::clearResults):
  14997. (MockWebSpeechInputController::startRecognition):
  14998. (MockWebSpeechInputController::MockWebSpeechInputController):
  14999. (makeRectResult):
  15000. (MockWebSpeechInputController::speechTaskFired):
  15001. * DumpRenderTree/chromium/MockWebSpeechInputController.h:
  15002. (MockWebSpeechInputController):
  15003. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  15004. (LayoutTestController::setMockSpeechInputDumpRect):
  15005. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  15006. (LayoutTestController::setMockSpeechInputDumpRect):
  15007. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  15008. (LayoutTestController::setMockSpeechInputDumpRect):
  15009. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  15010. (LayoutTestController::setMockSpeechInputDumpRect):
  15011. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  15012. (LayoutTestController):
  15013. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  15014. (LayoutTestController::setMockSpeechInputDumpRect):
  15015. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  15016. (LayoutTestController::setMockSpeechInputDumpRect):
  15017. 2012-01-31 Ryuan Choi <ryuan.choi@samsung.com>
  15018. [EFL] Add basic DRT/Efl implementation to support viewport test.
  15019. https://bugs.webkit.org/show_bug.cgi?id=77320
  15020. Reviewed by Andreas Kling.
  15021. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  15022. (LayoutTestController::dumpConfigurationForViewport): call dumpConfigurationForViewport().
  15023. 2012-01-31 Alexey Proskuryakov <ap@apple.com>
  15024. REGRESSION (WebKit2): event.keyCode is always zero when typing in Russian
  15025. https://bugs.webkit.org/show_bug.cgi?id=77473
  15026. <rdar://problem/10751357>
  15027. Reviewed by Darin Adler.
  15028. * DumpRenderTree/mac/EventSendingController.mm:
  15029. (-[EventSendingController keyDown:withModifiers:withLocation:]):
  15030. * WebKitTestRunner/mac/EventSenderProxy.mm:
  15031. (WTR::EventSenderProxy::keyDown):
  15032. Added a new special keyDown value to test this.
  15033. 2012-01-31 Dirk Pranke <dpranke@chromium.org>
  15034. nrwt: fix the mock port to work with DriverProxy, reftests
  15035. https://bugs.webkit.org/show_bug.cgi?id=77170
  15036. Reviewed by Eric Seidel.
  15037. The DryrunPort used for benchmarking and testing NRWT has been
  15038. broken since we added the DriverProxy code. It isn't really
  15039. needed any more, so I've removed it.
  15040. The MockDRT port was also broken by DriverProxy, and moreover,
  15041. never worked w/ reftests. Since we don't exercise this module in
  15042. the unit tests, the code had also bitrotted some. I have cleaned
  15043. it up and made it use DriverInput and DriverOutput for
  15044. consistency.
  15045. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  15046. (DryRunPort.__init__):
  15047. (DryRunPort):
  15048. (DryRunPort.real_name):
  15049. (DryRunPort.create_driver):
  15050. (DryRunPort.driver_cmd_line):
  15051. (DryRunPort._driver_class):
  15052. (DryrunDriver):
  15053. (DryrunDriver.run_test):
  15054. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  15055. (MockDRTPort.create_driver):
  15056. (MockChromiumDRT.run_one_test):
  15057. 2012-01-31 Ojan Vafai <ojan@chromium.org>
  15058. run-webkit-tests calls out to webkit-build-directory twice
  15059. https://bugs.webkit.org/show_bug.cgi?id=77248
  15060. Reviewed by Dirk Pranke.
  15061. * Scripts/webkit-build-directory:
  15062. If called with no arguments, print out both the top-level directory and the
  15063. configuration directory
  15064. * Scripts/webkitpy/layout_tests/port/config.py:
  15065. (Config.build_directory):
  15066. When called with no arguments, get and cache both the top-level and configuration directories.
  15067. * Scripts/webkitpy/layout_tests/port/config_standalone.py:
  15068. (main):
  15069. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  15070. (ConfigTest.assert_configuration):
  15071. (ConfigTest.test_build_directory.mock_webkit_build_directory):
  15072. (ConfigTest.test_build_directory):
  15073. (ConfigTest.test_default_configuration__notfound):
  15074. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15075. (WebKitPort._build_path):
  15076. Cache the build directory in the options object so that other users
  15077. of the options object don't need to call out to webkit-build-directory.
  15078. Also, properly support the existing --build-directory argument.
  15079. 2012-01-31 Ryosuke Niwa <rniwa@webkit.org>
  15080. Bump up the timeout for performance tests since DOM/DOMTable.html
  15081. and Parser/html5-full-render.html are timing out on the bot.
  15082. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  15083. (PerfTestsRunner._parse_args):
  15084. 2012-01-31 Ehsan Akhgari <ehsan.akhgari@gmail.com>
  15085. Fix the update_webgl_conformance_tests.py script in order to enable it
  15086. to detect the SCM being used correctly.
  15087. https://bugs.webkit.org/show_bug.cgi?id=77462
  15088. Reviewed by Kenneth Russell.
  15089. * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
  15090. (default_out_dir):
  15091. 2012-01-31 Eric Seidel <eric@webkit.org>
  15092. webkit-patch apply-from-bug should work regardless of your CWD
  15093. https://bugs.webkit.org/show_bug.cgi?id=77482
  15094. Reviewed by Adam Barth.
  15095. webkit-patch only ever works with patches made from the root
  15096. directory. We should pass the CWD to svn-apply in the case
  15097. where we're running not from the webkit root. I believe
  15098. this used to work in the past and regressed.
  15099. * Scripts/webkitpy/common/checkout/checkout.py:
  15100. (Checkout.apply_patch):
  15101. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  15102. (CheckoutTest.test_apply_patch):
  15103. 2012-01-31 Sheriff Bot <webkit.review.bot@gmail.com>
  15104. Unreviewed, rolling out r106302.
  15105. http://trac.webkit.org/changeset/106302
  15106. https://bugs.webkit.org/show_bug.cgi?id=77472
  15107. Broke building DRT before running the tests (Requested by ojan
  15108. on #webkit).
  15109. * Scripts/webkit-build-directory:
  15110. * Scripts/webkitpy/layout_tests/port/config.py:
  15111. (Config.build_directory):
  15112. * Scripts/webkitpy/layout_tests/port/config_standalone.py:
  15113. (main):
  15114. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  15115. (ConfigTest.assert_configuration):
  15116. (ConfigTest.test_build_directory.mock_webkit_build_directory):
  15117. (ConfigTest.test_build_directory):
  15118. (ConfigTest.test_default_configuration__notfound):
  15119. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15120. (WebKitPort._build_path):
  15121. 2012-01-31 Antoine Labour <piman@chromium.org>
  15122. Merge WebGraphicsContext3D creation and initialization, and move it to
  15123. WebViewClient.
  15124. https://bugs.webkit.org/show_bug.cgi?id=76593
  15125. Reviewed by Darin Fisher.
  15126. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  15127. (TestWebPlugin::TestWebPlugin):
  15128. (TestWebPlugin::initialize):
  15129. * DumpRenderTree/chromium/TestWebPlugin.h:
  15130. * DumpRenderTree/chromium/WebViewHost.cpp:
  15131. (WebViewHost::createGraphicsContext3D):
  15132. (WebViewHost::createPlugin):
  15133. * DumpRenderTree/chromium/WebViewHost.h:
  15134. 2012-01-31 Gabor Rapcsanyi <rgabor@webkit.org>
  15135. [GTK] build-webkit warning.
  15136. https://bugs.webkit.org/show_bug.cgi?id=77411
  15137. Reviewed by Philippe Normand.
  15138. * Scripts/webkitdirs.pm:
  15139. (isCrossCompilation):
  15140. 2012-01-31 Dan Bernstein <mitz@apple.com>
  15141. When generating derived sources, use the same compiler that is used to compile WebKitTestRunner.
  15142. Reviewed by Anders Carlsson.
  15143. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  15144. 2012-01-31 Csaba Osztrogonác <ossy@webkit.org>
  15145. If the QTDIR environment variable is set, the build system fails to compile WinCairo
  15146. https://bugs.webkit.org/show_bug.cgi?id=77112
  15147. Reviewed by Daniel Bates.
  15148. * Scripts/webkitdirs.pm:
  15149. (determineIsQt):
  15150. 2012-01-31 Adam Roben <aroben@apple.com>
  15151. Only call -typingAttributes on WebViews, not WebHTMLViews
  15152. Looks like this case was just missed in r105908.
  15153. Fixes <http://webkit.org/b/77432> REGRESSION (r105908): WebKit1.InspectorBarTest is crashing
  15154. Reviewed by Antti Koivisto.
  15155. * TestWebKitAPI/Tests/mac/InspectorBar.mm:
  15156. (TestWebKitAPI::TEST): Call -typingAttributes on the WebView, just like we do 2 lines
  15157. earlier.
  15158. 2012-01-31 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  15159. [Qt] MiniBrowser: Show touch mocking indicators only when Ctrl is held down.
  15160. https://bugs.webkit.org/show_bug.cgi?id=77221
  15161. Reviewed by Kenneth Rohde Christiansen.
  15162. This makes sure that the indicator isn't in the way when doing clicks or dealing with the rest of the UI.
  15163. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  15164. (MiniBrowserApplication::sendTouchEvent):
  15165. 2012-01-26 Hans Wennborg <hans@chromium.org>
  15166. Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
  15167. https://bugs.webkit.org/show_bug.cgi?id=77083
  15168. Reviewed by Darin Fisher.
  15169. Add MockWebSpeechInputController which provides a mock implementation
  15170. of the WebSpeechInputController interface, and use that in
  15171. DumpRenderTree.
  15172. * DumpRenderTree/DumpRenderTree.gypi:
  15173. * DumpRenderTree/chromium/LayoutTestController.cpp:
  15174. (LayoutTestController::addMockSpeechInputResult):
  15175. * DumpRenderTree/chromium/LayoutTestController.h:
  15176. ():
  15177. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
  15178. (MockWebSpeechInputController::create):
  15179. (MockWebSpeechInputController::addMockRecognitionResult):
  15180. (MockWebSpeechInputController::clearResults):
  15181. (MockWebSpeechInputController::startRecognition):
  15182. (MockWebSpeechInputController::cancelRecognition):
  15183. (MockWebSpeechInputController::stopRecording):
  15184. (MockWebSpeechInputController::MockWebSpeechInputController):
  15185. (MockWebSpeechInputController::speechTaskFired):
  15186. (MockWebSpeechInputController::SpeechTask::SpeechTask):
  15187. (MockWebSpeechInputController::SpeechTask::stop):
  15188. (MockWebSpeechInputController::SpeechTask::runIfValid):
  15189. * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
  15190. (WebKit):
  15191. (MockWebSpeechInputController):
  15192. (MockWebSpeechInputController::taskList):
  15193. (SpeechTask):
  15194. * DumpRenderTree/chromium/TestShell.cpp:
  15195. * DumpRenderTree/chromium/WebViewHost.cpp:
  15196. (WebViewHost::speechInputController):
  15197. * DumpRenderTree/chromium/WebViewHost.h:
  15198. (WebKit):
  15199. (WebViewHost::speechInputControllerMock):
  15200. (WebViewHost):
  15201. ():
  15202. 2012-01-31 Hajime Morrita <morrita@chromium.org>
  15203. [PerformanceTests] Add landing html for Dromaeo dom-query test
  15204. https://bugs.webkit.org/show_bug.cgi?id=77329
  15205. Reviewed by Ryosuke Niwa.
  15206. Added some more ignorable output patterns to allow warnings
  15207. from a third party test suite.
  15208. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  15209. (PerfTestsRunner):
  15210. (PerfTestsRunner._should_ignore_line_in_parser_test_result):
  15211. 2012-01-30 Kevin Ollivier <kevino@theolliviers.com>
  15212. [wx] Unreviewed. Update download URLs to new domain.
  15213. * waf/build/build_utils.py:
  15214. (update_wx_deps):
  15215. 2012-01-30 Kevin Ollivier <kevino@theolliviers.com>
  15216. [wx] Unreviewed. Build fix, add JavaScriptCore/tools
  15217. to the list of build directories.
  15218. * waf/build/settings.py:
  15219. 2012-01-30 Kentaro Hara <haraken@chromium.org>
  15220. REGRESSION(r105797): prepare-ChangeLog for a .cpp file can
  15221. output an empty method name (i.e. "()")
  15222. https://bugs.webkit.org/show_bug.cgi?id=77336
  15223. Reviewed by Darin Adler.
  15224. r105797 tried to detect a change outside methods, but it causes a bug that
  15225. prepare-ChangeLog can output an empty method name, like this:
  15226. * foo/bar/baz.cpp:
  15227. (method1):
  15228. ():
  15229. (method2):
  15230. This is because the cpp parser in prepare-ChangeLog cannot distinguish
  15231. '{' as the beginning of a method with '{' as the beginning of an array definition
  15232. at the top level.
  15233. int a[] = { 1, 2, 3 }; // This '{' is the beginning of an array definition.
  15234. void func() { // This '{' is the beginning of a method.
  15235. ...;
  15236. }
  15237. This patch fixes prepare-ChangeLog so that it skips an array definition at the top level.
  15238. * Scripts/prepare-ChangeLog:
  15239. (get_function_line_ranges_for_cpp): Modified as described above.
  15240. (generateFunctionLists): As a hack, modified so that prepare-ChangeLog does not output
  15241. an empty method name. Ideally this should not happen but may happen, since the
  15242. parsers are not perfect.
  15243. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
  15244. (NameSpace7):
  15245. (NameSpace8):
  15246. (Class109):
  15247. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
  15248. 2012-01-30 Ojan Vafai <ojan@chromium.org>
  15249. run-webkit-tests calls out to webkit-build-directory twice
  15250. https://bugs.webkit.org/show_bug.cgi?id=77248
  15251. Reviewed by Dirk Pranke.
  15252. This reduces to calls to webkit-build-directory to one call and
  15253. saves 500ms for run-webkit-tests over a single file.
  15254. * Scripts/webkit-build-directory:
  15255. If called with no arguments, print out both the top-level directory and the
  15256. configuration directory.
  15257. * Scripts/webkit-build-directory:
  15258. * Scripts/webkitpy/layout_tests/port/config.py:
  15259. (Config.build_directory):
  15260. When called with no arguments, get and cache both the top-level and configuration directories.
  15261. * Scripts/webkitpy/layout_tests/port/config_standalone.py:
  15262. (main):
  15263. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  15264. (ConfigTest.assert_configuration):
  15265. (ConfigTest.test_build_directory.mock_webkit_build_directory):
  15266. (ConfigTest.test_build_directory):
  15267. (ConfigTest.test_default_configuration__notfound):
  15268. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15269. (WebKitPort._build_path):
  15270. Cache the root directory in the options object so that other users
  15271. of the options object don't need to call out to webkit-build-directory.
  15272. 2012-01-30 Ojan Vafai <ojan@chromium.org>
  15273. Parsing test_expecations.txt + Skipped lists takes too long
  15274. https://bugs.webkit.org/show_bug.cgi?id=77059
  15275. Reviewed by Dirk Pranke.
  15276. This saves ~100ms on the Apple Mac port.
  15277. -memoize a bunch of path methods.
  15278. -Avoid doing multiple disk accesses per line.
  15279. -Parse the skipped list directly instead of turning it into a test_expecations.txt
  15280. formatting string and parsing that.
  15281. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  15282. (TestExpectationParser):
  15283. (TestExpectationParser.expectation_for_skipped_test):
  15284. (TestExpectationParser._parse_line):
  15285. (TestExpectationParser._collect_matching_tests):
  15286. (TestExpectations.__init__):
  15287. (TestExpectations._add_skipped_tests):
  15288. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  15289. (test_add_skipped_tests):
  15290. (test_add_skipped_tests_duplicate):
  15291. * Scripts/webkitpy/layout_tests/port/base.py:
  15292. (Port):
  15293. (Port.test_isfile):
  15294. (Port.normalize_test_name):
  15295. (Port.layout_tests_dir):
  15296. (Port.abspath_for_test):
  15297. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15298. 2012-01-30 Alexis Menard <alexis.menard@openbossa.org>
  15299. Unreviewed. Add myself to CSS, GStreamer, Qt related watchlists.
  15300. * Scripts/webkitpy/common/config/watchlist:
  15301. 2012-01-30 Gavin Barraclough <barraclough@apple.com>
  15302. Unreviewed build fix following bug#76855
  15303. * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
  15304. ():
  15305. (TestWebKitAPI::TEST_F):
  15306. 2012-01-26 No'am Rosenthal <noam.rosenthal@nokia.com> and Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  15307. [Qt] WKTR: Use a software rendering pipiline when running tests.
  15308. https://bugs.webkit.org/show_bug.cgi?id=76708
  15309. Reviewed by Kenneth Rohde Christiansen.
  15310. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  15311. (WTR::WrapperWindow::WrapperWindow):
  15312. (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
  15313. 2012-01-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  15314. [Qt] Store build config immediately instead of waiting for a successfull build
  15315. Otherwise we will not pick up changes to the config if the build is aborted,
  15316. for example due to build errors or if the user pressed Ctrl+Z. We now write
  15317. the new config before starting a build, but still defer to write the SVN
  15318. revision once the build completes successfully.
  15319. Reviewed by Ossy.
  15320. * Scripts/webkitdirs.pm:
  15321. (buildQMakeProjects):
  15322. 2012-01-30 Alexander Færøy <ahf@0x90.dk>
  15323. [Qt] Add "New Window" button to the Qt MiniBrowser
  15324. https://bugs.webkit.org/show_bug.cgi?id=77281
  15325. Reviewed by Tor Arne Vestbø.
  15326. * MiniBrowser/qt/BrowserWindow.cpp:
  15327. (BrowserWindow::BrowserWindow):
  15328. * MiniBrowser/qt/MiniBrowser.qrc:
  15329. * MiniBrowser/qt/icons/plus.png: Added.
  15330. * MiniBrowser/qt/qml/BrowserWindow.qml:
  15331. 2012-01-30 Csaba Osztrogonác <ossy@webkit.org>
  15332. Unreviewed rolling out r106222.
  15333. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  15334. (SingleTestRunner.__init__):
  15335. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  15336. (Worker.handle_test_list):
  15337. * Scripts/webkitpy/layout_tests/models/test_input.py:
  15338. (TestInput.__init__):
  15339. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15340. (_set_up_derived_options):
  15341. (parse_args):
  15342. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  15343. (MainTest.test_repeat_each):
  15344. * WebKitTestRunner/TestInvocation.cpp:
  15345. (WTR::TestInvocation::setIsPixelTest):
  15346. 2012-01-30 Hans Wennborg <hans@chromium.org>
  15347. Unreviewed, rolling out r106219.
  15348. http://trac.webkit.org/changeset/106219
  15349. https://bugs.webkit.org/show_bug.cgi?id=77083
  15350. This broke Chromium's test_shell.
  15351. * DumpRenderTree/DumpRenderTree.gypi:
  15352. * DumpRenderTree/chromium/LayoutTestController.cpp:
  15353. (LayoutTestController::addMockSpeechInputResult):
  15354. * DumpRenderTree/chromium/LayoutTestController.h:
  15355. (WebKit):
  15356. (LayoutTestController):
  15357. ():
  15358. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Removed.
  15359. * DumpRenderTree/chromium/MockWebSpeechInputController.h: Removed.
  15360. * DumpRenderTree/chromium/TestShell.cpp:
  15361. * DumpRenderTree/chromium/WebViewHost.cpp:
  15362. (WebViewHost::speechInputController):
  15363. * DumpRenderTree/chromium/WebViewHost.h:
  15364. (WebKit):
  15365. (WebViewHost::speechInputControllerMock):
  15366. (WebViewHost):
  15367. ():
  15368. 2012-01-26 Hans Wennborg <hans@chromium.org>
  15369. Speech Input: move MockSpeechInputClient into Chromium DumpRenderTree implementation
  15370. https://bugs.webkit.org/show_bug.cgi?id=77083
  15371. Reviewed by Darin Fisher.
  15372. Add MockWebSpeechInputController which provides a mock implementation
  15373. of the WebSpeechInputController interface, and use that in
  15374. DumpRenderTree.
  15375. * DumpRenderTree/DumpRenderTree.gypi:
  15376. * DumpRenderTree/chromium/LayoutTestController.cpp:
  15377. (LayoutTestController::addMockSpeechInputResult):
  15378. * DumpRenderTree/chromium/LayoutTestController.h:
  15379. ():
  15380. * DumpRenderTree/chromium/MockWebSpeechInputController.cpp: Added.
  15381. (MockWebSpeechInputController::create):
  15382. (MockWebSpeechInputController::addMockRecognitionResult):
  15383. (MockWebSpeechInputController::clearResults):
  15384. (MockWebSpeechInputController::startRecognition):
  15385. (MockWebSpeechInputController::cancelRecognition):
  15386. (MockWebSpeechInputController::stopRecording):
  15387. (MockWebSpeechInputController::MockWebSpeechInputController):
  15388. (MockWebSpeechInputController::speechTaskFired):
  15389. (MockWebSpeechInputController::SpeechTask::SpeechTask):
  15390. (MockWebSpeechInputController::SpeechTask::stop):
  15391. (MockWebSpeechInputController::SpeechTask::runIfValid):
  15392. * DumpRenderTree/chromium/MockWebSpeechInputController.h: Added.
  15393. (WebKit):
  15394. (MockWebSpeechInputController):
  15395. (MockWebSpeechInputController::taskList):
  15396. (SpeechTask):
  15397. * DumpRenderTree/chromium/TestShell.cpp:
  15398. * DumpRenderTree/chromium/WebViewHost.cpp:
  15399. (WebViewHost::speechInputController):
  15400. * DumpRenderTree/chromium/WebViewHost.h:
  15401. (WebKit):
  15402. (WebViewHost::speechInputControllerMock):
  15403. (WebViewHost):
  15404. ():
  15405. 2012-01-29 Sheriff Bot <webkit.review.bot@gmail.com>
  15406. Unreviewed, rolling out r106109.
  15407. http://trac.webkit.org/changeset/106109
  15408. https://bugs.webkit.org/show_bug.cgi?id=77302
  15409. It made tests crash (Requested by Ossy_weekend on #webkit).
  15410. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  15411. (WTR::WrapperWindow::WrapperWindow):
  15412. (WTR::PlatformWebView::PlatformWebView):
  15413. 2012-01-28 Nico Weber <thakis@chromium.org>
  15414. [chromium] Add support for building standalone webkit/chromium checkouts with ninja.
  15415. https://bugs.webkit.org/show_bug.cgi?id=77243
  15416. Reviewed by Adam Barth.
  15417. * Scripts/update-webkit:
  15418. * Scripts/webkitdirs.pm:
  15419. (isChromiumNinja):
  15420. (determineIsChromiumNinja):
  15421. (buildChromiumNinja):
  15422. (buildChromium):
  15423. 2012-01-27 Kentaro Hara <haraken@chromium.org>
  15424. The cpp parser of prepare-ChangeLog treats if(...) {} as a method
  15425. https://bugs.webkit.org/show_bug.cgi?id=77241
  15426. Reviewed by Ryosuke Niwa.
  15427. The cpp parser of prepare-ChangeLog is wrong, and an inner {} block
  15428. in a method in some namespace or class is treated as a method.
  15429. This patch fixes the bug.
  15430. class C {
  15431. void func()
  15432. {
  15433. if (1) { // This should not be treated as a method.
  15434. }
  15435. }
  15436. };
  15437. * Scripts/prepare-ChangeLog:
  15438. (get_function_line_ranges_for_cpp):
  15439. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
  15440. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
  15441. (Class108):
  15442. (Class108::func35):
  15443. 2012-01-27 Enrica Casucci <enrica@apple.com>
  15444. Followup to http://trac.webkit.org/changeset/106171.
  15445. Dan Bernstein pointed out correctly that I should
  15446. have used copy instead of initWithString.
  15447. Reviewed by Dan Bernstein.
  15448. * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  15449. (-[LocalPasteboard initWithName:]):
  15450. 2012-01-27 Enrica Casucci <enrica@apple.com>
  15451. DRT pasteboard object should return the correct pasteboard name.
  15452. https://bugs.webkit.org/show_bug.cgi?id=77260
  15453. Currently the name property always returns nil.
  15454. Adding a memeber variable to store the pasteboard name and return its
  15455. value from the name method instead of returning nil always.
  15456. Reviewed by Dan Bernstein.
  15457. * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
  15458. (+[DumpRenderTreePasteboard _pasteboardWithName:]):
  15459. (-[LocalPasteboard initWithName:]):
  15460. (-[LocalPasteboard name]):
  15461. 2012-01-27 Martin Robinson <mrobinson@igalia.com>
  15462. [GTK] [WK2] Implement the policy client
  15463. https://bugs.webkit.org/show_bug.cgi?id=76343
  15464. Reviewed by Gustavo Noronha Silva.
  15465. * gtk/generate-gtkdoc:
  15466. (get_webkit2_options): Update the list of skipped source files to include all clients.
  15467. 2012-01-27 Ada Chan <adachan@apple.com>
  15468. Add test for WKBundleFrameGetParentFrame().
  15469. https://bugs.webkit.org/show_bug.cgi?id=77161
  15470. Reviewed by Anders Carlsson.
  15471. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add ParentFrame.cpp and ParentFrame_Bundle.cpp.
  15472. * TestWebKitAPI/Tests/WebKit2/ParentFrame.cpp: Added.
  15473. (TestWebKitAPI):
  15474. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Get the check result from the injected bundle.
  15475. (TestWebKitAPI::setInjectedBundleClient):
  15476. (TestWebKitAPI::TEST): Load simple-iframe.html and then wait for the injected bundle to post result.
  15477. Make sure the check is successful.
  15478. * TestWebKitAPI/Tests/WebKit2/ParentFrame_Bundle.cpp: Added.
  15479. (TestWebKitAPI):
  15480. (ParentFrameTest):
  15481. (TestWebKitAPI::ParentFrameTest::ParentFrameTest):
  15482. (TestWebKitAPI::didFinishLoadForFrame): If the frame is a subframe, store it off for checking later.
  15483. If the frame is the main frame, check whether it's indeed the subframe's parent frame and post the result
  15484. to the test controller.
  15485. (TestWebKitAPI::ParentFrameTest::didCreatePage): Set the page loader client on this page.
  15486. 2012-01-27 Zan Dobersek <zandobersek@gmail.com>
  15487. [Gtk] DumpRenderTree lacks --no-timeout command line option
  15488. https://bugs.webkit.org/show_bug.cgi?id=77196
  15489. Reviewed by Martin Robinson.
  15490. Add the --no-timeout command line option and reorganize
  15491. watchdog code to make running DumpRenderTree without
  15492. timeout possible.
  15493. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  15494. (setWaitToDumpWatchdog):
  15495. (shouldSetWaitToDumpWatchdog):
  15496. (initializeGlobalsFromCommandLineOptions):
  15497. * DumpRenderTree/gtk/DumpRenderTreeGtk.h:
  15498. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  15499. (waitToDumpWatchdogFired):
  15500. (LayoutTestController::setWaitToDump):
  15501. 2012-01-27 Andras Becsi <andras.becsi@nokia.com>
  15502. [Qt][WK2] Enable the automatic touch->mouse mocking on the new Qt5 hashes
  15503. https://bugs.webkit.org/show_bug.cgi?id=77122
  15504. Reviewed by Kenneth Rohde Christiansen.
  15505. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  15506. (MiniBrowserApplication::MiniBrowserApplication):
  15507. 2012-01-27 Zeno Albisser <zeno@webkit.org>
  15508. [Qt][Mac] Build fails after adding ICU support (r105997).
  15509. https://bugs.webkit.org/show_bug.cgi?id=77118
  15510. Define WTF_USE_ICU_UNICODE if we are on mac.
  15511. Reviewed by Tor Arne Vestbø.
  15512. * qmake/mkspecs/features/features.prf:
  15513. 2012-01-27 Roland Takacs <takacs.roland@stud.u-szeged.hu>
  15514. Update committers.py with new contributors.
  15515. https://bugs.webkit.org/show_bug.cgi?id=77207
  15516. I added six new contributors into committers.py:
  15517. - Adam Kallai
  15518. - Balazs Ankes
  15519. - Janos Badics
  15520. - Nandor Huszka
  15521. - Roland Takacs
  15522. - Szilard Ledan-Muntean
  15523. * Scripts/webkitpy/common/config/committers.py:
  15524. 2012-01-27 Vsevolod Vlasov <vsevik@chromium.org>
  15525. Add Vsevolod Vlasov to reviewers list.
  15526. Reviewed by Pavel Feldman.
  15527. * Scripts/webkitpy/common/config/committers.py:
  15528. 2012-01-26 No'am Rosenthal <noam.rosenthal@nokia.com> and Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  15529. [Qt] WKTR: Use a software rendering pipiline when running tests.
  15530. https://bugs.webkit.org/show_bug.cgi?id=76708
  15531. Reviewed by Kenneth Rohde Christiansen.
  15532. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  15533. (WTR::WrapperWindow::WrapperWindow):
  15534. (WTR::PlatformWebView::PlatformWebView): Use software rendering of layers since the wrapping QQuickView isn't shown.
  15535. 2012-01-26 Kevin Ollivier <kevino@theolliviers.com>
  15536. [wx] Unreviewed. Build fix, add WebCore/testing/js
  15537. to the list of source directories we build.
  15538. * waf/build/settings.py:
  15539. 2012-01-26 Filip Pizlo <fpizlo@apple.com>
  15540. Tools/Scripts/commit-log-editor is broken due to $_ getting clobbered
  15541. https://bugs.webkit.org/show_bug.cgi?id=77177
  15542. Reviewed by Jon Honeycutt.
  15543. * Scripts/commit-log-editor:
  15544. 2012-01-26 Ojan Vafai <ojan@chromium.org>
  15545. Decrease sleep time when killing server_process on Mac.
  15546. https://bugs.webkit.org/show_bug.cgi?id=77169
  15547. Reviewed by Eric Seidel.
  15548. This shaves another ~70ms off single test runtime.
  15549. * Scripts/webkitpy/layout_tests/port/server_process.py:
  15550. (ServerProcess.stop):
  15551. 2012-01-26 Ojan Vafai <ojan@chromium.org>
  15552. Remove builder name so http://trac.webkit.org/changeset/106035 actually works.
  15553. https://bugs.webkit.org/show_bug.cgi?id=77164
  15554. Reviewed by Dirk Pranke.
  15555. http://trac.webkit.org/changeset/106035 depends on builder_name being
  15556. falsey by default. There's other code that requires it to be iterable
  15557. by default. So, make it be the empty string.
  15558. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15559. (parse_args):
  15560. 2012-01-26 Ryosuke Niwa <rniwa@webkit.org>
  15561. run-perf-test should include relative file paths in test names
  15562. https://bugs.webkit.org/show_bug.cgi?id=77144
  15563. Reviewed by Adam Barth.
  15564. Include all directory names in the test name separated by "/".
  15565. e.g. Bindings/event-target-wrapper.html translates to Bindings/event-target-wrapper
  15566. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  15567. (PerfTestsRunner):
  15568. (PerfTestsRunner._process_parser_test_result):
  15569. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  15570. (test_run_test_set_with_json_output):
  15571. (test_run_test_set_with_json_source):
  15572. 2012-01-26 Dirk Pranke <dpranke@chromium.org>
  15573. webkitpy: re-land cleanup of test scaffolding
  15574. https://bugs.webkit.org/show_bug.cgi?id=77153
  15575. Reviewed by Eric Seidel.
  15576. This is an attempt to reland the change in bug 76973 /
  15577. r105935. My earlier attempt to manipulate PYTHONPATH
  15578. seems to only work some of the time, for reasons that
  15579. elude me. Directly adding Tools/Scripts to sys.path from
  15580. inside the test script appears to work (more?) reliably.
  15581. Also, it seemed like the files didn't actually get deleted
  15582. the last time; I don't know why.
  15583. * Scripts/test-webkitpy:
  15584. * Scripts/webkitpy/common/system/executive_unittest.py:
  15585. (command_line):
  15586. (ExecutiveTest):
  15587. (ExecutiveTest.test_run_command_args_type):
  15588. (ExecutiveTest.test_run_command_with_unicode):
  15589. (ExecutiveTest.test_running_pids):
  15590. (main):
  15591. * Scripts/webkitpy/common/system/fileutils.py: Removed.
  15592. * Scripts/webkitpy/test/cat.py: Removed.
  15593. * Scripts/webkitpy/test/cat_unittest.py: Removed.
  15594. * Scripts/webkitpy/test/echo.py: Removed.
  15595. * Scripts/webkitpy/test/echo_unittest.py: Removed.
  15596. 2012-01-26 Ojan Vafai <ojan@chromium.org>
  15597. run-webkit-tests calls "nm" when it doesn't need to
  15598. https://bugs.webkit.org/show_bug.cgi?id=77143
  15599. Reviewed by Dirk Pranke.
  15600. If we are not running any test that can be skipped by checking
  15601. the DRT feature list or looking at the list of symbols, avoid calling
  15602. out to DRT or calling "nm".
  15603. This saves ~700ms on my Mac Pro. In cases where you still have to call out
  15604. to "nm" it's only a couple ms slower.
  15605. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  15606. (TestExpectations.__init__):
  15607. * Scripts/webkitpy/layout_tests/port/base.py:
  15608. (Port.skipped_tests):
  15609. * Scripts/webkitpy/layout_tests/port/webkit.py:
  15610. (WebKitPort._should_check_for_missing_features):
  15611. (WebKitPort):
  15612. (WebKitPort._should_check_for_missing_symbols):
  15613. (WebKitPort._skipped_tests_for_unsupported_features):
  15614. (WebKitPort.skipped_layout_tests):
  15615. (WebKitPort.skipped_tests):
  15616. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  15617. (WebKitPortTest.test_skipped_directories_for_symbols):
  15618. (test_skipped_directories_for_features):
  15619. (test_skipped_directories_for_features_no_matching_tests_in_test_list):
  15620. (test_skipped_layout_tests):
  15621. 2012-01-26 Benjamin Poulain <bpoulain@apple.com>
  15622. Support a suffix on ChangeLog filenames based on a configuration file
  15623. https://bugs.webkit.org/show_bug.cgi?id=76956
  15624. Reviewed by Kentaro Hara.
  15625. Modify the tools used to generate, edit and resolve ChangeLogs to support
  15626. the addition of a suffix to the ChangeLog filename.
  15627. This patch makes it easier to support alternate ChangeLog files in branches.
  15628. * Scripts/VCSUtils.pm:
  15629. (changeLogSuffix):
  15630. (changeLogFileName):
  15631. * Scripts/commit-log-editor:
  15632. * Scripts/prepare-ChangeLog:
  15633. (getLatestChangeLogs):
  15634. (generateNewChangeLogs):
  15635. (generateFileList):
  15636. * Scripts/resolve-ChangeLogs:
  15637. (findChangeLog):
  15638. 2012-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
  15639. Unreviewed, rolling out r106038.
  15640. http://trac.webkit.org/changeset/106038
  15641. https://bugs.webkit.org/show_bug.cgi?id=77142
  15642. Caused a bunch of skipped tests to not be skipped. (Requested
  15643. by ojan on #webkit).
  15644. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  15645. (TestExpectationParser):
  15646. (TestExpectationParser.parse):
  15647. (TestExpectationParser._parse_line):
  15648. (TestExpectationParser._collect_matching_tests):
  15649. (TestExpectations.__init__):
  15650. (TestExpectations._add_skipped_tests):
  15651. * Scripts/webkitpy/layout_tests/port/base.py:
  15652. (Port.test_dirs):
  15653. (Port.normalize_test_name):
  15654. (Port.update_baseline):
  15655. (Port.layout_tests_dir):
  15656. (Port.relative_perf_test_filename):
  15657. (Port.abspath_for_test):
  15658. 2012-01-25 Ojan Vafai <ojan@chromium.org>
  15659. Parsing test_expecations.txt + Skipped lists takes too long
  15660. https://bugs.webkit.org/show_bug.cgi?id=77059
  15661. Reviewed by Dirk Pranke.
  15662. This saves ~100ms on the Apple Mac port.
  15663. -memoize a bunch of path methods.
  15664. -Avoid doing multiple disk accesses per line.
  15665. -Parse the skipped list directly instead of turning it into a test_expecations.txt
  15666. formatting string and parsing that.
  15667. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  15668. (TestExpectationParser):
  15669. (TestExpectationParser.parse_skipped_tests):
  15670. (TestExpectationParser._parse_line):
  15671. (TestExpectationParser._collect_matching_tests):
  15672. (TestExpectations.__init__):
  15673. (TestExpectations._add_skipped_tests):
  15674. * Scripts/webkitpy/layout_tests/port/base.py:
  15675. (Port):
  15676. (Port.test_isfile):
  15677. (Port.normalize_test_name):
  15678. (Port.layout_tests_dir):
  15679. (Port.abspath_for_test):
  15680. 2012-01-25 Ojan Vafai <ojan@chromium.org>
  15681. Only store the SVN revision in the summarized results if we're on a builder
  15682. https://bugs.webkit.org/show_bug.cgi?id=76976
  15683. Reviewed by Dirk Pranke.
  15684. This shaves another ~130ms off the single test run-webkit-tests runtime.
  15685. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  15686. (summarize_results):
  15687. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  15688. (ResultSummaryTest.get_result):
  15689. (ResultSummaryTest):
  15690. (ResultSummaryTest.get_result_summary):
  15691. (ResultSummaryTest.get_unexpected_results):
  15692. (ResultSummaryTest.test_no_svn_revision):
  15693. (ResultSummaryTest.test_svn_revision):
  15694. * Scripts/webkitpy/layout_tests/port/base.py:
  15695. (Port.use_trac_links_in_results_html):
  15696. 2012-01-26 Luciano Wolf <luciano.wolf@openbossa.org>
  15697. [Qt][WK2] fast/loader tests failed after r94178
  15698. https://bugs.webkit.org/show_bug.cgi?id=67388
  15699. Reviewed by Simon Hausmann.
  15700. Applying the same fix used for Qt-WebKit1 from bug #67254 -
  15701. [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
  15702. https://bugs.webkit.org/show_bug.cgi?id=67254
  15703. Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
  15704. derived from the running location of DumpRenderTree binary.
  15705. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  15706. (WTR::LayoutTestController::pathToLocalResource):
  15707. 2012-01-26 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  15708. Implement overridePreference for boolean preferences in WebKitTestRunner
  15709. https://bugs.webkit.org/show_bug.cgi?id=77033
  15710. Reviewed by Alexey Proskuryakov.
  15711. For now overridePreference supports boolean values.
  15712. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  15713. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  15714. (WTR::LayoutTestController::setXSSAuditorEnabled):
  15715. (WTR::LayoutTestController::overridePreference):
  15716. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  15717. * WebKitTestRunner/TestController.cpp:
  15718. (WTR::TestController::resetStateToConsistentValues): Reset the overrides
  15719. explicitly and properly disable the use of PageCache when resetting the
  15720. state. Tests that use PageCache can now enable it via overridePreference.
  15721. 2012-01-26 Alexander Færøy <alexander.faeroy@nokia.com>
  15722. [Qt] Support opening multiple URL's from the command line in the Qt MiniBrowser
  15723. https://bugs.webkit.org/show_bug.cgi?id=77100
  15724. Reviewed by Simon Hausmann.
  15725. This patch makes the MiniBrowser read multiple URL's from the command
  15726. line such that there will be one browser window opened for each URL.
  15727. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  15728. (MiniBrowserApplication::handleUserOptions):
  15729. 2012-01-26 Alexander Færøy <alexander.faeroy@nokia.com>
  15730. [Qt] The Qt MiniBrowser crashes when given multiple URL's
  15731. https://bugs.webkit.org/show_bug.cgi?id=77009
  15732. Reviewed by Simon Hausmann.
  15733. This patch fixes a crash in BrowserWindow::newWindow() where a
  15734. BrowserWindow-object is constructed with a 0 pointer as the
  15735. WindowOptions parameter which leads to a crash.
  15736. * MiniBrowser/qt/BrowserWindow.cpp:
  15737. (BrowserWindow::BrowserWindow):
  15738. (BrowserWindow::newWindow):
  15739. * MiniBrowser/qt/BrowserWindow.h:
  15740. 2012-01-26 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
  15741. [Qt] Use ICU if available
  15742. https://bugs.webkit.org/show_bug.cgi?id=76821
  15743. Reviewed by Simon Hausmann.
  15744. Adding unicode defines for a Qt 5 based build.
  15745. * qmake/mkspecs/features/features.prf:
  15746. 2012-01-26 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
  15747. [WK2] WebKitTestRunner needs layoutTestController.setGeolocationPermission
  15748. https://bugs.webkit.org/show_bug.cgi?id=42545
  15749. Reviewed by Zoltan Herczeg.
  15750. Implement the setGeolocationPermission method.
  15751. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  15752. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  15753. (WTR::LayoutTestController::setGeolocationPermission):
  15754. (WTR):
  15755. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  15756. (LayoutTestController):
  15757. 2012-01-26 Balazs Kelemen <kbalazs@webkit.org>
  15758. [NRWT] Support --ignore-metrics
  15759. https://bugs.webkit.org/show_bug.cgi?id=76278
  15760. Reviewed by Tony Chang.
  15761. Port the feature from ORWT.
  15762. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  15763. (SingleTestRunner._run_compare_test):
  15764. * Scripts/webkitpy/layout_tests/port/driver.py:
  15765. (DriverOutput):
  15766. (DriverOutput.strip_metrics):
  15767. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  15768. (DriverOutputTest):
  15769. (DriverOutputTest.test_strip_metrics):
  15770. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15771. (_set_up_derived_options):
  15772. (parse_args):
  15773. 2012-01-26 Sheriff Bot <webkit.review.bot@gmail.com>
  15774. Unreviewed, rolling out r105935 and r105954.
  15775. http://trac.webkit.org/changeset/105935
  15776. http://trac.webkit.org/changeset/105954
  15777. https://bugs.webkit.org/show_bug.cgi?id=77080
  15778. test-webkitpy is still broken (Requested by abarth on
  15779. #webkit).
  15780. * Scripts/test-webkitpy:
  15781. * Scripts/webkitpy/common/system/executive_unittest.py:
  15782. (never_ending_command):
  15783. (ExecutiveTest.test_run_command_args_type):
  15784. (ExecutiveTest.test_run_command_with_unicode):
  15785. (ExecutiveTest.test_running_pids):
  15786. * Scripts/webkitpy/common/system/fileutils.py:
  15787. (make_stdout_binary):
  15788. * Scripts/webkitpy/test/cat.py:
  15789. (command_arguments):
  15790. (main):
  15791. * Scripts/webkitpy/test/cat_unittest.py:
  15792. (CatTest):
  15793. (CatTest.assert_cat):
  15794. (CatTest.test_basic):
  15795. (CatTest.test_no_newline):
  15796. (CatTest.test_unicode):
  15797. (CatTest.test_as_command):
  15798. * Scripts/webkitpy/test/echo.py:
  15799. (command_arguments):
  15800. (main):
  15801. * Scripts/webkitpy/test/echo_unittest.py:
  15802. (EchoTest):
  15803. (EchoTest.test_basic):
  15804. (EchoTest.test_no_newline):
  15805. (EchoTest.test_unicode):
  15806. (EchoTest.test_argument_order):
  15807. (EchoTest.test_empty_arguments):
  15808. (EchoTest.test_no_arguments):
  15809. (EchoTest.test_as_command):
  15810. 2012-01-26 Gabor Rapcsanyi <rgabor@webkit.org>
  15811. [GTK] Detect cross-compilation in webkitdirs.pm to not generate gtkdoc
  15812. https://bugs.webkit.org/show_bug.cgi?id=76138
  15813. Reviewed by Martin Robinson.
  15814. * Scripts/webkitdirs.pm:
  15815. (isCrossCompilation):
  15816. (buildAutotoolsProject):
  15817. 2012-01-25 Adam Barth <abarth@webkit.org>
  15818. Kentaro is a reviewer now. Yay!
  15819. * Scripts/webkitpy/common/config/committers.py:
  15820. 2012-01-25 Dirk Pranke <dpranke@chromium.org>
  15821. nrwt: running w/ no arguments fails
  15822. https://bugs.webkit.org/show_bug.cgi?id=77064
  15823. Unreviewed, build fix.
  15824. This change fixes a regression introduced in r105944
  15825. where running without --platform <foo> or one of the other
  15826. platform switches would cause a null deref :(.
  15827. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15828. (main):
  15829. 2012-01-25 Eric Seidel <eric@webkit.org>
  15830. Automatically CC someone from Apple on any changes to Obj-C public API
  15831. https://bugs.webkit.org/show_bug.cgi?id=77053
  15832. Reviewed by Timothy Hatcher.
  15833. This has long been de-facto practice, seems now that we have
  15834. fancy watchlist support, we should just make the tools
  15835. do this automatically.
  15836. * Scripts/webkitpy/common/config/watchlist:
  15837. 2012-01-25 Antoine Labour <piman@chromium.org>
  15838. Updating status in committers.py.
  15839. Unreviewed.
  15840. * Scripts/webkitpy/common/config/committers.py:
  15841. 2012-01-25 Dirk Pranke <dpranke@chromium.org>
  15842. test-webkitpy: executive_unittest fails if PYTHONPATH isn't set
  15843. https://bugs.webkit.org/show_bug.cgi?id=77058
  15844. Reviewed by Eric Seidel.
  15845. r105935 broke executive_unittest by changing which script we
  15846. were running and not ensuring that the PYTHONPATH was set up
  15847. properly.
  15848. This change also fixes a regression introduced recently where
  15849. test-webkitpy wasn't figuring out the path to Tools/Scripts
  15850. right, either (so running ./test-webkitpy would fail).
  15851. * Scripts/test-webkitpy:
  15852. * Scripts/webkitpy/common/system/executive_unittest.py:
  15853. (script_dir):
  15854. (ExecutiveTest.setUp):
  15855. (ExecutiveTest):
  15856. (ExecutiveTest.tearDown):
  15857. 2012-01-25 Adam Barth <abarth@webkit.org>
  15858. Disable tests on the mac-ews while we sort out hte stability issues.
  15859. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  15860. (MacEWS):
  15861. 2012-01-23 Dirk Pranke <dpranke@chromium.org>
  15862. investigate use of 'mac' and 'win' as fully-specified port names for the apple ports
  15863. https://bugs.webkit.org/show_bug.cgi?id=76475
  15864. Reviewed by Eric Seidel.
  15865. This patch cleans up the internal usage of port names for the
  15866. Apple mac and Apple win ports so that 'mac' and 'win are never
  15867. considered "fully specified" port names: they are still legal
  15868. input to the PortFactory.get() routine, but only if run on the given
  15869. platform (i.e. trying to PortFactory.get('mac') on windows or
  15870. linux will return an error, since we don't know which version of
  15871. the port is desired.
  15872. This also cleans up handling of the webkit2 variants, so that
  15873. the full port names consistently follow the
  15874. <operating_system>-<version>[-<wk2>] convention.
  15875. Lastly this patch adds some assertions and removes some
  15876. try/catch logic to catch more programming and usage errors;
  15877. previously mac-tiger might've been allowed -- and it would've
  15878. translated into using just the baselines in platform/mac -- but
  15879. now it should fail.
  15880. * Scripts/webkitpy/layout_tests/port/apple.py:
  15881. (ApplePort.determine_full_port_name):
  15882. (ApplePort.__init__):
  15883. (ApplePort):
  15884. (ApplePort._port_name_with_version):
  15885. * Scripts/webkitpy/layout_tests/port/builders.py:
  15886. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  15887. (FactoryTest.test_mac):
  15888. (FactoryTest.test_win):
  15889. * Scripts/webkitpy/layout_tests/port/mac.py:
  15890. (MacPort.baseline_search_path):
  15891. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  15892. (MacTest.test_versions):
  15893. * Scripts/webkitpy/layout_tests/port/win.py:
  15894. (WinPort.baseline_search_path):
  15895. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  15896. (WinTest.test_versions):
  15897. 2012-01-25 Dirk Pranke <dpranke@chromium.org>
  15898. webkitpy: print nicer errors while linting expectations files, remove redundant tests
  15899. https://bugs.webkit.org/show_bug.cgi?id=76955
  15900. Reviewed by Adam Barth.
  15901. This change cleans up the errors that are printed so that the
  15902. are more "quickfix" compatible (path:lineno).
  15903. Also, there were a bunch of redundant tests between
  15904. layout_tests.models.test_expectations_unittest and
  15905. style.checkers.test_expectations_unittest. The latter should
  15906. just expect the former to do most of the testing.
  15907. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  15908. (TestExpectationParser._parse_modifiers):
  15909. (TestExpectations._report_errors):
  15910. (TestExpectations._add_skipped_tests):
  15911. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  15912. (test_parse_error_nonfatal):
  15913. (SemanticTests.test_bad_bugid):
  15914. * Scripts/webkitpy/style/checkers/test_expectations.py:
  15915. (TestExpectationsChecker.__init__):
  15916. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  15917. (TestExpectationsTestCase.assert_lines_lint):
  15918. (TestExpectationsTestCase.test_valid_expectations):
  15919. (TestExpectationsTestCase.test_invalid_expectations):
  15920. (TestExpectationsTestCase.test_tab):
  15921. 2012-01-25 Eric Seidel <eric@webkit.org>
  15922. webkit-patch apply-* should always continue after failures
  15923. https://bugs.webkit.org/show_bug.cgi?id=77057
  15924. Reviewed by Adam Barth.
  15925. As far as I can tell there is only one potential drawback to always
  15926. forcing: that if you're somehow in the wrong directory it will create new
  15927. directories for new files. Since webkit-patch always cd's to the root
  15928. it seems that's not a drawback. The drawback of not using --force for
  15929. svn-apply, is that it will stop after the first failure, which is rarely
  15930. (if ever) the desired behavior. This just removes the force option
  15931. (which was strangely hidden behind --non-interactive). This should
  15932. make for a better user experiance.
  15933. * Scripts/webkitpy/common/checkout/checkout.py:
  15934. (Checkout.apply_patch):
  15935. * Scripts/webkitpy/common/checkout/checkout_mock.py:
  15936. (MockCheckout.apply_patch):
  15937. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  15938. (CheckoutTest.test_chromium_deps):
  15939. (CheckoutTest):
  15940. (CheckoutTest.test_apply_patch):
  15941. * Scripts/webkitpy/tool/commands/download_unittest.py:
  15942. (DownloadCommandsTest._default_options):
  15943. * Scripts/webkitpy/tool/steps/applypatch.py:
  15944. (ApplyPatch.options):
  15945. (ApplyPatch.run):
  15946. * Scripts/webkitpy/tool/steps/options.py:
  15947. (Options):
  15948. 2012-01-25 Dirk Pranke <dpranke@chromium.org>
  15949. nrwt: should be able to run --platform test interactively
  15950. https://bugs.webkit.org/show_bug.cgi?id=76959
  15951. Reviewed by Adam Barth.
  15952. As part of refactoring the Port interfaces, in r103254 I made
  15953. passing a Host object to the Port mandatory; previously TestPort
  15954. objects would create their own (mock) hosts. However,
  15955. new-run-webkit-tests always passed a real Host, not a MockHost,
  15956. and so you couldn't run new-run-webkit-tests --platform test
  15957. interactively to debug test failures.
  15958. This change fixes that by creating a MockHost instead of a real
  15959. host if you say --platform test*.
  15960. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15961. (main):
  15962. 2012-01-25 Dirk Pranke <dpranke@chromium.org>
  15963. run-webkit-tests --lint-test-files should lint all the ports by default
  15964. https://bugs.webkit.org/show_bug.cgi?id=76749
  15965. Reviewed by Ojan Vafai.
  15966. Currently run-webkit-tests --lint-test-files will only lint the
  15967. test_expectations for the single port determined by the command
  15968. line options. This is not obvious and can produce unintended results
  15969. if you want to lint the chromium port (probably the normal case
  15970. for using --lint-test-files) but don't specify a port name or
  15971. --chromium.
  15972. I think we should probably lint *all* of the ports if no port
  15973. name is supplied. This change implements that, and also moves
  15974. the linting logic out of the Manager class, since this really
  15975. has nothing to do with Managers. It has little to do with
  15976. run-webkit-tests, but splitting it into a different script would
  15977. introduce compatibility issues. It might make sense to do that
  15978. anyway, in a separate patch and combining that with cleaning up
  15979. the style checker to share more code.
  15980. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  15981. (Manager._strip_test_dir_prefix):
  15982. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  15983. (lint):
  15984. (run):
  15985. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  15986. (LintTest.test_all_configurations): added.
  15987. (LintTest.test_lint_test_files): added.
  15988. (LintTest.test_lint_test_files__errors): added.
  15989. (MainTest.test_lint_test_files): removed.
  15990. (MainTest.test_lint_test_files__errors): removed.
  15991. 2012-01-25 Dirk Pranke <dpranke@chromium.org>
  15992. webkitpy: clean up a bunch of test scaffolding
  15993. https://bugs.webkit.org/show_bug.cgi?id=76973
  15994. Reviewed by Eric Seidel.
  15995. There were several helper modules in the webkitpy.test package
  15996. that appear to only be used by executive_unittest.py. I am
  15997. rolling them all into that file to make that clearer.
  15998. * Scripts/webkitpy/common/system/executive_unittest.py:
  15999. (ExecutiveTest.test_run_command_args_type):
  16000. (ExecutiveTest.test_run_command_with_unicode):
  16001. (ExecutiveTest.test_running_pids):
  16002. (command_line):
  16003. (main):
  16004. * Scripts/webkitpy/common/system/fileutils.py: Removed.
  16005. * Scripts/webkitpy/test/cat.py: Removed.
  16006. * Scripts/webkitpy/test/cat_unittest.py: Removed.
  16007. * Scripts/webkitpy/test/echo.py: Removed.
  16008. * Scripts/webkitpy/test/echo_unittest.py: Removed.
  16009. 2012-01-25 Dirk Pranke <dpranke@chromium.org>
  16010. webkitpy: clean up a bunch of test scaffolding
  16011. https://bugs.webkit.org/show_bug.cgi?id=76973
  16012. Reviewed by Eric Seidel.
  16013. There were several helper modules in the webkitpy.test package
  16014. that appear to only be used by executive_unittest.py. I am
  16015. rolling them all into that file to make that clearer.
  16016. * Scripts/webkitpy/common/system/executive_unittest.py:
  16017. (ExecutiveTest.test_run_command_args_type):
  16018. (ExecutiveTest.test_run_command_with_unicode):
  16019. (ExecutiveTest.test_running_pids):
  16020. (command_line):
  16021. (main):
  16022. * Scripts/webkitpy/common/system/fileutils.py: Removed.
  16023. * Scripts/webkitpy/test/cat.py: Removed.
  16024. * Scripts/webkitpy/test/cat_unittest.py: Removed.
  16025. * Scripts/webkitpy/test/echo.py: Removed.
  16026. * Scripts/webkitpy/test/echo_unittest.py: Removed.
  16027. 2012-01-25 Eric Seidel <eric@webkit.org>
  16028. Remove Python 2.5 support from WebKit
  16029. https://bugs.webkit.org/show_bug.cgi?id=71593
  16030. Reviewed by Adam Barth.
  16031. Just removing support from this one core file.
  16032. I'll commit the rest of the (large) change once we've
  16033. gone 24 hours and seen that no bots have exploded.
  16034. We can roll out this one change if we break bots
  16035. and then roll in the rest once those bots are fixed.
  16036. * Scripts/webkitpy/common/system/executive.py:
  16037. (Executive.cpu_count):
  16038. 2012-01-25 Hajime Morita <morrita@google.com>
  16039. ENABLE_SHADOW_DOM should be available via build-webkit --shadow-dom
  16040. https://bugs.webkit.org/show_bug.cgi?id=76863
  16041. Reviewed by Dimitri Glazkov.
  16042. Added a feature flag.
  16043. * Scripts/build-webkit:
  16044. * qmake/mkspecs/features/features.prf:
  16045. 2012-01-25 Martin Robinson <mrobinson@igalia.com>
  16046. [WK2] Navigation events not triggered by a mouse event claim to be triggered by the left mouse button during policy decisions
  16047. https://bugs.webkit.org/show_bug.cgi?id=76344
  16048. Reviewed by Sam Weinig.
  16049. Add a test verifying that the mouse button during policy decisions for
  16050. events not triggered by mouse events is NoButton.
  16051. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  16052. (TestWebKitAPI::decidePolicyForNavigationAction): Added test.
  16053. (TestWebKitAPI::decidePolicyForNewWindowAction): Added test.
  16054. 2012-01-25 Ryosuke Niwa <rniwa@webkit.org>
  16055. run-perf-tests should timeout sooner
  16056. https://bugs.webkit.org/show_bug.cgi?id=77026
  16057. Reviewed by Adam Barth.
  16058. Bump off the timeout from 10 minutes to 4 minutes.
  16059. Also use float instead of str in test result values to compress the size of json files bots upload.
  16060. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  16061. (PerfTestsRunner._parse_args):
  16062. (PerfTestsRunner._process_chromium_style_test_result):
  16063. (PerfTestsRunner._process_parser_test_result):
  16064. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  16065. (test_run_test_set_for_parser_tests):
  16066. (test_run_test_set_with_json_output):
  16067. (test_run_test_set_with_json_source):
  16068. 2012-01-25 Enrica Casucci <enrica@apple.com>
  16069. WebView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
  16070. https://bugs.webkit.org/show_bug.cgi?id=76951
  16071. <rdar://problem/9325158>
  16072. Reviewed by Alexey Proskuryakov.
  16073. * TestWebKitAPI/Tests/mac/InspectorBar.mm: Modified to reflect the changes to WebView
  16074. and WebHTMLView.
  16075. (TestWebKitAPI::TEST):
  16076. 2012-01-23 MORITA Hajime <morrita@google.com>
  16077. [Refactoring][Internals] Should have InternalSettings
  16078. https://bugs.webkit.org/show_bug.cgi?id=76424
  16079. Reviewed by Kent Tamura.
  16080. * GNUmakefile.am: Added so new files.
  16081. 2012-01-25 Takashi Toyoshima <toyoshim@chromium.org>
  16082. webkitpy: new-run-webkit-websocket is broken
  16083. https://bugs.webkit.org/show_bug.cgi?id=76999
  16084. Reviewed by Dirk Pranke.
  16085. r105674 broke new-run-webkit-websocket, since options.chromium
  16086. doesn't exist any more. new-run-webkit-httpd was also broken
  16087. and already fixed at r105835.
  16088. * Scripts/new-run-webkit-websocketserver:
  16089. (main):
  16090. 2012-01-25 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
  16091. [WK2] WebKitTestRunner needs layoutTestController.setPopupBlockingEnabled
  16092. https://bugs.webkit.org/show_bug.cgi?id=63458
  16093. Reviewed by Adam Roben.
  16094. Implement the setPopupBlockingEnabled method.
  16095. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  16096. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  16097. (WTR::LayoutTestController::setPopupBlockingEnabled):
  16098. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  16099. 2012-01-24 Balazs Kelemen <kbalazs@webkit.org>
  16100. [Qt] Cleanup testfonts handling
  16101. https://bugs.webkit.org/show_bug.cgi?id=76068
  16102. Reviewed by Simon Hausmann.
  16103. Factor test font initialization into it's own file so test
  16104. font users can share the implementation by adding the file
  16105. to their build.
  16106. Use fonts.conf from the test font directory to not require the
  16107. current directory to be the WebKit root.
  16108. Fix the -use-test-fonts option of QtTestBrowser by initializing
  16109. the fonts earlier, before it is too late (namely before calling
  16110. show on the main window).
  16111. * DumpRenderTree/qt/DumpRenderTree.pro:
  16112. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  16113. (WebCore::DumpRenderTree::open):
  16114. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  16115. * DumpRenderTree/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
  16116. (WebKit::initializeTestFonts):
  16117. * DumpRenderTree/qt/QtInitializeTestFonts.h: Added.
  16118. * DumpRenderTree/qt/fonts.conf: Removed. No need for this since
  16119. we will use the one from the test fonts directory.
  16120. * DumpRenderTree/qt/main.cpp:
  16121. (main): Fix the ifdefs to make it clear that the code to
  16122. set up the Dpi has not been ported to Qt5 yet.
  16123. * QtTestBrowser/QtTestBrowser.pro:
  16124. * QtTestBrowser/launcherwindow.h:
  16125. (WindowOptions::WindowOptions):
  16126. * QtTestBrowser/main.cpp:
  16127. (launcherMain):
  16128. (LauncherApplication::handleUserOptions):
  16129. * WebKitTestRunner/InjectedBundle/Target.pri:
  16130. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  16131. (WTR::activateFonts): Remove the code to set up the Dpi
  16132. because it does not work with Qt5.
  16133. 2012-01-25 Simon Hausmann <simon.hausmann@nokia.com>
  16134. [Qt] build-webkit --qt requires a git-svn or SVN checkout.
  16135. Reviewed by Tor Arne Vestø.
  16136. Don't require it by making svnRevisionForDirectory return "unknown"
  16137. instead of bailing out with an error.
  16138. * Scripts/VCSUtils.pm:
  16139. (svnRevisionForDirectory):
  16140. 2012-01-25 Adam Barth <abarth@webkit.org>
  16141. Temporarily disable running the unit tests on the Chromium EWS. These
  16142. tests don't work properly (see
  16143. https://bugs.webkit.org/show_bug.cgi?id=76979) and are currently
  16144. blocking the EWS.
  16145. * Scripts/webkitpy/common/config/ports.py:
  16146. (ChromiumPort):
  16147. 2012-01-25 Adam Barth <abarth@webkit.org>
  16148. Update results.html version of PixelZoomer
  16149. https://bugs.webkit.org/show_bug.cgi?id=76965
  16150. Reviewed by Ojan Vafai.
  16151. Improve readability as suggested by Ojan.
  16152. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
  16153. 2012-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
  16154. [GTK] Page clients don't need to be GObjects anymore in WebKit2 GTK+ API
  16155. https://bugs.webkit.org/show_bug.cgi?id=76899
  16156. Reviewed by Martin Robinson.
  16157. * gtk/generate-gtkdoc:
  16158. (get_webkit2_options): WebKitWebLoaderClient has been renamed to
  16159. WebKitLoaderClient.
  16160. 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
  16161. Build fix. Trigger Chromium Mac Release (Perf) on new commits.
  16162. * BuildSlaveSupport/build.webkit.org-config/config.json:
  16163. 2012-01-23 Ryosuke Niwa <rniwa@webkit.org>
  16164. WebKit needs public performance tests running on public bots
  16165. https://bugs.webkit.org/show_bug.cgi?id=10266
  16166. Reviewed by Adam Barth.
  16167. Completes the initial implementation of WebKit Perf bots. Add a build step for run-perf-test
  16168. and make google-mac-4 run it, and upload the results to webkit-perf.webkit.org.
  16169. * BuildSlaveSupport/build.webkit.org-config/config.json:
  16170. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  16171. (RunAndUploadPerfTests):
  16172. (RunAndUploadPerfTests.start):
  16173. (UploadPerfTestResults):
  16174. (BuildAndPerfTestFactory):
  16175. (BuildAndPerfTestFactory.__init__):
  16176. 2012-01-24 Ojan Vafai <ojan@chromium.org>
  16177. Initializing the browser property of the Bugzilla class takes too long
  16178. https://bugs.webkit.org/show_bug.cgi?id=76960
  16179. Reviewed by Adam Barth.
  16180. Lazily initialize it. This saves ~150ms on a no-op run-webkit-tests call
  16181. on my Mac Pro.
  16182. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  16183. (Bugzilla.__init__):
  16184. (Bugzilla._get_browser):
  16185. (Bugzilla):
  16186. (Bugzilla._set_browser):
  16187. 2012-01-24 Mark Rowe <mrowe@apple.com>
  16188. Death to JavaScriptGlue.
  16189. Rubber-stamped by Geoffrey Garen.
  16190. * BuildSlaveSupport/build-launcher-app:
  16191. (copyNightlyLauncher):
  16192. * Scripts/build-webkit:
  16193. * Scripts/do-file-rename:
  16194. * Scripts/do-webcore-rename:
  16195. * Scripts/webkitpy/common/config/build.py:
  16196. (_should_file_trigger_build):
  16197. * Scripts/webkitpy/common/config/build_unittest.py: Update the test to use another Mac-specific
  16198. path in conjunction with a cross-platform path.
  16199. (ShouldBuildTest):
  16200. 2012-01-24 Kentaro Hara <haraken@chromium.org>
  16201. webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl should test stdout and stderr
  16202. https://bugs.webkit.org/show_bug.cgi?id=75836
  16203. Reviewed by David Kilzer.
  16204. Previously parser_unittests.pl can just test the returned value of
  16205. get_function_line_ranges() in prepare-ChangeLog. This patch fixes
  16206. parser_unittests.pl so that it also tests the stdout and stderr of
  16207. get_function_line_ranges().
  16208. This patch adds css_unittests_warning.css, which contains test cases
  16209. for warning messages of the CSS parser of prepare-ChangeLog.
  16210. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  16211. (captureOutput): Captures the stdout and stderr of a given method.
  16212. (convertAbsolutepathToWebKitPath): Converts absolute paths in a given
  16213. string to relative paths.
  16214. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning-expected.txt: Added.
  16215. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests_warning.css: Added.
  16216. (element1):
  16217. (element2):
  16218. (element3):
  16219. (element4):
  16220. ():
  16221. (element5):
  16222. (element6):
  16223. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
  16224. Just updated the test results, i.e. added stdout and stderr results.
  16225. No essential changes in the test results.
  16226. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Ditto.
  16227. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Ditto.
  16228. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Ditto.
  16229. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Ditto.
  16230. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Ditto.
  16231. 2012-01-24 Dirk Pranke <dpranke@chromium.org>
  16232. webkitpy: new-run-webkit-httpd is broken
  16233. https://bugs.webkit.org/show_bug.cgi?id=76963
  16234. Reviewed by Adam Barth.
  16235. r105674 broke new-run-webkit-httpd, since options.chromium
  16236. doesn't exist any more. We didn't catch this because we don't
  16237. run the integration tests by default anywhere :(.
  16238. * Scripts/new-run-webkit-httpd:
  16239. (run):
  16240. (main):
  16241. 2012-01-24 Adam Barth <abarth@webkit.org>
  16242. garden-o-matic pixel zoomer should let you look at every pixel of the image
  16243. https://bugs.webkit.org/show_bug.cgi?id=76962
  16244. Reviewed by Ojan Vafai.
  16245. Previously, you couldn't get up to the right and bottom pixels.
  16246. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js:
  16247. 2012-01-24 Enrica Casucci <enrica@apple.com>
  16248. WebHTMLView should implement typingAttributes methods to work correctly with the Inspector bar in Mail.
  16249. https://bugs.webkit.org/show_bug.cgi?id=76951
  16250. <rdar://problem/9325158>
  16251. Added test to verify that WebHTMLView supports the typingAttributes method and that it
  16252. works as expected.
  16253. Reviewed by Alexey Proskuryakov.
  16254. * TestWebKitAPI/Tests/mac/InspectorBar.mm:
  16255. (TestWebKitAPI::TEST):
  16256. 2012-01-24 James Robinson <jamesr@chromium.org>
  16257. Put a space between the trac link and ellipsis in sheriffbot rollout message so it linkifies better in some IRC clients
  16258. https://bugs.webkit.org/show_bug.cgi?id=76884
  16259. Reviewed by Adam Barth.
  16260. * Scripts/webkitpy/tool/bot/irc_command.py:
  16261. (Rollout.execute):
  16262. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  16263. (SheriffIRCBotTest.test_rollout):
  16264. (SheriffIRCBotTest.test_revert):
  16265. (SheriffIRCBotTest.test_multi_rollout):
  16266. (SheriffIRCBotTest.test_rollout_with_r_in_svn_revision):
  16267. (SheriffIRCBotTest.test_multi_rollout_with_r_in_svn_revision):
  16268. (SheriffIRCBotTest.test_rollout_invalidate_reason):
  16269. (test_multi_rollout_invalidate_reason):
  16270. 2012-01-24 Kentaro Hara <haraken@chromium.org>
  16271. The cpp parser of prepare-ChangeLog cannot detect a change in classes and namespaces
  16272. https://bugs.webkit.org/show_bug.cgi?id=75531
  16273. Reviewed by David Kilzer.
  16274. Previously, the cpp parser of prepare-ChangeLog could not detect a change
  16275. outside methods. Consider the following cpp file.
  16276. namespace N {
  16277. int a; // this change does not appear on ChangeLog.
  16278. class C {
  16279. int b; // this change does not appear on ChangeLog.
  16280. void f()
  16281. {
  16282. int c; // this change appears on ChangeLog.
  16283. }
  16284. int d; // this change does not appear on ChangeLog.
  16285. };
  16286. int e; // this change does not appear on ChangeLog.
  16287. };
  16288. The previous prepare-ChangeLog outputs just methods in which a change is found:
  16289. (N::C::f):
  16290. This patch fixes prepare-ChangeLog so that it outputs namespaces, classes
  16291. and methods in which a change is found:
  16292. (N):
  16293. (N::C):
  16294. (N::C::f):
  16295. * Scripts/prepare-ChangeLog:
  16296. (get_function_line_ranges_for_cpp): Modified as described above.
  16297. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added test cases.
  16298. (Class104):
  16299. (Class105):
  16300. (Class106):
  16301. (Class106::func32):
  16302. (Class106::func33):
  16303. (NameSpace3):
  16304. (NameSpace4):
  16305. (NameSpace5):
  16306. (NameSpace6):
  16307. (Class107):
  16308. (NameSpace5::NameSpace6::Class107::func34):
  16309. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
  16310. 2012-01-24 Kentaro Hara <haraken@chromium.org>
  16311. prepare-ChangeLog outputs warnings for top-level { ... } blocks
  16312. https://bugs.webkit.org/show_bug.cgi?id=75943
  16313. Reviewed by David Kilzer.
  16314. Currently, prepare-ChangeLog outputs warnings for top-level { ... } blocks,
  16315. because it does not distinguish '}' at the end of a subroutine
  16316. with '}' at the end of a if or for statement.
  16317. foo.pl:
  16318. if (1) {
  16319. }
  16320. for (@v) {
  16321. }
  16322. output:
  16323. nested functions found at top-level at foo.pl:2
  16324. nested functions found at top-level at foo.pl:4
  16325. This patch fixes the bug.
  16326. * Scripts/prepare-ChangeLog:
  16327. (get_function_line_ranges_for_perl):
  16328. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
  16329. Added test cases. No change in the test results.
  16330. 2012-01-24 Dirk Pranke <dpranke@chromium.org>
  16331. r105674 broke check-webkit-style for chromium's test_expectations.
  16332. Unreviewed, build fix.
  16333. We now need to pass in a platform name of 'chromium' if we want
  16334. the chromium port; options.chromium is no longer recognized. I
  16335. will follow this patch up with a separate patch that has a test,
  16336. but this at least fixes the build.
  16337. * Scripts/webkitpy/style/checkers/test_expectations.py:
  16338. (TestExpectationsChecker._determine_port_from_exepectations_path):
  16339. 2012-01-20 Ojan Vafai <ojan@chromium.org>
  16340. check-webkit-style of the chromium test_expectations.txt file takes too long
  16341. https://bugs.webkit.org/show_bug.cgi?id=76745
  16342. Reviewed by Dimitri Glazkov.
  16343. When in lint mode, have TestExpectations test all configurations instead
  16344. of looping over each configuration. This also has the benefit of making
  16345. the error output considerably more concise.
  16346. Also, got rid of the double-printing of errors when linting through check-webkit-style.
  16347. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  16348. (Manager.lint):
  16349. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  16350. (TestExpectations._report_errors):
  16351. (TestExpectations._add_expectations):
  16352. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  16353. (test_parse_error_nonfatal):
  16354. (test_error_on_different_platform):
  16355. * Scripts/webkitpy/style/checkers/test_expectations.py:
  16356. (TestExpectationsChecker.check_test_expectations):
  16357. (TestExpectationsChecker.check):
  16358. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  16359. (TestExpectationsTestCase.test_determine_port_from_exepectations_path):
  16360. (TestExpectationsTestCase.assert_lines_lint):
  16361. 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
  16362. Another build fix attempt after r105543.
  16363. * Scripts/webkitpy/common/net/file_uploader.py:
  16364. (FileUploader.upload_as_multipart_form_data):
  16365. 2012-01-24 Ryosuke Niwa <rniwa@webkit.org>
  16366. Build fix attempt after r105543.
  16367. * Scripts/webkitpy/common/net/file_uploader.py:
  16368. (FileUploader.upload_as_multipart_form_data):
  16369. 2012-01-24 Vincent Scheib <scheib@chromium.org>
  16370. [Chromium] Add Pointer Lock test hooks and mock implementation to DumpRenderTree
  16371. https://bugs.webkit.org/show_bug.cgi?id=76411
  16372. Reviewed by Adam Barth.
  16373. Breaking up https://bugs.webkit.org/show_bug.cgi?id=75762
  16374. into a series of patches, this change adds a trivial
  16375. pointer lock implementation to the Chromium port's DumpRenderTree
  16376. and exposes LayoutTestController hooks to force failure conditions.
  16377. * DumpRenderTree/chromium/LayoutTestController.cpp:
  16378. (LayoutTestController::LayoutTestController):
  16379. (LayoutTestController::didLosePointerLock):
  16380. (LayoutTestController::setPointerLockWillFailAsynchronously):
  16381. (LayoutTestController::setPointerLockWillFailSynchronously):
  16382. * DumpRenderTree/chromium/LayoutTestController.h:
  16383. * DumpRenderTree/chromium/WebViewHost.cpp:
  16384. (WebViewHost::requestPointerLock):
  16385. (WebViewHost::requestPointerUnlock):
  16386. (WebViewHost::isPointerLocked):
  16387. (WebViewHost::didCompletePointerLock):
  16388. (WebViewHost::didNotCompletePointerLock):
  16389. (WebViewHost::didLosePointerLock):
  16390. (WebViewHost::reset):
  16391. * DumpRenderTree/chromium/WebViewHost.h:
  16392. (WebViewHost::setPointerLockWillFailAsynchronously):
  16393. (WebViewHost::setPointerLockWillFailSynchronously):
  16394. 2012-01-24 Mario Sanchez Prada <msanchez@igalia.com>
  16395. Unreviewed, skip WK2 API test timing out on some GTK bots.
  16396. WebKit2APITests/TestDownloads is consistently timing out on the
  16397. 32bit release and 64bit debug bots.
  16398. * Scripts/run-gtk-tests:
  16399. (TestRunner): Skip WebKit2APITests/TestDownloads.
  16400. 2012-01-24 Andras Becsi <andras.becsi@nokia.com>
  16401. [Qt] Fix the build with the newes Qt5 hashes
  16402. https://bugs.webkit.org/show_bug.cgi?id=76657
  16403. Reviewed by Simon Hausmann.
  16404. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  16405. (MiniBrowserApplication::MiniBrowserApplication): Disable the automatic touch->mouse event synthesis
  16406. for now to prevent an infinite loop where Qt always creates mouse events out of our touch mock events.
  16407. 2012-01-24 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16408. [Qt] Distinguish between Cygwin and cmd.exe in the way we set env variables
  16409. We can't use win32-msvc* to decide whether or not to use (set FOO=bar), as
  16410. building with MinGW inside cmd.exe will require the same construct. Instead
  16411. we assume that when the first character in PWD is a '/' we're running under
  16412. Cygwin, and use the normal unix way of setting environment variables.
  16413. Reviewed by Simon Hausmann.
  16414. * qmake/mkspecs/features/default_pre.prf:
  16415. 2012-01-24 Simon Hausmann <simon.hausmann@nokia.com>
  16416. Some qmake build files must include Qt5's "quick" module.
  16417. https://bugs.webkit.org/show_bug.cgi?id=76671
  16418. Unreviewed build fix.
  16419. * MiniBrowser/qt/MiniBrowser.pro:
  16420. * WebKitTestRunner/Target.pri:
  16421. 2012-01-24 Andras Becsi <andras.becsi@nokia.com>
  16422. [Qt] Fix the event timestamps for touch mocking
  16423. Reviewed by Simon Hausmann.
  16424. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  16425. (MiniBrowserApplication::sendTouchEvent): We should not set QEvent::None as the
  16426. timestamp argument in the QWindowSystemInterface::handleTouchEvent call.
  16427. 2012-01-24 Carlos Garcia Campos <cgarcia@igalia.com>
  16428. [GTK] Implement DownloadClient in WebKit2 GTK+ API
  16429. https://bugs.webkit.org/show_bug.cgi?id=72952
  16430. Reviewed by Martin Robinson.
  16431. * gtk/generate-gtkdoc:
  16432. (get_webkit2_options): Ignore WebKitDownloadClient.
  16433. 2012-01-23 Zan Dobersek <zandobersek@gmail.com>
  16434. [GTK] editing/deleting/5408255.html results are incorrect
  16435. https://bugs.webkit.org/show_bug.cgi?id=53644
  16436. Reviewed by Martin Robinson.
  16437. WEBKIT_TOP_LEVEL environment variable is now set directly in either
  16438. WebKitTestRunner or DumpRenderTree through usage of a compilation-time
  16439. macro. This way both tools can be run outside the test harness without
  16440. the need to manually set the environment variable.
  16441. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  16442. (getTopLevelPath):
  16443. * GNUmakefile.am:
  16444. * Scripts/webkitpy/layout_tests/port/gtk.py:
  16445. (GtkPort.setup_environ_for_server):
  16446. * WebKitTestRunner/GNUmakefile.am:
  16447. * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp:
  16448. (WTR::InjectedBundle::platformInitialize):
  16449. 2012-01-23 Dmitry Lomov <dslomov@google.com>
  16450. [Chromium] Implement layoutTestController.workerThreadCount in DRT
  16451. https://bugs.webkit.org/show_bug.cgi?id=74653.
  16452. Reviewed by Darin Fisher.
  16453. * DumpRenderTree/chromium/LayoutTestController.cpp:
  16454. (LayoutTestController::LayoutTestController):
  16455. (LayoutTestController::workerThreadCount):
  16456. * DumpRenderTree/chromium/LayoutTestController.h:
  16457. 2012-01-23 Dirk Pranke <dpranke@chromium.org>
  16458. nrwt: make --chromium work like --qt
  16459. https://bugs.webkit.org/show_bug.cgi?id=76875
  16460. Reviewed by Adam Barth.
  16461. --chromium used to have to be handled differently from --qt
  16462. due to the way the PortFactory was implemented; there's not
  16463. really a good reason for that any more so this patch makes
  16464. things slightly more consistent and eliminates the
  16465. options.chromium flag (--chromium is now truly a synonym for
  16466. --platform chromium).
  16467. * Scripts/webkitpy/layout_tests/port/factory.py:
  16468. (PortFactory._default_port):
  16469. (PortFactory.get):
  16470. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  16471. (FactoryTest.setUp):
  16472. (FactoryTest.test_chromium_mac):
  16473. (FactoryTest.test_chromium_linux):
  16474. (FactoryTest.test_chromium_win):
  16475. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  16476. (parse_args):
  16477. 2012-01-23 Dirk Pranke <dpranke@chromium.org>
  16478. run-webkit-tests needs to propagate --chromium
  16479. https://bugs.webkit.org/show_bug.cgi?id=76870
  16480. Reviewed by Eric Seidel.
  16481. run-webkit-tests removes '--chromium' argument from @ARGV when
  16482. determining which port to run, which means that that doesn't
  16483. propagate to new-run-webkit-tests. That's bad (and is handled
  16484. for the other ports by re-adding the flag, but apparently we're
  16485. just now noticing for Chromium).
  16486. * Scripts/run-webkit-tests:
  16487. 2012-01-23 Brian Weinstein <bweinstein@apple.com>
  16488. More build fixing after r105646.
  16489. * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
  16490. (TestWebKitAPI::TestNode::key):
  16491. 2012-01-23 Gavin Barraclough <barraclough@apple.com>
  16492. Unreviewed build fix - r105646 broke this.
  16493. * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
  16494. (TestWebKitAPI::TestNode::TestNode):
  16495. (TestWebKitAPI::TestNode::key):
  16496. (TestWebKitAPI::RedBlackTreeTest::assertEqual):
  16497. (TestWebKitAPI::RedBlackTreeTest::assertSameValuesForKey):
  16498. (TestWebKitAPI::RedBlackTreeTest::testDriver):
  16499. 2012-01-23 Sheriff Bot <webkit.review.bot@gmail.com>
  16500. Unreviewed, rolling out r105658.
  16501. http://trac.webkit.org/changeset/105658
  16502. https://bugs.webkit.org/show_bug.cgi?id=76883
  16503. We want this eventually, but not right at this moment
  16504. (Requested by abarth on #webkit).
  16505. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  16506. 2012-01-23 Adam Barth <abarth@webkit.org>
  16507. garden-o-matic should support Chromium Mac Lion
  16508. https://bugs.webkit.org/show_bug.cgi?id=76880
  16509. Reviewed by Eric Seidel.
  16510. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  16511. 2012-01-23 Emil A Eklund <eae@chromium.org>
  16512. check-webkit-style whitespace/operators triggers on overloaded division operator
  16513. https://bugs.webkit.org/show_bug.cgi?id=76650
  16514. Reviewed by Darin Adler.
  16515. * Scripts/webkitpy/style/checkers/cpp.py:
  16516. (check_spacing):
  16517. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  16518. (CppStyleTest.test_operator_methods):
  16519. 2012-01-23 Ryosuke Niwa <rniwa@webkit.org>
  16520. run-perf-tests should report server-side errors
  16521. https://bugs.webkit.org/show_bug.cgi?id=76802
  16522. Reviewed by Tony Chang.
  16523. Report errors whenever server's response doesn't match "OK".
  16524. * Scripts/webkitpy/common/net/file_uploader.py:
  16525. (FileUploader.upload_single_text_file):
  16526. (FileUploader.upload_as_multipart_form_data):
  16527. (FileUploader._upload_data.callback):
  16528. (FileUploader):
  16529. (FileUploader._upload_data):
  16530. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  16531. (PerfTestsRunner._upload_json):
  16532. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  16533. (test_upload_json):
  16534. (test_upload_json.MockFileUploader.upload_single_text_file):
  16535. 2012-01-22 Ryosuke Niwa <rniwa@webkit.org>
  16536. run-perf-tests ignore Skipped list on chromium
  16537. https://bugs.webkit.org/show_bug.cgi?id=76764
  16538. Reviewed by Dirk Pranke.
  16539. Move skipped_perf_tests from WebKit port to Base port so that Chromium port
  16540. can also find skipped list. Chromium port only uses test_expectations.txt for
  16541. layout tests but performacne tests don't use test_expectations.txt so Chromium port
  16542. also needs to use Skipped list.
  16543. * Scripts/webkitpy/layout_tests/port/base.py:
  16544. (Port._tests_from_skipped_file_contents):
  16545. (Port):
  16546. (Port._expectations_from_skipped_files):
  16547. (Port.skipped_perf_tests):
  16548. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  16549. (PortTest.test_skipped_perf_tests):
  16550. (PortTest.test_skipped_perf_tests.add_text_file):
  16551. * Scripts/webkitpy/layout_tests/port/webkit.py:
  16552. (WebKitPort._skipped_tests_for_unsupported_features):
  16553. (WebKitPort._skipped_file_search_paths):
  16554. (WebKitPort.skipped_layout_tests):
  16555. 2012-01-23 Andy Estes <aestes@apple.com>
  16556. Fix the build after r105635.
  16557. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
  16558. (TestWebKitAPI::TEST):
  16559. 2012-01-23 Xianzhu Wang <wangxianzhu@chromium.org>
  16560. Basic enhancements to StringBuilder
  16561. https://bugs.webkit.org/show_bug.cgi?id=67081
  16562. Reviewed by Darin Adler.
  16563. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
  16564. (TestWebKitAPI::TEST):
  16565. 2012-01-23 Mario Sanchez Prada <msanchez@igalia.com>
  16566. [GTK] run-gtk-tests randomly fails while running the xprop comand
  16567. https://bugs.webkit.org/show_bug.cgi?id=76817
  16568. Reviewed by Gustavo Noronha Silva.
  16569. No need to use xprop to remove the AT_SPI_BUS property since
  16570. run-gtk-tests will always run new instances of Xvfb.
  16571. * Scripts/run-gtk-tests:
  16572. (TestRunner): Unskip TestWebKitAccessibility.
  16573. (TestRunner.run): Uncomment lines for launching the accessibility
  16574. bus and registry daemon, and remove lines for running xprop.
  16575. 2012-01-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16576. [Qt] Don't warn about override and final being C++11 extensions
  16577. Clang will emit a warning when these extensions are used without passing
  16578. --std=c++11, but we use feature checking to decide if we have the right
  16579. extensions, so we can safely ignore these warnings. The XCode and Windows
  16580. project files have the same workaround.
  16581. The reason for adding the flag to QMAKE_OBJECTIVE_CFLAGS as well is that
  16582. we only have one extra compiler for Objective-C, which is also used for
  16583. Objective-C++ sources, so we have to pass the flag, even if it doesn't
  16584. make sense for Objective-C.
  16585. Reviewed by Simon Hausmann.
  16586. * qmake/mkspecs/features/unix/default_post.prf:
  16587. 2012-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16588. [Qt] Change how build-webkit decides when to do full incremental builds
  16589. Instead of relying on update-webkit (which isn't run on the bots) to
  16590. decide when to do a full incremental build (make qmake), we let the
  16591. build-webkit script itself check the current SVN revision against the
  16592. previous build (by storing it in .webkit.config).
  16593. If the two differ we assume a full incremental build is needed, since
  16594. the new revisions might have introduced problematic things like new
  16595. Q_OBJECT macros. If not, we assume the developer is doing changes
  16596. locally, and revert to doing a plain 'make'.
  16597. In addition, when the build fails in the latter case, we inform the
  16598. developer of possible pitfalls and how to manually run 'make qmake'.
  16599. Reviewed by Ossy.
  16600. * Scripts/update-webkit:
  16601. * Scripts/webkitdirs.pm:
  16602. (buildQMakeProjects):
  16603. 2012-01-23 Mario Sanchez Prada <msanchez@igalia.com>
  16604. [GTK] run-gtk-tests randomly fails while running the xprop comand
  16605. https://bugs.webkit.org/show_bug.cgi?id=76817
  16606. Reviewed by Philippe Normand.
  16607. Temporarily comment the lines related to launching the ATSPI bus
  16608. and registry daemon, which are making the bots to fail randomly.
  16609. * Scripts/run-gtk-tests:
  16610. (TestRunner): Skip TestWebKitAccessibility, as it won't run
  16611. properly if the ATSPI infrastructure is not properly initialized.
  16612. (TestRunner.run): Comment lines related to initialization of ATSPI.
  16613. 2012-01-22 Ryosuke Niwa <rniwa@webkit.org>
  16614. Windows python test build fix.
  16615. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  16616. (PerfTestsRunner.__init__):
  16617. 2012-01-22 Sergio Villar Senin <svillar@igalia.com>
  16618. [GTK] DumpRenderTree converts "file:///" to a path differently
  16619. https://bugs.webkit.org/show_bug.cgi?id=76631
  16620. Reviewed by Martin Robinson.
  16621. DumpRenderTree should print "/" as the last path component if the
  16622. path is a lone slash instead of empty output.
  16623. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  16624. (webViewConsoleMessage):
  16625. 2012-01-20 David Levin <levin@chromium.org>
  16626. The leaky DC check should use adoptPtr as a signal instead of OwnPtr to get less false positives.
  16627. https://bugs.webkit.org/show_bug.cgi?id=76752
  16628. Reviewed by Eric Seidel.
  16629. * Scripts/webkitpy/style/checkers/cpp.py:
  16630. (check_for_leaky_patterns):
  16631. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  16632. (LeakyPatternTest.test_create_dc):
  16633. (LeakyPatternTest.test_create_compatible_dc):
  16634. 2012-01-20 Shawn Singh <shawnsingh@chromium.org>
  16635. Changed my status in commiters.py
  16636. Unreviewed.
  16637. * Scripts/webkitpy/common/config/committers.py:
  16638. 2012-01-20 Ojan Vafai <ojan@chromium.org>
  16639. run-webkit-tests --lint-test-files crawls the whole LayoutTests subtree
  16640. https://bugs.webkit.org/show_bug.cgi?id=76748
  16641. Reviewed by Ryosuke Niwa.
  16642. It crawls the whole subtree and then doesn't use the data. Cutting this out
  16643. saves 4 seconds warm and 17 seconds cold on my Mac Pro.
  16644. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  16645. (run):
  16646. 2012-01-20 Adam Barth <abarth@webkit.org>
  16647. Another tiny tweak to the garden-o-matic CSS. This makes things line
  16648. up slightly nicer when there aren't any failures.
  16649. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
  16650. (#summary):
  16651. 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
  16652. run-perf-tests should support --test-results-server option
  16653. https://bugs.webkit.org/show_bug.cgi?id=76680
  16654. Reviewed by Adam Barth.
  16655. Add --test-results-server, --builder-name, and --build-number options to run-perf-tests
  16656. to be used by perf bots. Also refactor file_uploader as needed.
  16657. * Scripts/webkitpy/common/net/file_uploader.py:
  16658. (FileUploader.__init__):
  16659. (FileUploader.upload_single_file):
  16660. (FileUploader.upload_as_multipart_form_data):
  16661. (FileUploader):
  16662. (FileUploader._upload_data):
  16663. (FileUploader._upload_data.callback):
  16664. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  16665. (JSONResultsGeneratorBase.upload_json_files):
  16666. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  16667. (PerfTestsRunner):
  16668. (PerfTestsRunner._parse_args):
  16669. (PerfTestsRunner.run):
  16670. (PerfTestsRunner._generate_json):
  16671. (PerfTestsRunner._upload_json):
  16672. (PerfTestsRunner._run_tests_set):
  16673. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  16674. (create_runner):
  16675. (test_run_with_upload_json):
  16676. (test_run_with_upload_json.mock_upload_json):
  16677. (test_upload_json):
  16678. (test_upload_json.MockFileUploader):
  16679. (test_upload_json.MockFileUploader.__init__):
  16680. (test_upload_json.MockFileUploader.upload_single_file):
  16681. (test_parse_args):
  16682. 2012-01-20 Adam Barth <abarth@webkit.org>
  16683. The party time image overlaps real content! This patch makes the
  16684. image centered vertically.
  16685. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
  16686. (#onebar.partytime #summary):
  16687. 2012-01-19 Ojan Vafai <ojan@chromium.org>
  16688. Refactor TestExpectationsParser in preparation for caching the results
  16689. https://bugs.webkit.org/show_bug.cgi?id=76669
  16690. Reviewed by Dimitri Glazkov.
  16691. Make everything private expect for the parse method.
  16692. Eventually, we'll need the expectations lines to not be modified
  16693. outside of TestExpectationsParser so we can cache the results.
  16694. This makes check-webkit-style of the chromium test_expectations.txt file
  16695. go from ~17 seconds to ~12 seconds on my Mac Pro.
  16696. This patch is just a refactor in preparation, so no new tests.
  16697. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  16698. (TestExpectationEditorTests.make_parsed_expectation_lines):
  16699. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  16700. (TestExpectationParser.parse):
  16701. (TestExpectationParser):
  16702. (TestExpectationParser._parse_line):
  16703. (TestExpectationParser._tokenize):
  16704. (TestExpectationParser._tokenize_list):
  16705. (TestExpectationsModel._clear_expectations_for_test):
  16706. (TestExpectations.__init__):
  16707. (TestExpectations._add_expectations):
  16708. (TestExpectations._add_skipped_tests):
  16709. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  16710. (TestExpectationParserTests.test_tokenize_blank):
  16711. (TestExpectationParserTests.test_tokenize_missing_colon):
  16712. (TestExpectationParserTests.test_tokenize_extra_colon):
  16713. (TestExpectationParserTests.test_tokenize_empty_comment):
  16714. (TestExpectationParserTests.test_tokenize_comment):
  16715. (TestExpectationParserTests.test_tokenize_missing_equal):
  16716. (TestExpectationParserTests.test_tokenize_extra_equal):
  16717. (TestExpectationParserTests.test_tokenize_valid):
  16718. (TestExpectationParserTests.test_tokenize_valid_with_comment):
  16719. (TestExpectationParserTests.test_tokenize_valid_with_multiple_modifiers):
  16720. (TestExpectationParserTests.test_parse_empty_string):
  16721. (TestExpectationSerializerTests.assert_round_trip):
  16722. (TestExpectationSerializerTests.assert_list_round_trip):
  16723. * Scripts/webkitpy/tool/commands/expectations.py:
  16724. (OptimizeExpectations.execute):
  16725. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  16726. (GardeningExpectationsUpdater.update_expectations):
  16727. 2012-01-20 Adam Barth <abarth@webkit.org>
  16728. Follow-up to previous patch: don't produce NaN when the revision number
  16729. is missing.
  16730. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  16731. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
  16732. 2012-01-20 Adam Barth <abarth@webkit.org>
  16733. Garden-o-matic should tell me which revisions have been checked by all the bots
  16734. https://bugs.webkit.org/show_bug.cgi?id=76722
  16735. Reviewed by Dimitri Glazkov.
  16736. This information helps me know when it's safe for me to roll a
  16737. candidate revision.
  16738. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  16739. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  16740. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js:
  16741. 2012-01-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16742. build-webkit: Don't spit out congratulations message on Ctrl+C
  16743. Reviewed by Andreas Kling.
  16744. * Scripts/build-webkit:
  16745. 2012-01-20 Philippe Normand <pnormand@igalia.com>
  16746. [GTK] Allow extra jhbuild modulesets
  16747. https://bugs.webkit.org/show_bug.cgi?id=76691
  16748. Reviewed by Gustavo Noronha Silva.
  16749. * gtk/jhbuildrc: Extra modulesets and modules can be added in
  16750. JHBuild using the WEBKIT_EXTRA_MODULESETS and WEBKIT_EXTRA_MODULES
  16751. env variables respectively. Use comma-separated values. Example:
  16752. WEBKIT_EXTRA_MODULES=file:///path/to/module.set,file:///other/path.
  16753. 2012-01-20 Mario Sanchez Prada <msanchez@igalia.com>
  16754. [GTK] Expose accessibility hierarchy in WebKit2 to ATK/AT-SPI based ATs
  16755. https://bugs.webkit.org/show_bug.cgi?id=72589
  16756. Reviewed by Martin Robinson.
  16757. Ensure the accessibility infrastructure is available when running
  16758. the unit tests, otherwise WK2's accessibility tests won't work.
  16759. * Scripts/run-gtk-tests:
  16760. (TestRunner):
  16761. (TestRunner._lookup_atspi2_binary): New. Looks for the directory
  16762. where at-spi2's stuff is located (like at-spi-bus-launcher and
  16763. at-spi2-registryd).
  16764. (TestRunner.run): Initialize the accessibility infrastructure.
  16765. * gtk/generate-gtkdoc:
  16766. (get_webkit2_options): Add 'WebKitWebViewBaseAccessible.*'.
  16767. * gtk/jhbuild.modules: Added at-spi2-core and at-spi2-atk.
  16768. 2012-01-20 Hayato Ito <hayato@chromium.org>
  16769. Add ShadowRoot.idl which is enabled by newly introduced SHADOW_DOM flag.
  16770. https://bugs.webkit.org/show_bug.cgi?id=76353
  16771. Reviewed by Hajime Morita.
  16772. Add ShadowRoot.idl, which is enabled only on chromium port since this is
  16773. under development feature.
  16774. ShadowRoot.idl contains minimum API so that we can test it.
  16775. Other APIs should be added on other changes so that we can isolate issues.
  16776. * DumpRenderTree/chromium/TestShell.cpp:
  16777. (TestShell::TestShell):
  16778. 2012-01-20 Mario Sanchez Prada <msanchez@igalia.com>
  16779. [GTK] GTK's DRT not to log events for already defunct objects
  16780. https://bugs.webkit.org/show_bug.cgi?id=76620
  16781. Reviewed by Martin Robinson.
  16782. Do not log 'state-change:defunct' events.
  16783. * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
  16784. (printAccessibilityEvent): Early return if a
  16785. 'state-change:defunct' signal is passed.
  16786. (axObjectEventListener): Pass the signal name and value in
  16787. separate parameters to printAccessibilityEvent.
  16788. 2012-01-19 Gustavo Noronha Silva <gns@gnome.org>
  16789. Unreviewed build fix. Wrong variable being used as the cwd for git
  16790. remote update command.
  16791. * gtk/run-with-jhbuild:
  16792. (update_jhbuild):
  16793. 2012-01-19 Gustavo Noronha Silva <gns@gnome.org>
  16794. [GTK] ensure the jhbuild used by webkit is as up-to-date as needed
  16795. https://bugs.webkit.org/show_bug.cgi?id=76585
  16796. Reviewed by Martin Robinson.
  16797. This allows us to specify a minimum version of jhbuild required,
  16798. while also providing stability against changes done to the master
  16799. branch, by letting us choose what is the exact version that will
  16800. be used.
  16801. * gtk/run-with-jhbuild: refactored for more hackability and easier
  16802. reading
  16803. (jhbuild_installed): checks whether jhbuild is installed
  16804. (jhbuild_cloned): checks whether jhbuild has been cloned
  16805. (jhbuild_at_expected_revision): checks whether jhbuild is at the
  16806. expected revision
  16807. (update_jhbuild): brings jhbuild to the expected revision
  16808. (clone_jhbuild): clones jhbuild
  16809. (install_jhbuild): build and installs jhbuild
  16810. (update_webkitgtk_libs): runs update-webkitgtk-libs
  16811. (ensure_jhbuild): high-level logic to decide whether and which of
  16812. the steps above are executed
  16813. 2012-01-19 Alexey Proskuryakov <ap@apple.com>
  16814. [WK2] DumpRenderTree converts "file:///" to a path differently
  16815. https://bugs.webkit.org/show_bug.cgi?id=76653
  16816. Reviewed by John Sullivan.
  16817. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: (WTR::lastFileURLPathComponent):
  16818. Do print a slash if there are no path components.
  16819. 2012-01-19 Eric Seidel <eric@webkit.org>
  16820. webkit-patch cannot rollout patches without changelog/bug number
  16821. https://bugs.webkit.org/show_bug.cgi?id=75962
  16822. Reviewed by Adam Barth.
  16823. * Scripts/webkitpy/tool/commands/download.py:
  16824. (AbstractRolloutPrepCommand._prepare_state):
  16825. * Scripts/webkitpy/tool/commands/download_unittest.py:
  16826. (AbstractRolloutPrepCommandTest.test_prepare_state):
  16827. 2012-01-19 Alexey Proskuryakov <ap@apple.com>
  16828. [WK2] fast/url/degenerate-file-base.html fails
  16829. https://bugs.webkit.org/show_bug.cgi?id=76619
  16830. Reviewed by Adam Roben.
  16831. A URL generated form local path for loading had an extra slash, making document.URL
  16832. incorrect in all WebKit2 tests (file://localhost//path/to/test.html).
  16833. * WebKitTestRunner/TestInvocation.cpp: (WTR::createWKURL):
  16834. 2012-01-18 Ojan Vafai <ojan@chromium.org>
  16835. check-webkit-style of the chromium test_expectations.txt file doesn't test all chromium ports
  16836. https://bugs.webkit.org/show_bug.cgi?id=76510
  16837. Reviewed by Adam Barth.
  16838. Unlike other style rules, if you get the syntax of the test_expectations.txt
  16839. file wrong, the layout tests won't run. Also, this check is simple and only
  16840. slows down committing if you actually modify one of the test_expectations.txt files.
  16841. * Scripts/webkitpy/style/checkers/test_expectations.py:
  16842. (TestExpectationsChecker.check_test_expectations):
  16843. (TestExpectationsChecker.check):
  16844. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  16845. (TestExpectationsTestCase.test_check_covers_all_configurations):
  16846. (TestExpectationsTestCase.test_check_covers_all_configurations.mock_check_test_expectations):
  16847. (TestExpectationsTestCase):
  16848. (assert_lines_lint):
  16849. 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
  16850. Build fix. Revert an unintentional change to WebKitDriver in r105443.
  16851. * Scripts/webkitpy/layout_tests/port/driver.py:
  16852. (DriverProxy.__init__):
  16853. 2012-01-19 Dirk Pranke <dpranke@chromium.org>
  16854. remove the duplicated build rules from WebKit.gyp, Tools.gyp
  16855. https://bugs.webkit.org/show_bug.cgi?id=73384
  16856. Reviewed by Tony Chang.
  16857. This patch removes the no-longer-necessary conditional logic for
  16858. build_webkit_exes_from_webkit_gyp; we now always build the exes
  16859. from their own dedicated gyp files.
  16860. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  16861. 2012-01-19 Alexey Proskuryakov <ap@apple.com>
  16862. make-new-script-test should work with HTTP tests
  16863. https://bugs.webkit.org/show_bug.cgi?id=76603
  16864. Reviewed by Adam Roben.
  16865. * Scripts/make-new-script-test:
  16866. (makePathToSharedSources): Renamed from makeTestRelativePathToSharedSources(), since it
  16867. now also creates absolute paths for HTTP.
  16868. 2012-01-19 Ryosuke Niwa <rniwa@webkit.org>
  16869. Some perf tests time out when ran by run-perf-tests
  16870. https://bugs.webkit.org/show_bug.cgi?id=76612
  16871. Reviewed by Dirk Pranke and Eric Seidel.
  16872. Always pass --no-timeout to DumpRenderTree from run-perf-tests.
  16873. Otherwise some tests such as Parser/xml-parser.html will timeout.
  16874. --no-timeout option is currently supported by Chromium and Mac ports.
  16875. * Scripts/webkitpy/layout_tests/port/base.py:
  16876. (Port.to.create_driver):
  16877. * Scripts/webkitpy/layout_tests/port/chromium.py:
  16878. (ChromiumDriver.__init__):
  16879. (ChromiumDriver._wrapper_options):
  16880. * Scripts/webkitpy/layout_tests/port/driver.py:
  16881. (Driver.__init__):
  16882. (DriverProxy.__init__):
  16883. * Scripts/webkitpy/layout_tests/port/webkit.py:
  16884. (WebKitDriver.__init__):
  16885. (WebKitDriver.cmd_line):
  16886. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  16887. (WebKitDriverTest.test_read_binary_block):
  16888. (WebKitDriverTest):
  16889. (WebKitDriverTest.test_no_timeout):
  16890. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  16891. (get_tests_run.RecordingTestDriver.__init__):
  16892. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  16893. (PerfTestsRunner._parse_args):
  16894. (PerfTestsRunner._run_tests_set):
  16895. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  16896. (create_runner):
  16897. 2012-01-19 Ben Wells <benwells@chromium.org>
  16898. Add support for window.print to chromium DRT
  16899. https://bugs.webkit.org/show_bug.cgi?id=76479
  16900. When used in a test window.print goes into print mode and then
  16901. straight out again. This will allow the afterprint event to be
  16902. tested by having the afterprint event happen before the dump
  16903. happens.
  16904. Reviewed by Mihai Parparita.
  16905. * DumpRenderTree/chromium/WebViewHost.cpp:
  16906. (WebViewHost::printPage):
  16907. * DumpRenderTree/chromium/WebViewHost.h:
  16908. 2012-01-18 Enrica Casucci <enrica@apple.com>
  16909. editingAttributedStringFromRange in WebHTMLConverter does not handle NSUnderlineStyleAttributeName.
  16910. https://bugs.webkit.org/show_bug.cgi?id=76588
  16911. <rdar://problem/9325183>
  16912. Added test.
  16913. Reviewed by Dan Bernstein.
  16914. * TestWebKitAPI/Tests/mac/InspectorBar.mm:
  16915. (TestWebKitAPI::TEST):
  16916. 2012-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16917. [Qt] Do full incremental builds until bots use update-webkit
  16918. Rubber-stamped by Simon Hausmann.
  16919. * Scripts/webkitdirs.pm:
  16920. (buildQMakeProjects):
  16921. 2012-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16922. Fix the Qt build
  16923. Unreviewed build fix.
  16924. * Scripts/webkitdirs.pm:
  16925. (buildQMakeProjects):
  16926. 2012-01-19 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  16927. [Qt] Make build-webkit always do safe incremental builds after update-webkit
  16928. When building against Qt5 with GCC we would just run 'make' in the build dir,
  16929. and rely on the dependency files output by GCC (-MD) to handle dependency
  16930. tracking, but that fails for special-cases like adding a Q_OBJECT macro
  16931. to a header.
  16932. To guarantee that an incrmental build will work, we have to run 'make qmake',
  16933. which we now do on every build-webkit that's followed by a successful run
  16934. of update-webkit. The reasoning is that update-webkit can result in such
  16935. potential corner-cases being applied, and since we can't know for sure
  16936. unless we inspect the diff and account for all the corner cases we assume
  16937. the worst and always run 'make qmake'.
  16938. After a succesful run of build-webkit we proceed to do just 'make' for any
  16939. subsequent runs, since we assume that the developer knows what kind of
  16940. changes he/she is doing, and when a 'make qmake' is needed.
  16941. Reviewed by Simon Hausmann.
  16942. * Scripts/update-webkit:
  16943. * Scripts/webkitdirs.pm:
  16944. (determineCurrentSVNRevision):
  16945. (currentSVNRevision):
  16946. (buildQMakeProjects):
  16947. * qmake/mkspecs/features/default_post.prf:
  16948. 2012-01-18 Ryosuke Niwa <rniwa@webkit.org>
  16949. run-perf-tests should support Skipped list
  16950. https://bugs.webkit.org/show_bug.cgi?id=76594
  16951. Reviewed by Adam Barth.
  16952. Add a support for Skipped list in run-perf-tests; also skip files in resources directories.
  16953. * Scripts/webkitpy/layout_tests/port/base.py:
  16954. (Port.perf_tests_dir):
  16955. (Port.skipped_perf_tests):
  16956. (Port.skips_perf_test):
  16957. (Port.relative_perf_test_filename):
  16958. * Scripts/webkitpy/layout_tests/port/test.py:
  16959. (TestPort.perf_tests_dir):
  16960. * Scripts/webkitpy/layout_tests/port/webkit.py:
  16961. (WebKitPort._expectations_from_skipped_files):
  16962. (WebKitPort):
  16963. (WebKitPort.skipped_layout_tests):
  16964. (WebKitPort.skipped_perf_tests):
  16965. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  16966. (PerfTestsRunner._collect_tests):
  16967. (PerfTestsRunner.run):
  16968. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  16969. (test_run_test_set_with_json_output):
  16970. (test_run_test_set_with_json_source):
  16971. (test_collect_tests_with_skipped_list):
  16972. (test_collect_tests_with_skipped_list.add_file):
  16973. 2012-01-18 Dirk Pranke <dpranke@chromium.org>
  16974. Fix path to chromium_src_dir introduced in previous change.
  16975. Unreviewed, build fix.
  16976. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
  16977. 2012-01-18 Alexey Proskuryakov <ap@apple.com>
  16978. Need infrastructure to test Content-Disposition filename encoding support
  16979. https://bugs.webkit.org/show_bug.cgi?id=76572
  16980. <rdar://problem/6421825>
  16981. Reviewed by Sam Weinig.
  16982. Made policy delegate log suggested file name when resource has Content-Disposition: attachment.
  16983. WebKitTestRunner does not have a policy delegate yet, bug 42546.
  16984. * DumpRenderTree/mac/PolicyDelegate.mm:
  16985. (dispositionTypeFromContentDispositionHeader):
  16986. (-[PolicyDelegate webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
  16987. 2012-01-18 Ojan Vafai <ojan@chromium.org>
  16988. Fix tests from http://trac.webkit.org/changeset/105332.
  16989. The code assumed that if you passed an options object with a configuration
  16990. attribute that it would have a valid value. A bunch of the testing mocks
  16991. do things like having a configuration value of None.
  16992. * Scripts/webkitpy/layout_tests/port/base.py:
  16993. (Port.__init__):
  16994. 2012-01-18 Ojan Vafai <ojan@chromium.org>
  16995. Shave 0.5 seconds off check-webkit-style runtime for test_expectations.txt
  16996. https://bugs.webkit.org/show_bug.cgi?id=76576
  16997. Reviewed by Adam Barth.
  16998. Avoid calling default_configuration in base.py. We don't need it for
  16999. checking test_expectations.txt style. It takes ~0.5 seconds to run on my
  17000. Mac Pro. It's the call to "perl Tools/Scripts/webkit-build-directory --top-level"
  17001. from common.executive.
  17002. At some point someone should probably look into why that call is so slow
  17003. since it's on the critical path for run-webkit-tests and build-webkit startup.
  17004. * Scripts/webkitpy/layout_tests/port/base.py:
  17005. (Port.__init__):
  17006. * Scripts/webkitpy/style/checkers/test_expectations.py:
  17007. (TestExpectationsChecker._determine_port_from_exepectations_path):
  17008. 2012-01-18 Dirk Pranke <dpranke@chromium.org>
  17009. [chromium] move Tools.gyp, switch build-webkit --chromium to All.gyp
  17010. https://bugs.webkit.org/show_bug.cgi?id=76505
  17011. Reviewed by Tony Chang.
  17012. Update chromium build script to use All.gyp instead of WebKit.gyp
  17013. * DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp: Renamed from Source/WebKit/chromium/Tools.gyp.
  17014. * Scripts/webkitdirs.pm:
  17015. 2012-01-18 Sam Weinig <sam@webkit.org>
  17016. Don’t hardcode the path to ‘make‘.
  17017. Reviewed by Dan Bernstein.
  17018. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  17019. 2012-01-18 Joshua Bell <jsbell@chromium.org>
  17020. Adding myself to committers.py
  17021. https://bugs.webkit.org/show_bug.cgi?id=76569
  17022. Unreviewed.
  17023. * Scripts/webkitpy/common/config/committers.py:
  17024. 2012-01-18 Adam Barth <abarth@webkit.org>
  17025. Up the cap on test failures tolerated by the EWS so the mac-ews can run to completion
  17026. https://bugs.webkit.org/show_bug.cgi?id=76567
  17027. Reviewed by Eric Seidel.
  17028. Current the AppleMac port has slightly more failures than we allow on
  17029. the EWS, causing the mac-ews to spin. This patch ups the limit a bit,
  17030. which should hopefully let the mac-ews run to completion. Once
  17031. AppleMac has fewer failures, we can lower the cap again.
  17032. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  17033. (LayoutTestResultsReaderTest.test_layout_test_results):
  17034. * Scripts/webkitpy/tool/steps/runtests.py:
  17035. (RunTests):
  17036. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  17037. 2012-01-18 Eric Carlson <eric.carlson@apple.com>
  17038. Provide access to user's list of preferred languages
  17039. https://bugs.webkit.org/show_bug.cgi?id=76138
  17040. Reviewed by Alexey Proskuryakov.
  17041. * GNUmakefile.am: Add JSInternalsCustom.cpp.
  17042. 2012-01-18 Adam Barth <abarth@webkit.org>
  17043. Add Chromium Linux GPU 32 to the list of allowed Chromium Linux
  17044. configurations.
  17045. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  17046. (ChromiumLinuxPort.__init__):
  17047. 2012-01-18 Dominic Mazzoni <dmazzoni@google.com>
  17048. Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
  17049. https://bugs.webkit.org/show_bug.cgi?id=73460
  17050. Reviewed by Chris Fleizach.
  17051. * DumpRenderTree/AccessibilityUIElement.h:
  17052. * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  17053. (AccessibilityUIElement::AccessibilityUIElement):
  17054. (AccessibilityUIElement::scrollToMakeVisibleCallback):
  17055. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
  17056. (AccessibilityUIElement::scrollToGlobalPointCallback):
  17057. * DumpRenderTree/chromium/AccessibilityUIElement.h:
  17058. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  17059. (AccessibilityUIElement::scrollToMakeVisible):
  17060. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
  17061. (AccessibilityUIElement::scrollToGlobalPoint):
  17062. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  17063. (AccessibilityUIElement::scrollToMakeVisible):
  17064. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
  17065. (AccessibilityUIElement::scrollToGlobalPoint):
  17066. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  17067. (AccessibilityUIElement::scrollToMakeVisible):
  17068. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
  17069. (AccessibilityUIElement::scrollToGlobalPoint):
  17070. 2012-01-17 Enrica Casucci <enrica@apple.com>
  17071. Missing NSForegroundColorAttributeName should be treated as black instead of transparent.
  17072. https://bugs.webkit.org/show_bug.cgi?id=76490
  17073. <rdar://problem/9460733>
  17074. Added TestWebKitAPI test.
  17075. Reviewed by Dan Bernstein.
  17076. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new test file.
  17077. * TestWebKitAPI/Tests/mac/InspectorBar.mm: Added test that calls
  17078. changeAttributes to the WebView.
  17079. 2012-01-18 Balazs Kelemen <kbalazs@webkit.org>
  17080. [Qt] Consolidate layout test crash logging
  17081. https://bugs.webkit.org/show_bug.cgi?id=75088
  17082. Reviewed by Simon Hausmann.
  17083. Move backtrace generating logic into WTFReportBacktrace
  17084. and add a way to deinstall signal handlers if we know
  17085. that we have already printed the backtrace.
  17086. * DumpRenderTree/qt/main.cpp:
  17087. (crashHandler):
  17088. (setupSignalHandlers):
  17089. (WTFCrashHook):
  17090. (main):
  17091. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
  17092. (WTR::crashHandler):
  17093. (WTR::setupSignalHandlers):
  17094. (WTR::crashHook):
  17095. (WTR::InjectedBundle::platformInitialize):
  17096. 2012-01-18 Ilya Tikhonovsky <loislo@chromium.org>
  17097. Unreviewed build fix after r105256.
  17098. There was a cyclic dependency between self._port and self._host assigments.
  17099. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  17100. (PerfTestsRunner.__init__):
  17101. 2012-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  17102. Add new watchlist rule for the Qt build system
  17103. Reviewed by Simon Hausmann.
  17104. * Scripts/webkitpy/common/config/watchlist:
  17105. 2012-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  17106. [Qt] Move OTHER_FILES from WebKit.pro to Tools.pro
  17107. Reviewed by Simon Hausmann.
  17108. * Tools.pro:
  17109. 2012-01-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  17110. [Qt] Allow building only a subset of the WebKit sub-projects
  17111. Fixes build-jsc, broken in r104825.
  17112. We no longer need the intermediate buildQMakeQtProject(), as we're the
  17113. only port using qmake, and buildQMakeProject is now highly Qt specific.
  17114. <http://webkit.org/b/76179>
  17115. Reviewed by Simon Hausmann.
  17116. * Scripts/build-jsc:
  17117. * Scripts/build-webkit:
  17118. * Scripts/webkitdirs.pm:
  17119. (buildQMakeProjects):
  17120. 2012-01-18 Ryosuke Niwa <rniwa@webkit.org>
  17121. run-perf-tests should generate a json file that summaries the result
  17122. https://bugs.webkit.org/show_bug.cgi?id=76504
  17123. Reviewed by Adam Barth.
  17124. Add an ability to generate a json file to run-perf-test in the preparation for perf bots.
  17125. New option --outout-json-path specifies the json file's path, and --source-json-path specifies
  17126. another json file to be merged into the generated json file.
  17127. Also fixed a bug that --build wasn't set by default.
  17128. * Scripts/webkitpy/layout_tests/port/test.py:
  17129. (TestPort.webkit_base):
  17130. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  17131. (PerfTestsRunner.__init__):
  17132. (PerfTestsRunner):
  17133. (PerfTestsRunner._parse_args):
  17134. (PerfTestsRunner.run):
  17135. (PerfTestsRunner._generate_json_if_specified):
  17136. (PerfTestsRunner._process_chromium_style_test_result):
  17137. (PerfTestsRunner._process_parser_test_result):
  17138. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  17139. (MainTest):
  17140. (create_runner):
  17141. (test_run_test_set):
  17142. (test_run_test_set_for_parser_tests):
  17143. (test_run_test_set_with_summary_json):
  17144. (test_collect_tests):
  17145. (test_parse_args):
  17146. 2012-01-17 Sheriff Bot <webkit.review.bot@gmail.com>
  17147. Unreviewed, rolling out r105244.
  17148. http://trac.webkit.org/changeset/105244
  17149. https://bugs.webkit.org/show_bug.cgi?id=76518
  17150. broke Chromium Mac (Requested by rolandsteiner on #webkit).
  17151. * DumpRenderTree/AccessibilityUIElement.h:
  17152. * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  17153. (AccessibilityUIElement::AccessibilityUIElement):
  17154. * DumpRenderTree/chromium/AccessibilityUIElement.h:
  17155. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  17156. (AccessibilityUIElement::removeSelection):
  17157. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  17158. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  17159. (AccessibilityUIElement::removeSelection):
  17160. 2012-01-17 Dominic Mazzoni <dmazzoni@google.com>
  17161. Accessibility: Chromium needs methods to scroll an object into view or to a specific location.
  17162. https://bugs.webkit.org/show_bug.cgi?id=73460
  17163. Reviewed by Chris Fleizach.
  17164. * DumpRenderTree/AccessibilityUIElement.h:
  17165. * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  17166. (AccessibilityUIElement::AccessibilityUIElement):
  17167. (AccessibilityUIElement::scrollToMakeVisibleCallback):
  17168. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocusCallback):
  17169. (AccessibilityUIElement::scrollToGlobalPointCallback):
  17170. * DumpRenderTree/chromium/AccessibilityUIElement.h:
  17171. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  17172. (AccessibilityUIElement::scrollToMakeVisible):
  17173. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
  17174. (AccessibilityUIElement::scrollToGlobalPoint):
  17175. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  17176. (AccessibilityUIElement::scrollToMakeVisible):
  17177. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
  17178. (AccessibilityUIElement::scrollToGlobalPoint):
  17179. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  17180. (AccessibilityUIElement::scrollToMakeVisible):
  17181. (AccessibilityUIElement::scrollToMakeVisibleWithSubFocus):
  17182. (AccessibilityUIElement::scrollToGlobalPoint):
  17183. 2012-01-17 Adam Barth <abarth@webkit.org>
  17184. Enable tests on the mac-ews
  17185. https://bugs.webkit.org/show_bug.cgi?id=76502
  17186. Reviewed by Simon Fraser.
  17187. Apple now has five machines running the mac-ews. Lucas Forschler has
  17188. asked that we try enabling tests to see if we have enough bandwidth.
  17189. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  17190. (MacEWS):
  17191. 2012-01-17 Sanjoy Das <sanjoy@playingwithpointers.com>
  17192. Add a check-webkit-style exception for GDBInterface.cpp
  17193. https://bugs.webkit.org/show_bug.cgi?id=76187
  17194. Add an exception for Source/JavaScriptCore/jit/GDBInterface.cpp so
  17195. that it does not fail the style check.
  17196. Reviewed by Martin Robinson.
  17197. * Scripts/webkitpy/style/checker.py: Tell the style checker to not run
  17198. readability/naming tests on
  17199. Source/JavaScriptCore/jit/GDBInterface.cpp.
  17200. * Scripts/webkitpy/style/checker_unittest.py:
  17201. (GlobalVariablesTest.test_path_rules_specifier): Add a test for
  17202. the above exception.
  17203. 2012-01-17 Hajime Morrita <morrita@chromium.org>
  17204. https://bugs.webkit.org/show_bug.cgi?id=76245
  17205. [Mac][DRT] should allow query string for the file URL.
  17206. Reviewed by Tony Chang.
  17207. Taught DRT about file:// as a url instead of a file path.
  17208. We are now able to use a path file:///foo/bar.html?baz as a url
  17209. with which DRT opens "/foo/bar.html" with "baz" as a query string.
  17210. * DumpRenderTree/mac/DumpRenderTree.mm:
  17211. (runTest):
  17212. 2012-01-17 Ojan Vafai <ojan@chromium.org>
  17213. Check style on test_expectations.txt files before commit
  17214. https://bugs.webkit.org/show_bug.cgi?id=76484
  17215. Reviewed by Adam Barth.
  17216. Unlike other style rules, if you get the syntax of the test_expectations.txt
  17217. file wrong, the layout tests won't run. Also, this check is simple and only
  17218. slows down committing if you actually modify one of the test_expectations.txt files.
  17219. * Scripts/webkitpy/tool/steps/commit.py:
  17220. (Commit._check_test_expectations):
  17221. (Commit.run):
  17222. * Scripts/webkitpy/tool/steps/commit_unittest.py: Added.
  17223. (CommitTest):
  17224. (CommitTest.test_check_test_expectations):
  17225. 2012-01-17 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
  17226. [Qt] Debug build fails with debug qt5
  17227. https://bugs.webkit.org/show_bug.cgi?id=76463
  17228. Reviewed by Simon Hausmann.
  17229. Add QNetworkCookie include in order to satisfy sizeof in QTypeInfo in debug builds.
  17230. * QtTestBrowser/cookiejar.h:
  17231. 2012-01-17 Dirk Pranke <dpranke@chromium.org>
  17232. webkitpy: fix json import on linux
  17233. https://bugs.webkit.org/show_bug.cgi?id=76481
  17234. Reviewed by Adam Barth.
  17235. For some reason, the version of simplejson autoinstalled on my linux
  17236. box seems to be broken. We should really only be using
  17237. simplejson if json isn't available anyway, so this change looks
  17238. for json first.
  17239. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  17240. (JSONGeneratorTest.test_test_timings_trie):
  17241. 2012-01-17 Dirk Pranke <dpranke@chromium.org>
  17242. Fix failures in test-webkitpy caused by r105177.
  17243. Unreviewed, build fix.
  17244. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  17245. (ChromiumLinuxPort._determine_driver_path_statically):
  17246. (ChromiumLinuxPort._static_build_path):
  17247. 2012-01-17 Dirk Pranke <dpranke@chromium.org>
  17248. webkitpy: make PortFactory.get() be fully data-driven
  17249. https://bugs.webkit.org/show_bug.cgi?id=76360
  17250. Reviewed by Eric Seidel.
  17251. Refactor PortFactory.get() to be fully data-driven.
  17252. * Scripts/webkitpy/layout_tests/port/factory.py:
  17253. (PortFactory):
  17254. (PortFactory._default_port):
  17255. (PortFactory.get):
  17256. (PortFactory.get.in):
  17257. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  17258. (FactoryTest.assert_port):
  17259. 2012-01-17 Dirk Pranke <dpranke@chromium.org>
  17260. webkitpy: add determine_full_port_name(), clean up port.__init__()
  17261. https://bugs.webkit.org/show_bug.cgi?id=76357
  17262. Reviewed by Adam Barth.
  17263. Each Port class is now required to implement a 'port_name' field
  17264. that will match the start of all ports constructed by this class and
  17265. a 'determine_full_port_name' field that will make the port
  17266. fully-qualified.
  17267. * Scripts/webkitpy/layout_tests/port/apple.py:
  17268. (ApplePort.__init__):
  17269. * Scripts/webkitpy/layout_tests/port/base.py:
  17270. (Port):
  17271. (Port.determine_port_name):
  17272. (Port.__init__):
  17273. * Scripts/webkitpy/layout_tests/port/chromium.py:
  17274. (ChromiumPort.for):
  17275. (ChromiumPort.__init__):
  17276. (ChromiumPort):
  17277. (ChromiumPort._chromium_base_dir):
  17278. (ChromiumPort.path_from_chromium_base):
  17279. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  17280. (ChromiumGpuLinuxPort):
  17281. (ChromiumGpuLinuxPort.__init__):
  17282. (ChromiumGpuMacPort):
  17283. (ChromiumGpuMacPort.__init__):
  17284. (ChromiumGpuWinPort):
  17285. (ChromiumGpuWinPort.__init__):
  17286. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  17287. (ChromiumLinuxPort):
  17288. (ChromiumLinuxPort.determine_port_name):
  17289. (ChromiumLinuxPort.__init__):
  17290. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  17291. (ChromiumMacPort):
  17292. (ChromiumMacPort.determine_port_name):
  17293. (ChromiumMacPort.__init__):
  17294. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  17295. (ChromiumWinPort):
  17296. (ChromiumWinPort.determine_port_name):
  17297. (ChromiumWinPort.__init__):
  17298. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  17299. (DryRunPort):
  17300. (DryRunPort.determine_port_name):
  17301. (DryRunPort.__init__):
  17302. * Scripts/webkitpy/layout_tests/port/efl.py:
  17303. (EflPort):
  17304. * Scripts/webkitpy/layout_tests/port/factory.py:
  17305. (PortFactory):
  17306. (PortFactory._default_port):
  17307. (PortFactory.get):
  17308. (PortFactory.get.in):
  17309. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  17310. (FactoryTest.assert_port):
  17311. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  17312. (GoogleChromeLinux32Port):
  17313. (GoogleChromeLinux32Port.determine_port_name):
  17314. (GoogleChromeLinux64Port):
  17315. (GoogleChromeLinux64Port.determine_port_name):
  17316. (GoogleChromeMacPort):
  17317. (GoogleChromeMacPort.determine_port_name):
  17318. (GoogleChromeWinPort):
  17319. (GoogleChromeWinPort.determine_port_name):
  17320. * Scripts/webkitpy/layout_tests/port/gtk.py:
  17321. (GtkPort):
  17322. * Scripts/webkitpy/layout_tests/port/mac.py:
  17323. (MacPort):
  17324. (MacPort.determine_port_name):
  17325. (MacPort.__init__):
  17326. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  17327. (test_versions):
  17328. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  17329. (MockDRTPort):
  17330. (MockDRTPort.determine_port_name):
  17331. (MockDRTPort.__init__):
  17332. (MockDRT):
  17333. (MockDRT.determine_port_name):
  17334. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  17335. (PortTestCase.make_port):
  17336. * Scripts/webkitpy/layout_tests/port/qt.py:
  17337. (QtPort):
  17338. (QtPort.determine_port_name):
  17339. (QtPort.__init__):
  17340. * Scripts/webkitpy/layout_tests/port/test.py:
  17341. (TestPort):
  17342. (TestPort.determine_port_name):
  17343. (TestPort.__init__):
  17344. * Scripts/webkitpy/layout_tests/port/webkit.py:
  17345. (WebKitPort.__init__):
  17346. * Scripts/webkitpy/layout_tests/port/win.py:
  17347. (WinPort):
  17348. (WinPort.determine_port_name):
  17349. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  17350. (get_test_baselines.AllPlatformsPort.__init__):
  17351. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  17352. (get_test_config.TestMacPort):
  17353. (get_test_config):
  17354. 2012-01-17 Dirk Pranke <dpranke@chromium.org>
  17355. webkitpy: clean up port code in preparation for static port names
  17356. https://bugs.webkit.org/show_bug.cgi?id=76356
  17357. Reviewed by Adam Barth.
  17358. To fix bug 76215 and be able to determine appropriate port names
  17359. in webkitpy without actually constructing Port objects, we need
  17360. to shuffle some logic in the chromium ports to be able to figure
  17361. out whether we built DRT in 32 or 64-bit mode.
  17362. * Scripts/webkitpy/layout_tests/port/chromium.py:
  17363. (ChromiumPort):
  17364. (ChromiumPort._chromium_base_dir):
  17365. (ChromiumPort.__init__):
  17366. (ChromiumPort.path_from_chromium_base):
  17367. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  17368. (ChromiumLinuxPort):
  17369. (ChromiumLinuxPort._determine_driver_path_statically):
  17370. (ChromiumLinuxPort._static_build_path):
  17371. (ChromiumLinuxPort._determine_architecture):
  17372. (ChromiumLinuxPort.__init__):
  17373. (ChromiumLinuxPort._build_path):
  17374. 2012-01-17 Hao Zheng <zhenghao@chromium.org>
  17375. Do not remove pixel failures for ref tests.
  17376. https://bugs.webkit.org/show_bug.cgi?id=76243
  17377. Reviewed by Tony Chang.
  17378. 'NRWT --no-pixel-tests' complains when reftests are expected to
  17379. be image mismatch.
  17380. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  17381. (Manager._update_summary_with_result):
  17382. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  17383. (is_reftest_failure):
  17384. (determine_result_type):
  17385. 2012-01-17 Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu>
  17386. REGRESSION(r81225): ORWT should ignore reftests
  17387. https://bugs.webkit.org/show_bug.cgi?id=67936
  17388. Reviewed by Csaba Osztrogonác.
  17389. * Scripts/old-run-webkit-tests:
  17390. (isUsedInReftest): $filename should be the first parameter
  17391. (findTestsToRun): run test if it isn't reftest
  17392. 2012-01-17 Gustavo Noronha Silva <gns@gnome.org>
  17393. Unreviewed. Fix python unit test I broke with r105142
  17394. * Scripts/webkitpy/common/config/ports_unittest.py:
  17395. (WebKitPortTest.test_gtk_port):
  17396. 2012-01-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  17397. [Qt] Don't set the 'primary' flag when mocking touch-points in MiniBrowser
  17398. Qt 5 no longer has that flag.
  17399. Reviewed by Simon Hausmann.
  17400. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  17401. (MiniBrowserApplication::notify):
  17402. 2012-01-16 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
  17403. GTK+ EWS needs to run update-webkitgtk-libs after applying a patch
  17404. https://bugs.webkit.org/show_bug.cgi?id=75857
  17405. Reviewed by Adam Barth.
  17406. * Scripts/webkitdirs.pm:
  17407. (buildAutotoolsProject): move cleaning the build to happen early,
  17408. and handle --update-gtk right after that
  17409. * Scripts/webkitpy/common/config/ports.py:
  17410. (GtkPort.build_webkit_command): pass --update-gtk as an option to
  17411. build-webkit, so that it is used in the EWS
  17412. 2012-01-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  17413. [Qt] Don't add _debug postfix to targets when building debug only
  17414. Reviewed by Simon Hausmann.
  17415. * qmake/mkspecs/features/default_post.prf:
  17416. * qmake/mkspecs/features/functions.prf:
  17417. 2012-01-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  17418. [Qt] Add more files to project-files for easier navigation in Qt Creator
  17419. Reviewed by Simon Hausmann.
  17420. * Tools.pro:
  17421. * qmake/config.tests/README: Added.
  17422. 2012-01-17 Philippe Normand <pnormand@igalia.com>
  17423. [GTK] fast/dom/constructed-objects-prototypes.html fails
  17424. https://bugs.webkit.org/show_bug.cgi?id=75432
  17425. Reviewed by Martin Robinson.
  17426. * Scripts/build-webkit: Enable video-track in GTK.
  17427. 2012-01-16 Takashi Toyoshima <toyoshim@chromium.org>
  17428. Add toyoshim as a committer.
  17429. https://bugs.webkit.org/show_bug.cgi?id=76390
  17430. Reviewed by Hajime Morita.
  17431. * Scripts/webkitpy/common/config/committers.py:
  17432. 2012-01-16 Brent Fulgham <bfulgham@webkit.org>
  17433. [WinCairo] Build fix after r104155. Several debug targets were not
  17434. properly including the '*Common' property sheets.
  17435. * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops:
  17436. * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops:
  17437. * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops:
  17438. * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops:
  17439. * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops:
  17440. 2012-01-16 Csaba Osztrogonác <ossy@webkit.org>
  17441. REGRESSION(r105072): It broke committers_unittest.py
  17442. https://bugs.webkit.org/show_bug.cgi?id=76396
  17443. Reviewed by Adam Barth.
  17444. * Scripts/webkitpy/common/config/committers_unittest.py:
  17445. (CommittersTest._assert_fuzz_match): It should handle more names.
  17446. (CommittersTest.test_contributors_by_fuzzy_match_with_legacy_names): Fix the testcase.
  17447. 2012-01-16 Mario Sanchez Prada <msanchez@igalia.com>
  17448. [GTK] Include gtk+3 in the jhbuild modules
  17449. https://bugs.webkit.org/show_bug.cgi?id=76284
  17450. Reviewed by Philippe Normand.
  17451. * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
  17452. 2012-01-16 Dan Winship <danw@gnome.org>
  17453. Add myself as a committer
  17454. Unreviewed
  17455. * Scripts/webkitpy/common/config/committers.py:
  17456. 2012-01-16 Raphael Kubo da Costa <kubo@profusion.mobi>
  17457. Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.
  17458. Some recent versions of a few Linux distributions have started passing
  17459. --as-needed and --no-copy-dt-needed-entries by default to the linker,
  17460. which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
  17461. needed a few symbols from libjavascriptcore_efl.so.
  17462. * DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
  17463. before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
  17464. libraries are searched in the right order by the linker.
  17465. 2012-01-16 Philippe Normand <pnormand@igalia.com>
  17466. [GTK] set audio resources path in NRTW
  17467. https://bugs.webkit.org/show_bug.cgi?id=76380
  17468. Reviewed by Martin Robinson.
  17469. * Scripts/webkitpy/layout_tests/port/gtk.py:
  17470. (GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
  17471. the uninstalled audio resources are used during webaudio tests.
  17472. 2012-01-16 Carlos Garcia Campos <cgarcia@igalia.com>
  17473. [GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
  17474. https://bugs.webkit.org/show_bug.cgi?id=76369
  17475. Reviewed by Xan Lopez.
  17476. If there's an installed version of webkit and there are new
  17477. symbols in the build tree, gtkdoc-scanobj fails due to undefined
  17478. references, because the env ldflags are given before the local
  17479. ones.
  17480. * gtk/gtkdoc.py:
  17481. (GTKDoc._run_gtkdoc_scangobj):
  17482. 2012-01-15 Pablo Flouret <pablof@motorola.com>
  17483. Fix compilation errors on build-webkit --debug --no-video on mac.
  17484. https://bugs.webkit.org/show_bug.cgi?id=75867
  17485. Reviewed by Philippe Normand.
  17486. Add --[no-]video-track to build-webkit, since video track feature
  17487. depends on video.
  17488. * Scripts/build-webkit:
  17489. 2012-01-14 James Robinson <jamesr@chromium.org>
  17490. [chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
  17491. https://bugs.webkit.org/show_bug.cgi?id=76313
  17492. Reviewed by Adam Barth.
  17493. The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.
  17494. * Scripts/run-chromium-webkit-unit-tests:
  17495. 2012-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
  17496. Unreviewed, rolling out r105017.
  17497. http://trac.webkit.org/changeset/105017
  17498. https://bugs.webkit.org/show_bug.cgi?id=76333
  17499. broke the build (Requested by philn-tp on #webkit).
  17500. * gtk/jhbuild.modules:
  17501. 2012-01-14 Mario Sanchez Prada <msanchez@igalia.com>
  17502. [GTK] Include gtk+3 in the jhbuild modules
  17503. https://bugs.webkit.org/show_bug.cgi?id=76284
  17504. Reviewed by Philippe Normand.
  17505. * gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.
  17506. 2012-01-13 Adam Barth <abarth@webkit.org>
  17507. Remove --dry-run support from webkit-patch
  17508. https://bugs.webkit.org/show_bug.cgi?id=76300
  17509. Reviewed by Dirk Pranke.
  17510. This is the rest of the patch from Bug 76300. I landed it separtely
  17511. because main.py had some stray conflict markers that I needed to clean
  17512. up first.
  17513. * Scripts/webkitpy/test/main.py:
  17514. (Tester.parse_args):
  17515. (Tester._run_tests):
  17516. 2012-01-13 Adam Barth <abarth@webkit.org>
  17517. test-webkitpy does not run
  17518. https://bugs.webkit.org/show_bug.cgi?id=76318
  17519. Unreviewed.
  17520. Looks like some conflict markers got left in the file.
  17521. * Scripts/webkitpy/test/main.py:
  17522. (Tester.run):
  17523. 2012-01-13 Adam Barth <abarth@webkit.org>
  17524. Remove --dry-run support from webkit-patch
  17525. https://bugs.webkit.org/show_bug.cgi?id=76300
  17526. Reviewed by Dirk Pranke.
  17527. We don't use this functionality for anything, and it doesn't really
  17528. work. Someone in #webkit tried using it and and got sad/confused. We
  17529. should just remove it.
  17530. * Scripts/webkitpy/common/checkout/scm/git.py:
  17531. (Git.push_local_commits_to_server):
  17532. * Scripts/webkitpy/common/checkout/scm/scm.py:
  17533. (SCM.__init__):
  17534. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  17535. (_shared_test_commit_with_message):
  17536. (GitSVNTest.test_commit_text_parsing):
  17537. * Scripts/webkitpy/common/checkout/scm/svn.py:
  17538. (SVN.commit_with_message):
  17539. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  17540. (Bugzilla.__init__):
  17541. (Bugzilla.quips):
  17542. (Bugzilla.authenticate):
  17543. (Bugzilla.add_attachment_to_bug):
  17544. (Bugzilla.add_patch_to_bug):
  17545. (Bugzilla.create_bug):
  17546. (Bugzilla.clear_attachment_flags):
  17547. (Bugzilla.set_flag_on_attachment):
  17548. (Bugzilla.obsolete_attachment):
  17549. (Bugzilla.add_cc_to_bug):
  17550. (Bugzilla.post_comment_to_bug):
  17551. (Bugzilla.close_bug_as_fixed):
  17552. (Bugzilla.reassign_bug):
  17553. (reopen_bug):
  17554. * Scripts/webkitpy/test/main.py:
  17555. (Tester.parse_args):
  17556. (Tester.run_tests):
  17557. 2012-01-13 David Levin <levin@chromium.org>
  17558. check-webkit-style: should encourage the use of Own* classes for Windows DC.
  17559. https://bugs.webkit.org/show_bug.cgi?id=76227
  17560. Reviewed by Dirk Pranke.
  17561. * Scripts/webkitpy/style/checkers/cpp.py:
  17562. (check_for_leaky_patterns): The new check.
  17563. (process_line): Added a call to the new check.
  17564. (CppChecker): Added the new error type.
  17565. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  17566. (CppStyleTestBase):
  17567. (CppStyleTestBase.perform_leaky_pattern_check):
  17568. The check for only leaky pattern errors.
  17569. (LeakyPatternTest): Test cases.
  17570. 2012-01-13 Dirk Pranke <dpranke@chromium.org>
  17571. test-webkitpy: clean up handling of test directories, QueueStatusServer
  17572. https://bugs.webkit.org/show_bug.cgi?id=76238
  17573. Reviewed by Adam Barth.
  17574. This patch cleans up a bunch of hacks related to how we find all
  17575. of the python unit tests and set up the sys.path variable in
  17576. test-webkitpy.
  17577. This patch changes how test-webkitpy works slightly in that we
  17578. will now look for test files under Tools/Scripts and Source/WebKit2/Scripts
  17579. rather than just Tools/Scripts/webkitpy and Source/WebKit2/Scripts/webkit.
  17580. This greatly simplifies the mapping of paths to module names and
  17581. appears to have no significant performance impact or other drawbacks.
  17582. There are other ways that we could remove all of the hacks and
  17583. still have a more flexible mapping of paths to module names, but
  17584. the ones I've thought of so far add a decent amount of complexity to
  17585. the implementation and don't seem to buy us much.
  17586. * QueueStatusServer/__init__.py:
  17587. * Scripts/test-webkitpy:
  17588. * Scripts/webkitpy/test/main.py:
  17589. (Tester._modules_from_paths):
  17590. (Tester._is_module):
  17591. 2012-01-13 Dirk Pranke <dpranke@chromium.org>
  17592. test-webkitpy: should support classes and individual test names as well as modules
  17593. https://bugs.webkit.org/show_bug.cgi?id=76233
  17594. Reviewed by Adam Barth.
  17595. The default unittest.main() supports a list of individual
  17596. TestCase classes or individual tests as well as modules. This
  17597. change adds support for the same to test-webkitpy, so now you
  17598. can say
  17599. % test-wekbitpy webkitpy.test.cat_unittest.CatTest
  17600. and
  17601. % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic
  17602. in addition to
  17603. % test-wekbitpy webkitpy.test.cat_unittest
  17604. * Scripts/test-webkitpy:
  17605. * Scripts/webkitpy/test/cat_unittest.py:
  17606. * Scripts/webkitpy/test/main.py:
  17607. (Tester.parse_args):
  17608. (Tester.run):
  17609. (Tester):
  17610. (Tester._find_modules):
  17611. (Tester._exclude):
  17612. (Tester._run_tests):
  17613. (Tester._is_module):
  17614. (Tester._log_exception):
  17615. 2012-01-13 Dirk Pranke <dpranke@chromium.org>
  17616. test-webkitpy: add basic code coverage support
  17617. https://bugs.webkit.org/show_bug.cgi?id=76201
  17618. Reviewed by Adam Barth.
  17619. This test adds basic code coverage support to test-webkitpy; if
  17620. you pass the -c flag, we will generate a new coverage file. We
  17621. can start simply with this and add more features as necessary.
  17622. This patch requires coverage to be already installed on the
  17623. machine. I am not auto-installing this for now.
  17624. * Scripts/webkitpy/test/main.py:
  17625. (Tester.parse_args):
  17626. (Tester.run_tests):
  17627. 2012-01-13 Dirk Pranke <dpranke@chromium.org>
  17628. StatusBubbleTest.test_build_bubble is failing
  17629. https://bugs.webkit.org/show_bug.cgi?id=76222
  17630. Reviewed by Adam Barth.
  17631. * QueueStatusServer/handlers/statusbubble_unittest.py:
  17632. (StatusBubbleTest.test_build_bubble):
  17633. 2012-01-13 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  17634. nrwt should use multiple http shards
  17635. https://bugs.webkit.org/show_bug.cgi?id=75958
  17636. Add --max-locked-shards option to the nrwt for manual set
  17637. the maximum number of the locked shards
  17638. Reviewed by Dirk Pranke.
  17639. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  17640. (Manager._max_locked_shards):
  17641. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  17642. (ShardingTests.get_shards):
  17643. (ShardingTests.test_multiple_locked_shards):
  17644. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  17645. (parse_args):
  17646. 2012-01-13 Raphael Kubo da Costa <kubo@profusion.mobi>
  17647. prepare-ChangeLog: Look for a text editor in a few more variables.
  17648. https://bugs.webkit.org/show_bug.cgi?id=76289
  17649. Reviewed by Ryosuke Niwa.
  17650. A text editor was looked for only in the CHANGE_LOG_EDITOR and
  17651. CHANGE_LOG_EDIT_APPLICATION environment variables before falling back
  17652. to the OS X-specific open(1) command.
  17653. As there does not seem to be a common way of looking for a text editor
  17654. among the scripts in Tools/Scripts right now, just look at $VISUAL and
  17655. $EDITOR (set much more often than the other variables in Unix systems)
  17656. before falling back to open(1).
  17657. * Scripts/prepare-ChangeLog:
  17658. (openChangeLogs):
  17659. 2012-01-13 Gabor Rapcsanyi <rgabor@webkit.org>
  17660. [GTK] gtkdoc.py ignoring LDFLAGS and CFLAGS environment variables
  17661. https://bugs.webkit.org/show_bug.cgi?id=76269
  17662. Reviewed by Martin Robinson.
  17663. * gtk/gtkdoc.py:
  17664. (GTKDoc._run_gtkdoc_scangobj):
  17665. 2012-01-13 Csaba Osztrogonác <ossy@webkit.org>
  17666. [Qt][WK2]REGRESSION(r104881):It broke hundreds of tests
  17667. https://bugs.webkit.org/show_bug.cgi?id=76247
  17668. Reviewed by Kenneth Rohde Christiansen.
  17669. * WebKitTestRunner/TestController.cpp:
  17670. (WTR::TestController::resetStateToConsistentValues): Disable mock scrollbars on Qt by default. (workaround)
  17671. 2012-01-13 Hajime Morrita <morrita@chromium.org>
  17672. [Mac][DRT] Should support --no-timeout
  17673. https://bugs.webkit.org/show_bug.cgi?id=76242
  17674. Reviewed by Darin Adler.
  17675. * DumpRenderTree/mac/DumpRenderTree.mm:
  17676. (initializeGlobalsFromCommandLineOptions): Added "--no-timeout" to the options list.
  17677. (setWaitToDumpWatchdog): Added to encapsulate the waitToDumpWatchdog global variable.
  17678. (shouldSetWaitToDumpWatchdog): Added to check the useTimeoutWatchdog flag set by the option.
  17679. * DumpRenderTree/mac/DumpRenderTreeMac.h:
  17680. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  17681. (LayoutTestController::setWaitToDump): Now calls shouldSetWaitToDumpWatchdog() to check the flag.
  17682. 2012-01-12 Simon Fraser <simon.fraser@apple.com>
  17683. Mitigate scrollbar differences when running pixel tests
  17684. https://bugs.webkit.org/show_bug.cgi?id=67217
  17685. Reviewed by Dan Bernstein.
  17686. Enable mock scrollbars by default for tests.
  17687. * DumpRenderTree/mac/DumpRenderTree.mm:
  17688. (resetDefaultsToConsistentValues):
  17689. * WebKitTestRunner/TestController.cpp:
  17690. (WTR::TestController::resetStateToConsistentValues):
  17691. 2012-01-12 Ryosuke Niwa <rniwa@webkit.org>
  17692. Need a script to run tests in PerformanceTests
  17693. https://bugs.webkit.org/show_bug.cgi?id=76132
  17694. Reviewed by Adam Barth.
  17695. Add run-perf-tests to run performance tests using parser/resources/runner.js.
  17696. Unfortunately, there isn't an easy way of telling which test uses which format
  17697. so hard-code directory that uses Chromium perf-bot style (only inspector perf. tests for now).
  17698. All test outputs are re-formatted to match Chromium perf-bot style.
  17699. * Scripts/run-inspector-perf-tests.py:
  17700. * Scripts/run-perf-tests: Added.
  17701. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  17702. (PerfTestsRunner):
  17703. (PerfTestsRunner.__init__):
  17704. (PerfTestsRunner._collect_tests):
  17705. (PerfTestsRunner.run):
  17706. (PerfTestsRunner._print_status):
  17707. (PerfTestsRunner._run_tests_set):
  17708. (PerfTestsRunner._process_chromium_style_test_result):
  17709. (PerfTestsRunner._should_ignore_line_in_parser_test_result):
  17710. (PerfTestsRunner._process_parser_test_result):
  17711. (PerfTestsRunner._run_single_test):
  17712. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
  17713. (MainTest.TestDriver.run_test):
  17714. (create_runner):
  17715. (run_test):
  17716. (test_run_test_set):
  17717. (test_run_test_set_for_parser_tests):
  17718. (test_collect_tests):
  17719. 2012-01-12 Dirk Pranke <dpranke@chromium.org>
  17720. webkitpy: clean up port unit tests in preparation for making port_name mandatory
  17721. https://bugs.webkit.org/show_bug.cgi?id=76123
  17722. Reviewed by Adam Barth.
  17723. This change updates the unit tests to be more consistent in how
  17724. ports are created, in preparation for making port_name a
  17725. mandatory parameter to the constructor and removing any version
  17726. interpretation from it.
  17727. There should be no functional changes in this patch, but some
  17728. tests that are no longer relevant have been removed or reworked.
  17729. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  17730. (PortTest.test_get_option__default):
  17731. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  17732. (ChromiumLinuxPortTest):
  17733. (ChromiumLinuxPortTest.assert_architecture):
  17734. (ChromiumLinuxPortTest.test_determine_architecture_fails):
  17735. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  17736. (ChromiumMacPortTest):
  17737. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  17738. (ChromiumPortTest):
  17739. (ChromiumPortTest.test_all_test_configurations):
  17740. (ChromiumPortTest.TestMacPort.__init__):
  17741. (ChromiumPortTest.TestLinuxPort.__init__):
  17742. (ChromiumPortTest.TestWinPort.__init__):
  17743. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  17744. (ChromiumWinTest):
  17745. * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
  17746. (EflPortTest):
  17747. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  17748. (GtkPortTest):
  17749. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  17750. (MacTest):
  17751. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  17752. (MockDRTPortTest):
  17753. (MockDRTPortTest.make_port):
  17754. * Scripts/webkitpy/layout_tests/port/qt.py:
  17755. (QtPort._port_flag_for_scripts):
  17756. (QtPort.__init__):
  17757. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  17758. (QtPortTest):
  17759. (QtPortTest._assert_search_path):
  17760. (QtPortTest.test_baseline_search_path):
  17761. (QtPortTest.test_operating_system):
  17762. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  17763. (WebKitPortTest):
  17764. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  17765. (WinPortTest):
  17766. (WinPortTest._assert_search_path):
  17767. (WinPortTest.test_baseline_search_path):
  17768. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  17769. (get_test_config.TestMacPort.__init__):
  17770. 2012-01-12 Dirk Pranke <dpranke@chromium.org>
  17771. test-webkitpy: clean up logging and provide a real --help message
  17772. https://bugs.webkit.org/show_bug.cgi?id=76142
  17773. Reviewed by Adam Barth.
  17774. This test is mostly more refactoring - it calls objects in
  17775. unittest directly instead of routing through unittest.main() --
  17776. in order to gain more control over the logging and to provide a
  17777. correct --help message. This will also give us a better
  17778. foundation for adding more feautures down the road.
  17779. This patch adds different levels of logging controlled by the
  17780. '-s', '-q', and '-v' options (see --help for details), and
  17781. removes the --verbose-logging option.
  17782. * Scripts/test-webkitpy:
  17783. * Scripts/webkitpy/test/main.py:
  17784. (Tester):
  17785. (Tester.clean_packages):
  17786. (Tester.__init__):
  17787. (Tester.parse_args):
  17788. (Tester.configure):
  17789. (Tester._configure_logging):
  17790. (Tester.find_modules):
  17791. (Tester._exclude):
  17792. (Tester._modules_from_paths):
  17793. (Tester.run_tests):
  17794. 2012-01-12 Simon Hausmann <simon.hausmann@nokia.com>
  17795. Make the new WTF module build on Qt
  17796. https://bugs.webkit.org/show_bug.cgi?id=76163
  17797. Reviewed by Tor Arne Vestbø.
  17798. * qmake/mkspecs/modules/wtf.prf: Pull in WTF from the new location.
  17799. 2012-01-12 Vsevolod Vlasov <vsevik@chromium.org>
  17800. Unreviewed, mac DumpRenderTree fix.
  17801. * DumpRenderTree/mac/UIDelegate.mm:
  17802. (-[UIDelegate webView:addMessageToConsole:withSource:]):
  17803. 2012-01-12 Vsevolod Vlasov <vsevik@chromium.org>
  17804. WebKitTestRunner should not print console message line number when it is equal to zero.
  17805. https://bugs.webkit.org/show_bug.cgi?id=76167
  17806. Reviewed by Csaba Osztrogonác.
  17807. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  17808. (WTR::InjectedBundlePage::willAddMessageToConsole):
  17809. 2012-01-11 Vsevolod Vlasov <vsevik@chromium.org>
  17810. Make default console messages line numbers consistent.
  17811. https://bugs.webkit.org/show_bug.cgi?id=74075
  17812. Reviewed by Pavel Feldman.
  17813. Unset line numbers are not printed to console now.
  17814. Added Source/WebCore/inspector to efl DumpRenderTree include path.
  17815. * DumpRenderTree/chromium/WebViewHost.cpp:
  17816. (WebViewHost::didAddMessageToConsole):
  17817. * DumpRenderTree/efl/CMakeLists.txt:
  17818. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  17819. (onConsoleMessage):
  17820. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  17821. (webViewConsoleMessage):
  17822. * DumpRenderTree/mac/UIDelegate.mm:
  17823. (-[UIDelegate webView:addMessageToConsole:withSource:]):
  17824. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  17825. (WebCore::WebPage::javaScriptConsoleMessage):
  17826. * DumpRenderTree/win/UIDelegate.cpp:
  17827. (UIDelegate::webViewAddMessageToConsole):
  17828. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  17829. (LayoutWebViewEventHandler::OnConsoleMessageEvent):
  17830. 2012-01-10 Dirk Pranke <dpranke@chromium.org>
  17831. test-webkitpy: push more logic into webkitpy.test.main, clean up code
  17832. https://bugs.webkit.org/show_bug.cgi?id=76021
  17833. Reviewed by Eric Seidel.
  17834. I plan to add more functionality to test-webkitpy, but it is
  17835. difficult to hack on now; this patch is the first of two that
  17836. brings test-webkitpy more inline with current coding style by
  17837. pushing more logic into the webkitpy.test.main.Tester class (so
  17838. that it will be testable itself).
  17839. There should be no functional changes in this patch.
  17840. * Scripts/test-webkitpy:
  17841. (_path_from_webkit_root):
  17842. * Scripts/webkitpy/test/main.py:
  17843. (Tester):
  17844. (Tester.init):
  17845. (Tester.configure_logging):
  17846. (Tester.configure_logging.filter):
  17847. (Tester.clean_packages):
  17848. (Tester.run_tests):
  17849. 2012-01-11 Wei Jia <wjia@chromium.org>
  17850. implement layout tests for <video> with media stream
  17851. https://bugs.webkit.org/show_bug.cgi?id=74882
  17852. Reviewed by Kent Tamura.
  17853. * DumpRenderTree/DumpRenderTree.gypi:
  17854. * DumpRenderTree/chromium/WebUserMediaClientMock.cpp: Added.
  17855. (WebKit::WebUserMediaClientMock::create):
  17856. (WebKit::WebUserMediaClientMock::IsMockStream):
  17857. (WebKit::WebUserMediaClientMock::requestUserMedia):
  17858. (WebKit::WebUserMediaClientMock::cancelUserMediaRequest):
  17859. * DumpRenderTree/chromium/WebUserMediaClientMock.h: Added.
  17860. (WebKit::WebUserMediaClientMock::~WebUserMediaClientMock):
  17861. (WebKit::WebUserMediaClientMock::WebUserMediaClientMock):
  17862. * DumpRenderTree/chromium/WebViewHost.cpp:
  17863. (WebViewHost::userMediaClient):
  17864. (WebViewHost::userMediaClientMock):
  17865. (WebViewHost::createMediaPlayer):
  17866. (WebViewHost::mediaStreamUtil):
  17867. (WebViewHost::testMediaStreamClient):
  17868. * DumpRenderTree/chromium/WebViewHost.h:
  17869. 2012-01-11 Dirk Pranke <dpranke@chromium.org>
  17870. Unreviewed, build fix.
  17871. Fix chromium-win's version remapping to work correctly on Win 7 SP1.
  17872. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  17873. (ChromiumWinPort.__init__):
  17874. 2012-01-11 Ryosuke Niwa <rniwa@webkit.org>
  17875. Sheriffbot build fix. Don't emit empty lines on IRC.
  17876. * Scripts/webkitpy/tool/bot/irc_command.py:
  17877. (LastGreenRevision.execute):
  17878. 2012-01-11 Ryosuke Niwa <rniwa@webkit.org>
  17879. last-green-revision should report the revision that succeeded on all bots
  17880. https://bugs.webkit.org/show_bug.cgi?id=76109
  17881. Reviewed by Adam Barth.
  17882. Add an algorithm to find the last known good revision among the specified bots. For a revision to be
  17883. considered green by this algorithm, all matching builders must have a successful run at the revision
  17884. or two consecutive successful runs before and after the revision.
  17885. Also fixed a bug in irc_command that the result wasn't posted on IRC properly and a bug in queries.py
  17886. that resulted in an exception when the user didn't pass BUILDER_NAME argument.
  17887. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  17888. (BuildBot._revisions_for_builder):
  17889. (BuildBot):
  17890. (BuildBot._find_green_revision):
  17891. (BuildBot.last_green_revision):
  17892. * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
  17893. (MockBuildBot.last_green_revision):
  17894. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  17895. (test_revisions_for_builder):
  17896. (test_find_green_revision):
  17897. (test_last_green_revision):
  17898. * Scripts/webkitpy/tool/bot/irc_command.py:
  17899. (LastGreenRevision.execute):
  17900. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  17901. (SheriffIRCBotTest.test_lgr):
  17902. * Scripts/webkitpy/tool/commands/queries.py:
  17903. (LastGreenRevision):
  17904. 2012-01-11 Dirk Pranke <dpranke@chromium.org>
  17905. Unreviewed, fix build bustage on win32 introduced by r104725.
  17906. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  17907. (MockDRTPortTest.make_port):
  17908. (MockChromiumDRTTest.test_pixeltest__fails):
  17909. 2012-01-11 Jochen Eisinger <jochen@chromium.org>
  17910. [Chromium] mimic the (old) behavior of the mac port for (re)setting the color profile
  17911. https://bugs.webkit.org/show_bug.cgi?id=75618
  17912. Eventually, we should get away from setting the display's color profile, as the mac port is doing now.
  17913. Reviewed by Tony Chang.
  17914. * DumpRenderTree/chromium/LayoutTestHelper.mm:
  17915. (installLayoutTestColorProfile):
  17916. (restoreUserColorProfile):
  17917. (main):
  17918. 2012-01-11 Dirk Pranke <dpranke@chromium.org>
  17919. test-webkitpy: fix -v and eliminate some spurious warnings
  17920. https://bugs.webkit.org/show_bug.cgi?id=76099
  17921. Reviewed by Adam Barth.
  17922. when we added support for --xml output, we broke the -v flag.
  17923. Also, fix the code to swallow a harmless warning from
  17924. VCSUtils.pm and fix a deprecated warning in jsonchecker.py.
  17925. test-webkitpy is now silent again except for the one known
  17926. logging issue.
  17927. * Scripts/webkitpy/common/checkout/checkout.py:
  17928. (Checkout.commit_message_for_this_commit):
  17929. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  17930. (test_commit_message_for_this_commit):
  17931. * Scripts/webkitpy/style/checkers/jsonchecker.py:
  17932. (JSONChecker.check):
  17933. (JSONChecker.line_number_from_json_exception):
  17934. * Scripts/webkitpy/test/main.py:
  17935. (Tester.run_tests):
  17936. 2012-01-11 Dirk Pranke <dpranke@chromium.org>
  17937. webkitpy: webkitpy.layout_tests.port tests should only use MockSystemHost, not MockHost
  17938. https://bugs.webkit.org/show_bug.cgi?id=76084
  17939. Reviewed by Adam Barth.
  17940. This will help make it easier to catch layering violations. This
  17941. change just refactors test code; there are no changes to
  17942. production code.
  17943. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  17944. (PortTest.make_port):
  17945. (PortTest.test_find_no_paths_specified):
  17946. (PortTest.test_find_one_test):
  17947. (PortTest.test_find_glob):
  17948. (PortTest.test_find_with_skipped_directories):
  17949. (PortTest.test_find_with_skipped_directories_2):
  17950. (PortTest.test_parse_reftest_list):
  17951. (PortTest.test_httpd_returns_error_code):
  17952. (PortTest.test_virtual_methods):
  17953. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  17954. (ChromiumGpuTest.assert_port_works):
  17955. (ChromiumGpuTest._assert_baseline_path):
  17956. (ChromiumGpuTest.test_graphics_type):
  17957. (ChromiumGpuTest.test_default_tests_paths.test_paths):
  17958. (ChromiumGpuTest.test_test_files):
  17959. (ChromiumGpuTest.test_test_files.test_paths):
  17960. (ChromiumGpuTest):
  17961. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  17962. (ChromiumLinuxPortTest.assert_architecture):
  17963. (ChromiumLinuxPortTest.test_check_illegal_port_names):
  17964. (ChromiumLinuxPortTest.test_determine_architecture_fails):
  17965. * Scripts/webkitpy/layout_tests/port/driver_unittest.py:
  17966. (DriverTest.make_port):
  17967. (DriverTest):
  17968. (DriverTest.assertVirtual):
  17969. (DriverTest._assert_wrapper):
  17970. (DriverTest.test_virtual_driver_methods):
  17971. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  17972. (MockDRTPortTest.make_port):
  17973. (MockDRTPortTest.test_port_name_in_constructor):
  17974. (MockDRTTest.assertTest):
  17975. (MockDRTTest.test_main):
  17976. (MockChromiumDRTTest.test_pixeltest__fails):
  17977. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  17978. (QtPortTest._assert_search_path):
  17979. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  17980. (TestWebKitPort.__init__):
  17981. (WebKitPortUnitTests.test_default_options):
  17982. (test_runtime_feature_list):
  17983. (test_test_expectations):
  17984. 2012-01-11 Ojan Vafai <ojan@chromium.org>
  17985. Style skipped tests in the flakiness dashboard
  17986. https://bugs.webkit.org/show_bug.cgi?id=76091
  17987. Reviewed by Tony Chang.
  17988. * TestResultServer/static-dashboards/dashboard_base.js:
  17989. Removed "FLAKY" from this list since we don't ever mark individual runs
  17990. as flaky. Also deleted an outdated line.
  17991. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  17992. 2012-01-11 Ojan Vafai <ojan@chromium.org>
  17993. Remove gtest normalization code from the test results server
  17994. https://bugs.webkit.org/show_bug.cgi?id=76089
  17995. Reviewed by Tony Chang.
  17996. The normalization now happens on the gtest side.
  17997. * TestResultServer/model/jsonresults.py:
  17998. (JsonResults.merge):
  17999. * TestResultServer/model/jsonresults_unittest.py:
  18000. (JsonResultsTest.test_gtest):
  18001. 2012-01-11 Ojan Vafai <ojan@chromium.org>
  18002. Be more aggressive about deleting unnecessary results from the test-results-server json files
  18003. https://bugs.webkit.org/show_bug.cgi?id=76086
  18004. Reviewed by Tony Chang.
  18005. Remove any tests that only contain skip/pass/nodata values whose runtime
  18006. is less than 5 seconds.
  18007. * TestResultServer/model/jsonresults.py:
  18008. (JsonResults._normalize_results_json):
  18009. * TestResultServer/model/jsonresults_unittest.py:
  18010. (JsonResultsTest.test_merge_remove_test):
  18011. (JsonResultsTest.test_merge_keep_test_with_all_pass_but_slow_time):
  18012. 2012-01-11 Ryosuke Niwa <rniwa@webkit.org>
  18013. last-green-revision should give us per-bot information
  18014. https://bugs.webkit.org/show_bug.cgi?id=76011
  18015. Reviewed by Adam Barth.
  18016. Rewrote last-green-revision command. Instead of finding a revision for which all bots succeeded,
  18017. we report the latest green run on each bot from the last 100 runs.
  18018. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  18019. (BuildBot._fetch_builder_page):
  18020. (BuildBot):
  18021. (BuildBot._green_revision_for_builder):
  18022. (BuildBot.last_green_revision):
  18023. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  18024. (test_green_revision_for_builder):
  18025. (test_last_green_revision):
  18026. * Scripts/webkitpy/tool/bot/irc_command.py:
  18027. (LastGreenRevision.execute):
  18028. * Scripts/webkitpy/tool/commands/queries.py:
  18029. (LastGreenRevision.execute):
  18030. 2012-01-11 Dirk Pranke <dpranke@chromium.org>
  18031. webkitpy: clean up version detection in webkitpy.layout_tests.port
  18032. https://bugs.webkit.org/show_bug.cgi?id=76016
  18033. Reviewed by Adam Barth.
  18034. This change updates the code in webkitpy.layout_tests.port to
  18035. use the new os_name and os_version fields on host.platform. This
  18036. gets layout_tests.port out of the version parsing business. Most
  18037. of the diffs are just cleaning up test code to accomodate the
  18038. changes.
  18039. * Scripts/webkitpy/common/system/executive_mock.py:
  18040. (MockExecutive):
  18041. (MockExecutive.ignore_error):
  18042. (MockExecutive2):
  18043. (MockExecutive2.ignore_error):
  18044. * Scripts/webkitpy/common/system/platforminfo_mock.py:
  18045. (MockPlatformInfo.is_mac):
  18046. (MockPlatformInfo.is_linux):
  18047. (MockPlatformInfo.is_win):
  18048. * Scripts/webkitpy/common/system/systemhost_mock.py:
  18049. (MockSystemHost.__init__):
  18050. * Scripts/webkitpy/layout_tests/port/apple.py:
  18051. (ApplePort.__init__):
  18052. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  18053. (ChromiumMacPort.__init__):
  18054. (ChromiumMacPort.check_wdiff):
  18055. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  18056. (ChromiumMacPortTest):
  18057. (ChromiumMacPortTest.assert_name):
  18058. (ChromiumMacPortTest.test_versions):
  18059. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  18060. (ChromiumPortTest.test_all_test_configurations):
  18061. (ChromiumPortTest.TestMacPort.__init__):
  18062. (ChromiumPortTest.TestLinuxPort.__init__):
  18063. (ChromiumPortTest.TestWinPort.__init__):
  18064. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  18065. (ChromiumWinPort.__init__):
  18066. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  18067. (ChromiumWinTest):
  18068. (ChromiumWinTest.assert_name):
  18069. (ChromiumWinTest.test_versions):
  18070. (ChromiumWinTest.test_baseline_path):
  18071. (ChromiumWinTest.test_build_path):
  18072. * Scripts/webkitpy/layout_tests/port/factory.py:
  18073. (PortFactory._port_name_from_arguments_and_options):
  18074. (PortFactory.get):
  18075. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  18076. (FactoryTest):
  18077. (FactoryTest.setUp):
  18078. (FactoryTest.assert_port):
  18079. (FactoryTest.test_mac):
  18080. (FactoryTest.test_win):
  18081. (FactoryTest.test_google_chrome):
  18082. (FactoryTest.test_gtk):
  18083. (FactoryTest.test_qt):
  18084. (FactoryTest.test_chromium_gpu):
  18085. (FactoryTest.test_chromium_gpu_linux):
  18086. (FactoryTest.test_chromium_gpu_mac):
  18087. (FactoryTest.test_chromium_gpu_win):
  18088. (FactoryTest.test_chromium_mac):
  18089. (FactoryTest.test_chromium_linux):
  18090. (FactoryTest.test_chromium_win):
  18091. (FactoryTest.test_unknown_specified):
  18092. (FactoryTest.test_unknown_default):
  18093. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  18094. (TestGoogleChromePort):
  18095. (TestGoogleChromePort._verify_baseline_path):
  18096. (TestGoogleChromePort._verify_expectations_overrides):
  18097. (TestGoogleChromePort.test_get_google_chrome_port):
  18098. * Scripts/webkitpy/layout_tests/port/mac.py:
  18099. (MacPort):
  18100. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  18101. (MacTest):
  18102. (assert_name):
  18103. (test_tests_for_other_platforms):
  18104. (test_version):
  18105. (test_versions):
  18106. (test_is_version_methods):
  18107. (test_setup_environ_for_server):
  18108. (_assert_search_path):
  18109. (test_show_results_html_file):
  18110. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  18111. (PortTestCase):
  18112. (PortTestCase.make_port):
  18113. * Scripts/webkitpy/layout_tests/port/win.py:
  18114. (WinPort):
  18115. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  18116. (WinPortTest):
  18117. (WinPortTest.test_show_results_html_file):
  18118. (WinPortTest._assert_search_path):
  18119. (WinPortTest._assert_version):
  18120. 2012-01-11 Hugo Parente Lima <hugo.lima@openbossa.org>
  18121. [Qt][WK2] Remove workaround introduced into bug 75470
  18122. https://bugs.webkit.org/show_bug.cgi?id=75889
  18123. Reviewed by Tor Arne Vestbø.
  18124. * MiniBrowser/qt/qml/BrowserWindow.qml:
  18125. 2012-01-10 Dmitry Lomov <dslomov@google.com>
  18126. [Chromium] Remove obsolete references to WebWorker class.
  18127. https://bugs.webkit.org/show_bug.cgi?id=76020
  18128. Reviewed by David Levin.
  18129. * DumpRenderTree/chromium/TestWebWorker.h: Removed.
  18130. * DumpRenderTree/chromium/WebViewHost.cpp:
  18131. * DumpRenderTree/chromium/WebViewHost.h:
  18132. 2012-01-11 Csaba Osztrogonác <ossy@webkit.org>
  18133. [Qt] Some css3 filter tests are failing after r104698
  18134. https://bugs.webkit.org/show_bug.cgi?id=76055
  18135. Reviewed by Simon Hausmann.
  18136. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  18137. (LayoutTestController::overridePreference): Add WebKitAcceleratedCompositingEnabled preference.
  18138. 2012-01-11 Tony Chang <tony@chromium.org>
  18139. Don't remove 0 byte files when running build-webkit --chromium
  18140. https://bugs.webkit.org/show_bug.cgi?id=75997
  18141. Reviewed by Csaba Osztrogonác.
  18142. If QTDIR is set, isQt() is true even when running build-webkit --chromium.
  18143. * Scripts/webkitdirs.pm:
  18144. (determineIsQt):
  18145. 2012-01-10 David Kilzer <ddkilzer@apple.com>
  18146. Add TestWebKitAPI tests for KURL
  18147. <http://webkit.org/b/75774>
  18148. Reviewed by Adam Barth.
  18149. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add a
  18150. WebCore folder and KURL.cpp source file to the project.
  18151. * TestWebKitAPI/Tests/WebCore/KURL.cpp: Added.
  18152. (TestWebKitAPI::WebCore::SetUp): Initialize the main thread
  18153. during setup since this test doesn't go through WebKit or
  18154. WebKit2.
  18155. (TestWebKitAPI::TEST_F): Add two basic tests.
  18156. 2012-01-10 David Kilzer <ddkilzer@apple.com>
  18157. Extract common code for comparing WTF::String objects into WTFStringUtilities.h
  18158. Reviewed by Adam Barth.
  18159. Needed for: <http://webkit.org/b/75774> Add TestWebKitAPI tests for KURL
  18160. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add
  18161. WTFStringUtilities.h to the project.
  18162. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Update to use
  18163. WTFStringUtilities.h.
  18164. * TestWebKitAPI/WTFStringUtilities.h: Added.
  18165. (WTF::operator<<):
  18166. 2012-01-10 Vincent Scheib <scheib@chromium.org>
  18167. Clarify run-webkit-tests options reset-results and new-baseline
  18168. https://bugs.webkit.org/show_bug.cgi?id=75993
  18169. Reviewed by Dirk Pranke.
  18170. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  18171. (parse_args):
  18172. 2012-01-10 Simon Fraser <simon.fraser@apple.com>
  18173. Disabled mock scrollbars should draw differently
  18174. https://bugs.webkit.org/show_bug.cgi?id=75995
  18175. Reviewed by James Robinson.
  18176. When the scrollbar is disabled, paint the entire track of
  18177. mock scrollbars with a lighter gray, and hide the thumb.
  18178. * DumpRenderTree/mac/DumpRenderTree.mm:
  18179. (-[DRTMockScroller drawKnob]):
  18180. (-[DRTMockScroller drawRect:]):
  18181. 2012-01-10 James Robinson <jamesr@chromium.org>
  18182. [chromium] Run webkit_unit_tests as part of webkit-patch build-and-test
  18183. https://bugs.webkit.org/show_bug.cgi?id=75988
  18184. Reviewed by Adam Barth.
  18185. * Scripts/webkitpy/common/config/ports.py:
  18186. (WebKitPort.run_webkit_unit_tests_command):
  18187. (WebKitPort):
  18188. (ChromiumPort.run_webkit_unit_tests_command):
  18189. (ChromiumPort):
  18190. * Scripts/webkitpy/common/config/ports_mock.py:
  18191. (MockPort.run_webkit_unit_tests_command):
  18192. * Scripts/webkitpy/tool/commands/download_unittest.py:
  18193. (DownloadCommandsTest.test_build_and_test):
  18194. (test_land):
  18195. (test_land_red_builders):
  18196. * Scripts/webkitpy/tool/steps/runtests.py:
  18197. (RunTests.run):
  18198. * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  18199. 2012-01-09 Dirk Pranke <dpranke@chromium.org>
  18200. webkitpy: add os_name, os_version to platforminfo
  18201. https://bugs.webkit.org/show_bug.cgi?id=75931
  18202. Reviewed by Eric Siedel.
  18203. As a first step in cleaning up the version parsing logic in
  18204. webkitpy.layout_tests.port, this adds common routines for
  18205. getting the os_name and os_version fields to the PlatformInfo
  18206. class. Nothing uses them yet but I've added FIXME's to some of
  18207. the code that needs to be deleted in the port files.
  18208. * Scripts/webkitpy/common/system/platforminfo.py:
  18209. (PlatformInfo.__init__):
  18210. (PlatformInfo):
  18211. (PlatformInfo._determine_os_name):
  18212. (PlatformInfo._determine_mac_version):
  18213. (PlatformInfo._determine_linux_version):
  18214. (PlatformInfo._determine_win_version):
  18215. (PlatformInfo.display_name):
  18216. (PlatformInfo.total_bytes_memory):
  18217. (PlatformInfo._compute_bytes_from_vm_stat_output):
  18218. (PlatformInfo.free_bytes_memory):
  18219. * Scripts/webkitpy/common/system/platforminfo_unittest.py: Added.
  18220. (TestPlatformInfo):
  18221. (TestPlatformInfo.make_info):
  18222. (TestPlatformInfo.make_info.mock_run_command):
  18223. (TestPlatformInfo.setUp):
  18224. (TestPlatformInfo.tearDown):
  18225. (TestPlatformInfo.test_basic):
  18226. (TestPlatformInfo.integration_test_basic):
  18227. (TestPlatformInfo.test_display_name_mac):
  18228. (TestPlatformInfo.test_display_name_win32):
  18229. (TestPlatformInfo.test_memory_mac):
  18230. (TestPlatformInfo.test_memory_win32):
  18231. (TestPlatformInfo.test_determine_os_name):
  18232. (TestPlatformInfo.test_determine_mac_version):
  18233. (TestPlatformInfo.test_determine_linux_version):
  18234. (TestPlatformInfo.test_determine_win_version_from_tuple):
  18235. (TestPlatformInfo.test_determine_win_version_from_cmd):
  18236. * Scripts/webkitpy/layout_tests/port/apple.py:
  18237. (ApplePort.__init__):
  18238. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  18239. (ChromiumMacPort.__init__):
  18240. * Scripts/webkitpy/layout_tests/port/mac.py:
  18241. (MacPort):
  18242. * Scripts/webkitpy/layout_tests/port/win.py:
  18243. (WinPort):
  18244. 2012-01-10 Adam Roben <aroben@apple.com>
  18245. Make it possible to type data: URLs into MiniBrowser on Windows
  18246. Fixes <http://webkit.org/b/75084> Crash when trying to navigate to a data: URL in
  18247. MiniBrowser on Windows
  18248. Reviewed by Darin Adler.
  18249. * MiniBrowser/win/BrowserWindow.cpp:
  18250. (BrowserWindow::handleMessage): Instead of checking for an "http://" prefix when deciding
  18251. whether to prepend "http://", just look for whether the typed URL contains a colon. If it
  18252. does, we assume it already has a scheme and don't modify it.
  18253. 2012-01-10 Adam Roben <aroben@apple.com>
  18254. Make MiniBrowser automatically escape invalid URL characters typed in its URL field
  18255. Fixes <http://webkit.org/b/75086> Crash when typing a data: URL containing double-quotes in
  18256. MiniBrowser on Windows
  18257. Reviewed by Darin Adler.
  18258. * MiniBrowser/win/BrowserView.cpp:
  18259. (BrowserView::goToURL): Pass the typed string through
  18260. CFURLCreateStringByAddingPercentEscapes before trying to create a URL from it.
  18261. 2012-01-10 Ben Wells <benwells@chromium.org>
  18262. Adding myself (benwells) to committers.py
  18263. https://bugs.webkit.org/show_bug.cgi?id=75971
  18264. Reviewed by Ojan Vafai.
  18265. * Scripts/webkitpy/common/config/committers.py:
  18266. 2012-01-10 Mario Sanchez Prada <msanchez@igalia.com>
  18267. AX: support helpText() in DumpRenderTree
  18268. https://bugs.webkit.org/show_bug.cgi?id=40193
  18269. Reviewed by Chris Fleizach.
  18270. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  18271. (AccessibilityUIElement::helpText): Implemented.
  18272. 2012-01-10 Sheriff Bot <webkit.review.bot@gmail.com>
  18273. Unreviewed, rolling out r104572.
  18274. http://trac.webkit.org/changeset/104572
  18275. https://bugs.webkit.org/show_bug.cgi?id=75967
  18276. It broke zillion tests (Requested by Ossy on #webkit).
  18277. * DumpRenderTree/qt/EventSenderQt.cpp:
  18278. (EventSender::EventSender):
  18279. (EventSender::sendOrQueueEvent):
  18280. (EventSender::replaySavedEvents):
  18281. (EventSender::eventFilter):
  18282. * DumpRenderTree/qt/EventSenderQt.h:
  18283. 2012-01-10 Hugo Parente Lima <hugo.lima@openbossa.org>
  18284. [Qt] fast/events/dont-loose-last-event test fails on WK1
  18285. https://bugs.webkit.org/show_bug.cgi?id=73894
  18286. Reviewed by Simon Hausmann.
  18287. Empty the entire event queue when requested besides using
  18288. sendEvent instead of postEvent to make sure all events were
  18289. delivered.
  18290. This commit also removes not working DRT code to handle drag and drop,
  18291. for more refs see: https://bugs.webkit.org/show_bug.cgi?id=31332
  18292. * DumpRenderTree/qt/EventSenderQt.cpp:
  18293. (EventSender::EventSender):
  18294. (EventSender::sendOrQueueEvent):
  18295. (EventSender::replaySavedEvents):
  18296. * DumpRenderTree/qt/EventSenderQt.h:
  18297. 2012-01-10 No'am Rosenthal <noam.rosenthal@nokia.com>
  18298. [Qt] Enable CSS_FILTERS in Qt build
  18299. https://bugs.webkit.org/show_bug.cgi?id=75777
  18300. Add the CSS_FILTERS feature flag to Qt.
  18301. Reviewed by Kenneth Rohde Christiansen.
  18302. * qmake/mkspecs/features/features.prf:
  18303. 2012-01-10 Simon Hausmann <simon.hausmann@nokia.com>
  18304. [Qt] Unreviewed -Werror build fix.
  18305. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  18306. (MiniBrowserApplication::MiniBrowserApplication): Re-order initialization to match
  18307. declaration.
  18308. 2012-01-10 Simon Hausmann <simon.hausmann@nokia.com>
  18309. [Qt] Remove dependency to uitools
  18310. https://bugs.webkit.org/show_bug.cgi?id=75952
  18311. Reviewed by Tor Arne Vestbø.
  18312. QUiLoader is used for creating QLabel/QProgressBar widgets for
  18313. a layout test, to verify some widget embedding feature. Unfortunately
  18314. in Qt 5, QUiLoader is part of qttools, which depends on webkit, which
  18315. depends on qttools. Since we don't really _need_ QUiLoader for our tests,
  18316. let's break the circular dependency.
  18317. * DumpRenderTree/qt/DumpRenderTree.pro:
  18318. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  18319. (WebCore::WebPage::createPlugin):
  18320. * QtTestBrowser/QtTestBrowser.pro:
  18321. * QtTestBrowser/launcherwindow.h:
  18322. * QtTestBrowser/webpage.cpp:
  18323. (WebPage::createPlugin):
  18324. * qmake/mkspecs/features/minimal_qt.prf:
  18325. * qmake/mkspecs/features/uitools.prf: Removed.
  18326. 2012-01-10 Alexander Færøy <alexander.faeroy@nokia.com>
  18327. [Qt] Don't expose m_windowOptions as part of the public interface in MiniBrowserApplication
  18328. https://bugs.webkit.org/show_bug.cgi?id=75894
  18329. Reviewed by Tor Arne Vestbø.
  18330. * MiniBrowser/qt/MiniBrowserApplication.h:
  18331. (MiniBrowserApplication::windowOptions):
  18332. * MiniBrowser/qt/main.cpp:
  18333. (main):
  18334. 2012-01-10 Simon Hausmann <simon.hausmann@nokia.com>
  18335. [Qt] DRT crashes with Qt 5
  18336. https://bugs.webkit.org/show_bug.cgi?id=75951
  18337. Reviewed by Ossy.
  18338. * DumpRenderTree/qt/fonts.conf: Add missing last-resort font fallback for Qt 5 where
  18339. Qt relies on font-config to define the default font family.
  18340. 2012-01-10 Csaba Osztrogonác <ossy@webkit.org>
  18341. [Qt] REGRESSION(r100130): Clean build feature is broken.
  18342. https://bugs.webkit.org/show_bug.cgi?id=75863
  18343. Reviewed by Tor Arne Vestbø.
  18344. * Scripts/webkitdirs.pm:
  18345. (buildQMakeProject):
  18346. 2012-01-10 Zeno Albisser <zeno@webkit.org>
  18347. [Qt][WK2] Fix keyboard shortcuts in MiniBrowser.
  18348. https://bugs.webkit.org/show_bug.cgi?id=75885
  18349. In QML events are propagated through parents. But since the
  18350. WebView may consume key events, a shortcut might never reach
  18351. the top QtQuickItem.
  18352. Therefore an application wide event handling function in C++
  18353. needs to take care of shortcuts for MiniBrowser.
  18354. Reviewed by Kenneth Rohde Christiansen.
  18355. * MiniBrowser/qt/BrowserWindow.cpp:
  18356. (BrowserWindow::reload):
  18357. (BrowserWindow::focusAddressBar):
  18358. * MiniBrowser/qt/BrowserWindow.h:
  18359. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  18360. (MiniBrowserApplication::notify):
  18361. * MiniBrowser/qt/qml/BrowserWindow.qml:
  18362. 2012-01-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  18363. Add --efl alias for --platform=efl to run-webkit-test
  18364. https://bugs.webkit.org/show_bug.cgi?id=75937
  18365. Reviewed by Andreas Kling.
  18366. * Scripts/run-webkit-tests: Add --efl alias.
  18367. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --efl alias.
  18368. (parse_args):
  18369. 2012-01-09 Dan Bernstein <mitz@apple.com>
  18370. -[DOMRange renderedImageForcingBlackText:] fails with non-user-selectable text
  18371. https://bugs.webkit.org/show_bug.cgi?id=75920
  18372. Reviewed by Darin Adler.
  18373. * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
  18374. (TestWebKitAPI::TEST): Added a test for a range in a
  18375. -webkit-user-select: none; block.
  18376. 2012-01-09 Dirk Pranke <dpranke@chromium.org>
  18377. webkitpy.layout_tests.port.mock_drt_unittest.MockChromiumDRTTest has been failing on cr-win
  18378. https://bugs.webkit.org/show_bug.cgi?id=75884
  18379. Reviewed by Ryosuke Niwa.
  18380. Fix regression introduced (revealed?) in r104340. Chromium file
  18381. url syntax is different on win32 and the test results weren't
  18382. expecting that.
  18383. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  18384. (TestExpectations._report_errors):
  18385. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  18386. (test_parse_error_nonfatal):
  18387. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  18388. (MockDRTTest.input_line):
  18389. (MockChromiumDRTTest.test_pixeltest__fails):
  18390. * Scripts/webkitpy/layout_tests/port/test.py:
  18391. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  18392. (TestRebaseliner.make_rebaseliner):
  18393. (TestRebaseliner.test_one_platform):
  18394. (TestRebaseliner.test_all_platforms):
  18395. (TestRebaseliner.test_png_file_with_comment):
  18396. (TestRebaseliner.test_png_file_with_comment_remove_old_checksum):
  18397. (TestRebaseliner.test_png_file_with_comment_as_duplicate):
  18398. (TestRealMain.test_all_platforms):
  18399. 2012-01-09 Dirk Pranke <dpranke@chromium.org>
  18400. Fix regression in test-webkitpy introduced by removing the webkitpy/python24 directory.
  18401. Unreviewed, build fix.
  18402. test-webkitpy had a built-in self-test routine to verify that
  18403. deleting the .pyc files worked correctly. When I removed the
  18404. python24 directory in r104482, I broke the self-test.
  18405. I have deleted the self-test for now. Since I am reworking
  18406. test-webkitpy I will make sure the new version is adequately
  18407. tested.
  18408. * Scripts/test-webkitpy:
  18409. (configure_logging):
  18410. (_clean_pyc_files):
  18411. (_clean_packages):
  18412. (init):
  18413. 2012-01-09 Justin Novosad <junov@chromium.org>
  18414. [Chromium] remove all references to the legacy accelerated 2d Canvas
  18415. implementation
  18416. https://bugs.webkit.org/show_bug.cgi?id=75108
  18417. Purging an old settings flag that is no longer referenced
  18418. Reviewed by Darin Fisher.
  18419. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  18420. (main):
  18421. * DumpRenderTree/chromium/TestShell.cpp:
  18422. (TestShell::TestShell):
  18423. (TestShell::resetWebSettings):
  18424. * DumpRenderTree/chromium/TestShell.h:
  18425. (TestShell::setAccelerated2dCanvasEnabled):
  18426. * DumpRenderTree/chromium/WebPreferences.cpp:
  18427. (WebPreferences::reset):
  18428. (WebPreferences::applyTo):
  18429. * DumpRenderTree/chromium/WebPreferences.h:
  18430. 2012-01-09 Adam Roben <aroben@apple.com>
  18431. Convert Cygwin paths to Windows paths before passing them to DRT
  18432. Fixes <http://webkit.org/b/64468> <rdar://problem/10663409> WIN: DumpRenderTree hangs under
  18433. NRWT
  18434. I couldn't find a way to test this because I couldn't figure out how to override the
  18435. cygpath function as it is used by WebKitDriver.
  18436. Reviewed by Dirk Pranke.
  18437. * Scripts/webkitpy/layout_tests/port/webkit.py:
  18438. (WebKitDriver._command_from_driver_input): On Cygwin, convert the test's path to a
  18439. Windows-style path before passing it to DRT.
  18440. 2012-01-06 Dirk Pranke <dpranke@chromium.org>
  18441. webkitpy: revamp version checking
  18442. https://bugs.webkit.org/show_bug.cgi?id=75765
  18443. Reviewed by Adam Barth.
  18444. The version-checking code in webkitpy/python24/versioning seems really
  18445. awkward and overdesigned, especially since we don't support python 2.4
  18446. any more.
  18447. In addition, I am tired of getting warnings about Python 2.6 being "a
  18448. newer release than what is supported" :).
  18449. I'm taking a page from the depot_tools python code and just creating a
  18450. new webkitpy.common.version_check module that will print a message on
  18451. stderr and call sys.exit() if we're running an unsupported version.
  18452. * Scripts/check-webkit-style:
  18453. * Scripts/new-run-webkit-httpd:
  18454. * Scripts/new-run-webkit-tests:
  18455. * Scripts/rebaseline-chromium-webkit-tests:
  18456. * Scripts/test-webkitpy:
  18457. (configure_logging):
  18458. (init):
  18459. * Scripts/webkit-patch:
  18460. (main):
  18461. * Scripts/webkitpy/common/system/executive.py:
  18462. (Executive._child_process_encoding):
  18463. (Executive._should_encode_child_process_arguments):
  18464. * Scripts/webkitpy/common/version_check.py: Copied from Tools/Scripts/rebaseline-chromium-webkit-tests.
  18465. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  18466. * Scripts/webkitpy/python24/__init__.py: Removed.
  18467. * Scripts/webkitpy/python24/versioning.py: Removed.
  18468. * Scripts/webkitpy/python24/versioning_unittest.py: Removed.
  18469. 2012-01-09 Adam Barth <abarth@webkit.org>
  18470. Remove Chromium Mac CG from the flakiness dashboard
  18471. https://bugs.webkit.org/show_bug.cgi?id=75873
  18472. Reviewed by Ojan Vafai.
  18473. This configuration no longer exists.
  18474. * TestResultServer/static-dashboards/builders.js:
  18475. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  18476. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  18477. (testOverrideJustBuildType):
  18478. (testPlatformAndBuildType):
  18479. 2012-01-06 Adam Roben <aroben@apple.com>
  18480. Print an error message when NRWT can't run Apache
  18481. Fixes <http://webkit.org/b/75712> NRWT mysteriously exits when Apache returns an error code
  18482. Reviewed by Dirk Pranke.
  18483. * Scripts/webkitpy/layout_tests/port/base.py:
  18484. (Port.check_httpd): Print an error message when Apache returns an error code instead of
  18485. failing silently.
  18486. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  18487. (PortTest.test_check_httpd_success): Test that we don't print anything when we successfully
  18488. run Apache.
  18489. (PortTest.test_httpd_returns_error_code): Test that we print an error message when Apache
  18490. fails.
  18491. 2012-01-09 Gabor Rapcsanyi <rgabor@webkit.org>
  18492. [Gtk][ARM] Cross compiler buildbot is failing after r103040
  18493. https://bugs.webkit.org/show_bug.cgi?id=75846
  18494. Reviewed by Philippe Normand.
  18495. * Scripts/webkitdirs.pm:
  18496. (runAutogenForAutotoolsProjectIfNecessary):
  18497. 2012-01-09 Alexander Færøy <ahf@0x90.dk>
  18498. [Qt] Add support for dynamically enabling and disabling touch mocking in the Qt MiniBrowser
  18499. https://bugs.webkit.org/show_bug.cgi?id=75807
  18500. This patch adds a new icon to navigationbar of the Qt MiniBrowser
  18501. which allows you to dynamically toggle whether touch mocking is
  18502. enabled or disabled.
  18503. Reviewed by Tor Arne Vestbø.
  18504. * MiniBrowser/qt/MiniBrowser.qrc:
  18505. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  18506. (MiniBrowserApplication::notify):
  18507. * MiniBrowser/qt/MiniBrowserApplication.h:
  18508. (WindowOptions::WindowOptions):
  18509. (WindowOptions::touchMockingEnabled):
  18510. (WindowOptions::setTouchMockingEnabled):
  18511. * MiniBrowser/qt/icons/touch.png: Added.
  18512. * MiniBrowser/qt/qml/BrowserWindow.qml:
  18513. 2012-01-09 Carlos Garcia Campos <cgarcia@igalia.com>
  18514. Unreviewed. Fix make distcheck issues.
  18515. * MiniBrowser/gtk/GNUmakefile.am:
  18516. 2012-01-08 Sheriff Bot <webkit.review.bot@gmail.com>
  18517. Unreviewed, rolling out r104421.
  18518. http://trac.webkit.org/changeset/104421
  18519. https://bugs.webkit.org/show_bug.cgi?id=75816
  18520. Need to rebaseline some tests on Linux (Requested by noamr on
  18521. #webkit).
  18522. * qmake/mkspecs/features/features.prf:
  18523. 2012-01-08 Adam Barth <abarth@webkit.org>
  18524. Remove support for Chromium Mac CG from garden-o-matic
  18525. https://bugs.webkit.org/show_bug.cgi?id=75814
  18526. Reviewed by Eric Seidel.
  18527. This configuration no longer exists. This patch is mostly a matter of
  18528. updating config.js and removing the examples from the unit tests.
  18529. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  18530. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  18531. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  18532. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  18533. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  18534. 2012-01-08 No'am Rosenthal <noam.rosenthal@nokia.com>
  18535. [Qt] Enable CSS_FILTERS in Qt build
  18536. https://bugs.webkit.org/show_bug.cgi?id=75777
  18537. Add the CSS_FILTERS feature flag to Qt.
  18538. Reviewed by Kenneth Rohde Christiansen.
  18539. * qmake/mkspecs/features/features.prf:
  18540. 2012-01-08 Ryosuke Niwa <rniwa@webkit.org>
  18541. Categorize bots by ports instead of core/non-core separation
  18542. https://bugs.webkit.org/show_bug.cgi?id=75766
  18543. Reviewed by Eric Seidel.
  18544. Rename categorizes so as to preserve the original ordering of bots per Eric's suggestion
  18545. (Chromium still comes before GTK and Qt).
  18546. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  18547. (loadBuilderConfig):
  18548. * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  18549. 2012-01-08 Ryosuke Niwa <rniwa@webkit.org>
  18550. Remove the concept of core builders from webkitpy
  18551. https://bugs.webkit.org/show_bug.cgi?id=75809
  18552. Reviewed by Ryosuke Niwa.
  18553. Treat all bots equally since core/non-core sepration has been removed from build.webkit.org,
  18554. and remove the relevant code.
  18555. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  18556. (BuildBot.__init__):
  18557. (BuildBot._matches_regexps):
  18558. (BuildBot._builder_statuses_with_names_matching_regexps):
  18559. (BuildBot.builder_statuses):
  18560. (BuildBot.failure_map):
  18561. (BuildBot._latest_builds_from_builders):
  18562. (BuildBot.last_green_revision):
  18563. * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
  18564. (MockBuildBot.builder_statuses):
  18565. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  18566. (test_status_parsing):
  18567. (test_last_green_revision):
  18568. (test_last_green_revision.mock_builds_from_builders):
  18569. 2012-01-08 Adam Barth <abarth@webkit.org>
  18570. Remove Chromium Mac CG concept from webkitpy
  18571. https://bugs.webkit.org/show_bug.cgi?id=75810
  18572. Reviewed by Ryosuke Niwa.
  18573. This configuration no longer exists. We can remove all the supporting
  18574. code from webkitpy.
  18575. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  18576. (BaselineOptimizerTest.test_move_baselines):
  18577. (BaselineOptimizerTest.test_chromium_covers_mac_win_linux):
  18578. (BaselineOptimizerTest.test_chromium_mac_redundant_with_apple_mac):
  18579. (BaselineOptimizerTest.test_common_directory_includes_root):
  18580. (BaselineOptimizerTest.test_complex_shadowing):
  18581. * Scripts/webkitpy/common/config/build.py:
  18582. (_should_file_trigger_build):
  18583. * Scripts/webkitpy/common/config/build_unittest.py:
  18584. (ShouldBuildTest):
  18585. * Scripts/webkitpy/layout_tests/port/builders.py:
  18586. * Scripts/webkitpy/layout_tests/port/chromium.py:
  18587. (ChromiumPort):
  18588. (ChromiumPort._generate_all_test_configurations):
  18589. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  18590. (_default_tests_paths):
  18591. (ChromiumGpuLinuxPort.tests):
  18592. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  18593. (ChromiumGpuTest.integration_test_chromium_gpu_mac):
  18594. (ChromiumGpuTest.assert_port_works):
  18595. (ChromiumGpuTest.test_baseline_paths):
  18596. (ChromiumGpuTest.test_graphics_type):
  18597. (ChromiumGpuTest.test_default_tests_paths):
  18598. (ChromiumGpuTest.test_test_files):
  18599. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  18600. (ChromiumMacPort):
  18601. (ChromiumMacPort.__init__):
  18602. (ChromiumMacPort.baseline_search_path):
  18603. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  18604. (ChromiumMacPortTest.test_graphics_type):
  18605. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  18606. (ChromiumPortTest.test_all_test_configurations):
  18607. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  18608. * Scripts/webkitpy/layout_tests/port/factory.py:
  18609. (PortFactory._port_name_from_arguments_and_options):
  18610. (PortFactory.get):
  18611. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  18612. (FactoryTest.test_chromium_gpu_mac):
  18613. (FactoryTest.test_chromium_mac):
  18614. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  18615. (GetGoogleChromePortTest._verify_expectations_overrides):
  18616. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  18617. (MockChromiumDRTTest.test_chromium_parse_options):
  18618. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  18619. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  18620. (test_url_fetcher):
  18621. (test_zip_factory):
  18622. (test_archive):
  18623. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  18624. (TestRebaseline.test_rebaseline_expectations):
  18625. 2012-01-08 Ryosuke Niwa <rniwa@webkit.org>
  18626. Categorize bots by ports instead of core/non-core separation
  18627. https://bugs.webkit.org/show_bug.cgi?id=75766
  18628. Reviewed by Adam Barth.
  18629. Get rid of the concept of core/non-core builders, and categorize build bots by ports instead.
  18630. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  18631. (loadBuilderConfig):
  18632. * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  18633. 2012-01-08 Sheriff Bot <webkit.review.bot@gmail.com>
  18634. Unreviewed, rolling out r104403.
  18635. http://trac.webkit.org/changeset/104403
  18636. https://bugs.webkit.org/show_bug.cgi?id=75803
  18637. It broke all tests on Qt5 (Requested by Ossy_weekend on
  18638. #webkit).
  18639. * qmake/mkspecs/features/features.prf:
  18640. 2012-01-08 No'am Rosenthal <noam.rosenthal@nokia.com>
  18641. [Qt] Enable CSS_FILTERS in Qt build
  18642. https://bugs.webkit.org/show_bug.cgi?id=75777
  18643. Add the CSS_FILTERS feature flag to Qt.
  18644. Reviewed by Kenneth Rohde Christiansen.
  18645. * qmake/mkspecs/features/features.prf:
  18646. 2012-01-04 Kentaro Hara <haraken@chromium.org>
  18647. Rewrite the CSS parser of prepare-ChangeLog with unittests.
  18648. https://bugs.webkit.org/show_bug.cgi?id=75202
  18649. Reviewed by David Kilzer.
  18650. The current CSS parser can just parse simple CSSes like
  18651. foo bar baz {
  18652. property1: value;
  18653. property2: value;
  18654. }
  18655. , and cannot parse comments nor a CSS in which a selector and {
  18656. appears in different lines. This patch rewrites the CSS parser
  18657. (i.e. get_selector_line_ranges_for_css()) so that it can parse more CSSes
  18658. shown in css_unittests.css.
  18659. Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css
  18660. * Scripts/prepare-ChangeLog:
  18661. (get_selector_line_ranges_for_css):
  18662. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  18663. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests-expected.txt: Added.
  18664. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/css_unittests.css: Added.
  18665. (element1):
  18666. (element2):
  18667. (element3):
  18668. (element4.p):
  18669. (element5.p.q.r.s):
  18670. (element6#p):
  18671. (element7 element8):
  18672. (element9.p element10.q):
  18673. (element11#p element12#q):
  18674. (element13, element14):
  18675. (.p):
  18676. (#p):
  18677. (.p element15 #q element16.r element17#s):
  18678. (element18:target):
  18679. (element19):
  18680. (element20):
  18681. (element21):
  18682. (element22):
  18683. 2012-01-04 Kentaro Hara <haraken@chromium.org>
  18684. The Perl parser of prepare-ChangeLog can parse here-documents
  18685. https://bugs.webkit.org/show_bug.cgi?id=73208
  18686. Reviewed by David Kilzer.
  18687. Currently prepare-ChangeLog cannot recognize here-documents in Perl,
  18688. which results in wrong subroutine names in ChangeLogs.
  18689. With this patch, prepare-ChangeLog can judge whether the line of "}"
  18690. is the end of a subroutine or a line inside a here-document.
  18691. Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
  18692. * Scripts/prepare-ChangeLog:
  18693. (get_function_line_ranges_for_perl):
  18694. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt:
  18695. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl:
  18696. Added test cases for here-documents.
  18697. (func7):
  18698. (func8):
  18699. (func9):
  18700. (func10):
  18701. (func11):
  18702. (func12):
  18703. (func13):
  18704. (func14):
  18705. (func15):
  18706. (func16):
  18707. 2012-01-08 Kentaro Hara <haraken@chromium.org>
  18708. Add unittests for the JavaScript parser of prepare-ChangeLog
  18709. https://bugs.webkit.org/show_bug.cgi?id=75201
  18710. Reviewed by David Kilzer.
  18711. javascript_unittests.js is a unittest for get_function_line_ranges_for_javascript()
  18712. of prepare-ChangeLog.
  18713. * Scripts/prepare-ChangeLog:
  18714. (get_function_line_ranges_for_javascript): Before this patch, a string found was just
  18715. omitted from parsing. Thus,
  18716. str = "foo"
  18717. function func() {
  18718. }
  18719. was recognized as equivalent to
  18720. str = function func() {
  18721. }
  18722. This patch replaces a string with a dummy identifier 'string_appeared_here'
  18723. to tell the parser that a string appeared there.
  18724. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  18725. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests-expected.txt: Added.
  18726. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/javascript_unittests.js: Added.
  18727. (func1):
  18728. (func2):
  18729. (func3):
  18730. (func4):
  18731. (func5):
  18732. (func6):
  18733. (func7):
  18734. (func8):
  18735. (func9):
  18736. (func10):
  18737. (func11):
  18738. (func12):
  18739. (funcOverloaded):
  18740. (Func1.prototype.get x1):
  18741. (Func1.prototype.get x2):
  18742. (Func1.prototype.set x1):
  18743. (Func1.prototype.set x3):
  18744. (Func2.prototype.func13):
  18745. (Func2.prototype.func14):
  18746. (Func2.prototype.func15):
  18747. (func16.func17):
  18748. (func16.func18):
  18749. (func16.func19):
  18750. (func16):
  18751. 2012-01-08 David Levin <levin@chromium.org>
  18752. [chromium] Add layout test support for autosize code in FrameView.
  18753. https://bugs.webkit.org/show_bug.cgi?id=73631
  18754. Reviewed by Dmitry Titov.
  18755. * DumpRenderTree/chromium/LayoutTestController.cpp:
  18756. (LayoutTestController::LayoutTestController): Expose the new autoresize method.
  18757. (LayoutTestController::reset): Set the autoresize mode back to false.
  18758. (LayoutTestController::enableAutoResizeMode): A way to turn on autoresizing from javascript code in DumpRenderTree.
  18759. * DumpRenderTree/chromium/LayoutTestController.h:
  18760. * DumpRenderTree/chromium/WebViewHost.cpp:
  18761. (WebViewHost::didAutoResize): Handle the autoresize callback so that the outer bounds change appropriately.
  18762. * DumpRenderTree/chromium/WebViewHost.h:
  18763. 2012-01-07 Zan Dobersek <zandobersek@gmail.com>
  18764. [WK2][GTK] Each test takes roughly half a second to load
  18765. https://bugs.webkit.org/show_bug.cgi?id=70699
  18766. Reviewed by Martin Robinson.
  18767. Set the XDG_CACHE_HOME environment variable when testing with
  18768. WebKitTestRunner. This way the testing is started with a non-existing
  18769. application cache. If the cache exists and is not empty, the emptying
  18770. and vacuuming that is performed before every test can consume a lot of
  18771. time.
  18772. This is just a temporary workaround until it becomes possible to set
  18773. a desired directory to be used as the application cache location through
  18774. WebKitWebContext.
  18775. * Scripts/webkitpy/layout_tests/port/gtk.py:
  18776. (GtkPort.setup_environ_for_server):
  18777. 2012-01-07 Zan Dobersek <zandobersek@gmail.com>
  18778. [GTK] Enable requestAnimationFrame in build-webkit
  18779. https://bugs.webkit.org/show_bug.cgi?id=75773
  18780. Reviewed by Martin Robinson.
  18781. Enable requestAnimationFrame for the Gtk port.
  18782. * Scripts/build-webkit:
  18783. 2012-01-06 Jarred Nicholls <jarred@sencha.com>
  18784. Unreviewed build-webkit fix for Chromium to properly use make if gyp generates Makefiles.
  18785. * Scripts/webkitdirs.pm:
  18786. (buildChromium):
  18787. Missing parentheses.
  18788. 2012-01-06 Simon Fraser <simon.fraser@apple.com>
  18789. Fix DRT build on case-sensitive file systems.
  18790. Fix case of include of WebDynamicScrollBarsView.h
  18791. * DumpRenderTree/mac/DumpRenderTree.mm:
  18792. 2012-01-06 Simon Fraser <simon.fraser@apple.com>
  18793. Pixel results from DumpRenderTree and WebKitTestRunner don't match because of colorspace issues
  18794. https://bugs.webkit.org/show_bug.cgi?id=75662
  18795. Reviewed by Dan Bernstein.
  18796. The pixel results generated by DumpRenderTree and WebKitTestRunner differed because
  18797. of color profile issues. Fix by keeping everything in device RGB and ensuring that the
  18798. test window uses the main display's color space, so that the pixel values in the bitmap
  18799. that gets checksummed are identical to the CSS colors.
  18800. Removed the code that switches the display profile in DRT, since that is no longer required.
  18801. * DumpRenderTree/PixelDumpSupport.h: Remove unused function declarations.
  18802. * DumpRenderTree/mac/DumpRenderTree.mm:
  18803. (crashHandler): Remove code that switches display profiles.
  18804. (prepareConsistentTestingEnvironment): Ditto.
  18805. (dumpRenderTree): Ditto.
  18806. * DumpRenderTree/mac/PixelDumpSupportMac.mm: Ditto.
  18807. (createBitmapContext): Use DeviceRGB for the bitmap colorspace.
  18808. (createBitmapContextFromWebView): Add comment about the colorspace handling.
  18809. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  18810. (WTR::createCGContextFromImage): Use a RetainPtr, add comment.
  18811. (WTR::computeMD5HashStringForContext): Simplify the #ifdefs around the braces.
  18812. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  18813. (WTR::PlatformWebView::PlatformWebView): Set the window's colorspace to that of the main display.
  18814. (WTR::PlatformWebView::windowSnapshotImage): Add comment about colorspaces.
  18815. 2012-01-06 David Kilzer <ddkilzer@apple.com>
  18816. run-api-tests: specify individual suites and tests on the command-line
  18817. Reviewed by Adam Roben.
  18818. Fixes: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
  18819. The run-api-tests script will now accept a list of arguments on
  18820. the command-line that are used as prefix filters. To run all
  18821. tests in a suite that starts with "WTF" (WTF and WTF_Vector)
  18822. use:
  18823. $ run-api-tests WTF
  18824. To run only the tests in the "WTF" suite, not the "WTF_Vector"
  18825. suite, use:
  18826. $ run-api-tests WTF.
  18827. * Scripts/run-api-tests: Filter tests if any prefix arguments
  18828. are passed on the command-line.
  18829. 2012-01-06 David Kilzer <ddkilzer@apple.com>
  18830. run-api-tests: change internal representation of tests to array of "SuiteName.TestName" strings
  18831. Reviewed by Adam Roben.
  18832. Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
  18833. * Scripts/run-api-tests:
  18834. (dumpTestsBySuite): Update to accept array of tests instead of
  18835. hash data structure.
  18836. (runTestsBySuite): Ditto.
  18837. (listAllTests): Rename from populateTests(). Update to return
  18838. an array of tests instad of the hash data structure.
  18839. 2012-01-05 Dirk Pranke <dpranke@chromium.org>
  18840. webkitpy: clean up test/uri conversion routines
  18841. https://bugs.webkit.org/show_bug.cgi?id=75648
  18842. Reviewed by Eric Seidel.
  18843. This change moves test_to_uri and uri_to_test from the Port
  18844. class to the Driver class (the routines were only being
  18845. called by the drivers), and removes a bunch of stale and/or
  18846. busted logic.
  18847. * Scripts/webkitpy/layout_tests/port/base.py:
  18848. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  18849. * Scripts/webkitpy/layout_tests/port/chromium.py:
  18850. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  18851. * Scripts/webkitpy/layout_tests/port/driver.py:
  18852. (is_http_test):
  18853. (test_to_uri):
  18854. (uri_to_test):
  18855. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  18856. (run_one_test):
  18857. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  18858. (MockDRTTest.input_line):
  18859. (input_line):
  18860. (expected_output):
  18861. * Scripts/webkitpy/layout_tests/port/test.py:
  18862. * Scripts/webkitpy/layout_tests/port/webkit.py:
  18863. (_command_from_driver_input):
  18864. 2012-01-06 Simon Fraser <simon.fraser@apple.com>
  18865. Mitigate scrollbar differences when running pixel tests
  18866. https://bugs.webkit.org/show_bug.cgi?id=67217
  18867. Reviewed by Dan Bernstein.
  18868. Add an NSScroller subclass that draws mock scrollbars identically
  18869. to the WebCore mock scrollbar theme, and register it with the
  18870. WebDynamicScrollbarsView.
  18871. * DumpRenderTree/mac/DumpRenderTree.mm:
  18872. (-[DRTMockScroller rectForPart:]):
  18873. (-[DRTMockScroller drawKnob]):
  18874. (-[DRTMockScroller drawRect:]):
  18875. (registerMockScrollbars):
  18876. (prepareConsistentTestingEnvironment):
  18877. 2012-01-05 Jon Lee <jonlee@apple.com>
  18878. Update DRT on Mac to draw resize handles on text areas.
  18879. Reviewed by John Sullivan.
  18880. Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
  18881. between WK1 and WK2. This will require rebaselining existing textarea pixel tests.
  18882. * DumpRenderTree/mac/DumpRenderTree.mm:
  18883. (resetDefaultsToConsistentValues):
  18884. 2012-01-06 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  18885. [Qt] Move listing of include paths and libs to pri files in sources
  18886. Includepaths are sometimes modified by non-Qt contributors so keeping
  18887. them in files inside Sources makes it more likely that they are updated
  18888. along with project files for the other ports.
  18889. Using pri files instead of prf files for this also has the benefit that
  18890. the include() from the main target file can be parsed and followed by
  18891. Qt Creator -- something that does not work with load().
  18892. Dependency from a target to a library through the WEBKIT variable are
  18893. handled through forwarding-files in Tools/qmake/mkspecs/modules, which
  18894. set the source root of the module and include the right pri file.
  18895. Ideally we'd use the variant of include() that takes an optional
  18896. namespace to read the variables into, or the fromfile() function,
  18897. but both of these add an overhead of about 40% on the total qmake
  18898. runtime, due to making a deep copy of all the variables in the
  18899. project or re-reading all the prf files from scratch.
  18900. Reviewed by Simon Hausmann.
  18901. Reviewed by Ossy.
  18902. * qmake/mkspecs/features/default_post.prf:
  18903. * qmake/mkspecs/modules/javascriptcore.prf: Added.
  18904. * qmake/mkspecs/modules/webcore.prf: Added.
  18905. * qmake/mkspecs/modules/webkit2.prf: Added.
  18906. * qmake/mkspecs/modules/wtf.prf: Added.
  18907. 2012-01-06 JungJik Lee <jungjik.lee@samsung.com>
  18908. [EFL] Add pre-render handling code in EWebLauncher.
  18909. https://bugs.webkit.org/show_bug.cgi?id=73430
  18910. Reviewed by Zoltan Herczeg.
  18911. Add pre-render handling code by pressing Insert key.
  18912. * EWebLauncher/main.c:
  18913. (on_key_down):
  18914. 2012-01-06 Csaba Osztrogonác <ossy@webkit.org>
  18915. NRWT should use test_expectation.txt on wk2 platforms
  18916. https://bugs.webkit.org/show_bug.cgi?id=75417
  18917. Reviewed by Dirk Pranke.
  18918. * Scripts/webkitpy/layout_tests/port/webkit.py:
  18919. (path_to_test_expectations_file):
  18920. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  18921. (test_path_to_test_expectations_file):
  18922. 2012-01-05 Jochen Eisinger <jochen@chromium.org>
  18923. Don't hardcode expected file URIs in as they depend on the platform
  18924. https://bugs.webkit.org/show_bug.cgi?id=75666
  18925. Reviewed by Dirk Pranke.
  18926. * Scripts/webkitpy/layout_tests/port/win.py:
  18927. (WinPort.show_results_html_file):
  18928. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  18929. (MainTest.test_unexpected_failures):
  18930. (MainTest.test_results_directory_default):
  18931. (MainTest.test_results_directory_relative):
  18932. 2012-01-05 Anders Carlsson <andersca@apple.com>
  18933. Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
  18934. https://bugs.webkit.org/show_bug.cgi?id=75667
  18935. <rdar://problem/10389454>
  18936. Reviewed by Kevin Decker.
  18937. Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.
  18938. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  18939. (PluginTest::executeScript):
  18940. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  18941. * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
  18942. (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
  18943. (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
  18944. (NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):
  18945. 2012-01-05 Dirk Pranke <dpranke@chromium.org>
  18946. webkitpy: clean up port factory methods
  18947. https://bugs.webkit.org/show_bug.cgi?id=75590
  18948. Reviewed by Eric Seidel.
  18949. This change consolidates much of the "factory method" logic
  18950. of determining which port objects to create for a given set
  18951. of configurations by merging the separate factory methods in
  18952. chromium_gpu and google_chrome into PortFactory so that at least
  18953. all of the logic is in one place.
  18954. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  18955. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  18956. * Scripts/webkitpy/layout_tests/port/factory.py:
  18957. (_port_name_from_arguments_and_options):
  18958. (get):
  18959. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  18960. (test_google_chrome):
  18961. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  18962. (GoogleChromeLinux32Port):
  18963. (GoogleChromeLinux32Port.baseline_search_path):
  18964. (test_expectations_overrides):
  18965. (architecture):
  18966. (GoogleChromeLinux64Port):
  18967. (GoogleChromeLinux64Port.baseline_search_path):
  18968. (GoogleChromeMacPort):
  18969. (GoogleChromeMacPort.baseline_search_path):
  18970. (GoogleChromeWinPort):
  18971. (GoogleChromeWinPort.baseline_search_path):
  18972. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  18973. (_verify_baseline_path):
  18974. 2012-01-05 Jochen Eisinger <jochen@chromium.org>
  18975. Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
  18976. https://bugs.webkit.org/show_bug.cgi?id=75617
  18977. Reviewed by Dirk Pranke.
  18978. * Scripts/webkitpy/common/system/filesystem.py:
  18979. (FileSystem.exists):
  18980. * Scripts/webkitpy/common/system/filesystem_mock.py:
  18981. (MockFileSystem.exists):
  18982. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  18983. (GenericFileSystemTests.teardown_generic_test_dir):
  18984. * Scripts/webkitpy/layout_tests/port/base.py:
  18985. (Port.to.show_results_html_file):
  18986. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  18987. (MainTest.test_results_directory_absolute):
  18988. 2012-01-05 Adam Roben <aroben@apple.com>
  18989. Remove some unnecessary code from old-run-webkit-tests
  18990. Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
  18991. WebKitTestRunner.
  18992. Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
  18993. Windows
  18994. Reviewed by Eric Seidel.
  18995. * Scripts/old-run-webkit-tests:
  18996. (top level):
  18997. (openDumpTool):
  18998. Removed calls to setPathForRunningWebKitApp.
  18999. 2012-01-05 Adam Roben <aroben@apple.com>
  19000. Teach NRWT to use run-safari to open results.html on Apple's Windows port
  19001. NRWT was trying to use User.open_url, which doesn't work on Cygwin. But run-safari is
  19002. better, since we always want to open results.html using the user's build of WebKit, not
  19003. whatever their default browser is.
  19004. Fixes <http://webkit.org/b/75629> <rdar://problem/10648621> NRWT fails to open results.html
  19005. for Apple's Windows port
  19006. Reviewed by Eric Seidel.
  19007. * Scripts/webkitpy/layout_tests/port/win.py:
  19008. (WinPort.show_results_html_file): Changed to use run_safari, like MacPort does. Also removed
  19009. an obsolete comment.
  19010. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  19011. (WinPortTest.test_show_results_html_file): Updated expected results.
  19012. 2012-01-05 Adam Roben <aroben@apple.com>
  19013. Prepend Safari.exe's path to the command-line passed to CreateProcess
  19014. Safari expects the first argument in the command-line to be the path to Safari.exe itself.
  19015. This is how things get set up when Safari is launched normally (e.g., by Explorer). Safari
  19016. thus ignores the first argument when looking for command-line arguments. WebKitLauncherWin
  19017. was not including the path to Safari.exe in the command-line, so Safari was ignoring the
  19018. first argument that WebKitLauncherWin was trying to pass to it.
  19019. Fixes <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by Safari
  19020. Reviewed by Steve Falkenburg.
  19021. * WebKitLauncherWin/WebKitLauncherWin.cpp:
  19022. (_tWinMain): Construct a command-line for CreateProcess that first contains a double-quoted
  19023. path to Safari.exe, then contains any arguments that were passed to WebKitLauncherWin.
  19024. 2012-01-05 Adam Roben <aroben@apple.com>
  19025. Stop using explicit memory management in WebKitLauncherWin
  19026. We now use stack-allocated STL objects instead.
  19027. Prep work for <http://webkit.org/b/56571> First argument passed to WebKit.exe is ignored by
  19028. Safari
  19029. Reviewed by Steve Falkenburg.
  19030. * WebKitLauncherWin/WebKitLauncherWin.cpp:
  19031. (getStringValue):
  19032. (applePathFromRegistry):
  19033. (safariInstallDir):
  19034. (safariBrowserExe):
  19035. (_tWinMain):
  19036. Changed to use stack-allocated STL objects instead of malloc/free.
  19037. 2012-01-05 Adam Roben <aroben@apple.com>
  19038. Turn WebKitTestRunner into a stub .exe launcher and a .dll that contains all the real code
  19039. This allows us to add the Safari and Apple Application Support directories to PATH before
  19040. trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
  19041. Fixes <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
  19042. Windows port of DumpRenderTree/WebKitTestRunner
  19043. Reviewed by Steve Falkenburg.
  19044. * WebKitTestRunner/WebKitTestRunner.sln: Added WebKitTestRunnerLauncher and
  19045. ImageDiffLauncher, which I forgot to add to this .sln when that project was created.
  19046. * WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops:
  19047. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  19048. Changed to build WebKitTestRunner.dll instead of WebKitTestRunner.exe.
  19049. * WebKitTestRunner/win/WebKitTestRunnerLauncher.vcproj: Copied from
  19050. Tools/WebKitTestRunner/win/WebKitTestRunner.vcproj but changed to build
  19051. the stub launcher.
  19052. * WebKitTestRunner/win/WebKitTestRunnerLauncherCommon.vsprops: Added.
  19053. * WebKitTestRunner/win/WebKitTestRunnerLauncherDebug.vsprops: Added.
  19054. * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugAll.vsprops: Added.
  19055. * WebKitTestRunner/win/WebKitTestRunnerLauncherDebugCairoCFLite.vsprops: Added.
  19056. * WebKitTestRunner/win/WebKitTestRunnerLauncherProduction.vsprops: Added.
  19057. * WebKitTestRunner/win/WebKitTestRunnerLauncherRelease.vsprops: Added.
  19058. * WebKitTestRunner/win/WebKitTestRunnerLauncherReleaseCairoCFLite.vsprops: Added.
  19059. * WebKitTestRunner/win/main.cpp:
  19060. (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
  19061. 2012-01-05 Adam Roben <aroben@apple.com>
  19062. Turn DumpRenderTree into a stub .exe launcher and a .dll that contains all the real code
  19063. This allows us to add the Safari and Apple Application Support directories to PATH before
  19064. trying to load WebKit so that SafariTheme.dll, CoreGraphics.dll and friends can be found.
  19065. Part of <http://webkit.org/b/75486> <rdar://problem/10638124> NRWT fails to launch Apple's
  19066. Windows port of DumpRenderTree/WebKitTestRunner
  19067. Reviewed by Steve Falkenburg.
  19068. * DumpRenderTree/DumpRenderTree.sln: Added DumpRenderTreeLauncher and ImageDiffLauncher,
  19069. which I forgot to add to this .sln when that project was created.
  19070. * DumpRenderTree/win/DumpRenderTree.cpp:
  19071. (dllLauncherEntryPoint): Renamed from main. This is what the stub launcher calls.
  19072. * DumpRenderTree/win/DumpRenderTree.vcproj:
  19073. * DumpRenderTree/win/DumpRenderTreeCommon.vsprops:
  19074. Changed to build DumpRenderTree.dll instead of DumpRenderTree.exe.
  19075. * DumpRenderTree/win/DumpRenderTreeLauncher.vcproj: Added.
  19076. * DumpRenderTree/win/DumpRenderTreeLauncherCommon.vsprops: Added.
  19077. * DumpRenderTree/win/DumpRenderTreeLauncherDebug.vsprops: Added.
  19078. * DumpRenderTree/win/DumpRenderTreeLauncherDebugAll.vsprops: Added.
  19079. * DumpRenderTree/win/DumpRenderTreeLauncherDebugCairoCFLite.vsprops: Added.
  19080. * DumpRenderTree/win/DumpRenderTreeLauncherProduction.vsprops: Added.
  19081. * DumpRenderTree/win/DumpRenderTreeLauncherRelease.vsprops: Added.
  19082. * DumpRenderTree/win/DumpRenderTreeLauncherReleaseCairoCFLite.vsprops: Added.
  19083. * win/DLLLauncher/DLLLauncherMain.cpp:
  19084. (modifyPath): Moved code to modify PATH here from main/wWinMain. Changed to also prepend
  19085. Safari's directory to PATH so that SafariTheme.dll can be found.
  19086. (main):
  19087. (wWinMain):
  19088. Changed to use the new modifyPath function.
  19089. 2012-01-05 Alexander Færøy <alexander.faeroy@nokia.com>
  19090. [Qt] Never enable FontConfig on Mac OS X
  19091. https://bugs.webkit.org/show_bug.cgi?id=75616
  19092. Reviewed by Tor Arne Vestbø.
  19093. * qmake/mkspecs/features/features.prf:
  19094. 2012-01-05 Alpha Lam <hclam@chromium.org>
  19095. Unreviewed, rolling out r104159.
  19096. http://trac.webkit.org/changeset/104159
  19097. https://bugs.webkit.org/show_bug.cgi?id=75590
  19098. Chromium port GPU tests cannot be executed.
  19099. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  19100. (get):
  19101. (_default_tests_paths):
  19102. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  19103. (ChromiumGpuTest.assert_port_works):
  19104. * Scripts/webkitpy/layout_tests/port/factory.py:
  19105. (PortFactory._port_name_from_arguments_and_options):
  19106. (PortFactory):
  19107. (PortFactory._get_kwargs):
  19108. (PortFactory.get):
  19109. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  19110. (FactoryTest.test_google_chrome.names):
  19111. (FactoryTest.test_google_chrome):
  19112. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  19113. (GetGoogleChromePort):
  19114. (GetGoogleChromePort.GoogleChromeLinux32Port):
  19115. (GetGoogleChromePort.GoogleChromeLinux32Port.baseline_search_path):
  19116. (GetGoogleChromePort.GoogleChromeLinux32Port.test_expectations_overrides):
  19117. (GetGoogleChromePort.GoogleChromeLinux32Port.architecture):
  19118. (GetGoogleChromePort.GoogleChromeLinux64Port):
  19119. (GetGoogleChromePort.GoogleChromeLinux64Port.baseline_search_path):
  19120. (GetGoogleChromePort.GoogleChromeLinux64Port.test_expectations_overrides):
  19121. (GetGoogleChromePort.GoogleChromeLinux64Port.architecture):
  19122. (GetGoogleChromePort.GoogleChromeMacPort):
  19123. (GetGoogleChromePort.GoogleChromeMacPort.baseline_search_path):
  19124. (GetGoogleChromePort.GoogleChromeMacPort.test_expectations_overrides):
  19125. (GetGoogleChromePort.GoogleChromeWinPort):
  19126. (GetGoogleChromePort.GoogleChromeWinPort.baseline_search_path):
  19127. (GetGoogleChromePort.GoogleChromeWinPort.test_expectations_overrides):
  19128. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  19129. (GetGoogleChromePortTest._verify_baseline_path):
  19130. (GetGoogleChromePortTest._verify_expectations_overrides):
  19131. 2012-01-05 Dirk Pranke <dpranke@chromium.org>
  19132. webkitpy: clean up port factory methods
  19133. https://bugs.webkit.org/show_bug.cgi?id=75590
  19134. Reviewed by Eric Seidel.
  19135. This change consolidates much of the "factory method" logic
  19136. of determining which port objects to create for a given set
  19137. of configurations by merging the separate factory methods in
  19138. chromium_gpu and google_chrome into PortFactory so that at least
  19139. all of the logic is in one place.
  19140. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  19141. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  19142. * Scripts/webkitpy/layout_tests/port/factory.py:
  19143. (_port_name_from_arguments_and_options):
  19144. (get):
  19145. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  19146. (test_google_chrome):
  19147. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  19148. (GoogleChromeLinux32Port):
  19149. (GoogleChromeLinux32Port.baseline_search_path):
  19150. (test_expectations_overrides):
  19151. (architecture):
  19152. (GoogleChromeLinux64Port):
  19153. (GoogleChromeLinux64Port.baseline_search_path):
  19154. (GoogleChromeMacPort):
  19155. (GoogleChromeMacPort.baseline_search_path):
  19156. (GoogleChromeWinPort):
  19157. (GoogleChromeWinPort.baseline_search_path):
  19158. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  19159. (_verify_baseline_path):
  19160. 2012-01-04 Adam Roben <aroben@apple.com>
  19161. Turn ImageDiff into a stub .exe launcher and a .dll that contains all the real code
  19162. This allows us to add the Apple Application Support directory to PATH before trying to load
  19163. WebKit so that CoreGraphics.dll and friends can be found.
  19164. Fixes <http://webkit.org/b/75572> ImageDiff.exe can't be run without first munging PATH
  19165. Reviewed by Anders Carlsson.
  19166. * DumpRenderTree/win/ImageDiff.vcproj:
  19167. * DumpRenderTree/win/ImageDiffCommon.vsprops:
  19168. Changed to build ImageDiff.dll instead of ImageDiff.exe.
  19169. * DumpRenderTree/win/ImageDiffLauncher.vcproj: Copied from
  19170. Tools/DumpRenderTree/win/ImageDiff.vcproj but changed to build the stub launcher.
  19171. * DumpRenderTree/win/ImageDiffLauncherCommon.vsprops: Added.
  19172. * DumpRenderTree/win/ImageDiffLauncherDebug.vsprops: Added.
  19173. * DumpRenderTree/win/ImageDiffLauncherDebugAll.vsprops: Added.
  19174. * DumpRenderTree/win/ImageDiffLauncherDebugCairoCFLite.vsprops: Added.
  19175. * DumpRenderTree/win/ImageDiffLauncherProduction.vsprops: Added.
  19176. * DumpRenderTree/win/ImageDiffLauncherRelease.vsprops: Added.
  19177. * DumpRenderTree/win/ImageDiffLauncherReleaseCairoCFLite.vsprops: Added.
  19178. * DumpRenderTree/win/ImageDiffWin.cpp: Added.
  19179. (dllLauncherEntryPoint): This function is called by the stub launcher and just calls through
  19180. to main.
  19181. * win/DLLLauncher/DLLLauncherMain.cpp:
  19182. (main):
  19183. (wWinMain):
  19184. Added support for launching console programs. When USE_CONSOLE_ENTRY_POINT is defined, the
  19185. stub launcher acts as a console program and calls a console version of
  19186. dllLauncherEntryPoint.
  19187. 2012-01-04 Adam Roben <aroben@apple.com>
  19188. Turn MiniBrowser into a stub .exe launcher and a .dll that contains all the real code
  19189. This allows us to add the Apple Application Support directory to PATH before trying to load
  19190. WebKit so that CoreGraphics.dll and friends can be found.
  19191. Fixes <http://webkit.org/b/68576> <rdar://problem/10163853> MiniBrowser fails to launch when
  19192. double-clicked
  19193. Reviewed by Anders Carlsson.
  19194. * MiniBrowser/MiniBrowser.vcproj:
  19195. * MiniBrowser/Configurations/MiniBrowserCommon.vsprops:
  19196. Changed to build MiniBrowser.dll instead of MiniBrowser.exe.
  19197. * MiniBrowser/Configurations/MiniBrowserLauncherCommon.vsprops: Added.
  19198. * MiniBrowser/Configurations/MiniBrowserLauncherDebug.vsprops: Added.
  19199. * MiniBrowser/Configurations/MiniBrowserLauncherDebugAll.vsprops: Added.
  19200. * MiniBrowser/Configurations/MiniBrowserLauncherDebugCairoCFLite.vsprops: Added.
  19201. * MiniBrowser/Configurations/MiniBrowserLauncherProduction.vsprops: Added.
  19202. * MiniBrowser/Configurations/MiniBrowserLauncherRelease.vsprops: Added.
  19203. * MiniBrowser/Configurations/MiniBrowserLauncherReleaseCairoCFLite.vsprops: Added.
  19204. * MiniBrowser/MiniBrowserLauncher.vcproj: Copied from Tools/MiniBrowser/MiniBrowser.vcproj
  19205. but changed to build the stub launcher.
  19206. * MiniBrowser/win/main.cpp: Moved the /manifestdependency code to DLLLauncherMain.cpp, since
  19207. it needs to be compiled into the .exe instead of the .dll.
  19208. (DllMain): Added. We use this to store the DLL's HINSTANCE.
  19209. (dllLauncherEntryPoint): Renamed from _tWinMain. This is what gets called by the
  19210. DLLLauncherMain code.
  19211. * win/DLLLauncher/DLLLauncherMain.cpp: Moved the /manifestdependency code from MiniBrowser
  19212. to here.
  19213. 2012-01-04 Adam Roben <aroben@apple.com>
  19214. Make WinLauncher's window frame respond to clicks/drags again
  19215. Fixes <http://webkit.org/b/75562> REGRESSION (r84990): Can't drag WinLauncher by its title
  19216. bar when Aero is disabled
  19217. Reviewed by Brent Fulgham.
  19218. * WinLauncher/WinLauncher.cpp:
  19219. (WndProc): Always call up to our parent wndproc when we don't handle WM_NCHITTEST ourselves.
  19220. Also removed an unnecessary "break" keyword.
  19221. 2012-01-04 Adam Roben <aroben@apple.com>
  19222. Turn WinLauncher into a stub .exe launcher and a .dll that contains all the real code
  19223. This allows us to add the Apple Application Support directory to PATH before trying to load
  19224. WebKit so that CoreGraphics.dll and friends can be found. Eventually all our WebKit apps
  19225. should use this mechanism.
  19226. Fixes <http://webkit.org/b/68578> <rdar://problem/10163861> WinLauncher fails to launch when
  19227. double-clicked
  19228. Reviewed by Anders Carlsson.
  19229. * WinLauncher/WinLauncher.cpp: Removed InitInstance.
  19230. (DllMain): Added. Stores the DLL HINSTANCE in the global hInst variable. This used to be
  19231. done by the now-removed InitInstance function.
  19232. (dllLauncherEntryPoint): Renamed from _tWinMain. This is the function that our stub launcher
  19233. calls. Merged code from InitInstance into this function, and change to use the global hInst
  19234. variable, which corresponds to WinLauncher.dll, rather than the HINSTANCE passed into this
  19235. function, which corresponds to WinLauncher.exe.
  19236. * WinLauncher/WinLauncher.vcproj:
  19237. * WinLauncher/WinLauncherCommon.vsprops:
  19238. Changed to build WinLauncher.dll instead of WinLauncher.exe.
  19239. * WinLauncher/WinLauncherLauncher.rc: Added.
  19240. * WinLauncher/WinLauncherLauncherResource.h: Added.
  19241. This just references the WinLauncher.ico file to set the application icon (though it looks
  19242. like that's a default icon).
  19243. * WinLauncher/WinLauncherLauncher.vcproj: Copied from Tools/WinLauncher/WinLauncher.vcproj
  19244. but changed to build WinLauncher.exe using the new DLLLauncherMain.cpp file.
  19245. * WinLauncher/WinLauncherLauncherCommon.vsprops: Added.
  19246. * WinLauncher/WinLauncherLauncherDebug.vsprops: Added.
  19247. * WinLauncher/WinLauncherLauncherDebugAll.vsprops: Added.
  19248. * WinLauncher/WinLauncherLauncherDebugCairoCFLite.vsprops: Added.
  19249. * WinLauncher/WinLauncherLauncherProduction.vsprops: Added.
  19250. * WinLauncher/WinLauncherLauncherRelease.vsprops: Added.
  19251. * WinLauncher/WinLauncherLauncherReleaseCairoCFLite.vsprops: Added.
  19252. * win/DLLLauncher/DLLLauncherMain.cpp: Added.
  19253. (enableTerminationOnHeapCorruption): Uses HeapSetInformation to tell Windows to kill the
  19254. program if it detects heap corruption.
  19255. (getStringValue): Helper function to read a string value from the registry.
  19256. (applePathFromRegistry): Helper function to read the InstallDir for a given Apple
  19257. application from the registry.
  19258. (appleApplicationSupportDirectory): Helper function to return the path to the Apple
  19259. Application Support directory.
  19260. (copyEnvironmentVariable): Helper function to copy an environment variable's value.
  19261. (prependPath): Helper function to prepend a directory to the PATH.
  19262. (fatalError): Helper function to display an error to the user.
  19263. (wWinMain): Add Apple Application Support to the PATH, then load our DLL and call its
  19264. dllLauncherEntryPoint function.
  19265. 2012-01-05 Kentaro Hara <haraken@chromium.org>
  19266. prepare-ChangeLog cannot parse python code that nests classes and defs
  19267. https://bugs.webkit.org/show_bug.cgi?id=75524
  19268. Reviewed by Ryosuke Niwa.
  19269. This patch fixes the python parser of prepare-ChangeLog so that it can parse
  19270. python code that nests classes and defs, like this:
  19271. class C:
  19272. pass
  19273. def f():
  19274. pass
  19275. pass
  19276. Also, this patch fixes the python parser so that it inserts a dummy line
  19277. at the end of the file to pop out all popped scopes.
  19278. * Scripts/prepare-ChangeLog:
  19279. (get_function_line_ranges_for_python):
  19280. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py:
  19281. Added test cases that nest classes and defs.
  19282. (func7):
  19283. (func7.func8):
  19284. (func7.func8.func9):
  19285. (Class2):
  19286. (Class2.Class3):
  19287. (Class2.Class3.Class4):
  19288. (Class5):
  19289. (Class5.func10):
  19290. (Class5.func11):
  19291. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt:
  19292. 2012-01-05 Carlos Garcia Campos <cgarcia@igalia.com>
  19293. [GTK] Rename webkit_web_view_load_alternate_html as webkit_web_view_replace_content in WebKit2 GTK+
  19294. https://bugs.webkit.org/show_bug.cgi?id=75433
  19295. Reviewed by Martin Robinson.
  19296. * MiniBrowser/gtk/BrowserWindow.c:
  19297. (webViewLoadFailed): Reset the progress bar when load fails.
  19298. (browserWindowConstructed): Connect to load-failed signal.
  19299. 2012-01-04 Dan Bernstein <mitz@apple.com>
  19300. Add a --target-web-process option to the debug-* scripts. When specified, the scripts will
  19301. start WebProcess under gdb and WebProcess will then run the client executable.
  19302. This is the Tools part of fixing <http://webkit.org/b/75444> Debugging WebProcess requires running a UI process first and waiting to attach
  19303. Reviewed by Anders Carlsson.
  19304. * Scripts/webkitdirs.pm:
  19305. (shouldTargetWebProcess): Added.
  19306. (determineShouldTargetWebProcess): Added. Checks for --target-web-process.
  19307. (execMacWebKitAppForDebugging): Changed to target gdb at WebProcess and pass the path to the
  19308. app using the -client-executable option if targeting the web process.
  19309. 2012-01-04 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
  19310. Adding myself to committers list.
  19311. Unreviewed.
  19312. * Scripts/webkitpy/common/config/committers.py:
  19313. 2012-01-04 David Kilzer <ddkilzer@apple.com>
  19314. Revert fix for Bug 75064: TestWebKitAPI: initialize the main thread before running tests
  19315. This reverts commit r103546.
  19316. * TestWebKitAPI/TestsController.cpp:
  19317. (TestWebKitAPI::TestsController::TestsController):
  19318. 2012-01-04 James Robinson <jamesr@chromium.org>
  19319. [chromium] Move WebMimeRegistry and dependencies to Source/Platform
  19320. https://bugs.webkit.org/show_bug.cgi?id=74583
  19321. Reviewed by Darin Fisher.
  19322. Teaches the WEBKIT_EXPORT check about the chromium WebKit platform API header location.
  19323. * Scripts/webkitpy/style/checkers/cpp.py:
  19324. (check_function_definition):
  19325. 2012-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19326. [Qt] Fix link order of static libraries and unbreak QtWin32
  19327. We were keeping the correct static link order between the intermediate
  19328. WebKit libraries, but not the internal dependencies for each of those
  19329. libraries. The load() will in some instances mess with LIBS, so we need
  19330. to ensure that the dependent libraries are added after the library we
  19331. are linking against.
  19332. Reviewed by Simon Hausmann.
  19333. * qmake/mkspecs/features/default_post.prf:
  19334. 2012-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19335. [Qt] Introduce new qmake variable 'WEBKIT' for signaling dependencies
  19336. The custom qmake variable 'WEBKIT' is used for signaling that a
  19337. target depends in some way on other subproject of the WebKit
  19338. project. For now this is limited to the set of intermediate
  19339. libraries: wtf, javascriptcore, webcore, and webkit2.
  19340. This replaces the previous convension of using load(foo) for
  19341. just include paths, and CONFIG += foo to also link against foo.
  19342. Adding a dependency results in additional include paths being
  19343. available, and potentially linking to the library. This is
  19344. decided by the build system based on conditions such as what
  19345. kind of target is being built and the general build config.
  19346. An advantage to his approach is that it simplifies the individual
  19347. foo.prf files, for example by allowing us to use INCLUDEPATH +=
  19348. and LIBS += as normal instead of prepending.
  19349. Reviewed by Simon Hausmann.
  19350. * DumpRenderTree/qt/DumpRenderTree.pro:
  19351. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  19352. * QtTestBrowser/QtTestBrowser.pro:
  19353. * WebKitTestRunner/InjectedBundle/Target.pri:
  19354. * WebKitTestRunner/Target.pri:
  19355. * qmake/README:
  19356. * qmake/mkspecs/features/default_post.prf:
  19357. * qmake/mkspecs/features/functions.prf:
  19358. * qmake/mkspecs/features/javascriptcore.prf:
  19359. * qmake/mkspecs/features/qtwebkit.prf:
  19360. * qmake/mkspecs/features/webcore.prf:
  19361. * qmake/mkspecs/features/webkit2.prf:
  19362. * qmake/mkspecs/features/wtf.prf:
  19363. 2012-01-04 Alexander Færøy <ahf@0x90.dk>
  19364. [Qt] Add UI for JavaScript Prompt dialog in the Qt MiniBrowser
  19365. https://bugs.webkit.org/show_bug.cgi?id=75488
  19366. Reviewed by Tor Arne Vestbø.
  19367. * MiniBrowser/qt/MiniBrowser.qrc:
  19368. * MiniBrowser/qt/qml/BrowserWindow.qml:
  19369. * MiniBrowser/qt/qml/Dialog.qml:
  19370. * MiniBrowser/qt/qml/DialogLineInput.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
  19371. * MiniBrowser/qt/qml/PromptDialog.qml: Copied from Tools/MiniBrowser/qt/qml/Dialog.qml.
  19372. 2012-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19373. [Qt] Use rpath for WTR's InjectedBundle to pick up the right QtWebKit
  19374. It wasn't really a problem at runtime since the right QtWebKit was
  19375. already loaded as a dependency of the web process, but the ldd output
  19376. would still be busted.
  19377. Reviewed by Simon Hausmann.
  19378. * WebKitTestRunner/InjectedBundle/Target.pri:
  19379. 2012-01-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19380. [Qt] Move use of $$qtLibraryTarget() to a single place
  19381. Reviewed by Kenneth Rohde Christiansen.
  19382. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  19383. * WebKitTestRunner/InjectedBundle/Target.pri:
  19384. * qmake/mkspecs/features/default_post.prf:
  19385. * qmake/mkspecs/features/webcore.prf:
  19386. 2012-01-04 Mary Wu <mary.wu@torchmobile.com.cn>
  19387. Enable DOWNLOAD_ATTRIBUTE in BlackBerry porting
  19388. https://bugs.webkit.org/show_bug.cgi?id=75238
  19389. Reviewed by Antonio Gomes.
  19390. Add ENABLE_DOWNLOAD_ATTRIBUTE webkit feature into the build script so that
  19391. it could initiate download directly if it has the download attribute in the link
  19392. and doesn't need to open new blank page for the target="_blank". Enabling this
  19393. feature in the BlackBerry porting also prepares for later blob feature implementation.
  19394. * Scripts/build-webkit: Modified to handle ENABLE_DOWNLOAD_ATTRIBUTE. Make it default on
  19395. for the BlackBerry porting.
  19396. 2012-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
  19397. [GTK] Fix a runtime warning when hovering hyperlink auditing setting in MiniBroweser settings dialog
  19398. https://bugs.webkit.org/show_bug.cgi?id=75475
  19399. Reviewed by Martin Robinson.
  19400. The problem is that the property blurb contains <a ping> and tree
  19401. view uses gtk_tooltip_set_markup() internally, so we need to
  19402. escape the text.
  19403. * MiniBrowser/gtk/BrowserSettingsDialog.c:
  19404. (browserSettingsDialogConstructed): Escape property blurb before
  19405. storing it in the GtkTreeModel.
  19406. 2012-01-03 Jochen Eisinger <jochen@chromium.org>
  19407. When showing results.html pass a correct URL to webbrowser.open
  19408. https://bugs.webkit.org/show_bug.cgi?id=75438
  19409. Reviewed by Adam Barth.
  19410. * Scripts/webkitpy/common/system/filesystem.py:
  19411. (file_path_as_url):
  19412. * Scripts/webkitpy/common/system/filesystem_mock.py:
  19413. (file_path_as_url):
  19414. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  19415. (test_file_path_as_url):
  19416. * Scripts/webkitpy/layout_tests/port/base.py:
  19417. (show_results_html_file):
  19418. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  19419. (test_show_results_html_file):
  19420. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  19421. (test_results_directory_relative):
  19422. 2012-01-03 Ojan Vafai <ojan@chromium.org>
  19423. shrink the header on the flakiness dashboard
  19424. https://bugs.webkit.org/show_bug.cgi?id=65153
  19425. Reviewed by Adam Roben.
  19426. Move some of the "show" links to be to the right of the header
  19427. instead of below the header when they content they're showing
  19428. is hidden. That way we don't waste vertical space on them.
  19429. No new tests. This code is covered by existing tests.
  19430. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  19431. 2012-01-03 Ryosuke Niwa <rniwa@webkit.org>
  19432. Add a tool to analyze change logs
  19433. https://bugs.webkit.org/show_bug.cgi?id=72243
  19434. Reviewed by Eric Seidel.
  19435. Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
  19436. in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
  19437. for visualizing json files.
  19438. Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
  19439. where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
  19440. generates json files, and N is the number of changelogs to parse.
  19441. * Scripts/webkitpy/common/config/contributionareas.py: Added names().
  19442. * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
  19443. * Scripts/webkitpy/tool/commands/__init__.py:
  19444. * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
  19445. * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
  19446. * Scripts/webkitpy/tool/commands/data/summary.html: Added.
  19447. * Scripts/webkitpy/tool/steps/options.py:
  19448. 2012-01-03 Ryosuke Niwa <rniwa@webkit.org>
  19449. Add a tool to analyze change logs
  19450. https://bugs.webkit.org/show_bug.cgi?id=72243
  19451. Reviewed by Eric Seidel.
  19452. Add the initial implementation of analyze-changelog command. This version supports parsing multiple changelogs
  19453. in a single directory and summarizes the result in json files. It also copies summary.html to the output directory
  19454. for visualizing json files.
  19455. Usage: webkit-patch analyze-changelog [--changelog-count N] <CHANGELOG_DIR> <OUTPUT_DIR>
  19456. where CHANGELOG_DIR is the directory to look for changelogs, OUTPUT_DIR is the directory into which the tool
  19457. generates json files, and N is the number of changelogs to parse.
  19458. * Scripts/webkitpy/common/config/contributionareas.py: Added names().
  19459. * Scripts/webkitpy/common/system/filesystem_mock.py: Added readline and iterator support to ReadableTextFileObject.
  19460. * Scripts/webkitpy/tool/commands/__init__.py:
  19461. * Scripts/webkitpy/tool/commands/analyzechangelog.py: Added.
  19462. * Scripts/webkitpy/tool/commands/analyzechangelog_unittest.py: Added.
  19463. * Scripts/webkitpy/tool/commands/data/summary.html: Added.
  19464. * Scripts/webkitpy/tool/steps/options.py:
  19465. 2012-01-03 Adam Roben <aroben@apple.com>
  19466. Make Port subclasses override the operating_system method rather than setting an attribute
  19467. Without this patch, any use of Port.operating_system() within a port's __init__ method would
  19468. return the default value ("mac"). This was confusing the version-checking logic inside
  19469. ApplePort.__init__ on Windows.
  19470. Fixes <http://webkit.org/b/75479> <rdar://problem/10637385> REGRESSION (r102161): NRWT
  19471. crashes on launch on Windows 7 SP1
  19472. Reviewed by Eric Seidel.
  19473. * Scripts/webkitpy/layout_tests/port/apple.py:
  19474. (ApplePort.__init__): Replaced uses of self._operating_system with self.operating_system().
  19475. * Scripts/webkitpy/layout_tests/port/base.py:
  19476. (Port.__init__): Removed code that set the self._operating_system attribute. Subclasses
  19477. should now override the operating_system method instead.
  19478. (Port.operating_system): Changed to always return "mac". Subclasses should override to
  19479. return something else.
  19480. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  19481. (ChromiumLinuxPort.__init__):
  19482. (ChromiumLinuxPort.operating_system):
  19483. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  19484. (ChromiumMacPort.__init__):
  19485. (ChromiumMacPort.operating_system):
  19486. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  19487. (ChromiumWinPort.__init__):
  19488. (ChromiumWinPort.operating_system):
  19489. * Scripts/webkitpy/layout_tests/port/mac.py:
  19490. (MacPort.__init__):
  19491. (MacPort.operating_system):
  19492. * Scripts/webkitpy/layout_tests/port/win.py:
  19493. (WinPort.__init__):
  19494. (WinPort.operating_system):
  19495. Changed to override the operating_system method rather than setting the _operating_system
  19496. attribute, since setting the attribute isn't sufficient for code inside __init__ methods.
  19497. * Scripts/webkitpy/layout_tests/port/qt.py:
  19498. (QtPort.__init__):
  19499. (QtPort._path_to_webcore_library):
  19500. Changed to use self.operating_system() instead of self._operating_system, for consistency
  19501. with other Port-related code.
  19502. (QtPort.operating_system): Added this override of Port.operating_system that returns the
  19503. value we determined in our __init__ method.
  19504. * Scripts/webkitpy/layout_tests/port/test.py:
  19505. (TestPort.operating_system): Added this override of Port.operating_system that returns the
  19506. value we determined in our __init__ method.
  19507. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  19508. (PortTest.test_operating_system):
  19509. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  19510. (ChromiumLinuxPortTest.test_operating_system):
  19511. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  19512. (ChromiumMacPortTest.test_operating_system):
  19513. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  19514. (ChromiumWinPortTest.test_operating_system):
  19515. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  19516. (MacPortTest.test_operating_system):
  19517. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  19518. (QtPortTest.test_operating_system):
  19519. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  19520. (WinPortTest.test_operating_system):
  19521. Test that all ports return the expected operating system string.
  19522. 2012-01-03 Mario Sanchez Prada <msanchez@igalia.com>
  19523. [GTK] run-gtk-test should ignore files with names without a "test" or "Test" prefix
  19524. https://bugs.webkit.org/show_bug.cgi?id=75474
  19525. Reviewed by Philippe Normand.
  19526. * Scripts/run-gtk-tests: Ignore files whose name does not start
  19527. with a "test" (for WK1's API tests) or a "Test" prefix (for WK2).
  19528. 2012-01-03 Alexander Færøy <alexander.faeroy@nokia.com>
  19529. [Qt] Add UI for JavaScript Confirmation dialog in the Qt MiniBrowser
  19530. https://bugs.webkit.org/show_bug.cgi?id=75472
  19531. Reviewed by Tor Arne Vestbø.
  19532. * MiniBrowser/qt/MiniBrowser.pro:
  19533. * MiniBrowser/qt/MiniBrowser.qrc:
  19534. * MiniBrowser/qt/qml/BrowserWindow.qml:
  19535. * MiniBrowser/qt/qml/ConfirmDialog.qml: Added.
  19536. 2012-01-03 Alexander Færøy <alexander.faeroy@nokia.com>
  19537. [Qt] Add UI for JavaScript Alert dialog in the Qt MiniBrowser
  19538. https://bugs.webkit.org/show_bug.cgi?id=75471
  19539. Reviewed by Tor Arne Vestbø.
  19540. Add simple UI for JavaScript Alert dialogs. This patch also adds a
  19541. simple DialogButton QML type and a Dialog QML type which will be
  19542. reusable for other JavaScript dialogs.
  19543. * MiniBrowser/qt/MiniBrowser.qrc:
  19544. * MiniBrowser/qt/qml/AlertDialog.qml: Added.
  19545. * MiniBrowser/qt/qml/BrowserWindow.qml:
  19546. * MiniBrowser/qt/qml/Dialog.qml: Added.
  19547. * MiniBrowser/qt/qml/DialogButton.qml: Added.
  19548. 2012-01-03 Rafael Brandao <rafael.lobo@openbossa.org>
  19549. [Qt][WK2] MiniBrowser doesn't show url bar
  19550. https://bugs.webkit.org/show_bug.cgi?id=75470
  19551. Reviewed by Tor Arne Vestbø.
  19552. * MiniBrowser/qt/qml/BrowserWindow.qml: Remove clipping until it is fixed
  19553. on QtDeclarative (QTBUG-23422).
  19554. 2012-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
  19555. [GTK] Simplify loader client WebKit2 GTK+ API
  19556. https://bugs.webkit.org/show_bug.cgi?id=74605
  19557. Reviewed by Gustavo Noronha Silva.
  19558. * gtk/generate-gtkdoc: Ignore WebKitWebLoaderClient since it's now
  19559. private API.
  19560. 2012-01-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19561. [Qt] Clean up detection of fontconfig
  19562. We decide in features.prf whether or not fontconfig is available, and
  19563. set the HAVE_FONTCONFIG define accordingly. All leaf project files
  19564. should use this define to decide whether or not to link against
  19565. fontconfig, not do their own detection.
  19566. We don't need to add link_pkgconfig to CONFIG in each project file,
  19567. as we selectivly enable that configuration in defaults_post when
  19568. needed.
  19569. Reviewed by Ossy.
  19570. * DumpRenderTree/qt/DumpRenderTree.pro:
  19571. * QtTestBrowser/QtTestBrowser.pro:
  19572. * WebKitTestRunner/InjectedBundle/Target.pri:
  19573. * qmake/mkspecs/features/unix/default_post.prf:
  19574. * qmake/mkspecs/features/unix/default_pre.prf:
  19575. 2012-01-03 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  19576. [Qt] Introduce qmake replace function for the active build config
  19577. Reviewed by Ossy.
  19578. * qmake/mkspecs/features/default_post.prf:
  19579. * qmake/mkspecs/features/functions.prf:
  19580. 2012-01-03 Carlos Garcia Campos <cgarcia@igalia.com>
  19581. [GTK] Use gdk_screen_get_monitor_workarea() when available for screenAvailableRect()
  19582. https://bugs.webkit.org/show_bug.cgi?id=75435
  19583. Reviewed by Martin Robinson.
  19584. * GNUmakefile.am: Make sure DRT links to X11.
  19585. * WebKitTestRunner/GNUmakefile.am: Make sure WTR links to X11.
  19586. 2011-12-04 Philippe Normand <pnormand@igalia.com>
  19587. [WK2][GTK] WebSettings support in MiniBrowser
  19588. https://bugs.webkit.org/show_bug.cgi?id=73773
  19589. Reviewed by Martin Robinson.
  19590. Patch heavily inspired from the WebKit GtkLauncher to support
  19591. command-line WebSettings. Example: --enable-fullscreen=TRUE.
  19592. The full list of options can be consulted with --help-websettings.
  19593. * MiniBrowser/gtk/main.c:
  19594. (loadURI):
  19595. (parseOptionEntryCallback):
  19596. (isValidParameterType):
  19597. (getOptionEntriesFromWebKitSettings):
  19598. (addSettingsGroupToContext):
  19599. (main):
  19600. 2012-01-02 Philippe Normand <pnormand@igalia.com>
  19601. [GTK] GtkLauncher settings improvements
  19602. https://bugs.webkit.org/show_bug.cgi?id=75439
  19603. Reviewed by Martin Robinson.
  19604. * GtkLauncher/main.c:
  19605. (filenameToURL): We can use NULL in C.
  19606. (isValidParameterType): Utility function to filter GParamTypes
  19607. that can be edited.
  19608. (getOptionEntriesFromWebKitWebSettings): Avoid handling
  19609. construct-only properties and use the isValidParameterType
  19610. function. Makes the code a bit cleaner.
  19611. 2012-01-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  19612. [EFL] Remove whitespace/declaration style exception
  19613. https://bugs.webkit.org/show_bug.cgi?id=75424
  19614. Reviewed by David Levin.
  19615. Remove *whitespace/eclaration* style rule. However, EWebLauncher and MiniBrowser are EFL simple
  19616. application. So, they still need to use EFL coding style.
  19617. * Scripts/webkitpy/style/checker.py:
  19618. 2012-01-02 Carlos Garcia Campos <cgarcia@igalia.com>
  19619. [GTK] Add a way to change web view settings in MiniBrowser
  19620. https://bugs.webkit.org/show_bug.cgi?id=71568
  19621. Reviewed by Philippe Normand.
  19622. Add a preferences button to the toolbar that shows a dialog to
  19623. change settings of the current web view. It uses a GtkTreeView
  19624. with a custom cell renderer to support multiple types of values.
  19625. * MiniBrowser/gtk/BrowserCellRendererVariant.c: Added.
  19626. (browserCellRendererVariantFinalize):
  19627. (browserCellRendererVariantGetProperty):
  19628. (browserCellRendererVariantSetModeForValue):
  19629. (browserCellRendererVariantSetProperty):
  19630. (browserCellRendererVariantGetRendererForValue):
  19631. (browserCellRendererVariantCellRendererTextEdited):
  19632. (browserCellRendererVariantCellRendererSpinEdited):
  19633. (browserCellRendererVariantCellRendererActivate):
  19634. (browserCellRendererVariantCellRendererRender):
  19635. (browserCellRendererVariantCellRendererStartEditing):
  19636. (browserCellRendererVariantCellRendererGetPreferredWidth):
  19637. (browserCellRendererVariantCellRendererGetPreferredHeight):
  19638. (browserCellRendererVariantCellRendererGetPreferredWidthForHeight):
  19639. (browserCellRendererVariantCellRendererGetPreferredHeightForWidth):
  19640. (browserCellRendererVariantCellRendererGetAlignedArea):
  19641. (browser_cell_renderer_variant_init):
  19642. (browser_cell_renderer_variant_class_init):
  19643. (browser_cell_renderer_variant_new):
  19644. * MiniBrowser/gtk/BrowserCellRendererVariant.h: Added.
  19645. * MiniBrowser/gtk/BrowserSettingsDialog.c: Added.
  19646. (cellRendererChanged):
  19647. (browserSettingsDialogSetProperty):
  19648. (browser_settings_dialog_init):
  19649. (browserSettingsDialogConstructed):
  19650. (browser_settings_dialog_class_init):
  19651. (browser_settings_dialog_new):
  19652. * MiniBrowser/gtk/BrowserSettingsDialog.h: Added.
  19653. * MiniBrowser/gtk/BrowserWindow.c:
  19654. (settingsCallback):
  19655. (browser_window_init):
  19656. * MiniBrowser/gtk/GNUmakefile.am:
  19657. * MiniBrowser/gtk/browser-marshal.list: Added.
  19658. 2012-01-02 Carlos Garcia Campos <cgarcia@igalia.com>
  19659. [GTK] Implement create/ready-to-show/close signals in MiniBrowser
  19660. https://bugs.webkit.org/show_bug.cgi?id=74711
  19661. Reviewed by Philippe Normand.
  19662. * MiniBrowser/gtk/BrowserWindow.c:
  19663. (webViewClose): Destroy the window.
  19664. (webViewReadyToShow): Use WindowProperties of the new view to
  19665. setup and show the window.
  19666. (webViewCreate): Create a new view and add it to a browser window.
  19667. (browser_window_init):
  19668. (browserWindowConstructed): Connect to WebKitWebView::create signal.
  19669. 2011-12-31 Dan Bernstein <mitz@apple.com>
  19670. MiniBrowser sets the WKView’s frame incorrectly
  19671. https://bugs.webkit.org/show_bug.cgi?id=75393
  19672. Reviewed by Anders Carlsson.
  19673. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Removed Make Launchable build phase,
  19674. which is not needed since the binray is linked with the frameworks search path set to the
  19675. built products directory.
  19676. * MiniBrowser/mac/BrowserWindowController.m:
  19677. (-[BrowserWindowController awakeFromNib]): Changed to set the WKView’s frame to its
  19678. container’s bounds rather than its frame.
  19679. * MiniBrowser/mac/make-launchable.sh: Removed.
  19680. 2011-12-29 Dan Bernstein <mitz@apple.com>
  19681. debug-safari --no-saved-state fails to start the debugger
  19682. https://bugs.webkit.org/show_bug.cgi?id=75374
  19683. Reviewed by Sam Weinig.
  19684. * Scripts/webkitdirs.pm:
  19685. (execMacWebKitAppForDebugging): Pass the --args option to gdb so that it passes arguments to
  19686. the executable being debugged.
  19687. 2011-12-29 Sam Weinig <sam@webkit.org>
  19688. It should be easier to iterate a Vector backwards
  19689. https://bugs.webkit.org/show_bug.cgi?id=75359
  19690. Reviewed by Anders Carlsson.
  19691. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  19692. * TestWebKitAPI/TestWebKitAPI.gypi:
  19693. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  19694. Add new Vector test.
  19695. * TestWebKitAPI/Tests/Vector.cpp: Added.
  19696. (TestWebKitAPI::TEST):
  19697. Test Vector iterators, reverse_iterators and new reversed proxy.
  19698. 2011-12-28 Dmitry Lomov <dslomov@google.com>
  19699. [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
  19700. https://bugs.webkit.org/show_bug.cgi?id=66509
  19701. Just renames, merges and removal of dead code. Here are the list of renames:
  19702. - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  19703. - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  19704. - WebWorkerBase merged into WebSharedWorkerImpl
  19705. - NewWebWorkerBase renamed into WebWorkerBase
  19706. Reviewed by David Levin.
  19707. * DumpRenderTree/chromium/TestWebWorker.h:
  19708. (TestWebWorker::createWorker):
  19709. * DumpRenderTree/chromium/WebViewHost.cpp:
  19710. (WebViewHost::createWorker):
  19711. * DumpRenderTree/chromium/WebViewHost.h:
  19712. 2011-12-28 Sheriff Bot <webkit.review.bot@gmail.com>
  19713. Unreviewed, rolling out r103785.
  19714. http://trac.webkit.org/changeset/103785
  19715. https://bugs.webkit.org/show_bug.cgi?id=75332
  19716. Broke builders; looks like clobbering didnt help (Requested by
  19717. dslomov on #webkit).
  19718. * DumpRenderTree/chromium/TestWebWorker.h:
  19719. (TestWebWorker::createWorker):
  19720. * DumpRenderTree/chromium/WebViewHost.cpp:
  19721. (WebViewHost::createWorker):
  19722. * DumpRenderTree/chromium/WebViewHost.h:
  19723. 2011-12-28 Dmitry Lomov <dslomov@google.com>
  19724. [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
  19725. https://bugs.webkit.org/show_bug.cgi?id=66509
  19726. Just renames, merges and removal of dead code. Here are the list of renames:
  19727. - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  19728. - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  19729. - WebWorkerBase merged into WebSharedWorkerImpl
  19730. - NewWebWorkerBase renamed into WebWorkerBase
  19731. Reviewed by David Levin.
  19732. * DumpRenderTree/chromium/TestWebWorker.h:
  19733. (TestWebWorker::createWorker):
  19734. * DumpRenderTree/chromium/WebViewHost.cpp:
  19735. (WebViewHost::createWorker):
  19736. * DumpRenderTree/chromium/WebViewHost.h:
  19737. 2011-12-28 Sheriff Bot <webkit.review.bot@gmail.com>
  19738. Unreviewed, rolling out r103620.
  19739. http://trac.webkit.org/changeset/103620
  19740. https://bugs.webkit.org/show_bug.cgi?id=75316
  19741. Causes many crashes (Requested by abarth on #webkit).
  19742. * DumpRenderTree/chromium/LayoutTestController.cpp:
  19743. (LayoutTestController::LayoutTestController):
  19744. (LayoutTestController::reset):
  19745. * DumpRenderTree/chromium/LayoutTestController.h:
  19746. * DumpRenderTree/chromium/WebViewHost.cpp:
  19747. * DumpRenderTree/chromium/WebViewHost.h:
  19748. 2011-12-27 Sheriff Bot <webkit.review.bot@gmail.com>
  19749. Unreviewed, rolling out r103734.
  19750. http://trac.webkit.org/changeset/103734
  19751. https://bugs.webkit.org/show_bug.cgi?id=75278
  19752. Broke cr-mac (Requested by dslomov on #webkit).
  19753. * DumpRenderTree/chromium/TestWebWorker.h:
  19754. (TestWebWorker::createWorker):
  19755. * DumpRenderTree/chromium/WebViewHost.cpp:
  19756. (WebViewHost::createWorker):
  19757. * DumpRenderTree/chromium/WebViewHost.h:
  19758. 2011-12-27 Dmitry Lomov <dslomov@google.com>
  19759. [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
  19760. https://bugs.webkit.org/show_bug.cgi?id=66509
  19761. Just renames, merges and removal of dead code. Here are the list of renames:
  19762. - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  19763. - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  19764. - WebWorkerBase merged into WebSharedWorkerImpl
  19765. - NewWebWorkerBase renamed into WebWorkerBase
  19766. Reviewed by David Levin.
  19767. * DumpRenderTree/chromium/TestWebWorker.h:
  19768. (TestWebWorker::createWorker):
  19769. * DumpRenderTree/chromium/WebViewHost.cpp:
  19770. (WebViewHost::createWorker):
  19771. * DumpRenderTree/chromium/WebViewHost.h:
  19772. 2011-12-27 Anders Carlsson <andersca@apple.com>
  19773. Function should handle wrapping/unwrapping RefPtr and PassRefPtr
  19774. https://bugs.webkit.org/show_bug.cgi?id=75266
  19775. Reviewed by Sam Weinig.
  19776. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  19777. (TestWebKitAPI::Number::create):
  19778. (TestWebKitAPI::Number::~Number):
  19779. (TestWebKitAPI::Number::value):
  19780. (TestWebKitAPI::Number::Number):
  19781. (TestWebKitAPI::multiplyNumberByTwo):
  19782. (TestWebKitAPI::TEST):
  19783. 2011-12-24 Kentaro Hara <haraken@chromium.org>
  19784. Add unittests for the C++ parser of prepare-ChangeLog
  19785. https://bugs.webkit.org/show_bug.cgi?id=75191
  19786. Reviewed by Ryosuke Niwa.
  19787. cpp_unittests.cpp is the unittests for get_function_line_ranges_for_cpp()
  19788. of prepare-ChangeLog.
  19789. * Scripts/prepare-ChangeLog:
  19790. (get_function_line_ranges): Renames get_function_line_ranges_for_c()
  19791. to get_function_line_ranges_for_cpp().
  19792. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  19793. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt: Added.
  19794. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp: Added.
  19795. (func1):
  19796. (func2):
  19797. (func3):
  19798. (func4):
  19799. (func5):
  19800. (func6):
  19801. (func7):
  19802. (func8):
  19803. (func9):
  19804. (func10):
  19805. (func11):
  19806. (func12):
  19807. (func13):
  19808. (func14):
  19809. (func15):
  19810. (funcOverloaded):
  19811. (Class::func16):
  19812. (Class1::Class2::func17):
  19813. (Class2::func18):
  19814. (Class2::func19):
  19815. (Class2::func20):
  19816. (Class2::func21):
  19817. (Class2::func22):
  19818. (func23):
  19819. (func24):
  19820. (Class2::func25):
  19821. (Class1::func26):
  19822. (Class2::func27):
  19823. (Class3::func28):
  19824. (Class7::operator+):
  19825. (Class100::Class100):
  19826. (Class101::~Class101):
  19827. (Class102::Class102):
  19828. (Class103::Class103):
  19829. (Struct1::func29):
  19830. (Struct2::func30):
  19831. (NameSpace1::func30):
  19832. (NameSpace1::NameSpace2::func31):
  19833. 2011-12-24 Kentaro Hara <haraken@chromium.org>
  19834. Add unittests for the Java parser of prepare-ChangeLog
  19835. https://bugs.webkit.org/show_bug.cgi?id=75195
  19836. Reviewed by Ryosuke Niwa.
  19837. java_unittests.java is unittest cases for get_function_line_ranges_for_java()
  19838. of prepare-ChangeLog.
  19839. * Scripts/prepare-ChangeLog:
  19840. (get_function_line_ranges_for_java): Fixed a parser bug.
  19841. interface I
  19842. {
  19843. void f()
  19844. {
  19845. }
  19846. }
  19847. should be recognized as "I.f", and
  19848. class C interface I
  19849. {
  19850. void f()
  19851. {
  19852. }
  19853. }
  19854. should be recognized as "C.f".
  19855. Without this patch, both are recognized as "I.f".
  19856. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  19857. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests-expected.txt: Added.
  19858. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/java_unittests.java: Added.
  19859. (Simple):
  19860. (Simple.func1):
  19861. (Simple.func2):
  19862. (Simple.func3):
  19863. (Simple.func4):
  19864. (Simple.func5):
  19865. (Simple.func6):
  19866. (Simple.func7):
  19867. (Simple.func8):
  19868. (Simple.func9):
  19869. (Simple.func10):
  19870. (Simple.funcOverloaded):
  19871. (Simple.func11):
  19872. (Simple.func12):
  19873. (Simple.func13):
  19874. (Simple.func14):
  19875. (Simple.func15):
  19876. (Simple.func16):
  19877. (Simple.func17):
  19878. (Simple.func18):
  19879. (Simple.func19):
  19880. (Simple.func20):
  19881. (Simple.func21):
  19882. (Derived1):
  19883. (Derived1.Derived1):
  19884. (Derived1.func22):
  19885. (Interface1):
  19886. (Interface2):
  19887. (Interface2.func23):
  19888. (Derived2):
  19889. (Derived2.Derived2):
  19890. (Derived2.func23):
  19891. 2011-12-24 Kentaro Hara <haraken@chromium.org>
  19892. Add unittests for the Python parser of prepare-ChangeLog
  19893. https://bugs.webkit.org/show_bug.cgi?id=75197
  19894. Reviewed by Ryosuke Niwa.
  19895. python_unittests.py is the unittest for get_function_line_ranges_for_python()
  19896. of prepare-ChangeLog. The unittest just contains classes and defs that are not nested.
  19897. This is because the current python parser is wrong, and it cannot correctly parse nested
  19898. classes and defs (even one def in a class), nor class inheritance.
  19899. We will fix it in another patch.
  19900. * Scripts/prepare-ChangeLog:
  19901. (get_function_line_ranges_for_python): Ignores comment lines that starts from #.
  19902. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  19903. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests-expected.txt: Added.
  19904. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/python_unittests.py: Added.
  19905. (func1):
  19906. (func2):
  19907. (func3):
  19908. (funcInsideComment):
  19909. (func4):
  19910. (func5):
  19911. (func6):
  19912. (funcOverloaded):
  19913. (Class1):
  19914. 2011-12-24 Dan Bernstein <mitz@apple.com>
  19915. Set SHARED_PRECOMPS_DIR when Xcode is set to use a custom build product path.
  19916. Reviewed by Anders Carlsson.
  19917. * Scripts/webkitdirs.pm:
  19918. (determineBaseProductDir):
  19919. 2011-12-24 Dan Bernstein <mitz@apple.com>
  19920. Make build-webkit aware of additional Xcode build location defaults.
  19921. Reviewed by Anders Carlsson.
  19922. * Scripts/webkitdirs.pm:
  19923. (determineXcodeVersion): Added. This was previously in determineBaseProductDir().
  19924. (readXcodeUserDefault): Added. Factored out from determineBaseProductDir().
  19925. (determineBaseProductDir): Changed to check for a custom build location
  19926. style specified as an absolute location.
  19927. 2011-12-24 Ryosuke Niwa <rniwa@webkit.org>
  19928. Unreviewed, rolling out r103619.
  19929. http://trac.webkit.org/changeset/103619
  19930. https://bugs.webkit.org/show_bug.cgi?id=66509
  19931. Broke chromium clang build
  19932. * DumpRenderTree/chromium/TestWebWorker.h:
  19933. (TestWebWorker::createWorker):
  19934. * DumpRenderTree/chromium/WebViewHost.cpp:
  19935. (WebViewHost::createWorker):
  19936. * DumpRenderTree/chromium/WebViewHost.h:
  19937. 2011-12-23 Daniel Bates <dbates@webkit.org>
  19938. Provide option to disable Mac OS 10.7 application resume when using
  19939. {debug, run}-{safari, minibrowser, test-runner, test-webkit-api}, and run-webkit-app
  19940. https://bugs.webkit.org/show_bug.cgi?id=66902
  19941. Reviewed by David Kilzer.
  19942. Add an optional command line argument --no-saved-state to disable
  19943. application resume (state restoration) for the session on Mac OS 10.7.
  19944. For instance, when debugging an issue in Safari it is useful to be able
  19945. to temporarily disable application resume. Currently you can disable
  19946. application resume when launching Safari from within Xcode. We should
  19947. expose a similar option in our command line tools.
  19948. * Scripts/debug-minibrowser: Call printHelpAndExitForRunAndDebugWebKitAppIfNeeded()
  19949. to print a help message and exit() if the command line argument --help was given.
  19950. * Scripts/debug-safari: Ditto.
  19951. * Scripts/debug-test-runner: Ditto.
  19952. * Scripts/run-minibrowser: Ditto.
  19953. * Scripts/run-safari: Ditto.
  19954. * Scripts/run-test-runner: Ditto.
  19955. * Scripts/run-test-webkit-api: Ditto.
  19956. * Scripts/run-webkit-app: Ditto.
  19957. * Scripts/webkitdirs.pm:
  19958. (printHelpAndExitForRunAndDebugWebKitAppIfNeeded): Added.
  19959. (argumentsForRunAndDebugMacWebKitApp): Added.
  19960. (runMacWebKitApp): If the --no-saved-state command line argument was given then
  19961. disable application resume for the session.
  19962. (execMacWebKitAppForDebugging): Ditto.
  19963. 2011-12-23 Dmitry Lomov <dslomov@google.com>
  19964. [WebWorkers][Chromium] Remove remains of cross-process dedicated worker implementation.
  19965. https://bugs.webkit.org/show_bug.cgi?id=66509
  19966. Just renames, merges and removal of dead code. Here are the list of renames:
  19967. - WebCommonWorkerClient merged with WebWorkerClient and renamed to WebSharedWorkerClient
  19968. - NewWebCommonWorkerClient renamed to WebCommonWorkerClient
  19969. - WebWorkerBase merged into WebSharedWorkerImpl
  19970. - NewWebWorkerBase renamed into WebWorkerBase
  19971. Reviewed by David Levin.
  19972. * DumpRenderTree/chromium/TestWebWorker.h:
  19973. (TestWebWorker::createWorker):
  19974. * DumpRenderTree/chromium/WebViewHost.cpp:
  19975. (WebViewHost::createWorker):
  19976. * DumpRenderTree/chromium/WebViewHost.h:
  19977. 2011-12-23 Kentaro Hara <haraken@chromium.org>
  19978. Let parser_unittests.pl call different language parsers
  19979. https://bugs.webkit.org/show_bug.cgi?id=75081
  19980. Reviewed by David Kilzer.
  19981. We introduced parser_unittests.pl in bug 74994 , but it is implemented
  19982. to always call get_function_line_ranges_for_perl(). In order to enable unittests
  19983. for other languages, this patch lets parser_unittests.pl call different language
  19984. parsers depending on the languages.
  19985. Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
  19986. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl:
  19987. 2011-12-22 Adam Roben <aroben@apple.com>
  19988. Snow Leopard test fix
  19989. * Scripts/webkitpy/test/main.py:
  19990. (Tester.run_tests): Python 2.6.1 doesn't seem to like specifying testRunner=None to
  19991. unittest.main, even though that's the default. So now we explicitly specify a
  19992. TextTestRunner.
  19993. 2011-12-22 Chris Fleizach <cfleizach@apple.com>
  19994. AX: attributed strings do not include AXHeading information when a link is contained within the heading
  19995. https://bugs.webkit.org/show_bug.cgi?id=75059
  19996. Reviewed by Darin Adler.
  19997. Support the ability to check if an arbitrary attribute is present within an
  19998. attributed string that can be retrieved through an AccessibilityTextMarkerRange.
  19999. * DumpRenderTree/AccessibilityUIElement.cpp:
  20000. (attributedStringForTextMarkerRangeContainsAttributeCallback):
  20001. (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
  20002. (AccessibilityUIElement::getJSClass):
  20003. * DumpRenderTree/AccessibilityUIElement.h:
  20004. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  20005. (AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
  20006. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
  20007. (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
  20008. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
  20009. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  20010. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  20011. (WTR::AccessibilityUIElement::attributedStringForTextMarkerRangeContainsAttribute):
  20012. 2011-12-22 David Kilzer <ddkilzer@apple.com>
  20013. run-api-tests: runAllTests() and runTest() should not use global variables
  20014. Reviewed by Adam Roben.
  20015. Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
  20016. * Scripts/run-api-tests:
  20017. (runTestsBySuite): Rename from runAllTests(). Add arguments for
  20018. list of tests and $verbose.
  20019. (runTest): Add $verbose argument.
  20020. 2011-12-22 David Kilzer <ddkilzer@apple.com>
  20021. run-api-tests: inline runAllTestsInSuite() into runAllTests()
  20022. Reviewed by Adam Roben.
  20023. Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
  20024. In order to make it easy to run one or more individual suites,
  20025. or one more individual tests, it's easier to call a single
  20026. method with different data structures than individual methods.
  20027. * Scripts/run-api-tests:
  20028. (runAllTests): Inline runAllTestsInSuite().
  20029. 2011-12-22 Adam Roben <aroben@apple.com>
  20030. Add a --xml flag to test-webkitpy
  20031. test-webkitpy --xml will, in addition to providing the standard text output on stdout, write
  20032. JUnit-style XML files to a test-webkitpy-xml-reports subdirectory in the working directory.
  20033. This is useful for working with tools that consume JUnit-style XML files.
  20034. Fixes <http://webkit.org/b/75090> Would like a way to generate JUnit-style XML files when
  20035. running test-webkitpy
  20036. Reviewed by Darin Adler.
  20037. * Scripts/webkitpy/test/main.py:
  20038. (Tester.run_tests): If the --xml flag is passed, create an XMLTestRunner and pass it to
  20039. unittest.main(). Otherwise pass no test runner so that unittest will choose its own default.
  20040. * Scripts/webkitpy/thirdparty/__init__.py:
  20041. (AutoinstallImportHook.find_module):
  20042. (AutoinstallImportHook._install_xmlrunner):
  20043. Added code to install unittest-xml-reporting as webkitpy.thirdparty.autoinstalled.xmlrunner.
  20044. This change is untested because it's basically impossible to get a test to pass when --xml
  20045. is passed to test-webkitpy (because xmlrunner will already have been imported by the time
  20046. the test runs).
  20047. 2011-12-22 David Kilzer <ddkilzer@apple.com>
  20048. TestWebKitAPI: initialize the main thread before running tests
  20049. <http://webkit.org/b/75064>
  20050. Reviewed by Adam Roben.
  20051. * TestWebKitAPI/TestsController.cpp:
  20052. (TestWebKitAPI::TestsController::TestsController): Call
  20053. WTF::initializeMainThread() to prevent assertions in Debug
  20054. builds.
  20055. 2011-12-22 David Kilzer <ddkilzer@apple.com>
  20056. run-api-tests: dumpAllTests() should not use global variables
  20057. Reviewed by Adam Roben.
  20058. Part of: <http://webkit.org/b/75065> run-api-tests should be able to run individual suites and tests
  20059. * Scripts/run-api-tests: Renamed $dump to $dumpTests.
  20060. (dumpTestsBySuite): Rename from dumpAllTests() and pass in
  20061. global data as an argument. Sort suite names and test names
  20062. alphabetically to match output when running tests.
  20063. 2011-12-22 Leo Yang <leo.yang@torchmobile.com.cn>
  20064. [BlackBerry] Enable blob for the BlackBerry porting
  20065. https://bugs.webkit.org/show_bug.cgi?id=75074
  20066. Reviewed by George Staikos.
  20067. * Scripts/build-webkit:
  20068. 2011-12-22 Kentaro Hara <haraken@chromium.org>
  20069. Add unittests for the Perl parser of prepare-ChangeLog
  20070. https://bugs.webkit.org/show_bug.cgi?id=74994
  20071. Reviewed by David Kilzer.
  20072. This patch adds unittests for get_function_line_ranges_for_perl() of prepare-ChangeLog.
  20073. Test: Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl
  20074. * Scripts/webkitperl/prepare-ChangeLog_unittest/parser_unittests.pl: Added.
  20075. Runs unittests specified in @testFiles.
  20076. You can reset expected results by specifying a --reset-results option.
  20077. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests.pl: Added.
  20078. Contains simple methods.
  20079. (func1):
  20080. (func2):
  20081. (func3):
  20082. (func4):
  20083. (func5):
  20084. (func6):
  20085. * Scripts/webkitperl/prepare-ChangeLog_unittest/resources/perl_unittests-expected.txt: Added.
  20086. This test result is generated by the --reset-results option.
  20087. 2011-12-21 Eric Seidel <eric@webkit.org>
  20088. Add webkit.review.bot@gmail.com and commit-queue@webkit.org as "contributors"
  20089. so that they appear in the bugzilla autocomplete CC list.
  20090. I also removed the "radar" irc nick (which I believe does not exist)
  20091. and removed the uneeded [] around the radar bugzilla email.
  20092. Unreviewed.
  20093. * Scripts/webkitpy/common/config/committers.py:
  20094. 2011-12-21 Daniel Bates <dbates@rim.com>
  20095. Teach build-jsc how to build JavaScriptCore for the EFL, BlackBerry, and WinCE ports
  20096. https://bugs.webkit.org/show_bug.cgi?id=74985
  20097. Reviewed by Eric Seidel.
  20098. * Scripts/build-jsc:
  20099. * Scripts/webkitdirs.pm:
  20100. (cmakeBasedPortName): Added.
  20101. 2011-12-21 Daniel Bates <dbates@rim.com>
  20102. Extract BlackBerry CMake arguments from build-webkit into separate function
  20103. https://bugs.webkit.org/show_bug.cgi?id=74981
  20104. Reviewed by Rob Buis.
  20105. Towards adding support for using Tools/Scripts/build-jsc for the BlackBerry port, move
  20106. the CMake argument logic from Tools/Scripts/build-webkit to function webkitdirs::blackberryCMakeArguments()
  20107. and have cmakeBasedPortArguments() call this function for the BlackBerry CMake argument list.
  20108. This will allow us to get the BlackBerry CMake arguments in Tools/Scripts/build-jsc so
  20109. that we can pass them to the CMake build system when building JavaScriptCore.
  20110. * Scripts/build-webkit: Move construction of CMake argument list from here to
  20111. webkitdirs::blackberryCMakeArguments(). Also, remove exported function blackberryTargetArchitecture()
  20112. since it's only called within webkitdirs.pm now. Formerly we exported this function so that we could
  20113. call it from build-webkit.
  20114. * Scripts/webkitdirs.pm:
  20115. (blackberryCMakeArguments): Added.
  20116. (cmakeBasedPortArguments): Modified to call blackberryCMakeArguments() when building the
  20117. BlackBerry port.
  20118. 2011-12-21 Daniel Bates <dbates@webkit.org>
  20119. Extract WinCE CMake arguments from build-webkit into separate function
  20120. https://bugs.webkit.org/show_bug.cgi?id=74983
  20121. Reviewed by Rob Buis.
  20122. Towards adding support for using Tools/Scripts/build-jsc for the WinCE port, extract the
  20123. WinCE-specific CMake argument from Tools/Scripts/build-webkit into webkitdirs::cmakeBasedPortArguments().
  20124. This will allow us to get the WinCE-specific CMake argument in Tools/Scripts/build-jsc so
  20125. that we can pass it to the CMake build system when building JavaScriptCore.
  20126. * Scripts/build-webkit:
  20127. * Scripts/webkitdirs.pm:
  20128. (cmakeBasedPortArguments): Added.
  20129. 2011-12-21 Kentaro Hara <haraken@chromium.org>
  20130. In prepare-ChangeLog, replace constant global variables with "use constant"
  20131. https://bugs.webkit.org/show_bug.cgi?id=74992
  20132. Reviewed by Ryosuke Niwa.
  20133. This patch replaces the following constant global variables with "use constant"s.
  20134. - $changeLogTimeZone
  20135. - $SVN
  20136. - $GIT
  20137. - %supportedTestExtensions
  20138. * Scripts/prepare-ChangeLog:
  20139. (changeLogNameFromArgs):
  20140. (changeLogEmailAddressFromArgs):
  20141. (resolveConflictedChangeLogs):
  20142. (generateNewChangeLogs):
  20143. (diffCommand):
  20144. (statusCommand):
  20145. (createPatchCommand):
  20146. (findOriginalFileFromSvn):
  20147. (determinePropertyChanges):
  20148. (generateFileList):
  20149. (reviewerAndDescriptionForGitCommit):
  20150. 2011-12-20 Dirk Pranke <dpranke@chromium.org>
  20151. nrwt: rename field references from _fs to _filesystem
  20152. https://bugs.webkit.org/show_bug.cgi?id=74898
  20153. Reviewed by Adam Barth.
  20154. This is a simple cleanup; most of the code uses
  20155. self._filesystem, but some used self._fs; this change renames
  20156. the latter to the former to be more consistent.
  20157. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  20158. (Manager.__init__):
  20159. (Manager.collect_tests):
  20160. (Manager._strip_test_dir_prefix):
  20161. (Manager._split_into_chunks_if_necessary):
  20162. (Manager.results_directory):
  20163. (Manager._clobber_old_results):
  20164. (Manager._upload_json_files):
  20165. (Manager.print_config):
  20166. (Manager._copy_results_html_file):
  20167. (Manager._show_results_html_file):
  20168. (Manager._log_worker_stack):
  20169. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  20170. (JSONLayoutResultsGenerator._normalize_results_json):
  20171. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  20172. (JSONResultsGeneratorBase.__init__):
  20173. (JSONResultsGeneratorBase.generate_json_output):
  20174. (JSONResultsGeneratorBase.generate_times_ms_file):
  20175. (JSONResultsGeneratorBase.upload_json_files):
  20176. (JSONResultsGeneratorBase._get_svn_revision):
  20177. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  20178. (Base.__init__):
  20179. 2011-12-20 Kentaro Hara <haraken@chromium.org>
  20180. Replace webkitperl/run-leaks_unittest/RunLeaks.pm with webkitperl/LoadAsModule.pm
  20181. https://bugs.webkit.org/show_bug.cgi?id=74836
  20182. Reviewed by David Kilzer.
  20183. webkitperl/run-leaks_unittest/RunLeaks.pm can be used for unit-testing of run-leaks only.
  20184. This patch creates more generalized webkitperl/LoadAsModule.pm, which can be also used
  20185. for unit-testing of other Perl scripts. We are planning to use it for unit-testing
  20186. of prepare-ChangeLog.
  20187. Using LoadAsModule.pm, you can load a Perl script as follows.
  20188. The first argument is the arbitrary package name you want to use, and the second argument
  20189. is the name of the Perl script you want to load.
  20190. use LoadAsModule qw(RunLeaks run-leaks);
  20191. RunLeaks::someFunctionDefinedInRunLeaks(...);
  20192. Tests: Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl
  20193. Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl
  20194. Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl
  20195. * Scripts/webkitperl/LoadAsModule.pm: Added.
  20196. * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Removed.
  20197. (import):
  20198. (readFile):
  20199. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Used LoadAsModule instead of RunLeaks.
  20200. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  20201. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
  20202. 2011-12-20 Balazs Kelemen <kbalazs@webkit.org>
  20203. [Qt] WK2 Debugging quirks need some improvement
  20204. https://bugs.webkit.org/show_bug.cgi?id=74859
  20205. Reviewed by Simon Hausmann.
  20206. Improvements added to make debugging WebKit2 more
  20207. confortable and efficient:
  20208. 1. Unify debugging quirks. From now all of them are controlled
  20209. by the QT_WEBKIT2_DEBUG environment variable.
  20210. 2. Disable crash handlers for WebKitTestRunner if debugging quirks
  20211. are used to make it possible to use postmortem debugging via core dumps
  20212. which is extremely useful for debugging bugs triggered by layout tests.
  20213. 3. Disable test timeout for WebKitTestRunner if debugging quirks
  20214. are used because that makes debugging impossible.
  20215. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
  20216. (WTR::InjectedBundle::platformInitialize):
  20217. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  20218. (WTR::LayoutTestController::initializeWaitToDumpWatchdogTimerIfNeeded):
  20219. * WebKitTestRunner/qt/TestControllerQt.cpp:
  20220. (WTR::TestController::platformRunUntil):
  20221. 2011-12-20 Rafael Brandao <rafael.lobo@openbossa.org>
  20222. [Qt][WK2] Implement favicon support
  20223. https://bugs.webkit.org/show_bug.cgi?id=71082
  20224. Reviewed by Simon Hausmann.
  20225. A favorite icon was added on MiniBrowser's url bar as example.
  20226. We display a default icon when the page doesn't have an icon ready.
  20227. * MiniBrowser/qt/MiniBrowser.qrc:
  20228. * MiniBrowser/qt/icons/favicon.png: Added.
  20229. * MiniBrowser/qt/qml/BrowserWindow.qml:
  20230. 2011-12-19 Sam Weinig <sam@webkit.org>
  20231. Add support for scrollLineDown: and scrollLineUp: NSResponder selectors
  20232. https://bugs.webkit.org/show_bug.cgi?id=74907
  20233. Reviewed by Dan Bernstein.
  20234. Add ScrollByLineCommands API test.
  20235. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  20236. * TestWebKitAPI/Tests/WebKit2/mac/EditorCommands.mm: Added.
  20237. * TestWebKitAPI/Tests/WebKit2/simple-tall.html: Added.
  20238. 2011-12-19 Dirk Pranke <dpranke@chromium.org>
  20239. webkitpy: remove port.executive, port.filesystem, port.user properties
  20240. https://bugs.webkit.org/show_bug.cgi?id=74896
  20241. Reviewed by Eric Seidel.
  20242. Following on the refactoring of the port and host objects, this
  20243. removes the public executive, filesystem, and user properties
  20244. from the Port interface (protected versions of executive and
  20245. filesystem still exist). There is still some more clean up to
  20246. make the code more consistent and rearrange some other files to
  20247. talk to Hosts directly instead of getting them off of the Port
  20248. class.
  20249. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  20250. (Manager.__init__):
  20251. (Manager.results_directory):
  20252. (Manager._log_worker_stack):
  20253. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  20254. (ManagerTest.test_fallback_path_in_config):
  20255. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  20256. (_InlineManager.start_worker):
  20257. (_InlineWorkerConnection.__init__):
  20258. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  20259. (Worker.safe_init):
  20260. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  20261. (TestConfiguration.from_port):
  20262. * Scripts/webkitpy/layout_tests/port/base.py:
  20263. (Port.__init__):
  20264. (Port.tests):
  20265. (Port.show_results_html_file):
  20266. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  20267. (PortTest.test_layout_tests_skipping):
  20268. (PortTest.test_test_dirs):
  20269. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  20270. (_set_up_derived_options):
  20271. * Scripts/webkitpy/performance_tests/perftestsrunner.py:
  20272. (PerfTestsRunner.__init__):
  20273. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  20274. (HtmlGenerator.__init__):
  20275. (HtmlGenerator.show_html):
  20276. (real_main):
  20277. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  20278. (TestHtmlGenerator.make_generator):
  20279. 2011-12-19 Daniel Bates <dbates@webkit.org>
  20280. Pass command line arguments to GDB when debugging a Mac WebKit application
  20281. https://bugs.webkit.org/show_bug.cgi?id=72829
  20282. Reviewed by David Kilzer.
  20283. Pass through any command line arguments given to debug-{safari, minibrowser}
  20284. to GDB so that they may influence the application instance launched by GDB.
  20285. * Scripts/webkitdirs.pm:
  20286. (execMacWebKitAppForDebugging):
  20287. 2011-12-19 Dirk Pranke <dpranke@chromium.org>
  20288. webkitpy: remove executive,filesystem,user parameters from Port constructor
  20289. https://bugs.webkit.org/show_bug.cgi?id=74878
  20290. Reviewed by Eric Seidel.
  20291. This change concludes the refactoring that makes Host a required
  20292. parameter for Port and ensures that all access to filesystem,
  20293. executives, etc. is going through the Host.
  20294. * Scripts/webkitpy/layout_tests/port/base.py:
  20295. (Port.__init__):
  20296. 2011-12-19 Dirk Pranke <dpranke@chromium.org>
  20297. webkitpy: finish refactoring port classes to make a host mandatory
  20298. https://bugs.webkit.org/show_bug.cgi?id=74566
  20299. Reviewed by Eric Seidel.
  20300. This change makes all Port objects take a required (System)Host
  20301. parameter, and updates the TestPort object to no longer create a
  20302. mock filesystem or add files to the existing filesystem by
  20303. default.
  20304. * Scripts/webkitpy/layout_tests/port/base.py:
  20305. (Port.__init__):
  20306. * Scripts/webkitpy/layout_tests/port/factory.py:
  20307. (PortFactory.__init__):
  20308. (PortFactory._get_kwargs):
  20309. * Scripts/webkitpy/layout_tests/port/test.py:
  20310. (TestInstance.__init__):
  20311. (TestPort.__init__):
  20312. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  20313. (passing_run):
  20314. (logging_run):
  20315. (get_tests_run):
  20316. (MainTest.test_single_file):
  20317. (MainTest.test_stderr_is_saved):
  20318. (MainTest.test_test_list):
  20319. (MainTest.test_test_list_with_prefix):
  20320. (MainTest.test_missing_and_unexpected_results):
  20321. (MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
  20322. (MainTest.test_crash_with_stderr):
  20323. (MainTest.test_no_image_failure_with_image_diff):
  20324. (MainTest.test_crash_log):
  20325. (MainTest.test_web_process_crash_log):
  20326. (MainTest.test_exit_after_n_failures_upload):
  20327. (MainTest.test_results_directory_absolute):
  20328. (MainTest.test_results_directory_relative):
  20329. (MainTest.test_retries_directory):
  20330. (MainTest.test_tolerance.get_port_for_run):
  20331. (MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
  20332. (EndToEndTest.test_end_to_end):
  20333. (EndToEndTest.test_reftest_with_two_notrefs):
  20334. (RebaselineTest.test_reset_results):
  20335. (RebaselineTest.test_missing_results):
  20336. (RebaselineTest.test_new_baseline):
  20337. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  20338. (Rebaseliner.__init__):
  20339. (main):
  20340. (real_main):
  20341. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  20342. (test_host_port_and_filesystem):
  20343. (TestRebaseliner.make_rebaseliner):
  20344. (TestRealMain.test_all_platforms):
  20345. (TestHtmlGenerator.make_generator):
  20346. 2011-12-19 Dirk Pranke <dpranke@chromium.org>
  20347. webkitpy: update unit tests in preparation for making host a mandatory parameter to Port objects
  20348. https://bugs.webkit.org/show_bug.cgi?id=74562
  20349. Reviewed by Eric Seidel.
  20350. Apart from a minor change to style/checkers/test_expectations.py
  20351. to take a host as a parameter to a TestExpectationsChecker(),
  20352. there are only refactoring changes to unit tests here.
  20353. * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
  20354. (TestResultWriterTest.test_reftest_diff_image):
  20355. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  20356. (JSONGeneratorTest._test_json_generation):
  20357. (JSONGeneratorTest.test_test_timings_trie):
  20358. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  20359. (Base.__init__):
  20360. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  20361. (PortTest.make_port):
  20362. (PortTest.test_layout_tests_skipping):
  20363. (PortTest.test_test_dirs):
  20364. (PortTest.test_additional_platform_directory):
  20365. (PortTest.test_uses_test_expectations_file):
  20366. (PortTest.test_find_no_paths_specified):
  20367. (PortTest.test_find_one_test):
  20368. (PortTest.test_find_glob):
  20369. (PortTest.test_find_with_skipped_directories):
  20370. (PortTest.test_find_with_skipped_directories_2):
  20371. (PortTest.test_parse_reftest_list):
  20372. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  20373. (DryRunPort.__init__):
  20374. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  20375. (FactoryTest.setUp):
  20376. (FactoryTest.tearDown):
  20377. (FactoryTest.assert_port):
  20378. (FactoryTest.assert_platform_port):
  20379. (FactoryTest.test_unknown_specified):
  20380. (FactoryTest.test_unknown_default):
  20381. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  20382. (GetGoogleChromePortTest._verify_expectations_overrides):
  20383. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  20384. (MockDRTPortTest.make_port):
  20385. (MockDRTTest.assertTest):
  20386. (MockDRTTest.test_main):
  20387. (MockChromiumDRTTest.test_pixeltest__fails):
  20388. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  20389. (QtPortTest._assert_search_path):
  20390. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  20391. (TestWebKitPort.__init__):
  20392. (WebKitPortTest.test_skipped_directories_for_symbols):
  20393. (test_skipped_directories_for_features):
  20394. (test_skipped_layout_tests):
  20395. (test_skipped_file_search_paths):
  20396. (test_root_option):
  20397. (test_test_expectations):
  20398. (test_build_driver):
  20399. (test_linux_distro_detection):
  20400. (test_apache_config_file_name_for_platform):
  20401. (test_path_to_apache_config_file):
  20402. (WebKitDriverTest.test_read_block):
  20403. * Scripts/webkitpy/style/checkers/test_expectations.py:
  20404. (TestExpectationsChecker.__init__):
  20405. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  20406. (TestExpectationsTestCase._expect_port_for_expectations_path):
  20407. (TestExpectationsTestCase.assert_lines_lint):
  20408. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  20409. (get_test_config.TestMacPort):
  20410. 2011-12-19 Raphael Kubo da Costa <kubo@profusion.mobi>
  20411. [Efl] Fix path returned by builtDylibPathForName in webkitdirs.pm
  20412. https://bugs.webkit.org/show_bug.cgi?id=74854
  20413. Reviewed by Csaba Osztrogonác.
  20414. Since r101052, libewebkit.so is built in a different location, so we
  20415. need to adjust the path returned by builtDylibPathForName.
  20416. usesPerConfigurationBuildDirectory also needs to be fixed, as the Efl
  20417. port also respects Release/Debug configurations.
  20418. These changes should make run-launcher finally work correctly with
  20419. webkit-efl.
  20420. * Scripts/webkitdirs.pm:
  20421. (usesPerConfigurationBuildDirectory):
  20422. (builtDylibPathForName):
  20423. 2011-12-19 Simon Hausmann <simon.hausmann@nokia.com>
  20424. [Qt][WK2] Add support for modal event loop processing for WTR
  20425. https://bugs.webkit.org/show_bug.cgi?id=74852
  20426. Reviewed by Kenneth Rohde Christiansen.
  20427. Rewrote event loop processing: Instead of terminating the event loop
  20428. in notifyDone() - something no other platform does - we now respect the
  20429. "bool& condition" parameter passed to platformRunUntil. This ensures
  20430. proper termination even when the condition is changed from within a
  20431. nested event loop, because only when we _exit_ from the nested event
  20432. loop we will check the condition and terminate the test properly.
  20433. In addition this patch implements TestController::runModal by means of
  20434. a nested event loop, which is passed to the platform webview that is
  20435. supposed to be modal. It is that view's responsibility to exit the
  20436. loop, upon destruction. I believe that's similar to how it works on the Mac,
  20437. where it doesn't seem that NSApp's runModalForWindow is terminate via
  20438. abort/stopModal but simply because the window is closed.
  20439. * WebKitTestRunner/PlatformWebView.h:
  20440. (WTR::PlatformWebView::setModalEventLoop):
  20441. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  20442. (WTR::PlatformWebView::PlatformWebView):
  20443. (WTR::PlatformWebView::~PlatformWebView):
  20444. * WebKitTestRunner/qt/TestControllerQt.cpp:
  20445. (WTR::TestController::notifyDone):
  20446. (WTR::TestController::platformRunUntil):
  20447. (WTR::TestController::runModal):
  20448. 2011-12-18 Kentaro Hara <haraken@chromium.org>
  20449. REGRESSION(r103149): prepare-ChangeLog outputs a warning
  20450. https://bugs.webkit.org/show_bug.cgi?id=74808
  20451. Reviewed by David Kilzer.
  20452. Added the prototype declaration of main() to avoid warning messages.
  20453. Sorted subroutine declarations in the alphabetical order.
  20454. * Scripts/prepare-ChangeLog:
  20455. 2011-12-17 Adenilson Cavalcanti <cavalcantii@gmail.com>
  20456. [Qt] Fix QtTestBrowser compilation with QtWidgets module
  20457. https://bugs.webkit.org/show_bug.cgi?id=74791
  20458. Reviewed by Andreas Kling.
  20459. * QtTestBrowser/QtTestBrowser.pro:
  20460. 2011-12-17 Kentaro Hara <haraken@chromium.org>
  20461. Remove top-level code completely from prepare-ChangeLog
  20462. https://bugs.webkit.org/show_bug.cgi?id=74698
  20463. Reviewed by Darin Adler.
  20464. We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest manner.
  20465. This patch just moves all top-level code into main().
  20466. * Scripts/prepare-ChangeLog:
  20467. (main):
  20468. 2011-12-16 Dean Jackson <dino@apple.com>
  20469. Move webkit-bug-importer to Contributor. It won't
  20470. autocomplete as an Account.
  20471. See https://bugs.webkit.org/show_bug.cgi?id=74739
  20472. for some discussion.
  20473. Unreviewed.
  20474. * Scripts/webkitpy/common/config/committers.py:
  20475. 2011-12-16 Dean Jackson <dino@apple.com>
  20476. Add webkit-bug-importer@group.apple.com to accounts
  20477. so that it autocompletes in bugzilla.
  20478. Unreviewed.
  20479. * Scripts/webkitpy/common/config/committers.py:
  20480. 2011-12-16 Philippe Normand <pnormand@igalia.com>
  20481. Unreviewed, skipping 3 failing GTK API tests.
  20482. * Scripts/run-gtk-tests:
  20483. 2011-12-16 Philippe Normand <pnormand@igalia.com>
  20484. Unreviewed, GTK API tests build fix attempt.
  20485. * Scripts/run-gtk-tests: Run xvfb on a display not used by NRWT.
  20486. 2011-12-16 Philippe Normand <pnormand@igalia.com>
  20487. Unreviewed, unskipping GTK testdownload. Should pass on the bot now.
  20488. * Scripts/run-gtk-tests:
  20489. 2011-12-16 Simon Hausmann <simon.hausmann@nokia.com>
  20490. [Qt] Fix the build for newer Qt5
  20491. https://bugs.webkit.org/show_bug.cgi?id=74703
  20492. Reviewed by Csaba Osztrogonác.
  20493. * QtTestBrowser/launcherwindow.h: Add missing forward declaration.
  20494. * DumpRenderTree/qt/EventSenderQt.cpp:
  20495. (EventSender::sendTouchEvent): Allocate QTouchDevice and use with QTouchEvent constructor.
  20496. * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Ditto.
  20497. (WTR::EventSenderProxy::sendTouchEvent):
  20498. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  20499. (MiniBrowserApplication::sendTouchEvent): Ditto.
  20500. (MiniBrowserApplication::notify): Adapt to changed API for marking primary touch point.
  20501. 2011-12-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  20502. [Qt] Detect and force clean build when feature defines are added
  20503. Reviewed by Ossy.
  20504. https://bugs.webkit.org/show_bug.cgi?id=74689
  20505. * Scripts/webkitdirs.pm:
  20506. 2011-12-16 Kentaro Hara <haraken@chromium.org>
  20507. [Refactoring] Remove all global variables from prepare-ChangeLog
  20508. https://bugs.webkit.org/show_bug.cgi?id=74681
  20509. Reviewed by Ryosuke Niwa.
  20510. We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
  20511. manner. This bug is one of the incremental refactorings to remove all top-level
  20512. code and global variables from prepare-ChangeLog. In this patch,
  20513. we make the following global variables be used only through parameter passing.
  20514. This patch removes all global variables from prepare-ChangeLog.
  20515. - $mergeBase
  20516. - $gitCommit
  20517. - $gitIndex
  20518. * Scripts/prepare-ChangeLog:
  20519. (generateFunctionLists):
  20520. (changeLogNameFromArgs):
  20521. (changeLogEmailAddressFromArgs):
  20522. (generateNewChangeLogs):
  20523. (printDiff):
  20524. (diffFromToString):
  20525. (diffCommand):
  20526. (statusCommand):
  20527. (createPatchCommand):
  20528. (generateFileList):
  20529. (isConflictStatus):
  20530. 2011-12-15 Philippe Normand <pnormand@igalia.com>
  20531. [GTK] Rounding errors on 32-bit machines causes tests to fail
  20532. https://bugs.webkit.org/show_bug.cgi?id=72254
  20533. Initial patch by vanuan@gmail.com.
  20534. Reviewed by Martin Robinson.
  20535. * Scripts/webkitdirs.pm:
  20536. (runAutogenForAutotoolsProjectIfNecessary): Pass additional
  20537. CXXFLAGS to autogen in an attempt to harmonize floating point
  20538. values between 32-bit and 64-bit architectures.
  20539. 2011-12-16 Martin Robinson <mrobinson@igalia.com>
  20540. [GTK] Make distcheck fails during the install
  20541. https://bugs.webkit.org/show_bug.cgi?id=74274
  20542. No review, since this is a build fix.
  20543. * GNUmakefile.am: Remove BUILT_SOURCES from the dependency list for the gtkdoc
  20544. step. BUILT_SOURCES includes forwarding header generation for WebKit2, which
  20545. always runs. This means that the gtkdoc step was always running when make was
  20546. invoked. Generating gtkdoc during 'make install' was triggering a race condition
  20547. with the library file. Later we can fix generate-forwarding-headers and unbreak
  20548. 'make docs,' but this bandaid is sufficient to let us release.
  20549. 2011-12-15 Eric Seidel <eric@webkit.org>
  20550. NRWT should use free + inactive memory for default_child_processes on OS X (and never return < 1 process)
  20551. https://bugs.webkit.org/show_bug.cgi?id=74650
  20552. Reviewed by Adam Barth.
  20553. * Scripts/webkitpy/common/system/platforminfo.py:
  20554. (PlatformInfo._compute_bytes_from_vm_stat_output):
  20555. * Scripts/webkitpy/layout_tests/port/base.py:
  20556. (Port.default_child_processes):
  20557. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  20558. (PortTest.test_default_child_processes):
  20559. 2011-12-15 Filip Pizlo <fpizlo@apple.com>
  20560. bencher script should support remote benchmarking on platforms that don't have ruby
  20561. https://bugs.webkit.org/show_bug.cgi?id=74659
  20562. Rubber-stamped by Sam Weinig.
  20563. Added the ability to have bencher generate a benchmarking playload that consists of
  20564. copies of all of the benchmarks, optionally copies of all of the frameworks and
  20565. binaries to run all of the VMs, and a sh script that runs the benchmarks in random
  20566. order, which then spits out a raw results file that bencher can parse.
  20567. In normal operating mode, you never see this, as it just generates the payload and
  20568. script internally, runs it, parses the results, and spits them out.
  20569. The --remote mode has been changed to use this style, so any remote host that has
  20570. sshd, passwordless login support, a ~/.bencher file that points to a "tempPath", and
  20571. a sh-compatible shell can be used for remote benchmarking.
  20572. The feature to include VMs in the benchmarking payload is by default only activated
  20573. when using --remote, but it can also be activated when doing local benchmarking; the
  20574. benefit is that you remove any pathname-related performance pathologies. All VMs
  20575. become equal because they are all located in
  20576. /path/to/bencher/directory/temp/benchdata/vmN where N is the configuration number
  20577. (usually 0 or 1).
  20578. Also fixed bugs in the DumpRenderTree support. It's now possible to run all benchmarks
  20579. through DumpRenderTree. This is only a bit slower than running in jsc.
  20580. * Scripts/bencher:
  20581. 2011-12-15 Dirk Pranke <dpranke@chromium.org>
  20582. webkitpy: clean up TestPort to (mostly) not create a new filesystem
  20583. https://bugs.webkit.org/show_bug.cgi?id=74556
  20584. This change modifies the TestPort to be ready to add tests to an
  20585. existing filesystem instead of creating a new filesystem; we
  20586. leave unit_test_filesystem() in for now for compatibility.
  20587. * Scripts/webkitpy/common/host_mock.py:
  20588. (MockHost.__init__):
  20589. - call add_unit_tests_to_mock_filesystem by default to make
  20590. the MockHost more generally useful for layout_test unit tests.
  20591. * Scripts/webkitpy/layout_tests/port/test.py:
  20592. (TestInstance.__init__):
  20593. (add_unit_tests_to_mock_filesystem):
  20594. (add_file):
  20595. (unit_test_filesystem):
  20596. (TestPort.__init__):
  20597. (TestPort._set_default_overriding_none):
  20598. 2011-12-15 Dirk Pranke <dpranke@chromium.org>
  20599. webkitpy: cleanup prior to systemhostifying the layout_test/port* classes
  20600. https://bugs.webkit.org/show_bug.cgi?id=74551
  20601. This is some minor cleanup prior to making all of the host/port
  20602. changes described in bug 74138.
  20603. * Scripts/webkitpy/common/host_mock.py:
  20604. (MockHost.__init__):
  20605. - make sure the scm object is initialized with the same mock
  20606. executive and filesystem objects.
  20607. * Scripts/webkitpy/common/system/filesystem_mock.py:
  20608. (MockFileSystem.clear_written_files):
  20609. - add a routine that will be useful in testing.
  20610. (MockFileSystem.maybe_make_directory):
  20611. (MockFileSystem.write_binary_file):
  20612. - fix bugs to make sure directories are created properly.
  20613. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  20614. (_Process.run):
  20615. - add clarifying comments.
  20616. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  20617. (MockDRTPort.__init__):
  20618. (MockDRT.__init__):
  20619. - add clarifying comments.
  20620. 2011-12-15 Anders Carlsson <andersca@apple.com>
  20621. Regression (r102866): Navigating away from or closing a page with a plugin crashes
  20622. https://bugs.webkit.org/show_bug.cgi?id=74655
  20623. Reviewed by Sam Weinig.
  20624. Add a bunch of tests.
  20625. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20626. 2011-12-15 Stephanie Lewis <slewis@apple.com>
  20627. https://bugs.webkit.org/show_bug.cgi?id=74469
  20628. Escape paths to svn commands so our tools can handle filenames with @ symbols.
  20629. Reviewed by Adam Roben.
  20630. * Scripts/VCSUtils.pm:
  20631. (scmMoveOrRenameFile):
  20632. (scmAddExecutableBit):
  20633. (scmRemoveExecutableBit):
  20634. (determineSVNRoot):
  20635. (svnRevisionForDirectory):
  20636. (pathRelativeToSVNRepositoryRootForPath):
  20637. (svnStatus):
  20638. (escapeSubversionPath):
  20639. * Scripts/parse-malloc-history:
  20640. (main):
  20641. * Scripts/prepare-ChangeLog:
  20642. (diffCommand):
  20643. (statusCommand):
  20644. (findOriginalFileFromSvn):
  20645. (determinePropertyChanges):
  20646. * Scripts/resolve-ChangeLogs:
  20647. (conflictFiles):
  20648. (resolveConflict):
  20649. (showStatus):
  20650. * Scripts/svn-apply:
  20651. (patch):
  20652. (scmCopy):
  20653. (scmAdd):
  20654. (scmRemove):
  20655. * Scripts/svn-create-patch:
  20656. (findBaseUrl):
  20657. (findMimeType):
  20658. (findSourceFileAndRevision):
  20659. (generateDiff):
  20660. (generateFileList):
  20661. (manufacturePatchForAdditionWithHistory):
  20662. * Scripts/svn-unapply:
  20663. (patch):
  20664. (revertDirectories):
  20665. 2011-12-15 Michael Bruning <michael.bruning@nokia.com>
  20666. [qt][wk2] MiniBrowser: Add pressed state for viewport info button.
  20667. https://bugs.webkit.org/show_bug.cgi?id=74617
  20668. Reviewed by Kenneth Rohde Christiansen.
  20669. * MiniBrowser/qt/qml/BrowserWindow.qml: Added state dependent coloring
  20670. for viewport info button, adjusted height and added rounded corners.
  20671. 2011-12-15 Andy Estes <aestes@apple.com>
  20672. TestFailures: store the name of the buildbot results directory in a property
  20673. https://bugs.webkit.org/show_bug.cgi?id=74663
  20674. Reviewed by Adam Barth.
  20675. Store the name of the results directory as a property on Buildbot's
  20676. prototype. This allows subclasses of Buildbot to customize the results
  20677. directory.
  20678. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js:
  20679. (Buildbot.prototype.resultsDirectoryURL):
  20680. 2011-12-15 Tony Chang <tony@chromium.org>
  20681. [chromium] pass --delete_unversioned_trees to gclient on the bots
  20682. https://bugs.webkit.org/show_bug.cgi?id=74565
  20683. Reviewed by Kenneth Russell.
  20684. It was temporarily removed in r102891 to keep the bots green. Now
  20685. that the bots have cycled, we can add it back.
  20686. * Scripts/update-webkit-chromium:
  20687. 2011-12-15 Kentaro Hara <haraken@chromium.org>
  20688. [Refactoring] In prepare-ChangeLog, make several global variables be used only through parameter passing
  20689. https://bugs.webkit.org/show_bug.cgi?id=74497
  20690. Reviewed by Ryosuke Niwa.
  20691. We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
  20692. manner. This bug is one of the incremental refactorings to remove all top-level
  20693. code and global variables from prepare-ChangeLog. In this patch,
  20694. we make the following global variables be used only through parameter passing.
  20695. - $bugDescription
  20696. - $bugNumber
  20697. - $name
  20698. - $emailAddress
  20699. - $gitReviewer
  20700. - $writeChangeLogs
  20701. * Scripts/prepare-ChangeLog:
  20702. (fetchBugDescriptionFromURL):
  20703. (generateNewChangeLogs):
  20704. (reviewerAndDescriptionForGitCommit):
  20705. 2011-12-15 Raphael Kubo da Costa <kubo@profusion.mobi>
  20706. [EFL] Add a few more web database functions to ewk_settings.
  20707. https://bugs.webkit.org/show_bug.cgi?id=72148
  20708. Reviewed by Antonio Gomes.
  20709. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  20710. (LayoutTestController::clearAllDatabases):
  20711. (LayoutTestController::setDatabaseQuota):
  20712. 2011-12-15 Martin Kosiba <mkosiba@google.com>
  20713. Fix find on web pages with -webkit-user-select: none for Chromium
  20714. https://bugs.webkit.org/show_bug.cgi?id=72281
  20715. Reviewed by Ryosuke Niwa.
  20716. Provided a partial findString implementation. This doesn't support
  20717. all of the FindOptions since they're not exposed via WebFindOptions.
  20718. * DumpRenderTree/chromium/LayoutTestController.cpp:
  20719. (LayoutTestController::LayoutTestController):
  20720. (LayoutTestController::findString):
  20721. * DumpRenderTree/chromium/LayoutTestController.h:
  20722. 2011-12-15 Kenneth Russell <kbr@google.com>
  20723. [chromium] Add DRT support for WebKitPageCacheSupportsPluginsPreferenceKey
  20724. https://bugs.webkit.org/show_bug.cgi?id=74581
  20725. Reviewed by Darin Fisher.
  20726. * DumpRenderTree/chromium/LayoutTestController.cpp:
  20727. (LayoutTestController::overridePreference):
  20728. * DumpRenderTree/chromium/WebPreferences.cpp:
  20729. (WebPreferences::reset):
  20730. (WebPreferences::applyTo):
  20731. * DumpRenderTree/chromium/WebPreferences.h:
  20732. 2011-12-15 Kenneth Rohde Christiansen <kenneth@webkit.org>
  20733. [Qt] Improve the look of the viewport info overlay
  20734. Reviewed by Tor Arne Vestbø.
  20735. * MiniBrowser/qt/qml/ViewportInfoItem.qml:
  20736. 2011-12-15 Igor Oliveira <igor.oliveira@openbossa.org>
  20737. [Qt] Support requestAnimationFrame API
  20738. https://bugs.webkit.org/show_bug.cgi?id=74528
  20739. Add build-option for requestAnimationFrame feature.
  20740. Reviewed by Kenneth Rohde Christiansen.
  20741. * qmake/mkspecs/features/features.prf:
  20742. 2011-12-15 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  20743. [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
  20744. Reviewed by Simon Hausmann.
  20745. * qmake/mkspecs/features/webcore.prf:
  20746. 2011-12-15 Michael Brüning <michael.bruning@nokia.com>
  20747. [QT][WK2]Add (experimental) viewport info view to Minibrowser/qt.
  20748. https://bugs.webkit.org/show_bug.cgi?id=72893
  20749. Reviewed by Kenneth Rohde Christiansen.
  20750. This patch extends QQuickWebViewExperimental by a property named
  20751. viewportInfo, which contains the viewport scalability and
  20752. layout and contents size information. This property is exposed to
  20753. QML through the experimental extension for QQuickWebView.
  20754. * MiniBrowser/qt/MiniBrowser.pro:
  20755. * MiniBrowser/qt/MiniBrowser.qrc:
  20756. * MiniBrowser/qt/icons/info.png: Added.
  20757. * MiniBrowser/qt/qml/BrowserWindow.qml:
  20758. * MiniBrowser/qt/qml/ViewportInfoItem.qml: Added.
  20759. 2011-12-15 Shinya Kawanaka <shinyak@google.com>
  20760. [chromium] WebViewHost::requestCheckingOfText should return immediately if text is empty.
  20761. https://bugs.webkit.org/show_bug.cgi?id=74586
  20762. Reviewed by Hajime Morita.
  20763. No new tests. Covered by existing tests.
  20764. * DumpRenderTree/chromium/WebViewHost.cpp:
  20765. (WebViewHost::requestCheckingOfText):
  20766. Returns immediately if text is empty.
  20767. 2011-12-15 Alexander Færøy <ahf@0x90.dk>
  20768. [Qt] QtWebKit fails to build on Mac OS X after r102776
  20769. https://bugs.webkit.org/show_bug.cgi?id=74593
  20770. Reviewed by Simon Hausmann.
  20771. CONFIG =+ link_pkgconfig is needed such that the correct parameters
  20772. are passed to the compiler.
  20773. * DumpRenderTree/qt/DumpRenderTree.pro:
  20774. 2011-12-14 Tony Chang <tony@chromium.org>
  20775. [chromium] Remove redundant third_party entries from chromium DEPS
  20776. https://bugs.webkit.org/show_bug.cgi?id=74472
  20777. Reviewed by Kenneth Russell.
  20778. * Scripts/update-webkit-chromium: Temporarily keep unversioned trees.
  20779. 2011-12-14 Kentaro Hara <haraken@chromium.org>
  20780. [Refactoring] In prepare-ChangeLog, replace $isGit and $isSVN with
  20781. VCSUtils::isGit() and VCSUtils::isSVN().
  20782. https://bugs.webkit.org/show_bug.cgi?id=74485
  20783. Reviewed by David Kilzer.
  20784. We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
  20785. manner. This bug is one of the incremental refactorings to remove all top-level
  20786. code and global variables from prepare-ChangeLog. This patch replaces $isGit and $isSVN
  20787. with VCSUtils::isGit() and VCSUtils::isSVN(). This patch also removes firstDirectoryOrCwd(),
  20788. assuming that no user will mix Git/SVN checkouts and thus we can judge SVN or Git
  20789. just by looking at the current working directory.
  20790. * Scripts/prepare-ChangeLog: Removed firstDirectoryOrCwd().
  20791. (diffFromToString):
  20792. (diffCommand):
  20793. (statusCommand):
  20794. (createPatchCommand):
  20795. (diffHeaderFormat):
  20796. (generateFileList):
  20797. (isAddedStatus):
  20798. (isConflictStatus):
  20799. (statusDescription):
  20800. (extractLineRange):
  20801. 2011-12-14 Sam Weinig <weinig@apple.com>
  20802. Remove whitespace from InheritedPropertySheets attributes in
  20803. vsprops files to appease the Visual Studio project migrator.
  20804. Reviewed by Adam Roben.
  20805. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops:
  20806. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops:
  20807. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops:
  20808. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
  20809. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
  20810. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
  20811. * DumpRenderTree/win/DumpRenderTreeDebug.vsprops:
  20812. * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops:
  20813. * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops:
  20814. * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
  20815. * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
  20816. * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
  20817. * DumpRenderTree/win/ImageDiffDebug.vsprops:
  20818. * DumpRenderTree/win/ImageDiffDebugAll.vsprops:
  20819. * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops:
  20820. * DumpRenderTree/win/ImageDiffProduction.vsprops:
  20821. * DumpRenderTree/win/ImageDiffRelease.vsprops:
  20822. * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
  20823. * MiniBrowser/Configurations/MiniBrowserDebug.vsprops:
  20824. * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops:
  20825. * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops:
  20826. * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
  20827. * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
  20828. * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
  20829. * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
  20830. * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
  20831. * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops:
  20832. * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops:
  20833. * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops:
  20834. * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
  20835. * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
  20836. * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
  20837. * WebKitTestRunner/win/InjectedBundleDebug.vsprops:
  20838. * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops:
  20839. * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops:
  20840. * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
  20841. * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
  20842. * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
  20843. * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops:
  20844. * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops:
  20845. * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops:
  20846. * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
  20847. * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
  20848. * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
  20849. * WinLauncher/WinLauncherDebug.vsprops:
  20850. * WinLauncher/WinLauncherDebugAll.vsprops:
  20851. * WinLauncher/WinLauncherDebugCairoCFLite.vsprops:
  20852. * WinLauncher/WinLauncherProduction.vsprops:
  20853. * WinLauncher/WinLauncherRelease.vsprops:
  20854. * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
  20855. * record-memory-win/record-memory-winDebug.vsprops:
  20856. * record-memory-win/record-memory-winDebugAll.vsprops:
  20857. * record-memory-win/record-memory-winDebugCairoCFLite.vsprops:
  20858. * record-memory-win/record-memory-winProduction.vsprops:
  20859. * record-memory-win/record-memory-winRelease.vsprops:
  20860. * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
  20861. 2011-12-14 Anders Carlsson <andersca@apple.com>
  20862. Windows build fix.
  20863. Move CHECKs out of the destructor.
  20864. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20865. (TestWebKitAPI::B::~B):
  20866. (TestWebKitAPI::TEST):
  20867. 2011-12-14 Anders Carlsson <andersca@apple.com>
  20868. binding a member function should ref/deref the object pointer if needed
  20869. https://bugs.webkit.org/show_bug.cgi?id=74552
  20870. Reviewed by Sam Weinig.
  20871. Add new tests.
  20872. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20873. (TestWebKitAPI::B::B):
  20874. (TestWebKitAPI::B::~B):
  20875. (TestWebKitAPI::B::ref):
  20876. (TestWebKitAPI::B::deref):
  20877. (TestWebKitAPI::B::f):
  20878. (TestWebKitAPI::B::g):
  20879. (TestWebKitAPI::TEST):
  20880. 2011-12-14 Hajime Morrita <morrita@chromium.org>
  20881. JS_INLINE and WTF_INLINE should be visible from WebCore
  20882. https://bugs.webkit.org/show_bug.cgi?id=73191
  20883. Reviewed by Kevin Ollivier.
  20884. Removed macro definitions which is now provided by Platform.h
  20885. * DumpRenderTree/chromium/config.h:
  20886. * DumpRenderTree/config.h:
  20887. * DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h: Added.
  20888. * DumpRenderTree/ForwardingHeaders/wtf/ExportMacros.h: Added.
  20889. * DumpRenderTree/win/DumpRenderTreePreBuild.cmd: Add new ForwardingHeaders.
  20890. * TestWebKitAPI/config.h:
  20891. * WebKitTestRunner/config.h:
  20892. 2011-12-14 Kentaro Hara <haraken@chromium.org>
  20893. Unreviewed, rolling out r102761.
  20894. http://trac.webkit.org/changeset/102761
  20895. https://bugs.webkit.org/show_bug.cgi?id=74485
  20896. we came up with a better fix than this (see comments in bug
  20897. 74485)
  20898. * Scripts/prepare-ChangeLog:
  20899. (generateFunctionLists):
  20900. (printDiff):
  20901. (diffCommand):
  20902. (statusCommand):
  20903. (createPatchCommand):
  20904. (generateFileList):
  20905. (isAddedStatus):
  20906. (isConflictStatus):
  20907. (statusDescription):
  20908. (extractLineRange):
  20909. 2011-12-14 Anders Carlsson <andersca@apple.com>
  20910. Work around a bug in the MSVC2005 compiler
  20911. https://bugs.webkit.org/show_bug.cgi?id=74550
  20912. Reviewed by Sam Weinig.
  20913. Re-enable tests.
  20914. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20915. 2011-12-14 Csaba Osztrogonác <ossy@webkit.org>
  20916. [Qt] Test fonts are not used with Qt5
  20917. https://bugs.webkit.org/show_bug.cgi?id=72513
  20918. My last unreviewed buildfix for this crazy bug.
  20919. * qmake/mkspecs/features/features.prf:
  20920. 2011-12-14 Anders Carlsson <andersca@apple.com>
  20921. Another attempt at fixing the Windows build.
  20922. Disable all the tests until I can figure out what's going on here.
  20923. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20924. 2011-12-14 Anders Carlsson <andersca@apple.com>
  20925. Fix the Windows build.
  20926. Disable some of the tests for now.
  20927. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20928. 2011-12-14 Anders Carlsson <andersca@apple.com>
  20929. bind should handle member functions
  20930. https://bugs.webkit.org/show_bug.cgi?id=74529
  20931. Reviewed by Sam Weinig.
  20932. Add tests.
  20933. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20934. (TestWebKitAPI::A::A):
  20935. (TestWebKitAPI::A::f):
  20936. (TestWebKitAPI::A::addF):
  20937. (TestWebKitAPI::TEST):
  20938. 2011-12-14 Anders Carlsson <andersca@apple.com>
  20939. Add unary and binary bind overloads
  20940. https://bugs.webkit.org/show_bug.cgi?id=74524
  20941. Reviewed by Sam Weinig.
  20942. Add tests.
  20943. * TestWebKitAPI/Tests/WTF/Functional.cpp:
  20944. (TestWebKitAPI::TEST):
  20945. (TestWebKitAPI::multiplyByTwo):
  20946. (TestWebKitAPI::multiplyByOneAndAHalf):
  20947. (TestWebKitAPI::multiply):
  20948. (TestWebKitAPI::subtract):
  20949. 2011-12-14 Holger Hans Peter Freyther <holger@moiji-mobile.com>
  20950. [Qt] Test fonts are not used with Qt5
  20951. https://bugs.webkit.org/show_bug.cgi?id=72513
  20952. MIPS and SH4 buildfix after r102776 and r102795.
  20953. Reviewed by Csaba Osztrogonác.
  20954. * qmake/mkspecs/features/features.prf:
  20955. 2011-12-14 Csaba Osztrogonác <ossy@webkit.org>
  20956. [Qt] Unreviewed speculative MIPS and SH4 buildfix after r102776.
  20957. * qmake/mkspecs/features/features.prf:
  20958. 2011-12-14 Andreas Kling <kling@webkit.org>
  20959. Make my e-mail address a little more awesome.
  20960. * Scripts/webkitpy/common/config/committers.py:
  20961. 2011-12-14 Csaba Osztrogonác <ossy@webkit.org>
  20962. [Qt] Rollout r102769, because it broke Qt-4.8 builds.
  20963. * qmake/mkspecs/features/webcore.prf:
  20964. 2011-12-14 Balazs Kelemen <kbalazs@webkit.org>
  20965. [Qt] Test fonts are not used with Qt5
  20966. https://bugs.webkit.org/show_bug.cgi?id=72513
  20967. Reviewed by Simon Hausmann.
  20968. Don't depend on Q_WS_X11 anymore since it's not the Qt5
  20969. way to detect the platform. Make the guards depend
  20970. on our own configtest for fontconfig. For Qt4 we can still
  20971. use the preassumption that we have it on Linux.
  20972. * DumpRenderTree/qt/DumpRenderTree.pro:
  20973. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  20974. (WebCore::DumpRenderTree::open):
  20975. (WebCore::DumpRenderTree::initializeFonts):
  20976. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  20977. * DumpRenderTree/qt/main.cpp:
  20978. (main): Additionally remove a nonsense piece of code that was
  20979. trying to reset the font settings - which is not necessary -
  20980. after we have already returned from main.
  20981. * WebKitTestRunner/InjectedBundle/Target.pri:
  20982. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  20983. (WTR::activateFonts):
  20984. * WebKitTestRunner/Target.pri: Remove unnecessary fontconfig linkage
  20985. from WTR. It is not needed. We set up the fonts via the injected bundle.
  20986. * qmake/config.tests/fontconfig/fontconfig.cpp: Added.
  20987. (main):
  20988. * qmake/config.tests/fontconfig/fontconfig.pro: Added.
  20989. * qmake/mkspecs/features/features.prf:
  20990. * qmake/sync.profile:
  20991. 2011-12-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  20992. [Qt] Don't add WebCoreSupport and WebKit APIs to include WebCore's include path
  20993. Followup to r102679
  20994. https://bugs.webkit.org/show_bug.cgi?id=74413
  20995. Reviewed by Simon Hausmann.
  20996. * qmake/mkspecs/features/webcore.prf:
  20997. 2011-12-14 Pierre Rossi <pierre.rossi@gmail.com>
  20998. [Qt] Mobile theme could use a little refresh
  20999. https://bugs.webkit.org/show_bug.cgi?id=74293
  21000. Have MiniBrowser use the mobile theme when not
  21001. passed --desktop.
  21002. Reviewed by Kenneth Rohde Christiansen.
  21003. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  21004. (MiniBrowserApplication::handleUserOptions):
  21005. 2011-12-14 João Paulo Rechi Vita <jprvita@openbossa.org>
  21006. [Qt] [Gardening] Remove qt-4.7 layout tests dir
  21007. https://bugs.webkit.org/show_bug.cgi?id=74426
  21008. Building trunk now depends on Qt >= 4.8, so no need to keep this directory
  21009. on the tree.
  21010. Reviewed by Csaba Osztrogonác.
  21011. * Scripts/webkitpy/layout_tests/port/qt.py:
  21012. (QtPort.qt_version):
  21013. (QtPort.baseline_search_path):
  21014. (QtPort._skipped_file_search_paths):
  21015. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  21016. (QtPortTest._assert_search_path):
  21017. 2011-12-14 Kentaro Hara <haraken@chromium.org>
  21018. [Refactoring] In prepare-ChangeLog, make $isGit and $isSVN be used only
  21019. through parameter passing
  21020. https://bugs.webkit.org/show_bug.cgi?id=74485
  21021. Reviewed by Ryosuke Niwa.
  21022. We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
  21023. manner. This bug is one of the incremental refactorings to remove all top-level
  21024. code and global variables from prepare-ChangeLog. In this patch,
  21025. we make the following global variables be used only through parameter passing.
  21026. - $isGit
  21027. - $isSVN
  21028. * Scripts/prepare-ChangeLog:
  21029. (generateFunctionLists):
  21030. (printDiff):
  21031. (diffFromToString):
  21032. (diffCommand):
  21033. (statusCommand):
  21034. (createPatchCommand):
  21035. (diffHeaderFormat):
  21036. (generateFileList):
  21037. (isAddedStatus):
  21038. (isConflictStatus):
  21039. (statusDescription):
  21040. (extractLineRange):
  21041. 2011-12-14 Alexander Færøy <alexander.faeroy@nokia.com>
  21042. [Qt] DeviceOrientationClientMockQt should be removed in favor of DeviceOrientationClientMock
  21043. https://bugs.webkit.org/show_bug.cgi?id=74417
  21044. Reviewed by Simon Hausmann.
  21045. Based on original patch by Kenneth Christiansen.
  21046. Already covered by current tests.
  21047. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  21048. (WebCore::DumpRenderTree::DumpRenderTree):
  21049. (WebCore::DumpRenderTree::~DumpRenderTree):
  21050. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  21051. (LayoutTestController::setMockDeviceOrientation):
  21052. 2011-12-03 Philippe Normand <pnormand@igalia.com>
  21053. [GTK] Bad text rendering since r101343
  21054. https://bugs.webkit.org/show_bug.cgi?id=73744
  21055. Reviewed by Martin Robinson.
  21056. Turn cairo hint metrics off for better font metrics reporting in
  21057. the tests. This is especially important for SVG.
  21058. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  21059. (initializeGtkFontSettings):
  21060. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  21061. (WTR::initializeGtkSettings):
  21062. 2011-12-13 Kentaro Hara <haraken@chromium.org>
  21063. [Refactoring] Remove several global variables from prepare-ChangeLog
  21064. https://bugs.webkit.org/show_bug.cgi?id=74389
  21065. Reviewed by David Kilzer.
  21066. We are planning to write unit-tests for prepare-ChangeLog in a run-leaks_unittest
  21067. manner. This bug is one of the incremental refactorings to remove all top-level
  21068. code and global variables from prepare-ChangeLog. In this patch,
  21069. we make the following global variables being used only through parameter passing.
  21070. - %paths
  21071. - $changedFiles
  21072. - $conflictFiles
  21073. - $functionLists
  21074. - $bugURL
  21075. * Scripts/prepare-ChangeLog:
  21076. (findChangeLogs):
  21077. (generateNewChangeLogs):
  21078. (processPaths):
  21079. (generateFileList):
  21080. (firstDirectoryOrCwd):
  21081. 2011-12-13 Anders Carlsson <andersca@apple.com>
  21082. Add a very bare-bones implementation of bind and Function to WTF
  21083. https://bugs.webkit.org/show_bug.cgi?id=74462
  21084. Reviewed by Sam Weinig.
  21085. Add basic tests for WTF::Function and WTF::bind.
  21086. * TestWebKitAPI/TestWebKitAPI.gypi:
  21087. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  21088. * TestWebKitAPI/Tests/Functional.cpp: Added.
  21089. (TestWebKitAPI::returnFortyTwo):
  21090. (TestWebKitAPI::TEST):
  21091. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  21092. 2011-12-13 Robin Dunn <robin@alldunn.com>
  21093. [wx] Add a URL argument to wxWebView constructor.
  21094. https://bugs.webkit.org/show_bug.cgi?id=74316
  21095. Reviewed by Kevin Ollivier.
  21096. * DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  21097. (MyApp::OnInit):
  21098. * wx/browser/browser.cpp:
  21099. (MyApp::OnInit):
  21100. 2011-12-13 Raphael Kubo da Costa <kubo@profusion.mobi>
  21101. watchlist: Add watchlist for EFL, CMake and libsoup code and put myself on it.
  21102. https://bugs.webkit.org/show_bug.cgi?id=74430
  21103. Reviewed by David Levin.
  21104. * Scripts/webkitpy/common/config/watchlist:
  21105. 2011-12-13 Peter Beverloo <peter@chromium.org>
  21106. [Chromium] Pull in FreeType and decrease check-out complexity for Android
  21107. https://bugs.webkit.org/show_bug.cgi?id=74401
  21108. Decrease the check-out complexity by removing the need to first run
  21109. "update-webkit-chromium --chromium" prior to running it with
  21110. "--chromium-android", which was caused by an unversioned third_party/
  21111. directory being created. This moves the Android NDK to Source/WebKit/
  21112. chromium/, coming from third_party/ in that directory.
  21113. Reviewed by Adam Barth.
  21114. * Scripts/update-webkit-chromium:
  21115. * Scripts/webkitdirs.pm:
  21116. (buildChromiumMakefile):
  21117. 2011-12-13 Andy Wingo <wingo@igalia.com> and Martin Robinson <mrobinson@igalia.com>
  21118. build-jsc passing incorrect args to buildGtkProject
  21119. https://bugs.webkit.org/show_bug.cgi?id=74308
  21120. Reviewed by Gustavo Noronha Silva.
  21121. * Scripts/build-webkit: Instead of invoking buildGtkProject with
  21122. another argument about webkit2, unshift a --disable-webkit2
  21123. argument onto the buildArgs.
  21124. * Scripts/webkitdirs.pm: Remove $enableWebKit2 arg. Only save autogen.sh
  21125. arguments for WebKit to prevent unnecessary reconfiguration when build-webkit
  21126. and build-jsc are run one after the other.
  21127. 2011-12-13 Csaba Osztrogonác <ossy@webkit.org>
  21128. [Qt] REGRESSION(102679): It broke Qt5-WK1 build
  21129. https://bugs.webkit.org/show_bug.cgi?id=74413
  21130. Unreviewed buildfix.
  21131. * qmake/mkspecs/features/webcore.prf: Temporarily revert a part of r102679 until a proper fix.
  21132. 2011-12-13 Csaba Osztrogonác <ossy@webkit.org>
  21133. [Qt] Unreviewed speculativ debug buildfix after r102679.
  21134. * QtTestBrowser/QtTestBrowser.pro:
  21135. * QtTestBrowser/main.cpp:
  21136. 2011-12-13 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  21137. [Qt] Get rid of layering violations in includes
  21138. WebKit/qt/API and WebKit/qt/WebCoreSupport should not be included
  21139. in the webcore.prf, but rather in each target that specificly needs
  21140. headers in these location. We used to include them directly in webcore
  21141. since we had layering violations between WebCore and WebKit, but now
  21142. that they are gone there's no reason to do that.
  21143. Reviewed by Simon Hausmann.
  21144. * DumpRenderTree/qt/DumpRenderTree.pro:
  21145. * QtTestBrowser/launcherwindow.h:
  21146. * WebKitTestRunner/InjectedBundle/Target.pri:
  21147. * qmake/mkspecs/features/webcore.prf:
  21148. * qmake/mkspecs/features/webkit2.prf:
  21149. 2011-12-13 János Badics <dicska@gmail.com>
  21150. [NRWT] It crashes intermittently when there are WebProcess crashes
  21151. https://bugs.webkit.org/show_bug.cgi?id=73451
  21152. Use self.poll() instead of self._proc.poll() because it checks if self._proc is None or not.
  21153. Reviewed by Kenneth Rohde Christiansen.
  21154. * Scripts/webkitpy/layout_tests/port/server_process.py:
  21155. (ServerProcess._check_for_crash):
  21156. 2011-12-13 Carlos Garcia Campos <cgarcia@igalia.com>
  21157. Unreviewed. Fix GTK+ API docs build.
  21158. * gtk/generate-gtkdoc:
  21159. (get_webkit2_options): Ignore WebKitUIClient since it's private
  21160. API.
  21161. 2011-12-13 Kenichi Ishibashi <bashi@chromium.org>
  21162. Reviewed, removed one of my email addresses to use the apprpriate one.
  21163. * Scripts/webkitpy/common/config/committers.py:
  21164. 2011-12-12 Ádám Kallai <Kallai.Adam@stud.u-szeged.hu>
  21165. [Qt] Fix skip list search path and expected file search path in ORWT
  21166. https://bugs.webkit.org/show_bug.cgi?id=74281
  21167. Expected file search path fixed.
  21168. Print all used skipped list and expected search path in verbose mode similar to NRWT.
  21169. Reviewed by Csaba Osztrogonác.
  21170. * Scripts/old-run-webkit-tests:
  21171. (buildPlatformResultHierarchy):
  21172. (buildPlatformTestHierarchy):
  21173. (readSkippedFiles):
  21174. 2011-12-12 Nándor Huszka <huszka.nandor@stud.u-szeged.hu>
  21175. [Qt] Missing layoutTestController.dumpWillCacheResponse
  21176. https://bugs.webkit.org/show_bug.cgi?id=74287
  21177. Reviewed by Csaba Osztrogonác.
  21178. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  21179. (LayoutTestController::reset):
  21180. (LayoutTestController::dumpWillCacheResponse):
  21181. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  21182. 2011-12-12 Martin Robinson <mrobinson@igalia.com>
  21183. [GTK] platform/gtk/fonts/custom-font-missing-glyphs.html fails on 64-bit Debug
  21184. https://bugs.webkit.org/show_bug.cgi?id=73771
  21185. Reviewed by Gustavo Noronha Silva.
  21186. When using a fallback font during testing, always use DejaVu Sans. This prevents
  21187. falling back to DejaVu Serif on some systems.
  21188. * DumpRenderTree/gtk/fonts/fonts.conf: Fall back to DejaVu Sans.
  21189. 2011-12-08 Pierre Rossi <pierre.rossi@gmail.com>
  21190. Add myself as a committer
  21191. * Scripts/webkitpy/common/config/committers.py:
  21192. 2011-12-12 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  21193. [Qt] [WK2] Support customizing popup menus with QML
  21194. https://bugs.webkit.org/show_bug.cgi?id=73560
  21195. Reviewed by Tor Arne Vestbø.
  21196. Add an Item Selector to our WebView using the experimental API.
  21197. * MiniBrowser/qt/MiniBrowser.pro:
  21198. * MiniBrowser/qt/MiniBrowser.qrc:
  21199. * MiniBrowser/qt/qml/BrowserWindow.qml:
  21200. * MiniBrowser/qt/qml/ItemSelector.qml: Added.
  21201. 2011-12-12 Alexander Færøy <alexander.faeroy@nokia.com>
  21202. [Qt] MiniBrowser should only visualize mock touch points when in non-desktop mode
  21203. https://bugs.webkit.org/show_bug.cgi?id=74283
  21204. Reviewed by Simon Hausmann.
  21205. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  21206. (MiniBrowserApplication::sendTouchEvent):
  21207. 2011-12-12 Kentaro Hara <haraken@chromium.org>
  21208. [Refactoring] In prepare-ChangeLog, move into a method the top-level code
  21209. to show ChangeLogs diff and open ChangeLogs in an editor
  21210. https://bugs.webkit.org/show_bug.cgi?id=74266
  21211. Reviewed by Ryosuke Niwa.
  21212. We are planning to write unit-tests for prepare-ChangeLog
  21213. in a run-leaks_unittest manner. This patch is one of the incremental
  21214. refactorings to remove all top-level code and global variables from
  21215. prepare-ChangeLog.
  21216. * Scripts/prepare-ChangeLog: Moved the top-level code to show ChangeLogs diff into printDiff().
  21217. Moved the top-level code to open ChangeLogs in an editor into openChangeLogs().
  21218. Renamed @changed_files to @changedFiles.
  21219. Renamed %conflict_files to %conflictFiles.
  21220. (generateFunctionLists):
  21221. (printDiff):
  21222. (openChangeLogs):
  21223. 2011-12-11 Kentaro Hara <haraken@chromium.org>
  21224. [Refactoring] Move top-level code to resolve conflicted ChangeLogs into a method
  21225. https://bugs.webkit.org/show_bug.cgi?id=74257
  21226. Reviewed by Ryosuke Niwa.
  21227. We are planning to write unit-tests for prepare-ChangeLog
  21228. in a run-leaks_unittest/ manner. This patch is one of the incremental
  21229. refactorings to remove all top-level code and global variables from
  21230. prepare-ChangeLog.
  21231. * Scripts/prepare-ChangeLog: Moved top-level code to get the latest ChangeLogs
  21232. into getLatestChangeLogs(), and moved top-level code to resolve conflicted ChangeLogs
  21233. into resolveConflictedChangeLogs().
  21234. (getLatestChangeLogs):
  21235. (resolveConflictedChangeLogs):
  21236. 2011-12-11 Kentaro Hara <haraken@chromium.org>
  21237. [Refactoring] Move top-level code to generate a new ChangeLog into a method
  21238. https://bugs.webkit.org/show_bug.cgi?id=74253
  21239. Reviewed by David Kilzer.
  21240. The objective is to make prepare-ChangeLog a loadable Perl module for unit testing,
  21241. which requires to remove top-level code and global variables. This patch is one of
  21242. the incremental refactorings for that.
  21243. * Scripts/prepare-ChangeLog: Moved top-level code to generate a new ChangeLog into generateNewChangeLogs().
  21244. (generateFunctionLists):
  21245. (findChangeLogs):
  21246. (generateNewChangeLogs):
  21247. (generateFileList): Removed an unnecessary variable $didChangeRegressionTests.
  21248. 2011-12-10 Kentaro Hara <haraken@chromium.org>
  21249. [Refactoring] In prepare-ChangeLog, move top-level code to find ChangeLogs into a method
  21250. https://bugs.webkit.org/show_bug.cgi?id=74175
  21251. Reviewed by Ryosuke Niwa.
  21252. The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
  21253. This requires to remove top-level code. This patch is one of the incremental refactorings
  21254. for that.
  21255. * Scripts/prepare-ChangeLog: Moved top-level code to find ChangeLogs into findChangeLogs().
  21256. (findChangeLogs):
  21257. 2011-12-10 Andreas Kling <kling@webkit.org>
  21258. Add my Apple e-mail to committers.py.
  21259. * Scripts/webkitpy/common/config/committers.py:
  21260. 2011-12-09 Dirk Pranke <dpranke@chromium.org>
  21261. chromium win build: revert build_webkit_exes_from_webkit_gyp change
  21262. https://bugs.webkit.org/show_bug.cgi?id=74225
  21263. This change sets build_webkit_exes_from_webkit_gyp back to 1;
  21264. the "All.gyp" solution doesn't work on windows.
  21265. * Scripts/webkitdirs.pm:
  21266. (buildChromium):
  21267. 2011-12-09 Hugo Parente Lima <hugo.lima@openbossa.org>
  21268. [Qt] Click's count is limited to three continuous clicks.
  21269. https://bugs.webkit.org/show_bug.cgi?id=45666
  21270. Reviewed by Kenneth Rohde Christiansen.
  21271. Update m_time at every call to leapForward, so double clicks
  21272. event are correctly sent by EventSender.
  21273. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  21274. (WTR::EventSenderProxy::updateClickCountForButton):
  21275. (WTR::EventSenderProxy::leapForward):
  21276. 2011-12-09 Kentaro Hara <haraken@chromium.org>
  21277. [Refactoring] Reduce top-level code in prepare-ChangeLog
  21278. https://bugs.webkit.org/show_bug.cgi?id=74172
  21279. Reviewed by Ryosuke Niwa.
  21280. The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
  21281. This requires to remove top-level code. This patch is one of the incremental refactorings
  21282. for that.
  21283. * Scripts/prepare-ChangeLog: Moved some top-level code into generateFunctionLists().
  21284. (generateFunctionLists):
  21285. 2011-12-09 Sam Weinig <sam@webkit.org>
  21286. Expose a WKConnectionRef which represents the connection to/from the WebProcess/UIProcess
  21287. https://bugs.webkit.org/show_bug.cgi?id=74218
  21288. Reviewed by Anders Carlsson.
  21289. Add a test of the WKConnectionRef API.
  21290. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  21291. * TestWebKitAPI/Tests/WebKit2/WKConnection.cpp: Added.
  21292. (TestWebKitAPI::didCreateConnection):
  21293. (TestWebKitAPI::connectionDidReceiveMessage):
  21294. (TestWebKitAPI::connectionDidClose):
  21295. (TestWebKitAPI::TEST):
  21296. * TestWebKitAPI/Tests/WebKit2/WKConnection_Bundle.cpp: Added.
  21297. (TestWebKitAPI::connectionDidReceiveMessage):
  21298. (TestWebKitAPI::WKConnectionTest::WKConnectionTest):
  21299. (TestWebKitAPI::WKConnectionTest::initialize):
  21300. 2011-12-09 David Levin <levin@chromium.org>
  21301. Hash* iterators should allow comparison between const and const versions.
  21302. https://bugs.webkit.org/show_bug.cgi?id=73370
  21303. Reviewed by Darin Adler.
  21304. * TestWebKitAPI/TestWebKitAPI.gypi: Add the new test file to the build.
  21305. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
  21306. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
  21307. * TestWebKitAPI/Tests/WTF/HashMap.cpp: Added.
  21308. (TestWebKitAPI::TEST): Add a test for the new functionality.
  21309. 2011-12-09 Dirk Pranke <dpranke@chromium.org>
  21310. chromium: visual studio projects are busted when build_webkit_exes_from_webkit_gyp==0
  21311. https://bugs.webkit.org/show_bug.cgi?id=74212
  21312. Reviewed by Tony Chang.
  21313. The change introduced in r102201 to split the executables out of
  21314. WebKit.gyp apparently doesn't work right on Windows, since
  21315. WebKit.gyp and Tools.gyp refer to dependent projects by
  21316. different relative paths (it appears gyp doesn't normalize the
  21317. paths). This change moves Tools.gyp to be in the same directory
  21318. as WebKit.gyp (and All.gyp), which should fix this and
  21319. conveniently will also solve the problem of how to add Tools.gyp
  21320. to the chromium DEPS file.
  21321. * Tools.gyp: Renamed to ../Source/WebKit/chromium/Tools.gyp
  21322. 2011-12-09 Kentaro Hara <haraken@chromium.org>
  21323. [Refactoring] In prepare-ChangeLog, move top-level code to fetch a bug description from URL into a method
  21324. https://bugs.webkit.org/show_bug.cgi?id=74173
  21325. Reviewed by Ryosuke Niwa.
  21326. The objective is to make prepare-ChangeLog a loadable Perl module for unit testing.
  21327. This requires to remove top-level code. This patch is one of the incremental refactorings
  21328. for that.
  21329. * Scripts/prepare-ChangeLog: Moved top-level code to fetch a bug description from URL into fetchBugDescriptionFromURL().
  21330. (fetchBugDescriptionFromURL):
  21331. 2011-12-09 Tony Chang <tony@chromium.org>
  21332. Switch the chromium mac bots to using skia test results
  21333. https://bugs.webkit.org/show_bug.cgi?id=74201
  21334. Reviewed by Ryosuke Niwa.
  21335. This is reverting http://trac.webkit.org/changeset/97781 and changing
  21336. the name in master.cfg to no longer have cg in the name.
  21337. * BuildSlaveSupport/build.webkit.org-config/config.json:
  21338. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  21339. (appendCustomBuildFlags):
  21340. (RunWebKitTests.start):
  21341. 2011-12-09 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  21342. [Qt] Remove a wrongly placed ASSERT.
  21343. Reviewed by Tor Arne Vestbø.
  21344. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  21345. (MiniBrowserApplication::notify):
  21346. 2011-12-09 Cary Clark <caryclark@google.com>
  21347. layout_test update to accommodate new use_skia=1 default on Chromium-Mac
  21348. https://bugs.webkit.org/show_bug.cgi?id=74118
  21349. Reviewed by Adam Barth.
  21350. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  21351. (get):
  21352. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  21353. (ChromiumMacPort.__init__):
  21354. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  21355. (ChromiumMacPortTest.test_versions):
  21356. (ChromiumMacPortTest.test_graphics_type):
  21357. 2011-12-09 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  21358. [Qt] Use new qmake option in Qt5 to prevent dependency issues with GNUmake
  21359. The GNUmake + gcc_MD_depends options together produce .d files using GCC, but
  21360. this failed when moving files in the source tree, as the .d file would contain
  21361. stale dependencies on the old source file location. By keeping the object files
  21362. (and hence the depdendency files) in a proper tree structure inside the objects
  21363. directory we can prevent this failure.
  21364. A side benefit is that we can also have objects with the same name inside the
  21365. same project.
  21366. Reviewed by Simon Hausmann.
  21367. * qmake/mkspecs/features/unix/default_pre.prf:
  21368. 2011-12-09 Csaba Osztrogonác <ossy@webkit.org>
  21369. Unreviewed. Update unit test after r102412.
  21370. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  21371. (IRCCommandTest.test_whois):
  21372. 2011-12-09 Kentaro Hara <haraken@chromium.org>
  21373. REGRESSION(r102105): run-bindings-tests should output full diff results
  21374. https://bugs.webkit.org/show_bug.cgi?id=74166
  21375. Reviewed by Adam Barth.
  21376. Since r102105, the output of run-bindings-tests is truncated to 500 characters.
  21377. run-bindings-tests should output full diff results.
  21378. * Scripts/webkitpy/bindings/main.py: Replaced e.message_with_output() with e.output.
  21379. (BindingsTests.generate_from_idl):
  21380. (BindingsTests.generate_supplemental_dependency):
  21381. (BindingsTests.detect_changes):
  21382. 2011-12-09 Simon Hausmann <simon.hausmann@nokia.com>
  21383. [Qt] Fix compilation with newly separated Qt 5 QtQuick module
  21384. https://bugs.webkit.org/show_bug.cgi?id=73990
  21385. Reviewed by Kenneth Rohde Christiansen, tweaked by Csaba Osztrogonác.
  21386. Fix QtQuick includes after move from QtDeclarative to QtQuick.
  21387. * MiniBrowser/qt/BrowserWindow.h:
  21388. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  21389. 2011-12-08 Adam Klein <adamk@chromium.org>
  21390. [MutationObservers] V8LazyEventHandler breaks microtask delivery semantics
  21391. https://bugs.webkit.org/show_bug.cgi?id=73492
  21392. Reviewed by Adam Barth.
  21393. Add eventSender.scheduleAsynchronousKeyDown, needed to cause a
  21394. keypress event without any script on the stack.
  21395. * DumpRenderTree/chromium/EventSender.cpp:
  21396. (EventSender::EventSender):
  21397. (EventSender::keyDown):
  21398. (KeyDownTask::KeyDownTask):
  21399. (KeyDownTask::runIfValid):
  21400. (EventSender::scheduleAsynchronousKeyDown):
  21401. * DumpRenderTree/chromium/EventSender.h:
  21402. 2011-12-08 Hayato Ito <hayato@chromium.org>
  21403. [gdb] Pretty printer for a 8-bit version of WTF::StringImpl and LChar*.
  21404. https://bugs.webkit.org/show_bug.cgi?id=73980
  21405. Reviewed by Tony Chang.
  21406. * gdb/webkit.py:
  21407. (guess_string_length):
  21408. (ustring_to_string):
  21409. (lstring_to_string):
  21410. (LCharStringPrinter):
  21411. (LCharStringPrinter.to_string):
  21412. (WTFStringImplPrinter.get_length):
  21413. (WTFStringImplPrinter.to_string):
  21414. (WTFStringImplPrinter.is_8bit):
  21415. (WTFStringPrinter.stringimpl_ptr):
  21416. (WTFStringPrinter.get_length):
  21417. (WTFStringPrinter.to_string):
  21418. (add_pretty_printers.lookup_function):
  21419. 2011-12-08 Pierre Rossi <pierre.rossi@gmail.com>
  21420. Drop ENABLE_NO_LISTBOX_RENDERING, and make it a runtime decision.
  21421. https://bugs.webkit.org/show_bug.cgi?id=73916
  21422. Reviewed by Kent Tamura.
  21423. * qmake/mkspecs/features/features.prf:
  21424. 2011-12-08 Adrienne Walker <enne@google.com>
  21425. Unreviewed contributor additions to committers.py.
  21426. * Scripts/webkitpy/common/config/committers.py:
  21427. 2011-12-08 David Reveman <reveman@chromium.org>
  21428. [Chromium] Add per-tile painting flag to DumpRenderTree and rename AcceleratedDrawing to AcceleratedPainting in chromium specific code.
  21429. https://bugs.webkit.org/show_bug.cgi?id=74017
  21430. Reviewed by James Robinson.
  21431. Add support for command line flag enable-per-tile-painting in DumpRenderTree.
  21432. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  21433. (main):
  21434. * DumpRenderTree/chromium/TestShell.cpp:
  21435. (TestShell::TestShell):
  21436. (TestShell::resetWebSettings):
  21437. * DumpRenderTree/chromium/TestShell.h:
  21438. (TestShell::setAcceleratedPaintingEnabled):
  21439. (TestShell::setPerTilePaintingEnabled):
  21440. * DumpRenderTree/chromium/WebPreferences.cpp:
  21441. (WebPreferences::reset):
  21442. (WebPreferences::applyTo):
  21443. * DumpRenderTree/chromium/WebPreferences.h:
  21444. * Scripts/webkitpy/layout_tests/port/chromium.py:
  21445. (ChromiumDriver._wrapper_options):
  21446. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  21447. (parse_args):
  21448. 2011-12-08 Dirk Pranke <dpranke@chromium.org>
  21449. create a "SystemHost" object for webkitpy to slim down the Host object
  21450. https://bugs.webkit.org/show_bug.cgi?id=72680
  21451. Reviewed by Eric Siedel.
  21452. This creates a SystemHost object that other objects that should
  21453. only have dependencies on functionality in webkitpy.common.system
  21454. can use; this will allow them to not require a full Host.
  21455. * Scripts/webkitpy/common/host.py:
  21456. * Scripts/webkitpy/common/host_mock.py:
  21457. * Scripts/webkitpy/common/system/systemhost.py: Added.
  21458. * Scripts/webkitpy/common/system/systemhost_mock.py: Added.
  21459. 2011-12-08 Chris Fleizach <cfleizach@apple.com>
  21460. AX: platform/mac/accessibility/search-with-frames.html crashes
  21461. https://bugs.webkit.org/show_bug.cgi?id=74093
  21462. Reviewed by Darin Adler.
  21463. Take care of the case when an incoming element is null.
  21464. * DumpRenderTree/AccessibilityUIElement.cpp:
  21465. (uiElementForSearchPredicateCallback):
  21466. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  21467. (AccessibilityUIElement::uiElementForSearchPredicate):
  21468. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  21469. (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
  21470. 2011-12-08 Alexander Færøy <ahf@0x90.dk>
  21471. [Qt] Visualize mock point ID's in the MiniBrowser
  21472. https://bugs.webkit.org/show_bug.cgi?id=74098
  21473. Reviewed by Tor Arne Vestbø.
  21474. * MiniBrowser/qt/BrowserWindow.cpp:
  21475. (BrowserWindow::updateVisualMockTouchPoints):
  21476. * MiniBrowser/qt/qml/MockTouchPoint.qml:
  21477. 2011-12-08 Dominic Mazzoni <dmazzoni@google.com>
  21478. Accessibility: AccessibilityController should support listening to notifications on all elements.
  21479. https://bugs.webkit.org/show_bug.cgi?id=72866
  21480. Adds addNotificationListener and removeNotificationListener methods
  21481. to AccessibilityController, to listen to notifications on any element
  21482. rather than a specific element. Mac (DRT and WKTR) and Chromium (DRT)
  21483. implementations are all contained in this change.
  21484. On Mac, refactors AccessibilityNotificationHandler into its own
  21485. source file that can be used by both AccessibilityController and
  21486. AccessibilityUIElement. (Both DRT and WKTR.)
  21487. Reviewed by Chris Fleizach.
  21488. * DumpRenderTree/AccessibilityController.cpp:
  21489. (addNotificationListenerCallback):
  21490. (removeNotificationListenerCallback):
  21491. (AccessibilityController::getJSClass):
  21492. * DumpRenderTree/AccessibilityController.h:
  21493. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  21494. * DumpRenderTree/chromium/AccessibilityController.cpp:
  21495. (AccessibilityController::AccessibilityController):
  21496. (AccessibilityController::notificationReceived):
  21497. (AccessibilityController::addNotificationListenerCallback):
  21498. (AccessibilityController::removeNotificationListenerCallback):
  21499. * DumpRenderTree/chromium/AccessibilityController.h:
  21500. * DumpRenderTree/gtk/AccessibilityControllerGtk.cpp:
  21501. (AccessibilityController::addNotificationListener):
  21502. (AccessibilityController::removeNotificationListener):
  21503. * DumpRenderTree/mac/AccessibilityControllerMac.mm:
  21504. (AccessibilityController::~AccessibilityController):
  21505. (AccessibilityController::addNotificationListener):
  21506. (AccessibilityController::removeNotificationListener):
  21507. * DumpRenderTree/mac/AccessibilityNotificationHandler.h: Added.
  21508. * DumpRenderTree/mac/AccessibilityNotificationHandler.mm: Added.
  21509. (-[NSString createJSStringRef]):
  21510. (-[AccessibilityNotificationHandler init]):
  21511. (-[AccessibilityNotificationHandler setPlatformElement:]):
  21512. (-[AccessibilityNotificationHandler dealloc]):
  21513. (-[AccessibilityNotificationHandler setCallback:]):
  21514. (-[AccessibilityNotificationHandler startObserving]):
  21515. (-[AccessibilityNotificationHandler _notificationReceived:]):
  21516. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  21517. (AccessibilityUIElement::addNotificationListener):
  21518. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  21519. (notificationListenerProc):
  21520. (AccessibilityController::addNotificationListener):
  21521. (AccessibilityController::removeNotificationListener):
  21522. (AccessibilityController::winNotificationReceived):
  21523. (AccessibilityController::winAddNotificationListener):
  21524. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  21525. (AccessibilityUIElement::addNotificationListener):
  21526. * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
  21527. (WTR::AccessibilityController::addNotificationListener):
  21528. (WTR::AccessibilityController::removeNotificationListener):
  21529. * WebKitTestRunner/InjectedBundle/AccessibilityController.h:
  21530. (WTR::AccessibilityController::logAccessibilityEvents):
  21531. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
  21532. (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
  21533. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
  21534. (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
  21535. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:
  21536. * WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm: Added.
  21537. (WTR::AccessibilityController::addNotificationListener):
  21538. (WTR::AccessibilityController::removeNotificationListener):
  21539. * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.h: Added.
  21540. * WebKitTestRunner/InjectedBundle/mac/AccessibilityNotificationHandler.mm: Added.
  21541. (-[NSString createJSStringRef]):
  21542. (-[AccessibilityNotificationHandler init]):
  21543. (-[AccessibilityNotificationHandler setPlatformElement:]):
  21544. (-[AccessibilityNotificationHandler dealloc]):
  21545. (-[AccessibilityNotificationHandler setCallback:]):
  21546. (-[AccessibilityNotificationHandler startObserving]):
  21547. (-[AccessibilityNotificationHandler _notificationReceived:]):
  21548. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  21549. (WTR::AccessibilityUIElement::AccessibilityUIElement):
  21550. (WTR::AccessibilityUIElement::verticalScrollbar):
  21551. (WTR::AccessibilityUIElement::addNotificationListener):
  21552. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  21553. 2011-12-08 Csaba Osztrogonác <ossy@webkit.org>
  21554. [Qt][WK2] Unreviewed buildfix after r102352.
  21555. * qmake/mkspecs/features/webkit2.prf:
  21556. 2011-12-08 Adam Roben <aroben@apple.com>
  21557. Make finding crash logs by PID work on Snow Leopard
  21558. Crash Reporter on Snow Leopard doesn't set the "app_description" extended attribute that we
  21559. were using to check the PID of the crashed process. (Crash Reporter on Lion does.) Now we
  21560. read the first line of the crash log and pull the PID out of there.
  21561. Fixes <http://webkit.org/b/74094> "webkit-patch crash-log <process> <PID>" doesn't work on
  21562. Snow Leopard
  21563. Reviewed by Darin Adler.
  21564. * Scripts/webkitpy/common/system/crashlogs.py:
  21565. (CrashLogs._find_newest_log_darwin): Read the first line of the crash log to get the process
  21566. name and PID for the log, rather than checking the Lion-only app_description extended
  21567. attribute. We now also reject the log if the process name doesn't match what we expect.
  21568. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  21569. (make_mock_crash_report_darwin): Added. Returns a mock crash report given a process name and
  21570. PID.
  21571. (CrashLogsTest.assertLinesEqual): Added. This is a compatibility shim around
  21572. unittest.TestCase.assertMultiLineEqual, which didn't exist before Python 2.7.
  21573. (CrashLogsTest.test_find_log_darwin): Made the mock crash reports more believable by using
  21574. the new make_mock_crash_report_darwin function. Also added tests for files that can't be
  21575. read, files that actually contain a crash log for some other process, and files that are
  21576. misformatted.
  21577. * Scripts/webkitpy/common/system/filesystem.py: Removed FileSystem.getxattr, which is now
  21578. unused.
  21579. * Scripts/webkitpy/common/system/filesystem_mock.py:
  21580. (MockFileSystem.__init__): Removed xattr support, which is now unused.
  21581. (MockFileSystem.open_text_file_for_reading): Changed to actually pass the file's data to
  21582. ReadableTextFileObject. This function was completely broken before!
  21583. (ReadableBinaryFileObject.__init__): Made the data parameter non-optional to try to prevent
  21584. bugs like the above.
  21585. (ReadableTextFileObject.__init__): Added. Wraps the data in a StringIO object so we can do
  21586. things like readline() and seek().
  21587. (ReadableTextFileObject.close):
  21588. (ReadableTextFileObject.read):
  21589. Added. We override the superclass implementation to account for using a StringIO object.
  21590. (ReadableTextFileObject.readline):
  21591. (ReadableTextFileObject.seek):
  21592. Added. These just call through to StringIO.
  21593. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  21594. (MainTest.test_crash_log):
  21595. (MainTest.test_web_process_crash_log):
  21596. Changed to use make_mock_crash_report_darwin.
  21597. 2011-12-06 Jon Lee <jonlee@apple.com>
  21598. [WK2] Add permissions support (73960)
  21599. https://bugs.webkit.org/show_bug.cgi?id=73960
  21600. <rdar://problem/10357008>
  21601. Reviewed by Darin Adler.
  21602. Add null function item to comply with added callback to WKPageUIClient.
  21603. * MiniBrowser/mac/BrowserWindowController.m:
  21604. (-[BrowserWindowController awakeFromNib]):
  21605. * WebKitTestRunner/TestController.cpp:
  21606. (WTR::TestController::createOtherPage):
  21607. (WTR::TestController::initialize):
  21608. 2011-12-08 Alexander Færøy <alexander.faeroy@nokia.com>
  21609. [Qt] Visualize mock points in the Qt MiniBrowser
  21610. https://bugs.webkit.org/show_bug.cgi?id=74074
  21611. Reviewed by Tor Arne Vestbø.
  21612. * MiniBrowser/qt/BrowserWindow.cpp:
  21613. (BrowserWindow::updateVisualMockTouchPoints):
  21614. * MiniBrowser/qt/BrowserWindow.h:
  21615. * MiniBrowser/qt/MiniBrowser.qrc:
  21616. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  21617. (MiniBrowserApplication::notify):
  21618. (MiniBrowserApplication::sendTouchEvent):
  21619. * MiniBrowser/qt/MiniBrowserApplication.h:
  21620. * MiniBrowser/qt/icons/touchpoint.png: Added.
  21621. * MiniBrowser/qt/qml/MockTouchPoint.qml: Added.
  21622. 2011-12-08 Simon Hausmann <simon.hausmann@nokia.com>
  21623. [Qt] WebKitTestRunner crashes with debug builds
  21624. https://bugs.webkit.org/show_bug.cgi?id=74090
  21625. Reviewed by Tor Arne Vestbø.
  21626. * WebKitTestRunner/qt/TestControllerQt.cpp:
  21627. (WTR::TestController::platformInitialize): Call QQuickWebView::platformInitialize
  21628. to ensure WTF/JSC threading is initialized.
  21629. 2011-12-08 Dirk Pranke <dpranke@chromium.org>
  21630. fix build-webkit --chromium after breakage in r102201
  21631. https://bugs.webkit.org/show_bug.cgi?id=74031
  21632. Reviewed by Tony Chang.
  21633. * Scripts/webkitdirs.pm:
  21634. (buildChromium):
  21635. 2011-12-08 Kentaro Hara <haraken@chromium.org>
  21636. Unreviewed, rolling out r102280.
  21637. http://trac.webkit.org/changeset/102280
  21638. https://bugs.webkit.org/show_bug.cgi?id=74031
  21639. Chromium/Windows build is broken
  21640. * Scripts/webkitdirs.pm:
  21641. (buildChromium):
  21642. 2011-12-08 Nayan Kumar K <nayankk@motorola.com>
  21643. Adding myself to committers list.
  21644. Unreviewed.
  21645. * Scripts/webkitpy/common/config/committers.py:
  21646. 2011-12-07 Michael Saboff <msaboff@apple.com>
  21647. StringBuilderTest.Append and StringBuilderTest.ToStringPreserveCapacity are failing.
  21648. https://bugs.webkit.org/show_bug.cgi?id=73995
  21649. Reenabled failing tests that the code part of the patch fixes.
  21650. Reviewed by Geoffrey Garen.
  21651. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
  21652. (TestWebKitAPI::TEST):
  21653. 2011-12-07 MORITA Hajime <morrita@google.com>
  21654. [filter-build-webkit] should not emit reset color when --no-color is given
  21655. https://bugs.webkit.org/show_bug.cgi?id=73992
  21656. Reviewed by Daniel Bates.
  21657. Stop printing control sequences when --no-color is given.
  21658. After this change, the filter runs nicely even on environments
  21659. like Emacs compilation-mode which cannot understand the control sequence.
  21660. * Scripts/filter-build-webkit:
  21661. (printLine):
  21662. 2011-12-07 Eric Seidel <eric@webkit.org>
  21663. Use free memory to determine if we have space for DRT instances instead of total memory
  21664. https://bugs.webkit.org/show_bug.cgi?id=74021
  21665. Reviewed by Adam Barth.
  21666. This will hopefully make the Mac buildbots behave better.
  21667. I also reduced the expected memory needed per DRT now that
  21668. we're properly accounting for the system memory in our calculations.
  21669. * Scripts/webkitpy/common/system/platforminfo.py:
  21670. (PlatformInfo.total_bytes_memory):
  21671. (PlatformInfo._compute_free_bytes_from_vm_stat_output):
  21672. * Scripts/webkitpy/common/system/platforminfo_mock.py:
  21673. (MockPlatformInfo.total_bytes_memory):
  21674. * Scripts/webkitpy/layout_tests/port/base.py:
  21675. (Port.default_child_processes):
  21676. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  21677. (PortTest.test_default_child_processes):
  21678. 2011-12-07 Dirk Pranke <dpranke@chromium.org>
  21679. fix build-webkit --chromium after breakage in r102201
  21680. https://bugs.webkit.org/show_bug.cgi?id=74031
  21681. Reviewed by Tony Chang.
  21682. r102201 introduced a change to the chromium build that splits
  21683. the executables out of WebKit.gyp into other gyp files, and adds
  21684. a new "All.gyp" that builds everything. However, I forgot to
  21685. update the build script to use All.gyp.
  21686. * Scripts/webkitdirs.pm:
  21687. (buildChromium):
  21688. 2011-12-07 Tom Zakrajsek <tomz@codeaurora.org>
  21689. Moved myself to the committers list.
  21690. * Scripts/webkitpy/common/config/committers.py:
  21691. 2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
  21692. [Qt] Fix debug shlib build with V8.
  21693. Reviewed by Tor Arne Vestbø.
  21694. * qmake/mkspecs/features/qtwebkit.prf: Don't link jscore with
  21695. v8 builds.
  21696. 2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
  21697. [Qt] V8 build fixes.
  21698. Reviewed by Tor Arne Vestbø.
  21699. * qmake/mkspecs/features/javascriptcore.prf: Don't add
  21700. Source/Thirdparty to the include search path here.
  21701. * qmake/mkspecs/features/webcore.prf: Instead it belongs here, because it's
  21702. used when building WebCore as well as using it, because header files like
  21703. GraphicsContext3D.h include stuff from ThirdParty.
  21704. 2011-12-07 Peter Beverloo <peter@chromium.org>
  21705. [Chromium] Fix project file generation for the Android bot after r102201
  21706. https://bugs.webkit.org/show_bug.cgi?id=73996
  21707. The gyp refactoring in r102201 was didn't explicitly exclude
  21708. the Android operating system in Tools/Tools.gyp, which broke
  21709. as gcc_version is not defined for that configuration.
  21710. Reviewed by Andreas Kling.
  21711. * Tools.gyp:
  21712. 2011-12-07 Vsevolod Vlasov <vsevik@chromium.org>
  21713. Unreviewed. Disabled failing tests on chromium.
  21714. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp:
  21715. (TestWebKitAPI::TEST):
  21716. 2011-12-06 Dirk Pranke <dpranke@chromium.org>
  21717. binaries in webkit.gyp should be split into a new file to break circular dependencies on webkit_support
  21718. https://bugs.webkit.org/show_bug.cgi?id=73382
  21719. Reviewed by Tony Chang.
  21720. XCode (and hence GYP) can't handle circular dependencies between
  21721. files (and projects). Accordingly, although the binaries in
  21722. WebKit.gyp depend on webkit_support and webkit_support depends
  21723. on webkit, we don't mention the latter dependency in the file.
  21724. To fix this, this change moves the binaries like DRT into a new
  21725. GYP file, and modifies gyp_webkit to build from that file
  21726. instead of WebKit.gyp.
  21727. * Tools.gyp: Added.
  21728. 2011-12-06 Adam Roben <aroben@apple.com>
  21729. Add a pid parameter to CrashLogs.find_newest_log
  21730. When a PID is passed, only crash logs corresponding to a crashed process with that PID are
  21731. considered.
  21732. Fixes <http://webkit.org/b/73942> webkitpy provides no way to specify the PID of the crashed
  21733. process whose crash log you want to find
  21734. Reviewed by Dirk Pranke.
  21735. * Scripts/webkitpy/common/system/crashlogs.py:
  21736. (CrashLogs.find_newest_log): Added an optional pid parameter.
  21737. (CrashLogs._find_newest_log_darwin): Added a pid parameter. When specified, we look at each
  21738. candidate log's app_description extended attribute to see if that log corresponds to a
  21739. crashed process with the specified PID.
  21740. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  21741. (CrashLogsTest.test_find_newest_log_darwin): Added a few more mock crash logs with various
  21742. contents and PIDs. Added tests that show that the pid parameter to find_newest_log is
  21743. respected. Also fixed an erroneous use of assertTrue instead of assertEqual.
  21744. * Scripts/webkitpy/common/system/filesystem.py:
  21745. (FileSystem.getxattr): Added. On Darwin, calls through to the xattr module. On other
  21746. systems, raises a KeyError, mimicking the behavior on Darwin when the given attribute isn't
  21747. present.
  21748. * Scripts/webkitpy/common/system/filesystem_mock.py:
  21749. (MockFileSystem.__init__): Added an optional xattrs parameter. Documented other parameters.
  21750. (MockFileSystem.getxattr): Added. Just pulls the given attribute out of the xattrs
  21751. dictionary.
  21752. * Scripts/webkitpy/tool/commands/queries.py:
  21753. (CrashLog): Added help text. Added an optional PID parameter.
  21754. (CrashLog.execute): Pass the PID, if any, through to find_newest_log.
  21755. 2011-12-06 Adam Roben <aroben@apple.com>
  21756. Wait for Crash Reporter to finish even when it lets the crashed process die quickly
  21757. NRWT was only waiting for Crash Reporter in cases where it was keeping the crashed process
  21758. alive beyond the normal timeout limit. In cases where the crashed process was able to die
  21759. faster, NRWT would assume that Crash Reporter had finished even though it often was still
  21760. running, which would lead to an incorrect crash log being picked up.
  21761. Part of <http://webkit.org/b/71380> NRWT incorrectly associates crash logs with tests
  21762. Reviewed by Dirk Pranke.
  21763. * Scripts/webkitpy/layout_tests/port/server_process.py:
  21764. (ServerProcess._reset):
  21765. (ServerProcess.write):
  21766. (ServerProcess._check_for_crash): Changed to use new set_crashed function instead of setting
  21767. .crashed directly. Added wait_for_crash_reporter parameter, which we pass along to
  21768. set_crashed.
  21769. (ServerProcess._handle_timeout): Fixed a logic error that would cause .crashed and
  21770. .timed_out both to be set to True in cases where Crash Reporter took a long time to run. Now
  21771. we bail out of handling the failure as a timeout if we find out that the process in fact
  21772. crashed. We tell _check_for_crash not to wait for Crash Reporter because we've already done
  21773. so.
  21774. (ServerProcess.set_crashed): Added. When the process crashes, we wait for Crash Reporter to
  21775. finish running (unless directed otherwise) so we can be sure the crash log has been saved to
  21776. disk.
  21777. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  21778. (TrivialMockPort.is_crash_reporter): Added.
  21779. * Scripts/webkitpy/layout_tests/port/webkit.py:
  21780. (WebKitDriver._check_for_driver_crash): Changed to use set_crashed. (This also fixed a typo
  21781. that would have partially broken crash detection on Windows, if NRWT worked on Windows.)
  21782. 2011-12-06 Adam Barth <abarth@webkit.org>
  21783. NRWT fails on unreleased versions of Mac OS X
  21784. https://bugs.webkit.org/show_bug.cgi?id=72748
  21785. Reviewed by Dirk Pranke.
  21786. Hopefully this patch will make NRWT work on future versions on Mac OS X.
  21787. Most of the infrastructure was already in place, but there were some
  21788. asserts that failed. I've tested this patch by haxoring the version
  21789. detection logic to simulate an unknown version. We might need to
  21790. iterate based on feedback from folks with a real future version.
  21791. * Scripts/webkitpy/layout_tests/port/apple.py:
  21792. (ApplePort.__init__):
  21793. - mac-future is an allowed port_name that's used internally by
  21794. webkitpy to represent future versions of Mac OS X.
  21795. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  21796. (test_versions):
  21797. - Test that we don't throw exceptions when dealing with future
  21798. versions of Mac OS X.
  21799. * Scripts/webkitpy/layout_tests/port/webkit.py:
  21800. (WebKitPort._expectations_from_skipped_files):
  21801. - Demote this logging message to "debug". It's expected that
  21802. mac-future doesn't have a Skipped file.
  21803. * Scripts/webkitpy/layout_tests/port/mac.py:
  21804. (MacPort.__init__):
  21805. * Scripts/webkitpy/layout_tests/port/win.py:
  21806. (WinPort.__init__):
  21807. - Re-order some code in these constructors so that
  21808. self._operating_system is available to the ApplePort constructor.
  21809. 2011-12-06 Tommy Widenflycht <tommyw@google.com>
  21810. Added myself as a committer.
  21811. * Scripts/webkitpy/common/config/committers.py:
  21812. 2011-12-06 Peter Beverloo <peter@chromium.org>
  21813. Added myself as a committer.
  21814. * Scripts/webkitpy/common/config/committers.py:
  21815. 2011-12-06 Kentaro Hara <haraken@chromium.org>
  21816. [Refactoring] In webkitpy/bindings/main.py, replace subprocess.Popen() with Executive
  21817. https://bugs.webkit.org/show_bug.cgi?id=73637
  21818. Reviewed by Adam Barth.
  21819. This patch replaces subprocess.Popen() with Executive, similar to other
  21820. Python scripts in webkitpy/. I manually confirmed that run-bindings-tests
  21821. works well for cases where no exception is raised, no exception is raised
  21822. but diff is found, and ScriptError is raised.
  21823. * Scripts/run-bindings-tests:
  21824. (main):
  21825. * Scripts/webkitpy/bindings/main.py: Replaces subprocess.Popen() with Executive.
  21826. (BindingsTests.__init__):
  21827. (BindingsTests.generate_from_idl):
  21828. (BindingsTests.generate_supplemental_dependency):
  21829. (BindingsTests.detect_changes):
  21830. 2011-12-05 Alexander Færøy <alexander.faeroy@nokia.com>
  21831. [Qt] MiniBrowser should default to touch behavior
  21832. https://bugs.webkit.org/show_bug.cgi?id=73863
  21833. Reviewed by Chang Shu.
  21834. MiniBrowser currently defaults to the traditional desktop behaviour
  21835. instead of touch behaviour which is prefered.
  21836. * MiniBrowser/qt/BrowserWindow.cpp:
  21837. (BrowserWindow::BrowserWindow):
  21838. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  21839. (printHelp):
  21840. (MiniBrowserApplication::handleUserOptions):
  21841. * MiniBrowser/qt/MiniBrowserApplication.h:
  21842. (WindowOptions::WindowOptions):
  21843. (WindowOptions::setUseTraditionalDesktopBehavior):
  21844. (WindowOptions::useTraditionalDesktopBehavior):
  21845. 2011-12-05 Raphael Kubo da Costa <kubo@profusion.mobi>
  21846. webkit.py: Really fix the printing of StringImpl now that 8-bit strings are present.
  21847. https://bugs.webkit.org/show_bug.cgi?id=73878
  21848. Reviewed by Tony Chang.
  21849. r98624 turned StringImpl::m_data into StringImpl::{m_data8,m_data16}.
  21850. r98785 made webkit.py always use m_data16, which does not work when
  21851. the string is an 8-bit string (such as KURL::string()).
  21852. I was not able to directly call StringImpl::is8Bit() in the Python
  21853. code, so I just reproduced the implementation there.
  21854. * gdb/webkit.py:
  21855. (WTFStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
  21856. (WTFStringPrinter.to_string):
  21857. (JSCUStringPrinter.is_8bit): Reproduced StringImpl::is8Bit().
  21858. (JSCUStringPrinter.to_string):
  21859. 2011-12-05 Eric Seidel <eric@webkit.org>
  21860. Up the "expected ram for each DRT instance" to 400MB instead of 300MB
  21861. in hopes of making the Snow Leopard bot stop timing out.
  21862. Unreviewed.
  21863. * Scripts/webkitpy/layout_tests/port/base.py:
  21864. (Port.default_child_processes):
  21865. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  21866. (PortTest.test_default_child_processes):
  21867. 2011-12-05 Eric Seidel <eric@webkit.org>
  21868. NRWT creates too many workers on RAM-limited machines
  21869. https://bugs.webkit.org/show_bug.cgi?id=73847
  21870. Reviewed by Dirk Pranke.
  21871. Make NRWT restrict its number of workers when there isn't enough
  21872. RAM to support them.
  21873. Also re-enable parallel testing on the Mac bots which were
  21874. failing due to not enough ram.
  21875. * Scripts/run-webkit-tests:
  21876. (platformIsReadyForParallelTesting):
  21877. * Scripts/webkitpy/common/host.py:
  21878. (Host.__init__):
  21879. * Scripts/webkitpy/common/system/executive_mock.py:
  21880. (MockExecutive.cpu_count):
  21881. * Scripts/webkitpy/common/system/platforminfo.py:
  21882. (PlatformInfo.__init__):
  21883. (PlatformInfo.display_name):
  21884. * Scripts/webkitpy/common/system/platforminfo_mock.py:
  21885. (MockPlatformInfo.display_name):
  21886. * Scripts/webkitpy/layout_tests/port/base.py:
  21887. (Port.default_child_processes):
  21888. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  21889. (PortTest.test_default_child_processes):
  21890. (PortTest.test_pretty_patch_os_error):
  21891. 2011-12-05 Hugo Parente Lima <hugo.lima@openbossa.org>
  21892. Last mouse event could be lost if a JS call to eventSender.leapForward is made
  21893. https://bugs.webkit.org/show_bug.cgi?id=73366
  21894. Reviewed by Kenneth Rohde Christiansen.
  21895. Empty the entire event queue when requested besides using
  21896. sendEvent instead of postEvent to make sure all events were
  21897. delivered.
  21898. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  21899. (WTR::EventSenderProxy::EventSenderProxy):
  21900. (WTR::EventSenderProxy::sendOrQueueEvent):
  21901. (WTR::EventSenderProxy::replaySavedEvents):
  21902. 2011-12-05 Adam Barth <abarth@webkit.org>
  21903. [Chromium] Remove no-longer-used forwarding headers in the WebKit API
  21904. https://bugs.webkit.org/show_bug.cgi?id=73845
  21905. Reviewed by Darin Fisher.
  21906. Update includes to point to the new header locations.
  21907. * DumpRenderTree/chromium/AccessibilityController.cpp:
  21908. * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  21909. * DumpRenderTree/chromium/CppBoundClass.cpp:
  21910. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  21911. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  21912. * DumpRenderTree/chromium/DRTDevToolsClient.h:
  21913. * DumpRenderTree/chromium/EventSender.cpp:
  21914. * DumpRenderTree/chromium/EventSender.h:
  21915. * DumpRenderTree/chromium/GamepadController.h:
  21916. * DumpRenderTree/chromium/LayoutTestController.cpp:
  21917. * DumpRenderTree/chromium/LayoutTestController.h:
  21918. * DumpRenderTree/chromium/MockSpellCheck.cpp:
  21919. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  21920. * DumpRenderTree/chromium/PlainTextController.cpp:
  21921. * DumpRenderTree/chromium/Task.cpp:
  21922. * DumpRenderTree/chromium/TestNavigationController.h:
  21923. * DumpRenderTree/chromium/TestShell.cpp:
  21924. * DumpRenderTree/chromium/TestWebPlugin.cpp:
  21925. * DumpRenderTree/chromium/TestWebPlugin.h:
  21926. * DumpRenderTree/chromium/TextInputController.cpp:
  21927. * DumpRenderTree/chromium/WebPermissions.cpp:
  21928. * DumpRenderTree/chromium/WebPreferences.h:
  21929. * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  21930. * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  21931. * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  21932. * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
  21933. * DumpRenderTree/chromium/WebViewHost.cpp:
  21934. 2011-12-05 Ryosuke Niwa <rniwa@webkit.org>
  21935. Add Aharon Lanin to the contributors list.
  21936. * Scripts/webkitpy/common/config/committers.py:
  21937. 2011-12-05 Jarred Nicholls <jarred@sencha.com>
  21938. Moving myself from contributors to committers.
  21939. * Scripts/webkitpy/common/config/committers.py:
  21940. 2011-12-05 Raphael Kubo da Costa <kubo@profusion.mobi>
  21941. Add myself as a committer.
  21942. * Scripts/webkitpy/common/config/committers.py:
  21943. 2011-12-05 Michael Brüning <michael.bruning@nokia.com>
  21944. [Qt] Rename QQuickWebView::canStop property to just loading
  21945. https://bugs.webkit.org/show_bug.cgi?id=73813
  21946. Reviewed by Kenneth Rohde Christiansen.
  21947. Replaced references to WebView.canStop with WebView.loading.
  21948. * MiniBrowser/qt/qml/BrowserWindow.qml:
  21949. 2011-12-05 Dirk Pranke <dpranke@chromium.org>
  21950. run-webkit-tests: limit --child-processes properly on apple mac
  21951. https://bugs.webkit.org/show_bug.cgi?id=73856
  21952. Reviewed by Adam Roben.
  21953. Fix typos in r102013 so that we correctly pass --child-processes=1 on
  21954. the apple mac bots temporarily.
  21955. * Scripts/run-webkit-tests:
  21956. (platformIsReadyForParallelTesting):
  21957. 2011-12-05 Ryosuke Niwa <rniwa@webkit.org>
  21958. Temporarily set --child-process=1 on Mac because 20+ tests are timing out
  21959. https://bugs.webkit.org/show_bug.cgi?id=73840
  21960. Reviewed by Simon Fraser.
  21961. Temporarily go back to single process mode on Mac.
  21962. * Scripts/run-webkit-tests:
  21963. (platformIsReadyForParallelTesting):
  21964. 2011-12-05 Adam Roben <aroben@apple.com>
  21965. Redeploy apple-macpro-7 and apple-xserve-1
  21966. These slaves have been sitting idle since we removed our Leopard builders in r97496.
  21967. Fixes <http://webkit.org/b/73829> REGRESSION (r97496): apple-macpro-7 and apple-xserve-1 are
  21968. sitting idle
  21969. Reviewed by Sam Weinig.
  21970. * BuildSlaveSupport/build.webkit.org-config/config.json: Re-added apple-macpro-7 and
  21971. apple-xserve-1. The former is now doing "SnowLeopard Intel Debug (WebKit2 Tests)", which
  21972. allows apple-xserve-9 to be a build-only slave, and the latter is doing "Lion Intel Debug
  21973. (WebKit2 Tests)".
  21974. 2011-12-05 Kenneth Rohde Christiansen <kenneth@webkit.org>
  21975. [Qt] Make the UI of the MiniBrowser slightly nicer
  21976. Rubberstamped by Simon Hausmann.
  21977. - Add proper padding
  21978. - Show feedback when pressing on the toolbar icons
  21979. - Make the text entry better looking
  21980. * MiniBrowser/qt/qml/BrowserWindow.qml:
  21981. 2011-12-05 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  21982. NRWT should handle duplicated expectations
  21983. https://bugs.webkit.org/show_bug.cgi?id=69750
  21984. Reviewed by Dirk Pranke.
  21985. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  21986. (TestExpectations.__init__):
  21987. (TestExpectations._report_errors):
  21988. (TestExpectations._add_expectations):
  21989. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  21990. (test_add_skipped_tests):
  21991. * Scripts/webkitpy/layout_tests/port/base.py:
  21992. (Port.skipped_tests):
  21993. * Scripts/webkitpy/layout_tests/port/webkit.py:
  21994. (WebKitPort.test_expectations):
  21995. (WebKitPort.skipped_tests):
  21996. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  21997. (test_test_expectations):
  21998. 2011-12-04 Eric Seidel <eric@webkit.org>
  21999. After success with Mac, Win and Gtk, turning on parallel testing
  22000. by default for all platforms (except Qt).
  22001. We'll add more platforms to the blacklist if we see problems.
  22002. Unreviewed.
  22003. * Scripts/run-webkit-tests:
  22004. (platformIsReadyForParallelTesting):
  22005. 2011-12-04 Sam Weinig <sam@webkit.org>
  22006. Add tests for RetainPtr::adoptNS/adoptCF
  22007. https://bugs.webkit.org/show_bug.cgi?id=73470
  22008. Reviewed by Adam Roben and Darin Adler.
  22009. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  22010. * TestWebKitAPI/Tests/WTF/cf/RetainPtr.cpp: Added.
  22011. (TestWebKitAPI::TEST):
  22012. Test that adopting using adoptCF creates a RetainPtr with a
  22013. value whose retain count is 1.
  22014. * TestWebKitAPI/Tests/WTF/ns: Added.
  22015. * TestWebKitAPI/Tests/WTF/ns/RetainPtr.mm: Added.
  22016. (TestWebKitAPI::TEST):
  22017. Test that adopting using adoptNS creates a RetainPtr with a
  22018. value whose retain count is 1.
  22019. 2011-12-04 Martin Robinson <mrobinson@igalia.com>
  22020. [GTK] Include cairo, pixman and gnome-icon-theme in the jhbuild modules
  22021. https://bugs.webkit.org/show_bug.cgi?id=73748
  22022. Reviewed by Gustavo Noronha Silva.
  22023. * gtk/jhbuild.modules: Add some new modules the jhbuild moduleset.
  22024. 2011-12-04 Philippe Normand <pnormand@igalia.com>
  22025. Another GTK build fix after r101922.
  22026. Rubber-stamped by Martin Robinson.
  22027. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  22028. (LayoutTestController::pathToLocalResource): Plug possible String ref leak.
  22029. 2011-12-04 Xan Lopez <xlopez@igalia.com>
  22030. Fix compiler warning in LayoutTestController
  22031. Reviewed by Philippe Normand.
  22032. * DumpRenderTree/LayoutTestController.cpp:
  22033. (LayoutTestController::LayoutTestController): fix warning.
  22034. 2011-12-04 Alexandre Mazari <scaroo@gmail.com>
  22035. Add missing methods used by fast/notifications tests to LayoutTestController
  22036. https://bugs.webkit.org/show_bug.cgi?id=63616
  22037. Reviewed by Martin Robinson.
  22038. Add missing simulateDesktopNotificationClick method used by
  22039. fast/notifications. Provide a default implementation for
  22040. areDesktopNotificationPermissionRequestsIgnored and
  22041. ignoreDesktopNotificationPermissionRequests.
  22042. * DumpRenderTree/LayoutTestController.cpp:
  22043. (LayoutTestController::LayoutTestController): call into the port implementation.
  22044. (simulateDesktopNotificationClickCallback): ditto.
  22045. (ignoreDesktopNotificationPermissionRequestsCallback): default implementation.
  22046. (LayoutTestController::staticFunctions): declare new methods.
  22047. (LayoutTestController::ignoreDesktopNotificationPermissionRequests): default implementation.
  22048. * DumpRenderTree/LayoutTestController.h:
  22049. (LayoutTestController::areDesktopNotificationPermissionRequestsIgnored):
  22050. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  22051. (LayoutTestController::simulateDesktopNotificationClick): dummy implementation.
  22052. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  22053. (LayoutTestController::simulateDesktopNotificationClick): ditto.
  22054. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  22055. (LayoutTestController::simulateDesktopNotificationClick): ditto.
  22056. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  22057. (LayoutTestController::simulateDesktopNotificationClick): ditto.
  22058. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  22059. (LayoutTestController::simulateDesktopNotificationClick): ditto.
  22060. 2011-12-03 Mario Sanchez Prada <msanchez@igalia.com>
  22061. [GTK] Don't log document events in DRT
  22062. https://bugs.webkit.org/show_bug.cgi?id=73746
  22063. Reviewed by Martin Robinson.
  22064. Stop connecting globally to document-related events.
  22065. * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
  22066. (connectAccessibilityCallbacks): Removed connections.
  22067. (disconnectAccessibilityCallbacks): Removed disconnections.
  22068. 2011-12-03 Dan Bernstein <mitz@apple.com>
  22069. Added a test for <rdar://problem/10523721> Crash at WebCore::SubresourceLoader::releaseResources
  22070. Reviewed by Darin Adler.
  22071. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  22072. * TestWebKitAPI/Tests/mac/SubresourceErrorCrash.mm: Added.
  22073. (TestWebKitAPI::TEST):
  22074. 2011-12-03 Philippe Normand <pnormand@igalia.com>
  22075. Another GTK build fix after r101922.
  22076. Rubber-stamped by Martin James Robinson.
  22077. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  22078. (LayoutTestController::pathToLocalResource): return value needs to
  22079. be a URI.
  22080. 2011-12-03 Martin Robinson <mrobinson@igalia.com>
  22081. Small fix for my previous patch. Do not try to delete a member
  22082. of a dictionary that does not exist.
  22083. Reviewed by Gustavo Noronha Silva.
  22084. * gtk/run-with-jhbuild:
  22085. (install_and_run_jhbuild):
  22086. 2011-12-03 Martin Robinson <mrobinson@igalia.com>
  22087. Fix jhbuild installation for people who have unusual MAKE environment
  22088. variables such as 'make -j4' as the jhbuild build does not handle it.
  22089. Reviewed by Gustavo Noronha Silva.
  22090. * gtk/run-with-jhbuild:
  22091. (install_and_run_jhbuild): Remove any MAKE environment variable before building jhbuild.
  22092. 2011-12-03 Martin Robinson <mrobinson@igalia.com>
  22093. Fix the update-webkitgtk-libs script to properly trigger a jhbuild installation
  22094. when run for the first time.
  22095. Reviewed by Gustavo Noronha Silva.
  22096. * Scripts/update-webkitgtk-libs: Fix first run.
  22097. 2011-12-03 Philippe Normand <pnormand@igalia.com>
  22098. Unreviewed, GTK build fix after r101922.
  22099. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  22100. (LayoutTestController::pathToLocalResource): Added sentinel in
  22101. g_build_filename call.
  22102. 2011-12-03 Philippe Normand <pnormand@igalia.com>
  22103. GTK API tests build fix. Run the tests inside jhbuild.
  22104. Rubber-stamped by Gustavo Noronha Silva.
  22105. * Scripts/run-gtk-tests:
  22106. (TestRunner.__init__):
  22107. (TestRunner.run._error_handler):
  22108. (TestRunner):
  22109. (TestRunner.run):
  22110. 2011-12-03 Martin Robinson <mrobinson@igalia.com>
  22111. Small build fix. Properly specify the path to the locally installed jhbuild.
  22112. * Scripts/update-webkitgtk-libs: Fix jhbuild path.
  22113. 2011-12-03 Martin Robinson <mrobinson@igalia.com>
  22114. [GTK][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
  22115. https://bugs.webkit.org/show_bug.cgi?id=67256
  22116. Reviewed by Philippe Normand.
  22117. Implement LayoutTestController::pathToLocalResource for GTK+. Instead of passing
  22118. WEBKIT_TEST_FONTS to the GTK+ test harnesses, pass a more generic WEBKIT_TOP_LEVEL,
  22119. which points to the more generic top-level path of the WebKit checkout. This code is
  22120. duplicated between WK1 and WK2 harnesses because we do not currently have a way to
  22121. share code here.
  22122. If WEBKIT_TOP_LEVEL is not provided, we search for the top level based on the binary
  22123. location. This will cause the fallback to fail if you build into a non-typical location
  22124. or even fake it with a symlink. In this case it's important to use the environment variable.
  22125. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  22126. (getTopLevelPath): Added.
  22127. (initializeFonts): Use the new helper to get the font path.
  22128. * DumpRenderTree/gtk/DumpRenderTreeGtk.h: Expose the new helper.
  22129. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  22130. (LayoutTestController::pathToLocalResource):Use the new helper to normalize
  22131. test paths.
  22132. * Scripts/webkitpy/layout_tests/port/gtk.py:
  22133. (GtkPort.setup_environ_for_server):Pass the top-level path of the
  22134. checkout instead of passing the font path.
  22135. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  22136. (WTR::getTopLevelPath): Added this helper.
  22137. (WTR::inititializeFontConfigSetting): Use the helper to find the font path.
  22138. 2011-12-02 David Levin <levin@chromium.org>
  22139. Rename WTF class from TemporarilyChange to TemporaryChange.
  22140. https://bugs.webkit.org/show_bug.cgi?id=73479
  22141. Reviewed by Eric Seidel.
  22142. * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Removed.
  22143. * DumpRenderTree/ForwardingHeaders/wtf/TemporaryChange.h: Added.
  22144. * TestWebKitAPI/TestWebKitAPI.gypi:
  22145. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  22146. * TestWebKitAPI/Tests/WTF/TemporaryChange.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp.
  22147. (TestWebKitAPI::TEST):
  22148. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  22149. 2011-12-02 Tony Chang <tony@chromium.org>
  22150. [NRWT] reftest asserts intermittently on the Qt-WK2 bot
  22151. https://bugs.webkit.org/show_bug.cgi?id=73453
  22152. Reviewed by Ryosuke Niwa.
  22153. We used to assert if a ref test didn't generate pixel results. Instead, just claim it is a failing test.
  22154. The verbose output will include the failure reason.
  22155. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Don't assert, return FailureReftestNoImagesGenerated instead.
  22156. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  22157. (write_test_result):
  22158. * Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py: Remove stray letter t.
  22159. * Scripts/webkitpy/layout_tests/models/test_failures.py: Add a new failure type: FailureReftestNoImagesGenerated
  22160. (determine_result_type):
  22161. (FailureReftestNoImagesGenerated.__init__):
  22162. (FailureReftestNoImagesGenerated):
  22163. (FailureReftestNoImagesGenerated.message):
  22164. * Scripts/webkitpy/layout_tests/port/test.py: Add a test case for integration tests.
  22165. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Update test counts.
  22166. (MainTest.test_run_singly_actually_runs_tests):
  22167. (MainTest.test_unexpected_failures):
  22168. (EndToEndTest.test_end_to_end):
  22169. 2011-12-02 Ryosuke Niwa <rniwa@webkit.org>
  22170. ChangeLog should be able to parse annotated changelogs
  22171. https://bugs.webkit.org/show_bug.cgi?id=72703
  22172. Reviewed by Eric Seidel.
  22173. Make parse_entries_from_file aware of svn blame annotation such as "100000 ossy@webkit.org ",
  22174. and extract the revision number for each entry.
  22175. Also add a support to extract "svn blame" result from svn/git checkout to scm classes.
  22176. * Scripts/webkitpy/common/checkout/changelog.py:
  22177. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  22178. * Scripts/webkitpy/common/checkout/scm/git.py:
  22179. * Scripts/webkitpy/common/checkout/scm/scm.py:
  22180. * Scripts/webkitpy/common/checkout/scm/svn.py:
  22181. 2011-12-02 Eric Seidel <eric@webkit.org>
  22182. Enable parallel testing for Win and Gtk bots
  22183. after confirming with Lucas and Martin the bots should be OK.
  22184. Unreviewed. (I ran the idea by Lucas and Martin.)
  22185. * Scripts/run-webkit-tests:
  22186. (platformIsReadyForParallelTesting):
  22187. 2011-12-02 Martin Robinson <mrobinson@igalia.com>
  22188. Try to fix the GTK+ build.
  22189. * gtk/jhbuild.modules: Properly specify the glib-networking
  22190. dependency for soup.
  22191. 2011-12-02 Martin Robinson <mrobinson@igalia.com>
  22192. Fix a syntax error in the committers.py file.
  22193. * Scripts/webkitpy/common/config/committers.py: Add a missing comma.
  22194. 2011-12-02 Ryosuke Niwa <rniwa@webkit.org>
  22195. Add Alan Stearns and Peter Linss to the contributors list.
  22196. * Scripts/webkitpy/common/config/committers.py:
  22197. 2011-12-02 Kent Tamura <tkent@chromium.org>
  22198. [Chromium] Fix compilation warnings for ASSERT()
  22199. https://bugs.webkit.org/show_bug.cgi?id=73623
  22200. Reviewed by Tony Chang.
  22201. * DumpRenderTree/chromium/ImageDiff.cpp:
  22202. - Fix fprintf format: %s -> %d for __LINE__
  22203. - Do nothing for ASSERT() if NDEBUG.
  22204. 2011-12-02 Eric Seidel <eric@webkit.org>
  22205. Enable parallel testing for all Mac bots.
  22206. Unreviewed.
  22207. * Scripts/run-webkit-tests:
  22208. (platformIsReadyForParallelTesting):
  22209. 2011-12-02 Eric Seidel <eric@webkit.org>
  22210. Enable parallel testing for run-webkit-tests on Mac Lion.
  22211. I plan to move all the machines to parallel testing shortly
  22212. but we're starting with Lion.
  22213. Unreviewed.
  22214. * Scripts/run-webkit-tests:
  22215. (platformIsReadyForParallelTesting):
  22216. 2011-12-02 Kausalya Madhusudhanan <kmadhusu@chromium.org>
  22217. Added helper method to identify whether the page has custom page size style.
  22218. https://bugs.webkit.org/show_bug.cgi?id=73585
  22219. Reviewed by Darin Fisher.
  22220. * DumpRenderTree/chromium/LayoutTestController.cpp:
  22221. (LayoutTestController::LayoutTestController):
  22222. (LayoutTestController::hasCustomPageSizeStyle):
  22223. * DumpRenderTree/chromium/LayoutTestController.h:
  22224. 2011-12-01 Ryosuke Niwa <rniwa@webkit.org>
  22225. [NRWT] reftest should support having multiple references per test
  22226. https://bugs.webkit.org/show_bug.cgi?id=73613
  22227. Reviewed by Dirk Pranke.
  22228. Add a support for having multiple reference files for a single test.
  22229. Because a reftest succeeds when it matches at least one of expected matches and fails when it matches
  22230. at least one of expected mismatches, we compare expected mismatches first in order to minimize
  22231. the number of reference files to open on DRT.
  22232. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  22233. (interpret_test_failures): Remove checks no longer applicable.
  22234. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  22235. (ResultSummaryTest.test_interpret_test_failures): Ditto.
  22236. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  22237. (SingleTestRunner.__init__): Remove a bunch of code and just call port.reference_files.
  22238. (SingleTestRunner._driver_input):
  22239. (SingleTestRunner.run):
  22240. (SingleTestRunner._run_reftest): Compare the output of the test to each reference file.
  22241. * Scripts/webkitpy/layout_tests/models/test_input.py:
  22242. (TestInput.__init__): Remove ref_file and is_mismatch_reftest because they are no longer used.
  22243. * Scripts/webkitpy/layout_tests/port/base.py:
  22244. (Port.reference_files): Renamed from _reference_file_for. Returns a list of expectation, filename pairs.
  22245. (_parse_reftest_list): Now supports parsing multiple entries for a single test.
  22246. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  22247. (PortTest.test_parse_reftest_list):
  22248. * Scripts/webkitpy/layout_tests/port/test.py:
  22249. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  22250. (MainTest.test_unexpected_failures):
  22251. (MainTest.test_reftest_skipped_if_unlisted): Renamed from test_missing_and_unexpected_results.
  22252. (EndToEndTest.test_end_to_end):
  22253. (EndToEndTest.test_reftest_with_two_notrefs): Added.
  22254. 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
  22255. Build libsoup without gnome dependencies (like keyring).
  22256. * gtk/jhbuild.modules:
  22257. 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
  22258. Also build gcrypt and p11-kit, and make them dependencies of
  22259. gnutls.
  22260. * gtk/jhbuild.modules:
  22261. 2011-12-02 Kevin Ollivier <kevino@theolliviers.com>
  22262. [wx] Unreviewed build fixes for Windows build.
  22263. * waf/build/wxpresets.py:
  22264. 2011-12-01 Eric Seidel <eric@webkit.org>
  22265. Reviewed by Adam Barth.
  22266. webkit-patch post, post-commits, upload should warn when posting to a closed bug, and offer to reopen it
  22267. https://bugs.webkit.org/show_bug.cgi?id=32006
  22268. I decided not to make it warn, and just have it re-open the bug.
  22269. That's not that different from today's behavior which will
  22270. just silently attach the patch.
  22271. This patch makes behavior between upload and land-safely consistent
  22272. (previously one would assign patches and the other would not)
  22273. as well as adds the ability for both to ensure that the bug is open.
  22274. To test this I had to add a few more methods to MockBugzilla which
  22275. (positively) affected a few other test results.
  22276. I also made AbstractStep keep a cached copy of the Bug object
  22277. and used the cached copy where appropriate (including for 'bug_title').
  22278. This should reduce the number of bug fetches we perform.
  22279. * Scripts/webkitpy/tool/commands/download_unittest.py:
  22280. * Scripts/webkitpy/tool/commands/upload.py:
  22281. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  22282. * Scripts/webkitpy/tool/mocktool.py:
  22283. * Scripts/webkitpy/tool/steps/__init__.py:
  22284. * Scripts/webkitpy/tool/steps/abstractstep.py:
  22285. * Scripts/webkitpy/tool/steps/closebug.py:
  22286. * Scripts/webkitpy/tool/steps/ensurebugisopenandassigned.py: Added.
  22287. * Scripts/webkitpy/tool/steps/postdiff.py:
  22288. * Scripts/webkitpy/tool/steps/postdiffforcommit.py:
  22289. * Scripts/webkitpy/tool/steps/preparechangelog.py:
  22290. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  22291. * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  22292. 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
  22293. Also pass --no-interact to jhbuild when updating dependencies.
  22294. * Scripts/update-webkitgtk-libs:
  22295. 2011-12-02 Alice Boxhall <aboxhall@chromium.org>
  22296. Make _build_path check more thoroughly that build paths exist.
  22297. https://bugs.webkit.org/show_bug.cgi?id=73601
  22298. Reviewed by Ojan Vafai.
  22299. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  22300. (ChromiumMacPort._build_path):
  22301. 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
  22302. Add libffi to the jhbuild modules list as a glib dependency.
  22303. Rubber-stamped by Martin Robinson.
  22304. * gtk/jhbuild.modules:
  22305. 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
  22306. Build fix. Use internal pcre on glib, make gnutls a dependency of
  22307. glib-networking, unset AR_FLAGS for jhbuild builds, and run jhbuild
  22308. in non-interactive mode.
  22309. * Scripts/update-webkitgtk-libs:
  22310. * gtk/jhbuild.modules:
  22311. * gtk/run-with-jhbuild:
  22312. 2011-12-02 Adam Roben <aroben@apple.com>
  22313. Fix for Python 2.6
  22314. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  22315. (RunUnitTests.countFailures): Removed the flags parameter to re.split, which was only added
  22316. in Python 2.7, and used whitespace instead of start-of-string/end-of-string markers when
  22317. searching for "Tests that timed out:" etc. This makes our check less strict, but it
  22318. shouldn't matter given the kinds of content we parse.
  22319. 2011-12-02 Adam Roben <aroben@apple.com>
  22320. Fix names of failed/timed out tests in run-api-tests output
  22321. Fixes <http://webkit.org/b/73663> run-api-tests prints suite names twice for failed or timed
  22322. out tests
  22323. We were ending up with the suite name doubled (e.g., "WebKit2.WebKit2.MouseMoveAfterCrash").
  22324. Reviewed by Simon Fraser.
  22325. * Scripts/run-api-tests:
  22326. (runTest): Don't prepend the suite name to $test. It's already been prepended at the start
  22327. of this function.
  22328. 2011-11-29 Martin Robinson <mrobinson@igalia.com>
  22329. [GTK] generate-gtkdoc should respect build type
  22330. https://bugs.webkit.org/show_bug.cgi?id=73296
  22331. Reviewed by Philippe Normand.
  22332. * Scripts/webkitdirs.pm:
  22333. (buildAutotoolsProject): Pass the --debug to the generate-gtkdoc script.
  22334. * gtk/common.py: If --build is passed give preference to the Debug build directory.
  22335. 2011-12-02 Tony Chang <tony@chromium.org>
  22336. [nrwt] fix wdiff output
  22337. https://bugs.webkit.org/show_bug.cgi?id=73604
  22338. Reviewed by Adam Barth.
  22339. * Scripts/webkitpy/layout_tests/port/base.py:
  22340. (Port.wdiff_text):
  22341. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  22342. (PortTest.test_wdiff_text):
  22343. 2011-12-02 Adam Roben <aroben@apple.com>
  22344. Teach build.webkit.org to display how many unit tests failed or timed out
  22345. Fixes <http://webkit.org/b/73659> It's hard to tell how many unit tests are failing on
  22346. build.webkit.org
  22347. We now display something like "5 unit tests failed or timed out". Eventually we might want
  22348. to split out how many failure vs. timeouts there were.
  22349. Reviewed by Darin Adler.
  22350. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  22351. (TestWithFailureCount): Moved this class up to the top of the file so it is before any other
  22352. classes that may want to subclass it.
  22353. (RunUnitTests): Changed to inherit from TestWithFailureCount.
  22354. (RunUnitTests.countFailures): Added. Counts the number of tests following the "Tests that
  22355. timed out:" and "Tests that failed:" lines, if present.
  22356. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  22357. (StubStdio):
  22358. (StubRemoteCommand):
  22359. Added these two stub classes to mimic buildbot's RemoteCommand and log classes.
  22360. (RunUnitTestsTest.assertFailures): Helper method to check that we interpreted the results of
  22361. the test run correctly.
  22362. (RunUnitTestsTest.test_no_failures_or_timeouts):
  22363. (RunUnitTestsTest.test_one_failure):
  22364. (RunUnitTestsTest.test_multiple_failures):
  22365. (RunUnitTestsTest.test_one_timeout):
  22366. (RunUnitTestsTest.test_multiple_timeouts):
  22367. (RunUnitTestsTest.test_multiple_failures_and_timeouts):
  22368. Test various cases.
  22369. 2011-12-02 Adam Roben <aroben@apple.com>
  22370. Teach prepare-ChangeLog to treat master.cfg as a Python file
  22371. Fixes <http://webkit.org/b/73658> prepare-ChangeLog doesn't show modified classes/functions
  22372. in buildbot's master.cfg
  22373. Reviewed by Darin Adler.
  22374. * Scripts/prepare-ChangeLog:
  22375. (get_function_line_ranges): Use get_function_line_ranges_for_python if the filename is
  22376. master.cfg.
  22377. 2011-12-02 Martin Robinson <mrobinson@igalia.com>
  22378. [GTK] Create a wrapper script that knows how to install jhbuild and run commands with it
  22379. https://bugs.webkit.org/show_bug.cgi?id=73669
  22380. Reviewed by Gustavo Noronha Silva.
  22381. Add a wrapper script that knows how to install jhbuild and also to wrap commands
  22382. in the jhbuild shell.
  22383. * Scripts/webkitdirs.pm:
  22384. (runAutogenForAutotoolsProject): Use the new wrapper script.
  22385. (mustReRunAutogen): Ditto.
  22386. (buildAutotoolsProject): Ditto.
  22387. * Scripts/webkitpy/layout_tests/port/gtk.py:
  22388. (GtkDriver.cmd_line): Ditto.
  22389. * gtk/run-with-jhbuild: Added.
  22390. 2011-12-01 Adam Roben <aroben@apple.com>
  22391. Teach check-webkit-style how to check the syntax of JSON files
  22392. Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
  22393. I previously landed this patch as r101711, but the new tests failed on Snow Leopard. This
  22394. patch is identical to that one except for two change: assertIn(a, b) (which is new to Python
  22395. 2.7) has been replaced with assertTrue(a in b), and the test_missing_closing_brace test has
  22396. been removed, since its output differs by platform.
  22397. Reviewed by Darin Adler.
  22398. * Scripts/webkitpy/style/checker.py:
  22399. (_all_categories): Added JSONChecker's categories to the set of all categories.
  22400. (FileType): Added a JSON type. Incremented other types.
  22401. (CheckerDispatcher._file_type): Use the JSON file type for .json files.
  22402. (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
  22403. * Scripts/webkitpy/style/checker_unittest.py:
  22404. (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
  22405. (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
  22406. * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
  22407. which would have matched our other checkers, because I couldn't figure out how to call
  22408. "json.loads" without hitting namespace conflicts.)
  22409. (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
  22410. just the modified lines from a patch.
  22411. (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
  22412. exception.
  22413. (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
  22414. try to extract a line number.
  22415. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
  22416. (MockErrorHandler.__init__):
  22417. (MockErrorHandler.turn_off_line_filtering):
  22418. (MockErrorHandler.__call__):
  22419. Helper class. Copied from xml_unittest.py.
  22420. (JSONCheckerTest.test_line_number_from_json_exception): Test the
  22421. line_number_from_json_exception helper method.
  22422. (JSONCheckerTest.assert_no_error):
  22423. (JSONCheckerTest.assert_error):
  22424. Helper methods to assert that we did or didn't get an error.
  22425. (JSONCheckerTest.mock_handle_style_error): Helper method.
  22426. (JSONCheckerTest.test_conflict_marker):
  22427. (JSONCheckerTest.test_single_quote):
  22428. (JSONCheckerTest.test_init):
  22429. (JSONCheckerTest.test_no_error):
  22430. Test various cases.
  22431. 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
  22432. [GTK] Add glib, glib-networking, gnutls and libsoup to jhbuild
  22433. https://bugs.webkit.org/show_bug.cgi?id=73664
  22434. Reviewed by Martin Robinson.
  22435. This patch adds our HTTP library and its main dependencies; this
  22436. should not affect layout or rendering.
  22437. * gtk/jhbuild.modules:
  22438. 2011-12-02 Gustavo Noronha Silva <gns@gnome.org>
  22439. [GTK] Also run DumpRenderTree under jhbuild
  22440. https://bugs.webkit.org/show_bug.cgi?id=73646
  22441. Reviewed by Martin Robinson.
  22442. * Scripts/webkitpy/layout_tests/port/gtk.py:
  22443. (GtkDriver.cmd_line):
  22444. 2011-12-02 Hajime Morrita <morrita@chromium.org>
  22445. Unreviewed, rolling out r101751 and r101775.
  22446. http://trac.webkit.org/changeset/101751
  22447. http://trac.webkit.org/changeset/101775
  22448. https://bugs.webkit.org/show_bug.cgi?id=73191
  22449. breaks Windows build
  22450. * DumpRenderTree/chromium/config.h:
  22451. * DumpRenderTree/config.h:
  22452. * TestWebKitAPI/config.h:
  22453. * WebKitTestRunner/config.h:
  22454. 2011-12-02 Kentaro Hara <haraken@chromium.org>
  22455. Move run-bindings-tests implementation to webkitpy/bindings/main.py
  22456. https://bugs.webkit.org/show_bug.cgi?id=73619
  22457. Reviewed by Adam Barth.
  22458. As run-bindings-tests has been growing, this patch just moves its implementation
  22459. to webkitpy/bindings/main.py to integrate with the rest of webkitpy.
  22460. No change in behavior.
  22461. * Scripts/run-bindings-tests:
  22462. (main):
  22463. * Scripts/webkitpy/bindings/__init__.py: Added.
  22464. * Scripts/webkitpy/bindings/main.py: Added.
  22465. (BindingsTests.__init__):
  22466. (BindingsTests.generate_from_idl):
  22467. (BindingsTests.generate_supplemental_dependency):
  22468. (BindingsTests.detect_changes):
  22469. (BindingsTests.run_tests):
  22470. 2011-12-01 Ilya Tikhonovsky <loislo@chromium.org>
  22471. Tools/Scripts: eliminate find_test_files from Port class.
  22472. https://bugs.webkit.org/show_bug.cgi?id=73553
  22473. rebaseline.py and chromium_gpu.py use Port.find_test_files() the same way as it is used in Port.tests()
  22474. I'd like to replace all calls to find_test_files with tests and eliminate find_tests_files.
  22475. Also I'll move _is_test_file() and related functions close to Port.tests().
  22476. Reviewed by Dirk Pranke.
  22477. * Scripts/webkitpy/layout_tests/port/base.py:
  22478. (Port.tests):
  22479. (Port.is_reference_html_file):
  22480. (Port._has_supported_extension):
  22481. (Port._is_test_file):
  22482. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  22483. (PortTest.test_find_no_paths_specified):
  22484. (PortTest.test_find_one_test):
  22485. (PortTest.test_find_glob):
  22486. (PortTest.test_find_with_skipped_directories):
  22487. (PortTest.test_find_with_skipped_directories_2):
  22488. (PortTest.test_is_test_file):
  22489. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  22490. (_default_tests_paths):
  22491. (ChromiumGpuLinuxPort.tests):
  22492. (ChromiumGpuCgMacPort.tests):
  22493. (ChromiumGpuMacPort.tests):
  22494. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  22495. (ChromiumGpuTest.test_default_tests_paths.test_paths):
  22496. (ChromiumGpuTest.test_default_tests_paths):
  22497. (ChromiumGpuTest.test_test_files.test_paths):
  22498. (ChromiumGpuTest):
  22499. (ChromiumGpuTest.test_test_files):
  22500. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  22501. (get_tests_run.RecordingTestDriver.run_test):
  22502. * Scripts/webkitpy/tool/commands/rebaseline.py:
  22503. (OptimizeBaselines._optimize_baseline):
  22504. (OptimizeBaselines.execute):
  22505. (AnalyzeBaselines._analyze_baseline):
  22506. (AnalyzeBaselines.execute):
  22507. 2011-12-01 Hajime Morrita <morrita@chromium.org>
  22508. JS_INLINE and WTF_INLINE should be visible from WebCore
  22509. https://bugs.webkit.org/show_bug.cgi?id=73191
  22510. Reviewed by Kevin Ollivier.
  22511. Removed macro definitions which is now provided by Platform.h
  22512. * DumpRenderTree/chromium/config.h:
  22513. * DumpRenderTree/config.h:
  22514. * TestWebKitAPI/config.h:
  22515. * WebKitTestRunner/config.h:
  22516. 2011-12-01 Hayato Ito <hayato@chromium.org>
  22517. Explicitly pass tolerance=0 to port.diff_image in case of RefTestMismatch failure.
  22518. https://bugs.webkit.org/show_bug.cgi?id=73406
  22519. Reviewed by Ryosuke Niwa.
  22520. WebKitPort's image_diff uses tolerance='0.1' in default.
  22521. When reftests fail, we should use tolerace=0 when diff-ing images.
  22522. Since ImageDiff on chromium port doesn't use tolerance value as of now,
  22523. this change doesn't affect chromium port's behavior.
  22524. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  22525. (write_test_result):
  22526. * Scripts/webkitpy/layout_tests/port/base.py:
  22527. (Port.diff_image):
  22528. * Scripts/webkitpy/layout_tests/port/chromium.py:
  22529. (ChromiumPort.diff_image):
  22530. * Scripts/webkitpy/layout_tests/port/test.py:
  22531. (TestPort.diff_image):
  22532. * Scripts/webkitpy/layout_tests/port/webkit.py:
  22533. (WebKitPort.diff_image):
  22534. (WebKitPort._start_image_diff_process):
  22535. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  22536. (MainTest.test_tolerance.ImageDiffTestPort.diff_image):
  22537. 2011-12-01 Adam Klein <adamk@chromium.org>
  22538. Add Chromium ToT GTest build bots (and group selection support) to flakiness dashboard
  22539. https://bugs.webkit.org/show_bug.cgi?id=73599
  22540. Reviewed by Ojan Vafai.
  22541. * TestResultServer/static-dashboards/builders.js:
  22542. * TestResultServer/static-dashboards/dashboard_base.js:
  22543. ():
  22544. (htmlForTestTypeSwitcher):
  22545. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  22546. (testHtmlForTestTypeSwitcherGroup):
  22547. 2011-12-01 Ryosuke Niwa <rniwa@webkit.org>
  22548. Parse reftest.list and extract types of ref tests
  22549. https://bugs.webkit.org/show_bug.cgi?id=66837
  22550. Reviewed by Dirk Pranke.
  22551. Add support for reftest.list to base port.
  22552. * Scripts/webkitpy/common/find_files.py:
  22553. (find):
  22554. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  22555. (SingleTestRunner.__init__):
  22556. * Scripts/webkitpy/layout_tests/port/base.py:
  22557. (Port.__init__): Initialize self._reftest_list. It's a dictionary mapping from a test directory
  22558. to a dictionary of {test path: ("==" or "!=", reference file path)}
  22559. (Port._get_reftest_list): Added; calls test_file.parse_reftest_list to fill self._reftest_list.
  22560. (Port._reference_file_for): Added; obtains the reference file name given a test name.
  22561. (Port.is_reftest): Added; Calls _reference_file_for.
  22562. (Port.reftest_expected_filename): Calls _reference_file_for.
  22563. (Port.reftest_expected_mismatch_filename): Ditto.
  22564. (Port.find_test_files):
  22565. (is_reference_html_file): Treat any file that starts with ref- or notref- or ends with
  22566. -expected, -expected-mismach, -ref, or -notref as a reference file.
  22567. (_is_test_file):
  22568. (_parse_reftest_list): Added.
  22569. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  22570. (PortTest.test_is_test_file):
  22571. (PortTest.test_parse_reftest_list):
  22572. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  22573. (DryrunDriver.run_test):
  22574. * Scripts/webkitpy/layout_tests/port/test.py:
  22575. (unit_test_filesystem.add_test_file):
  22576. (unit_test_filesystem.add_file):
  22577. (unit_test_filesystem):
  22578. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  22579. (get_tests_run.RecordingTestDriver.run_test):
  22580. (MainTest.test_unexpected_failures):
  22581. (MainTest.test_missing_and_unexpected_results):
  22582. (EndToEndTest.test_end_to_end):
  22583. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  22584. (Rebaseliner._compile_rebaselining_tests):
  22585. 2011-12-01 Sheriff Bot <webkit.review.bot@gmail.com>
  22586. Unreviewed, rolling out r101711.
  22587. http://trac.webkit.org/changeset/101711
  22588. https://bugs.webkit.org/show_bug.cgi?id=73605
  22589. Broke 3 webkitpy tests (Requested by rniwa on #webkit).
  22590. * Scripts/webkitpy/style/checker.py:
  22591. (_all_categories):
  22592. (FileType):
  22593. (CheckerDispatcher._file_type):
  22594. (CheckerDispatcher._create_checker):
  22595. * Scripts/webkitpy/style/checker_unittest.py:
  22596. (CheckerDispatcherDispatchTest.assert_checker_cpp):
  22597. (CheckerDispatcherDispatchTest.test_cpp_paths):
  22598. * Scripts/webkitpy/style/checkers/jsonchecker.py: Removed.
  22599. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Removed.
  22600. 2011-12-01 Gustavo Noronha Silva <gns@gnome.org>
  22601. Unreviewed. Add myself to GStreamer and WebKit2GTK+ watchlists.
  22602. * Scripts/webkitpy/common/config/watchlist:
  22603. 2011-12-01 Martin Robinson <mrobinson@igalia.com>
  22604. [GTK] Read fonts from the jhbuild root
  22605. https://bugs.webkit.org/show_bug.cgi?id=73487
  22606. Reviewed by Gustavo Noronha Silva.
  22607. Read fonts from the jhbuild root instead of from the system. This will ensure
  22608. that all testers use the same fonts instead of leaving this up to luck.
  22609. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  22610. (initializeFonts): Load fonts from jhbuild root.
  22611. * Scripts/webkitpy/layout_tests/port/gtk.py:
  22612. (GtkPort.setup_environ_for_server): Pass an environment variable containing
  22613. the path to the jhbuild root.
  22614. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  22615. (WTR::inititializeFontConfigSetting): Load fonts from the jhbuild root.
  22616. 2011-12-01 Adam Roben <aroben@apple.com>
  22617. Teach check-webkit-style how to check the syntax of JSON files
  22618. Fixes <http://webkit.org/b/73590> check-webkit-style doesn't flag JSON syntax errors
  22619. Reviewed by Darin Adler.
  22620. * Scripts/webkitpy/style/checker.py:
  22621. (_all_categories): Added JSONChecker's categories to the set of all categories.
  22622. (FileType): Added a JSON type. Incremented other types.
  22623. (CheckerDispatcher._file_type): Use the JSON file type for .json files.
  22624. (CheckerDispatcher._create_checker): Use a JSONChecker for JSON files.
  22625. * Scripts/webkitpy/style/checker_unittest.py:
  22626. (CheckerDispatcherDispatchTest.assert_checker_json): Added this helper method.
  22627. (CheckerDispatcherDispatchTest.test_json_paths): Added. Based on test_python_paths.
  22628. * Scripts/webkitpy/style/checkers/jsonchecker.py: Added. (I didn't name this just "json",
  22629. which would have matched our other checkers, because I couldn't figure out how to call
  22630. "json.loads" without hitting namespace conflicts.)
  22631. (JSONChecker.__init__): Turn of line filtering so that we always check the whole file, not
  22632. just the modified lines from a patch.
  22633. (JSONChecker.check): Try to parse the lines as JSON. Mark an error if there was an
  22634. exception.
  22635. (JSONChecker.line_number_from_json_exception): Parse the json modules exception message to
  22636. try to extract a line number.
  22637. * Scripts/webkitpy/style/checkers/jsonchecker_unittest.py: Added.
  22638. (MockErrorHandler.__init__):
  22639. (MockErrorHandler.turn_off_line_filtering):
  22640. (MockErrorHandler.__call__):
  22641. Helper class. Copied from xml_unittest.py.
  22642. (JSONCheckerTest.test_line_number_from_json_exception): Test the
  22643. line_number_from_json_exception helper method.
  22644. (JSONCheckerTest.assert_no_error):
  22645. (JSONCheckerTest.assert_error):
  22646. Helper methods to assert that we did or didn't get an error.
  22647. (JSONCheckerTest.mock_handle_style_error): Helper method.
  22648. (JSONCheckerTest.test_conflict_marker):
  22649. (JSONCheckerTest.test_single_quote):
  22650. (JSONCheckerTest.test_init):
  22651. (JSONCheckerTest.test_missing_closing_brace):
  22652. (JSONCheckerTest.test_no_error):
  22653. Test various cases.
  22654. 2011-12-01 Martin Robinson <mrobinson@igalia.com>
  22655. [GTK] Add a helper function to find the current executable's path
  22656. https://bugs.webkit.org/show_bug.cgi?id=73473
  22657. Reviewed by Gustavo Noronha Silva.
  22658. Update MiniBrowser to not pass the binary directory as an environment variable.
  22659. This means that you can move the binaries around without it breaking.
  22660. * MiniBrowser/gtk/main.c:
  22661. (main): No longer set the environment variable.
  22662. * WebKitTestRunner/GNUmakefile.am: No longer add the directory path define.
  22663. * WebKitTestRunner/gtk/main.cpp: Ditto.
  22664. 2011-12-01 Gustavo Noronha Silva <gns@gnome.org>
  22665. Unreviewed. Fix bad file =(.
  22666. * gtk/jhbuild.modules:
  22667. * Scripts/webkitdirs.pm:
  22668. (runAutogenForAutotoolsProject):
  22669. 2011-12-01 Gustavo Noronha Silva <gns@gnome.org>
  22670. [GTK] Add freetype to our jhbuild setup
  22671. https://bugs.webkit.org/show_bug.cgi?id=73488
  22672. Reviewed by Martin Robinson.
  22673. This adds the first library to our jhbuild setup, and makes sure
  22674. build-webkit calls autogen.sh and make with jhbuild, so that the
  22675. environment is properly set.
  22676. * Scripts/webkitdirs.pm:
  22677. (saveSum):
  22678. (hashFile):
  22679. (runAutogenForAutotoolsProject): save md5sum of jhbuild-related files, and
  22680. call autogen under jhbuild run;
  22681. (mustRunAutogen): generalized the arguments change checking to also force
  22682. running autogen when jhbuild files change;
  22683. (buildAutotoolsProject): run make under jhbuild;
  22684. * gtk/jhbuild.modules: add freetype.
  22685. 2011-12-01 Dominic Mazzoni <dmazzoni@google.com>
  22686. Fix WebKitTestRunner compile warnings with XCode 3.2
  22687. https://bugs.webkit.org/show_bug.cgi?id=73378
  22688. Reviewed by Chris Fleizach.
  22689. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp:
  22690. (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
  22691. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp:
  22692. (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
  22693. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  22694. (WTR::AccessibilityUIElement::AccessibilityUIElement):
  22695. (WTR::AccessibilityUIElement::verticalScrollbar):
  22696. 2011-12-01 Adam Roben <aroben@apple.com>
  22697. Allow committers to use their Trac credentials to force builds on the buildbots
  22698. Fixes <http://webkit.org/b/73353>
  22699. A new class, CommitterAuth, handles authentication of WebKit committers. CommitterAuth uses
  22700. three files to do its job: a config file that contains a list of WebKit committer usernames,
  22701. an htdigest file that contains Trac credentials, and JSON file that gives the paths for
  22702. those two files.
  22703. Reviewed by Darin Adler.
  22704. * BuildSlaveSupport/build.webkit.org-config/committer_auth.py: Added.
  22705. (Error): Basic wrapper around Exception that we use for cases where we couldn't even check
  22706. whether credentials were valid or not.
  22707. (CommitterAuth.__init__): Just store the path to auth.json.
  22708. (CommitterAuth.auth_json): Load, parse, and return auth.json.
  22709. (CommitterAuth.auth_json_filename): Return the path to auth.json.
  22710. (CommitterAuth.authenticate): Return true if the user is a WebKit committer and their
  22711. credentials are valid Trac credentials. Return false otherwise or if an error occurred while
  22712. checking those conditions.
  22713. (CommitterAuth.is_webkit_committer): Return true if the user is a WebKit committer. Return
  22714. false otherwise or if an exception was thrown.
  22715. (CommitterAuth.is_webkit_trac_user): Return true if the username/password are present in the
  22716. Trac credentials htdigest file. Return false otherwise or if an exception was thrown.
  22717. (CommitterAuth.open_auth_json_file):
  22718. (CommitterAuth.open_trac_credentials_file):
  22719. (CommitterAuth.open_webkit_committers_file):
  22720. Open the specified file. These are mostly useful for testing purposes.
  22721. (CommitterAuth.trac_credentials_filename):
  22722. (CommitterAuth.webkit_committers_filename):
  22723. Return the path to the specified file by retrieving it from auth.json.
  22724. (CommitterAuth.webkit_committers): Load and parse the committers file and extract the list
  22725. of WebKit committers from it.
  22726. * BuildSlaveSupport/build.webkit.org-config/committer_auth_unittest.py: Added.
  22727. (CMStringIO.__enter__):
  22728. (CMStringIO.__exit__):
  22729. Helper class that makes it possible to use StringIO with the "with" statement.
  22730. (open_override): Helper context manager for overriding the global "open" function
  22731. temporarily.
  22732. (CommitterAuthTest.setUp): Set up a somewhat-mocked CommitterAuth that is used by most
  22733. tests.
  22734. (CommitterAuthTest.fake_open_function): Returns a function that can be used in place of
  22735. "open" to test that the expected path was opened.
  22736. (CommitterAuthTest.test_authentication_success): Test that committers can authenticate
  22737. successfully.
  22738. (CommitterAuthTest.test_committer_without_trac_credentials_fails): Test that committers who
  22739. somehow have no Trac account can't authenticate.
  22740. (CommitterAuthTest.test_fail_to_open_auth_json_file):
  22741. (CommitterAuthTest.test_fail_to_open_trac_credentials_file):
  22742. (CommitterAuthTest.test_fail_to_open_webkit_committers_file):
  22743. Test what happens when we can't open the three files we depend upon.
  22744. (CommitterAuthTest.test_implements_IAuth): Test that we fulfill buildbot's expectations for
  22745. an authentication class.
  22746. (CommitterAuthTest.test_invalid_auth_json_file):
  22747. (CommitterAuthTest.test_invalid_committers_file):
  22748. (CommitterAuthTest.test_invalid_trac_credentials_file):
  22749. (CommitterAuthTest.test_missing_auth_json_keys):
  22750. Test what happens when the three files we depend upon are invalid in some way.
  22751. (CommitterAuthTest.test_open_auth_json_file):
  22752. (CommitterAuthTest.test_open_trac_credentials_file):
  22753. (CommitterAuthTest.test_open_webkit_committers_file):
  22754. Test that we open the expected paths.
  22755. (CommitterAuthTest.test_trac_credentials_filename):
  22756. (CommitterAuthTest.test_webkit_committers_filename):
  22757. Test that we extract filenames out of auth.json correctly.
  22758. (CommitterAuthTest.test_non_committer_fails):
  22759. (CommitterAuthTest.test_unknown_user_fails):
  22760. (CommitterAuthTest.test_username_is_prefix_of_valid_user):
  22761. (CommitterAuthTest.test_wrong_password_fails):
  22762. Test various failed authentication attempts.
  22763. (CommitterAuthTest.test_webkit_committers): Test that we can parse the list of WebKit
  22764. committers out of the committers file correctly.
  22765. (CommitterAuthTest.fake_auth_json_file):
  22766. (CommitterAuthTest.invalid_auth_json_file):
  22767. (CommitterAuthTest.fake_committers_file):
  22768. (CommitterAuthTest.invalid_committers_file):
  22769. (CommitterAuthTest.fake_htdigest_file):
  22770. (CommitterAuthTest.invalid_htdigest_file):
  22771. Return various fake files for testing.
  22772. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Specify an instance of CommitterAuth
  22773. to be used for authentication in the web interface, and specify that only authenticated
  22774. users may force builds.
  22775. 2011-12-01 Adam Roben <aroben@apple.com>
  22776. Add an HTDigestParser class to webkitpy
  22777. Fixes <http://webkit.org/b/73575> webkitpy doesn't provide a way to parse htdigest files
  22778. This class can be used to parse Apache's htdigest files and check whether a given
  22779. username/realm/password tuple is present in the file. Eventually this will be used for
  22780. authenticating users on build.webkit.org (<http://webkit.org/b/73353>).
  22781. Reviewed by Eric Seidel.
  22782. * Scripts/webkitpy/common/net/htdigestparser.py: Added.
  22783. (HTDigestParser.__init__): Stores the parsed representation of the file.
  22784. (HTDigestParser.authenticate): Hashes the username/realm/password tuple to generate a hashed
  22785. password and returns whether the resulting tuple is present in the file.
  22786. (HTDigestParser.entries): Just returns the parsed representation of the file.
  22787. (HTDigestParser.parse_file): Splits each line on colons and checks that each line has the
  22788. expected syntax ('username:realm:hashed_password'). If any line is invalid, we treat the
  22789. whole file as invalid and all authentication attempts will fail.
  22790. * Scripts/webkitpy/common/net/htdigestparser_unittest.py: Added.
  22791. (HTDigestParserTest.assertEntriesEqual): Helper method to assert that fake_htdigest_file,
  22792. optionally appended with some extra data, generates the expected entries.
  22793. (HTDigestParserTest.test_authenticate): Tests that tuples present in the file can
  22794. authenticate, and tuples not present cannot.
  22795. (HTDigestParserTest.test_entries): Tests that we get the expected entries from
  22796. fake_htdigest_file.
  22797. (HTDigestParserTest.test_empty_file):
  22798. (HTDigestParserTest.test_too_few_colons):
  22799. (HTDigestParserTest.test_too_many_colons):
  22800. (HTDigestParserTest.test_invalid_hash):
  22801. Test various forms of invalid files.
  22802. (HTDigestParserTest.fake_htdigest_file): Returns a fake valid htdigest file for testing.
  22803. 2011-12-01 Philippe Normand <pnormand@igalia.com>
  22804. [GTK] Make the new 64-bit Release bot part of the core set
  22805. https://bugs.webkit.org/show_bug.cgi?id=73570
  22806. Reviewed by Adam Roben.
  22807. The 64-bit Release bot re-introduced in r101676 replaces the 64-bit
  22808. Debug bot which was already part of the core set. The GTK
  22809. gardeners are willing to actively maintain it.
  22810. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  22811. (BuildBot.__init__):
  22812. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  22813. (test_builder_name_regexps):
  22814. 2011-12-01 Philippe Normand <pnormand@igalia.com>
  22815. [GTK] Buildslave switch from 32-bit Debug to 64-bit Release
  22816. https://bugs.webkit.org/show_bug.cgi?id=73547
  22817. Reviewed by Adam Roben.
  22818. * BuildSlaveSupport/build.webkit.org-config/config.json: Rename
  22819. the 32-bit Debug configuration to 64-bit Release. The new slave is
  22820. a 64-bit machine already. The 32-bit slave will be shut down.
  22821. 2011-12-01 Martin Robinson <mrobinson@igalia.com>
  22822. [GTK] build-jsc should not trigger gtkdoc generation
  22823. https://bugs.webkit.org/show_bug.cgi?id=73552
  22824. Reviewed by Philippe Normand.
  22825. Do not generate gtkdoc when building projects other than WebKit. In particular, this ensures
  22826. that build-jsc does not try to generate gtkdoc.
  22827. * Scripts/webkitdirs.pm:
  22828. (buildAutotoolsProject): Only generate gtkdoc if the project is "WebKit".
  22829. 2011-12-01 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  22830. tests_run0.txt gets clobbered when re-running failing tests
  22831. https://bugs.webkit.org/show_bug.cgi?id=63844
  22832. Reviewed by Dirk Pranke.
  22833. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  22834. (Manager.results_directory):
  22835. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  22836. (AbstractWorker.__init__):
  22837. (_ManagerConnection.start_worker):
  22838. (_InlineManager.start_worker):
  22839. (_MultiProcessManager.start_worker):
  22840. (_WorkerConnection.__init__):
  22841. (_InlineWorkerConnection.__init__):
  22842. (_MultiProcessWorkerConnection.__init__):
  22843. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  22844. (_TestWorker.__init__):
  22845. (_TestsMixin.test_cancel):
  22846. (_TestsMixin.test_done):
  22847. (_TestsMixin.test_unknown_message):
  22848. (InterfaceTest.test_managerconnection_is_abstract):
  22849. (InterfaceTest.test_workerconnection_is_abstract):
  22850. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  22851. (Worker.__init__):
  22852. (Worker.safe_init):
  22853. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  22854. (MainTest.test_retries_directory):
  22855. 2011-12-01 Adam Roben <aroben@apple.com>
  22856. Buildbot fix
  22857. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved all of the initialization of
  22858. BuildmasterConfig not performed by loadBuilderConfig up to the top of the file. This makes
  22859. it possible for build steps to reference things like the buildbotURL property of the config.
  22860. 2011-11-30 Adam Roben <aroben@apple.com>
  22861. Use curl for downloading builds to test slaves
  22862. Buildbot's built-in file transfer capabilities are transferring files much more slowly than
  22863. curl does. This seems to be due to a combination of buildbot being single-threaded (and thus
  22864. often busy servicing web requests, etc.) and using an IPC mechanism with fairly high
  22865. overhead (courtesy of the Twisted framework).
  22866. Eventually we'd like to make Buildbot's built-in transferring more efficient. In the
  22867. meantime we'll try using curl for downloads and keep thinking about a solution for uploads.
  22868. This should make the test slaves quite a bit faster, and should ease the CPU load on
  22869. build.webkit.org a bit.
  22870. Part of <http://webkit.org/b/73484> Mac slaves take 7+ minutes to upload or download a build
  22871. Reviewed by Mark Rowe.
  22872. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added the CreateWebKitBuildDirectory
  22873. to Test slaves. It's run just before DownloadBuiltProduct.
  22874. (DownloadBuiltProduct): Changed to be a normal ShellCommand that invokes curl to perform the
  22875. download.
  22876. (CreateWebKitBuildDirectory): Added. Creates the WebKitBuild directory on a slave.
  22877. FileDownload used to do this for us automatically.
  22878. 2011-11-21 Philippe Normand <pnormand@igalia.com>
  22879. [GTK] enable-webaudio websetting
  22880. https://bugs.webkit.org/show_bug.cgi?id=69836
  22881. Reviewed by Martin Robinson.
  22882. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  22883. (LayoutTestController::overridePreference): Update WebKitGTK
  22884. enable-webaudio setting when a layout test requests it.
  22885. 2011-11-30 Ilya Tikhonovsky <loislo@chromium.org>
  22886. Web Inspector: chromium: I'd like to add a script for running perf tests for WebInspector.
  22887. https://bugs.webkit.org/show_bug.cgi?id=73079
  22888. The idea is to have performance tests for WebInspector.
  22889. I was suggested to put these tests into PerformanceTests/inspector.
  22890. They produce output in a format that is suitable for chromium perf bot drawing scripts.
  22891. I'd like to reuse code for scanning folders for test files.
  22892. Because of the fact that original test_files.py has common and layout specific parts
  22893. I decided to extract the generic part and put it into webkitpy/common
  22894. I think the two packages with name test_files look strange but I have no idea about a better name.
  22895. Reviewed by Dirk Pranke.
  22896. * Scripts/run-inspector-perf-tests.py: Added.
  22897. * Scripts/webkitpy/common/find_files.py: Renamed from Tools/Scripts/webkitpy/layout_tests/port/test_files.py.
  22898. (find):
  22899. (_normalize):
  22900. * Scripts/webkitpy/common/find_files_unittest.py: Added.
  22901. (MockWinFileSystem.join):
  22902. (MockWinFileSystem):
  22903. (MockWinFileSystem.normpath):
  22904. (TestWinNormalize.assert_filesystem_normalizes):
  22905. (TestWinNormalize.test_mocked_win):
  22906. (TestWinNormalize):
  22907. (TestWinNormalize.test_win):
  22908. * Scripts/webkitpy/layout_tests/port/base.py:
  22909. (Port.tests):
  22910. (Port.find_test_files):
  22911. (Port._driver_class):
  22912. (is_reference_html_file):
  22913. (_has_supported_extension):
  22914. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  22915. (PortTest.test_find_no_paths_specified):
  22916. (PortTest.test_find_one_test):
  22917. (PortTest.test_find_glob):
  22918. (PortTest.test_find_with_skipped_directories):
  22919. (PortTest.test_find_with_skipped_directories_2):
  22920. (PortTest):
  22921. (PortTest.test_is_test_file):
  22922. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  22923. (_tests):
  22924. * Scripts/webkitpy/layout_tests/port/test.py:
  22925. * Scripts/webkitpy/layout_tests/port/test_files_unittest.py: Removed.
  22926. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  22927. * Scripts/webkitpy/performance_tests/__init__.py: Added.
  22928. * Scripts/webkitpy/performance_tests/perftestsrunner.py: Added.
  22929. (PerfTestsRunner.__init__):
  22930. (PerfTestsRunner._parse_args):
  22931. (PerfTestsRunner._collect_tests._is_test_file):
  22932. (PerfTestsRunner._collect_tests):
  22933. (PerfTestsRunner.run):
  22934. (PerfTestsRunner._run_tests_set):
  22935. * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py: Added.
  22936. (MainTest.TestPort):
  22937. (MainTest.TestPort.create_driver):
  22938. (MainTest.TestDriver.run_test):
  22939. (MainTest.TestDriver):
  22940. (MainTest.TestDriver.stop):
  22941. (MainTest.create_runner):
  22942. (MainTest.run_test):
  22943. (MainTest.test_run_passing_test):
  22944. (MainTest.test_run_silent_test):
  22945. (MainTest.test_run_failed_test):
  22946. (MainTest.test_run_tonguey_test):
  22947. (MainTest.test_run_timeout_test):
  22948. (MainTest.test_run_crash_test):
  22949. (MainTest.test_run_test_set):
  22950. (MainTest.test_collect_tests):
  22951. (MainTest):
  22952. (MainTest.test_parse_args):
  22953. * Scripts/webkitpy/tool/commands/rebaseline.py:
  22954. (OptimizeBaselines.execute):
  22955. (AnalyzeBaselines.execute):
  22956. 2011-11-30 nduca@chromium.org <nduca@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
  22957. [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
  22958. https://bugs.webkit.org/show_bug.cgi?id=70838
  22959. Reviewed by James Robinson.
  22960. * DumpRenderTree/chromium/TestShell.cpp:
  22961. (TestShell::resetWebSettings):
  22962. * DumpRenderTree/chromium/TestShell.h:
  22963. (TestShell::threadedCompositingEnabled):
  22964. * DumpRenderTree/chromium/WebPreferences.cpp:
  22965. (WebPreferences::reset):
  22966. (WebPreferences::applyTo):
  22967. * DumpRenderTree/chromium/WebPreferences.h:
  22968. * DumpRenderTree/chromium/WebViewHost.cpp:
  22969. (WebViewHost::WebViewHost):
  22970. (WebViewHost::~WebViewHost):
  22971. 2011-11-30 Chris Fleizach <cfleizach@apple.com>
  22972. AX: Nodes are reporting that focus can be set when they really can't
  22973. https://bugs.webkit.org/show_bug.cgi?id=72791
  22974. Reviewed by Beth Dakin.
  22975. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  22976. (AccessibilityUIElement::isFocusable):
  22977. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  22978. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:
  22979. (WTR::AccessibilityUIElement::isFocusable):
  22980. 2011-11-30 Alejandro G. Castro <alex@igalia.com>
  22981. Moved myself to the reviewers list.
  22982. * Scripts/webkitpy/common/config/committers.py:
  22983. 2011-11-30 David Levin <levin@chromium.org>
  22984. [chromium] Move didUpdateLayout from WebFrameClient to WebViewClient.
  22985. https://bugs.webkit.org/show_bug.cgi?id=73415
  22986. Reviewed by Darin Fisher.
  22987. * DumpRenderTree/chromium/WebViewHost.cpp:
  22988. (WebViewHost::didUpdateLayout): Move didUpdateLayout to account for
  22989. it being moved to a new interface and having the parameter removed.
  22990. * DumpRenderTree/chromium/WebViewHost.h: Ditto.
  22991. 2011-11-30 Adam Roben <aroben@apple.com>
  22992. Make NRWT show DRT/WTR build logs when the build fails or --verbose is passed
  22993. This will make it a lot easier to investigate build failures on the bots.
  22994. Fixes <http://webkit.org/b/71160> NRWT doesn't show build output when building DRT
  22995. Reviewed by Eric Seidel.
  22996. * Scripts/webkitpy/common/system/executive_mock.py:
  22997. (MockExecutive.run_command): Include the mock output in the ScriptError we raise since it
  22998. makes the expected output in WebKitPortTest.test_build_driver more closely mimic the output
  22999. seen in practice.
  23000. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  23001. (ManagerTest.test_http_locking): Pass False for the configure_logging parameter to Printer.
  23002. The Printer was modifying the root logger in way that would cause my new tests in
  23003. WebKitPort.test_build_driver to fail. The value of the configure_logging parameter doesn't
  23004. seem important to the functioning of this test, and passing False makes Printer not modify
  23005. the root logger.
  23006. * Scripts/webkitpy/layout_tests/port/webkit.py:
  23007. (WebKitPort._run_script): Log the output of the command at the DEBUG level so it will show
  23008. up when --verbose is passed but not otherwise.
  23009. (WebKitPort._build_driver): When an error occurs, log the error message and the script's
  23010. output at the ERROR level so it will always show up.
  23011. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  23012. (WebKitPortTest.test_build_driver): Test that nothing is logged in the normal, successful
  23013. cases. Test that the build scripts' output is logged when --verbose is passed or the build
  23014. fails.
  23015. 2011-11-30 Adam Roben <aroben@apple.com>
  23016. Add a way to set OutputCapture's log level
  23017. This will be used by some unit tests I'm planning to add.
  23018. Fixes <http://webkit.org/b/73469> OutputCapture can't be used to capture DEBUG messages
  23019. Reviewed by Eric Seidel.
  23020. * Scripts/webkitpy/common/system/outputcapture.py:
  23021. (OutputCapture.__init__): Initialize our internal logging level to INFO, which was the only
  23022. level we ever used before this patch.
  23023. (OutputCapture.set_log_level): Added. This is useful for testing what log level code that is
  23024. being tested uses. Sets the log level for any current or future logging handlers.
  23025. (OutputCapture.capture_output): Use our internal logging level instead of always using INFO.
  23026. * Scripts/webkitpy/common/system/outputcapture_unittest.py: Added.
  23027. (OutputCaptureTest.setUp): Create an OutputCapture to test.
  23028. (OutputCaptureTest.log_all_levels): Helper method to log a message at each log level.
  23029. (OutputCaptureTest.assertLogged): Helper method to assert that a particular set of strings
  23030. was logged.
  23031. (OutputCaptureTest.test_initial_log_level): Test that we start out at the INFO level.
  23032. (OutputCaptureTest.test_set_log_level): Test that set_log_level correctly modifies the log
  23033. level.
  23034. 2011-11-29 Beth Dakin <bdakin@apple.com>
  23035. https://bugs.webkit.org/show_bug.cgi?id=72751
  23036. WebKit2.MouseMoveAfterCrash API test is failing
  23037. Reviewed by Sam Weinig.
  23038. Like DumpRenderTree, the NSWindow should act as an active window.
  23039. * TestWebKitAPI/mac/PlatformWebViewMac.mm:
  23040. (-[ActiveOffscreenWindow isKeyWindow]):
  23041. (TestWebKitAPI::PlatformWebView::PlatformWebView):
  23042. 2011-11-30 Gustavo Noronha Silva <gns@gnome.org>
  23043. Add step to update gtk dependencies to the buildbot
  23044. https://bugs.webkit.org/show_bug.cgi?id=73455
  23045. Reviewed by Martin Robinson.
  23046. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  23047. 2011-11-30 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  23048. [Qt] Add a fullscreen option to MiniBrowser.
  23049. https://bugs.webkit.org/show_bug.cgi?id=73445
  23050. Reviewed by Noam Rosenthal.
  23051. This bypasses the compositor on the N9 to increase performances
  23052. and remove the huge useless gray bar part of the window frame
  23053. at the bottom.
  23054. * MiniBrowser/qt/BrowserWindow.cpp:
  23055. (BrowserWindow::BrowserWindow):
  23056. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  23057. (printHelp):
  23058. (MiniBrowserApplication::handleUserOptions):
  23059. * MiniBrowser/qt/MiniBrowserApplication.h:
  23060. (WindowOptions::setStartFullScreen):
  23061. (WindowOptions::startFullScreen):
  23062. 2011-11-30 Martin Robinson <mrobinson@igalia.com>
  23063. [GTK] Add an initial jhbuild setup which installs fonts into the WebKitBuild
  23064. https://bugs.webkit.org/show_bug.cgi?id=73425
  23065. Reviewed by Gustavo Noronha Silva.
  23066. Add initial jhbuild support to the GTK+ port. update-webkitgtk-libs will
  23067. ensure that the jhbuild root is up-to-date. Currently the only module is
  23068. the font module.
  23069. * Scripts/update-webkitgtk-libs: Added.
  23070. * gtk/common.py: Added a helper to get the number of CPUs.
  23071. * gtk/jhbuild.modules: Added.
  23072. * gtk/jhbuildrc: Added.
  23073. 2011-11-30 Simon Hausmann <simon.hausmann@nokia.com>
  23074. [Qt] Remove dependency of Qt DRT on JavaScriptCore.
  23075. Reviewed by Csaba Osztrogonác.
  23076. * DumpRenderTree/WorkQueue.cpp: Include the correct header file we're using anyway,
  23077. instead of one that pulls in JavaScriptCore headers.
  23078. * DumpRenderTree/qt/DumpRenderTree.pro: There's no need to pull in the JSC headers
  23079. with load(javascriptcore).
  23080. 2011-11-30 Sheriff Bot <webkit.review.bot@gmail.com>
  23081. Unreviewed, rolling out r101440 and r101442.
  23082. http://trac.webkit.org/changeset/101440
  23083. http://trac.webkit.org/changeset/101442
  23084. https://bugs.webkit.org/show_bug.cgi?id=73429
  23085. multiple crashes on layout tests (Requested by hayato on
  23086. #webkit).
  23087. * DumpRenderTree/chromium/TestShell.cpp:
  23088. (TestShell::resetWebSettings):
  23089. * DumpRenderTree/chromium/TestShell.h:
  23090. * DumpRenderTree/chromium/WebPreferences.cpp:
  23091. (WebPreferences::reset):
  23092. (WebPreferences::applyTo):
  23093. * DumpRenderTree/chromium/WebPreferences.h:
  23094. * DumpRenderTree/chromium/WebViewHost.cpp:
  23095. (WebViewHost::WebViewHost):
  23096. (WebViewHost::~WebViewHost):
  23097. 2011-11-30 Fady Samuel <fsamuel@chromium.org>
  23098. [Chromium] Fix broken DRT build for Aura Linux
  23099. https://bugs.webkit.org/show_bug.cgi?id=72667
  23100. Reviewed by Tony Chang.
  23101. DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
  23102. The following changes have been made:
  23103. 1. Renamed TestShellAndroid to TestShellLinux.
  23104. 2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
  23105. 3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
  23106. * DumpRenderTree/DumpRenderTree.gypi:
  23107. * DumpRenderTree/chromium/EventSender.cpp:
  23108. (EventSender::keyDown):
  23109. * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
  23110. * DumpRenderTree/chromium/TestShellGtk.cpp:
  23111. * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
  23112. (AlarmHandler):
  23113. (TestShell::waitTestFinished):
  23114. (setupFontconfig):
  23115. (platformInit):
  23116. * DumpRenderTree/chromium/TestShellStub.cpp: Added.
  23117. (checkLayoutTestSystemDependencies):
  23118. (openStartupDialog):
  23119. 2011-11-30 Fady Samuel <fsamuel@chromium.org>
  23120. [Chromium] Set Result Before Early Exit for Fixed Layout Methods in LayoutTestController
  23121. https://bugs.webkit.org/show_bug.cgi?id=73328
  23122. Reviewed by Kent Tamura.
  23123. * DumpRenderTree/chromium/LayoutTestController.cpp:
  23124. (LayoutTestController::enableFixedLayoutMode):
  23125. (LayoutTestController::setFixedLayoutSize):
  23126. 2011-11-29 Hayato Ito <hayato@chromium.org>
  23127. Skip writing the result of diff_image since non-chromium ports don't implement diff_image.
  23128. https://bugs.webkit.org/show_bug.cgi?id=73381
  23129. Reviewed by Ryosuke Niwa.
  23130. This is a quick fix for the breakage of tests on non-chromium port.
  23131. We should implement diff_image later on non-chromium ports.
  23132. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  23133. (write_test_result):
  23134. 2011-11-29 Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu>
  23135. [NRWT] Fix --platform=qt-5.0 --new-baseline combo
  23136. https://bugs.webkit.org/show_bug.cgi?id=72489
  23137. Reviewed by Eric Seidel.
  23138. Before the this fix always added "qt" option for the option list
  23139. * Scripts/run-webkit-tests:
  23140. * Scripts/webkitpy/layout_tests/port/qt.py:
  23141. 2011-11-29 David Levin <levin@chromium.org>
  23142. Add a way to revert a variable to its previous value after leaving a scope.
  23143. https://bugs.webkit.org/show_bug.cgi?id=73371
  23144. Reviewed by Adam Barth.
  23145. * DumpRenderTree/ForwardingHeaders/wtf/TemporarilyChange.h: Added.
  23146. * TestWebKitAPI/TestWebKitAPI.gypi: Added test file to the build.
  23147. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Ditto.
  23148. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
  23149. * TestWebKitAPI/Tests/WTF/TemporarilyChange.cpp: Added.
  23150. (TestWebKitAPI::TEST): Added a test for TemporarilyChange.
  23151. 2011-11-28 Kentaro Hara <haraken@chromium.org>
  23152. Implement [Supplemental] IDL and support it in run-bindings-tests
  23153. https://bugs.webkit.org/show_bug.cgi?id=73162
  23154. Reviewed by Adam Barth.
  23155. run-bindings-tests supports the [Supplemental] IDL in the following way.
  23156. (1) It creates a file |x| listing all IDL files.
  23157. (2) It generates a supplemental dependency file |y| using resolve-supplemental.pl and |x|.
  23158. (3) For each IDL file |z|, it runs generate-bindings.pl with |y|.
  23159. Then, generate-bindings.pl generates .h and .cpp files for the IDL file |z|,
  23160. including all attributes in IDL files that are supplementing the IDL file |z|.
  23161. * Scripts/run-bindings-tests:
  23162. (generate_from_idl):
  23163. (generate_supplemental_dependency):
  23164. (detect_changes):
  23165. (run_tests):
  23166. (main):
  23167. 2011-11-18 Nat Duca <nduca@chromium.org>
  23168. [chromium] Enable threaded compositing via CCThreadProxy::hasThread only
  23169. https://bugs.webkit.org/show_bug.cgi?id=70838
  23170. Reviewed by James Robinson.
  23171. * DumpRenderTree/chromium/TestShell.cpp:
  23172. (TestShell::resetWebSettings):
  23173. * DumpRenderTree/chromium/TestShell.h:
  23174. (TestShell::threadedCompositingEnabled):
  23175. * DumpRenderTree/chromium/WebPreferences.cpp:
  23176. (WebPreferences::reset):
  23177. (WebPreferences::applyTo):
  23178. * DumpRenderTree/chromium/WebPreferences.h:
  23179. * DumpRenderTree/chromium/WebViewHost.cpp:
  23180. (WebViewHost::WebViewHost):
  23181. (WebViewHost::~WebViewHost):
  23182. 2011-11-29 Ojan Vafai <ojan@chromium.org>
  23183. List of builders in the flakiness dashboard is out of date
  23184. https://bugs.webkit.org/show_bug.cgi?id=73347
  23185. Reviewed by Adam Barth.
  23186. The chromium gpu bots no longer run layout tests, so kill that
  23187. group entirely.
  23188. * TestResultServer/static-dashboards/builders.js:
  23189. * TestResultServer/static-dashboards/dashboard_base.js:
  23190. 2011-11-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  23191. [Qt] Don't hard-code the list of WebKit2 generated sources
  23192. The generated sources are... wait for it... generated. So
  23193. use the generator itself to figure out which sources we need
  23194. to compile.
  23195. Reviewed by Simon Hausmann.
  23196. * qmake/mkspecs/features/default_post.prf:
  23197. 2011-11-29 Martin Robinson <mrobinson@igalia.com>
  23198. [GTK] Add a method to detect 'make dist' errors without running 'make dist'
  23199. https://bugs.webkit.org/show_bug.cgi?id=73216
  23200. Reviewed by Philippe Normand.
  23201. Add a script that tries to sniff out 'make dist' problems without running
  23202. 'make dist.' 'make distcheck' takes a very long time to run and this should
  23203. reduce the amount of times it needs to be run consecutively.
  23204. * gtk/common.py:
  23205. (get_build_path.is_valid_build_directory): Guess the source directory
  23206. by the existence of the GNUmakefile instead of the .libs directory. This
  23207. allows one to run the script after running autogen.sh but before fully
  23208. building.
  23209. * gtk/find-make-dist-errors: Added.
  23210. 2011-11-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  23211. [Qt] Remove use of internal headers in the MiniBrowser
  23212. Reviewed by Simon Hausmann.
  23213. * MiniBrowser/qt/MiniBrowser.pro:
  23214. 2011-11-29 Simon Hausmann <simon.hausmann@nokia.com>
  23215. [Qt] Fix debug-shlib build without webkit2
  23216. Reviewed by Tor Arne Vestbø.
  23217. * qmake/mkspecs/features/qtwebkit.prf: Respect no_webkit2.
  23218. 2011-11-28 Csaba Osztrogonác <ossy@webkit.org>
  23219. [Qt][WK2] Unreviewed buildfix after r101307.
  23220. * qmake/mkspecs/features/webkit2.prf: Add missing includepath.
  23221. 2011-11-29 Roland Steiner <rolandsteiner@chromium.org>
  23222. <style scoped>: add ENABLE(STYLE_SCOPED) flag to WebKit
  23223. https://bugs.webkit.org/show_bug.cgi?id=72848
  23224. Add option to build-webkit.
  23225. Reviewed by Dimitri Glazkov.
  23226. * Scripts/build-webkit:
  23227. 2011-11-28 Ojan Vafai <ojan@chromium.org>
  23228. gtest normalization in the test results server is sometimes wrong
  23229. https://bugs.webkit.org/show_bug.cgi?id=73262
  23230. Reviewed by Tony Chang.
  23231. If a gtest has it's modified changed (e.g. add FLAKY_) then it will have two
  23232. entries in the incremental JSON, one of the entries will have the correct data
  23233. from the run and the other will have dummy no-data values. Make sure to
  23234. always pick the one with real data.
  23235. * TestResultServer/model/jsonresults.py:
  23236. (JsonResults._remove_gtest_modifiers):
  23237. * TestResultServer/model/jsonresults_unittest.py:
  23238. (JsonResultsTest.test_remove_gtest_modifiers):
  23239. 2011-11-28 Ojan Vafai <ojan@chromium.org>
  23240. Some of the results.json files have results/times entries at the directory level
  23241. https://bugs.webkit.org/show_bug.cgi?id=73261
  23242. Reviewed by Tony Chang.
  23243. This is just a bug that got introduced in a temporary push of the results server.
  23244. This patch repairs the broken files. After all the bots have cycled, we can simplify
  23245. this code to just assert that results/times are not at the directory level.
  23246. Also, when catching exceptions, log the full stacktrace.
  23247. * TestResultServer/model/jsonresults.py:
  23248. (_is_directory):
  23249. (JsonResults._load_json):
  23250. (JsonResults._merge_tests):
  23251. (JsonResults.merge):
  23252. * TestResultServer/model/jsonresults_unittest.py:
  23253. (JsonResultsTest.test_merge_directory_hierarchy_extra_results_and_times):
  23254. 2011-11-28 Tony Chang <tony@chromium.org>
  23255. ews bots should pass --force to update-webkit-chromium
  23256. https://bugs.webkit.org/show_bug.cgi?id=73230
  23257. Reviewed by Adam Barth.
  23258. This makes it less likely for gclient changes to break the bots (e.g.,
  23259. if a DEPS repository moves or is switched to a branch).
  23260. Also pass --force when using |build-webkit --update-chromium| since this
  23261. appears to only be used by the bots.
  23262. Take 2: Add Options.non_interactive to update.py's options() method.
  23263. * Scripts/update-webkit:
  23264. * Scripts/webkitdirs.pm:
  23265. (determineIsChromium): Add --force-update to update-webkit --chromium.
  23266. (forceChromiumUpdate):
  23267. (buildChromium): Pass --force to update-webkit-chromium.
  23268. * Scripts/webkitpy/tool/steps/update.py:
  23269. (Update.run): Add --force-update if non-interactive (i.e., bots).
  23270. * Scripts/webkitpy/tool/steps/update_unittest.py:
  23271. 2011-11-28 Tony Chang <tony@chromium.org>
  23272. Revert r101279, broke the ews and cq bots.
  23273. * Scripts/update-webkit:
  23274. * Scripts/webkitdirs.pm:
  23275. (determineIsChromium):
  23276. (buildChromium):
  23277. * Scripts/webkitpy/common/config/ports.py:
  23278. (WebKitPort.update_webkit_command):
  23279. (ChromiumPort.update_webkit_command):
  23280. * Scripts/webkitpy/common/config/ports_mock.py:
  23281. (MockPort.update_webkit_command):
  23282. * Scripts/webkitpy/tool/steps/update.py:
  23283. * Scripts/webkitpy/tool/steps/update_unittest.py: Removed.
  23284. 2011-11-28 Ojan Vafai <ojan@chromium.org>
  23285. testlistjson on the test results server doesn't understand hierarchical results format
  23286. https://bugs.webkit.org/show_bug.cgi?id=73246
  23287. Reviewed by Tony Chang.
  23288. * TestResultServer/model/jsonresults.py:
  23289. (JsonResults._delete_results_and_times):
  23290. Instead of just getting the top-level keys, we now walk the tests tree and
  23291. delete the results and times values.
  23292. * TestResultServer/model/jsonresults_unittest.py:
  23293. Simplify the test harness to take in the same JSON format for the tests
  23294. that the actual results.json uses instead of something very similar but
  23295. needlessly different. This also allows for testing the broken case of
  23296. results and times values being at non-leaf level.
  23297. 2011-11-28 Tony Chang <tony@chromium.org>
  23298. ews bots should pass --force to update-webkit-chromium
  23299. https://bugs.webkit.org/show_bug.cgi?id=73230
  23300. Reviewed by Adam Barth.
  23301. This makes it less likely for gclient changes to break the bots (e.g.,
  23302. if a DEPS repository moves or is switched to a branch).
  23303. Also pass --force when using |build-webkit --update-chromium| since this
  23304. appears to only be used by the bots.
  23305. * Scripts/update-webkit:
  23306. * Scripts/webkitdirs.pm:
  23307. (determineIsChromium): Add --force-update to update-webkit --chromium.
  23308. (forceChromiumUpdate):
  23309. (buildChromium): Pass --force to update-webkit-chromium.
  23310. * Scripts/webkitpy/tool/steps/update.py:
  23311. (Update.run): Add --force-update if non-interactive (i.e., bots).
  23312. * Scripts/webkitpy/tool/steps/update_unittest.py:
  23313. 2011-11-28 Michael Saboff <msaboff@apple.com>
  23314. Fixed help message for --exclude-kraken to say that
  23315. it excludes Kraken and not SunSpider.
  23316. Rubber-stamped by Filip Pizlo.
  23317. * Scripts/bencher:
  23318. 2011-11-28 Sheriff Bot <webkit.review.bot@gmail.com>
  23319. Unreviewed, rolling out r101273.
  23320. http://trac.webkit.org/changeset/101273
  23321. https://bugs.webkit.org/show_bug.cgi?id=73244
  23322. multiple test failures and timeouts (Requested by tony^work on
  23323. #webkit).
  23324. * DumpRenderTree/DumpRenderTree.gypi:
  23325. * DumpRenderTree/chromium/EventSender.cpp:
  23326. (EventSender::keyDown):
  23327. * DumpRenderTree/chromium/TestShellAndroid.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
  23328. (AlarmHandler):
  23329. (TestShell::waitTestFinished):
  23330. (platformInit):
  23331. (openStartupDialog):
  23332. (checkLayoutTestSystemDependencies):
  23333. * DumpRenderTree/chromium/TestShellGtk.cpp:
  23334. (AlarmHandler):
  23335. (setupFontconfig):
  23336. (TestShell::waitTestFinished):
  23337. (platformInit):
  23338. * DumpRenderTree/chromium/TestShellLinux.cpp: Removed.
  23339. * DumpRenderTree/chromium/TestShellStub.cpp: Removed.
  23340. 2011-11-28 John Yani <vanuan@gmail.com>
  23341. new-run-webkit-tests is locale dependent
  23342. https://bugs.webkit.org/show_bug.cgi?id=68691
  23343. Reviewed and modified by Eric Seidel.
  23344. This is a simpler version of John's patch which I'm landing.
  23345. This just engages the hacks from the Host constructor on a global
  23346. basis.
  23347. * Scripts/webkitpy/common/host.py:
  23348. (Host.__init__):
  23349. (Host._engage_awesome_locale_hacks):
  23350. 2011-11-28 Fady Samuel <fsamuel@chromium.org>
  23351. [Chromium] Fix broken DRT build for Aura Linux
  23352. https://bugs.webkit.org/show_bug.cgi?id=72667
  23353. Reviewed by Tony Chang.
  23354. DRT now builds for Aura Linux. This, more or less, shares the same code as Android.
  23355. The following changes have been made:
  23356. 1. Renamed TestShellAndroid to TestShellLinux.
  23357. 2. Stub code moved added in TestShellStub that will only compile on non-GTK Linux builds.
  23358. 3. Code common to Gtk, Aura, and Android moved to TestShellLinux.
  23359. * DumpRenderTree/DumpRenderTree.gypi:
  23360. * DumpRenderTree/chromium/EventSender.cpp:
  23361. (EventSender::keyDown):
  23362. * DumpRenderTree/chromium/TestShellAndroid.cpp: Removed.
  23363. * DumpRenderTree/chromium/TestShellGtk.cpp:
  23364. * DumpRenderTree/chromium/TestShellLinux.cpp: Copied from Tools/DumpRenderTree/chromium/TestShellGtk.cpp.
  23365. (AlarmHandler):
  23366. (TestShell::waitTestFinished):
  23367. (setupFontconfig):
  23368. (platformInit):
  23369. * DumpRenderTree/chromium/TestShellStub.cpp: Added.
  23370. (checkLayoutTestSystemDependencies):
  23371. (openStartupDialog):
  23372. 2011-11-28 Eric Seidel <eric@webkit.org>
  23373. Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
  23374. https://bugs.webkit.org/show_bug.cgi?id=71983
  23375. Reviewed by Adam Barth.
  23376. We'll add more code to Environment overtime,
  23377. allowing us to mock out more of our direct interactions with os.environ.
  23378. This patch also makes run_command print the passed in environment.
  23379. * Scripts/webkitpy/common/host_mock.py:
  23380. * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  23381. * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  23382. * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  23383. * Scripts/webkitpy/common/system/executive.py:
  23384. * Scripts/webkitpy/common/system/executive_mock.py:
  23385. * Scripts/webkitpy/layout_tests/port/webkit.py:
  23386. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  23387. * Scripts/webkitpy/tool/commands/download_unittest.py:
  23388. * Scripts/webkitpy/tool/steps/build.py:
  23389. 2011-11-28 Simon Hausmann <simon.hausmann@nokia.com>
  23390. [Qt] Build system fixes against V8.
  23391. Reviewed by Tor Arne Vestbø.
  23392. * qmake/mkspecs/features/webcore.prf: Get rid of old v8 cruft.
  23393. * qmake/mkspecs/features/wtf.prf: If requested, pull in v8 from Qt and configure
  23394. WTF accordingly to use v8. (WTF in the implementation needs it as well as users of WTF)
  23395. 2011-11-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
  23396. Make sure the useFixedLayout feature is consistently handled
  23397. https://bugs.webkit.org/show_bug.cgi?id=73212
  23398. Reviewed by Simon Hausmann.
  23399. The web page parameters are set to our Qt defaults and are now altered
  23400. in the WebKitTestRunner.
  23401. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  23402. (WTR::WrapperWindow::WrapperWindow):
  23403. 2011-11-28 Simon Hausmann <simon.hausmann@nokia.com>
  23404. [Qt] WTF should be built as separate static library
  23405. https://bugs.webkit.org/show_bug.cgi?id=73201
  23406. Reviewed by Tor Arne Vestbø.
  23407. * DumpRenderTree/qt/DumpRenderTree.pro: Require wtf.
  23408. * MiniBrowser/qt/BrowserWindow.cpp: Remove unnecessary config.h inclusion and
  23409. thus wtf dependency.
  23410. * WebKitTestRunner/InjectedBundle/Target.pri: Require wtf.
  23411. * WebKitTestRunner/Target.pri: Ditto.
  23412. * qmake/mkspecs/features/default_post.prf: When re-ordering the static libs
  23413. consider wtf, too.
  23414. * qmake/mkspecs/features/javascriptcore.prf: Remove WTF specific build stuff,
  23415. moved into wtf.prf.
  23416. * qmake/mkspecs/features/qtwebkit.prf: For debug builds with shared libs, also
  23417. link in libwtf.
  23418. * qmake/mkspecs/features/wtf.prf: Added. Stuff needed for building and using WTF.
  23419. 2011-11-28 Kentaro Hara <haraken@chromium.org>
  23420. run-bindings-tests shows diff error for a newly added binding test
  23421. https://bugs.webkit.org/show_bug.cgi?id=73179
  23422. Reviewed by Adam Barth.
  23423. Currently, when we add a new binding test, say bindings/scripts/test/TestSupplemental.idl,
  23424. run-bindings-tests just shows diff error because reference files
  23425. (i.e. {V8,JS,...}TestSupplemental.h and {V8,JS,...}TestSupplemental.cpp) do not yet exist:
  23426. FAIL: (V8) V8TestSupplemental.h
  23427. diff: WebCore/bindings/scripts/test/V8/V8TestSupplemental.h: No such file or directory
  23428. Instead, this patch treats a non-existent reference file as an empty file and
  23429. shows the result of the newly added binding test, like this:
  23430. FAIL: (V8) V8TestSupplemental.h
  23431. --- WebCore/bindings/scripts/test/V8/V8TestSupplemental.h 1970-01-01 09:00:00.000000000 +0900
  23432. +++ /tmp/tmpmX2i2F/V8TestSupplemental.h 2011-11-28 11:08:34.150707677 +0900
  23433. @@ -0,0 +1,84 @@
  23434. +/*
  23435. + This file is part of the WebKit open source project.
  23436. + This file has been generated by generate-bindings.pl. DO NOT MODIFY!
  23437. +
  23438. (omitted)
  23439. * Scripts/run-bindings-tests:
  23440. (detect_changes): Just added an -N option to the diff command.
  23441. 2011-11-28 Martin Robinson <mrobinson@igalia.com>
  23442. [Gtk][gtkdoc] Syntax error in Tools/gtk/generate-gtkdoc
  23443. https://bugs.webkit.org/show_bug.cgi?id=73165
  23444. Reviewed by Philippe Normand.
  23445. Fix some syntax errors in this script and remove an unused variable.
  23446. * gtk/generate-gtkdoc:
  23447. (get_webkit2_options.src_path):
  23448. (get_webkit2_options):
  23449. (get_webkit1_options.src_path):
  23450. 2011-11-26 Kevin Ollivier <kevino@theolliviers.com>
  23451. [wx] Unreviewed build fix. Enable the inspector.
  23452. * waf/build/settings.py:
  23453. 2011-11-26 Martin Robinson <mrobinson@igalia.com>
  23454. Try to fix the build after r101174.
  23455. * gtk/generate-gtkdoc: Properly handle empty PKG_CONFIG_PATHs.
  23456. 2011-11-17 Martin Robinson <mrobinson@igalia.com>
  23457. [GTK] Integrate build-gtkdoc into build-webkit and make
  23458. https://bugs.webkit.org/show_bug.cgi?id=72626
  23459. Reviewed by Philippe Normand.
  23460. * GNUmakefile.am: Added support for new scripts and "make docs".
  23461. * Scripts/webkitdirs.pm: Call generate-gtkdoc when building.
  23462. (buildAutotoolsProject):
  23463. * gtk/generate-gtkdoc: Added.
  23464. * gtk/gtkdoc.py: Renamed from Source/WebKit2/UIProcess/API/gtk/docs/gtkdoc.py.
  23465. 2011-11-25 Ádám Kallai <Kallai.Adam@stud.u-szeged.hu>
  23466. [Qt] Add support for using OWRT with Qt5
  23467. https://bugs.webkit.org/show_bug.cgi?id=72947
  23468. Add qt-5.0 platform and don't pass -graphicssystem to QtTestBrowser if using Qt5.
  23469. Reviewed by Csaba Osztrogonác.
  23470. * Scripts/old-run-webkit-tests:
  23471. 2011-11-25 Yury Semikhatsky <yurys@chromium.org>
  23472. [Chromium] Web Inspector: get rid of WebDevToolsFrontendClient::sendFrontendLoaded method
  23473. https://bugs.webkit.org/show_bug.cgi?id=73126
  23474. No need to have a separate client call for this. The front-end can store messages
  23475. which arrive before front-end loaded and dispatch them later. This happens in layout
  23476. tests only by the way as all other messages should be initiated by the front-end code.
  23477. Reviewed by Pavel Feldman.
  23478. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  23479. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  23480. * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  23481. * DumpRenderTree/chromium/DRTDevToolsClient.h:
  23482. 2011-11-24 Kentaro Hara <haraken@chromium.org>
  23483. Replace subprocess.call() with subprocess.Popen()
  23484. https://bugs.webkit.org/show_bug.cgi?id=73105
  23485. Reviewed by Adam Barth.
  23486. Currently, the stdout and stderr of the child processes of run-bindings-tests
  23487. are mixed (or even gone away) with the stdout and stderr of run-bindings-tests itself.
  23488. This is the problem of subprocess.call(), which does not synchronize the stdout and stderr
  23489. between a parent process and a child process. This patch replaces subprocess.call() with
  23490. subprocess.Popen() and synchronizes the stdout and stderr between them.
  23491. This patch also makes output messages of run-bindings-tests more readable.
  23492. With this patch, the output messages of run-bindings-tests look like as follows:
  23493. PASS: (CPP) WebDOMTestObj.h
  23494. PASS: (CPP) WebDOMTestObj.cpp
  23495. FAIL: (CPP) WebDOMTestInterface.h
  23496. --- Source/WebCore/bindings/scripts/test/CPP/WebDOMTestInterface.h 2011-11-25 13:34:09.313516268 +0900
  23497. +++ /tmp/tmpDAV87G/WebDOMTestInterface.h 2011-11-25 13:44:42.712946812 +0900
  23498. @@ -23,7 +23,7 @@
  23499. #ifndef WebDOMTestInterface_h
  23500. #define WebDOMTestInterface_h
  23501. -#if ENABLE(Condition1) || ENABLE(Condition2)
  23502. +#if ENABLE(Condition1) || ENABLE(Condition3)
  23503. #include <WebDOMObject.h>
  23504. #include <WebDOMString.h>
  23505. @@ -53,5 +53,5 @@
  23506. WebDOMTestInterface toWebKit(WebCore::TestInterface*);
  23507. #endif
  23508. -#endif // ENABLE(Condition1) || ENABLE(Condition2)
  23509. +#endif // ENABLE(Condition1) || ENABLE(Condition3)
  23510. PASS: (CPP) WebDOMFloat64Array.cpp
  23511. PASS: (CPP) WebDOMFloat64Array.h
  23512. Some tests FAIL! (To update the reference files, execute "run-bindings-tests --reset-results")
  23513. * Scripts/run-bindings-tests:
  23514. (generate_from_idl):
  23515. (detect_changes):
  23516. (run_tests):
  23517. (main):
  23518. 2011-11-24 Kentaro Hara <haraken@chromium.org>
  23519. Fix the current working directory of run-bindings-tests
  23520. https://bugs.webkit.org/show_bug.cgi?id=73106
  23521. Reviewed by Adam Barth.
  23522. Currently, run-bindings-tests outputs the following error
  23523. (although it outputs "all tests passed!" in the end):
  23524. Testing the ObjC generator on TestObj.idl
  23525. gcc: WebCore/bindings/objc/PublicDOMInterfaces.h: No such file or directory
  23526. gcc: warning: '-x objective-c' after last input file has no effect
  23527. gcc: no input files
  23528. This is because CodeGeneratorObjC.pm assumes that the current working directory
  23529. is WebKit/Source/, but run-bindings-tests sets the current working directory to WebKit/.
  23530. Thus, this patch changes it to WebKit/Source/.
  23531. * Scripts/run-bindings-tests:
  23532. (generate_from_idl):
  23533. (main):
  23534. 2011-11-24 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  23535. [Qt] Get rid of the buildDirForSource() function in the build system
  23536. At some point the plan was to allow for running qmake on sub-trees
  23537. of the sources, into the top level build directory, but this is no
  23538. longer possible, so no reason to keep the convenience function around.
  23539. Reviewed by Simon Hausmann.
  23540. * WebKitTestRunner/DerivedSources.pri:
  23541. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  23542. * qmake/mkspecs/features/default_post.prf:
  23543. * qmake/mkspecs/features/default_pre.prf:
  23544. * qmake/mkspecs/features/functions.prf:
  23545. * qmake/mkspecs/features/javascriptcore.prf:
  23546. * qmake/mkspecs/features/webcore.prf:
  23547. * qmake/mkspecs/features/webkit2.prf:
  23548. 2011-11-23 Sheriff Bot <webkit.review.bot@gmail.com>
  23549. Unreviewed, rolling out r101107.
  23550. http://trac.webkit.org/changeset/101107
  23551. https://bugs.webkit.org/show_bug.cgi?id=73062
  23552. Breaks the commit-queue (Requested by abarth on #webkit).
  23553. * Scripts/webkitpy/common/host.py:
  23554. (Host._engage_awesome_windows_hacks):
  23555. * Scripts/webkitpy/common/host_mock.py:
  23556. (MockHost.__init__):
  23557. * Scripts/webkitpy/common/system/environment.py: Removed.
  23558. * Scripts/webkitpy/common/system/environment_unittest.py: Removed.
  23559. * Scripts/webkitpy/common/system/executive.py:
  23560. (Executive._run_command_with_teed_output):
  23561. (Executive.run_and_throw_if_fail):
  23562. * Scripts/webkitpy/common/system/executive_mock.py:
  23563. (MockExecutive.run_and_throw_if_fail):
  23564. (MockExecutive.run_command):
  23565. * Scripts/webkitpy/layout_tests/port/webkit.py:
  23566. (WebKitPort._driver_build_script_name):
  23567. (WebKitPort._run_script):
  23568. (WebKitPort._build_driver):
  23569. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  23570. (test_build_driver):
  23571. * Scripts/webkitpy/tool/commands/download_unittest.py:
  23572. * Scripts/webkitpy/tool/steps/build.py:
  23573. (Build.build):
  23574. 2011-11-23 Ojan Vafai <ojan@chromium.org>
  23575. Unreviewed, rolling out r101110.
  23576. http://trac.webkit.org/changeset/101110
  23577. https://bugs.webkit.org/show_bug.cgi?id=73057
  23578. The bots have now cycled and this patch is no longer needed.
  23579. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  23580. (Manager._upload_json_files):
  23581. 2011-11-23 Ojan Vafai <ojan@chromium.org>
  23582. Temporarily save the incremental results json in order to identify bug
  23583. https://bugs.webkit.org/show_bug.cgi?id=73057
  23584. Reviewed by Dean Jackson.
  23585. The test results server needed to be rolled back from tip of tree
  23586. due to a JSON merging bug. It's hard to identify what the bug is without
  23587. the raw data.
  23588. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  23589. (Manager._upload_json_files):
  23590. 2011-11-23 Ojan Vafai <ojan@chromium.org>
  23591. Merging two version 4 results hits an error in the test results server
  23592. https://bugs.webkit.org/show_bug.cgi?id=73042
  23593. Reviewed by Adam Barth.
  23594. The old code assumed that if the aggregate results value was not a leaf
  23595. value that the incremental results would exist, which is just totally
  23596. wrong. Added a test for that case as well.
  23597. * TestResultServer/model/jsonresults.py:
  23598. (JsonResults._merge_tests):
  23599. * TestResultServer/model/jsonresults_unittest.py:
  23600. (JsonResultsTest.test_merge_build_directory_hierarchy_old_version):
  23601. (JsonResultsTest.test_merge_build_directory_hierarchy):
  23602. 2011-11-23 Eric Seidel <eric@webkit.org>
  23603. Add Environment object to Host and fix the GCC smartquotes trouble seen on the commit-queue
  23604. https://bugs.webkit.org/show_bug.cgi?id=71983
  23605. Reviewed by Adam Barth.
  23606. We'll add more code to Environment overtime,
  23607. allowing us to mock out more of our direct interactions with os.environ.
  23608. This patch also makes run_command print the passed in environment.
  23609. * Scripts/webkitpy/common/host_mock.py:
  23610. * Scripts/webkitpy/common/system/environment.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  23611. * Scripts/webkitpy/common/system/environment_mock.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  23612. * Scripts/webkitpy/common/system/environment_unittest.py: Copied from Tools/Scripts/webkitpy/tool/steps/build.py.
  23613. * Scripts/webkitpy/common/system/executive.py:
  23614. * Scripts/webkitpy/common/system/executive_mock.py:
  23615. * Scripts/webkitpy/layout_tests/port/webkit.py:
  23616. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  23617. * Scripts/webkitpy/tool/commands/download_unittest.py:
  23618. * Scripts/webkitpy/tool/steps/build.py:
  23619. 2011-11-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  23620. [Qt] Re-generate QtWebKit API forwarding headers when API changes
  23621. The forwarding headers are generated by syncqt, and syncqt is run by qmake,
  23622. so we need sync.profile to live in the same directory as the project file
  23623. that will be touched when adding/removing API (api.pri in our case).
  23624. Since the WebKit2 APIs live in a separate static library, we have to
  23625. add the project file for WebKit2 as a dependency of the api.pri file
  23626. as well, so that any changes to the WebKit2 API will still trigger a
  23627. run of qmake (and then syncqt).
  23628. Lastly, we use the new QMAKE_SYNCQT_OUTDIR variable in Qt 5 to ensure
  23629. that the forwarding headers are still generated in the root build dir,
  23630. not in the Source dir along with the internal forwarding headers.
  23631. Reviewed by Andreas Kling.
  23632. * qmake/mkspecs/features/default_pre.prf:
  23633. * qmake/mkspecs/features/functions.prf:
  23634. 2011-11-23 Johnny Ding <jnd@chromium.org>
  23635. Set right default value to baseURL in LayoutTestController::queueLoadHTMLString.
  23636. https://bugs.webkit.org/show_bug.cgi?id=72950
  23637. Reviewed by Tony Chang.
  23638. * DumpRenderTree/chromium/LayoutTestController.cpp:
  23639. (LayoutTestController::queueLoadHTMLString):
  23640. 2011-11-23 Adam Barth <abarth@webkit.org>
  23641. garden-o-matic should display a message if it can't find results to display
  23642. https://bugs.webkit.org/show_bug.cgi?id=72991
  23643. Reviewed by Dimitri Glazkov.
  23644. Not all failures (e.g., TIMEOUT) have results that we can display.
  23645. This patch adds a short message so that the user can see that we're
  23646. done trying to load the results.
  23647. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  23648. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  23649. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  23650. 2011-11-23 Adam Barth <abarth@webkit.org>
  23651. garden-o-matic should explain more clearly what the builder lists at the top of the page mean
  23652. https://bugs.webkit.org/show_bug.cgi?id=72992
  23653. Reviewed by Dimitri Glazkov.
  23654. This patch also prepares us to list other sorts of failures, like
  23655. performance and unit test.
  23656. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  23657. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  23658. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  23659. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  23660. 2011-11-23 Ryan Sleevi <rsleevi@chromium.org>
  23661. Add new Chromium tests to the flakiness dashboard
  23662. https://bugs.webkit.org/show_bug.cgi?id=72997
  23663. Reviewed by Ojan Vafai.
  23664. * TestResultServer/static-dashboards/dashboard_base.js:
  23665. ():
  23666. 2011-11-23 Adam Barth <abarth@webkit.org>
  23667. garden-o-matic should support AUDIO failures
  23668. https://bugs.webkit.org/show_bug.cgi?id=69477
  23669. Reviewed by Dimitri Glazkov.
  23670. This is a first iteration at supporting AUDIO failures in
  23671. garden-o-matic. We'll probably need to iterate a bit when we have a
  23672. real audio failure in the tree to play with. For example, we'll
  23673. probably want to add and <audio> element to the "Examine" view to hear
  23674. the differences, but that all can be done in a subsequent patch.
  23675. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  23676. 2011-11-23 Scott Graham <scottmg@chromium.org>
  23677. Adding gamepad support
  23678. https://bugs.webkit.org/show_bug.cgi?id=69451
  23679. Reviewed by Darin Fisher.
  23680. Add a 'gamepadController' to Chromium DRT. Allows for setting of mock
  23681. gamepad data that will be retrieved when JS code pulls via API access.
  23682. * DumpRenderTree/DumpRenderTree.gypi:
  23683. * DumpRenderTree/chromium/GamepadController.cpp: Added.
  23684. (GamepadController::GamepadController):
  23685. (GamepadController::bindToJavascript):
  23686. (GamepadController::reset):
  23687. (GamepadController::connect):
  23688. (GamepadController::disconnect):
  23689. (GamepadController::setId):
  23690. (GamepadController::setButtonCount):
  23691. (GamepadController::setButtonData):
  23692. (GamepadController::setAxisCount):
  23693. (GamepadController::setAxisData):
  23694. (GamepadController::fallbackCallback):
  23695. * DumpRenderTree/chromium/GamepadController.h: Added.
  23696. * DumpRenderTree/chromium/TestShell.cpp:
  23697. (TestShell::TestShell):
  23698. (TestShell::resetTestController):
  23699. (TestShell::bindJSObjectsToWindow):
  23700. * DumpRenderTree/chromium/TestShell.h:
  23701. (TestShell::gamepadController):
  23702. 2011-11-23 Raphael Kubo da Costa <kubo@profusion.mobi>
  23703. [CMake] Move the top-level logic to the top-level directory.
  23704. https://bugs.webkit.org/show_bug.cgi?id=72685
  23705. Reviewed by Brent Fulgham.
  23706. * CMakeLists.txt: Added.
  23707. * DumpRenderTree/efl/CMakeLists.txt: Keep building into Programs/.
  23708. * EWebLauncher/CMakeLists.txt: Renamed from Tools/CMakeListsEfl.txt.
  23709. * Scripts/webkitdirs.pm:
  23710. (generateBuildSystemFromCMakeProject):
  23711. * WinCELauncher/CMakeLists.txt: Renamed from Tools/CMakeListsWinCE.txt.
  23712. 2011-11-17 Vincent Scheib <scheib@chromium.org>
  23713. Pointer Lock: Initial Tests for navigator.webkitPonter
  23714. https://bugs.webkit.org/show_bug.cgi?id=72659
  23715. Reviewed by Darin Fisher.
  23716. * DumpRenderTree/chromium/TestShell.cpp:
  23717. (TestShell::TestShell):
  23718. Enabling PointerLock in TestShell
  23719. 2011-11-22 Ryan Sleevi <rsleevi@chromium.org>
  23720. Update flakiness dashboard for new Chromium builders and tests
  23721. https://bugs.webkit.org/show_bug.cgi?id=72931
  23722. Reviewed by Ojan Vafai.
  23723. * TestResultServer/static-dashboards/builders.js:
  23724. * TestResultServer/static-dashboards/dashboard_base.js:
  23725. 2011-11-22 Adam Roben <aroben@apple.com>
  23726. Remove some debugging code I accidentally left in r101005
  23727. * Scripts/prepare-ChangeLog:
  23728. (get_function_line_ranges_for_python):
  23729. 2011-11-22 Adam Roben <aroben@apple.com>
  23730. Teach prepare-ChangeLog how to find changed classes/methods/functions in Python files
  23731. Fixes <http://webkit.org/b/57008> prepare-ChangeLog doesn't find names of modified
  23732. classes/methods in Python source files
  23733. Reviewed by Dan Bates.
  23734. * Scripts/prepare-ChangeLog:
  23735. (get_function_line_ranges): Call get_function_line_ranges_for_python for files ending in .py
  23736. or that use python as their interpreter. Modified the code that extracts the interpreter to
  23737. ignore a leading "/usr/bin/env " in the interpreter line, as is common for our Python
  23738. scripts.
  23739. (get_function_line_ranges_for_python): Added. Does simple parsing of Python files to look
  23740. for class/def lines and generate ranges based on them.
  23741. 2011-11-21 Yuta Kitamura <yutak@chromium.org>
  23742. [GTK] Enable WebSocket hybi tests
  23743. https://bugs.webkit.org/show_bug.cgi?id=72870
  23744. Reviewed by Xan Lopez.
  23745. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  23746. (resetDefaultsToConsistentValues):
  23747. Reset the setting value to the default value (true).
  23748. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  23749. (LayoutTestController::overridePreference):
  23750. Change the setting value through a function in DumpRenderTreeSupportGtk.
  23751. 2011-11-21 Ryosuke Niwa <rniwa@webkit.org>
  23752. ChangeLogEntry should be able to parse entries with multiple authors
  23753. https://bugs.webkit.org/show_bug.cgi?id=72690
  23754. Reviewed by Eric Seidel.
  23755. Support multi-author change log entries in ChangeLogEntry. Split author names using
  23756. the same logic as splitting reviewer names. _authors now stores list of dictionaries
  23757. with "name" and "email" as keys. Unlike reviewers, we can't always resolve authors to
  23758. accounts because some contributors are never listed in committers.py.
  23759. * Scripts/webkitpy/common/checkout/changelog.py:
  23760. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  23761. * Scripts/webkitpy/common/config/committers.py: Fixed a bug that *_by_{name|email}
  23762. throws an exception when the argument is None.
  23763. 2011-11-21 Simon Hausmann <simon.hausmann@nokia.com>
  23764. [Qt] Speed up debug builds.
  23765. https://bugs.webkit.org/show_bug.cgi?id=72882
  23766. Reviewed by Tor Arne Vestbø.
  23767. Introduce a special type of build that replaces the static jsc/wc/wk2
  23768. static libraries with shared libraries, that individually are much faster
  23769. to link and don't require relinking into the big library when changing just
  23770. one file in one module. It can be enabled with
  23771. --qmakearg="CONFIG+=force_static_libs_as_shared"
  23772. * qmake/mkspecs/features/force_static_libs_as_shared.prf: Added. With this configuration,
  23773. disable symbol visibility, static linkage and enable rpath.
  23774. * qmake/mkspecs/features/functions.prf: Add a helper function to determine if
  23775. we need to link the convenience libraries together or not and renamed linkStaticLibrary
  23776. to just linkLibrary (because linkage is not necessarily static).
  23777. * qmake/mkspecs/features/qtwebkit.prf: When using the trick, make sure to also
  23778. link against jsc/wc/wk2 when linking app code against QtWebKit.
  23779. * qmake/mkspecs/features/javascriptcore.prf: Use new +needToLinkLibrary helper
  23780. function.
  23781. * qmake/mkspecs/features/webcore.prf: Ditto.
  23782. * qmake/mkspecs/features/webkit2.prf: Ditto.
  23783. 2011-11-21 Adam Klein <adamk@chromium.org>
  23784. Update flakiness dashboard linkification regexps for crbug.com/100000 and above
  23785. https://bugs.webkit.org/show_bug.cgi?id=72898
  23786. Reviewed by Ojan Vafai.
  23787. Also removed a comment that was going to be more trouble to keep up to
  23788. date than seemed worthwhile (the code is now the documentation).
  23789. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  23790. 2011-11-21 Dominic Mazzoni <dmazzoni@google.com>
  23791. [Chromium] WebAccessibilityNotification should use AssertMatchingEnums.
  23792. https://bugs.webkit.org/show_bug.cgi?id=72895
  23793. Reviewed by Chris Fleizach.
  23794. * DumpRenderTree/chromium/WebViewHost.cpp:
  23795. (WebViewHost::postAccessibilityNotification):
  23796. 2011-11-21 Philippe Normand <pnormand@igalia.com>
  23797. Unreviewed, run-gtk-tests temporary workaround after r98500.
  23798. * Scripts/run-gtk-tests: Try to find the build directory like in
  23799. build-gtkdoc, until webkit-build-directory --configuration gets fixed.
  23800. 2011-11-21 Carlos Garcia Campos <cgarcia@igalia.com>
  23801. [GTK] Add a way to skip unit tests in the bots
  23802. https://bugs.webkit.org/show_bug.cgi?id=72879
  23803. Reviewed by Philippe Normand.
  23804. Rewrite the script in python to make it easier for everybody to
  23805. change it and add support for skipping tests.
  23806. * Scripts/run-gtk-tests:
  23807. 2011-11-21 Raphael Kubo da Costa <kubo@profusion.mobi>
  23808. [EFL] Add more appcache functions to ewk_settings.
  23809. https://bugs.webkit.org/show_bug.cgi?id=72143
  23810. Reviewed by Kenneth Rohde Christiansen.
  23811. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  23812. (LayoutTestController::clearAllApplicationCaches):
  23813. (LayoutTestController::setAppCacheMaximumSize): Use the right
  23814. function, this is not related to the memory cache, but rather to the
  23815. appcache.
  23816. 2011-11-18 Adam Roben <aroben@apple.com>
  23817. Make NRWT consider all lines of output from parse-malloc-history, not just the first
  23818. Fixes <http://webkit.org/b/72652> REGRESSION (NRWT): NRWT always reports "1 unique leaks
  23819. found" even when there are more than 1 unique leaks
  23820. Reviewed by Darin Adler.
  23821. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  23822. (LeakDetector.count_total_bytes_and_unique_leaks): Pass re.MULTILINE to re.findall so that
  23823. "^" will be considered to match the beginning of any line, not only the beginning of the
  23824. string.
  23825. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  23826. (LeakDetectorTest.test_count_total_bytes_and_unique_leaks): Added a second callstack to the
  23827. fake output and updated expectations to match.
  23828. 2011-11-21 Andras Becsi <andras.becsi@nokia.com>
  23829. [Qt] Clean up MiniBrowser project file after recent changes
  23830. https://bugs.webkit.org/show_bug.cgi?id=72869
  23831. Reviewed by Simon Hausmann.
  23832. Remove nonexistent files from OTHER_FILES after our touch and desktop webviews were merged.
  23833. * MiniBrowser/qt/MiniBrowser.pro:
  23834. 2011-11-21 Dominic Mazzoni <dmazzoni@google.com>
  23835. Accessibility: Multiselect list boxes need to report the active option in addition to which items are selected.
  23836. https://bugs.webkit.org/show_bug.cgi?id=72479
  23837. Reviewed by Chris Fleizach.
  23838. * DumpRenderTree/AccessibilityUIElement.cpp:
  23839. (getIsSelectedOptionActiveCallback):
  23840. (AccessibilityUIElement::getJSClass):
  23841. * DumpRenderTree/AccessibilityUIElement.h:
  23842. * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  23843. (AccessibilityUIElement::AccessibilityUIElement):
  23844. (AccessibilityUIElement::isSelectedOptionActiveGetterCallback):
  23845. * DumpRenderTree/chromium/AccessibilityUIElement.h:
  23846. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  23847. (AccessibilityUIElement::isSelectedOptionActive):
  23848. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  23849. (AccessibilityUIElement::isSelectedOptionActive):
  23850. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  23851. (AccessibilityUIElement::isSelectedOptionActive):
  23852. 2011-11-21 Takashi Toyoshima <toyoshim@chromium.org>
  23853. Use Host().port_factory instead of webkitpy.layout_tests.port.factory.
  23854. https://bugs.webkit.org/show_bug.cgi?id=72859
  23855. Reviewed by Eric Seidel.
  23856. * Scripts/new-run-webkit-websocketserver:
  23857. 2011-11-20 Shinya Kawanaka <shinyak@google.com>
  23858. [Chromium] Layout test does not return correct misspelling positions if there are multiple misspelled words.
  23859. https://bugs.webkit.org/show_bug.cgi?id=72655
  23860. Reviewed by Hajime Morita.
  23861. Fixed the calculation of offset.
  23862. * DumpRenderTree/chromium/WebViewHost.cpp:
  23863. (WebViewHost::finishLastTextCheck):
  23864. 2011-11-20 Ojan Vafai <ojan@chromium.org>
  23865. Change the final place where we use version 3 of the results json output
  23866. https://bugs.webkit.org/show_bug.cgi?id=72838
  23867. Reviewed by Adam Barth.
  23868. This converts the json from being a flat map of test name --> results
  23869. to being hierarchical by directory. This will make the json files
  23870. considerably smaller.
  23871. Also cleaned up some functions that were returning/checking boolean values
  23872. that were always True.
  23873. * TestResultServer/model/jsonresults.py:
  23874. * TestResultServer/model/jsonresults_unittest.py:
  23875. 2011-11-20 Ojan Vafai <ojan@chromium.org>
  23876. Include the master name when querying the test results server.
  23877. This will soon be required since leaving the master name out mean
  23878. that multiple files could match the query.
  23879. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  23880. 2011-11-19 Ojan Vafai <ojan@chromium.org>
  23881. Fix jsonp callback code to add the callback if json content
  23882. is not jsonp.
  23883. * TestResultServer/handlers/testfilehandler.py:
  23884. 2011-11-19 Alice Boxhall <aboxhall@chromium.org>
  23885. Modify dashboard_base.js to optionally accept version 4 results json.
  23886. Reviewed by Ojan Vafai.
  23887. * TestResultServer/static-dashboards/dashboard_base.js:
  23888. (ADD_RESULTS):
  23889. (flattenTrie):
  23890. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  23891. (testFlattenTrie):
  23892. 2011-11-19 Ojan Vafai <ojan@chromium.org>
  23893. Stop storing results files as jsonp in the test results server
  23894. https://bugs.webkit.org/show_bug.cgi?id=72814
  23895. Reviewed by Adam Barth.
  23896. * TestResultServer/model/jsonresults.py:
  23897. * TestResultServer/model/jsonresults_unittest.py:
  23898. 2011-11-19 Ojan Vafai <ojan@chromium.org>
  23899. Remove the dependence on jsonp from more of new-run-webkit-tests and the test results server
  23900. https://bugs.webkit.org/show_bug.cgi?id=72813
  23901. Reviewed by Adam Barth.
  23902. Once this lands, we can start storing pure json in the test results server and then
  23903. we can delete the code with all the FIXMEs added here.
  23904. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  23905. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  23906. Only add jsonp for full_results.json.
  23907. * TestResultServer/model/jsonresults.py:
  23908. * TestResultServer/model/jsonresults_unittest.py:
  23909. Accept pure json uploads.
  23910. * TestResultServer/static-dashboards/dashboard_base.js:
  23911. (appendJSONScriptElementFor):
  23912. Use the callback parameter so that the server can start returning pure json if it's left out.
  23913. 2011-11-19 Ojan Vafai <ojan@chromium.org>
  23914. Allow json NRWT downloads to be pure json and not jsonp
  23915. https://bugs.webkit.org/show_bug.cgi?id=72809
  23916. Reviewed by Adam Barth.
  23917. I'm moving the server to storing and serving up raw json instead of jsonp.
  23918. You can still get the jsonp by passing a "callback" parameter, but there's no
  23919. need for run-webkit-tests to get jsonp when all it wants is the raw json.
  23920. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  23921. Make the wrapper stripping only happen if the json is actually wrapped.
  23922. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  23923. 2011-11-18 Daniel Bates <dbates@rim.com>
  23924. Add CMake build infrastructure for the BlackBerry port
  23925. https://bugs.webkit.org/show_bug.cgi?id=72768
  23926. Reviewed by Antonio Gomes.
  23927. Add optional --blackberry command line argument to build-webkit to build the
  23928. BlackBerry port.
  23929. * Scripts/build-webkit:
  23930. * Scripts/webkitdirs.pm:
  23931. (determineBaseProductDir):
  23932. (argumentsForConfiguration):
  23933. (builtDylibPathForName):
  23934. (determineIsQt):
  23935. (isBlackBerry): Added.
  23936. (determineIsBlackBerry): Added.
  23937. (blackberryTargetArchitecture): Added.
  23938. (isAppleWebKit):
  23939. 2011-11-18 James Robinson <jamesr@chromium.org>
  23940. Unreviewed, rolling out r100835.
  23941. http://trac.webkit.org/changeset/100835
  23942. https://bugs.webkit.org/show_bug.cgi?id=72778
  23943. Broke some page scale tests
  23944. * DumpRenderTree/chromium/EventSender.cpp:
  23945. (EventSender::scalePageBy):
  23946. 2011-11-18 Adam Barth <abarth@webkit.org>
  23947. Prepare to move manual-tests out of WebCore
  23948. https://bugs.webkit.org/show_bug.cgi?id=72782
  23949. Reviewed by Eric Seidel.
  23950. Update this file to refer to the new location of ManualTests.
  23951. * Scripts/webkitpy/common/config/build.py:
  23952. 2011-11-18 James Robinson <jamesr@chromium.org>
  23953. [chromium] Set min/max page scale factors when calling eventSender.scalePageBy to avoid clamping
  23954. https://bugs.webkit.org/show_bug.cgi?id=72778
  23955. Reviewed by Kenneth Russell.
  23956. Set the min/max page scale clamps when a test calls eventSender.scalePageBy() so that the scale isn't clamped.
  23957. * DumpRenderTree/chromium/EventSender.cpp:
  23958. (EventSender::scalePageBy):
  23959. 2011-11-18 Scott Graham <scottmg@chromium.org>
  23960. IDL changes for gamepad support
  23961. https://bugs.webkit.org/show_bug.cgi?id=71753
  23962. Reviewed by Adam Barth.
  23963. Runtime enable gamepad in chromium test shell.
  23964. * DumpRenderTree/chromium/TestShell.cpp:
  23965. (TestShell::TestShell):
  23966. 2011-10-27 Darin Fisher <darin@chromium.org>
  23967. [chromium] Improve fullscreen API
  23968. https://bugs.webkit.org/show_bug.cgi?id=70477
  23969. Reviewed by Adam Barth.
  23970. Implement enter/exitFullScreen. The implementation is asynchronous,
  23971. via postDelayedTask, to simulate how the browser actually behaves.
  23972. * DumpRenderTree/chromium/WebViewHost.cpp:
  23973. (WebViewHost::enterFullScreen):
  23974. (WebViewHost::exitFullScreen):
  23975. (WebViewHost::setAddressBarURL):
  23976. (WebViewHost::enterFullScreenNow):
  23977. (WebViewHost::exitFullScreenNow):
  23978. * DumpRenderTree/chromium/WebViewHost.h:
  23979. 2011-11-18 Adam Roben <aroben@apple.com>
  23980. Ignore an ANGLE leak that is not WebKit's fault
  23981. * Scripts/old-run-webkit-tests:
  23982. (countAndPrintLeaks):
  23983. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  23984. (LeakDetector._callstacks_to_exclude_from_leaks):
  23985. Added ScanFromString to the call stacks to exclude on all OS versions.
  23986. 2011-11-18 Adam Roben <aroben@apple.com>
  23987. Ignore another Lion-specific leak that is not WebKit's fault
  23988. * Scripts/old-run-webkit-tests:
  23989. (countAndPrintLeaks):
  23990. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  23991. (LeakDetector._callstacks_to_exclude_from_leaks):
  23992. Added SecTransformExecute to the call stacks to exclude.
  23993. 2011-11-18 Yuta Kitamura <yutak@chromium.org>
  23994. [Qt] Enable WebSocket hybi tests
  23995. https://bugs.webkit.org/show_bug.cgi?id=72687
  23996. Reviewed by Simon Hausmann.
  23997. Let LayoutTestControllerQt be able to switch WebSocket protocols via overridePreference().
  23998. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  23999. (WebCore::WebPage::resetSettings):
  24000. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  24001. (LayoutTestController::overridePreference):
  24002. 2011-11-18 Sergio Villar Senin <svillar@igalia.com>
  24003. [GTK][WK2] Invalid TestNetscapePlugin path when using new-run-webkit-tests
  24004. https://bugs.webkit.org/show_bug.cgi?id=72707
  24005. Reviewed by Philippe Normand.
  24006. Make new-run-webkit-tests use the right path to locate the test
  24007. plugin used by WebKitTestRunner.
  24008. * Scripts/webkitpy/layout_tests/port/gtk.py:
  24009. 2011-11-18 Simon Hausmann <simon.hausmann@nokia.com>
  24010. [Qt] WTR and InjectedBundle should not link statically against JSC/WTF
  24011. https://bugs.webkit.org/show_bug.cgi?id=72697
  24012. Reviewed by Kenneth Rohde Christiansen.
  24013. * Tools.pro: Make WTR linux only for the moment.
  24014. * WebKitTestRunner/InjectedBundle/Target.pri: Remove static jsc/wtf linkage.
  24015. * WebKitTestRunner/Target.pri: Ditto.
  24016. * qmake/mkspecs/features/default_post.prf: Don't build the main webkit sources
  24017. with ELF visibility on Linux. Instead we're temporarily using an LD version script.
  24018. 2011-11-18 Kenneth Rohde Christiansen <kenneth@webkit.org>
  24019. [Qt] Change default size of the MiniBrowser
  24020. Reviewed by Simon Hausmann.
  24021. As we lay out desktop pages using the width of 980, change our default
  24022. size to 980x735 so that we are not scaling down by default.
  24023. * MiniBrowser/qt/MiniBrowserApplication.h:
  24024. (WindowOptions::WindowOptions):
  24025. 2011-11-17 Raphael Kubo da Costa <kubo@profusion.mobi>
  24026. [EFL] Clean up the use of DATA_DIR in the buildsystem
  24027. https://bugs.webkit.org/show_bug.cgi?id=72681
  24028. Reviewed by Daniel Bates.
  24029. Instead of adding -DDATA_DIR in all scopes, only define it in
  24030. WebCore/PlatformEFL.cmake, as WebCore is the only place that uses
  24031. it.
  24032. We can then define DATA_DIR to the generated theme directory for
  24033. EWebLauncher, since it's what we want here.
  24034. * CMakeListsEfl.txt:
  24035. 2011-11-17 Raphael Kubo da Costa <kubo@profusion.mobi>
  24036. [EFL] Move platform includes last in DRT's include directories.
  24037. https://bugs.webkit.org/show_bug.cgi?id=72684
  24038. Reviewed by Daniel Bates.
  24039. This is the first step in fixing the build when a platform include (in
  24040. this case, Valgrind 3.7.0 ships its config.h) and the wrong config.h
  24041. is included instead of WebKit's.
  24042. * DumpRenderTree/efl/CMakeLists.txt:
  24043. 2011-11-17 Ryosuke Niwa <rniwa@webkit.org>
  24044. fuzzy_match doesn't recognize "Dan B" or "hyatt"
  24045. https://bugs.webkit.org/show_bug.cgi?id=72636
  24046. Reviewed by Eric Seidel.
  24047. Make contributors_by_fuzz_match search string in shorthand names of contributors such as "Ryosuke N"
  24048. and user names of email addreses such as rniwa in rniwa@webkit.org.
  24049. Also import legacy contributor names and mispell lists from Eric's script on the bug 26533 as a test.
  24050. * Scripts/webkitpy/common/config/committers.py:
  24051. * Scripts/webkitpy/common/config/committers_unittest.py:
  24052. 2011-11-17 Eric Seidel <eric@webkit.org>
  24053. Remove support for running check-webkit-style w/o a webkit checkout
  24054. https://bugs.webkit.org/show_bug.cgi?id=72678
  24055. Reviewed by Adam Barth.
  24056. After talking to Dave Levin we've decided to remove this
  24057. code. I know of no users of check-webkit-style w/o a webkit checkout
  24058. and this needlessly adds complexity.
  24059. * Scripts/webkitpy/style/main.py:
  24060. 2011-11-17 Eric Seidel <eric@webkit.org>
  24061. Remove more direct uses of os.path
  24062. https://bugs.webkit.org/show_bug.cgi?id=72677
  24063. Reviewed by Adam Barth.
  24064. Remove more uses of os.path, including refactoring
  24065. CommitterValidator to use a Host object instead of
  24066. manual hacks to emulate what SCM and FileSystem provide.
  24067. * Scripts/webkitpy/common/checkout/changelog.py:
  24068. * Scripts/webkitpy/common/config/committervalidator.py:
  24069. * Scripts/webkitpy/common/config/committervalidator_unittest.py:
  24070. * Scripts/webkitpy/common/system/filesystem_mock.py:
  24071. - Turns out none of our unittests actually looked at this path.
  24072. now I've made it be a valid path.
  24073. * Scripts/webkitpy/tool/bot/feeders.py:
  24074. * Scripts/webkitpy/tool/commands/queues.py:
  24075. 2011-11-17 Eric Seidel <eric@webkit.org>
  24076. Teach TextFileReader about FileSystem
  24077. https://bugs.webkit.org/show_bug.cgi?id=72673
  24078. Reviewed by Adam Barth.
  24079. Unfortunately TextFileReader doesn't use FileSystem
  24080. everywhere yet, so we can't move the unittests to
  24081. using MockFileSystem, but we're close.
  24082. * Scripts/webkitpy/style/filereader.py:
  24083. * Scripts/webkitpy/style/filereader_unittest.py:
  24084. * Scripts/webkitpy/style/main.py:
  24085. 2011-11-17 Eric Seidel <eric@webkit.org>
  24086. Give check-webkit-style a Host
  24087. https://bugs.webkit.org/show_bug.cgi?id=72670
  24088. Reviewed by Adam Barth.
  24089. * Scripts/webkitpy/common/checkout/scm/detection.py:
  24090. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  24091. - We don't run these unittests, but this one was looking for the wrong exception.
  24092. * Scripts/webkitpy/style/main.py:
  24093. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  24094. - This was create a new scm object even though it already had one?
  24095. 2011-11-17 Eric Seidel <eric@webkit.org>
  24096. Move check-webkit-style change_directory code to more modern mocks
  24097. https://bugs.webkit.org/show_bug.cgi?id=72664
  24098. Reviewed by Adam Barth.
  24099. * Scripts/check-webkit-style:
  24100. * Scripts/webkitpy/style/main.py:
  24101. * Scripts/webkitpy/style/main_unittest.py:
  24102. 2011-11-17 Zan Dobersek <zandobersek@gmail.com>
  24103. [GTK] enable ref tests
  24104. https://bugs.webkit.org/show_bug.cgi?id=72601
  24105. Re-enable ref tests. Run the driver under evenly numbered display if performing
  24106. pixel tests or under oddly numbered display otherwise. This prevents the ref tests
  24107. being run in an already used Xvfb instance if pixel tests are disabled.
  24108. Reviewed by Tony Chang.
  24109. * Scripts/webkitpy/layout_tests/port/gtk.py: Also set Xvfb variable to None
  24110. after the process is killed
  24111. 2011-11-17 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  24112. Make check-webkit-style accept xxx_p.h as a primary header for xxx.cpp for Qt's sake
  24113. https://bugs.webkit.org/show_bug.cgi?id=72620
  24114. Reviewed by David Levin.
  24115. Qt's convention of keeping private (but exposed) API suffixed by "_p.h" but not
  24116. adding the suffix the cpp file. One example of false positive
  24117. https://bugs.webkit.org/show_bug.cgi?id=72319#c12.
  24118. * Scripts/webkitpy/style/checkers/cpp.py: accept headers ending with _p as primary if its
  24119. basename contains the cpp's basename.
  24120. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  24121. 2011-11-17 Eric Seidel <eric@webkit.org>
  24122. Move check-webkit-style's guts into webkitpy/style/main.py
  24123. https://bugs.webkit.org/show_bug.cgi?id=72657
  24124. Reviewed by Adam Barth.
  24125. * Scripts/check-webkit-style:
  24126. * Scripts/webkitpy/style/main.py:
  24127. 2011-11-17 Eric Seidel <eric@webkit.org>
  24128. new-run-webkit-tests is locale dependent
  24129. https://bugs.webkit.org/show_bug.cgi?id=68691
  24130. Reviewed by Adam Barth.
  24131. Make NRWT use a clean environment, just like ORWT did.
  24132. * Scripts/webkitpy/layout_tests/port/base.py:
  24133. * Scripts/webkitpy/layout_tests/port/chromium.py:
  24134. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  24135. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  24136. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  24137. * Scripts/webkitpy/layout_tests/port/efl.py:
  24138. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  24139. * Scripts/webkitpy/layout_tests/port/mac.py:
  24140. * Scripts/webkitpy/layout_tests/port/qt.py:
  24141. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  24142. * Scripts/webkitpy/layout_tests/port/webkit.py:
  24143. * Scripts/webkitpy/layout_tests/port/win.py:
  24144. 2011-11-17 Dirk Pranke <dpranke@chromium.org>
  24145. Chromium Mac 10.5 CG dbg bots are failing to run webkit_gpu_tests
  24146. https://bugs.webkit.org/show_bug.cgi?id=72615
  24147. Reviewed by James Robinson.
  24148. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  24149. 2011-11-17 Simon Hausmann <simon.hausmann@nokia.com>
  24150. [Qt] Layer violation: qt_runtime.cpp accesses QWebElement and QTDRTNode
  24151. https://bugs.webkit.org/show_bug.cgi?id=72595
  24152. Reviewed by Noam Rosenthal.
  24153. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  24154. (WebCore::DumpRenderTree::DumpRenderTree): Use new initialize() function to
  24155. ensure the registration of the DRTNode JS bindings.
  24156. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  24157. (LayoutTestController::LayoutTestController): Remove unnecessary explicit qt meta type
  24158. registration of QWebElement (now done implicitly through QWebPage ->
  24159. QtWebElementRunTime::initialize code path)
  24160. 2011-11-17 Adam Roben <aroben@apple.com>
  24161. Fix a crash-inducing typo I introduced in r100648
  24162. Fixes <http://webkit.org/b/72642> REGRESSION (r100648): NRWT crashes on Chromium when
  24163. handling a crashing test
  24164. Reviewed by Adam Barth.
  24165. * Scripts/webkitpy/layout_tests/port/chromium.py:
  24166. (ChromiumDriver.run_test): Get the driver name from the port.
  24167. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  24168. (ChromiumDriverTest.test_crashed_process_name): Simulate a crash and check that we got the
  24169. right crashed process name.
  24170. 2011-11-17 Adam Roben <aroben@apple.com>
  24171. Fix NRWT's parsing of the number of excluded leaks
  24172. Fixes <http://webkit.org/b/72635> NRWT crashes when parsing leaks files from which certain
  24173. leaks were excluded
  24174. Reviewed by Adam Barth.
  24175. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  24176. (LeakDetector._parse_leaks_output): Extract just the number of excluded leaks from the
  24177. regular expression match, not the entire matched string.
  24178. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  24179. (LeakDetectorTest): Added some example output that shows how things look when leaks are
  24180. excluded.
  24181. (LeakDetectorTest.test_parse_leaks_output): Test that we parse the number of exclusions
  24182. correctly.
  24183. 2011-11-17 Adam Roben <aroben@apple.com>
  24184. Make NRWT find crash logs for the crashed process, which may not necessarily be the driver process
  24185. Fixes <http://webkit.org/b/72526> REGRESSION (NRWT): WebKitTestRunner crash log gets saved
  24186. when web process crashes, but WebProcess crash log should get saved instead
  24187. Reviewed by Eric Seidel.
  24188. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
  24189. (write_test_result): Simplified a little to share more code between the case where we
  24190. crashed when running the test and where we crashed when checking the expected rendering for
  24191. a reftest. Changed to pass the crashed process name down to write_crash_report.
  24192. (TestResultWriter.write_crash_report): Added crashed_process_name parameter, which we pass
  24193. along to CrashLogs.find_newest_log rather than always using the driver name.
  24194. * Scripts/webkitpy/layout_tests/port/chromium.py:
  24195. (ChromiumDriver.run_test): Pass the driver name as the name of the crashed process if we
  24196. crashed.
  24197. * Scripts/webkitpy/layout_tests/port/test.py:
  24198. (TestInstance.__init__): Initialize new web_process_crash attribute.
  24199. (unit_test_list): Added new web-process-crash-with-stderr test, which is used by the new
  24200. test this patch adds.
  24201. (TestDriver.run_test): Pass a crashed process name to DriverOutput based on whether the test
  24202. specifies that the driver crashed or the web process crashed.
  24203. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  24204. (MainTest.test_web_process_crash_log): Added. Similar to test_crash_log, but uses a test for
  24205. which we pretend the web process crashed rather than the driver process.
  24206. (MainTest.test_run_singly_actually_runs_tests):
  24207. (MainTest.test_unexpected_failures):
  24208. (EndToEndTest.test_end_to_end):
  24209. Updated magic numbers to account for new unexpected failing test added to unit_test_list.
  24210. 2011-11-17 Tony Chang <tony@chromium.org>
  24211. [chromium] stop spamming features warning on every build
  24212. https://bugs.webkit.org/show_bug.cgi?id=72629
  24213. Reviewed by Ojan Vafai.
  24214. We toggle $blobSupport on if $mediaStreamSupport is on. Since
  24215. $mediaStreamSupport is on by default for chromium, make the default
  24216. for $blobSupport also on.
  24217. * Scripts/build-webkit:
  24218. 2011-11-17 Adam Roben <aroben@apple.com>
  24219. Remove extra quoting of call stacks and types passed to run-leaks by NRWT
  24220. Fixes <http://webkit.org/b/72623> REGRESSION (NRWT): run-webkit-tests --leaks reports leaks
  24221. that are supposed to be ignored
  24222. Reviewed by Adam Barth.
  24223. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  24224. (LeakDetector._leaks_args): Removed extra quoting of call stacks and types. Quoting is only
  24225. required when passing arguments via the shell (which we aren't doing here). It is not
  24226. required by Perl's option-parsing code (as the comment I removed mistakenly claimed).
  24227. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  24228. (LeakDetectorTest.test_leaks_args): Updated expectations.
  24229. 2011-11-17 Philippe Normand <pnormand@igalia.com>
  24230. Unreviewed, run-bindings-tests fix after r91028.
  24231. * Scripts/run-bindings-tests: Use scm.detection module.
  24232. 2011-11-17 Jochen Eisinger <jochen@chromium.org>
  24233. Silence a warning about control reaching the end of a non-void function
  24234. https://bugs.webkit.org/show_bug.cgi?id=72616
  24235. Reviewed by Tony Gentilcore.
  24236. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  24237. (AccessibilityUIElement::verticalScrollbar):
  24238. 2011-11-17 Adam Roben <aroben@apple.com>
  24239. Ignore some leaks in frameworks we link against on Lion
  24240. Fixes <http://webkit.org/b/72609> Lion Leaks bot complains about a bunch of leaks that
  24241. aren't WebKit's fault
  24242. Reviewed by Antti Koivisto.
  24243. * Scripts/old-run-webkit-tests:
  24244. (countAndPrintLeaks):
  24245. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  24246. (LeakDetector._callstacks_to_exclude_from_leaks):
  24247. Added some call stacks to exclude on Lion that represent leaks in lower-level frameworks.
  24248. * Scripts/webkitpy/layout_tests/port/mac.py:
  24249. (MacPort.is_lion): Added.
  24250. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  24251. (MacPortTest.test_is_version_methods): Added tests for the is_leopard/is_snowleopard/is_lion
  24252. methods.
  24253. 2011-11-17 Philippe Normand <pnormand@igalia.com>
  24254. [GTK] Disable ref tests
  24255. https://bugs.webkit.org/show_bug.cgi?id=72599
  24256. Reviewed by Xan Lopez.
  24257. * Scripts/webkitpy/layout_tests/port/gtk.py: Enforce disabled ref
  24258. tests to avoid massive flakiness.
  24259. 2011-11-17 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  24260. [Qt] Move WebKit2 C++ APIs to private API and build QML extension plugin on top of that
  24261. A new extension object has been added to QQuickWebView (the same approach should be used
  24262. for other API classes that need experimental APIs). The QML extension mechanism is then
  24263. built on top of the experimental object.
  24264. https://bugs.webkit.org/show_bug.cgi?id=72522
  24265. Reviewed by Simon Hausmann.
  24266. * MiniBrowser/qt/BrowserWindow.cpp:
  24267. (BrowserWindow::BrowserWindow):
  24268. (BrowserWindow::webView):
  24269. * MiniBrowser/qt/BrowserWindow.h:
  24270. * MiniBrowser/qt/UrlLoader.cpp:
  24271. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  24272. * qmake/mkspecs/features/default_post.prf:
  24273. * qmake/mkspecs/features/default_pre.prf:
  24274. * qmake/mkspecs/features/qtwebkit-private.prf: Added.
  24275. * qmake/mkspecs/features/qtwebkit.prf:
  24276. 2011-11-17 Adam Barth <abarth@webkit.org>
  24277. Move test_results_uploader.py out of layout_package
  24278. https://bugs.webkit.org/show_bug.cgi?id=72590
  24279. Reviewed by Eric Seidel.
  24280. Most of the lines of code in this file are wrong, but I've restrained
  24281. myself and only changed a few of them to generalized this class to the
  24282. common package.
  24283. This is part of a series of patches to remove layout_package.
  24284. * Scripts/webkitpy/common/net/file_uploader.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py.
  24285. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  24286. * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py: Removed.
  24287. 2011-11-17 Adam Barth <abarth@webkit.org>
  24288. Unreviewed. Fix style nits in printing.py.
  24289. * Scripts/webkitpy/layout_tests/views/printing.py:
  24290. 2011-11-17 Adam Barth <abarth@webkit.org>
  24291. Minor style nits in run_webkit_tests.py
  24292. https://bugs.webkit.org/show_bug.cgi?id=72583
  24293. Reviewed by Eric Seidel.
  24294. This patch just fixes some minor style issues as I work my way back
  24295. into this code.
  24296. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  24297. 2011-11-17 Adam Barth <abarth@webkit.org>
  24298. Move test_result_writer out of layout_package
  24299. https://bugs.webkit.org/show_bug.cgi?id=72586
  24300. Rubber-stamped by Eric Seidel.
  24301. This is part of a series of patches to remove layout_package.
  24302. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  24303. * Scripts/webkitpy/layout_tests/controllers/test_result_writer.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py.
  24304. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Removed.
  24305. * Scripts/webkitpy/tool/commands/rebaseline.py:
  24306. 2011-11-17 Adam Barth <abarth@webkit.org>
  24307. svn-apply shouldn't magically move files into Source anymore
  24308. https://bugs.webkit.org/show_bug.cgi?id=72579
  24309. Reviewed by Eric Seidel.
  24310. The Source directory has existed for long enough that we don't need
  24311. svn-apply to magically re-write old-style patches anymore.
  24312. * Scripts/VCSUtils.pm:
  24313. (parseGitDiffHeader):
  24314. (parseSvnDiffHeader):
  24315. 2011-11-16 Ryosuke Niwa <rniwa@webkit.org>
  24316. Add a list of contribution areas
  24317. https://bugs.webkit.org/show_bug.cgi?id=72566
  24318. Reviewed by Eric Seidel.
  24319. Added ContributionAreas class.
  24320. * Scripts/webkitpy/common/config/contributionareas.py: Added.
  24321. * Scripts/webkitpy/common/config/contributionareas_unittest.py: Added.
  24322. 2011-11-16 Ryosuke Niwa <rniwa@webkit.org>
  24323. Refactor ChangeLogTest.test_parse_reviewer_text
  24324. https://bugs.webkit.org/show_bug.cgi?id=72572
  24325. Reviewed by Eric Seidel.
  24326. Refactored the test code by introduing two helper functions.
  24327. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  24328. 2011-11-16 Eric Seidel <eric@webkit.org>
  24329. Add SCMDetector object to make scm detection mockable
  24330. https://bugs.webkit.org/show_bug.cgi?id=72247
  24331. Reviewed by Adam Barth.
  24332. I think SCM detection may eventually be rolled into Checkout,
  24333. but this patch at least makes it possible to mock code-paths
  24334. which rely on scm detection.
  24335. In the process of replacing callers of these free-functions
  24336. I found that one of the functions was no longer used,
  24337. and that one of the callers could instead just use the SCM
  24338. object it already had access to through port.host.scm().
  24339. I also discovered that I was not calling Host._initialize_scm()
  24340. and thus host.scm() was always returning None!
  24341. * Scripts/check-webkit-style:
  24342. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  24343. * Scripts/webkitpy/common/checkout/deps.py:
  24344. * Scripts/webkitpy/common/checkout/scm/__init__.py:
  24345. * Scripts/webkitpy/common/checkout/scm/detection.py:
  24346. * Scripts/webkitpy/common/checkout/scm/git.py:
  24347. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  24348. * Scripts/webkitpy/common/checkout/scm/svn.py:
  24349. * Scripts/webkitpy/common/host.py:
  24350. * Scripts/webkitpy/common/host_mock.py:
  24351. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  24352. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  24353. * Scripts/webkitpy/layout_tests/port/base.py:
  24354. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  24355. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  24356. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  24357. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  24358. 2011-11-16 Mark Rowe <mrowe@apple.com>
  24359. Fix the build.
  24360. The C++ standard library interferes with Objective-C exceptions when built with -fno-exceptions.
  24361. Apply the workaround that we use in other projects to WebKitTestRunner.
  24362. * WebKitTestRunner/Configurations/Base.xcconfig: Use the prefix header for all targets.
  24363. * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Ditto.
  24364. * WebKitTestRunner/WebKitTestRunnerPrefix.h: Work around the C++ standard library obnoxiousness.
  24365. 2011-11-16 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  24366. [Qt] Fix build after WTR AX support
  24367. https://bugs.webkit.org/show_bug.cgi?id=72560
  24368. Reviewed by Geoffrey Garen.
  24369. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  24370. * WebKitTestRunner/InjectedBundle/Target.pri:
  24371. 2011-11-16 Tony Chang <tony@chromium.org>
  24372. repurpose the flexbox bot for grid layout
  24373. https://bugs.webkit.org/show_bug.cgi?id=72557
  24374. Reviewed by Ryosuke Niwa.
  24375. Since new flexbox is enabled everywhere, we don't need this bot
  24376. anymore. However, work on grid layout has begun, so we can use this
  24377. bot to compile with ENABLE_CSS_GRID_LAYOUT.
  24378. * BuildSlaveSupport/build.webkit.org-config/config.json: Just rename
  24379. the bot on the waterfall, I will change the slave config to enable
  24380. the compile flag and tests.
  24381. 2011-11-11 Adrienne Walker <enne@google.com>
  24382. [chromium] Expose mock scrollbars to window.internals
  24383. https://bugs.webkit.org/show_bug.cgi?id=72195
  24384. Reviewed by James Robinson.
  24385. Because mock scrollbars are a global setting, reset between runs.
  24386. * DumpRenderTree/chromium/WebPreferences.cpp:
  24387. (WebPreferences::applyTo):
  24388. 2011-11-16 James Robinson <jamesr@chromium.org>
  24389. [chromium] Enable video and canvas 2d compositing triggers by default for layout tests in the compositing directory
  24390. https://bugs.webkit.org/show_bug.cgi?id=72562
  24391. Reviewed by Dirk Pranke.
  24392. * DumpRenderTree/chromium/TestShell.cpp:
  24393. (TestShell::runFileTest):
  24394. 2011-11-16 Tony Chang <tony@chromium.org>
  24395. [NRWT] speculative fix for multiple subprocess test on cygwin
  24396. https://bugs.webkit.org/show_bug.cgi?id=72518
  24397. Reviewed by Adam Barth.
  24398. * Scripts/webkitpy/layout_tests/port/chromium.py: cygwin probably
  24399. tries to emulate posix fd behavior.
  24400. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  24401. 2011-11-16 Dirk Pranke <dpranke@chromium.org>
  24402. Revert r100509; change was committed twice (first time as r100491).
  24403. Unreviewed, build fix.
  24404. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  24405. 2011-11-16 Dirk Pranke <dpranke@chromium.org>
  24406. Run a dummy test in the gpu configurations if there's nothing to do.
  24407. https://bugs.webkit.org/show_bug.cgi?id=72498
  24408. Reviewed by James Robinson.
  24409. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  24410. 2011-11-16 Ryosuke Niwa <rniwa@webkit.org>
  24411. contributors_by_fuzzy_match is super slow
  24412. https://bugs.webkit.org/show_bug.cgi?id=72540
  24413. Reviewed by Eric Seidel.
  24414. Make contributors_by_name do case insensitive search using a dictionary.
  24415. Also call contributors_by_name first in contributors_by_fuzzy_match now that it's fast
  24416. because that's the most common case.
  24417. * Scripts/webkitpy/common/config/committers.py:
  24418. * Scripts/webkitpy/common/config/committers_unittest.py:
  24419. 2011-11-16 David Levin <levin@chromium.org>
  24420. check-webkit-style should recognize functions even if they have OVERRIDE after them.
  24421. https://bugs.webkit.org/show_bug.cgi?id=72515
  24422. Reviewed by Adam Barth.
  24423. * Scripts/webkitpy/style/checkers/cpp.py:
  24424. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  24425. 2011-11-16 Tony Chang <tony@chromium.org>
  24426. [NRWT] refactor drivers to require pixel_tests param
  24427. https://bugs.webkit.org/show_bug.cgi?id=72517
  24428. Reviewed by Ojan Vafai.
  24429. No tests, just a refactoring.
  24430. * Scripts/webkitpy/layout_tests/port/chromium.py:
  24431. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  24432. * Scripts/webkitpy/layout_tests/port/webkit.py:
  24433. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  24434. 2011-11-16 Dirk Pranke <dpranke@chromium.org>
  24435. Run a dummy test in the gpu configurations if there's nothing to do.
  24436. https://bugs.webkit.org/show_bug.cgi?id=72498
  24437. Reviewed by James Robinson.
  24438. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  24439. 2011-11-16 Chris Fleizach <cfleizach@apple.com>
  24440. WebKitTestRunner needs to support accessibility-related DRT APIs
  24441. https://bugs.webkit.org/show_bug.cgi?id=42131
  24442. Reviewed by Beth Dakin.
  24443. Port the AX code in DRT to WKTestRunner by using IDL.
  24444. * DumpRenderTree/AccessibilityUIElement.cpp:
  24445. (horizontalScrollbarCallback):
  24446. (verticalScrollbarCallback):
  24447. (AccessibilityUIElement::horizontalScrollbar):
  24448. (AccessibilityUIElement::verticalScrollbar):
  24449. (AccessibilityUIElement::getJSClass):
  24450. * DumpRenderTree/AccessibilityUIElement.h:
  24451. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  24452. (AccessibilityUIElement::horizontalScrollbar):
  24453. (AccessibilityUIElement::verticalScrollbar):
  24454. * WebKitTestRunner/DerivedSources.make:
  24455. * WebKitTestRunner/GNUmakefile.am:
  24456. * WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Added.
  24457. (WTR::AccessibilityController::create):
  24458. (WTR::AccessibilityController::AccessibilityController):
  24459. (WTR::AccessibilityController::~AccessibilityController):
  24460. (WTR::AccessibilityController::makeWindowObject):
  24461. (WTR::AccessibilityController::wrapperClass):
  24462. (WTR::AccessibilityController::rootElement):
  24463. (WTR::AccessibilityController::focusedElement):
  24464. (WTR::AccessibilityController::elementAtPoint):
  24465. * WebKitTestRunner/InjectedBundle/AccessibilityController.h: Added.
  24466. (WTR::AccessibilityController::logFocusEvents):
  24467. (WTR::AccessibilityController::logValueChangeEvents):
  24468. (WTR::AccessibilityController::logScrollingStartEvents):
  24469. (WTR::AccessibilityController::logAccessibilityEvents):
  24470. (WTR::AccessibilityController::addNotificationListener):
  24471. (WTR::AccessibilityController::notificationReceived):
  24472. (WTR::AccessibilityController::resetToConsistentState):
  24473. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.cpp: Added.
  24474. (WTR::AccessibilityTextMarker::create):
  24475. (WTR::AccessibilityTextMarker::AccessibilityTextMarker):
  24476. (WTR::AccessibilityTextMarker::~AccessibilityTextMarker):
  24477. (WTR::AccessibilityTextMarker::platformTextMarker):
  24478. (WTR::AccessibilityTextMarker::wrapperClass):
  24479. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarker.h: Added.
  24480. (WTR::AccessibilityTextMarker::isEqual):
  24481. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.cpp: Added.
  24482. (WTR::AccessibilityTextMarkerRange::create):
  24483. (WTR::AccessibilityTextMarkerRange::AccessibilityTextMarkerRange):
  24484. (WTR::AccessibilityTextMarkerRange::~AccessibilityTextMarkerRange):
  24485. (WTR::AccessibilityTextMarkerRange::platformTextMarkerRange):
  24486. (WTR::AccessibilityTextMarkerRange::wrapperClass):
  24487. * WebKitTestRunner/InjectedBundle/AccessibilityTextMarkerRange.h: Added.
  24488. (WTR::AccessibilityTextMarkerRange::isEqual):
  24489. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp: Added.
  24490. (WTR::AccessibilityUIElement::create):
  24491. (WTR::AccessibilityUIElement::wrapperClass):
  24492. (WTR::AccessibilityUIElement::isValid):
  24493. (WTR::AccessibilityUIElement::AccessibilityUIElement):
  24494. (WTR::AccessibilityUIElement::~AccessibilityUIElement):
  24495. (WTR::AccessibilityUIElement::isEqual):
  24496. (WTR::AccessibilityUIElement::elementAtPoint):
  24497. (WTR::AccessibilityUIElement::childAtIndex):
  24498. (WTR::AccessibilityUIElement::indexOfChild):
  24499. (WTR::AccessibilityUIElement::childrenCount):
  24500. (WTR::AccessibilityUIElement::titleUIElement):
  24501. (WTR::AccessibilityUIElement::parentElement):
  24502. (WTR::AccessibilityUIElement::takeFocus):
  24503. (WTR::AccessibilityUIElement::takeSelection):
  24504. (WTR::AccessibilityUIElement::addSelection):
  24505. (WTR::AccessibilityUIElement::removeSelection):
  24506. (WTR::AccessibilityUIElement::allAttributes):
  24507. (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
  24508. (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
  24509. (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
  24510. (WTR::AccessibilityUIElement::attributesOfChildren):
  24511. (WTR::AccessibilityUIElement::parameterizedAttributeNames):
  24512. (WTR::AccessibilityUIElement::increment):
  24513. (WTR::AccessibilityUIElement::decrement):
  24514. (WTR::AccessibilityUIElement::showMenu):
  24515. (WTR::AccessibilityUIElement::press):
  24516. (WTR::AccessibilityUIElement::stringAttributeValue):
  24517. (WTR::AccessibilityUIElement::uiElementAttributeValue):
  24518. (WTR::AccessibilityUIElement::numberAttributeValue):
  24519. (WTR::AccessibilityUIElement::boolAttributeValue):
  24520. (WTR::AccessibilityUIElement::isAttributeSupported):
  24521. (WTR::AccessibilityUIElement::isAttributeSettable):
  24522. (WTR::AccessibilityUIElement::isActionSupported):
  24523. (WTR::AccessibilityUIElement::role):
  24524. (WTR::AccessibilityUIElement::subrole):
  24525. (WTR::AccessibilityUIElement::roleDescription):
  24526. (WTR::AccessibilityUIElement::title):
  24527. (WTR::AccessibilityUIElement::description):
  24528. (WTR::AccessibilityUIElement::language):
  24529. (WTR::AccessibilityUIElement::stringValue):
  24530. (WTR::AccessibilityUIElement::accessibilityValue):
  24531. (WTR::AccessibilityUIElement::helpText):
  24532. (WTR::AccessibilityUIElement::orientation):
  24533. (WTR::AccessibilityUIElement::x):
  24534. (WTR::AccessibilityUIElement::y):
  24535. (WTR::AccessibilityUIElement::width):
  24536. (WTR::AccessibilityUIElement::height):
  24537. (WTR::AccessibilityUIElement::intValue):
  24538. (WTR::AccessibilityUIElement::minValue):
  24539. (WTR::AccessibilityUIElement::maxValue):
  24540. (WTR::AccessibilityUIElement::valueDescription):
  24541. (WTR::AccessibilityUIElement::insertionPointLineNumber):
  24542. (WTR::AccessibilityUIElement::selectedTextRange):
  24543. (WTR::AccessibilityUIElement::isEnabled):
  24544. (WTR::AccessibilityUIElement::isRequired):
  24545. (WTR::AccessibilityUIElement::isFocused):
  24546. (WTR::AccessibilityUIElement::isFocusable):
  24547. (WTR::AccessibilityUIElement::isSelected):
  24548. (WTR::AccessibilityUIElement::isSelectable):
  24549. (WTR::AccessibilityUIElement::isMultiSelectable):
  24550. (WTR::AccessibilityUIElement::setSelectedChild):
  24551. (WTR::AccessibilityUIElement::selectedChildrenCount):
  24552. (WTR::AccessibilityUIElement::selectedChildAtIndex):
  24553. (WTR::AccessibilityUIElement::isExpanded):
  24554. (WTR::AccessibilityUIElement::isChecked):
  24555. (WTR::AccessibilityUIElement::isVisible):
  24556. (WTR::AccessibilityUIElement::isOffScreen):
  24557. (WTR::AccessibilityUIElement::isCollapsed):
  24558. (WTR::AccessibilityUIElement::isIgnored):
  24559. (WTR::AccessibilityUIElement::hasPopup):
  24560. (WTR::AccessibilityUIElement::hierarchicalLevel):
  24561. (WTR::AccessibilityUIElement::clickPointX):
  24562. (WTR::AccessibilityUIElement::clickPointY):
  24563. (WTR::AccessibilityUIElement::documentEncoding):
  24564. (WTR::AccessibilityUIElement::documentURI):
  24565. (WTR::AccessibilityUIElement::url):
  24566. (WTR::AccessibilityUIElement::speak):
  24567. (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
  24568. (WTR::AccessibilityUIElement::attributesOfRowHeaders):
  24569. (WTR::AccessibilityUIElement::attributesOfColumns):
  24570. (WTR::AccessibilityUIElement::attributesOfRows):
  24571. (WTR::AccessibilityUIElement::attributesOfVisibleCells):
  24572. (WTR::AccessibilityUIElement::attributesOfHeader):
  24573. (WTR::AccessibilityUIElement::indexInTable):
  24574. (WTR::AccessibilityUIElement::rowIndexRange):
  24575. (WTR::AccessibilityUIElement::columnIndexRange):
  24576. (WTR::AccessibilityUIElement::rowCount):
  24577. (WTR::AccessibilityUIElement::columnCount):
  24578. (WTR::AccessibilityUIElement::selectedRowAtIndex):
  24579. (WTR::AccessibilityUIElement::disclosedByRow):
  24580. (WTR::AccessibilityUIElement::disclosedRowAtIndex):
  24581. (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
  24582. (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
  24583. (WTR::AccessibilityUIElement::ariaIsGrabbed):
  24584. (WTR::AccessibilityUIElement::ariaDropEffects):
  24585. (WTR::AccessibilityUIElement::lineForIndex):
  24586. (WTR::AccessibilityUIElement::rangeForLine):
  24587. (WTR::AccessibilityUIElement::boundsForRange):
  24588. (WTR::AccessibilityUIElement::setSelectedTextRange):
  24589. (WTR::AccessibilityUIElement::stringForRange):
  24590. (WTR::AccessibilityUIElement::attributedStringForRange):
  24591. (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
  24592. (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
  24593. (WTR::AccessibilityUIElement::cellForColumnAndRow):
  24594. (WTR::AccessibilityUIElement::horizontalScrollbar):
  24595. (WTR::AccessibilityUIElement::verticalScrollbar):
  24596. (WTR::AccessibilityUIElement::addNotificationListener):
  24597. (WTR::AccessibilityUIElement::removeNotificationListener):
  24598. (WTR::AccessibilityUIElement::textMarkerRangeForElement):
  24599. (WTR::AccessibilityUIElement::textMarkerRangeLength):
  24600. (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
  24601. (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
  24602. (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
  24603. (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
  24604. (WTR::AccessibilityUIElement::textMarkerForPoint):
  24605. (WTR::AccessibilityUIElement::previousTextMarker):
  24606. (WTR::AccessibilityUIElement::nextTextMarker):
  24607. (WTR::AccessibilityUIElement::stringForTextMarkerRange):
  24608. * WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h: Added.
  24609. (WTR::AccessibilityUIElement::platformUIElement):
  24610. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl: Added.
  24611. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarker.idl: Added.
  24612. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityTextMarkerRange.idl: Added.
  24613. * WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl: Added.
  24614. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  24615. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  24616. (WTR::InjectedBundle::beginTesting):
  24617. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  24618. (WTR::InjectedBundle::accessibilityController):
  24619. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  24620. (WTR::InjectedBundlePage::didClearWindowForFrame):
  24621. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  24622. * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp:
  24623. (WTR::LayoutTestController::platformName):
  24624. * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerMac.mm: Added.
  24625. (WTR::AccessibilityTextMarker::isEqual):
  24626. * WebKitTestRunner/InjectedBundle/mac/AccessibilityTextMarkerRangeMac.mm: Added.
  24627. (WTR::AccessibilityTextMarkerRange::isEqual):
  24628. * WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm: Added.
  24629. (+[NSString stringWithJSStringRef:]):
  24630. (-[NSString createJSStringRef]):
  24631. (-[AccessibilityNotificationHandler initWithPlatformElement:]):
  24632. (-[AccessibilityNotificationHandler dealloc]):
  24633. (-[AccessibilityNotificationHandler _notificationReceived:]):
  24634. (-[AccessibilityNotificationHandler setCallback:]):
  24635. (WTR::AccessibilityUIElement::AccessibilityUIElement):
  24636. (WTR::AccessibilityUIElement::~AccessibilityUIElement):
  24637. (WTR::AccessibilityUIElement::isEqual):
  24638. (WTR::descriptionOfValue):
  24639. (WTR::attributesOfElement):
  24640. (WTR::concatenateAttributeAndValue):
  24641. (WTR::convertNSArrayToVector):
  24642. (WTR::descriptionOfElements):
  24643. (WTR::AccessibilityUIElement::getLinkedUIElements):
  24644. (WTR::AccessibilityUIElement::getDocumentLinks):
  24645. (WTR::AccessibilityUIElement::getChildren):
  24646. (WTR::AccessibilityUIElement::getChildrenWithRange):
  24647. (WTR::AccessibilityUIElement::childrenCount):
  24648. (WTR::AccessibilityUIElement::elementAtPoint):
  24649. (WTR::AccessibilityUIElement::indexOfChild):
  24650. (WTR::AccessibilityUIElement::childAtIndex):
  24651. (WTR::AccessibilityUIElement::linkedUIElementAtIndex):
  24652. (WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
  24653. (WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
  24654. (WTR::AccessibilityUIElement::disclosedRowAtIndex):
  24655. (WTR::AccessibilityUIElement::selectedChildAtIndex):
  24656. (WTR::AccessibilityUIElement::selectedChildrenCount):
  24657. (WTR::AccessibilityUIElement::selectedRowAtIndex):
  24658. (WTR::AccessibilityUIElement::titleUIElement):
  24659. (WTR::AccessibilityUIElement::parentElement):
  24660. (WTR::AccessibilityUIElement::disclosedByRow):
  24661. (WTR::AccessibilityUIElement::attributesOfLinkedUIElements):
  24662. (WTR::AccessibilityUIElement::attributesOfDocumentLinks):
  24663. (WTR::AccessibilityUIElement::attributesOfChildren):
  24664. (WTR::AccessibilityUIElement::allAttributes):
  24665. (WTR::AccessibilityUIElement::stringAttributeValue):
  24666. (WTR::AccessibilityUIElement::numberAttributeValue):
  24667. (WTR::AccessibilityUIElement::uiElementAttributeValue):
  24668. (WTR::AccessibilityUIElement::boolAttributeValue):
  24669. (WTR::AccessibilityUIElement::isAttributeSettable):
  24670. (WTR::AccessibilityUIElement::isAttributeSupported):
  24671. (WTR::AccessibilityUIElement::parameterizedAttributeNames):
  24672. (WTR::AccessibilityUIElement::role):
  24673. (WTR::AccessibilityUIElement::subrole):
  24674. (WTR::AccessibilityUIElement::roleDescription):
  24675. (WTR::AccessibilityUIElement::title):
  24676. (WTR::AccessibilityUIElement::description):
  24677. (WTR::AccessibilityUIElement::orientation):
  24678. (WTR::AccessibilityUIElement::stringValue):
  24679. (WTR::AccessibilityUIElement::language):
  24680. (WTR::AccessibilityUIElement::helpText):
  24681. (WTR::AccessibilityUIElement::x):
  24682. (WTR::AccessibilityUIElement::y):
  24683. (WTR::AccessibilityUIElement::width):
  24684. (WTR::AccessibilityUIElement::height):
  24685. (WTR::AccessibilityUIElement::clickPointX):
  24686. (WTR::AccessibilityUIElement::clickPointY):
  24687. (WTR::AccessibilityUIElement::intValue):
  24688. (WTR::AccessibilityUIElement::minValue):
  24689. (WTR::AccessibilityUIElement::maxValue):
  24690. (WTR::AccessibilityUIElement::valueDescription):
  24691. (WTR::AccessibilityUIElement::insertionPointLineNumber):
  24692. (WTR::AccessibilityUIElement::isActionSupported):
  24693. (WTR::AccessibilityUIElement::isEnabled):
  24694. (WTR::AccessibilityUIElement::isRequired):
  24695. (WTR::AccessibilityUIElement::isFocused):
  24696. (WTR::AccessibilityUIElement::isSelected):
  24697. (WTR::AccessibilityUIElement::isExpanded):
  24698. (WTR::AccessibilityUIElement::isChecked):
  24699. (WTR::AccessibilityUIElement::hierarchicalLevel):
  24700. (WTR::AccessibilityUIElement::speak):
  24701. (WTR::AccessibilityUIElement::ariaIsGrabbed):
  24702. (WTR::AccessibilityUIElement::ariaDropEffects):
  24703. (WTR::AccessibilityUIElement::lineForIndex):
  24704. (WTR::AccessibilityUIElement::rangeForLine):
  24705. (WTR::AccessibilityUIElement::boundsForRange):
  24706. (WTR::AccessibilityUIElement::stringForRange):
  24707. (WTR::AccessibilityUIElement::attributedStringForRange):
  24708. (WTR::AccessibilityUIElement::attributedStringRangeIsMisspelled):
  24709. (WTR::AccessibilityUIElement::uiElementForSearchPredicate):
  24710. (WTR::AccessibilityUIElement::attributesOfColumnHeaders):
  24711. (WTR::AccessibilityUIElement::attributesOfRowHeaders):
  24712. (WTR::AccessibilityUIElement::attributesOfColumns):
  24713. (WTR::AccessibilityUIElement::attributesOfRows):
  24714. (WTR::AccessibilityUIElement::attributesOfVisibleCells):
  24715. (WTR::AccessibilityUIElement::attributesOfHeader):
  24716. (WTR::AccessibilityUIElement::rowCount):
  24717. (WTR::AccessibilityUIElement::columnCount):
  24718. (WTR::AccessibilityUIElement::indexInTable):
  24719. (WTR::AccessibilityUIElement::rowIndexRange):
  24720. (WTR::AccessibilityUIElement::columnIndexRange):
  24721. (WTR::AccessibilityUIElement::cellForColumnAndRow):
  24722. (WTR::AccessibilityUIElement::horizontalScrollbar):
  24723. (WTR::AccessibilityUIElement::verticalScrollbar):
  24724. (WTR::AccessibilityUIElement::selectedTextRange):
  24725. (WTR::AccessibilityUIElement::setSelectedTextRange):
  24726. (WTR::AccessibilityUIElement::increment):
  24727. (WTR::AccessibilityUIElement::decrement):
  24728. (WTR::AccessibilityUIElement::showMenu):
  24729. (WTR::AccessibilityUIElement::press):
  24730. (WTR::AccessibilityUIElement::setSelectedChild):
  24731. (WTR::AccessibilityUIElement::accessibilityValue):
  24732. (WTR::AccessibilityUIElement::documentEncoding):
  24733. (WTR::AccessibilityUIElement::documentURI):
  24734. (WTR::AccessibilityUIElement::url):
  24735. (WTR::AccessibilityUIElement::addNotificationListener):
  24736. (WTR::AccessibilityUIElement::removeNotificationListener):
  24737. (WTR::AccessibilityUIElement::isFocusable):
  24738. (WTR::AccessibilityUIElement::isSelectable):
  24739. (WTR::AccessibilityUIElement::isMultiSelectable):
  24740. (WTR::AccessibilityUIElement::isVisible):
  24741. (WTR::AccessibilityUIElement::isOffScreen):
  24742. (WTR::AccessibilityUIElement::isCollapsed):
  24743. (WTR::AccessibilityUIElement::isIgnored):
  24744. (WTR::AccessibilityUIElement::hasPopup):
  24745. (WTR::AccessibilityUIElement::takeFocus):
  24746. (WTR::AccessibilityUIElement::takeSelection):
  24747. (WTR::AccessibilityUIElement::addSelection):
  24748. (WTR::AccessibilityUIElement::removeSelection):
  24749. (WTR::AccessibilityUIElement::textMarkerRangeForElement):
  24750. (WTR::AccessibilityUIElement::textMarkerRangeLength):
  24751. (WTR::AccessibilityUIElement::previousTextMarker):
  24752. (WTR::AccessibilityUIElement::nextTextMarker):
  24753. (WTR::AccessibilityUIElement::stringForTextMarkerRange):
  24754. (WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
  24755. (WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
  24756. (WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
  24757. (WTR::AccessibilityUIElement::textMarkerForPoint):
  24758. (WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
  24759. * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
  24760. (WTR::LayoutTestController::platformName):
  24761. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  24762. (WTR::LayoutTestController::platformName):
  24763. * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
  24764. (WTR::LayoutTestController::platformName):
  24765. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  24766. * WebKitTestRunner/win/InjectedBundle.vcproj:
  24767. 2011-11-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  24768. [Qt] Fix use of config.tests
  24769. We were checking @buildArgs to determine if the optional argument was
  24770. passed or not, but this is not the right way to do that in Perl. The
  24771. right way is to not use a prototype for the function, and to pass
  24772. the list as a reference (to avoid list expansion). That way we can
  24773. check the number of arguments, and choose the right code path based
  24774. on that.
  24775. We were also missing a default-value of 0 for any feature that's not
  24776. set in features.prf.
  24777. Reviewed by Kenneth Rohde Christiansen.
  24778. * Scripts/build-webkit:
  24779. * Scripts/webkitdirs.pm:
  24780. (qtFeatureDefaults):
  24781. (buildQMakeProject):
  24782. 2011-11-16 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  24783. [Qt] Prospective fix for broken plugin tests
  24784. Don't hide symbols for the NPAPI test plugin
  24785. Rubber-stamped by Andreas Kling.
  24786. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  24787. 2011-11-16 Adam Roben <aroben@apple.com>
  24788. Move filenames/line numbers off to the right edge in Leaks Viewer
  24789. Fixes <http://webkit.org/b/72510> Callstacks in Leaks Viewer are a little hard to read
  24790. because filenames/line numbers are right next to function names
  24791. Reviewed by Andreas Kling.
  24792. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js:
  24793. (LeaksParserImpl.prototype._createNode): Separate the filename and line number out from the
  24794. function name. Use the filename as the profile node's URL (we don't have enough info to
  24795. compute a real URL currently) and the line number as the profile node's line number so the
  24796. Inspector code will put them on the right side of the callstack graph.
  24797. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
  24798. (WebInspector.displayNameForURL): Stubbed this out. For now we don't ever get any URLs
  24799. passed here, just filenames.
  24800. (WebInspector.linkifyURLAsNode):
  24801. (WebInspector.linkifyResourceAsNode):
  24802. Copied and slightly modified from inspector.js.
  24803. 2011-11-16 Adam Roben <aroben@apple.com>
  24804. Make Leaks Viewer load builds from the new Lion Leaks bot
  24805. Fixes <http://webkit.org/b/72507> REGRESSION: Leaks Viewer no longer shows recent leaky builds
  24806. Reviewed by Andreas Kling.
  24807. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
  24808. (LeaksViewer._displayURLPrompt): Use the Lion Leaks bot instead of the nonexistent
  24809. SnowLeopard one.
  24810. 2011-11-16 Raphael Kubo da Costa <kubo@profusion.mobi>
  24811. [EFL] Clean up the offline apps-related functions in ewk_settings.
  24812. https://bugs.webkit.org/show_bug.cgi?id=72132
  24813. Reviewed by Kenneth Rohde Christiansen.
  24814. `ewk_settings_cache' and `ewk_view_setting_cache' are too common
  24815. prefixes for code that is related only to the HTML5 app cache
  24816. features.
  24817. Use `ewk_settings_application_cache' and
  24818. `ewk_view_setting_application_cache' instead.
  24819. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  24820. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  24821. 2011-11-15 Simon Hausmann <simon.hausmann@nokia.com>
  24822. [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
  24823. Reviewed by Tor Arne Vestbø.
  24824. * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
  24825. magic here where we handle all TEMPLATE = lib .pro files (except plugins).
  24826. * WebKitTestRunner/InjectedBundle/Target.pri: Mark the injected bundle as plugin, which also
  24827. removes the .so.0.0.0 and just produces .so.
  24828. 2011-11-16 Peter Beverloo <peter@chromium.org>
  24829. Explicitly include unistd.h in TestNetscapePlugIn
  24830. https://bugs.webkit.org/show_bug.cgi?id=72385
  24831. This is needed for the sleep() call in the indicateTestFailure method,
  24832. which seems to be implicitly available for other platforms. This is not
  24833. the case on Android.
  24834. Reviewed by Steve Block.
  24835. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  24836. 2011-11-16 Peter Beverloo <peter@chromium.org>
  24837. [Chromium] Update the Android NDK version being pulled in by update-webkit-chromium
  24838. https://bugs.webkit.org/show_bug.cgi?id=72384
  24839. Update to Android NDK r7, which was released last Friday. This adds
  24840. support for RTTI and the -mimplicit-it gcc flag, which are required to
  24841. respectively build ICU and Skia.
  24842. Reviewed by Steve Block.
  24843. * Scripts/update-webkit-chromium:
  24844. * Scripts/webkitdirs.pm:
  24845. (buildChromiumMakefile):
  24846. 2011-11-16 Simon Hausmann <simon.hausmann@nokia.com>
  24847. Unreviewed, rolling out r100266.
  24848. http://trac.webkit.org/changeset/100266
  24849. Broke WTR.
  24850. * qmake/mkspecs/features/default_post.prf:
  24851. 2011-11-16 Eric Seidel <eric@webkit.org>
  24852. check-webkit-style broken by r99773: "Could not determine the port"
  24853. https://bugs.webkit.org/show_bug.cgi?id=72275
  24854. Reviewed by Adam Barth.
  24855. I will continue engaging hacks, until windows improves.
  24856. * Scripts/webkitpy/common/host.py:
  24857. - Host uses self.executive instead of self._executive like Port does.
  24858. - I wanted to test this, but it mutates global state -- thus impossible to unittest at this time.
  24859. 2011-11-16 Eric Seidel <eric@webkit.org>
  24860. check-webkit-style broken by r99773: "Could not determine the port"
  24861. https://bugs.webkit.org/show_bug.cgi?id=72275
  24862. Reviewed by Adam Barth.
  24863. Engage windows hacks harder.
  24864. This is a speculative fix for ChromiumWin. We're now
  24865. creating an SCM object much earlier, so we need to
  24866. engage our "awesome" windows hacks earlier.
  24867. * Scripts/webkitpy/common/host.py:
  24868. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  24869. 2011-11-15 Darin Adler <darin@apple.com>
  24870. DRT's uiElementAttributeValueCallback function is leaky
  24871. https://bugs.webkit.org/show_bug.cgi?id=72453
  24872. Reviewed by Dan Bernstein.
  24873. * DumpRenderTree/AccessibilityUIElement.cpp:
  24874. (uiElementAttributeValueCallback): Use JSRetainPtr and don't leak.
  24875. 2011-11-14 Ryosuke Niwa <rniwa@webkit.org>
  24876. Implement edit-distance based reviewer recognition algorithm
  24877. https://bugs.webkit.org/show_bug.cgi?id=72351
  24878. Reviewed by Eric Seidel.
  24879. Implement an algorithm to recognize reviewer's name based on its edit distance (or more precisely
  24880. its Levenshtein distance) to each reviewer's full name, first, last and middle names, and IRC nicknames.
  24881. Furthermore, we cap the maximum edit distance at len(name) - 1 to avoid matching a bogus string like
  24882. "build fix" to a reviewer's name (e.g. with with edit distance 9).
  24883. This algorithm is implemented in CommitterList.contributors_by_fuzzy_match. The function to compute
  24884. the edit distance is implemented in edit_distance.py.
  24885. Also moved _has_valid_reviewer from ValidateReviewer to ChangeLogEntry because we can no longer rely
  24886. on the presence of ChangeLogEntry.reviewer() to verify that reviewer string is nicely formatted.
  24887. * Scripts/webkitpy/common/checkout/changelog.py:
  24888. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  24889. * Scripts/webkitpy/common/config/committers.py:
  24890. * Scripts/webkitpy/common/config/committers_unittest.py:
  24891. * Scripts/webkitpy/common/editdistance.py: Added.
  24892. * Scripts/webkitpy/common/editdistance_unittest.py: Added.
  24893. * Scripts/webkitpy/tool/steps/validatereviewer.py:
  24894. * Scripts/webkitpy/tool/steps/validatereviewer_unittest.py: Removed.
  24895. 2011-11-15 Tony Chang <tony@chromium.org>
  24896. Skip a failing webkitpy test on cygwin.
  24897. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  24898. 2011-11-15 Sam Weinig <sam@webkit.org>
  24899. TestWebKitAPI should not put its resources in the root products directory
  24900. https://bugs.webkit.org/show_bug.cgi?id=72446
  24901. Reviewed by Anders Carlsson.
  24902. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  24903. Change the copy resources phase to place the resources in a TestWebKitAPI.resources
  24904. directory.
  24905. * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
  24906. (TEST_F):
  24907. * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
  24908. (TestWebKitAPI::TEST):
  24909. * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
  24910. (TestWebKitAPI::DeviceScaleFactorOnBack::url):
  24911. * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
  24912. (TestWebKitAPI::DynamicDeviceScaleFactor::url):
  24913. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  24914. (TestWebKitAPI::Util::createURLForResource):
  24915. Update calls to retrieve files from the bundle to look in the newly
  24916. created subdirectory.
  24917. 2011-11-15 Tony Chang <tony@chromium.org>
  24918. Fix a webkitpy test caused by renaming the accelerate-video flag in r100355.
  24919. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  24920. 2011-11-15 Tony Chang <tony@chromium.org>
  24921. Unreviewed, fix test-webkitpy tests. Move the check for image results
  24922. earlier.
  24923. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  24924. * Scripts/webkitpy/layout_tests/port/webkit.py:
  24925. 2011-11-15 James Robinson <jamesr@chromium.org>
  24926. [chromium] Fix flag name in chromium DumpRenderTree for accelerated video trigger
  24927. https://bugs.webkit.org/show_bug.cgi?id=72444
  24928. Reviewed by Adam Barth.
  24929. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  24930. 2011-11-15 Tony Chang <tony@chromium.org>
  24931. Unreviewed, better fix for ref tests failures on SL Intel bot.
  24932. Revert the previous change and return None if pixel results from
  24933. either the test page or the expected page is missing.
  24934. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  24935. * Scripts/webkitpy/layout_tests/port/webkit.py:
  24936. 2011-11-15 James Robinson <jamesr@chromium.org>
  24937. [chromium] Merge chromium-gpu layout test configurations into non-gpu versions
  24938. https://bugs.webkit.org/show_bug.cgi?id=72402
  24939. Reviewed by Dirk Pranke.
  24940. Allows the compositing layout tests to run in the normal layout test run. This sets the default compositing
  24941. triggers in DumpRenderTree to more closely match what we use in Chromium. There are two exceptions, canvas 2d
  24942. and video (media) are still controlled by an explicit trigger so that they are true when platform=chromium-gpu
  24943. and false otherwise, so that we can run the same set of tests in both configurations. This isn't necessary for
  24944. the normal compositing triggers since we currently run the compositing tests in only one configuration - with
  24945. compositing enabled.
  24946. Since the compositing tests are currently marked WONTFIX SKIP on non-GPU platforms in test_expectations.txt this
  24947. patch should not impact any tests.
  24948. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  24949. (main):
  24950. * DumpRenderTree/chromium/TestShell.cpp:
  24951. (TestShell::TestShell):
  24952. (TestShell::resetWebSettings):
  24953. * DumpRenderTree/chromium/TestShell.h:
  24954. (TestShell::setAcceleratedCompositingForVideoEnabled):
  24955. * DumpRenderTree/chromium/WebPreferences.cpp:
  24956. (WebPreferences::reset):
  24957. (WebPreferences::applyTo):
  24958. * DumpRenderTree/chromium/WebPreferences.h:
  24959. * Scripts/webkitpy/layout_tests/port/chromium.py:
  24960. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  24961. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  24962. 2011-11-15 Tony Chang <tony@chromium.org>
  24963. Unreviewed, try to fix ref tests failures on SL Intel bot.
  24964. It looks like ImageDiff isn't returning an image diff.
  24965. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  24966. 2011-11-15 Tony Chang <tony@chromium.org>
  24967. Unreviewed fix of ref-tests on GTK+.
  24968. If a driver is never started, _xvfb_process is never set.
  24969. * Scripts/webkitpy/layout_tests/port/gtk.py:
  24970. 2011-11-14 Tony Chang <tony@chromium.org>
  24971. [NRWT] Reftests should run even when pixel tests are disabled.
  24972. https://bugs.webkit.org/show_bug.cgi?id=60605
  24973. Reviewed by Dirk Pranke.
  24974. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Only skip ref tests if --no-ref-tests is passed.
  24975. Also add an assert to make sure we get image hashes back when running ref tests.
  24976. * Scripts/webkitpy/layout_tests/controllers/worker.py: Use Driver.has_crashed() instead of poll().
  24977. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  24978. * Scripts/webkitpy/layout_tests/port/chromium.py: Use DriverProxy.
  24979. * Scripts/webkitpy/layout_tests/port/driver.py: Add DriverProxy which does the work
  24980. of starting a pixel driver if needed. It handles the logic of sending the test
  24981. to the correct driver. Also renamed Driver.poll() to Driver.has_crashed().
  24982. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  24983. * Scripts/webkitpy/layout_tests/port/test.py: Switch to using DriverProxy so we get test coverage.
  24984. * Scripts/webkitpy/layout_tests/port/webkit.py:
  24985. * Scripts/webkitpy/layout_tests/run_webkit_tests.py: Add --no-ref-tests.
  24986. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Test --no-ref-tests.
  24987. 2011-11-15 David Kilzer <ddkilzer@apple.com>
  24988. Don't use File::Slurp for run-leaks unit tests
  24989. <http://webkit.org/b/72356>
  24990. Reviewed by Daniel Bates.
  24991. * Scripts/webkitperl/run-leaks_unittest/RunLeaks.pm: Added.
  24992. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl:
  24993. Extracted common package logic into RunLeaks.pm. Fixed call to
  24994. RunLeaks::parseLeaksOutput().
  24995. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Ditto.
  24996. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Ditto.
  24997. 2011-11-15 Peter Kasting <pkasting@google.com>
  24998. Handle svn 1.7 when detecting whether a directory is in an svn checkout.
  24999. https://bugs.webkit.org/show_bug.cgi?id=72349
  25000. Reviewed by Adam Roben.
  25001. * Scripts/VCSUtils.pm:
  25002. (isSVNDirectory):
  25003. 2011-11-15 Simon Hausmann <simon.hausmann@nokia.com>
  25004. [Qt] Centralize hide_symbols and ensure all libs are built with symbol visibility & bsymbolic_functions
  25005. Reviewed by Tor Arne Vestbø.
  25006. * qmake/mkspecs/features/default_post.prf: Place the common hide_symbols and -Bsymbolic-functions
  25007. magic here where we handle all TEMPLATE = lib .pro files.
  25008. 2011-11-15 Simon Hausmann <simon.hausmann@nokia.com>
  25009. [Qt] Unreviewed prospective --minimal build fix.
  25010. * DumpRenderTree/qt/DumpRenderTree.pro: Avoid USE_SYSTEM_MALLOC=0
  25011. and USE_SYSTEM_MALLOC=1 appearing in DEFINES at the same time.
  25012. 2011-11-15 Simon Hausmann <simon.hausmann@nokia.com>
  25013. [Qt] Unreviewed --minimal build fix.
  25014. * Scripts/build-webkit: Add to DEFINES+= from @options only if there is
  25015. a define. The "coverage" option doesn't have one, causing "DEFINES+= =0"
  25016. to make moc's preprocessor abort.
  25017. 2011-11-14 Raphael Kubo da Costa <kubo@profusion.mobi>
  25018. build-webkit: Accept --cmakearg to pass additional arguments to CMake.
  25019. https://bugs.webkit.org/show_bug.cgi?id=72156
  25020. Reviewed by Daniel Bates.
  25021. Similar to --makearg and --qmakearg, --cmakearg lets one pass
  25022. additional arguments to CMake (eg. --cmakearg="-DFOO=bar").
  25023. * Scripts/build-webkit:
  25024. * Scripts/webkitdirs.pm:
  25025. (generateBuildSystemFromCMakeProject):
  25026. 2011-11-14 Ryosuke Niwa <rniwa@webkit.org>
  25027. Improve ChangeLogEntry's reviewer parsing algorithm part 2
  25028. https://bugs.webkit.org/show_bug.cgi?id=72340
  25029. Reviewed by Eric Seidel.
  25030. This patch improves the recognition of NOBODY, wrestler names, and parenthesized clauses,
  25031. and prepares ChangeLogEntry to support edit-distance-based reviewer-name recognition.
  25032. * Scripts/webkitpy/common/checkout/changelog.py:
  25033. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  25034. 2011-11-14 Eric Seidel <eric@webkit.org>
  25035. check-webkit-style broken by r99773: "Could not determine the port"
  25036. https://bugs.webkit.org/show_bug.cgi?id=72275
  25037. Reviewed by Adam Barth.
  25038. The TestExpectationsChecker was using a generic try/except block
  25039. which caught all exceptions, so we didn't notice that failing
  25040. to pass a Host to PortFactory was causing an exception in port instantiation.
  25041. I've factored out the "lookup the port" logic into a separate function
  25042. which I've now unittested. This should fix the bug and prevent
  25043. others like it from occuring the the future.
  25044. * Scripts/webkitpy/style/checkers/test_expectations.py:
  25045. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  25046. 2011-11-14 Julien Chaffraix <jchaffraix@webkit.org>
  25047. Add --css-grid-layout to build-webkit and the build systems
  25048. https://bugs.webkit.org/show_bug.cgi?id=72320
  25049. Reviewed by Ojan Vafai.
  25050. * Scripts/build-webkit:
  25051. Added the option.
  25052. 2011-11-14 Sheriff Bot <webkit.review.bot@gmail.com>
  25053. Unreviewed, rolling out r100192.
  25054. http://trac.webkit.org/changeset/100192
  25055. https://bugs.webkit.org/show_bug.cgi?id=72328
  25056. Caused infinite tests to fail (Requested by abarth on
  25057. #webkit).
  25058. * Scripts/webkitpy/layout_tests/port/base.py:
  25059. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  25060. 2011-11-14 Tony Chang <tony@chromium.org>
  25061. Remove the CSS3_FLEXBOX compile time flag and enable on all ports
  25062. https://bugs.webkit.org/show_bug.cgi?id=72196
  25063. Reviewed by Ojan Vafai.
  25064. * Scripts/build-webkit:
  25065. 2011-11-14 John Yani <vanuan@gmail.com>
  25066. new-run-webkit-tests should not be locale dependent https://bugs.webkit.org/show_bug.cgi?id=68691
  25067. Override LOCALE to en_US.
  25068. Reviewed by Eric Seidel.
  25069. * Scripts/webkitpy/layout_tests/port/base.py:
  25070. 2011-11-14 Julien Chaffraix <jchaffraix@webkit.org>
  25071. [Chromium] build-webkit silently drops the features flags
  25072. https://bugs.webkit.org/show_bug.cgi?id=72293
  25073. Reviewed by Tony Chang.
  25074. Chromium still ignores @features but now we give a warning!
  25075. * Scripts/build-webkit: Check if one of the features is different
  25076. from the default and print a warning in this case.
  25077. 2011-11-14 David Kilzer <ddkilzer@apple.com>
  25078. run-leaks does not work on Lion?
  25079. <http://webkit.org/b/71059>
  25080. <rdar://problem/10428527>
  25081. Reviewed by Adam Roben.
  25082. The output of leaks(1) changed again in Lion to move the
  25083. "leaks Report Version: 2.0" line from the first line of the
  25084. output to just above the "Process " lines that run-leaks is
  25085. interested in parsing. This required using a more generic
  25086. algorithm to find the start of the "Process " lines.
  25087. * Scripts/run-leaks:
  25088. (parseLeaksOutput): Make the code to skip headers more generic.
  25089. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v1.0.pl: Added.
  25090. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-new.pl: Added.
  25091. * Scripts/webkitperl/run-leaks_unittest/run-leaks-report-v2.0-old.pl: Added.
  25092. 2011-11-14 Lei Zhang <thestig@chromium.org>
  25093. Missing include in Tools/DumpRenderTree/chromium/AccessibilityUIElement.h:
  25094. https://bugs.webkit.org/show_bug.cgi?id=72088
  25095. Reviewed by Tony Chang.
  25096. * DumpRenderTree/chromium/AccessibilityUIElement.h:
  25097. 2011-11-14 Andrew Scherkus <scherkus@chromium.org>
  25098. [Chromium] Skip media layout tests on chromium-gpu-cg-mac-leopard platform
  25099. https://bugs.webkit.org/show_bug.cgi?id=72147
  25100. Reviewed by Adam Barth.
  25101. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  25102. 2011-11-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25103. [Qt] Move the QtWebKit module file to match the layout of Qt's mkspecs
  25104. Reviewed by Simon Hausmann.
  25105. * qmake/mkspecs/modules/qt_webkit.pri: Renamed from Tools/qmake/qt_webkit.pri.
  25106. 2011-11-14 Simon Hausmann <simon.hausmann@nokia.com>
  25107. [Qt] Disable plugins on X11 for WK2
  25108. Reviewed by Kenneth Rohde Christiansen.
  25109. Currently plugins are in-process and they crash in the likely case of
  25110. a plugin installation that uses Qt 4, which beautifully clashes with the
  25111. Qt 5 based QtWebProcess.
  25112. * qmake/mkspecs/features/features.prf:
  25113. 2011-11-14 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25114. [Qt] Add support for config tests for Qt 5
  25115. This allows us to build and run configure-tests at build
  25116. time to determine if a given platform feature is available.
  25117. Reviewed by Simon Hausmann.
  25118. * Scripts/build-webkit:
  25119. * Scripts/webkitdirs.pm:
  25120. (qtFeatureDefaults):
  25121. * qmake/configure.pro: Added.
  25122. * qmake/mkspecs/features/features.prf:
  25123. * qmake/sync.profile: Added.
  25124. 2011-11-11 Pierre Rossi <pierre.rossi@gmail.com>
  25125. [Qt] Remove the QStyle dependency in Qt's mobile theme
  25126. https://bugs.webkit.org/show_bug.cgi?id=67773
  25127. This refactoring splits up RenderThemeQt with two
  25128. subclasses, a QStyle-backed one, and a Mobile version
  25129. that uses the old mobile theme for now.
  25130. QStyle availability is detected at compile time, and
  25131. its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
  25132. environment variable.
  25133. Reviewed by Simon Hausmann.
  25134. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  25135. (WTR::activateFonts):
  25136. * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
  25137. based on availability of QtWidgets.
  25138. * qmake/mkspecs/features/webcore.prf: cleanup.
  25139. 2011-11-14 Tony Gentilcore <tonyg@chromium.org>
  25140. Unreviewed, rolling out r100116.
  25141. http://trac.webkit.org/changeset/100116
  25142. r100104 was rolled out, so no longer needed
  25143. * Scripts/run-bindings-tests:
  25144. 2011-11-14 Tony Gentilcore <tonyg@chromium.org>
  25145. Unreviewed, rolling out r100104.
  25146. http://trac.webkit.org/changeset/100104
  25147. https://bugs.webkit.org/show_bug.cgi?id=72247
  25148. broke windows builds
  25149. * Scripts/check-webkit-style:
  25150. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  25151. * Scripts/webkitpy/common/checkout/deps.py:
  25152. * Scripts/webkitpy/common/checkout/scm/__init__.py:
  25153. * Scripts/webkitpy/common/checkout/scm/detection.py:
  25154. * Scripts/webkitpy/common/checkout/scm/git.py:
  25155. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  25156. * Scripts/webkitpy/common/checkout/scm/svn.py:
  25157. * Scripts/webkitpy/common/host.py:
  25158. * Scripts/webkitpy/common/host_mock.py:
  25159. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  25160. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  25161. * Scripts/webkitpy/layout_tests/port/base.py:
  25162. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  25163. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  25164. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  25165. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  25166. 2011-11-14 Philippe Normand <pnormand@igalia.com>
  25167. Unreviewed, build fix after r100104. run-binding-tests broke.
  25168. * Scripts/run-bindings-tests: Explicitely use scm.detection.
  25169. 2011-11-13 Eric Seidel <eric@webkit.org>
  25170. Add SCMDetector object to make scm detection mockable
  25171. https://bugs.webkit.org/show_bug.cgi?id=72247
  25172. Reviewed by Adam Barth.
  25173. I think SCM detection may eventually be rolled into Checkout,
  25174. but this patch at least makes it possible to mock code-paths
  25175. which rely on scm detection.
  25176. In the process of replacing callers of these free-functions
  25177. I found that one of the functions was no longer used,
  25178. and that one of the callers could instead just use the SCM
  25179. object it already had access to through port.host.scm().
  25180. I also discovered that I was not calling Host._initialize_scm()
  25181. and thus host.scm() was always returning None!
  25182. * Scripts/check-webkit-style:
  25183. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  25184. * Scripts/webkitpy/common/checkout/deps.py:
  25185. * Scripts/webkitpy/common/checkout/scm/__init__.py:
  25186. * Scripts/webkitpy/common/checkout/scm/detection.py:
  25187. * Scripts/webkitpy/common/checkout/scm/git.py:
  25188. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  25189. * Scripts/webkitpy/common/checkout/scm/svn.py:
  25190. * Scripts/webkitpy/common/host.py:
  25191. * Scripts/webkitpy/common/host_mock.py:
  25192. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  25193. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  25194. * Scripts/webkitpy/layout_tests/port/base.py:
  25195. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  25196. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  25197. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  25198. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  25199. 2011-11-13 Gavin Peters <gavinp@chromium.org>
  25200. command line control of webcore log channels in chromium DumpRenderTree
  25201. https://bugs.webkit.org/show_bug.cgi?id=72126
  25202. The option --webcore-log-channels=<foo>,<bar>,<quux> is the same as
  25203. what chromium takes.
  25204. Reviewed by Kent Tamura.
  25205. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  25206. (main):
  25207. 2011-11-12 Ariya Hidayat <ariya@sencha.com>
  25208. [Qt] Fix minor config typo in the build tool documentation
  25209. https://bugs.webkit.org/show_bug.cgi?id=72194
  25210. Reviewed by Andreas Kling.
  25211. * qmake/README:
  25212. 2011-11-11 Stephen Chenney <schenney@chromium.org>
  25213. [Chromium] DRT does not have LayoutTestController.pageSizeAndMarginsInPixels
  25214. https://bugs.webkit.org/show_bug.cgi?id=49257
  25215. Adds the remaining missing layout test functionality for printing.
  25216. Reviewed by Darin Fisher.
  25217. * DumpRenderTree/chromium/LayoutTestController.cpp:
  25218. (LayoutTestController::LayoutTestController): Add bindings for new JS methods
  25219. (parsePageNumber): Method to parse JS arguments for a page number
  25220. (parsePageNumberSizeMargins): Method to parse JS arguments for page size and margins
  25221. (LayoutTestController::pageSizeAndMarginsInPixels): Get the page size and margins for a given page.
  25222. (LayoutTestController::isPageBoxVisible): get the visibility status for printing
  25223. (LayoutTestController::pageProperty): get a specific CSS property when in printing mode
  25224. * DumpRenderTree/chromium/LayoutTestController.h: Add declarations for new methods
  25225. 2011-11-11 Darin Adler <darin@apple.com>
  25226. Remove all releaseRef implementations except for RetainPtr
  25227. https://bugs.webkit.org/show_bug.cgi?id=71423
  25228. Reviewed by Julien Chaffraix.
  25229. * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  25230. (createXMLStringFromWebArchiveData): Use leakRef instead of releaseRef.
  25231. 2011-11-11 Ryosuke Niwa <rniwa@webkit.org>
  25232. Make ChangeLogEntry's reviewer parsing algorithm support last 4 WebCore change logs
  25233. https://bugs.webkit.org/show_bug.cgi?id=72090
  25234. Reviewed by Eric Seidel.
  25235. Significantly improve ChangeLogEntry's reviewer parsing algorithm. This version can successfully parse
  25236. ChangeLog, ChangeLog-2011-10-19, ChangeLog-2011-06-04, ChangeLog-2011-02-16, and ChangeLog-2010-12-06.
  25237. yay! r100002.
  25238. * Scripts/webkitpy/common/checkout/changelog.py:
  25239. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  25240. 2011-11-11 Tony Chang <tony@chromium.org>
  25241. Remove --force from gclient sync. The bots seem to have made it past
  25242. the update step.
  25243. * Scripts/update-webkit:
  25244. 2011-11-11 Tony Chang <tony@chromium.org>
  25245. Add --force to gclient sync. Once the cq bots cycle, we can remove
  25246. this since it slows down the normal sync.
  25247. * Scripts/update-webkit:
  25248. 2011-11-11 Marc-Antoine Ruel <maruel@chromium.org>
  25249. When --force is used, also use --reset
  25250. https://bugs.webkit.org/show_bug.cgi?id=72129
  25251. Reviewed by Dimitri Glazkov.
  25252. * Scripts/update-webkit-chromium:
  25253. 2011-11-11 Tony Chang <tony@chromium.org>
  25254. allow two chromium drivers to run at the same time in NRWT
  25255. https://bugs.webkit.org/show_bug.cgi?id=72067
  25256. Reviewed by Dirk Pranke.
  25257. * Scripts/webkitpy/layout_tests/port/chromium.py: close_fds=True on
  25258. posix prevents the subprocesses from sharing the same fd for stdin.
  25259. Sharing the same fd prevents us from closing the files unless all references
  25260. to the fd are closed.
  25261. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: In addition
  25262. to adding a test for this, speed up a test (from 3sec to 0) by fixing
  25263. the timeout override. It looks like it regressed in r95875.
  25264. 2011-11-11 Sheriff Bot <webkit.review.bot@gmail.com>
  25265. Unreviewed, rolling out r99964.
  25266. http://trac.webkit.org/changeset/99964
  25267. https://bugs.webkit.org/show_bug.cgi?id=72124
  25268. Broke too many Qt tests (Requested by tronical_ on #webkit).
  25269. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  25270. (WTR::activateFonts):
  25271. * qmake/mkspecs/features/features.prf:
  25272. * qmake/mkspecs/features/webcore.prf:
  25273. 2011-11-11 Pierre Rossi <pierre.rossi@gmail.com>
  25274. [Qt] Remove the QStyle dependency in Qt's mobile theme
  25275. https://bugs.webkit.org/show_bug.cgi?id=67773
  25276. This refactoring splits up RenderThemeQt with two
  25277. subclasses, a QStyle-backed one, and a Mobile version
  25278. that uses the old mobile theme for now.
  25279. QStyle availability is detected at compile time, and
  25280. its use is determined by the QT_WEBKIT_USE_MOBILE_THEME
  25281. environment variable.
  25282. Reviewed by Simon Hausmann.
  25283. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  25284. (WTR::activateFonts):
  25285. * qmake/mkspecs/features/features.prf: HAVE_QSTYLE detection,
  25286. based on availability of QtWidgets.
  25287. * qmake/mkspecs/features/webcore.prf: cleanup.
  25288. 2011-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25289. [Qt] Add missing include to PlatformWebViewQt
  25290. Reviewed by Simon Hausmann.
  25291. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  25292. 2011-11-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25293. [Qt] Fix incremental builds on Windows after buildsystem refactor
  25294. The qmake rules to ensure that we run make on the derived sources
  25295. before running qmake on the target were inside a unix-scope, which
  25296. resulted in flakey builds on Windows.
  25297. We now generate a rule on all platforms that ensures that "make qmake"
  25298. will always run make on the derived sources. In addition, on platforms
  25299. that have GNU make (where "make incremental" does not run "make qmake",
  25300. but only "make"), we add a similar rule that ensures that any time the
  25301. target makefile is regenerated we first run qmake and make on the derived
  25302. sources. This rule relies on GNU make's order-only-prerequisites to
  25303. not trigger a qmake-run of the target every time we run make.
  25304. https://bugs.webkit.org/show_bug.cgi?id=71778
  25305. Reviewed by Simon Hausmann.
  25306. * qmake/mkspecs/features/functions.prf:
  25307. 2011-11-11 Simon Hausmann <simon.hausmann@nokia.com>
  25308. [Qt][WK2] Remove QWebNavigationController
  25309. https://bugs.webkit.org/show_bug.cgi?id=72113
  25310. Reviewed by Andreas Kling.
  25311. Adapt to the move of the QWebNavigationController functions/properties to
  25312. QQuickWebView.
  25313. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  25314. * MiniBrowser/qt/qml/BrowserWindow.qml:
  25315. 2011-11-11 Simon Hausmann <simon.hausmann@nokia.com>
  25316. [Qt] Build system tweak
  25317. Reviewed by Tor Arne Vestbø.
  25318. Be a good qmake citizen, return true from our linkStaticLibrary
  25319. "test" function.
  25320. * qmake/mkspecs/features/functions.prf:
  25321. 2011-11-11 Simon Hausmann <simon.hausmann@nokia.com>
  25322. [Qt] Add support for QT += webkit-private
  25323. Reviewed by Tor Arne Vestbø.
  25324. * qmake/qt_webkit.pri: Declare private headers.
  25325. 2011-11-11 Philippe Normand <pnormand@igalia.com>
  25326. Unreviewed, build fix attempt after r99907. Since that revision
  25327. GTK layout tests were not running at all...
  25328. * Scripts/webkitpy/layout_tests/port/gtk.py:
  25329. 2011-11-10 Andrew Scherkus <scherkus@chromium.org>
  25330. [Chromium] only run media GPU layout tests on platforms supporting accelerated compositing
  25331. https://bugs.webkit.org/show_bug.cgi?id=72001
  25332. Reviewed by Dirk Pranke.
  25333. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  25334. 2011-11-05 Filip Pizlo <fpizlo@apple.com>
  25335. bencher script should support remote benchmarking
  25336. https://bugs.webkit.org/show_bug.cgi?id=71618
  25337. Rubber-stamped by Geoff Garen.
  25338. Added the following features:
  25339. - Benchmark report tells you the hostname and machine model (according to
  25340. 'sysctl hw.model') of the machine you did the run on, and svn revision number
  25341. (according to 'svn info') of the VMs you're testing.
  25342. - The --remote option. You give this an ssh-style hostname (i.e. user@host is
  25343. acceptable, in addition to just host, in which case your username is used)
  25344. and it automatically packages the build directories of the VMs you're testing,
  25345. sends them to the remote machine along with your copy of the bencher script
  25346. and all of the options you passed. This pretty much seamlessly allows you
  25347. to run a set of benchmarks on any machine that is sufficiently compatible with
  25348. yours (i.e. similar OS) and that has the appropriate ~/.bencher file, which
  25349. must now include a tempPath setting that tells bencher where to put files
  25350. when that machine is used as a slave in a remote benchmarking run.
  25351. - Added yet another way of specifying which benchmarks to run. This was sort of
  25352. necessary for --remote to work as expected. Previously, you either said what
  25353. suites to exclude (for example --exclude-sunspider) or that you only wanted
  25354. to run one suite to the exclusion of others (--sunspider-only). But it's
  25355. often better to just be able to specify the list of suites you want. This is
  25356. now supported. You can say, for example, --v8 --sunspider, which means, just
  25357. run V8 and SunSpider. This is equivalent to saying --exclude-kraken, which is
  25358. still supported.
  25359. * Scripts/bencher:
  25360. 2011-11-10 Tony Chang <tony@chromium.org>
  25361. Lazily start DRT instances in NRWT
  25362. https://bugs.webkit.org/show_bug.cgi?id=72038
  25363. Reviewed by Eric Seidel.
  25364. Just a refactoring, no new tests.
  25365. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  25366. * Scripts/webkitpy/layout_tests/port/chromium.py:
  25367. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  25368. * Scripts/webkitpy/layout_tests/port/test.py:
  25369. * Scripts/webkitpy/layout_tests/port/webkit.py:
  25370. 2011-11-10 Ryosuke Niwa <rniwa@webkit.org>
  25371. ChangeLog mistakenly recognizes any string between '*' and ':' as touched files
  25372. https://bugs.webkit.org/show_bug.cgi?id=72057
  25373. Reviewed by Eric Seidel.
  25374. Make the regular expression more explicit.
  25375. * Scripts/webkitpy/common/checkout/changelog.py:
  25376. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  25377. 2011-11-10 Balazs Kelemen <kbalazs@webkit.org>
  25378. [Qt] X11 plugins need to be reworked for Qt5
  25379. https://bugs.webkit.org/show_bug.cgi?id=70023
  25380. Reviewed by Simon Hausmann.
  25381. Rework our basic plugin support in a way that does
  25382. not need a bridge between Qt and X. The solution is
  25383. based on getting the content drawed by the plugin
  25384. from the server as an image and creating a QImage
  25385. from it.
  25386. * qmake/mkspecs/features/features.prf: Enable X11
  25387. plugins if Qt is built with the xcb-xlib backend.
  25388. 2011-11-10 Simon Hausmann <simon.hausmann@nokia.com>
  25389. [Qt] Fix keyboard related layout tests after API refactoring
  25390. Reviewed by Tor Arne Vestbø.
  25391. Send key events to the handling page item, not the view.
  25392. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  25393. (WTR::PlatformWebView::sendEvent):
  25394. (WTR::PlatformWebView::postEvent):
  25395. 2011-11-10 Alexandre Mazari <amazari@igalia.com>
  25396. [GTK] Make the ENABLE(FEATURE) macro work in DRT
  25397. https://bugs.webkit.org/show_bug.cgi?id=71940
  25398. Reviewed by Philippe Normand.
  25399. * GNUmakefile.am:
  25400. Add webcore_cppflags to Programs_DumpRenderTree_CPP so
  25401. ENABLE_* variables are part of the environment.
  25402. 2011-11-10 Simon Hausmann <simon.hausmann@nokia.com>
  25403. [Qt] Fix focus related layout tests after API refactoring
  25404. Reviewed by Tor Arne Vestbø.
  25405. Make sure the focus is set on the page now, not on the view
  25406. (which doesn't actually handle the focus).
  25407. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  25408. (WTR::WrapperWindow::WrapperWindow):
  25409. (WTR::WrapperWindow::handleStatusChanged):
  25410. 2011-11-10 Alexis Menard <alexis.menard@openbossa.org>
  25411. [Qt] Merge QTouchWebView and QDesktopWebView into one class
  25412. https://bugs.webkit.org/show_bug.cgi?id=71355
  25413. Reviewed by Kenneth Rohde Christiansen.
  25414. Make MiniBrowser and WebKitTestRunner work again after the
  25415. merge.
  25416. * MiniBrowser/qt/BrowserWindow.cpp:
  25417. (BrowserWindow::BrowserWindow):
  25418. (BrowserWindow::webView):
  25419. * MiniBrowser/qt/MiniBrowser.pro:
  25420. * MiniBrowser/qt/MiniBrowser.qrc:
  25421. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  25422. * MiniBrowser/qt/main.cpp:
  25423. * MiniBrowser/qt/qml/BrowserWindow.qml:
  25424. * MiniBrowser/qt/qml/DesktopView.qml: Removed.
  25425. * MiniBrowser/qt/qml/TouchView.qml: Removed.
  25426. * WebKitTestRunner/PlatformWebView.h:
  25427. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  25428. (WTR::PlatformWebView::PlatformWebView):
  25429. 2011-11-10 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25430. [Qt] Change semantics of the haveQt() function to match API promises
  25431. Having Qt 5 does not imply that we have Qt 4, from an API point of
  25432. view, as a major version can in theory break BC/SC. Our minimum
  25433. version of Qt 4 will always be the latest released version of Qt 4,
  25434. so the only place we should use haveQt(4, x) is when checking for
  25435. the minimum requirements.
  25436. Reviewed by Simon Hausmann.
  25437. * qmake/mkspecs/features/default_pre.prf:
  25438. * qmake/mkspecs/features/features.prf:
  25439. * qmake/mkspecs/features/functions.prf:
  25440. 2011-11-07 Kaustubh Atrawalkar <kaustubh@motorola.com> and Sergio Villar Senin <svillar@igalia.com>
  25441. [WK2] [GTK] Implement a MouseDown/MouseUp/MouseMoveTo/MouseScrollBy/LeapForward functions for WebKit2 EventSender
  25442. https://bugs.webkit.org/show_bug.cgi?id=69411
  25443. Reviewed by Martin Robinson.
  25444. * WebKitTestRunner/EventSenderProxy.h:
  25445. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  25446. * WebKitTestRunner/TestController.cpp:
  25447. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  25448. use the EventSender instead of WebProcess Event Simulation.
  25449. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
  25450. (WTR::WTREventQueueItem::WTREventQueueItem):
  25451. (WTR::EventSenderProxy::EventSenderProxy):
  25452. (WTR::getMouseButtonModifiers):
  25453. (WTR::eventSenderButtonToGDKButton):
  25454. (WTR::EventSenderProxy::createMouseButtonEvent):
  25455. (WTR::EventSenderProxy::updateClickCountForButton):
  25456. (WTR::EventSenderProxy::replaySavedEvents):
  25457. (WTR::EventSenderProxy::sendOrQueueEvent):
  25458. (WTR::webkitModifiersToGDKModifiers):
  25459. (WTR::getGDKKeySymForKeyRef):
  25460. (WTR::EventSenderProxy::keyDown):
  25461. (WTR::EventSenderProxy::mouseDown):
  25462. (WTR::EventSenderProxy::mouseUp):
  25463. (WTR::EventSenderProxy::mouseMoveTo):
  25464. (WTR::EventSenderProxy::mouseScrollBy):
  25465. (WTR::EventSenderProxy::leapForward):
  25466. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25467. [Qt] Enable exports and constructor functions in static libs
  25468. Reviewed by Tor Arne Vestbø.
  25469. * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
  25470. mac/win32-msvc equivalents when linking static libraries into a shared
  25471. library or executable.
  25472. 2011-11-09 Hayato Ito <hayato@chromium.org>
  25473. [NRWT] Make results.html aware of reference filename in reftests.
  25474. https://bugs.webkit.org/show_bug.cgi?id=71574
  25475. Reviewed by Ryosuke Niwa.
  25476. If a reference filename is different from the default one, include that in result summary
  25477. so results.html can link to the correct reference file.
  25478. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  25479. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  25480. 2011-11-09 Kevin Ollivier <kevino@theolliviers.com>
  25481. [wx] Unreviewed build fix. Update project files and
  25482. add LTC stubs for new methods.
  25483. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  25484. (LayoutTestController::addChromeInputField):
  25485. (LayoutTestController::removeChromeInputField):
  25486. (LayoutTestController::focusWebView):
  25487. (LayoutTestController::setBackingScaleFactor):
  25488. * waf/build/settings.py:
  25489. 2011-11-09 Kevin Ollivier <kevino@theolliviers.com>
  25490. [wx] Unreviewed build fix. Support XCode 4 when building deps.
  25491. * wx/install-unix-extras:
  25492. 2011-11-09 Eric Seidel <eric@webkit.org>
  25493. Remove the concept of platform-dependent unittests
  25494. https://bugs.webkit.org/show_bug.cgi?id=71963
  25495. Unreviewed. Fix test-webkitpy on cygwin.
  25496. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  25497. 2011-11-09 Dana Jansens <danakj@chromium.org>
  25498. Add cc-bugs group to watch changes in chromium graphics
  25499. https://bugs.webkit.org/show_bug.cgi?id=71690
  25500. Reviewed by David Levin.
  25501. * Scripts/webkitpy/common/config/committers.py: Make new Account superclass for non-contributor watch accounts
  25502. * Scripts/webkitpy/common/config/committers_unittest.py: Test the Account superclass
  25503. * Scripts/webkitpy/common/config/watchlist: Add cc-bugs@google.com to watch list
  25504. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Check for Accounts also, but require it to be the bugzilla email for any Account/Contributor/etc.
  25505. 2011-11-09 Eric Seidel <eric@webkit.org>
  25506. Remove more platform-dependent unittests
  25507. https://bugs.webkit.org/show_bug.cgi?id=71971
  25508. Reviewed by Adam Barth.
  25509. Tests which only run on a couple platforms will break.
  25510. All tests should run on all platforms where possible.
  25511. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  25512. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  25513. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  25514. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  25515. 2011-11-09 Ojan Vafai <ojan@chromium.org>
  25516. Merge in results to the test results server even if build numbers conflict
  25517. https://bugs.webkit.org/show_bug.cgi?id=71967
  25518. Reviewed by Tony Chang.
  25519. This was initially meant to be a sanity check that we don't
  25520. enter duplicate runs, but it turns out that we can reasonably get
  25521. in these situations when a builder is clobbered (e.g. the build
  25522. numbers start over again from 0).
  25523. * TestResultServer/model/jsonresults.py:
  25524. * TestResultServer/model/jsonresults_unittest.py:
  25525. 2011-11-09 Eric Seidel <eric@webkit.org>
  25526. Remove the concept of platform-dependent unittests
  25527. https://bugs.webkit.org/show_bug.cgi?id=71963
  25528. Reviewed by Adam Barth.
  25529. These have been the source of never-ending sadness.
  25530. We'd change behavior and forget to update results in
  25531. some unittests because they were only run on certain platforms.
  25532. This change removes a large source of these platform-dependent
  25533. unittests, which was caused by the port_maker stuff.
  25534. It's possible that this change will break test-webkitpy
  25535. on some platforms, but that will be a one-time cost.
  25536. I will fix the breakage by removing the platform-dependantness
  25537. of any such broken tests.
  25538. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  25539. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  25540. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  25541. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  25542. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  25543. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  25544. * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
  25545. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  25546. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  25547. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  25548. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  25549. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  25550. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  25551. 2011-11-09 Eric Seidel <eric@webkit.org>
  25552. Make the Port object have a Host
  25553. https://bugs.webkit.org/show_bug.cgi?id=71961
  25554. Reviewed by Adam Barth.
  25555. This has been a long time coming.
  25556. Now that Port has a Host object, it's very easy
  25557. to write unittests which use a properly mocked Port.
  25558. Soon we will remove the executive, filesystem and user
  25559. members of Port and get everything through the Host.
  25560. Note how in many callsites we're actually removing
  25561. explicit mocks, since we're now always going to get the
  25562. correct Executive/User/FileSystem from the
  25563. Host and callsites don't need to be careful to pass each one.
  25564. This is prep-work for adding a new Environment member to
  25565. Host and needing to be able to access the Environment
  25566. member from Port functions w/o needing to pass an Environment
  25567. object (or appropriate Mock) every place we create a Port object.
  25568. Now that we have a single Host object to reach out through, its
  25569. simple to add additional functionality (like Environment) while
  25570. keeping our unittests properly mocked.
  25571. * Scripts/webkitpy/common/host.py:
  25572. * Scripts/webkitpy/common/net/credentials_unittest.py:
  25573. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  25574. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  25575. * Scripts/webkitpy/layout_tests/port/apple.py:
  25576. * Scripts/webkitpy/layout_tests/port/base.py:
  25577. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  25578. * Scripts/webkitpy/layout_tests/port/chromium.py:
  25579. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  25580. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  25581. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  25582. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  25583. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  25584. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  25585. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  25586. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  25587. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  25588. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  25589. * Scripts/webkitpy/layout_tests/port/efl.py:
  25590. * Scripts/webkitpy/layout_tests/port/factory.py:
  25591. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  25592. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  25593. * Scripts/webkitpy/layout_tests/port/gtk.py:
  25594. * Scripts/webkitpy/layout_tests/port/mac.py:
  25595. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  25596. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  25597. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  25598. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  25599. * Scripts/webkitpy/layout_tests/port/qt.py:
  25600. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  25601. * Scripts/webkitpy/layout_tests/port/test.py:
  25602. * Scripts/webkitpy/layout_tests/port/webkit.py:
  25603. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  25604. * Scripts/webkitpy/layout_tests/port/win.py:
  25605. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  25606. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  25607. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  25608. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  25609. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  25610. 2011-11-09 Dominic Mazzoni <dmazzoni@google.com>
  25611. [Chromium] Implement AccessibilityUIElement::insertionPointLineNumberGetterCallback
  25612. https://bugs.webkit.org/show_bug.cgi?id=71561
  25613. Reviewed by Dimitri Glazkov.
  25614. * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  25615. (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
  25616. 2011-11-09 Benjamin Poulain <bpoulain@apple.com>
  25617. Implement dumpProgressFinishedCallback() for Mac layoutTestController
  25618. https://bugs.webkit.org/show_bug.cgi?id=66772
  25619. Reviewed by Simon Fraser.
  25620. When dumpProgressFinishedCallback is enabled, DumpRenderTree should output
  25621. "postProgressFinishedNotification" on FrameLoaderClient::postProgressFinishedNotification().
  25622. On Mac, the FrameLoaderClient post a notification. This patch add handling for this notification
  25623. in the FrameLoadDelegate and print the output in response to the notification.
  25624. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  25625. (-[FrameLoadDelegate init]):
  25626. (-[FrameLoadDelegate dealloc]):
  25627. (-[FrameLoadDelegate webViewProgressFinishedNotification:]):
  25628. 2011-11-09 Philippe Normand <pnormand@igalia.com>
  25629. [GTK][DRT] window internals object is not reset after each test
  25630. https://bugs.webkit.org/show_bug.cgi?id=71890
  25631. Reviewed by Martin Robinson.
  25632. Call WebCoreTestSupport::resetInternalsObject without going
  25633. through DumpRenderTreeSupport.
  25634. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  25635. (runTest):
  25636. 2011-11-09 Beth Dakin <bdakin@apple.com>
  25637. Build fix.
  25638. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  25639. (AccessibilityUIElement::uiElementAttributeValue):
  25640. 2011-11-09 Beth Dakin <bdakin@apple.com>
  25641. Speculative build fix.
  25642. * DumpRenderTree/AccessibilityUIElement.h:
  25643. 2011-11-09 Julien Chaffraix <jchaffraix@webkit.org>
  25644. Unreviewed build fix.
  25645. * DumpRenderTree/AccessibilityUIElement.cpp:
  25646. (AccessibilityUIElement::makeJSAccessibilityUIElement):
  25647. A bad merge added this check that is making the bots sad.
  25648. 2011-11-09 Chris Fleizach <cfleizach@apple.com>
  25649. AX: crash when accessing selectedTab in a tab list
  25650. https://bugs.webkit.org/show_bug.cgi?id=70938
  25651. Reviewed by Beth Dakin.
  25652. Add the ability to retrieve an element through an arbitrary attribute.
  25653. * DumpRenderTree/AccessibilityUIElement.cpp:
  25654. (uiElementAttributeValueCallback):
  25655. (AccessibilityUIElement::uiElementAttributeValue):
  25656. (AccessibilityUIElement::getJSClass):
  25657. * DumpRenderTree/AccessibilityUIElement.h:
  25658. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  25659. (AccessibilityUIElement::uiElementAttributeValue):
  25660. 2011-11-09 Andy Wingo <wingo@igalia.com>
  25661. Add webkitdirs.pm:getArchitecture implementation for GTK
  25662. https://bugs.webkit.org/show_bug.cgi?id=71370
  25663. Reviewed by Xan Lopez.
  25664. * Scripts/webkitdirs.pm (determineArchitecture): Add an
  25665. implementation for ports using autotools, so that a vanilla
  25666. `run-javascriptcore-tests --gtk' invocation doesn't pass --32-bit
  25667. to build-jsc on x86-64 machines.
  25668. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25669. Unreviewed, rolling out r99707.
  25670. http://trac.webkit.org/changeset/99707
  25671. Re-enable until we can disable it together with tests in one
  25672. shot.
  25673. * qmake/mkspecs/features/features.prf:
  25674. 2011-11-09 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25675. [Qt] Disable use of QtUiTools if the library/module is not found
  25676. We rely on the lookup order of prf files to inject our own uitools.prf
  25677. that will verify that QtUiTools is in fact present before allowing the
  25678. CONFIG += uitools to have any effect.
  25679. Reviewed by Simon Hausmann.
  25680. * DumpRenderTree/qt/DumpRenderTree.pro:
  25681. * QtTestBrowser/QtTestBrowser.pro:
  25682. * qmake/mkspecs/features/uitools.prf: Added.
  25683. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25684. Unreviewed, rolling out r99701.
  25685. http://trac.webkit.org/changeset/99701
  25686. Breaks Qt mac build
  25687. * qmake/mkspecs/features/functions.prf:
  25688. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25689. [Qt] Prospective build fix for Win32/Mac with xmlpatterns
  25690. Reviewed by Tor Arne Vestbø.
  25691. * qmake/mkspecs/features/features.prf: Disable XSLT support initially.
  25692. We default to XSLT support if qxmlpatterns is available. However qxmlpatterns
  25693. is not up to the task of full XSLT support, so we should disable it.
  25694. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25695. [Qt] Enable exports and constructor functions in static libs
  25696. Reviewed by Tor Arne Vestbø.
  25697. * qmake/mkspecs/features/functions.prf: Use --whole-archive and their
  25698. mac/win32-msvc equivalents when linking static libraries into a shared
  25699. library or executable.
  25700. 2011-11-09 Philippe Normand <pnormand@igalia.com>
  25701. [GTK][DRT] window internals object is not reset after each test
  25702. https://bugs.webkit.org/show_bug.cgi?id=71890
  25703. Reviewed by Xan Lopez.
  25704. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  25705. (runTest): reset the Internals object after each test.
  25706. 2011-11-09 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25707. [Qt] Detect presence of QtUiTools and enable it only when available
  25708. The disable_uitools option was a workaround for missing detection.
  25709. Reviewed by Simon Hausmann.
  25710. * QtTestBrowser/QtTestBrowser.pro:
  25711. * qmake/mkspecs/features/default_post.prf:
  25712. * qmake/mkspecs/features/default_pre.prf:
  25713. 2011-11-09 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25714. [Qt] Don't override config for the build_pass of debug_and_release
  25715. Qmake will parse the profile once for each configuration (debug and
  25716. release), with the build_pass option set. In that situation we don't
  25717. want to override what qmake is setting explicitly, otherwise the
  25718. debug-step will end up hitting all the release-scopes.
  25719. Reviewed by Simon Hausmann.
  25720. * qmake/mkspecs/features/default_pre.prf:
  25721. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25722. [Qt] Unbreak the Qt build (copy & paste mistake - oops)
  25723. * qmake/mkspecs/features/functions.prf:
  25724. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25725. [Qt] Centralize duplicated code for linking the static libs
  25726. Reviewed by Tor Arne Vestbø.
  25727. * qmake/mkspecs/features/functions.prf:
  25728. * qmake/mkspecs/features/javascriptcore.prf:
  25729. * qmake/mkspecs/features/webcore.prf:
  25730. * qmake/mkspecs/features/webkit2.prf:
  25731. 2011-11-09 Simon Hausmann <simon.hausmann@nokia.com>
  25732. [Qt] Build system cleanup
  25733. https://bugs.webkit.org/show_bug.cgi?id=71815
  25734. Reviewed by Kenneth Rohde Christiansen.
  25735. * WebKitTestRunner/InjectedBundle/Target.pri: We don't need to link against the webkit2
  25736. static library.
  25737. * qmake/mkspecs/features/javascriptcore.prf: The wtf sources pull in a glib dependency
  25738. (ownPtr functions for glib types). Propagate that to everyone using javascriptcore.
  25739. 2011-11-08 Hayato Ito <hayato@chromium.org>
  25740. [NRWT] Make single_test_runner aware of reference filename of test_input.
  25741. https://bugs.webkit.org/show_bug.cgi?id=71567
  25742. Reviewed by Ryosuke Niwa.
  25743. Make single_test_runner honor a reference filename of given test_input so that
  25744. we can use any file as reference html, instead of depending on implicit naming convention.
  25745. The typical use case is to support w3c reftests.
  25746. No tests since no functional changes until there is a client.
  25747. Test should be easily written with future clients.
  25748. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  25749. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  25750. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  25751. * Scripts/webkitpy/layout_tests/models/test_input.py:
  25752. 2011-11-08 Lucas Forschler <lforschler@apple.com>
  25753. https://bugs.webkit.org/show_bug.cgi?id=71839
  25754. Update the leaks bot OS to Lion.
  25755. Update the config.json to reflect the update.
  25756. Reviewed by Stephanie Lewis.
  25757. * BuildSlaveSupport/build.webkit.org-config/config.json:
  25758. 2011-11-08 Sheriff Bot <webkit.review.bot@gmail.com>
  25759. Unreviewed, rolling out r99626.
  25760. http://trac.webkit.org/changeset/99626
  25761. https://bugs.webkit.org/show_bug.cgi?id=71866
  25762. "C++ exceptions cannot be disabled without influencing the
  25763. Objective-C exceptions" (Requested by benjaminp on #webkit).
  25764. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  25765. 2011-11-08 Benjamin Poulain <bpoulain@apple.com>
  25766. [Mac] Disable C++ exceptions from DumpRenderTree
  25767. https://bugs.webkit.org/show_bug.cgi?id=71834
  25768. Reviewed by Darin Adler.
  25769. DumpRenderTree Mac does not handle C++ exceptions. When such exception
  25770. happens, it tends to cause the AutoReleasePool stack to be corrupted,
  25771. which leads to crashes long after the exception was raised.
  25772. This patch disabled C++ exceptions in order to catch the problems where
  25773. they happen when a C++ exception is raised.
  25774. * DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
  25775. 2011-11-08 Julien Chaffraix <jchaffraix@webkit.org>
  25776. Moved myself to the reviewer list (yay!).
  25777. * Scripts/webkitpy/common/config/committers.py:
  25778. 2011-11-08 Zeno Albisser <zeno@webkit.org>
  25779. Added myself as a committer.
  25780. * Scripts/webkitpy/common/config/committers.py:
  25781. 2011-11-08 Andy Wingo <wingo@igalia.com>
  25782. Skip some ECMAScript tests that fail on Linux in some time zones.
  25783. https://bugs.webkit.org/show_bug.cgi?id=71371
  25784. Reviewed by Martin Robinson.
  25785. * Scripts/run-javascriptcore-tests: Skip some more tests.
  25786. 2011-11-08 Csaba Osztrogonác <ossy@webkit.org>
  25787. [Qt] Unreviewed trivial fix after build system refactoring.
  25788. * Scripts/run-qtwebkit-tests: Fix path of QtWebProcess for QML tests.
  25789. 2011-11-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25790. [Qt] Don't set OBJECTS_DIR and DEFINES in default_pre
  25791. If a pro file needs to access the OBJECTS_DIR it should use the
  25792. form ${QMAKE_VAR_OBJECTS_DIR} to ensure the value is evaluated
  25793. after defaults_post has been processed.
  25794. Setting DEFINES in defaults_pre is also bad, as any DEFINES=foo on
  25795. the command line will override whatever we set in defaults_pre.
  25796. Reviewed by Simon Hausmann.
  25797. * qmake/mkspecs/features/default_post.prf:
  25798. * qmake/mkspecs/features/default_pre.prf:
  25799. 2011-11-08 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25800. [Qt] Prevent duplicated sources in SOURCES/OBJECTIVE_SOURCES
  25801. Reviewed by Simon Hausmann.
  25802. * qmake/mkspecs/features/default_post.prf:
  25803. 2011-11-07 Zeno Albisser <zeno.albisser@nokia.com>
  25804. [Qt][WK2] MiniBrowser should use urlFromUserInput()
  25805. https://bugs.webkit.org/show_bug.cgi?id=71680
  25806. Use urlFromUserInput() / QUrl::fromUserInput() to automatically
  25807. complete urls in MiniBrowser.
  25808. Reviewed by Tor Arne Vestbø.
  25809. * MiniBrowser/qt/BrowserWindow.cpp:
  25810. (BrowserWindow::BrowserWindow):
  25811. (BrowserWindow::load):
  25812. * MiniBrowser/qt/qml/BrowserWindow.qml:
  25813. * MiniBrowser/qt/utils.cpp:
  25814. (Utils::urlFromUserInput):
  25815. * MiniBrowser/qt/utils.h:
  25816. (Utils::Utils):
  25817. 2011-11-07 Yuqiang Xian <yuqiang.xian@intel.com>
  25818. Added myself as a committer.
  25819. * Scripts/webkitpy/common/config/committers.py:
  25820. 2011-11-07 Csaba Osztrogonác <ossy@webkit.org>
  25821. Unreviewed webkitpy test fix after r99512.
  25822. * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py:
  25823. Xianzhu Wang is now a committer, so we can't nominate him as a committer anymore.
  25824. 2011-11-07 Xianzhu Wang <wangxianzhu@chromium.org>
  25825. Added myself as a committer.
  25826. * Scripts/webkitpy/common/config/committers.py:
  25827. 2011-11-07 Sheriff Bot <webkit.review.bot@gmail.com>
  25828. Unreviewed, rolling out r99470.
  25829. http://trac.webkit.org/changeset/99470
  25830. https://bugs.webkit.org/show_bug.cgi?id=71740
  25831. "Broke test-webkitpy" (Requested by eseidel2 on #webkit).
  25832. * Scripts/webkitpy/common/config/watchlist:
  25833. 2011-11-07 Tony Chang <tony@chromium.org>
  25834. [chromium] update flakiness dashboard to reflect current bots
  25835. Reviewed by Ojan Vafai.
  25836. * TestResultServer/static-dashboards/builders.js: Remove (deps) debug
  25837. bots and merged linux debug bots into a single bot.
  25838. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  25839. (setupExpectationsTest):
  25840. 2011-11-07 Dana Jansens <danakj@chromium.org>
  25841. Add cc-bugs group to watch changes in chromium graphics
  25842. https://bugs.webkit.org/show_bug.cgi?id=71690
  25843. Reviewed by James Robinson.
  25844. * Scripts/webkitpy/common/config/watchlist:
  25845. 2011-11-07 Balazs Ankes <Ankes.Balazs@stud.u-szeged.hu>
  25846. [NRWT] Parsing of test_expectations.txt should be agnostic to newline at end
  25847. https://bugs.webkit.org/show_bug.cgi?id=70912
  25848. Reviewed by Ojan Vafai.
  25849. * Scripts/webkitpy/layout_tests/port/webkit.py: Add newline at the end of test_expectations.txt.
  25850. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Make up the test_test_expectations method for the updated webkit.py.
  25851. 2011-11-07 Eric Seidel <eric@webkit.org>
  25852. new-run-webkit-tests: support --repeat-each feature from old-run-webkit-tests
  25853. https://bugs.webkit.org/show_bug.cgi?id=62199
  25854. Reviewed by Dirk Pranke.
  25855. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  25856. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  25857. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  25858. 2011-11-07 Fady Samuel <fsamuel@chromium.org>
  25859. [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
  25860. https://bugs.webkit.org/show_bug.cgi?id=71485
  25861. Reviewed by Darin Fisher.
  25862. * DumpRenderTree/chromium/EventSender.cpp:
  25863. (EventSender::scalePageBy):
  25864. * DumpRenderTree/chromium/TestShell.cpp:
  25865. (TestShell::resetTestController):
  25866. 2011-11-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25867. [Qt] Put the jsc binary in 'bin' instead of leaving it deep in the build tree
  25868. Allows us to not package up the whole Source/JavaScriptCore directory for the
  25869. buildbots.
  25870. Reviewed-by Simon Hausmann.
  25871. * BuildSlaveSupport/built-product-archive:
  25872. * Scripts/webkitdirs.pm:
  25873. (jscProductDir):
  25874. 2011-11-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25875. [Qt] Ensure we always export symbols for the QtWebKit API when building WebKit
  25876. Reviewed-by Simon Hausmann.
  25877. * qmake/mkspecs/features/default_post.prf:
  25878. 2011-11-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25879. [Qt] Sanitize qmake paths correctly before comparing
  25880. The qmake function toSanitizedPath had a bug causing empty paths on MinGW,
  25881. which caused us to always generate derived webcore sources, but never build
  25882. them. The bug has been fixed, and we now also sanitize paths for the injected
  25883. bundle derived sources.
  25884. Reviewed by Simon Hausmann.
  25885. * WebKitTestRunner/InjectedBundle/DerivedSources.pri:
  25886. * qmake/mkspecs/features/functions.prf:
  25887. 2011-11-07 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  25888. [Qt] Print right order for changing feature defines
  25889. Reviewed by Simon Hausmann.
  25890. * Scripts/webkitdirs.pm:
  25891. (buildQMakeProject):
  25892. 2011-11-06 Csaba Osztrogonác <ossy@webkit.org>
  25893. [Qt] Unreviewed trivial fix after build system refactoring.
  25894. * Scripts/run-qtwebkit-tests: Fix qml_import_path.
  25895. 2011-11-06 Eric Seidel <eric@webkit.org>
  25896. Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
  25897. https://bugs.webkit.org/show_bug.cgi?id=66078
  25898. Unreviewed. Add an assert about the type of "args"
  25899. to our Executive Mocks and fix a piece of code
  25900. from this patch which was hitting that assert
  25901. when executing for real.
  25902. * Scripts/webkitpy/common/system/executive_mock.py:
  25903. * Scripts/webkitpy/layout_tests/port/webkit.py:
  25904. 2011-11-06 Eric Seidel <eric@webkit.org>
  25905. Split chunk handling out of prepare_lists_and_print_output to make it more readable
  25906. https://bugs.webkit.org/show_bug.cgi?id=71629
  25907. Reviewed by Adam Barth.
  25908. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  25909. 2011-11-06 Eric Seidel <eric@webkit.org>
  25910. Clarify how the symbol and runtime-feature based test exclusion works and cleanup the code a bit
  25911. https://bugs.webkit.org/show_bug.cgi?id=66078
  25912. Reviewed by Adam Barth.
  25913. The runtime feature detection was fixed to work in bug 64472.
  25914. In this bug I moved the symbol-based feature detection from
  25915. popen() to Executive.run_command and cleaned up the callers
  25916. and unittests to make sure that we're correctly parsing the
  25917. nm output correctly. The old code happened to work even though
  25918. the runtime-features path was using "str in list" and the
  25919. symbol features path was using "str in str" and it just happened
  25920. to do what we wanted to. Now runtime features and symbol feature
  25921. blacklists are computed separately (and with better documentation).
  25922. This system remains confusing, partially because these are black-lists
  25923. which are amended to whatever static blacklist may exist for the
  25924. port as part of a Skipped list file.
  25925. For example, notice how the runtime feature list only has directory
  25926. blacklists for a couple features. If all features are off,
  25927. how do we skip enough tests with only 2 entries in the blacklist map?
  25928. The answer is that Windows is the only port to use runtime feature
  25929. detection, and the win/Skipped file turns off all the other features
  25930. statically (like mathml, mhtml, wss, etc.) where as some other ports (like AppleMac)
  25931. which use symbol-based feature detection turn of mathml, wcss, etc
  25932. using the blacklists found in _missing_symbol_to_skipped_tests.
  25933. I also noticed a couple places where we still referenced xhtmlmp
  25934. even though support for such has been removed from WebKit. Removed those.
  25935. This should result in no functional change.
  25936. * Scripts/webkitpy/layout_tests/port/gtk.py:
  25937. - Use self._filesystem instead of os.path
  25938. * Scripts/webkitpy/layout_tests/port/webkit.py:
  25939. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  25940. 2011-11-06 Dan Bernstein <mitz@apple.com>
  25941. Made show-pretty-diff work when the input path contains spaces.
  25942. Reviewed by Anders Carlsson.
  25943. * Scripts/show-pretty-diff:
  25944. 2011-11-05 Daniel Cheng <dcheng@chromium.org>
  25945. [chromium] Use the security origin instead of the URL when checking notification permissions
  25946. https://bugs.webkit.org/show_bug.cgi?id=71590
  25947. Reviewed by Adam Barth.
  25948. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  25949. (NotificationPresenter::checkPermission):
  25950. * DumpRenderTree/chromium/NotificationPresenter.h:
  25951. 2011-11-05 Darin Adler <darin@apple.com>
  25952. Fix a small leak in Mac version of LayoutTestController
  25953. https://bugs.webkit.org/show_bug.cgi?id=71615
  25954. Reviewed by Mark Rowe.
  25955. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  25956. (LayoutTestController::applicationCacheDiskUsageForOrigin): Release the origin.
  25957. (LayoutTestController::localStorageDiskUsageForOrigin): Ditto.
  25958. 2011-11-04 Eric Seidel <eric@webkit.org>
  25959. Upgrade to the latest Mechanize
  25960. https://bugs.webkit.org/show_bug.cgi?id=71594
  25961. Reviewed by Adam Barth.
  25962. I noticed our mechanize was somewhat out of date when removing Python 2.5 support.
  25963. Mechanize is no longer two separate libraries, so importing it is much simpler.
  25964. * Scripts/webkitpy/thirdparty/__init__.py:
  25965. 2011-11-04 Stephen Chenney <schenney@chromium.org>
  25966. Crash in ScrollAnimator.cpp
  25967. https://bugs.webkit.org/show_bug.cgi?id=69865
  25968. The code in ScrollAnimator assumes that horizontal per-page mouse
  25969. wheel events cannot happen, which is not true. This patch adds layout
  25970. tests for all paging wheel event situations and fixes the broken
  25971. horizontal case.
  25972. Reviewed by Anders Carlsson
  25973. * DumpRenderTree/chromium/EventSender.cpp:
  25974. (EventSender::handleMouseWheel): Added the ability to specify that a
  25975. mouse wheel event should be paging.
  25976. 2011-11-04 Eric Seidel <eric@webkit.org>
  25977. Remove deprecated free functions in port.factory
  25978. https://bugs.webkit.org/show_bug.cgi?id=71494
  25979. Unreviewed. Fix exception when running new-run-webkit-httpd.
  25980. * Scripts/new-run-webkit-httpd:
  25981. 2011-11-04 Adam Roben <aroben@apple.com>
  25982. Remove Leopard-specific code from build.webkit.org
  25983. We don't have any Leopard bots anymore.
  25984. Fixes <http://webkit.org/b/71583> build.webkit.org configuration contains obsolete Leopard code
  25985. Reviewed by Mark Rowe.
  25986. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed now-unused StartATSServer
  25987. and StopATSServer steps.
  25988. (unitTestsSupported): Removed check for mac-leopard.
  25989. (TestFactory.__init__): Removed Leopard-specific steps.
  25990. 2011-11-04 Eric Seidel <eric@webkit.org>
  25991. new-run-webkit-tests autoinstalls python-irclib even though it doesn't need to
  25992. https://bugs.webkit.org/show_bug.cgi?id=71549
  25993. Reviewed by Adam Barth.
  25994. Several members of Host didn't really belong there
  25995. and were instead specific to WebKitPatch, so I've moved
  25996. them up onto that class.
  25997. * Scripts/webkitpy/common/host.py:
  25998. * Scripts/webkitpy/common/host_mock.py:
  25999. * Scripts/webkitpy/tool/main.py:
  26000. * Scripts/webkitpy/tool/mocktool.py:
  26001. * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  26002. 2011-11-04 Tony Chang <tony@chromium.org>
  26003. garden-o-matic: bring back party time!
  26004. https://bugs.webkit.org/show_bug.cgi?id=71582
  26005. Reviewed by Adam Barth.
  26006. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Allow images from file:
  26007. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/partytime.gif: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif.
  26008. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Add length() for UpdateTracker.
  26009. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Plumb through length().
  26010. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Toggle partytime.gif via css class.
  26011. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css: Add css styling for partytime.
  26012. 2011-11-04 Raphael Kubo da Costa <kubo@profusion.mobi>
  26013. [EFL] DRT: Fix the order of the items in the dumped history list.
  26014. https://bugs.webkit.org/show_bug.cgi?id=71562
  26015. It did not make much sense to hold the history list in a map, as we do not need
  26016. the keys. And the printed items must be sorted by target, which is more easily
  26017. done with a vector.
  26018. Should make tests such as http/tests/navigation/error404-frames.html pass.
  26019. Reviewed by Antonio Gomes.
  26020. * DumpRenderTree/efl/DumpHistoryItem.cpp:
  26021. (compareHistoryItemsByTarget):
  26022. (dumpHistoryItem):
  26023. 2011-11-04 Patrick Gansterer <paroga@webkit.org>
  26024. [Qt] Remove ENABLE_SQLITE from qmake files
  26025. https://bugs.webkit.org/show_bug.cgi?id=71546
  26026. Reviewed by Simon Hausmann.
  26027. * qmake/mkspecs/features/features.prf:
  26028. * qmake/mkspecs/features/webcore.prf:
  26029. 2011-11-04 Adam Barth <abarth@webkit.org>
  26030. watchlist for WebIDL shouldn't trigger on Internals.idl
  26031. https://bugs.webkit.org/show_bug.cgi?id=70657
  26032. Reviewed by David Levin.
  26033. Internals.idl isn't part of the Web-facing IDL in the project.
  26034. * Scripts/webkitpy/common/config/watchlist:
  26035. 2011-11-04 Anders Carlsson <andersca@apple.com>
  26036. Fix WKTR crash when running NPN_ConvertPoint test.
  26037. Call notifyDone in a timeout - otherwise we'll end up entering layout from layout.
  26038. * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
  26039. (ConvertPoint::NPP_SetWindow):
  26040. 2011-11-04 Anders Carlsson <andersca@apple.com>
  26041. NPN_ConvertPoint plug-in test should be called from NPP_SetWindow
  26042. https://bugs.webkit.org/show_bug.cgi?id=71570
  26043. Reviewed by Simon Fraser.
  26044. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  26045. (PluginTest::NPP_SetWindow):
  26046. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  26047. Remove the NPP parameter from NPP_SetWindow.
  26048. * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp:
  26049. (NPPSetWindowCalledDuringDestruction::NPP_SetWindow):
  26050. Remove the NPP parameter from NPP_SetWindow.
  26051. * DumpRenderTree/TestNetscapePlugIn/Tests/PassDifferentNPPStruct.cpp:
  26052. (PassDifferentNPPStruct::NPP_SetWindow):
  26053. Remove the NPP parameter from NPP_SetWindow and use PluginTest::log for logging.
  26054. * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp:
  26055. (ConvertPoint::NPP_SetWindow):
  26056. Run the test from NPP_SetWindow and call notifyDone() when done.
  26057. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  26058. (NPP_SetWindow):
  26059. Remove unnecessary parameter.
  26060. 2011-11-04 Simon Hausmann <simon.hausmann@nokia.com>
  26061. [Qt] Fix run-qtwebkit-tests execution on the build bot(s).
  26062. Rubber-stamped by Tor Arne Vestbø.
  26063. * BuildSlaveSupport/build.webkit.org-config/master.cfg: The path to the tests
  26064. changed slightly after the refactoring.
  26065. 2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  26066. [Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
  26067. Reviewed by Simon Hausmann.
  26068. * qmake/mkspecs/features/default_pre.prf:
  26069. 2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  26070. [Qt] Don't error out on wrong Qt version when qmake does recursive includes
  26071. Reviewed by Simmon Hausmann.
  26072. * qmake/mkspecs/features/default_pre.prf:
  26073. 2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  26074. [Qt] Disable STDIN check before cleaning build dir
  26075. It didn't work on the bots.
  26076. Reviewed by Ossy.
  26077. * Scripts/webkitdirs.pm:
  26078. 2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  26079. [Qt] Don't build all of webkit when running build-jsc
  26080. In case the whole webkit project was built, but we then subsequently
  26081. want to build only JSC, we need to run make in the proper subdirectory.
  26082. This also means the incremental target needs to be added to all
  26083. makefiles.
  26084. Reviewed by Simmon Hausmann.
  26085. * Scripts/webkitdirs.pm:
  26086. (buildQMakeProject):
  26087. * qmake/mkspecs/features/default_post.prf:
  26088. 2011-11-04 Simon Hausmann <simon.hausmann@nokia.com>
  26089. Fix run-javascriptcore-tests for Qt when it's executed by the bot.
  26090. Reviewed by Tor Arne Vestbø.
  26091. * Scripts/webkitdirs.pm:
  26092. (jscProductDir): jsc path changed.
  26093. 2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  26094. [Qt] Error out early if trying to build against Qt < 4.8
  26095. Reviewed by Simon Hausmann.
  26096. * qmake/mkspecs/features/default_pre.prf:
  26097. 2011-11-04 Simon Hausmann <simon.hausmann@nokia.com>
  26098. Fix run-launcher for Qt and Gtk.
  26099. Rubber-stamped by Tor Arne Vestbø.
  26100. * Scripts/webkitdirs.pm:
  26101. (isWK2): Re-add isWK2(), as it's used in run-launcher.
  26102. 2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  26103. [Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
  26104. Reviewed by Simon Hausmann.
  26105. * Scripts/build-webkit:
  26106. 2011-11-04 Carlos Garcia Campos <cgarcia@igalia.com>
  26107. [GTK] Use web view title as window title in MiniBrowser
  26108. https://bugs.webkit.org/show_bug.cgi?id=71544
  26109. Reviewed by Philippe Normand.
  26110. * MiniBrowser/gtk/BrowserWindow.c:
  26111. (webViewURIChanged): Removed extra space.
  26112. (webViewTitleChanged): Set window title using
  26113. webkit_web_view_get_title().
  26114. (browser_window_init): Set initial default window title.
  26115. (browserWindowConstructed): Connect to WebView notify::title
  26116. signal.
  26117. 2011-11-04 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  26118. [Qt] Refactor and clean up the qmake build system
  26119. The qmake build system has accumulated a bit of cruft and redundancy
  26120. over time. There's also a fairly tight coupling between how to build
  26121. the various targets, and _what_ to build, making it harder to add new
  26122. rules or sources. This patch aims to elevate these issues somewhat.
  26123. This is a short-list of the changes:
  26124. * The rules for how to build targets are now mostly contained as
  26125. prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
  26126. allows us to do pre- and post-processing of each project file,
  26127. which helps to clean up the actual project files.
  26128. * Derived sources are no longer generated as a separate make-step
  26129. but is part of each target's project file as a subdir. Makefile
  26130. rules are used to ensure that we run make on the derived sources
  26131. before running qmake on the actual target makefile. This makes
  26132. it easier to keep a proper dependency between derived sources
  26133. and the target.
  26134. * We use GNU make and the compiler to generate dependencies on
  26135. UNIX-based systems running Qt 5. This allows us to lessen the
  26136. need to run qmake, which should reduce compile time.
  26137. * WebKit2 is now build by default if building with Qt 5. It can
  26138. be disabled by passing --no-webkit2 to build-webkit.
  26139. The result of these changes are hopefully a cleaner and easier
  26140. build system to modify, and faster build times due to no longer
  26141. running qmake on every single build. It's also a first step
  26142. towards possibly generating the list of sources using another
  26143. build system.
  26144. https://bugs.webkit.org/show_bug.cgi?id=71222
  26145. Reviewed by Simon Hausmann.
  26146. * DerivedSources.pro: Removed.
  26147. * DumpRenderTree/qt/DumpRenderTree.pro:
  26148. * DumpRenderTree/qt/ImageDiff.pro:
  26149. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  26150. * MiniBrowser/qt/MiniBrowser.pro:
  26151. * QtTestBrowser/QtTestBrowser.pro:
  26152. * QtTestBrowser/launcherwindow.cpp:
  26153. (LauncherWindow::initializeView):
  26154. (LauncherWindow::createChrome):
  26155. (LauncherWindow::screenshot):
  26156. * QtTestBrowser/launcherwindow.h:
  26157. (WindowOptions::WindowOptions):
  26158. * Scripts/build-webkit:
  26159. (unlinkZeroFiles):
  26160. * Scripts/webkitdirs.pm:
  26161. (qtFeatureDefaults):
  26162. (promptUser):
  26163. (buildQMakeProject):
  26164. * Tools.pro:
  26165. * WebKitTestRunner/DerivedSources.pri: Added.
  26166. * WebKitTestRunner/DerivedSources.pro: Removed.
  26167. * WebKitTestRunner/InjectedBundle/DerivedSources.pri: Added.
  26168. * WebKitTestRunner/InjectedBundle/InjectedBundle.pro: Added.
  26169. * WebKitTestRunner/InjectedBundle/Target.pri: Added.
  26170. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Removed.
  26171. * WebKitTestRunner/Target.pri: Added.
  26172. * WebKitTestRunner/WebKitTestRunner.pro:
  26173. * WebKitTestRunner/qt/TestInvocationQt.cpp:
  26174. * WebKitTestRunner/qt/WebKitTestRunner.pro: Removed.
  26175. * qmake/README: Added.
  26176. * qmake/mkspecs/features/default_post.prf: Added.
  26177. * qmake/mkspecs/features/default_pre.prf: Added.
  26178. * qmake/mkspecs/features/features.prf: Renamed from Source/WebCore/features.pri.
  26179. * qmake/mkspecs/features/functions.prf: Added.
  26180. * qmake/mkspecs/features/javascriptcore.prf: Renamed from Source/JavaScriptCore/JavaScriptCore.pri.
  26181. * qmake/mkspecs/features/mac/default_post.prf: Added.
  26182. * qmake/mkspecs/features/mac/default_pre.prf: Added.
  26183. * qmake/mkspecs/features/minimal_qt.prf: Added.
  26184. * qmake/mkspecs/features/qtwebkit.prf: Added.
  26185. * qmake/mkspecs/features/rpath.prf: Added.
  26186. * qmake/mkspecs/features/unix/default_post.prf: Added.
  26187. * qmake/mkspecs/features/unix/default_pre.prf: Added.
  26188. * qmake/mkspecs/features/valgrind.prf: Added.
  26189. * qmake/mkspecs/features/webcore.prf: Renamed from Source/WebCore/WebCore.pri.
  26190. * qmake/mkspecs/features/webkit2.prf: Copied from Source/WebKit2/WebKit2.pri.
  26191. * qmake/mkspecs/features/win32/default_post.prf: Added.
  26192. * qmake/qt_webkit.pri: Renamed from Source/WebKit/qt/qt_webkit_version.pri.
  26193. * qmake/syncqt-4.8: Added.
  26194. (showUsage):
  26195. ():
  26196. (copyFile):
  26197. (symlinkFile):
  26198. 2011-11-04 Eric Seidel <eric@webkit.org>
  26199. Remove deprecated free functions in port.factory
  26200. https://bugs.webkit.org/show_bug.cgi?id=71494
  26201. Unreviewed. Fixing exception seen when running test-webkitpy.
  26202. Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
  26203. unittest, since that script is nearly ready to be deleted. But I added
  26204. it back at the last second and failed to run the tests. :(
  26205. This fixes the exception the bots were seeing.
  26206. * Scripts/webkitpy/style/checkers/test_expectations.py:
  26207. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  26208. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  26209. 2011-11-02 Xiaomei Ji <xji@chromium.org>
  26210. Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
  26211. https://bugs.webkit.org/show_bug.cgi?id=71163
  26212. Reviewed by Ryosuke Niwa.
  26213. * DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
  26214. (WebPreferences::applyTo):
  26215. 2011-11-03 Eric Seidel <eric@webkit.org>
  26216. Remove deprecated free functions in port.factory
  26217. https://bugs.webkit.org/show_bug.cgi?id=71494
  26218. Reviewed by Adam Barth.
  26219. I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
  26220. free functions in factory.py. To remove these required fixing all callsites
  26221. to use MockHost, Host, or PortFactory where appropriate. After this change
  26222. we're only left with a handfull of places where we inappropraitely use a
  26223. real Executive, FileSystem or User object during unittesting.
  26224. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  26225. - These PortFactory overrides were from an earlier edition of my previous patch
  26226. in the end, I removed MockPortFactory so all tests ended up with this same
  26227. real PortFactory() with a MockHost. This was simply redundent code.
  26228. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  26229. - Use MockHost to get a mocked-out PortFactory.
  26230. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  26231. - This code has no access to a Host object, so we just use a default PortFactory
  26232. for now. This will still incorrectly create real Executive/FileSystem objects
  26233. durring unittesting, which is wrong. :(
  26234. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  26235. - Use a MockHost to get a mocked PortFactory.
  26236. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  26237. - Use a MockHost to get a mocked PortFactory.
  26238. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  26239. - ditto.
  26240. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  26241. - ditto.
  26242. * Scripts/webkitpy/layout_tests/port/__init__.py:
  26243. - factory.get no longer exists. Yay!
  26244. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  26245. - Use a MockHost to get a mocked PortFactory.
  26246. To do this efficiently, I created a helper function
  26247. and combined all these (mostly redundant) tests into one test
  26248. with several calls to the helper function.
  26249. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  26250. - Pass MockUser and MockExecutive in these port testing subclasses.
  26251. - I also removed a bunch of unecessary uses of mocktool. namespacing.
  26252. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  26253. - Awesome windows hacks should only happen on win32. Once we started
  26254. using MockExecutives these 'svn help' commands started printing in
  26255. other tests, which is how I found this bug.
  26256. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  26257. - DryRunPort has no Host, so just use a PortFactory() directly.
  26258. This will do the wrong thing if we're unittesting the DryRun port
  26259. but it's no worse than the existing code.
  26260. * Scripts/webkitpy/layout_tests/port/factory.py:
  26261. - Remove the free functions.
  26262. - Fix argument overriding to be able to override None.
  26263. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  26264. - Use a mocked-out PortFactory during testing.
  26265. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  26266. - Pass MockExecutive and MockUser to these manual Port instantiations.
  26267. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  26268. - No access to a Host object here, so just using PortFactory directly.
  26269. This is wrong, but no more wrong than the existing code was.
  26270. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  26271. - Use a MockHost to get a mocked out PortFactory.
  26272. * Scripts/webkitpy/layout_tests/port/test.py:
  26273. - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
  26274. * Scripts/webkitpy/layout_tests/port/win.py:
  26275. - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
  26276. now that we're actually passing MockExecutive to most Port instantiations during testing.
  26277. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  26278. - Pass our new "unittesting" bool to _detect_version when actually unittesting.
  26279. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  26280. - Host is the future.
  26281. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  26282. - Use a MockHost to get a mocked out PortFactory. Once we have a mocked PortFactory
  26283. we don't need to pass MockUser explicitly, it does that automatically for us.
  26284. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  26285. - Use a MockHost to get a mocked out PortFactory.
  26286. * Scripts/webkitpy/style/checkers/test_expectations.py:
  26287. - We don't have access to a Host object, so using PortFactory() directly.
  26288. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  26289. - Remove unused variable.
  26290. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  26291. - Host isn't accessible here, so using PortFactory() directly, which
  26292. although unfortunate is no worse than before.
  26293. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  26294. - Testing is much easier when you don't need to hack global state...
  26295. * Scripts/webkitpy/tool/commands/expectations.py:
  26296. - Use the port_factory on the tool.
  26297. * Scripts/webkitpy/tool/commands/rebaseline.py:
  26298. - ditto.
  26299. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  26300. - This unittest was wrong. It was trying to pass the tool object, but failing to pass
  26301. the arguments in the right order. Fixing that made it use a MockFileSystem
  26302. (like it had been trying to), which then required us to actually populate
  26303. that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
  26304. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  26305. - Get the port_factory from the tool.
  26306. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  26307. - Ditto.
  26308. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  26309. - Use a MockHost to get a mocked out Port object.
  26310. 2011-11-03 Raphael Kubo da Costa <kubo@profusion.mobi>
  26311. [EFL] DRT: Allow choosing which backing store to use.
  26312. https://bugs.webkit.org/show_bug.cgi?id=70532
  26313. Reviewed by Antonio Gomes.
  26314. This change makes it possible to change the backing store used by DRT
  26315. from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
  26316. setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.
  26317. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  26318. (DumpRenderTreeChrome::createView):
  26319. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  26320. (shouldUseSingleBackingStore):
  26321. (chooseAndInitializeAppropriateSmartClass):
  26322. (drtViewAdd):
  26323. * DumpRenderTree/efl/DumpRenderTreeView.h:
  26324. 2011-11-02 Erik Arvidsson <arv@chromium.org>
  26325. JS Test Harness: Remove more link tags
  26326. https://bugs.webkit.org/show_bug.cgi?id=71339
  26327. Reviewed by Ojan Vafai.
  26328. * Scripts/make-new-script-test:
  26329. (writeTestFile): Don't output <link>
  26330. 2011-11-03 Thouraya ANDOLSI <thouraya.andolsi@st.com>
  26331. Reviewed by Martin Robinson.
  26332. [GTK] arguments passed to build-jsc are not taken into account
  26333. https://bugs.webkit.org/show_bug.cgi?id=58333
  26334. * Scripts/build-jsc:
  26335. 2011-11-03 Carlos Garcia Campos <cgarcia@igalia.com>
  26336. [GTK] Show url of history items in a status bar in MiniBrowser
  26337. https://bugs.webkit.org/show_bug.cgi?id=71474
  26338. Reviewed by Martin Robinson.
  26339. * MiniBrowser/gtk/BrowserWindow.c:
  26340. (browserWindowSetStatusText): Set status text and show/hide the
  26341. status label.
  26342. (resetStatusText): Reset status text when history menu is hidden.
  26343. (browserWindowHistoryItemSelected): Show url of currently selected
  26344. history item.
  26345. (browserWindowCreateBackForwardMenu): Connect to hide signal of
  26346. menu to reset the status text.
  26347. (browserWindowConstructed): Use GtkOverlay if available to show
  26348. status text.
  26349. 2011-11-03 Carlos Garcia Campos <cgarcia@igalia.com>
  26350. [GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
  26351. https://bugs.webkit.org/show_bug.cgi?id=71466
  26352. Reviewed by Martin Robinson.
  26353. * MiniBrowser/gtk/BrowserWindow.c:
  26354. (browserWindowHistoryItemActivated): Go to selected back formard
  26355. list item using webkit_web_view_go_to_back_forward_list_item()
  26356. (browserWindowCreateBackForwardMenu): Create a GtkMenu for the
  26357. given GList of WebKitBackForwardListItems.
  26358. (browserWindowUpdateNavigationActions): Enable/disable back and
  26359. forward buttons depending on whether it's possible to go
  26360. back/forward. Create a menu for back and forward toolbar buttons.
  26361. (backForwadlistChanged): Call browserWindowUpdateNavigationActions().
  26362. (browserWindowConstructed): Connect to WebKitBackForwardList
  26363. changed signal.
  26364. 2011-11-03 Simon Hausmann <simon.hausmann@nokia.com>
  26365. [Qt] Remove Maemo specific code paths
  26366. https://bugs.webkit.org/show_bug.cgi?id=71476
  26367. Reviewed by Kenneth Rohde Christiansen.
  26368. * QtTestBrowser/launcherwindow.cpp:
  26369. (LauncherWindow::~LauncherWindow):
  26370. (LauncherWindow::init):
  26371. (LauncherWindow::showLinkHover):
  26372. (LauncherWindow::selectElements):
  26373. (LauncherWindow::showFPS):
  26374. (LauncherWindow::updateFPS):
  26375. * QtTestBrowser/launcherwindow.h:
  26376. (WindowOptions::WindowOptions):
  26377. * QtTestBrowser/locationedit.cpp:
  26378. * QtTestBrowser/locationedit.h:
  26379. 2011-11-03 Carlos Garcia Campos <cgarcia@igalia.com>
  26380. [GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
  26381. https://bugs.webkit.org/show_bug.cgi?id=71461
  26382. Reviewed by Martin Robinson.
  26383. * MiniBrowser/gtk/BrowserWindow.c:
  26384. (resetEntryProgress): Reset the entry progress after a while when
  26385. load has been completed.
  26386. (webViewLoadProgressChanged): Update location entry progress.
  26387. (browserWindowConstructed): Connect to WebView
  26388. notify::estimated-load-progress signal.
  26389. 2011-11-03 Carlos Garcia Campos <cgarcia@igalia.com>
  26390. [GTK] Remove WebKit2 C API from MiniBrowser
  26391. https://bugs.webkit.org/show_bug.cgi?id=71459
  26392. Reviewed by Martin Robinson.
  26393. Use the GTK+ API instead to add minimum functionality. The other
  26394. features will be ported to GTK+ API in following patches.
  26395. * MiniBrowser/gtk/BrowserWindow.c:
  26396. (activateUriEntryCallback): Use webkit_web_view_load_uri().
  26397. (goBackCallback): Use webkit_web_view_go_back().
  26398. (goForwardCallback): Use webkit_web_view_go_forward().
  26399. (webViewURIChanged): Update location entry with current uri using
  26400. webkit_web_view_get_uri().
  26401. (browserWindowFinalize):
  26402. (browserWindowGetProperty):
  26403. (browserWindowSetProperty):
  26404. (browser_window_init):
  26405. (browserWindowConstructed): Connect to notify::uri signal of
  26406. WebView to be notified when the URI changes.
  26407. (browser_window_class_init):
  26408. (browser_window_new): Use WebKitWebView.
  26409. (browser_window_get_view): Use WebKitWebView
  26410. * MiniBrowser/gtk/BrowserWindow.h:
  26411. * MiniBrowser/gtk/GNUmakefile.am:
  26412. * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
  26413. * MiniBrowser/gtk/main.c:
  26414. (loadURI): Use webkit_web_view_new().
  26415. (main):
  26416. 2011-11-03 Simon Hausmann <simon.hausmann@nokia.com>
  26417. [Qt] Unable to start MiniBrowser after run-webkit-tests
  26418. https://bugs.webkit.org/show_bug.cgi?id=71469
  26419. Reviewed by Csaba Osztrogonác.
  26420. * Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
  26421. from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
  26422. line arguments.
  26423. 2011-11-03 Philippe Normand <pnormand@igalia.com>
  26424. [GTK] [WK2] ttf-liberation fonts moved to a new location (in Debian)
  26425. https://bugs.webkit.org/show_bug.cgi?id=71445
  26426. Reviewed by Martin Robinson.
  26427. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  26428. (initializeFonts): set directoriesDescription only when needed.
  26429. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  26430. (WTR::inititializeFontConfigSetting): Add the new font path for Debian fonts and
  26431. refactored the font files loading code to avoid copy/pastes, ease
  26432. maintenance and future font directories additions.
  26433. 2011-11-03 Carlos Garcia Campos <cgarcia@igalia.com>
  26434. [GTK] Remove GtkLauncher2
  26435. https://bugs.webkit.org/show_bug.cgi?id=71449
  26436. Reviewed by Martin Robinson.
  26437. GtkLauncher2 is the GtkLauncher code compiled with webkit2. This
  26438. made sense when we wanted to implement the exactly same wk1 API
  26439. for wk2. Now the code would require an ifdef for most the api, so
  26440. it's better to remove GtkLauncher2 and port MiniBrowser to the new
  26441. GTK+ API.
  26442. * GNUmakefile.am:
  26443. * GtkLauncher/main.c:
  26444. (notifyProgressCb):
  26445. (closeWebViewCb):
  26446. (createBrowser):
  26447. (addWebSettingsGroupToContext):
  26448. (main):
  26449. 2011-11-02 Philippe Normand <pnormand@igalia.com>
  26450. [GTK] [DRT] ttf-liberation fonts moved to a new location (in Debian)
  26451. https://bugs.webkit.org/show_bug.cgi?id=71359
  26452. Reviewed by Martin Robinson.
  26453. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  26454. (initializeFonts): Add the new font path for Debian fonts and
  26455. refactored the font files loading code to avoid copy/pastes, ease
  26456. maintenance and future font directories additions.
  26457. 2011-11-02 Eric Seidel <eric@webkit.org>
  26458. Move Mocks into _mock files near their implementations
  26459. https://bugs.webkit.org/show_bug.cgi?id=71425
  26460. Reviewed by Adam Barth.
  26461. This entire change is splitting mocktool.py into separate _mock.py files
  26462. and placing them next to their real implementations.
  26463. I also deleted MockPortFactory (since it was wrong) and was just hiding
  26464. the fact that the "skipped-ports" command was broken (and has been for a long time).
  26465. So I made MockHost use a real PortFactory (passed a MockHost) and changed
  26466. the skipped-ports implementation to use modern PortFactory methods.
  26467. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  26468. * Scripts/webkitpy/common/checkout/checkout_mock.py: Added.
  26469. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  26470. * Scripts/webkitpy/common/checkout/deps_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
  26471. * Scripts/webkitpy/common/checkout/scm/scm_mock.py: Added.
  26472. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  26473. * Scripts/webkitpy/common/config/ports_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  26474. * Scripts/webkitpy/common/host.py:
  26475. * Scripts/webkitpy/common/host_mock.py: Added.
  26476. * Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py: Added.
  26477. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  26478. * Scripts/webkitpy/common/net/buildbot/buildbot_mock.py: Added.
  26479. * Scripts/webkitpy/common/net/credentials_unittest.py:
  26480. * Scripts/webkitpy/common/net/failuremap_unittest.py:
  26481. * Scripts/webkitpy/common/net/irc/irc_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
  26482. * Scripts/webkitpy/common/net/statusserver_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  26483. * Scripts/webkitpy/common/net/statusserver_unittest.py:
  26484. * Scripts/webkitpy/common/net/web_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  26485. * Scripts/webkitpy/common/system/executive.py:
  26486. * Scripts/webkitpy/common/system/executive_mock.py:
  26487. * Scripts/webkitpy/common/system/platforminfo_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
  26488. * Scripts/webkitpy/common/system/user_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/gtk_unittest.py.
  26489. * Scripts/webkitpy/common/system/workspace_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
  26490. * Scripts/webkitpy/common/system/workspace_unittest.py:
  26491. * Scripts/webkitpy/common/watchlist/watchlist_mock.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/__init__.py.
  26492. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  26493. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
  26494. * Scripts/webkitpy/layout_tests/port/__init__.py:
  26495. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  26496. * Scripts/webkitpy/layout_tests/port/efl_unittest.py:
  26497. * Scripts/webkitpy/layout_tests/port/factory.py:
  26498. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  26499. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  26500. * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  26501. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  26502. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  26503. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  26504. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  26505. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  26506. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  26507. * Scripts/webkitpy/test/main.py:
  26508. * Scripts/webkitpy/tool/bot/botinfo_unittest.py:
  26509. * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  26510. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  26511. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  26512. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  26513. * Scripts/webkitpy/tool/mocktool.py:
  26514. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  26515. 2011-11-02 Dan Bernstein <mitz@apple.com>
  26516. Fixed the build and removed another copy to ColorBits.ttf.
  26517. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  26518. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  26519. * WebKitTestRunner/fonts/ColorBits.ttf: Removed.
  26520. 2011-11-02 Dan Bernstein <mitz@apple.com>
  26521. REGRESSION (r98759-r98773): platform/mac/fonts/color-bitmap.html failing on Lion Intel Debug (Tests)
  26522. https://bugs.webkit.org/show_bug.cgi?id=71424
  26523. Reviewed by Sam Weinig.
  26524. Removed the ColorBits font and the code to register it in the process
  26525. running the tests. The font was only used by the aforementioned test,
  26526. which is now being removed.
  26527. * DumpRenderTree/fonts/ColorBits-A.png: Removed.
  26528. * DumpRenderTree/fonts/ColorBits.ttf: Removed.
  26529. * DumpRenderTree/mac/DumpRenderTree.mm:
  26530. (allowedFontFamilySet):
  26531. (activateTestingFonts):
  26532. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
  26533. (WTR::inititializeFontConfigSetting):
  26534. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  26535. (WTR::allowedFontFamilySet):
  26536. (WTR::activateFonts):
  26537. 2011-11-02 Dan Bernstein <mitz@apple.com>
  26538. Fix an intermittent hang in RenderedImageFromDOMRange.
  26539. Reviewed by Anders Carlsson.
  26540. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  26541. (TestWebKitAPI::Util::run): Made the call to -runMode:beforeDate: return
  26542. immediately if there are no sources by passing a date in the distant past.
  26543. 2011-11-02 Adam Roben <aroben@apple.com>
  26544. Add git-add-reviewer
  26545. I've been using this script for a while to add reviewers to git commits in my local
  26546. repository before pushing them to the Subversion repository. Basic usage is:
  26547. git-add-reviewer HEAD^ "Joe Schmoe"
  26548. or
  26549. git-add-reviewer -i trunk
  26550. Fixes <http://webkit.org/b/71419> Would like an easy way to add reviewer names to existing
  26551. git commits
  26552. Reviewed by Sam Weinig.
  26553. * Scripts/git-add-reviewer: Added.
  26554. (top level): Parse options, check that the working tree is clean, then run in either
  26555. interactive or non-interactive mode as appropriate.
  26556. (interactive): Write out a temp file that contains each commit with "NOBODY" next to it and
  26557. open it in the user's editor. The user can replace "NOBODY" with reviewer names. When the
  26558. editor exits, we check out the commit just before the earliest one we're modifying. Then
  26559. for each commit, we check it out, update the reviewer, and amend the commit to contain the
  26560. new reviewer. Finally, we update the branch that was originally checked out to point to the
  26561. last amended commit.
  26562. (nonInteractive): Check out the commit to modify, write the current commit message to the
  26563. MERGE_MSG file so addReviewer will update it, add the reviewer to the ChangeLog(s), amend
  26564. the commit, and rebase the original branch on top of the amended commit. (usage): Print out
  26565. a usage message and exit.
  26566. (requireCleanWorkTree): Do the same steps git-rebase does to ensure that the working tree
  26567. and index are clean.
  26568. (fail): Print out the specified error message, if any, and return false. This function is
  26569. used as a return value in various error cases throughout the script.
  26570. (cherryPick): Cherry-pick the specified commit and return 1 if we succeeded.
  26571. (addReviewer): Add the specified reviewer to all the ChangeLogs modified in this commit, and
  26572. to .git/MERGE_MSG, which will be used as the commit message for the next commit.
  26573. (commit): Call git-commit and use .git/MERGE_MSG as the commit message.
  26574. (addReviewerToChangeLog):
  26575. (addReviewerToCommitMessage):
  26576. These just call through to addReviewerToFile.
  26577. (addReviewerToFile): Read in the file, replacing any "NOBODY" text with the reviewer name(s)
  26578. and replacing "Reviewed" with "Rubber-stamped" if specified. Write the resulting text to a
  26579. temp file, then move the temp file over the original file and stage it for the next commit.
  26580. (head): Returns the name of the currently-checked-out branch.
  26581. (isAncestor): Returns true if the first commit is an ancestor of the second.
  26582. (toCommit): Converts a commitish to a commit ID using git-rev-parse.
  26583. (changeLogsForCommit): Returns a list of all the ChangeLogs modified in the given commit.
  26584. (resetToCommit): Checks out the given commit, throwing away any local changes.
  26585. (writeCommitMessageToFile): Gets the commit message for the current commit and writes it to
  26586. the specified file.
  26587. (rebaseOntoHead): Rebases the specified branch onto HEAD.
  26588. (checkout): Checks out the given commit.
  26589. (getConfigValue): Reads the specified config variable from git-config.
  26590. 2011-11-02 Dean Jackson <dino@apple.com>
  26591. Add ENABLE_CSS_SHADERS flag
  26592. https://bugs.webkit.org/show_bug.cgi?id=71394
  26593. Reviewed by Sam Weinig.
  26594. * Scripts/build-webkit:
  26595. 2011-10-31 Eric Seidel <eric@webkit.org>
  26596. BaselineOptimizer tests should use mocks instead of real Executive/FileSystem objects
  26597. https://bugs.webkit.org/show_bug.cgi?id=71237
  26598. Reviewed by Adam Barth.
  26599. Calling the static version of factory.get() with proper mocking
  26600. requires passsing an explict filesystem, executive, etc.
  26601. So instead, we use a PortFactory instance and pass it a Host pointer.
  26602. I had to add a MockHost since we'd not needed a non-host tool before now.
  26603. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  26604. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  26605. * Scripts/webkitpy/tool/commands/rebaseline.py:
  26606. * Scripts/webkitpy/tool/mocktool.py:
  26607. 2011-11-02 Anders Carlsson <andersca@apple.com>
  26608. Update for the WebKit2 API fixage.
  26609. * MiniBrowser/mac/BrowserWindowController.m:
  26610. (-[BrowserWindowController awakeFromNib]):
  26611. * WebKitTestRunner/TestController.cpp:
  26612. (WTR::TestController::initialize):
  26613. 2011-11-02 Anders Carlsson <andersca@apple.com>
  26614. Fix build.
  26615. Add new functions to the page loader client.
  26616. * MiniBrowser/mac/BrowserWindowController.m:
  26617. (-[BrowserWindowController awakeFromNib]):
  26618. * WebKitTestRunner/TestController.cpp:
  26619. (WTR::TestController::initialize):
  26620. 2011-11-02 Dan Bernstein <mitz@apple.com>
  26621. <rdar://problem/10336700> Add API to get rendered text image without having to select it
  26622. https://bugs.webkit.org/show_bug.cgi?id=71407
  26623. Reviewed by Simon Fraser.
  26624. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  26625. * TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm: Added.
  26626. (-[RenderedImageFromDOMRangeFrameLoadDelegate webView:didFinishLoadForFrame:]):
  26627. (TestWebKitAPI::TEST):
  26628. 2011-11-02 Benjamin Poulain <benjamin@webkit.org>
  26629. Make the main frame's base path more explicit in _drt_descriptionSuitableForTestResult
  26630. https://bugs.webkit.org/show_bug.cgi?id=71351
  26631. Reviewed by Darin Adler.
  26632. Add the delimiter "/" at the end of the path instead of adding +1 when using
  26633. the path.
  26634. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  26635. (-[NSURL _drt_descriptionSuitableForTestResult]):
  26636. 2011-11-02 Tom Sepez <tsepez@chromium.org>
  26637. XSSAuditor is silent
  26638. https://bugs.webkit.org/show_bug.cgi?id=70973
  26639. Reviewed by Adam Barth.
  26640. * DumpRenderTree/chromium/WebViewHost.cpp:
  26641. (WebViewHost::didDetectXSS):
  26642. * DumpRenderTree/chromium/WebViewHost.h:
  26643. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  26644. (-[FrameLoadDelegate webView:didDetectXSS:]):
  26645. * MiniBrowser/mac/BrowserWindowController.m:
  26646. (didDetectXSSForFrame):
  26647. (-[BrowserWindowController awakeFromNib]):
  26648. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  26649. (WTR::InjectedBundlePage::InjectedBundlePage):
  26650. (WTR::InjectedBundlePage::didDetectXSSForFrame):
  26651. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  26652. 2011-11-02 Simon Hausmann <simon.hausmann@nokia.com>
  26653. [Qt] REGRESSION: 5 editing tests fail
  26654. https://bugs.webkit.org/show_bug.cgi?id=71117
  26655. Reviewed by Andreas Kling.
  26656. Make sure that the view is properly focused, in order to get the
  26657. didBeginEditing DRT calls.
  26658. This requires activating the window (the call will result in a FocusIn
  26659. event to the window as well as setting QGuiApplication::focusWindow())
  26660. as well as enabling the focus on the view item. The signature of
  26661. setFocus has changed to take a boolean.
  26662. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  26663. (WTR::WrapperWindow::handleStatusChanged):
  26664. 2011-11-02 Matt Falkenhagen <falken@chromium.org>
  26665. [chromium] Add per-script font preferences support in overridePreference
  26666. https://bugs.webkit.org/show_bug.cgi?id=71110
  26667. This allows a layout test to do something like:
  26668. // Set standard font for Arabic to Ahem.
  26669. overridePreference("WebKitStandardFontMap", [ "Arab", "Ahem" ]);
  26670. This should make writing a layout test for per-script fonts easier.
  26671. This change only affects the Chromium DumpRenderTree, but the other
  26672. platforms should probably also have a similar change eventually.
  26673. Reviewed by Tony Chang.
  26674. * DumpRenderTree/chromium/LayoutTestController.cpp: add per-script
  26675. font preferences to overridePreference
  26676. (LayoutTestController::cppVariantToWebStringArray):
  26677. (setFontMap):
  26678. (LayoutTestController::overridePreference):
  26679. * DumpRenderTree/chromium/LayoutTestController.h:
  26680. * DumpRenderTree/chromium/WebPreferences.cpp:
  26681. (setStandardFontFamilyWrapper):
  26682. (setFixedFontFamilyWrapper):
  26683. (setSerifFontFamilyWrapper):
  26684. (setSansSerifFontFamilyWrapper):
  26685. (setCursiveFontFamilyWrapper):
  26686. (setFantasyFontFamilyWrapper):
  26687. (applyFontMap):
  26688. (WebPreferences::applyTo):
  26689. * DumpRenderTree/chromium/WebPreferences.h: add per-script font
  26690. preference members
  26691. (WebPreferences::UScriptCodeHashTraits::emptyValue):
  26692. (WebPreferences::UScriptCodeHashTraits::constructDeletedValue):
  26693. (WebPreferences::UScriptCodeHashTraits::isDeletedValue):
  26694. 2011-11-02 Elliot Poger <epoger@google.com>
  26695. until use_skia=1 by default on mac, default port should be chromium-cg-mac
  26696. https://bugs.webkit.org/show_bug.cgi?id=71312
  26697. Reviewed by Adam Barth.
  26698. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  26699. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  26700. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  26701. 2011-11-02 Stephen Chenney <schenney@chromium.org>
  26702. printing layout test failures after r98634
  26703. https://bugs.webkit.org/show_bug.cgi?id=71080
  26704. Reviewed by Kent Tamura
  26705. * DumpRenderTree/chromium/WebViewHost.cpp:
  26706. (WebViewHost::paintPagesWithBoundaries): Added transforms invert the CG Bitmap so the coord system
  26707. matches that for Skia.
  26708. 2011-11-01 Sam Weinig <sam@webkit.org>
  26709. Can't complete ChangeLog when using resolve-Changelogs and webkit-tools-completion.sh
  26710. https://bugs.webkit.org/show_bug.cgi?id=71346
  26711. Reviewed by Dan Bernstein.
  26712. * Scripts/webkit-tools-completion.sh:
  26713. Add "-o default" which allows for completing files in addition to the word list.
  26714. 2011-11-02 Simon Hausmann <simon.hausmann@nokia.com>
  26715. [Qt][WK2] Add support for touch event testing to WebKitTestRunner
  26716. https://bugs.webkit.org/show_bug.cgi?id=71310
  26717. Reviewed by Kenneth Rohde Christiansen.
  26718. * WebKitTestRunner/DerivedSources.pro: Build system foo to ensure the ENABLE_TOUCH_EVENTS
  26719. define works in EventSendingController.idl
  26720. * WebKitTestRunner/EventSenderProxy.h: Add declarations for Qt implementations of touch
  26721. handlers.
  26722. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl: Add touch functions
  26723. required by tests.
  26724. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp: Forward touch messages to the
  26725. ui process.
  26726. (WTR::EventSendingController::addTouchPoint):
  26727. (WTR::EventSendingController::updateTouchPoint):
  26728. (WTR::EventSendingController::setTouchModifier):
  26729. (WTR::EventSendingController::touchStart):
  26730. (WTR::EventSendingController::touchMove):
  26731. (WTR::EventSendingController::touchEnd):
  26732. (WTR::EventSendingController::clearTouchPoints):
  26733. (WTR::EventSendingController::releaseTouchPoint):
  26734. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  26735. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Include features.pri for feature
  26736. defines.
  26737. * WebKitTestRunner/TestController.cpp:
  26738. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle): Forward incoming
  26739. touch messages to the EventSenderProxy.
  26740. * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Implement touch test harness functions.
  26741. (WTR::EventSenderProxy::EventSenderProxy):
  26742. (WTR::EventSenderProxy::addTouchPoint):
  26743. (WTR::EventSenderProxy::updateTouchPoint):
  26744. (WTR::EventSenderProxy::setTouchModifier):
  26745. (WTR::EventSenderProxy::touchStart):
  26746. (WTR::EventSenderProxy::touchMove):
  26747. (WTR::EventSenderProxy::touchEnd):
  26748. (WTR::EventSenderProxy::clearTouchPoints):
  26749. (WTR::EventSenderProxy::releaseTouchPoint):
  26750. (WTR::EventSenderProxy::sendTouchEvent):
  26751. * WebKitTestRunner/qt/WebKitTestRunner.pro: Include features.pri for feature defines.
  26752. 2011-11-01 Sam Weinig <sam@webkit.org>
  26753. resolve-ChangeLogs --help should be faster.
  26754. Reviewed by Adam Roben.
  26755. * Scripts/resolve-ChangeLogs:
  26756. (usageAndExit):
  26757. Add a call to usageAndExit() before doing work to find unmerged changelogs
  26758. if --help or something illegal is provided on the command line.
  26759. 2011-11-01 Benjamin Poulain <bpoulain@apple.com>
  26760. [Mac] _drt_descriptionSuitableForTestResult generate an exception for absolute paths above the main frame
  26761. https://bugs.webkit.org/show_bug.cgi?id=71342
  26762. Reviewed by Darin Adler.
  26763. [NSURL _drt_descriptionSuitableForTestResult] was generating a NSRangeException due to the call to
  26764. [NSString substringFromIndex:] with an index out of the string range.
  26765. The source of this path is the test-loading-archive-subresource-null-mimetype.html which load a subresource
  26766. from the root of the disk.
  26767. The problem was hidden because the exception are catched when calling the delegate.
  26768. This patch changes _drt_descriptionSuitableForTestResult to return absolute string if the resource is not
  26769. in a subdirectory of the main frame.
  26770. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  26771. (-[NSURL _drt_descriptionSuitableForTestResult]):
  26772. 2011-11-01 Alok Priyadarshi <alokp@chromium.org>
  26773. [chromium] --enable-hardware-gpu flag is not recognized by run-webkit-tests
  26774. https://bugs.webkit.org/show_bug.cgi?id=71318
  26775. Reviewed by James Robinson.
  26776. Fixed a typo for --enable-hardware-gpu flag.
  26777. * Scripts/webkitpy/layout_tests/port/chromium.py:
  26778. 2011-11-01 Elliot Poger <epoger@google.com>
  26779. chromium-gpu port should default to chromium-gpu-mac, not chromium-gpu-cg-mac
  26780. https://bugs.webkit.org/show_bug.cgi?id=71286
  26781. Reviewed by Stephen White.
  26782. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  26783. 2011-11-01 Simon Hausmann <simon.hausmann@nokia.com>
  26784. [Qt][WK2] Fix build of WebKitTestRunner with ELF symbol visibility
  26785. https://bugs.webkit.org/show_bug.cgi?id=71299
  26786. Reviewed by Andreas Kling.
  26787. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp: Use the properly exported symbol for the Qt
  26788. build to enable WebCoreTestSupport::injectInternalsObject.
  26789. (WTR::InjectedBundlePage::didClearWindowForFrame):
  26790. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Fix include path to DRTSupportQt
  26791. 2011-11-01 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  26792. [Qt] Merge common desktop and touch view APIs under a base class.
  26793. https://bugs.webkit.org/show_bug.cgi?id=71280
  26794. Reviewed by Andreas Kling.
  26795. Remove unneded forwarding logic for TouchWebView since those properties are
  26796. now in the view just as the desktop web view.
  26797. * MiniBrowser/qt/qml/TouchView.qml:
  26798. 2011-11-01 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  26799. check-webkit-style: Allow names starting with "_q_".
  26800. https://bugs.webkit.org/show_bug.cgi?id=70625
  26801. Reviewed by Tor Arne Vestbø.
  26802. Used by the Qt port as the standard prefix for private slots.
  26803. * Scripts/webkitpy/style/checkers/cpp.py:
  26804. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  26805. 2011-11-01 Simon Hausmann <simon.hausmann@nokia.com>
  26806. [Qt][WK2] Fix valgrind error about uninitialized variable
  26807. https://bugs.webkit.org/show_bug.cgi?id=71273
  26808. Reviewed by Kenneth Christiansen.
  26809. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  26810. (MiniBrowserApplication::notify): Initialize isPrimary.
  26811. 2011-10-31 Adam Roben <aroben@apple.com>
  26812. Make Leaks Viewer less strict when parsing leaks-related output from NRWT/ORWT
  26813. Fixes <http://webkit.org/b/71258> REGRESSION (r98639): Leaks Viewer doesn't show recent
  26814. leaky builds
  26815. Reviewed by Anders Carlsson.
  26816. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  26817. (RecentBuildsLoader.prototype.start): Relax a regex to gloss over differences in ORWT's vs.
  26818. NRWT's leaks-related output (i.e., "M total leaks found!" vs. "M total leaks found for a
  26819. total of N bytes!").
  26820. 2011-10-31 Raphael Kubo da Costa <kubo@profusion.mobi>
  26821. [EFL] Rename ewk_view_setting_scripts_window_open_{get,set} after r93833
  26822. https://bugs.webkit.org/show_bug.cgi?id=71228
  26823. Reviewed by Antonio Gomes.
  26824. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  26825. (DumpRenderTreeChrome::createNewWindow):
  26826. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  26827. 2011-10-31 Eric Seidel <eric@webkit.org>
  26828. webkitpy tests depend too much on the user's environment
  26829. https://bugs.webkit.org/show_bug.cgi?id=71234
  26830. Reviewed by Dirk Pranke.
  26831. This change just makes a bunch of our older tests use
  26832. more modern mocking to avoid trying to launch processes
  26833. or read from the user's filesystem during unittesting.
  26834. I found many of these by adding an assert in Executive.run_command
  26835. that we were not unittesting. I can't add that assert always
  26836. as there are some valid uses of Executive during unittesting.
  26837. Once I fix more of these, I may find a way to add such an assert conditionally.
  26838. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  26839. * Scripts/webkitpy/common/net/credentials_unittest.py:
  26840. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  26841. * Scripts/webkitpy/layout_tests/port/base.py:
  26842. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  26843. 2011-10-31 Kenneth Rohde Christiansen <kenneth@webkit.org>
  26844. [Qt] MiniBrowser doesn't resize as the size is always overridden
  26845. https://bugs.webkit.org/show_bug.cgi?id=71212
  26846. Reviewed by Simon Hausmann.
  26847. Remove call overriden the size.
  26848. * MiniBrowser/qt/main.cpp:
  26849. (main):
  26850. 2011-10-30 Sheriff Bot <webkit.review.bot@gmail.com>
  26851. Unreviewed, rolling out r98819, r98823, r98825, and r98830.
  26852. http://trac.webkit.org/changeset/98819
  26853. http://trac.webkit.org/changeset/98823
  26854. http://trac.webkit.org/changeset/98825
  26855. http://trac.webkit.org/changeset/98830
  26856. https://bugs.webkit.org/show_bug.cgi?id=71199
  26857. Broke Chromium Windows bot (Requested by rniwa on #webkit).
  26858. * Scripts/webkitpy/layout_tests/port/base.py:
  26859. * Scripts/webkitpy/layout_tests/port/chromium.py:
  26860. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  26861. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  26862. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  26863. * Scripts/webkitpy/layout_tests/port/efl.py:
  26864. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  26865. * Scripts/webkitpy/layout_tests/port/mac.py:
  26866. * Scripts/webkitpy/layout_tests/port/qt.py:
  26867. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  26868. * Scripts/webkitpy/layout_tests/port/webkit.py:
  26869. * Scripts/webkitpy/layout_tests/port/win.py:
  26870. 2011-10-30 Eric Seidel <eric@webkit.org>
  26871. new-run-webkit-tests is locale dependent
  26872. https://bugs.webkit.org/show_bug.cgi?id=68691
  26873. Unreviewed.
  26874. This is a temporary hack until someone from the cr-win port
  26875. can take a look and determine which environment variable
  26876. lighttpd is missing.
  26877. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  26878. 2011-10-30 Eric Seidel <eric@webkit.org>
  26879. new-run-webkit-tests is locale dependent
  26880. https://bugs.webkit.org/show_bug.cgi?id=68691
  26881. Unreviewed. I would have preferred to have this reviewed,
  26882. but relevant reviewers are asleep and bots are broken.
  26883. This was a regression from moving to a clean environment.
  26884. ChromiumWin (and possibly other ports), need the "PATH"
  26885. environment copied over. This wasn't caught in my testing
  26886. because although we had unittests to cover this, they
  26887. weren't being run on anything but windows. The vast majority
  26888. of this change is just fixing the unittests to use our
  26889. modern MockFileSystem/MockUser/MockExecutive so they can
  26890. be run on any system (and removing the platform checks from
  26891. the unittests so they are run everywhere).
  26892. The actual fix is the single line "PATH" string added to base.py.
  26893. The rest of this change is just fixing the Chromium port unittests
  26894. to run on all systems (including changing the Chromium port to
  26895. use FileSystem.path_to_module instead of __file__).
  26896. * Scripts/webkitpy/layout_tests/port/base.py:
  26897. * Scripts/webkitpy/layout_tests/port/chromium.py:
  26898. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  26899. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  26900. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  26901. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  26902. 2011-10-29 Eric Seidel <eric@webkit.org>
  26903. new-run-webkit-tests is locale dependent
  26904. https://bugs.webkit.org/show_bug.cgi?id=68691
  26905. Unreviewed.
  26906. Fix the Qt port and unittest the function so we don't break it again.
  26907. * Scripts/webkitpy/layout_tests/port/qt.py:
  26908. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  26909. 2011-10-29 Eric Seidel <eric@webkit.org>
  26910. new-run-webkit-tests is locale dependent
  26911. https://bugs.webkit.org/show_bug.cgi?id=68691
  26912. Reviewed by Adam Barth.
  26913. Make NRWT use a clean environment just like ORWT did.
  26914. I've manually validated that NRWT now copies over
  26915. the same environment variables that ORWT did.
  26916. This new code is exercised by existing setup_environ_for_server tests.
  26917. * Scripts/webkitpy/layout_tests/port/base.py:
  26918. * Scripts/webkitpy/layout_tests/port/efl.py:
  26919. * Scripts/webkitpy/layout_tests/port/mac.py:
  26920. * Scripts/webkitpy/layout_tests/port/qt.py:
  26921. * Scripts/webkitpy/layout_tests/port/webkit.py:
  26922. * Scripts/webkitpy/layout_tests/port/win.py:
  26923. 2011-10-29 Eric Seidel <eric@webkit.org>
  26924. new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
  26925. https://bugs.webkit.org/show_bug.cgi?id=34984
  26926. Reviewed by Adam Barth.
  26927. Move run-webkit-tests from using a white-list of supported NRWT ports
  26928. to a blacklist of ports requiring ORWT.
  26929. I've also added the ability to opt-in to parallel testing on a per-port basis.
  26930. With these changes I'm going to officially declare this bug dead and
  26931. work on remaining polish issues and individual developer complaints.
  26932. * Scripts/run-webkit-tests:
  26933. (useNewRunWebKitTests):
  26934. (platformIsReadyForParallelTesting):
  26935. 2011-10-29 Sheriff Bot <webkit.review.bot@gmail.com>
  26936. Unreviewed, rolling out r98780.
  26937. http://trac.webkit.org/changeset/98780
  26938. https://bugs.webkit.org/show_bug.cgi?id=71173
  26939. Broke Qt bots (Requested by rniwa on #webkit).
  26940. * Scripts/run-webkit-tests:
  26941. (useNewRunWebKitTests):
  26942. 2011-10-28 Rafael Weinstein <rafaelw@chromium.org>
  26943. webkit.py gdb visualizer is broken after change to StringImpl
  26944. https://bugs.webkit.org/show_bug.cgi?id=71154
  26945. Reviewed by Tony Chang.
  26946. r98624 changed StringImpl m_data to m_data32. This changes updates
  26947. webkit.py to match.
  26948. * gdb/webkit.py:
  26949. 2011-10-28 Joseph Pecoraro <pecoraro@apple.com>
  26950. Fix typo in check-for-inappropriate-objc-class-names
  26951. https://bugs.webkit.org/show_bug.cgi?id=71144
  26952. Reviewed by Dan Bernstein.
  26953. * Scripts/check-for-inappropriate-objc-class-names:
  26954. 2011-10-28 Sadrul Habib Chowdhury <sadrul@chromium.org>
  26955. Add support for sending scroll-update events from EventSender.
  26956. https://bugs.webkit.org/show_bug.cgi?id=66272
  26957. Reviewed by Adam Barth.
  26958. * DumpRenderTree/chromium/EventSender.cpp:
  26959. (EventSender::EventSender):
  26960. (EventSender::reset):
  26961. (EventSender::gestureScrollUpdate):
  26962. (EventSender::gestureEvent):
  26963. * DumpRenderTree/chromium/EventSender.h:
  26964. 2011-10-28 Eric Seidel <eric@webkit.org>
  26965. new-run-webkit-tests: MASTER BUG: Switch all webkit.org bots over
  26966. https://bugs.webkit.org/show_bug.cgi?id=34984
  26967. Reviewed by Adam Barth.
  26968. Move run-webkit-tests from using a white-list of supported NRWT ports
  26969. to a blacklist of ports requiring ORWT.
  26970. I've also added the ability to opt-in to parallel testing on a per-port basis.
  26971. With these changes I'm going to officially declare this bug dead and
  26972. work on remaining polish issues and individual developer complaints.
  26973. * Scripts/run-webkit-tests:
  26974. (useNewRunWebKitTests):
  26975. (platformIsReadyForParallelTesting):
  26976. 2011-10-28 Eric Seidel <eric@webkit.org>
  26977. NRWT crashes when parsing leaks output due to UTF-8 decoding error
  26978. https://bugs.webkit.org/show_bug.cgi?id=71112
  26979. Reviewed by Adam Barth.
  26980. Use read_binary_file instead of read_text_file and add a test
  26981. case with some non-utf8 data to make sure we don't break this in the future.
  26982. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  26983. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  26984. 2011-10-28 David Levin <levin@chromium.org>
  26985. watchlist should not CC the bug reporter
  26986. https://bugs.webkit.org/show_bug.cgi?id=71079
  26987. Reviewed by Adam Barth.
  26988. Tested by test_apply_watch_list_local (webkitpy.tool.steps.applywatchlist_unittest.ApplyWatchListTest)
  26989. which remains upchanged and thus verifies that the reporter doesn't get added to the cc line.
  26990. * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Add the new email in the output.
  26991. * Scripts/webkitpy/tool/mocktool.py: Change the reporter and make them one of the people to cc.
  26992. * Scripts/webkitpy/tool/steps/applywatchlist.py: Remove the reporter from the cc list.
  26993. 2011-10-28 Zoltan Horvath <zoltan@webkit.org>
  26994. Add watchlist for QtWebKit2 API and for WK2's Qt specific files.
  26995. https://bugs.webkit.org/show_bug.cgi?id=71116
  26996. Reviewed by David Levin.
  26997. * Scripts/webkitpy/common/config/watchlist:
  26998. 2011-10-28 Simon Hausmann <simon.hausmann@nokia.com>
  26999. [Qt] Adapt to QSG* to QQuick* API change in qtdeclarative
  27000. https://bugs.webkit.org/show_bug.cgi?id=70494
  27001. Reviewed by Kenneth Christiansen.
  27002. Use QQuick* instead of QSG* as well as QStandardPaths
  27003. instead of QDesktopLocation.
  27004. * MiniBrowser/qt/BrowserWindow.cpp:
  27005. (BrowserWindow::BrowserWindow):
  27006. * MiniBrowser/qt/BrowserWindow.h:
  27007. * QtTestBrowser/cookiejar.cpp:
  27008. (TestBrowserCookieJar::TestBrowserCookieJar):
  27009. * QtTestBrowser/launcherwindow.cpp:
  27010. (LauncherWindow::setDiskCache):
  27011. * WebKitTestRunner/PlatformWebView.h:
  27012. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  27013. (WTR::WrapperWindow::WrapperWindow):
  27014. (WTR::WrapperWindow::handleStatusChanged):
  27015. 2011-10-28 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  27016. [Qt] Fix the Ctrl behavior for touch mocking in MiniBrowser.
  27017. https://bugs.webkit.org/show_bug.cgi?id=71106
  27018. Reviewed by Simon Hausmann.
  27019. Holding Ctrl allows multiple touch points to be held on the screen using
  27020. mouse buttons. It would previously only prevent TouchReleased to be sent
  27021. and would require another MouseButtonRelease to be sent without holding Ctrl.
  27022. This patch makes sure that all held touch points are released when Ctrl
  27023. is released if MouseButtonRelease was received.
  27024. It also removes the touch QEvent::Type logic since it's currently handled
  27025. by QtGui by observing the modified touch points.
  27026. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  27027. (MiniBrowserApplication::notify):
  27028. (MiniBrowserApplication::sendTouchEvent):
  27029. * MiniBrowser/qt/MiniBrowserApplication.h:
  27030. 2011-10-28 Kenneth Rohde Christiansen <kenneth@webkit.org>
  27031. [Qt] MiniBrowser needs a -window-size option
  27032. https://bugs.webkit.org/show_bug.cgi?id=70999
  27033. Reviewed by Simon Hausmann.
  27034. Add an -window-size option useful for testing the viewport handling.
  27035. Also clean up the option handling.
  27036. * MiniBrowser/qt/BrowserWindow.cpp:
  27037. (BrowserWindow::BrowserWindow):
  27038. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  27039. (MiniBrowserApplication::handleUserOptions):
  27040. * MiniBrowser/qt/MiniBrowserApplication.h:
  27041. (WindowOptions::WindowOptions):
  27042. (WindowOptions::setRequestedWindowSize):
  27043. (WindowOptions::requestedWindowSize):
  27044. * MiniBrowser/qt/utils.cpp:
  27045. (takeOptionValue):
  27046. * MiniBrowser/qt/utils.h:
  27047. 2011-10-28 Jochen Eisinger <jochen@chromium.org>
  27048. Add allowScriptFromSource callback to FrameLoaderClient
  27049. https://bugs.webkit.org/show_bug.cgi?id=71013
  27050. Reviewed by Darin Fisher.
  27051. * DumpRenderTree/chromium/LayoutTestController.cpp:
  27052. (LayoutTestController::LayoutTestController):
  27053. (LayoutTestController::setScriptsAllowed):
  27054. * DumpRenderTree/chromium/LayoutTestController.h:
  27055. * DumpRenderTree/chromium/WebPermissions.cpp:
  27056. (WebPermissions::allowScriptFromSource):
  27057. (WebPermissions::setScriptsAllowed):
  27058. (WebPermissions::reset):
  27059. * DumpRenderTree/chromium/WebPermissions.h:
  27060. 2011-10-28 Alexandru Chiculita <achicu@adobe.com>
  27061. Added myself as a committer.
  27062. * Scripts/webkitpy/common/config/committers.py:
  27063. 2011-10-27 Adam Barth <abarth@webkit.org>
  27064. Remove WinCairo from the set of core builders. WinCairo rarely builds
  27065. and is never green.
  27066. Rubber-stamped by Eric Seidel.
  27067. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  27068. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  27069. 2011-10-27 Yuta Kitamura <yutak@chromium.org>
  27070. WebSocket: Connecting to localhost:8880 takes one second on Windows
  27071. https://bugs.webkit.org/show_bug.cgi?id=64788
  27072. Reviewed by Dirk Pranke.
  27073. * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  27074. Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
  27075. IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
  27076. from timing out on Windows, because this test tries to open a lot of
  27077. connections to localhost and each attempt takes one second to fall back from
  27078. IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
  27079. 2011-10-27 Adam Barth <abarth@webkit.org>
  27080. Dis-integrate run-bindings-tests with webkitpy
  27081. https://bugs.webkit.org/show_bug.cgi?id=71092
  27082. Reviewed by Ryosuke Niwa.
  27083. These tests aren't really adding any value.
  27084. * Scripts/webkitpy/common/config/ports.py:
  27085. * Scripts/webkitpy/tool/commands/download_unittest.py:
  27086. * Scripts/webkitpy/tool/mocktool.py:
  27087. * Scripts/webkitpy/tool/steps/runtests.py:
  27088. * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  27089. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  27090. 2011-10-27 Eric Seidel <eric@webkit.org>
  27091. REGRESSION (r98639): NRWT crashes when parsing leaks output
  27092. https://bugs.webkit.org/show_bug.cgi?id=71087
  27093. Unreviewed. Sadly we have no good way to test logging.
  27094. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  27095. 2011-10-27 David Levin <levin@chromium.org>
  27096. Test expectation errors should include the file name and platform in both the log and exception info.
  27097. https://bugs.webkit.org/show_bug.cgi?id=71067
  27098. Reviewed by Ojan Vafai.
  27099. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  27100. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  27101. 2011-10-27 Eric Seidel <eric@webkit.org>
  27102. new-run-webkit-tests doesn't understand --qt or --gtk
  27103. https://bugs.webkit.org/show_bug.cgi?id=63970
  27104. Reviewed by Ojan Vafai.
  27105. Add support for --qt and --gtk to NRWT.
  27106. I also removed some incorrect comments in the option parsing
  27107. code (options which we already implement, but said we didn't)
  27108. as well as moved --platform parsing out of the "results_options"
  27109. section into the top configuration section.
  27110. Now run-webkit-tests no longer needs NRWT-specific code for passing
  27111. --platform=qt, etc.
  27112. * Scripts/run-webkit-tests:
  27113. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  27114. 2011-10-27 Eric Seidel <eric@webkit.org>
  27115. REGRESSION (NRWT): build.webkit.org doesn't show the total number of leaks found during a test run on the Leaks bot
  27116. https://bugs.webkit.org/show_bug.cgi?id=66227
  27117. Reviewed by Adam Roben.
  27118. I believe this should fix the bug.
  27119. * Scripts/run-webkit-tests: make NRWT default for --leaks
  27120. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  27121. (LeakDetector._parse_leaks_output): removed the (unneeded) process_pid argument, and made the regexp use named groups (even though we don't ever grab them by name)
  27122. (LeakDetector.count_total_bytes_and_unique_leaks): renamed from parse_leak_files
  27123. (LeakDetector.count_total_leaks): new file (the guts of this change) which is used to re-parse the leaks output during the summarize leaks phase.
  27124. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  27125. Changes to reflect the rename of count_total_bytes_and_unique_leaks and a new test for count_total_leaks.
  27126. * Scripts/webkitpy/layout_tests/port/mac.py:
  27127. Use count_total_leaks to spit out the total leak count like ORWT did, and remove the FIXME on the subject.
  27128. 2011-10-27 Stephen Chenney <schenney@chromium.org>
  27129. [Chromium] Need setPrinting
  27130. https://bugs.webkit.org/show_bug.cgi?id=46152
  27131. Reviewed by Hajime Morita.
  27132. * DumpRenderTree/chromium/LayoutTestController.cpp:
  27133. (LayoutTestController::LayoutTestController): Added logic for handling setPrinting.
  27134. (LayoutTestController::reset): Clearing flags for setPrinting.
  27135. (LayoutTestController::setPrinting): Set flags for setPrinting.
  27136. * DumpRenderTree/chromium/LayoutTestController.h:
  27137. (LayoutTestController::setIsPrinting): Added the setPrinting methods and flags.
  27138. (LayoutTestController::isPrinting): Method to return the setPrinting status.
  27139. * DumpRenderTree/chromium/TestShell.cpp:
  27140. (dumpFramesAsPrintedText): A method for creating a text dump in printed layout.
  27141. (TestShell::dump): Modified to dump setPrinting-specific output.
  27142. * DumpRenderTree/chromium/WebViewHost.cpp:
  27143. (WebViewHost::paintPagesWithBoundaries): Handling for pixel tests when setPrinting is
  27144. active.
  27145. * DumpRenderTree/chromium/WebViewHost.h: Prototype for paintPagesWithBoundaries.
  27146. 2011-10-27 Sam Weinig <sam@webkit.org>
  27147. Add allowsPlugIns property to WKBrowsingContextGroup
  27148. https://bugs.webkit.org/show_bug.cgi?id=70987
  27149. Reviewed by Anders Carlsson.
  27150. * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm:
  27151. Add basic test for WKBrowsingContextGroup.allowsPlugIns.
  27152. 2011-10-27 Adam Roben <aroben@apple.com>
  27153. Test WKBundlePageGetBackingScaleFactor
  27154. Test for <http://webkit.org/b/71025> <rdar://problem/10355037> REGRESSION (r97191): Clients
  27155. can't reliably determine the scale factor of snapshots returned via
  27156. WKBundlePageCreateSnapshot* API
  27157. Reviewed by Sam Weinig.
  27158. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  27159. * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm: Added.
  27160. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Record the passed-back scale factor.
  27161. (TestWebKitAPI::setInjectedBundleClient): Hook up our didReceiveMessage callback.
  27162. (TestWebKitAPI::createWindow): Conjure up a window.
  27163. (TestWebKitAPI::TEST): Ask the injected bundle code to call the new
  27164. WKBundlePageGetBackingScaleFactor API when the WKView is in windows with various scale
  27165. factors and when using a custom scale factor, and check that we get those same scale factors
  27166. back.
  27167. * TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor_Bundle.mm: Added.
  27168. (TestWebKitAPI::GetBackingScaleFactorTest::GetBackingScaleFactorTest): Just initialize our
  27169. members.
  27170. (TestWebKitAPI::GetBackingScaleFactorTest::didCreatePage): Store the page for later.
  27171. (TestWebKitAPI::GetBackingScaleFactorTest::didReceiveMessage): Get the backing scale factor
  27172. from the page using the new API and send it back.
  27173. 2011-10-27 Balazs Kelemen <kbalazs@webkit.org>
  27174. [Qt][WK2] MiniBrowser crashes when started with 0 arguments
  27175. Rubber-stamped by Simon Hausmann.
  27176. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  27177. (MiniBrowserApplication::handleUserOptions):
  27178. Fix typo error.
  27179. 2011-10-27 Takashi Toyoshima <toyoshim@chromium.org>
  27180. [WebSocket] update pywebsocket to 0.7.
  27181. https://bugs.webkit.org/show_bug.cgi?id=70992
  27182. Reviewed by Kent Tamura.
  27183. pywebsocket 0.7 fixed the bug on dual stack support on OS X.
  27184. * Scripts/webkitpy/thirdparty/__init__.py:
  27185. 2011-10-27 Elliot Poger <epoger@google.com>
  27186. make lion observe MAC lines in test_expectations.txt
  27187. https://bugs.webkit.org/show_bug.cgi?id=70941
  27188. Reviewed by Ojan Vafai.
  27189. * Scripts/webkitpy/layout_tests/port/chromium.py:
  27190. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  27191. 2011-10-27 John Knottenbelt <jknotten@chromium.org>
  27192. [Chromium] Allow DRT to be built without notifications enabled.
  27193. https://bugs.webkit.org/show_bug.cgi?id=70919
  27194. Reviewed by Tony Gentilcore.
  27195. * DumpRenderTree/chromium/LayoutTestController.cpp:
  27196. (LayoutTestController::grantDesktopNotificationPermission):
  27197. (LayoutTestController::simulateDesktopNotificationClick):
  27198. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  27199. * DumpRenderTree/chromium/TestShell.cpp:
  27200. (TestShell::TestShell):
  27201. (TestShell::resetTestController):
  27202. 2011-10-21 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  27203. [Qt] Improve command line arguments handling for MiniBrowser.
  27204. https://bugs.webkit.org/show_bug.cgi?id=70616
  27205. Reviewed by Kenneth Rohde Christiansen.
  27206. - Use two dashes for word arguments.
  27207. - Return with an error when an unsupported argument is given.
  27208. - Allow the URL to be placed before option arguments.
  27209. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  27210. (printHelp):
  27211. (MiniBrowserApplication::handleUserOptions):
  27212. * MiniBrowser/qt/utils.cpp:
  27213. (takeOptionFlag):
  27214. (takeOptionValue):
  27215. * MiniBrowser/qt/utils.h:
  27216. 2011-10-27 Csaba Osztrogonác <ossy@webkit.org>
  27217. [Qt] NRWT doesn't work on qt-mac platform
  27218. https://bugs.webkit.org/show_bug.cgi?id=64445
  27219. Reviewed by Adam Barth.
  27220. * Scripts/run-webkit-tests: Switch qt-mac platform to NRWT.
  27221. (useNewRunWebKitTests):
  27222. * Scripts/webkitpy/layout_tests/port/qt.py: Fix library path on Mac.
  27223. 2011-10-26 Sam Weinig <sam@webkit.org>
  27224. Add initial setting to WKBrowsingContextGroup
  27225. https://bugs.webkit.org/show_bug.cgi?id=70942
  27226. Reviewed by Anders Carlsson.
  27227. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  27228. * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextGroupTest.mm: Added.
  27229. Add basic test that setting the javaScriptEnabled setting takes. It is not
  27230. possible to test its effect quite yet.
  27231. 2011-10-26 Alejandro G. Castro <alex@igalia.com>
  27232. [GTK] [WK2] Add WebKit2 distcheck support
  27233. https://bugs.webkit.org/show_bug.cgi?id=70933
  27234. Reviewed by Martin Robinson.
  27235. * WebKitTestRunner/GNUmakefile.am: Add missing files to the
  27236. sources and EXTRA_DIST.
  27237. 2011-10-26 Simon Hausmann <simon.hausmann@nokia.com>
  27238. [Qt][WK2] Fix failing assertion on startup of MiniBrowser -touch.
  27239. Reviewed by Tor Arne Vestbø.
  27240. We're using QScroller since r98460, which requires QWidget/QApplication. So
  27241. use QApplication and QtWidgets for the time being.
  27242. * MiniBrowser/qt/MiniBrowser.pro:
  27243. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  27244. (MiniBrowserApplication::MiniBrowserApplication):
  27245. (MiniBrowserApplication::notify):
  27246. * MiniBrowser/qt/MiniBrowserApplication.h:
  27247. 2011-10-25 Zeno Albisser <zeno.albisser@nokia.com>
  27248. [Qt][WK2] Rewrite MiniBrowser in QML
  27249. https://bugs.webkit.org/show_bug.cgi?id=70315
  27250. Add the first QML based implementation of MiniBrowser.
  27251. Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
  27252. Zeno Albisser <zeno.albisser@nokia.com>
  27253. Reviewed by Tor Arne Vestbø.
  27254. * MiniBrowser/qt/BrowserWindow.cpp:
  27255. (BrowserWindow::BrowserWindow):
  27256. (BrowserWindow::webView):
  27257. (BrowserWindow::load):
  27258. (BrowserWindow::keyPressEvent):
  27259. (BrowserWindow::~BrowserWindow):
  27260. * MiniBrowser/qt/BrowserWindow.h:
  27261. * MiniBrowser/qt/MiniBrowser.pro:
  27262. * MiniBrowser/qt/MiniBrowser.qrc:
  27263. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  27264. (MiniBrowserApplication::MiniBrowserApplication):
  27265. (MiniBrowserApplication::handleUserOptions):
  27266. * MiniBrowser/qt/MiniBrowserApplication.h:
  27267. (WindowOptions::WindowOptions):
  27268. * MiniBrowser/qt/UrlLoader.cpp:
  27269. (UrlLoader::UrlLoader):
  27270. * MiniBrowser/qt/icons/next.png: Added.
  27271. * MiniBrowser/qt/icons/previous.png: Added.
  27272. * MiniBrowser/qt/icons/refresh.png: Added.
  27273. * MiniBrowser/qt/icons/stop.png: Added.
  27274. * MiniBrowser/qt/main.cpp:
  27275. (main):
  27276. * MiniBrowser/qt/qml/BrowserWindow.qml: Added.
  27277. 2011-10-26 Zeno Albisser <zeno.albisser@nokia.com>
  27278. [Qt][WK2] Remove QtWidgets dependency in MiniBrowser
  27279. https://bugs.webkit.org/show_bug.cgi?id=70529
  27280. Remove obsolete code for a new QML based implementation
  27281. of MiniBrowser.
  27282. Change BrowserWindow to derive from QSGView instead of
  27283. QMainWindow. QSGView is used as a top level window that
  27284. provides the container for placing QML content.
  27285. Make MiniBrowserApplication derive from QGuiApplication
  27286. instead of QApplication.
  27287. Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
  27288. Zeno Albisser <zeno.albisser@nokia.com>
  27289. Reviewed by Simon Hausmann.
  27290. * MiniBrowser/qt/BrowserView.cpp: Removed.
  27291. * MiniBrowser/qt/BrowserView.h: Removed.
  27292. * MiniBrowser/qt/BrowserWindow.cpp:
  27293. (BrowserWindow::BrowserWindow):
  27294. (BrowserWindow::load):
  27295. (BrowserWindow::screenshot):
  27296. (BrowserWindow::loadURLListFromFile):
  27297. (BrowserWindow::updateUserAgentList):
  27298. (BrowserWindow::~BrowserWindow):
  27299. * MiniBrowser/qt/BrowserWindow.h:
  27300. * MiniBrowser/qt/MiniBrowser.pro:
  27301. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  27302. (MiniBrowserApplication::MiniBrowserApplication):
  27303. (MiniBrowserApplication::notify):
  27304. * MiniBrowser/qt/MiniBrowserApplication.h:
  27305. * MiniBrowser/qt/UrlLoader.cpp:
  27306. (UrlLoader::UrlLoader):
  27307. * MiniBrowser/qt/main.cpp:
  27308. 2011-10-25 Zeno Albisser <zeno.albisser@nokia.com>
  27309. [Qt][WK2] Remove QAction from MiniBrowser
  27310. https://bugs.webkit.org/show_bug.cgi?id=70525
  27311. In order to rewrite MiniBrowser in QML we need a suitable
  27312. mechanism for triggering navigation actions.
  27313. Due to the QtWidgets dependency of QAction the current
  27314. solution is not suitable anymore. Therefore we introduce
  27315. invokable methods and export properties in QWebNavigationController.
  27316. Patch by Jocelyn Turcotte <jocelyn.turcotte@nokia.com>,
  27317. Zeno Albisser <zeno.albisser@nokia.com>
  27318. Reviewed by Simon Hausmann.
  27319. * MiniBrowser/qt/BrowserView.cpp:
  27320. * MiniBrowser/qt/BrowserView.h:
  27321. * MiniBrowser/qt/BrowserWindow.cpp:
  27322. (BrowserWindow::BrowserWindow):
  27323. 2011-10-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  27324. [EFL] Unregister viewport,changed signal in EWebLauncher.
  27325. https://bugs.webkit.org/show_bug.cgi?id=70478
  27326. Reviewed by Eric Seidel.
  27327. 'viewport,changed' signal was registered by EWebLauncher in order to test viewport meta tag.
  27328. However, it sets wrong layout to some web sites which have viewport meta tag. Because, host pc
  27329. doesn't support proper DPI value though viewport is using DPI value to compute layout values.
  27330. This signal is for mobile device.
  27331. * EWebLauncher/main.c:
  27332. (browserCreate):
  27333. 2011-10-25 Anders Carlsson <andersca@apple.com>
  27334. Plug-ins have no way to find out when the device scale factor changes
  27335. https://bugs.webkit.org/show_bug.cgi?id=67226
  27336. <rdar://problem/10048276>
  27337. Reviewed by Sam Weinig.
  27338. Keep a cached copy of the contents scale and update it when it changes.
  27339. * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp:
  27340. (ContentsScaleFactor::ContentsScaleFactor):
  27341. (ContentsScaleFactor::cachedContentsScaleFactor):
  27342. (ContentsScaleFactor::ScriptableObject::hasProperty):
  27343. (ContentsScaleFactor::ScriptableObject::getProperty):
  27344. (ContentsScaleFactor::NPP_New):
  27345. (ContentsScaleFactor::NPP_SetValue):
  27346. 2011-10-25 Sam Weinig <sam@webkit.org>
  27347. Add WKBrowsingContextLoadDelegateTest test for a failed load
  27348. https://bugs.webkit.org/show_bug.cgi?id=70859
  27349. Reviewed by Anders Carlsson.
  27350. * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
  27351. (TEST_F): Add TEST_F(WKBrowsingContextLoadDelegateTest, SimpleLoadFail).
  27352. (-[SimpleLoadFailDelegate browsingContextControllerDidFailProvisionalLoad:withError:]):
  27353. Test that we are getting the correct NSError code and domain.
  27354. 2011-10-25 Erik Arvidsson <arv@chromium.org>
  27355. JS Test Harness: Make successfullyParsed optional
  27356. https://bugs.webkit.org/show_bug.cgi?id=70784
  27357. Reviewed by Ojan Vafai.
  27358. * Scripts/make-new-script-test:
  27359. (writeTestFile): Update the template for script tests.
  27360. 2011-10-25 Anders Carlsson <andersca@apple.com>
  27361. Plug-ins have to use JavaScript to find out the current device scale factor
  27362. https://bugs.webkit.org/show_bug.cgi?id=67225
  27363. <rdar://problem/10048258>
  27364. Reviewed by Darin Adler.
  27365. Add a plug-in test for getting the contents scale factor.
  27366. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  27367. * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ContentsScaleFactor.cpp: Added.
  27368. (ContentsScaleFactor::ContentsScaleFactor):
  27369. (ContentsScaleFactor::contentsScaleFactor):
  27370. (ContentsScaleFactor::ScriptableObject::hasProperty):
  27371. (ContentsScaleFactor::ScriptableObject::getProperty):
  27372. (ContentsScaleFactor::ScriptableObject::pluginTest):
  27373. (ContentsScaleFactor::NPP_GetValue):
  27374. 2011-10-25 Sam Weinig <sam@webkit.org>
  27375. Flesh out WKBrowsingContextLoadDelegate a bit
  27376. https://bugs.webkit.org/show_bug.cgi?id=70846
  27377. Reviewed by Anders Carlsson.
  27378. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  27379. * TestWebKitAPI/Tests/WebKit2ObjC: Added.
  27380. * TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm: Added.
  27381. (WKBrowsingContextLoadDelegateTest::WKBrowsingContextLoadDelegateTest):
  27382. (WKBrowsingContextLoadDelegateTest::SetUp):
  27383. (WKBrowsingContextLoadDelegateTest::TearDown):
  27384. (-[SimpleLoadDelegate browsingContextControllerDidFinishLoad:]):
  27385. (TEST_F):
  27386. Add basic testing for WKBrowsingContextLoadDelegate.
  27387. 2011-10-25 Alexey Proskuryakov <ap@apple.com>
  27388. make-script-test-wrappers should not look outside fast/js
  27389. https://bugs.webkit.org/show_bug.cgi?id=66357
  27390. Reviewed by Maciej Stachowiak.
  27391. * Scripts/make-script-test-wrappers: Don't look for template files everywhere, only support
  27392. fast/js.
  27393. 2011-10-25 Adam Barth <abarth@webkit.org>
  27394. Add a --make option to update-webkit to engage the Makefile-based build system
  27395. https://bugs.webkit.org/show_bug.cgi?id=70847
  27396. Reviewed by Dimitri Glazkov.
  27397. I can never remember what crazy environment variables I'm supposed to
  27398. set to tell GYP what to do.
  27399. * Scripts/update-webkit:
  27400. 2011-10-25 Raphael Kubo da Costa <kubo@profusion.mobi>
  27401. [EFL] DRT: Force layout when sending events.
  27402. https://bugs.webkit.org/show_bug.cgi?id=70357
  27403. Reviewed by Antonio Gomes.
  27404. Some tests such as editing/input/page-up-down-scrolls.html rely on the
  27405. scrollbars being properly set up during the onload events.
  27406. Document::implicitClose(), however, dispatches the onload events before
  27407. calling FrameView::layout(), so these tests usually fail.
  27408. We now do the same as the GTK+ and Chromium ports and manually force the
  27409. layout when dispatching events.
  27410. * DumpRenderTree/efl/EventSender.cpp:
  27411. (sendMouseEvent):
  27412. (keyDownCallback):
  27413. 2011-10-25 Daniel Bates <dbates@rim.com>
  27414. build-webkit --clean should only clean build directory for CMake-based ports
  27415. https://bugs.webkit.org/show_bug.cgi?id=70834
  27416. Reviewed by Antonio Gomes.
  27417. Currently build-webkit --clean both cleans the build directory and builds WebKit for
  27418. CMake-based ports. Instead, build-webkit --clean should only clean up the build directory
  27419. as per its description in the usage message of build-webkit.
  27420. * Scripts/webkitdirs.pm:
  27421. (buildCMakeProjectOrExit):
  27422. 2011-10-25 Anna Cavender <annacc@chromium.org>
  27423. Enable running of track layout tests for Chromium
  27424. https://bugs.webkit.org/show_bug.cgi?id=70803
  27425. Reviewed by Adam Barth.
  27426. Make DumpRenderTree/TestShell always run with track enabled
  27427. (equivalent of --enable-video-track).
  27428. * DumpRenderTree/chromium/TestShell.cpp:
  27429. (TestShell::TestShell):
  27430. 2011-10-25 Vamshikrishna Yellenki <vamshi@motorola.com>
  27431. [WK2]Main window never gets focus using TAB key in WebKit2 GTK+.
  27432. https://bugs.webkit.org/show_bug.cgi?id=70603
  27433. Reviewed by Gustavo Noronha Silva.
  27434. * MiniBrowser/gtk/BrowserWindow.c:
  27435. (focus):
  27436. (unFocus):
  27437. (browserWindowUIClientInit):
  27438. 2011-10-25 Dan Bernstein <mitz@apple.com>
  27439. <rdar://problem/10337033> DOMRangeOfString:relativeTo:options has problems with -webkit-user-select: none
  27440. Reviewed by Adam Roben.
  27441. * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
  27442. (TestWebKitAPI::TEST):
  27443. 2011-10-25 Eric Seidel <eric@webkit.org>
  27444. WIN: editing tests fail under NRWT because editing delegate callbacks aren't stripped
  27445. https://bugs.webkit.org/show_bug.cgi?id=64471
  27446. Reviewed by Adam Roben.
  27447. Speculative fix.
  27448. * Scripts/webkitpy/layout_tests/port/win.py:
  27449. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  27450. 2011-10-24 Mikhail Naganov <mnaganov@chromium.org>
  27451. Fix bug summary when rolling Chromium DEPS to LKGR.
  27452. https://bugs.webkit.org/show_bug.cgi?id=69917
  27453. Reviewed by Adam Barth.
  27454. * Scripts/webkitpy/tool/bot/irc_command.py:
  27455. * Scripts/webkitpy/tool/bot/sheriff.py:
  27456. * Scripts/webkitpy/tool/commands/roll.py:
  27457. * Scripts/webkitpy/tool/commands/roll_unittest.py:
  27458. 2011-10-24 Ivan Briano <ivan@profusion.mobi>
  27459. [EFL] Build fix. Add include path to find npapi.h
  27460. https://bugs.webkit.org/show_bug.cgi?id=70730
  27461. Unreviewed build fix.
  27462. * DumpRenderTree/efl/CMakeLists.txt: Add include path for npapi.h
  27463. 2011-10-24 Eric Seidel <eric@webkit.org>
  27464. Plugin tests are failing after switching WK2 to NRWT
  27465. https://bugs.webkit.org/show_bug.cgi?id=70760
  27466. Reviewed by Simon Fraser.
  27467. Perpetuate this horrible hack.
  27468. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27469. 2011-10-24 Eric Seidel <eric@webkit.org>
  27470. NRWT doesn't support ORWT's --root option, but should
  27471. https://bugs.webkit.org/show_bug.cgi?id=70416
  27472. Reviewed by Dirk Pranke.
  27473. Add support for ORWT's --root option which is used for
  27474. running tests with a nightly build of WebKit.
  27475. * Scripts/old-run-webkit-tests:
  27476. * Scripts/webkitpy/layout_tests/port/base.py:
  27477. - webkit_build_path was never called by any code, removed.
  27478. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27479. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  27480. 2011-10-24 David Levin <levin@chromium.org>
  27481. check-webkit-style complains about WEBKIT_EXPORT in test/WebUnitTests.h
  27482. https://bugs.webkit.org/show_bug.cgi?id=70747
  27483. Reviewed by Tony Chang.
  27484. * Scripts/webkitpy/style/checkers/cpp.py: Allow WEBKIT_EXPORT in tests dir.
  27485. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Corresponding test.
  27486. 2011-10-24 Balazs Kelemen <kbalazs@webkit.org>
  27487. [Qt][WK2] Crash when running pixel tests
  27488. https://bugs.webkit.org/show_bug.cgi?id=70725
  27489. Reviewed by Chang Shu.
  27490. * WebKitTestRunner/qt/TestInvocationQt.cpp:
  27491. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  27492. 2011-10-24 Carlos Garcia Campos <cgarcia@igalia.com>
  27493. [GTK] Remove g_thread_init() calls
  27494. https://bugs.webkit.org/show_bug.cgi?id=70717
  27495. Reviewed by Xan Lopez.
  27496. With newer glib it's not needed anymore and with previous versions
  27497. it was already called by g_type_init().
  27498. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  27499. (main):
  27500. * GtkLauncher/main.c:
  27501. (main):
  27502. * MiniBrowser/gtk/main.c:
  27503. (main):
  27504. 2011-10-24 Alejandro G. Castro <alex@igalia.com>
  27505. [WK2] [GTK] WebKitTestRunner crashes with heap corruption
  27506. https://bugs.webkit.org/show_bug.cgi?id=69403
  27507. We did not added autotoolsconfig.h to the config.h file and we
  27508. were adding Platform.h without the config.h in the
  27509. WebKitTestRunnerPrefix.h. Added the autotoolsconfig.h include in
  27510. the Prefix file.
  27511. Reviewed by Martin Robinson.
  27512. * WebKitTestRunner/WebKitTestRunnerPrefix.h:
  27513. 2011-10-23 Tomasz Morawski <t.morawski@samsung.com>
  27514. [EFL] Remove unused code from EWebLauncher
  27515. https://bugs.webkit.org/show_bug.cgi?id=70590
  27516. Reviewed by Andreas Kling.
  27517. Removed unused function on_closeWindow from EWebLauncher
  27518. * EWebLauncher/main.c:
  27519. 2011-10-23 Luke Macpherson <macpherson@chromium.org>
  27520. Add watchlist for WebCore/css and put myself on it.
  27521. https://bugs.webkit.org/show_bug.cgi?id=70701
  27522. Reviewed by Adam Barth.
  27523. * Scripts/webkitpy/common/config/watchlist:
  27524. Add watchlist for WebCore/css and put myself on it.
  27525. 2011-10-23 Kaustubh Atrawalkar <kaustubh@motorola.com>
  27526. [GTK] Implement KeyDown function for WebKit2 EventSender.
  27527. https://bugs.webkit.org/show_bug.cgi?id=69410
  27528. Reviewed by Martin Robinson.
  27529. Implement the KeyDown function on Gtk platform.
  27530. * WebKitTestRunner/GNUmakefile.am:
  27531. * WebKitTestRunner/TestController.cpp:
  27532. (WTR::TestController::TestController):
  27533. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  27534. * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp: Added.
  27535. (WTR::EventSenderProxy::EventSenderProxy):
  27536. (WTR::dispatchEvent):
  27537. (WTR::getModifiers):
  27538. (WTR::getGDKKeySymForKeyRef):
  27539. (WTR::EventSenderProxy::keyDown):
  27540. 2011-10-22 Zan Dobersek <zandobersek@gmail.com>
  27541. [WK2][GTK] run-launcher script fails after testing WK2 tests
  27542. https://bugs.webkit.org/show_bug.cgi?id=70676
  27543. Reviewed by Andreas Kling.
  27544. Pass the '-2' flag instead of '--webkit-test-runner' when executing
  27545. run-launcher script after testing with WebKitTestRunner.
  27546. * Scripts/webkitpy/layout_tests/port/gtk.py:
  27547. 2011-10-22 Zan Dobersek <zandobersek@gmail.com>
  27548. [WK2][GTK] Missing env variables cause WKTR to crash
  27549. https://bugs.webkit.org/show_bug.cgi?id=70674
  27550. Reviewed by Martin Robinson.
  27551. Set two environment variables that the Gtk's port of WebKitTestRunner
  27552. depends on and crashes if they're not explicitly set by the user.
  27553. Also modify the setting of the WEBKIT_INSPECTOR_PATH variable so it
  27554. properly uses the _build_path method.
  27555. * Scripts/webkitpy/layout_tests/port/gtk.py: Set
  27556. TEST_RUNNER_INJECTED_BUNDLE_FILENAME and TEST_RUNNER_TEST_PLUGIN_PATH
  27557. environment variables.
  27558. 2011-10-21 Filip Pizlo <fpizlo@apple.com>
  27559. Bencher script doesn't measure GC times accurately
  27560. https://bugs.webkit.org/show_bug.cgi?id=70588
  27561. Reviewed by Geoff Garen.
  27562. Added two new options which allow different ways of measuring GC times:
  27563. --measure-gc, which omits calls to gc() between benchmark invocations.
  27564. This option takes an optional argument, which is the name of the
  27565. VM in which to enable this feature. This allows comparing a single VM
  27566. against itself, with and without GC.
  27567. --rerun <N>, which causes each sample measurement to include N invocations
  27568. which do not have gc() calls between them. The default is N = 1, which
  27569. results in the same behavior as before.
  27570. You can use either --measure-gc or --rerun <N> for N > 1 (preferably
  27571. N >= 3) to get more of a contribution from GC to the measured times.
  27572. --rerun results in tighter confidence intervals than --measure-gc, since
  27573. it amortizes GC effects in each sample, while with --measure-gc some
  27574. samples will see GC and some won't leading to a higher standard devation
  27575. and thus requiring more samples to reduce confidence intervals to
  27576. managable levels.
  27577. * Scripts/bencher:
  27578. 2011-10-21 Sam Weinig <sam@webkit.org>
  27579. Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
  27580. https://bugs.webkit.org/show_bug.cgi?id=70653
  27581. Reviewed by Simon Fraser.
  27582. * MiniBrowser/mac/AppDelegate.h:
  27583. * MiniBrowser/mac/AppDelegate.m:
  27584. (-[BrowserAppDelegate init]):
  27585. (-[BrowserAppDelegate newWindow:]):
  27586. (-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
  27587. * MiniBrowser/mac/BrowserWindowController.h:
  27588. * MiniBrowser/mac/BrowserWindowController.m:
  27589. (-[BrowserWindowController initWithContext:pageGroup:]):
  27590. (-[BrowserWindowController windowWillClose:]):
  27591. (createNewPage):
  27592. (-[BrowserWindowController awakeFromNib]):
  27593. * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  27594. (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
  27595. Update testing code to pass a PageGroup as necessary.
  27596. 2011-10-21 Leandro Pereira <leandro@profusion.mobi>
  27597. webkitpy: Teach NRWT about the EFL port
  27598. https://bugs.webkit.org/show_bug.cgi?id=70637
  27599. Allows using ``efl'' as a platform when executing NRWT.
  27600. Reviewed by Eric Seidel.
  27601. * Scripts/webkitpy/layout_tests/port/efl.py: Added.
  27602. * Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
  27603. * Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
  27604. when using PortFactory.get(port_name='efl').
  27605. 2011-10-21 Devdatta Deshpande <pwjd73@motorola.com>
  27606. [Gtk] mousemove event always has metaKey == true
  27607. https://bugs.webkit.org/show_bug.cgi?id=35299
  27608. Reviewed by Martin Robinson.
  27609. * DumpRenderTree/gtk/EventSender.cpp:
  27610. (gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
  27611. keyboard events. So making it in sync with WebCore files.
  27612. (mouseMoveToCallback): Sending modifier keys state for mouse move event.
  27613. 2011-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
  27614. watchlist: Add a new entry for WebKit2 GTK+ public API
  27615. https://bugs.webkit.org/show_bug.cgi?id=70601
  27616. Reviewed by Philippe Normand.
  27617. Subscribe myself to WebKit2 GTK+ API patches. Also add a message
  27618. for patches that might include new API that points to the WebKit2
  27619. GTK+ API guidelines.
  27620. * Scripts/webkitpy/common/config/watchlist:
  27621. 2011-10-21 Simon Hausmann <simon.hausmann@nokia.com>
  27622. Remove QtScript source code from WebKit.
  27623. https://bugs.webkit.org/show_bug.cgi?id=64088
  27624. Reviewed by Tor Arne Vestbø.
  27625. Removed dead code that isn't developed anymore.
  27626. * Scripts/webkitpy/style/checker_unittest.py:
  27627. 2011-10-20 Eric Seidel <eric@webkit.org>
  27628. Switch webkit2 bot to NRWT
  27629. https://bugs.webkit.org/show_bug.cgi?id=56729
  27630. Reviewed by Adam Barth.
  27631. Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
  27632. https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html
  27633. * Scripts/run-webkit-tests:
  27634. (runningOnBuildBot):
  27635. (useNewRunWebKitTests):
  27636. 2011-10-20 Eric Seidel <eric@webkit.org>
  27637. NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
  27638. https://bugs.webkit.org/show_bug.cgi?id=70585
  27639. Reviewed by Adam Barth.
  27640. This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
  27641. However since DRT was functioning fine before in Qt, we'll make this an error log for now
  27642. and once we find the root cause flip this back to an assert.
  27643. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27644. 2011-10-20 Yuta Kitamura <yutak@chromium.org>
  27645. Unreviewed, rolling out r98064.
  27646. http://trac.webkit.org/changeset/98064
  27647. https://bugs.webkit.org/show_bug.cgi?id=64788
  27648. Broke Mac bots.
  27649. * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  27650. 2011-10-20 Yuta Kitamura <yutak@chromium.org>
  27651. WebSocket: Connecting to localhost:8880 takes one second on Windows
  27652. https://bugs.webkit.org/show_bug.cgi?id=64788
  27653. Reviewed by Dirk Pranke.
  27654. * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  27655. Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
  27656. IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
  27657. from timing out on Windows, because this test tries to open a lot of
  27658. connections to localhost and each attempt takes one second to fall back from
  27659. IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).
  27660. 2011-10-20 Ryosuke Niwa <rniwa@webkit.org>
  27661. nrwt: newly generated results are put in cross-platform directory
  27662. https://bugs.webkit.org/show_bug.cgi?id=68931
  27663. Reviewed by Dirk Pranke.
  27664. The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
  27665. with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
  27666. (because png images are typically different on each platform), and passing True when .txt file is missing
  27667. and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".
  27668. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  27669. * Scripts/webkitpy/layout_tests/port/test.py:
  27670. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
  27671. and added a test case.
  27672. 2011-10-20 Kent Tamura <tkent@chromium.org>
  27673. Unreviewed. Adding myself to watchlist.
  27674. * Scripts/webkitpy/common/config/watchlist:
  27675. Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.
  27676. 2011-10-20 Nico Weber <thakis@chromium.org>
  27677. [chromium/mac] Add support for building with make
  27678. https://bugs.webkit.org/show_bug.cgi?id=70455
  27679. Reviewed by Adam Barth.
  27680. Depends on http://codereview.chromium.org/8352029/
  27681. `GYP_GENERATORS=make Tools/Scripts/update-webkit --chromium` will
  27682. create a toplevel Makefile.chromium.
  27683. If that file exists and is newer than Source/WebKit/chromium/WebKit.xcodeproj,
  27684. `Tools/Scripts/build-webkit --chromium` will build with make instead of
  27685. xcodebuild.
  27686. Also let nrwt use a binary from out/ if it exists.
  27687. * Scripts/webkitdirs.pm:
  27688. (determineBaseProductDir):
  27689. (isChromiumMacMake):
  27690. (determineIsChromiumMacMake):
  27691. (buildChromium):
  27692. 2011-10-20 Eric Seidel <eric@webkit.org>
  27693. Possible REGRESSION(97879): NRWT fails when DumpRenderTree crashes
  27694. https://bugs.webkit.org/show_bug.cgi?id=70524
  27695. Reviewed by Adam Barth.
  27696. This is a speculative fix, since I do not use a platform
  27697. which outputs crashlogs over stderr.
  27698. * Scripts/webkitpy/layout_tests/port/server_process.py:
  27699. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27700. 2011-10-20 Eric Seidel <eric@webkit.org>
  27701. REGRESSION(97879): Pixel tests no longer work with NRWT on Mac
  27702. https://bugs.webkit.org/show_bug.cgi?id=70492
  27703. Reviewed by Adam Barth.
  27704. The bug turned out to be that I was assuming the block.content
  27705. would be empty before the binary content following Content-Length
  27706. was read inside _read_block. Turns out its not, due to extra newlines
  27707. and "ExpectedHash" header.
  27708. In the process of trying to figure out what was going wrong I ended up
  27709. cleaning up our newline usage in DumpRenderTree a little. Moved
  27710. two error messages from stdout to stderr, and fixed a little code indent/whitespace.
  27711. I also fixed ServerProcess to use "deadline" everywhere instead of timeout
  27712. per Adam's request in the original bug.
  27713. * DumpRenderTree/PixelDumpSupport.cpp:
  27714. (dumpWebViewAsPixelsAndCompareWithExpected):
  27715. * DumpRenderTree/cg/ImageDiffCG.cpp:
  27716. (main):
  27717. * DumpRenderTree/mac/DumpRenderTree.mm:
  27718. (dump):
  27719. * DumpRenderTree/mac/PixelDumpSupportMac.mm:
  27720. (restoreMainDisplayColorProfile):
  27721. (setupMainDisplayColorProfile):
  27722. * Scripts/webkitpy/layout_tests/port/server_process.py:
  27723. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27724. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  27725. 2011-10-20 Tony Chang <tony@chromium.org>
  27726. [chromium] Remove <stdint.h> from ImageDiff and use
  27727. unsigned int instead of uint32_t.
  27728. Unreviewed, fixing the chromium win build.
  27729. * DumpRenderTree/chromium/ImageDiff.cpp:
  27730. (Image::pixelAt):
  27731. (Image::setPixelAt):
  27732. (maxOf3):
  27733. (getRedComponent):
  27734. (getGreenComponent):
  27735. (getBlueComponent):
  27736. (weightedPercentageDifferent):
  27737. (createImageDiff):
  27738. 2011-10-20 Hao Zheng <zhenghao@chromium.org>
  27739. [Chromium] Reduce dependencies of ImageDiff to compile it for Android.
  27740. https://bugs.webkit.org/show_bug.cgi?id=69997
  27741. Reviewed by Tony Chang.
  27742. This change is required to make ImageDiff for Android, and can benefit
  27743. other platforms, too. On Android, most targets are built as
  27744. toolsets:target. while ImageDiff needs to be built as toolsets:host.
  27745. Currently, building the standalone target of ImageDiff depends on about
  27746. 85 other targets (try make ImageDiff'), which is inefficient. After the
  27747. change, ImageDiff only depends on webkit_support_gfx, which in turn
  27748. depends on libpng and zlib.
  27749. * DumpRenderTree/chromium/ImageDiff.cpp:
  27750. (main):
  27751. 2011-10-20 Leandro Pereira <leandro@profusion.mobi>
  27752. [EFL] Unreviewed DumpRenderTree build fix.
  27753. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  27754. (LayoutTestController::addChromeInputField): Add stub.
  27755. (LayoutTestController::removeChromeInputField): Ditto.
  27756. (LayoutTestController::focusWebView): Ditto.
  27757. (LayoutTestController::setBackingScaleFactor): Ditto.
  27758. 2011-10-20 Leandro Pereira <leandro@profusion.mobi>
  27759. [EFL] Plug ImageDiff/DumpRenderTree on CMake build system
  27760. https://bugs.webkit.org/show_bug.cgi?id=70142
  27761. Reviewed by Gustavo Noronha Silva.
  27762. * CMakeListsEfl.txt: Include DRT CMakeLists.
  27763. * DumpRenderTree/efl/CMakeLists.txt: Added.
  27764. 2011-10-20 Philippe Normand <pnormand@igalia.com>
  27765. [style] Allow usage of NULL in gst_*
  27766. https://bugs.webkit.org/show_bug.cgi?id=70498
  27767. Reviewed by David Levin.
  27768. * Scripts/webkitpy/style/checkers/cpp.py: Simplified the detection
  27769. of gst_ calls. Now just ignore NULL in all of them.
  27770. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Test for above change.
  27771. 2011-10-20 Leandro Pereira <leandro@profusion.mobi>
  27772. [EFL] Unreviewed. Build fix after r97043.
  27773. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  27774. (DumpRenderTreeChrome::resetDefaultsToConsistentValues): Use ewk_view_scale_set() instead of ewk_view_page_scale().
  27775. * DumpRenderTree/efl/EventSender.cpp:
  27776. (scalePageByCallback): Ditto.
  27777. 2011-10-20 Philippe Normand <pnormand@igalia.com>
  27778. Unreviewed. Adding myself to watchlists.
  27779. * Scripts/webkitpy/common/config/watchlist:
  27780. 2011-10-19 Eric Seidel <eric@webkit.org>
  27781. Reviewed by Adam Barth.
  27782. Teach new-run-webkit-tests about #CRASHED and #CRASHED - WebProcess
  27783. https://bugs.webkit.org/show_bug.cgi?id=63683
  27784. * Scripts/webkitpy/common/net/layouttestresults.py:
  27785. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  27786. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  27787. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  27788. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  27789. * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  27790. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  27791. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  27792. * Scripts/webkitpy/layout_tests/port/base.py:
  27793. * Scripts/webkitpy/layout_tests/port/server_process.py:
  27794. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27795. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  27796. 2011-10-19 Jochen Eisinger <jochen@chromium.org>
  27797. Chromium doesn't support git branch builds, so don't add the branch to the product dir
  27798. https://bugs.webkit.org/show_bug.cgi?id=70449
  27799. Reviewed by Eric Seidel.
  27800. * Scripts/webkitdirs.pm:
  27801. (determineBaseProductDir):
  27802. 2011-10-19 Ojan Vafai <ojan@chromium.org>
  27803. Unreviewed. Adding myself to watchlists.
  27804. * Scripts/webkitpy/common/config/watchlist:
  27805. 2011-10-19 Tom Zakrajsek <tomz@codeaurora.org>
  27806. Add a suggest-nominations command to webkit-patch for computing potential committer/reviewer nominations
  27807. https://bugs.webkit.org/show_bug.cgi?id=62166
  27808. Reviewed by Eric Seidel.
  27809. Included options to control committer/reviewer patch count requirements,
  27810. an age-limit on patches, and verbose output for more in-depth analysis.
  27811. * Scripts/webkitpy/common/checkout/changelog.py:
  27812. * Scripts/webkitpy/tool/commands/__init__.py:
  27813. * Scripts/webkitpy/tool/commands/suggestnominations.py: Added.
  27814. * Scripts/webkitpy/tool/commands/suggestnominations_unittest.py: Added.
  27815. 2011-10-19 Eric Seidel <eric@webkit.org>
  27816. new-run-webkit-tests -2 was crashing due to both "java" and "java/" being listed in Skipped files.
  27817. Make NRWT normalize directory names in Skipped files during parsing.
  27818. Unreviewed. Very simple (tested) change.
  27819. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  27820. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27821. 2011-10-19 David Levin <levin@chromium.org>
  27822. watchlist: Should be more robust to bad regex.
  27823. https://bugs.webkit.org/show_bug.cgi?id=69486
  27824. Reviewed by Adam Barth.
  27825. * Scripts/webkitpy/common/config/watchlist: Change the instructions due to
  27826. watchlist being checked by check-webkit-style (bug 69487) and remove the .* from file
  27827. patterns since they are no longer anchored on the right hand side.
  27828. * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Change *pattern to take a compiled regex directly.
  27829. * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Ditto.
  27830. * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Ditto.
  27831. * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Ditto.
  27832. * Scripts/webkitpy/common/watchlist/filenamepattern.py: Ditto.
  27833. * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Ditto and change a test now that
  27834. filenames are no longer anchored on the right hand side.
  27835. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Catch regex errors and log them as errors.
  27836. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add some tests to verify that bad regexes
  27837. don't kill everything.
  27838. 2011-10-19 David Levin <levin@chromium.org>
  27839. watchlist: Add a stylecheck to do validity checks for the watchlist config.
  27840. https://bugs.webkit.org/show_bug.cgi?id=69487
  27841. Reviewed by Adam Barth.
  27842. * Scripts/webkitpy/style/checker.py: Add the watchlist file type.
  27843. * Scripts/webkitpy/style/checkers/watchlist.py: Added.
  27844. * Scripts/webkitpy/style/checkers/watchlist_unittest.py: Added.
  27845. 2011-10-19 Eric Seidel <eric@webkit.org>
  27846. NRWT ServerProcess can't read lines from stderr and stdio separately
  27847. https://bugs.webkit.org/show_bug.cgi?id=70435
  27848. Reviewed by Adam Barth.
  27849. This is the underlying bug behind our lack of WK2 support, and timeout detection on Windows.
  27850. DRT expects RWT to read one line at a time from stderr and stdout independently.
  27851. This allows DRT to communicate errors over stderr and have them responded to immediately
  27852. regardless of what state the stdio stream may be in. Previously NRWT's ServerProcess
  27853. class only exposed a read_line function which would read a line from stdout
  27854. and batch all output from stderr into an error buffer. Callers would only be able
  27855. to respond to commands over stderr if they happened to correspond with a stdout line boundary.
  27856. * Scripts/webkitpy/layout_tests/port/server_process.py:
  27857. * Scripts/webkitpy/layout_tests/port/webkit.py:
  27858. 2011-10-19 Chang Shu <cshu@webkit.org>
  27859. [Qt] Support WK1-only Skipped list
  27860. https://bugs.webkit.org/show_bug.cgi?id=70254
  27861. Reviewed by Csaba Osztrogonác.
  27862. Added a new search path qt-wk1 for skipping WK1-only tests.
  27863. * Scripts/webkitpy/layout_tests/port/qt.py: NRWT
  27864. * Scripts/old-run-webkit-tests: ORWT
  27865. 2011-10-19 Gabor Rapcsanyi <rgabor@webkit.org>
  27866. [GTK] Enable to use built-product-archive on GTK platform
  27867. https://bugs.webkit.org/show_bug.cgi?id=70319
  27868. Reviewed by Csaba Osztrogonác.
  27869. * BuildSlaveSupport/built-product-archive:
  27870. 2011-10-18 David Levin <levin@chromium.org>
  27871. watchlist: Should try to run if it can and not throw on mistakes.
  27872. https://bugs.webkit.org/show_bug.cgi?id=70358
  27873. Reviewed by Adam Barth.
  27874. * Scripts/webkitpy/common/system/outputcapture.py: Add the ability to capture log output.
  27875. * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adapt to the logging of errors.
  27876. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Change to log problems and fix problems when found.
  27877. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Adapt to the logging of errors.
  27878. * Scripts/webkitpy/common/watchlist/watchlistrule.py: Expose a way to remove instructions.
  27879. * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Test the new function.
  27880. 2011-10-18 Sam Weinig <sam@webkit.org>
  27881. Move uses of C-SPI out of WKView.h and into WKViewPrivate.h
  27882. https://bugs.webkit.org/show_bug.cgi?id=70387
  27883. Reviewed by Dan Bernstein.
  27884. * MiniBrowser/mac/BrowserWindowController.m:
  27885. * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
  27886. * TestWebKitAPI/mac/JavaScriptTestMac.mm:
  27887. * TestWebKitAPI/mac/PlatformWebViewMac.mm:
  27888. * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  27889. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  27890. Update to include WKViewPrivate.h where necessary.
  27891. 2011-10-18 Joseph Pecoraro <joepeck@webkit.org>
  27892. Web Inspector: Some localizedStrings.js Updates
  27893. https://bugs.webkit.org/show_bug.cgi?id=70365
  27894. Reviewed by Darin Adler.
  27895. * Scripts/check-inspector-strings:
  27896. Updated to the new webkitpy way to determine checkout root.
  27897. * Scripts/webkitdirs.pm:
  27898. (copyInspectorFrontendFiles):
  27899. Made it so build-webkit --inspector-frontend copies over
  27900. the localizedStrings.js file as well as the frontend files.
  27901. 2011-10-18 Raphael Kubo da Costa <kubo@profusion.mobi>
  27902. [EFL] DRT: Clear list of visited pages before each test.
  27903. https://bugs.webkit.org/show_bug.cgi?id=70355
  27904. Reviewed by Antonio Gomes.
  27905. r97596 uncovered a bug in the implementation: the list of visited
  27906. links was not cleared between tests, which caused tests such as
  27907. fast/repaint/outline-repaint-glitch.html to be flaky (the link color
  27908. changed depending on whether fast/repaint/border-repaint-glitch.html
  27909. was visited before or not).
  27910. Call ewk_history_clear to make sure the visited links list does not
  27911. persist between tests.
  27912. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  27913. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  27914. 2011-10-18 Dimitri Glazkov <dglazkov@chromium.org>
  27915. Split TestExpectationsEditor into its own file.
  27916. https://bugs.webkit.org/show_bug.cgi?id=70348
  27917. Reviewed by Adam Barth.
  27918. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py.
  27919. * Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py.
  27920. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Adjusted for change.
  27921. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  27922. * Scripts/webkitpy/tool/servers/gardeningserver.py: Ditto.
  27923. 2011-10-18 Ryosuke Niwa <rniwa@webkit.org>
  27924. [Chromium] buildbot runs nrwt with --chromium instead of --chromium-cg-mac
  27925. https://bugs.webkit.org/show_bug.cgi?id=70313
  27926. Reviewed by Adam Barth.
  27927. Fixed the bug by passing --platform --chromium-cg-mac in RunWebKitTests. We can't always add
  27928. this parameter because build-webkit and other scripts don't accept it.
  27929. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  27930. 2011-10-18 Adam Barth <abarth@webkit.org>
  27931. Subscribe myself to WebIDL changes
  27932. https://bugs.webkit.org/show_bug.cgi?id=70341
  27933. Reviewed by David Levin.
  27934. I've also added some documentation and refactored my previous
  27935. subscriptions to make it eaiser for others to subscribe as well.
  27936. * Scripts/webkitpy/common/config/watchlist:
  27937. 2011-10-18 Dimitri Glazkov <dglazkov@chromium.org>
  27938. Add myself to the newfangled watchlist plumbing.
  27939. https://bugs.webkit.org/show_bug.cgi?id=70338
  27940. Reviewed by David Levin.
  27941. * Scripts/webkitpy/common/config/watchlist: Added sheepishly.
  27942. 2011-10-18 Dimitri Glazkov <dglazkov@chromium.org>
  27943. Fix a unit test in TestFailures.
  27944. https://bugs.webkit.org/show_bug.cgi?id=70337
  27945. Reviewed by Adam Barth.
  27946. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Turns out,
  27947. the value of a method property should always be lowercase.
  27948. 2011-10-18 Adam Barth <abarth@webkit.org>
  27949. Always enable ENABLE(XPATH)
  27950. https://bugs.webkit.org/show_bug.cgi?id=70217
  27951. Reviewed by Eric Seidel.
  27952. * Scripts/build-webkit:
  27953. 2011-10-18 Dimitri Glazkov <dglazkov@chromium.org>
  27954. garden-o-matic should not report flaking in expected failures as failures.
  27955. https://bugs.webkit.org/show_bug.cgi?id=70279
  27956. Reviewed by Adam Barth.
  27957. On the bots, flakes that are already expected to fail aren't reported as failures (they keep the bot green).
  27958. For example, if TEXT failure is expected, a TEXT TIMEOUT result will not cause the redness. We should do the
  27959. same for garden-o-matic.
  27960. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Spuriously changed to use Array iterators rather than jQuery APIs,
  27961. rewrote the logic for determining expected or unexpected failures as a central analysis tool.
  27962. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Added unit tests.
  27963. 2011-10-18 Zan Dobersek <zandobersek@gmail.com>
  27964. [Gtk] Support for client-based geolocation
  27965. https://bugs.webkit.org/show_bug.cgi?id=64970
  27966. Reviewed by Martin Robinson.
  27967. Add support for testing client-based geolocation tests in DumpRenderTree.
  27968. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  27969. (resetDefaultsToConsistentValues): Reset GeolocationClientMock.
  27970. (createWebView): Create web view after declaring DumpRenderTree mode.
  27971. That way a mock client for geolocation is used instead of a GeoClue
  27972. client if a web view is created when testing.
  27973. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Implement functions for
  27974. geolocation layout tests.
  27975. (LayoutTestController::setMockGeolocationPosition):
  27976. (LayoutTestController::setMockGeolocationError):
  27977. (LayoutTestController::setGeolocationPermission):
  27978. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  27979. * Scripts/build-webkit: Note that the Gtk port is using client-based
  27980. geolocation, even though changing this flag has no effect on compilation.
  27981. 2011-10-07 Andrey Kosyakov <caseq@chromium.org>
  27982. [Chromium] suppress console output from DevTools window
  27983. https://bugs.webkit.org/show_bug.cgi?id=69632
  27984. Reviewed by Pavel Feldman.
  27985. * DumpRenderTree/chromium/TestShell.cpp:
  27986. (TestShell::showDevTools):
  27987. * DumpRenderTree/chromium/WebViewHost.cpp:
  27988. (WebViewHost::didAddMessageToConsole):
  27989. (WebViewHost::reset):
  27990. (WebViewHost::setLogConsoleOutput):
  27991. * DumpRenderTree/chromium/WebViewHost.h:
  27992. 2011-10-18 Sheriff Bot <webkit.review.bot@gmail.com>
  27993. Unreviewed, rolling out r97735.
  27994. http://trac.webkit.org/changeset/97735
  27995. https://bugs.webkit.org/show_bug.cgi?id=70317
  27996. some people apparently use build-jsc with the qt port without
  27997. building webkit first (Requested by torarne on #webkit).
  27998. * Scripts/build-webkit:
  27999. * Scripts/webkitdirs.pm:
  28000. (buildQMakeProject):
  28001. (buildQMakeQtProject):
  28002. 2011-10-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  28003. [Qt] Remove dead code in build-webkit
  28004. build-webkit will iterate over a list of subdirectories to build,
  28005. but this feature is only used by the Apple ports. For QtWebKit we
  28006. always pass an empty directory to buildQMakeProject, which makes
  28007. the logic for dealing with sub-projects in buildQMakeProject just
  28008. added noise.
  28009. If we do want this feature at some point, we should redo it in
  28010. the context of the upcoming build system changes for Qt.
  28011. Reviewed by Simon Hausmann.
  28012. * Scripts/build-webkit:
  28013. * Scripts/webkitdirs.pm:
  28014. (buildQt):
  28015. 2011-10-18 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  28016. Remove traces of Symbian support from the build scripts
  28017. Reviewed by Simon Hausmann.
  28018. * Scripts/build-webkit:
  28019. * Scripts/webkitdirs.pm:
  28020. (determineBaseProductDir):
  28021. (argumentsForConfiguration):
  28022. (usesPerConfigurationBuildDirectory):
  28023. (buildQMakeProject):
  28024. 2011-10-18 Ryosuke Niwa <rniwa@webkit.org>
  28025. Build fix after r97672.
  28026. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  28027. 2011-10-17 Kent Tamura <tkent@chromium.org>
  28028. A follow-up of r97716.
  28029. https://bugs.webkit.org/show_bug.cgi?id=68803
  28030. * DumpRenderTree/chromium/LayoutTestController.cpp:
  28031. (LayoutTestController::reset): Initialize m_dumpCreateView.
  28032. 2011-10-17 Jochen Eisinger <jochen@chromium.org>
  28033. [chromium] add LayoutTestController.dumpCreateView() to monitor calls to WebViewClient::createView
  28034. https://bugs.webkit.org/show_bug.cgi?id=68803
  28035. Reviewed by Nate Chapin.
  28036. * DumpRenderTree/chromium/LayoutTestController.cpp:
  28037. (LayoutTestController::LayoutTestController):
  28038. (LayoutTestController::dumpCreateView):
  28039. * DumpRenderTree/chromium/LayoutTestController.h:
  28040. (LayoutTestController::shouldDumpCreateView):
  28041. * DumpRenderTree/chromium/WebViewHost.cpp:
  28042. (WebViewHost::createView):
  28043. 2011-10-17 Nate Chapin <japhet@chromium.org>
  28044. Add myself to watchlists, and add a watch
  28045. for Source/WebCore/loader/.
  28046. https://bugs.webkit.org/show_bug.cgi?id=70263
  28047. Reviewed by David Levin.
  28048. * Scripts/webkitpy/common/config/watchlist:
  28049. 2011-10-17 Raphael Kubo da Costa <kubo@profusion.mobi>
  28050. [EFL] DRT: Make non-recognized keys work in events as well.
  28051. https://bugs.webkit.org/show_bug.cgi?id=69860
  28052. Reviewed by Antonio Gomes.
  28053. fast/forms/select-type-ahead-non-latin.html is the canonical case we fix
  28054. here: it has a select box with a few non-latin options, and one of them
  28055. is selected via the keyboard.
  28056. In this specific case, we need to make EventHandler::keyEvent send a
  28057. keyPressEvent to SelectElement, so that
  28058. SelectElement::defaultEventHandler calls typeAheadFind(). This happens
  28059. only when PlatformKeyEvent::text() is not empty, which was not the case
  28060. so far.
  28061. * DumpRenderTree/efl/EventSender.cpp:
  28062. (keyDownCallback):
  28063. 2011-10-17 Alok Priyadarshi <alokp@chromium.org>
  28064. Add layout tests for WebPlugin compositor path
  28065. https://bugs.webkit.org/show_bug.cgi?id=69027
  28066. Reviewed by James Robinson.
  28067. * DumpRenderTree/DumpRenderTree.gypi:
  28068. * DumpRenderTree/chromium/TestWebPlugin.cpp: Added.
  28069. (premultiplyAlpha):
  28070. (TestWebPlugin::TestWebPlugin):
  28071. (TestWebPlugin::~TestWebPlugin):
  28072. (TestWebPlugin::mimeType):
  28073. (TestWebPlugin::initialize):
  28074. (TestWebPlugin::destroy):
  28075. (TestWebPlugin::updateGeometry):
  28076. (TestWebPlugin::parsePrimitive):
  28077. (TestWebPlugin::parseColor):
  28078. (TestWebPlugin::parseOpacity):
  28079. (TestWebPlugin::initScene):
  28080. (TestWebPlugin::drawScene):
  28081. (TestWebPlugin::destroyScene):
  28082. (TestWebPlugin::initProgram):
  28083. (TestWebPlugin::initPrimitive):
  28084. (TestWebPlugin::drawPrimitive):
  28085. (TestWebPlugin::loadShader):
  28086. (TestWebPlugin::loadProgram):
  28087. * DumpRenderTree/chromium/TestWebPlugin.h: Added.
  28088. (TestWebPlugin::scriptableObject):
  28089. (TestWebPlugin::paint):
  28090. (TestWebPlugin::updateFocus):
  28091. (TestWebPlugin::updateVisibility):
  28092. (TestWebPlugin::acceptsInputEvents):
  28093. (TestWebPlugin::handleInputEvent):
  28094. (TestWebPlugin::didReceiveResponse):
  28095. (TestWebPlugin::didReceiveData):
  28096. (TestWebPlugin::didFinishLoading):
  28097. (TestWebPlugin::didFailLoading):
  28098. (TestWebPlugin::didFinishLoadingFrameRequest):
  28099. (TestWebPlugin::didFailLoadingFrameRequest):
  28100. (TestWebPlugin::Scene::Scene):
  28101. * DumpRenderTree/chromium/WebViewHost.cpp:
  28102. (WebViewHost::createPlugin):
  28103. 2011-10-17 Ryosuke Niwa <rniwa@webkit.org>
  28104. [nrwt] Add new category for MISSING
  28105. https://bugs.webkit.org/show_bug.cgi?id=69990
  28106. Reviewed by Dirk Pranke.
  28107. Treat missing results as a new category in summerize_results.
  28108. Because Chromium port wants to turn bots red when there are tests with missing results,
  28109. extracted the logic to compute the exit code as exit_code_from_summarized_results in
  28110. base and chromium ports.
  28111. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  28112. * Scripts/webkitpy/layout_tests/port/base.py:
  28113. * Scripts/webkitpy/layout_tests/port/chromium.py:
  28114. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  28115. 2011-10-17 Dimitri Glazkov <dglazkov@chromium.org>
  28116. garden-o-matic operations fail because of CSP.
  28117. https://bugs.webkit.org/show_bug.cgi?id=70249
  28118. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Added gardening server to the policy.
  28119. 2011-10-17 Ada Chan <adachan@apple.com>
  28120. Add a test to call WKPageLoadAlternateHTMLString() with a non-directory URL.
  28121. https://bugs.webkit.org/show_bug.cgi?id=70168
  28122. Reviewed by Alexey Proskuryakov.
  28123. * TestWebKitAPI/Tests/WebKit2/LoadAlternateHTMLStringWithNonDirectoryURL.cpp: Added.
  28124. (TestWebKitAPI::didFinishLoadForFrame):
  28125. (TestWebKitAPI::TEST): Call WKPageLoadAlternateHTMLString() with a file URL and make sure it finishes loading.
  28126. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  28127. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  28128. Add the new file.
  28129. 2011-10-17 Darin Adler <darin@apple.com>
  28130. Add some more *.pyc ignores in directories with Python scripts.
  28131. * QueueStatusServer: Added property svn:ignore.
  28132. * Scripts/webkitpy/common/watchlist: Added property svn:ignore.
  28133. * Scripts/webkitpy/layout_tests/controllers: Added property svn:ignore.
  28134. * Scripts/webkitpy/layout_tests/views: Added property svn:ignore.
  28135. 2011-10-17 Alexis Menard <alexis.menard@openbossa.org>
  28136. [Qt][WK2][meta] Fix failing API tests
  28137. https://bugs.webkit.org/show_bug.cgi?id=70236
  28138. Reviewed by Csaba Osztrogonác.
  28139. In order to run WebKit2 API tests we need the WebProcess to be in
  28140. the path so let's add the bin directory when running the API tests of Qt.
  28141. * Scripts/run-qtwebkit-tests:
  28142. 2011-10-17 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  28143. [Qt][WK2] Build dependency problems
  28144. https://bugs.webkit.org/show_bug.cgi?id=68456
  28145. Reviewed by Csaba Osztrogonác.
  28146. * Scripts/webkitdirs.pm:
  28147. (buildQMakeProject):
  28148. 2011-10-17 Holger Hans Peter Freyther <holger@moiji-mobile.com>
  28149. [build] Introduce Qt/SH4 buildbot
  28150. https://bugs.webkit.org/show_bug.cgi?id=70227
  28151. Reviewed by Adam Roben.
  28152. Add buildslave for Linux/Qt/SH4.
  28153. * BuildSlaveSupport/build.webkit.org-config/config.json:
  28154. 2011-10-16 Adam Barth <abarth@webkit.org>
  28155. Always enable ENABLE(DOM_STORAGE)
  28156. https://bugs.webkit.org/show_bug.cgi?id=70189
  28157. Reviewed by Eric Seidel.
  28158. * Scripts/build-webkit:
  28159. * waf/build/settings.py:
  28160. 2011-10-15 Adam Barth <abarth@webkit.org>
  28161. Rename ENABLE(TILED_BACKING_STORE) to USE(TILED_BACKING_STORE)
  28162. https://bugs.webkit.org/show_bug.cgi?id=70194
  28163. Reviewed by Daniel Bates.
  28164. * Scripts/build-webkit:
  28165. 2011-10-15 Ojan Vafai <ojan@chromium.org>
  28166. run-webkit-tests should accept --child-processes
  28167. https://bugs.webkit.org/show_bug.cgi?id=69713
  28168. Reviewed by Adam Barth.
  28169. Only set --child-processes=1 if --child-processes it not
  28170. passed on the commandline.
  28171. * Scripts/run-webkit-tests:
  28172. 2011-10-15 Daniel Bates <dbates@webkit.org>
  28173. Extract common gdb code into its own function; Remove script gdb-safari
  28174. https://bugs.webkit.org/show_bug.cgi?id=68499
  28175. Reviewed by David Kilzer.
  28176. Almost identical code is used in webkitdirs::{debugMiniBrowser, debugWebKitTestRunner,
  28177. runSafari}() and in the script gdb-safari to launch gdb to debug an application.
  28178. We should extract the common parts into a function that can be shared by all callers
  28179. so as to remove duplicate code.
  28180. As a side effect of removing duplicate code we can remove the script gdb-safari since
  28181. its code has been incorporated into webkitdirs::debugSafari() which is called by the
  28182. script debug-safari.
  28183. * Scripts/debug-safari: Modified to call webkitdirs::debugSafari().
  28184. * Scripts/gdb-safari: Removed.
  28185. * Scripts/webkitdirs.pm:
  28186. (execMacWebKitAppForDebugging): Added; Extracted common debugging code from
  28187. debugMiniBrowser(), debugWebKitTestRunner(), runSafari() and
  28188. script gdb-safari to here.
  28189. (debugSafari): Added.
  28190. (runSafari): Extracted debugging code to debugSafari() and debugMacWebKitApp();
  28191. Also, return the exit status of WebKit launcher (WebKit.exe) on Windows. Currently,
  28192. runSafari() always returns 1 on Windows and the script run-safari exits using this
  28193. value as its exit status. Hence, the script run-safari always exits with a nonzero
  28194. exit status (i.e. abnormal termination) on Windows. Instead, we should return the
  28195. exit status of the WebKit launcher application.
  28196. (debugMiniBrowser): Modified to call debugMacWebKitApp().
  28197. (debugWebKitTestRunner): Ditto.
  28198. 2011-10-15 Robert Hogan <robert@webkit.org>
  28199. [webkit-patch] Put Source/Tools changes at the top of patches, LayoutTests at the bottom
  28200. https://bugs.webkit.org/show_bug.cgi?id=70056
  28201. Reviewed by Adam Barth.
  28202. The preferred file-order for patches is LayoutTests at the end and
  28203. ChangeLogs before everything else in a subdirectory. Specify this in a git 'orderfile' and use
  28204. it when creating patches for review and landing.
  28205. * Scripts/webkitpy/common/checkout/scm/git.py:
  28206. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  28207. * Scripts/webkitpy/common/config/orderfile: Added.
  28208. 2011-10-15 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  28209. [Qt] [Symbian] Remove support for the Symbian platform for the QtWebKit port
  28210. https://bugs.webkit.org/show_bug.cgi?id=69920
  28211. Reviewed by Kenneth Rohde Christiansen.
  28212. * DumpRenderTree/qt/DumpRenderTree.pro:
  28213. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  28214. (WebCore::DumpRenderTree::open):
  28215. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  28216. * QtTestBrowser/QtTestBrowser.pro:
  28217. * QtTestBrowser/launcherwindow.cpp:
  28218. (LauncherWindow::screenshot):
  28219. (LauncherWindow::showFPS):
  28220. (LauncherWindow::updateFPS):
  28221. * QtTestBrowser/launcherwindow.h:
  28222. (WindowOptions::WindowOptions):
  28223. * QtTestBrowser/mainwindow.cpp:
  28224. (MainWindow::buildUI):
  28225. * Scripts/webkitpy/style/checker.py: Remove rules for the
  28226. WebKit/qt/symbian/platformplugin directory.
  28227. * Scripts/webkitpy/style/checker_unittest.py:
  28228. * Tools.pro:
  28229. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  28230. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  28231. (WTR::LayoutTestController::platformInitialize):
  28232. * WebKitTestRunner/qt/TestControllerQt.cpp:
  28233. (WTR::isExistingLibrary):
  28234. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  28235. 2011-10-15 Adam Barth <abarth@webkit.org>
  28236. Fix typo in webkitpy help
  28237. https://bugs.webkit.org/show_bug.cgi?id=70169
  28238. Reviewed by Eric Seidel.
  28239. * Scripts/webkitpy/tool/commands/upload.py:
  28240. 2011-10-15 Tony Chang <tony@chromium.org>
  28241. fix another typo in treemap.html
  28242. https://bugs.webkit.org/show_bug.cgi?id=70149
  28243. Reviewed by Ojan Vafai.
  28244. Fixes a bug where #treemapfocus=LayoutTests%2Fhttp didn't focus the http tests.
  28245. * TestResultServer/static-dashboards/treemap.html:
  28246. 2011-10-14 Adam Barth <abarth@webkit.org>
  28247. Hide status bubbles from queues which are very far behind
  28248. https://bugs.webkit.org/show_bug.cgi?id=70133
  28249. Reviewed by Eric Seidel.
  28250. The mac-ews is so far behind that we shouldn't show its status bubble.
  28251. The status bubble just makes contributors sad.
  28252. * QueueStatusServer/handlers/statusbubble.py:
  28253. 2011-10-14 Dimitri Glazkov <dglazkov@chromium.org>
  28254. Write unit test to ensure style-checker-filter option is passed properly in webkit-patch
  28255. https://bugs.webkit.org/show_bug.cgi?id=70143
  28256. Reviewed by Adam Barth.
  28257. * Scripts/webkitpy/tool/commands/download_unittest.py: Added a test for land-cowboy. Not so cowboy after all.
  28258. * Scripts/webkitpy/tool/steps/checkstyle.py: Fixed a bug, discovered by the newly added test.
  28259. 2011-10-14 David Levin <levin@chromium.org>
  28260. watchlist: Add a validation check for the email names in the list.
  28261. https://bugs.webkit.org/show_bug.cgi?id=70154
  28262. Reviewed by Adam Barth.
  28263. If an email is listed which doesn't have a bugzilla log in, then any emails
  28264. added to the bug along with that email will fail to happen, so try to prevent this
  28265. from happening by validating that emails added to the watchlist are known to be
  28266. contributors.
  28267. * Scripts/webkitpy/common/config/committers.py: Add my other email aliases for bugzilla.
  28268. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add the check.
  28269. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: A unit test for the check.
  28270. 2011-10-14 David Levin <levin@chromium.org>
  28271. watchlist: If the style check fails, then the watchlist will not be run.
  28272. https://bugs.webkit.org/show_bug.cgi?id=69484
  28273. Reviewed by Adam Barth.
  28274. * Scripts/webkitpy/tool/commands/queues.py: Run the watch list even
  28275. if the style part fails and don't allow watch list failures turn the
  28276. bot run red.
  28277. * Scripts/webkitpy/tool/commands/queues_unittest.py: Appropriate unit tests.
  28278. * Scripts/webkitpy/tool/mocktool.py: Add support to make an executive command throw.
  28279. 2011-10-14 Dimitri Glazkov <dglazkov@chromium.org>
  28280. Plumb style-checker filter up to command options and make land-cowboy use it.
  28281. https://bugs.webkit.org/show_bug.cgi?id=70119
  28282. Reviewed by Adam Barth.
  28283. * Scripts/webkitpy/style/checker.py: Added ChangeLogChecker categories to the big list.
  28284. * Scripts/webkitpy/style/checkers/changelog.py: Declared categories, used in ChangeLogChecker.
  28285. * Scripts/webkitpy/tool/commands/download.py: Made LandCowboy use filter.
  28286. * Scripts/webkitpy/tool/commands/download_unittest.py: Tweaked the test.
  28287. * Scripts/webkitpy/tool/commands/upload_unittest.py: Ditto.
  28288. * Scripts/webkitpy/tool/steps/checkstyle.py: Made check_style_filter work.
  28289. * Scripts/webkitpy/tool/steps/options.py: Added new option, check-style-filter.
  28290. 2011-10-14 Sam Weinig <sam@webkit.org>
  28291. Remove the Leopard slaves.
  28292. Reviewed by Adam Roben.
  28293. * BuildSlaveSupport/build.webkit.org-config/config.json:
  28294. 2011-10-14 Peter Beverloo <peter@chromium.org>
  28295. [Chromium] Inherit settings from Chromium's envsetup.sh, address a NDK todo
  28296. https://bugs.webkit.org/show_bug.cgi?id=70028
  28297. Reviewed by Adam Barth.
  28298. * Scripts/update-webkit-chromium:
  28299. * Scripts/webkitdirs.pm:
  28300. (buildChromiumMakefile):
  28301. (buildChromium):
  28302. 2011-10-14 Leandro Pereira <leandro@profusion.mobi>
  28303. Unreviewed; add missing #includes.
  28304. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  28305. * DumpRenderTree/efl/EventSender.cpp:
  28306. 2011-10-14 Raphael Kubo da Costa <kubo@profusion.mobi>
  28307. [EFL] Correctly get the absolute URL in LayoutTestController::queueLoad()
  28308. https://bugs.webkit.org/show_bug.cgi?id=69770
  28309. Reviewed by Antonio Gomes.
  28310. We were just appending the given URL to the absolute URI of the main
  28311. frame, which resulted in "file:///foo/bar/baz.htmltheother/url.html"
  28312. instead of "file:///foo/bar/theother/url.html".
  28313. This should make fast/dom/navigation-type-navigate.html behave
  28314. better (it still fails, but later).
  28315. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  28316. (LayoutTestController::queueLoad):
  28317. 2011-10-13 Arko Saha <arko@motorola.com>
  28318. Microdata: Basic implementation of document.getItems() method.
  28319. https://bugs.webkit.org/show_bug.cgi?id=68610
  28320. Reviewed by Ryosuke Niwa.
  28321. Added ENABLE(MICRODATA) feature flag. Implement document.getItems() DOM API.
  28322. Spec : http://www.whatwg.org/specs/web-apps/current-work/complete/microdata.html
  28323. * Scripts/build-webkit:
  28324. 2011-10-14 Csaba Osztrogonác <ossy@webkit.org>
  28325. new-run-webkit-tests does not support qt-4.8 results
  28326. https://bugs.webkit.org/show_bug.cgi?id=64071
  28327. Roll-back second part of r97252. :)
  28328. * Scripts/webkitpy/layout_tests/port/qt.py:
  28329. 2011-10-14 Raphael Kubo da Costa <kubo@profusion.mobi>
  28330. [EFL] DRT: Do not use OwnFastMallocPtr to manage char*'s.
  28331. https://bugs.webkit.org/show_bug.cgi?id=70106
  28332. Reviewed by Antonio Gomes.
  28333. OwnFastMallocPtr was being used as a smart pointer that automatically called
  28334. free() on the strings returned by the EFL or by ewk.
  28335. However, when WTF is built in release mode, it uses its own memory management
  28336. code instead of using the system malloc(), free() and friends. This means bad
  28337. things will happen when one uses WTF's free() on memory allocated with system
  28338. malloc() by the EFL or ewk.
  28339. The easiest way to solve this is to call free() ourselves.
  28340. * DumpRenderTree/efl/DumpRenderTree.cpp:
  28341. (dumpFramesAsText):
  28342. (getFinalTestURL):
  28343. 2011-10-14 Raphael Kubo da Costa <kubo@profusion.mobi>
  28344. [EFL] Add DumpRenderTreeSupportEfl
  28345. https://bugs.webkit.org/show_bug.cgi?id=68458
  28346. Reviewed by Kenneth Rohde Christiansen.
  28347. Make the calls in DumpRenderTree use DumpRenderTreeSupportEfl.
  28348. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
  28349. (DumpRenderTreeChrome::initialize): Turn on mock scrollbars.
  28350. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  28351. (DumpRenderTreeChrome::onWindowObjectCleared):
  28352. (DumpRenderTreeChrome::onDocumentLoadFinished):
  28353. * DumpRenderTree/efl/GCControllerEfl.cpp:
  28354. (GCController::collect):
  28355. (GCController::collectOnAlternateThread):
  28356. (GCController::getJSObjectCount):
  28357. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  28358. (LayoutTestController::counterValueForElementById):
  28359. (LayoutTestController::pageNumberForElementById):
  28360. (LayoutTestController::numberOfPages):
  28361. (LayoutTestController::workerThreadCount):
  28362. (LayoutTestController::findString):
  28363. (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
  28364. (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
  28365. (LayoutTestController::sampleSVGAnimationForElementAtTime):
  28366. (LayoutTestController::numberOfActiveAnimations):
  28367. (LayoutTestController::suspendAnimations):
  28368. (LayoutTestController::resumeAnimations):
  28369. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
  28370. (createBitmapContextFromWebView):
  28371. 2011-10-14 Csaba Osztrogonác <ossy@webkit.org>
  28372. [Qt] Enable NRWT for Qt 4.8 version too, because it is supported after r97461.
  28373. Unreviewed.
  28374. * Scripts/run-webkit-tests:
  28375. (useNewRunWebKitTests):
  28376. 2011-10-14 Csaba Osztrogonác <ossy@webkit.org>
  28377. new-run-webkit-tests does not support qt-4.8 results
  28378. https://bugs.webkit.org/show_bug.cgi?id=64071
  28379. Roll-back r97252 with unit test fix.
  28380. Reviewed by Csaba Osztrogonác.
  28381. * Scripts/webkitpy/layout_tests/port/qt.py:
  28382. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  28383. 2011-10-13 Ojan Vafai <ojan@chromium.org>
  28384. Make filter-build-webkit exit 1 if the build fails.
  28385. https://bugs.webkit.org/show_bug.cgi?id=70080
  28386. Reviewed by Eric Seidel.
  28387. This only works if you redirect stderr to stdout, but it at least makes it possible.
  28388. This is useful if you want to run a followup command (e.g. run-webkit-tests) but
  28389. only if the build succeeds.
  28390. * Scripts/filter-build-webkit:
  28391. 2011-10-13 Dimitri Glazkov <dglazkov@chromium.org>
  28392. land-cowboy should at least check style.
  28393. https://bugs.webkit.org/show_bug.cgi?id=70073
  28394. Reviewed by Adam Barth.
  28395. * Scripts/webkitpy/tool/commands/download.py: Added CheckStyle step to LandCowboy command.
  28396. 2011-10-13 Tony Chang <tony@chromium.org>
  28397. fix regex in layout test times dashboard
  28398. https://bugs.webkit.org/show_bug.cgi?id=70059
  28399. This fixes the treemapfocus query param.
  28400. Reviewed by Ojan Vafai.
  28401. * TestResultServer/static-dashboards/treemap.html:
  28402. 2011-10-13 Beth Dakin <bdakin@apple.com>
  28403. https://bugs.webkit.org/show_bug.cgi?id=70050
  28404. DRT and WRT should have HiDPI testing capabilities
  28405. Reviewed by Darin Adler.
  28406. New layoutTestController function setBackingScaleFactor takes a double for a scale
  28407. factor and a callback function to call once the backing scale factor has
  28408. successfully been set for the view.
  28409. * DumpRenderTree/LayoutTestController.cpp:
  28410. (setBackingScaleFactorCallback):
  28411. (LayoutTestController::staticFunctions):
  28412. On Mac, setBackingScaleFactor calls WebView _setCustomBackingScaleFactor. Other
  28413. platforms do nothing.
  28414. * DumpRenderTree/LayoutTestController.h:
  28415. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  28416. (LayoutTestController::setBackingScaleFactor):
  28417. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  28418. (LayoutTestController::setBackingScaleFactor):
  28419. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  28420. (LayoutTestController::setBackingScaleFactor):
  28421. Reset the backing scale factor by calling _setCutsomBackingScaleFactor with a
  28422. value of 0, which resets to the system default.
  28423. * DumpRenderTree/mac/DumpRenderTree.mm:
  28424. (resetWebViewToConsistentStateBeforeTesting):
  28425. When generating the pixel dump, create a Bitmap of the appropriate size based on
  28426. the backing scale factor. If it is a HiDPI view, paint into the context using
  28427. displayRectIgnoringOpacity.
  28428. * DumpRenderTree/mac/PixelDumpSupportMac.mm:
  28429. (createBitmapContextFromWebView):
  28430. And now the same stuff for WK2. Again, new layoutTestController function
  28431. setBackingScaleFactor takes a double for a scale factor and a callback function.
  28432. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  28433. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  28434. (WTR::LayoutTestController::setBackingScaleFactor):
  28435. (WTR::LayoutTestController::callSetBackingScaleFactorCallback):
  28436. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  28437. The InjectedBundle sends a message to the UI process to set the backing scale
  28438. factor. It also processes a message the UI process will send back once it
  28439. completes this task, and at that time, the InjectedBundle calls the callback.
  28440. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  28441. (WTR::InjectedBundle::didReceiveMessage):
  28442. (WTR::InjectedBundle::postSetBackingScaleFactor):
  28443. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  28444. Again, reset the backing scale factor by calling WKPageSetCustomBackingScaleFactor
  28445. with a value of 0, which resets to the system default.
  28446. * WebKitTestRunner/TestController.cpp:
  28447. (WTR::TestController::resetStateToConsistentValues):
  28448. Upon receiving the SetBackingScaleFactor message, call
  28449. WKPageSetCustomBackingScaleFactor to the given scale factor, and post a message
  28450. back to InjectedBundle to say it has been done.
  28451. * WebKitTestRunner/TestInvocation.cpp:
  28452. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  28453. Don't use window snapshotting for the HiDPI tests. We don't have a way to fake a
  28454. window's scale factor so we have to avoid that.
  28455. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  28456. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  28457. 2011-10-13 John Knottenbelt <jknotten@chromium.org>
  28458. [Chromium] Allow building without speech input enabled.
  28459. https://bugs.webkit.org/show_bug.cgi?id=69867
  28460. Reviewed by Darin Fisher.
  28461. * DumpRenderTree/chromium/LayoutTestController.cpp:
  28462. (LayoutTestController::addMockSpeechInputResult):
  28463. 2011-10-13 Kent Tamura <tkent@chromium.org>
  28464. [Chromium] A DRT fix for r97348.
  28465. * DumpRenderTree/chromium/LayoutTestController.cpp:
  28466. (LayoutTestController::overridePreference):
  28467. Ignore overridePreference() for "WebKitWebAudioEnabled", and don't
  28468. print an error message.
  28469. 2011-10-12 Lucas Forschler <lforschler@apple.com>
  28470. Update kill-old-processes logic.
  28471. https://bugs.webkit.org/show_bug.cgi?id=63651
  28472. Reviewed by Ryosuke Niwa.
  28473. Remove unused mac platform specific folder.
  28474. Update master.config to use new kill-old-processes.
  28475. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  28476. * BuildSlaveSupport/kill-old-processes:
  28477. * BuildSlaveSupport/mac: Removed.
  28478. 2011-10-12 Ryosuke Niwa <rniwa@webkit.org>
  28479. [NRWT] New tests without expected files are reported as flakey tests
  28480. https://bugs.webkit.org/show_bug.cgi?id=67268
  28481. Reviewed by Dirk Pranke.
  28482. The bug was caused by summarize_results's regarding all tests that have an entry in result_summary
  28483. and no entry in retry_summary as flaky. Since we don't retry missing tests, there will be no entries
  28484. for missing results in retry_summary.
  28485. Fixed the bug by treating missing results separately.
  28486. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  28487. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  28488. 2011-10-12 Adam Barth <abarth@webkit.org>
  28489. Remove ENABLE(XHTMLMP) and associated code
  28490. https://bugs.webkit.org/show_bug.cgi?id=69729
  28491. Reviewed by David Levin.
  28492. * Scripts/build-webkit:
  28493. * Scripts/old-run-webkit-tests:
  28494. * Scripts/webkitperl/features.pm:
  28495. * Scripts/webkitpy/layout_tests/port/webkit.py:
  28496. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  28497. 2011-10-12 Ryosuke Niwa <rniwa@webkit.org>
  28498. Kill old run-webkit-tests processes in kill-process on Mac
  28499. https://bugs.webkit.org/show_bug.cgi?id=69976
  28500. Reviewed by Dirk Pranke.
  28501. Add a system call to remove all python processes running run-webkit-tests.
  28502. * BuildSlaveSupport/kill-old-processes:
  28503. * BuildSlaveSupport/mac: Removed.
  28504. 2011-10-12 Simon Fraser <simon.fraser@apple.com>
  28505. Many WK2 snapshots are blank
  28506. https://bugs.webkit.org/show_bug.cgi?id=69953
  28507. Reviewed by Beth Dakin.
  28508. Two fixes:
  28509. 1. negating a size_t in CGContextTranslateCTM() fails, because
  28510. size_t is unsigned. Fix by casing to CGFloat before negation.
  28511. 2. Turn on window autodisplay, so that compositing tests snapshot correctly.
  28512. Autodisplay is necessary to kick off Core Animation rendering.
  28513. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  28514. (WTR::createCGContextFromImage):
  28515. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  28516. (WTR::PlatformWebView::PlatformWebView):
  28517. 2011-10-12 Adam Barth <abarth@webkit.org>
  28518. commit-queue doesn't have a friendly error message when the reviewer line is messed up
  28519. https://bugs.webkit.org/show_bug.cgi?id=69979
  28520. Reviewed by Eric Seidel.
  28521. Rather than combining the ChangeLog validation with a more complicated
  28522. command, this patch has the commit-queue run it as a separate command,
  28523. which will give us more control over the error message.
  28524. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  28525. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  28526. * Scripts/webkitpy/tool/commands/download.py:
  28527. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  28528. * Scripts/webkitpy/tool/steps/validatechangelogs.py:
  28529. * Scripts/webkitpy/tool/steps/validatereviewer.py:
  28530. 2011-10-12 Eric Seidel <eric@webkit.org>
  28531. Layout tests asserting in LayoutTestController::pathToLocalResource()
  28532. https://bugs.webkit.org/show_bug.cgi?id=69898
  28533. Reviewed by Simon Fraser.
  28534. old-run-webkit-tests just didn't know to set LOCAL_RESOURCE_ROOT, oops.
  28535. * Scripts/old-run-webkit-tests:
  28536. (openDumpTool):
  28537. 2011-10-12 Adam Barth <abarth@webkit.org>
  28538. The commit-queue doesn't tell me which tests my patch broke
  28539. https://bugs.webkit.org/show_bug.cgi?id=69975
  28540. Reviewed by Eric Seidel.
  28541. We now print the list of newly failing tests, like we do for the EWS.
  28542. * Scripts/webkitpy/tool/commands/queues.py:
  28543. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  28544. 2011-10-10 Alice Boxhall <aboxhall@chromium.org>
  28545. Added myself as a committer.
  28546. * Scripts/webkitpy/common/config/committers.py:
  28547. 2011-10-12 Adam Barth <abarth@webkit.org>
  28548. _run_tests is a confusing variable name in webkitpy
  28549. https://bugs.webkit.org/show_bug.cgi?id=69971
  28550. Reviewed by Eric Seidel.
  28551. Eric and I thought this was a function.
  28552. * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  28553. 2011-10-12 Tony Chang <tony@chromium.org>
  28554. Fix test-webkitpy after r97307 and r97293.
  28555. * Scripts/webkitpy/layout_tests/port/chromium.py: options.time_out_ms
  28556. is None during tests so add back the check.
  28557. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py: The
  28558. output directory is now build/Debug.
  28559. 2011-10-12 Tony Chang <tony@chromium.org>
  28560. [chromium] remove old build dirs on chromium-win
  28561. https://bugs.webkit.org/show_bug.cgi?id=69961
  28562. Reviewed by Adam Barth.
  28563. * Scripts/webkitpy/layout_tests/port/chromium_win.py: Output is now
  28564. always in build and never in chrome or webkit.
  28565. 2011-10-12 Dimitri Glazkov <dglazkov@chromium.org>
  28566. garden-o-matic's "Expect Failure" button does not work correctly, so we should remove it until the plumbing is fixed to avoid landmines.
  28567. https://bugs.webkit.org/show_bug.cgi?id=69954
  28568. Also renamed the action and associated event name to address an FIXME.
  28569. Reviewed by Adam Barth.
  28570. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed event name.
  28571. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Renamed the action.
  28572. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Removed action temporarily.
  28573. 2011-10-12 Tony Chang <tony@chromium.org>
  28574. stop spamming 'stopping test driver timed out, killing it' when running rwt
  28575. https://bugs.webkit.org/show_bug.cgi?id=69938
  28576. Reviewed by Adam Barth.
  28577. In http://trac.webkit.org/changeset/95875 , we made the timeout for
  28578. stopping the driver based on time_out_ms, but we based it on the wrong
  28579. default times.
  28580. * Scripts/webkitpy/layout_tests/port/chromium.py:
  28581. 2011-10-12 Simon Fraser <simon.fraser@apple.com>
  28582. 3D transforms are flattened in WebKit2 snapshots
  28583. https://bugs.webkit.org/show_bug.cgi?id=68276
  28584. Reviewed by Adam Roben.
  28585. Fix WKImage leak noticed by Adam.
  28586. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  28587. (WTR::PlatformWebView::windowSnapshotImage):
  28588. 2011-10-12 Dimitri Glazkov <dglazkov@chromium.org>
  28589. garden-o-matic should color-code test failure types.
  28590. https://bugs.webkit.org/show_bug.cgi?id=69945
  28591. Reviewed by Adam Barth.
  28592. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added an extra span for styling.
  28593. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
  28594. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Ditto.
  28595. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added color-coding.
  28596. 2011-10-12 Adam Barth <abarth@webkit.org>
  28597. webkitpy tests are failing on Mac bots
  28598. https://bugs.webkit.org/show_bug.cgi?id=69929
  28599. Reviewed by Simon Fraser.
  28600. Admit that Lion exists.
  28601. * Scripts/webkitpy/layout_tests/port/chromium.py:
  28602. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  28603. 2011-10-12 Simon Fraser <simon.fraser@apple.com>
  28604. Improve output of run-api-tests to make time-outs more obvious
  28605. https://bugs.webkit.org/show_bug.cgi?id=69788
  28606. Reviewed by Adam Roben.
  28607. List the tests that failed and timed out at the bottom of the output,
  28608. if run with --verbose.
  28609. * Scripts/run-api-tests:
  28610. (runAllTests):
  28611. (runTest):
  28612. 2011-10-12 Sheriff Bot <webkit.review.bot@gmail.com>
  28613. Unreviewed, rolling out r97252.
  28614. http://trac.webkit.org/changeset/97252
  28615. https://bugs.webkit.org/show_bug.cgi?id=69944
  28616. Broke test-webkpy (Requested by abarth on #webkit).
  28617. * Scripts/webkitpy/layout_tests/port/qt.py:
  28618. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  28619. 2011-10-12 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  28620. new-run-webkit-tests does not support qt-4.8 results
  28621. https://bugs.webkit.org/show_bug.cgi?id=64071
  28622. Reviewed by Csaba Osztrogonác.
  28623. * Scripts/webkitpy/layout_tests/port/qt.py:
  28624. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  28625. 2011-10-10 Martin Robinson <mrobinson@igalia.com>
  28626. [GTK] [WebKit2] Make adding another unit test easier
  28627. https://bugs.webkit.org/show_bug.cgi?id=69409
  28628. Reviewed by Gustavo Noronha Silva.
  28629. * Scripts/run-gtk-tests: Update run-gtk-tests to be able to execute
  28630. new WebKit2 tests.
  28631. 2011-10-11 Takashi Toyoshima <toyoshim@chromium.org>
  28632. [WebSocket] update pywebsocket to 0.6b6.
  28633. https://bugs.webkit.org/show_bug.cgi?id=69824
  28634. Reviewed by Kent Tamura.
  28635. WebKit supports WebSocket with version 8 based protocol for now.
  28636. We should update its protocol to version 13 based one like hybi-17.
  28637. pywebsocket 0.6b6 supports both of version 8 and 13.
  28638. * Scripts/webkitpy/thirdparty/__init__.py:
  28639. 2011-10-11 Simon Fraser <simon.fraser@apple.com>
  28640. WebKitTestRunner needs to link with WebKit for NSURL category methods
  28641. https://bugs.webkit.org/show_bug.cgi?id=69892
  28642. Reviewed by Sam Weinig.
  28643. WebDragClient::declareAndWriteDragImage() was throwing an Obj-C exception on 10.6 because
  28644. the +_web_originalDataAsString selector on NSURL was not recognized. Link with
  28645. WebKit.framework to fix this.
  28646. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  28647. 2011-10-11 Adam Barth <abarth@webkit.org>
  28648. sheriffbot takes too long to acknowledge rollout commands
  28649. https://bugs.webkit.org/show_bug.cgi?id=69871
  28650. Reviewed by Eric Seidel.
  28651. We used to update the working copy before acknowledging the command
  28652. because we wanted to ping all the relevant IRC nicks. That's caused a
  28653. bunch of frustration because folks don't know whether the bot has heard
  28654. their commands.
  28655. This patch makes the bot reply immediately before updating the working
  28656. copy. All the relevenat folks are still pinged when the bot finishes
  28657. preparing the rollout.
  28658. * Scripts/webkitpy/tool/bot/irc_command.py:
  28659. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  28660. 2011-10-11 Adam Barth <abarth@webkit.org>
  28661. test-webkitpy fails on Lion
  28662. https://bugs.webkit.org/show_bug.cgi?id=69873
  28663. Reviewed by Eric Seidel.
  28664. This patch fixes one of the two failures. I'll need to track down the
  28665. other failure another time.
  28666. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  28667. 2011-10-11 Adam Barth <abarth@webkit.org>
  28668. garden-o-matic should warn me when run-webkit-tests errors out (e.g., due to python screw-ups)
  28669. https://bugs.webkit.org/show_bug.cgi?id=65230
  28670. Reviewed by Dimitri Glazkov.
  28671. This patch causes us to treat crashed or hung run-webkit-tests runs
  28672. similarly to how we treat compile failures. In some sense, they're
  28673. similar because they prevent us from getting test coverage.
  28674. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
  28675. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  28676. 2011-10-11 Adam Barth <abarth@webkit.org>
  28677. Failing builder display in garden-o-matic should have the same visual style as the failure grid
  28678. https://bugs.webkit.org/show_bug.cgi?id=69876
  28679. Reviewed by Dimitri Glazkov.
  28680. This patch generalizes the view we use for failing builders in the
  28681. FailureGrid so that we can use it for the list of builders that aren't
  28682. compiling.
  28683. One downside of this patch is that it makes it harder to tell when
  28684. debug builders are failing (as opposed to release builders) because
  28685. that information isn't presented in this view. A future patch will
  28686. improve this aspect.
  28687. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  28688. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  28689. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  28690. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  28691. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css:
  28692. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
  28693. 2011-10-11 Filip Pizlo <fpizlo@apple.com>
  28694. Some API tests are timing out in Release
  28695. https://bugs.webkit.org/show_bug.cgi?id=69787
  28696. Reviewed by Mark Rowe.
  28697. NDEBUG must be set in release builds. Otherwise the world breaks. Also added some
  28698. magic to ensure that GTest builds in release mode in clang with NDEBUG set.
  28699. * TestWebKitAPI/Configurations/Base.xcconfig:
  28700. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  28701. * TestWebKitAPI/config.h:
  28702. 2011-10-11 Adam Barth <abarth@webkit.org>
  28703. garden-o-matic links to flakiness dashboard should open in a new tab
  28704. https://bugs.webkit.org/show_bug.cgi?id=69864
  28705. Reviewed by Dimitri Glazkov.
  28706. This bug was obvious in the first five minutes of using this new
  28707. feature. :)
  28708. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  28709. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  28710. 2011-10-11 Adam Barth <abarth@webkit.org>
  28711. Tweak the Content-Security-Policy for garden-o-matic. It turns out
  28712. that * doesn't really mean "all". I've emailed the W3C working group
  28713. about changing the spec.
  28714. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  28715. 2011-10-11 Adam Barth <abarth@webkit.org>
  28716. garden-o-matic should link to the flakiness dashboard
  28717. https://bugs.webkit.org/show_bug.cgi?id=69862
  28718. Reviewed by Dimitri Glazkov.
  28719. The flakiness dashboard has lots of great information about the failure
  28720. history of each test. This patch adds a link from garden-o-matic to
  28721. the flakiness dashboard so the gardener can look at this information.
  28722. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  28723. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  28724. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  28725. 2011-10-11 David Levin <levin@chromium.org>
  28726. watchlist: assertRaisesRegexp implementation should be compatible with python 2.7.
  28727. https://bugs.webkit.org/show_bug.cgi?id=69789
  28728. Reviewed by Eric Seidel.
  28729. Made the signature of _assertRaisesRegexp match that of Python 2.7.
  28730. * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Adjusted to be compatible with Python 2.7.
  28731. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Ditto.
  28732. * Scripts/webkitpy/common/webkitunittest.py: Ditto.
  28733. * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Ditto.
  28734. 2011-10-11 Raphael Kubo da Costa <kubo@profusion.mobi>
  28735. [EFL] DRT: Do not abort() when an unknown key is pressed.
  28736. https://bugs.webkit.org/show_bug.cgi?id=69856
  28737. Reviewed by Antonio Gomes.
  28738. A lot of tests crash due to the previous behaviour. Just using the
  28739. received name of the pressed key works most of the time, and when it
  28740. does not the failing tests should tell us.
  28741. * DumpRenderTree/efl/EventSender.cpp:
  28742. (keyPadNameFromJSValue):
  28743. (keyNameFromJSValue):
  28744. (keyDownCallback):
  28745. 2011-10-11 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  28746. [Qt] [WK2] NRWT failed to launch MiniBrowser after test run
  28747. https://bugs.webkit.org/show_bug.cgi?id=68016
  28748. Reviewed by Chang Shu.
  28749. * Scripts/webkitpy/layout_tests/port/qt.py:
  28750. 2011-10-11 Raphael Kubo da Costa <kubo@profusion.mobi>
  28751. [EFL] DRT: Return the right window count in LayoutTestController.
  28752. https://bugs.webkit.org/show_bug.cgi?id=69764
  28753. Reviewed by Antonio Gomes.
  28754. Follow-up to r96943: now that we have DumpRenderTreeChrome and
  28755. DumpRenderTreeView in the tree, we can correctly count the number of
  28756. open windows in DRT.
  28757. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  28758. (LayoutTestController::windowCount):
  28759. 2011-10-11 Jer Noble <jer.noble@apple.com>
  28760. REGRESSION (r96770-r96777): fast/dom/Window/window-properties.html, fast/dom/prototype-inheritance-2.html, fast/js/global-constructors.html failing on SnowLeopard Intel Release (Tests)
  28761. https://bugs.webkit.org/show_bug.cgi?id=69800
  28762. Reviewed by Csaba Osztrogonác.
  28763. Enable WEB_AUDIO at runtime.
  28764. * DumpRenderTree/mac/DumpRenderTree.mm:
  28765. (resetDefaultsToConsistentValues):
  28766. 2011-10-11 Raphael Kubo da Costa <kubo@profusion.mobi>
  28767. [EFL] DRT: Make sure IconDatabase is closed before trying to open it again.
  28768. https://bugs.webkit.org/show_bug.cgi?id=69769
  28769. Reviewed by Antonio Gomes.
  28770. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  28771. (LayoutTestController::setIconDatabaseEnabled):
  28772. 2011-10-11 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  28773. [Qt] Remove all references to QTDIR_build and standalone_package
  28774. Qt is now modularized, which means we no longer import WebKit into
  28775. the Qt source tree. Instead we use git submodules, and building
  28776. QtWebKit as "part of Qt" is really building QtWebKit as from trunk.
  28777. To decrease the number of buildsystem configurations we also remove
  28778. the standalone_package code-path used when we were providing tarballs
  28779. with the derived sources pre-generated.
  28780. Reviewed by Simon Hausmann.
  28781. * MiniBrowser/qt/MiniBrowser.pro:
  28782. * QtTestBrowser/QtTestBrowser.pro:
  28783. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  28784. 2011-10-11 Dominic Mazzoni <dmazzoni@google.com>
  28785. Update Chromium accessibility support in DRT.
  28786. https://bugs.webkit.org/show_bug.cgi?id=69676
  28787. Reviewed by Chris Fleizach.
  28788. Adds several missing properties and methods to enable more
  28789. tests to pass, and in particular adds support for notification
  28790. callbacks.
  28791. * DumpRenderTree/chromium/AccessibilityController.cpp:
  28792. (AccessibilityController::AccessibilityController):
  28793. (AccessibilityController::reset):
  28794. (AccessibilityController::getFocusedElement):
  28795. (AccessibilityController::shouldLogAccessibilityEvents):
  28796. (AccessibilityController::notificationReceived):
  28797. (AccessibilityController::logAccessibilityEventsCallback):
  28798. * DumpRenderTree/chromium/AccessibilityController.h:
  28799. * DumpRenderTree/chromium/AccessibilityUIElement.cpp:
  28800. (getHelpText):
  28801. (getStringValue):
  28802. (getOrientation):
  28803. (AccessibilityUIElement::AccessibilityUIElement):
  28804. (AccessibilityUIElement::getChildAtIndex):
  28805. (AccessibilityUIElement::isEqual):
  28806. (AccessibilityUIElement::notificationReceived):
  28807. (AccessibilityUIElement::roleGetterCallback):
  28808. (AccessibilityUIElement::titleGetterCallback):
  28809. (AccessibilityUIElement::descriptionGetterCallback):
  28810. (AccessibilityUIElement::helpTextGetterCallback):
  28811. (AccessibilityUIElement::stringValueGetterCallback):
  28812. (AccessibilityUIElement::xGetterCallback):
  28813. (AccessibilityUIElement::yGetterCallback):
  28814. (AccessibilityUIElement::widthGetterCallback):
  28815. (AccessibilityUIElement::heightGetterCallback):
  28816. (AccessibilityUIElement::intValueGetterCallback):
  28817. (AccessibilityUIElement::minValueGetterCallback):
  28818. (AccessibilityUIElement::maxValueGetterCallback):
  28819. (AccessibilityUIElement::childrenCountGetterCallback):
  28820. (AccessibilityUIElement::insertionPointLineNumberGetterCallback):
  28821. (AccessibilityUIElement::selectedTextRangeGetterCallback):
  28822. (AccessibilityUIElement::isEnabledGetterCallback):
  28823. (AccessibilityUIElement::isRequiredGetterCallback):
  28824. (AccessibilityUIElement::isFocusedGetterCallback):
  28825. (AccessibilityUIElement::isFocusableGetterCallback):
  28826. (AccessibilityUIElement::isSelectedGetterCallback):
  28827. (AccessibilityUIElement::isSelectableGetterCallback):
  28828. (AccessibilityUIElement::isMultiSelectableGetterCallback):
  28829. (AccessibilityUIElement::isExpandedGetterCallback):
  28830. (AccessibilityUIElement::isCheckedGetterCallback):
  28831. (AccessibilityUIElement::isVisibleGetterCallback):
  28832. (AccessibilityUIElement::isOffScreenGetterCallback):
  28833. (AccessibilityUIElement::isCollapsedGetterCallback):
  28834. (AccessibilityUIElement::hasPopupGetterCallback):
  28835. (AccessibilityUIElement::isValidGetterCallback):
  28836. (AccessibilityUIElement::orientationGetterCallback):
  28837. (AccessibilityUIElement::showMenuCallback):
  28838. (AccessibilityUIElement::pressCallback):
  28839. (AccessibilityUIElement::isEqualCallback):
  28840. (AccessibilityUIElement::addNotificationListenerCallback):
  28841. (AccessibilityUIElement::removeNotificationListenerCallback):
  28842. (AccessibilityUIElement::takeFocusCallback):
  28843. (AccessibilityUIElement::fallbackCallback):
  28844. (RootAccessibilityUIElement::getChildAtIndex):
  28845. (AccessibilityUIElementList::getOrCreate):
  28846. * DumpRenderTree/chromium/AccessibilityUIElement.h:
  28847. * DumpRenderTree/chromium/CppVariant.cpp:
  28848. (CppVariant::invokeDefault):
  28849. * DumpRenderTree/chromium/CppVariant.h:
  28850. * DumpRenderTree/chromium/LayoutTestController.cpp:
  28851. (LayoutTestController::LayoutTestController):
  28852. (LayoutTestController::reset):
  28853. * DumpRenderTree/chromium/LayoutTestController.h:
  28854. * DumpRenderTree/chromium/WebViewHost.cpp:
  28855. (WebViewHost::postAccessibilityNotification):
  28856. 2011-10-10 Adam Klein <adamk@chromium.org>
  28857. Support Distributed-CompileC as an action name in filter-build-webkit
  28858. https://bugs.webkit.org/show_bug.cgi?id=69783
  28859. Reviewed by Ojan Vafai.
  28860. * Scripts/filter-build-webkit:
  28861. 2011-10-10 Simon Fraser <simon.fraser@apple.com>
  28862. 3D transforms are flattened in WebKit2 snapshots
  28863. https://bugs.webkit.org/show_bug.cgi?id=68276
  28864. Reviewed by Anders Carlsson.
  28865. Use a snapshot of the window, rather than an image from the web process
  28866. for pixel testing in WebKitTestRunner. This correctly captures compositing
  28867. layers, so works for 3D transform tests.
  28868. * WebKitTestRunner/PlatformWebView.h: Add a windowSnapshotImage() method.
  28869. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  28870. (WTR::createCGContextFromImage): Add a param to optionally flip the image when drawing.
  28871. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Call windowSnapshotImage(), and if it returns an image,
  28872. use that instead of the image we get from the web process.
  28873. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
  28874. (WTR::PlatformWebView::windowSnapshotImage): Stub out the new method.
  28875. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  28876. (WTR::PlatformWebView::windowSnapshotImage): Ditto.
  28877. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  28878. (WTR::PlatformWebView::windowSnapshotImage): Ditto.
  28879. * WebKitTestRunner/win/PlatformWebViewWin.cpp:
  28880. (WTR::PlatformWebView::windowSnapshotImage): Ditto.
  28881. 2011-10-10 David Levin <levin@chromium.org>
  28882. Quick fix for watchlist unit test failures when using Python 2.7+
  28883. Reviewed by Adam Barth.
  28884. Filed bug https://bugs.webkit.org/show_bug.cgi?id=69789 about a
  28885. better fix.
  28886. * Scripts/webkitpy/common/webkitunittest.py: Always use our
  28887. version of assertRaisesRegexp.
  28888. 2011-10-10 Sheriff Bot <webkit.review.bot@gmail.com>
  28889. Unreviewed, rolling out r97082.
  28890. http://trac.webkit.org/changeset/97082
  28891. https://bugs.webkit.org/show_bug.cgi?id=69784
  28892. broke Windows build (Requested by smfr on #webkit).
  28893. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  28894. * WebKitTestRunner/cg/TestInvocationCG.cpp: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.mm.
  28895. (WTR::createCGContextFromImage):
  28896. (WTR::computeMD5HashStringForContext):
  28897. (WTR::dumpBitmap):
  28898. (WTR::paintRepaintRectOverlay):
  28899. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  28900. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  28901. (WTR::PlatformWebView::PlatformWebView):
  28902. 2011-10-10 Simon Fraser <simon.fraser@apple.com>
  28903. 3D transforms are flattened in WebKit2 snapshots
  28904. https://bugs.webkit.org/show_bug.cgi?id=68276
  28905. Reviewed by Anders Carlsson.
  28906. The WKImage passed from the WebProcess when pixel dumping is created by painting compositing layers
  28907. flattened, which flattens 3D transforms. Instead, use CGWindowListCreateImage() to get a snapshot of
  28908. the window when doing pixel tests.
  28909. Also allow the window to auto-display, so that Core Animation layers are rendered, and animate.
  28910. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: TestInvocationCG became a .mm file
  28911. * WebKitTestRunner/cg/TestInvocationCG.mm: Renamed from Tools/WebKitTestRunner/cg/TestInvocationCG.cpp.
  28912. (WTR::createBitmapCGContext): Utility function to create a bitmap context.
  28913. (WTR::computeMD5HashStringForContext):
  28914. (WTR::dumpBitmap):
  28915. (WTR::paintRepaintRectOverlay):
  28916. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Use CGWindowListCreateImage() to
  28917. grap a snapshot of the window, rather than relying on the WKImage which was passed from the web process.
  28918. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  28919. (WTR::PlatformWebView::PlatformWebView): Remove the line that turned off autoDisplay for the NSWindow.
  28920. We need the window to autodisplay for Core Animation to render layers and start animations.
  28921. 2011-10-10 Simon Fraser <simon.fraser@apple.com>
  28922. WebKitTestRunner needs layoutTestController.setWindowIsKey
  28923. https://bugs.webkit.org/show_bug.cgi?id=42688
  28924. Reviewed by Anders Carlsson.
  28925. Implement layoutTestController.setWindowIsKey() in WebKitTestRunner.
  28926. This sets a flag that the platform layer uses to indicate that
  28927. the window is the key window, which fixes focus ring drawing
  28928. in pixel results.
  28929. Also focus the web view when we get a 'didCommitLoad' for the main
  28930. frame, as DumpRenderTree does.
  28931. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  28932. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  28933. (WTR::InjectedBundle::postSetWindowIsKey):
  28934. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  28935. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  28936. (WTR::cacheLayoutTestControllerCallback): Replace some magic numbers with an enum.
  28937. (WTR::LayoutTestController::addChromeInputField):
  28938. (WTR::LayoutTestController::removeChromeInputField):
  28939. (WTR::LayoutTestController::focusWebView):
  28940. (WTR::LayoutTestController::setWindowIsKey):
  28941. (WTR::LayoutTestController::callAddChromeInputFieldCallback):
  28942. (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
  28943. (WTR::LayoutTestController::callFocusWebViewCallback):
  28944. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  28945. * WebKitTestRunner/PlatformWebView.h: Add an NSWindow subclass
  28946. so that we can override -isKeyWindow. Use a boolean member variable
  28947. to track window key status.
  28948. (WTR::PlatformWebView::setWindowIsKey):
  28949. (WTR::PlatformWebView::windowIsKey):
  28950. * WebKitTestRunner/TestController.cpp:
  28951. (WTR::TestController::runModal): Change the window key status when showing a modal alert, as DRT does.
  28952. (WTR::closeOtherPage): Use the same cast as other functions.
  28953. (WTR::focus): Implement to call setWindowIsKey(true)
  28954. (WTR::unfocus): Implement to call setWindowIsKey(false)
  28955. (WTR::TestController::createOtherPage): Add page callbacks for focus and unfocus.
  28956. (WTR::TestController::initialize):
  28957. (WTR::TestController::didCommitLoadForFrame): Hook up callback to focus the web view, as DRT does.
  28958. * WebKitTestRunner/TestController.h:
  28959. * WebKitTestRunner/TestInvocation.cpp:
  28960. (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
  28961. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
  28962. (WTR::PlatformWebView::PlatformWebView):
  28963. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  28964. (-[WebKitTestRunnerWindow isKeyWindow]):
  28965. (WTR::PlatformWebView::PlatformWebView): Make a WebKitTestRunnerWindow.
  28966. (WTR::PlatformWebView::~PlatformWebView): Clean up the back pointer on the NSWindow subclass, in case it outlives us.
  28967. (WTR::PlatformWebView::focus): Set the view as the first responder, and the window as the key window, as DRT does.
  28968. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  28969. (WTR::PlatformWebView::PlatformWebView):
  28970. * WebKitTestRunner/win/PlatformWebViewWin.cpp:
  28971. (WTR::PlatformWebView::PlatformWebView):
  28972. 2011-10-10 Raphael Kubo da Costa <kubo@profusion.mobi>
  28973. check-webkit-style: Add readability exception for Ewk_* data types.
  28974. https://bugs.webkit.org/show_bug.cgi?id=69763
  28975. Reviewed by David Levin.
  28976. Many EFL-related files (such as EditorClientEfl.h or
  28977. DumpRenderTreeSupportEfl.h) need to have declarations such as "typedef
  28978. struct _Ewk_Foo Ewk_Foo", which currently produce false positives in
  28979. check-webkit-style.
  28980. Add an exception for them, just like there are exceptions for
  28981. Evas_*, Ecore_* and others.
  28982. * Scripts/webkitpy/style/checkers/cpp.py:
  28983. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  28984. 2011-10-10 Dominic Mazzoni <dmazzoni@google.com>
  28985. [Chromium] Get rid of WebAccessibilityCache.
  28986. https://bugs.webkit.org/show_bug.cgi?id=68224
  28987. Reviewed by Dimitri Glazkov.
  28988. * DumpRenderTree/chromium/AccessibilityController.cpp:
  28989. (AccessibilityController::bindToJavascript):
  28990. 2011-10-09 Adam Barth <abarth@webkit.org>
  28991. Remove "near miss" XSS vulnerabilities in garden-o-matic
  28992. https://bugs.webkit.org/show_bug.cgi?id=69708
  28993. Reviewed by David Levin.
  28994. Collin Jackson did a security audit of garden-o-matic. He hasn't found
  28995. any actual vulnerabilities yet, but he did identify a couple "near
  28996. misses" where a slight change in garden-o-matic could lead to a
  28997. vulnerability. This patch removes those potential issues.
  28998. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
  28999. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  29000. 2011-10-07 Adam Barth <abarth@webkit.org>
  29001. Add a Content-Security-Policy to garden-o-matic
  29002. https://bugs.webkit.org/show_bug.cgi?id=69668
  29003. Reviewed by David Levin.
  29004. This will help mitigate cross-site script and will also help us dogfood CSP.
  29005. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  29006. 2011-10-07 Raphael Kubo da Costa <kubo@profusion.mobi>
  29007. [EFL] DRT: Add DumpRenderTreeChrome.{cpp,h}
  29008. https://bugs.webkit.org/show_bug.cgi?id=66380
  29009. Reviewed by Antonio Gomes.
  29010. This encapsulates EWebKit into an object that manages multiple windows
  29011. and provides a cleaner interface to EFL's DumpRenderTree.
  29012. * DumpRenderTree/efl/DumpRenderTreeChrome.cpp: Added.
  29013. (DumpRenderTreeChrome::create):
  29014. (DumpRenderTreeChrome::DumpRenderTreeChrome):
  29015. (DumpRenderTreeChrome::~DumpRenderTreeChrome):
  29016. (DumpRenderTreeChrome::createNewWindow):
  29017. (DumpRenderTreeChrome::createView):
  29018. (DumpRenderTreeChrome::removeWindow):
  29019. (DumpRenderTreeChrome::initialize):
  29020. (DumpRenderTreeChrome::extraViews):
  29021. (DumpRenderTreeChrome::mainFrame):
  29022. (DumpRenderTreeChrome::mainView):
  29023. (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
  29024. (DumpRenderTreeChrome::onWindowObjectCleared):
  29025. (DumpRenderTreeChrome::onLoadStarted):
  29026. (DumpRenderTreeChrome::processWork):
  29027. (DumpRenderTreeChrome::onLoadFinished):
  29028. (DumpRenderTreeChrome::onStatusbarTextSet):
  29029. (DumpRenderTreeChrome::onTitleChanged):
  29030. (DumpRenderTreeChrome::onDocumentLoadFinished):
  29031. * DumpRenderTree/efl/DumpRenderTreeChrome.h: Added.
  29032. * DumpRenderTree/efl/EventSender.cpp:
  29033. (sendClick): Use browser->mainFrame() instead of mainFrame.
  29034. (mouseDownCallback): Ditto.
  29035. (mouseUpCallback): Ditto.
  29036. (mouseMoveToCallback): Ditto.
  29037. (mouseScrollByCallback): Ditto.
  29038. (keyDownCallback): Ditto.
  29039. (scalePageByCallback): Ditto.
  29040. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  29041. (LayoutTestController::counterValueForElementById): Use
  29042. browser->mainFrame() instead of mainFrame.
  29043. (LayoutTestController::pageNumberForElementById): Ditto.
  29044. (LayoutTestController::numberOfPages): Ditto.
  29045. (LayoutTestController::pauseAnimationAtTimeOnElementWithId): Ditto.
  29046. (LayoutTestController::pauseTransitionAtTimeOnElementWithId): Ditto.
  29047. (LayoutTestController::sampleSVGAnimationForElementAtTime): Ditto.
  29048. (LayoutTestController::numberOfActiveAnimations): Ditto.
  29049. (LayoutTestController::suspendAnimations): Ditto.
  29050. (LayoutTestController::resumeAnimations): Ditto.
  29051. (LayoutTestController::setWebViewEditable): Ditto.
  29052. (LayoutTestController::webHistoryItemCount): Use browser->mainView()
  29053. instead of browser.
  29054. (LayoutTestController::queueLoad): Ditto.
  29055. (LayoutTestController::setAcceptsEditing): Ditto.
  29056. (LayoutTestController::setUserStyleSheetEnabled): Ditto.
  29057. (LayoutTestController::setPrivateBrowsingEnabled): Ditto.
  29058. (LayoutTestController::setFrameFlatteningEnabled): Ditto.
  29059. (LayoutTestController::setSpatialNavigationEnabled): Ditto.
  29060. (LayoutTestController::setPluginsEnabled): Ditto.
  29061. (LayoutTestController::findString): Ditto.
  29062. (LayoutTestController::setDeveloperExtrasEnabled): Ditto.
  29063. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
  29064. (createBitmapContextFromWebView): Use browser->mainFrame() instead of
  29065. mainFrame.
  29066. * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
  29067. (LoadItem::invoke): Ditto.
  29068. (LoadHTMLStringItem::invoke): Ditto.
  29069. (ScriptItem::invoke): Ditto.
  29070. (ReloadItem::invoke): Use browser->mainView() instead of browser.
  29071. 2011-10-07 Simon Hausmann <simon.hausmann@nokia.com>
  29072. [Qt][WK2] Touch mocking is broken with Qt 5 post refactor merge
  29073. https://bugs.webkit.org/show_bug.cgi?id=69617
  29074. Reviewed by Andreas Kling.
  29075. Injecting fake touch events using qt_translateRawTouchEvent does not work anymore, as it sends
  29076. the touch events to widgets only. The QML view however is a QWindow. Therefore the fake touch
  29077. events have to be dispatched through QWindowSystemInterface::handleTouchEvent. As a result the
  29078. events appear to be spontaenous, which required adjusting the are-we-on-a-real-touch-device
  29079. logic.
  29080. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  29081. (MiniBrowserApplication::MiniBrowserApplication):
  29082. (MiniBrowserApplication::notify):
  29083. * MiniBrowser/qt/MiniBrowserApplication.h:
  29084. 2011-10-06 Adam Barth <abarth@webkit.org>
  29085. Port PixelZoomer to work in garden-o-matic
  29086. https://bugs.webkit.org/show_bug.cgi?id=69577
  29087. Reviewed by David Levin.
  29088. This implementation of PixelZoomer is basically a fork of the
  29089. implementation used by results.html. These two apps have different
  29090. requirements on where this code lives. results.html wants to be
  29091. self-contained whereas garden-o-matic wants to live in the public_html
  29092. folder of the buildbot. We could do something fancy here to share the
  29093. code, but that's not likely to be of much benefit.
  29094. I had to change a few things about pixelzoomer to accounter for the
  29095. differences in DOM between results.html and garden-o-matic, but
  29096. surprisingly little. I also moved all the code into an anonymous
  29097. function, which is the style we're suing for module separation in
  29098. garden-o-matic. Finally, some jQuery-ims snuck in because I didn't
  29099. want to drag along too many extra functions from results.html.
  29100. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  29101. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  29102. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/pixelzoomer.js: Added.
  29103. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  29104. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/pixelzoomer.css: Added.
  29105. (.pixel-zoom-container):
  29106. (.pixel-zoom-container > *):
  29107. (.pixel-zoom-container .scaled-image-container):
  29108. (.scaled-image-container > img):
  29109. 2011-10-06 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  29110. [EFL] Change data type of parameter in ewk_view_viewport_attributes_get().
  29111. https://bugs.webkit.org/show_bug.cgi?id=69505
  29112. Reviewed by Andreas Kling.
  29113. * EWebLauncher/main.c: Use *int* variables for width and height of viewport meta tag.
  29114. (on_viewport_changed):
  29115. 2011-10-06 Brent Fulgham <bfulgham@webkit.org>
  29116. [WinCairo] Unreviewed test correction.
  29117. * Scripts/webkitdirs.pm:
  29118. (argumentsForConfiguration): Add 'wincairo' option to the set of
  29119. configuration flags used by run-javascript-core tests, so that it
  29120. does not attempt to run Apple's release version.
  29121. 2011-10-06 Brent Fulgham <bfulgham@webkit.org>
  29122. [WinCairo] Unreviewed test correction.
  29123. * BuildSlaveSupport/test-result-archive: Add 'wincairo' to the set
  29124. of known build slave types so that test-result-archive won't fail
  29125. when running tests.
  29126. 2011-10-06 Martin Robinson <mrobinson@igalia.com>
  29127. The GTK+ WebKit2 headers produce a lot of style warnings
  29128. https://bugs.webkit.org/show_bug.cgi?id=69481
  29129. Reviewed by David Levin.
  29130. Prevent emitting so many style warnings for GTK+ API. We skip header
  29131. files in the WebKit2 GTK+ API directory and also avoid warnings about
  29132. identifier names that begin with "webkit_" in files that contain the
  29133. string "gtk".
  29134. * Scripts/webkitpy/style/checker.py: Do not check header files in
  29135. Source/WebKit2/UIProcess/API/gtk that do not end in Private.h. This required
  29136. adding the ability to specify a regular expression in the skip list. Remove
  29137. a few files from the skipped list that no longer exist.
  29138. * Scripts/webkitpy/style/checker_unittest.py: Added a test for this behavior.
  29139. * Scripts/webkitpy/style/checkers/cpp.py: If a path contains "gtk" don't warn
  29140. about identifiers that begin with "webkit_".
  29141. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this behavior.
  29142. 2011-10-06 Brent Fulgham <bfulgham@webkit.org>
  29143. [WinCairo] Correct config.json for WinCairo Test builds.
  29144. https://bugs.webkit.org/show_bug.cgi?id=69272
  29145. Reviewed by Ryosuke Niwa.
  29146. * BuildSlaveSupport/build.webkit.org-config/config.json: Remove
  29147. old 'WinCairo Debug (Build)' label and replace with correct
  29148. 'WinCairo Release' label.
  29149. 2011-10-06 David Levin <levin@chromium.org>
  29150. Add a style checker watchlist definition and add myself to it.
  29151. https://bugs.webkit.org/show_bug.cgi?id=69564
  29152. Reviewed by Daniel Bates.
  29153. * Scripts/webkitpy/common/config/watchlist:
  29154. 2011-10-06 Raphael Kubo da Costa <kubo@profusion.mobi>
  29155. [EFL] DRT: Create icon database path in LayoutTestController::setIconDatabaseEnabled.
  29156. https://bugs.webkit.org/show_bug.cgi?id=69450
  29157. Reviewed by Ryosuke Niwa.
  29158. This should avoid stderr messages when running
  29159. webarchive/test-link-rel-icon.html.
  29160. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  29161. (LayoutTestController::setIconDatabaseEnabled):
  29162. 2011-10-06 Alejandro G. Castro <alex@igalia.com>
  29163. [WK2] [GTK] Add Skipped file for Webkit2 test runner
  29164. https://bugs.webkit.org/show_bug.cgi?id=69517
  29165. Use the shared WK2 skipped file also in GTK port.
  29166. Reviewed by Martin Robinson.
  29167. * Scripts/old-run-webkit-tests:
  29168. (readSkippedFiles):
  29169. 2011-10-06 Elliot Poger <epoger@google.com>
  29170. allow new-run-webkit-tests to run on Lion
  29171. https://bugs.webkit.org/show_bug.cgi?id=69429
  29172. Add fallback lists for chromium-mac-lion, and add chromium-mac-snowleopard
  29173. directory to fallback lists (even though that directory doesn't exist yet)
  29174. Reviewed by Adam Barth.
  29175. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  29176. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  29177. 2011-10-03 Hans Wennborg <hans@chromium.org>
  29178. IndexedDB: Remove SQLite-LevelDB migration code
  29179. https://bugs.webkit.org/show_bug.cgi?id=69264
  29180. Reviewed by Tony Chang.
  29181. Remove setOverrideIndexedDBBackingStore. It was used in the layout
  29182. test for migration.
  29183. * DumpRenderTree/chromium/LayoutTestController.cpp:
  29184. (LayoutTestController::LayoutTestController):
  29185. * DumpRenderTree/chromium/LayoutTestController.h:
  29186. 2011-10-05 James Robinson <jamesr@chromium.org>
  29187. [chromium] Add a command line option to DumpRenderTree and run_webkit_tests.py to enable threaded compositing mode
  29188. https://bugs.webkit.org/show_bug.cgi?id=69498
  29189. Reviewed by Adam Barth.
  29190. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  29191. (main):
  29192. * DumpRenderTree/chromium/TestShell.cpp:
  29193. (TestShell::TestShell):
  29194. (TestShell::resetWebSettings):
  29195. * DumpRenderTree/chromium/TestShell.h:
  29196. (TestShell::setThreadedCompositingEnabled):
  29197. * DumpRenderTree/chromium/WebPreferences.cpp:
  29198. (WebPreferences::reset):
  29199. (WebPreferences::applyTo):
  29200. * DumpRenderTree/chromium/WebPreferences.h:
  29201. * Scripts/webkitpy/layout_tests/port/chromium.py:
  29202. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  29203. 2011-10-05 Erik Arvidsson <arv@chromium.org>
  29204. [QT] Fix DRT after r96779
  29205. unreviewed.
  29206. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  29207. (WebCore::dumpHistoryItem):
  29208. 2011-10-05 Erik Arvidsson <arv@chromium.org>
  29209. window.location.href and others needlessly decodes URI-encoded characters
  29210. https://bugs.webkit.org/show_bug.cgi?id=30225
  29211. Reviewed by Darin Adler.
  29212. * DumpRenderTree/chromium/TestShell.cpp:
  29213. (normalizeLayoutTestURLInternal): Remove extra encode.
  29214. 2011-10-05 Darin Adler <darin@apple.com>
  29215. Fix build.
  29216. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  29217. (TestWebKitAPI::TEST): Remove underscore prefix from call to
  29218. WKContextRegisterURLSchemeAsEmptyDocument.
  29219. 2011-10-05 Brent Fulgham <bfulgham@webkit.org>
  29220. [WinCairo] Switch to building Release target, and activate tests.
  29221. https://bugs.webkit.org/show_bug.cgi?id=69272
  29222. Reviewed by Adam Barth.
  29223. * BuildSlaveSupport/build.webkit.org-config/config.json:
  29224. Change from debug to release target. Switch from "Build" to
  29225. "BuildAndTest"
  29226. 2011-10-05 Simon Fraser <simon.fraser@apple.com>
  29227. In WebKitTestRunner, text has font smoothing in pixel snapshots
  29228. https://bugs.webkit.org/show_bug.cgi?id=69396
  29229. Reviewed by Darin Adler.
  29230. Call the new WKContext method that disables font smoothing in
  29231. WebKitTestRunner, so that pixel snapshots don't have font smoothing
  29232. enabled. Remove leading underscore from a WKContext function call.
  29233. * WebKitTestRunner/TestController.cpp:
  29234. (WTR::TestController::resetStateToConsistentValues):
  29235. 2011-10-05 David Levin <levin@chromium.org>
  29236. Improve the watchlist for threading entries.
  29237. https://bugs.webkit.org/show_bug.cgi?id=69463
  29238. Reviewed by Adam Barth.
  29239. * Scripts/webkitpy/common/config/watchlist:
  29240. 2011-10-05 Adam Roben <aroben@apple.com>
  29241. Add tests for using RetainPtrs inside HashMap and HashSet
  29242. Fixes <http://webkit.org/b/69414> <rdar://problem/10236833> Using RetainPtr as the key type
  29243. in HashMap/HashSet fails to compile
  29244. Reviewed by John Sullivan.
  29245. * TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp: Added.
  29246. (TestWebKitAPI::TEST): Show that RetainPtr can be used inside HashSet and as both the key
  29247. and value type of HashMap.
  29248. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  29249. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  29250. Added new file.
  29251. 2011-10-05 Adam Barth <abarth@webkit.org>
  29252. Mark as Expected in garden-o-matic is confusing
  29253. https://bugs.webkit.org/show_bug.cgi?id=69452
  29254. Reviewed by David Levin.
  29255. krit didn't understand the difference between this button and the
  29256. Rebaseline button because both of them seem to indicate that the new
  29257. behavior is expected. This patch renames "Mark as Expected" to "Expect
  29258. Failure" to make it clear that we're just expecting the test to fail
  29259. rather than accepting the new results as passing. We might need to
  29260. iterate on these names a bit more if folks continue to find them
  29261. confusing.
  29262. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  29263. 2011-10-05 Adam Barth <abarth@webkit.org>
  29264. Add watchlist entries for abarth
  29265. https://bugs.webkit.org/show_bug.cgi?id=69461
  29266. Reviewed by David Levin.
  29267. I might have gone a bit overboard. We'll see if this is too much spam
  29268. for me.
  29269. * Scripts/webkitpy/common/config/watchlist:
  29270. 2011-10-05 Brent Fulgham <bfulgham@webkit.org>
  29271. [WinCairo] Teach old-run-webkit-tests about wincairo.
  29272. https://bugs.webkit.org/show_bug.cgi?id=69280
  29273. Reviewed by Adam Roben.
  29274. * Scripts/old-run-webkit-tests: Handle wincairo case.
  29275. (buildPlatformResultHierarchy):
  29276. (readSkippedFiles): Ditto
  29277. * Scripts/webkitdirs.pm: Deal with wincairo build case.
  29278. (determineConfiguration):
  29279. 2011-10-05 Chang Shu <cshu@webkit.org>
  29280. [WK2] Support setMarkedText/hasMarkedText/unmarkText/insertText for WTR TextInputController
  29281. https://bugs.webkit.org/show_bug.cgi?id=68924
  29282. Added TextInputController files and JS interfaces for the above functions.
  29283. Reviewed by Darin Adler.
  29284. * WebKitTestRunner/DerivedSources.make:
  29285. * WebKitTestRunner/DerivedSources.pro:
  29286. * WebKitTestRunner/GNUmakefile.am:
  29287. * WebKitTestRunner/InjectedBundle/Bindings/TextInputController.idl: Added.
  29288. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  29289. (WTR::InjectedBundle::beginTesting):
  29290. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  29291. (WTR::InjectedBundle::textInputController):
  29292. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  29293. (WTR::InjectedBundlePage::didClearWindowForFrame):
  29294. * WebKitTestRunner/InjectedBundle/TextInputController.cpp: Added.
  29295. (WTR::TextInputController::create):
  29296. (WTR::TextInputController::TextInputController):
  29297. (WTR::TextInputController::~TextInputController):
  29298. (WTR::TextInputController::wrapperClass):
  29299. (WTR::TextInputController::makeWindowObject):
  29300. (WTR::TextInputController::setMarkedText):
  29301. (WTR::TextInputController::hasMarkedText):
  29302. (WTR::TextInputController::unmarkText):
  29303. (WTR::TextInputController::insertText):
  29304. * WebKitTestRunner/InjectedBundle/TextInputController.h: Added.
  29305. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  29306. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  29307. * WebKitTestRunner/win/InjectedBundle.vcproj:
  29308. 2011-10-04 Oliver Hunt <oliver@apple.com>
  29309. Add rudimentary filtering to write barriers
  29310. https://bugs.webkit.org/show_bug.cgi?id=69392
  29311. Reviewed by Filip Pizlo.
  29312. When we're recording gc phase times Heap.o picks up
  29313. some exit time destructors, so we'll just ignore Heap.o
  29314. in this check.
  29315. * Scripts/check-for-exit-time-destructors:
  29316. 2011-10-05 Chang Shu <cshu@webkit.org>
  29317. [WK2] WebKitTestRunner needs LayoutTestController.dumpConfigurationForViewport
  29318. https://bugs.webkit.org/show_bug.cgi?id=69365
  29319. Reviewed by Darin Adler.
  29320. Added js API in WTR LayoutTestController.
  29321. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  29322. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  29323. (WTR::LayoutTestController::dumpConfigurationForViewport):
  29324. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  29325. 2011-10-05 Raphael Kubo da Costa <kubo@profusion.mobi>
  29326. [EFL] ImageDiff: Do not clear the image before it is processed and compared
  29327. https://bugs.webkit.org/show_bug.cgi?id=69378
  29328. Reviewed by Antonio Gomes.
  29329. Commit 61836 to Evas added a few cleanup calls to some
  29330. evas_object_image functions which effectively made ImageDiff consider
  29331. all images to be equal.
  29332. It turns out that now evas_object_image_colorspace_set clears any
  29333. data set, so the call to evas_object_image_data_set was not having any
  29334. effect.
  29335. * DumpRenderTree/efl/ImageDiff.cpp:
  29336. (readImageFromStdin): Call evas_object_image_data_set after
  29337. evas_object_image_colorspace_set.
  29338. 2011-10-05 Raphael Kubo da Costa <kubo@profusion.mobi>
  29339. [EFL] Fix Evas_Object_Image reference counts and file descriptor leakage in ImageDiff.
  29340. https://bugs.webkit.org/show_bug.cgi?id=68449
  29341. Reviewed by Antonio Gomes.
  29342. evas_render() must be called to close up temporary files and unmap unused
  29343. resources. evas_object_image_data_set() must be called after an
  29344. evas_object_image_data_get() to balance an internal reference count.
  29345. * DumpRenderTree/efl/ImageDiff.cpp:
  29346. (differenceImageFromDifferenceBuffer):
  29347. (calculateDifference):
  29348. (printImage):
  29349. (printImageDifferences):
  29350. 2011-10-05 Balazs Kelemen <kbalazs@webkit.org>
  29351. [Qt][WK2] Unreviewed build fix.
  29352. Don't use WebCore directly in WTR.
  29353. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  29354. (WTR::PlatformWebView::addChromeInputField):
  29355. (WTR::PlatformWebView::removeChromeInputField):
  29356. (WTR::PlatformWebView::makeWebViewFirstResponder):
  29357. 2011-10-05 David Levin <levin@chromium.org>
  29358. watchlist: Add more rules for chromium public api and sort the file.
  29359. https://bugs.webkit.org/show_bug.cgi?id=69323
  29360. Reviewed by Adam Barth.
  29361. * Scripts/webkitpy/common/config/watchlist:
  29362. 2011-10-05 David Levin <levin@chromium.org>
  29363. watchlist: Don't add the same message to a bug more than once.
  29364. https://bugs.webkit.org/show_bug.cgi?id=69303
  29365. Reviewed by Adam Barth.
  29366. * Scripts/webkitpy/common/net/bugzilla/bug.py: Added a way to determine
  29367. if a message is in the comments already.
  29368. * Scripts/webkitpy/common/net/bugzilla/bug_unittest.py: A test for the above.
  29369. * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
  29370. Pick a bug supplied by the mock. Change the test due to different output
  29371. from the mock watch list tool.
  29372. * Scripts/webkitpy/tool/mocktool.py: Change the mock watch list to return
  29373. another email so it will be filtered out, fix bugs to have the cc and comment fields,
  29374. and fix fetch_bug to handle bug_id's which are text (because that took me way too long
  29375. to debug).
  29376. * Scripts/webkitpy/tool/steps/applywatchlist.py: Change to filter out comments
  29377. and/or cc's that are already in the bug.
  29378. * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Pick a bug supplied by the mock,
  29379. and remove a comment that is filtered out.
  29380. 2011-10-05 Balazs Kelemen <kbalazs@webkit.org>
  29381. [Qt][WK2] Unreviewed build fix after r96643.
  29382. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  29383. (WTR::PlatformWebView::addChromeInputField):
  29384. (WTR::PlatformWebView::removeChromeInputField):
  29385. (WTR::PlatformWebView::makeWebViewFirstResponder):
  29386. 2011-10-04 Kent Tamura <tkent@chromium.org>
  29387. Introduce feature flags for incomplete input types
  29388. https://bugs.webkit.org/show_bug.cgi?id=68971
  29389. Reviewed by Hajime Morita.
  29390. * Scripts/build-webkit:
  29391. Add --input-type-{date,datetime,datetimelocal,month,time,week} flags.
  29392. They are disabled by default.
  29393. 2011-10-04 Adam Barth <abarth@webkit.org>
  29394. garden-o-matic doesn't launch it's UI on Lion
  29395. https://bugs.webkit.org/show_bug.cgi?id=69349
  29396. Reviewed by Darin Adler.
  29397. It turns out that Lion is a bit more picky about file URLs. This patch
  29398. switches us from using a path to using an actual file URL, silencing
  29399. the warning and making the tool actually launch on Lion.
  29400. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  29401. 2011-10-04 Daniel Bates <dbates@rim.com>
  29402. Fix Perl undefined variable warning when using run-safari after
  29403. <http://trac.webkit.org/changeset/96448> (https://bugs.webkit.org/show_bug.cgi?id=68662)
  29404. Rubber-stamped by Alexey Proskuryakov.
  29405. * Scripts/webkitdirs.pm:
  29406. (runMacWebKitApp): Check that the optional function argument $useOpenCommand
  29407. is defined before using it in a comparison operation.
  29408. 2011-10-04 Scott Graham <scottmg@chromium.org>
  29409. Add GAMEPAD feature flag
  29410. https://bugs.webkit.org/show_bug.cgi?id=66859
  29411. Reviewed by Darin Fisher.
  29412. * Scripts/build-webkit:
  29413. 2011-10-04 Jon Lee <jonlee@apple.com>
  29414. REGRESSION (WK2): (Shift-)option-tabbing skips over elements when transitioning from chrome to webview
  29415. https://bugs.webkit.org/show_bug.cgi?id=68412
  29416. <rdar://problem/9988252>
  29417. Reviewed by Darin Adler.
  29418. In order to create a test for the bug, I had to update DRT and WKTR to create some
  29419. widget that allows first responder status to move away from the main web view.
  29420. Three methods were added to layoutTestController: addChromeInputField,
  29421. removeChromeInputField, and focusWebView. addChromeInputField adds a text field
  29422. that is a sibling to the web view, and sets up the key event loop between the two.
  29423. removeChromeInputField removes that field. focusWebView moves first responder
  29424. status to the web view.
  29425. The test makes the call via layoutTestController and passes a callback that it
  29426. assumes will be executed once the task is completed. In DRT the callback is called
  29427. synchronously. In WKTR this is handled with message passing between the two
  29428. processes.
  29429. * DumpRenderTree/LayoutTestController.cpp:
  29430. (addChromeInputFieldCallback):
  29431. (removeChromeInputFieldCallback):
  29432. (focusWebViewCallback):
  29433. (LayoutTestController::staticFunctions):
  29434. * DumpRenderTree/LayoutTestController.h:
  29435. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  29436. (LayoutTestController::addChromeInputField):
  29437. (LayoutTestController::removeChromeInputField):
  29438. (LayoutTestController::focusWebView):
  29439. * DumpRenderTree/mac/DumpRenderTree.mm:
  29440. (resetWebViewToConsistentStateBeforeTesting): When resetting for the next test,
  29441. make sure to remove the chrome input field.
  29442. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  29443. (LayoutTestController::addChromeInputField):
  29444. (LayoutTestController::removeChromeInputField):
  29445. (LayoutTestController::focusWebView):
  29446. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  29447. (LayoutTestController::addChromeInputField):
  29448. (LayoutTestController::removeChromeInputField):
  29449. (LayoutTestController::focusWebView):
  29450. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  29451. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  29452. (WTR::InjectedBundle::didReceiveMessage):
  29453. (WTR::InjectedBundle::postAddChromeInputField):
  29454. (WTR::InjectedBundle::postRemoveChromeInputField):
  29455. (WTR::InjectedBundle::postFocusWebView):
  29456. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  29457. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  29458. (WTR::callbackMap): Create a hash map that keeps track of the callbacks provided
  29459. through JS.
  29460. (WTR::cacheLayoutTestControllerCallback):
  29461. (WTR::callLayoutTestControllerCallback):
  29462. (WTR::LayoutTestController::addChromeInputField):
  29463. (WTR::LayoutTestController::removeChromeInputField):
  29464. (WTR::LayoutTestController::focusWebView):
  29465. (WTR::LayoutTestController::callAddChromeInputFieldCallback):
  29466. (WTR::LayoutTestController::callRemoveChromeInputFieldCallback):
  29467. (WTR::LayoutTestController::callFocusWebViewCallback):
  29468. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  29469. * WebKitTestRunner/PlatformWebView.h:
  29470. * WebKitTestRunner/TestController.cpp:
  29471. (WTR::TestController::resetStateToConsistentValues):
  29472. * WebKitTestRunner/TestInvocation.cpp:
  29473. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  29474. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
  29475. (WTR::PlatformWebView::addChromeInputField):
  29476. (WTR::PlatformWebView::removeChromeInputField):
  29477. (WTR::PlatformWebView::makeWebViewFirstResponder):
  29478. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  29479. (WTR::PlatformWebView::addChromeInputField):
  29480. (WTR::PlatformWebView::removeChromeInputField):
  29481. (WTR::PlatformWebView::makeWebViewFirstResponder):
  29482. * WebKitTestRunner/win/PlatformWebViewWin.cpp:
  29483. (WTR::PlatformWebView::addChromeInputField):
  29484. (WTR::PlatformWebView::removeChromeInputField):
  29485. (WTR::PlatformWebView::makeWebViewFirstResponder):
  29486. * DumpRenderTree/mac/LayoutTestControllerMac.mm: These functions have nothing to do
  29487. with the patch-- just cleaning up style.
  29488. (LayoutTestController::addDisallowedURL):
  29489. (originsArrayToJS):
  29490. (LayoutTestController::queueLoad):
  29491. (LayoutTestController::setMockDeviceOrientation):
  29492. (LayoutTestController::setIconDatabaseEnabled):
  29493. (LayoutTestController::setEditingBehavior):
  29494. 2011-10-04 Simon Fraser <simon.fraser@apple.com>
  29495. Move font-fixup code in WebKitTestRunner to a better place
  29496. https://bugs.webkit.org/show_bug.cgi?id=69356
  29497. Reviewed by Sam Weinig.
  29498. Move code that swizzles NSFontManager methods to ActivateFonts.mm, which
  29499. already contains font-related code.
  29500. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  29501. (WTR::InjectedBundle::initialize):
  29502. * WebKitTestRunner/InjectedBundle/mac/ActivateFonts.mm:
  29503. (WTR::allowedFontFamilySet):
  29504. (WTR::drt_NSFontManager_availableFontFamilies):
  29505. (WTR::drt_NSFontManager_availableFonts):
  29506. (WTR::swizzleNSFontManagerMethods):
  29507. (WTR::activateFonts):
  29508. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  29509. (WTR::InjectedBundle::platformInitialize):
  29510. 2011-10-04 Raphael Kubo da Costa <kubo@profusion.mobi>
  29511. [EFL] DRT: Add DumpRenderTree.cpp
  29512. https://bugs.webkit.org/show_bug.cgi?id=62034
  29513. Reviewed by Antonio Gomes.
  29514. This is the main implementation file for EFL's DumpRenderTree.
  29515. * DumpRenderTree/efl/DumpRenderTree.cpp: Added.
  29516. (dumpFramesAsText):
  29517. (dumpFrameScrollPosition):
  29518. (shouldLogFrameLoadDelegates):
  29519. (shouldDumpAsText):
  29520. (sendPixelResultsEOF):
  29521. (invalidateAnyPreviousWaitToDumpWatchdog):
  29522. (onEcoreEvasResize):
  29523. (onCloseWindow):
  29524. (useLongRunningServerMode):
  29525. (parseCommandLineOptions):
  29526. (getFinalTestURL):
  29527. (getExpectedPixelHash):
  29528. (createLayoutTestController):
  29529. (runTest):
  29530. (runTestingServerLoop):
  29531. (adjustOutputTypeByMimeType):
  29532. (dumpFrameContentsAsText):
  29533. (shouldDumpFrameScrollPosition):
  29534. (shouldDumpPixelsAndCompareWithExpected):
  29535. (shouldDumpBackForwardList):
  29536. (initEfl):
  29537. (shutdownEfl):
  29538. (displayWebView):
  29539. (dump):
  29540. (initEcoreEvas):
  29541. (main):
  29542. 2011-10-03 Adam Barth <abarth@webkit.org>
  29543. garden-o-matic should remove builders from the failure grid once they start to pass
  29544. https://bugs.webkit.org/show_bug.cgi?id=69309
  29545. Unreviewed. dglazkov is on vacation. I need to interest someone else
  29546. in reviewing these patches.
  29547. This patch follows the update/purge model from UpdateTracker. This
  29548. patch is less awesome than it could be because it causes the UI to
  29549. flash slightly. In a future patch, we'll want to use these
  29550. update/purge notifications to update the UI without flashing. However,
  29551. that's not such a big deal because this UI is hidden in the default
  29552. view.
  29553. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  29554. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  29555. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  29556. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  29557. 2011-10-03 David Levin <levin@chromium.org>
  29558. webkitpy: Expose cc_emails and comments from bug.py
  29559. https://bugs.webkit.org/show_bug.cgi?id=69308
  29560. Reviewed by Adam Barth.
  29561. * Scripts/webkitpy/common/net/bugzilla/bug.py: Expose cc_emails and comments .
  29562. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py: Add parsing support for comments.
  29563. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py: Fix the unit test due
  29564. to comments being exposed.
  29565. 2011-10-03 James Robinson <jamesr@chromium.org>
  29566. Add myself to the watchlist for platform/graphics/chromium
  29567. https://bugs.webkit.org/show_bug.cgi?id=69297
  29568. Reviewed by David Levin.
  29569. * Scripts/webkitpy/common/config/watchlist:
  29570. 2011-10-03 Anders Carlsson <andersca@apple.com>
  29571. Remove custom scrollbar painting hooks
  29572. https://bugs.webkit.org/show_bug.cgi?id=69163
  29573. Reviewed by Alexey Proskuryakov.
  29574. * DumpRenderTree/chromium/WebPreferences.cpp:
  29575. (WebPreferences::applyTo):
  29576. No need to enable custom scrollbar painting.
  29577. 2011-10-03 David Levin <levin@chromium.org>
  29578. watchlist: Make watchlist run on a bot.
  29579. https://bugs.webkit.org/show_bug.cgi?id=68974
  29580. Reviewed by Adam Barth.
  29581. * Scripts/webkitpy/tool/commands/queues.py: Add the watchlist to the style bot.
  29582. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  29583. Change to log what is run so that we can see the style command
  29584. and the watchlist command being run.
  29585. 2011-10-03 David Levin <levin@chromium.org>
  29586. watchlist: Allow specified a bug to attach the watchlist info to.
  29587. https://bugs.webkit.org/show_bug.cgi?id=69288
  29588. Reviewed by Eric Seidel.
  29589. * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Add support for bugid.
  29590. * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py:
  29591. Add tests and fix an existing test because the unit tests do not go through the
  29592. normal command line processing (so the -g argument remained when we determined bug ids).
  29593. * Scripts/webkitpy/tool/commands/commandtest.py: Change the derivation to
  29594. get the assert raises regex method.
  29595. * Scripts/webkitpy/tool/commands/download.py: Fix the command help to be more unixy.
  29596. 2011-10-03 Leandro Pereira <leandro@profusion.mobi>
  29597. [EFL] DRT: Add JSStringUtils.{cpp,h}
  29598. https://bugs.webkit.org/show_bug.cgi?id=66397
  29599. Reviewed by Ryosuke Niwa.
  29600. Adds helper functions to compare the equality of C-style strings and
  29601. JSStringRef objects.
  29602. * DumpRenderTree/efl/JSStringUtils.cpp: Added.
  29603. (equals):
  29604. * DumpRenderTree/efl/JSStringUtils.h: Added.
  29605. 2011-10-03 Adam Barth <abarth@webkit.org>
  29606. garden-o-matic should work in Safari 5.1
  29607. https://bugs.webkit.org/show_bug.cgi?id=69290
  29608. Reviewed by Sam Weinig.
  29609. My old implementation of bind was too clever by half. This one seems
  29610. to work better, at least according to this test.
  29611. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  29612. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  29613. 2011-09-29 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
  29614. Unreviewed: change my e-mail in commiters.py
  29615. (I'm leaving the company and my @openbossa.org will be no more)
  29616. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
  29617. 2011-10-01 Brent Fulgham <bfulgham@webkit.org>
  29618. Correct post-build step for WinCairo test runs.
  29619. https://bugs.webkit.org/show_bug.cgi?id=69191
  29620. Reviewed by Brian Weinstein.
  29621. * DumpRenderTree/win/DumpRenderTreePostBuild.cmd: Add additional
  29622. shell case to handle the CFLite build.
  29623. 2011-10-01 Filip Pizlo <fpizlo@apple.com>
  29624. Added myself to reviewers, because I'm now a reviewer.
  29625. * Scripts/webkitpy/common/config/committers.py:
  29626. 2011-10-01 Filip Pizlo <fpizlo@apple.com>
  29627. Bencher script makes it difficult to do automated performance testing
  29628. https://bugs.webkit.org/show_bug.cgi?id=69207
  29629. Reviewed by Sam Weinig.
  29630. This adds two new features:
  29631. The ability to disable automatic VM detection, which is flaky if any
  29632. profiling features are enabled in jsc.
  29633. The ability to compute, and report, a scaled result for all benchmark
  29634. suites. It is the geometric mean of three numbers: SunSpider's
  29635. arithmetic mean, V8's geometric mean, and Kraken's arithmetic mean.
  29636. It is also possible to turn off all other output from bencher and just
  29637. get this number with the --brief option.
  29638. * Scripts/bencher:
  29639. 2011-10-01 Sam Weinig <sam@webkit.org>
  29640. WTR is not successfully changing the NSUserDefaults
  29641. https://bugs.webkit.org/show_bug.cgi?id=69204
  29642. Reviewed by Dan Bernstein.
  29643. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  29644. (WTR::InjectedBundle::platformInitialize):
  29645. Use -setVolatileDomain:forName:NSArgumentDomain instead of registerDefaults to
  29646. get our overrides picked up.
  29647. 2011-09-30 Daniel Bates <dbates@rim.com>
  29648. Cleanup: Extract code to launch a Mac WebKit application into a common function
  29649. https://bugs.webkit.org/show_bug.cgi?id=68662
  29650. Reviewed by Adam Roben.
  29651. Extracts common code to launch a WebKit application on Mac OS X into a function
  29652. so that we can remove duplicate code.
  29653. * Scripts/run-webkit-app: Modified to use webkitdirs::runMacWebKitApp().
  29654. * Scripts/webkitdirs.pm: Sorted @EXPORT list and added constant USE_OPEN_COMMAND.
  29655. (runMacWebKitApp): Added.
  29656. (runSafari): Modified to use webkitdirs::runMacWebKitApp().
  29657. (runMiniBrowser): Ditto.
  29658. (runWebKitTestRunner): Ditto.
  29659. (runTestWebKitAPI): Ditto.
  29660. 2011-09-29 David Levin <levin@chromium.org>
  29661. watchlist: Add webkit-patch command to run watchlist.
  29662. https://bugs.webkit.org/show_bug.cgi?id=68973
  29663. Reviewed by Eric Seidel.
  29664. * Scripts/webkitpy/common/host.py: Exposed the watch_list.
  29665. * Scripts/webkitpy/common/watchlist/watchlist.py: Changed to return
  29666. the cc and messages as sorted lists. To allow for deterministic ordering.
  29667. * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Ditto.
  29668. * Scripts/webkitpy/tool/commands/__init__.py: Add ApplyWatchListLocal so
  29669. that it will be exposed as a command by webkit-patch.
  29670. * Scripts/webkitpy/tool/commands/applywatchlistlocal.py: Added.
  29671. * Scripts/webkitpy/tool/commands/applywatchlistlocal_unittest.py: Added.
  29672. * Scripts/webkitpy/tool/commands/download.py: Added ApplyWatchList which mimics CheckStyle.
  29673. * Scripts/webkitpy/tool/commands/download_unittest.py: Added an appropriate test.
  29674. * Scripts/webkitpy/tool/mocktool.py: Mock out the watch list.
  29675. * Scripts/webkitpy/tool/steps/__init__.py: Added ApplyWatchList.
  29676. * Scripts/webkitpy/tool/steps/applywatchlist.py: Added.
  29677. * Scripts/webkitpy/tool/steps/applywatchlist_unittest.py: Added.
  29678. 2011-09-30 David Levin <levin@chromium.org>
  29679. watchlist: Add a way to detect a net increase or decrease of a pattern (in a file).
  29680. https://bugs.webkit.org/show_bug.cgi?id=69031
  29681. Reviewed by Adam Barth.
  29682. * Scripts/webkitpy/common/config/watchlist: Added usage of the new pattern,
  29683. a comment to explain something important about the email addresses, and
  29684. a comment to let emacs know to treat the file as a python file.
  29685. * Scripts/webkitpy/common/watchlist/amountchangedpattern.py: Added.
  29686. Detects increases or decreases in a pattern.
  29687. * Scripts/webkitpy/common/watchlist/amountchangedpattern_unittest.py: Added.
  29688. * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
  29689. Added unit tests for watchlist which has "more" or "less".
  29690. * Scripts/webkitpy/common/watchlist/watchlistparser.py:
  29691. Added support for "more" or "less".
  29692. 2011-09-30 Sam Weinig <sam@webkit.org>
  29693. Add support for eventSender.mouseScrollBy in WTR
  29694. https://bugs.webkit.org/show_bug.cgi?id=69189
  29695. Add implementation of eventSender.mouseScrollBy for the mac.
  29696. Reviewed by Simon Fraser.
  29697. * WebKitTestRunner/EventSenderProxy.h:
  29698. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  29699. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  29700. (WTR::EventSendingController::keyDown):
  29701. (WTR::EventSendingController::mouseScrollBy):
  29702. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  29703. * WebKitTestRunner/TestController.cpp:
  29704. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  29705. * WebKitTestRunner/mac/EventSenderProxy.mm:
  29706. (WTR::EventSenderProxy::mouseScrollBy):
  29707. 2011-09-30 Simon Fraser <simon.fraser@apple.com>
  29708. fast/forms/text-control-intrinsic-widths.html fails on Mac if Word/Office fonts are installed
  29709. https://bugs.webkit.org/show_bug.cgi?id=35273
  29710. Reviewed by Dan Bernstein.
  29711. There are two types of font issue that can cause layout test failure.
  29712. First, the user may have non-standard fonts installed that affect the layout
  29713. of some tests. For example, some tests use the MS Gothic font if installed.
  29714. Secondly, the user may have duplicate fonts installed in ~/Library/Fonts,
  29715. which override the system fonts (e.g. a copy of Arial from MS Office). For
  29716. some tests, this can affect font metrics or fallback behavior.
  29717. This change addresses the first problem only. It limits the set of fonts
  29718. available through NSFontManager, by swizzling some methods to return
  29719. a list of fonts or font families which only include fonts from a hardcoded
  29720. whitelist.
  29721. * DumpRenderTree/mac/DumpRenderTree.mm:
  29722. (allowedFontFamilySet):
  29723. (drt_NSFontManager_availableFontFamilies):
  29724. (drt_NSFontManager_availableFonts):
  29725. (swizzleNSFontManagerMethods):
  29726. (activateTestingFonts):
  29727. (adjustFonts):
  29728. (createWebViewAndOffscreenWindow):
  29729. (prepareConsistentTestingEnvironment):
  29730. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  29731. (WTR::allowedFontFamilySet):
  29732. (WTR::drt_NSFontManager_availableFontFamilies):
  29733. (WTR::drt_NSFontManager_availableFonts):
  29734. (WTR::swizzleNSFontManagerMethods):
  29735. (WTR::InjectedBundle::platformInitialize):
  29736. 2011-09-30 David Levin <levin@chromium.org>
  29737. Need to skip webkitpy.common.checkout.baselineoptimizer_unittest.BaselineOptimizerTest on Windows..
  29738. https://bugs.webkit.org/show_bug.cgi?id=69039
  29739. Reviewed by Adam Barth.
  29740. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  29741. Actually skip only one specific test that is failing on Windows.
  29742. 2011-09-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  29743. [Qt] Prevent qDebug() output from DRT and WTR unless --verbose
  29744. For DRT we didn't install the message handler early enough to
  29745. catch output while constructing the QApplication. For WTR we
  29746. didn't even install a message handler.
  29747. Since the UI process will forward any output from the web process
  29748. we set an environment variable QT_WEBKIT_SUPPRESS_WEB_PROCESS_OUTPUT
  29749. in WTR before the web process is started. This is picked up by the
  29750. web process which installs its own message handler.
  29751. The environment variable can be overriden on the command line if you
  29752. want to see output from the web process, or you can pass --verbose to
  29753. WTR to see output from both processes.
  29754. https://bugs.webkit.org/show_bug.cgi?id=69132
  29755. Reviewed by Andreas Kling.
  29756. * DumpRenderTree/qt/main.cpp:
  29757. * WebKitTestRunner/qt/main.cpp:
  29758. 2011-09-30 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  29759. [Qt] Make sure WTR sizes the window and item correctly
  29760. Revision 96345 changed the logic for how the view and
  29761. window was created, but missed a vital part, setting
  29762. the size.
  29763. We now use a QSGView for the window, that has a simple
  29764. item as its root object that is always resized to fit
  29765. within the window. The webview is then parented to the
  29766. root object and set to anchors.fill: parent. That way
  29767. any window geometry changes will propagate to the web
  29768. view.
  29769. https://bugs.webkit.org/show_bug.cgi?id=69134
  29770. Reviewed by Andreas Kling.
  29771. * WebKitTestRunner/PlatformWebView.h:
  29772. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  29773. 2011-09-30 Raphael Kubo da Costa <kubo@profusion.mobi>
  29774. [EFL] Only save the current viewport in PixelDumpSupportEfl.
  29775. https://bugs.webkit.org/show_bug.cgi?id=68450
  29776. Reviewed by Antonio Gomes.
  29777. The previous implementation saved the whole page contents in the final
  29778. PNG, however the baselines and expectations in the tree only want the
  29779. current viewport (with a scrollbar, if needed), so we now only save the
  29780. currently visible contents.
  29781. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
  29782. (createBitmapContextFromWebView): Use
  29783. ewk_frame_visible_content_geometry_get instead of
  29784. ewk_frame_contents_size_get.
  29785. 2011-09-30 Raphael Kubo da Costa <kubo@profusion.mobi>
  29786. [EFL] Support and keep track of extra windows (views).
  29787. https://bugs.webkit.org/show_bug.cgi?id=68454
  29788. Reviewed by Antonio Gomes.
  29789. So far, window.open and related JavaScript code would not work, as
  29790. DRTView did not implementation
  29791. Ewk_View_Smart_Class::window_{open,close}. The default implementation
  29792. in ewk just returns the current window/view, which broke any
  29793. layouttest which relied on window.open.
  29794. We now properly create and remove these new views. Unfortunately, the
  29795. current way ewk works (and due to the fact that we cannot pass class
  29796. methods as function pointers to the EFL functions), DRTView needs to
  29797. know that DRTChrome exists and call `browser' directly in some points.
  29798. * DumpRenderTree/efl/DumpRenderTreeView.cpp:
  29799. (onWindowCreate):
  29800. (onWindowCloseDelayed):
  29801. (onWindowClose):
  29802. (drtViewTiledAdd):
  29803. 2011-09-30 Qi Zhang <qi.2.zhang@nokia.com>
  29804. WebKitTestRunner needs layoutTestController.setAppCacheMaximumSize
  29805. https://bugs.webkit.org/show_bug.cgi?id=42698
  29806. Reviewed by Andreas Kling.
  29807. Implemented layoutTestController.setAppCacheMaximumSize and layoutTestController.clearApplicationCache,
  29808. and call clearApplicationCache when layoutTest start up.
  29809. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  29810. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  29811. (WTR::InjectedBundle::beginTesting):
  29812. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  29813. (WTR::LayoutTestController::clearAllApplicationCaches):
  29814. (WTR::LayoutTestController::setAppCacheMaximumSize):
  29815. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  29816. 2011-09-30 Zeno Albisser <zeno.albisser@nokia.com>
  29817. [Qt][WK2] Change WebKitTestRunner to use QMouseEvents instead of QGraphicsSceneMouseEvents
  29818. https://bugs.webkit.org/show_bug.cgi?id=69145
  29819. This is a follow up to https://bugs.webkit.org/show_bug.cgi?id=69105
  29820. Due to refactorings in Qt5, QMouseEvent now supports floating point coordinates
  29821. and is perfectly suitable for SceneGraph as well. GraphicsScene events
  29822. will not be available in QtGui anymore in future. Therefore we also have to change
  29823. QtWebKit to use QMouseEvents instead of QGraphicsSceneMouseEvents.
  29824. Reviewed by Chang Shu.
  29825. * WebKitTestRunner/EventSenderProxy.h:
  29826. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  29827. (WTR::EventSenderProxy::createMouseEvent):
  29828. (WTR::EventSenderProxy::mouseDown):
  29829. (WTR::EventSenderProxy::mouseUp):
  29830. (WTR::EventSenderProxy::mouseMoveTo):
  29831. 2011-09-30 James Robinson <jamesr@chromium.org>
  29832. [chromium] Add WebKit API for sending input events to the compositor thread
  29833. https://bugs.webkit.org/show_bug.cgi?id=69117
  29834. Reviewed by Darin Fisher.
  29835. Adds support for creating and setting a compositor thread in DRT.
  29836. * DumpRenderTree/chromium/WebViewHost.cpp:
  29837. (WebViewHost::WebViewHost):
  29838. * DumpRenderTree/chromium/WebViewHost.h:
  29839. 2011-09-29 David Levin <levin@chromium.org>
  29840. watchlist: Add cross-checks for WatchList once it is filled.
  29841. https://bugs.webkit.org/show_bug.cgi?id=68975
  29842. Reviewed by Eric Seidel.
  29843. * Scripts/webkitpy/common/watchlist/watchlist.py: Made the data members public
  29844. instead of having trivial getter and setters.
  29845. * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Fix the unit tests to
  29846. pass the validation checks.
  29847. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add validation checks
  29848. and fix a few style nits.
  29849. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests for the
  29850. validation checks.
  29851. * Scripts/webkitpy/common/watchlist/watchlistrule.py: Make definitions_to_match public.
  29852. 2011-09-29 Xianzhu Wang <wangxianzhu@chromium.org>
  29853. run-api-tests fails on chromium-win bot
  29854. https://bugs.webkit.org/show_bug.cgi?id=69121
  29855. On Windows running a perl script needs the interpreter.
  29856. Reviewed by Adam Barth.
  29857. * Scripts/run-api-tests:
  29858. (buildTestTool):
  29859. 2011-09-29 Adam Barth <abarth@webkit.org>
  29860. Attempt to make this tool work on Windows.
  29861. * Scripts/run-api-tests:
  29862. (buildTestTool):
  29863. 2011-09-29 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  29864. [Qt] Try to fix the minial build
  29865. * QtTestBrowser/launcherwindow.cpp:
  29866. * QtTestBrowser/webpage.cpp:
  29867. 2011-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  29868. [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
  29869. QWidget and friends now live in the QtWidgets library. We update
  29870. includes in implementation files and private headers to us the
  29871. non-module-prefixed path, and leave the lookup for the include
  29872. path. For public headers we have to ifdef the includes as the
  29873. user might now have the modules we need in his QT config.
  29874. Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
  29875. have to update our code and use windowHandle() for setting the
  29876. parent relationships.
  29877. https://bugs.webkit.org/show_bug.cgi?id=68687
  29878. Reviewed by Andreas Kling.
  29879. * DumpRenderTree/qt/DumpRenderTree.pro:
  29880. * DumpRenderTree/qt/ImageDiff.pro:
  29881. * MiniBrowser/qt/BrowserView.cpp:
  29882. * MiniBrowser/qt/BrowserView.h:
  29883. * MiniBrowser/qt/BrowserWindow.cpp:
  29884. * MiniBrowser/qt/BrowserWindow.h:
  29885. * MiniBrowser/qt/MiniBrowser.pro:
  29886. * MiniBrowser/qt/MiniBrowserApplication.h:
  29887. * MiniBrowser/qt/main.cpp:
  29888. * QtTestBrowser/QtTestBrowser.pro:
  29889. * QtTestBrowser/launcherwindow.cpp:
  29890. * QtTestBrowser/launcherwindow.h:
  29891. * QtTestBrowser/locationedit.h:
  29892. * QtTestBrowser/main.cpp:
  29893. * QtTestBrowser/mainwindow.cpp:
  29894. * QtTestBrowser/mainwindow.h:
  29895. * QtTestBrowser/webinspector.h:
  29896. * QtTestBrowser/webpage.cpp:
  29897. * QtTestBrowser/webview.cpp:
  29898. * WebKitTestRunner/PlatformWebView.h:
  29899. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  29900. 2011-09-29 Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com>
  29901. Initial implementation of WebInspector for WebKit2 GTK port.
  29902. https://bugs.webkit.org/show_bug.cgi?id=68235
  29903. Reviewed by Martin Robinson.
  29904. * MiniBrowser/gtk/BrowserWindow.c:
  29905. (browserWindowConstructed): Set the developer extra flags to true to enable inspect element.
  29906. 2011-09-29 Adam Barth <abarth@webkit.org>
  29907. Unbreak the "update expectatations" button by using the existing
  29908. machinery to create the failureInfo objects.
  29909. Unbreak the "close" button on the progress dialog by using |this|
  29910. instead of the old name of the object.
  29911. Teach the controllers unit test not to talk to the actual network.
  29912. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  29913. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers_unittests.js:
  29914. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  29915. 2011-09-29 Hans Wennborg <hans@chromium.org>
  29916. IndexedDB: Use LevelDB also for in-memory databases
  29917. https://bugs.webkit.org/show_bug.cgi?id=68903
  29918. Reviewed by Steve Block.
  29919. Remove the temporary dir that was necessary before LevelDB supported
  29920. in-memory databases.
  29921. * DumpRenderTree/chromium/TestShell.cpp:
  29922. (TestShell::TestShell):
  29923. * DumpRenderTree/chromium/TestShell.h:
  29924. 2011-09-28 Xianzhu Wang <wangxianzhu@chromium.org>
  29925. Run TestWebKitAPI on Chromium buildbots
  29926. https://bugs.webkit.org/show_bug.cgi?id=68678
  29927. Reviewed by Tony Chang.
  29928. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  29929. 2011-09-28 Dimitri Glazkov <dglazkov@chromium.org>
  29930. garden-o-matic results should anticipate 0 unexpected failures.
  29931. https://bugs.webkit.org/show_bug.cgi?id=69036
  29932. Also fixes controllers: UnexpectedFailures test.
  29933. Reviewed by Adam Barth.
  29934. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Tweaked.
  29935. 2011-09-28 Dirk Pranke <dpranke@chromium.org>
  29936. Modify new-run-webkit-tests to return the percentage difference in image diffs where possible.
  29937. https://bugs.webkit.org/show_bug.cgi?id=67253
  29938. Reviewed by Eric Seidel.
  29939. Nearly all of the work in this was done by Simon Fraser; I'm
  29940. just repackaging it and cleaning it up a bit. This change
  29941. modifies port.diff_image() to return a tuple of (pass/fail,
  29942. %age), adds the value to the FailureImageHashMismatch, and
  29943. writes the value into the full_results.json files to be
  29944. displayed in the results page.
  29945. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  29946. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  29947. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  29948. * Scripts/webkitpy/layout_tests/models/test_failures.py:
  29949. * Scripts/webkitpy/layout_tests/port/base.py:
  29950. * Scripts/webkitpy/layout_tests/port/chromium.py:
  29951. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  29952. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  29953. * Scripts/webkitpy/layout_tests/port/test.py:
  29954. * Scripts/webkitpy/layout_tests/port/webkit.py:
  29955. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  29956. 2011-09-25 Kentaro Hara <haraken@chromium.org>
  29957. Unreviewed. Adding myself to committers.py.
  29958. * Scripts/webkitpy/common/config/committers.py:
  29959. 2011-09-28 Adam Barth <abarth@webkit.org>
  29960. garden-o-matic shouldn't depend on test-results.appspot.com
  29961. https://bugs.webkit.org/show_bug.cgi?id=69019
  29962. Reviewed by Dimitri Glazkov.
  29963. This patch moves garden-o-matic from getting full_results.json from
  29964. test-results.appspot.com to getting that information directly from the
  29965. buildbot. This patch improve the load time and accuracy of
  29966. garden-o-matic because test-results.appspot.com is slow and is dropping
  29967. a significant number of writes (see
  29968. https://bugs.webkit.org/show_bug.cgi?id=68748).
  29969. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
  29970. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  29971. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  29972. 2011-09-28 David Levin <levin@chromium.org>
  29973. watchlist: Add a way to load the watchlist from config.
  29974. https://bugs.webkit.org/show_bug.cgi?id=68991
  29975. Reviewed by Eric Seidel.
  29976. * Scripts/webkitpy/common/config/watchlist: Added.
  29977. * Scripts/webkitpy/common/watchlist/watchlistloader.py: Added.
  29978. Support for loading the watch list.
  29979. * Scripts/webkitpy/common/watchlist/watchlistloader_unittest.py: Added.
  29980. Tests for the loading.
  29981. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
  29982. Adjusted to use the common base class.
  29983. * Scripts/webkitpy/common/webkitunittest.py: Added.
  29984. Made a common base class for functionality used in more than one.
  29985. 2011-09-28 David Levin <levin@chromium.org>
  29986. Attempt fix for Leopard python unit test run.
  29987. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
  29988. 2011-09-27 Dimitri Glazkov <dglazkov@chromium.org>
  29989. REGRESSION(r95573): Crash when loading SVG documents in a flattened frame or any SVG document in Chromium/Mac.
  29990. https://bugs.webkit.org/show_bug.cgi?id=68938
  29991. Made Chromium/Mac DRT better match how Chromium/Mac queries WebKit.
  29992. Reviewed by David Hyatt.
  29993. * DumpRenderTree/chromium/WebViewHost.cpp:
  29994. (WebViewHost::didUpdateLayout): Added width/height queries.
  29995. * DumpRenderTree/chromium/WebViewHost.h: Updated defs.
  29996. 2011-09-28 Mihai Parparita <mihaip@chromium.org>
  29997. Get rebaseline server running again
  29998. https://bugs.webkit.org/show_bug.cgi?id=69020
  29999. Reviewed by Adam Barth.
  30000. Make rebaseline server run again after r90337 (missing format_date_time
  30001. import, results_json wasn't outputting anything).
  30002. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  30003. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  30004. 2011-09-28 David Grogan <dgrogan@chromium.org>
  30005. Move dgrogan from contributor to committer
  30006. https://bugs.webkit.org/show_bug.cgi?id=69021
  30007. * Scripts/webkitpy/common/config/committers.py:
  30008. 2011-09-28 Mihai Parparita <mihaip@chromium.org>
  30009. Add Mac Skia GPU bots to builders.py
  30010. https://bugs.webkit.org/show_bug.cgi?id=69016
  30011. Reviewed by Eric Seidel.
  30012. This allows wwebkit-patch rebaseline-expectations to work with Mac Skia
  30013. GPU tests.
  30014. * Scripts/webkitpy/layout_tests/port/builders.py:
  30015. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  30016. 2011-09-28 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
  30017. Second try at fixing the GTK+ build.
  30018. * GNUmakefile.am:
  30019. 2011-09-28 Xianzhu Wang <wangxianzhu@chromium.org>
  30020. Let TestWebKitAPI and webkit_unit_tests work for chromium-win
  30021. https://bugs.webkit.org/show_bug.cgi?id=68680
  30022. Reviewed by Tony Chang.
  30023. * Scripts/run-chromium-webkit-unit-tests:
  30024. * Scripts/webkitdirs.pm:
  30025. (determineBaseProductDir):
  30026. 2011-09-28 Kaustubh Atrawalkar <kaustubh@motorola.com>
  30027. [Gtk] Implement textInputController.doCommand
  30028. https://bugs.webkit.org/show_bug.cgi?id=66496
  30029. Reviewed by Martin Robinson.
  30030. * DumpRenderTree/gtk/TextInputController.cpp:
  30031. (doCommandCallback): Callback function for textInputController.doCommand
  30032. 2011-09-28 David Levin <levin@chromium.org>
  30033. watchlist: Suggest corrections for typos and improve error message consistency.
  30034. https://bugs.webkit.org/show_bug.cgi?id=68976
  30035. Reviewed by Adam Barth.
  30036. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Add suggestions
  30037. for typos and improve consistency of the error messages.
  30038. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Add tests
  30039. and improve the regex that were already present.
  30040. 2011-09-28 David Levin <levin@chromium.org>
  30041. watchlist: Add support for matching added or deleted lines.
  30042. https://bugs.webkit.org/show_bug.cgi?id=68972
  30043. Reviewed by Adam Barth.
  30044. * Scripts/webkitpy/common/watchlist/changedlinepattern.py: Added.
  30045. * Scripts/webkitpy/common/watchlist/changedlinepattern_unittest.py: Added.
  30046. * Scripts/webkitpy/common/watchlist/watchlist.py: Comment fix up and fix input
  30047. to the pattern match to only have the diff lines instead of the DiffFile.
  30048. * Scripts/webkitpy/common/watchlist/watchlist_unittest.py:
  30049. Add tests for the new patterns and combinations of the patterns.
  30050. * Scripts/webkitpy/common/watchlist/watchlistparser.py:
  30051. Sort imports. Add changeline support.
  30052. 2011-09-28 Carlos Garcia Campos <cgarcia@igalia.com>
  30053. [GTK] Add WebKitError to GTK+ WebKit2 API
  30054. https://bugs.webkit.org/show_bug.cgi?id=68508
  30055. Reviewed by Martin Robinson.
  30056. * GNUmakefile.am: Add path to webkitgtk derived sources to the
  30057. include path.
  30058. 2011-09-28 Philippe Normand <pnormand@igalia.com>
  30059. [GTK] missing WebKit2 support in run-gtk-tests
  30060. https://bugs.webkit.org/show_bug.cgi?id=68992
  30061. Rubber-stamped by Andreas Kling.
  30062. * Scripts/run-gtk-tests: Get the WebKit2 tests to run from the
  30063. webkit2 directory.
  30064. 2011-09-27 Philippe Normand <pnormand@igalia.com>
  30065. [GTK] build-webkit --no-webkit2 still builds WebKit2
  30066. https://bugs.webkit.org/show_bug.cgi?id=68892
  30067. Reviewed by Martin Robinson.
  30068. Take the --no-webkit2 option in account when building WebKitGTK+.
  30069. * Scripts/build-webkit:
  30070. * Scripts/webkitdirs.pm:
  30071. (buildAutotoolsProject):
  30072. (buildGtkProject):
  30073. 2011-09-28 Ryosuke Niwa <rniwa@webkit.org>
  30074. Make Chromium Win Release (Tests) a core builder
  30075. https://bugs.webkit.org/show_bug.cgi?id=68906
  30076. Reviewed by Adam Barth.
  30077. Add Chromium Win Release (Tests) to the list of core builders.
  30078. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  30079. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  30080. 2011-09-27 Adam Barth <abarth@webkit.org>
  30081. garden-o-matic should load faster and inform the user what is happening
  30082. https://bugs.webkit.org/show_bug.cgi?id=68954
  30083. Reviewed by Dimitri Glazkov.
  30084. This test disables the expected failures tab. The web inspector showed
  30085. that loading the data for this tab was slowing down the loading time
  30086. for the whole app. We need to find a way to load that data lazily.
  30087. This patch also improves the update message to better describe the
  30088. progress the app is making analyzing data from the buildbot.
  30089. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  30090. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  30091. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  30092. 2011-09-27 Adam Barth <abarth@webkit.org>
  30093. garden-o-matic should show the first result when examining results
  30094. https://bugs.webkit.org/show_bug.cgi?id=68960
  30095. Reviewed by Dimitri Glazkov.
  30096. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  30097. 2011-09-27 David Levin <levin@chromium.org>
  30098. watchlist: Add support for cc and message rules.
  30099. https://bugs.webkit.org/show_bug.cgi?id=68950
  30100. Reviewed by Adam Barth.
  30101. * Scripts/webkitpy/common/watchlist/watchlist.py: Added support to get
  30102. the cc's and messages for a patch.
  30103. * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Tests for the above.
  30104. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Parsing support
  30105. for the rules.
  30106. * Scripts/webkitpy/common/watchlist/watchlistrule.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
  30107. A generic encapsulation of either a message list or a cc list.
  30108. * Scripts/webkitpy/common/watchlist/watchlistrule_unittest.py: Copied from Tools/Scripts/webkitpy/common/watchlist/watchlist.py.
  30109. 2011-09-27 Tom Zakrajsek <tomz@codeaurora.org>
  30110. webkit-patch doesn't like UTF-8 characters in reviewers names
  30111. https://bugs.webkit.org/show_bug.cgi?id=63452
  30112. Reviewed by Eric Seidel.
  30113. * Scripts/webkit-patch:
  30114. 2011-09-27 Adam Barth <abarth@webkit.org>
  30115. garden-o-matic examine buttons shows both expected and unexpected failures
  30116. https://bugs.webkit.org/show_bug.cgi?id=68918
  30117. Reviewed by Dimitri Glazkov.
  30118. This was a copy/paste error when I refactored this classes to share
  30119. more code.
  30120. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  30121. 2011-09-27 Ryosuke Niwa <rniwa@webkit.org>
  30122. Add Kaustubh Atrawalkar to the list of contributors.
  30123. * Scripts/webkitpy/common/config/committers.py:
  30124. 2011-09-27 Mihai Parparita <mihaip@chromium.org>
  30125. [Chromium] Fixed layout mode tests break subsequent tests
  30126. https://bugs.webkit.org/show_bug.cgi?id=68923
  30127. Reviewed by Adam Barth.
  30128. Reset fixed layout mode between tests, so that tests that run after
  30129. platform/chromium/fast/repaint/fixed-layout-360x240.html still have the
  30130. regular 800x600 non-fixed layout.
  30131. * DumpRenderTree/chromium/TestShell.cpp:
  30132. (TestShell::resetTestController):
  30133. 2011-09-27 David Levin <levin@chromium.org>
  30134. watchlist: Add the filename pattern for definitions.
  30135. https://bugs.webkit.org/show_bug.cgi?id=68917
  30136. Reviewed by Adam Barth.
  30137. * Scripts/webkitpy/common/watchlist/filenamepattern.py: Added.
  30138. * Scripts/webkitpy/common/watchlist/filenamepattern_unittest.py: Added.
  30139. * Scripts/webkitpy/common/watchlist/watchlist.py: Added the filename pattern
  30140. for definitions.
  30141. * Scripts/webkitpy/common/watchlist/watchlist_unittest.py: Added tests.
  30142. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Typo fix.
  30143. 2011-09-27 Adam Barth <abarth@webkit.org>
  30144. garden-o-matic results view should sort test and builder names
  30145. https://bugs.webkit.org/show_bug.cgi?id=68488
  30146. Reviewed by Andy Estes.
  30147. Previously, the test and builder names were displayed in an arbitrary
  30148. order that changed from time to time. That confused one user study
  30149. participant. This patch sorts the lists so that they occur in a
  30150. predictable order.
  30151. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  30152. 2011-09-27 Sheriff Bot <webkit.review.bot@gmail.com>
  30153. Unreviewed, rolling out r96108, r96111, r96113, and r96116.
  30154. http://trac.webkit.org/changeset/96108
  30155. http://trac.webkit.org/changeset/96111
  30156. http://trac.webkit.org/changeset/96113
  30157. http://trac.webkit.org/changeset/96116
  30158. https://bugs.webkit.org/show_bug.cgi?id=68913
  30159. Wait for working Qt5 (Requested by ossy on #webkit).
  30160. * DumpRenderTree/qt/DumpRenderTree.pro:
  30161. * DumpRenderTree/qt/ImageDiff.pro:
  30162. * MiniBrowser/qt/BrowserView.cpp:
  30163. (BrowserView::BrowserView):
  30164. * MiniBrowser/qt/BrowserView.h:
  30165. * MiniBrowser/qt/BrowserWindow.cpp:
  30166. (BrowserWindow::BrowserWindow):
  30167. (BrowserWindow::urlChanged):
  30168. (BrowserWindow::~BrowserWindow):
  30169. * MiniBrowser/qt/BrowserWindow.h:
  30170. * MiniBrowser/qt/MiniBrowser.pro:
  30171. * MiniBrowser/qt/MiniBrowserApplication.h:
  30172. * MiniBrowser/qt/main.cpp:
  30173. * QtTestBrowser/QtTestBrowser.pro:
  30174. * QtTestBrowser/launcherwindow.cpp:
  30175. * QtTestBrowser/launcherwindow.h:
  30176. * QtTestBrowser/locationedit.h:
  30177. * QtTestBrowser/main.cpp:
  30178. * QtTestBrowser/mainwindow.cpp:
  30179. * QtTestBrowser/mainwindow.h:
  30180. * QtTestBrowser/webinspector.h:
  30181. * QtTestBrowser/webpage.cpp:
  30182. * QtTestBrowser/webview.cpp:
  30183. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  30184. * WebKitTestRunner/PlatformWebView.h:
  30185. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  30186. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  30187. (WTR::WebView::wkView):
  30188. (WTR::WebView::pageRef):
  30189. (WTR::WebView::~WebView):
  30190. (WTR::WebView::WebView):
  30191. (WTR::PlatformWebView::PlatformWebView):
  30192. (WTR::PlatformWebView::sendEvent):
  30193. (WTR::PlatformWebView::postEvent):
  30194. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  30195. 2011-09-27 Carlos Garcia Campos <cgarcia@igalia.com>
  30196. [GTK] Rename WebKit2 GTK+ API main header as webkit2.h
  30197. https://bugs.webkit.org/show_bug.cgi?id=65178
  30198. Reviewed by Martin Robinson.
  30199. * GNUmakefile.am:
  30200. * GtkLauncher/main.c: Include <webkit2/webkit2.h>.
  30201. 2011-09-27 Csaba Osztrogonác <ossy@webkit.org>
  30202. [Qt][WK2] Buildfix after r96108.
  30203. Rubber-stamped by Andreas Kling.
  30204. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  30205. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  30206. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  30207. 2011-09-27 David Levin <levin@chromium.org>
  30208. watchlist: Change watchlistparser.py to be class based.
  30209. https://bugs.webkit.org/show_bug.cgi?id=68869
  30210. Reviewed by Eric Seidel.
  30211. * Scripts/webkitpy/common/watchlist/watchlistparser.py:
  30212. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
  30213. 2011-09-27 David Levin <levin@chromium.org>
  30214. watchlist: Break out the diff boilerplate to allow for re-use.
  30215. https://bugs.webkit.org/show_bug.cgi?id=68871
  30216. Reviewed by Eric Seidel.
  30217. * Scripts/webkitpy/common/checkout/diff_parser_unittest.py:
  30218. Break out the diff into a new file.
  30219. * Scripts/webkitpy/common/checkout/diff_test_data.py: Added.
  30220. 2011-09-27 Ilya Tikhonovsky <loislo@chromium.org>
  30221. Web Inspector: UI performance: introduce heap size tracking stats.
  30222. https://bugs.webkit.org/show_bug.cgi?id=68901
  30223. It is interesting how much the heap memory is used by Inspector in order of running the test.
  30224. Reviewed by Yury Semikhatsky.
  30225. * DumpRenderTree/chromium/TestShell.cpp:
  30226. (TestShell::showDevTools):
  30227. (TestShell::closeDevTools):
  30228. 2011-09-23 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  30229. [Qt] Fix build against Qt5 after refactor of widgets out of QtGUi
  30230. QWidget and friends now live in the QtWidgets library. We update
  30231. includes in implementation files and private headers to us the
  30232. non-module-prefixed path, and leave the lookup for the include
  30233. path. For public headers we have to ifdef the includes as the
  30234. user might now have the modules we need in his QT config.
  30235. Finally, QSGCanvas is no longer a QWidget but a QWindow, so we
  30236. have to update our code and use windowHandle() for setting the
  30237. parent relationships.
  30238. https://bugs.webkit.org/show_bug.cgi?id=68687
  30239. Reviewed by Andreas Kling.
  30240. * DumpRenderTree/qt/DumpRenderTree.pro:
  30241. * DumpRenderTree/qt/ImageDiff.pro:
  30242. * MiniBrowser/qt/BrowserView.cpp:
  30243. * MiniBrowser/qt/BrowserView.h:
  30244. * MiniBrowser/qt/BrowserWindow.cpp:
  30245. * MiniBrowser/qt/BrowserWindow.h:
  30246. * MiniBrowser/qt/MiniBrowser.pro:
  30247. * MiniBrowser/qt/MiniBrowserApplication.h:
  30248. * MiniBrowser/qt/main.cpp:
  30249. * QtTestBrowser/QtTestBrowser.pro:
  30250. * QtTestBrowser/launcherwindow.cpp:
  30251. * QtTestBrowser/launcherwindow.h:
  30252. * QtTestBrowser/locationedit.h:
  30253. * QtTestBrowser/main.cpp:
  30254. * QtTestBrowser/mainwindow.cpp:
  30255. * QtTestBrowser/mainwindow.h:
  30256. * QtTestBrowser/webinspector.h:
  30257. * QtTestBrowser/webpage.cpp:
  30258. * QtTestBrowser/webview.cpp:
  30259. * WebKitTestRunner/PlatformWebView.h:
  30260. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  30261. 2011-09-26 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  30262. [Qt][WK2] Add support for hover API in Qt WebKit2
  30263. https://bugs.webkit.org/show_bug.cgi?id=68369
  30264. Reviewed by Andreas Kling.
  30265. Change the statusbar to show the link URL when hovering links in
  30266. MiniBrowser using QDesktopWebView.
  30267. * MiniBrowser/qt/BrowserWindow.cpp:
  30268. (BrowserWindow::BrowserWindow):
  30269. (BrowserWindow::onLinkHovered):
  30270. * MiniBrowser/qt/BrowserWindow.h:
  30271. 2011-09-26 Dimitri Glazkov <dglazkov@chromium.org>
  30272. garden-o-matic's commit data on summary page should not crowd itself or twitch when hovered over.
  30273. https://bugs.webkit.org/show_bug.cgi?id=68864
  30274. Reviewed by Adam Barth.
  30275. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Updated mocks to work.
  30276. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed the structure of commit data to keep commit revision apart from the rest of details.
  30277. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
  30278. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Made things look shiny.
  30279. 2011-09-26 Csaba Osztrogonác <ossy@webkit.org>
  30280. [Qt][WK2] One more unreviewed buildfix after r96005.
  30281. * WebKitTestRunner/qt/TestInvocationQt.cpp: Missing include added.
  30282. 2011-09-26 Csaba Osztrogonác <ossy@webkit.org>
  30283. [Qt][WK2] Unreviewed buildfix after r96005.
  30284. * WebKitTestRunner/qt/TestInvocationQt.cpp:
  30285. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  30286. 2011-09-26 Dimitri Glazkov <dglazkov@chromium.org>
  30287. garden-o-matic should be pretty in Open Sans.
  30288. https://bugs.webkit.org/show_bug.cgi?id=68845
  30289. Reviewed by Adam Barth.
  30290. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked to bring back teh fonts.
  30291. 2011-09-26 Dimitri Glazkov <dglazkov@chromium.org>
  30292. garden-o-matic should not say "Just now" when it doesn't actually know when an event happened.
  30293. https://bugs.webkit.org/show_bug.cgi?id=68841
  30294. Reviewed by Adam Barth.
  30295. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Changed ui.RelativeTime to not initialize with current time.
  30296. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Adjusted unit tests.
  30297. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Ditto.
  30298. 2011-09-26 David Levin <levin@chromium.org>
  30299. watchlist: Add parsing for definition section.
  30300. https://bugs.webkit.org/show_bug.cgi?id=68850
  30301. Reviewed by Adam Barth.
  30302. * Scripts/webkitpy/common/watchlist/watchlist.py:
  30303. * Scripts/webkitpy/common/watchlist/watchlistparser.py:
  30304. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:
  30305. 2011-09-26 Simon Fraser <simon.fraser@apple.com>
  30306. Fix WebKitTestRunner builds for Cairo, Windows and Qt.
  30307. * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
  30308. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  30309. * WebKitTestRunner/win/TestInvocationWin.cpp:
  30310. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  30311. 2011-09-26 Simon Fraser <simon.fraser@apple.com>
  30312. Repaint tests don't work in WebKit2
  30313. https://bugs.webkit.org/show_bug.cgi?id=68453
  30314. Reviewed by Sam Weinig.
  30315. Convert DumpRenderTree to use use the repaint rects
  30316. exposed via WebKit API when generating the repaint test
  30317. overlay.
  30318. Fix WebKitTestRunner to work with repaint tests, again
  30319. using the repaint rects exposed from WK2.
  30320. In both cases, layoutTestController.display() now just
  30321. forces a display of the web view, and turns on repaint
  30322. rect tracking on the main FrameView.
  30323. Later, when pixel results are requested, the alpha overlay
  30324. that shows the repaint rects is generated using the list
  30325. of rects supplied by WebCore.
  30326. * DumpRenderTree/mac/DumpRenderTree.mm:
  30327. (resetDefaultsToConsistentValues):
  30328. (resetWebViewToConsistentStateBeforeTesting):
  30329. (displayWebView):
  30330. * DumpRenderTree/mac/PixelDumpSupportMac.mm:
  30331. (paintRepaintRectOverlay):
  30332. (createBitmapContextFromWebView):
  30333. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  30334. (WTR::InjectedBundle::beginTesting):
  30335. (WTR::InjectedBundle::done):
  30336. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  30337. (WTR::InjectedBundle::setRepaintRects):
  30338. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  30339. (WTR::InjectedBundlePage::reset):
  30340. (WTR::InjectedBundlePage::dump):
  30341. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  30342. (WTR::LayoutTestController::display):
  30343. * WebKitTestRunner/TestInvocation.cpp:
  30344. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  30345. * WebKitTestRunner/TestInvocation.h:
  30346. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  30347. (WTR::paintRepaintRectOverlay):
  30348. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  30349. 2011-09-26 Nayan Kumar K <nayankk@motorola.com>
  30350. Get hover'ed element URL from HitTest.
  30351. mouseDidMoveOverElement now gets the hover'ed element link using
  30352. WKHitTestResult API's.
  30353. https://bugs.webkit.org/show_bug.cgi?id=68426
  30354. Reviewed by Anders Carlsson.
  30355. * MiniBrowser/gtk/BrowserWindow.c:
  30356. (mouseDidMoveOverElement):
  30357. 2011-09-26 David Levin <levin@chromium.org>
  30358. Add skeleton parsing for a WatchList.
  30359. https://bugs.webkit.org/show_bug.cgi?id=68823
  30360. Reviewed by Adam Barth.
  30361. * Scripts/webkitpy/common/watchlist/watchlistparser.py: Added.
  30362. Parses the top level watch list sections -- none are defined yet -- and
  30363. throws an exception if an invalid one is listed.
  30364. * Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py: Added.
  30365. Verify the exception for an invalid section in a watch list.
  30366. * Scripts/webkitpy/common/watchlist/watchlist.py: Added.
  30367. 2011-09-26 Adam Roben <aroben@apple.com>
  30368. Clean up code imported from WebKitAPITest
  30369. Fixes <http://webkit.org/b/68799> WebViewDestruction tests and related code don't match
  30370. TestWebKitAPI conventions
  30371. Reviewed by David Levin.
  30372. * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Changed tests to use gtest macros
  30373. and to share functionality via test fixtures. Prefixed Win32 API calls with ::. Updated
  30374. namespace name.
  30375. (TestWebKitAPI::WebViewDestruction::SetUp):
  30376. (TestWebKitAPI::WebViewDestruction::webViewCount):
  30377. (TestWebKitAPI::WebViewDestructionWithHostWindow::SetUp):
  30378. (TestWebKitAPI::WebViewDestruction::runMessagePump):
  30379. (TestWebKitAPI::WebViewDestruction::TearDown):
  30380. (TestWebKitAPI::WebViewDestructionWithHostWindow::TearDown):
  30381. Moved functionality from free functions into these new test fixtures.
  30382. * TestWebKitAPI/win/HostWindow.cpp:
  30383. * TestWebKitAPI/win/HostWindow.h:
  30384. Prefixed Win32 API calls with ::. Updated namespace name.
  30385. 2011-09-23 Adam Roben <aroben@apple.com>
  30386. Merge WebKitAPITest into TestWebKitAPI
  30387. This also means that our formerly-WebKitAPITest tests will be run on the bots!
  30388. I made the minimal changes necessary to get the tests to run in TestWebKitAPI. I'll make
  30389. them more idiomatic in a separate pass.
  30390. Fixes <http://webkit.org/b/66560> WebKitAPITest and TestWebKitAPI have duplicate
  30391. functionality (and names!)
  30392. Reviewed by Anders Carlsson.
  30393. * TestWebKitAPI/Tests/WebKit/win/WebViewDestruction.cpp: Renamed from Tools/WebKitAPITest/tests/WebViewDestruction.cpp.
  30394. * TestWebKitAPI/win/HostWindow.cpp: Renamed from Tools/WebKitAPITest/HostWindow.cpp.
  30395. * TestWebKitAPI/win/HostWindow.h: Renamed from Tools/WebKitAPITest/HostWindow.h.
  30396. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added new files.
  30397. * TestWebKitAPI/win/main.cpp:
  30398. (main): Added a call to ::OleInitialize to make WebKit1 work. This came from WebKitAPITest.
  30399. * WebKitAPITest: Removed this directory and its contents.
  30400. 2011-09-23 Adam Roben <aroben@apple.com>
  30401. Remove two failing WebKitAPITest tests
  30402. The failures are covered by <http://webkit.org/b/33162> and <http://webkit.org/b/32868>.
  30403. Reviewed by Anders Carlsson.
  30404. * WebKitAPITest/tests/WebViewDestruction.cpp: Removed the NoCloseOrDestroyViewWindow and
  30405. MainFrameAfterClose tests.
  30406. 2011-09-25 Adam Barth <abarth@webkit.org>
  30407. Finish removing PLATFORM(BREWMP) by removing associated code
  30408. https://bugs.webkit.org/show_bug.cgi?id=68779
  30409. Reviewed by Sam Weinig.
  30410. * Scripts/webkitpy/common/config/build.py:
  30411. * waf/build/settings.py:
  30412. 2011-09-21 Ai Makabi <makabi@google.com>
  30413. Provides a simple LRU cache class in Python.
  30414. https://bugs.webkit.org/show_bug.cgi?id=67823
  30415. Reviewed by Tony Chang.
  30416. * Scripts/webkitpy/common/lru_cache.py:
  30417. * Scripts/webkitpy/common/lru_cache_unittest.py:
  30418. 2011-09-25 Adam Barth <abarth@webkit.org>
  30419. Remove PLATFORM(HAIKU) and associated code
  30420. https://bugs.webkit.org/show_bug.cgi?id=68774
  30421. Reviewed by Sam Weinig.
  30422. * Scripts/webkitpy/common/config/build.py:
  30423. * waf/build/settings.py:
  30424. 2011-09-24 Adam Barth <abarth@webkit.org>
  30425. Always enable ENABLE(OFFLINE_WEB_APPLICATIONS)
  30426. https://bugs.webkit.org/show_bug.cgi?id=68767
  30427. Reviewed by Eric Seidel.
  30428. * Scripts/build-webkit:
  30429. 2011-09-24 Adam Barth <abarth@webkit.org>
  30430. Remove ENABLE(WCSS) and associated code
  30431. https://bugs.webkit.org/show_bug.cgi?id=68759
  30432. Reviewed by Darin Adler.
  30433. * Scripts/build-webkit:
  30434. * Scripts/old-run-webkit-tests:
  30435. * Scripts/webkitperl/features.pm:
  30436. (hasFeature):
  30437. * Scripts/webkitpy/layout_tests/port/webkit.py:
  30438. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  30439. 2011-09-24 Alejandro G. Castro <alex@igalia.com>
  30440. Fixed GTK compilation after r95878, the operator== was defined
  30441. twice when USE_WEBPROCESS_EVENT_SIMULATION is defined.
  30442. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  30443. 2011-09-23 Raphael Kubo da Costa <kubo@profusion.mobi>
  30444. [DRT] Include the right config file for EFL's DRT.
  30445. https://bugs.webkit.org/show_bug.cgi?id=67042
  30446. Reviewed by Martin Robinson.
  30447. Ports which use CMake as their buildsystem (such as the EFL one) also
  30448. have config.h files, but they are named differently, so include the
  30449. right one depending on the buildsystem being used.
  30450. * DumpRenderTree/config.h:
  30451. 2011-09-23 Adam Klein <adamk@chromium.org>
  30452. Add ENABLE_MUTATION_OBSERVERS feature flag
  30453. https://bugs.webkit.org/show_bug.cgi?id=68732
  30454. Reviewed by Ojan Vafai.
  30455. This flag will guard an implementation of the "Mutation Observers" proposed in
  30456. http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html
  30457. * Scripts/build-webkit:
  30458. 2011-09-23 Chang Shu <cshu@webkit.org>
  30459. [WK2] [Qt] Implement MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
  30460. https://bugs.webkit.org/show_bug.cgi?id=68556
  30461. Implement the MouseDown/MouseUp/MouseMoveTo functions on Qt platform.
  30462. Reviewed by Darin Adler.
  30463. * WebKitTestRunner/EventSenderProxy.h:
  30464. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  30465. * WebKitTestRunner/PlatformWebView.h:
  30466. * WebKitTestRunner/mac/EventSenderProxy.mm:
  30467. (WTR::EventSenderProxy::EventSenderProxy):
  30468. (WTR::EventSenderProxy::leapForward):
  30469. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  30470. (WTR::EventSenderProxy::EventSenderProxy):
  30471. (WTR::getMouseButton):
  30472. (WTR::getModifiers):
  30473. (WTR::EventSenderProxy::updateClickCountForButton):
  30474. (WTR::EventSenderProxy::createGraphicsSceneMouseEvent):
  30475. (WTR::EventSenderProxy::mouseDown):
  30476. (WTR::EventSenderProxy::mouseUp):
  30477. (WTR::EventSenderProxy::mouseMoveTo):
  30478. (WTR::EventSenderProxy::leapForward):
  30479. (WTR::EventSenderProxy::sendOrQueueEvent):
  30480. (WTR::EventSenderProxy::replaySavedEvents):
  30481. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  30482. (WTR::PlatformWebView::postEvent):
  30483. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  30484. 2011-09-23 Lei Zhang <thestig@chromium.org>
  30485. [chromium] Make the layout test script's kill timeout proportional to --time-out-ms
  30486. https://bugs.webkit.org/show_bug.cgi?id=68026
  30487. Reviewed by Dirk Pranke.
  30488. * Scripts/webkitpy/layout_tests/port/chromium.py:
  30489. 2011-09-23 Elliot Poger <epoger@google.com>
  30490. update layout_tests to account for new default of use_skia=1
  30491. https://bugs.webkit.org/show_bug.cgi?id=68698
  30492. Rolls Source/WebKit/chromium/DEPS to pick up new default use_skia=1
  30493. from http://src.chromium.org/viewvc/chrome?view=rev&revision=102532
  30494. (Chromium-on-Mac now uses the Skia graphics library instead of
  30495. Core Graphics).
  30496. Also updates layout_test code to work with that change.
  30497. Reviewed by Mihai Parparita.
  30498. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  30499. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  30500. 2011-09-23 Mark Rowe <mrowe@apple.com>
  30501. Fix the build.
  30502. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Define operator<<(std::ostream&, const WTF::String&) inside
  30503. the WTF namespace.
  30504. 2011-09-22 Dirk Pranke <dpranke@chromium.org>
  30505. enable NRWT for run-webkit-tests on Lion
  30506. https://bugs.webkit.org/show_bug.cgi?id=68673
  30507. Reviewed by Eric Seidel.
  30508. * Scripts/run-webkit-tests:
  30509. (useNewRunWebKitTests):
  30510. 2011-09-22 Xianzhu Wang <wangxianzhu@chromium.org>
  30511. Add unit test for existing StringBuilder
  30512. https://bugs.webkit.org/show_bug.cgi?id=67080
  30513. Reviewed by Darin Adler.
  30514. * TestWebKitAPI/TestWebKitAPI.gypi:
  30515. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  30516. * TestWebKitAPI/Tests/WTF/StringBuilder.cpp: Added.
  30517. (operator<<):
  30518. (TestWebKitAPI::expectBuilderContent):
  30519. (TestWebKitAPI::expectEmpty):
  30520. (TestWebKitAPI::TEST):
  30521. 2011-09-22 Raphael Kubo da Costa <kubo@profusion.mobi>
  30522. [EFL] Use ewk_view to navigate in history instead of ewk_history.
  30523. https://bugs.webkit.org/show_bug.cgi?id=68455
  30524. Reviewed by Antonio Gomes.
  30525. BackForwardItem::invoke() was using ewk_history functions to navigate
  30526. in history; however, this will only call WebCore::BackForwardListImpl
  30527. and not move between pages at all. We now call ewk_view_navigate and
  30528. its siblings to make sure the navigation actually happens.
  30529. This should make tests like fast/dom/navigation-type-back-forward.html
  30530. stop timing out.
  30531. * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
  30532. (BackForwardItem::invoke):
  30533. 2011-09-22 Dean Jackson <dino@apple.com>
  30534. Add ENABLE_CSS_FILTERS
  30535. https://bugs.webkit.org/show_bug.cgi?id=68652
  30536. Reviewed by Simon Fraser.
  30537. * Scripts/build-webkit:
  30538. 2011-09-22 Anders Carlsson <andersca@apple.com>
  30539. EventSenderProxy::mouseUp should call -[WKView mouseUp:] instead of -[WKView mouseDown:]
  30540. https://bugs.webkit.org/show_bug.cgi?id=68660
  30541. Reviewed by Adam Barth.
  30542. * WebKitTestRunner/mac/EventSenderProxy.mm:
  30543. (WTR::EventSenderProxy::mouseUp):
  30544. 2011-09-22 Adam Roben <aroben@apple.com>
  30545. Remove FindSafari
  30546. It isn't used or built anymore.
  30547. Fixes <http://webkit.org/b/68628>
  30548. Reviewed by Darin Adler.
  30549. * FindSafari: Removed this directory and its contents.
  30550. 2011-09-22 Adam Roben <aroben@apple.com>
  30551. Remove FindSafari from all our .sln files
  30552. It isn't used anymore, so there's no point in building it.
  30553. Part of <http://webkit.org/b/68628> Remove FindSafari
  30554. Reviewed by Steve Falkenburg.
  30555. * DumpRenderTree/DumpRenderTree.sln:
  30556. * WebKitTestRunner/WebKitTestRunner.sln:
  30557. 2011-09-22 Adam Roben <aroben@apple.com>
  30558. Remove all uses of FindSafari
  30559. It isn't really needed anymore.
  30560. Fixes <http://webkit.org/b/68626>.
  30561. Reviewed by Darin Adler.
  30562. * Scripts/old-run-webkit-tests: Moved read/writeRegistryString from here to webkitdirs.pm.
  30563. * Scripts/run-webkit-nightly.cmd: Removed. This used to be used to launch nightly builds of
  30564. WebKit, but now we use WebKit.exe for that.
  30565. * Scripts/webkitdirs.pm:
  30566. (installedSafariPath): Changed to use readRegistryString instead of invoking FindSafari to
  30567. do the same thing.
  30568. (readRegistryString):
  30569. (writeRegistryString):
  30570. Moved here from old-run-webkit-tests.
  30571. 2011-09-22 Adam Roben <aroben@apple.com>
  30572. Use the "direct object" form of system() to run WebKit.exe
  30573. This prevents the shell from parsing (and possibly splitting, if it contains spaces) the
  30574. path to WebKit.exe.
  30575. Fixes <http://webkit.org/b/68623> run-safari doesn't work if there are spaces in the path to
  30576. %WEBKITOUTPUTDIR%
  30577. Reviewed by Steve Falkenburg.
  30578. * Scripts/webkitdirs.pm:
  30579. (runSafari):
  30580. 2011-09-22 Adam Roben <aroben@apple.com>
  30581. Quote the WEBKITLIBRARIESDIR path before passing it to the shell/cygpath
  30582. Fixes <http://webkit.org/b/68621> build-webkit goes totally haywire on Windows if there are
  30583. spaces in the path to the WebKit source tree
  30584. Reviewed by John Sullivan.
  30585. * Scripts/webkitdirs.pm:
  30586. (setupCygwinEnv):
  30587. 2011-09-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  30588. [Qt] Use same DPI for application font as rest of app in DRT and WTR
  30589. QApplication will initialize the default application font based
  30590. on the application DPI at construction time, but we then override
  30591. the application DPI using QX11Info (hard-coding it to 96 for
  30592. consistency). This hard-coding is not reflected in the application
  30593. font, so we explicitly have update the font ourselves.
  30594. The 6 test results that are updated were originally produced with
  30595. a DPI of 75, as this is the default fallback DPI when a QFont is
  30596. constructed before QApplication. This was wrong, and the results
  30597. are updated to match a DPI of 96.
  30598. Reviewed by Csaba Osztrogonác.
  30599. * DumpRenderTree/qt/main.cpp:
  30600. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  30601. 2011-09-21 Anna Cavender <annacc@chromium.org>
  30602. Update committers.py with a new contributor contact
  30603. https://bugs.webkit.org/show_bug.cgi?id=68565
  30604. Reviewed by Eric Carlson.
  30605. * Scripts/webkitpy/common/config/committers.py:
  30606. 2011-09-21 Chang Shu <cshu@webkit.org>
  30607. [WK2] [Mac] Implement a more-complete MouseDown/MouseUp/MouseMoveTo functions for WebKit2 EventSender
  30608. https://bugs.webkit.org/show_bug.cgi?id=68108
  30609. This patch implements the event sender mouse events through WebKit2 UIProcess which is
  30610. closer to the real simulation than a WebProcess-only approach. The patch only supports Mac
  30611. platform as the first step so the existing code is still kept for other platforms.
  30612. Reviewed by Darin Adler.
  30613. * WebKitTestRunner/EventSenderProxy.h:
  30614. (WTR::EventSenderProxy::EventSenderProxy):
  30615. (WTR::EventSenderProxy::leapForward):
  30616. (WTR::EventSenderProxy::currentEventTime):
  30617. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  30618. (WTR::EventSendingController::EventSendingController):
  30619. (WTR::EventSendingController::mouseDown):
  30620. (WTR::EventSendingController::mouseUp):
  30621. (WTR::EventSendingController::mouseMoveTo):
  30622. (WTR::EventSendingController::leapForward):
  30623. (WTR::EventSendingController::keyDown):
  30624. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  30625. * WebKitTestRunner/TestController.cpp:
  30626. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  30627. * WebKitTestRunner/mac/EventSenderProxy.mm:
  30628. (WTR::eventTypeForMouseButtonAndAction):
  30629. (WTR::operator==):
  30630. (WTR::EventSenderProxy::updateClickCountForButton):
  30631. (WTR::EventSenderProxy::mouseDown):
  30632. (WTR::EventSenderProxy::mouseUp):
  30633. (WTR::EventSenderProxy::mouseMoveTo):
  30634. (WTR::EventSenderProxy::keyDown):
  30635. * WebKitTestRunner/qt/EventSenderProxyQt.cpp:
  30636. (WTR::EventSenderProxy::keyDown):
  30637. (WTR::EventSenderProxy::mouseDown):
  30638. (WTR::EventSenderProxy::mouseUp):
  30639. (WTR::EventSenderProxy::mouseMoveTo):
  30640. 2011-09-21 Dan Bernstein <mitz@apple.com>
  30641. Tools part of: Prevent the WebKit frameworks from defining inappropriately-named Objective-C classes
  30642. https://bugs.webkit.org/show_bug.cgi?id=68451
  30643. Reviewed by Darin Adler.
  30644. * Scripts/check-for-inappropriate-objc-class-names: Added. Checks for
  30645. Objective-C classes with names not having one of a list of prefixes
  30646. passed on the command line.
  30647. 2011-09-21 Xianzhu Wang <wangxianzhu@chromium.org>
  30648. Ensure TestWebKitAPI works on mac, win, chromium-mac and chromium-linux
  30649. https://bugs.webkit.org/show_bug.cgi?id=68206
  30650. Reviewed by Tony Chang.
  30651. * Scripts/webkitdirs.pm:
  30652. (determineBaseProductDir): add support for chromium-mac
  30653. * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
  30654. * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
  30655. 2011-09-21 Adam Barth <abarth@webkit.org>
  30656. garden-o-matic command should explain that it is starting a local server
  30657. https://bugs.webkit.org/show_bug.cgi?id=68486
  30658. Reviewed by Dimitri Glazkov.
  30659. In the user study, both participants didn't understand why the
  30660. garden-o-matic command appeared to hang. This patch adds an
  30661. explaination of what's going on. It also adds a confirmation prompt
  30662. before launching the browser to give the user a chance to read the
  30663. text. If that's too much of a speed bump, we can iterate.
  30664. * Scripts/webkitpy/tool/commands/gardenomatic.py:
  30665. 2011-09-21 Chang Shu <cshu@webkit.org>
  30666. [Qt] Implement KeyDown function for WebKit2 EventSender.
  30667. https://bugs.webkit.org/show_bug.cgi?id=56485
  30668. Implement the KeyDown function on Qt platform.
  30669. Reviewed by Andreas Kling.
  30670. * WebKitTestRunner/PlatformWebView.h:
  30671. * WebKitTestRunner/TestController.cpp:
  30672. (WTR::TestController::TestController):
  30673. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  30674. * WebKitTestRunner/qt/EventSenderProxyQt.cpp: Added.
  30675. (WTR::getModifiers):
  30676. (WTR::EventSenderProxy::keyDown):
  30677. (buildModifierFlags):
  30678. (EventSenderProxy::keyDown):
  30679. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  30680. (WTR::PlatformWebView::sendEvent):
  30681. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  30682. 2011-09-20 Adam Barth <abarth@webkit.org>
  30683. garden-o-matic unit test fail because Safari 5.1 doesn't enumerate dictionaries in the same order as V8
  30684. https://bugs.webkit.org/show_bug.cgi?id=68496
  30685. Reviewed by Dimitri Glazkov.
  30686. This patch adds a bunch of sorting to make sure things happen in a
  30687. predictable order in both JavaScriptCore and V8. We've talked before
  30688. about whether these two JavaScript engines should enumerate
  30689. dictionaries in the same order, but the consensus has been that they
  30690. shouldn't. Personally, I disagree with that consensus, but such is life.
  30691. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  30692. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  30693. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  30694. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  30695. 2011-09-20 Adam Barth <abarth@webkit.org>
  30696. garden-o-matic doesn't work in Safari 5.1 because Safari 5.1 lacks Function.prototype.bind
  30697. https://bugs.webkit.org/show_bug.cgi?id=68495
  30698. Reviewed by Dimitri Glazkov.
  30699. This patch adds an implementation of Function.prototype.bind if the browser lacks one.
  30700. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  30701. 2011-09-20 Eric Seidel <eric@webkit.org>
  30702. [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
  30703. https://bugs.webkit.org/show_bug.cgi?id=65781
  30704. Reviewed by Ryosuke Niwa.
  30705. Instead of making NRWT create the symlink, I made DumpRenderTree smart enough
  30706. to resolve the passed in url relative to the absolute url for the test.
  30707. For http tests, since the test url is an http url, we can't resolve relative
  30708. to the test path, and thus use a new LOCAL_RESOURCE_ROOT environment variable
  30709. for resolving.
  30710. I believe this is a better approach than the on used in the Qt and Chromium DRT's
  30711. (which resolves the path relative to the built location of the DRT executable)
  30712. and we should move this new code into a shared location in a follow-up patch.
  30713. It turns out that there was a second use for pathToLocalResource, used by one
  30714. test (http/tests/plugins/post-url-file.html) used for getting a path to /tmp.
  30715. To support this test I made the new pathToLocalResource smart enough to map
  30716. /tmp to DUMPRENDERTREE_TEMP (which is already defined for all ports).
  30717. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  30718. (LayoutTestController::pathToLocalResource):
  30719. * Scripts/webkitpy/layout_tests/port/webkit.py: Set LOCAL_RESOURCE_ROOT for use by DRT.
  30720. 2011-09-20 Tom Zakrajsek <tomz@codeaurora.org>
  30721. Need to specify a django version, instead of using default
  30722. https://bugs.webkit.org/show_bug.cgi?id=68398
  30723. Reviewed by Eric Seidel.
  30724. * QueueStatusServer/__init__.py:
  30725. * QueueStatusServer/main.py:
  30726. 2011-09-20 Tom Zakrajsek <tomz@codeaurora.org>
  30727. Update committers.py with a few more contributor contacts
  30728. https://bugs.webkit.org/show_bug.cgi?id=68487
  30729. Reviewed by Eric Seidel.
  30730. * Scripts/webkitpy/common/config/committers.py:
  30731. 2011-09-20 Leandro Pereira <leandro@profusion.mobi>
  30732. Fix webkitpy unit tests after 95547 and 95549
  30733. https://bugs.webkit.org/show_bug.cgi?id=68483
  30734. Reviewed by Adam Barth.
  30735. Fix tests for ChangeLog.touched_files() and ChangeLog.parse_entries_from_file().
  30736. * Scripts/webkitpy/common/checkout/changelog_unittest.py: While testing
  30737. parse_entries_from_file(), use StringIO and entry.reviewer_text().
  30738. While testing parse_latest_entry_from_file(), expect the correct
  30739. touched_files() list.
  30740. 2011-09-20 Adam Barth <abarth@webkit.org>
  30741. garden-o-matic makes it hard to compare images when scroll bars appear
  30742. https://bugs.webkit.org/show_bug.cgi?id=68482
  30743. Reviewed by Eric Seidel.
  30744. Because we autoscale image width, the images rescale if we overflow
  30745. vertically and get a scrollbar. That makes it hard to compare two sets
  30746. of images. This patch reserves space for the scrollbar so we won't
  30747. have the layout change.
  30748. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
  30749. 2011-09-20 Sheriff Bot <webkit.review.bot@gmail.com>
  30750. Unreviewed, rolling out r95565.
  30751. http://trac.webkit.org/changeset/95565
  30752. https://bugs.webkit.org/show_bug.cgi?id=68470
  30753. Broke builds (Requested by andersca on #webkit).
  30754. * MiniBrowser/gtk/BrowserWindow.c:
  30755. (mouseDidMoveOverElement):
  30756. 2011-09-20 Nayan Kumar K <nayankk@motorola.com>
  30757. Get hover'ed element URL from HitTest.
  30758. mouseDidMoveOverElement now gets the hover'ed element link using
  30759. WKHitTestResult API's.
  30760. https://bugs.webkit.org/show_bug.cgi?id=68426
  30761. Reviewed by Anders Carlsson.
  30762. * MiniBrowser/gtk/BrowserWindow.c:
  30763. (mouseDidMoveOverElement):
  30764. 2011-09-20 Leandro Pereira <leandro@profusion.mobi>
  30765. Changelog class should have a method to return all entries
  30766. https://bugs.webkit.org/show_bug.cgi?id=68399
  30767. Implement ChangeLog.parse_entries_from_file(). This method returns a generator
  30768. of ChangeLogEntry objects, ordered from the latest to the oldest entry in the file.
  30769. Reviewed by Ryosuke Niwa.
  30770. * Scripts/webkitpy/common/checkout/changelog.py: Copy parse_latest_entry_from_file()
  30771. and adapt it to become a generator.
  30772. * Scripts/webkitpy/common/checkout/changelog_unittest.py: Add test case.
  30773. 2011-09-20 Jarred Nicholls <jarred@sencha.com>
  30774. [Qt] Permit qrc resources to load in QWebSettings::setUserStyleSheetUrl()
  30775. https://bugs.webkit.org/show_bug.cgi?id=51159
  30776. Permit any URL with a local scheme to set a user style sheet. Allow qrc
  30777. resource URLs as arguments to QWebSettings::setUserStyleSheetUrl().
  30778. Add DRT/WKTR qrc resource to test loading user style sheets from a qrc URL.
  30779. Reviewed by Kenneth Rohde Christiansen.
  30780. * DumpRenderTree/qt/DumpRenderTree.pro:
  30781. * DumpRenderTree/qt/DumpRenderTree.qrc: Added.
  30782. * DumpRenderTree/qt/resources/user.css: Added.
  30783. (body):
  30784. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  30785. * WebKitTestRunner/qt/WebKitTestRunner.qrc: Added.
  30786. * WebKitTestRunner/qt/resources/user.css: Added.
  30787. (body):
  30788. 2011-09-20 Leandro Pereira <leandro@profusion.mobi>
  30789. ChangeLogEntry class should contain a list of touched files
  30790. https://bugs.webkit.org/show_bug.cgi?id=68115
  30791. Reviewed by Eric Seidel.
  30792. Add method to return the list of files touched in a ChangeLog entry.
  30793. * Scripts/webkitpy/common/checkout/changelog.py: Add
  30794. touched_files_regexp and touched_files() method.
  30795. * Scripts/webkitpy/common/checkout/changelog_unittest.py: Implement
  30796. unit tests for touched_files() method.
  30797. 2011-09-20 Sheriff Bot <webkit.review.bot@gmail.com>
  30798. Unreviewed, rolling out r95526 and r95541.
  30799. http://trac.webkit.org/changeset/95526
  30800. http://trac.webkit.org/changeset/95541
  30801. https://bugs.webkit.org/show_bug.cgi?id=68443
  30802. It broke 6 tests (Requested by ossy_ on #webkit).
  30803. * DumpRenderTree/qt/main.cpp:
  30804. (main):
  30805. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  30806. (WTR::activateFonts):
  30807. 2011-09-20 Tom Zakrajsek <tomz@codeaurora.org>
  30808. Fix patch and bug numbering in the mocktool simulation code
  30809. https://bugs.webkit.org/show_bug.cgi?id=68374
  30810. Reviewed by Adam Barth.
  30811. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  30812. * Scripts/webkitpy/tool/bot/feeders_unittest.py:
  30813. * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  30814. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  30815. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  30816. * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  30817. * Scripts/webkitpy/tool/commands/download_unittest.py:
  30818. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  30819. * Scripts/webkitpy/tool/commands/queries_unittest.py:
  30820. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  30821. * Scripts/webkitpy/tool/commands/queuestest.py:
  30822. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  30823. * Scripts/webkitpy/tool/mocktool.py:
  30824. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  30825. * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  30826. 2011-09-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  30827. [Qt] Don't override default QApplication font for DRT and WTR
  30828. Revision 95526 moved the relevant code below the QApplication
  30829. constructor, to fix a potential crash, and that made the code
  30830. take effect, breaking 6 tests.
  30831. We should rely on the QWebSettings to set default fonts, and
  30832. this QApplication::setFont() is a relic from when we didn't
  30833. have that option, so we remove the code.
  30834. Reviewed by Csaba Osztrogonác.
  30835. * DumpRenderTree/qt/main.cpp:
  30836. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  30837. 2011-09-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  30838. WebKitTestRunner: Provide usage if run without arguments
  30839. If WTR is run without either one or more filenames, or
  30840. a '-' to indicate server mode, we don't need to start
  30841. up the test machinery. Doing so might actually crash,
  30842. as we'll exit the application immedeatly after anyways.
  30843. Reviewed by Simon Hausmann.
  30844. * WebKitTestRunner/TestController.cpp:
  30845. (WTR::TestController::initialize):
  30846. 2011-09-20 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  30847. [Qt] Don't use QFont before initializing QApplication
  30848. Could potentially result in crash.
  30849. Reviewed by Simon Hausmann.
  30850. * DumpRenderTree/qt/main.cpp:
  30851. (main):
  30852. 2011-09-19 Adam Barth <abarth@webkit.org>
  30853. Always enable ENABLE(EVENTSOURCE)
  30854. https://bugs.webkit.org/show_bug.cgi?id=68414
  30855. Reviewed by Eric Seidel.
  30856. * Scripts/build-webkit:
  30857. 2011-09-19 David Levin <levin@chromium.org>
  30858. Sheriffbot rollout should be more intuitive.
  30859. https://bugs.webkit.org/show_bug.cgi?id=68415
  30860. Reviewed by Adam Barth.
  30861. * Scripts/webkitpy/tool/bot/irc_command.py: Add support for revert and comma separated args.
  30862. * Scripts/webkitpy/tool/bot/irc_command_unittest.py: Add parsing tests for comma separated args
  30863. and a few others cases.
  30864. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py: Verify that revert works.
  30865. 2011-09-19 David Levin <levin@chromium.org>
  30866. check-webkit-style generates bogus warning for StructuredExceptionHandlerSupressor.h
  30867. https://bugs.webkit.org/show_bug.cgi?id=68391
  30868. Reviewed by Darin Adler.
  30869. * Scripts/webkitpy/style/checkers/cpp.py: Skip __asm lines when doing style checks on a line.
  30870. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added a test for this.
  30871. 2011-09-19 Alexis Menard <alexis.menard@openbossa.org>
  30872. Style checker should not check public Qt WK2 API for parameter_name.
  30873. https://bugs.webkit.org/show_bug.cgi?id=68359
  30874. Reviewed by Andreas Kling.
  30875. The public Qt WK2 APIs have different rules than WebKit for parameters of methods in h files.
  30876. Add an exception in the style checker to disable the check. Also added the test for it.
  30877. * Scripts/webkitpy/style/checker.py:
  30878. * Scripts/webkitpy/style/checker_unittest.py:
  30879. 2011-09-19 Leandro Pereira <leandro@profusion.mobi>
  30880. GTK DRT leaks memory while comparing history items
  30881. https://bugs.webkit.org/show_bug.cgi?id=68086
  30882. Reviewed by Martin Robinson.
  30883. webkit_web_history_item_get_target() returns a g_strdup()'d string,
  30884. so memory must be freed before compareHistoryItems() returns.
  30885. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  30886. (compareHistoryItems): Use GOwnPtr to manage memory automatically.
  30887. 2011-09-19 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  30888. Buildbot marks a nrwt bot red when tests are missing results
  30889. https://bugs.webkit.org/show_bug.cgi?id=64812
  30890. Reviewed by Ryosuke Niwa.
  30891. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  30892. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  30893. 2011-09-19 Jessie Berlin <jberlin@apple.com>
  30894. Sites that use history pushState or replaceState are recorded in history in Private Browsing
  30895. mode.
  30896. https://bugs.webkit.org/show_bug.cgi?id=68208
  30897. Reviewed by Brady Eidson.
  30898. Add a test that the WKContextDidNavigateWithNavigationDataCallback (which is invoked by
  30899. updateGlobalHistory) is not called in Private Browsing when the page does history.pushState.
  30900. * TestWebKitAPI/Tests/WebKit2/PrivateBrowsingPushStateNoHistoryCallback.cpp: Added.
  30901. (TestWebKitAPI::didNavigateWithNavigationData):
  30902. This is a context history client callback, so it should not be called when in Private
  30903. Browsing. Add a call to FAIL().
  30904. (TestWebKitAPI::didSameDocumentNavigationForFrame):
  30905. This is a page load client callback that happens after the didNavigateWithNavigationData
  30906. callback. End the test.
  30907. (TestWebKitAPI::TEST):
  30908. Enable Private Browsing and load a page that uses history.pushState.
  30909. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  30910. Add PrivateBrowsingPushStateNoHistoryCallback.cpp and push-state.html.
  30911. * TestWebKitAPI/Tests/WebKit2/push-state.html: Added.
  30912. Ditto.
  30913. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  30914. Ditto.
  30915. * TestWebKitAPI/win/copy-resources.cmd:
  30916. Ditto.
  30917. 2011-09-16 Elliot Poger <epoger@google.com>
  30918. add non-CG Webkit-Mac builds to flakiness dashboard
  30919. https://bugs.webkit.org/show_bug.cgi?id=68265
  30920. Reviewed by Adam Barth.
  30921. As Chromium-on-Mac approaches the switchover from Core Graphics to
  30922. Skia, we need to add the Skia version to the flakiness dashboard.
  30923. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  30924. * TestResultServer/static-dashboards/builders.js:
  30925. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  30926. 2011-09-16 Jochen Eisinger <jochen@chromium.org>
  30927. Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
  30928. https://bugs.webkit.org/show_bug.cgi?id=68071
  30929. Reviewed by Adam Barth.
  30930. * DumpRenderTree/chromium/WebPermissions.cpp:
  30931. (WebPermissions::allowImage):
  30932. * DumpRenderTree/chromium/WebPermissions.h:
  30933. 2011-09-16 Tom Zakrajsek <tomz@codeaurora.org>
  30934. update-webkit-chromium should retry the gclient call if it fails once
  30935. https://bugs.webkit.org/show_bug.cgi?id=68252
  30936. Reviewed by Adam Barth.
  30937. * Scripts/update-webkit-chromium:
  30938. 2011-09-16 Rob Buis <rbuis@rim.com>
  30939. Add Eli's rim address and change the nick.
  30940. * Scripts/webkitpy/common/config/committers.py:
  30941. 2011-09-16 Anders Carlsson <andersca@apple.com>
  30942. Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
  30943. https://bugs.webkit.org/show_bug.cgi?id=68269
  30944. Reviewed by Geoffrey Garen.
  30945. Update client function signatures.
  30946. * MiniBrowser/gtk/BrowserWindow.c:
  30947. (browserWindowUIClientInit):
  30948. * MiniBrowser/mac/BrowserWindowController.m:
  30949. (mouseDidMoveOverElement):
  30950. (-[BrowserWindowController awakeFromNib]):
  30951. * MiniBrowser/win/BrowserView.cpp:
  30952. (BrowserView::create):
  30953. * WebKitTestRunner/TestController.cpp:
  30954. (WTR::TestController::createOtherPage):
  30955. (WTR::TestController::initialize):
  30956. 2011-09-16 Anders Carlsson <andersca@apple.com>
  30957. Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
  30958. https://bugs.webkit.org/show_bug.cgi?id=68266
  30959. Reviewed by John Sullivan.
  30960. * MiniBrowser/mac/BrowserWindowController.m:
  30961. (mouseDidMoveOverElement):
  30962. 2011-09-16 Vincent Scheib <scheib@chromium.org>
  30963. Add Vincent Scheib to the committers list.
  30964. * Scripts/webkitpy/common/config/committers.py:
  30965. 2011-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
  30966. Unreviewed, rolling out r95285.
  30967. http://trac.webkit.org/changeset/95285
  30968. https://bugs.webkit.org/show_bug.cgi?id=68247
  30969. It broke a webkitpy test (Requested by ossy on #webkit).
  30970. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  30971. 2011-09-16 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  30972. Buildbot marks a nrwt bot red when tests are missing results
  30973. https://bugs.webkit.org/show_bug.cgi?id=64812
  30974. Reviewed by Dirk Pranke.
  30975. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  30976. 2011-09-16 Martin Robinson <mrobinson@igalia.com>
  30977. [GTK] Disable WebKit2 by default in configure.ac, but enable it with build-webkit
  30978. https://bugs.webkit.org/show_bug.cgi?id=68178
  30979. Reviewed by Xan Lopez.
  30980. Add a work-around to enable WebKit2 when using build-webkit.
  30981. * Scripts/webkitdirs.pm:
  30982. (buildAutotoolsProject):
  30983. 2011-09-15 James Robinson <jamesr@chromium.org>
  30984. Add Antoine Labour and Shawn Singh to the contributors-but-not-committers list.
  30985. * Scripts/webkitpy/common/config/committers.py:
  30986. 2011-09-15 Tom Zakrajsek <tomz@codeaurora.org>
  30987. UpdateChangeLogsWithReviewer should be able to determine reviewer of latest reviewed patch in a bug
  30988. https://bugs.webkit.org/show_bug.cgi?id=68003
  30989. Reviewed by Adam Barth.
  30990. * Scripts/webkitpy/tool/mocktool.py:
  30991. * Scripts/webkitpy/tool/steps/updatechangelogswithreview_unittest.py:
  30992. * Scripts/webkitpy/tool/steps/updatechangelogswithreviewer.py:
  30993. 2011-09-15 Tom Zakrajsek <tomz@codeaurora.org>
  30994. Python version check is confusing in test-webkitpy
  30995. https://bugs.webkit.org/show_bug.cgi?id=68004
  30996. Reviewed by Adam Barth.
  30997. * Scripts/test-webkitpy:
  30998. 2011-09-15 Eric Seidel <eric@webkit.org>
  30999. Reviewed by Adam Barth.
  31000. webkit-patch should be able to find users and add them to bugzilla groups
  31001. https://bugs.webkit.org/show_bug.cgi?id=63351
  31002. These are both very basic commands. But it's now possible to find
  31003. all users matching a regexp, as well as add all users matching a regexp
  31004. to a set of groups.
  31005. bugzilla.py already knew how to find users (for validate-committer-lists)
  31006. but now it has the ability to modify the user records.
  31007. I split some of the logic out into a new EditUsersParser class
  31008. to try and reduce the amount of code in Bugzilla/BugzillaQueries.
  31009. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  31010. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  31011. * Scripts/webkitpy/tool/commands/__init__.py:
  31012. * Scripts/webkitpy/tool/commands/adduserstogroups.py: Added.
  31013. * Scripts/webkitpy/tool/commands/findusers.py: Added.
  31014. 2011-09-15 Eric Seidel <eric@webkit.org>
  31015. Remove ENABLE(SVG_AS_IMAGE) since all major ports have it on by default
  31016. https://bugs.webkit.org/show_bug.cgi?id=68182
  31017. Reviewed by Adam Barth.
  31018. * Scripts/build-webkit:
  31019. * waf/build/settings.py:
  31020. 2011-09-15 Eric Seidel <eric@webkit.org>
  31021. Unreviewed. Make contributor email look-up case-insensitive.
  31022. validate-committer-list was incorrectly reporting that "chang.shu@nokia.com"
  31023. was missing from committers.py due to case sensitivity.
  31024. This also includes a test expectations update to committers_unittest.py
  31025. after my previous change.
  31026. * Scripts/webkitpy/common/config/committers.py:
  31027. * Scripts/webkitpy/common/config/committers_unittest.py:
  31028. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  31029. 2011-09-15 Eric Seidel <eric@webkit.org>
  31030. Unreviewed. Updated this based on webkit-patch suggest-nominations and validate-committer-list output.
  31031. Add a bunch of email aliases to committers.py for regular contributors
  31032. who are committing using other email addresses than they have listed in the file.
  31033. * Scripts/webkitpy/common/config/committers.py:
  31034. 2011-09-15 Eric Seidel <eric@webkit.org>
  31035. Remove ENABLE_SVG_ANIMATION as all major ports have it on by default
  31036. https://bugs.webkit.org/show_bug.cgi?id=68022
  31037. Reviewed by Ryosuke Niwa.
  31038. * Scripts/build-webkit:
  31039. * waf/build/settings.py:
  31040. 2011-09-15 Anders Carlsson <andersca@apple.com>
  31041. Fix Mac build by including config.h where needed.
  31042. * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
  31043. * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp:
  31044. * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp:
  31045. * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
  31046. * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp:
  31047. * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
  31048. * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
  31049. * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
  31050. * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
  31051. * TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
  31052. * TestWebKitAPI/mac/JavaScriptTestMac.mm:
  31053. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  31054. * TestWebKitAPI/mac/PlatformWebViewMac.mm:
  31055. * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m:
  31056. * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  31057. * TestWebKitAPI/mac/main.mm:
  31058. 2011-09-15 Xianzhu Wang <wangxianzhu@chromium.org>
  31059. Let TestWebKitAPI work for chromium
  31060. https://bugs.webkit.org/show_bug.cgi?id=67756
  31061. Reviewed by Sam Weinig.
  31062. * Scripts/build-api-tests:
  31063. * Scripts/run-api-tests:
  31064. (isSupportedPlatform):
  31065. (runTest):
  31066. (populateTests):
  31067. * Scripts/webkitdirs.pm:
  31068. (determineBaseProductDir):
  31069. * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
  31070. * TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  31071. * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  31072. * TestWebKitAPI/InjectedBundleController.cpp:
  31073. * TestWebKitAPI/InjectedBundleMain.cpp:
  31074. * TestWebKitAPI/JavaScriptTest.cpp:
  31075. * TestWebKitAPI/PlatformUtilities.cpp:
  31076. * TestWebKitAPI/TestWebKitAPI.gypi: Added.
  31077. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  31078. * TestWebKitAPI/TestWebKitAPIPrefix.h: Removed.
  31079. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
  31080. * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
  31081. * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  31082. * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
  31083. * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  31084. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  31085. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
  31086. * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  31087. * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
  31088. * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
  31089. * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
  31090. * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  31091. * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  31092. * TestWebKitAPI/Tests/WebKit2/Find.cpp:
  31093. * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
  31094. * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  31095. * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  31096. * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  31097. * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
  31098. * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  31099. * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
  31100. * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp:
  31101. * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp:
  31102. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  31103. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp:
  31104. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  31105. * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  31106. * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  31107. * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  31108. * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp:
  31109. * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  31110. * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  31111. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  31112. * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  31113. * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
  31114. * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
  31115. * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
  31116. * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
  31117. * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
  31118. * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
  31119. * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
  31120. * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
  31121. * TestWebKitAPI/TestsController.cpp:
  31122. * TestWebKitAPI/config.h: Copied from TestWebKitAPI/TestWebKitAPIPrefix.h.
  31123. * TestWebKitAPI/win/InjectedBundleControllerWin.cpp:
  31124. * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
  31125. * TestWebKitAPI/win/PlatformWebViewWin.cpp:
  31126. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  31127. * TestWebKitAPI/win/main.cpp:
  31128. 2011-09-15 Jochen Eisinger <jochen@chromium.org>
  31129. [chromium] extract normalization of LayoutTests URLs to a method of TestShell
  31130. https://bugs.webkit.org/show_bug.cgi?id=68145
  31131. This will allow for other classes in DumpRenderTree to reuse this functionality
  31132. Reviewed by David Levin.
  31133. * DumpRenderTree/chromium/TestShell.cpp:
  31134. (normalizeLayoutTestURLInternal):
  31135. (dumpHistoryItem):
  31136. (TestShell::normalizeLayoutTestURL):
  31137. * DumpRenderTree/chromium/TestShell.h:
  31138. 2011-09-14 Ada Chan <adachan@apple.com>
  31139. Add test for WKBundleFrameCopyWebArchive().
  31140. https://bugs.webkit.org/show_bug.cgi?id=67857
  31141. Reviewed by Anders Carlsson.
  31142. * TestWebKitAPI/Tests/WebKit2/WebArchive.cpp: Added.
  31143. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Do some basic sanity checks to make sure
  31144. the returned data is a valid webarchive.
  31145. (TestWebKitAPI::setInjectedBundleClient):
  31146. (TestWebKitAPI::didFinishLoadForFrame):
  31147. (TestWebKitAPI::TEST): Load simple.html in a WebView. Wait for it to finish loading, and then ask the
  31148. injected bundle for the webarchive and check the returned webarchive.
  31149. * TestWebKitAPI/Tests/WebKit2/WebArchive_Bundle.cpp: Added.
  31150. (TestWebKitAPI::WebArchiveTest::WebArchiveTest):
  31151. (TestWebKitAPI::WebArchiveTest::didReceiveMessage): Handle the "GetWebArchive" message and return
  31152. the web archive.
  31153. Add files to project.
  31154. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Also let Visual Studio reorder a file.
  31155. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  31156. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  31157. 2011-09-14 Ryosuke Niwa <rniwa@webkit.org>
  31158. committers.py should support multiple IRC nicknames
  31159. https://bugs.webkit.org/show_bug.cgi?id=68110
  31160. Reviewed by Eric Seidel.
  31161. Add multiple IRC nickname support to committers.py
  31162. * Scripts/webkitpy/common/config/committers.py:
  31163. * Scripts/webkitpy/common/config/committers_unittest.py:
  31164. * Scripts/webkitpy/tool/bot/irc_command.py:
  31165. * Scripts/webkitpy/tool/bot/sheriff.py:
  31166. 2011-09-14 Jon Lee <jonlee@apple.com>
  31167. Implement globalFlag for WebKitTestRunner
  31168. https://bugs.webkit.org/show_bug.cgi?id=68033
  31169. <rdar://problem/10119204>
  31170. Reviewed by Sam Weinig.
  31171. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Porting globalFlag from DRT
  31172. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  31173. (WTR::LayoutTestController::LayoutTestController): initialize m_globalFlag to false
  31174. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: add m_globalFlag
  31175. (WTR::LayoutTestController::globalFlag): simple getter
  31176. (WTR::LayoutTestController::setGlobalFlag): simple setter
  31177. 2011-09-13 Eric Seidel <eric@webkit.org>
  31178. Remove ENABLE_SVG_USE as <use> is required by HTML5
  31179. https://bugs.webkit.org/show_bug.cgi?id=68019
  31180. Reviewed by Ryosuke Niwa.
  31181. * Scripts/build-webkit:
  31182. * waf/build/settings.py:
  31183. 2011-09-14 Ryosuke Niwa <rniwa@webkit.org>
  31184. Remove Jan Erik Hanssen (added in my r95078) from the list for now
  31185. since I can't confirm acceptable his committership.
  31186. * Scripts/webkitpy/common/config/committers.py:
  31187. 2011-09-14 Jochen Eisinger <jochen@chromium.org>
  31188. [chromium] Remove obsolete WebViewClient methods from DumpRenderTree.
  31189. https://bugs.webkit.org/show_bug.cgi?id=68066
  31190. Reviewed by Adam Barth.
  31191. * DumpRenderTree/chromium/WebViewHost.cpp:
  31192. * DumpRenderTree/chromium/WebViewHost.h:
  31193. 2011-09-13 Ryosuke Niwa <rniwa@webkit.org>
  31194. committers.py is missing some contributors
  31195. https://bugs.webkit.org/show_bug.cgi?id=68059
  31196. Reviewed by Adam Barth.
  31197. Add David Barr, Jan Erik Hanssen, and Kim Grönholm.
  31198. Also add nicks of Alejandro G. Castro, Collin Jackson, and Matt Lilek.
  31199. * Scripts/webkitpy/common/config/committers.py:
  31200. 2011-09-13 Ryosuke Niwa <rniwa@webkit.org>
  31201. Fix webkit python test after r95061.
  31202. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  31203. 2011-09-13 Xianzhu Wang <wangxianzhu@chromium.org>
  31204. Add myself as a contributor. No review needed.
  31205. * Scripts/webkitpy/common/config/committers.py:
  31206. 2011-09-13 Adam Barth <abarth@webkit.org>
  31207. garden-o-matic has unfriendly error messages when the local server is not available
  31208. https://bugs.webkit.org/show_bug.cgi?id=68042
  31209. Reviewed by Dimitri Glazkov.
  31210. This patch moves us from using alert to showing the error inline in the
  31211. progress dialog.
  31212. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  31213. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  31214. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  31215. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  31216. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  31217. 2011-09-13 Adam Barth <abarth@webkit.org>
  31218. FailureGrid in garden-o-matic should link to the builder's waterfall page
  31219. https://bugs.webkit.org/show_bug.cgi?id=68036
  31220. Reviewed by Dimitri Glazkov.
  31221. One of the users in the user study thought the configurations names in
  31222. the failure grid would link to the underlying bots. That makes sense,
  31223. so this patch adds the behavior.
  31224. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  31225. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  31226. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  31227. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
  31228. 2011-09-13 Adam Barth <abarth@webkit.org>
  31229. garden-o-matic should be able to mark failures as expected
  31230. https://bugs.webkit.org/show_bug.cgi?id=68027
  31231. Reviewed by Dimitri Glazkov.
  31232. All the back-end infrastructure exists for this operation. This patch
  31233. just adds some UI to the front-end and wires that UI up to the back
  31234. end. This exact UI will likely need some more polish, but this should
  31235. be a reasonable first cut.
  31236. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  31237. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  31238. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  31239. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  31240. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  31241. 2011-09-13 Adam Barth <abarth@webkit.org>
  31242. garden-o-matic should tell you about the progress of your rebaseline
  31243. https://bugs.webkit.org/show_bug.cgi?id=67967
  31244. Reviewed by Dimitri Glazkov.
  31245. This patch adds ui.MessageBox, which is a light wrapper around jQuery
  31246. UI's dialog widget. We then use ui.MessageBox to show status messages
  31247. about in-progress rebaselines. As each baseline is downloaded, the
  31248. MessageBox updates. This UI replaces our temporary "alert"-based UI.
  31249. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  31250. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  31251. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  31252. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  31253. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  31254. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  31255. 2011-09-13 Leandro Pereira <leandro@profusion.mobi>
  31256. GTK DumpRenderTree uses inefficient idioms to iterate over G[S]Lists
  31257. https://bugs.webkit.org/show_bug.cgi?id=68024
  31258. Reviewed by Gustavo Noronha Silva.
  31259. Using g_list_count() and g_list_nth_data() together on a loop is
  31260. inneficient since they're both O(n). Iterate over lists in a saner
  31261. way.
  31262. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  31263. (dumpHistoryItem): Reduce the scope for the 'kids' variable, and
  31264. iterate on it using g_list_next(). Free the list after done with it.
  31265. (dumpBackForwardListForWebView): Instead of appending (which is
  31266. expensive in GLists) history items and then iterating from the tail
  31267. of the itemsToPrint list, prepend items and walk forwards as usual.
  31268. (dumpBackForwardListForAllWebViews): Walk the list in a saner way,
  31269. remove the (unneeded) viewList variable.
  31270. 2011-09-13 Ryosuke Niwa <rniwa@webkit.org>
  31271. Add Eric's IRC nick.
  31272. * Scripts/webkitpy/common/config/committers.py:
  31273. 2011-09-13 Anders Carlsson <andersca@apple.com>
  31274. Disable C++ exceptions when building with clang
  31275. https://bugs.webkit.org/show_bug.cgi?id=68031
  31276. <rdar://problem/9556880>
  31277. Reviewed by Mark Rowe.
  31278. * MiniBrowser/Configurations/Base.xcconfig:
  31279. * TestWebKitAPI/Configurations/Base.xcconfig:
  31280. * WebKitTestRunner/Configurations/Base.xcconfig:
  31281. 2011-09-13 Ojan Vafai <ojan@chromium.org>
  31282. [chromium] fix flakiness dashboard for chromium interactive tests
  31283. https://bugs.webkit.org/show_bug.cgi?id=68029
  31284. Reviewed by Tony Chang.
  31285. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  31286. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  31287. 2011-09-13 Ryosuke Niwa <rniwa@webkit.org>
  31288. Add Alice and Aryeh to the list of contributors.
  31289. * Scripts/webkitpy/common/config/committers.py:
  31290. 2011-09-13 Ryosuke Niwa <rniwa@webkit.org>
  31291. sheriffbot whois should also tell us email addresses
  31292. https://bugs.webkit.org/show_bug.cgi?id=67975
  31293. Reviewed by Eric Seidel and David Levin.
  31294. Taught sheriffbot how to tell us contributor's email addresses.
  31295. * Scripts/webkitpy/tool/bot/irc_command.py:
  31296. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  31297. 2011-09-13 Eric Seidel <eric@webkit.org>
  31298. Remove ENABLE_SVG_FOREIGN_OBJECT as it is a required part of HTML5
  31299. https://bugs.webkit.org/show_bug.cgi?id=68018
  31300. Reviewed by Ryosuke Niwa.
  31301. * Scripts/build-webkit:
  31302. * waf/build/settings.py:
  31303. 2011-09-13 Chang Shu <cshu@webkit.org>
  31304. [WK2] [Mac] Implement KeyDown function for WebKit2 EventSender.
  31305. https://bugs.webkit.org/show_bug.cgi?id=57515
  31306. The code change in WebKitTestRunner first sends keydown event from InjectedBundle to
  31307. TestController synchronously. The latter then sends simulated event to WebKit2 module,
  31308. which is synchronous, too.
  31309. Reviewed by Darin Adler.
  31310. * WebKitTestRunner/EventSenderProxy.h: Added.
  31311. (WTR::EventSenderProxy::EventSenderProxy):
  31312. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  31313. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  31314. (WTR::EventSendingController::keyDown):
  31315. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  31316. * WebKitTestRunner/PlatformWebView.h:
  31317. (WTR::PlatformWebView::platformWindow):
  31318. * WebKitTestRunner/TestController.cpp:
  31319. (WTR::TestController::TestController):
  31320. (WTR::TestController::didReceiveSynchronousMessageFromInjectedBundle):
  31321. * WebKitTestRunner/TestController.h:
  31322. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  31323. * WebKitTestRunner/mac/EventSenderProxy.mm: Added.
  31324. (WTR::buildModifierFlags):
  31325. (WTR::EventSenderProxy::keyDown):
  31326. 2011-09-12 Leandro Pereira <leandro@profusion.mobi>
  31327. [EFL] DRT: Add DumpRenderTreeEfl.h
  31328. https://bugs.webkit.org/show_bug.cgi?id=63993
  31329. Reviewed by Eric Seidel.
  31330. This header contains some global variables used by EFL's
  31331. DumpRenderTree implementation.
  31332. * DumpRenderTree/DumpRenderTree.h: Include DumpRenderTreeEfl.h when
  31333. appropriate.
  31334. * DumpRenderTree/efl/DumpRenderTreeEfl.h: Added.
  31335. 2011-09-12 Raphael Kubo da Costa <kubo@profusion.mobi>
  31336. [EFL] Send the right key names for PageUp and PageDown.
  31337. https://bugs.webkit.org/show_bug.cgi?id=67044
  31338. Reviewed by Kenneth Rohde Christiansen.
  31339. PlatformKeyboardEventEfl uses "Prior" and "Next" to refer to PageUp and
  31340. PageDown (which is close to the defines in WindowsKeyboardCodes.h).
  31341. However, EventSender was sending "Page_Up" and "Page_Down", so tests
  31342. such as editing/input/page-up-down-scrolls.html were timing out due to
  31343. the right key down events not being sent.
  31344. * DumpRenderTree/efl/EventSender.cpp:
  31345. (keyPadNameFromJSValue):
  31346. (keyNameFromJSValue):
  31347. 2011-09-12 Eric Seidel <eric@webkit.org>
  31348. sheriffbot whois is case sensitive
  31349. https://bugs.webkit.org/show_bug.cgi?id=67972
  31350. Reviewed by Adam Barth.
  31351. I also fixed a typo in the "More than 5 contributors" message
  31352. from my previous commit.
  31353. * Scripts/webkitpy/common/config/committers.py:
  31354. * Scripts/webkitpy/common/config/committers_unittest.py:
  31355. * Scripts/webkitpy/tool/bot/irc_command.py:
  31356. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  31357. 2011-09-12 Eric Seidel <eric@webkit.org>
  31358. sheriffbot whois should be smarter
  31359. https://bugs.webkit.org/show_bug.cgi?id=67971
  31360. Reviewed by Adam Barth.
  31361. This makes sheriffbot whois basically grep the committers list
  31362. making it much easier to find a contributor by name.
  31363. Unfortunately the current unittests depend on the real committers.py
  31364. file, so as we add more eric's to the project, this unittest result will
  31365. change. I think that's OK for now. We'll fix it when it breaks.
  31366. * Scripts/webkitpy/common/config/committers.py:
  31367. * Scripts/webkitpy/tool/bot/irc_command.py:
  31368. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  31369. 2011-09-12 Sheriff Bot <webkit.review.bot@gmail.com>
  31370. Unreviewed, rolling out r94976.
  31371. http://trac.webkit.org/changeset/94976
  31372. https://bugs.webkit.org/show_bug.cgi?id=67953
  31373. Broke a bunch of security/load& tests (Requested by rniwa on
  31374. #webkit).
  31375. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  31376. (LayoutTestController::pathToLocalResource):
  31377. 2011-09-12 Eric Seidel <eric@webkit.org>
  31378. Rubber-stamped by Adam Barth.
  31379. Remove the "the tree is burning!" warning previously shown
  31380. when landing patches. It was a dream. But it's just noise now.
  31381. Some bots will require a restart to notice the removal of the option
  31382. so I've left the --ignore-builders option in for now.
  31383. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  31384. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  31385. * Scripts/webkitpy/tool/commands/download.py:
  31386. * Scripts/webkitpy/tool/commands/download_unittest.py:
  31387. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  31388. * Scripts/webkitpy/tool/steps/__init__.py:
  31389. * Scripts/webkitpy/tool/steps/commit.py:
  31390. * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py: Removed.
  31391. * Scripts/webkitpy/tool/steps/postdiffforrevert.py:
  31392. 2011-09-12 Eric Seidel <eric@webkit.org>
  31393. [NRWT] REGRESSION: Local loader tests are failing on machines that lost /tmp/LayoutTests symlink
  31394. https://bugs.webkit.org/show_bug.cgi?id=65781
  31395. Reviewed by Ryosuke Niwa.
  31396. Instead of making NRWT create the symlink, I just made DumpRenderTree smart enough
  31397. to resolve the passed in url relative to the absolute url for the test.
  31398. I believe this is a better approach than the on used in the Qt and Chromium DRT's
  31399. (which resolves the path relative to the built location of the DRT executable)
  31400. and we should move this new code into a shared location in a follow-up patch.
  31401. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  31402. (LayoutTestController::pathToLocalResource):
  31403. 2011-09-12 Eric Seidel <eric@webkit.org>
  31404. Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
  31405. https://bugs.webkit.org/show_bug.cgi?id=67530
  31406. Reviewed by Adam Barth.
  31407. I believe I've fixed the bug in the original patch which prompted the rollout.
  31408. The previous patch was using the wrong deadline for the initial read,
  31409. subtracting time.time() twice from the deadline value.
  31410. * Scripts/webkitpy/layout_tests/port/webkit.py:
  31411. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  31412. 2011-09-12 Balazs Kelemen <kbalazs@webkit.org>
  31413. [Qt][WK2] WebKitTestRunner does not produce crash logs
  31414. https://bugs.webkit.org/show_bug.cgi?id=67714
  31415. Reviewed by Chang Shu.
  31416. Added a simple way of generating backtrace on crash
  31417. to the web process. The implementation is similar what
  31418. we have in DRT. It depends on GNU libc functionality
  31419. so it is only enabled where we are running in such an environment.
  31420. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
  31421. (WTR::printBacktrace):
  31422. (WTR::crashHandler):
  31423. (WTR::InjectedBundle::platformInitialize):
  31424. 2011-09-11 Filip Pizlo <fpizlo@apple.com>
  31425. Added my IRC nick to the committers file.
  31426. * Scripts/webkitpy/common/config/committers.py:
  31427. 2011-09-01 Filip Pizlo <fpizlo@apple.com>
  31428. The executable allocator makes it difficult to free individual
  31429. chunks of executable memory
  31430. https://bugs.webkit.org/show_bug.cgi?id=66363
  31431. Reviewed by Oliver Hunt.
  31432. Introduced a best-fit, balanced-tree based allocator. The allocator
  31433. required a balanced tree that does not allocate memory and that
  31434. permits the removal of individual nodes directly (as opposed to by
  31435. key); neither AVLTree nor WebCore's PODRedBlackTree supported this.
  31436. Changed all references to executable code to use a reference counted
  31437. handle.
  31438. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  31439. * TestWebKitAPI/Tests/WTF/MetaAllocator.cpp: Added.
  31440. (TestWebKitAPI::TEST_F):
  31441. * TestWebKitAPI/Tests/WTF/RedBlackTree.cpp: Added.
  31442. (TestWebKitAPI::Pair::findExact):
  31443. (TestWebKitAPI::Pair::remove):
  31444. (TestWebKitAPI::Pair::findLeastGreaterThanOrEqual):
  31445. (TestWebKitAPI::Pair::assertFoundAndRemove):
  31446. (TestWebKitAPI::Pair::assertEqual):
  31447. (TestWebKitAPI::Pair::assertSameValuesForKey):
  31448. (TestWebKitAPI::Pair::testDriver):
  31449. (TestWebKitAPI::TEST_F):
  31450. 2011-09-10 Andy Estes <aestes@apple.com>
  31451. Move myself from committers_unable_to_review to reviewers_list.
  31452. * Scripts/webkitpy/common/config/committers.py:
  31453. 2011-09-10 Kevin Ollivier <kevino@theolliviers.com>
  31454. [wx] Unreviewed build fix. MSW build fixes.
  31455. * DumpRenderTree/config.h:
  31456. * waf/build/wxpresets.py:
  31457. 2011-09-10 Andreas Kling <kling@webkit.org>
  31458. Crash beneath WKURLIsEqual() when reloading in MiniBrowser.
  31459. https://bugs.webkit.org/show_bug.cgi?id=59328
  31460. Reviewed by Kenneth Rohde Christiansen.
  31461. * MiniBrowser/mac/BrowserWindowController.m:
  31462. (-[BrowserWindowController updateProvisionalURLForFrame:]): Add missing null check.
  31463. 2011-09-10 Adam Barth <abarth@webkit.org>
  31464. Build fix for Android. DumpRenderTree is a client of the WebKit API
  31465. and does not have access to notImplemented().
  31466. * DumpRenderTree/chromium/TestShellAndroid.cpp:
  31467. (openStartupDialog):
  31468. 2011-09-09 Alexey Proskuryakov <ap@apple.com>
  31469. Add a script to create a monolithic script-test
  31470. https://bugs.webkit.org/show_bug.cgi?id=67747
  31471. Reviewed by Darin Adler.
  31472. * Scripts/make-new-script-test: Added.
  31473. 2011-09-09 Luiz Agostini <luiz@webkit.org>
  31474. Adding myself to the reviewers list.
  31475. * Scripts/webkitpy/common/config/committers.py:
  31476. 2011-09-09 Ryosuke Niwa <rniwa@webkit.org>
  31477. Buildbot may use RunWebKitTest's evaluateCommand on bots that run nrwt
  31478. https://bugs.webkit.org/show_bug.cgi?id=67855
  31479. Reviewed by Dirk Pranke.
  31480. The bug was caused by the fact some ports use RunWebKitTests instead of NewRunWebKitTests to run tests,
  31481. and using RunWebKitTests.evaluateCommand after calling _parseNewRunWebKitTestsOutput.
  31482. Fixed the bug by merging evaluateCommand of RunWebKitTests and NewRunWebKitTests.
  31483. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  31484. 2011-09-09 Mark Hahnenberg <mhahnenberg@apple.com>
  31485. Add myself to committers.py
  31486. https://bugs.webkit.org/show_bug.cgi?id=67853
  31487. Reviewed by Darin Adler.
  31488. * Scripts/webkitpy/common/config/committers.py:
  31489. 2011-09-09 Laszlo Gombos <laszlo.1.gombos@nokia.com>
  31490. [Qt] Remove common.pri
  31491. https://bugs.webkit.org/show_bug.cgi?id=67814
  31492. Reviewed by Andreas Kling.
  31493. * Tools.pro:
  31494. 2011-09-09 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  31495. [NRWT] the nrwt check httpd with --no-http option
  31496. https://bugs.webkit.org/show_bug.cgi?id=67835
  31497. Reviewed by Tony Chang.
  31498. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  31499. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  31500. 2011-09-09 Hao Zheng <zhenghao@chromium.org>
  31501. [chromium] Implement DRT support for Android.
  31502. https://bugs.webkit.org/show_bug.cgi?id=67590
  31503. Reviewed by Tony Chang.
  31504. Add 2 mechanism to make DRT interaction more robust on Android:
  31505. - Send 'QUIT' to DRT to make it stop.
  31506. - Wait until receiving '#READY' from DRT, so that DRT won't miss any
  31507. input commands before it starts.
  31508. And LayoutTestController.cpp needs to include <cctype> for 'tolower'
  31509. and <clocale> for 'LC_ALL' to compile on Android.
  31510. Also change to use sigaction instead of signal for TestShellGtk.cpp,
  31511. as signal() man page recommends using sigaction().
  31512. * DumpRenderTree/DumpRenderTree.gypi:
  31513. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  31514. (main):
  31515. * DumpRenderTree/chromium/LayoutTestController.cpp:
  31516. * DumpRenderTree/chromium/TestShellAndroid.cpp: Added.
  31517. (AlarmHandler):
  31518. (TestShell::waitTestFinished):
  31519. (platformInit):
  31520. (openStartupDialog):
  31521. (checkLayoutTestSystemDependencies):
  31522. * DumpRenderTree/chromium/TestShellGtk.cpp:
  31523. (AlarmHandler):
  31524. (TestShell::waitTestFinished):
  31525. 2011-09-09 Kevin Ollivier <kevino@theolliviers.com>
  31526. [wx] Unreviewed build fix. Add Source/JavaScriptCore/dfg directory to the build.
  31527. * waf/build/settings.py:
  31528. 2011-09-09 Sheriff Bot <webkit.review.bot@gmail.com>
  31529. Unreviewed, rolling out r94851.
  31530. http://trac.webkit.org/changeset/94851
  31531. https://bugs.webkit.org/show_bug.cgi?id=67847
  31532. It broke a webkitpy test (Requested by ossy on #webkit).
  31533. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  31534. 2011-09-09 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  31535. [NRWT] the nrwt check httpd with --no-http option
  31536. https://bugs.webkit.org/show_bug.cgi?id=67835
  31537. Reviewed by Csaba Osztrogonác.
  31538. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  31539. 2011-09-08 Brian Weinstein <bweinstein@apple.com>
  31540. WebKit2: Assertion when calling didPerform*Redirect on null source/destination URL string
  31541. https://bugs.webkit.org/show_bug.cgi?id=67794
  31542. <rdar://problem/9892024>
  31543. Add a test that we don't send a didPerformServerRedirect when a load is cancelled from willSendRequest.
  31544. Reviewed by Brady Eidson.
  31545. * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback.cpp: Added.
  31546. (TestWebKitAPI::didFinishLoadForFrame): Set flags on whether we've loaded the main frame, iframe, or both.
  31547. (TestWebKitAPI::didPerformServerRedirect): Set a flag for whether we've performed a server redirect.
  31548. (TestWebKitAPI::TEST): Set up a WKPageLoaderClient and WKContextHistoryClient, and load simple-iframe.html.
  31549. Once both frames have loaded (main frame and blocked iframe), make sure that we have never called
  31550. didPerformServerRedirect.
  31551. * TestWebKitAPI/Tests/WebKit2/LoadCanceledNoServerRedirectCallback_Bundle.cpp: Added.
  31552. (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::LoadCanceledNoServerRedirectCallbackTest): Initialize
  31553. our InjectedBundleTest.
  31554. (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::willSendRequestForFrame): If we are dealing with a request
  31555. from the main frame (the main resource in simple-iframe.html), allow it. If not (dealing with the iframe), block
  31556. the request.
  31557. (TestWebKitAPI::LoadCanceledNoServerRedirectCallbackTest::didCreatePage): Set up the WKBundlePageResourceLoadClient.
  31558. * TestWebKitAPI/Tests/WebKit2/simple-iframe.html: Added.
  31559. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Add new files.
  31560. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Ditto.
  31561. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Ditto.
  31562. * TestWebKitAPI/win/copy-resources.cmd: Ditto.
  31563. 2011-09-08 David Levin <levin@chromium.org>
  31564. check-webkit-style: Ref|Own Ptr& should be allowed as a parameter.
  31565. https://bugs.webkit.org/show_bug.cgi?id=67797
  31566. Reviewed by Eric Seidel.
  31567. * Scripts/webkitpy/style/checkers/cpp.py: Allow Ref/Own Ptr when it ends with &.
  31568. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added test cases for this.
  31569. 2011-09-08 Fady Samuel <fsamuel@chromium.org>
  31570. Fixed Layout Mode should be adjustable from layoutTestController for testing on Chromium platforms
  31571. https://bugs.webkit.org/show_bug.cgi?id=67723
  31572. Reviewed by Adam Barth.
  31573. * DumpRenderTree/chromium/EventSender.h:
  31574. * DumpRenderTree/chromium/LayoutTestController.cpp:
  31575. (LayoutTestController::LayoutTestController):
  31576. (LayoutTestController::enableFixedLayoutMode):
  31577. (LayoutTestController::setFixedLayoutSize):
  31578. * DumpRenderTree/chromium/LayoutTestController.h:
  31579. 2011-09-07 Matthew Delaney <mdelaney@apple.com>
  31580. Add standalone script that filters the output of build-webkit to be more human-readable
  31581. https://bugs.webkit.org/show_bug.cgi?id=44081
  31582. Reviewed by Daniel Bates.
  31583. * Scripts/filter-build-webkit: Added. Just need to feed it the output of
  31584. a build script (e.g. build-webkit) and it spits out a prettier version.
  31585. * Scripts/VCSUtils.pm: Refactored "possiblyColored" out of run-api-tests into VCSUtils.
  31586. * Scripts/run-api-tests: Now includes VCSUtils to use "possiblyColored"
  31587. 2011-09-07 Noel Gordon <noel.gordon@gmail.com>
  31588. Add myself to committers.py
  31589. https://bugs.webkit.org/show_bug.cgi?id=67696
  31590. Reviewed by Kent Tamura.
  31591. * Scripts/webkitpy/common/config/committers.py:
  31592. 2011-09-07 Adam Barth <abarth@webkit.org>
  31593. rebaseline button in garden-o-matic details view should work
  31594. https://bugs.webkit.org/show_bug.cgi?id=67738
  31595. Reviewed by Dimitri Glazkov.
  31596. This patch wires up the rebaseline button in garden-o-matic results
  31597. details view. The button is current per-test, so there isn't a way to
  31598. rebaseline individual bots. This is a place to start. If we decide we
  31599. want per-bot rebaselining, we'll need to think of some better UI.
  31600. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  31601. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  31602. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  31603. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  31604. 2011-09-07 Eric Seidel <eric@webkit.org>
  31605. Teach the PortFactory object how to pass along executive/user/filesystem to port objects (which fixes the failing rebaseline_test on bots)
  31606. https://bugs.webkit.org/show_bug.cgi?id=67737
  31607. Reviewed by Adam Barth.
  31608. I got a little over-eager when deprecating host.port_factory in the previous commit.
  31609. Turns out that Host.port_factory was already the "modern" port/factory.py
  31610. it was just the Module object. I un-deprecated the variable, and changed it from
  31611. being the module to being an actual PortFactory, passing it a host object.
  31612. I also taught PortFactory how to set user/executive/filesystem in the kwargs
  31613. when instantiating a new Port object.
  31614. This magically fixed the test_rebaseline test, since its now no longer talking
  31615. to the real filesystem.
  31616. * Scripts/webkitpy/common/host.py:
  31617. * Scripts/webkitpy/layout_tests/port/factory.py:
  31618. * Scripts/webkitpy/tool/commands/queries.py:
  31619. * Scripts/webkitpy/tool/mocktool.py:
  31620. 2011-09-07 Eric Seidel <eric@webkit.org>
  31621. Add a new PortFactory class for creating new-style ports and deprecate the old PortFactory
  31622. https://bugs.webkit.org/show_bug.cgi?id=67734
  31623. Reviewed by Adam Barth.
  31624. Right now every place that creates a Port object has to be very careful
  31625. to pass in a MockSCM/MockUser/MockFilesystem when appropriate.
  31626. The correct fix is for port/factory.py (which creates most port objects)
  31627. to know how to pass these in automatically. However, currently all port/factory.py
  31628. functions are free functions instead of being on an object. This patch
  31629. adds a new PortFactory object and deprecates the PortFactory for the old-style Port objects.
  31630. In a follow-up patch I will add PortFactory to the Host object and teach PortFactory how to
  31631. pass along the proper scm/user/filesystem to the Port object.
  31632. * Scripts/webkitpy/common/host.py:
  31633. * Scripts/webkitpy/layout_tests/port/factory.py:
  31634. * Scripts/webkitpy/tool/commands/queries.py:
  31635. * Scripts/webkitpy/tool/mocktool.py:
  31636. 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
  31637. Unreviewed, rolling out r94441.
  31638. http://trac.webkit.org/changeset/94441
  31639. https://bugs.webkit.org/show_bug.cgi?id=67731
  31640. "MacEWSes are backed up due to new machines not able to reach
  31641. git.webkit.org. Disabling tests for now" (Requested by
  31642. eseidel2 on #webkit).
  31643. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  31644. 2011-09-07 Elliot Poger <epoger@google.com>
  31645. filter test_expectations properly for chromium-mac vs chromium-cg-mac
  31646. https://bugs.webkit.org/show_bug.cgi?id=67324
  31647. Reviewed by Dirk Pranke.
  31648. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  31649. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  31650. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  31651. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  31652. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  31653. 2011-09-07 Eric Boren <borenet@gmail.com>
  31654. [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
  31655. https://bugs.webkit.org/show_bug.cgi?id=66800
  31656. Reviewed by Darin Fisher.
  31657. * DumpRenderTree/chromium/EventSender.cpp:
  31658. (EventSender::sendCurrentTouchEvent):
  31659. 2011-09-07 Jarred Nicholls <jarred@sencha.com>
  31660. [Qt][DRT] Normalize file:///tmp/LayoutTests in LayoutTestController::pathToLocalResource()
  31661. https://bugs.webkit.org/show_bug.cgi?id=67254
  31662. Reviewed by Csaba Osztrogonác.
  31663. Translate file:///tmp/LayoutTests/* urls into the repository LayoutTests directory, which is
  31664. derived from the running location of DumpRenderTree binary.
  31665. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  31666. (LayoutTestController::pathToLocalResource):
  31667. (LayoutTestController::setUserStyleSheetLocation): pass the url through pathToLocalResource
  31668. 2011-09-07 Csaba Osztrogonác <ossy@webkit.org>
  31669. REGRESSION(r94288) build-webkit doesn't work on Symbian
  31670. https://bugs.webkit.org/show_bug.cgi?id=67706
  31671. * Scripts/webkitdirs.pm: Disable automatic clean build on Symbian, because it doesn't support shadow build.
  31672. (buildQMakeProject):
  31673. 2011-09-07 Csaba Osztrogonác <ossy@webkit.org>
  31674. REGRESSION(r94288) build-webkit doesn't work on Windows
  31675. https://bugs.webkit.org/show_bug.cgi?id=67646
  31676. Roll back r94655 with a small fix.
  31677. * Scripts/webkitdirs.pm:
  31678. (buildQMakeProject):
  31679. 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
  31680. Unreviewed, rolling out r94635.
  31681. http://trac.webkit.org/changeset/94635
  31682. https://bugs.webkit.org/show_bug.cgi?id=67704
  31683. Linux Touch build is failing to compile this change.
  31684. (Requested by loislo on #webkit).
  31685. * DumpRenderTree/chromium/EventSender.cpp:
  31686. (EventSender::sendCurrentTouchEvent):
  31687. 2011-09-07 Sheriff Bot <webkit.review.bot@gmail.com>
  31688. Unreviewed, rolling out r94655.
  31689. http://trac.webkit.org/changeset/94655
  31690. https://bugs.webkit.org/show_bug.cgi?id=67703
  31691. It broke Leopard debug bot (Requested by ossy on #webkit).
  31692. * Scripts/webkitdirs.pm:
  31693. 2011-09-07 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  31694. REGRESSION(r94288) build-webkit doesn't work on Windows
  31695. https://bugs.webkit.org/show_bug.cgi?id=67646
  31696. Reviewed by Csaba Osztrogonác.
  31697. * Scripts/webkitdirs.pm:
  31698. 2011-09-06 Eric Boren <borenet@gmail.com>
  31699. [Chromium] Modify WebTouchEvent structure to match WebCore::TouchEvent
  31700. https://bugs.webkit.org/show_bug.cgi?id=66800
  31701. Reviewed by Darin Fisher.
  31702. * DumpRenderTree/chromium/EventSender.cpp:
  31703. (EventSender::sendCurrentTouchEvent):
  31704. 2011-09-06 Adam Barth <abarth@webkit.org>
  31705. garden-o-matic details view should having working rebaseline and next/previous buttons
  31706. https://bugs.webkit.org/show_bug.cgi?id=67659
  31707. Reviewed by Dimitri Glazkov.
  31708. This patch wires up basic back/forward buttons that let you traverse
  31709. through the results we're examining in the details view. This ended up
  31710. being more code than I expected, but I wanted to keep all the state
  31711. information in the DOM itself.
  31712. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  31713. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  31714. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  31715. 2011-09-01 Dirk Pranke <dpranke@chromium.org>
  31716. fix MockFileSystem.glob(), refactor filesystem tests
  31717. https://bugs.webkit.org/show_bug.cgi?id=67462
  31718. Reviewed by Eric Seidel.
  31719. In debugging why my proposed change for MockFileSystem.glob()
  31720. in bug 66228 didn't work, I stumbled across two real bugs
  31721. that cancelled each other out for the unit tests. I fixed those
  31722. (glob shouldn't recurse into subdirs, and we weren't populating
  31723. self.dirs from self.files properly).
  31724. I have also created a "mixin" class for tests that can be shared
  31725. between the real filesystem and the mock filesystem - MockFileSystem
  31726. is being used enough it needs its own tests.
  31727. * Scripts/webkitpy/common/system/filesystem_mock.py:
  31728. * Scripts/webkitpy/common/system/filesystem_mock_unittest.py: Added.
  31729. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  31730. 2011-09-06 Anders Carlsson <andersca@apple.com>
  31731. Move NPAPI headers in bridge to plugins
  31732. https://bugs.webkit.org/show_bug.cgi?id=67661
  31733. Update forwarding headers.
  31734. * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npapi.h:
  31735. * DumpRenderTree/unix/TestNetscapePlugin/ForwardingHeaders/WebKit/npruntime.h:
  31736. 2011-09-06 Tony Chang <tony@chromium.org>
  31737. [chromium] Check in 'build' for compiled binaries first
  31738. https://bugs.webkit.org/show_bug.cgi?id=67549
  31739. Reviewed by Dirk Pranke.
  31740. I'm working on moving the windows build output to a common location
  31741. rather than relative to the sln file. Because of that, we need to
  31742. check those build locations first for DumpRenderTree.exe.
  31743. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  31744. 2011-09-06 Adam Barth <abarth@webkit.org>
  31745. Use a hierarchial structure for the garden-o-matic results view
  31746. https://bugs.webkit.org/show_bug.cgi?id=67620
  31747. Reviewed by Dimitri Glazkov.
  31748. This patch re-organizes the results view to use a hierachial structure
  31749. for selection. At the top-level are sections for each test. Expanding
  31750. the test section shows a tab selector for builders.
  31751. This structure prepares us for wiring up various actions to this view.
  31752. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  31753. (.):
  31754. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  31755. ():
  31756. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  31757. (.):
  31758. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  31759. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  31760. (.results-view>.toolbar):
  31761. (.results-view>.toolbar ul.actions):
  31762. (.results-view>.toolbar ul.actions li):
  31763. (.results-grid table):
  31764. (.results-grid table td, .results-view table th):
  31765. (.results-grid table th):
  31766. (.results-grid .text-result):
  31767. (.results-grid .image-result):
  31768. 2011-09-06 Adam Barth <abarth@webkit.org>
  31769. garden-o-matic's base.probe generates spam in the JavaScript console
  31770. https://bugs.webkit.org/show_bug.cgi?id=67622
  31771. Reviewed by Dimitri Glazkov.
  31772. Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
  31773. instead of HTMLScriptElement to test whether results exist. This
  31774. reduces the console.log spam and saves bandwidth because we can use a
  31775. HEAD request instead of a GET request.
  31776. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:
  31777. 2011-09-05 Adam Barth <abarth@webkit.org>
  31778. Add a tab to garden-o-matic for viewing expected failures
  31779. https://bugs.webkit.org/show_bug.cgi?id=67619
  31780. Reviewed by Dimitri Glazkov.
  31781. This patch adds a basic tab to garden-o-matic that shows all the tests
  31782. failing on the bots, including the expected failures. This patch
  31783. mostly involves refactoring existing classes to allow new subclasses.
  31784. This view is useful for when gardeners mark tests as expected to fail
  31785. and then rebaseline them later.
  31786. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  31787. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
  31788. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  31789. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
  31790. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  31791. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  31792. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  31793. 2011-09-05 Adam Barth <abarth@webkit.org>
  31794. Fix global variable leak in garden-o-matic
  31795. https://bugs.webkit.org/show_bug.cgi?id=67617
  31796. Reviewed by Dimitri Glazkov.
  31797. Caught by running the unit tests with noglobals turned on.
  31798. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  31799. 2011-09-05 Balazs Kelemen <kbalazs@webkit.org>
  31800. [Qt][WK2] Add pixel test support
  31801. https://bugs.webkit.org/show_bug.cgi?id=66283
  31802. Reviewed by Andreas Kling.
  31803. Implemented pixel result generation by reusing the logic
  31804. that we have in DumpRenderTree.
  31805. * WebKitTestRunner/qt/TestInvocationQt.cpp:
  31806. (WTR::dumpImage):
  31807. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  31808. 2011-09-04 Robin Dunn <robin@alldunn.com>
  31809. [wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
  31810. https://bugs.webkit.org/show_bug.cgi?id=67577
  31811. Reviewed by Kevin Ollivier.
  31812. * waf/build/settings.py:
  31813. 2011-09-03 Kevin Ollivier <kevino@theolliviers.com>
  31814. [wx] Unreviewed build fix. Add wtf/dtoa directory to build.
  31815. * waf/build/settings.py:
  31816. 2011-09-03 Dan Bernstein <mitz@apple.com>
  31817. 32-bit build fix.
  31818. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  31819. (TestWebKitAPI::Util::toSTD):
  31820. 2011-09-03 Dan Bernstein <mitz@apple.com>
  31821. Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
  31822. https://bugs.webkit.org/show_bug.cgi?id=67559
  31823. Reviewed by Darin Adler.
  31824. * DumpRenderTree/mac/DumpRenderTree.mm:
  31825. (dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
  31826. the call to it.
  31827. * TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
  31828. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
  31829. * TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
  31830. (TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
  31831. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  31832. (TestWebKitAPI::Util::toSTD): Added.
  31833. 2011-09-03 Adam Barth <abarth@webkit.org>
  31834. garden-o-matic results view should have a better results selector
  31835. https://bugs.webkit.org/show_bug.cgi?id=67542
  31836. Reviewed by Dimitri Glazkov.
  31837. This patch adds a basic grid-based results selector to the results
  31838. view. Currently, this grid just shows how the tests fail on the
  31839. various bots. A future patch will let you select which failure to view
  31840. and to mark the failures for rebaselining.
  31841. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  31842. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  31843. - Add some more basic functions for manipulating dictionaries.
  31844. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  31845. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  31846. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  31847. 2011-09-03 Adam Barth <abarth@webkit.org>
  31848. garden-o-matic results view should show Actual and Expected results for text failures
  31849. https://bugs.webkit.org/show_bug.cgi?id=67536
  31850. Reviewed by Eric Seidel.
  31851. In the past, we didn't show actual and expected text results (we just
  31852. showed the diff) because we didn't have the awesome six-by-two results
  31853. grid. Now that we do, we can move show these results.
  31854. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  31855. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  31856. - Fixed some typos that were preventing these unit tests from running.
  31857. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  31858. (.):
  31859. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  31860. - Report -actual.txt and -expected.txt as possible results URLs.
  31861. 2011-09-03 Adam Barth <abarth@webkit.org>
  31862. garden-o-matic shows "ghost" failures that are already fixed
  31863. https://bugs.webkit.org/show_bug.cgi?id=67535
  31864. Reviewed by Eric Seidel.
  31865. About 10% of writes fail to stick on test-results.appspot.com. This
  31866. patch causes us to fetch the full_results.json blob directly from
  31867. build.chromium.org rather than relying upon AppEngine.
  31868. Unforuntately, we still need to get historical information from
  31869. AppEngine. That will take several patches to fix becuase I need to
  31870. change the bots to write the full_results.json file to the
  31871. build-specific directory in addition to the zip file.
  31872. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  31873. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  31874. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  31875. 2011-09-03 Sheriff Bot <webkit.review.bot@gmail.com>
  31876. Unreviewed, rolling out r94458.
  31877. http://trac.webkit.org/changeset/94458
  31878. https://bugs.webkit.org/show_bug.cgi?id=67558
  31879. Caused appcache test to fail on various bots (Requested by
  31880. rniwa on #webkit).
  31881. * Scripts/webkitpy/layout_tests/port/webkit.py:
  31882. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  31883. 2011-09-03 Sheriff Bot <webkit.review.bot@gmail.com>
  31884. Unreviewed, rolling out r94453.
  31885. http://trac.webkit.org/changeset/94453
  31886. https://bugs.webkit.org/show_bug.cgi?id=67557
  31887. Caused appcache test to fail on various bots (Requested by
  31888. rniwa on #webkit).
  31889. * Scripts/webkitpy/layout_tests/port/webkit.py:
  31890. 2011-09-02 Michael Saboff <msaboff@apple.com>
  31891. Add JSC:RegExp functional tests
  31892. https://bugs.webkit.org/show_bug.cgi?id=67339
  31893. New perl script to build JavaScriptCore and run the RegExp tests.
  31894. Reviewed by Gavin Barraclough.
  31895. * Scripts/run-regexp-tests: Added.
  31896. 2011-09-02 Michael Saboff <msaboff@apple.com>
  31897. Add JSC:RegExp functional tests
  31898. https://bugs.webkit.org/show_bug.cgi?id=67339
  31899. New perl script to build JavaScriptCore and run the RegExp tests.
  31900. Reviewed by Gavin Barraclough.
  31901. * Scripts/run-regexp-tests: Added.
  31902. 2011-09-02 Eric Seidel <eric@webkit.org>
  31903. Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
  31904. https://bugs.webkit.org/show_bug.cgi?id=67530
  31905. Unreviewed. Fixing typo from previous commit.
  31906. Turns out there was *no* unittesting of WebKitDriver. Added a basic test of _read_block
  31907. which exercises the code I previously made a typo in.
  31908. * Scripts/webkitpy/layout_tests/port/webkit.py:
  31909. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  31910. 2011-09-02 Eric Seidel <eric@webkit.org>
  31911. Reshuffle some code in WebKitDriver._read_block in preparation for reading stderr/stdout separately
  31912. https://bugs.webkit.org/show_bug.cgi?id=67530
  31913. Reviewed by Adam Barth.
  31914. No functional change, just reshuffling code.
  31915. * Scripts/webkitpy/layout_tests/port/webkit.py:
  31916. 2011-09-02 Darin Adler <darin@apple.com>
  31917. Added Subversion ignore for .pyc generated files.
  31918. * Scripts/webkitpy/layout_tests/models: Added property svn:ignore.
  31919. * Scripts/webkitpy/layout_tests/servers: Added property svn:ignore.
  31920. * Scripts/webkitpy/tool/servers: Added property svn:ignore.
  31921. 2011-09-02 Adam Barth <abarth@webkit.org>
  31922. Enable testing on mac-ews
  31923. https://bugs.webkit.org/show_bug.cgi?id=67505
  31924. Reviewed by Eric Seidel.
  31925. This patch enables testing on the Mac EWS, which should help
  31926. contributors not turn the Mac bots red.
  31927. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  31928. 2011-09-01 Beth Dakin <bdakin@apple.com>
  31929. https://bugs.webkit.org/show_bug.cgi?id=67451
  31930. Add a test for going back to a cached page after changing the device scale factor
  31931. Reviewed by Adam Roben.
  31932. New test DeviceScaleFactorOnBack.mm inherits from WebKitAgnosticTest.
  31933. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  31934. * TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm: Added.
  31935. (TestWebKitAPI::DeviceScaleFactorOnBack::url):
  31936. (TestWebKitAPI::DeviceScaleFactorOnBack::didLoadURL):
  31937. (TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
  31938. (TestWebKitAPI::DeviceScaleFactorOnBack::initializeView):
  31939. (TestWebKitAPI::DeviceScaleFactorOnBack::runTest):
  31940. (TestWebKitAPI::TEST_F):
  31941. Added new function to WebKitAgnosticTest to goBack. Separated
  31942. waitForLoadToFinish() into its own function (instead of being a part of
  31943. loadAndWaitUntilFinished()) so that it can be called from goBack as
  31944. well. Also added initializeView() so we can set the cache model.
  31945. * TestWebKitAPI/mac/WebKitAgnosticTest.h:
  31946. (TestWebKitAPI::WebKitAgnosticTest::initializeView):
  31947. * TestWebKitAPI/mac/WebKitAgnosticTest.mm:
  31948. (TestWebKitAPI::WebKitAgnosticTest::WebKitAgnosticTest):
  31949. (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
  31950. (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
  31951. (TestWebKitAPI::WebKitAgnosticTest::loadURL):
  31952. (TestWebKitAPI::WebKitAgnosticTest::goBack):
  31953. (TestWebKitAPI::WebKitAgnosticTest::waitForLoadToFinish):
  31954. 2011-09-02 Anders Carlsson <andersca@apple.com>
  31955. Build fix.
  31956. * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp:
  31957. (PrivateBrowsing::ScriptableObject::pluginTest):
  31958. 2011-09-02 Anders Carlsson <andersca@apple.com>
  31959. Move private browsing test to a PluginTest subclass
  31960. https://bugs.webkit.org/show_bug.cgi?id=67498
  31961. Reviewed by Darin Adler.
  31962. * DumpRenderTree/DumpRenderTree.gypi:
  31963. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  31964. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  31965. (pluginGetProperty):
  31966. * DumpRenderTree/TestNetscapePlugIn/PluginObject.h:
  31967. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  31968. (PluginTest::NPP_SetValue):
  31969. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  31970. * DumpRenderTree/TestNetscapePlugIn/Tests/PrivateBrowsing.cpp: Added.
  31971. (PrivateBrowsing::PrivateBrowsing):
  31972. (PrivateBrowsing::privateBrowsingEnabled):
  31973. (PrivateBrowsing::cachedPrivateBrowsingEnabled):
  31974. (PrivateBrowsing::ScriptableObject::hasProperty):
  31975. (PrivateBrowsing::ScriptableObject::getProperty):
  31976. (PrivateBrowsing::ScriptableObject::pluginTest):
  31977. (PrivateBrowsing::NPP_New):
  31978. (PrivateBrowsing::NPP_GetValue):
  31979. (PrivateBrowsing::NPP_SetValue):
  31980. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  31981. (NPP_New):
  31982. (NPP_SetValue):
  31983. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  31984. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  31985. * GNUmakefile.am:
  31986. 2011-09-02 Csaba Osztrogonác <ossy@webkit.org>
  31987. [Qt] Build dependency problems
  31988. https://bugs.webkit.org/show_bug.cgi?id=38054
  31989. Trivial fix after r94288.
  31990. Rubber-stamped by Andras Becsi.
  31991. * Scripts/webkitdirs.pm: We should read the whole defaults.txt, not only the first two lines.
  31992. (buildQMakeProject):
  31993. 2011-09-02 Andras Becsi <andras.becsi@nokia.com>
  31994. Remove my old e-mail address and add my new one.
  31995. Rubber-stamped by Tor Arne Vestbø.
  31996. * Scripts/webkitpy/common/config/committers.py:
  31997. 2011-09-02 Philippe Normand <pnormand@igalia.com>
  31998. [GTK] run-gtk-tests leaves a zombie Xvfb process
  31999. https://bugs.webkit.org/show_bug.cgi?id=67389
  32000. Reviewed by Martin Robinson.
  32001. * Scripts/run-gtk-tests: Properly close STDIN and STDERR on the
  32002. child process instead of doing shell redirection.
  32003. 2011-09-01 Mark Rowe <mrowe@apple.com>
  32004. Fix the build by adding some more missing return types.
  32005. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  32006. (-[ResourceLoadDelegate webView:identifierForInitialRequest:fromDataSource:]):
  32007. 2011-09-01 Eric Seidel <eric@webkit.org>
  32008. REGRESSION (NRWT): Leaks Viewer can't load leaks from test runs that used NRWT
  32009. https://bugs.webkit.org/show_bug.cgi?id=66228
  32010. Reviewed by Dirk Pranke.
  32011. ORWT used $(PROCESS)$(NUMBER)-leaks.txt for leaks filenames.
  32012. The LeaksViewer tool globs for all *-leaks.txt files.
  32013. This patch makes NRWT output $(PROCESS)-$(PID)-leaks.txt which should match.
  32014. In order to test this I had to fix a limitation in our MockFileSystem.glob
  32015. method. However, doing so uncovered a typo and bug in the integration tests.
  32016. I've disabled the offending integration tests.
  32017. * Scripts/webkitpy/common/system/filesystem_mock.py:
  32018. * Scripts/webkitpy/layout_tests/port/leakdetector.py:
  32019. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py:
  32020. 2011-09-01 Dominic Mazzoni <dmazzoni@google.com>
  32021. Adds a LayoutTestController method to make it possible to test
  32022. starting speech input via an API call.
  32023. https://bugs.webkit.org/show_bug.cgi?id=60170
  32024. Reviewed by Dimitri Glazkov.
  32025. * DumpRenderTree/LayoutTestController.h:
  32026. * DumpRenderTree/chromium/LayoutTestController.cpp:
  32027. (LayoutTestController::LayoutTestController):
  32028. (LayoutTestController::startSpeechInput):
  32029. * DumpRenderTree/chromium/LayoutTestController.h:
  32030. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  32031. (LayoutTestController::startSpeechInput):
  32032. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  32033. (LayoutTestController::startSpeechInput):
  32034. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  32035. (LayoutTestController::startSpeechInput):
  32036. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  32037. (LayoutTestController::startSpeechInput):
  32038. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  32039. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  32040. (LayoutTestController::startSpeechInput):
  32041. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  32042. (LayoutTestController::startSpeechInput):
  32043. 2011-09-01 Tim Horton <hortont424@gmail.com>
  32044. Fix TestWebKitAPI build on clang-2.0
  32045. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
  32046. 2011-09-01 Adam Barth <abarth@webkit.org>
  32047. Remove unused "extension" parameter from rebaseline gardeningserver handler
  32048. https://bugs.webkit.org/show_bug.cgi?id=67384
  32049. Reviewed by James Robinson.
  32050. This parameter hasn't done anything in a while.
  32051. * Scripts/webkitpy/tool/commands/rebaseline.py:
  32052. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  32053. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  32054. 2011-09-01 Eric Seidel <eric@webkit.org>
  32055. Unreviewed.
  32056. Fix a typo in unittests. Unfortunately fixing it
  32057. caused several assertions. Just disabling the test
  32058. instead, since it was providing no value before due to the typo.
  32059. * Scripts/webkitpy/layout_tests/port/test.py:
  32060. 2011-09-01 Adam Barth <abarth@webkit.org>
  32061. Add a "rebaseline" button to the garden-o-matic summary page
  32062. https://bugs.webkit.org/show_bug.cgi?id=67382
  32063. Reviewed by Dimitri Glazkov.
  32064. As much as we might wish folks to not rebaseline entire test groups at
  32065. once, the truth is that doing so is a common operation. Adding a
  32066. button for this operation is likely to make folks happy.
  32067. This patch also cleans up a bunch of plumbing surrounding failureInfo
  32068. objects.
  32069. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  32070. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  32071. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  32072. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  32073. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32074. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
  32075. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
  32076. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  32077. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32078. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  32079. 2011-09-01 Adam Barth <abarth@webkit.org>
  32080. garden-o-matic should let the gardener assign blame for a group of test failures
  32081. https://bugs.webkit.org/show_bug.cgi?id=67379
  32082. Reviewed by Dimitri Glazkov.
  32083. If a group of test failures has a large revision range, the gardener
  32084. might wish to blame a specific revision for the failure. Currently,
  32085. this only effect of assigning blame in this way is to hide the other
  32086. suspect commits.
  32087. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32088. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  32089. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32090. 2011-09-01 Adam Barth <abarth@webkit.org>
  32091. Hide garden-o-matic failure table until hover
  32092. https://bugs.webkit.org/show_bug.cgi?id=67376
  32093. Reviewed by Dimitri Glazkov.
  32094. This patch removes the failure table for build failures (because it
  32095. does not make sense) and hides the failure table for test groups until
  32096. the user hovers over the test failure block, reducing visual noise.
  32097. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32098. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  32099. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
  32100. 2011-09-01 Adam Barth <abarth@webkit.org>
  32101. Switch garden-o-matic from commitData.title to commitData.summary
  32102. https://bugs.webkit.org/show_bug.cgi?id=67375
  32103. Reviewed by Dimitri Glazkov.
  32104. commitData.title is a string provided by Trac, which isn't great in all
  32105. cases. commitData.summary is my attempt to find the most important
  32106. one-line summary of the commit. This patch switches garden-o-matic
  32107. over to summary.
  32108. Also, this patch tweaks a bunch of CSS to tighten up the summary page
  32109. and reduce visual noise.
  32110. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32111. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  32112. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css:
  32113. 2011-09-01 Adam Barth <abarth@webkit.org>
  32114. Group failing tests in garden-o-matic if there are more than three in a folder
  32115. https://bugs.webkit.org/show_bug.cgi?id=67373
  32116. Reviewed by Dimitri Glazkov.
  32117. Sometimes a failure will cause many tests in a given directory to fail.
  32118. When that happens, it's better to list the directory as a single item
  32119. (with a count) rather than spamming all the test names.
  32120. (This patch also updates a bunch of unit test expected results after my last commit.)
  32121. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  32122. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  32123. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js:
  32124. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32125. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  32126. 2011-09-01 Adam Barth <abarth@webkit.org>
  32127. Lower the visual noise from the failing builders display
  32128. https://bugs.webkit.org/show_bug.cgi?id=67369
  32129. Reviewed by Dimitri Glazkov.
  32130. This patch ensures that the "Building" row in the failing builders
  32131. display is always last and dims it by 50% to reduce visual noise. This
  32132. lets the gardener focus on the actual failures.
  32133. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  32134. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js:
  32135. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/failures.css: Added.
  32136. 2011-09-01 Kristóf Kosztyó <kkristof@inf.u-szeged.hu>
  32137. [Qt] Build dependency problems
  32138. https://bugs.webkit.org/show_bug.cgi?id=38054
  32139. Make clean build after the defines are changed.
  32140. Reviewed by Csaba Osztrogonác.
  32141. * Scripts/webkitdirs.pm:
  32142. (buildQMakeProject):
  32143. 2011-08-31 Adam Barth <abarth@webkit.org>
  32144. Move DumpRenderTree to WebKitPlatformSupport
  32145. https://bugs.webkit.org/show_bug.cgi?id=67331
  32146. Reviewed by Darin Fisher.
  32147. This patch update DumpRenderTree to account for the WebKitClient =>
  32148. WebKitPlatformSupport rename.
  32149. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  32150. (NotificationPresenter::show):
  32151. * DumpRenderTree/chromium/Task.cpp:
  32152. (postTask):
  32153. 2011-08-31 Eric Seidel <eric@webkit.org>
  32154. Add queues.webkit.org/active-bots page to make it easy to see which bots are down
  32155. https://bugs.webkit.org/show_bug.cgi?id=67314
  32156. Reviewed by Adam Barth.
  32157. Very simple page. Just lists all the bots, what queue they belong to and what we last heard from them.
  32158. If we haven't heard from a bot in the last 500 messages (last day or so), then it won't show up here.
  32159. This makes it very easy for me to see which of my cr-jail bots might be down at any one time.
  32160. I also moved a bunch of code into dashboard.css which belonged there.
  32161. * QueueStatusServer/handlers/activebots.py: Added.
  32162. * QueueStatusServer/main.py:
  32163. * QueueStatusServer/stylesheets/dashboard.css:
  32164. (.queue_bubble):
  32165. (.queue_name):
  32166. (.last_heard_from):
  32167. (.status_text):
  32168. (.alive):
  32169. (.behind):
  32170. (.dead):
  32171. * QueueStatusServer/templates/activebots.html: Added.
  32172. * QueueStatusServer/templates/dashboard.html:
  32173. * QueueStatusServer/templates/recentstatus.html:
  32174. 2011-08-31 Oliver Hunt <oliver@apple.com>
  32175. Move CheckedArithmeticOperations.cpp to the intended location
  32176. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  32177. * TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp: Renamed from Tools/TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp.
  32178. 2011-08-31 Elliot Poger <epoger@google.com>
  32179. add unittest to validate the complete set of Chromium configurations
  32180. https://bugs.webkit.org/show_bug.cgi?id=67211
  32181. Reviewed by Adam Barth.
  32182. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  32183. 2011-08-31 Nico Weber <thakis@chromium.org>
  32184. Make ScrollAnimator(Chromium)?Mac check scrollAnimatorEnabled()
  32185. https://bugs.webkit.org/show_bug.cgi?id=67297
  32186. Reviewed by Tony Chang.
  32187. Explicitly disable smooth scrolling in chromium's DRT.
  32188. * DumpRenderTree/chromium/WebPreferences.cpp:
  32189. (WebPreferences::applyTo):
  32190. 2011-08-31 Oliver Hunt <oliver@apple.com>
  32191. Add Checked<> tests to windows build
  32192. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  32193. 2011-08-30 Oliver Hunt <oliver@apple.com>
  32194. Add support for checked arithmetic
  32195. https://bugs.webkit.org/show_bug.cgi?id=67095
  32196. Reviewed by Sam Weinig.
  32197. Add test cases for Checked<>
  32198. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  32199. * TestWebKitAPI/Tests/CheckedArithmeticOperations.cpp: Added.
  32200. 2011-08-31 Adam Barth <abarth@webkit.org>
  32201. Move summary.html to garden-o-matic.html.
  32202. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html.
  32203. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js.
  32204. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Removed.
  32205. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Removed.
  32206. 2011-08-31 Noel Gordon <noel.gordon@gmail.com>
  32207. [chromium] DRT linux should pass nativeKeyCode to plugins
  32208. https://bugs.webkit.org/show_bug.cgi?id=66679
  32209. Reviewed by Tony Chang.
  32210. * DumpRenderTree/chromium/EventSender.cpp:
  32211. (EventSender::keyDown): Call a Chromium Linux GTK helper routine that returns the
  32212. (simulated) nativeKeyCode for the given input keyboard code.
  32213. 2011-08-31 Adam Barth <abarth@webkit.org>
  32214. Tighen up UI for garden-o-matic tab strip
  32215. https://bugs.webkit.org/show_bug.cgi?id=67266
  32216. Reviewed by Dimitri Glazkov.
  32217. This patch add CSS to move the tab strip to the edges of the page and
  32218. to remove some gratuitous border-radius.
  32219. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
  32220. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  32221. 2011-08-31 Adam Barth <abarth@webkit.org>
  32222. garden-o-matic results view shouldn't be horrifically ugly
  32223. https://bugs.webkit.org/show_bug.cgi?id=67264
  32224. Reviewed by Dimitri Glazkov.
  32225. Minor tweak to the results view CSS to make it fit in better with the new tabbed UI.
  32226. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32227. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  32228. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
  32229. 2011-08-31 Adam Barth <abarth@webkit.org>
  32230. garden-o-matic needs a tabstrip
  32231. https://bugs.webkit.org/show_bug.cgi?id=67263
  32232. Reviewed by Dimitri Glazkov.
  32233. This patch adds a basic tabstrip to garden-o-matic. The results
  32234. details view now opens in the "Results" tab, and the user can flip back
  32235. and forth between the Summary and the Results tab quickly. There's
  32236. also a stub for a "Commits" tab, which is disabled.
  32237. This patch isn't the most beautiful in the world, but it gets the ball
  32238. rolling on a multi-modal UI.
  32239. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32240. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  32241. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  32242. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css:
  32243. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  32244. 2011-08-31 Ai Makabi <makabi@google.com>
  32245. Extract reference links from reftest test file.
  32246. https://bugs.webkit.org/show_bug.cgi?id=66838
  32247. Reviewed by Shinichiro Hamaji.
  32248. * Scripts/webkitpy/layout_tests/reftests/__init__.py: Added.
  32249. * Scripts/webkitpy/layout_tests/reftests/extract_reference_link.py: Added.
  32250. * Scripts/webkitpy/layout_tests/reftests/extract_reference_link_unittest.py: Added.
  32251. 2011-08-03 Philippe Normand <pnormand@igalia.com>
  32252. [webkitpy] missing log import in common/net/resultsjsonparser.py
  32253. https://bugs.webkit.org/show_bug.cgi?id=65606
  32254. Reviewed by Martin Robinson.
  32255. * Scripts/webkitpy/common/net/resultsjsonparser.py: Import the logging module.
  32256. 2011-08-30 Philippe Normand <pnormand@igalia.com>
  32257. [stylechecker] complains about NULL usage in some gst_structure_ calls
  32258. https://bugs.webkit.org/show_bug.cgi?id=67194
  32259. Reviewed by Martin Robinson.
  32260. Don't warn about NULL in some gst_structure_ calls. 0 can't be
  32261. used for these, a proper sentinel is required.
  32262. * Scripts/webkitpy/style/checkers/cpp.py:
  32263. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  32264. 2011-08-30 Adam Barth <abarth@webkit.org>
  32265. Remove old-style UI from garden-o-matic
  32266. https://bugs.webkit.org/show_bug.cgi?id=67257
  32267. Reviewed by Dimitri Glazkov.
  32268. This code is nowhere near as awesome as the new hotness. Let's remove
  32269. it so it doesn't weigh us down.
  32270. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Removed.
  32271. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Removed.
  32272. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  32273. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  32274. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Removed.
  32275. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Removed.
  32276. 2011-08-30 Takashi Toyoshima <toyoshim@chromium.org>
  32277. [WebSocket] update pywebsocket to 0.6b5.
  32278. https://bugs.webkit.org/show_bug.cgi?id=66924
  32279. Reviewed by Kent Tamura.
  32280. pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
  32281. Now, pywebsocket 0.6b5 supports full features of Hybi-10 specification.
  32282. 0.6b3 or later supports a closing handshake handler and it is useful to
  32283. verify client's closing handshake implementation.
  32284. 0.6b4 supports AbortedByUserException. It is useful to eliminate
  32285. unnecessary server warning messages on intended abnormal closures.
  32286. 0.6b5 supports Python 2.5.1 or Mac 10.5.
  32287. * Scripts/webkitpy/thirdparty/__init__.py:
  32288. Update download URL and directory path.
  32289. 2011-08-30 Dan Bernstein <mitz@apple.com>
  32290. Test for <rdar://problem/9281695> Add text search API for getting the DOM range of a text match
  32291. https://bugs.webkit.org/show_bug.cgi?id=67230
  32292. Reviewed by Darin Adler.
  32293. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  32294. * TestWebKitAPI/Tests/mac/DOMRangeOfString.html: Added.
  32295. * TestWebKitAPI/Tests/mac/DOMRangeOfString.mm: Added.
  32296. (-[DOMRangeOfStringFrameLoadDelegate webView:didFinishLoadForFrame:]):
  32297. (TestWebKitAPI::TEST):
  32298. 2011-08-30 Aaron Colwell <acolwell@chromium.org>
  32299. Add MediaSource API to HTMLMediaElement
  32300. https://bugs.webkit.org/show_bug.cgi?id=64731
  32301. Reviewed by Eric Carlson.
  32302. * Scripts/build-webkit:
  32303. 2011-08-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  32304. Emit last progress notification before calling dispatchDidFinishLoad
  32305. https://bugs.webkit.org/show_bug.cgi?id=28851
  32306. Reviewed by Adam Barth.
  32307. Implement dumpProgressFinishedCallback() in the layoutTestController for Qt,
  32308. Chromium and GTK ports. The first two were simple changes.
  32309. Some refactoring was needed in GTK port to assure that the dumps are emitted
  32310. correctly and the processing after the page load finished is in the right place.
  32311. To detect the load finished, we use the callback for the "load-status" notifier
  32312. signal of the top loading frame. And we use the deprecated "load-finished" signal
  32313. for dumping (if enabled) the progress finished expected output.
  32314. * DumpRenderTree/LayoutTestController.cpp:
  32315. (LayoutTestController::LayoutTestController):
  32316. (dumpProgressFinishedCallbackCallback):
  32317. (LayoutTestController::staticFunctions):
  32318. * DumpRenderTree/LayoutTestController.h:
  32319. (LayoutTestController::dumpProgressFinishedCallback):
  32320. (LayoutTestController::setDumpProgressFinishedCallback):
  32321. * DumpRenderTree/chromium/LayoutTestController.cpp:
  32322. (LayoutTestController::LayoutTestController):
  32323. (LayoutTestController::dumpProgressFinishedCallback):
  32324. (LayoutTestController::reset):
  32325. * DumpRenderTree/chromium/LayoutTestController.h:
  32326. (LayoutTestController::shouldDumpProgressFinishedCallback):
  32327. (LayoutTestController::setShouldDumpProgressFinishedCallback):
  32328. * DumpRenderTree/chromium/WebViewHost.cpp:
  32329. (WebViewHost::didStopLoading):
  32330. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  32331. (webViewLoadFinished):
  32332. (topLoadingFrameLoadFinished):
  32333. (webFrameLoadStatusNotified):
  32334. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  32335. (LayoutTestController::reset):
  32336. (LayoutTestController::dumpProgressFinishedCallback):
  32337. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  32338. 2011-08-30 Filip Pizlo <fpizlo@apple.com>
  32339. JavaScriptCore does not have a good mechanism for performance
  32340. regression testing
  32341. https://bugs.webkit.org/show_bug.cgi?id=67177
  32342. Reviewed by Darin Adler.
  32343. Added a new script, which allows for testing one, two, or more VMs
  32344. at once on SunSpider, V8, and Kraken benchmarks. Benchmark/VM runs
  32345. are interleaved at random to minimize systematics. The results
  32346. that bencher prints includes all possible relevant information about
  32347. how bencher was invoked. Bencher can be easily used to measure
  32348. performance changes down to fractions of a percent.
  32349. Bencher also includes experimental support for running benchmarks in
  32350. a DumpRenderTree release build. This works in SunSpider and V8, but
  32351. not yet in Kraken. Running benchmarks in DumpRenderTree more
  32352. closely mimics the performance when running in browser.
  32353. * Scripts/bencher: Added.
  32354. 2011-08-29 Alexey Proskuryakov <ap@apple.com>
  32355. DumpRenderTree should begin each test with an empty cookie store
  32356. https://bugs.webkit.org/show_bug.cgi?id=63545
  32357. <rdar://problem/5666907>
  32358. Reviewed by Darin Adler.
  32359. * DumpRenderTree/mac/DumpRenderTree.mm:
  32360. (resetDefaultsToConsistentValues):
  32361. (setDefaultsToConsistentValuesForTesting):
  32362. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  32363. (LayoutTestController::setAlwaysAcceptCookies):
  32364. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  32365. (WTR::InjectedBundle::beginTesting):
  32366. Use new SPIs to manipulate sessions.
  32367. 2011-08-30 Sheriff Bot <webkit.review.bot@gmail.com>
  32368. Unreviewed, rolling out r94055 and r94057.
  32369. http://trac.webkit.org/changeset/94055
  32370. http://trac.webkit.org/changeset/94057
  32371. https://bugs.webkit.org/show_bug.cgi?id=67191
  32372. Many failures on Mac 10.5 (Requested by toyoshim on #webkit).
  32373. * Scripts/webkitpy/thirdparty/__init__.py:
  32374. 2011-08-30 Adam Barth <abarth@webkit.org>
  32375. Chromium Android should not be a core builder
  32376. https://bugs.webkit.org/show_bug.cgi?id=67184
  32377. Reviewed by Ryosuke Niwa.
  32378. This bot hasn't been consistently green yet because it has never actually run!
  32379. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  32380. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  32381. 2011-08-30 Takashi Toyoshima <toyoshim@chromium.org>
  32382. [WebSocket] update pywebsocket to 0.6b4.
  32383. https://bugs.webkit.org/show_bug.cgi?id=66924
  32384. Reviewed by Kent Tamura.
  32385. pywebsocket 0.6b2 supported minimum features of Hybi-08 specification.
  32386. Now, pywebsocket 0.6b4 supports full features of Hybi-10 specification.
  32387. 0.6b3 or later supports a closing handshake handler and it is useful to
  32388. verify client's closing handshake implementation.
  32389. 0.6b4 supports AbortedByUserException. It is useful to eliminate
  32390. unnecessary server warning messages on intended abnormal closures.
  32391. * Scripts/webkitpy/thirdparty/__init__.py:
  32392. Update download URL and directory path.
  32393. 2011-08-29 Tom Zakrajsek <tomz@codeaurora.org>
  32394. sheriffbot "usage" help statements are wrong
  32395. https://bugs.webkit.org/show_bug.cgi?id=67170
  32396. Reviewed by Adam Barth.
  32397. * Scripts/webkitpy/tool/bot/irc_command.py:
  32398. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  32399. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  32400. 2011-08-29 Adam Barth <abarth@webkit.org>
  32401. Add support for chomium-mac (non-CoreGraphics) baselines
  32402. https://bugs.webkit.org/show_bug.cgi?id=67163
  32403. Reviewed by Eric Seidel.
  32404. This patch teaches the non-CG chromium-mac bots to look at non-CG
  32405. baselines. However, the patch still leaves CG as the default set of
  32406. baselines.
  32407. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  32408. * Scripts/webkitpy/common/config/build.py:
  32409. * Scripts/webkitpy/common/config/build_unittest.py:
  32410. * Scripts/webkitpy/layout_tests/port/builders.py:
  32411. * Scripts/webkitpy/layout_tests/port/chromium.py:
  32412. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  32413. * Scripts/webkitpy/layout_tests/port/factory.py:
  32414. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  32415. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  32416. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  32417. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  32418. 2011-08-29 Shawn Singh <shawnsingh@chromium.org>
  32419. Small fix in chromium port of new-run-webkit-tests.
  32420. https://bugs.webkit.org/show_bug.cgi?id=67078
  32421. Reviewed by Dirk Pranke.
  32422. * Scripts/webkitpy/layout_tests/port/chromium.py:
  32423. 2011-08-29 Sheriff Bot <webkit.review.bot@gmail.com>
  32424. Unreviewed, rolling out r93987, r93992, r93995, r93998, and
  32425. r93999.
  32426. http://trac.webkit.org/changeset/93987
  32427. http://trac.webkit.org/changeset/93992
  32428. http://trac.webkit.org/changeset/93995
  32429. http://trac.webkit.org/changeset/93998
  32430. http://trac.webkit.org/changeset/93999
  32431. https://bugs.webkit.org/show_bug.cgi?id=67147
  32432. Many failing tests (Requested by ap on #webkit).
  32433. * DumpRenderTree/mac/DumpRenderTree.mm:
  32434. (setDefaultsToConsistentValuesForTesting):
  32435. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  32436. (WTR::InjectedBundle::beginTesting):
  32437. 2011-08-26 Alexey Proskuryakov <ap@apple.com>
  32438. DumpRenderTree should begin each test with an empty cookie store
  32439. https://bugs.webkit.org/show_bug.cgi?id=63545
  32440. <rdar://problem/5666907>
  32441. Reviewed by Darin Adler.
  32442. * DumpRenderTree/mac/DumpRenderTree.mm:
  32443. (setDefaultsToConsistentValuesForTesting):
  32444. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  32445. (WTR::InjectedBundle::beginTesting):
  32446. Tell WebCore to use a temporary session, starting with a clean cookie store.
  32447. 2011-08-23 Chris Marrin <cmarrin@apple.com>
  32448. [mac] requestAnimationFrame support for mac port
  32449. https://bugs.webkit.org/show_bug.cgi?id=59146
  32450. Reviewed by Simon Fraser.
  32451. Add support for request-animation-callback flag
  32452. * Scripts/build-webkit:
  32453. 2011-08-27 Peter Beverloo <peter@chromium.org>
  32454. Add a build bot for Chromium with OS(ANDROID)
  32455. https://bugs.webkit.org/show_bug.cgi?id=66687
  32456. Reviewed by Adam Barth.
  32457. * BuildSlaveSupport/build.webkit.org-config/config.json:
  32458. 2011-08-27 Peter Beverloo <peter@chromium.org>
  32459. Update the master build bot configuration script to properly
  32460. deal with the --chromium-android switch.
  32461. https://bugs.webkit.org/show_bug.cgi?id=66687
  32462. The --chromium-android switch is needed when running
  32463. update-webkit-chromium and build-webkit, as it'll tell the
  32464. scripts to pull in the right dependencies and cross-compile
  32465. WebKit using the Android NDK.
  32466. Reviewed by Adam Barth.
  32467. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  32468. 2011-08-27 Peter Beverloo <peter@chromium.org>
  32469. Teach the update and build scripts how to handle dependencies
  32470. and cross-compiling rules for the Chromium port on OS(ANDROID).
  32471. https://bugs.webkit.org/show_bug.cgi?id=66687
  32472. Reviewed by Adam Barth.
  32473. * Scripts/build-webkit:
  32474. * Scripts/update-webkit:
  32475. * Scripts/update-webkit-chromium:
  32476. * Scripts/webkitdirs.pm:
  32477. (argumentsForConfiguration):
  32478. (isChromium):
  32479. (isChromiumAndroid):
  32480. (determineIsChromiumAndroid):
  32481. (buildChromium):
  32482. 2011-08-26 Adam Barth <abarth@webkit.org>
  32483. garden-o-matic should let me know that I need to run the local server
  32484. https://bugs.webkit.org/show_bug.cgi?id=66985
  32485. Reviewed by Dimitri Glazkov.
  32486. The patch triggers an alert dialog whenever the user tries to use a
  32487. feature that requires the local server.
  32488. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  32489. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
  32490. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  32491. 2011-08-26 Dimitri Glazkov <dglazkov@chromium.org>
  32492. garden-o-matic summary view should have pretty commit data information.
  32493. https://bugs.webkit.org/show_bug.cgi?id=67069
  32494. Reviewed by Adam Barth.
  32495. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added support for styling commit data.
  32496. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Changed tests.
  32497. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Defined global anchor color.
  32498. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Styled commit data.
  32499. 2011-08-26 Dimitri Glazkov <dglazkov@chromium.org>
  32500. Tweak the use of Open Sans in garden-o-matic summary view to make it look decent on Windows and Linux.
  32501. https://bugs.webkit.org/show_bug.cgi?id=67066
  32502. Reviewed by Adam Barth.
  32503. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Tweaked.
  32504. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
  32505. 2011-08-26 Raphael Kubo da Costa <kubo@profusion.mobi>
  32506. [DRT] Include cairo.h in PixelDumpSupportCairo.h for EFL too.
  32507. https://bugs.webkit.org/show_bug.cgi?id=67041
  32508. Reviewed by Martin Robinson.
  32509. This is a follow-up to r89053: EFL's PixelDumpSupportEfl.cpp includes
  32510. PixelDumpSupportCairo.h, but the latter was #including cairo.h only
  32511. when the GTK+ port was being built.
  32512. * DumpRenderTree/cairo/PixelDumpSupportCairo.h:
  32513. 2011-08-26 Dimitri Glazkov <dglazkov@chromium.org>
  32514. Clean up and line up layout in garden-o-matic summary view.
  32515. https://bugs.webkit.org/show_bug.cgi?id=67057
  32516. 1) Renamed ui.notifications.TestFailures to ui.notifications.TestsFailing to match BuildersFailing;
  32517. 2) Rearranged DOM structure a bit to accommodate recent changes;
  32518. 3) Added minimal CSS to line things up.
  32519. Reviewed by Adam Barth.
  32520. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Renamed TestFailures to TestsFailing.
  32521. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added mocks for BuildersFailing.
  32522. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Renamed TestFailures to TestsFailing.
  32523. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Updated tests.
  32524. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed DOM structure.
  32525. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  32526. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Tweaked common appearance.
  32527. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added minimal layout/style.
  32528. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added Google Web Fonts hook.
  32529. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
  32530. 2011-08-26 Alice Liu <alice.liu@apple.com>
  32531. https://bugs.webkit.org/show_bug.cgi?id=66823
  32532. Add the request info to the WebPageProxy::CreateNewPage message
  32533. Reviewed by Anders Carlsson.
  32534. Update function declarations with additional parameter:
  32535. * MiniBrowser/gtk/BrowserWindow.c:
  32536. (createNewPage):
  32537. * MiniBrowser/mac/BrowserWindowController.m:
  32538. (createNewPage):
  32539. * MiniBrowser/win/BrowserView.cpp:
  32540. (createNewPage):
  32541. * WebKitTestRunner/TestController.cpp:
  32542. (WTR::TestController::createOtherPage):
  32543. * WebKitTestRunner/TestController.h:
  32544. 2011-08-26 Noel Gordon <noel.gordon@gmail.com>
  32545. Make show-pretty-diff work on linux
  32546. https://bugs.webkit.org/show_bug.cgi?id=67017
  32547. Reviewed by Adam Barth.
  32548. * Scripts/show-pretty-diff:
  32549. 2011-08-25 Dimitri Glazkov <dglazkov@chromium.org>
  32550. Reorganize garden-o-matic CSS files to match JS-built views.
  32551. https://bugs.webkit.org/show_bug.cgi?id=66998
  32552. Reviewed by Adam Barth.
  32553. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/common.css: Added.
  32554. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/notifications.css: Added.
  32555. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css: Added.
  32556. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Removed.
  32557. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Changed to use new CSS files.
  32558. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Ditto.
  32559. 2011-08-25 Adam Barth <abarth@webkit.org>
  32560. garden-o-matic should be able to roll out patches
  32561. https://bugs.webkit.org/show_bug.cgi?id=66982
  32562. Reviewed by Dimitri Glazkov.
  32563. This patch just wires the rollout event through the controller to the
  32564. local server, which is already set up to perform rollouts.
  32565. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  32566. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32567. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  32568. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:
  32569. 2011-08-25 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
  32570. [Qt] [WK2] Assert in computeViewportAttributes when MiniBrowser started with -touch
  32571. https://bugs.webkit.org/show_bug.cgi?id=66951
  32572. Reviewed by Andreas Kling.
  32573. Function computeViewportAttributes() gets called when height is still 0 because MiniBrowser sets
  32574. width and height one by one and setWidth cause geometryChange event in QTouchWebView.
  32575. * MiniBrowser/qt/BrowserView.cpp:
  32576. (BrowserView::resizeEvent):
  32577. 2011-08-25 Dimitri Glazkov <dglazkov@chromium.org>
  32578. garden-o-matic summary view should provide information on builders still in flight.
  32579. https://bugs.webkit.org/show_bug.cgi?id=66992
  32580. Reviewed by Adam Barth.
  32581. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Added grabbing the list of in-flight builders.
  32582. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Added buildersInFlightForRevision.
  32583. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Added tests.
  32584. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Split off updating builder results to own method.
  32585. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
  32586. 2011-08-25 Adam Barth <abarth@webkit.org>
  32587. webkit-patch rebaseline-expectations don't work when run outside the root
  32588. https://bugs.webkit.org/show_bug.cgi?id=66966
  32589. Reviewed by Eric Seidel.
  32590. Turns out tool.path() used to be relative, which caused problems when
  32591. running webkit-patch outside the root directory. This patch makes it
  32592. absolute. I checked all callers, and they all appear to want this
  32593. behavior.
  32594. It was unclear to me how to test this change because we only really
  32595. have a testing strategy for webkitpy, not for the main script.
  32596. * Scripts/webkit-patch:
  32597. 2011-08-25 Dimitri Glazkov <dglazkov@chromium.org>
  32598. garden-o-matic summary needs a mock view that could be used for working on styling
  32599. https://bugs.webkit.org/show_bug.cgi?id=66971
  32600. Reviewed by Adam Barth.
  32601. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js: Added.
  32602. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary-mock.html: Added.
  32603. 2011-08-25 Anders Carlsson <andersca@apple.com>
  32604. Return the correct value for NPNVsupportsCarbonBool
  32605. https://bugs.webkit.org/show_bug.cgi?id=66964
  32606. Add a test.
  32607. Reviewed by Adam Roben.
  32608. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  32609. * DumpRenderTree/TestNetscapePlugIn/Tests/mac/SupportsCarbonEventModel.cpp: Added.
  32610. (SupportsCarbonEventModel::SupportsCarbonEventModel):
  32611. (SupportsCarbonEventModel::testConvert):
  32612. (SupportsCarbonEventModel::runTest):
  32613. (SupportsCarbonEventModel::NPP_New):
  32614. 2011-08-25 Dimitri Glazkov <dglazkov@chromium.org>
  32615. garden-o-matic summary view should not be broken.
  32616. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
  32617. (table.comparison): Added more specificity.
  32618. 2011-08-25 Adam Barth <abarth@webkit.org>
  32619. This command has been broken for a while. This patch updates the
  32620. callsite to the new API.
  32621. * Scripts/webkitpy/tool/commands/rebaseline.py:
  32622. 2011-08-25 Dimitri Glazkov <dglazkov@chromium.org>
  32623. garden-o-matic needs a way to report where and how tests are failing in the summary view.
  32624. https://bugs.webkit.org/show_bug.cgi?id=66955
  32625. Introduce FailureGrid, your one-stop failure-indicating destination.
  32626. Reviewed by Adam Barth.
  32627. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added new scripts.
  32628. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures.js: Added.
  32629. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/failures_unittests.js: Added.
  32630. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Updated to use FailureGrid.
  32631. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated tests.
  32632. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added new scripts.
  32633. 2011-08-25 Igor Oliveira <igor.oliveira@openbossa.org>
  32634. Add myself to the committers list
  32635. https://bugs.webkit.org/show_bug.cgi?id=66941
  32636. Reviewed by Andreas Kling.
  32637. * Scripts/webkitpy/common/config/committers.py:
  32638. 2011-08-25 Sheriff Bot <webkit.review.bot@gmail.com>
  32639. Unreviewed, rolling out r93767.
  32640. http://trac.webkit.org/changeset/93767
  32641. https://bugs.webkit.org/show_bug.cgi?id=66931
  32642. Broke Qt bot. (Requested by yutak on #webkit).
  32643. * Scripts/webkitpy/thirdparty/__init__.py:
  32644. 2011-08-25 Takashi Toyoshima <toyoshim@chromium.org>
  32645. [WebSocket] update pywebsocket to 0.6b3 which supports closing handshake test
  32646. https://bugs.webkit.org/show_bug.cgi?id=66924
  32647. Reviewed by Kent Tamura.
  32648. * Scripts/webkitpy/thirdparty/__init__.py:
  32649. 2011-08-24 Adam Barth <abarth@webkit.org>
  32650. The user can't close the details view in garden-o-matic
  32651. https://bugs.webkit.org/show_bug.cgi?id=66911
  32652. Reviewed by Dimitri Glazkov.
  32653. In addition to adding a close button, this patch changes the test
  32654. selector to use a <select> element and refactors the test selector to
  32655. share code with the builder selector.
  32656. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32657. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  32658. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  32659. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  32660. 2011-08-24 James Robinson <jamesr@chromium.org>
  32661. [chromium] Stacktrace not in test output when a test crashes
  32662. https://bugs.webkit.org/show_bug.cgi?id=66806
  32663. Reviewed by Dirk Pranke.
  32664. Appends the .error and .text output when a test crashes since on chromium the .text contains the actual stack
  32665. trace.
  32666. * Scripts/webkitpy/layout_tests/port/chromium.py:
  32667. 2011-08-24 Adam Barth <abarth@webkit.org>
  32668. Remove empty directory.
  32669. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui: Removed.
  32670. 2011-08-24 Adam Barth <abarth@webkit.org>
  32671. Finish writing up details-view in garden-o-matic
  32672. https://bugs.webkit.org/show_bug.cgi?id=66891
  32673. Reviewed by Dimitri Glazkov.
  32674. This patch mostly just copies a bunch of CSS from main.css to
  32675. summary.css. Presumably we'll delete main.css soon.
  32676. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32677. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js:
  32678. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js:
  32679. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css:
  32680. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  32681. 2011-08-24 James Robinson <jamesr@chromium.org>
  32682. Some compositing LayoutTests flakily crashing on Mac 10.6
  32683. https://bugs.webkit.org/show_bug.cgi?id=66740
  32684. Reviewed by Adam Barth.
  32685. Null-check obj->pluginTest before dereferencing it. This can be null in chromium if the plugin load fails, for
  32686. example if the test attempts to load a PDF plugin the load will fail since we don't have such a thing in the
  32687. chromium configuration.
  32688. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  32689. (NPP_Destroy):
  32690. 2011-08-24 Anton D'Auria <adauria@apple.com>
  32691. No review necessary.
  32692. Adding myself to list of committers.
  32693. * Scripts/webkitpy/common/config/committers.py:
  32694. 2011-08-24 Avi Drissman <avi@google.com>
  32695. Crash when restoring NSGraphicsContext when running the Chromium GPU layout tests on Mac
  32696. https://bugs.webkit.org/show_bug.cgi?id=66875
  32697. Reviewed by James Robinson.
  32698. * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  32699. (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
  32700. 2011-08-23 Dimitri Glazkov <dglazkov@chromium.org>
  32701. Make notifications appear in time order again.
  32702. https://bugs.webkit.org/show_bug.cgi?id=66815
  32703. Reviewed by Adam Barth.
  32704. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added setting index of the notification.
  32705. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated the test.
  32706. 2011-08-23 James Robinson <jamesr@chromium.org>
  32707. [chromium] Need a way to test lost compositor context recovery
  32708. https://bugs.webkit.org/show_bug.cgi?id=66820
  32709. Reviewed by Kenneth Russell.
  32710. Exposes a LayoutTestController interface in chromium to simulate a
  32711. lost compositor context.
  32712. * DumpRenderTree/chromium/LayoutTestController.cpp:
  32713. (LayoutTestController::LayoutTestController):
  32714. (LayoutTestController::loseCompositorContext):
  32715. * DumpRenderTree/chromium/LayoutTestController.h:
  32716. 2011-08-23 Dimitri Glazkov <dglazkov@chromium.org>
  32717. Change garden-o-matic frontend builder array to be a configuration map.
  32718. https://bugs.webkit.org/show_bug.cgi?id=66816
  32719. Reviewed by Adam Barth.
  32720. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Made kBuilders a map, with value being a configuration object.
  32721. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Adjusted callsites to expect a map.
  32722. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Ditto.
  32723. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Ditto.
  32724. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Ditto.
  32725. 2011-08-23 Cary Clark <caryclark@google.com>
  32726. Turn WebCanvas into CGContext before drawing scrollbar (DRT using Skia on Mac)
  32727. https://bugs.webkit.org/show_bug.cgi?id=66803
  32728. This fixes the WebKit Canaries, in particular avoids a crash on tests
  32729. like css1/basic/comments.html.
  32730. Reviewed by James Robinson.
  32731. * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  32732. (WebThemeEngineDRTMac::paintNSScrollerScrollbarThumb):
  32733. The NSGraphicsContext call graphicsContextWithGraphicsPort takes a void*
  32734. parameter, so it took a WebCanvas* (mapped to SkCanvas* in Skia-land)
  32735. and treated it as if it were a CGContextRef.
  32736. 2011-08-23 Patrick Gansterer <paroga@webkit.org>
  32737. Fix mergeChangeLogs test on native windows
  32738. https://bugs.webkit.org/show_bug.cgi?id=66797
  32739. Reviewed by Adam Roben.
  32740. Windows has no /tmp/ directory and the "TMPDIR" environment variable isn't set in the default setup.
  32741. Add the "TEMP" environment variable as additional source for the temporary directory used in writeTempFile.
  32742. * Scripts/webkitperl/VCSUtils_unittest/mergeChangeLogs.pl:
  32743. (writeTempFile):
  32744. 2011-08-23 Dimitri Glazkov <dglazkov@chromium.org>
  32745. garden-o-matic relative time is wrong and updates too frequently.
  32746. https://bugs.webkit.org/show_bug.cgi?id=66802
  32747. Reviewed by Adam Barth.
  32748. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Changed to account for rounding correctly.
  32749. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Updated tests.
  32750. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Upped the interval to 1 minute.
  32751. 2011-08-23 Patrick Gansterer <paroga@webkit.org>
  32752. Add missing quotes around filenames in mergeChangeLogs
  32753. https://bugs.webkit.org/show_bug.cgi?id=66794
  32754. Reviewed by Adam Roben.
  32755. * Scripts/VCSUtils.pm:
  32756. (mergeChangeLogs):
  32757. 2011-08-23 Patrick Gansterer <paroga@webkit.org>
  32758. webkit-perl tests fail on win32 Perl due to lack of list form of pipe open implementation
  32759. https://bugs.webkit.org/show_bug.cgi?id=49080
  32760. Reviewed by Adam Roben.
  32761. Use the string form of pipe open instead (like we do at all other places).
  32762. * Scripts/VCSUtils.pm:
  32763. (mergeChangeLogs):
  32764. 2011-08-23 Adam Barth <abarth@webkit.org>
  32765. garden-o-matic summary should be able to examine failures
  32766. https://bugs.webkit.org/show_bug.cgi?id=66748
  32767. Reviewed by Dimitri Glazkov.
  32768. This patch refactors a bunch of code from summary.js to independent
  32769. controllers in controllers.js. This patch also contains the first
  32770. iteration of binding the "examine" event to a the behavior showing the
  32771. details view for the tests. There's more work to do here to make this
  32772. work properly (and elegantly), but this patch is a start.
  32773. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
  32774. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  32775. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
  32776. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers/rebaseline.js:
  32777. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  32778. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32779. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  32780. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
  32781. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  32782. 2011-08-23 Adam Barth <abarth@webkit.org>
  32783. webkitpy/common/config/build.py shouldn't mention non-existant Android directory
  32784. https://bugs.webkit.org/show_bug.cgi?id=66737
  32785. Reviewed by Steve Block.
  32786. This directory doesn't exist anymore now that the Android port shares
  32787. more code with Chromium.
  32788. * Scripts/webkitpy/common/config/build.py:
  32789. 2011-08-22 Eric Seidel <eric@webkit.org>
  32790. Hack start-queue.sh in an attempt to resurrect the cr-jail-1 cr-mac-ews bot.
  32791. I won't have ssh access to the bot again for a couple days, so
  32792. attempting to fix by changing this script. If this doesn't
  32793. work we'll just live with the it hung for now.
  32794. Unreviewed.
  32795. * EWSTools/start-queue.sh:
  32796. 2011-08-22 Dimitri Glazkov <dglazkov@chromium.org>
  32797. webkit-patch rebaseline-expectations command should not rearrange the entire test_expectations.txt file.
  32798. https://bugs.webkit.org/show_bug.cgi?id=66727
  32799. Reviewed by Adam Barth.
  32800. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Made it possible to run TestExpectationSerializer without a TestConfigurationConverter,
  32801. in which case the serializer treats all expectations as unparsed.
  32802. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added unit tests.
  32803. 2011-08-22 Dimitri Glazkov <dglazkov@chromium.org>
  32804. Update unit test expectations after r93530.
  32805. * Scripts/webkitpy/layout_tests/port/factory_unittest.py: Updated.
  32806. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Ditto.
  32807. 2011-08-22 Dimitri Glazkov <dglazkov@chromium.org>
  32808. [Chromium] Expand CPU/GPU/Skia/CG into a matrix in graphics_type.
  32809. https://bugs.webkit.org/show_bug.cgi?id=66705
  32810. Reviewed by Adam Barth.
  32811. * Scripts/webkitpy/layout_tests/port/chromium.py: Added plumbing for CG graphics types.
  32812. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Adjusted unit test.
  32813. 2011-08-22 James Robinson <jamesr@chromium.org>
  32814. [chromium] Update builder names for chromium gpu bots due to CG switchover
  32815. https://bugs.webkit.org/show_bug.cgi?id=66693
  32816. Reviewed by Dirk Pranke.
  32817. Update the port and builder names for the chromium mac gpu bots to
  32818. account for the CG transition.
  32819. * Scripts/webkitpy/layout_tests/port/builders.py:
  32820. 2011-08-22 Dirk Pranke <dpranke@chromium.org>
  32821. fix the GPU bot names on the layout test dashboard
  32822. https://bugs.webkit.org/show_bug.cgi?id=66697
  32823. Reviewed by Dimitri Glazkov.
  32824. * TestResultServer/static-dashboards/builders.js:
  32825. 2011-08-22 Dimitri Glazkov <dglazkov@chromium.org>
  32826. garden-o-matic's relative time display should be updated regularly.
  32827. https://bugs.webkit.org/show_bug.cgi?id=66682
  32828. Reviewed by Adam Barth.
  32829. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Moved Time to ui.Time, added code for regular updates.
  32830. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Changed to use ui.Time.
  32831. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Added tests.
  32832. 2011-08-22 Xianzhu Wang <wangxianzhu@chromium.org>
  32833. Pass --makeargs of build-webkit to chromium linux builder
  32834. https://bugs.webkit.org/show_bug.cgi?id=66361
  32835. Reviewed by Tony Chang.
  32836. * Scripts/build-webkit:
  32837. * Scripts/webkitdirs.pm:
  32838. (buildChromiumMakefile):
  32839. (buildChromium):
  32840. 2011-08-22 Peter Beverloo <peter@chromium.org>
  32841. Add myself to the contributor list.
  32842. https://bugs.webkit.org/show_bug.cgi?id=66674
  32843. Reviewed by Tony Gentilcore.
  32844. * Scripts/webkitpy/common/config/committers.py:
  32845. 2011-08-22 Balazs Kelemen <kbalazs@webkit.org>
  32846. [Qt] ImageDiff does not consider --tolerance
  32847. https://bugs.webkit.org/show_bug.cgi?id=66299
  32848. Reviewed by Csaba Osztrogonác.
  32849. * DumpRenderTree/qt/ImageDiff.cpp:
  32850. (main):
  32851. 2011-08-22 Csaba Osztrogonác <ossy@webkit.org>
  32852. Update contributor list.
  32853. Reviewed by Zoltan Herczeg.
  32854. * Scripts/webkitpy/common/config/committers.py:
  32855. 2011-08-22 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  32856. [ORWT] Fix --reset-results --add-platform-exceptions combo
  32857. https://bugs.webkit.org/show_bug.cgi?id=65464
  32858. Reviewed by Csaba Osztrogonác.
  32859. * Scripts/old-run-webkit-tests:
  32860. 2011-08-20 Adam Barth <abarth@webkit.org>
  32861. garden-o-matic summary.html should have UI for examining failures
  32862. https://bugs.webkit.org/show_bug.cgi?id=66625
  32863. Reviewed by Dimitri Glazkov.
  32864. This patch introduces the notion of UI actions and converts our
  32865. existing manual <button> manipulation with this new abstraction. The
  32866. patch also adds an Examine button to failure notifications. In a
  32867. future patch, I'll add a controller that wires this button up to
  32868. something useful.
  32869. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  32870. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  32871. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions.js: Added.
  32872. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/actions_unittests.js: Added.
  32873. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32874. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  32875. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
  32876. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  32877. 2011-08-20 Adam Barth <abarth@webkit.org>
  32878. garden-o-matic summary page should indiciate compile failures
  32879. https://bugs.webkit.org/show_bug.cgi?id=66624
  32880. Reviewed by Dimitri Glazkov.
  32881. This patch creates a notification-based UI for build failures. The new
  32882. UI displays the same information that used to be displayed in the
  32883. infobar. There's lots of room for improvement in surfacing more
  32884. information, but this is a start.
  32885. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js:
  32886. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
  32887. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
  32888. 2011-08-19 James Robinson <jamesr@chromium.org>
  32889. [chromium] Default to experimental-fully-parallel mode for chromium gpu port
  32890. https://bugs.webkit.org/show_bug.cgi?id=66606
  32891. Reviewed by Dirk Pranke.
  32892. The chromium GPU configuration does not (currently) contain any tests
  32893. incompatible with --experimental-fully-parallel, and this flag is a
  32894. significan speedup because of the directory canvas/philip/tests which
  32895. contains 802 tests in the same directory. Setting this option by
  32896. default on this configuration is a 2x speed in release, 44s to 22s,
  32897. and a 3x speedup in debug, 223s to 77s, on linux on a 16 core machine.
  32898. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  32899. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  32900. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  32901. 2011-08-19 Sheriff Bot <webkit.review.bot@gmail.com>
  32902. Unreviewed, rolling out r93426.
  32903. http://trac.webkit.org/changeset/93426
  32904. https://bugs.webkit.org/show_bug.cgi?id=66607
  32905. Broke the Mac build by not building gtest.framework anymore
  32906. (Requested by andersca on #webkit).
  32907. * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
  32908. 2011-08-19 James Robinson <jamesr@chromium.org>
  32909. [chromium] Chromium GPU layout tests should use the normal process number selection, not force 1 worker
  32910. https://bugs.webkit.org/show_bug.cgi?id=66603
  32911. Reviewed by Dirk Pranke.
  32912. The various ChromiumGpu ports should use the same child worker
  32913. selection logic as other ports so they can run with full
  32914. parallelization on multicore systems.
  32915. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  32916. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  32917. 2011-08-19 Alok Priyadarshi <alokp@chromium.org>
  32918. [chromium] Remove dependency of WebThemeControlDRTWin on skia::PlatformCanvas
  32919. https://bugs.webkit.org/show_bug.cgi?id=66570
  32920. Reviewed by Mihai Parparita.
  32921. * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
  32922. (WebThemeControlDRTWin::draw):
  32923. (WebThemeControlDRTWin::drawTextField):
  32924. (WebThemeControlDRTWin::drawProgressBar):
  32925. * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
  32926. 2011-08-18 Dmitry Lomov <dslomov@google.com>
  32927. TestWebKitAPI breaks on Windows due to fast malloc incompatibility.
  32928. https://bugs.webkit.org/show_bug.cgi?id=66521
  32929. This patch ensures that gtest uses new and delete operators that are defined in JavaScriptCore.
  32930. Reviewed by David Levin.
  32931. * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Removed redefinition of JS_EXPORTDATA.
  32932. 2011-08-19 Adam Roben <aroben@apple.com>
  32933. Add project file changes I left out in r93417
  32934. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  32935. 2011-08-19 Adam Roben <aroben@apple.com>
  32936. Add a helper class for swizzling ObjC instance methods to TestWebKitAPI
  32937. Fixes <http://webkit.org/b/66565> TestWebKitAPI needs a way to override instance methods of
  32938. NSScreen
  32939. Reviewed by Anders Carlsson.
  32940. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  32941. * TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
  32942. (-[SimpleObject setValue:]): Original implementation.
  32943. (TestWebKitAPI::setValue2):
  32944. (TestWebKitAPI::setValue3):
  32945. Swizzled implementations.
  32946. (TestWebKitAPI::TEST): Test that we can swizzle and re-swizzle and un-swizzle an ObjC
  32947. instance method.
  32948. * TestWebKitAPI/mac/InstanceMethodSwizzler.h: Added.
  32949. * TestWebKitAPI/mac/InstanceMethodSwizzler.mm: Added.
  32950. (TestWebKitAPI::InstanceMethodSwizzler::InstanceMethodSwizzler): Swizzle the method.
  32951. (TestWebKitAPI::InstanceMethodSwizzler::~InstanceMethodSwizzler): Unswizzle the method.
  32952. 2011-08-19 Tom Zakrajsek <tomz@codeaurora.org>
  32953. Fix _path_to_apache() error reporting
  32954. https://bugs.webkit.org/show_bug.cgi?id=66486
  32955. Reviewed by Ryosuke Niwa.
  32956. * Scripts/webkitpy/layout_tests/port/webkit.py:
  32957. 2011-08-19 Adam Roben <aroben@apple.com>
  32958. Windows build fix after r93404
  32959. * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp: Added missing #include.
  32960. 2011-08-19 Tony Gentilcore <tonyg@chromium.org>
  32961. Add leandrogracia to the committers list
  32962. https://bugs.webkit.org/show_bug.cgi?id=66552
  32963. Also fix line endings in file.
  32964. No reviewed required.
  32965. * Scripts/webkitpy/common/config/committers.py:
  32966. 2011-08-19 Amruth Raj <amruthraj@motorola.com>
  32967. Fix compilation issue in WebKitTestRunner
  32968. https://bugs.webkit.org/show_bug.cgi?id=66554
  32969. Reviewed by Martin Robinson.
  32970. * WebKitTestRunner/PixelDumpSupport.cpp:
  32971. 2011-08-19 Adam Roben <aroben@apple.com>
  32972. Pull some of DynamicDeviceScaleFactor's code up into a shareable base class
  32973. This will make it easier to write other WebKit-agnostic tests
  32974. Fixes <http://webkit.org/b/66558> Would like to be able to reuse DynamicDeviceScaleFactor's
  32975. code in other WebKit-agnostic tests
  32976. Reviewed by Anders Carlsson.
  32977. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  32978. * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Fixed copyright. Moved a bunch of
  32979. code to WebKitAgnosticTest.h/mm. Changed to inherit from WebKitAgnosticTest.
  32980. (TestWebKitAPI::DynamicDeviceScaleFactor::url): Simple getter.
  32981. (TestWebKitAPI::DynamicDeviceScaleFactor::didLoadURL): Calls through to runTest.
  32982. (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Removed loading code which
  32983. WebKitAgnosticTest handles for us.
  32984. (TestWebKitAPI::TEST_F): Removed view-creation code which WebKitAgnosticTest handles for us.
  32985. * TestWebKitAPI/mac/WebKitAgnosticTest.h: Added. Code came from DynamicDeviceScaleFactor.
  32986. (TestWebKitAPI::WebKitAgnosticTest::loadAndWaitUntilDone): Code came from
  32987. DynamicDeviceScaleFactor::runTest.
  32988. * TestWebKitAPI/mac/WebKitAgnosticTest.mm: Copied from Tools/TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm.
  32989. (TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test): Code came from
  32990. DynamicDeviceScaleFactor.WebKit.
  32991. (TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test): Code came from
  32992. DynamicDeviceScaleFactor.WebKit2.
  32993. 2011-08-19 Adam Roben <aroben@apple.com>
  32994. Clean up #includes in TestWebKitAPI
  32995. Fixes <http://webkit.org/b/66556> TestWebKitAPI's prefix header isn't very helpful
  32996. Reviewed by Anders Carlsson.
  32997. * TestWebKitAPI/TestWebKitAPIPrefix.h: Added wtf/Platform.h. Added gtest/gtest.h for C++
  32998. files and WebKit/WebKit.h for ObjC files.
  32999. * TestWebKitAPI/InjectedBundleController.cpp:
  33000. * TestWebKitAPI/JavaScriptTest.h:
  33001. * TestWebKitAPI/PlatformUtilities.h:
  33002. * TestWebKitAPI/PlatformWebView.h:
  33003. * TestWebKitAPI/Test.h:
  33004. * TestWebKitAPI/Tests/WTF/StringOperators.cpp:
  33005. * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  33006. * TestWebKitAPI/Tests/WTF/VectorReverse.cpp:
  33007. * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  33008. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  33009. * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  33010. * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp:
  33011. * TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp:
  33012. * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp:
  33013. * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  33014. * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  33015. * TestWebKitAPI/Tests/WebKit2/Find.cpp:
  33016. * TestWebKitAPI/Tests/WebKit2/ForceRepaint.cpp:
  33017. * TestWebKitAPI/Tests/WebKit2/FrameMIMETypeHTML.cpp:
  33018. * TestWebKitAPI/Tests/WebKit2/FrameMIMETypePNG.cpp:
  33019. * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  33020. * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp:
  33021. * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic.cpp:
  33022. * TestWebKitAPI/Tests/WebKit2/InjectedBundleBasic_Bundle.cpp:
  33023. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  33024. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  33025. * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  33026. * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  33027. * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  33028. * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  33029. * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  33030. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  33031. * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  33032. * TestWebKitAPI/Tests/WebKit2/WKStringJSString.cpp:
  33033. * TestWebKitAPI/Tests/WebKit2/win/AltKeyGeneratesWMSysCommand.cpp:
  33034. * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
  33035. * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
  33036. * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
  33037. * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp:
  33038. * TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp:
  33039. * TestWebKitAPI/Tests/WebKit2/win/WMPrint.cpp:
  33040. * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
  33041. * TestWebKitAPI/TestsController.cpp:
  33042. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  33043. Removed now-unnecessary #includes. Moved #includes of Test.h in with the rest of the
  33044. #includes since it is no longer a special header.
  33045. 2011-08-18 Dirk Pranke <dpranke@chromium.org>
  33046. new-run-webkit-tests hung while acquiring http lock on snow leopard bots
  33047. https://bugs.webkit.org/show_bug.cgi?id=64886
  33048. Temporarily disable the http locking to work around the issue.
  33049. I'm not actually sure if this is going to work or improve things
  33050. much.
  33051. Reviewed by Ryosuke Niwa.
  33052. * Scripts/webkitpy/layout_tests/port/mac.py:
  33053. 2011-08-18 Tony Chang <tony@chromium.org>
  33054. add embedded png checksums to WebKitTestRunner
  33055. https://bugs.webkit.org/show_bug.cgi?id=66494
  33056. Looks like WebKitTestRunner has never supported embedded checksums. This copies
  33057. some code from DRT and adds it to the WebKitTestRunner.
  33058. Reviewed by Darin Adler.
  33059. * WebKitTestRunner/CyclicRedundancyCheck.cpp: Copied from Tools/DumpRenderTree
  33060. * WebKitTestRunner/CyclicRedundancyCheck.h: Copied from Tools/DumpRenderTree
  33061. * WebKitTestRunner/GNUmakefile.am: Add new files
  33062. * WebKitTestRunner/PixelDumpSupport.cpp: Copied from Tools/DumpRenderTree
  33063. * WebKitTestRunner/PixelDumpSupport.h: Copied from Tools/DumpRenderTree
  33064. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Add new files
  33065. * WebKitTestRunner/cairo/TestInvocationCairo.cpp:
  33066. (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
  33067. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  33068. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  33069. (WTR::dumpBitmap): Refactor to use PixelDumpSupport.
  33070. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  33071. * WebKitTestRunner/win/WebKitTestRunner.vcproj: Add new files
  33072. 2011-08-18 Shawn Singh <shawnsingh@chromium.org>
  33073. https://bugs.webkit.org/show_bug.cgi?id=47240
  33074. Fixed a cygwin path problem in the chromium port of diff_image;
  33075. Also made the return values of the diff_image function more consistent.
  33076. Reviewed by Dirk Pranke.
  33077. * Scripts/webkitpy/layout_tests/port/chromium.py:
  33078. 2011-08-17 Alejandro G. Castro <alex@igalia.com>
  33079. [GTK] Fix compilation problems with deprecations in gtk+
  33080. https://bugs.webkit.org/show_bug.cgi?id=66073
  33081. Reviewed by Martin Robinson.
  33082. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  33083. (main): G_CONST_RETURN was deprecated
  33084. * GtkLauncher/main.c:
  33085. (createWindow): Added gtk_box_new conditional compilation for
  33086. gtk+-3.
  33087. * MiniBrowser/gtk/BrowserWindow.c:
  33088. (browser_window_init): Replaced gtk_vbox_new with gtk_box_new, we
  33089. are just supporting gtk+-3 for WebKit2.
  33090. 2011-08-18 Anders Carlsson <andersca@apple.com>
  33091. Fix libc++ C++0x build
  33092. https://bugs.webkit.org/show_bug.cgi?id=66479
  33093. Reviewed by Adam Roben.
  33094. Add missing includes.
  33095. * DumpRenderTree/LayoutTestController.cpp:
  33096. * DumpRenderTree/mac/CheckedMalloc.cpp:
  33097. 2011-08-18 Adam Roben <aroben@apple.com>
  33098. Test that WebKit updates style when a WebView is moved between differently-scaled windows
  33099. Test for <http://webkit.org/b/66412> <rdar://problem/9971958> WebKit doesn't react when a
  33100. WebView is moved between windows with different backing scale factors
  33101. Reviewed by Anders Carlsson.
  33102. * TestWebKitAPI/JavaScriptTest.cpp:
  33103. (TestWebKitAPI::runJSTest): Moved a little bit of code from here...
  33104. (TestWebKitAPI::compareJSResult): ...to here. Also made the error message more similar to
  33105. gtest's built-in error messages.
  33106. * TestWebKitAPI/JavaScriptTest.h: Added overloads of runJSTest that take a WebView * and
  33107. WKView * for convenience on Mac. Added compareJSResult helper function for implementing
  33108. those overloads.
  33109. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  33110. * TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm: Added.
  33111. (-[FrameLoadDelegate initWithDidFinishLoadBoolean:]): Simple initializer.
  33112. (-[FrameLoadDelegate webView:didFinishLoadForFrame:]): Record that the load finished.
  33113. (TestWebKitAPI::didFinishLoadForFrame): Record that the load finished.
  33114. (TestWebKitAPI::setPageLoaderClient): Set up the client.
  33115. (TestWebKitAPI::DynamicDeviceScaleFactor::DynamicDeviceScaleFactor): Simple constructor.
  33116. (TestWebKitAPI::DynamicDeviceScaleFactor::createWindow): Creates a
  33117. SyntheticBackingScaleFactorWindow and returns it.
  33118. (TestWebKitAPI::DynamicDeviceScaleFactor::runTest): Loads devicePixelRatio.html and checks
  33119. that WebKit uses the correct scale factor when the WebView is not in a window, is put in a
  33120. window, is moved to a differently-scaled window, and is taken out of the window.
  33121. (TestWebKitAPI::DynamicDeviceScaleFactor::loadURL): Helper function with overloads for
  33122. WebKit1 and WebKit2.
  33123. (TestWebKitAPI::TEST_F): Runs the test, with overloads for WebKit1 and WebKit2.
  33124. * TestWebKitAPI/Tests/mac/devicePixelRatio.html: Added.
  33125. * TestWebKitAPI/mac/JavaScriptTestMac.mm: Added.
  33126. (TestWebKitAPI::runJSTest): Fairly simple overloads for WebView * and WKView *.
  33127. * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.h: Added.
  33128. * TestWebKitAPI/mac/SyntheticBackingScaleFactorWindow.m: Added.
  33129. (-[SyntheticBackingScaleFactorWindow initWithContentRect:styleMask:backing:defer:]): Simple
  33130. initializer.
  33131. (-[SyntheticBackingScaleFactorWindow setBackingScaleFactor:]): Simple setter.
  33132. (-[SyntheticBackingScaleFactorWindow backingScaleFactor]):
  33133. (-[SyntheticBackingScaleFactorWindow userSpaceScaleFactor]):
  33134. Overrides of NSWindow methods that WebKit uses to determine the device scale factor.
  33135. 2011-08-18 Dmitry Lomov <dslomov@google.com>
  33136. https://bugs.webkit.org/show_bug.cgi?id=66425
  33137. check-webkit-style should detect incorrectly formatted file change descriptions.
  33138. Description, if present, should be separated from colon with a space.
  33139. Reviewed by David Levin.
  33140. * Scripts/webkitpy/style/checkers/changelog.py: Fix.
  33141. * Scripts/webkitpy/style/checkers/changelog_unittest.py: Unit tests.
  33142. 2011-08-18 Adam Barth <abarth@webkit.org>
  33143. webkit-patch pretty-diff should be shown in main help
  33144. https://bugs.webkit.org/show_bug.cgi?id=66404
  33145. Reviewed by Dimitri Glazkov.
  33146. As requested by dglazkov.
  33147. * Scripts/webkitpy/tool/commands/prettydiff.py:
  33148. 2011-08-17 Dmitry Lomov <dslomov@google.com>
  33149. https://bugs.webkit.org/show_bug.cgi?id=66400
  33150. Fix TestWebKitAPI build on Mac OS.
  33151. Reviewed by David Levin.
  33152. * TestWebKitAPI/Configurations/Base.xcconfig: Added ICU headers to the HEADER_SEARCH_PATH.
  33153. 2011-08-17 Dimitri Glazkov <dglazkov@chromium.org>
  33154. garden-o-matic spring cleaning: move scripts, styles, and images in the respective directories.
  33155. https://bugs.webkit.org/show_bug.cgi?id=66427
  33156. Reviewed by Adam Barth.
  33157. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Removed.
  33158. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Removed.
  33159. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js: Removed.
  33160. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Removed.
  33161. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js: Removed.
  33162. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Removed.
  33163. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Removed.
  33164. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Removed.
  33165. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js: Removed.
  33166. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js: Removed.
  33167. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js: Removed.
  33168. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js: Removed.
  33169. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js: Removed.
  33170. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Removed.
  33171. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Removed.
  33172. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js: Removed.
  33173. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Removed.
  33174. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Removed.
  33175. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css: Removed.
  33176. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Removed.
  33177. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js: Removed.
  33178. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Removed.
  33179. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Removed.
  33180. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js: Removed.
  33181. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Removed.
  33182. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js: Removed.
  33183. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Removed.
  33184. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed.
  33185. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed.
  33186. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Removed.
  33187. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Removed.
  33188. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Removed.
  33189. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Removed.
  33190. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Removed.
  33191. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Removed.
  33192. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Removed.
  33193. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Removed.
  33194. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Removed.
  33195. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Removed.
  33196. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Removed.
  33197. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  33198. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images: Added.
  33199. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-green.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png.
  33200. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/images/favicon-red.png: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png.
  33201. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  33202. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Removed.
  33203. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Removed.
  33204. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Removed.
  33205. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Removed.
  33206. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Removed.
  33207. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Removed.
  33208. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html:
  33209. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Removed.
  33210. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Removed.
  33211. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  33212. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js.
  33213. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js.
  33214. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Buildbot_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js.
  33215. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js.
  33216. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Builder_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js.
  33217. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js.
  33218. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FailingTestsBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js.
  33219. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js.
  33220. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyLayoutTestDetector_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js.
  33221. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js.
  33222. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/FlakyTestBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js.
  33223. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestHistoryAnalyzer.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js.
  33224. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/LayoutTestResultsLoader.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js.
  33225. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NRWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js.
  33226. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js.
  33227. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/NewBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js.
  33228. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ORWTResultsParser.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js.
  33229. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/PersistentCache.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js.
  33230. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js.
  33231. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/TestRelatedBugForm_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js.
  33232. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Trac.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js.
  33233. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js.
  33234. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Utilities_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js.
  33235. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js.
  33236. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBugzilla.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js.
  33237. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js.
  33238. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js.
  33239. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js.
  33240. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/bugzilla_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js.
  33241. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js.
  33242. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js.
  33243. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js.
  33244. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js.
  33245. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js.
  33246. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.
  33247. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js.
  33248. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/main.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js.
  33249. ():
  33250. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js.
  33251. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js.
  33252. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js.
  33253. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js.
  33254. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js.
  33255. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js.
  33256. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/trac_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js.
  33257. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js.
  33258. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js.
  33259. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js.
  33260. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js.
  33261. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/unexpected-passes.js: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js.
  33262. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/TestFailures.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css.
  33263. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/main.css: Copied from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css.
  33264. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html:
  33265. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Removed.
  33266. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Removed.
  33267. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Removed.
  33268. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Removed.
  33269. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Removed.
  33270. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html:
  33271. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Removed.
  33272. 2011-08-17 Jochen Eisinger <jochen@chromium.org>
  33273. Make SVNTest.test_svn_apply use the same timezone logic as VCSUtils.pm
  33274. https://bugs.webkit.org/show_bug.cgi?id=65877
  33275. Reviewed by Eric Seidel.
  33276. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  33277. 2011-08-17 Dimitri Glazkov <dglazkov@chromium.org>
  33278. Remove base.keys and replace it with Object.keys.
  33279. https://bugs.webkit.org/show_bug.cgi?id=66422
  33280. Reviewed by Adam Barth.
  33281. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Removed base.keys.
  33282. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Removed unit tests for it.
  33283. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Replaced with Object.keys
  33284. 2011-08-17 Dimitri Glazkov <dglazkov@chromium.org>
  33285. garden-o-matic Summary view should have items in descending chronological order.
  33286. https://bugs.webkit.org/show_bug.cgi?id=66403
  33287. Reviewed by Adam Barth.
  33288. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Renamed "push" to "add" for clarity, cleaned up some stuff.
  33289. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Rewrote add to insert DOM elements in order.
  33290. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added unit tests.
  33291. 2011-08-17 Dimitri Glazkov <dglazkov@chromium.org>
  33292. Fix a few errors in garden-o-matic frontend unit tests.
  33293. https://bugs.webkit.org/show_bug.cgi?id=66421
  33294. Reviewed by Adam Barth.
  33295. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Changed my excellent test to view time as variable continuum.
  33296. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Tweaked the test to accommodate new builder names.
  33297. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Hurriedly covered up my prior sins.
  33298. 2011-08-17 Adam Barth <abarth@webkit.org>
  33299. Update Tools to account for (CG) being added to Chromium builder names
  33300. https://bugs.webkit.org/show_bug.cgi?id=66410
  33301. Reviewed by Adam Barth.
  33302. Some of these names will change back once we turn on Skia bots.
  33303. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js:
  33304. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  33305. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  33306. * Scripts/webkitpy/layout_tests/port/builders.py:
  33307. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  33308. * TestResultServer/static-dashboards/builders.js:
  33309. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  33310. 2011-08-16 Dimitri Glazkov <dglazkov@chromium.org>
  33311. Wire up relative time to garden-o-matic summary view.
  33312. https://bugs.webkit.org/show_bug.cgi?id=66343
  33313. Reviewed by Adam Barth.
  33314. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Add time to the commitData object.
  33315. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Adjusted unit tests.
  33316. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up relative date.
  33317. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Updated unit tests.
  33318. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Adjusted unit tests.
  33319. 2011-08-17 Adam Roben <aroben@apple.com>
  33320. Make run-api-tests run tests in alphabetical order
  33321. Fixes <http://webkit.org/b/66401> run-api-tests runs tests in a semi-random order
  33322. Reviewed by David Kilzer.
  33323. * Scripts/run-api-tests:
  33324. (runAllTests):
  33325. (runAllTestsInSuite):
  33326. Sort the lists of tests and suites before iterating over them.
  33327. 2011-08-17 Adam Barth <abarth@webkit.org>
  33328. garden-o-matic should be able to rebaseline expected failures
  33329. https://bugs.webkit.org/show_bug.cgi?id=66204
  33330. Reviewed by Dimitri Glazkov.
  33331. This patch introduces a new view for displaying expect, actual, and
  33332. differences between results. The new view also has a fledgling
  33333. controller that handles some basic operations. The new view is
  33334. exercised by rebaseline.html, which lets you rebaselines expected
  33335. failures, but the new view is not fully integrated into
  33336. garden-o-matic.html
  33337. More patches will be required to make this stuff fully working, but
  33338. this patch was already somewhat spiraling out of control. Hopefully
  33339. this patch will serve as a good starting point for further development.
  33340. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers: Added.
  33341. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers.js: Added.
  33342. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/controllers/rebaseline.js: Added.
  33343. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  33344. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  33345. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  33346. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/rebaseline.html: Added.
  33347. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  33348. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  33349. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  33350. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js:
  33351. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results_unittests.js: Added.
  33352. 2011-08-16 Chang Shu <cshu@webkit.org>
  33353. Support reset in WebCore::Internals
  33354. https://bugs.webkit.org/show_bug.cgi?id=66307
  33355. Reviewed by Dimitri Glazkov.
  33356. Added call to resetInternalsObject in DRT.
  33357. * DumpRenderTree/chromium/TestShell.cpp:
  33358. (TestShell::resetTestController):
  33359. * DumpRenderTree/mac/DumpRenderTree.mm:
  33360. (resetWebViewToConsistentStateBeforeTesting):
  33361. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  33362. (WebCore::WebPage::resetSettings):
  33363. 2011-08-17 Alexis Menard <alexis.menard@openbossa.org>
  33364. Add a new build slave for the Qt port on Mac OS SnowLeopard.
  33365. https://bugs.webkit.org/show_bug.cgi?id=66392
  33366. Modify the config file to include the new build slave.
  33367. Reviewed by Adam Roben.
  33368. * BuildSlaveSupport/build.webkit.org-config/config.json:
  33369. 2011-08-17 Sam White <samuel.white@rochester.edu>
  33370. AccessibilityObject levels are inconsistent
  33371. https://bugs.webkit.org/show_bug.cgi?id=66180
  33372. Added the ability to get numeric attribute values using numberAttributeValue. This
  33373. function complements the existing stringAttributeValue and boolAttributeValue functions.
  33374. The addition of numberAttributeValue was necessary because the stringAttributeValue
  33375. function does a type check and will only return strings. This limitation made it
  33376. impossible to get values for attributes that returned an NSNumber.
  33377. Reviewed by Chris Fleizach.
  33378. * DumpRenderTree/AccessibilityUIElement.cpp:
  33379. (numberAttributeValueCallback):
  33380. (AccessibilityUIElement::getJSClass):
  33381. * DumpRenderTree/AccessibilityUIElement.h:
  33382. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  33383. (AccessibilityUIElement::numberAttributeValue):
  33384. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  33385. (AccessibilityUIElement::numberAttributeValue):
  33386. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  33387. (AccessibilityUIElement::numberAttributeValue):
  33388. 2011-08-17 Adam Roben <aroben@apple.com>
  33389. Tell Trac logs always to display all specified revisions in a single page
  33390. Trac imposes a default limit of 100 revisions per log page. We need to tell it to allow more
  33391. revisions than that.
  33392. Fixes <http://webkit.org/b/66373> Links to Trac from TestFailures page don't always show all
  33393. relevant revisions
  33394. Reviewed by Daniel Bates.
  33395. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  33396. (trac.logURL): Add a limit parameter to the log URL that allows all revisions to be seen in
  33397. a single page.
  33398. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  33399. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js:
  33400. Updated tests for the above.
  33401. 2011-08-17 Adam Roben <aroben@apple.com>
  33402. Fix TestFailures's link to file a bug about TestFailures itself
  33403. Fixes <http://webkit.org/b/66387> REGRESSION (r92135): TestFailures page's link to file a
  33404. bug about itself is broken
  33405. Reviewed by Dan Bates.
  33406. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  33407. (ViewController.prototype._domForAuxiliaryUIElements): Added a path separator to separate
  33408. the host from the path.
  33409. 2011-08-17 Adam Roben <aroben@apple.com>
  33410. Teach TestFailures to ignore unbelievably short test runs
  33411. Fixes <http://webkit.org/b/66385> TestFailures page thinks all tests passed in
  33412. http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14956
  33413. Reviewed by Dan Bates.
  33414. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  33415. (Builder.prototype.getNumberOfFailingTests): If it looks like all tests passed, but
  33416. run-webkit-tests took less than 10 seconds to run, assume that some weird error occurred
  33417. that caused it not to run any tests at all (as happened for a while due to
  33418. <http://webkit.org/b/64988>). Bumped the cache version to evict old, buggy cached data.
  33419. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  33420. Test for the above.
  33421. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  33422. (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy cached data.
  33423. 2011-08-16 Adam Barth <abarth@webkit.org>
  33424. Add a CG qualifier similar to the GPU qualifier
  33425. https://bugs.webkit.org/show_bug.cgi?id=66359
  33426. Reviewed by Eric Seidel.
  33427. Once we have a Skia configuration on Chromium Mac, we'll use this CG
  33428. qualifier to note that expectations apply only to the CG configuration.
  33429. * Scripts/webkitpy/layout_tests/port/chromium.py:
  33430. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  33431. 2011-08-16 Eric Seidel <eric@webkit.org>
  33432. REGRESSION(92717): WinPort needs to parse version information from port_name
  33433. https://bugs.webkit.org/show_bug.cgi?id=66325
  33434. Unreviewed. Fixing an exception/typo seen on the bots (and testing to make sure it works).
  33435. * Scripts/webkitpy/layout_tests/port/mac.py:
  33436. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  33437. 2011-08-16 Adam Barth <abarth@webkit.org>
  33438. Change webkit-patch analyze-baselines to print in a more unix-friendly way
  33439. https://bugs.webkit.org/show_bug.cgi?id=66349
  33440. Reviewed by James Robinson.
  33441. As requested by jamesr.
  33442. * Scripts/webkitpy/tool/commands/rebaseline.py:
  33443. 2011-08-16 Eric Seidel <eric@webkit.org>
  33444. REGRESSION(92717): WinPort needs to parse version information from port_name
  33445. https://bugs.webkit.org/show_bug.cgi?id=66325
  33446. Reviewed by Adam Barth.
  33447. WinPort didn't have any port_name parsing logic.
  33448. Seemed it was best to just share the logic from MacPort.
  33449. Sharing the logic from MacPort seemed easiest with a shared superclass.
  33450. Once I created ApplePort (the superclass) there was a bunch of logic to share.
  33451. I found LeakDetector was just in the way when switching back and forth
  33452. between win.py and mac.py so I moved it into its own file.
  33453. The only logic change here is that WinPort should now be
  33454. able to parse port_name values like MacPort (and other ports)
  33455. can. The fact that ports do this in their constructors is
  33456. wrong and a source of many bugs. But at least now WinPort
  33457. matches the status-quo.
  33458. * Scripts/webkitpy/layout_tests/port/apple.py: Added.
  33459. * Scripts/webkitpy/layout_tests/port/leakdetector.py: Added.
  33460. * Scripts/webkitpy/layout_tests/port/leakdetector_unittest.py: Added.
  33461. * Scripts/webkitpy/layout_tests/port/mac.py:
  33462. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  33463. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  33464. * Scripts/webkitpy/layout_tests/port/win.py:
  33465. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  33466. 2011-08-16 Adam Barth <abarth@webkit.org>
  33467. Add webkit-patch analyze-baselines, as requested by jamesr.
  33468. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  33469. * Scripts/webkitpy/tool/commands/rebaseline.py:
  33470. 2011-08-16 Adam Barth <abarth@webkit.org>
  33471. Fold bulk-optimize-baselines into optimize-baselines
  33472. https://bugs.webkit.org/show_bug.cgi?id=66345
  33473. Reviewed by James Robinson.
  33474. bulk-optimize-baselines is now a superset of optimize-baselines, so
  33475. they can be combined.
  33476. * Scripts/webkitpy/tool/commands/rebaseline.py:
  33477. 2011-08-16 Adam Barth <abarth@webkit.org>
  33478. Move chromium-mac to chromium-cg-mac to prepare for Skia switchover
  33479. https://bugs.webkit.org/show_bug.cgi?id=66334
  33480. Reviewed by Tony Chang.
  33481. This patch moves us closer to switching the Chromium port from
  33482. CoreGraphics to Skia. This patch teaches our tools that the current
  33483. Chromium Mac configuration is actually chromium-cg-mac, which makes
  33484. room for a future chromium-mac configuration that uses Skia.
  33485. Shortly after this patch lands, I'll do a server-side move of the
  33486. chromium-mac and chromium-mac-leopard directories to chromium-cg-mac
  33487. and chromium-cg-mac-leopard.
  33488. * BuildSlaveSupport/build.webkit.org-config/config.json:
  33489. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  33490. * Scripts/webkitpy/common/config/build.py:
  33491. * Scripts/webkitpy/common/config/build_unittest.py:
  33492. * Scripts/webkitpy/layout_tests/port/base.py:
  33493. * Scripts/webkitpy/layout_tests/port/builders.py:
  33494. * Scripts/webkitpy/layout_tests/port/chromium.py:
  33495. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  33496. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  33497. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  33498. * Scripts/webkitpy/layout_tests/port/factory.py:
  33499. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  33500. * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
  33501. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  33502. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  33503. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  33504. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  33505. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  33506. 2011-08-16 Dimitri Glazkov <dglazkov@chromium.org>
  33507. garden-o-matic frontend needs a friendly relative time description method.
  33508. https://bugs.webkit.org/show_bug.cgi?id=66324
  33509. Reviewed by Adam Barth.
  33510. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.relativizeTime method.
  33511. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added unit tests.
  33512. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Wired up Time widget to use it.
  33513. 2011-08-16 Dimitri Glazkov <dglazkov@chromium.org>
  33514. Summary view should not add multiple entries for the same test failure.
  33515. https://bugs.webkit.org/show_bug.cgi?id=66318
  33516. Reviewed by Adam Barth.
  33517. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added a simplistic updating button.
  33518. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added ways to check for
  33519. equality of ui.notifications.FailingTest, and whether ui.notifications.TestFailures already contains a given failure analysis.
  33520. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added tests.
  33521. 2011-08-16 Adam Roben <aroben@apple.com>
  33522. Teach TestFailures that tests that have failed or passed many times in a row are not flaky
  33523. The basic strategy here is that once a test has failed or passed many times in a row we
  33524. never again consider it as a possibly flaky test. It's a simple strategy but seems to result
  33525. in many fewer false positives than our current behavior.
  33526. Fixes <http://webkit.org/b/66327> TestFailures page considers far too many tests to be
  33527. flaky, including tests that failed for a while but then were fixed
  33528. Reviewed by Dan Bates.
  33529. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
  33530. (FlakyLayoutTestDetector): Initialize new _buildCount property, which is used to track the
  33531. number of non-too-many-failure builds we've seen.
  33532. (FlakyLayoutTestDetector.prototype.incorporateTestResults): Don't track tests which haven't
  33533. failed in the _maximumFailOrPassCount most recent builds. For other not-yet-considered-flaky
  33534. tests, keep track of how many times they have passed or failed in a row. If they pass or
  33535. fail more than _maximumFailOrPassCount times, consider them to be non-flaky. (Once a test is
  33536. considered flaky it doesn't matter how many times it passes or fails.)
  33537. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
  33538. Added tests for the above.
  33539. 2011-08-16 Dimitri Glazkov <dglazkov@chromium.org>
  33540. garden-o-matic needs a summary view with actions for each problem.
  33541. https://bugs.webkit.org/show_bug.cgi?id=66144
  33542. Reviewed by Adam Barth.
  33543. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html: Added notifications tests.
  33544. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary.js: Added.
  33545. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js: Added.
  33546. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js: Added.
  33547. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/summary.css: Added.
  33548. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/summary.html: Added.
  33549. 2011-08-16 Dean Jackson <dino@apple.com>
  33550. Adding Ted "hober" O'Connor as a non-committing contributor.
  33551. * Scripts/webkitpy/common/config/committers.py:
  33552. 2011-08-16 Adam Roben <aroben@apple.com>
  33553. Teach TestFailures how to interpret unfinished test runs
  33554. Fixes <http://webkit.org/b/66309> TestFailures thinks all tests passed in
  33555. http://build.webkit.org/builders/Lion%20Intel%20Debug%20(Tests)/builds/136
  33556. Reviewed by David Kilzer.
  33557. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  33558. (Builder.prototype.getNumberOfFailingTests): Look for "isFinished" in the layout-test step
  33559. rather than "isStarted" so that we don't count builds for which the test run never finished.
  33560. Bumped the cache version to evict old, buggy cached data.
  33561. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  33562. Added a test for the above, and made a somewhat synthetic test more realistic by including
  33563. more of the actual JSON data from build.webkit.org.
  33564. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  33565. (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
  33566. cached data.
  33567. 2011-08-16 Adam Roben <aroben@apple.com>
  33568. Make Apple's Windows port fall back to Lion results instead of SnowLeopard
  33569. Apple's Windows port now uses Lion-era versions of CoreFoundation, ICU, etc., so in theory
  33570. should match Lion's behavior.
  33571. Fixes <http://webkit.org/b/66302> Apple's Windows port matches Lion for some test results,
  33572. but doesn't use Lion results
  33573. Reviewed by David Kilzer.
  33574. * Scripts/old-run-webkit-tests:
  33575. (expectedDirectoryForTest):
  33576. * Scripts/webkitpy/layout_tests/port/win.py:
  33577. (WinPort.baseline_search_path):
  33578. * Scripts/webkitpy/layout_tests/port/win_unittest.py:
  33579. (WinPortTest.test_baseline_search_path):
  33580. Replaced mac-snowleopard with mac-lion.
  33581. * Scripts/webkitpy/common/config/build.py:
  33582. (_should_file_trigger_build): Added an entry for the LayoutTests/platform/mac-lion
  33583. directory, which all Apple Mac platforms and Apple Win platforms could potentially use
  33584. results from. Removed Apple Win from being affected by mac-snowleopard changes, since it
  33585. will no longer look there for results.
  33586. * Scripts/webkitpy/common/config/build_unittest.py:
  33587. (ShouldBuildTest.test_should_build): Tests for the above changes.
  33588. 2011-08-16 Dean Jackson <dino@apple.com>
  33589. Move me from contributor to reviewer.
  33590. * Scripts/webkitpy/common/config/committers.py:
  33591. 2011-08-15 Dimitri Glazkov <dglazkov@chromium.org>
  33592. garden-o-matic frontend needs model.commitDataForRevisionRange function.
  33593. https://bugs.webkit.org/show_bug.cgi?id=66252
  33594. Reviewed by Adam Barth.
  33595. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added commitDataForRevisionRange method.
  33596. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added tests.
  33597. 2011-08-15 Dimitri Glazkov <dglazkov@chromium.org>
  33598. garden-o-matic frontend needs a generic way to track updates.
  33599. https://bugs.webkit.org/show_bug.cgi?id=66245
  33600. Reviewed by Adam Barth.
  33601. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added UpdateTracker.
  33602. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
  33603. 2011-08-15 Adam Roben <aroben@apple.com>
  33604. Teach TestWebKitAPI/gtest how to print JavaScript failures nicely
  33605. Failures now give output of the form: foo should be bar but is baz
  33606. Fixes <http://webkit.org/b/66240> It's hard to tell what the actual result of a failed JS
  33607. test is in TestWebKitAPI's output
  33608. Reviewed by David Levin.
  33609. * TestWebKitAPI/JavaScriptTest.cpp:
  33610. (TestWebKitAPI::JavaScriptCallbackContext::JavaScriptCallbackContext): Removed now-unused
  33611. members.
  33612. (TestWebKitAPI::javaScriptCallback): Changed to just store the result string in the context
  33613. object, rather than doing any testing of it here.
  33614. (TestWebKitAPI::runJSTest): Made this function a gtest predicate-formatter. This allows us
  33615. to use a pretty error message when the test fails.
  33616. * TestWebKitAPI/JavaScriptTest.h: Changed runJSTest to a predicate-formatter, and added nice
  33617. gtest-style macros that wrap it.
  33618. * TestWebKitAPI/Test.h: Removed now-unused TEST_ASSERT_RETURN.
  33619. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp:
  33620. (TestWebKitAPI::TEST): Changed to use the new macros.
  33621. * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  33622. (TestWebKitAPI::createSessionStateContainingFormData): Ditto. Note that this function no
  33623. longer returns 0 when the JS test fails. That shouldn't have any effect on whether or not
  33624. the test passes, though. Returning early seems to have been an unnecessary optimization.
  33625. * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  33626. (TestWebKitAPI::TEST): Changed to use the new macros.
  33627. 2011-08-15 Eric Seidel <eric@webkit.org>
  33628. Move the Leaks bot back to ORWT until I can fix LeaksViewer regressions filed by Adam Roben in bug 66227 and 66228.
  33629. Unreviewed.
  33630. * Scripts/run-webkit-tests:
  33631. (usingLeaks):
  33632. (useNewRunWebKitTests):
  33633. 2011-08-14 Adam Barth <abarth@webkit.org>
  33634. Switch results detail view over to new-style object-oriented UI widgets
  33635. https://bugs.webkit.org/show_bug.cgi?id=66200
  33636. Reviewed by Dimitri Glazkov.
  33637. This patch replaces my goofy template-based UI for the results
  33638. comparison screen with new object-oriented UI widgets.
  33639. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  33640. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  33641. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  33642. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  33643. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  33644. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui/results.js: Added.
  33645. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  33646. 2011-08-13 Dimitri Glazkov <dglazkov@chromium.org>
  33647. garden-o-matic's analyzeUnexpectedFailures needs a completion callback.
  33648. https://bugs.webkit.org/show_bug.cgi?id=66166
  33649. Also changed base.RequestTracker to:
  33650. a) fire callback immediately if requestsInFlight is 0;
  33651. b) not barf if callback is not supplied.
  33652. Reviewed by Adam Barth.
  33653. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Started using completion callback.
  33654. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js: Added completion callback.
  33655. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Changed RequestTracker.
  33656. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittest.js: Added unit tests.
  33657. 2011-08-12 Mark Rowe <mrowe@apple.com>
  33658. Be more forward-looking in the choice of compiler.
  33659. Rubber-stamped by Jon Honeycutt.
  33660. * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  33661. * MiniBrowser/Configurations/CompilerVersion.xcconfig:
  33662. * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  33663. * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
  33664. 2011-08-12 Sadrul Habib Chowdhury <sadrul@chromium.org>
  33665. DRT: Add support for gesture events.
  33666. https://bugs.webkit.org/show_bug.cgi?id=66105
  33667. Reviewed by Darin Fisher.
  33668. * DumpRenderTree/chromium/EventSender.cpp:
  33669. (EventSender::EventSender):
  33670. (EventSender::gestureScrollBegin):
  33671. (EventSender::gestureScrollEnd):
  33672. (EventSender::gestureTap):
  33673. (EventSender::gestureEvent):
  33674. * DumpRenderTree/chromium/EventSender.h:
  33675. 2011-08-12 Andy Estes <aestes@apple.com>
  33676. allowRoundingHacksCallback uses the wrong argument for 'thisObject'.
  33677. https://bugs.webkit.org/show_bug.cgi?id=66158
  33678. Reviewed by Dan Bernstein.
  33679. * DumpRenderTree/LayoutTestController.cpp:
  33680. (allowRoundingHacksCallback): The third argument is the 'this'
  33681. JSObjectRef, not the second.
  33682. 2011-08-12 Andy Estes <aestes@apple.com>
  33683. Cancel in onbeforeunload dialog sometime causes a button to stop working.
  33684. https://bugs.webkit.org/show_bug.cgi?id=26211
  33685. Reviewed by Alexey Proskuryakov.
  33686. Implement a new LayoutTestController method that a test can call to set
  33687. the return value of DumpRenderTree's beforeunload UI delegate.
  33688. * DumpRenderTree/LayoutTestController.cpp:
  33689. (LayoutTestController::LayoutTestController): Initialize
  33690. m_shouldStayOnPageAfterHandlingBeforeUnload.
  33691. (setShouldStayOnPageAfterHandlingBeforeUnloadCallback): Call
  33692. LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload().
  33693. (LayoutTestController::staticFunctions): Register
  33694. 'setShouldStayOnPageAfterHandlingBeforeUnload' as a static function.
  33695. * DumpRenderTree/LayoutTestController.h:
  33696. (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
  33697. (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
  33698. * DumpRenderTree/chromium/LayoutTestController.cpp:
  33699. (LayoutTestController::LayoutTestController): Initialize
  33700. m_shouldStayOnPageAfterHandlingBeforeUnload and bind
  33701. 'setShouldStayOnPageAfterHandlingBeforeUnload' to its c++ setter.
  33702. (LayoutTestController::reset): Reset
  33703. m_shouldStayOnPageAfterHandlingBeforeUnload to false.
  33704. (LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
  33705. Set m_shouldStayOnPageAfterHandlingBeforeUnload to the value passed in
  33706. from JavaScript.
  33707. * DumpRenderTree/chromium/LayoutTestController.h:
  33708. (LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload):
  33709. * DumpRenderTree/chromium/WebViewHost.cpp:
  33710. (WebViewHost::runModalBeforeUnloadDialog): Add the correct logging and
  33711. return the inverse of
  33712. LayoutTestController::shouldStayOnPageAfterHandlingBeforeUnload().
  33713. * DumpRenderTree/mac/UIDelegate.mm:
  33714. (-[UIDelegate webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:]): Ditto.
  33715. * DumpRenderTree/win/UIDelegate.cpp:
  33716. (UIDelegate::runBeforeUnloadConfirmPanelWithMessage): Ditto.
  33717. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  33718. Define setShouldStayOnPageAfterHandlingBeforeUnload().
  33719. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  33720. (WTR::InjectedBundle::postNewBeforeUnloadReturnValue): Post a message
  33721. to the Test Controller telling it what value it should return in its
  33722. onbeforeunload UI delegate.
  33723. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  33724. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  33725. (WTR::LayoutTestController::setShouldStayOnPageAfterHandlingBeforeUnload):
  33726. Call InjectedBundle::postNewBeforeUnloadReturnValue().
  33727. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  33728. * WebKitTestRunner/TestController.cpp:
  33729. (WTR::TestController::TestController): Initialize
  33730. m_beforeUnloadReturnValue to true.
  33731. (WTR::runBeforeUnloadConfirmPanel): Add the correct logging and return
  33732. the value of TestController::beforeUnloadReturnValue().
  33733. (WTR::TestController::resetStateToConsistentValues): Reset
  33734. m_beforeUnloadReturnValue to true.
  33735. * WebKitTestRunner/TestController.h:
  33736. (WTR::TestController::beforeUnloadReturnValue):
  33737. (WTR::TestController::setBeforeUnloadReturnValue):
  33738. * WebKitTestRunner/TestInvocation.cpp:
  33739. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle): Handle the
  33740. message posted from the injected bundle by retrieving the message body
  33741. as a WKBoolean and calling TestController::setBeforeUnloadReturnValue().
  33742. 2011-08-12 Sam Weinig <sam@webkit.org>
  33743. Move compiler specific macros to their own header
  33744. https://bugs.webkit.org/show_bug.cgi?id=66119
  33745. Reviewed by Anders Carlsson.
  33746. * DumpRenderTree/ForwardingHeaders/wtf/Compiler.h: Added.
  33747. 2011-08-11 Dimitri Glazkov <dglazkov@chromium.org>
  33748. Add a way to extend DOM objects in garden-o-matic.
  33749. https://bugs.webkit.org/show_bug.cgi?id=66096
  33750. Reviewed by Adam Barth.
  33751. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Added base.extends.
  33752. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Added tests.
  33753. 2011-08-11 MORITA Hajime <morrita@google.com>
  33754. [Chromium][DRT] editing/spelling/spelling-backspace-between-lines.html fails
  33755. https://bugs.webkit.org/show_bug.cgi?id=45438
  33756. Reviewed by Kent Tamura.
  33757. MockSpellCheck was assuming the input of spellCheckWord() is a word.
  33758. But it can be a series of word. This change made spellCheckWord()
  33759. understand simple word boundary which appears in tests.
  33760. * DumpRenderTree/chromium/MockSpellCheck.cpp:
  33761. (MockSpellCheck::spellCheckWord):
  33762. 2011-08-11 Mark Rowe <mrowe@apple.com>
  33763. Rework some Makefile logic to remove a double-negative.
  33764. Reviewed by Jon Honeycutt.
  33765. * DumpRenderTree/mac/PerlSupport/Makefile:
  33766. 2011-08-11 Anders Carlsson <andersca@apple.com>
  33767. Add a FIXME.
  33768. * TestWebKitAPI/TestsController.cpp:
  33769. (TestWebKitAPI::TestsController::TestsController):
  33770. 2011-08-11 Anders Carlsson <andersca@apple.com>
  33771. Initialize threading before running any tests
  33772. https://bugs.webkit.org/show_bug.cgi?id=66112
  33773. Reviewed by Adam Barth.
  33774. * TestWebKitAPI/TestsController.cpp:
  33775. (TestWebKitAPI::TestsController::TestsController):
  33776. 2011-08-11 Adam Barth <abarth@webkit.org>
  33777. Add unexpected-passes.html to TestFailures for marking tests as passing
  33778. https://bugs.webkit.org/show_bug.cgi?id=66102
  33779. Reviewed by Dimitri Glazkov.
  33780. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  33781. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  33782. - Move some code into the library so it can be shared.
  33783. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  33784. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  33785. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  33786. - Add round-trip unit tests.
  33787. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.html: Added.
  33788. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/unexpected-passes.js: Added.
  33789. - I'm not entirely sure this feature should remain a separate HTML
  33790. file, but it seemed better than cluttering up the main HTML file
  33791. with too much extra stuff.
  33792. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  33793. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  33794. - The gardening server couldn't handle adding PASS expectations. Now it can.
  33795. 2011-08-11 Eric Seidel <eric@webkit.org>
  33796. NRWT has wrong fallback order for Mac now that Lion exists
  33797. https://bugs.webkit.org/show_bug.cgi?id=66093
  33798. Reviewed by Adam Barth.
  33799. ORWT used a different system for fallback orders than NRWT did.
  33800. I moved win.py to match ORWT fallback orders in bug 64486.
  33801. This bug moves mac.py to match ORWT fallback order
  33802. and adds 'lion' as a supported OS version.
  33803. Because ChromiumMac shares OS version detection code with AppleMac
  33804. this also added support for 'lion' to chromium mac. Hopefully that's a good thing.
  33805. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  33806. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  33807. * Scripts/webkitpy/layout_tests/port/mac.py:
  33808. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  33809. * Scripts/webkitpy/layout_tests/port/win.py:
  33810. 2011-08-11 Adam Barth <abarth@webkit.org>
  33811. Update test results now that we use absolute URLs.
  33812. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
  33813. 2011-08-11 Adam Barth <abarth@webkit.org>
  33814. garden-o-matic should be able to determine when tests unexpectedly pass
  33815. https://bugs.webkit.org/show_bug.cgi?id=66092
  33816. Reviewed by Dimitri Glazkov.
  33817. This patch just contains the library methods for extracting this
  33818. information. I'll add some UI in a subsequent patch.
  33819. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  33820. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  33821. 2011-08-11 Dimitri Glazkov <dglazkov@chromium.org>
  33822. New expectation entries should be placed next to existing ones.
  33823. https://bugs.webkit.org/show_bug.cgi?id=66066
  33824. Reviewed by Adam Barth.
  33825. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added the notion of insertion point,
  33826. which is computed as the last found reference to the same test.
  33827. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added and adjusted unit tests.
  33828. 2011-08-11 Dimitri Glazkov <dglazkov@chromium.org>
  33829. Unreviewed, rolling out r92847.
  33830. http://trac.webkit.org/changeset/92847
  33831. https://bugs.webkit.org/show_bug.cgi?id=65986
  33832. Broke check-webkit-style
  33833. * Scripts/webkitpy/style/checker.py:
  33834. * Scripts/webkitpy/style/checker_unittest.py:
  33835. 2011-08-11 Dimitri Glazkov <dglazkov@chromium.org>
  33836. Unreviewed, rolling out r92847.
  33837. http://trac.webkit.org/changeset/92847
  33838. https://bugs.webkit.org/show_bug.cgi?id=65986
  33839. Broke check-webkit-style
  33840. * Scripts/webkitpy/style/checker.py:
  33841. * Scripts/webkitpy/style/checker_unittest.py:
  33842. 2011-08-11 Pierre Rossi <pierre.rossi@gmail.com>
  33843. [Qt] autotests shouldn't require config.h in the style check
  33844. https://bugs.webkit.org/show_bug.cgi?id=65986
  33845. Remove the include rules from the style-check for Qt tests.
  33846. Since for the most part it's just a matter of using the
  33847. API provided by QtWebKit, enforcing the WebCore set of rules
  33848. only seems to make sense in the case of MIMESniffing.
  33849. Reviewed by Benjamin Poulain.
  33850. * Scripts/webkitpy/style/checker.py:
  33851. * Scripts/webkitpy/style/checker_unittest.py:
  33852. 2011-08-11 Zsolt Fehér <h490267@stud.u-szeged.hu>
  33853. [WK2] Implement waitForPolicyDelegate
  33854. https://bugs.webkit.org/show_bug.cgi?id=42330
  33855. Reviewed by Csaba Osztrogonác.
  33856. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  33857. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  33858. (WTR::navigationTypeToString):
  33859. (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
  33860. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  33861. (WTR::LayoutTestController::LayoutTestController):
  33862. (WTR::LayoutTestController::setCustomPolicyDelegate):
  33863. (WTR::LayoutTestController::waitForPolicyDelegate):
  33864. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  33865. (WTR::LayoutTestController::isPolicyDelegateEnabled):
  33866. (WTR::LayoutTestController::isPolicyDelegatePermissive):
  33867. 2011-08-11 Adam Barth <abarth@webkit.org>
  33868. rebaseline-expectations should use the release bots, not the debug
  33869. bots. The debug bots don't all run all the tests. Also, delay
  33870. updating test_expectations a long as possible to avoid clearing out
  33871. lines that we'll need for other ports.
  33872. * Scripts/webkitpy/layout_tests/port/builders.py:
  33873. * Scripts/webkitpy/tool/commands/rebaseline.py:
  33874. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  33875. 2011-08-10 Ryosuke Niwa <rniwa@webkit.org>
  33876. r92792 inadvertently removed PlatformSpecificScheduler for all Snow Leopard bots.
  33877. Revert it partially so that the remaining Snow Leopard bots can fulfill their duty.
  33878. * BuildSlaveSupport/build.webkit.org-config/config.json:
  33879. 2011-08-10 Eric Seidel <eric@webkit.org>
  33880. new-run-webkit-test's WinPort has no fallback logic
  33881. https://bugs.webkit.org/show_bug.cgi?id=64486
  33882. Unreviewed.
  33883. Turns out that we've long had a subtle bug whereby if you didn't
  33884. already have DumpRenderTree built, we might end up running unsupported tests
  33885. because the DumpRenderTree --print-supported-features check would silently fail.
  33886. When I moved the call from using popen to using Executive.run_command, this silent
  33887. failure became noisy. (Breaking some bots.)
  33888. This re-orders our steps so that we always build DRT before collecting expectations,
  33889. as well as adds a warning message when DumpRenderTree can't be found.
  33890. * Scripts/webkitpy/layout_tests/port/webkit.py:
  33891. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  33892. 2011-08-10 Eric Seidel <eric@webkit.org>
  33893. new-run-webkit-test's WinPort has no fallback logic
  33894. https://bugs.webkit.org/show_bug.cgi?id=64486
  33895. Unreviewed. Fix test-webkitpy under Python 2.5.
  33896. * Scripts/webkitpy/layout_tests/port/win.py:
  33897. 2011-08-10 Benjamin Poulain <benjamin@webkit.org>
  33898. [Qt][WK2] MiniBrowser is firing twice the QDesktopWebView::mousePressEvent method
  33899. https://bugs.webkit.org/show_bug.cgi?id=65875
  33900. Reviewed by Kenneth Rohde Christiansen.
  33901. For some reason, QWidget send fake mouse event on some platform, under certains conditions.
  33902. This causes mouse events to be sent twice in some cases. We work around the problem
  33903. by defining the first touch point to be a primary touch point (case which hit some
  33904. weird condition in QWidget, skipping the generation of fake mouse events).
  33905. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  33906. (MiniBrowserApplication::notify):
  33907. 2011-08-10 David Hyatt <hyatt@apple.com>
  33908. https://bugs.webkit.org/show_bug.cgi?id=66004
  33909. Remove the regions and exclusions bots and also the flags in build-webkit, since I'm just turning
  33910. the code on by default.
  33911. Reviewed by Adam Roben.
  33912. * BuildSlaveSupport/build.webkit.org-config/config.json:
  33913. * Scripts/build-webkit:
  33914. 2011-08-10 Oliver Hunt <oliver@apple.com>
  33915. JSEvaluteScript does not return the correct object when given JSONP data
  33916. https://bugs.webkit.org/show_bug.cgi?id=66003
  33917. Reviewed by Gavin Barraclough.
  33918. Add a test case.
  33919. * DumpRenderTree/mac/DumpRenderTree.mm:
  33920. (testStringByEvaluatingJavaScriptFromString):
  33921. 2011-08-10 Eric Seidel <eric@webkit.org>
  33922. WIN: NRWT runs compositing tests on configurations that don't support compositing
  33923. https://bugs.webkit.org/show_bug.cgi?id=64472
  33924. Reviewed by Adam Barth.
  33925. I think the code was just wrong. It was never splitting the string
  33926. into list pieces before.
  33927. I've now tested the supported_features code and theoretically it
  33928. should now work with Windows DRT.
  33929. I also made the list-lookup functions always return lists, to make
  33930. it possible to clean up the list-transform code in the future
  33931. (I opted not to do that cleanup in this patch, but at least now
  33932. both types of feature lookup functions match return types.)
  33933. * Scripts/webkitpy/layout_tests/port/webkit.py:
  33934. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  33935. 2011-08-10 Eric Seidel <eric@webkit.org>
  33936. Clean up ChromiumDriver a little
  33937. https://bugs.webkit.org/show_bug.cgi?id=65995
  33938. Unreviewed.
  33939. Fix NRWT for chromium. Silly python.
  33940. * Scripts/webkitpy/layout_tests/port/chromium.py:
  33941. 2011-08-10 Eric Seidel <eric@webkit.org>
  33942. Clean up ChromiumDriver a little
  33943. https://bugs.webkit.org/show_bug.cgi?id=65995
  33944. Reviewed by Adam Barth.
  33945. - We no longer support threading, so remove threading specific code.
  33946. - Add FIXMEs about using ServerProcess instead.
  33947. - Condense option-mapping if-cascade into a for loop.
  33948. - Unindent long if blocks by using early return.
  33949. - Unwrap lines which are needlessly wrapped.
  33950. There should be no functional changes here, just code cleanup/dead-code removal.
  33951. * Scripts/webkitpy/layout_tests/port/chromium.py:
  33952. 2011-08-10 Dimitri Glazkov <dglazkov@chromium.org>
  33953. Unmuddle construction options for TestConfiguration.
  33954. https://bugs.webkit.org/show_bug.cgi?id=65988
  33955. The TestConfiguration instance is now constructed only using actual values.
  33956. Port-based construction is split into a "from_port" class method.
  33957. Reviewed by Eric Seidel.
  33958. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfiguration.from_port
  33959. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Adjusted code to accommodate the change.
  33960. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  33961. * Scripts/webkitpy/layout_tests/port/base.py: Ditto.
  33962. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Ditto.
  33963. 2011-08-10 Eric Seidel <eric@webkit.org>
  33964. Leaks bot shows python logging prefixes as part of summary display
  33965. https://bugs.webkit.org/show_bug.cgi?id=65931
  33966. Reviewed by Adam Barth.
  33967. The big part of this change is adding a unittesting system for
  33968. master.cfg, so mere-mortals can make changes to build.webkit.org
  33969. with greatly-reduced risk of breaking the world.
  33970. Turns out that in typing up my trival logging fix I made 2 typos,
  33971. so hopefully the hour spent getting master.cfg to load was worth it. :)
  33972. I also tried to make mastercfg_unittest run as part of test-webkitpy
  33973. but right now test-webkitpy requires that unittest files be located in
  33974. a module-name-compatible directory. 'build.webkit.org-config' is not
  33975. a valid module name.
  33976. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  33977. - Fixed _parseNewRunWebKitTestsOutput to strip NRWT's python formatter prefix
  33978. by using a new _strip_python_logging_prefix function.
  33979. - Also fixed this function to file to work with a more modern
  33980. simplejson version (which returns unicode objects instead of str objects)
  33981. and filed a related bug with buildbot.net due to their handling of unicode builder names.
  33982. * BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Added.
  33983. - BuildBotConfigLoader is a huge pile of code just to get master.cfg to load.
  33984. - The actual tiny unittest of the new _parseNewRunWebKitTestsOutput logic.
  33985. * Scripts/webkitpy/thirdparty/__init__.py:
  33986. - Add autoinstallation of buildbot (and jinja2) for use by mastercfg_unittest.py
  33987. 2011-08-09 Dimitri Glazkov <dglazkov@chromium.org>
  33988. garden-o-matic should extrapolate failures given a set of known results
  33989. https://bugs.webkit.org/show_bug.cgi?id=65882
  33990. Reviewed by Adam Barth.
  33991. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Spuriously covered my old sins.
  33992. * Scripts/webkitpy/layout_tests/port/builders.py: Augmented builders dictionary to contain build coverage specifiers,
  33993. adjusted all call sites.
  33994. * Scripts/webkitpy/tool/servers/gardeningserver.py: Added BuildCoverageExtrapolator, a thing that
  33995. makes wider net for specific failures.
  33996. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit tests.
  33997. 2011-08-10 Adam Barth <abarth@webkit.org>
  33998. The URL we were computing for retrieving baselines was missing a slash
  33999. character because our mocks had an extra slash character. I've
  34000. corrected both the code and the mock.
  34001. * Scripts/webkitpy/tool/commands/rebaseline.py:
  34002. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  34003. * Scripts/webkitpy/tool/mocktool.py:
  34004. 2011-08-09 Adam Barth <abarth@webkit.org>
  34005. Move the quote mark to the right place.
  34006. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34007. 2011-08-09 Adam Barth <abarth@webkit.org>
  34008. garden-o-matic should use huerstics to narrow regression range
  34009. https://bugs.webkit.org/show_bug.cgi?id=65948
  34010. Reviewed by Dimitri Glazkov.
  34011. When analyzing a regression range, if one of the commit messages
  34012. mentions the test in question, we now hueristically assume that
  34013. revision caused the failure. (I'm shamelessly stealing this idea from
  34014. TestFailures.)
  34015. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  34016. 2011-07-13 Eric Seidel <eric@webkit.org>
  34017. new-run-webkit-test's WinPort has no fallback logic
  34018. https://bugs.webkit.org/show_bug.cgi?id=64486
  34019. Reviewed by Adam Roben.
  34020. I've tried to write a patch for bug 64439 twice now, and both times
  34021. I've ended up re-writing half the port system. So I'm breaking
  34022. things up into smaller pieces, this being the first.
  34023. WinPort still does not have any port_name parsing, so when instantiated
  34024. with the name "win-xp" (i.e. by the rebaseline server) it will just behave as the 'win' port.
  34025. I'll fix this in a second pass when I standardize port_name parsing for all webkit ports.
  34026. Otherwise this should "just work" for windows. I've not been able to test the
  34027. version detection on my mac, but the unit tests show the code behaving as designed.
  34028. * Scripts/webkitpy/layout_tests/port/win.py:
  34029. * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added.
  34030. 2011-08-09 Adam Barth <abarth@webkit.org>
  34031. Teach build.webkit.org's garden-o-matic how to talk to the local server
  34032. https://bugs.webkit.org/show_bug.cgi?id=65940
  34033. Reviewed by Dimitri Glazkov.
  34034. After this patch, the version of garden-o-matic on build.webkit.org is
  34035. fully functional. It can interact with the local server via CORS.
  34036. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34037. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  34038. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34039. * Scripts/webkitpy/tool/commands/gardenomatic.py:
  34040. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  34041. 2011-08-09 Adam Barth <abarth@webkit.org>
  34042. Enable CORS for garden-o-matic
  34043. https://bugs.webkit.org/show_bug.cgi?id=65936
  34044. Reviewed by Dimitri Glazkov.
  34045. This patch will allow the hosted instance of garden-o-matic to
  34046. communicate with the local server.
  34047. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  34048. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  34049. 2011-08-09 Adam Barth <abarth@webkit.org>
  34050. Upgrade jquery in TestFailures
  34051. https://bugs.webkit.org/show_bug.cgi?id=65935
  34052. Reviewed by Dimitri Glazkov.
  34053. Upgrade to a newer version of jQuery with better support for CORS and CSP.
  34054. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34055. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  34056. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  34057. 2011-08-09 Sheriff Bot <webkit.review.bot@gmail.com>
  34058. Unreviewed, rolling out r92683.
  34059. http://trac.webkit.org/changeset/92683
  34060. https://bugs.webkit.org/show_bug.cgi?id=65921
  34061. "Breaks Qt --minimal build. Revert pending update of the Qt
  34062. minimal configuration" (Requested by simathur on #webkit).
  34063. * QtTestBrowser/cookiejar.cpp:
  34064. (TestBrowserCookieJar::TestBrowserCookieJar):
  34065. * QtTestBrowser/launcherwindow.cpp:
  34066. (LauncherWindow::createChrome):
  34067. (LauncherWindow::setDiskCache):
  34068. * QtTestBrowser/main.cpp:
  34069. (LauncherApplication::handleUserOptions):
  34070. * QtTestBrowser/webpage.cpp:
  34071. (WebPage::openUrlInDefaultBrowser):
  34072. 2011-08-09 Siddharth Mathur <siddharth.mathur@nokia.com>
  34073. [Qt] Simplify code by removing QT_NO_DESKTOPSERVICES and QT_NO_NETWORKDISKCACHE
  34074. https://bugs.webkit.org/show_bug.cgi?id=65880
  34075. Reviewed by Andreas Kling.
  34076. QDesktopServices and QNetworkDiskCache have been around for a while now. Kill flags which
  34077. check for their feature flags. Assume that any reasonable Qt build provides them.
  34078. * QtTestBrowser/cookiejar.cpp:
  34079. (TestBrowserCookieJar::TestBrowserCookieJar):
  34080. * QtTestBrowser/launcherwindow.cpp:
  34081. (LauncherWindow::createChrome):
  34082. (LauncherWindow::setDiskCache):
  34083. * QtTestBrowser/main.cpp:
  34084. (LauncherApplication::handleUserOptions):
  34085. * QtTestBrowser/webpage.cpp:
  34086. (WebPage::openUrlInDefaultBrowser):
  34087. 2011-08-09 Adam Barth <abarth@webkit.org>
  34088. BaselineOptimizer created the wrong baseline for fast/js/regexp-overflow.html
  34089. https://bugs.webkit.org/show_bug.cgi?id=65891
  34090. Reviewed by Eric Seidel.
  34091. The problem was that platform/chromium contained a bogus expectation
  34092. file that needed to be removed, but by the time we got around to
  34093. removing it, we'd already moved the correct baseline into its place.
  34094. After this patch, we copy the gold results into memory before
  34095. reshuffling things on disk (and we delete bad things before adding good
  34096. things).
  34097. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  34098. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  34099. 2011-08-08 Adam Barth <abarth@webkit.org>
  34100. Chromium Windows bots can't figure out what SVN revision they're running
  34101. https://bugs.webkit.org/show_bug.cgi?id=65893
  34102. Reviewed by Eric Seidel.
  34103. The comment in _engage_awesome_windows_hacks explains why we're making
  34104. this change. It's ugly and rediculous, but this approach seems better
  34105. than using shell=True when calling popen.
  34106. * Scripts/webkitpy/common/checkout/scm/svn.py:
  34107. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  34108. 2011-08-08 Adam Barth <abarth@webkit.org>
  34109. Remove deduplicate-tests
  34110. https://bugs.webkit.org/show_bug.cgi?id=65886
  34111. Reviewed by Tony Chang.
  34112. This script is redundant with "webkit-patch bulk-optimize-baselines",
  34113. which can find many more duplicates than deduplicate-tests because
  34114. bulk-optimize-baselines can move results around whereas
  34115. deduplicate-tests can only remove results.
  34116. * Scripts/deduplicate-tests: Removed.
  34117. * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Removed.
  34118. * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Removed.
  34119. 2011-08-08 Adam Barth <abarth@webkit.org>
  34120. scm.delete should delete empty parent directories as well
  34121. https://bugs.webkit.org/show_bug.cgi?id=65878
  34122. Reviewed by Eric Seidel.
  34123. This behavior makes SVN match GIT (which has no concept of empty
  34124. directories). This bug comes up a lot when optimizing baselines, which
  34125. often create empty directories when we're able to optimize everything
  34126. out of a given folder.
  34127. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  34128. * Scripts/webkitpy/common/checkout/scm/svn.py:
  34129. 2011-08-08 Lucas Forschler <lforschler@apple.com>
  34130. Add triggers for Lion WK2 test bots.
  34131. Reviewed by Stephanie Lewis.
  34132. * BuildSlaveSupport/build.webkit.org-config/config.json:
  34133. 2011-08-08 Adam Barth <abarth@webkit.org>
  34134. bulk-optimize-baselines should take directories on the command line
  34135. https://bugs.webkit.org/show_bug.cgi?id=65879
  34136. Reviewed by Dimitri Glazkov.
  34137. Passing lists of tests via stdin is a pain. It's easier if the command
  34138. takes a list of tests on the command line, like run-webkit-tests.
  34139. * Scripts/webkitpy/tool/commands/rebaseline.py:
  34140. 2011-08-08 Adam Barth <abarth@webkit.org>
  34141. Deprecate rebaseline-chromium-webkit-tests
  34142. https://bugs.webkit.org/show_bug.cgi?id=65873
  34143. Reviewed by Dimitri Glazkov.
  34144. This script never worked correctly and now is redundant with more
  34145. modern infrastructure for rebaselining tests. This patch deprecates
  34146. the script in order to flush out any issues with the new tools. Once
  34147. folks are happy with the new tools, we'll delete this script.
  34148. * Scripts/rebaseline-chromium-webkit-tests:
  34149. 2011-08-08 Dimitri Glazkov <dglazkov@chromium.org>
  34150. garden-o-matic should only touch expectations that need updating.
  34151. https://bugs.webkit.org/show_bug.cgi?id=65876
  34152. Reviewed by Adam Barth.
  34153. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added reconstitute_only_these to TestExpectationSerializer.list_to_string,
  34154. so that a caller could influence which lines to serialize from values.
  34155. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
  34156. * Scripts/webkitpy/tool/servers/gardeningserver.py: Started using reconstitute_only_these.
  34157. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added tests.
  34158. 2011-08-08 Dimitri Glazkov <dglazkov@chromium.org>
  34159. TestExpectationsEditor should return a list of updated expectations.
  34160. https://bugs.webkit.org/show_bug.cgi?id=65872
  34161. Reviewed by Adam Barth.
  34162. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added a list to store lines that are being updated.
  34163. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to account for updated lines.
  34164. 2011-08-08 Jochen Eisinger <jochen@chromium.org>
  34165. Fix SCM webkitpy unit test failures
  34166. https://bugs.webkit.org/show_bug.cgi?id=65823
  34167. Reviewed by Eric Seidel.
  34168. * Scripts/webkitpy/common/checkout/scm/git.py:
  34169. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  34170. 2011-08-08 Eric Seidel <eric@webkit.org>
  34171. Move the --leaks bot back over to NRWT now that I'm back
  34172. from vacation and able to debug it.
  34173. Unreviewed.
  34174. * Scripts/run-webkit-tests:
  34175. (usingWebKit2):
  34176. (useNewRunWebKitTests):
  34177. 2011-08-05 Dimitri Glazkov <dglazkov@chromium.org>
  34178. Wire up updating expectations in garden-o-matic.
  34179. https://bugs.webkit.org/show_bug.cgi?id=65794
  34180. Reviewed by Adam Barth.
  34181. * Scripts/webkitpy/layout_tests/port/factory.py: Moved _port_for_builder from rebaseline.py to here, rename to get_from_builder_name.
  34182. * Scripts/webkitpy/tool/commands/rebaseline.py: Adapted callsites to new location.
  34183. * Scripts/webkitpy/tool/servers/gardeningserver.py: Added GardeningExpectationsUpdater, which knows how to update expectations.
  34184. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added loads of tests.
  34185. 2011-08-08 Jochen Eisinger <jochen@chromium.org>
  34186. webkit-patch doesn't get along with renamed files
  34187. https://bugs.webkit.org/show_bug.cgi?id=48075
  34188. Possibly a bit heavy handed - I removed all instances of -C and
  34189. changed every instance of -M with '--no-renames' in git.py. This
  34190. forces git to not try to tell us about renames at all, which is
  34191. ultimately the behaviour we want. The old file is shown deleted,
  34192. then the new file is shown added, followed by any changes that
  34193. occurred. Also gets rid of the problem where deleting one file
  34194. and adding another file which has similar content would
  34195. unexpectedly show up as a rename, and fall out of a diff.
  34196. Based on a patch by Wyatt Carss.
  34197. Reviewed by Eric Seidel.
  34198. * Scripts/webkitpy/common/checkout/scm/git.py:
  34199. 2011-08-07 Sam White <samuel.white@rochester.edu>
  34200. Add the ability to search the AccessibilityObject cache
  34201. https://bugs.webkit.org/show_bug.cgi?id=64994
  34202. Added testing support for AccessibilityObject cache searching. Currently,
  34203. only the mac platform is full supported and has had API exposed. Other
  34204. platforms have only have this new functionality stubbed. Full implementation
  34205. is a job suited only for an accessibility expert of each respective platform.
  34206. Reviewed by Chris Fleizach.
  34207. * DumpRenderTree/AccessibilityUIElement.cpp:
  34208. (uiElementForSearchPredicateCallback):
  34209. (AccessibilityUIElement::getJSClass):
  34210. * DumpRenderTree/AccessibilityUIElement.h:
  34211. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  34212. (AccessibilityUIElement::uiElementForSearchPredicate):
  34213. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  34214. (AccessibilityUIElement::uiElementForSearchPredicate):
  34215. * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
  34216. (AccessibilityUIElement::uiElementForSearchPredicate):
  34217. 2011-08-06 Adam Barth <abarth@webkit.org>
  34218. Remove dead code in webkitpy
  34219. https://bugs.webkit.org/show_bug.cgi?id=65818
  34220. Reviewed by Dimitri Glazkov.
  34221. This code was added to support the rebaseline2 command six months ago,
  34222. but the rebaseline2 command was never finished and no one else has used
  34223. this code since it was landed. This patch removes the dead code. If
  34224. we revive rebaseline2, then we can revert this patch and recover the
  34225. code. Until then, this code is just dead weight.
  34226. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  34227. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  34228. * Scripts/webkitpy/common/net/testoutput.py: Removed.
  34229. * Scripts/webkitpy/common/net/testoutput_unittest.py: Removed.
  34230. * Scripts/webkitpy/common/net/testoutputset.py: Removed.
  34231. * Scripts/webkitpy/common/net/testoutputset_unittest.py: Removed.
  34232. * Scripts/webkitpy/common/system/directoryfileset.py: Removed.
  34233. * Scripts/webkitpy/common/system/directoryfileset_unittest.py: Removed.
  34234. * Scripts/webkitpy/layout_tests/port/base.py:
  34235. * Scripts/webkitpy/layout_tests/port/chromium.py:
  34236. * Scripts/webkitpy/layout_tests/port/webkit.py:
  34237. 2011-08-06 Adam Barth <abarth@webkit.org>
  34238. webkit-patch optimize-baselines can't handle promotions to base results directory
  34239. https://bugs.webkit.org/show_bug.cgi?id=65819
  34240. Reviewed by Dimitri Glazkov.
  34241. This bug came up when testing the optimizer on some editing baselines.
  34242. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  34243. * Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
  34244. 2011-08-06 Adam Barth <abarth@webkit.org>
  34245. Add a small command to optimize baselines in bulk.
  34246. * Scripts/webkitpy/tool/commands/rebaseline.py:
  34247. 2011-08-05 Dimitri Glazkov <dglazkov@chromium.org>
  34248. Fix unit test breakage by plumbing convert_404_to_None in MockWeb.
  34249. * Scripts/webkitpy/tool/mocktool.py: Added missing parameter to MockWeb.get_binary
  34250. 2011-08-05 Dimitri Glazkov <dglazkov@chromium.org>
  34251. Garden-o-matic updateexpectations needs a unit test.
  34252. https://bugs.webkit.org/show_bug.cgi?id=65780
  34253. Reviewed by Adam Barth.
  34254. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added unit test.
  34255. 2011-08-05 Anders Carlsson <andersca@apple.com>
  34256. Future proof an Objective-C test
  34257. https://bugs.webkit.org/show_bug.cgi?id=65788
  34258. Reviewed by Dan Bernstein.
  34259. Add isObjectInstanceOf to ObjCController.
  34260. * DumpRenderTree/mac/ObjCController.m:
  34261. (+[ObjCController isSelectorExcludedFromWebScript:]):
  34262. (+[ObjCController webScriptNameForSelector:]):
  34263. (-[ObjCController isObject:instanceOf:]):
  34264. 2011-08-05 Adam Barth <abarth@webkit.org>
  34265. trac.js needs unittests
  34266. https://bugs.webkit.org/show_bug.cgi?id=65673
  34267. Reviewed by Dimitri Glazkov.
  34268. This tests also have somewhat large fixtures. I've trimmed the example
  34269. XML down a bunch while still hitting interesting cases in the parsing.
  34270. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  34271. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/trac_unittests.js: Added.
  34272. 2011-08-05 Adam Barth <abarth@webkit.org>
  34273. Rebuild rebaseline-chromium-webkit-tests on top of modern infrastructure
  34274. https://bugs.webkit.org/show_bug.cgi?id=65759
  34275. Reviewed by Dimitri Glazkov.
  34276. rebaseline-chromium-webkit-tests doesn't really fit into webkitpy's
  34277. architecture, is poorly tested, and has a bunch of quirks. This patch
  34278. rebuilds the core functionality of rebaseline-chromium-webkit-tests on
  34279. top of more modern infrastructure. In the process, we get more code
  34280. re-use and better testing.
  34281. Once we're satisfied with this new implementation, we can delete the
  34282. old implementation.
  34283. * Scripts/webkitpy/common/checkout/baselineoptimizer.py:
  34284. * Scripts/webkitpy/common/net/web.py:
  34285. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  34286. * Scripts/webkitpy/layout_tests/port/builders.py:
  34287. * Scripts/webkitpy/layout_tests/port/chromium.py:
  34288. * Scripts/webkitpy/layout_tests/port/factory.py:
  34289. * Scripts/webkitpy/layout_tests/port/webkit.py:
  34290. * Scripts/webkitpy/tool/commands/rebaseline.py:
  34291. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  34292. 2011-08-05 Anders Carlsson <andersca@apple.com>
  34293. Remove PluginHalter
  34294. https://bugs.webkit.org/show_bug.cgi?id=65729
  34295. Reviewed by Darin Adler.
  34296. Remove call to set the allowed plug-in run time.
  34297. * DumpRenderTree/mac/DumpRenderTree.mm:
  34298. (resetDefaultsToConsistentValues):
  34299. 2011-08-05 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
  34300. Unreviewed build fix for Qt-Minimal buildbot
  34301. Use ~/.QtTestBrowser for the cookiejar when QDesktopServices
  34302. is disabled.
  34303. Rubber-stamped by Holger Freyther.
  34304. * QtTestBrowser/cookiejar.cpp:
  34305. (TestBrowserCookieJar::TestBrowserCookieJar):
  34306. 2011-08-05 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
  34307. [Qt] QtTestBrowser: Add support for saving cookies on disk
  34308. https://bugs.webkit.org/show_bug.cgi?id=65328
  34309. Simple cookiejar that saves cookies on disk.
  34310. Added menu options to clear cookies (Edit->Clear cookies) and
  34311. disable disk cookies (Settings->[ ]Save Cookies on Disk).
  34312. Option -no-disk-cookies is also available.
  34313. Reviewed by Andreas Kling.
  34314. * QtTestBrowser/QtTestBrowser.pro:
  34315. * QtTestBrowser/cookiejar.cpp: Added.
  34316. * QtTestBrowser/cookiejar.h: Added.
  34317. * QtTestBrowser/launcherwindow.cpp:
  34318. * QtTestBrowser/launcherwindow.h:
  34319. * QtTestBrowser/main.cpp:
  34320. 2011-08-04 Adam Barth <abarth@webkit.org>
  34321. model.js needs some unit testing
  34322. https://bugs.webkit.org/show_bug.cgi?id=65730
  34323. Reviewed by Dimitri Glazkov.
  34324. These tests do not cover all the functions exported by the model
  34325. module. We'll need to add the remaining ones in the future.
  34326. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model_unittests.js: Added.
  34327. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  34328. 2011-08-04 Adam Barth <abarth@webkit.org>
  34329. Another speculative fix for the "svn revision on Windows" problem.
  34330. * Scripts/webkitpy/common/checkout/scm/git.py:
  34331. 2011-08-04 Mark Rowe <mrowe@apple.com>
  34332. Future-proof Xcode configuration settings.
  34333. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  34334. * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  34335. * DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
  34336. * MiniBrowser/Configurations/Base.xcconfig:
  34337. * MiniBrowser/Configurations/CompilerVersion.xcconfig:
  34338. * MiniBrowser/Configurations/DebugRelease.xcconfig:
  34339. * TestWebKitAPI/Configurations/Base.xcconfig:
  34340. * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  34341. * TestWebKitAPI/Configurations/DebugRelease.xcconfig:
  34342. * WebKitTestRunner/Configurations/Base.xcconfig:
  34343. * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
  34344. * WebKitTestRunner/Configurations/DebugRelease.xcconfig:
  34345. 2011-08-04 Adam Barth <abarth@webkit.org>
  34346. Fancier debug logging.
  34347. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  34348. 2011-08-04 David Levin <levin@chromium.org>
  34349. [chromium] Fix assertion failure in ThreadIdentifierData::identifier in TestShell.
  34350. https://bugs.webkit.org/show_bug.cgi?id=65685
  34351. Reviewed by Dmitry Titov.
  34352. * DumpRenderTree/chromium/WebViewHost.cpp:
  34353. (WebViewHost::WebViewHost): Intialize WTF threading before
  34354. anything in WTF is used. Usually this is done by WebViewImpl::WebViewImpl
  34355. but in some cases code may use WTF without creating WebViewImpl and
  34356. WTF code functionality may call WTF::currentThread, which requires
  34357. this initialization now.
  34358. 2011-08-04 Adam Barth <abarth@webkit.org>
  34359. An educated guess at causing the Windows bots on build.webkit.org to
  34360. find the SVN revision number.
  34361. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  34362. * Scripts/webkitpy/layout_tests/port/base.py:
  34363. 2011-08-04 Adam Barth <abarth@webkit.org>
  34364. More logging to help debug the "no SVN rev on Chromium Windows bots"
  34365. bug. My current theory is that we're trying to detect the SCM system
  34366. in the wrong directory.
  34367. * Scripts/webkitpy/layout_tests/port/base.py:
  34368. 2011-08-04 Dimitri Glazkov <dglazkov@chromium.org>
  34369. Speed up webkit-patch optimize-expectations significantly by not collecting test files.
  34370. https://bugs.webkit.org/show_bug.cgi?id=65697
  34371. I neglected to realize that collecting test names is not necessary for this operation.
  34372. Reviewed by Adam Barth.
  34373. * Scripts/webkitpy/tool/commands/expectations.py: Changed to pass an empty list of test files.
  34374. 2011-08-04 Adam Barth <abarth@webkit.org>
  34375. checkout_unittest.js should have better coverage of checkout.js
  34376. https://bugs.webkit.org/show_bug.cgi?id=65671
  34377. Reviewed by Dimitri Glazkov.
  34378. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34379. - Remove unused functions.
  34380. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
  34381. - Test remaining public functions in the checkout module.
  34382. 2011-08-04 Dmitry Lomov <dslomov@google.com>
  34383. https://bugs.webkit.org/show_bug.cgi?id=65706
  34384. Run run-unit-tests on release mode test bots.
  34385. Reenabling after 61812 is fixed.
  34386. Reviewed by Adam Roben.
  34387. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  34388. 2011-08-04 Adam Barth <abarth@webkit.org>
  34389. builders.js needs unit tests
  34390. https://bugs.webkit.org/show_bug.cgi?id=65670
  34391. Reviewed by Dimitri Glazkov.
  34392. This test requires somewhat large test fixtures, but using real
  34393. examples seemed better than trimming them down too much.
  34394. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  34395. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders_unittests.js: Added.
  34396. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  34397. - Note: trac_unittests.js doesn't exist (yet!).
  34398. 2011-08-04 Alexis Menard <alexis.menard@openbossa.org>
  34399. [Qt] Make navigation actions properly usable in QML.
  34400. https://bugs.webkit.org/show_bug.cgi?id=65624
  34401. Fix compilation after the introduction of QWebNavigationController.
  34402. Reviewed by Benjamin Poulain.
  34403. * MiniBrowser/qt/BrowserView.cpp:
  34404. (BrowserView::navigationAction):
  34405. 2011-08-04 Adam Barth <abarth@webkit.org>
  34406. Another subtle bug due to lack of testing in main.js. :(
  34407. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34408. 2011-08-04 Adam Barth <abarth@webkit.org>
  34409. Fix types. Sadly, main.js has no test coverage. (I need to think
  34410. about how to test this part of the code.)
  34411. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34412. 2011-08-04 Adam Barth <abarth@webkit.org>
  34413. bugzilla.js is missing unit tests
  34414. https://bugs.webkit.org/show_bug.cgi?id=65656
  34415. Reviewed by Adam Roben.
  34416. Testing makes perfect.
  34417. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/bugzilla_unittests.js: Added.
  34418. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
  34419. (NetworkSimulator.prototype.runTest.get if):
  34420. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  34421. 2011-08-04 Adam Barth <abarth@webkit.org>
  34422. Add missing license blocks to garden-o-matic
  34423. https://bugs.webkit.org/show_bug.cgi?id=65654
  34424. Reviewed by Dimitri Glazkov.
  34425. This patch is entirely boilerplate.
  34426. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  34427. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  34428. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
  34429. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  34430. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34431. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js:
  34432. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  34433. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34434. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  34435. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34436. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  34437. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js:
  34438. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js:
  34439. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  34440. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  34441. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  34442. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  34443. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  34444. 2011-08-04 Adam Barth <abarth@webkit.org>
  34445. garden-o-matic needs a way to mock out the network
  34446. https://bugs.webkit.org/show_bug.cgi?id=65653
  34447. Reviewed by Dimitri Glazkov.
  34448. This patch introduces the net module, which is a useful mock point for
  34449. abstracting away the network. Future patches will use this
  34450. infrastructure to test some currently untested code.
  34451. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  34452. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  34453. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  34454. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js:
  34455. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34456. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34457. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  34458. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net.js: Added.
  34459. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/net_unittests.js: Added.
  34460. (NetworkSimulator):
  34461. (NetworkSimulator.prototype.scheduleCallback):
  34462. (NetworkSimulator.prototype.runTest):
  34463. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  34464. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  34465. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  34466. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  34467. 2011-08-03 Adam Barth <abarth@webkit.org>
  34468. Use failureInfo more pervasively in garden-o-matic
  34469. https://bugs.webkit.org/show_bug.cgi?id=65650
  34470. Reviewed by Dimitri Glazkov.
  34471. These three variable appears in concert together many places. This
  34472. patch unifies the remaining uses into being failureInfo objects, which
  34473. saves some marshalling.
  34474. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34475. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  34476. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  34477. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  34478. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  34479. 2011-08-03 Adam Barth <abarth@webkit.org>
  34480. garden-o-matic should be able to update expecations from the details pane
  34481. https://bugs.webkit.org/show_bug.cgi?id=65648
  34482. Reviewed by Dimitri Glazkov.
  34483. The new button queues up the updates, which get executed all at once.
  34484. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34485. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34486. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  34487. 2011-08-03 Adam Barth <abarth@webkit.org>
  34488. Add UI to garden-o-matic for updating expectations
  34489. https://bugs.webkit.org/show_bug.cgi?id=65644
  34490. Reviewed by Dimitri Glazkov.
  34491. The patch plumbs the UI back to the gardening server, but the gardening
  34492. server endpoint is just a stub at this point.
  34493. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34494. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34495. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34496. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  34497. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  34498. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  34499. 2011-08-03 Adam Barth <abarth@webkit.org>
  34500. garden-o-matic details view should queue rebaselines for later execution
  34501. https://bugs.webkit.org/show_bug.cgi?id=65636
  34502. Reviewed by Dimitri Glazkov.
  34503. This patch doesn't contain any confirmation UI, but we'll probably want
  34504. that at some point.
  34505. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34506. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34507. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34508. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  34509. 2011-08-03 Kentaro Hara <haraken@google.com>
  34510. Implement EventSender.scalePageBy()
  34511. https://bugs.webkit.org/show_bug.cgi?id=58013
  34512. Reviewed by Darin Fisher.
  34513. Implemented EventSender.scalePageBy(f, x, y), which scales a page by a factor of f
  34514. and then sets a scroll position to (x, y). Enabled the tests that had been waiting
  34515. for the implementation of EventSender.scalePageBy(f, x, y).
  34516. Tests: compositing/scaling/tiled-layer-recursion.html
  34517. fast/repaint/scale-page-shrink.html
  34518. fast/dom/Element/scale-page-client-rects.html
  34519. fast/dom/Range/scale-page-client-rects.html
  34520. fast/events/scroll-in-scaled-page-with-overflow-hidden.html
  34521. fast/dom/Element/scale-page-bounding-client-rect.html
  34522. fast/dom/Range/scale-page-bounding-client-rect.html
  34523. * DumpRenderTree/chromium/EventSender.cpp:
  34524. (EventSender::EventSender): Added bindings for scalePageBy().
  34525. (EventSender::scalePageBy): A wrapper method for scalePage() in WebView.
  34526. * DumpRenderTree/chromium/EventSender.h:
  34527. * DumpRenderTree/chromium/TestShell.cpp:
  34528. (TestShell::resetTestController): Resets the scale factor to 1.
  34529. 2011-08-03 David Levin <levin@chromium.org>
  34530. Rename WEBKIT_API to WEBKIT_EXPORT in check-webkit-style.
  34531. https://bugs.webkit.org/show_bug.cgi?id=65652
  34532. Reviewed by Adam Barth.
  34533. * Scripts/webkitpy/style/checkers/cpp.py:
  34534. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  34535. 2011-08-03 Filip Pizlo <fpizlo@apple.com>
  34536. Adding Filip Pizlo to committer list.
  34537. Unreviewed.
  34538. * Scripts/webkitpy/common/config/committers.py:
  34539. 2011-08-03 Dimitri Glazkov <dglazkov@chromium.org>
  34540. Add "optimize-expectations" command to webkit-patch.
  34541. https://bugs.webkit.org/show_bug.cgi?id=65633
  34542. For now, only operates on Chromium test_expectations.txt and does not report errors/warnings.
  34543. Reviewed by Adam Barth.
  34544. * Scripts/webkitpy/tool/commands/__init__.py: Added command.
  34545. * Scripts/webkitpy/tool/commands/expectations.py: Added.
  34546. 2011-08-03 Dimitri Glazkov <dglazkov@chromium.org>
  34547. Allow multiple bug identifiers in test expectations.
  34548. https://bugs.webkit.org/show_bug.cgi?id=65642
  34549. Reviewed by Adam Barth.
  34550. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Tweaked to allow multiple bug ids.
  34551. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
  34552. 2011-08-03 Dimitri Glazkov <dglazkov@chromium.org>
  34553. Teach BuilderToPort to distinguish between Release and Debug builders.
  34554. https://bugs.webkit.org/show_bug.cgi?id=65628
  34555. Reviewed by Adam Barth.
  34556. * Scripts/webkitpy/tool/commands/rebaseline.py: Added a smart options object and passed it to port factory.
  34557. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py: Added tests.
  34558. 2011-08-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  34559. [Qt] Fix running qmltests for WK2 in the bot
  34560. https://bugs.webkit.org/show_bug.cgi?id=65621
  34561. Reviewed by Csaba Osztrogonác.
  34562. The path for QML_IMPORT_PATH was assuming we were running the WK1 tests,
  34563. but now there's the case for WK2 UIProcess tests as well.
  34564. * Scripts/run-qtwebkit-tests: add both possible paths to the QML_IMPORT_PATH.
  34565. 2011-08-02 Dimitri Glazkov <dglazkov@chromium.org>
  34566. Add a way to edit test expectations.
  34567. https://bugs.webkit.org/show_bug.cgi?id=64922
  34568. Implements a TestExpectationsEditor, which provides a standard way to
  34569. update and remove test expectations.
  34570. Reviewed by Adam Barth.
  34571. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed TestExpectationSerializer to skip lines that match no test configurations,
  34572. added TestExpectationLine.is_flaky, added BugManager, a simple interface to be fleshed out later, and a TestExpectationsEditor, the big
  34573. enchilada.
  34574. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Loads of tests to capture desired behavior.
  34575. 2011-08-03 Andreas Kling <kling@webkit.org>
  34576. [Qt] MiniBrowser: Unbreak load progress indication.
  34577. https://bugs.webkit.org/show_bug.cgi?id=65614
  34578. Reviewed by Kenneth Rohde Christiansen.
  34579. loadProgress() was renamed to loadProgressChanged().
  34580. * MiniBrowser/qt/BrowserWindow.cpp:
  34581. (BrowserWindow::BrowserWindow):
  34582. (BrowserWindow::onLoadProgressChanged):
  34583. * MiniBrowser/qt/BrowserWindow.h:
  34584. 2011-08-03 Martin Robinson <mrobinson@igalia.com>
  34585. Build fix for WebKit2GTK+.
  34586. * WebKitTestRunner/GNUmakefile.am: Include libInternals as one of
  34587. of the library dependencies of the injected bundle.
  34588. 2011-08-03 Carlos Garcia Campos <cgarcia@igalia.com>
  34589. [GTK] Install web and plugin processes in libexecdir instead of bindir
  34590. https://bugs.webkit.org/show_bug.cgi?id=65600
  34591. Reviewed by Martin Robinson.
  34592. Set WEBKIT_EXEC_PATH environment variable to use web and plugin
  34593. process from current directory instead of the intalled ones.
  34594. * MiniBrowser/gtk/GNUmakefile.am:
  34595. * MiniBrowser/gtk/main.c:
  34596. (main):
  34597. * WebKitTestRunner/GNUmakefile.am:
  34598. * WebKitTestRunner/gtk/main.cpp:
  34599. (main):
  34600. 2011-08-02 Anders Carlsson <andersca@apple.com>
  34601. Add mac-lion platform to old-run-webkit-tests
  34602. https://bugs.webkit.org/show_bug.cgi?id=65577
  34603. * Scripts/old-run-webkit-tests:
  34604. * Scripts/webkitdirs.pm:
  34605. (isLion):
  34606. 2011-08-02 Alexandru Chiculita <achicu@adobe.com>
  34607. Buildbot: The Properties object has no "hasProperty" method in buildbot 8.3
  34608. https://bugs.webkit.org/show_bug.cgi?id=65554
  34609. Using "has_key" instead of "hasProperty" in order to support buildbot 8.3.
  34610. Reviewed by Adam Roben.
  34611. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  34612. 2011-08-02 Jochen Eisinger <jochen@chromium.org>
  34613. Implement WebPermissionClient::allowPlugins for layout tests
  34614. https://bugs.webkit.org/show_bug.cgi?id=33991
  34615. Reviewed by Adam Barth.
  34616. * DumpRenderTree/chromium/LayoutTestController.cpp:
  34617. (LayoutTestController::LayoutTestController):
  34618. (LayoutTestController::setPluginsAllowed):
  34619. * DumpRenderTree/chromium/LayoutTestController.h:
  34620. * DumpRenderTree/chromium/WebPermissions.cpp:
  34621. (WebPermissions::allowPlugins):
  34622. (WebPermissions::setPluginsAllowed):
  34623. (WebPermissions::reset):
  34624. * DumpRenderTree/chromium/WebPermissions.h:
  34625. 2011-08-02 Adam Barth <abarth@webkit.org>
  34626. TestFailures unit tests leak a global variable
  34627. https://bugs.webkit.org/show_bug.cgi?id=65500
  34628. Reviewed by Adam Roben.
  34629. qunit detects the leak if you check the "noglobals" box on run-unittests.html.
  34630. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  34631. 2011-08-02 Alexandru Chiculita <achicu@adobe.com>
  34632. CSS Regions build bot should archive and upload output files
  34633. https://bugs.webkit.org/show_bug.cgi?id=65200
  34634. Until now the buildbots would only upload the result archive if the 'trigger' parameters was specified. The
  34635. upload was needed, because the testbots needed to download and use the archive. For CSS Regions we don't have
  34636. a testbot yet, but we want to save the archive on the server for manual testing. Added new parameter
  34637. in config.json, called "upload" that when set to "true" will force the upload to the buildmaster server.
  34638. The "features" argument is now taken into account when determining the name of the archive on the server. That
  34639. was needed in order to avoid the CSS Regions Mac buildbot overwrite the SnowLeopard Mac build.
  34640. Reviewed by Adam Roben.
  34641. * BuildSlaveSupport/build.webkit.org-config/config.json:
  34642. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  34643. 2011-08-02 Patrick Gansterer <paroga@webkit.org>
  34644. Fix _win32_check_running_pid on 64bit windows python
  34645. https://bugs.webkit.org/show_bug.cgi?id=64950
  34646. Reviewed by Adam Roben.
  34647. Use the correct types for the PROCESSENTRY32 struct.
  34648. th32DefaultHeapID is declared as ULONG_PTR and not as DWORD.
  34649. Using 32bit for pointers instead of 64bit results in an ERROR_BAD_LENGTH
  34650. failure, when calling the Process32First function.
  34651. This is covered by the executive unittest.
  34652. * Scripts/webkitpy/common/system/executive.py:
  34653. 2011-08-01 Adam Barth <abarth@webkit.org>
  34654. garden-o-matic should call optimize-baselines when rebaselining tests
  34655. https://bugs.webkit.org/show_bug.cgi?id=65499
  34656. Reviewed by Dimitri Glazkov.
  34657. I took the opportunity to modernize this code to use some of our more
  34658. powerful primitives from base.
  34659. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  34660. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js:
  34661. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js:
  34662. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  34663. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  34664. 2011-08-01 Stephanie Lewis <slewis@apple.com>
  34665. Finish reconfiguration started by Lucas Forschler
  34666. Reconfigured slaves:
  34667. Removed Leopard Intel Release (Build)
  34668. Removed Leopard Intel Release (Tests)
  34669. Remove apple-pixel-1
  34670. Added Lion slaves from disabled Leopard slaves
  34671. Added builders:
  34672. Lion Intel Release (Build)
  34673. Lion Intel Debug (Build)
  34674. Lion Intel Release (Tests)
  34675. Lion Intel Release WK2 (Tests)
  34676. Lion Intel Debug (Tests)
  34677. Lion Intel Debug WK2 (Tests)
  34678. Added triggers:
  34679. lion-intel-debug-tests
  34680. lion-intel-debug-test-wk2
  34681. lion-intel-release-tests
  34682. lion-intel-release-tests-wk2
  34683. Removed trigger:
  34684. leopard-intel-release-tests
  34685. Added PlatformSpecificScheduler:
  34686. mac-lion
  34687. Added "mac-lion" to build.py and build_unitttest.py
  34688. Reviewed by Mark Rowe.
  34689. * BuildSlaveSupport/build.webkit.org-config/config.json:
  34690. * Scripts/webkitpy/common/config/build.py:
  34691. * Scripts/webkitpy/common/config/build_unittest.py:
  34692. 2011-08-01 Adam Barth <abarth@webkit.org>
  34693. webkit-patch needs to be able to "optimize" the storage of baselines on disk
  34694. https://bugs.webkit.org/show_bug.cgi?id=65418
  34695. Reviewed by Dimitri Glazkov.
  34696. If we're not careful when rebaselining tests, we can end up with lots
  34697. of duplicate expected results files in the tree. This patch adds a
  34698. webkit-patch command that optimizes the storage of expected results on
  34699. disk.
  34700. This command is similar to deduplicate-tests, except that it can move
  34701. test results around rather than just remove duplicate results.
  34702. Unfortunately, this problem is very tricky because the baseline search
  34703. structure is a hypergraph. This patch include a huerstic optimizer
  34704. that appears to work on a bunch of examples I've tried. We'll likely
  34705. need to refine it as gain experience.
  34706. * Scripts/webkitpy/common/system/filesystem.py:
  34707. * Scripts/webkitpy/tool/commands/rebaseline.py:
  34708. 2011-08-01 Dimitri Glazkov <dglazkov@chromium.org>
  34709. Teach TestExpectationSerializer about parsed expectations.
  34710. https://bugs.webkit.org/show_bug.cgi?id=65444
  34711. This is a bit largish in size, but the essentials are:
  34712. * TestExpectationSerializer, given a parsed TestExpectationLine, can now spit out a pretty string.
  34713. * We now store original content of the expectation line on TestExpectationLine.
  34714. * Lots of tests.
  34715. Reviewed by Adam Barth.
  34716. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Fixed an issue where we didn't
  34717. populate macros correctly, also fixed an issue where we incorrectly returned an empty list
  34718. for all configurations.
  34719. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for those.
  34720. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed vestiges of code long gone,
  34721. refactored TestExpectationsSerializer to recognize and correctly serialize parsed TestExpectationLine instances,
  34722. changed to store and use TestExpectationLine.original_string.
  34723. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests.
  34724. 2011-08-01 Adam Barth <abarth@webkit.org>
  34725. Remove unused functionality from gardeningserver
  34726. https://bugs.webkit.org/show_bug.cgi?id=65479
  34727. Reviewed by Dimitri Glazkov.
  34728. We now handle these operations directly from the front-end. That means
  34729. they work even without the gardening server running!
  34730. Also, add some missing files to the list of static files.
  34731. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  34732. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  34733. 2011-08-01 Dimitri Glazkov <dglazkov@chromium.org>
  34734. Introduce SpecifierSorter, a thing that knows how specifiers should be ordered.
  34735. https://bugs.webkit.org/show_bug.cgi?id=65413
  34736. Reviewed by Adam Barth.
  34737. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added SpecifierSorter and converted
  34738. existing code to use it.
  34739. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests and cleaned up a bit.
  34740. 2011-08-01 Adam Barth <abarth@webkit.org>
  34741. Refactor bugzilla.js for use by garden-o-matic
  34742. https://bugs.webkit.org/show_bug.cgi?id=65450
  34743. Reviewed by Dimitri Glazkov.
  34744. This patch refactors bugzilla.js to use the AsynchronousCache and
  34745. updates the style to use a module instead of an object. This patch
  34746. then fixes all the existing code that uses this class to use the new
  34747. API style.
  34748. This main benefit of this patch is we remove the tricky manual caching
  34749. and this code is now available to use in garden-o-matic (since the
  34750. dependency on Utilities.js is now gone).
  34751. I ran all the unit tests and poked around in TestFailures a bit to see
  34752. that everything seemed to be working properly.
  34753. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  34754. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
  34755. (FailingTestsBugForm):
  34756. (FailingTestsBugForm.prototype._createBugTitle):
  34757. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  34758. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
  34759. (FlakyTestBugForm):
  34760. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
  34761. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js:
  34762. (NewBugForm):
  34763. (NewBugForm.prototype.domElement):
  34764. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
  34765. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js:
  34766. (TestRelatedBugForm):
  34767. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
  34768. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  34769. (ViewController.prototype._displayBuilder.start):
  34770. (ViewController.prototype._displayBuilder):
  34771. (ViewController.prototype._domForAuxiliaryUIElements):
  34772. (ViewController.prototype._domForNewAndExistingBugs.bugzilla.quickSearch):
  34773. (ViewController.prototype._domForPossiblyFlakyTests.flakyList.appendChildren):
  34774. (ViewController.prototype._domForPossiblyFlakyTests):
  34775. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  34776. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34777. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  34778. 2011-08-01 Adam Barth <abarth@webkit.org>
  34779. garden-o-matic shouldn't require local server to determine if compile failed
  34780. https://bugs.webkit.org/show_bug.cgi?id=65446
  34781. Reviewed by Dimitri Glazkov.
  34782. This patch adds some basic bindings for the buildbot JSON API. I
  34783. wanted to use Buildbot.js an Builder.js from the original TestFailures,
  34784. but they make a number of WebKit-specific assumptions. We'll
  34785. eventually need to reconcile these pieces of code.
  34786. I should really add tests for this code, but that will require me to
  34787. build a better mock network. I'll be happy to do that in a follow-up
  34788. patch.
  34789. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/builders.js: Added.
  34790. - It's very unclear to me whether didFail is correct. Supposedly
  34791. the first entry here is the exit code of the step, which is 0 on
  34792. success. I suspect we'll need to improve this function over time.
  34793. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34794. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34795. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  34796. 2011-08-01 Adam Barth <abarth@webkit.org>
  34797. garden-o-matic should show all failures, even ones that it can't find a regression range for
  34798. https://bugs.webkit.org/show_bug.cgi?id=65447
  34799. Reviewed by Dimitri Glazkov.
  34800. Previously, we just wouldn't display test failures that we couldn't
  34801. identify a regression range for (or whose regression range had fallen
  34802. off the page). This patch just displays them at the end of the list,
  34803. which is slightly (but not much) better.
  34804. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34805. 2011-08-01 Jeff Miller <jeffm@apple.com>
  34806. Windows build fix after r92096.
  34807. * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Use #include, not #import, and don't include Foundation.h.
  34808. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Add InjectedBundleControllerWin.cpp.
  34809. 2011-07-31 Anders Carlsson <andersca@apple.com>
  34810. DownloadDecideDestinationCrash WebKit2 API tests crashes
  34811. https://bugs.webkit.org/show_bug.cgi?id=65442
  34812. Reviewed by Sam Weinig.
  34813. Copy the 18-characters.html file to the destination directory so we won't
  34814. crash trying to make an URL for it.
  34815. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  34816. 2011-07-31 Anders Carlsson <andersca@apple.com>
  34817. Fix SpacebarScrolling WebKit2 API test
  34818. https://bugs.webkit.org/show_bug.cgi?id=65431
  34819. Reviewed by Sam Weinig.
  34820. Add a way to do platform-specific bundle initialization, and use it to disable smooth
  34821. scrolling. Also make it possible for a test to load the injected bundle without actually running
  34822. a test from it.
  34823. * TestWebKitAPI/InjectedBundleController.cpp:
  34824. (TestWebKitAPI::InjectedBundleController::initialize):
  34825. * TestWebKitAPI/InjectedBundleController.h:
  34826. * TestWebKitAPI/PlatformUtilities.cpp:
  34827. (TestWebKitAPI::Util::createContextWithInjectedBundle):
  34828. * TestWebKitAPI/PlatformUtilities.h:
  34829. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  34830. * TestWebKitAPI/Tests/WebKit2/SpacebarScrolling.cpp:
  34831. (TestWebKitAPI::TEST):
  34832. * TestWebKitAPI/mac/InjectedBundleControllerMac.mm: Added.
  34833. (TestWebKitAPI::InjectedBundleController::platformInitialize):
  34834. * TestWebKitAPI/win/InjectedBundleControllerWin.cpp: Added.
  34835. (TestWebKitAPI::InjectedBundleController::platformInitialize):
  34836. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  34837. 2011-07-31 Dimitri Glazkov <dglazkov@chromium.org>
  34838. Use set comparison to find duplicate or overlapping specifiers in test expectations.
  34839. https://bugs.webkit.org/show_bug.cgi?id=65430
  34840. Reviewed by Adam Barth.
  34841. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use set comparisons, because length
  34842. of a set is wrong.
  34843. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Added some unit tests to actually catch
  34844. regressions.
  34845. 2011-07-31 Xan Lopez <xlopez@igalia.com>
  34846. Group dependencies CFLAGS together.
  34847. * GNUmakefile.am: ditto.
  34848. 2011-07-31 Daniel Bates <dbates@webkit.org>
  34849. Attempt to fix the GTK build after <http://trac.webkit.org/changeset/92059>
  34850. (https://bugs.webkit.org/show_bug.cgi?id=65419).
  34851. * GNUmakefile.am: Add $(CAIRO_CFLAGS) to libWebCoreInternals_la_CPPFLAGS.
  34852. 2011-07-30 Patrick Gansterer <paroga@webkit.org>
  34853. Fix ports_unittest.py on native windows
  34854. https://bugs.webkit.org/show_bug.cgi?id=64959
  34855. Reviewed by Adam Barth.
  34856. Replace WebKitPort.script_path with WebKitPort.script_shell_command.
  34857. The latter includes the interpreter executable required on native windows.
  34858. * Scripts/webkitpy/common/config/ports_unittest.py:
  34859. 2011-07-30 Adam Barth <abarth@webkit.org>
  34860. Properly escape regular expressions. (Maybe these shouldn't be regular
  34861. expressions?)
  34862. * Scripts/webkitpy/tool/commands/rebaseline.py:
  34863. 2011-07-30 Adam Barth <abarth@webkit.org>
  34864. Add support for Win7 to garden-o-matic.
  34865. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  34866. * Scripts/webkitpy/tool/commands/rebaseline.py:
  34867. 2011-07-30 Adam Barth <abarth@webkit.org>
  34868. garden-o-matic regression ranges expand after fast bots start passing
  34869. https://bugs.webkit.org/show_bug.cgi?id=65406
  34870. Reviewed by Dimitri Glazkov.
  34871. Once the gardener has fixed a problem, the fast bots pick up the fix,
  34872. which means we end up using the slow bots to compute the regression
  34873. range. Unfortunately, the slow bots give us large regression ranges,
  34874. leading to this strange effect where the regression range quality
  34875. degrades as fixes roll in.
  34876. This patch causes us to remember the previous regression ranges we've
  34877. seen and to use that information in the future, as long as it's
  34878. consistent with the new information we receive.
  34879. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  34880. 2011-07-30 Adam Barth <abarth@webkit.org>
  34881. garden-o-matic should have a Refresh button to update its display
  34882. https://bugs.webkit.org/show_bug.cgi?id=65403
  34883. Reviewed by Dimitri Glazkov.
  34884. The refresh button should be faster and less disruptive than the browser's reload button.
  34885. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  34886. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  34887. 2011-07-30 Adam Barth <abarth@webkit.org>
  34888. garden-o-matic should look for the "patch by" line in revisions ostensibly authored by the commit-queue
  34889. https://bugs.webkit.org/show_bug.cgi?id=65231
  34890. Reviewed by Dimitri Glazkov.
  34891. The human readable name is easier to understand, especially when the patch is landed by the commit-queue.
  34892. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  34893. 2011-07-30 Adam Barth <abarth@webkit.org>
  34894. garden-o-matic should strikeout revisions that have been rolled out
  34895. https://bugs.webkit.org/show_bug.cgi?id=65227
  34896. Reviewed by Dimitri Glazkov.
  34897. This helps gardeners keep track of which problems have been solved.
  34898. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  34899. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  34900. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  34901. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  34902. 2011-07-30 Adam Barth <abarth@webkit.org>
  34903. Add missing files to the server.
  34904. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  34905. 2011-07-29 Adam Barth <abarth@webkit.org>
  34906. Actually import the logging module!
  34907. * Scripts/webkitpy/common/checkout/scm/git.py:
  34908. 2011-07-29 Adam Barth <abarth@webkit.org>
  34909. More debug logging. Maybe we're running the git version of this
  34910. function somehow? (That would explain why it doesn't work!)
  34911. * Scripts/webkitpy/common/checkout/scm/git.py:
  34912. 2011-07-29 Adam Barth <abarth@webkit.org>
  34913. Add some temporary debug logging messages to try to understand why the
  34914. windows bots can't figure out their current SVN revision.
  34915. * Scripts/webkitpy/common/checkout/scm/svn.py:
  34916. 2011-07-29 Adam Barth <abarth@webkit.org>
  34917. Chromium try servers should use downstream test_expectations
  34918. https://bugs.webkit.org/show_bug.cgi?id=65390
  34919. Reviewed by Dirk Pranke.
  34920. Otherwise the try servers will report bogus failures.
  34921. * Scripts/webkitpy/layout_tests/port/chromium.py:
  34922. 2011-07-29 Dimitri Glazkov <dglazkov@chromium.org>
  34923. Fix an error in macro collapsing, refactor code to be pretty.
  34924. https://bugs.webkit.org/show_bug.cgi?id=65387
  34925. My set math was wrong.
  34926. Reviewed by Adam Barth.
  34927. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Moved collapsing into a classmethod, fixed the math to be correct.
  34928. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
  34929. 2011-07-27 Ryuan Choi <ryuan.choi@samsung.com>
  34930. Style bot complains about EFL-specific forward declaration naming.
  34931. https://bugs.webkit.org/show_bug.cgi?id=64680
  34932. Exclude EFL-specific forward declarations from indentifiers with underscores checks.
  34933. Reviewed by Adam Barth.
  34934. * Scripts/webkitpy/style/checkers/cpp.py:
  34935. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  34936. 2011-07-27 Adam Roben <aroben@apple.com>
  34937. Use wacky !svn/bc URLs consistently in Leaks Viewer
  34938. This ensures that any resources loaded via relative URLs will still get pulled from the same
  34939. revision of Subversion.
  34940. Fixes <http://webkit.org/b/65267> Focus/exclude button glyphs don't load on Leaks Viewer
  34941. Reviewed by David Kilzer.
  34942. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Use the
  34943. !svn/bc-style URL for inspector.css, too, just like we do for all other resources we pull
  34944. from Subversion.
  34945. 2011-07-27 Raphael Kubo da Costa <kubo@profusion.mobi>
  34946. [EFL] Drop WorkQueueItemEfl.h in favour of the general WorkQueueItem.h
  34947. https://bugs.webkit.org/show_bug.cgi?id=65269
  34948. Reviewed by Kent Tamura.
  34949. WorkQueueItemEfl.h was being included by efl's
  34950. LayoutTestControllerEfl.cpp, however the top-level
  34951. LayoutTestController still included WorkQueueItem.h, causing a lot of
  34952. type mismatches when running the WorkQueueItem code.
  34953. We can stick to the original WorkQueueItem header by making a few
  34954. changes to EFL's LayoutTestController.
  34955. This should make tests such as
  34956. fast/loader/non-deferred-substitute-load.html stop crashing.
  34957. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
  34958. (LayoutTestController::queueLoad):
  34959. * DumpRenderTree/efl/WorkQueueItemEfl.cpp:
  34960. (LoadItem::invoke):
  34961. (LoadHTMLStringItem::invoke):
  34962. (ScriptItem::invoke):
  34963. * DumpRenderTree/efl/WorkQueueItemEfl.h: Removed.
  34964. 2011-07-27 Dimitri Glazkov <dglazkov@chromium.org>
  34965. Re-add unit tests I accidentally zapped in r91878.
  34966. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Re-added unit tests.
  34967. 2011-07-27 Dimitri Glazkov <dglazkov@chromium.org>
  34968. Replace SpecificityCalculator with TestConfiguration-driven logic.
  34969. https://bugs.webkit.org/show_bug.cgi?id=65206
  34970. Use our newly-acquired ability to expand modifiers into a set of
  34971. matching TestConfiguration instances to calculate specificity and
  34972. determine whether expectation applies to a given test configuration.
  34973. Also, store bug modifier on TestExpectationsLine.
  34974. Reviewed by Adam Barth.
  34975. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
  34976. test configuration matching, removed a bunch of code.
  34977. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
  34978. 2011-07-27 Dimitri Glazkov <dglazkov@chromium.org>
  34979. Allow ports to specify their own test expectation specifier macros.
  34980. https://bugs.webkit.org/show_bug.cgi?id=65291
  34981. Reviewed by Adam Barth.
  34982. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to use port macros.
  34983. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Ditto.
  34984. * Scripts/webkitpy/layout_tests/port/base.py: Added configuration_specifier_macros to retrieve the macros.
  34985. * Scripts/webkitpy/layout_tests/port/chromium.py: Overrode it to return Chromium's macros.
  34986. * Scripts/webkitpy/layout_tests/port/test.py: Added test macros.
  34987. 2011-07-27 Dimitri Glazkov <dglazkov@chromium.org>
  34988. Allow TestConfigurationConverter report conversion errors.
  34989. https://bugs.webkit.org/show_bug.cgi?id=65287
  34990. Also, fix a few miscellaneous testing issues.
  34991. Reviewed by Adam Barth.
  34992. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
  34993. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
  34994. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
  34995. was created. 'default' is not a valid build type.
  34996. * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
  34997. 2011-07-27 Dimitri Glazkov <dglazkov@chromium.org>
  34998. Teach all ports about their test configurations.
  34999. https://bugs.webkit.org/show_bug.cgi?id=65278
  35000. Each Port object should return a valid set of all TestConfiguration instances,
  35001. available for this port.
  35002. Reviewed by Philippe Normand.
  35003. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Removed TestConfiguration.all_test_configurations,
  35004. since it is different for each port.
  35005. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Removed related test.
  35006. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed SpecificityCalculator to take a list of
  35007. all test configurations as a param.
  35008. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted arguments accordingly.
  35009. * Scripts/webkitpy/layout_tests/port/base.py: Forced all ports to override generation of all test configurations.
  35010. * Scripts/webkitpy/layout_tests/port/chromium.py: Implemented _generate_all_test_configurations for the port.
  35011. * Scripts/webkitpy/layout_tests/port/gtk.py: Ditto.
  35012. * Scripts/webkitpy/layout_tests/port/mac.py: Ditto.
  35013. * Scripts/webkitpy/layout_tests/port/qt.py: Ditto.
  35014. * Scripts/webkitpy/layout_tests/port/win.py:
  35015. * Scripts/webkitpy/layout_tests/port/port_testcase.py: Added an extra test to ensure we're generating a good set.
  35016. * Scripts/webkitpy/layout_tests/port/test.py: Implemented a fixed-in-time all_test_configurations for testing.
  35017. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py: Added a mock all_test_configurations implementation.
  35018. * Scripts/webkitpy/layout_tests/port/win_unittest.py: Added a unit test for the port.
  35019. 2011-07-27 Benjamin Poulain <benjamin@webkit.org>
  35020. [WK2][Qt] Move from QGraphicsView to Qt Scene Graph
  35021. https://bugs.webkit.org/show_bug.cgi?id=62969
  35022. Reviewed by Andreas Kling.
  35023. Co-authored with Simon Hausmann <simon.hausmann@nokia.com>
  35024. With the scene graph, the interface to have a window on screen is
  35025. QSGCanvas. QGraphicsView is not used, and openGL is an enforced
  35026. dependency.
  35027. Both the BrowserView and the WebKitTest runner are changed from
  35028. QGraphicsView to QSGCanvas.
  35029. * MiniBrowser/qt/BrowserView.cpp:
  35030. (BrowserView::BrowserView):
  35031. (BrowserView::resizeEvent):
  35032. (BrowserView::view):
  35033. * MiniBrowser/qt/BrowserView.h:
  35034. * MiniBrowser/qt/BrowserWindow.cpp:
  35035. (BrowserWindow::BrowserWindow):
  35036. (BrowserWindow::urlChanged):
  35037. (BrowserWindow::~BrowserWindow):
  35038. * MiniBrowser/qt/BrowserWindow.h:
  35039. * MiniBrowser/qt/MiniBrowser.pro:
  35040. * MiniBrowser/qt/main.cpp:
  35041. (main):
  35042. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  35043. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  35044. (WTR::WebView::WebView):
  35045. (WTR::PlatformWebView::PlatformWebView):
  35046. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  35047. 2011-07-27 Sheriff Bot <webkit.review.bot@gmail.com>
  35048. Unreviewed, rolling out r91792.
  35049. http://trac.webkit.org/changeset/91792
  35050. https://bugs.webkit.org/show_bug.cgi?id=65242
  35051. It broke NRWT on Qt and GTK (Requested by Ossy_night on
  35052. #webkit).
  35053. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  35054. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
  35055. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  35056. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  35057. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  35058. * Scripts/webkitpy/layout_tests/port/test.py:
  35059. 2011-07-26 Adam Barth <abarth@webkit.org>
  35060. Switch to an older idiom that works on Python 2.5.
  35061. * Scripts/webkitpy/layout_tests/models/test_configuration.py:
  35062. 2011-07-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  35063. Add an exception to coding style check for EFL port.
  35064. https://bugs.webkit.org/show_bug.cgi?id=65162
  35065. Add an exception of whitespace/declaration for EFL port. Because,
  35066. '*' operator is next to variable in EFL coding style.
  35067. Reviewed by Kent Tamura.
  35068. * Scripts/webkitpy/style/checker.py:
  35069. 2011-07-26 Keith Kyzivat <keith.kyzivat@nokia.com>
  35070. [Qt] Add option to turn on disk caching in QtTestBrowser
  35071. https://bugs.webkit.org/show_bug.cgi?id=65007
  35072. Reviewed by Noam Rosenthal.
  35073. Add menu item and command line option to turn on disk caching in
  35074. QtTestBrowser. Simple QNetworkDiskCache added to the page's
  35075. QNetworkAccssManager.
  35076. * QtTestBrowser/launcherwindow.cpp:
  35077. (LauncherWindow::initializeView):
  35078. (LauncherWindow::createChrome):
  35079. (LauncherWindow::setDiskCache):
  35080. * QtTestBrowser/launcherwindow.h:
  35081. (WindowOptions::WindowOptions):
  35082. * QtTestBrowser/main.cpp:
  35083. (LauncherApplication::handleUserOptions):
  35084. 2011-07-26 Sadrul Habib Chowdhury <sadrul@chromium.org>
  35085. Add support for download='filename' attribute in anchors.
  35086. https://bugs.webkit.org/show_bug.cgi?id=64580
  35087. Reviewed by Adam Barth.
  35088. * DumpRenderTree/chromium/WebViewHost.cpp:
  35089. (WebViewHost::loadURLExternally):
  35090. * DumpRenderTree/chromium/WebViewHost.h:
  35091. 2011-07-26 Dan Bernstein <mitz@apple.com>
  35092. Rubber-stamped by Anders Carlsson.
  35093. Update DumpRenderTree and API tests for the pictograph font family preference.
  35094. * DumpRenderTree/mac/DumpRenderTree.mm:
  35095. (resetDefaultsToConsistentValues):
  35096. * DumpRenderTree/win/DumpRenderTree.cpp:
  35097. (resetDefaultsToConsistentValues):
  35098. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  35099. (TestWebKitAPI::TEST):
  35100. * WebKitTestRunner/TestController.cpp:
  35101. (WTR::TestController::resetStateToConsistentValues):
  35102. 2011-07-26 Dimitri Glazkov <dglazkov@chromium.org>
  35103. Replace SpecificityCalculator with TestConfiguration-driven logic.
  35104. https://bugs.webkit.org/show_bug.cgi?id=65206
  35105. Use our newly-acquired ability to expand modifiers into a set of
  35106. matching TestConfiguration instances to calculate specificity and
  35107. determine whether expectation applies to a given test configuration.
  35108. Also, store bug modifier on TestExpectationsLine.
  35109. Reviewed by Adam Barth.
  35110. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added a way to report unknown modifier errors.
  35111. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added a test for reporting errors.
  35112. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Replaced the logic of calculating specificity with
  35113. test configuration matching, removed a bunch of code.
  35114. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Removed a bunch of tests that aren't useful anymore.
  35115. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py: Fixed an error where an invalid TestConfiguration instance
  35116. was created. 'default' is not a valid build type.
  35117. * Scripts/webkitpy/layout_tests/port/test.py: Ditto. '' is not a valid version.
  35118. 2011-07-26 Adam Barth <abarth@webkit.org>
  35119. Increase the information density in garden-o-matic
  35120. https://bugs.webkit.org/show_bug.cgi?id=65141
  35121. Reviewed by Dimitri Glazkov.
  35122. This patch changes lets us show each revision on a single line,
  35123. allowing use to show an entire day's worth of commits at once.
  35124. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  35125. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/model.js:
  35126. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  35127. 2011-07-26 Dimitri Glazkov <dglazkov@chromium.org>
  35128. TestConfigurationConverter should not barf on invalid specifiers.
  35129. https://bugs.webkit.org/show_bug.cgi?id=65194
  35130. Reviewed by Adam Barth.
  35131. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Refactored TestConfigurationConverter.to_config_set a bit,
  35132. made it return empty set whenever an invalid specifier is encountered.
  35133. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added corresponding tests.
  35134. 2011-07-26 Dimitri Glazkov <dglazkov@chromium.org>
  35135. Introduce a way to convert between specifier lists and TestConfiguration sets.
  35136. https://bugs.webkit.org/show_bug.cgi?id=65094
  35137. Add TestConfigurationConverter, a facility to convert:
  35138. 1) a set of specifiers into a set of TestConfiguration instances;
  35139. 2) a set of TestConfiguration instances into a list of sets of specifiers.
  35140. Reviewed by Adam Barth.
  35141. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added TestConfigurationConverter.
  35142. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added tests for it.
  35143. 2011-07-26 Alexandru Chiculita <achicu@adobe.com>
  35144. CSS Regions build bot should build with "--css-regions" and "--css-exclusion" flags
  35145. https://bugs.webkit.org/show_bug.cgi?id=65171
  35146. Added "features" parameter in config.json for "builder" objects. The parameter is optional and must be an array. All the items
  35147. of the array will be passed to the build-webkit script. The items will automatically be prefixed with "--".
  35148. Reviewed by Adam Roben.
  35149. * BuildSlaveSupport/build.webkit.org-config/config.json:
  35150. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  35151. 2011-07-26 Chris Rogers <crogers@google.com>
  35152. Avoid outputting #EOF twice for web audio tests in chromium DRT
  35153. https://bugs.webkit.org/show_bug.cgi?id=65201
  35154. Reviewed by Dirk Pranke.
  35155. * DumpRenderTree/chromium/TestShell.cpp:
  35156. (TestShell::dump):
  35157. 2011-07-26 Adam Barth <abarth@webkit.org>
  35158. Windows bots on build.chromium.org can't figure out the head_svn_revision
  35159. https://bugs.webkit.org/show_bug.cgi?id=65156
  35160. Reviewed by Tony Chang.
  35161. This patch is a bit of a guess as to the issue based on the
  35162. investigation in https://bugs.webkit.org/show_bug.cgi?id=65148. I'm
  35163. not sure whether it will fix the issue, but it seems worth a try.
  35164. * Scripts/webkitpy/common/checkout/scm/svn.py:
  35165. 2011-07-26 Carlos Garcia Campos <cgarcia@igalia.com>
  35166. Unreviewed. Fix WebKitGtk build with GTK+ 3.x after r91707.
  35167. * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp:
  35168. (getPreferredSizeMethod):
  35169. 2011-07-26 MORITA Hajime <morrita@google.com>
  35170. [Chromium][DRT] MockSpellCheck.cpp should be clang clean
  35171. https://bugs.webkit.org/show_bug.cgi?id=65166
  35172. Reviewed by Kent Tamura.
  35173. * DumpRenderTree/chromium/MockSpellCheck.cpp:
  35174. (MockSpellCheck::spellCheckWord): -Wsign-compare warning.
  35175. 2011-07-25 Patrick Gansterer <paroga@webkit.org>
  35176. Ignore line endings in ChangeLogTests
  35177. https://bugs.webkit.org/show_bug.cgi?id=64956
  35178. Reviewed by Adam Barth.
  35179. Split the lines of the ChangeLog text before comparing them.
  35180. This fixes 3 tests on windows, since only the content importent.
  35181. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  35182. * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:
  35183. 2011-07-25 Adam Barth <abarth@webkit.org>
  35184. Add some debug logging to NRWT to diagnose why the windows bots can't determine their SVN revision
  35185. https://bugs.webkit.org/show_bug.cgi?id=65148
  35186. Reviewed by Tony Chang.
  35187. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  35188. 2011-07-25 Ojan Vafai <ojan@chromium.org>
  35189. Tweak whitespace wrapping to improve readability.
  35190. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35191. 2011-07-25 Ojan Vafai <ojan@chromium.org>
  35192. Minor tweak to wrap label elements as atomic units.
  35193. * TestResultServer/static-dashboards/dashboard_base.js:
  35194. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35195. 2011-07-25 Ojan Vafai <ojan@chromium.org>
  35196. always show flakiness details on the builder page
  35197. https://bugs.webkit.org/show_bug.cgi?id=65139
  35198. Reviewed by Tony Chang.
  35199. In order to simplify the UI, we hide the flakiness details by default,
  35200. but there's no actual use-case for this page without the flakiness details.
  35201. So get rid of that option and always show the flakiness details.
  35202. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35203. 2011-07-25 Ojan Vafai <ojan@chromium.org>
  35204. simplify the UI of the header above the test list table
  35205. https://bugs.webkit.org/show_bug.cgi?id=65136
  35206. Reviewed by Adam Barth.
  35207. Use checkboxes instead of links since this is really about which tests to include.
  35208. Ends up using less text and put the checkboxes to the right of the header instead of below it.
  35209. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35210. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35211. 2011-07-25 Chris Rogers <crogers@google.com>
  35212. Update new-run-webkit-tests to accomodate binary audio data
  35213. https://bugs.webkit.org/show_bug.cgi?id=65135
  35214. Reviewed by Dirk Pranke.
  35215. * Scripts/webkitpy/layout_tests/port/chromium.py:
  35216. 2011-07-25 Chris Rogers <crogers@google.com>
  35217. Update Chromium DRT to output binary (instead of base64-encoded) data for web audio testing
  35218. https://bugs.webkit.org/show_bug.cgi?id=65039
  35219. Reviewed by Tony Chang.
  35220. * DumpRenderTree/chromium/LayoutTestController.cpp:
  35221. (LayoutTestController::LayoutTestController):
  35222. (LayoutTestController::setAudioData):
  35223. * DumpRenderTree/chromium/LayoutTestController.h:
  35224. (LayoutTestController::audioData):
  35225. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  35226. (DRTPrinter::handleAudioHeader):
  35227. (TestShellPrinter::handleAudioHeader):
  35228. * DumpRenderTree/chromium/TestShell.cpp:
  35229. (TestShell::dump):
  35230. 2011-06-07 Martin Robinson <mrobinson@igalia.com>
  35231. Reviewed by Gustavo Noronha Silva.
  35232. [GTK] Use WebCore scrollbars for the DRT instead of GtkScrolledWindow
  35233. https://bugs.webkit.org/show_bug.cgi?id=62252
  35234. Add a new subclass of WebKitWebView that overrides the size request to
  35235. return 1 pixel by 1 pixel. This ensure that it operates properly when
  35236. not packed into a GtkScrolledWindow. Also construct the WebKitWebView
  35237. with self-scrolling set to true.
  35238. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  35239. (webInspectorInspectWebView): Use the new SelfScrollingWebKitWebview class here.
  35240. (createWebView): Ditto.
  35241. (main): Pack the widget into a GtkBox instead of a GtkScrolledWindow.
  35242. * DumpRenderTree/gtk/SelfScrollingWebKitWebView.cpp: Added.
  35243. (self_scrolling_webkit_web_view_class_init):
  35244. (self_scrolling_webkit_web_view_init):
  35245. (self_scrolling_webkit_web_view_new):
  35246. (sizeRequestMethod):
  35247. (getPreferredSizeMethod):
  35248. * DumpRenderTree/gtk/SelfScrollingWebKitWebView.h: Added.
  35249. * GNUmakefile.am: Added SelfScrollingWebKitWebView files to the source list.
  35250. 2011-07-25 Ojan Vafai <ojan@chromium.org>
  35251. by default hide tests that have passes for all recorded runs
  35252. https://bugs.webkit.org/show_bug.cgi?id=65127
  35253. Reviewed by Adam Barth.
  35254. This is part of simplifying the default views of the dashboard to
  35255. make it show less information for the common use cases.
  35256. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35257. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35258. 2011-07-25 Ojan Vafai <ojan@chromium.org>
  35259. stop generating expectations.json now that it's unused
  35260. https://bugs.webkit.org/show_bug.cgi?id=65130
  35261. Reviewed by Adam Barth.
  35262. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  35263. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  35264. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  35265. * TestResultServer/handlers/menu.py:
  35266. * TestResultServer/static-dashboards/dashboard_base.js:
  35267. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35268. 2011-07-25 Ojan Vafai <ojan@chromium.org>
  35269. don't show builders in the flakiness dashboard that have stopped running a given test suite
  35270. https://bugs.webkit.org/show_bug.cgi?id=65126
  35271. Reviewed by Mihai Parparita.
  35272. * TestResultServer/static-dashboards/dashboard_base.js:
  35273. 2011-07-25 Adam Barth <abarth@webkit.org>
  35274. Overhaul garden-o-matic frontend to integrate revision history and failures
  35275. https://bugs.webkit.org/show_bug.cgi?id=65089
  35276. Reviewed by Dimitri Glazkov.
  35277. This is a major overhaul of the garden-o-matic frontend. The new UI
  35278. integrates the revision history information with failures. Failures
  35279. appear in context adjacent to the revisions that caused them (which are
  35280. highlighted). Each buildbot receives a collumn to the left, which
  35281. indicates which revisions that bot has tested and whether that bot
  35282. showed the indicated failures.
  35283. Failures are selectable with checkboxes, and can then either be
  35284. examined or rebaselined.
  35285. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  35286. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  35287. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  35288. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  35289. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  35290. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  35291. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js:
  35292. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  35293. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  35294. 2011-07-25 Holger Hans Peter Freyther <zecke@selfish.org>
  35295. [buildbot] Add Qt Linux MIPSEL Configuration
  35296. https://bugs.webkit.org/show_bug.cgi?id=65116
  35297. Reviewed by Adam Roben.
  35298. Introduce a Qt Linux MIPS EL build slave. The configuration
  35299. is a build only configuration.
  35300. * BuildSlaveSupport/build.webkit.org-config/config.json: Add MIPS buildbot.
  35301. 2011-07-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
  35302. [Qt][WK2] Add multi-point touch mocking to MiniBrowser
  35303. https://bugs.webkit.org/show_bug.cgi?id=64374
  35304. Reviewed by Benjamin Poulain.
  35305. Each mouse button generate a touch point. The touch point stay
  35306. virtually on screen if the mouse release happened while the Ctrl
  35307. modifier was pressed.
  35308. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  35309. (MiniBrowserApplication::notify):
  35310. * MiniBrowser/qt/MiniBrowserApplication.h:
  35311. 2011-07-25 Balazs Kelemen <kbalazs@webkit.org>
  35312. [Qt][WK2] Use NRWT for Qt-WK2
  35313. https://bugs.webkit.org/show_bug.cgi?id=65097
  35314. Reviewed by Andreas Kling.
  35315. * Scripts/run-webkit-tests:
  35316. (useNewRunWebKitTests):
  35317. 2011-07-24 Sheriff Bot <webkit.review.bot@gmail.com>
  35318. Unreviewed, rolling out r91635.
  35319. http://trac.webkit.org/changeset/91635
  35320. https://bugs.webkit.org/show_bug.cgi?id=65083
  35321. It broke the minimal build (Requested by Ossy___OFFLINE on
  35322. #webkit).
  35323. * QtTestBrowser/launcherwindow.cpp:
  35324. (LauncherWindow::initializeView):
  35325. (LauncherWindow::createChrome):
  35326. * QtTestBrowser/launcherwindow.h:
  35327. (WindowOptions::WindowOptions):
  35328. * QtTestBrowser/main.cpp:
  35329. (LauncherApplication::handleUserOptions):
  35330. 2011-07-24 Adam Barth <abarth@webkit.org>
  35331. Rename garden-o-matic "alert" to "infobar" and increase the width to 100%.
  35332. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  35333. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  35334. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  35335. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  35336. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  35337. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js:
  35338. 2011-07-23 Dimitri Glazkov <dglazkov@chromium.org>
  35339. TestConfiguration should be hashable and comparable for equality.
  35340. https://bugs.webkit.org/show_bug.cgi?id=65070
  35341. Reviewed by Adam Barth.
  35342. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added __hash__ and __eq__ methods.
  35343. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added unit tests.
  35344. 2011-07-23 Dimitri Glazkov <dglazkov@chromium.org>
  35345. Extract TestConfiguration from base and write a few unit tests to capture current behavior.
  35346. https://bugs.webkit.org/show_bug.cgi?id=65066
  35347. Reviewed by Adam Barth.
  35348. * Scripts/webkitpy/layout_tests/models/test_configuration.py: Added.
  35349. * Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py: Added.
  35350. * Scripts/webkitpy/layout_tests/port/base.py: Moved code to test_configuration.py
  35351. 2011-07-23 Alok Priyadarshi <alokp@chromium.org>
  35352. Switching off acceleration for small canvas broke gpu tests
  35353. https://bugs.webkit.org/show_bug.cgi?id=65053
  35354. Reviewed by Stephen White.
  35355. * DumpRenderTree/chromium/WebPreferences.cpp:
  35356. (WebPreferences::reset):
  35357. (WebPreferences::applyTo):
  35358. * DumpRenderTree/chromium/WebPreferences.h:
  35359. 2011-07-23 Keith Kyzivat <keith.kyzivat@nokia.com>
  35360. [Qt] Add option to turn on disk caching in QtTestBrowser
  35361. https://bugs.webkit.org/show_bug.cgi?id=65007
  35362. Reviewed by Noam Rosenthal.
  35363. Add menu item and command line option to turn on disk caching in
  35364. QtTestBrowser. Simple QNetworkDiskCache added to the page's
  35365. QNetworkAccssManager.
  35366. * QtTestBrowser/launcherwindow.cpp:
  35367. (LauncherWindow::initializeView):
  35368. (LauncherWindow::createChrome):
  35369. (LauncherWindow::setDiskCache):
  35370. * QtTestBrowser/launcherwindow.h:
  35371. (WindowOptions::WindowOptions):
  35372. * QtTestBrowser/main.cpp:
  35373. (LauncherApplication::handleUserOptions):
  35374. 2011-07-22 Ojan Vafai <ojan@chromium.org>
  35375. Don't match 'DEBUG' when trying to filter BUG modifiers.
  35376. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35377. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35378. 2011-07-22 Ojan Vafai <ojan@chromium.org>
  35379. Fix issue loading gtests since there's no g_expectations.
  35380. Also, make filing a bug file a webkit.org bug, not a crbug since
  35381. the link is only shown for layout tests.
  35382. * TestResultServer/static-dashboards/dashboard_base.js:
  35383. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35384. 2011-07-22 Ojan Vafai <ojan@chromium.org>
  35385. pull test expectations into the dashboard from wvn.webkit.org
  35386. https://bugs.webkit.org/show_bug.cgi?id=65054
  35387. Reviewed by Adam Barth.
  35388. Now that svn.webkit.org supports cors headers, we can just grab the txt
  35389. file from there instead of generating a JSON file that we upload
  35390. to appengine. We'll stop generating the JSON file in a followup patch.
  35391. * TestResultServer/static-dashboards/dashboard_base.js:
  35392. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35393. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35394. 2011-07-22 Adam Barth <abarth@webkit.org>
  35395. Fix typo so the tool works on a case-sensitive file system.
  35396. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  35397. 2011-07-22 Adam Barth <abarth@webkit.org>
  35398. garden-o-matic should know what patches are landing
  35399. https://bugs.webkit.org/show_bug.cgi?id=64978
  35400. Reviewed by Dimitri Glazkov.
  35401. This patch adds a display of the recently committed patches to
  35402. garden-o-matic. The UI needs iteration, but this patch establishes the
  35403. plumbing.
  35404. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  35405. - Teach trac how to extract more information from the commit log.
  35406. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  35407. - Add a data attribute for storing the revision.
  35408. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  35409. - Add a container for the recent commit history.
  35410. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css:
  35411. - CSS for displaying non-ugly commit history.
  35412. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js:
  35413. - Wire up trac to the UI container.
  35414. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js:
  35415. - A basic, compact display for a list of commits.
  35416. 2011-07-22 Ojan Vafai <ojan@chromium.org>
  35417. Fix bug when switching from layout-tests to another test-type if
  35418. ToT webkit.org is the selected group.
  35419. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35420. 2011-07-22 Ojan Vafai <ojan@chromium.org>
  35421. Add back in line accidentally deleted in http://trac.webkit.org/changeset/91612.
  35422. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35423. 2011-07-22 Ojan Vafai <ojan@chromium.org>
  35424. simplify the flakiness dashboard to only show modifiers/expectations for the current builder
  35425. https://bugs.webkit.org/show_bug.cgi?id=65049
  35426. Reviewed by Tony Chang.
  35427. This communicates less information, but probably makes the dashboard more usable.
  35428. Also make it show that bug lines that don't point to bug numbers still
  35429. show up in the bugs column (e.g. BUG_TONY) and stop showing the extra/missing
  35430. columns in any view. The data is still used, but only in the view that updates
  35431. the test_expectations.txt file.
  35432. * TestResultServer/static-dashboards/dashboard_base.js:
  35433. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35434. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35435. 2011-07-21 Ojan Vafai <ojan@chromium.org>
  35436. hook in the rest of the bots to the dashboard now they run NRWT
  35437. https://bugs.webkit.org/show_bug.cgi?id=64985
  35438. Reviewed by Adam Barth.
  35439. * TestResultServer/static-dashboards/builders.js:
  35440. 2011-07-22 Alexey Proskuryakov <ap@apple.com>
  35441. Adding Tim Horton to contributor list for Bugzilla auto-completion. He is CC'ed quite frequently.
  35442. Unreviewed.
  35443. * Scripts/webkitpy/common/config/committers.py:
  35444. 2011-07-22 Michal Pakula vel Rutka <m.pakula@samsung.com>
  35445. [EFL] ewk_frame_hit_test_new enchancement
  35446. https://bugs.webkit.org/show_bug.cgi?id=64260
  35447. Apply changes done in ewk_frame_hit_test_new in EWebLauncher:
  35448. Replacing Ewk_Hit_Test_Result_Context structure 'flags'
  35449. in hit test output to by enum 'context'.
  35450. Reviewed by Antonio Gomes.
  35451. * EWebLauncher/main.c:
  35452. (on_key_down):
  35453. 2011-07-21 Adam Roben <aroben@apple.com>
  35454. Fix typo in TestFailures
  35455. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  35456. 2011-07-21 Ojan Vafai <ojan@chromium.org>
  35457. simplify gtest display now that we strip modifiers from the JSON
  35458. https://bugs.webkit.org/show_bug.cgi?id=64990
  35459. Reviewed by Adam Barth.
  35460. Now that names are normalized, we can remove all the code that
  35461. handles gtest name changes (e.g. for adding modifiers like DISABLED_).
  35462. Instead, if you try to list a test with a modifier in it, we need
  35463. to strip the modifier so we get the normalized value.
  35464. We also get rid of the concept of extra/missing expectations for gtests.
  35465. In a patch soon, we'll stop showing extra/missing expectations from the UI
  35466. entirely and only leave it for the special updating test_expectations.txt
  35467. view of the dashboard, which doesn't apply to gtests.
  35468. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35469. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35470. 2011-07-21 Adam Barth <abarth@webkit.org>
  35471. Refactor Trac.js for use in garden-o-matic
  35472. https://bugs.webkit.org/show_bug.cgi?id=64998
  35473. Reviewed by Adam Roben.
  35474. This patch refactors Trac.js to match the architecture and style of
  35475. garden-o-matic. I've also factored AsynchronousCache out of Trac (and
  35476. moved it to base) because it was redundant with some other code we
  35477. already had.
  35478. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
  35479. (FailingTestsBugForm):
  35480. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  35481. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  35482. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  35483. (ViewController.prototype._displayBuilder.start):
  35484. (ViewController.prototype._displayBuilder):
  35485. (ViewController.prototype._domForRegressionRange.trac.getCommitDataForRevisionRange):
  35486. (ViewController.prototype._domForRegressionRange):
  35487. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js:
  35488. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js:
  35489. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html:
  35490. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js:
  35491. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  35492. 2011-07-21 Ojan Vafai <ojan@chromium.org>
  35493. Fix issue throwing a 500 to the bots. We were modifying
  35494. the dictionary during an iteration over it's keys and would get
  35495. RuntimeError: dictionary changed size during iteration
  35496. * TestResultServer/model/jsonresults.py:
  35497. 2011-07-21 Adam Barth <abarth@webkit.org>
  35498. ORWT fails to consume some NRWT arguments
  35499. https://bugs.webkit.org/show_bug.cgi?id=64988
  35500. Reviewed by Adam Roben.
  35501. * Scripts/old-run-webkit-tests:
  35502. 2011-07-21 Adam Barth <abarth@webkit.org>
  35503. Merge TestFailures and garden-o-matic unit tests harness
  35504. https://bugs.webkit.org/show_bug.cgi?id=64984
  35505. Reviewed by Adam Roben.
  35506. One unit testing framework is better than two.
  35507. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Removed.
  35508. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  35509. 2011-07-21 Adam Barth <abarth@webkit.org>
  35510. Rubber-stamped by Adam Roben.
  35511. Move garden-o-matic files into the same directory as TestFailures to
  35512. make it easier to integrate the codebases.
  35513. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base.js.
  35514. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/base_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js.
  35515. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js.
  35516. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/checkout_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js.
  35517. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/config.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/config.js.
  35518. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-green.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png.
  35519. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/favicon-red.png: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png.
  35520. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/index.html.
  35521. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.css: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.css.
  35522. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/main.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/main.js.
  35523. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/partytime.gif: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif.
  35524. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results.js.
  35525. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/results_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js.
  35526. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-more-unittests.html: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html.
  35527. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js.
  35528. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ui_unittests.js: Copied from Tools/Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js.
  35529. * Scripts/webkitpy/tool/commands/abstractlocalservercommand.py:
  35530. * Scripts/webkitpy/tool/commands/gardenomatic.py:
  35531. * Scripts/webkitpy/tool/servers/data/gardeningserver: Removed.
  35532. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Removed.
  35533. * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Removed.
  35534. * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Removed.
  35535. * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Removed.
  35536. * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Removed.
  35537. * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Removed.
  35538. * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Removed.
  35539. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Removed.
  35540. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Removed.
  35541. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Removed.
  35542. * Scripts/webkitpy/tool/servers/data/gardeningserver/partytime.gif: Removed.
  35543. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Removed.
  35544. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Removed.
  35545. * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Removed.
  35546. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Removed.
  35547. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Removed.
  35548. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  35549. 2011-07-19 Ojan Vafai <ojan@chromium.org>
  35550. fix links on the flakiness dashboard
  35551. https://bugs.webkit.org/show_bug.cgi?id=64832
  35552. Reviewed by Tony Chang.
  35553. Make them actual anchor tags and linkify the test name instead of
  35554. adding an extra link. Also simplify the update view since we now
  35555. show the linkified test name.
  35556. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35557. 2011-07-21 Adam Barth <abarth@webkit.org>
  35558. webkit.org builders should upload results to test-results AppEngine instance
  35559. https://bugs.webkit.org/show_bug.cgi?id=64979
  35560. Reviewed by Adam Roben.
  35561. The master just needs to pass some flags to NRWT. This patch also lets
  35562. ORWT consume the flags (ignoring them) so we can pass the flags
  35563. unconditionally.
  35564. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  35565. * Scripts/old-run-webkit-tests:
  35566. 2011-07-21 Ojan Vafai <ojan@chromium.org>
  35567. normalize gtest names in the result json
  35568. https://bugs.webkit.org/show_bug.cgi?id=64971
  35569. Reviewed by Eric Seidel.
  35570. This will make the resulting JSON smaller and make the
  35571. flakiness dashboard much more sane (e.g. we won't need to
  35572. show you the FLAKY_ version and the normal version).
  35573. * TestResultServer/model/jsonresults.py:
  35574. * TestResultServer/model/jsonresults_unittest.py:
  35575. 2011-07-21 Eric Seidel <eric@webkit.org>
  35576. Unreviewed. Reenable ORWT for the --leaks bot.
  35577. Something is still wrong with the leaks summarizing
  35578. but I'm about to head out on vacation for 2 weeks,
  35579. so it's best to just revert back to ORWT until I'm back.
  35580. * Scripts/run-webkit-tests:
  35581. (usingLeaks):
  35582. (useNewRunWebKitTests):
  35583. 2011-07-21 Ojan Vafai <ojan@chromium.org>
  35584. cleanup jsonresults.py style in preparation for making some changes
  35585. https://bugs.webkit.org/show_bug.cgi?id=64968
  35586. Reviewed by Adam Barth.
  35587. No code changes. Unittest still passes. Mostly just removing
  35588. useless comments and 80 character wrapping.
  35589. * TestResultServer/model/jsonresults.py:
  35590. * TestResultServer/model/jsonresults_unittest.py:
  35591. 2011-07-21 Adam Barth <abarth@webkit.org>
  35592. Add missing column header.
  35593. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  35594. 2011-07-21 Eric Seidel <eric@webkit.org>
  35595. Unreviewed. Just fixing (and unittesting) a previous typo.
  35596. Fix typo in print_leaks_summary regexp which was causing
  35597. leaks summarizing to fail on the --leaks bot.
  35598. * Scripts/webkitpy/layout_tests/port/mac.py:
  35599. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  35600. 2011-07-21 Adam Barth <abarth@webkit.org>
  35601. garden-o-matic should be able to rebaseline many tests at once
  35602. https://bugs.webkit.org/show_bug.cgi?id=64963
  35603. Reviewed by Dimitri Glazkov.
  35604. This patch contains some UI for rebaselining tests in bulk. I don't
  35605. expect this UI to be the final UI, but the underlying infrastructure
  35606. will be useful.
  35607. * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
  35608. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  35609. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  35610. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  35611. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  35612. 2011-07-21 Adam Barth <abarth@webkit.org>
  35613. garden-o-matic has trouble when the same test fails in different ways on diffrent bots
  35614. https://bugs.webkit.org/show_bug.cgi?id=64830
  35615. Unreviewed. (Missing the patch is blocking me from fixing the tree.)
  35616. This patch is just some minor bug fixes. One of the bugs results from
  35617. the sadness of having two representations (a list and a space-separated
  35618. string) for the set of failure types.
  35619. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  35620. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  35621. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  35622. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  35623. 2011-07-20 Ryosuke Niwa <rniwa@webkit.org>
  35624. Buildbot marks a nrwt bot red when tests are missing results
  35625. https://bugs.webkit.org/show_bug.cgi?id=64812
  35626. Reviewed by Adam Barth.
  35627. The bug was caused by multiple expressions matching on the single output.
  35628. Fixed it by exiting the loop as soon as one expression matches.
  35629. Because the regular expression for 'failures' is most general,
  35630. moved it to the end of the list to avoid it catching other cases.
  35631. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  35632. 2011-07-20 Chang Shu <cshu@webkit.org>
  35633. Adding myself to the reviewers list; No review needed.
  35634. * Scripts/webkitpy/common/config/committers.py:
  35635. 2011-07-20 Eric Seidel <eric@webkit.org>
  35636. new-run-webkit-tests --leaks does not restart DumpRenderTree often enough
  35637. https://bugs.webkit.org/show_bug.cgi?id=64912
  35638. Reviewed by Adam Barth.
  35639. The bug was that set_default_option only works if the option's value
  35640. is "None". So I fixed --batch-size to default to None instead of 0
  35641. (which kinda makes sense).
  35642. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  35643. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  35644. 2011-07-20 Eric Seidel <eric@webkit.org>
  35645. Make kill-old-processes kill httpd on mac
  35646. https://bugs.webkit.org/show_bug.cgi?id=64898
  35647. Reviewed by Adam Barth.
  35648. * BuildSlaveSupport/kill-old-processes:
  35649. - The line endings seem to have flipped again,
  35650. Thus making this diff gigantic. The only line
  35651. changed is the "httpd" line. I suspect we'll need
  35652. to set the line ending style from an svn checkout.
  35653. 2011-07-20 Ojan Vafai <ojan@chromium.org>
  35654. show a list of average test times in the treemap
  35655. https://bugs.webkit.org/show_bug.cgi?id=64899
  35656. Reviewed by Adam Roben.
  35657. For now, you click a link and it replaces the treemap
  35658. with a reverse sorted list of directories based on
  35659. average test runtime within that directory.
  35660. To cut some of the noise, we don't show directories
  35661. that only have one test in them or where the average
  35662. runtime is less than 100ms.
  35663. * TestResultServer/static-dashboards/treemap.html:
  35664. 2011-07-20 Eric Seidel <eric@webkit.org>
  35665. Teach build.webkit.org how to identify leaks in NRWT output
  35666. https://bugs.webkit.org/show_bug.cgi?id=64891
  35667. Reviewed by Adam Barth.
  35668. This was the last remaining piece blocking turning on
  35669. NRWT for the leaks bot, so I did that in this change too.
  35670. If for some reason we see trouble on the bots, I'll
  35671. revert that part of this change.
  35672. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  35673. * Scripts/run-webkit-tests:
  35674. 2011-07-20 Ojan Vafai <ojan@chromium.org>
  35675. make the treemap display more human friendly
  35676. https://bugs.webkit.org/show_bug.cgi?id=64896
  35677. Reviewed by Tony Chang.
  35678. * TestResultServer/static-dashboards/treemap.html:
  35679. 2011-07-20 Eric Seidel <eric@webkit.org>
  35680. Move HttpLock to using a FileSystem object
  35681. https://bugs.webkit.org/show_bug.cgi?id=64885
  35682. Reviewed by Adam Barth.
  35683. I made a typo in my previous change, taking the value
  35684. of read_text_file(pid_file) and setting it to lock_pid_file
  35685. instead of current_pid. Fixed now. :)
  35686. In order to test my new change I had to overhaul the unittests
  35687. for this class to create a separate set of tests which work off
  35688. of Mock objects instead of the real filesystem.
  35689. Since Executive doesn't yet wrap os.getpid() I added a FIXME
  35690. in several places where we're currently calling os.getpid(). I
  35691. felt adding Executive.getpid was outside of the scope of this change
  35692. but once it exists some of this code will be much simpler to mock.
  35693. * Scripts/webkitpy/layout_tests/port/http_lock.py:
  35694. * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  35695. * Scripts/webkitpy/tool/mocktool.py:
  35696. 2011-07-20 Adam Roben <aroben@apple.com>
  35697. Fix typo in TestFailures's Bugzilla constants
  35698. This was preventing the "Version" field from being pre-filled when filing new bugs.
  35699. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
  35700. 2011-07-20 Eric Seidel <eric@webkit.org>
  35701. Move HttpLock to using a FileSystem object
  35702. https://bugs.webkit.org/show_bug.cgi?id=64885
  35703. Reviewed by Adam Barth.
  35704. There is no functional change here. Just moving off
  35705. of direct os.foo calls to their filesystem equivalent.
  35706. This makes it possible to now unittest HttpLock using a
  35707. MockFileSystem instead of needing to talk to the filesystem directly.
  35708. This also will have changed any port test cases which were using a
  35709. mock file system to now have an HttpLock based on a mock filesystem
  35710. instead. I saw no change in the unittests so it's possible
  35711. we're not testing that configuration (or more likely that it "just works").
  35712. * Scripts/webkitpy/layout_tests/port/base.py:
  35713. * Scripts/webkitpy/layout_tests/port/http_lock.py:
  35714. * Scripts/webkitpy/layout_tests/port/http_lock_unittest.py:
  35715. 2011-07-20 Adam Barth <abarth@webkit.org>
  35716. NRWT results uses too much space per run
  35717. https://bugs.webkit.org/show_bug.cgi?id=64845
  35718. Reviewed by Ojan Vafai.
  35719. Removing these files saves about 750K per build.
  35720. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  35721. 2011-07-20 Zan Dobersek <zandobersek@gmail.com>
  35722. [Gtk] [NRWT] Xvfb produces a lot of stderr output
  35723. https://bugs.webkit.org/show_bug.cgi?id=64669
  35724. Reviewed by Philippe Normand.
  35725. Redirect the stderr output of the driver's Xvfb process
  35726. to /dev/null to suppress unneeded output.
  35727. * Scripts/webkitpy/layout_tests/port/gtk.py:
  35728. 2011-07-19 Eric Seidel <eric@webkit.org>
  35729. parse-malloc-history always exits 1, causing NRWT to fail
  35730. https://bugs.webkit.org/show_bug.cgi?id=64835
  35731. Reviewed by Adam Barth.
  35732. ORWT just never checked the return code. :)
  35733. * Scripts/parse-malloc-history:
  35734. (main):
  35735. * Scripts/webkitpy/layout_tests/port/mac.py:
  35736. 2011-07-19 Kevin Ollivier <kevino@theolliviers.com>
  35737. [wx] Unreviewed build fix, don't add the debug prefix as 2.9 no longer uses one.
  35738. * waf/build/wxpresets.py:
  35739. 2011-07-19 Eric Seidel <eric@webkit.org>
  35740. new-run-webkit-tests should only enable MallocStackLogging for DRT
  35741. https://bugs.webkit.org/show_bug.cgi?id=64792
  35742. Reviewed by Adam Barth.
  35743. The previous code would enable it for all servers launched
  35744. by the port, which included Apache, the python websocket server
  35745. as well as ImageDiff. Now only DumpRenderTree will have
  35746. MallocStackLogging enabled or the GuardMalloc library injected.
  35747. I also cleaned up the websocket_server code to use filesystem
  35748. while I was in it.
  35749. I also made DRT restart every 1000 tests when running with
  35750. --leaks enabled. I believe this made the --leaks run slightly
  35751. faster, but it still takes over an hour on my machine. :(
  35752. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  35753. * Scripts/webkitpy/layout_tests/port/base.py:
  35754. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  35755. * Scripts/webkitpy/layout_tests/port/gtk.py:
  35756. * Scripts/webkitpy/layout_tests/port/mac.py:
  35757. * Scripts/webkitpy/layout_tests/port/qt.py:
  35758. * Scripts/webkitpy/layout_tests/port/server_process.py:
  35759. * Scripts/webkitpy/layout_tests/port/webkit.py:
  35760. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  35761. * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  35762. 2011-07-19 Ojan Vafai <ojan@chromium.org>
  35763. remove the concept of platform fallbacks
  35764. https://bugs.webkit.org/show_bug.cgi?id=64829
  35765. Reviewed by Adam Barth.
  35766. In the process, wrote tests for this code and fixed a pretty major
  35767. bug (now covered by the test).
  35768. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35769. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35770. 2011-07-19 Ojan Vafai <ojan@chromium.org>
  35771. cleanup some of the PLATFORM logic in the flakiness dashboard
  35772. https://bugs.webkit.org/show_bug.cgi?id=64821
  35773. Reviewed by Adam Barth.
  35774. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35775. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35776. 2011-07-19 Ojan Vafai <ojan@chromium.org>
  35777. cleanup some of the PLATFORM logic in the flakiness dashboard
  35778. https://bugs.webkit.org/show_bug.cgi?id=64821
  35779. Reviewed by Adam Barth.
  35780. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35781. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35782. 2011-07-19 Dimitri Glazkov <dglazkov@chromium.org>
  35783. Store line number on TestExpectationLine.
  35784. https://bugs.webkit.org/show_bug.cgi?id=64800
  35785. Reviewed by Adam Barth.
  35786. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored to store line number on TestExpectationLine instances.
  35787. 2011-07-19 Ojan Vafai <ojan@chromium.org>
  35788. fix flakiness dashboard for XP bots with XP in the name instead of WIN
  35789. https://bugs.webkit.org/show_bug.cgi?id=64826
  35790. Reviewed by Mihai Parparita.
  35791. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  35792. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  35793. 2011-07-19 Cary Clark <caryclark@google.com>
  35794. add myself to committers.py
  35795. https://bugs.webkit.org/show_bug.cgi?id=64816
  35796. No review needed.
  35797. * Scripts/webkitpy/common/config/committers.py:
  35798. 2011-07-19 Daniel Bates <dbates@webkit.org>
  35799. Rename variable isEmptyTextPatch in svn-{apply, unapply}
  35800. https://bugs.webkit.org/show_bug.cgi?id=64648
  35801. Reviewed by Adam Roben.
  35802. Rename the variable isEmptyTextPatch to hasTextChunks, which is
  35803. more descriptive and makes its usage read well in control statements.
  35804. * Scripts/svn-apply:
  35805. (patch):
  35806. * Scripts/svn-unapply:
  35807. (patch):
  35808. 2011-07-19 Adam Roben <aroben@apple.com>
  35809. Make TestFailures show existing bugs and a new bug link for flaky tests
  35810. Fixes <http://webkit.org/b/63728> TestFailures page should make it easy to file bugs about
  35811. flaky tests
  35812. and
  35813. <http://webkit.org/b/63830> TestFailures page doesn't show related bugs for possibly-flaky
  35814. tests, but should
  35815. Reviewed by Sam Weinig.
  35816. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm.js:
  35817. Added. This is what's used to file new bugs about flaky tests.
  35818. (FlakyTestBugForm): Calls up to the base class, stores the arguments, and sets our
  35819. title, description, and URL.
  35820. (FlakyTestBugForm.prototype._createBugDescription):
  35821. (FlakyTestBugForm.prototype._createBugTitle):
  35822. These do what they say.
  35823. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyTestBugForm_unittests.js:
  35824. Added. Tests of the above.
  35825. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  35826. (#failure-history > li):
  35827. (#possibly-flaky-tests > li):
  35828. (#failure-history > li, #possibly-flaky-tests > li):
  35829. (#possibly-flaky-tests > li > :first-child):
  35830. (.flakiness-examples-list):
  35831. Styling to account for the new elements.
  35832. (.expandable):
  35833. (.expanded > .expandable):
  35834. Generalized the .flakiness-example-list code to a generic .expandable class. Removed the
  35835. transition properties because we can't transition to/from 'auto' (but really would like
  35836. to!).
  35837. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  35838. (ViewController.prototype._displayBuilder): Moved code to create the FailingTestsBugForm
  35839. here from _domForNewAndExistingBugs. Updated for changes to _domForPossiblyFlakyTests.
  35840. (ViewController.prototype._domForNewAndExistingBugs): Changed to take a NewBugForm as an
  35841. argument instead of creating one ourselves.
  35842. (ViewController.prototype._domForPossiblyFlakyTests): Changed to take all analyzed builds as
  35843. an argument instead of just the number of analyzed builds. Put the examples list inside a
  35844. container <div>, which is also used to hold the new/existing bugs UI. Removed code to deal
  35845. with animating the height of the examples list; we don't do this anymore because it's hard
  35846. to make it work correctly with the asynchronous loading of existing bugs. When we populate
  35847. the examples list, also set up the new/existing bug UI.
  35848. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  35849. FlakyTestBugForm.
  35850. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  35851. Pull in FlakyTestBugForm and its tests.
  35852. 2011-07-19 Ryosuke Niwa <rniwa@webkit.org>
  35853. Buildbot marks a nrwt bot red when tests are missing results
  35854. https://bugs.webkit.org/show_bug.cgi?id=64812
  35855. Reviewed by Tony Chang.
  35856. Added "missing results" label for tests that are missing results.
  35857. buildbot Now reports shows a label "X missing results" on a run when X tests were missing
  35858. expected results on that run.
  35859. Also rephrased "X failed" and "X were flaky" to "X failures" and "X flakes".
  35860. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  35861. 2011-07-19 Adam Roben <aroben@apple.com>
  35862. Extract some of FailingTestsBugForm's code into a base class
  35863. Prep work for fixing <http://webkit.org/b/63728> TestFailures page should make it easy to
  35864. file bugs about flaky tests
  35865. Reviewed by Sam Weinig.
  35866. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js:
  35867. Moved BugzillaConstants to new WebKitBugzilla file. Moved a bunch of other code from here to
  35868. TestRelatedBugForm.js.
  35869. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js:
  35870. Moved some tests to TestRelatedBugForm_unittests.js.
  35871. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm.js: Added.
  35872. (TestRelatedBugForm):
  35873. (TestRelatedBugForm.prototype.domElement):
  35874. (TestRelatedBugForm.prototype._computeOperatingSystem):
  35875. (TestRelatedBugForm.prototype._computePlatform):
  35876. Code came from FailingTestsBugForm.
  35877. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestRelatedBugForm_unittests.js:
  35878. Added. Tests came from FailingTestsBugForm_unittests.js
  35879. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBugzilla.js:
  35880. Added. Code came from FailingTestsBugForm.js.
  35881. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  35882. TestRelatedBugForm.js and WebKitBugzilla.js. Moved Bugzilla.js out of the list of files that
  35883. need to be pulled in early for parsing reasons.
  35884. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  35885. Pull in TestRelatedBugForm and tests and WebKitBugzilla.
  35886. 2011-07-19 Sam Weinig <sam@webkit.org>
  35887. Remove obsolete Mac NRWT test bots
  35888. https://bugs.webkit.org/show_bug.cgi?id=64806
  35889. Reviewed by Adam Roben.
  35890. Remove "Leopard Intel Release (NRWT)" and "SnowLeopard Intel Release (NRWT)"
  35891. which have been disconnected for some time and have been obsoleted by
  35892. the main testers using NRWT.
  35893. * BuildSlaveSupport/build.webkit.org-config/config.json:
  35894. 2011-07-19 Sam Weinig <sam@webkit.org>
  35895. webkit-patch rebaseline crashes on use
  35896. https://bugs.webkit.org/show_bug.cgi?id=64775
  35897. Reviewed by Adam Roben.
  35898. Fix incorrectly spelled attribute name.
  35899. * Scripts/webkitpy/common/net/layouttestresults.py:
  35900. The attribute is test_name, not filename.
  35901. * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  35902. Add test for tests_matching_failure_types.
  35903. 2011-07-18 Eric Seidel <eric@webkit.org>
  35904. new-run-webkit-tests should support --leaks
  35905. https://bugs.webkit.org/show_bug.cgi?id=63832
  35906. Reviewed by Dirk Pranke.
  35907. This may not be sufficient to actually transition over the leaks bot,
  35908. but this is a huge step in the right direction.
  35909. I had to make parse-malloc-history understand being passed more than
  35910. one file (to avoid the silly cat | nonsense in old-run-webkit-tests).
  35911. I removed some dead code relating to previous iterations of our crash detection.
  35912. I created a new class "LeakDetector" to encapsulate all this logic.
  35913. Eventually we should consider pulling that class out of mac.py and
  35914. sharing with other ports. However given that ORWT has had
  35915. --leaks support on Mac for almost 7 years and no other port has added
  35916. it, leaves me to believe we're in no rush to move LeakDetector.
  35917. I've tested --leaks locally. I suspect there are more bugs to shake out
  35918. but it seems to work well enough to start.
  35919. I also added support for --guard-malloc, but have not tested it much. It
  35920. should be viewed as experimental at this time.
  35921. I also fixed various os.path uses to self._filesystem as I was reading
  35922. through the various files to understand how best to fix this bug.
  35923. * Scripts/old-run-webkit-tests:
  35924. (parseLeaksandPrintUniqueLeaks):
  35925. * Scripts/parse-malloc-history:
  35926. (main):
  35927. * Scripts/webkitpy/common/system/crashlogs.py:
  35928. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  35929. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  35930. * Scripts/webkitpy/layout_tests/port/base.py:
  35931. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  35932. * Scripts/webkitpy/layout_tests/port/gtk.py:
  35933. * Scripts/webkitpy/layout_tests/port/mac.py:
  35934. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  35935. * Scripts/webkitpy/layout_tests/port/server_process.py:
  35936. * Scripts/webkitpy/layout_tests/port/webkit.py:
  35937. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  35938. 2011-07-19 Adam Barth <abarth@webkit.org>
  35939. garden-o-matic should have a "Triage Failures" button for iterating over failures
  35940. https://bugs.webkit.org/show_bug.cgi?id=64769
  35941. Reviewed by Eric Seidel.
  35942. This patch adds some global static state and refactors things a bit so
  35943. that we can iterate over all the failures in the details pane.
  35944. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  35945. - Add a generic callback iterator to iterate through a series of
  35946. callbacks. We use this to iterate through the failures we want to
  35947. display the details of.
  35948. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  35949. - Add a toolbar for the results summary and change the buttons to
  35950. be real buttons.
  35951. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  35952. - Make the detail pane 75% of the window.
  35953. - Make the buttons pretty.
  35954. - Allow the failure type badges to apply to the details pane as well.
  35955. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  35956. - Restructure how we bring up the details pane so we can iterate
  35957. through a bunch of failures.
  35958. - Remove the transition between results details because it's
  35959. annoying when you want to click through a bunch of failures.
  35960. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  35961. - Add some more structure to the title bar for the results details
  35962. so it's clearer which results we're currently displaying.
  35963. 2011-07-19 Adam Barth <abarth@webkit.org>
  35964. garden-o-matic should live update as conditions change on the buildbot
  35965. https://bugs.webkit.org/show_bug.cgi?id=64646
  35966. Reviewed by Eric Seidel.
  35967. This patch causes the garden-o-matic display to update every 10 minutes
  35968. to show the latest failures. This patch required a moderately large
  35969. refactoring of main.js to make the display incremental instead of
  35970. all-at-once.
  35971. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  35972. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  35973. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  35974. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  35975. 2011-07-18 Tab Atkins <jackalmage@gmail.com>
  35976. Tab Atkins is not in committers.py (as a non-committer)
  35977. https://bugs.webkit.org/show_bug.cgi?id=64770
  35978. Reviewed by Eric Seidel.
  35979. * Scripts/webkitpy/common/config/committers.py:
  35980. 2011-07-18 Ojan Vafai <ojan@chromium.org>
  35981. Load ToT chromium bots by default in the flakiness dashboard
  35982. https://bugs.webkit.org/show_bug.cgi?id=64756
  35983. Reviewed by Adam Barth.
  35984. For now, these are the most useful bots to look at. Eventually,
  35985. we may want to load the build.webkit.org bots by default once
  35986. most of the bots there upload results.
  35987. * TestResultServer/static-dashboards/dashboard_base.js:
  35988. 2011-07-13 Jon Honeycutt <jhoneycutt@apple.com>
  35989. Focus and selection events are not fired when a <select>'s selection
  35990. changes
  35991. https://bugs.webkit.org/show_bug.cgi?id=64504
  35992. <rdar://problem/9319881>
  35993. Reviewed by Alice Liu.
  35994. * DumpRenderTree/AccessibilityController.h:
  35995. Added m_notificationsEventHook for addNotificationListener().
  35996. m_allEventsHook will now be used for setLogAccessibilityEvents().
  35997. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  35998. (AccessibilityController::AccessibilityController):
  35999. Initialize m_notificationsEventHook.
  36000. (AccessibilityController::~AccessibilityController):
  36001. Turn off logging of all accessibility events. If
  36002. m_notificationsEventHook is non-null, unhook it.
  36003. (logEventProc):
  36004. Add handling of EVENT_OBJECT_SELECTION.
  36005. (AccessibilityController::setLogAccessibilityEvents):
  36006. If the state of logging is not changing, return early. If we're turning
  36007. off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
  36008. hook for all events.
  36009. (AccessibilityController::addNotificationListener):
  36010. Use m_notificationsEventHook rather than m_allEventsHook.
  36011. 2011-07-18 Eric Seidel <eric@webkit.org>
  36012. webkit-patch apply-attachment does not work when not called from the root of the checkout
  36013. https://bugs.webkit.org/show_bug.cgi?id=64751
  36014. Unreviewed. Just updating unit test results after bug 64751.
  36015. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  36016. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  36017. 2011-07-18 Adam Barth <abarth@webkit.org>
  36018. simplejson has trouble on chromium-linux
  36019. https://bugs.webkit.org/show_bug.cgi?id=64757
  36020. Reviewed by Eric Seidel.
  36021. Use the native JSON, if available.
  36022. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  36023. 2011-07-18 Ojan Vafai <ojan@chromium.org>
  36024. update the flakiness dashboard to understand the new platforms/formats in test_expectations
  36025. https://bugs.webkit.org/show_bug.cgi?id=64743
  36026. Reviewed by Adam Barth.
  36027. The test expectations format changed a long time ago and the flakiness dashboard
  36028. was never updated to match.
  36029. * TestResultServer/static-dashboards/dashboard_base.js:
  36030. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  36031. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  36032. * TestResultServer/static-dashboards/timeline_explorer.html:
  36033. 2011-07-18 Eric Seidel <eric@webkit.org>
  36034. webkit-patch apply-attachment does not work when not called from the root of the checkout
  36035. https://bugs.webkit.org/show_bug.cgi?id=64751
  36036. Reviewed by Adam Barth.
  36037. Last week I removed a os.chdir in EnsureWorkingDirectoryClean, which
  36038. is a step that we run for most commands (as one of the earliest steps).
  36039. EnsureWorkingDirectoryClean was incorrectly calling os.chdir to change
  36040. the CWD to the checkout root. This magically made a bunch of otherwise
  36041. wrong code work.
  36042. When I realized that apply-attachment no longer worked as expected today,
  36043. I went and fixed the bug, then realizing that we were not testing
  36044. what the cwd was when running various commands. I fixed our MockExecutive
  36045. to always log what the cwd is and fixed a whole bunch of places
  36046. where we needed to be setting the cwd.
  36047. Hopefully this will solve our cwd problems once and for-all, and webkit-patch
  36048. will again correctly work when called from any directory (including outside
  36049. of a webkit checkout).
  36050. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  36051. * Scripts/webkitpy/common/system/executive.py:
  36052. * Scripts/webkitpy/common/system/workspace_unittest.py:
  36053. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  36054. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
  36055. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  36056. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  36057. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  36058. * Scripts/webkitpy/tool/bot/irc_command.py:
  36059. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  36060. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  36061. * Scripts/webkitpy/tool/commands/download_unittest.py:
  36062. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  36063. * Scripts/webkitpy/tool/commands/queues.py:
  36064. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  36065. * Scripts/webkitpy/tool/commands/queuestest.py:
  36066. * Scripts/webkitpy/tool/mocktool.py:
  36067. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  36068. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  36069. * Scripts/webkitpy/tool/steps/build.py:
  36070. * Scripts/webkitpy/tool/steps/checkstyle.py:
  36071. * Scripts/webkitpy/tool/steps/editchangelog.py:
  36072. * Scripts/webkitpy/tool/steps/preparechangelog.py:
  36073. * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  36074. * Scripts/webkitpy/tool/steps/runtests.py:
  36075. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  36076. * Scripts/webkitpy/tool/steps/update.py:
  36077. 2011-07-18 Adam Barth <abarth@webkit.org>
  36078. Increase information garden-o-matic information density by switching to a table
  36079. https://bugs.webkit.org/show_bug.cgi?id=64642
  36080. Reviewed by Dimitri Glazkov.
  36081. The old layout couldn't handle the large number of failures we had
  36082. today. This patch switches garden-o-matic to a table-based layout,
  36083. which can handle many more failures gracefully. (I expect we'll need
  36084. more UI iterations.)
  36085. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36086. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36087. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36088. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36089. 2011-07-18 Adam Barth <abarth@webkit.org>
  36090. garden-o-matic should be able to determine when compile breaks
  36091. https://bugs.webkit.org/show_bug.cgi?id=64190
  36092. Reviewed by Dimitri Glazkov.
  36093. This patch adds a red-ish box to the top of the page whenever there is
  36094. a compile error on the bots. The box automatically opens and closes as
  36095. appropriate and links to the waterfall display. In the future, we
  36096. might want to compute a regression range.
  36097. * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
  36098. - Add the build-only bots to the config. We use these to check
  36099. whether the build failed, which is faster than waiting for the
  36100. tester bots to cycle.
  36101. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  36102. - Add DOM for the alert bar.
  36103. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36104. - CSS to support the alert bar.
  36105. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36106. - Wiring up events to poll the buildbot to see whether compile has
  36107. failed.
  36108. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36109. - Infrastructure for fetching and parsing the buildbot status JSON
  36110. blob. This code could be better factored for testability. :(
  36111. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36112. - UI for displaying compile errors.
  36113. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36114. 2011-07-18 Sheriff Bot <webkit.review.bot@gmail.com>
  36115. Unreviewed, rolling out r91132 and r91135.
  36116. http://trac.webkit.org/changeset/91132
  36117. http://trac.webkit.org/changeset/91135
  36118. https://bugs.webkit.org/show_bug.cgi?id=64681
  36119. Broke GTK and Chromium debug bots (Requested by rniwa on
  36120. #webkit).
  36121. * DumpRenderTree/AccessibilityController.h:
  36122. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  36123. (AccessibilityController::AccessibilityController):
  36124. (AccessibilityController::~AccessibilityController):
  36125. (logEventProc):
  36126. (AccessibilityController::setLogAccessibilityEvents):
  36127. (AccessibilityController::addNotificationListener):
  36128. 2011-07-17 Philippe Normand <pnormand@igalia.com>
  36129. test-webkitpy failing with Python 2.5
  36130. https://bugs.webkit.org/show_bug.cgi?id=64594
  36131. Reviewed by Eric Seidel.
  36132. Updated simplejson to version 2.1.6 that fixes an issue when
  36133. dumping slashes. Also use cgi.parse_qs instead of the urlparse
  36134. version to be compatible with Python2.5. Verified the fix with
  36135. test-webkitpy on python 2.5 and python 2.6.
  36136. * Scripts/webkitpy/thirdparty/simplejson/README.txt:
  36137. * Scripts/webkitpy/thirdparty/simplejson/__init__.py:
  36138. * Scripts/webkitpy/thirdparty/simplejson/_speedups.c:
  36139. (json_PyOS_string_to_double):
  36140. (_convertPyInt_AsSsize_t):
  36141. (_convertPyInt_FromSsize_t):
  36142. (ascii_escape_char):
  36143. (ascii_escape_unicode):
  36144. (ascii_escape_str):
  36145. (raise_errmsg):
  36146. (join_list_unicode):
  36147. (join_list_string):
  36148. (_build_rval_index_tuple):
  36149. (scanstring_str):
  36150. (scanstring_unicode):
  36151. (py_scanstring):
  36152. (py_encode_basestring_ascii):
  36153. (scanner_dealloc):
  36154. (scanner_traverse):
  36155. (scanner_clear):
  36156. (_parse_object_str):
  36157. (_parse_object_unicode):
  36158. (_parse_array_str):
  36159. (_parse_array_unicode):
  36160. (_parse_constant):
  36161. (_match_number_str):
  36162. (_match_number_unicode):
  36163. (scan_once_str):
  36164. (scan_once_unicode):
  36165. (scanner_call):
  36166. (scanner_new):
  36167. (scanner_init):
  36168. (encoder_new):
  36169. (encoder_init):
  36170. (encoder_call):
  36171. (_encoded_const):
  36172. (encoder_encode_float):
  36173. (encoder_encode_string):
  36174. (_steal_list_append):
  36175. (encoder_listencode_obj):
  36176. (encoder_listencode_dict):
  36177. (encoder_listencode_list):
  36178. (encoder_dealloc):
  36179. (encoder_traverse):
  36180. (encoder_clear):
  36181. (init_speedups):
  36182. * Scripts/webkitpy/thirdparty/simplejson/decoder.py:
  36183. * Scripts/webkitpy/thirdparty/simplejson/encoder.py:
  36184. * Scripts/webkitpy/thirdparty/simplejson/ordered_dict.py: Added.
  36185. * Scripts/webkitpy/thirdparty/simplejson/scanner.py:
  36186. * Scripts/webkitpy/thirdparty/simplejson/tool.py: Added.
  36187. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  36188. 2011-07-17 Dimitri Glazkov <dglazkov@chromium.org>
  36189. Rename ModifierMatcher to SpecificityCalculator.
  36190. https://bugs.webkit.org/show_bug.cgi?id=64660
  36191. It's a little longer than before, but it is much clearer.
  36192. Reviewed by Adam Barth.
  36193. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Renamed and adjusted
  36194. all callsites, also rewrote the comments.
  36195. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Adjusted callsites
  36196. and renamed tests.
  36197. 2011-07-15 Adam Barth <abarth@webkit.org>
  36198. gardening server should proxy buildbot status for garden-o-matic
  36199. https://bugs.webkit.org/show_bug.cgi?id=64588
  36200. Reviewed by Eric Seidel.
  36201. This information will be used to detect build breaks. I took this
  36202. opportunity to make ChromiumBuildBot non-static.
  36203. * Scripts/webkitpy/common/host.py:
  36204. * Scripts/webkitpy/tool/commands/rebaseline.py:
  36205. * Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
  36206. * Scripts/webkitpy/tool/mocktool.py:
  36207. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  36208. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  36209. 2011-07-15 Julien Chaffraix <jchaffraix@webkit.org>
  36210. [NRWT] Add support for --no-http
  36211. https://bugs.webkit.org/show_bug.cgi?id=64564
  36212. Reviewed by Dirk Pranke.
  36213. Added support for --no-http, which disables both HTTP and websockets tests.
  36214. It also matches the old-run-webkit-tests behavior if --force is used.
  36215. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  36216. Fixed HTTP_SUBDIR and WEBSOCKET_SUBDIR as tests do not start with a leading separator.
  36217. We check if --no-http is set and add the HTTP / websockets tests to the skipped list prior to looking
  36218. at the expectation file. Fixed the _test_requires_lock function to use the same code path to determine
  36219. what is worth have an HTTP lock as --no-http to avoid badness.
  36220. * Scripts/webkitpy/layout_tests/port/test.py: Added 2 new tests to our mock filesystem to validate that
  36221. we do skip properly HTTP / websocket tests inside platform/.
  36222. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  36223. Added tests that we properly skip all the tests.
  36224. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  36225. Added checks for the command line arguments.
  36226. 2011-07-13 Jon Honeycutt <jhoneycutt@apple.com>
  36227. Focus and selection events are not fired when a <select>'s selection
  36228. changes
  36229. https://bugs.webkit.org/show_bug.cgi?id=64504
  36230. <rdar://problem/9319881>
  36231. Reviewed by Alice Liu.
  36232. * DumpRenderTree/AccessibilityController.h:
  36233. Added m_notificationsEventHook for addNotificationListener().
  36234. m_allEventsHook will now be used for setLogAccessibilityEvents().
  36235. * DumpRenderTree/win/AccessibilityControllerWin.cpp:
  36236. (AccessibilityController::AccessibilityController):
  36237. Initialize m_notificationsEventHook.
  36238. (AccessibilityController::~AccessibilityController):
  36239. Turn off logging of all accessibility events. If
  36240. m_notificationsEventHook is non-null, unhook it.
  36241. (logEventProc):
  36242. Add handling of EVENT_OBJECT_SELECTION.
  36243. (AccessibilityController::setLogAccessibilityEvents):
  36244. If the state of logging is not changing, return early. If we're turning
  36245. off logging, unhook m_allEventsHook, and zero it out. Otherwise, add a
  36246. hook for all events.
  36247. (AccessibilityController::addNotificationListener):
  36248. Use m_notificationsEventHook rather than m_allEventsHook.
  36249. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36250. Refactor TestExpectationModel to use TestExpectationLine as data item.
  36251. https://bugs.webkit.org/show_bug.cgi?id=64635
  36252. This is a bit largish in scope. Does the following things:
  36253. 1) Adds "path" member to TestExpectationLine to hold normalized path to test, computed at parsing,
  36254. and changes code that used Port.normalize_test_name to rely on TestExpectationLine.path. As a result, TestExpectationModel no longer
  36255. needs to have any port knowledge.
  36256. 2) Adds "create_passing_expectation" class method to TestExpectationLine to generate a pristine passing expectation out of a test name,
  36257. and changes TestExpectations._process_tests_without_expectations to use it, thus eliminating the need for a special API entry point.
  36258. Now all expectations are added to the model in the same way!
  36259. 3) Changes TestExpectationModel's main test index to store a tuple consisting of line number and TestExpectationLine instance.
  36260. Reviewed by Adam Barth.
  36261. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Refactored code.
  36262. 2011-07-15 Adam Roben <aroben@apple.com>
  36263. Teach TestFailures how to detect interrupted build steps
  36264. Fixes <http://webkit.org/b/64619> TestFailures page thinks all tests passed in
  36265. http://build.webkit.org/builders/SnowLeopard%20Intel%20Release%20(WebKit2%20Tests)/builds/13401
  36266. Reviewed by Daniel Bates.
  36267. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  36268. (Builder.prototype.getNumberOfFailingTests): If the build step has a result code of 4, the
  36269. build step was interrupted. Treat it as an error (by returning a failureCount of -1).
  36270. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  36271. Added a test for the above.
  36272. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  36273. (LayoutTestResultsLoader.prototype.start): Bumped the cache version to evict old, buggy
  36274. cache data that was afflicted by the above bug.
  36275. 2011-07-15 Eric Seidel <eric@webkit.org>
  36276. new-run-webkit-tests crashes on Apple's Windows port when trying to launch Apache
  36277. https://bugs.webkit.org/show_bug.cgi?id=64533
  36278. Reviewed by Adam Roben.
  36279. Blind removal of Chromium-specific code (now that Chromium does not use this file).
  36280. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  36281. 2011-07-15 Adam Roben <aroben@apple.com>
  36282. Make TestFailures's list of possibly-flaky tests not so tall
  36283. Fixes <http://webkit.org/b/64618> TestFailures page's list of flaky tests takes up way too
  36284. much room
  36285. Reviewed by Daniel Bates.
  36286. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  36287. Removed a no-longer-used .flakiness-example-separator selector.
  36288. (#failure-history > li):
  36289. (#possibly-flaky-tests > li):
  36290. (#failure-history > li, #possibly-flaky-tests > li):
  36291. Use a lot less padding for the possibly-flaky tests.
  36292. 2011-07-15 Tony Chang <tony@chromium.org>
  36293. [chromium] land linux selection color layout test
  36294. https://bugs.webkit.org/show_bug.cgi?id=64631
  36295. Reviewed by Ojan Vafai.
  36296. I had removed this code in r76620 because I thought it wasn't used.
  36297. Turns out there was a layout test in the chromium tree that never
  36298. got migrated that used it. Re-add the code and land the layout
  36299. test (I will remove it from the chromium tree soon).
  36300. * DumpRenderTree/chromium/LayoutTestController.cpp:
  36301. (LayoutTestController::LayoutTestController):
  36302. (LayoutTestController::forceRedSelectionColors):
  36303. * DumpRenderTree/chromium/LayoutTestController.h:
  36304. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36305. Revert http://trac.webkit.org/changeset/91091, since Python 2.5
  36306. does not support enumerate() start argument.
  36307. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Reverted.
  36308. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36309. Clean up test_expectations.py after refactorings.
  36310. https://bugs.webkit.org/show_bug.cgi?id=64620
  36311. * Renamed all variables holding TestExpectationLine to expectation_line to avoid confusion with
  36312. its sub-part, the actual expectation.
  36313. * Renamed all references to options to modifier to eliminate dual terminology.
  36314. * Made a bunch of parser constants and changed all callsites to use them.
  36315. * Various other minor clean-ups.
  36316. Reviewed by Adam Barth.
  36317. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Cleaned up stuff.
  36318. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed callsites after cleanup.
  36319. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
  36320. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36321. Move expectation parsing code to TestExpectationParser.
  36322. https://bugs.webkit.org/show_bug.cgi?id=64605
  36323. This is a somewhat mechanical move, with two interesting bits:
  36324. 1) TestExpectationParser.parse methods renamed to tokenize, to better
  36325. reflect what they do
  36326. 2) TestExpectationLine now carries all of its info, from tokens to parsed data,
  36327. and even the list of tests that it matches (a line may refer to more than one test).
  36328. Reviewed by Adam Barth.
  36329. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved parsing-related TestExpectaions methods
  36330. to TestExpectationParser, added more members to TestExpectationLine to carry parsed info, renamed existing parse methods
  36331. to "tokenize", changed callsites to use new code.
  36332. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed unit tests to reflect renames.
  36333. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36334. Switch to use Python enumerate function to enumerate line numbers.
  36335. https://bugs.webkit.org/show_bug.cgi?id=64602
  36336. Reviewed by Adam Barth.
  36337. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Changed to use enumerate.
  36338. 2011-07-15 Martin Robinson <mrobinson@igalia.com>
  36339. Build fixes for WebKit2. Ensure that all generated sources are
  36340. on nodist primaries, that they are on forward declared variables
  36341. so that BUILT_SOURCES is calculated properly and that zlib is
  36342. included during linking (for WOFF support).
  36343. * WebKitTestRunner/GNUmakefile.am:
  36344. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36345. Store error and warning information on TestExpectationLine.
  36346. https://bugs.webkit.org/show_bug.cgi?id=64565
  36347. Keeping errors and warnings on the TestExpectationLine instance allows us to decouple storing errors
  36348. from various parsing and validation mechanisms and have more flexibility in reporting and understanding the origin of the errors.
  36349. Reviewed by Adam Barth.
  36350. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added TestExpectationLine.warnings list to keep track of non-fatal errors,
  36351. converted the code to add errors and warnings to corresponding TestExpectationLine instances, removed the code that used to store
  36352. this info on TestExpectations. In the process, had to refactor ModifierMatcher a bit to take in a TestExpdectationLine instance.
  36353. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed ModifierMatcher callsite.
  36354. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36355. Plumb the use of TestExpectationLine deeper, clean up.
  36356. https://bugs.webkit.org/show_bug.cgi?id=64559
  36357. Instead of carrying various bits of TestExpectationLine, plumb it down to its consumers,
  36358. also cleaning up names and remove an unused TestExpectations._get_options_list member.
  36359. Reviewed by Adam Barth.
  36360. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  36361. 2011-07-15 Dimitri Glazkov <dglazkov@chromium.org>
  36362. Remove the notion of TestExpectationLine.valid, start storing parsing errors in expectations themselves.
  36363. https://bugs.webkit.org/show_bug.cgi?id=64554
  36364. This moves us toward the world where errors are collected on the expectations, which allows us to
  36365. easily enumerate them, keep association with the point of origin, and freely pass TestExpectationLine instances around.
  36366. Also eliminate the validator idea, since validation is a context-dependent concept and has to be decoupled from initial
  36367. parsing.
  36368. Reviewed by Adam Barth.
  36369. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed TestExpectation.valid, validator,
  36370. changed TestExpectationParser to collect errors in TestExpectationLine, refactored surrounding code.
  36371. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Changed tests to accommodate changes.
  36372. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Ditto.
  36373. 2011-07-15 Adam Roben <aroben@apple.com>
  36374. Rename TestFailureBugForm to FailingTestsBugForm
  36375. The new name will match better with a forthcoming FlakyTestBugForm class.
  36376. Fixes <http://webkit.org/b/64598> TestFailures page's TestFailureBugForm class has a bad
  36377. name
  36378. Reviewed by Daniel Bates.
  36379. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js.
  36380. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FailingTestsBugForm_unittests.js: Renamed from Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js.
  36381. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  36382. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  36383. Updated for renames.
  36384. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Ditto, and
  36385. reordered <script>s to put files which others depend on for parsing first.
  36386. 2011-07-15 Adam Barth <abarth@webkit.org>
  36387. NRWT stores the Chromium revision number in full_results.json
  36388. https://bugs.webkit.org/show_bug.cgi?id=64586
  36389. I have no earthly idea how to test this change.
  36390. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  36391. * Scripts/webkitpy/layout_tests/port/base.py:
  36392. 2011-07-14 Ojan Vafai <ojan@chromium.org>
  36393. fix remaining style issues in the static-dashboards directory
  36394. https://bugs.webkit.org/show_bug.cgi?id=64561
  36395. Reviewed by Adam Barth.
  36396. * TestResultServer/static-dashboards/aggregate_results.html:
  36397. * TestResultServer/static-dashboards/builders.js:
  36398. * TestResultServer/static-dashboards/dashboard_base.js:
  36399. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  36400. * TestResultServer/static-dashboards/timeline_explorer.html:
  36401. * TestResultServer/static-dashboards/treemap.html:
  36402. 2011-07-14 Yuta Kitamura <yutak@chromium.org>
  36403. WebSocket: Introduce pywebsocket-0.6b2
  36404. https://bugs.webkit.org/show_bug.cgi?id=64534
  36405. Reviewed by Kent Tamura.
  36406. * Scripts/webkitpy/thirdparty/__init__.py:
  36407. 2011-07-14 Dimitri Glazkov <dglazkov@chromium.org>
  36408. Introduce TestExpectationsModel, split out of TestExpectations.
  36409. https://bugs.webkit.org/show_bug.cgi?id=64531
  36410. This is a simple split-and-make-work refactoring, a first step among many.
  36411. Reviewed by Adam Barth.
  36412. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Moved all model-related members
  36413. out of TestExpectations and into TestExpectationsModel.
  36414. 2011-07-14 Eric Seidel <eric@webkit.org>
  36415. Move webkitpy off of loose mocks
  36416. https://bugs.webkit.org/show_bug.cgi?id=64508
  36417. Unreviewed. Fixing a test which fails under test-webkitpy --all (but not in a normal run).
  36418. * Scripts/webkitpy/common/checkout/scm/git.py:
  36419. 2011-07-14 Adam Barth <abarth@webkit.org>
  36420. garden-o-matic should have a "rebaseline" button
  36421. https://bugs.webkit.org/show_bug.cgi?id=64446
  36422. Reviewed by Ojan Vafai.
  36423. This patch adds a basic Rebaseline button that copies the baselines
  36424. displayed in the results pane into the appropriate directory in your
  36425. working copy.
  36426. There are two main limitations:
  36427. 1) There is no UI for actually committing the baselines.
  36428. 2) The baselines are not optimized for redundancy (meaning you can have
  36429. identical baselines in both chromium-mac and chromium-win).
  36430. * Scripts/webkitpy/tool/commands/rebaseline.py:
  36431. - Turns out we need to create the directory for the baseline if it doesn't exist yet.
  36432. * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js:
  36433. - Add an programatic API to call the server.
  36434. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  36435. - Add the rebaseline button itself.
  36436. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36437. - Change the CSS so that the Rebaseline and Close buttons can
  36438. appear in the normal order in the DOM.
  36439. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36440. - Bind the event and translate the parameters.
  36441. - Hide/show the rebaseline button, as appropriate.
  36442. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36443. - Add some helpful utility functions for manipulating failure types.
  36444. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36445. 2011-07-14 Ryosuke Niwa <rniwa@webkit.org>
  36446. REGRESSION: webkit-patch roll-chromium-deps is broken
  36447. https://bugs.webkit.org/show_bug.cgi?id=64568
  36448. Reviewed by Dirk Pranke
  36449. Use _filesystem.join.
  36450. * Scripts/webkitpy/common/checkout/checkout.py:
  36451. * Scripts/webkitpy/common/checkout/checkout_unittests.py:
  36452. 2011-07-14 Noam Rosenthal <noam.rosenthal@nokia.com>
  36453. Adding myself to the reviewers list; No review needed.
  36454. * Scripts/webkitpy/common/config/committers.py:
  36455. 2011-07-14 Adam Roben <aroben@apple.com>
  36456. Don't use Element.prototype.classList in TestFailures
  36457. Safari 5 doesn't support it.
  36458. Fixes <http://webkit.org/b/64550> Can't expand flaky tests on TestFailures page in Safari 5
  36459. Reviewed by Daniel Bates.
  36460. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  36461. (Element.prototype.hasStyleClass):
  36462. (Element.prototype.addStyleClass):
  36463. (Element.prototype.removeStyleClass):
  36464. (Element.prototype.toggleStyleClass):
  36465. Added these helper functions which simulate classList functionality.
  36466. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities_unittests.js:
  36467. Added. Tests for the above.
  36468. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  36469. (ViewController.prototype._domForPossiblyFlakyTests): Changed to use
  36470. toggleStyleClass/hasStyleClass instead of classList.
  36471. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  36472. Added Utilities_unittests.js, and reordered the tested files to be in
  36473. roughly dependency order (i.e., the lowest-level files are imported
  36474. and tested first).
  36475. 2011-07-14 Eric Seidel <eric@webkit.org>
  36476. NRWT doesn't store the svn revision in full_results.json on chromium-win
  36477. https://bugs.webkit.org/show_bug.cgi?id=64492
  36478. Unreviewed. Just fixing my test-webkitpy regression.
  36479. Fix the unit tests. Unfortunately scm does not use a filesystem
  36480. object so we can't control the result of detect_scm_system.
  36481. When detect_scm_system would fail, we would log, which would
  36482. cause all passing_run integration tests to fail.
  36483. * Scripts/webkitpy/common/checkout/scm/scm.py:
  36484. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  36485. * Scripts/webkitpy/layout_tests/port/base.py:
  36486. * Scripts/webkitpy/layout_tests/port/test.py:
  36487. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  36488. 2011-07-14 Eric Seidel <eric@webkit.org>
  36489. NRWT doesn't store the svn revision in full_results.json on chromium-win
  36490. https://bugs.webkit.org/show_bug.cgi?id=64492
  36491. Reviewed by Ojan Vafai.
  36492. This should fix the bug. Unfortunately this code is currently
  36493. impossible to test since it's impossible to mock detect_scm_system at the
  36494. moment. I started re-writing scm.detection.py to be mockable, but decided that
  36495. was best left for another day.
  36496. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  36497. * Scripts/webkitpy/layout_tests/port/base.py:
  36498. 2011-07-14 Ojan Vafai <ojan@chromium.org>
  36499. fix coding style of dashboard_base.js
  36500. https://bugs.webkit.org/show_bug.cgi?id=64545
  36501. Reviewed by Adam Roben.
  36502. The code changes to the files other than dashboard_base.js
  36503. are just fallout from renaming globals in dashboard_base.js.
  36504. * TestResultServer/static-dashboards/aggregate_results.html:
  36505. * TestResultServer/static-dashboards/builders.js:
  36506. * TestResultServer/static-dashboards/dashboard_base.js:
  36507. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  36508. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js:
  36509. * TestResultServer/static-dashboards/timeline_explorer.html:
  36510. * TestResultServer/static-dashboards/treemap.html:
  36511. 2011-07-14 Carlos Garcia Campos <cgarcia@igalia.com>
  36512. Unreviewed. Fix WebKit2 GTK build after r90953.
  36513. * WebKitTestRunner/GNUmakefile.am:
  36514. 2011-07-14 Adam Barth <abarth@webkit.org>
  36515. garden-o-matic results pane should be more discoverable
  36516. https://bugs.webkit.org/show_bug.cgi?id=64513
  36517. Reviewed by Eric Seidel.
  36518. This patch causes us to trigger the results pane on mouse clicks
  36519. instead of mousein. Also, handle the case of no results details more
  36520. elegantly.
  36521. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36522. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36523. - Change the binding to "click".
  36524. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36525. - Handle the "no results URLs" case explicitly instead of never
  36526. calling the callback.
  36527. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36528. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36529. - Show a message when there are no result details to show.
  36530. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36531. 2011-07-14 Adam Barth <abarth@webkit.org>
  36532. garden-o-matic should badge TIMEOUT failures
  36533. https://bugs.webkit.org/show_bug.cgi?id=64435
  36534. Reviewed by Eric Seidel.
  36535. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36536. (.regression .what a[draggable].TIMEOUT::before):
  36537. - Add TIMEOUT.
  36538. 2011-07-14 Adam Barth <abarth@webkit.org>
  36539. Fix Python exception blocking the commit-queue.
  36540. * Scripts/webkitpy/common/checkout/scm/git.py:
  36541. 2011-07-13 Eric Seidel <eric@webkit.org>
  36542. Move webkitpy off of loose mocks
  36543. https://bugs.webkit.org/show_bug.cgi?id=64508
  36544. Reviewed by Adam Barth.
  36545. Using Mock has caused us more pain than help.
  36546. It's possible that there was a cleaner way to use it
  36547. (maybe Mock(class) instead of inheriting from it?).
  36548. But for now, I've removed all uses of Mock from mocktool.py.
  36549. I also moved run_command into the only 3 files which call it
  36550. instead of leaving the deprecated method in executive.py.
  36551. I changed various direct calls to os.* to use filesystem instead.
  36552. * Scripts/webkitpy/common/checkout/checkout.py:
  36553. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  36554. * Scripts/webkitpy/common/checkout/scm/git.py:
  36555. * Scripts/webkitpy/common/checkout/scm/scm.py:
  36556. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  36557. * Scripts/webkitpy/common/checkout/scm/svn.py:
  36558. * Scripts/webkitpy/common/system/executive.py:
  36559. * Scripts/webkitpy/common/system/executive_unittest.py:
  36560. * Scripts/webkitpy/tool/mocktool.py:
  36561. * Scripts/webkitpy/tool/steps/cleanworkingdirectory_unittest.py:
  36562. * Scripts/webkitpy/tool/steps/ensurelocalcommitifneeded.py:
  36563. 2011-07-13 Eric Seidel <eric@webkit.org>
  36564. NRWT doesn't store the svn revision in full_results.json on chromium-win
  36565. https://bugs.webkit.org/show_bug.cgi?id=64492
  36566. Reviewed by Adam Barth.
  36567. Add a warning message in the revision='' case to help us diagnose
  36568. what's going wrong on the bot.
  36569. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  36570. 2011-07-13 Dirk Pranke <dpranke@chromium.org>
  36571. new-run-webkit-tests: print baseline search path as part of config output
  36572. https://bugs.webkit.org/show_bug.cgi?id=64499
  36573. Reviewed by Eric Seidel.
  36574. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  36575. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  36576. 2011-07-13 Adam Barth <abarth@webkit.org>
  36577. gardening server should have an API for parsing changelogs
  36578. https://bugs.webkit.org/show_bug.cgi?id=64495
  36579. Reviewed by Eric Seidel.
  36580. This patch exposes much of the same information from CommitInfo in a
  36581. dictionary form, which is easier to send over-the-wire as JSON to the
  36582. frontend.
  36583. * Scripts/webkitpy/common/checkout/checkout.py:
  36584. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  36585. * Scripts/webkitpy/tool/mocktool.py:
  36586. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  36587. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  36588. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  36589. 2011-07-13 Eric Seidel <eric@webkit.org>
  36590. REGRESSION: GitTestWithMock.test_create_patch fails
  36591. https://bugs.webkit.org/show_bug.cgi?id=62945
  36592. Reviewed by Daniel Bates.
  36593. I was not able to reproduce the exact failure seen in the bug,
  36594. however this test was failing on my machine for other reasons.
  36595. I went through and did an audit of our run_command usage, it's
  36596. entirely in scm classes after this change. (Not surprising given
  36597. that scm.py was the second file ever created in webkit.py.)
  36598. The real bug I'm fixing here is that we were setting executive.should_log
  36599. when the value had changed to executive._should_log. Now we set the right one
  36600. and the test works again.
  36601. * Scripts/webkitpy/common/checkout/checkout.py:
  36602. * Scripts/webkitpy/common/checkout/scm/git.py:
  36603. * Scripts/webkitpy/common/checkout/scm/scm.py:
  36604. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  36605. * Scripts/webkitpy/common/checkout/scm/svn.py:
  36606. 2011-07-13 Ilya Sherman <isherman@chromium.org>
  36607. Fix WTF header guard style check
  36608. https://bugs.webkit.org/show_bug.cgi?id=64488
  36609. Reviewed by David Levin.
  36610. * Scripts/webkitpy/style/checkers/cpp.py:
  36611. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Verify that we don't *always* suggest "WTF_" as a prefix
  36612. 2011-07-13 Ojan Vafai <ojan@chromium.org>
  36613. bring flakiness_dashboard.html closer to webkit style
  36614. https://bugs.webkit.org/show_bug.cgi?id=64477
  36615. Reviewed by Adam Barth.
  36616. * TestResultServer/static-dashboards/dashboard_base.js:
  36617. Fix bad variable name that would hit only when running the tests.
  36618. * TestResultServer/static-dashboards/flakiness_dashboard.html:
  36619. No code/logic changes. All moving/removing brackets, indents and moving things
  36620. to one line.
  36621. 2011-07-13 Xan Lopez <xlopez@igalia.com>
  36622. [GTK] Fix distcheck
  36623. Reviewed by Martin Robinson.
  36624. * WebKitTestRunner/GNUmakefile.am: mark built sources as nodist.
  36625. 2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
  36626. Unreviewed fix. Add a "\n" to a printf that somehow got lost.
  36627. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  36628. (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
  36629. 2011-07-13 Joseph Pecoraro <joepeck@webkit.org>
  36630. ApplicationCache Quota Output is Flakey
  36631. https://bugs.webkit.org/show_bug.cgi?id=64410
  36632. Reviewed by Alexey Proskuryakov.
  36633. Unify the delegate logging for reaching application cache
  36634. quotas. Truncate the space needed to the nearest 10000
  36635. for less flakey test output. This also better supports
  36636. printing NSUInteger on non-64 bit systems by casting to
  36637. an unsigned long.
  36638. * DumpRenderTree/mac/UIDelegate.mm:
  36639. (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
  36640. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  36641. (WebCore::DumpRenderTree::dumpApplicationCacheQuota):
  36642. 2011-07-13 Dimitri Glazkov <dglazkov@chromium.org>
  36643. Remove unused TestExpectations._overrides.
  36644. https://bugs.webkit.org/show_bug.cgi?id=64470
  36645. Reviewed by Adam Barth.
  36646. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Removed unused member.
  36647. 2011-07-13 Dimitri Glazkov <dglazkov@chromium.org>
  36648. Introduce TestExpectationSerializer.list_to_string.
  36649. https://bugs.webkit.org/show_bug.cgi?id=64462
  36650. Reviewed by Adam Barth.
  36651. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Added list_to_string and change the relevant callsite to use it.
  36652. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Added tests for it.
  36653. 2011-07-13 Dimitri Glazkov <dglazkov@chromium.org>
  36654. Consolidate expectations parsing code.
  36655. https://bugs.webkit.org/show_bug.cgi?id=64460
  36656. Reviewed by Adam Barth.
  36657. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationParser._split_expectation_string into TestExpectationParser.parse.
  36658. 2011-07-12 Brent Fulgham <bfulgham@webkit.org>
  36659. Standardize WinCairo conditionalized code under PLATFORM macro.
  36660. https://bugs.webkit.org/show_bug.cgi?id=64377
  36661. Reviewed by Maciej Stachowiak.
  36662. Update compile-time conditions that had previously used #ifdef
  36663. of WIN_CAIRO to consistently use PLATFORM(WIN_CAIRO).
  36664. * DumpRenderTree/config.h: Switch to PLATFORM(WIN_CAIRO)
  36665. * DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Remove redundant
  36666. define of WIN_CAIRO=1.
  36667. * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Add
  36668. WinCairo.vsprops to set (to match Release build).
  36669. 2011-07-13 Dimitri Glazkov <dglazkov@chromium.org>
  36670. Eliminate TestExpectationsFile.
  36671. https://bugs.webkit.org/show_bug.cgi?id=64458
  36672. Turns out, we can just use a Python list.
  36673. Reviewed by Adam Barth.
  36674. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Folded TestExpectationsFile.append into TestExpectationParser.parse_list,
  36675. removed TestExpectationsFile.
  36676. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Moved tests to better reflect new names, removed iterator test,
  36677. since there's no more custom iterator machinery.
  36678. 2011-07-13 Philippe Normand <pnormand@igalia.com>
  36679. Unreviewed, added my other email addresses.
  36680. * Scripts/webkitpy/common/config/committers.py:
  36681. 2011-07-13 Adam Barth <abarth@webkit.org>
  36682. Folks should only be listed once.
  36683. * Scripts/webkitpy/common/config/committers.py:
  36684. 2011-07-13 Philippe Normand <pnormand@igalia.com>
  36685. Unreviewed, adding myself as Reviewer.
  36686. * Scripts/webkitpy/common/config/committers.py:
  36687. 2011-07-13 Adam Barth <abarth@webkit.org>
  36688. Fix flickering bug introduced by my previous patch. I forgot to change
  36689. the name of the class everywhere.
  36690. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36691. 2011-07-12 Philippe Normand <pnormand@igalia.com>
  36692. [GTK] media/media-blocked-by-willsendrequest.html fails
  36693. https://bugs.webkit.org/show_bug.cgi?id=63699
  36694. Reviewed by Martin Robinson.
  36695. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  36696. (willSendRequestCallback): Abort the request if explicitely asked
  36697. by the LayoutTestController's willSendRequestReturnsNull() function.
  36698. 2011-07-13 Adam Barth <abarth@webkit.org>
  36699. Remove "Dismiss" button from garden-o-matic butterbar
  36700. https://bugs.webkit.org/show_bug.cgi?id=64443
  36701. Reviewed by Dimitri Glazkov.
  36702. We don't have any persistent butter bar messages yet, so the dismiss
  36703. button is premature (and fairly heavy, visually).
  36704. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  36705. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36706. 2011-07-13 Adam Barth <abarth@webkit.org>
  36707. Refine garden-o-matic status pane
  36708. https://bugs.webkit.org/show_bug.cgi?id=64442
  36709. Reviewed by Dimitri Glazkov.
  36710. This patch makes two improvements to the status pane:
  36711. 1) We only query the server for failure types that we're expecting.
  36712. This dramatically reduces the number of HTTP requests, making
  36713. loading the status pane faster.
  36714. 2) The status pane now displays which test and which builder it is
  36715. showing results for.
  36716. * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
  36717. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  36718. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36719. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36720. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36721. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36722. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36723. 2011-07-13 Adam Barth <abarth@webkit.org>
  36724. garden-o-matic should show test results
  36725. https://bugs.webkit.org/show_bug.cgi?id=64440
  36726. Reviewed by Adam Roben.
  36727. This patch introduces the results detail pane, which appears at the
  36728. bottom of the window and contains test results from the bots.
  36729. Currently, you can activate the pane by mousing over one of the builder
  36730. names associated with a failing test.
  36731. This is just a first iteration of the UI. There's no way to resize or
  36732. zoom in on elements of the details pane, and images likely aren't sized
  36733. correctly, but it's a place to start.
  36734. * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js:
  36735. - Add constants for our data attributes so we don't typo them!
  36736. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  36737. - Add DOM structure for the details pane.
  36738. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36739. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36740. - Bind events for showing and hiding the details pane.
  36741. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36742. - Reduce the number of result types that we query for to avoid
  36743. overfilling the details pane. We'll probably need another
  36744. solution here in the long-term. For example, we could use tabs
  36745. to pack more results into the pane.
  36746. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36747. * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  36748. - Now that we're using the config package during testing, we need
  36749. to include it in the testing HTML.
  36750. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36751. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36752. - Change the DOM structure of the results detail to make it fit
  36753. nicely in the details pane (rather than flowing freely in the
  36754. body, as it did before).
  36755. 2011-07-13 Adam Roben <aroben@apple.com>
  36756. Make TestFailures show every time a possibly-flaky test failed, but hide it by default
  36757. It's useful to be able to see every time a flaky test failed to see whether it failed the
  36758. same way every time. But doing so takes a lot of space, so the list of failures is now
  36759. collapsed by default and can be revealed using a disclosure triangle.
  36760. Fixes <http://webkit.org/b/64455> TestFailures page doesn't show as much information for
  36761. flaky tests as I would like, even though the page is already so long
  36762. Reviewed by Dimitri Glazkov.
  36763. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
  36764. (FlakyLayoutTestDetector.prototype.allFailures): Replaced flakinessExamples with this
  36765. function. Now returns all failures for the given test.
  36766. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector_unittests.js:
  36767. Added. This just contains some simple tests of the FlakyLayoutTestDetector class. We'll add
  36768. more over time.
  36769. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  36770. (LayoutTestHistoryAnalyzer.prototype.start): Updated the documentation comment to reflect
  36771. that we no longer return passing builds for possibly-flaky tests.
  36772. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  36773. (.existing-bugs-list, .suspect-revisions-list, .flakiness-examples-list): Make the list of
  36774. flakiness examples small, too, since it can get quite long.
  36775. (.disclosure-triangle):
  36776. (.expanded > .disclosure-triangle):
  36777. Simple styles for the disclosure triangle.
  36778. (.flakiness-examples-list): Collapse the list by default.
  36779. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  36780. (ViewController.prototype._displayBuilder): Pass the total number of builds analyzed to
  36781. _domForPossiblyFlakyTests.
  36782. (ViewController.prototype._domForPossiblyFlakyTests): Put a disclosure triangle to the left
  36783. of each test name, and the number of failures to the right. When the disclosure triangle is
  36784. clicked for the first time, we build up the list of failures and expand the element. After
  36785. that we just collapse or expand the element on subsequent clicks.
  36786. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  36787. Pulled in new tests.
  36788. 2011-07-13 Adam Roben <aroben@apple.com>
  36789. Teach TestFailures to understand NRWT's output when it exits early due to too many failures
  36790. Fixes <http://webkit.org/b/64456> TestFailures page reports way too many failures when NRWT
  36791. exits early
  36792. Reviewed by Dimitri Glazkov.
  36793. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  36794. (Builder.prototype.getNumberOfFailingTests): Relaxed the "Exiting early" test not to require
  36795. it to be at the beginning of the line, since NRWT prints a bunch of junk earlier in the
  36796. line. Tightened up the regex that's used to parse the number of failing tests to require the
  36797. leading number to be followed by whitespace so that we won't parse the "2011" in
  36798. "2011-07-13" as a number of failures.
  36799. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  36800. Added a test for the above.
  36801. 2011-07-12 Dimitri Glazkov <dglazkov@chromium.org>
  36802. Extract model-like TestExpectationLine and TestExpectationFile from TestExpectations.
  36803. https://bugs.webkit.org/show_bug.cgi?id=64386
  36804. This is the first step in converting TestExpectations to a real model.
  36805. * TestExpectationsLine represents a line in the test_expectations.txt file, and
  36806. * TestExpectationsFile represents the file, which is a collection of lines.
  36807. Reviewed by Adam Barth.
  36808. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  36809. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
  36810. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  36811. 2011-07-13 Xan Lopez <xlopez@igalia.com>
  36812. [GTK] Do not grab focus too early in DRT.
  36813. Reviewed by Gustavo Noronha.
  36814. It causes a layout to happen and a progress signal to be emitted
  36815. since r90900, but at this point we don't have a
  36816. LayoutTestController object and we'll eventually crash. Since we
  36817. already grab focus at the beginning of runTest() this is
  36818. redundant, so get rid of it to fix the crash.
  36819. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  36820. (main): remove call to grab_focus
  36821. 2011-07-13 Sheriff Bot <webkit.review.bot@gmail.com>
  36822. Unreviewed, rolling out r90893 and r90894.
  36823. http://trac.webkit.org/changeset/90893
  36824. http://trac.webkit.org/changeset/90894
  36825. https://bugs.webkit.org/show_bug.cgi?id=64441
  36826. NRWT still doesn't work on qt-mac platform (Requested by Ossy
  36827. on #webkit).
  36828. * Scripts/run-webkit-tests:
  36829. (useNewRunWebKitTests):
  36830. 2011-07-13 Csaba Osztrogonác <ossy@webkit.org>
  36831. [Qt] NRWT should pick up the right httpd config file
  36832. https://bugs.webkit.org/show_bug.cgi?id=64086
  36833. * Scripts/run-webkit-tests: Enable NRWT on qt-mac platform after r90810.
  36834. (useNewRunWebKitTests):
  36835. 2011-07-12 Mark Rowe <mrowe@apple.com>
  36836. Fix the 32-bit build.
  36837. * DumpRenderTree/mac/UIDelegate.mm:
  36838. (-[UIDelegate webView:exceededApplicationCacheOriginQuotaForSecurityOrigin:totalSpaceNeeded:]):
  36839. Cast the NSUInteger value to unsigned long to match the format specifier.
  36840. 2011-07-12 Adam Barth <abarth@webkit.org>
  36841. Improve garden-o-matic UI when the bots fail to report revision numbers
  36842. https://bugs.webkit.org/show_bug.cgi?id=64427
  36843. Reviewed by Dimitri Glazkov.
  36844. At least Win (dbg)(2) seems to fail to report the SVN revision number
  36845. in full_results.json. This patch makes garden-o-matic more robust to
  36846. missing revision numbers.
  36847. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36848. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36849. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36850. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36851. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36852. 2011-07-12 Adam Barth <abarth@webkit.org>
  36853. Adjust garden-o-matic layout to use fewer lines
  36854. https://bugs.webkit.org/show_bug.cgi?id=64422
  36855. Reviewed by Ojan Vafai.
  36856. This patch effectively merges the test name line with the list of
  36857. builders on which the test fails. Each test failure now occupies two
  36858. lines instead of three.
  36859. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36860. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36861. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36862. 2011-07-12 Adam Barth <abarth@webkit.org>
  36863. garden-o-matic should label tests failures of new tests as such
  36864. https://bugs.webkit.org/show_bug.cgi?id=64421
  36865. Reviewed by Ojan Vafai.
  36866. Also, we shouldn't dim failures of new tests, even if we've only seen
  36867. them once because they're likely to be real problems that need
  36868. attention.
  36869. * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  36870. * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout.js: Added.
  36871. * Scripts/webkitpy/tool/servers/data/gardeningserver/checkout_unittests.js: Added.
  36872. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  36873. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36874. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36875. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36876. * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  36877. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36878. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  36879. 2011-07-12 Adam Barth <abarth@webkit.org>
  36880. garden-o-matic should display how many times we've seen a failure
  36881. https://bugs.webkit.org/show_bug.cgi?id=64417
  36882. Reviewed by Ojan Vafai.
  36883. This patch adds some UI to display how many times we've seen a given
  36884. failure, which can be helpful for determining whether that failure is a
  36885. real failure or a flaky test.
  36886. When a failure has only been seen once (i.e., only a single run on a
  36887. single bot), we set the opacity of to 50% to avoid distracting the
  36888. gardener.
  36889. This patch also refactors the failure walker to have a simpler API
  36890. internally by moving from an object-oriented paradigm to a functional
  36891. paradigm.
  36892. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36893. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36894. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36895. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36896. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36897. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36898. 2011-07-12 Chris Rogers <crogers@google.com>
  36899. Enable Web Audio for chromium DRT
  36900. https://bugs.webkit.org/show_bug.cgi?id=64409
  36901. Reviewed by James Robinson.
  36902. * DumpRenderTree/chromium/TestShell.cpp:
  36903. (TestShell::TestShell):
  36904. 2011-07-12 Adam Barth <abarth@webkit.org>
  36905. Tweak some UI in garden-o-matic now that the tree actually has a
  36906. failure and I can see what this all looks like.
  36907. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css:
  36908. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36909. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36910. 2011-07-12 Joseph Pecoraro <joepeck@webkit.org>
  36911. Unreviewed. Skipping a few tests which fail due to differing output
  36912. Unit tests shouldn't be hitting the disk anyway. It's possible Config should move off of Port and onto Tool/Host directly.
  36913. * Scripts/webkitpy/layout_tests/port/factory.py:
  36914. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  36915. * Scripts/webkitpy/layout_tests/port/gtk.py:
  36916. * Scripts/webkitpy/layout_tests/port/gtk_unittest.py: Added.
  36917. * Scripts/webkitpy/layout_tests/port/mac.py:
  36918. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  36919. * Scripts/webkitpy/layout_tests/port/qt.py:
  36920. * Scripts/webkitpy/layout_tests/port/qt_unittest.py:
  36921. * Scripts/webkitpy/layout_tests/port/webkit.py:
  36922. 2011-07-12 Adam Roben <aroben@apple.com>
  36923. Teach TestFailures to recognize when run-webkit-tests gets killed by buildbot
  36924. Fixes <http://webkit.org/b/64358> TestFailures page thinks all tests passed in
  36925. http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14672
  36926. Reviewed by Daniel Bates.
  36927. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  36928. (Builder.prototype.getNumberOfFailingTests): If run-webkit-tests exited with a non-zero
  36929. exit status but we didn't find any failure counts, assume that there was some error that
  36930. caused run-webkit-tests to die early (like being killed by buildbot due to a timeout).
  36931. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  36932. Added a new test that shows that we get a failingTestCount of -1 when run-webkit-tests dies
  36933. early.
  36934. (runGetNumberOfFailingTestsTest): Moved most code here from the only pre-existing test in this
  36935. file.
  36936. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  36937. (LayoutTestResultsLoader.prototype.start): Bump the cache number so old cached data that was
  36938. tainted by the bug fixed in this patch will be evicted.
  36939. 2011-07-12 Adam Barth <abarth@webkit.org>
  36940. cr-linux-ews complains about tests that aren't actually failing
  36941. https://bugs.webkit.org/show_bug.cgi?id=64367
  36942. The underlying problem here is that full_results.json doesn't have
  36943. enough information to determine whether a given test result was
  36944. expected because whether an actual result is expected depends on
  36945. whether full_results.json was generated duing a test run that included
  36946. pixel tests.
  36947. The right long-term solution is to make full_results.json a complete
  36948. description of what happened durning a test run. In this patch
  36949. however, to stop the spam, this patch makes the jsonresultsparser
  36950. ignore pixel failures.
  36951. (I'm landing this patch unreviewed in order to stop the bots from
  36952. spamming. I'll happily address any review comments in a follow-up
  36953. patch.)
  36954. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  36955. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  36956. 2011-07-12 Adam Barth <abarth@webkit.org>
  36957. Re-work garden-o-matic UI to begin to look like the mocks
  36958. https://bugs.webkit.org/show_bug.cgi?id=64334
  36959. Reviewed by Dimitri Glazkov.
  36960. This patch changes how we display failures to be more like the mock the
  36961. dglazkov made. We now can display the same information much more
  36962. compactly.
  36963. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  36964. * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js:
  36965. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  36966. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.css: Added.
  36967. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  36968. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  36969. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  36970. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  36971. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  36972. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  36973. 2011-07-11 Adam Roben <aroben@apple.com>
  36974. Extract TestFailures's bug-filing code into two new classes
  36975. Fixes <http://webkit.org/b/64300> TestFailures page's new-bug-filing code is a mess!
  36976. Reviewed by Darin Adler and Adam Barth.
  36977. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
  36978. (Buildbot.prototype.resultsDirectoryURL): Changed to return a URI-encoded URL. Otherwise the
  36979. URL isn't valid (and it's harder to mock this function).
  36980. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot_unittests.js:
  36981. Added. Just tests the above change (for now).
  36982. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  36983. Added a license header, enclosed everything in a closure to avoid polluting the global
  36984. namespace, changed the test name to actually describe the passing condition, and replaced
  36985. uses of equals() with equal(). (The latter is the actual name of the function, and matches
  36986. deepEqual, etc.)
  36987. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm.js: Added.
  36988. (NewBugForm): This class knows how to construct a <form> used for filing new bugs in
  36989. Bugzilla based on some parameters.
  36990. (NewBugForm.prototype.domElement): Creates and returns the <form> element. Code came from
  36991. ViewController.prototype._domForNewAndExistingBugs.
  36992. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NewBugForm_unittests.js:
  36993. Added. Tests the above code.
  36994. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm.js: Added.
  36995. (TestFailureBugForm): This class knows how to construct a <form> element used for filing new
  36996. bugs specifically about test failures. Code came from
  36997. ViewController.prototype._domForNewAndExistingBugs.
  36998. (TestFailureBugForm.prototype.domElement): Slightly customizes the <form> element returned
  36999. by NewBugForm.
  37000. (TestFailureBugForm.prototype._computeOperatingSystem):
  37001. (TestFailureBugForm.prototype._computePlatform):
  37002. (TestFailureBugForm.prototype._createBugTitle):
  37003. (TestFailureBugForm.prototype._failingResultsHTMLURL):
  37004. (TestFailureBugForm.prototype._failingRevision):
  37005. (TestFailureBugForm.prototype._passingRevision):
  37006. (TestFailureBugForm.prototype._regressionRangeString):
  37007. Code came from ViewController.prototype._domForNewAndExistingBugs. I broke it out into
  37008. separate functions to break up the rat's nest a bit.
  37009. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailureBugForm_unittests.js:
  37010. Added. Tests the above code.
  37011. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  37012. (ViewController.prototype._domForNewAndExistingBugs): Moved code from here to
  37013. TestFailureBugForm/NewBugForm, and changed this code to use a TestFailureBugForm.
  37014. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  37015. NewBugForm/TestFailureBugForm.js.
  37016. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  37017. Added new tests and required files.
  37018. 2011-07-12 Adam Roben <aroben@apple.com>
  37019. Test that no intermediate WTF::Strings are created when concatenating with string literals
  37020. Test for <http://webkit.org/b/63330> Concatenating string literals and WTF::Strings using
  37021. operator+ is suboptimal
  37022. Reviewed by Darin Adler.
  37023. * TestWebKitAPI/Tests/WTF/StringOperators.cpp: Added.
  37024. (TestWebKitAPI::TEST): Test that a bunch of different string concatenation expressions don't
  37025. create any intermediate WTF::Strings while they're being evaluated.
  37026. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  37027. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  37028. Added new file.
  37029. 2011-07-12 Eric Seidel <eric@webkit.org>
  37030. [Qt] NRWT should pick up the right httpd config file
  37031. https://bugs.webkit.org/show_bug.cgi?id=64086
  37032. Reviewed by Adam Barth.
  37033. This is more fall-out from the Port class inappropriately encapsulating
  37034. both platform and port knowledge. We need to split out some of this
  37035. platform knowledge into a separate class which can be better shared
  37036. between ports.
  37037. The fix was to move all the _path_to_apache_config_file logic down
  37038. into the WebKitPort baseclass so that all of the ports can find the
  37039. right apache config file, regardless of what platform they may be running on.
  37040. I did not move this down into base.Port (even though I considered it).
  37041. Chromium duplicates some of this logic, but since they have separate
  37042. subclasses for each port-OS combination (e.g. ChromiumMac, ChromiumWin)
  37043. they wouldn't notice the change. Eventually we'll move this logic
  37044. out of Port entirely, and then it will be shared by all ports.
  37045. I also cleaned up the http-config logic for ORWT while I was there,
  37046. although since we're killing that code, I'm happy to revert that part
  37047. of the change if changing it is viewed as needlessly risky.
  37048. During this cleanup, I noticed that no ports use the "default" httpd.conf
  37049. which is left over from Mac OS X Tiger (and old linux distros) which used
  37050. Apache 1.3. I've removed httpd.conf (and associated support in ORWT) since
  37051. we no longer support any ports which use this httpd.conf.
  37052. * Scripts/webkitperl/httpd.pm:
  37053. (getHTTPDConfigPathForTestDirectory):
  37054. * Scripts/webkitpy/layout_tests/port/base.py:
  37055. * Scripts/webkitpy/layout_tests/port/gtk.py:
  37056. * Scripts/webkitpy/layout_tests/port/mac.py:
  37057. * Scripts/webkitpy/layout_tests/port/qt.py:
  37058. * Scripts/webkitpy/layout_tests/port/webkit.py:
  37059. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  37060. * Scripts/webkitpy/layout_tests/port/win.py:
  37061. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  37062. 2011-07-11 Hironori Bono <hbono@chromium.org>
  37063. Reviewed by Adam Roben.
  37064. Implement layoutTestController.setTextDirection for WebKit2 and Windows.
  37065. https://bugs.webkit.org/show_bug.cgi?id=61931
  37066. This change implements layoutTextController.setTextDirection for WebKit2
  37067. and Windows so we can run a layout test added by r87770 on them. Each
  37068. implementation adds a wrapper function for Editor::setBaseWritingDirection()
  37069. so LayoutTestController can call it.
  37070. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  37071. (LayoutTestController::setTextDirection): Implemented the binding function
  37072. for layoutTestController.setTextDirection (Windows).
  37073. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  37074. Added a binding function for layoutTestController.setTextDirection (WebKit2).
  37075. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp: ditto.
  37076. (WTR::LayoutTestController::setTextDirection):
  37077. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: ditto.
  37078. 2011-07-11 Raphael Kubo da Costa <kubo@profusion.mobi>
  37079. [EFL] ImageDiff: Make sure gEcoreEvas is destroyed at the right time.
  37080. https://bugs.webkit.org/show_bug.cgi?id=64293
  37081. Reviewed by Kent Tamura.
  37082. gEcoreEvas was being destroyed after shutdownEfl() was called, so the
  37083. call to ecore_evas_free() failed.
  37084. We now shut it down manually before shutdownEfl() is called.
  37085. * DumpRenderTree/efl/ImageDiff.cpp:
  37086. (main): Destroy gEcoreEvas before shutting down the EFL.
  37087. 2011-07-11 Ryosuke Niwa <rniwa@webkit.org>
  37088. Make Chromium Mac and Linux tests bot core builders
  37089. https://bugs.webkit.org/show_bug.cgi?id=63196
  37090. Reviewed by Adam Barth.
  37091. Added Chromium Mac and Linux Release Tests bots core builders.
  37092. Also rearranged the order of bots so that test bots show up right next to
  37093. respective builders.
  37094. * BuildSlaveSupport/build.webkit.org-config/config.json:
  37095. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  37096. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  37097. 2011-07-11 Raphael Kubo da Costa <kubo@profusion.mobi>
  37098. [EFL] DRT: Add code related to font management.
  37099. https://bugs.webkit.org/show_bug.cgi?id=63989
  37100. Reviewed by Kent Tamura.
  37101. The added files are responsible for managing fontconfig and adding the
  37102. fonts required by some layout tests to fontconfig's path.
  37103. * DumpRenderTree/efl/FontManagement.cpp: Added.
  37104. (getFontDirectories):
  37105. (getFontFiles):
  37106. (addFontDirectories):
  37107. (addFontFiles):
  37108. (addFontsToEnvironment):
  37109. * DumpRenderTree/efl/FontManagement.h: Added.
  37110. 2011-07-08 Dirk Pranke <dpranke@chromium.org>
  37111. nrwt: linting fixes
  37112. https://bugs.webkit.org/show_bug.cgi?id=64225
  37113. Reviewed by Eric Siedel.
  37114. Miscellaneous linting fixes. The most notable change is that
  37115. we add public attributes for user, executive, filesystem, and
  37116. options on the Port object, so we don't have to refer to the
  37117. "protected" versions all over the place".
  37118. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  37119. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  37120. * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
  37121. * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py:
  37122. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  37123. * Scripts/webkitpy/layout_tests/port/base.py:
  37124. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  37125. 2011-07-11 Ryosuke Niwa <rniwa@webkit.org>
  37126. webkit-patch roll-chromium-deps no longer works
  37127. https://bugs.webkit.org/show_bug.cgi?id=64324
  37128. Reviewed by James Robinson.
  37129. Lower the minimum commit message length to 10.
  37130. * Scripts/webkitpy/tool/steps/commit.py:
  37131. 2011-07-11 Alice Boxhall <aboxhall@chromium.org>
  37132. Convert json_results_generator.py to output version 4 JSON.
  37133. https://bugs.webkit.org/show_bug.cgi?id=60869
  37134. Reviewed by Ojan Vafai.
  37135. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  37136. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  37137. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  37138. 2011-07-11 Martin Robinson <mrobinson@igalia.com>
  37139. [GTK] [NRWT] Pixel tests do not work
  37140. https://bugs.webkit.org/show_bug.cgi?id=64091
  37141. Reviewed by Eric Seidel.
  37142. Fix pixel test runs for GTK+ new-run-webkit-tests by exposing the
  37143. path to the ImageDiff binary.
  37144. * Scripts/webkitpy/layout_tests/port/gtk.py: Implement _path_to_image_diff.
  37145. 2011-07-11 Dirk Pranke <dpranke@chromium.org>
  37146. Fix hang on win32 in a multiprocessing test that shouldn't have been running.
  37147. Unreviewed, build fix.
  37148. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  37149. 2011-07-11 Adam Roben <aroben@apple.com>
  37150. Don't count leaks as test failures on TestFailures's front page
  37151. As a bonus, this patch adds our first unit test.
  37152. Fixes <http://webkit.org/b/64303> REGRESSION (r90489): TestFailures page says far more tests
  37153. are failing on the Leaks bot than actually are
  37154. Reviewed by Adam Barth.
  37155. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  37156. (Builder.prototype.getNumberOfFailingTests): Exclude lines containing "leak" when summing
  37157. failure counts.
  37158. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder_unittests.js:
  37159. Added. Contains a simple test to show that leaks aren't counted as test failures.
  37160. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/run-unittests.html:
  37161. Added. This is the test harness.
  37162. 2011-06-14 Mike Stegeman <mrstegeman@gmail.com>
  37163. [GTK] Add API to allow setting local storage database path
  37164. https://bugs.webkit.org/show_bug.cgi?id=62091
  37165. Reviewed by Martin Robinson and Gustavo Noronha.
  37166. Expose the path of the localStorage databases through a setting
  37167. to allow HTML5 localStorage to be persistent. New setting is:
  37168. html5-local-storage-database-path
  37169. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  37170. (resetDefaultsToConsistentValues):
  37171. 2011-07-11 Adam Barth <abarth@webkit.org>
  37172. garden-o-matic should be able to rebaseline tests
  37173. https://bugs.webkit.org/show_bug.cgi?id=64186
  37174. Reviewed by Eric Seidel.
  37175. This patch contains a simple HTTP server binding for the
  37176. rebaseline-test command. The frontend will appear in another patch.
  37177. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  37178. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
  37179. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  37180. 2011-07-11 Adam Barth <abarth@webkit.org>
  37181. Add some basic UI for showing regression ranges
  37182. https://bugs.webkit.org/show_bug.cgi?id=64243
  37183. Reviewed by Eric Seidel.
  37184. This UI is all temporary. It exists mostly just to have some buttons
  37185. to click to exercise the code.
  37186. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  37187. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  37188. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  37189. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  37190. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  37191. 2011-07-11 Adam Barth <abarth@webkit.org>
  37192. garden-o-matic should be able to determine which revisions caused a given failure
  37193. https://bugs.webkit.org/show_bug.cgi?id=64189
  37194. Reviewed by Adam Roben.
  37195. Walking the failure history looking for failures turns out to be
  37196. slightly tricky because the network requests are asynchronous.
  37197. Currently we do all the fetches serially and our cache is unbounded.
  37198. We'll probably optimize both those parameters eventually.
  37199. This patch also generalizes some functionality in the unit testing
  37200. framework to make testing this sort of code easier.
  37201. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  37202. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  37203. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  37204. 2011-07-11 Adam Barth <abarth@webkit.org>
  37205. Add a webkit-patch command for rebaselining an individual test
  37206. https://bugs.webkit.org/show_bug.cgi?id=64246
  37207. Reviewed by Eric Seidel.
  37208. This patch introduces a command that's able to rebaseline a single
  37209. test. Currently, the command works only with the build.chromium.org
  37210. buildbots, but extending it to work with the build.webkit.org bots
  37211. shouldn't be that hard.
  37212. A complete rebaseling tool should also include an "optimize baselines"
  37213. command (which moves/deletes baselines in order to reduce the number of
  37214. expected results files), but that will come in a future patch.
  37215. Really BuilderToPort should be merged into builders.py, but I'm going
  37216. to save that for a future patch as well. (We need to stop shaving yaks
  37217. at some point.)
  37218. * Scripts/webkitpy/tool/commands/rebaseline.py:
  37219. 2011-07-11 Adam Barth <abarth@webkit.org>
  37220. garden-o-matic should be able to roll out patches
  37221. https://bugs.webkit.org/show_bug.cgi?id=64185
  37222. Reviewed by Eric Seidel.
  37223. This gardening server API is simply a binding to the rollout machinery
  37224. already present in webkit-patch.
  37225. * Scripts/webkitpy/tool/commands/gardenomatic.py:
  37226. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  37227. * Scripts/webkitpy/tool/servers/gardeningserver_unittest.py: Added.
  37228. 2011-07-11 Csaba Osztrogonác <ossy@webkit.org>
  37229. [Qt][Mac] Unreviewed fix after r90746.
  37230. * Scripts/run-webkit-tests:
  37231. (useNewRunWebKitTests): Really disable NRWT for qt-mac platform.
  37232. 2011-07-11 Adam Roben <aroben@apple.com>
  37233. Teach TestFailures that ORWT's results.html file might be missing due to all tests passing
  37234. There are three reasons why we might fail to fetch ORWT's results.html:
  37235. - All tests passed, so no results.html was generated
  37236. - Some error during the test run caused results.html not to be generated (e.g., ORWT
  37237. timed out)
  37238. - Some network error occurred when fetching results.html
  37239. We were failing to account for the first possibility in some cases. For test runs before
  37240. r89610, we first check build.webkit.org/json to determine how many tests failed and whether
  37241. ORWT exited early due to too many failures; if all tests passed then we don't fetch
  37242. results.html at all. r89610 changed ORWT to put information in results.html about exiting
  37243. early due to too many failures, so we no longer needed to check build.webkit.org/json to get
  37244. that information, and in r89619 I changed TestFailures to do just that. But I forgot that we
  37245. still needed to check build.webkit.org/json to find out if all tests passed!
  37246. Now, for test runs after r89610, we check results.html first, and then check
  37247. build.webkit.org/json if we fail to fetch results.html. This lets us distinguish between all
  37248. tests passing and the error cases.
  37249. Fixes <http://webkit.org/b/64280> TestFailures page can't pinpoint that r90699 caused 13
  37250. tests to fail on Windows 7 Release (WebKit2 Tests)
  37251. Reviewed by David Kilzer.
  37252. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  37253. (LayoutTestResultsLoader.prototype.start): Bumped the cache version so that old, buggy
  37254. cached data will get evicted. We were marking builds where all tests passed as errors!
  37255. (LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added success/error callback
  37256. parameters to the fetchAndParseResultsHTML helper function, and added a similar
  37257. fetchNumberOfFailingTests function that fetches data from build.webkit.org/json (code came
  37258. from later in the function). For test runs before r89610, we first check
  37259. build.webkit.org/json then check results.html. For builds after r89610, we first check
  37260. results.html and then check build.webkit.org/json if we couldn't fetch results.html.
  37261. 2011-07-11 Csaba Osztrogonác <ossy@webkit.org>
  37262. new-run-webkit-tests does not support qt-arm or qt-4.8 results
  37263. https://bugs.webkit.org/show_bug.cgi?id=64071
  37264. [Qt] NRWT should pick up the right httpd config file
  37265. https://bugs.webkit.org/show_bug.cgi?id=64086
  37266. Reviewed by Zoltán Herczeg.
  37267. * Scripts/run-webkit-tests: Disable NRWT for qt-mac, qt-arm and qt-4.8 platforms until fix.
  37268. (useNewRunWebKitTests):
  37269. 2011-07-11 Kenichi Ishibashi <bashi@chromium.org>
  37270. Add TestNetscapePlugIn/Tests/FormValue.cpp to DRT build files
  37271. https://bugs.webkit.org/show_bug.cgi?id=64248
  37272. Reviewed by Kent Tamura.
  37273. * DumpRenderTree/DumpRenderTree.gypi: Added FormValue.cpp.
  37274. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Ditto.
  37275. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Ditto.
  37276. * GNUmakefile.am: Ditto.
  37277. 2011-07-10 Kenichi Ishibashi <bashi@chromium.org>
  37278. Let plugins participate in form submission
  37279. https://bugs.webkit.org/show_bug.cgi?id=13061
  37280. Adds NPPVformValue support to the testing plugin.
  37281. Reviewed by Anders Carlsson.
  37282. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added FormValue.cpp
  37283. * DumpRenderTree/TestNetScapePlugIn/Tests/FormValue.cpp: Added.
  37284. (FormValue::FormValue): Ditto.
  37285. (FormValue::NPP_GetValue): Ditto.
  37286. 2011-07-11 Roland Steiner <rolandsteiner@chromium.org>
  37287. Reviewed by Tony Chang.
  37288. Complete functions in filesystem.py
  37289. https://bugs.webkit.org/show_bug.cgi?id=63528
  37290. - missing text file functions added
  37291. - functions sorted
  37292. - removed 'append' optional parameters (were unused)
  37293. - adapted filesystem_mock in the same way
  37294. * Scripts/webkitpy/common/system/filesystem.py:
  37295. * Scripts/webkitpy/common/system/filesystem_mock.py:
  37296. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  37297. 2011-07-10 Adam Barth <abarth@webkit.org>
  37298. Clean up style in fallback path calculation
  37299. https://bugs.webkit.org/show_bug.cgi?id=64239
  37300. Reviewed by Daniel Bates.
  37301. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  37302. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  37303. * Scripts/webkitpy/layout_tests/port/mac.py:
  37304. * Scripts/webkitpy/layout_tests/port/win.py:
  37305. 2011-07-10 Balazs Kelemen <kbalazs@webkit.org>
  37306. [Qt][WK2] Implement the rest of WTR::PlatformWebView
  37307. https://bugs.webkit.org/show_bug.cgi?id=63630
  37308. Reviewed by Kenneth Rohde Christiansen.
  37309. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  37310. (WTR::PlatformWebView::windowFrame):
  37311. (WTR::PlatformWebView::setWindowFrame):
  37312. 2011-07-10 Mark Rowe <mrowe@apple.com>
  37313. Teach build-webkit how to find the latest WebKitSystemInterface binary.
  37314. * Scripts/build-webkit:
  37315. 2011-07-09 Adam Roben <aroben@apple.com>
  37316. Teach TestFailures to abbreviate the examples of test flakiness
  37317. These lists can get quite long, and it's not really helpful in most cases to have soooooo
  37318. many examples of flakiness.
  37319. Fixes <http://webkit.org/b/64203> Lists of flaky revisions on TestFailures page can get so
  37320. long they're hard to navigate
  37321. Reviewed by Dan Bates.
  37322. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
  37323. (FlakyLayoutTestDetector.prototype.flakinessExamples): If we have more than a certain number
  37324. of examples, replace the middle items with a separator.
  37325. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  37326. (.flakiness-example-separator): Added styles for the separator.
  37327. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  37328. (ViewController.prototype._domForPossiblyFlakyTests): Use a vertical ellipsis to represent
  37329. the separator.
  37330. 2011-07-09 Dirk Pranke <dpranke@chromium.org>
  37331. nrwt: stack traces from worker-side exceptions aren't very useful inside test-webkitpy
  37332. https://bugs.webkit.org/show_bug.cgi?id=64218
  37333. Reviewed by Eric Seidel.
  37334. Exceptions aren't picklable and can't be sent across the
  37335. manager/worker message queue without losing information. NRWT
  37336. handles this by turning the stack trace into a set of strings,
  37337. and logging the strings when we receive an exception from the
  37338. worker. However, when you are running tests and something
  37339. crashes on the worker side, test-webkitpy prints the
  37340. manager-side stack trace, which is just confusing and useless.
  37341. This patch changes the logic so that exceptions are passed
  37342. through as-is when the worker and manager are in the same
  37343. process (the --worker-model=inline option). This increases the
  37344. code paths slightly but makes crashes much more useful.
  37345. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  37346. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  37347. * Scripts/webkitpy/layout_tests/controllers/message_broker.py:
  37348. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  37349. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  37350. 2011-07-09 Darin Fisher <darin@chromium.org>
  37351. Eliminate bad dependency on gfx::Point.
  37352. https://bugs.webkit.org/show_bug.cgi?id=64228
  37353. Reviewed by Kent Tamura.
  37354. * DumpRenderTree/chromium/EventSender.cpp:
  37355. (initMouseEvent):
  37356. 2011-07-08 Ojan Vafai <ojan@chromium.org>
  37357. pull static dashboard files into the appengine server from the chromium repository
  37358. https://bugs.webkit.org/show_bug.cgi?id=64208
  37359. Reviewed by Dirk Pranke.
  37360. These files belong in the WebKit repo since they are tied primarily to the webkit tests.
  37361. They have some extra bits to support chromium's gtests, but that seems fine.
  37362. Mainly, this will allow other WebKit hackers to hack on the dashboards.
  37363. As a nice side-effect, we can now push the dashboard files when we do appengine pushes
  37364. instead of the weird thing we used to do of pulling them from the Chromium repository
  37365. and storing them in the appengine datastore. This allows for cleaning up a lot of code
  37366. and will likely make the dashboards load a bit faster.
  37367. The new JS files don't fully match WebKit style, but I'd like to clean that up in a
  37368. followup patch if possible to maintain my sanity with this patch.
  37369. * TestResultServer/app.yaml:
  37370. * TestResultServer/handlers/dashboardhandler.py: Removed.
  37371. * TestResultServer/handlers/menu.py:
  37372. * TestResultServer/main.py:
  37373. * TestResultServer/model/dashboardfile.py: Removed.
  37374. * TestResultServer/static-dashboards/LICENSE.dygraph.txt: Added.
  37375. * TestResultServer/static-dashboards/README.dygraph.txt: Added.
  37376. * TestResultServer/static-dashboards/README.webtreemap.txt: Added.
  37377. * TestResultServer/static-dashboards/aggregate_results.html: Added.
  37378. * TestResultServer/static-dashboards/builders.js: Added.
  37379. * TestResultServer/static-dashboards/dashboard_base.js: Added.
  37380. * TestResultServer/static-dashboards/dygraph-combined.js: Added.
  37381. * TestResultServer/static-dashboards/flakiness_dashboard.html: Added.
  37382. * TestResultServer/static-dashboards/flakiness_dashboard_tests.js: Added.
  37383. * TestResultServer/static-dashboards/timeline_explorer.html: Added.
  37384. * TestResultServer/static-dashboards/treemap.html: Added.
  37385. * TestResultServer/static-dashboards/webtreemap.css: Added.
  37386. * TestResultServer/static-dashboards/webtreemap.js: Added.
  37387. * TestResultServer/stylesheets/dashboardfile.css: Removed.
  37388. * TestResultServer/stylesheets/menu.css:
  37389. * TestResultServer/templates/dashboardfilelist.html: Removed.
  37390. * TestResultServer/templates/menu.html:
  37391. 2011-07-08 Adam Roben <aroben@apple.com>
  37392. Make TestFailures's list of flaky tests look more like the list of non-flaky tests
  37393. Fixes <http://webkit.org/b/64204> TestFailures page's flaky tests list is ugly!
  37394. Reviewed by Daniel Bates.
  37395. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  37396. (#failure-history, #possibly-flaky-tests): Expanded this rule to apply to the list of flaky
  37397. tests.
  37398. (#failure-history > li, #possibly-flaky-tests > li): Ditto, but moved the 50px left padding
  37399. from here...
  37400. (#failure-history > li): ...to here.
  37401. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  37402. (ViewController.prototype._domForPossiblyFlakyTests): Give the list an id attribute for
  37403. styling purposes.
  37404. 2011-07-08 Jeffrey Pfau <jpfau@apple.com>
  37405. Unreviewed, add myself as committer.
  37406. * Scripts/webkitpy/common/config/committers.py:
  37407. 2011-07-08 Adam Barth <abarth@webkit.org>
  37408. TestResultsServer should keep old test results
  37409. https://bugs.webkit.org/show_bug.cgi?id=64199
  37410. Reviewed by Ojan Vafai.
  37411. Having historical data will help us do failure archeology.
  37412. * TestResultServer/handlers/testfilehandler.py:
  37413. * TestResultServer/model/testfile.py:
  37414. * TestResultServer/templates/showfilelist.jsonp: Added.
  37415. 2011-07-08 Adam Roben <aroben@apple.com>
  37416. Remove commit-log-editor's dependency on Module::Load::Conditional
  37417. This module isn't available in Perl 5.8.8 (the version used on Leopard).
  37418. Fixes <http://webkit.org/b/64198> REGRESSION (r90583):
  37419. webkitpy.common.checkout.checkout_unittest failing on Leopard
  37420. Reviewed by Daniel Bates.
  37421. * Scripts/commit-log-editor: Use the new loadTermReadKey() function instead of
  37422. Module::Load::Conditional::can_load.
  37423. (loadTermReadKey): Added. Tries to load Term::ReadKey and returns true if it's successful.
  37424. 2011-07-08 Adam Roben <aroben@apple.com>
  37425. Make checkout_unittest more robust against files moving around
  37426. Fixes <http://webkit.org/b/64197> checkout_unittest contains ugly, fragile code to find the
  37427. Scripts directory
  37428. Reviewed by Adam Barth.
  37429. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  37430. (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Instantiate a real SCM
  37431. object and use it to get the path to the Scripts directory, rather than hard-coding the
  37432. relative path from this file to Scripts.
  37433. 2011-07-08 Adam Roben <aroben@apple.com>
  37434. Make TestFailures remember that run-webkit-tests timed out, even across reloads
  37435. Fixes <http://webkit.org/b/64193> TestFailures page incorrectly thinks all tests passed in
  37436. http://build.webkit.org/builders/Windows%207%20Release%20(Tests)/builds/14589 after a reload
  37437. Reviewed by Daniel Bates.
  37438. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  37439. (LayoutTestResultsLoader.prototype.start): Store an "error" attribute in the cached data.
  37440. When true, it indicates that there was an error retrieving the results for this build and
  37441. that the errorCallback should be called.
  37442. 2011-07-08 Adam Barth <abarth@webkit.org>
  37443. Teach garden-o-matic how to display test results
  37444. https://bugs.webkit.org/show_bug.cgi?id=64141
  37445. Reviewed by Ojan Vafai.
  37446. This patch includes basic infrastructure for probing build.chromium.org
  37447. for test results. We only handle text and image tests, not anything
  37448. complicated like reftests. Also, we're using the revision/build
  37449. independent results store on the server, so we're avoiding that
  37450. complication for now.
  37451. It's slightly hacky that we need to probe the server to see what kinds
  37452. of results exist. A better solution would be to add CORS support to
  37453. the server or to use the local server to help.
  37454. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  37455. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  37456. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  37457. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  37458. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js:
  37459. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js:
  37460. 2011-07-08 Dirk Pranke <dpranke@chromium.org>
  37461. REGRESSION(90419) NRWT's httpd locking is broken for --child-processes=1
  37462. https://bugs.webkit.org/show_bug.cgi?id=64092
  37463. Reviewed by Tony Chang.
  37464. The code was incorrectly creating empty shards in the
  37465. shard_in_two case.
  37466. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  37467. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  37468. 2011-07-08 Adam Roben <aroben@apple.com>
  37469. Teach buildbot to figure out how many webkitpy/webkitperl tests failed
  37470. Fixes <http://webkit.org/b/64192> It's hard to tell how many test-webkitpy/test-webkitperl
  37471. tests failed when looking at build.webkit.org
  37472. Reviewed by Eric Seidel.
  37473. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  37474. (TestWithFailureCount): New class that represents a test build step which has an associated
  37475. failure count. Eventually we should move more of our test classes to deriving from this.
  37476. (TestWithFailureCount.countFailures): Method for subclasses to override to say how many
  37477. failures occurred.
  37478. (TestWithFailureCount.commandComplete):
  37479. (TestWithFailureCount.evaluateCommand):
  37480. (TestWithFailureCount.getText):
  37481. (TestWithFailureCount.getText2):
  37482. These were all based on RunGtkAPITests.
  37483. (RunPythonTests): Changed to inherit from TestWithFailureCount.
  37484. (RunPythonTests.countFailures): Parses the test-webkitpy output looking for the count of
  37485. failures.
  37486. (RunPerlTests): Changed to inherit from TestWithFailureCount.
  37487. (RunPerlTests.countFailures): Parses the test-webkitperl output looking for the count of
  37488. failures.
  37489. 2011-07-08 Adam Roben <aroben@apple.com>
  37490. Ensure $CHANGE_LOG_EMAIL_ADDRESS is set when testing webkitpy's commit-log-editor integration
  37491. Fixes <http://webkit.org/b/64180> REGRESSION (r90564): test-webkitpy failing on multiple
  37492. bots due to commit-log-editor errors
  37493. Reviewed by Adam Barth.
  37494. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  37495. (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Set
  37496. $CHANGE_LOG_EMAIL_ADDRESS to the patch author's email address. This ensures that
  37497. commit-log-editor can find a value for the committer's email, and that the committer and
  37498. author email addresses match, which will prevent commit-log-editor from inserting a "Patch
  37499. by" line in the commit message.
  37500. 2011-07-08 Andreas Kling <kling@webkit.org>
  37501. [Qt][WK2] Views should expose QActions for basic navigation.
  37502. https://bugs.webkit.org/show_bug.cgi?id=64174
  37503. Reviewed by Benjamin Poulain.
  37504. Bring the toolbar in Qt's MiniBrowser back to life.
  37505. * MiniBrowser/qt/BrowserView.cpp:
  37506. (BrowserView::navigationAction):
  37507. * MiniBrowser/qt/BrowserView.h:
  37508. * MiniBrowser/qt/BrowserWindow.cpp:
  37509. (BrowserWindow::BrowserWindow):
  37510. 2011-07-08 Adam Roben <aroben@apple.com>
  37511. Teach TestFailures how to find test names in commit-log-editor-style commit messages
  37512. TestFailures was relying on Trac turning the list of modified files in our commit messages
  37513. into an HTML list. But Trac only does this when the list of modified files is indented.
  37514. commit-log-editor doesn't indent the file list, so the list wasn't being turned into an HTML
  37515. list, which was confusing TestFailures.
  37516. TestFailures now does much simpler parsing of the commit message (i.e., just a substring
  37517. search) without relying at all on its structure.
  37518. Fixes <http://webkit.org/b/64173> TestFailures page fails to blame r90608 for breaking
  37519. fast/dom/HTMLProgressElement/progress-element-markup.html on Windows
  37520. Reviewed by David Kilzer.
  37521. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  37522. (Trac.prototype.getCommitDataForRevisionRange): Instead of trying to parse the commit
  37523. message, just return its text.
  37524. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  37525. (ViewController.prototype._domForRegressionRange): Instead of searching for test names in
  37526. each commit's list of modified files, just search for test names anywhere in the commit's
  37527. message.
  37528. 2011-07-08 Adam Barth <abarth@webkit.org>
  37529. sheriffbot is too spammy in IRC
  37530. https://bugs.webkit.org/show_bug.cgi?id=64153
  37531. Reviewed by Eric Seidel.
  37532. Reporting failures in IRC worked well when the tree was greener than it
  37533. is today. Nowadays, this feature mostly just results in spam about
  37534. false positives. If we reach a greener state, we can bring this code
  37535. back.
  37536. (Another possibility is to restrict this feature to builder bots,
  37537. rather than including testers, as we did before this patch.)
  37538. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  37539. * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  37540. 2011-07-08 Adam Roben <aroben@apple.com>
  37541. Ensure commit-log-editor adds a "Patch by" line when the author and committer are different
  37542. Previously we were only adding a "Patch by" line when the ChangeLog contained a "Reviewed
  37543. by" line. But some patches (like rollout patches) don't contain that line. Now we always add
  37544. "Patch by" to the commit log regardless of the ChangeLog's contents.
  37545. Fixes <http://webkit.org/b/64127> Committer for r90588 is commit-queue@webkit.org, but
  37546. should have been abarth@webkit.org
  37547. Reviewed by Anders Carlsson.
  37548. * Scripts/commit-log-editor:
  37549. (createCommitMessage): Try to put the "Patch by" line just above the "Reviewed by" line, as
  37550. before. If there is no "Reviewed by" line, try to put it just above the first modified file.
  37551. If all else fails, put it at the end of the commit message.
  37552. (patchAuthorshipString): Added. Code came from createCommitMessage.
  37553. 2011-07-08 Herczeg Zoltan <zherczeg@webkit.org>
  37554. Reviewed by Andreas Kling.
  37555. Adding myself as a reviewer.
  37556. * Scripts/webkitpy/common/config/committers.py:
  37557. 2011-07-07 Kevin Ollivier <kevino@theolliviers.com>
  37558. [wx] Unreviewed build fix, remove old files from the tree and update paths to new ones.
  37559. * wx/build: Removed.
  37560. * wx/build/build_utils.py: Removed.
  37561. * wx/build/settings.py: Removed.
  37562. * wx/build/waf_extensions.py: Removed.
  37563. * wx/build/wxpresets.py: Removed.
  37564. * wx/packaging/build-mac-installer.py:
  37565. 2011-07-07 Kevin Ollivier <kevino@theolliviers.com>
  37566. [wx] Unreviewed build fix, more fixes for install name issues.
  37567. * wx/packaging/build-mac-installer.py:
  37568. 2011-07-07 Dirk Pranke <dpranke@chromium.org>
  37569. test-webkitpy fails on chromium win
  37570. https://bugs.webkit.org/show_bug.cgi?id=64137
  37571. Reviewed by Eric Seidel.
  37572. test-webkitpy doesn't play nicely with the multiprocessing
  37573. module on win32. An earlier change actually reenabled the tests
  37574. on win32 by mistake.
  37575. This patch also fixes a few cases where path names will trip
  37576. things up on win32 (e.g., by testing unix paths on windows).
  37577. We do not lose any real coverage here with those fixes.
  37578. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  37579. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  37580. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  37581. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  37582. 2011-07-07 Leandro Pereira <leandro@profusion.mobi>
  37583. [ImageDiff] Calculate/print difference right after reading baseline image.
  37584. https://bugs.webkit.org/show_bug.cgi?id=64117
  37585. Reviewed by Kent Tamura.
  37586. Otherwise, ImageDiff will block on fgets() until the universe ends or you ^C
  37587. it. Whichever happens first.
  37588. * DumpRenderTree/efl/ImageDiff.cpp:
  37589. (main):
  37590. 2011-07-07 Raphael Kubo da Costa <kubo@profusion.mobi>
  37591. [EFL] DRT: Leak cairo_t to make the pixel tests stop crashing
  37592. https://bugs.webkit.org/show_bug.cgi?id=64107
  37593. Reviewed by Kent Tamura.
  37594. The pointer is later managed by BitmapContext, but it was being
  37595. de-refed and deleted earlier by our RefPtr, causing crashes in all
  37596. pixel tests.
  37597. We now call leakRef() to make sure it is not removed when our
  37598. createBitmapContextFromWebView goes out of context.
  37599. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
  37600. (createBitmapContextFromWebView):
  37601. 2011-07-07 Adam Roben <aroben@apple.com>
  37602. Update TestFailures's title and header immediately upon navigation
  37603. Fixes <http://webkit.org/b/64125> TestFailures page seems slow to react on link clicks
  37604. Reviewed by Daniel Bates.
  37605. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  37606. (ViewController.prototype.loaded): Create and store an h1 element for displaying the page's
  37607. title.
  37608. (ViewController.prototype._displayBuilder): Set the page's title and clear out any old
  37609. content immediately instead of waiting for the first set of results for the history
  37610. analyzer. As we receive new results from the analyzer we'll just clear out the main content
  37611. area and replace it with the new info.
  37612. (ViewController.prototype._displayTesters): Set the page's title and clear out any old
  37613. content immediately instead of waiting for the list of testers from the buildbot. Sprinkled
  37614. in a little use of our removeAllChildren helper, too.
  37615. (ViewController.prototype._setTitle): Added. Set's the page's title and the header text.
  37616. 2011-07-07 Adam Roben <aroben@apple.com>
  37617. Make Checkout use SCM's Executive instead of conjuring up its own
  37618. This will improve integration with the rest of webkitpy, particularly when invoked via
  37619. webkit-patch.
  37620. Fixes <http://webkit.org/b/64115> REGRESSION (r90564): webkitpy's Checkout class uses
  37621. Executive inappropriately
  37622. Reviewed by Adam Barth.
  37623. * Scripts/webkitpy/common/checkout/checkout.py:
  37624. (Checkout.commit_message_for_this_commit): Use SCM.run instead of creating an Executive for
  37625. our own use. SCM might have some super-special Executive that it uses under the covers, and
  37626. we want to use it, too!
  37627. * Scripts/webkitpy/common/checkout/checkout_unittest.py:
  37628. (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Mock the SCM.run
  37629. method to call through to Executive.run_command.
  37630. 2011-07-07 Adam Roben <aroben@apple.com>
  37631. Make Term/ReadKey.pm an optional dependency of commit-log-editor
  37632. When Term/ReadKey.pm isn't present, the --regenerate-log switch will be non-functional.
  37633. Fixes <http://webkit.org/b/64113> REGRESSION (r90564):
  37634. webkitpy.common.checkout.checkout_unittest failing on GTK bots due to missing
  37635. Term/ReadKey.pm module
  37636. Reviewed by Xan Lopez.
  37637. * Scripts/commit-log-editor: Use Module::Load::Conditional::can_load to only load
  37638. Term/ReadKey.pm if it's present. If it isn't present, ignore the --regenerate-log switch so
  37639. that existing commit messages will be preserved. (Users can manually remove existing commit
  37640. messages using git-reset.)
  37641. 2011-07-07 Adam Roben <aroben@apple.com>
  37642. Keep testing that commit messages containing Unicode are handled properly by webkitpy
  37643. Fixes <http://webkit.org/b/64109> REGRESSION (r90571): test-webkitpy no longer tests that we
  37644. correctly handle Unicode in commit messages
  37645. Reviewed by Eric Seidel.
  37646. * Scripts/webkitpy/common/checkout/checkout_unittest.py: Put some Unicode characters in
  37647. places in the ChangeLog that will end up being included in the commit message.
  37648. 2011-07-07 Andreas Kling <kling@webkit.org>
  37649. [Qt][WK2] Remove Symbian code.
  37650. https://bugs.webkit.org/show_bug.cgi?id=64101
  37651. Reviewed by Benjamin Poulain.
  37652. * MiniBrowser/qt/BrowserWindow.cpp:
  37653. (BrowserWindow::BrowserWindow):
  37654. (BrowserWindow::screenshot):
  37655. * MiniBrowser/qt/MiniBrowser.pro:
  37656. * MiniBrowser/qt/MiniBrowserApplication.h:
  37657. (WindowOptions::WindowOptions):
  37658. 2011-07-07 Andreas Kling <kling@webkit.org>
  37659. [Qt][WK2] Don't support ridiculous matrix of QT_NO_FEATURE combinations.
  37660. https://bugs.webkit.org/show_bug.cgi?id=64099
  37661. Reviewed by Benjamin Poulain.
  37662. * MiniBrowser/qt/BrowserWindow.cpp:
  37663. (BrowserWindow::openFile):
  37664. (BrowserWindow::screenshot):
  37665. (BrowserWindow::loadURLListFromFile):
  37666. 2011-07-07 Adam Roben <aroben@apple.com>
  37667. Completely ignore too-many-failures builds in TestFailures in most circumstances
  37668. Because a semi-arbitrary subset of tests are run in a too-many-failures build, we can't
  37669. really use them to perform regression analysis. The only time we want to pay attention to
  37670. too-many-failures builds is when we're trying to explain when the current bout of
  37671. too-many-failures started.
  37672. Fixes <http://webkit.org/b/64106> TestFailures page sometimes claims a test started failing
  37673. in a build that didn't even run it (because it exited early due to too many failues)
  37674. Reviewed by David Kilzer.
  37675. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  37676. (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Removed old, broken
  37677. too-many-failures handling that would cause us to blame builds that didn't even run a given
  37678. test for breaking it. Instead, skip over all too-many-failures builds unless the most recent
  37679. build was itself a too-many-failures build.
  37680. 2011-07-07 Adam Roben <aroben@apple.com>
  37681. Teach webkitpy's Checkout class to use commit-log-editor to create commit messages
  37682. Fixes <http://webkit.org/b/26755> webkit-patch's commit messages are less readable than
  37683. commit-log-editor's
  37684. Reviewed by David Kilzer.
  37685. * Scripts/webkitpy/common/checkout/checkout.py:
  37686. (Checkout.commit_message_for_this_commit): Run commit-log-editor, passing it the paths of
  37687. the modified ChangeLogs, to generate the commit message, rather than trying to generate one
  37688. ourselves.
  37689. * Scripts/webkitpy/common/checkout/checkout_unittest.py: Updated the expected commit message
  37690. to match commit-log-editor's format.
  37691. (CommitMessageForThisCommitTest.setUp): Write the ChangeLogs into Tools and LayoutTests
  37692. directories so we can see how the various entries get labeled in the commit message.
  37693. (CommitMessageForThisCommitTest.test_commit_message_for_this_commit): Create a mock SCM
  37694. instance that knows how to find commit-log-editor and pass it to our Checkout instance.
  37695. Don't bother capturing output, since there shouldn't be any.
  37696. 2011-07-07 Adam Roben <aroben@apple.com>
  37697. Add a --print-log option to commit-log-editor
  37698. When specified, commit-log-editor takes a set of ChangeLog paths on the command line,
  37699. generates a commit message from those ChangeLogs, prints it to stdout, and exits.
  37700. Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
  37701. readable than commit-log-editor's
  37702. Reviewed by David Kilzer.
  37703. * Scripts/commit-log-editor: Changed to use Getopt::Long to parse options. Added --print-log
  37704. option, which calls through to createCommitMessage, prints the result, and exits.
  37705. (printUsageAndExit): Renamed from "usage" for clarity. Beefed up the usage statement to
  37706. explain commit-log-editor's 2.5 (normal, --print-log, and --help) modes of operation.
  37707. 2011-07-07 Adam Roben <aroben@apple.com>
  37708. Extract commit-log-editor's commit-message-generation code into a separate function
  37709. As a bonus, we now skip a bunch of work in the case where we are generating a commit message
  37710. for staged git changes.
  37711. Prep work for fixing <http://webkit.org/b/26755> webkit-patch's commit messages are less
  37712. readable than commit-log-editor's
  37713. Reviewed by David Kilzer.
  37714. * Scripts/commit-log-editor: Moved the default definition of $endl up toward the top of the
  37715. file so that it will be defined even if we aren't operating on an existing log message.
  37716. Moved a bunch of top-level code to generate the commit message from here...
  37717. (createCommitMessage): ...to here.
  37718. 2011-07-07 Carlos Garcia Campos <cgarcia@igalia.com>
  37719. [GTK] Open links in a new window when clicking with the middle button in MiniBrowser
  37720. https://bugs.webkit.org/show_bug.cgi?id=63988
  37721. Reviewed by Martin Robinson.
  37722. * MiniBrowser/gtk/BrowserWindow.c:
  37723. (browserWindowConstructed):
  37724. (decidePolicyForNavigationAction): Ignore the action if a link is
  37725. clicked with the middle buttonm and open the link in a new window.
  37726. (browserWindowPolicyClientInit):
  37727. 2011-07-07 Adam Barth <abarth@webkit.org>
  37728. Remove style_references.py
  37729. https://bugs.webkit.org/show_bug.cgi?id=64070
  37730. Reviewed by Eric Seidel.
  37731. We never really adopted the _references design, and this file is a bit
  37732. of an orphan at this point.
  37733. * Scripts/check-webkit-style:
  37734. * Scripts/webkitpy/style/checker.py:
  37735. * Scripts/webkitpy/style/checker_unittest.py:
  37736. * Scripts/webkitpy/style/checkers/python.py:
  37737. * Scripts/webkitpy/style/checkers/test_expectations.py:
  37738. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  37739. * Scripts/webkitpy/style/main_unittest.py:
  37740. * Scripts/webkitpy/style_references.py: Removed.
  37741. 2011-07-07 Eric Seidel <eric@webkit.org>
  37742. Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
  37743. https://bugs.webkit.org/show_bug.cgi?id=64056
  37744. Unreviewed.
  37745. I had written this unittest prior to landing my change, but
  37746. had named it qt_unitest.py, so it wasn't running (nor was
  37747. it added to my git repo).
  37748. Once I fixe the name of the unittest file, it was very easy
  37749. to fix the error in webkit.py (which already had a FIXME).
  37750. * Scripts/webkitpy/layout_tests/port/qt_unittest.py: Added.
  37751. * Scripts/webkitpy/layout_tests/port/webkit.py:
  37752. 2011-07-07 Eric Seidel <eric@webkit.org>
  37753. Unreviewed. Add more debug logging about which test expectations we're using.
  37754. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  37755. * Scripts/webkitpy/layout_tests/port/webkit.py:
  37756. 2011-07-06 Adam Barth <abarth@webkit.org>
  37757. Remove unexpected_results.json
  37758. https://bugs.webkit.org/show_bug.cgi?id=64065
  37759. Reviewed by Eric Seidel.
  37760. No one should be using this file any more. This patch removes it from
  37761. the face of the earth. This patch also removes two NRWT-specific
  37762. command line options that were implemented using
  37763. unexpected_results.json.
  37764. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  37765. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  37766. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  37767. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  37768. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  37769. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  37770. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  37771. 2011-07-07 Adam Barth <abarth@webkit.org>
  37772. REGRESSION(90520): chromium GPU tests produce output in the LayoutTests directory
  37773. https://bugs.webkit.org/show_bug.cgi?id=64067
  37774. Reviewed by Eric Seidel.
  37775. The author of r90520 forgot to change the chromium_gpu.py implemenation
  37776. of this method as well.
  37777. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  37778. 2011-07-06 Eric Seidel <eric@webkit.org>
  37779. Fix WebKit2 expected results search paths for Mac and Qt under new-run-webkit-tests
  37780. https://bugs.webkit.org/show_bug.cgi?id=64056
  37781. Reviewed by Adam Barth.
  37782. This fixes the MacPort's version of baseline_search_path to include
  37783. wk2 fallback like WebKitPort's does. This also re-works the QtPort
  37784. to set self._name (as other ports do) so that WebKitPort's default
  37785. implementations will understand Qt operating system flavors correctly
  37786. (including when running wk2 tests).
  37787. In trying to test this, I realized that nearly all of our port-tests
  37788. use the default FileSystem(), User() and Executive() objects, which
  37789. is really bad, because they expose details of your system in the unittest results!
  37790. Once I fixed many of the Port() calls to pass MockFileSystem(), then
  37791. MacPort.test_tests_for_other_platforms started failing, and I had to
  37792. teach MockFileSystem.glob how to handle directories to make it work again.
  37793. I removed the useless PortTestCase.test_baseline_search_path and replaced
  37794. it with more useful test_baseline_search_path tests in MacPortTest and QtPortTest.
  37795. * Scripts/webkitpy/common/config/ports.py:
  37796. * Scripts/webkitpy/common/system/filesystem_mock.py:
  37797. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  37798. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  37799. * Scripts/webkitpy/layout_tests/port/mac.py:
  37800. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  37801. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  37802. * Scripts/webkitpy/layout_tests/port/qt.py:
  37803. * Scripts/webkitpy/layout_tests/port/test_files.py:
  37804. * Scripts/webkitpy/layout_tests/port/win.py:
  37805. * Scripts/webkitpy/to_be_moved/deduplicate_tests.py:
  37806. * Scripts/webkitpy/tool/mocktool.py:
  37807. 2011-07-06 Adam Barth <abarth@webkit.org>
  37808. Wean rebaseline-server off unexpected_results.json
  37809. https://bugs.webkit.org/show_bug.cgi?id=64063
  37810. Reviewed by Eric Seidel.
  37811. In the process of changing this code to use full_results.json, I
  37812. noticed that the code was broken (because it wasn't tested). This
  37813. patch also adds test coverage for the broken code.
  37814. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  37815. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  37816. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  37817. 2011-07-06 Adam Barth <abarth@webkit.org>
  37818. Wean resultsjsonparser off unexpected_results.json
  37819. https://bugs.webkit.org/show_bug.cgi?id=64061
  37820. Reviewed by Eric Seidel.
  37821. We're about to delete unexpected_results.json, so we need to remove all
  37822. the users.
  37823. * Scripts/webkitpy/common/config/ports.py:
  37824. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  37825. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  37826. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  37827. 2011-07-06 Adam Barth <abarth@webkit.org>
  37828. Cleanup result_summary.py
  37829. https://bugs.webkit.org/show_bug.cgi?id=64057
  37830. Reviewed by Eric Seidel.
  37831. This class had a bunch of out-of-date docstrings that no longer make
  37832. any sense.
  37833. * Scripts/webkitpy/layout_tests/models/result_summary.py:
  37834. 2011-07-06 Adam Barth <abarth@webkit.org>
  37835. Tweak the ChangeLog for DEPS rolls to say "Unreviewed" so that the
  37836. patches can be landed by the commit-queue.
  37837. * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
  37838. 2011-07-06 Adam Barth <abarth@webkit.org>
  37839. Normalize callers of logging.getLogger to use __name__
  37840. https://bugs.webkit.org/show_bug.cgi?id=64054
  37841. Reviewed by Eric Seidel.
  37842. Most callers were already using __name__. This patch makes everyone
  37843. consistent.
  37844. * Scripts/webkitpy/common/checkout/diff_parser.py:
  37845. * Scripts/webkitpy/common/checkout/scm/svn.py:
  37846. * Scripts/webkitpy/common/net/statusserver.py:
  37847. * Scripts/webkitpy/common/system/executive.py:
  37848. * Scripts/webkitpy/common/system/file_lock.py:
  37849. * Scripts/webkitpy/common/system/user.py:
  37850. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  37851. * Scripts/webkitpy/layout_tests/models/result_summary.py:
  37852. * Scripts/webkitpy/layout_tests/models/test_expectations.py:
  37853. * Scripts/webkitpy/layout_tests/port/chromium.py:
  37854. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  37855. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  37856. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  37857. * Scripts/webkitpy/layout_tests/port/gtk.py:
  37858. * Scripts/webkitpy/layout_tests/port/http_lock.py:
  37859. * Scripts/webkitpy/layout_tests/port/mac.py:
  37860. * Scripts/webkitpy/layout_tests/port/qt.py:
  37861. * Scripts/webkitpy/layout_tests/port/server_process.py:
  37862. * Scripts/webkitpy/layout_tests/port/webkit.py:
  37863. * Scripts/webkitpy/layout_tests/port/win.py:
  37864. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  37865. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  37866. * Scripts/webkitpy/layout_tests/servers/http_server_base.py:
  37867. * Scripts/webkitpy/layout_tests/servers/websocket_server.py:
  37868. * Scripts/webkitpy/layout_tests/views/printing.py:
  37869. * Scripts/webkitpy/python24/versioning.py:
  37870. * Scripts/webkitpy/style/checker.py:
  37871. * Scripts/webkitpy/style/checkers/test_expectations.py:
  37872. * Scripts/webkitpy/style/patchreader.py:
  37873. * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py:
  37874. 2011-07-06 Adam Barth <abarth@webkit.org>
  37875. Move model classes out of layout_package and into models
  37876. https://bugs.webkit.org/show_bug.cgi?id=64053
  37877. Reviewed by Eric Seidel.
  37878. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  37879. * Scripts/webkitpy/common/net/layouttestresults.py:
  37880. * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  37881. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  37882. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  37883. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  37884. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  37885. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
  37886. * Scripts/webkitpy/layout_tests/controllers/worker.py:
  37887. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  37888. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  37889. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  37890. * Scripts/webkitpy/layout_tests/layout_package/result_summary.py: Removed.
  37891. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Removed.
  37892. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py: Removed.
  37893. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Removed.
  37894. * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py: Removed.
  37895. * Scripts/webkitpy/layout_tests/layout_package/test_input.py: Removed.
  37896. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  37897. * Scripts/webkitpy/layout_tests/layout_package/test_results.py: Removed.
  37898. * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py: Removed.
  37899. * Scripts/webkitpy/layout_tests/models: Added.
  37900. * Scripts/webkitpy/layout_tests/models/__init__.py: Added.
  37901. * Scripts/webkitpy/layout_tests/models/result_summary.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/result_summary.py.
  37902. * Scripts/webkitpy/layout_tests/models/test_expectations.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations.py.
  37903. * Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py.
  37904. * Scripts/webkitpy/layout_tests/models/test_failures.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures.py.
  37905. * Scripts/webkitpy/layout_tests/models/test_failures_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py.
  37906. * Scripts/webkitpy/layout_tests/models/test_input.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_input.py.
  37907. * Scripts/webkitpy/layout_tests/models/test_results.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results.py.
  37908. * Scripts/webkitpy/layout_tests/models/test_results_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py.
  37909. * Scripts/webkitpy/layout_tests/port/chromium.py:
  37910. * Scripts/webkitpy/layout_tests/views/printing.py:
  37911. * Scripts/webkitpy/layout_tests/views/printing_unittest.py:
  37912. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  37913. * Scripts/webkitpy/style_references.py:
  37914. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  37915. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  37916. * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  37917. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  37918. * Scripts/webkitpy/tool/commands/rebaseline.py:
  37919. 2011-07-06 Dirk Pranke <dpranke@chromium.org>
  37920. nrwt: fix typo preventing http startup on windows
  37921. https://bugs.webkit.org/show_bug.cgi?id=64050
  37922. Reviewed by Eric Siedel.
  37923. NRWT checks whether it needs to start the servers by looking
  37924. for "/http/" in the test names. After r90520, the leading slash
  37925. is not present, so the check isn't quite right.
  37926. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  37927. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  37928. 2011-07-06 Dirk Pranke <dpranke@chromium.org>
  37929. nrwt: remove --use-apache from the command line
  37930. https://bugs.webkit.org/show_bug.cgi?id=63358
  37931. Reviewed by Adam Barth.
  37932. Re-land the fix in bug 63358 - the prior fix was flawed in that
  37933. we were trying to start the http server during check_sys_deps()
  37934. but not actually setting up the environment properly. This
  37935. broken prior to this change, but exposed by it, since the patch
  37936. changes the chromium port to call the base class's checks.
  37937. * Scripts/webkitpy/common/system/executive.py:
  37938. * Scripts/webkitpy/layout_tests/port/base.py:
  37939. * Scripts/webkitpy/layout_tests/port/chromium.py:
  37940. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  37941. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  37942. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  37943. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  37944. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  37945. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  37946. 2011-07-06 Adam Barth <abarth@webkit.org>
  37947. Move view-related code out of layout_package and into views
  37948. https://bugs.webkit.org/show_bug.cgi?id=64051
  37949. Reviewed by Eric Seidel.
  37950. * Scripts/webkitpy/layout_tests/controllers/manager.py:
  37951. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
  37952. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
  37953. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
  37954. * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py: Removed.
  37955. * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py: Removed.
  37956. * Scripts/webkitpy/layout_tests/layout_package/printing.py: Removed.
  37957. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py: Removed.
  37958. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  37959. * Scripts/webkitpy/layout_tests/views: Added.
  37960. * Scripts/webkitpy/layout_tests/views/__init__.py: Added.
  37961. * Scripts/webkitpy/layout_tests/views/metered_stream.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream.py.
  37962. * Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py.
  37963. * Scripts/webkitpy/layout_tests/views/printing.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing.py.
  37964. * Scripts/webkitpy/layout_tests/views/printing_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py.
  37965. 2011-07-06 Adam Barth <abarth@webkit.org>
  37966. Add goofy comments to explain why we have these files.
  37967. * Scripts/webkitpy/layout_tests/controllers/__init__.py:
  37968. * Scripts/webkitpy/layout_tests/layout_package/__init__.py:
  37969. 2011-07-06 Adam Barth <abarth@webkit.org>
  37970. Move a bunch of classes out of layout_tests.layout_package and into layout_tests.controllers
  37971. https://bugs.webkit.org/show_bug.cgi?id=64048
  37972. Reviewed by Eric Seidel.
  37973. * Scripts/webkitpy/layout_tests/controllers: Added.
  37974. * Scripts/webkitpy/layout_tests/controllers/__init__.py: Added.
  37975. * Scripts/webkitpy/layout_tests/controllers/manager.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager.py.
  37976. * Scripts/webkitpy/layout_tests/controllers/manager_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py.
  37977. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py.
  37978. * Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py.
  37979. * Scripts/webkitpy/layout_tests/controllers/message_broker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker.py.
  37980. * Scripts/webkitpy/layout_tests/controllers/message_broker_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py.
  37981. * Scripts/webkitpy/layout_tests/controllers/single_test_runner.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py.
  37982. * Scripts/webkitpy/layout_tests/controllers/worker.py: Copied from Tools/Scripts/webkitpy/layout_tests/layout_package/worker.py.
  37983. * Scripts/webkitpy/layout_tests/layout_package/manager.py: Removed.
  37984. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Removed.
  37985. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py: Removed.
  37986. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py: Removed.
  37987. * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
  37988. * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
  37989. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  37990. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Removed.
  37991. * Scripts/webkitpy/layout_tests/layout_package/worker.py: Removed.
  37992. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  37993. 2011-07-06 Adam Barth <abarth@webkit.org>
  37994. Attempt to fix unittest on Leopard. Let's enumerate the keys in sorted
  37995. order so the test results are predictable.
  37996. * Scripts/webkitpy/tool/bot/irc_command.py:
  37997. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  37998. 2011-07-06 Dirk Pranke <dpranke@chromium.org>
  37999. Reviewed by Eric Siedel.
  38000. nrwt: make the code be consistent about using test names instead of filenames or paths
  38001. https://bugs.webkit.org/show_bug.cgi?id=63597
  38002. It can be hard to figure out where in the code we're assuming
  38003. test names are listed as unix-style relative filenames and where
  38004. they are either absolute paths or relative paths following the
  38005. host filesystem convention.
  38006. This patch changes things so that everything outside of the
  38007. Port object uses (and must assume) unix-style relative
  38008. filenames (with one exception, which is specifying host-local
  38009. filenames as a list of test arguments on the command line).
  38010. This should make things clearer and more consistent, and also
  38011. removes a lot of path conversion calls.
  38012. The changes in this patch outside of port/base.py are largely
  38013. cosmetic changes of "filename" to "test". We add a few routines
  38014. to the base Port implementation to manipulate test names to
  38015. split them, figure out if we're referring to a directory of
  38016. tests, etc.
  38017. * Scripts/webkitpy/common/net/layouttestresults.py:
  38018. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  38019. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  38020. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  38021. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38022. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  38023. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  38024. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  38025. * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  38026. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  38027. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  38028. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  38029. * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
  38030. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  38031. * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  38032. * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  38033. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  38034. * Scripts/webkitpy/layout_tests/port/base.py:
  38035. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  38036. * Scripts/webkitpy/layout_tests/port/chromium.py:
  38037. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  38038. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  38039. * Scripts/webkitpy/layout_tests/port/test.py:
  38040. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  38041. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
  38042. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  38043. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  38044. * Scripts/webkitpy/tool/bot/flakytestreporter.py:
  38045. * Scripts/webkitpy/tool/commands/rebaseline.py:
  38046. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  38047. 2011-07-06 Chris Guillory <ctguil@chromium.org>
  38048. No review necessary.
  38049. Adding myself to committers list in committers.py.
  38050. https://bugs.webkit.org/show_bug.cgi?id=63478
  38051. * Scripts/webkitpy/common/config/committers.py:
  38052. 2011-07-06 Johnny Ding <jnd@chromium.org>
  38053. https://bugs.webkit.org/show_bug.cgi?id=63857
  38054. Implement createPopupMenu for Chromium DRT.
  38055. Reviewed by Tony Chang.
  38056. * DumpRenderTree/chromium/WebViewHost.cpp:
  38057. (WebViewHost::createPopupMenu):
  38058. (WebViewHost::~WebViewHost):
  38059. * DumpRenderTree/chromium/WebViewHost.h:
  38060. 2011-07-06 Mihai Parparita <mihaip@chromium.org>
  38061. Unreviewed, rolling out r90503.
  38062. http://trac.webkit.org/changeset/90503
  38063. https://bugs.webkit.org/show_bug.cgi?id=63358
  38064. Makes Chromium Windows canary bots hang.
  38065. * Scripts/webkitpy/layout_tests/port/base.py:
  38066. * Scripts/webkitpy/layout_tests/port/chromium.py:
  38067. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  38068. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  38069. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  38070. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  38071. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  38072. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  38073. 2011-07-06 Adam Barth <abarth@webkit.org>
  38074. Move buildbot URL in webkitpy to config.urls
  38075. https://bugs.webkit.org/show_bug.cgi?id=64041
  38076. Reviewed by Eric Seidel.
  38077. This patch prepares for using the buildbot class to talk to the
  38078. Chromium buildbots.
  38079. * Scripts/webkitpy/common/config/urls.py:
  38080. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  38081. * Scripts/webkitpy/tool/commands/download_unittest.py:
  38082. * Scripts/webkitpy/tool/commands/queries.py:
  38083. * Scripts/webkitpy/tool/mocktool.py:
  38084. * Scripts/webkitpy/tool/steps/ensurebuildersaregreen.py:
  38085. 2011-07-06 Kevin Ollivier <kevino@theolliviers.com>
  38086. [wx] Unreviewed build fix, add the correct path to the waf build settings.
  38087. * wx/packaging/build-win-installer.py:
  38088. 2011-07-06 Adam Barth <abarth@webkit.org>
  38089. Add missing include.
  38090. * Scripts/webkitpy/tool/bot/irc_command.py:
  38091. 2011-07-06 Adam Barth <abarth@webkit.org>
  38092. Add roll-chromium-deps command to sheriff-bot
  38093. https://bugs.webkit.org/show_bug.cgi?id=64037
  38094. Reviewed by Eric Seidel.
  38095. Lo, and the DEPS were rolled on command.
  38096. * Scripts/webkitpy/tool/bot/irc_command.py:
  38097. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  38098. * Scripts/webkitpy/tool/bot/sheriff.py:
  38099. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  38100. * Scripts/webkitpy/tool/commands/roll.py:
  38101. * Scripts/webkitpy/tool/commands/roll_unittest.py:
  38102. * Scripts/webkitpy/tool/steps/updatechromiumdeps.py:
  38103. 2011-07-06 Eric Seidel <eric@webkit.org>
  38104. Split Driver, DriverOutput and DriverInput out into a new driver.py file
  38105. https://bugs.webkit.org/show_bug.cgi?id=64031
  38106. Reviewed by Adam Barth.
  38107. This ended up kinda large and I'm happy to break it up if desired.
  38108. As part of cleaning up the Port module, I split Driver, DriverInput and DriverOutput
  38109. out into its own driver.py file.
  38110. I also cleaned up how we import Port objects, by making port/__init__.py
  38111. expose Port, Driver, DriverInput, and DriverOutput. I removed exposure of
  38112. some various test objects as they were causing circular dependencies.
  38113. base.py is now an implementation detail of port. No longer is "base" referenced
  38114. anywhere in the code.
  38115. I also made Driver.__init__ non-virtual so that sub-classers could all share
  38116. the data storage on Driver. This more closely matches how other subclasses
  38117. work throughout our python code.
  38118. Standard line-unwrapping and doc-string removal as I went through the code.
  38119. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  38120. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  38121. * Scripts/webkitpy/layout_tests/port/__init__.py:
  38122. * Scripts/webkitpy/layout_tests/port/base.py:
  38123. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  38124. * Scripts/webkitpy/layout_tests/port/chromium.py:
  38125. * Scripts/webkitpy/layout_tests/port/driver.py: Added.
  38126. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  38127. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  38128. * Scripts/webkitpy/layout_tests/port/test.py:
  38129. * Scripts/webkitpy/layout_tests/port/webkit.py:
  38130. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  38131. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
  38132. * Scripts/webkitpy/tool/servers/rebaselineserver_unittest.py:
  38133. 2011-07-06 Adam Roben <aroben@apple.com>
  38134. Clear TestFailures's getNumberOfFailingTests cache
  38135. Now that we support NRWT, we need to clear out old zero values for the NRWT bots that might
  38136. have been cached by old versions of TestFailures.
  38137. Fixes <http://webkit.org/b/64029> TestFailures page still doesn't show NRWT bots if you've
  38138. used it recently
  38139. Reviewed by Adam Barth.
  38140. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  38141. (Builder.prototype.getNumberOfFailingTests): Added a .version property to the cache data
  38142. that must match the current version. Otherwise we'll ignore the cached data.
  38143. 2011-06-24 Dirk Pranke <dpranke@chromium.org>
  38144. Reviewed by Adam Barth.
  38145. nrwt: remove --use-apache from the command line
  38146. https://bugs.webkit.org/show_bug.cgi?id=63358
  38147. This change removes the --use-apache command line argument. It
  38148. was initially put in when we were trying to get the cygwin
  38149. apache instance to work with Chromium win, but that code has
  38150. bitrotted and doesn't work at all now.
  38151. Arguably we should remove all of the code to allow for a choice
  38152. of web servers, but since we may still want to switch off of
  38153. LigHTTPd at some point on Windows, I'll leave the rest in for
  38154. now (or at least yank it in a different change.)
  38155. * Scripts/webkitpy/layout_tests/port/base.py:
  38156. * Scripts/webkitpy/layout_tests/port/chromium.py:
  38157. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  38158. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  38159. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  38160. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  38161. 2011-07-06 Dimitri Glazkov <dglazkov@chromium.org>
  38162. garden-o-matic should use a favicon to indicate current state.
  38163. https://bugs.webkit.org/show_bug.cgi?id=64027
  38164. Reviewed by Adam Barth.
  38165. * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-green.png: Added.
  38166. * Scripts/webkitpy/tool/servers/data/gardeningserver/favicon-red.png: Added.
  38167. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added blurb about icons.
  38168. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added setting icon state.
  38169. * Scripts/webkitpy/tool/servers/gardeningserver.py: Allowed the use of favicons.
  38170. 2011-07-06 Daniel Bates <dbates@rim.com>
  38171. Fix webkitpy error after changeset 90483 <http://trac.webkit.org/changeset/90483>; Add missing
  38172. parameter to _fetch_file_from_results lamdba function.
  38173. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  38174. 2011-07-06 Kevin Ollivier <kevino@theolliviers.com>
  38175. [wx] Unreviewed build fix. Generate the proper install_name for dylibs on Mac.
  38176. * wx/packaging/build-mac-installer.py:
  38177. 2011-07-06 Xan Lopez <xlopez@igalia.com>
  38178. [GTK] Only set env. variables in start when strictly needed
  38179. https://bugs.webkit.org/show_bug.cgi?id=64026
  38180. Reviewed by Eric Seidel.
  38181. * Scripts/webkitpy/layout_tests/port/gtk.py: add a
  38182. setup_environ_for_server method in GtkPort and set as many
  38183. env. variables as possible there.
  38184. 2011-07-06 Adam Roben <aroben@apple.com>
  38185. Teach TestFailures how to load, parse, and interpret NRWT test results
  38186. Fixes <http://webkit.org/b/61877> TestFailures page doesn't show testers that use
  38187. new-run-webkit-tests
  38188. Reviewed by Adam Barth.
  38189. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  38190. (Builder.prototype.failureDiagnosisTextAndURL): Added support for the new 'flaky' failure
  38191. type. For now we don't account for image-only flakes (but TestFailures doesn't deal with
  38192. pixel tests at all currently).
  38193. (Builder.prototype.getNumberOfFailingTests): Relaxed the regex used for parsing the number
  38194. of failing tests from the buildbot output. Make sure not to count "new passes" (a new
  38195. category introduced by NRWT) as failures.
  38196. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  38197. (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here to
  38198. _fetchAndParseORWTResults. This function now attempts to load NRWT results, then falls back
  38199. to loading ORWT results.
  38200. (LayoutTestResultsLoader.prototype._fetchAndParseNRWTResults): Added. Tries to load and
  38201. parse the full_results.json file for the given build.
  38202. (LayoutTestResultsLoader.prototype._fetchAndParseORWTResults): Added. Code came from start.
  38203. Fixed a bug along the way where we were sometimes calling the error callback instead of the
  38204. success callback when all tests passed.
  38205. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/NRWTResultsParser.js: Added.
  38206. (NRWTResultsParser): Do-nothing constructor.
  38207. (NRWTResultsParser.prototype.parse): Uses eval() (eww!) to get the test results out of the
  38208. JS string, then iterates over all the tests in the results data and builds up a data
  38209. structure matching what ORWTResultsParser returns.
  38210. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  38211. (Array.prototype.contains):
  38212. (String.prototype.contains):
  38213. Added these simple helper functions.
  38214. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  38215. NRWTResultsParser.js.
  38216. 2011-07-06 Adam Roben <aroben@apple.com>
  38217. Extract code to parse ORWT's results.html file into its own class
  38218. Prep work for fixing <http://webkit.org/b/61877> TestFailures page doesn't show testers that
  38219. use new-run-webkit-tests
  38220. Reviewed by Adam Barth.
  38221. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  38222. (LayoutTestResultsLoader.prototype.start): Moved a bunch of code from here...
  38223. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ORWTResultsParser.js: Added.
  38224. (ORWTResultsParser):
  38225. (ORWTResultsParser.prototype.parse):
  38226. ...to here.
  38227. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  38228. ORWTResultsParser.js.
  38229. 2011-07-06 Eric Seidel <eric@webkit.org>
  38230. Unreviewed. Fix a unittest from hitting the network. :)
  38231. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  38232. 2011-07-06 Eric Seidel <eric@webkit.org>
  38233. Unreviewed. Fixing an exception in test-webkitpy, caused by bug 64006.
  38234. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  38235. 2011-07-06 Gustavo Noronha Silva <gustavo.noronha@collabora.com>
  38236. Run an Xvfb instance to run the API tests on, like we do for the
  38237. layout tests.
  38238. Reviewed by Xan Lopez.
  38239. * Scripts/run-gtk-tests:
  38240. 2011-07-06 Daniel Bates <dbates@webkit.org>
  38241. Make SCM unit tests faster
  38242. https://bugs.webkit.org/show_bug.cgi?id=63883
  38243. Speeds up the SCM unit tests by a factor of 4. Currently, we create a
  38244. mock SVN repo for each test_ method in SVNTest and GitTest and creating
  38245. this repo is expensive.
  38246. Instead, it is significantly faster to create the mock SVN repo once
  38247. and then perform a filesystem copy of it for each test_ method.
  38248. Note, Python 2.7's unittest module implements support for per class and
  38249. per module setup and tear down methods which could be used to implement
  38250. similar functionality. At the time of writing, test-webkitpy is designed
  38251. to support Python 2.5. So, we can't take advantage of these Python 2.7
  38252. features :(
  38253. Reviewed by Eric Seidel.
  38254. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  38255. 2011-07-06 Adam Barth <abarth@webkit.org>
  38256. Remove unused parameter from _add_test in test_expectations.py
  38257. https://bugs.webkit.org/show_bug.cgi?id=64008
  38258. Reviewed by Eric Seidel.
  38259. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  38260. 2011-07-06 Adam Barth <abarth@webkit.org>
  38261. Use old-run-webkit-tests when --leaks is present
  38262. https://bugs.webkit.org/show_bug.cgi?id=64012
  38263. Reviewed by Adam Roben.
  38264. We'll remove this branch once support of --leaks is added to
  38265. new-run-webkit-tests.
  38266. * Scripts/run-webkit-tests:
  38267. 2011-07-06 Benjamin Poulain <benjamin@webkit.org>
  38268. [Qt] [WK2] Add touch mocking to Qt's MiniBrowser
  38269. https://bugs.webkit.org/show_bug.cgi?id=63995
  38270. Reviewed by Andreas Kling.
  38271. The mouse events are intercepted through QCoreApplication::notify(),
  38272. and fake touch events are generated for mouse events when necessary.
  38273. If touch events are received from the platform, we assume the current
  38274. hardware has a touch screen and we stop generating fake events.
  38275. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  38276. (isTouchEvent):
  38277. (isMouseEvent):
  38278. (MiniBrowserApplication::MiniBrowserApplication):
  38279. (MiniBrowserApplication::notify):
  38280. * MiniBrowser/qt/MiniBrowserApplication.h:
  38281. 2011-07-06 Xan Lopez <xlopez@igalia.com>
  38282. Reviewed by Gustavo Noronha.
  38283. * Scripts/webkitpy/layout_tests/port/gtk.py: use Popen correctly.
  38284. 2011-07-06 Eric Seidel <eric@webkit.org>
  38285. webkit-patch failure-reason does not understand NRWT results
  38286. https://bugs.webkit.org/show_bug.cgi?id=64006
  38287. Reviewed by Adam Barth.
  38288. Adam Barth tells me failure-reason should be deleted soon,
  38289. but aroben's fancy new TestFailures/ page doesn't work for
  38290. NRWT yet, and I needed to know when
  38291. third-party-cookie-relaxing started failing.
  38292. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  38293. * Scripts/webkitpy/tool/commands/queries.py:
  38294. 2011-07-06 Xan Lopez <xlopez@igalia.com>
  38295. [GTK] Add missing environment variables in NWRT
  38296. https://bugs.webkit.org/show_bug.cgi?id=64004
  38297. Reviewed by Gustavo Noronha Silva.
  38298. Add missing environment variables needed by the GTK+ port.
  38299. * Scripts/webkitpy/layout_tests/port/gtk.py: ditto.
  38300. 2011-07-06 Adam Roben <aroben@apple.com>
  38301. Make run-api-tests output intelligible on the bots
  38302. run-api-tests's output on the bots was very hard to read for two reasons:
  38303. 1) It was mixing its own output with gtest's
  38304. 2) It was using ANSI escape sequences to print colored text, but the bots don't support
  38305. that
  38306. Now, the --verbose flag turns off almost all of run-api-tests's own output so that gtest's
  38307. output will not be obscured. We still print "Timeout" messages even in verbose mode, since
  38308. gtest doesn't have any native support for timeouts. Also, when our output is being
  38309. redirected to a file, we don't print ANSI escape sequences.
  38310. Fixes <http://webkit.org/b/63996> It's very hard to read run-api-tests output on the bots
  38311. Reviewed by Sam Weinig.
  38312. * Scripts/run-api-tests: Don't use the :constants interface of Term::ANSIColor. We want to
  38313. use the colored function instead.
  38314. (runAllTestsInSuite): Don't print out suite names in verbose mode; gtest will give us enough
  38315. context that they aren't needed.
  38316. (runTest): Don't print out test names or pass/fail messages in verbose mode; gtest will do
  38317. that for us. Also, use the new possiblyColored function instead of always coloring output.
  38318. (possiblyColored): Added. When printing to a tty, returns the string with the appropriate
  38319. ANSI color escape sequences added. Otherwise just returns the string unmodified.
  38320. 2011-07-06 Xan Lopez <xlopez@igalia.com>
  38321. Reviewed by Gustavo Noronha.
  38322. Launch Xvfb (mostly) the same way we were launching it in the
  38323. bots, for maximum compatibility.
  38324. * Scripts/webkitpy/layout_tests/port/gtk.py:
  38325. 2011-07-06 Andreas Kling <kling@webkit.org>
  38326. [Qt][WK2] Split Qt API into two different web views (touch and desktop)
  38327. https://bugs.webkit.org/show_bug.cgi?id=63950
  38328. Co-authored with Benjamin Poulain <benjamin@webkit.org>.
  38329. Reviewed by Kenneth Rohde Christiansen.
  38330. Port WTR/Qt to use QDesktopWebView and force a 800x600 viewport.
  38331. The Qt MiniBrowser now defaults to QDesktopWebView but can be started
  38332. in QTouchWebView mode by passing -touch on the command line.
  38333. A lot of functionality has been removed and/or disabled from
  38334. MiniBrowser until we reintroduce the necessary API's.
  38335. * MiniBrowser/qt/BrowserView.cpp:
  38336. (BrowserView::BrowserView):
  38337. (BrowserView::~BrowserView):
  38338. (BrowserView::load):
  38339. (BrowserView::view):
  38340. (BrowserView::touchWebView):
  38341. (BrowserView::desktopWebView):
  38342. * MiniBrowser/qt/BrowserView.h:
  38343. * MiniBrowser/qt/BrowserWindow.cpp:
  38344. (newPageFunction):
  38345. (BrowserWindow::BrowserWindow):
  38346. (BrowserWindow::webView):
  38347. (BrowserWindow::newWindow):
  38348. (BrowserWindow::showUserAgentDialog):
  38349. (BrowserWindow::updateUserAgentList):
  38350. * MiniBrowser/qt/BrowserWindow.h:
  38351. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  38352. (MiniBrowserApplication::handleUserOptions):
  38353. * MiniBrowser/qt/MiniBrowserApplication.h:
  38354. (WindowOptions::WindowOptions):
  38355. * MiniBrowser/qt/UrlLoader.cpp:
  38356. (UrlLoader::UrlLoader):
  38357. * MiniBrowser/qt/main.cpp:
  38358. (main):
  38359. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  38360. (WTR::WebView::wkView):
  38361. (WTR::WebView::pageRef):
  38362. (WTR::WebView::WebView):
  38363. (WTR::PlatformWebView::page):
  38364. (WTR::PlatformWebView::windowFrame):
  38365. (WTR::PlatformWebView::setWindowFrame):
  38366. 2011-07-06 Eric Seidel <eric@webkit.org>
  38367. Unreviewed..
  38368. * Scripts/run-webkit-tests:
  38369. (useNewRunWebKitTests):
  38370. - Fix the pass-thru of --gtk and --qt for old-run-webkit-tests,
  38371. it was previously broken by the existence of isGtk/isQt checks which
  38372. removed the --gtk/--qt args from @ARGV.
  38373. 2011-07-06 Eric Seidel <eric@webkit.org>
  38374. new-run-webkit-tests uses a 35s timeout for Mac and 6s for all other ports
  38375. https://bugs.webkit.org/show_bug.cgi?id=63983
  38376. Reviewed by Xan Lopez.
  38377. All WebKit ports want to use a 35s timeout. Only chromium currently
  38378. uses a 6s timeout. Eventually we'll move all WebKit ports to 6s too
  38379. to further speed up new-run-webkit-tests runs, but that's going to be a while.
  38380. * Scripts/webkitpy/layout_tests/port/mac.py:
  38381. * Scripts/webkitpy/layout_tests/port/webkit.py:
  38382. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  38383. 2011-07-06 Xan Lopez <xlopez@igalia.com>
  38384. Unreviewed.
  38385. NWRT actually seems to work locally, so it should work in the bots
  38386. as long as we take care of the TIMEOUT issue (which is being fixed
  38387. as I write this). Let's give this another shot and fix whatever
  38388. breaks.
  38389. * Scripts/run-webkit-tests:
  38390. (useNewRunWebKitTests):
  38391. 2011-07-06 Xan Lopez <xlopez@igalia.com>
  38392. Unreviewed.
  38393. Disable NWRT on GTK. At the very least it needs an updated exected
  38394. results file since NWRT is more sensitive to timeouts, not sure
  38395. what the exact problem is.
  38396. * Scripts/run-webkit-tests:
  38397. (useNewRunWebKitTests):
  38398. 2011-07-06 Adam Barth <abarth@webkit.org>
  38399. Fix global variable leak detected by noglobals.
  38400. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  38401. 2011-07-06 Adam Barth <abarth@webkit.org>
  38402. garden-o-matic shouldn't show flaky tests by default
  38403. https://bugs.webkit.org/show_bug.cgi?id=63979
  38404. Reviewed by Ojan Vafai.
  38405. If any of the actual test results are PASS, the test is flaky and we
  38406. can ignore it (at least for now). If we get awesome at dealing with
  38407. failing tests, we might want to tackle flaky tests by refering the user
  38408. to the flakiness dashboard, which is way more awesome at dealing with
  38409. flaky tests that this tool ever will be.
  38410. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  38411. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  38412. 2011-07-05 Adam Barth <abarth@webkit.org>
  38413. garden-o-matic should list the failing tests
  38414. https://bugs.webkit.org/show_bug.cgi?id=63978
  38415. Reviewed by Eric Seidel.
  38416. * Scripts/webkitpy/tool/servers/data/gardeningserver/config.js: Added.
  38417. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  38418. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js:
  38419. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  38420. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js:
  38421. * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  38422. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui.js: Added.
  38423. * Scripts/webkitpy/tool/servers/data/gardeningserver/ui_unittests.js: Added.
  38424. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  38425. 2011-07-05 Eric Seidel <eric@webkit.org>
  38426. Re-enable NRWT on Leopard now that bug 63973 is fixed.
  38427. Reviewed by Adam Barth.
  38428. I also made the should-enable expression a black-list instead
  38429. of a white-list since every bot on build.webkit.org is
  38430. now using NRWT except windows and WebKit2 bots.
  38431. * Scripts/run-webkit-tests:
  38432. (useNewRunWebKitTests):
  38433. 2011-07-05 Eric Seidel <eric@webkit.org>
  38434. Perl string concat failure on Leopard (causes NRWT to fail)
  38435. https://bugs.webkit.org/show_bug.cgi?id=63973
  38436. Reviewed by Daniel Bates.
  38437. Leopard's "xcodebuild -version" has a different format from Snow Leopard/Lion
  38438. thus the version parsing logic in webkitdirs.pm seems to fail.
  38439. Default to "3.0" instead of undef when we can't parse the version number.
  38440. This should send us down the correct path for Leopard.
  38441. * Scripts/webkitdirs.pm:
  38442. (determineBaseProductDir):
  38443. 2011-07-05 Kevin Ollivier <kevino@theolliviers.com>
  38444. [wx] Unreviewed build fix after addition of Source/WebCore/xml/parser dir.
  38445. * waf/build/settings.py:
  38446. 2011-07-05 Eric Seidel <eric@webkit.org>
  38447. Disable NRWT for Leopard until https://bugs.webkit.org/show_bug.cgi?id=63973 can be fixed.
  38448. Reviewed by Adam Barth.
  38449. * Scripts/run-webkit-tests:
  38450. (useNewRunWebKitTests):
  38451. 2011-07-05 Eric Seidel <eric@webkit.org>
  38452. Make run-webkit-tests pass --verbose to new-run-webkit-tests on qt/gtk bots.
  38453. Reviewed by Adam Barth.
  38454. * Scripts/run-webkit-tests:
  38455. (runningOnBuildBot):
  38456. 2011-07-05 Adam Barth <abarth@webkit.org>
  38457. Add results_unittests.js to garden-o-matic
  38458. https://bugs.webkit.org/show_bug.cgi?id=63971
  38459. Reviewed by Eric Seidel.
  38460. Adding these unit tests forced me to commit to an API for the results
  38461. module. I'm not sure if this is the API we'll end up with, but it's
  38462. something not entirely unreasonable.
  38463. Also, I've changed results.js over to WebKit style, as discussed previously.
  38464. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  38465. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  38466. * Scripts/webkitpy/tool/servers/data/gardeningserver/results_unittests.js: Added.
  38467. * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html:
  38468. 2011-07-05 Eric Seidel <eric@webkit.org>
  38469. Teach run-webkit-tests how to translate --qt and --gtk for new-run-webkit-tests.
  38470. Reviewed by Adam Barth.
  38471. * Scripts/run-webkit-tests:
  38472. 2011-07-05 Adam Barth <abarth@webkit.org>
  38473. Add first unit tests for garden-o-matic
  38474. https://bugs.webkit.org/show_bug.cgi?id=63969
  38475. Reviewed by Eric Seidel.
  38476. I've also reformated base.js to match WebKit style, as discussed in the
  38477. previous bug.
  38478. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js:
  38479. * Scripts/webkitpy/tool/servers/data/gardeningserver/base_unittests.js: Added.
  38480. * Scripts/webkitpy/tool/servers/data/gardeningserver/run-unittests.html: Added.
  38481. 2011-07-05 Eric Seidel <eric@webkit.org>
  38482. Move Qt, Gtk and Leopard to NRWT.
  38483. We'll roll out any of these if we see problems.
  38484. Reviewed by Adam Barth.
  38485. * Scripts/run-webkit-tests:
  38486. (useNewRunWebKitTests):
  38487. 2011-07-05 Adam Barth <abarth@webkit.org>
  38488. garden-o-matic should understand which tests have unexpected failures
  38489. https://bugs.webkit.org/show_bug.cgi?id=63965
  38490. Reviewed by Eric Seidel.
  38491. Currently, this code just logs the list of unexpected failures to the
  38492. console. A future patch will do something useful with this
  38493. information. A testing harness will also come in the next patch.
  38494. * Scripts/webkitpy/tool/servers/data/gardeningserver/base.js: Added.
  38495. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  38496. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js:
  38497. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  38498. 2011-07-05 Adam Barth <abarth@webkit.org>
  38499. garden-o-matic should know how to fetch test results from the (NRWT) bots
  38500. https://bugs.webkit.org/show_bug.cgi?id=63959
  38501. Reviewed by Eric Seidel.
  38502. Currently, this code just fetches the results and expectations JSON
  38503. blob for Linux from the server and logs it to the console.
  38504. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  38505. * Scripts/webkitpy/tool/servers/data/gardeningserver/results.js: Added.
  38506. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  38507. 2011-07-05 Dirk Pranke <dpranke@chromium.org>
  38508. Reviewed by Eric Seidel.
  38509. Python tests are failing on leopard
  38510. https://bugs.webkit.org/show_bug.cgi?id=63842
  38511. Fix the missing flush() call that appears to be needed by the
  38512. logging package in python 2.5. Also fix the regressions
  38513. introduced in the run_webkit_test tests when we switched from
  38514. thread to processes (since processes aren't available on 2.5).
  38515. Also fix a missing "from __future__ import with_statement' in
  38516. testfilehandler (unreviewed).
  38517. * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  38518. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  38519. * TestResultServer/handlers/testfilehandler.py:
  38520. 2011-07-05 Eric Seidel <eric@webkit.org>
  38521. Reviewed by Adam Barth.
  38522. re-enabling new-run-webkit-tests on the Snow Leopard WebKit1 bots
  38523. now that we believe the stray http-server issue to be solved.
  38524. * Scripts/run-webkit-tests:
  38525. (useNewRunWebKitTests):
  38526. 2011-07-05 Adam Barth <abarth@webkit.org>
  38527. Turns out we need to support numerals too because that's what jQuery
  38528. uses by default.
  38529. * TestResultServer/handlers/testfilehandler.py:
  38530. 2011-07-05 Dirk Pranke <dpranke@chromium.org>
  38531. nrwt: allow for multiple http shards
  38532. https://bugs.webkit.org/show_bug.cgi?id=63116
  38533. Reviewed by Tony Chang.
  38534. This modifies the sharding logic to support multiple http
  38535. shards, but for now we clamp to one shard until we can test
  38536. perf impact and flakiness impact.
  38537. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38538. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  38539. 2011-07-05 Dirk Pranke <dpranke@chromium.org>
  38540. Re-land nrwt: make sharding tests needing locks less hard-coded
  38541. https://bugs.webkit.org/show_bug.cgi?id=63112
  38542. Reviewed by Ojan Vafai.
  38543. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38544. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  38545. 2011-07-05 Adam Barth <abarth@webkit.org>
  38546. TestResultServer should support callback parameter for JSON
  38547. https://bugs.webkit.org/show_bug.cgi?id=63961
  38548. Reviewed by Ojan Vafai.
  38549. This makes using jQuery.ajax so much more pleasant.
  38550. * TestResultServer/handlers/testfilehandler.py:
  38551. 2011-07-05 Eric Seidel <eric@webkit.org>
  38552. buildbot needs to understand whether NRWT exited early after having too many failures
  38553. https://bugs.webkit.org/show_bug.cgi?id=63839
  38554. Reviewed by Adam Barth.
  38555. Fix-up the exited early messages printed by NRWT so that
  38556. the buildbot can parse them as expected.
  38557. It looks for lines using "if line.find('Exiting early') >= 0:"
  38558. I also plumbed the "early exit" status through to results.json
  38559. in the form of an "interrupted" bool. It was unclear to me
  38560. if results.json already had enough information to compute this bool
  38561. itself. It's possible Ojan could come up with a better fix.
  38562. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38563. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  38564. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  38565. * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  38566. 2011-07-05 Eric Seidel <eric@webkit.org>
  38567. new-run-webkit-tests fails to start http server if one is already running
  38568. https://bugs.webkit.org/show_bug.cgi?id=63956
  38569. Reviewed by Adam Barth.
  38570. * BuildSlaveSupport/kill-old-processes:
  38571. - Removed ^M line endings and sorted the process names.
  38572. - There are no functional changes to this file.
  38573. (except that now that its using unix line endings it can be executed directly!)
  38574. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  38575. - Change the name to 'httpd' to match old-run-webkit-test paths.
  38576. 2011-07-05 Adam Barth <abarth@webkit.org>
  38577. Add basic ajax support to garden-o-matic
  38578. https://bugs.webkit.org/show_bug.cgi?id=63874
  38579. Reviewed by Eric Seidel.
  38580. This patch adds some basic infrastructure to garden-o-matic.
  38581. Currently, the infrastructure is just used to make the "quit" command
  38582. use Ajax, but in the future, this infrastructure will be used to do
  38583. more sophistocated remote proceedure calls.
  38584. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html:
  38585. * Scripts/webkitpy/tool/servers/data/gardeningserver/main.js: Added.
  38586. * Scripts/webkitpy/tool/servers/gardeningserver.py:
  38587. * Scripts/webkitpy/tool/servers/reflectionhandler.py:
  38588. 2011-07-05 Adam Barth <abarth@webkit.org>
  38589. Add trivial garden-o-matic command (with server)
  38590. https://bugs.webkit.org/show_bug.cgi?id=63872
  38591. Reviewed by Eric Seidel.
  38592. This patch adds a trivial "Hello, world" garden-o-matic command,
  38593. complete with an HTTP server. This command re-uses a bunch of code
  38594. from the existing rebaseline-server command. Over time, this command
  38595. will grow to be a tool useful for gardening the WebKit tree.
  38596. * Scripts/webkitpy/tool/commands/__init__.py:
  38597. * Scripts/webkitpy/tool/commands/abstractservercommand.py: Added.
  38598. * Scripts/webkitpy/tool/commands/gardenomatic.py: Added.
  38599. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  38600. * Scripts/webkitpy/tool/servers/data/gardeningserver/index.html: Added.
  38601. * Scripts/webkitpy/tool/servers/gardeningserver.py: Added.
  38602. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  38603. 2011-07-05 Adam Roben <aroben@apple.com>
  38604. Make prepare-ChangeLog include modified Perl functions in its ChangeLog template
  38605. This is a very simple first cut. Functions must start with a line that starts with "sub "
  38606. and end with a line that starts with a closing brace. No leading whitespace is allowed.
  38607. Package names aren't parsed at all.
  38608. Fixes <http://webkit.org/b/21591> prepare-ChangeLog should know how to find functions in
  38609. Perl files
  38610. Reviewed by David Kilzer.
  38611. * Scripts/prepare-ChangeLog: Removed redundant code that ignored certain files when
  38612. searching for function line ranges. This is already done inside the get_function_line_ranges
  38613. function.
  38614. (get_function_line_ranges): Cleaned up coding style a little bit. Call
  38615. get_function_line_ranges_for_perl for files with .pl and .pm extensions. For files with an
  38616. unknown extension or no extension, read the shebang line to try to determine the script
  38617. interpreter. Call get_function_line_ranges_for_perl if the interpreter seems to be Perl.
  38618. (get_function_line_ranges_for_perl): Added. Does extremely basic parsing of the file to find
  38619. lines starting with "sub " or "}".
  38620. 2011-07-05 Adam Roben <aroben@apple.com>
  38621. Clean up run-api-tests output on Windows
  38622. We were mixing run-api-tests output with gtest output, and the result was a mess.
  38623. Fixes <http://webkit.org/b/63954> run-api-tests output is very confusing on Windows
  38624. Reviewed by Dan Bates.
  38625. * Scripts/run-api-tests:
  38626. (runTest):
  38627. (populateTests):
  38628. Made Windows use the formerly-Mac-only codepaths which correctly suppress gtest output
  38629. except in verbose mode. Most changes are due to indentation. Use of the arch utility is now
  38630. the only Mac-specific thing in these functions. Some other platform-specific code was moved
  38631. from here...
  38632. (prepareEnvironmentForRunningTestTool):
  38633. (testToolPath):
  38634. ...to here.
  38635. 2011-07-04 Gavin Barraclough <barraclough@apple.com>
  38636. Reviewed by Sam Weinig.
  38637. https://bugs.webkit.org/show_bug.cgi?id=16652
  38638. Firefox and JavaScriptCore differ in Number.toString(integer)
  38639. Added forwarding header.
  38640. * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.
  38641. 2011-07-04 Anders Carlsson <andersca@apple.com>
  38642. Try to fix Qt build.
  38643. * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
  38644. 2011-07-04 Anders Carlsson <andersca@apple.com>
  38645. NP_RemoveProperty is not called back by Safari when delete npObject.prop is encountered in JavaScript
  38646. https://bugs.webkit.org/show_bug.cgi?id=63915
  38647. <rdar://problem/7124300>
  38648. Reviewed by Sam Weinig.
  38649. Extend the NPRuntimeRemoveProperty to handle delete object.property from JavaScript.
  38650. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  38651. (PluginTest::NPN_IdentifierIsString):
  38652. (PluginTest::NPN_UTF8FromIdentifier):
  38653. (PluginTest::NPN_IntFromIdentifier):
  38654. (PluginTest::NPN_RetainObject):
  38655. (PluginTest::NPN_ReleaseObject):
  38656. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  38657. (PluginTest::Object::removeProperty):
  38658. (PluginTest::Object::identifierIs):
  38659. (PluginTest::Object::NP_RemoveProperty):
  38660. (PluginTest::Object::npClass):
  38661. * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
  38662. (NPRuntimeRemoveProperty::TestObject::TestObject):
  38663. (NPRuntimeRemoveProperty::TestObject::hasProperty):
  38664. (NPRuntimeRemoveProperty::TestObject::getProperty):
  38665. (NPRuntimeRemoveProperty::TestObject::removeProperty):
  38666. (NPRuntimeRemoveProperty::PluginObject::PluginObject):
  38667. (NPRuntimeRemoveProperty::PluginObject::~PluginObject):
  38668. (NPRuntimeRemoveProperty::PluginObject::hasMethod):
  38669. (NPRuntimeRemoveProperty::PluginObject::invoke):
  38670. (NPRuntimeRemoveProperty::PluginObject::hasProperty):
  38671. (NPRuntimeRemoveProperty::PluginObject::getProperty):
  38672. (NPRuntimeRemoveProperty::NPP_GetValue):
  38673. 2011-07-04 Leandro Pereira <leandro@profusion.mobi>
  38674. Reviewed by Kent Tamura.
  38675. [EFL] Add LayoutTestControllerEfl.
  38676. https://bugs.webkit.org/show_bug.cgi?id=61974
  38677. Only the core features are implemented. Most functions are actually
  38678. stubs and will be implemented as soon as its features are needed.
  38679. Build system changes will be made as soon as DRT is completely
  38680. upstreamed.
  38681. * DumpRenderTree/efl/LayoutTestControllerEfl.cpp: Added.
  38682. (LayoutTestController::~LayoutTestController):
  38683. (LayoutTestController::addDisallowedURL):
  38684. (LayoutTestController::clearBackForwardList):
  38685. (LayoutTestController::copyDecodedHostName):
  38686. (LayoutTestController::copyEncodedHostName):
  38687. (LayoutTestController::dispatchPendingLoadRequests):
  38688. (LayoutTestController::display):
  38689. (LayoutTestController::counterValueForElementById):
  38690. (LayoutTestController::keepWebHistory):
  38691. (LayoutTestController::computedStyleIncludingVisitedInfo):
  38692. (LayoutTestController::nodesFromRect):
  38693. (LayoutTestController::layerTreeAsText):
  38694. (LayoutTestController::pageNumberForElementById):
  38695. (LayoutTestController::numberOfPages):
  38696. (LayoutTestController::pageProperty):
  38697. (LayoutTestController::isPageBoxVisible):
  38698. (LayoutTestController::pageSizeAndMarginsInPixels):
  38699. (LayoutTestController::webHistoryItemCount):
  38700. (LayoutTestController::workerThreadCount):
  38701. (LayoutTestController::notifyDone):
  38702. (LayoutTestController::pathToLocalResource):
  38703. (LayoutTestController::queueLoad):
  38704. (LayoutTestController::setAcceptsEditing):
  38705. (LayoutTestController::setAlwaysAcceptCookies):
  38706. (LayoutTestController::setCustomPolicyDelegate):
  38707. (LayoutTestController::waitForPolicyDelegate):
  38708. (LayoutTestController::setScrollbarPolicy):
  38709. (LayoutTestController::addOriginAccessWhitelistEntry):
  38710. (LayoutTestController::removeOriginAccessWhitelistEntry):
  38711. (LayoutTestController::setMainFrameIsFirstResponder):
  38712. (LayoutTestController::setTabKeyCyclesThroughElements):
  38713. (LayoutTestController::setUseDashboardCompatibilityMode):
  38714. (LayoutTestController::setUserStyleSheetEnabled):
  38715. (LayoutTestController::setUserStyleSheetLocation):
  38716. (LayoutTestController::setValueForUser):
  38717. (LayoutTestController::setViewModeMediaFeature):
  38718. (LayoutTestController::setWindowIsKey):
  38719. (LayoutTestController::setSmartInsertDeleteEnabled):
  38720. (waitToDumpWatchdogFired):
  38721. (LayoutTestController::setWaitToDump):
  38722. (LayoutTestController::windowCount):
  38723. (LayoutTestController::setPrivateBrowsingEnabled):
  38724. (LayoutTestController::setJavaScriptCanAccessClipboard):
  38725. (LayoutTestController::setXSSAuditorEnabled):
  38726. (LayoutTestController::setFrameFlatteningEnabled):
  38727. (LayoutTestController::setSpatialNavigationEnabled):
  38728. (LayoutTestController::setAllowUniversalAccessFromFileURLs):
  38729. (LayoutTestController::setAllowFileAccessFromFileURLs):
  38730. (LayoutTestController::setAuthorAndUserStylesEnabled):
  38731. (LayoutTestController::setAutofilled):
  38732. (LayoutTestController::disableImageLoading):
  38733. (LayoutTestController::setMockDeviceOrientation):
  38734. (LayoutTestController::setMockGeolocationPosition):
  38735. (LayoutTestController::setMockGeolocationError):
  38736. (LayoutTestController::setGeolocationPermission):
  38737. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  38738. (LayoutTestController::addMockSpeechInputResult):
  38739. (LayoutTestController::setIconDatabaseEnabled):
  38740. (LayoutTestController::setJavaScriptProfilingEnabled):
  38741. (LayoutTestController::setSelectTrailingWhitespaceEnabled):
  38742. (LayoutTestController::setPopupBlockingEnabled):
  38743. (LayoutTestController::setPluginsEnabled):
  38744. (LayoutTestController::elementDoesAutoCompleteForElementWithId):
  38745. (LayoutTestController::execCommand):
  38746. (LayoutTestController::findString):
  38747. (LayoutTestController::isCommandEnabled):
  38748. (LayoutTestController::setCacheModel):
  38749. (LayoutTestController::setPersistentUserStyleSheetLocation):
  38750. (LayoutTestController::clearPersistentUserStyleSheet):
  38751. (LayoutTestController::clearAllApplicationCaches):
  38752. (LayoutTestController::setApplicationCacheOriginQuota):
  38753. (LayoutTestController::clearApplicationCacheForOrigin):
  38754. (LayoutTestController::localStorageDiskUsageForOrigin):
  38755. (LayoutTestController::originsWithApplicationCache):
  38756. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  38757. (LayoutTestController::clearAllDatabases):
  38758. (LayoutTestController::setDatabaseQuota):
  38759. (LayoutTestController::originsWithLocalStorage):
  38760. (LayoutTestController::deleteAllLocalStorage):
  38761. (LayoutTestController::deleteLocalStorageForOrigin):
  38762. (LayoutTestController::observeStorageTrackerNotifications):
  38763. (LayoutTestController::syncLocalStorage):
  38764. (LayoutTestController::setDomainRelaxationForbiddenForURLScheme):
  38765. (LayoutTestController::goBack):
  38766. (LayoutTestController::setDefersLoading):
  38767. (LayoutTestController::setAppCacheMaximumSize):
  38768. (LayoutTestController::pauseAnimationAtTimeOnElementWithId):
  38769. (LayoutTestController::pauseTransitionAtTimeOnElementWithId):
  38770. (LayoutTestController::sampleSVGAnimationForElementAtTime):
  38771. (LayoutTestController::numberOfActiveAnimations):
  38772. (LayoutTestController::suspendAnimations):
  38773. (LayoutTestController::resumeAnimations):
  38774. (LayoutTestController::overridePreference):
  38775. (LayoutTestController::addUserScript):
  38776. (LayoutTestController::addUserStyleSheet):
  38777. (LayoutTestController::setDeveloperExtrasEnabled):
  38778. (LayoutTestController::setAsynchronousSpellCheckingEnabled):
  38779. (LayoutTestController::showWebInspector):
  38780. (LayoutTestController::closeWebInspector):
  38781. (LayoutTestController::evaluateInWebInspector):
  38782. (LayoutTestController::evaluateScriptInIsolatedWorld):
  38783. (LayoutTestController::removeAllVisitedLinks):
  38784. (LayoutTestController::callShouldCloseOnWebView):
  38785. (LayoutTestController::apiTestNewWindowDataLoadBaseURL):
  38786. (LayoutTestController::apiTestGoToCurrentBackForwardItem):
  38787. (LayoutTestController::setWebViewEditable):
  38788. (LayoutTestController::markerTextForListItem):
  38789. (LayoutTestController::authenticateSession):
  38790. (LayoutTestController::setEditingBehavior):
  38791. (LayoutTestController::abortModal):
  38792. (LayoutTestController::hasSpellingMarker):
  38793. (LayoutTestController::hasGrammarMarker):
  38794. (LayoutTestController::dumpConfigurationForViewport):
  38795. (LayoutTestController::setSerializeHTTPLoads):
  38796. (LayoutTestController::setMinimumTimerInterval):
  38797. (LayoutTestController::setTextDirection):
  38798. (LayoutTestController::allowRoundingHacks):
  38799. 2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
  38800. Unreviewed, add myself as committer.
  38801. * Scripts/webkitpy/common/config/committers.py:
  38802. 2011-07-03 Sheriff Bot <webkit.review.bot@gmail.com>
  38803. Unreviewed, rolling out r90347.
  38804. http://trac.webkit.org/changeset/90347
  38805. https://bugs.webkit.org/show_bug.cgi?id=63886
  38806. Build breaks on Leopard, Chromium-win, WinCairo, and WinCE.
  38807. (Requested by tkent on #webkit).
  38808. * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Removed.
  38809. 2011-07-03 Daniel Bates <dbates@webkit.org>
  38810. Import Checkout in scm_unittests.py and logging in svn.py to fix
  38811. Python missing global variable errors
  38812. Rubber-stamped by Adam Barth.
  38813. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Import Checkout.
  38814. * Scripts/webkitpy/common/checkout/scm/svn.py: Import logging.
  38815. 2011-07-02 Gavin Barraclough <barraclough@apple.com>
  38816. Reviewed by Sam Weinig.
  38817. https://bugs.webkit.org/show_bug.cgi?id=16652
  38818. Firefox and JavaScriptCore differ in Number.toString(integer)
  38819. Added forwarding header.
  38820. * DumpRenderTree/ForwardingHeaders/wtf/StdLibExtras.h: Added.
  38821. 2011-04-02 Robert Hogan <robert@webkit.org>
  38822. Reviewed by Benjamin Poulain.
  38823. [Qt] Support third-party cookie policy for Qt clients
  38824. https://bugs.webkit.org/show_bug.cgi?id=45455
  38825. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  38826. (LayoutTestController::reset):
  38827. (LayoutTestController::setAlwaysAcceptCookies):
  38828. (LayoutTestController::setAlwaysBlockCookies):
  38829. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  38830. 2011-07-03 Adam Barth <abarth@webkit.org>
  38831. Factor ReflectionHandler out of the rebaseline server. Just code motion.
  38832. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  38833. * Scripts/webkitpy/tool/servers/rebaselineserver.py:
  38834. * Scripts/webkitpy/tool/servers/reflectionhandler.py: Added.
  38835. 2011-07-03 Adam Barth <abarth@webkit.org>
  38836. Move the rebaseline server out of the commands package and into the
  38837. (new) servers package. This patch prepares for refactoring this code
  38838. to share server infrastructure with the (forthcoming) garden-o-matic
  38839. command.
  38840. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  38841. * Scripts/webkitpy/tool/servers/__init__.py: Added.
  38842. * Scripts/webkitpy/tool/servers/data/rebaselineserver/loupe.js:
  38843. * Scripts/webkitpy/tool/servers/data/rebaselineserver/main.css:
  38844. * Scripts/webkitpy/tool/servers/data/rebaselineserver/queue.js:
  38845. * Scripts/webkitpy/tool/servers/rebaselineserver.py: Added.
  38846. 2011-07-01 Adam Barth <abarth@webkit.org>
  38847. Fix typo in master.cfg, hoping to trigger a master restart.
  38848. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  38849. 2011-07-01 Adam Barth <abarth@webkit.org>
  38850. Turn off new-run-webkit-tests and remove some debug logging.
  38851. * Scripts/run-webkit-tests:
  38852. * Scripts/webkitpy/layout_tests/port/http_lock.py:
  38853. 2011-07-01 Adam Barth <abarth@webkit.org>
  38854. Add some more debug logging to try to understand why we're getting
  38855. stuck acquring the HTTP lock.
  38856. * Scripts/webkitpy/layout_tests/port/http_lock.py:
  38857. 2011-07-01 Adam Barth <abarth@webkit.org>
  38858. Refactor NRWT parsing logic in master.cfg to understand that run-webkit-tests might run NRWT
  38859. https://bugs.webkit.org/show_bug.cgi?id=63854
  38860. Reviewed by Dirk Pranke.
  38861. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  38862. 2011-07-01 Eric Seidel <eric@webkit.org>
  38863. new-run-webkit-tests results does not understand that mac uses test_expectations files
  38864. https://bugs.webkit.org/show_bug.cgi?id=63838
  38865. Reviewed by Adam Barth.
  38866. We've decided to "enable" test_expectations for the Mac port for now.
  38867. It makes the results.html results much more confusing to read, but at least they're
  38868. no longer lying to us.
  38869. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38870. * Scripts/webkitpy/layout_tests/port/base.py:
  38871. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  38872. 2011-07-01 Adam Barth <abarth@webkit.org>
  38873. Temporarily disable waiting for ReportCrash to see how this code
  38874. affects performance on the bots.
  38875. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38876. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  38877. 2011-07-01 Dmitry Lomov <dslomov@google.com>
  38878. Reviewed by Adam Roben.
  38879. https://bugs.webkit.org/show_bug.cgi?id=63818
  38880. Test bots shouldn't attempt to build TestWebKitAPI on Windows.
  38881. TestWebKitAPI builds as a part of general webkit build and is a
  38882. part of build products archive.
  38883. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  38884. * Scripts/run-api-tests:
  38885. 2011-07-01 Adam Barth <abarth@webkit.org>
  38886. We shouldn't wait for ReportCrash while the timeout is running
  38887. https://bugs.webkit.org/show_bug.cgi?id=63837
  38888. Reviewed by Eric Seidel.
  38889. Instead, we should move this check to worker.py.
  38890. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  38891. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  38892. 2011-07-01 Adam Roben <aroben@apple.com>
  38893. Stop setting unsafe headers on POSTs via XHR from TestFailures page
  38894. Fixes <http://webkit.org/b/63833> TestFailures page causes a bunch of spew in the
  38895. Inspector's console about unsafe headers
  38896. Reviewed by Dan Bates.
  38897. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  38898. (fetchResource): Removed unnecessary code to set Content-Length and Connection headers.
  38899. 2011-07-01 Eric Seidel <eric@webkit.org>
  38900. Reviewed by Adam Barth.
  38901. Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
  38902. https://bugs.webkit.org/show_bug.cgi?id=63786
  38903. We're down to one bug blocking the "move to NRWT" bug:
  38904. https://bugs.webkit.org/show_bug.cgi?id=34984
  38905. so we're trying transitioning Snow Leopard to NRWT as an experiment.
  38906. If we run into any blocking issues we'll of course roll this back out
  38907. (or anyone reading this should feel encouraged to).
  38908. * Scripts/run-webkit-tests:
  38909. 2011-07-01 Adam Barth <abarth@webkit.org>
  38910. Add a compat shim for --leaks. Support for --leaks will be added in
  38911. https://bugs.webkit.org/show_bug.cgi?id=63832.
  38912. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  38913. 2011-07-01 Adam Barth <abarth@webkit.org>
  38914. Reviewed by Darin Adler.
  38915. ReportCrash destabilizes new-run-webkit-tests
  38916. https://bugs.webkit.org/show_bug.cgi?id=63795
  38917. ReportCrash chews up too many system resources that it destablizes
  38918. tests run concurrently. This patch causes us to spin down all the
  38919. worker processes when ReportCrash is running.
  38920. Also, this patch causes the master process to tell the user we're
  38921. waiting for the crash reporter rather than having that be the worker's
  38922. job. This stops the user from getting spammed with too many "waiting
  38923. for crash reporter" messages and also cleans up some minor UI issues
  38924. with the meter.
  38925. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38926. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  38927. * Scripts/webkitpy/layout_tests/port/base.py:
  38928. * Scripts/webkitpy/layout_tests/port/server_process.py:
  38929. 2011-07-01 Adam Roben <aroben@apple.com>
  38930. Teach webkitpy about the new format of our ChangeLog template
  38931. r90229 moved the "Need a short description and bug URL" line to the top of the ChangeLog
  38932. template. But webkitpy didn't know this, so the various rollout-related commands were
  38933. leaving that line in the ChangeLog.
  38934. Fixes <http://webkit.org/b/63815> REGRESSION (r90229): webkit-patch rollout and sheriffbot
  38935. rollout are broken
  38936. Reviewed by Dan Bates.
  38937. * Scripts/webkitpy/common/checkout/changelog.py:
  38938. (ChangeLog.update_with_unreviewed_message): Changed to look for the "Need a short
  38939. description and bug URL" line instead of the "Reviewed by" line as the first line of the
  38940. ChangeLog template.
  38941. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  38942. (ChangeLogTest): Updated _new_entry_boilerplate to match what prepare-ChangeLog now
  38943. generates.
  38944. 2011-07-01 Adam Roben <aroben@apple.com>
  38945. Make TestFailures stop loading old builds once we've explained all current failures
  38946. We used to do this, but some refactoring in r90165 broke this logic.
  38947. Fixes <http://webkit.org/b/63808> REGRESSION (r90165): TestFailures page always loads all
  38948. builds back to the beginning of time
  38949. Reviewed by Dan Bates.
  38950. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  38951. (LayoutTestHistoryAnalyzer.prototype.start): Stop fetching old builds once we're told that
  38952. all current failures have been explained.
  38953. 2011-07-01 Adam Roben <aroben@apple.com>
  38954. commit-log-editor reorders ChangeLog entries in unexpected ways
  38955. https://bugs.webkit.org/show_bug.cgi?id=63804
  38956. Reviewed by Darin Adler.
  38957. commit-log-editor was changed in r46899 to move the bug title and URL to the top of the
  38958. commit message in order to make git-based tools, which expect the first line of the commit
  38959. message to be a summary of the change, to work better. But this reordering of the ChangeLog
  38960. entry was unpredictable and unexpected.
  38961. I changed prepare-ChangeLog to put the bug title and URL at the top of the ChangeLog entry
  38962. so that commit-log-editor doesn't have to move them. Then I changed commit-log-editor not to
  38963. try to move them.
  38964. * Scripts/commit-log-editor: Partially reverted r46899. We no longer save the "Reviewed by"
  38965. line and try to move it down below the bug title and URL. The order of the text in the
  38966. ChangeLog is now preserved, except that we insert a "Patch by" line just above the "Reviewed
  38967. by" line in cases where the committer and author are not the same person.
  38968. * Scripts/prepare-ChangeLog: Moved the "Reviewed by" line down below the bug title and URL.
  38969. 2011-07-01 Mihnea Ovidenie <mihnea@adobe.com>
  38970. Reviewed by Adam Roben.
  38971. [CSSRegions] Add build slave
  38972. https://bugs.webkit.org/show_bug.cgi?id=62372
  38973. * BuildSlaveSupport/build.webkit.org-config/config.json:
  38974. Add an entry for a release build of Mac.
  38975. 2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
  38976. Unreviewed, rolling out r90213.
  38977. http://trac.webkit.org/changeset/90213
  38978. https://bugs.webkit.org/show_bug.cgi?id=63792
  38979. The SL bot has an errant HTTP server holding port 8080
  38980. (Requested by abarth on #webkit).
  38981. * Scripts/run-webkit-tests:
  38982. 2011-07-01 Carlos Garcia Campos <cgarcia@igalia.com>
  38983. Unreviewed. Fix WebKit2 GTK build after r90163.
  38984. * MiniBrowser/gtk/WebBundle/WebBundleMain.c:
  38985. (didCreatePage):
  38986. 2011-07-01 Adam Barth <abarth@webkit.org>
  38987. Exit faster when we get a keyboard interrupt. Previously, we'd open
  38988. Safari if you ^C NRWT after it found a failure.
  38989. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  38990. 2011-07-01 Eric Seidel <eric@webkit.org>
  38991. Reviewed by Adam Barth.
  38992. Switch Snow Leopard over to new-run-webkit-tests (except for wk2)
  38993. https://bugs.webkit.org/show_bug.cgi?id=63786
  38994. We're down to one bug blocking the "move to NRWT" bug:
  38995. https://bugs.webkit.org/show_bug.cgi?id=34984
  38996. so we're trying transitioning Snow Leopard to NRWT as an experiment.
  38997. If we run into any blocking issues we'll of course roll this back out
  38998. (or anyone reading this should feel encouraged to).
  38999. * Scripts/run-webkit-tests:
  39000. 2011-07-01 Sheriff Bot <webkit.review.bot@gmail.com>
  39001. Unreviewed, rolling out r90192.
  39002. http://trac.webkit.org/changeset/90192
  39003. https://bugs.webkit.org/show_bug.cgi?id=63788
  39004. Appears to have caused NRWT on Chromium WebKit Vista to hang
  39005. (Requested by abarth on #webkit).
  39006. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  39007. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  39008. 2011-06-30 Adam Barth <abarth@webkit.org>
  39009. Reviewed by Eric Seidel.
  39010. Remove the concept of "being wedged" from new-run-webkit-tests
  39011. https://bugs.webkit.org/show_bug.cgi?id=63767
  39012. Worker processes shouldn't ever become wedged. My understanding is
  39013. that this code was originally motivated by the old threading-based
  39014. design but no longer servers any purpose.
  39015. Note: If we actually have a problem with the test harness getting
  39016. stuck, buildbot will kill us.
  39017. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  39018. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  39019. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  39020. 2011-06-30 Adam Barth <abarth@webkit.org>
  39021. The win32 implementation of fork is sad about forking test-webkitpy.
  39022. Hopefully this will heal the bot.
  39023. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  39024. 2011-06-30 Eric Seidel <eric@webkit.org>
  39025. Reviewed by Adam Barth.
  39026. Update new-run-webkit-tests now that the wk2 shared skipped list has moved
  39027. https://bugs.webkit.org/show_bug.cgi?id=63780
  39028. The shared list was moved from mac-wk2 to wk2 as part of
  39029. http://trac.webkit.org/changeset/90125.
  39030. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39031. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39032. 2011-06-30 Kenichi Ishibashi <bashi@chromium.org>
  39033. Reviewed by Darin Adler.
  39034. Style Checker should flag removal of "developmentRegion = English;" from project.pbxproj.
  39035. https://bugs.webkit.org/show_bug.cgi?id=62022
  39036. Adds XcodeProjectFileChecker to check removal of "developmentRegion".
  39037. * Scripts/webkitpy/style/checker.py: Added XcodeProjectFileChecker as a checker for *.pbxproj.
  39038. * Scripts/webkitpy/style/checkers/xcodeproj.py: Added.
  39039. * Scripts/webkitpy/style/checkers/xcodeproj_unittest.py: Added.
  39040. 2011-06-30 Dirk Pranke <dpranke@chromium.org>
  39041. Reviewed by Ojan Vafai.
  39042. nrwt: make sharding tests needing locks less hard-coded
  39043. https://bugs.webkit.org/show_bug.cgi?id=63112
  39044. This change also changes the manager logic so that it will
  39045. drop the server lock as soon as all of the shards requiring
  39046. the lock have completed.
  39047. This change includes some minor namespace/import changes in the
  39048. unit tests, and also makes the Manager a new-style object, which
  39049. it should've been all along.
  39050. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  39051. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  39052. 2011-06-30 Adam Barth <abarth@webkit.org>
  39053. Reviewed by Eric Seidel.
  39054. Remove threaded mode from new-run-webkit-tests
  39055. https://bugs.webkit.org/show_bug.cgi?id=63771
  39056. This mode is not used and is buggy. Rather than carry around a bunch
  39057. of unused buggy code, we should rip it out and focus on the
  39058. multiprocess implementation.
  39059. * Scripts/webkitpy/common/system/executive.py:
  39060. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  39061. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  39062. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  39063. * Scripts/webkitpy/layout_tests/port/base.py:
  39064. * Scripts/webkitpy/layout_tests/port/chromium.py:
  39065. * Scripts/webkitpy/layout_tests/port/mac.py:
  39066. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  39067. * Scripts/webkitpy/layout_tests/port/server_process.py:
  39068. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  39069. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  39070. 2011-06-30 Adam Barth <abarth@webkit.org>
  39071. Reviewed by Darin Adler.
  39072. Clean up output from new-run-webkit-tests
  39073. https://bugs.webkit.org/show_bug.cgi?id=63759
  39074. Printing messages from the child process looks super ugly because of
  39075. the way the pretty-printer works. Printing a blank line first is a
  39076. hack, but it makes things at least partially sane.
  39077. Also, handle the case where calling sample throws an exception.
  39078. * Scripts/webkitpy/layout_tests/port/server_process.py:
  39079. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  39080. 2011-06-27 Diego Gonzalez <diegohcg@webkit.org>
  39081. Reviewed by Antonio Gomes.
  39082. [Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support
  39083. https://bugs.webkit.org/show_bug.cgi?id=63489
  39084. Unskipped:
  39085. loader/navigation-while-deferring-loads.html
  39086. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  39087. (LayoutTestController::goBack):
  39088. (LayoutTestController::setDefersLoading):
  39089. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  39090. 2011-06-30 Adam Barth <abarth@webkit.org>
  39091. Reviewed by Dirk Pranke.
  39092. new-run-webkit-tests should stop when I ^C it
  39093. https://bugs.webkit.org/show_bug.cgi?id=63763
  39094. It still doesn't stop fast enough, but at least with this patch it
  39095. doesn't run more tests.
  39096. Also, I tweaked the UI that happens when there's a keyboard interrupt
  39097. to not be amazingly ugly. There's still a garbage "Te" left on the
  39098. console, but that's a problem for another day.
  39099. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  39100. 2011-06-30 Adam Roben <aroben@apple.com>
  39101. Make TestFailures never treat a too-many-failures build as a last-passing build for a test
  39102. Fixes <http://webkit.org/b/63758> TestFailures sometimes incorrectly says that a build was
  39103. the last passing build for a test, when in fact the test wasn't run due to too many failures
  39104. causing old-run-webkit-tests to exit early
  39105. Reviewed by Anders Carlsson.
  39106. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  39107. (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): If there were too many
  39108. failures in this build, assume that all the tests failed in the last build would have failed
  39109. in this build, too, had they been run. Introduced some new local variables to reduce typing,
  39110. and used them throughout.
  39111. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  39112. (LayoutTestResultsLoader.prototype.start): Fix a regression from r89841 where we wouldn't
  39113. correctly remember whether old-run-webkit-tests exited early due to too many failures for
  39114. builds older than r89610. Also removed an unused parameter while I was at it.
  39115. 2011-06-30 Adam Roben <aroben@apple.com>
  39116. Make TestFaiulres only load old-results directories as needed
  39117. Fixes <http://webkit.org/b/63752> Tester pages on TestFailures page load very slowly
  39118. Reviewed by Anders Carlsson.
  39119. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  39120. (Builder.prototype.getBuildNames): Moved up into the API section of the class. Now just
  39121. calls through to _getBuildNamesFromResultsDirectory.
  39122. (Builder.prototype.getOldBuildNames): Added. Just calls through to
  39123. _getBuildNamesFromResultsDirectory.
  39124. (Builder.prototype._getBuildNamesFromResultsDirectory): Renamed from getBuildNames. Now
  39125. takes the directory URL as an argument and only fetches that single URL.
  39126. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  39127. (LayoutTestHistoryAnalyzer.prototype.start): Moved most logic to _analyzeBuilds. First
  39128. analyzes builds from Builder.getBuildNames, then from Builder.getOldBuildNames if needed.
  39129. (LayoutTestHistoryAnalyzer.prototype._analyzeBuilds): Moved logic here from start. (Most
  39130. changes are just indentation.) Now takes a callback to call when we've finished analyzing
  39131. all builds in buildNames so that we can try to fetch more build names if needed.
  39132. 2011-06-30 Mark Rowe <mrowe@apple.com>
  39133. Reviewed by Anders Carlsson.
  39134. Update MiniBrowser and WebKitTestRunner to use the client version constants.
  39135. * MiniBrowser/gtk/BrowserWindow.c:
  39136. (browserWindowLoaderClientInit):
  39137. (browserWindowUIClientInit):
  39138. * MiniBrowser/gtk/WebBundle/WebBundleMain.c:
  39139. (didCreatePage):
  39140. (WKBundleInitialize):
  39141. * MiniBrowser/gtk/main.c:
  39142. (createWKContextWithInjectedBundle):
  39143. * MiniBrowser/mac/AppDelegate.m:
  39144. (-[BrowserAppDelegate init]):
  39145. * MiniBrowser/mac/BrowserWindowController.m:
  39146. (-[BrowserWindowController awakeFromNib]):
  39147. * MiniBrowser/mac/WebBundle/WebBundleMain.m:
  39148. (WKBundleInitialize):
  39149. * MiniBrowser/win/BrowserView.cpp:
  39150. (BrowserView::create):
  39151. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  39152. (WTR::InjectedBundle::initialize):
  39153. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  39154. (WTR::InjectedBundlePage::InjectedBundlePage):
  39155. * WebKitTestRunner/TestController.cpp:
  39156. (WTR::TestController::createOtherPage):
  39157. (WTR::TestController::initialize):
  39158. 2011-06-30 Adam Roben <aroben@apple.com>
  39159. Identify revisions that modified failing tests on TestFailures page
  39160. Fixes <http://webkit.org/b/63716> TestFailures page should try to infer which commit caused
  39161. a failure by looking at commit logs
  39162. Reviewed by David Kilzer.
  39163. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  39164. (.existing-bugs-list, .suspect-revisions-list): Made this rule apply to the suspect
  39165. revisions list, too.
  39166. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  39167. (Trac): Initialize our memory cache.
  39168. (Trac.prototype.getCommitDataForRevisionRange): Added. Fetches the commit log in RSS form,
  39169. then parses out the revision number, Trac's idea of the commit title, and the files modified
  39170. by the commit. (To get the modified files, we rely on the commit message including a
  39171. prepare-ChangeLog-style file list.)
  39172. (Trac.prototype.logURL): Added a new formatAsRSS parameter.
  39173. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  39174. (removePathExtension): Added. Returns a new string with the last dot and everything after it
  39175. removed.
  39176. (sorted): Added sortFunction parameter.
  39177. (Node.prototype.removeAllChildren): Added. Does what it says.
  39178. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39179. (ViewController.prototype._displayBuilder): Updated for change to _domForRegressionRange.
  39180. (ViewController.prototype._domForRegressionRange): Changed argument order to match
  39181. _domForNewAndExistingBugs. Now takes the list of failing tests and uses it to figure out
  39182. which revisions modified the failing tests and displays the suspect revisions in a list.
  39183. 2011-06-30 Eric Seidel <eric@webkit.org>
  39184. Reviewed by Adam Barth.
  39185. Rename should_kill_dump_render_tree to driver_needs_restart in preparation for supporting WebKitTestRunner
  39186. https://bugs.webkit.org/show_bug.cgi?id=63743
  39187. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  39188. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  39189. 2011-06-30 Martin Robinson <mrobinson@igalia.com>
  39190. Reviewed by Anders Carlsson.
  39191. [GTK] Crash observed with nspluginwrapper and flash
  39192. https://bugs.webkit.org/show_bug.cgi?id=62249
  39193. Added a TestNetscapePlugin test which verifies that WebKit properly
  39194. handles situations where InvalidateRect is called with a null instance.
  39195. * DumpRenderTree/TestNetscapePlugIn/Tests/x11/CallInvalidateRectWithNullNPPArgument.cpp: Added.
  39196. (CallInvalidateRectWithNullNPPArgument::CallInvalidateRectWithNullNPPArgument):
  39197. (CallInvalidateRectWithNullNPPArgument::NPP_New):
  39198. * GNUmakefile.am: Add the new file to sources list.
  39199. 2011-06-30 Eric Seidel <eric@webkit.org>
  39200. Reviewed by Adam Barth.
  39201. Remove redundant tests in TestFailuresTest
  39202. https://bugs.webkit.org/show_bug.cgi?id=63742
  39203. These tests are all already covered by TestFailuresTest.test_loads.
  39204. I also added the missing "T" from TestFailuresest. :)
  39205. * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  39206. 2011-06-30 Adam Barth <abarth@webkit.org>
  39207. Reviewed by Eric Seidel.
  39208. REGRESSION(r84294): new-run-webkit-tests results.html generate links to diffs.html or diff.png that don't exist
  39209. https://bugs.webkit.org/show_bug.cgi?id=63494
  39210. This patch does two things:
  39211. 1) Refactor diff_image to return the image diff instead of writing the
  39212. diff to a file. This fixes a bunch of hacks and disentangles a bunch
  39213. of code.
  39214. 2) When there's a checksum mismatch but not image diff, we no longer
  39215. report an IMAGE failure to results.html. That fixes the bug in
  39216. question because results.html won't try to link to a non-existent image
  39217. diff.
  39218. * Scripts/webkitpy/common/system/executive_mock.py:
  39219. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  39220. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  39221. * Scripts/webkitpy/layout_tests/port/base.py:
  39222. * Scripts/webkitpy/layout_tests/port/chromium.py:
  39223. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  39224. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  39225. * Scripts/webkitpy/layout_tests/port/test.py:
  39226. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39227. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  39228. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
  39229. 2011-06-28 Hans Wennborg <hans@chromium.org>
  39230. Reviewed by Tony Chang.
  39231. IndexedDB: Prepare for running layout tests with LevelDB
  39232. https://bugs.webkit.org/show_bug.cgi?id=63593
  39233. The TestShell must always provide a temporary folder for LevelDB,
  39234. not just when the backing store type is overridden.
  39235. * DumpRenderTree/chromium/LayoutTestController.cpp:
  39236. (LayoutTestController::setOverrideIndexedDBBackingStore):
  39237. (LayoutTestController::clearAllDatabases):
  39238. * DumpRenderTree/chromium/LayoutTestController.h:
  39239. * DumpRenderTree/chromium/TestShell.cpp:
  39240. (TestShell::TestShell):
  39241. * DumpRenderTree/chromium/TestShell.h:
  39242. 2011-06-30 Zsolt Fehér <h490267@stud.u-szeged.hu>
  39243. Reviewed by Csaba Osztrogonác.
  39244. [WK2] Create a general wk2 specific LayoutTests/platform/wk2 platform
  39245. qt-wk2, win-wk2, mac-wk2 use this common Skipped list too
  39246. https://bugs.webkit.org/show_bug.cgi?id=61785
  39247. * Scripts/old-run-webkit-tests:
  39248. 2011-06-30 Adam Roben <aroben@apple.com>
  39249. Use a colon to separate test names from failure info on TestFailures
  39250. This matches how the "Possibly Flaky Tests" list works, and is much prettier when the
  39251. failure info itself includes parentheses.
  39252. Fixes <http://webkit.org/b/63722> Crashing symbols on TestFailures page look ugly due to
  39253. double parentheses
  39254. Reviewed by Darin Adler.
  39255. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39256. (ViewController.prototype._domForFailedTest): Use a colon instead of surrounding the failure
  39257. info in parentheses.
  39258. 2011-06-30 Adam Roben <aroben@apple.com>
  39259. Robustify PersistentCache against cached data that contains the string ': '
  39260. Fixes <http://webkit.org/b/63721> Exceptions thrown while loading TestFailures page due to
  39261. passing a bad string to JSON.parse
  39262. Reviewed by Darin Adler.
  39263. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js:
  39264. (PersistentCache._parseDateAndJSONFromString): Manually split the string on the separator
  39265. using indexOf and substring. (String.prototype.split always splits on all instances of the
  39266. separator.)
  39267. 2011-06-30 Adam Roben <aroben@apple.com>
  39268. Include the crashing symbol in crash logs links on TestFailures
  39269. Fixes <http://webkit.org/b/63465> Links to crash logs on TestFailures page should include
  39270. the crashing symbol (like links in results.html do)
  39271. Reviewed by David Kilzer.
  39272. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  39273. (LayoutTestResultsLoader.prototype.start): Bumped the cache version because we now store
  39274. crashing symbols for crashing tests. Renamed testsForResultTable to parseResultTable because
  39275. it now returns more than just the test names. Specifically, it now looks for crash log links
  39276. and extracts the crashing symbol name from them. Updated callers of parseResultTable to
  39277. match its new behavior. Changed to store the crashing symbol along with the failure type in
  39278. the data we pass to the callback for tests which crashed.
  39279. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  39280. (code): Make <code> elements a little smaller because their contents can be quite long.
  39281. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39282. (ViewController.prototype._domForFailureDiagnosis): Include the crashing symbol inside a
  39283. <code> element in the link, if there is a crashing symbol.
  39284. 2011-06-30 Adam Roben <aroben@apple.com>
  39285. Use objects instead of strings to represent a test result in TestFailures code
  39286. This will eventually allow us to store more than just the type of failure for each test.
  39287. (E.g., we can store the name of the crashing symbol for tests which crashed.)
  39288. Prep work for <http://webkit.org/b/63465> Links to crash logs on TestFailures page should
  39289. include the crashing symbol (like links in results.html do)
  39290. Reviewed by David Kilzer.
  39291. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  39292. (Builder.prototype.failureDiagnosisTextAndURL): Changed to expect a testResult object
  39293. instead of just a failureType string.
  39294. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js:
  39295. (FlakyLayoutTestDetector.prototype.incorporateTestResults): Changed to store a
  39296. testResult-like object for passing tests.
  39297. (FlakyLayoutTestDetector.prototype.flakinessExamples): Changed to expect testResult-like
  39298. objects.
  39299. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  39300. (LayoutTestResultsLoader.prototype.start): Store a version number along with the cached data
  39301. so we can throw away cached data that's in an old format. Store a testResult object for each
  39302. test instead of just its failure type.
  39303. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39304. (ViewController.prototype._domForFailedTest):
  39305. (ViewController.prototype._domForFailureDiagnosis):
  39306. Changed to expect testResult objects instead of failureType strings.
  39307. 2011-06-30 Adam Roben <aroben@apple.com>
  39308. Show full commit logs when visiting Trac from TestFailures page
  39309. Fixes <http://webkit.org/b/63715> Links to Trac on TestFailures page
  39310. should show full commit logs
  39311. Reviewed by David Kilzer.
  39312. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  39313. (Trac.prototype.logURL): Added new 'showFullCommitLogs' parameter. When specified, we add
  39314. verbose=on to the log URL to tell Trac to show full commit logs.
  39315. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39316. (ViewController.prototype._domForRegressionRange): Specify true for showFullCommitLogs.
  39317. 2011-06-30 Adam Roben <aroben@apple.com>
  39318. Add a link to file a bug about TestFailures to the TestFailures page
  39319. Fixes <http://webkit.org/b/63466> TestFailures page should include a link to file a bug
  39320. about TestFailures itself
  39321. Reviewed by Anders Carlsson.
  39322. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  39323. (aside): Added some styles for the new link. It is positioned in the upper-right and
  39324. hopefully not to glaringly obvious.
  39325. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39326. (ViewController.prototype.loaded): Set up our main content element and auxiliary UI.
  39327. (ViewController.prototype._displayBuilder):
  39328. (ViewController.prototype._displayTesters):
  39329. Modify the main content element instead of the entire body, as there are other things in the
  39330. body that we want to preserve.
  39331. (ViewController.prototype._domForAuxiliaryUIElements): Create and return an <aside> element
  39332. that contains a link to file a bug about the TestFailures page.
  39333. 2011-06-30 Adam Roben <aroben@apple.com>
  39334. Ignore callbacks that correspond to old navigations of the TestFailures page
  39335. Fixes <http://webkit.org/b/63711> TestFailures page sometimes ignores back/forward
  39336. navigations
  39337. Reviewed by Anders Carlsson.
  39338. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  39339. (LayoutTestHistoryAnalyzer.prototype.start): Check the return value of the callback. If the
  39340. callback returns false, stop fetching more data.
  39341. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39342. (ViewController): Initialize new _navigationID member. This member is used to assign each
  39343. navigation by the user a unique ID.
  39344. (ViewController.prototype.parseHash): Increment the navigation ID.
  39345. (ViewController.prototype._displayBuilder):
  39346. (ViewController.prototype._displayTesters):
  39347. At the start of these functions, record the current navigation ID. Bail out from callbacks
  39348. if the navigation ID has changed, indicating that the user has navigated elsewhere.
  39349. 2011-06-30 Carlos Garcia Campos <cgarcia@igalia.com>
  39350. Reviewed by Martin Robinson.
  39351. [GTK] Add back/forward menu to MiniBrowser toolbar
  39352. https://bugs.webkit.org/show_bug.cgi?id=63445
  39353. * MiniBrowser/gtk/BrowserWindow.c:
  39354. (browser_window_init): Use a GtkMenuToolButton for navigation
  39355. widgets.
  39356. (browserWindowConstructed): Get the page BackForwardList.
  39357. (browserWindowHistoryItemActivated): Go to activated history item.
  39358. (browserWindowHistoryItemSelected): Show the url of currently
  39359. selected history item in the statusbar.
  39360. (createGtkActionFromBackForwardItem): Create a GtkAction from a
  39361. WKBackForwardListItemRef.
  39362. (browserWindowCreateMenuItemFromBackForwardItem): Create a
  39363. GtkMenuItem from a WKBackForwardListItemRef.
  39364. (browserWindowCreateBackForwardMenu): Create a GtkMenu with the
  39365. given history items.
  39366. (browserWindowUpdateNavigationActions): Update navigation widgets
  39367. sensitivity and history menus.
  39368. (didChangeBackForwardList): Call
  39369. browserWindowUpdateNavigationActions().
  39370. (browserWindowLoaderClientInit): Add didChangeBackForwardList
  39371. callback.
  39372. 2011-06-30 Dmitry Lomov <dslomov@google.com>
  39373. Reviewed by Adam Roben.
  39374. https://bugs.webkit.org/show_bug.cgi?id=63660
  39375. This enables unit-tests step on Windows and MacOS SnowLeopard.
  39376. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  39377. 2011-06-30 Balazs Kelemen <kbalazs@webkit.org>
  39378. Reviewed by Kenneth Rohde Christiansen.
  39379. [Qt][WK2] Implement the rest of WTR::PlatformWebView
  39380. https://bugs.webkit.org/show_bug.cgi?id=63630
  39381. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  39382. (WTR::PlatformWebView::windowFrame):
  39383. (WTR::PlatformWebView::setWindowFrame):
  39384. 2011-06-29 Dirk Pranke <dpranke@chromium.org>
  39385. Reviewed by Adam Barth.
  39386. test-webkitpy is spamming lots of messages about updating test expectations
  39387. https://bugs.webkit.org/show_bug.cgi?id=63680
  39388. This patch changes the passing_run() function to capture the
  39389. output to stdout and stderr and assert that it is empty, and
  39390. also specifies --no-new-test-results by default to avoid getting
  39391. "generating baseline" messages for the expected-missing results.
  39392. Also check that we are logging messages when we generate new
  39393. baselines.
  39394. Also fix a minor bug in the way test_tolerance() was
  39395. checking for whether the tests were passing or not.
  39396. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  39397. 2011-06-29 Yuta Kitamura <yutak@chromium.org>
  39398. Reviewed by Kent Tamura.
  39399. DRT: Make Hixie76WebSocketProtocolEnabled preference flag configurable from LayoutTestController
  39400. https://bugs.webkit.org/show_bug.cgi?id=63532
  39401. LayoutTestController::overridePreference() will be used to change the value of
  39402. the Hixie76WebSocketProtocolEnabled preference flag from layout tests. In this way,
  39403. we can avoid writing a lot of boilerplate code in each port's DumpRenderTree, but
  39404. at least we need to reset preference values in DumpRenderTree every time we start
  39405. a new test because preference values changed in some test should not be leaked
  39406. to the next test.
  39407. * DumpRenderTree/chromium/LayoutTestController.cpp:
  39408. (LayoutTestController::overridePreference):
  39409. The name of preference key is defined in WebKit/{mac/WebView,win}/WebPreferenceKeysPrivate.h.
  39410. * DumpRenderTree/chromium/WebPreferences.cpp:
  39411. (WebPreferences::reset):
  39412. Set the default value. This will be called from TestShell::resetTestController().
  39413. (WebPreferences::applyTo):
  39414. * DumpRenderTree/chromium/WebPreferences.h:
  39415. * DumpRenderTree/mac/DumpRenderTree.mm:
  39416. (resetDefaultsToConsistentValues): Set the default value.
  39417. * DumpRenderTree/win/DumpRenderTree.cpp:
  39418. (resetDefaultsToConsistentValues): Ditto.
  39419. 2011-06-29 Kenichi Ishibashi <bashi@chromium.org>
  39420. Reviewed by Adam Barth.
  39421. check-webkit-style fails to detect https://webkit.org/b/XXXXX as a bug number
  39422. https://webkit.org/b/57360
  39423. Modify the regular expression to match https scheme.
  39424. * Scripts/webkitpy/common/checkout/changelog_unittest.py: Added a test case for https://webkit.org/b/XXXXX.
  39425. * Scripts/webkitpy/common/config/urls.py: Modified bug_url_short to match https scheme.
  39426. 2011-06-29 Adam Barth <abarth@webkit.org>
  39427. Reviewed by Eric Seidel.
  39428. new-run-webkit-tests: images page switch actual and expected images before they're loaded
  39429. https://bugs.webkit.org/show_bug.cgi?id=63199
  39430. We now preload the images and keep the DOM nodes in memory instead of
  39431. going back to the MemoryCache all the time. (Also, remove some nutty
  39432. </img> HTML.)
  39433. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  39434. 2011-06-29 Adam Barth <abarth@webkit.org>
  39435. Reviewed by Eric Seidel.
  39436. new-run-webkit-tests should tell you when it creates new expectations
  39437. https://bugs.webkit.org/show_bug.cgi?id=63675
  39438. Unforunately, this patch creates a bunch of test-webkitpy spam because
  39439. we don't understand how Python logging works well enough to stop the
  39440. spam. :(
  39441. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  39442. 2011-06-29 Eric Seidel <eric@webkit.org>
  39443. Reviewed by Adam Barth.
  39444. Refactor WebKitDriver.run_test into smaller pieces
  39445. https://bugs.webkit.org/show_bug.cgi?id=63673
  39446. There is no functional change here. Just moving code around.
  39447. This is in preparation for adding support for #CRASHED and #CRASHED - WebProcess
  39448. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39449. 2011-06-29 Eric Seidel <eric@webkit.org>
  39450. Reviewed by Adam Barth.
  39451. Simplify skipped file finding in preparation for adding wk2 skipped list fallback
  39452. https://bugs.webkit.org/show_bug.cgi?id=63501
  39453. Re-landing after fixing a bug in WebKitPort.baseline_search_path which broke
  39454. the rebaselineserver unit tests. Also fixed nits brought up by Dirk after previous landing.
  39455. The goal was to add support for wk2 skipped lists.
  39456. However, I found that our skipped list computation was a
  39457. manual hack (which only worked for the mac port).
  39458. So I fixed a FIXME to move the skipped list finding
  39459. into WebKitPort instead of MacPort.
  39460. Doing so required the concept of a "port_name", since previously
  39461. the only name accessible from a port object was name()
  39462. which includes many things beyond "mac" or "chromium", etc.
  39463. Eventually I believe we'll want to re-think the way that we pass
  39464. in a port_name argument to Port subclasses and expect them to parse
  39465. it. But for now I just added a cls.port_name variable which contains
  39466. the static information needed to compute wk2 names as well as
  39467. compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
  39468. In order to test my new _skipped_file_search_paths method, I
  39469. fixed another FIXME by making it return relative paths.
  39470. I also fixed the test_expectations_path code in WebKitPort to use port_name.
  39471. It was using name() which would return PORT-VERSION so MacPort was overriding
  39472. it to use just PORT. After fixing test_expectations_path to use port_name
  39473. (and making it aware of webkit2) I was able to remove the MacPort implementation.
  39474. * Scripts/webkitpy/layout_tests/port/base.py:
  39475. - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
  39476. - Document that real_name() seems to have no purpose.
  39477. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  39478. - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
  39479. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  39480. - Add _parse_port_name.
  39481. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  39482. - Add _parse_port_name.
  39483. * Scripts/webkitpy/layout_tests/port/gtk.py:
  39484. * Scripts/webkitpy/layout_tests/port/mac.py:
  39485. - Move Skipped-file finding code down to WebKitPort
  39486. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  39487. * Scripts/webkitpy/layout_tests/port/qt.py:
  39488. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39489. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39490. 2011-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
  39491. Unreviewed, rolling out r90070.
  39492. http://trac.webkit.org/changeset/90070
  39493. https://bugs.webkit.org/show_bug.cgi?id=63676
  39494. Broke test-webkitpy rebaseline tests (Requested by eseidel2 on
  39495. #webkit).
  39496. * Scripts/webkitpy/layout_tests/port/base.py:
  39497. * Scripts/webkitpy/layout_tests/port/chromium.py:
  39498. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  39499. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  39500. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  39501. * Scripts/webkitpy/layout_tests/port/gtk.py:
  39502. * Scripts/webkitpy/layout_tests/port/mac.py:
  39503. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  39504. * Scripts/webkitpy/layout_tests/port/qt.py:
  39505. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39506. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39507. * Scripts/webkitpy/layout_tests/port/win.py:
  39508. * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
  39509. 2011-06-29 Adam Barth <abarth@webkit.org>
  39510. Reviewed by Eric Seidel.
  39511. new-run-webkit-tests doesn't support sample-on-timeout
  39512. https://bugs.webkit.org/show_bug.cgi?id=56731
  39513. * Scripts/webkitpy/layout_tests/port/server_process.py:
  39514. * Scripts/webkitpy/layout_tests/port/server_process_unittest.py:
  39515. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  39516. 2011-06-29 Eric Seidel <eric@webkit.org>
  39517. Reviewed by Adam Barth.
  39518. Simplify skipped file finding in preparation for adding wk2 skipped list fallback
  39519. https://bugs.webkit.org/show_bug.cgi?id=63501
  39520. The goal was to add support for wk2 skipped lists.
  39521. However, I found that our skipped list computation was a
  39522. manual hack (which only worked for the mac port).
  39523. So I fixed a FIXME to move the skipped list finding
  39524. into WebKitPort instead of MacPort.
  39525. Doing so required the concept of a "port_name", since previously
  39526. the only name accessible from a port object was name()
  39527. which includes many things beyond "mac" or "chromium", etc.
  39528. Eventually I believe we'll want to re-think the way that we pass
  39529. in a port_name argument to Port subclasses and expect them to parse
  39530. it. But for now I just added a cls.port_name variable which contains
  39531. the static information needed to compute wk2 names as well as
  39532. compute Skipped list fallback which works for Mac/Win/Qt and Gtk.
  39533. In order to test my new _skipped_file_search_paths method, I
  39534. fixed another FIXME by making it return relative paths.
  39535. I also fixed the test_expectations_path code in WebKitPort to use port_name.
  39536. It was using name() which would return PORT-VERSION so MacPort was overriding
  39537. it to use just PORT. After fixing test_expectations_path to use port_name
  39538. (and making it aware of webkit2) I was able to remove the MacPort implementation.
  39539. * Scripts/webkitpy/layout_tests/port/base.py:
  39540. - Add port_name() to access "mac", since name() returns "mac-leopard" etc.
  39541. - Document that real_name() seems to have no purpose.
  39542. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  39543. - Add _parse_port_name(), eventually we might call this from WebKitPort directly.
  39544. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  39545. - Add _parse_port_name.
  39546. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  39547. - Add _parse_port_name.
  39548. * Scripts/webkitpy/layout_tests/port/gtk.py:
  39549. * Scripts/webkitpy/layout_tests/port/mac.py:
  39550. - Move Skipped-file finding code down to WebKitPort
  39551. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  39552. * Scripts/webkitpy/layout_tests/port/qt.py:
  39553. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39554. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39555. 2011-06-29 Adam Barth <abarth@webkit.org>
  39556. Reviewed by Dirk Pranke.
  39557. new-run-webkit-tests complains about missing pixel results instead of plopping down new expectations
  39558. https://bugs.webkit.org/show_bug.cgi?id=38063
  39559. This patch changes new-run-webkit-tests to match old-run-webkit-tests
  39560. in generating new expected results when the expected results are
  39561. missing.
  39562. There are still a couple details that are different:
  39563. 1) Image baselines aren't generated unless you run with -p.
  39564. 2) Render tree dumps are places in the cross-platform directory instead
  39565. of the platform-specific directory.
  39566. I'm inclined to deal with both of these issues in follow-up patches.
  39567. * Scripts/webkitpy/common/net/layouttestresults.py:
  39568. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  39569. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  39570. * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  39571. * Scripts/webkitpy/layout_tests/port/test.py:
  39572. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  39573. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  39574. 2011-06-29 Adam Roben <aroben@apple.com>
  39575. Teach TestFailures to detect possibly flaky tests and list them separately
  39576. Fixes <http://webkit.org/b/61061> <rdar://problem/9452796> TestFailures page blames
  39577. arbitrary revisions for breaking flaky tests
  39578. Reviewed by Dan Bates.
  39579. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/FlakyLayoutTestDetector.js: Added.
  39580. (FlakyLayoutTestDetector): This class identifies flaky tests when given the test results
  39581. from various builds (in reverse-chronological order).
  39582. (FlakyLayoutTestDetector.prototype.incorporateTestResults): Detects flaky tests. Tests move
  39583. monotonically through three states: LastSeenFailing, LastSeenPassing, and PossiblyFlaky.
  39584. (FlakyLayoutTestDetector.prototype.flakinessExamples): Finds examples of flakiness for the
  39585. given test. Essentially, finds all the transitions from passing to failing (or vice-versa)
  39586. and puts them in an array in reverse-chronological order.
  39587. (FlakyLayoutTestDetector.prototype.get possiblyFlakyTests): Returns all tests we've detected
  39588. to be possibly flaky.
  39589. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  39590. (LayoutTestHistoryAnalyzer): Initialize new members.
  39591. (LayoutTestHistoryAnalyzer.prototype.start): Now passes the callback an object with two
  39592. properties: history and possiblyFlaky. history holds the data this function used to pass to
  39593. the callback, while possiblyFlaky lists all tests that might be flaky and examples of their
  39594. flakiness. Updated documentation comment to match.
  39595. (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Now uses a
  39596. FlakyLayoutTestDetector to identify possibly flaky tests. Any possibly flaky tests are
  39597. removed from the failure history, since when they started failing is no longer meaningful.
  39598. We tell our caller to keep calling until all current failures have been explained and we've
  39599. gone through 5 builds without any new flaky tests being identified.
  39600. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  39601. (sorted): New helper function to return a sorted copy of an array.
  39602. (Array.prototype.findLast): New helper function. Like findFirst, but finds the last item
  39603. that matches the predicate.
  39604. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39605. (ViewController.prototype._displayBuilder): Updated for change in the object passed to us by
  39606. the analyzer. Now puts the list of possibly flaky tests after the failure history.
  39607. (ViewController.prototype._domForFailedTest): Moved some code from here...
  39608. (ViewController.prototype._domForFailureDiagnosis): ...to here.
  39609. (ViewController.prototype._domForPossiblyFlakyTests): New function, builds up a list of
  39610. possibly flaky tests and examples of their flakiness and returns it.
  39611. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  39612. FlakyLayoutTestDetector.js.
  39613. 2011-06-29 Eric Seidel <eric@webkit.org>
  39614. Adam says cowboys don't review (or unit test).
  39615. * Scripts/webkitpy/tool/commands/download.py:
  39616. 2011-06-29 Eric Seidel <eric@webkit.org>
  39617. Reviewed by Adam Barth.
  39618. Make port/config.py mockable for easier unit testing
  39619. https://bugs.webkit.org/show_bug.cgi?id=63661
  39620. Fix an exception from the unit tests.
  39621. * Scripts/webkitpy/layout_tests/port/config.py:
  39622. 2011-06-29 Brent Fulgham <bfulgham@webkit.org>
  39623. Unreviewed build correction.
  39624. * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
  39625. Link against zlib1.dll, not the static zlib.lib.
  39626. 2011-06-29 Eric Seidel <eric@webkit.org>
  39627. Reviewed by Adam Barth.
  39628. Make port/config.py mockable for easier unit testing
  39629. https://bugs.webkit.org/show_bug.cgi?id=63661
  39630. Right now config.py leaks real system paths for
  39631. webkit_base_dir due to using __file__. This patch
  39632. adds a filsystem.py wrapper around __file__ so that
  39633. we don't have to jump through hoops in webkit_unittest.py
  39634. to avoid leaking local paths to the unit test results.
  39635. There are probably many more places where we should now
  39636. use filesystem.path_for_module, but starting with just this one.
  39637. * Scripts/webkitpy/common/system/filesystem.py:
  39638. * Scripts/webkitpy/common/system/filesystem_mock.py:
  39639. * Scripts/webkitpy/layout_tests/port/config.py:
  39640. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39641. * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
  39642. 2011-06-29 Eric Seidel <eric@webkit.org>
  39643. Reviewed by Adam Barth.
  39644. Remove duplicate methods in filesystem.py
  39645. https://bugs.webkit.org/show_bug.cgi?id=63658
  39646. Looks like there was a bad merge at some point.
  39647. I also removed a bunch of redundant docstrings.
  39648. * Scripts/webkitpy/common/system/filesystem.py:
  39649. 2011-06-29 Adam Barth <abarth@webkit.org>
  39650. Reviewed by Eric Seidel.
  39651. Pass --no-new-test-results to NRWT on build.webkit.org
  39652. https://bugs.webkit.org/show_bug.cgi?id=63653
  39653. This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.
  39654. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  39655. 2011-06-29 Xan Lopez <xlopez@igalia.com>
  39656. Reviewed by Adam Barth.
  39657. [GTK] overlapping drag&drop tests fail on NRWT
  39658. https://bugs.webkit.org/show_bug.cgi?id=57640
  39659. Make a GTK test driver that spawns one Xvfb instance per
  39660. thread. This avoids bad interactions in DnD tests between threads.
  39661. * Scripts/webkitpy/layout_tests/port/gtk.py:
  39662. 2011-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
  39663. Unreviewed, rolling out r89888.
  39664. http://trac.webkit.org/changeset/89888
  39665. https://bugs.webkit.org/show_bug.cgi?id=63609
  39666. "Seems to be causing merging issues on the dashboard, e.g.
  39667. http://test-
  39668. results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
  39669. (Requested by aboxhall on #webkit).
  39670. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  39671. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  39672. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  39673. 2011-06-29 Philippe Normand <pnormand@igalia.com>
  39674. Reviewed by Martin Robinson.
  39675. [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
  39676. https://bugs.webkit.org/show_bug.cgi?id=63624
  39677. * Scripts/webkitpy/common/system/executive.py: In some cases the
  39678. ps output lines can contain one or more leading white-spaces, so
  39679. strip it before splitting the pid and command name.
  39680. 2011-06-29 Noel Gordon <noel.gordon@gmail.com>
  39681. Reviewed by Kent Tamura.
  39682. [Chromium] [DRT] ImageDiff should compile in VS2010
  39683. https://bugs.webkit.org/show_bug.cgi?id=63614
  39684. * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.
  39685. 2011-06-27 Diego Gonzalez <diegohcg@webkit.org>
  39686. Reviewed by Kenneth Rohde Christiansen.
  39687. [Qt] DRT support for setInteractiveFormValidationEnabled
  39688. https://bugs.webkit.org/show_bug.cgi?id=63496
  39689. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  39690. (WebCore::DumpRenderTree::DumpRenderTree):
  39691. 2011-06-28 Eric Seidel <eric@webkit.org>
  39692. Reviewed by Adam Barth.
  39693. Make new-run-webkit-tests -2 actually use WebKitTestRunner
  39694. https://bugs.webkit.org/show_bug.cgi?id=63572
  39695. new-run-webkit-tests -2 works with this change. However a zillion
  39696. tests fail since it can't find the right skipped lists for wk2.
  39697. The Skipped-list fixing is covered in bug 63501.
  39698. * Scripts/webkitpy/layout_tests/port/gtk.py:
  39699. * Scripts/webkitpy/layout_tests/port/qt.py:
  39700. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39701. 2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
  39702. Reviewed by Adam Roben.
  39703. Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
  39704. https://bugs.webkit.org/show_bug.cgi?id=63500
  39705. Added google-mac-3 and google-mac-4.
  39706. * BuildSlaveSupport/build.webkit.org-config/config.json:
  39707. 2011-06-28 Eric Seidel <eric@webkit.org>
  39708. Reviewed by Dirk Pranke.
  39709. Remove webkitpy's tiger support now that WebKit no longer supports tiger
  39710. https://bugs.webkit.org/show_bug.cgi?id=63568
  39711. I don't think our support actually fully worked anyway. Regardless
  39712. tiger is dead now (thankfully)!
  39713. I also unwrapped some short lines and added a couple FIXMEs while
  39714. touring the code.
  39715. No new tests, only removing old ones which tested our Tiger support.
  39716. * Scripts/webkitpy/layout_tests/port/base.py:
  39717. * Scripts/webkitpy/layout_tests/port/builders.py:
  39718. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  39719. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  39720. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  39721. * Scripts/webkitpy/layout_tests/port/mac.py:
  39722. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  39723. * Scripts/webkitpy/tool/commands/rebaseline.py:
  39724. * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:
  39725. 2011-06-28 Eric Seidel <eric@webkit.org>
  39726. Unreviewed, just fixing a typo.
  39727. Fix misspellings of "thead" to "thread".
  39728. * Scripts/webkitpy/common/checkout/scm/git.py:
  39729. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  39730. 2011-06-28 Eric Seidel <eric@webkit.org>
  39731. Reviewed by Tony Chang.
  39732. new-run-webkit-tests needs a --webkit-test-runner option
  39733. https://bugs.webkit.org/show_bug.cgi?id=63439
  39734. This was accidentally fixed in bug 63501 as well.
  39735. The root problem here was that the webkit unit tests were not using
  39736. enough mocks. I've fixed them here to use more mocks
  39737. which should unbreak windows.
  39738. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39739. 2011-06-28 Eric Seidel <eric@webkit.org>
  39740. Reviewed by Tony Chang.
  39741. new-run-webkit-tests should not run mthml tests when MHTML support is disabled
  39742. https://bugs.webkit.org/show_bug.cgi?id=63549
  39743. This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
  39744. I happen to go looking for what code was deciding that .mht was a supported
  39745. extension, found test_files.py and then removed some redundant doc-strings and
  39746. if branching.
  39747. * Scripts/webkitpy/layout_tests/port/test_files.py:
  39748. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39749. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39750. 2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
  39751. Reviewed by Tony Chang.
  39752. Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
  39753. https://bugs.webkit.org/show_bug.cgi?id=63514
  39754. - change write_text_file to write_binary_file
  39755. - check that text_path and binary_path are actually existant files
  39756. - change cleanup block from 'except' to 'finally'
  39757. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  39758. 2011-06-28 Adam Roben <aroben@apple.com>
  39759. Roll out r89924 and r89925
  39760. I didn't mean to commit them!
  39761. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  39762. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  39763. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39764. 2011-06-27 Adam Barth <abarth@webkit.org>
  39765. Reviewed by Eric Seidel.
  39766. NRWT should wait for ReportCrash
  39767. https://bugs.webkit.org/show_bug.cgi?id=63495
  39768. When a test crashes on Mac, ReportCrash confuses us into thinking the
  39769. test times out.
  39770. I'm not sure how to test this in a meaningful way in our current test
  39771. harness...
  39772. * Scripts/webkitpy/common/system/crashlogs.py:
  39773. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  39774. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  39775. * Scripts/webkitpy/layout_tests/port/base.py:
  39776. * Scripts/webkitpy/layout_tests/port/mac.py:
  39777. * Scripts/webkitpy/layout_tests/port/server_process.py:
  39778. * Scripts/webkitpy/tool/commands/queries.py:
  39779. 2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>
  39780. Unreviewed, rolling out r89881.
  39781. http://trac.webkit.org/changeset/89881
  39782. https://bugs.webkit.org/show_bug.cgi?id=63513
  39783. Makes Qt massively slow (Requested by abarth on #webkit).
  39784. * Scripts/webkitpy/common/system/crashlogs.py:
  39785. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  39786. * Scripts/webkitpy/common/system/executive.py:
  39787. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  39788. * Scripts/webkitpy/layout_tests/port/base.py:
  39789. * Scripts/webkitpy/layout_tests/port/mac.py:
  39790. * Scripts/webkitpy/layout_tests/port/server_process.py:
  39791. * Scripts/webkitpy/tool/commands/queries.py:
  39792. 2011-06-27 Alice Boxhall <aboxhall@chromium.org>
  39793. Reviewed by Ojan Vafai.
  39794. Convert json_results_generator.py to output version 4 JSON.
  39795. https://bugs.webkit.org/show_bug.cgi?id=60869
  39796. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  39797. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  39798. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  39799. 2011-06-27 Adam Barth <abarth@webkit.org>
  39800. Reviewed by Eric Seidel.
  39801. NRWT should wait for ReportCrash
  39802. https://bugs.webkit.org/show_bug.cgi?id=63495
  39803. When a test crashes on Mac, ReportCrash confuses us into thinking the
  39804. test times out.
  39805. I'm not sure how to test this in a meaningful way in our current test
  39806. harness...
  39807. * Scripts/webkitpy/common/system/crashlogs.py:
  39808. * Scripts/webkitpy/common/system/crashlogs_unittest.py:
  39809. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  39810. * Scripts/webkitpy/layout_tests/port/base.py:
  39811. * Scripts/webkitpy/layout_tests/port/mac.py:
  39812. * Scripts/webkitpy/layout_tests/port/server_process.py:
  39813. * Scripts/webkitpy/tool/commands/queries.py:
  39814. 2011-06-27 Adam Barth <abarth@webkit.org>
  39815. Reviewed by Eric Seidel.
  39816. new-run-webkit-tests should upload crash logs
  39817. https://bugs.webkit.org/show_bug.cgi?id=55907
  39818. NRWT used to have a different name for crash logs. I've changed the
  39819. name to patch ORWT.
  39820. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  39821. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  39822. 2011-06-27 Eric Seidel <eric@webkit.org>
  39823. Reviewed by Adam Barth.
  39824. new-run-webkit-tests needs a --webkit-test-runner option
  39825. https://bugs.webkit.org/show_bug.cgi?id=63439
  39826. NRWT doesn't actually know how to run with the WebKitTestRunner yet
  39827. but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
  39828. There is a bunch of other little cleanup in this patch which I added as I
  39829. took a tour through all of our hard-coded DumpRenderTree strings.
  39830. * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  39831. * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  39832. * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  39833. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  39834. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  39835. * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  39836. * Scripts/webkitpy/layout_tests/port/config.py:
  39837. - build_dumprendertree had no business in this class, removed it.
  39838. - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
  39839. - Exposed _script_path as script_path() (this probably belongs elsewhere).
  39840. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  39841. - Moved these tests to webkit_unittests.
  39842. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39843. - Now respects the --webkit-test-runner option.
  39844. - setup_test_run is empty in base.py too, no need to override it.
  39845. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39846. - Test the new hotness.
  39847. - Bad, bad, bad! The old code was using a real Executive during unit-testing!
  39848. I think this code is still hitting disk during the unit tests. :(
  39849. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  39850. - Add the option.
  39851. * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  39852. - Remove optional args option.
  39853. * Scripts/webkitpy/tool/commands/commandtest.py:
  39854. - Remove optional args option.
  39855. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  39856. - Remove optional args option.
  39857. 2011-06-27 Adam Barth <abarth@webkit.org>
  39858. Reviewed by Dirk Pranke.
  39859. new-run-webkit-tests does not report stderr output
  39860. https://bugs.webkit.org/show_bug.cgi?id=37739
  39861. Almost all the infrastructure appears to be in place to report stderr
  39862. in results.html. We just need to wire up a bool to tell results.html
  39863. to create the hyperlink.
  39864. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  39865. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  39866. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  39867. * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  39868. * Scripts/webkitpy/layout_tests/port/base.py:
  39869. 2011-06-27 Adam Barth <abarth@webkit.org>
  39870. Reviewed by Dirk Pranke.
  39871. webkitpy unit tests should have more descriptive names than just "Test"
  39872. https://bugs.webkit.org/show_bug.cgi?id=63479
  39873. Luckily we kept these classes in separate namespaces in the harness so
  39874. we were actually running them all even though they had the same name.
  39875. * Scripts/webkitpy/common/system/stack_utils_unittest.py:
  39876. * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  39877. * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  39878. 2011-06-27 Greg Simon <gregsimon@chromium.org>
  39879. No review necessary.
  39880. Add email addr to contributor list
  39881. https://bugs.webkit.org/show_bug.cgi?id=63478
  39882. * Scripts/webkitpy/common/config/committers.py:
  39883. 2011-06-27 Sheriff Bot <webkit.review.bot@gmail.com>
  39884. Unreviewed, rolling out r89834.
  39885. http://trac.webkit.org/changeset/89834
  39886. https://bugs.webkit.org/show_bug.cgi?id=63476
  39887. Broke test-webkitpy (Requested by abarth on #webkit).
  39888. * Scripts/webkitpy/common/net/layouttestresults.py:
  39889. * Scripts/webkitpy/common/system/outputcapture.py:
  39890. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  39891. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  39892. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  39893. * Scripts/webkitpy/layout_tests/port/base.py:
  39894. * Scripts/webkitpy/layout_tests/port/config.py:
  39895. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  39896. * Scripts/webkitpy/layout_tests/port/webkit.py:
  39897. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  39898. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  39899. * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  39900. * Scripts/webkitpy/tool/commands/commandtest.py:
  39901. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  39902. 2011-06-27 Jeff Miller <jeffm@apple.com>
  39903. Reviewed by Adam Roben.
  39904. Stop copying obsolete WebKit libraries on Windows
  39905. https://bugs.webkit.org/show_bug.cgi?id=63474
  39906. Don't copy obsolete WebKit library directories and files on Windows, they no longer exist and just generate extraneous warnings. These include the CharacterSets directory, dnssd.dll, and icudt40.dll.
  39907. * DumpRenderTree/win/DumpRenderTreePostBuild.cmd:
  39908. * MiniBrowser/MiniBrowserPostBuild.cmd:
  39909. * WebKitTestRunner/win/WebKitTestRunnerPostBuild.cmd:
  39910. 2011-06-27 Ryosuke Niwa <rniwa@webkit.org>
  39911. Add Wyatt Carss to the list of non-committer contributors.
  39912. * Scripts/webkitpy/common/config/committers.py:
  39913. 2011-06-27 Adam Barth <abarth@webkit.org>
  39914. Reviewed by Eric Seidel.
  39915. webkitpy should understand crash logs
  39916. https://bugs.webkit.org/show_bug.cgi?id=63468
  39917. We're planning to use this functionality to upload crash logs along
  39918. with test results for new-run-webkit-tests.
  39919. * Scripts/webkitpy/common/system/crashlog.py: Added.
  39920. * Scripts/webkitpy/common/system/crashlog_unittest.py: Added.
  39921. * Scripts/webkitpy/common/system/executive.py:
  39922. * Scripts/webkitpy/common/system/executive_unittest.py:
  39923. * Scripts/webkitpy/common/system/filesystem.py:
  39924. * Scripts/webkitpy/common/system/filesystem_mock.py:
  39925. * Scripts/webkitpy/tool/commands/queries.py:
  39926. 2011-06-27 Adam Roben <aroben@apple.com>
  39927. Make LayoutTestResultsLoader cache whether old-run-webkit-tests exited early due to too many
  39928. failures
  39929. Fixes <http://webkit.org/b/63470> TestFailures page for a particular builder forgets
  39930. old-run-webkit-tests exited early after reload
  39931. Reviewed by Anders Carlsson.
  39932. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  39933. (LayoutTestResultsLoader.prototype.start): Store both the set of failing tests and whether
  39934. old-run-webkit-tests exited early due to too many failures in PersistentCache.
  39935. 2011-06-27 Adam Roben <aroben@apple.com>
  39936. Make TestFailures load build names from build.webkit.org/old-results too
  39937. Build results are periodically moved from results to old-results. This change makes those
  39938. builds still visible to TestFailures.
  39939. Fixes <http://webkit.org/b/63453> TestFailures page doesn't show information for builds that
  39940. have been moved to build.webkit.org/old-results
  39941. Reviewed by Anders Carlsson.
  39942. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  39943. (Builder.prototype.getBuildNames): Extracted code to parse build names from a
  39944. build.webkit.org directory listing into a separate function. Instead of omitting .zip files,
  39945. we now only include directory entries whose names are parseable as build names (since
  39946. old-results sometimes contains other random files/directories from who knows what). We now
  39947. fetch both results and old-results (with a FIXME about loading old-results on demand),
  39948. extract build names from each, and concatenate the two sets of names.
  39949. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js:
  39950. (WebKitBuildbot.prototype.parseBuildName): Changed to return null when the build name isn't
  39951. parseable, rather than throwing an exception.
  39952. 2011-06-26 Adam Roben <aroben@apple.com>
  39953. Store analyzed history directly in LayoutTestHistoryAnalyzer instead of in a generic cache
  39954. It seems silly to have a whole generic cache just to store a single object.
  39955. Fixes <http://webkit.org/b/63407> LayoutTestHistoryAnalyzer has a generic cache but doesn't
  39956. need one
  39957. Reviewed by Anders Carlsson.
  39958. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  39959. (LayoutTestHistoryAnalyzer): Replaced this._cache with this._history.
  39960. (LayoutTestHistoryAnalyzer.prototype.start): Ditto.
  39961. (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory): Ditto, and removed the
  39962. no-longer-needed history argument.
  39963. 2011-06-26 Adam Roben <aroben@apple.com>
  39964. Move some inappropriate code out of Builder
  39965. Fixes <http://webkit.org/b/63406> TestFailure page's Builder class has a bunch of code that
  39966. isn't really about a builder
  39967. Reviewed by Anders Carlsson.
  39968. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  39969. (Builder.prototype.getBuildNames): Renamed from _getBuildNames, since it now needs to be
  39970. called by other objects.
  39971. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
  39972. Added. Code came from Builder.
  39973. (LayoutTestHistoryAnalyzer):
  39974. (LayoutTestHistoryAnalyzer.prototype.start):
  39975. (LayoutTestHistoryAnalyzer.prototype._incorporateBuildHistory):
  39976. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:
  39977. Added. Code came from Builder.
  39978. (LayoutTestResultsLoader):
  39979. (LayoutTestResultsLoader.prototype.start):
  39980. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  39981. (ViewController.prototype._displayBuilder): Changed to use LayoutTestHistoryAnalyzer.
  39982. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in new
  39983. scripts.
  39984. 2011-05-17 Nat Duca <nduca@chromium.org>
  39985. Reviewed by James Robinson.
  39986. [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
  39987. https://bugs.webkit.org/show_bug.cgi?id=58408
  39988. * DumpRenderTree/chromium/WebViewHost.cpp:
  39989. (WebViewHost::paintInvalidatedRegion):
  39990. 2011-06-27 Eric Seidel <eric@webkit.org>
  39991. Reviewed by Adam Barth.
  39992. new-run-webkit-tests needs a --webkit-test-runner option
  39993. https://bugs.webkit.org/show_bug.cgi?id=63439
  39994. NRWT doesn't actually know how to run with the WebKitTestRunner yet
  39995. but it does have a --webkit-test-runner option and will build WebKitTestRunner correctly.
  39996. There is a bunch of other little cleanup in this patch which I added as I
  39997. took a tour through all of our hard-coded DumpRenderTree strings.
  39998. * Scripts/webkitpy/common/net/layouttestresults.py: Added FIXME.
  39999. * Scripts/webkitpy/common/system/outputcapture.py: Fixed spacing to pass PEP8.
  40000. * Scripts/webkitpy/layout_tests/layout_package/manager.py: Made the FIXME slightly stronger (bad bug).
  40001. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: test_shell is dead.
  40002. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py: Unwrapped silly wrapping.
  40003. * Scripts/webkitpy/layout_tests/port/base.py: Removed two dead methods.
  40004. * Scripts/webkitpy/layout_tests/port/config.py:
  40005. - build_dumprendertree had no business in this class, removed it.
  40006. - Exposed _FLAGS_FROM_CONFIGURATIONS through flag_for_configuration()
  40007. - Exposed _script_path as script_path() (this probably belongs elsewhere).
  40008. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  40009. - Moved these tests to webkit_unittests.
  40010. * Scripts/webkitpy/layout_tests/port/webkit.py:
  40011. - Now respects the --webkit-test-runner option.
  40012. - setup_test_run is empty in base.py too, no need to override it.
  40013. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  40014. - Test the new hotness.
  40015. - Bad, bad, bad! The old code was using a real Executive during unit-testing!
  40016. I think this code is still hitting disk during the unit tests. :(
  40017. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  40018. - Add the option.
  40019. * Scripts/webkitpy/tool/bot/queueengine_unittest.py:
  40020. - Remove optional args option.
  40021. * Scripts/webkitpy/tool/commands/commandtest.py:
  40022. - Remove optional args option.
  40023. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  40024. - Remove optional args option.
  40025. 2011-06-27 Chang Shu <cshu@webkit.org>
  40026. Reviewed by Darin Adler.
  40027. [WK2] WebKitTestRunner should reset FrameFlattening flag to disable before each test
  40028. https://bugs.webkit.org/show_bug.cgi?id=63457
  40029. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  40030. (WTR::InjectedBundle::beginTesting):
  40031. 2011-06-27 Raphael Kubo da Costa <kubo@profusion.mobi>
  40032. Reviewed by Kent Tamura.
  40033. [EFL] DRT: Add an ewk_view specialization for EFL's DumpRenderTree.
  40034. It will be plugged into the build system as soon as the rest of the
  40035. DRT code is fully upstreamed.
  40036. https://bugs.webkit.org/show_bug.cgi?id=63086
  40037. * DumpRenderTree/efl/DumpRenderTreeView.cpp: Added.
  40038. (onConsoleMessage):
  40039. (onJavaScriptAlert):
  40040. (onJavaScriptConfirm):
  40041. (onJavaScriptPrompt):
  40042. (drtViewTiledAdd):
  40043. * DumpRenderTree/efl/DumpRenderTreeView.h: Added.
  40044. 2011-06-27 Leandro Pereira <leandro@profusion.mobi>
  40045. Reviewed by Kent Tamura.
  40046. [EFL] Add an EventSender implementation to EFL's DumpRenderTree along
  40047. with support files.
  40048. Build system changes will be made as soon as the whole DumpRenderTree
  40049. is upstreamed.
  40050. https://bugs.webkit.org/show_bug.cgi?id=61962
  40051. * DumpRenderTree/efl/EventSender.cpp: Added.
  40052. (setEvasModifiers):
  40053. (translateMouseButtonNumber):
  40054. (sendMouseEvent):
  40055. (sendClick):
  40056. (scheduleAsynchronousClickCallback):
  40057. (updateClickCount):
  40058. (modifierFromJSValue):
  40059. (modifiersFromJSValue):
  40060. (mouseDownCallback):
  40061. (mouseUpCallback):
  40062. (mouseMoveToCallback):
  40063. (evasMouseEventFromHorizontalAndVerticalOffsets):
  40064. (mouseScrollByCallback):
  40065. (continuousMouseScrollByCallback):
  40066. (keyPadNameFromJSValue):
  40067. (keyNameFromJSValue):
  40068. (keyDownCallback):
  40069. (scalePageByCallback):
  40070. (getClass):
  40071. (makeEventSender):
  40072. * DumpRenderTree/efl/EventSender.h: Added.
  40073. 2011-06-27 Eric Seidel <eric@webkit.org>
  40074. Reviewed by Adam Barth.
  40075. Remove evil uses of hasattr
  40076. https://bugs.webkit.org/show_bug.cgi?id=63430
  40077. For some reason these classes believe that they may be called with
  40078. various flavors of "option" elements and so carefully check to make
  40079. sure that the options element has their option before checking it.
  40080. We had a set_option_default method which was never called, so I made it
  40081. do what callsites seemed to want it to do and replaced 3 callers
  40082. who previously used hasattr manually to use set_option_default instead.
  40083. * Scripts/webkitpy/layout_tests/port/base.py:
  40084. * Scripts/webkitpy/layout_tests/port/webkit.py:
  40085. 2011-06-27 Kent Tamura <tkent@chromium.org>
  40086. Reviewed by Hajime Morita.
  40087. [Chromium] WebViewHost should be destructed before LayoutTestController, etc.
  40088. https://bugs.webkit.org/show_bug.cgi?id=63427
  40089. ~WebViewHost() navigates to about:blank, so it calls some
  40090. callbacks and LayoutTestController functions.
  40091. * DumpRenderTree/chromium/TestShell.h:
  40092. Move m_printer upper and move m_webViewHost lower.
  40093. 2011-06-27 Adam Barth <abarth@webkit.org>
  40094. Reviewed by Eric Seidel.
  40095. Move server config files to webkitpy.layout_tests.servers
  40096. https://bugs.webkit.org/show_bug.cgi?id=63436
  40097. The config files belong with the servers.
  40098. * Scripts/webkitpy/layout_tests/port/httpd2.pem: Removed.
  40099. * Scripts/webkitpy/layout_tests/port/lighttpd.conf: Removed.
  40100. * Scripts/webkitpy/layout_tests/servers/http_server.py:
  40101. * Scripts/webkitpy/layout_tests/servers/httpd2.pem: Copied from Tools/Scripts/webkitpy/layout_tests/port/httpd2.pem.
  40102. * Scripts/webkitpy/layout_tests/servers/lighttpd.conf: Copied from Tools/Scripts/webkitpy/layout_tests/port/lighttpd.conf.
  40103. 2011-06-27 Adam Barth <abarth@webkit.org>
  40104. Reviewed by Eric Seidel.
  40105. Move websocket_server and http_server to webkitpy.layout_package.servers
  40106. https://bugs.webkit.org/show_bug.cgi?id=63434
  40107. These classes do not represent ports. They represent servers.
  40108. * Scripts/new-run-webkit-httpd:
  40109. * Scripts/new-run-webkit-websocketserver:
  40110. * Scripts/webkitpy/layout_tests/port/base.py:
  40111. * Scripts/webkitpy/layout_tests/port/chromium.py:
  40112. * Scripts/webkitpy/layout_tests/port/http_server.py: Removed.
  40113. * Scripts/webkitpy/layout_tests/port/http_server_base.py: Removed.
  40114. * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  40115. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  40116. * Scripts/webkitpy/layout_tests/port/websocket_server.py: Removed.
  40117. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py:
  40118. * Scripts/webkitpy/layout_tests/servers/http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server.py.
  40119. * Scripts/webkitpy/layout_tests/servers/http_server_base.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_base.py.
  40120. * Scripts/webkitpy/layout_tests/servers/http_server_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py.
  40121. * Scripts/webkitpy/layout_tests/servers/websocket_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/websocket_server.py.
  40122. 2011-06-27 Eric Seidel <eric@webkit.org>
  40123. Reviewed by Adam Barth.
  40124. Remove Chromium and ChromiumMac implementations of driver_name now that everything uses DumpRenderTree
  40125. https://bugs.webkit.org/show_bug.cgi?id=63428
  40126. * Scripts/webkitpy/layout_tests/port/chromium.py:
  40127. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  40128. 2011-06-27 Adam Barth <abarth@webkit.org>
  40129. Reviewed by Eric Seidel.
  40130. Move apache_http_server.py to webkitpy.layout_package.servers
  40131. https://bugs.webkit.org/show_bug.cgi?id=63433
  40132. The apache_http_server.py is a server, not a port.
  40133. * Scripts/webkitpy/layout_tests/port/apache_http_server.py: Removed.
  40134. * Scripts/webkitpy/layout_tests/port/base.py:
  40135. * Scripts/webkitpy/layout_tests/servers: Added.
  40136. * Scripts/webkitpy/layout_tests/servers/__init__.py: Added.
  40137. * Scripts/webkitpy/layout_tests/servers/apache_http_server.py: Copied from Tools/Scripts/webkitpy/layout_tests/port/apache_http_server.py.
  40138. 2011-06-27 Adam Barth <abarth@webkit.org>
  40139. Reviewed by Eric Seidel.
  40140. Move rebaseline-chromium-webkit-tests.py to webkitpy.to_be_moved
  40141. https://bugs.webkit.org/show_bug.cgi?id=63432
  40142. This code isn't in the dependency cone of new-run-webkit-tests. It's
  40143. unclear what it's final home should be, but this patch moves it out of
  40144. layout_tests to simply the package.
  40145. * Scripts/rebaseline-chromium-webkit-tests:
  40146. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Removed.
  40147. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Removed.
  40148. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py.
  40149. * Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py.
  40150. 2011-06-27 Adam Barth <abarth@webkit.org>
  40151. Reviewed by Eric Seidel.
  40152. Move update_webgl_conformance_tests.py to webkitpy.to_be_moved
  40153. https://bugs.webkit.org/show_bug.cgi?id=63429
  40154. This package as nothing to do with the layout_tests package.
  40155. * Scripts/update-webgl-conformance-tests:
  40156. * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Removed.
  40157. * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Removed.
  40158. * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py.
  40159. * Scripts/webkitpy/to_be_moved/update_webgl_conformance_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py.
  40160. 2011-06-27 Adam Barth <abarth@webkit.org>
  40161. Reviewed by Eric Seidel.
  40162. Move deduplicate_tests.py into webkitpy.to_be_moved
  40163. https://bugs.webkit.org/show_bug.cgi?id=63426
  40164. deduplicate_tests.py doesn't haven anything to do with layout tests.
  40165. It's really a separate script. This patch moves it to the (new)
  40166. to_be_moved package so that it doesn't distract us when working on NRWT.
  40167. * Scripts/deduplicate-tests:
  40168. * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Removed.
  40169. * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py: Removed.
  40170. * Scripts/webkitpy/test/main.py:
  40171. * Scripts/webkitpy/to_be_moved: Added.
  40172. * Scripts/webkitpy/to_be_moved/__init__.py: Added.
  40173. * Scripts/webkitpy/to_be_moved/deduplicate_tests.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests.py.
  40174. * Scripts/webkitpy/to_be_moved/deduplicate_tests_unittest.py: Copied from Tools/Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py.
  40175. 2011-06-26 Adam Barth <abarth@webkit.org>
  40176. Rubber-stamped by Eric Seidel.
  40177. Remove empty directory.
  40178. * Scripts/webkitpy/layout_tests/test_types: Removed.
  40179. 2011-06-25 Naoki Takano <honten@chromium.org>
  40180. Reviewed by Eric Seidel.
  40181. Change my entry from contributors to committers.
  40182. https://bugs.webkit.org/show_bug.cgi?id=63043
  40183. * Scripts/webkitpy/common/config/committers.py: Change my e-mail from takano.naoki@gmail.com to honten@chromium.org. And move the entry to commiters from contributors.
  40184. 2011-06-25 Adam Barth <abarth@webkit.org>
  40185. Reviewed by Eric Seidel.
  40186. [Chromium] Update WebKit for WEBKIT_FRAME_TO_DOCUMENT_API_MOVE
  40187. https://bugs.webkit.org/show_bug.cgi?id=63394
  40188. * DumpRenderTree/chromium/LayoutTestController.cpp:
  40189. (LayoutTestController::queueLoad):
  40190. 2011-06-25 Brent Fulgham <bfulgham@webkit.org>
  40191. Unreviewed build correction after r89426.
  40192. * WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops:
  40193. Link with Cairo DLL for new functionality.
  40194. * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Include compatibility
  40195. code for snprintf.
  40196. 2011-06-25 Dimitri Glazkov <dglazkov@chromium.org>
  40197. Reviewed by Adam Barth.
  40198. run-bindings-tests does not work on Chromium Windows.
  40199. https://bugs.webkit.org/show_bug.cgi?id=63382
  40200. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Removed run-bindings-tests as a build step for cr-win.
  40201. 2011-06-25 Dan Bernstein <mitz@apple.com>
  40202. Try to fix the Qt and Chromium builds.
  40203. * DumpRenderTree/chromium/LayoutTestController.cpp:
  40204. (LayoutTestController::setEncodedAudioData):
  40205. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  40206. 2011-06-24 Dan Bernstein <mitz@apple.com>
  40207. Reviewed by Anders Carlsson.
  40208. Add an option to enable legacy rounding hacks
  40209. https://bugs.webkit.org/show_bug.cgi?id=63363
  40210. Added layoutTestController.allowRoundingHacks() and implemented it
  40211. on OS X.
  40212. * DumpRenderTree/LayoutTestController.cpp:
  40213. (allowRoundingHacksCallback):
  40214. (LayoutTestController::staticFunctions):
  40215. * DumpRenderTree/LayoutTestController.h:
  40216. * DumpRenderTree/chromium/LayoutTestController.cpp:
  40217. (LayoutTestController::allowRoundingHacks):
  40218. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  40219. (LayoutTestController::allowRoundingHacks):
  40220. * DumpRenderTree/mac/DumpRenderTree.mm:
  40221. (resetWebViewToConsistentStateBeforeTesting):
  40222. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  40223. (LayoutTestController::allowRoundingHacks):
  40224. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  40225. (LayoutTestController::allowRoundingHacks):
  40226. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  40227. (LayoutTestController::allowRoundingHacks):
  40228. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  40229. (LayoutTestController::allowRoundingHacks):
  40230. 2011-06-24 Adam Roben <aroben@apple.com>
  40231. Include the directory containing the failing tests in titles of bugs filed from TestFailures
  40232. when all the tests won't fit
  40233. Fixes <http://webkit.org/b/63350> Short bug titles from TestFailures page give no indication
  40234. which tests are failing
  40235. Reviewed by David Kilzer.
  40236. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  40237. (longestCommonPathPrefix): Added. Given a set of paths, returns the longest common prefix
  40238. that ends in a path separator.
  40239. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  40240. (ViewController.prototype._domForNewAndExistingBugs): When we can't fit all the test names
  40241. in the title, first try to include the longest common prefix of the test names, then, if
  40242. that's still too long or there's no common prefix, fall back to not including any
  40243. information about which tests are failing.
  40244. 2011-06-24 Adam Roben <aroben@apple.com>
  40245. Include links to Trac in bugs filed from TestFailures
  40246. Fixes <http://webkit.org/b/63348> Bugs filed from TestFailures page should include links to
  40247. Trac for suspect revisions
  40248. Reviewed by David Kilzer.
  40249. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js:
  40250. (Trac.prototype.changesetURL): New function, returns the URL for a particular revision in
  40251. Trac.
  40252. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  40253. (ViewController.prototype._domForNewAndExistingBugs): If there's only one suspect revision,
  40254. include a link to Trac for it in the first sentence of the description. Otherwise include a
  40255. link to the suspect range after the list of failing tests.
  40256. 2011-06-24 Nat Duca <nduca@chromium.org>
  40257. Unreviewed, rolling out r89694.
  40258. http://trac.webkit.org/changeset/89694
  40259. https://bugs.webkit.org/show_bug.cgi?id=58408
  40260. Test shell still not ready for animate changes.
  40261. * DumpRenderTree/chromium/WebViewHost.cpp:
  40262. (WebViewHost::paintInvalidatedRegion):
  40263. 2011-06-24 Adam Roben <aroben@apple.com>
  40264. Fix typos introduced in r89696
  40265. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  40266. (Builder.prototype.getNumberOfFailingTests): Pass the result data's constituent parts to the
  40267. callback, since that's what it expects.
  40268. 2011-06-24 Adam Roben <aroben@apple.com>
  40269. Make TestFailures correctly remember whether old-run-webkit-tests exited early
  40270. Fixes <http://webkit.org/b/63342> TestFailures page incorrectly claims test run ran to
  40271. completion after reload
  40272. Reviewed by David Kilzer.
  40273. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  40274. (Builder.prototype.getNumberOfFailingTests): Instead of just storing the number of failures
  40275. in the PeristentCache, store an object that contains both the number of failures and whether
  40276. old-run-webkit-tests exited early.
  40277. 2011-06-24 Adam Roben <aroben@apple.com>
  40278. Add links to regression ranges in Trac to the TestFailures page
  40279. Fixes <http://webkit.org/b/61060> <rdar://problem/9452153> TestFailures page should provide
  40280. links to regression ranges in Trac
  40281. Reviewed by David Kilzer.
  40282. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Trac.js: Added.
  40283. (Trac): This new class represents a particular instance of Trac for a single project.
  40284. (Trac.prototype.logURL): Returns the URL that can be used to see the log of the given
  40285. repository path between the two specified revisions
  40286. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  40287. (ViewController): Added new trac argument.
  40288. (ViewController.prototype._displayBuilder): Moved code to create the DOM for the
  40289. passed/failed builds from here...
  40290. (ViewController.prototype._domForRegressionRange): ...to here. Now also includes a link to
  40291. Trac if there are multiple suspect revisions.
  40292. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  40293. Trac.js and pass a Trac instance for trac.webkit.org to the ViewController.
  40294. 2011-05-17 Nat Duca <nduca@chromium.org>
  40295. Reviewed by James Robinson.
  40296. [chromium] Implement CCLayerTreeHost and CCLayerTreeHostImpl portions of threaded compositor
  40297. https://bugs.webkit.org/show_bug.cgi?id=58408
  40298. * DumpRenderTree/chromium/WebViewHost.cpp:
  40299. (WebViewHost::paintInvalidatedRegion):
  40300. 2011-06-24 Dominic Cooney <dominicc@chromium.org>
  40301. Reviewed by Dimitri Glazkov.
  40302. Convert shadow DOM-related tests to use window.internals
  40303. https://bugs.webkit.org/show_bug.cgi?id=61671
  40304. Remove ensureShadowRoot, shadowRoot, shadowPseudoId and
  40305. removeShadowRoot from layoutTestController; these have been
  40306. replaced by equivalents in window.internals instead.
  40307. * DumpRenderTree/LayoutTestController.cpp:
  40308. (LayoutTestController::staticFunctions):
  40309. * DumpRenderTree/LayoutTestController.h:
  40310. * DumpRenderTree/chromium/LayoutTestController.cpp:
  40311. (LayoutTestController::LayoutTestController):
  40312. * DumpRenderTree/chromium/LayoutTestController.h:
  40313. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  40314. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  40315. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  40316. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  40317. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  40318. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  40319. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  40320. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  40321. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  40322. 2011-06-24 Csaba Osztrogonác <ossy@webkit.org>
  40323. Reviewed by Dirk Schulze.
  40324. Make run-bindings-tests remove its temporary directories.
  40325. https://bugs.webkit.org/show_bug.cgi?id=63320
  40326. * Scripts/run-bindings-tests:
  40327. 2011-06-23 MORITA Hajime <morrita@google.com>
  40328. Reviewed by Kent Tamura.
  40329. [Chromium] Invalid write inside WebKit::FrameLoaderClientImpl::dispatchDidClearWindowObjectInWorld
  40330. https://bugs.webkit.org/show_bug.cgi?id=63216
  40331. Deleted m_webViewHost which looks leaked.
  40332. * DumpRenderTree/chromium/TestShell.h:
  40333. * DumpRenderTree/chromium/TestShell.cpp:
  40334. (TestShell::~TestShell):
  40335. 2011-06-24 Carlos Garcia Campos <cgarcia@igalia.com>
  40336. Unreviewed. Fix WebKit2 GTK build.
  40337. * WebKitTestRunner/GNUmakefile.am:
  40338. 2011-06-23 Ryuan Choi <ryuan.choi@samsung.com>
  40339. Unreviewed, add myself as committer.
  40340. * Scripts/webkitpy/common/config/committers.py:
  40341. 2011-06-23 Nat Duca <nduca@chromium.org>
  40342. Unreviewed, add myself as committer.
  40343. * Scripts/webkitpy/common/config/committers.py:
  40344. 2011-06-23 Dirk Pranke <dpranke@chromium.org>
  40345. Reviewed by Tony Chang.
  40346. nrwt: move http locking code into manager
  40347. https://bugs.webkit.org/show_bug.cgi?id=63103
  40348. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  40349. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  40350. 2011-06-23 Alok Priyadarshi <alokp@chromium.org>
  40351. Reviewed by James Robinson.
  40352. [chromium] Add support for running layout tests with accelerated rendering
  40353. https://bugs.webkit.org/show_bug.cgi?id=63274
  40354. * Scripts/webkitpy/layout_tests/port/chromium.py:
  40355. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  40356. 2011-06-23 Adam Roben <aroben@apple.com>
  40357. Avoid fetching JSON data when possible on TestFailures page to determine if
  40358. old-run-webkit-tests exited early
  40359. As of r89610, results.html includes information about whether old-run-webkit-tests exited
  40360. early, so we don't need to look at JSON data to get this information for builds newer than
  40361. that.
  40362. Fixes <http://webkit.org/b/63281> TestFailures page fetches build JSON for every build,
  40363. which is slow and limits history to the last build master restart
  40364. Reviewed by David Kilzer.
  40365. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  40366. (Builder.prototype._getFailingTests): Moved code dealing with results.html into a new
  40367. function. If we're dealing with a build that has early-exit information in results.html,
  40368. don't bother fetching JSON data and go straight to parsing results.html. Otherwise first use
  40369. the JSON data to determine if old-run-webkit-tests exited early, and then parse results.html
  40370. (as before).
  40371. 2011-06-23 Eric Seidel <eric@webkit.org>
  40372. Reviewed by Adam Barth.
  40373. sheriffbot can no longer restart
  40374. https://bugs.webkit.org/show_bug.cgi?id=63221
  40375. Fixed and unit tested.
  40376. * Scripts/webkitpy/tool/bot/queueengine.py:
  40377. * Scripts/webkitpy/tool/bot/sheriffircbot.py:
  40378. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  40379. 2011-06-23 Martin Robinson <mrobinson@igalia.com>
  40380. Reviewed by Xan Lopez.
  40381. [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
  40382. https://bugs.webkit.org/show_bug.cgi?id=63287
  40383. Send the path to the TestNetscapePlugin to the WKTR via an environment variable
  40384. so that the plugin loads properly.
  40385. * Scripts/old-run-webkit-tests: Pass the appropriate environment variable to WKTR.
  40386. * WebKitTestRunner/gtk/TestControllerGtk.cpp:
  40387. (WTR::getEnvironmentVariableAsUTF8String): Added this helper which abstracts away some
  40388. of the work for getting an environment variable and converting it to UTF-8.
  40389. (WTR::TestController::initializeInjectedBundlePath): Use the helper.
  40390. (WTR::TestController::initializeTestPluginDirectory): Get the path from an environment variable now.
  40391. 2011-06-23 Adam Roben <aroben@apple.com>
  40392. Record whether old-run-webkit-tests aborted early in results.html
  40393. Fixes <http://webkit.org/b/63280> results.html gives no indication of whether
  40394. old-run-webkit-tests stopped running tests early
  40395. Reviewed by David Kilzer.
  40396. * Scripts/old-run-webkit-tests:
  40397. (top level): Switched to heredoc syntax for printing the start of results.html for clarity.
  40398. Added a <style> element with some styles for the new message. If we stopped running early,
  40399. put the reason why at the top of results.html.
  40400. (stopRunningTestsEarlyIfNeeded): Store the message we print in the new
  40401. $stoppedRunningEarlyMessage global.
  40402. 2011-06-23 Adam Roben <aroben@apple.com>
  40403. Cache some of the TestFailures page's data in localStorage
  40404. This makes reloading TestFailures much faster. Right now we only store the number of failing
  40405. tests and the list of failing tests for each build. We may choose to store more later, but
  40406. it's easy to run up against quota limits.
  40407. Fixes <http://webkit.org/b/61520> TestFailures page should take advantage of LocalStorage
  40408. APIs (or similar) to improve loading performance
  40409. Reviewed by David Kilzer.
  40410. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  40411. (Builder.prototype.getNumberOfFailingTests): Changed to use the new PersistentCache object.
  40412. (Builder.prototype.startFetchingBuildHistory): Changed to pass whether or not we're still
  40413. fetching data to the callback.
  40414. (Builder.prototype._getFailingTests): Changed to use the new PersistentCache object. We now
  40415. store the tests in the cache just before calling the callback. (The previous code in this
  40416. function relied on being able to modify the tests object after storing it in the cache and
  40417. having the cached version be updated. This worked while it was a non-serialized cache, but
  40418. PersistentCache uses serialization.)
  40419. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/PersistentCache.js: Added.
  40420. (PersistentCache): This object wraps localStorage. It uses JSON to serialize/deserialize
  40421. values, and stores the date that each value was initially stored along with it. This is
  40422. later used for pruning the cache.
  40423. (PersistentCache.contains): Checks whether the key exists in localStorage.
  40424. (PersistentCache.get): Fetch the string we stored in localStorage and extract the original
  40425. value out of it.
  40426. (PersistentCache.set): Serialize the value, add the date to it, and store it in
  40427. localStorage. If this fails due to quota limits, empty the whole cache and try again.
  40428. (PersistentCache.prune): Delete any cached data that is deemed old enough.
  40429. (PersistentCache._addDateToJSONString): Prepend the current date to the string.
  40430. (PersistentCache._emptyCache): Delete everything from localStorage.
  40431. (PersistentCache._parseDateAndJSONFromString): Split apart the date and the JSON string and
  40432. return them.
  40433. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  40434. (ViewController.prototype._displayBuilder): Updated for change to callback signature. When
  40435. we finish fetching data, prune the PersistentCache. While I was here I also fixed a bug
  40436. where we'd never show the new bug link for tests for which we couldn't determine a passing
  40437. revision.
  40438. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pull in
  40439. PersistentCache.js.
  40440. 2011-06-23 Adam Roben <aroben@apple.com>
  40441. Make finding existing bugs and filing new bugs work on TestFailures even when lots of tests are failing
  40442. One bug this fixes is <http://webkit.org/b/61660> New bug links on TestFailures page often
  40443. contain titles that are so long they are rejected by Bugzilla
  40444. Reviewed by David Kilzer.
  40445. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  40446. (Bugzilla.prototype.quickSearch): Use fetchResource to POST the search query rather than
  40447. using a query string on the URL. If the search query is very long, using a query string can
  40448. cause the request to be rejected due to the URL being too long. POSTing avoids this issue.
  40449. (Bugzilla.maximumBugTitleLength): Added this constant based on Bugzilla's implementation.
  40450. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  40451. (.new-bug-form): Hide the form that we secretly use to file a new bug.
  40452. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  40453. (fetchResource): Added. Code came from getResource. If we're using a GET request, add the
  40454. query parameters to the URL. Otherwise, send them as the body of the request along with the
  40455. appropriate headers.
  40456. (getResource): Now just calls through to fetchResource.
  40457. (urlEncodedQueryParameters): Added. Moved some code here...
  40458. (addQueryParametersToURL): ...from here.
  40459. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  40460. (ViewController.prototype._domForNewAndExistingBugs): Shorten the title to just mention the
  40461. number of failing tests if mentioning all the tests would make the title too long. Improved
  40462. the description for large numbers of failures by listing the tests one-per-line instead of
  40463. just having them be comma-separated, which was hard to read. Use a form to file the new bug
  40464. instead of a link so that we can POST the form data. (Using a URL with a query string can
  40465. result in the URL being too long.) The new bug link now just submits the form.
  40466. 2011-06-23 Adam Roben <aroben@apple.com>
  40467. Show closed bugs on the TestFailures page in addition to open ones
  40468. Fixes <http://webkit.org/b/63194> TestFailures page should show closed bugs, too
  40469. Reviewed by David Kilzer.
  40470. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js:
  40471. (Bugzilla.prototype.quickSearch): Added code to extract the bug's status and store it in the
  40472. returned data.
  40473. (Bugzilla.isOpenStatus): New function, returns true if the passed-in status indicates that
  40474. the associated bug is still open.
  40475. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  40476. (addQueryParametersToURL): Add a missing semicolon.
  40477. (Node.prototype.appendChildren): New function, like appendChild but takes an array-like
  40478. object and appends each of the values stored within.
  40479. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  40480. (ViewController.prototype._domForNewAndExistingBugs): Prepend 'ALL' to the query so closed
  40481. bugs will be included in the results. Split the returned bugs into two sets: those which are
  40482. open, and those which are closed. Put the open bugs at the top level of the list, and the
  40483. closed bugs in a second level.
  40484. 2011-06-23 Adam Roben <aroben@apple.com>
  40485. Don't count new tests as failures on the TestFailures page
  40486. Fixes <http://webkit.org/b/63254> TestFailures page calls new tests "failures", even though
  40487. they aren't
  40488. Reviewed by Anders Carlsson.
  40489. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  40490. (Builder.prototype.getNumberOfFailingTests): Don't add the number of new tests to the number
  40491. of failures.
  40492. 2011-06-23 Dirk Pranke <dpranke@chromium.org>
  40493. Reviewed by Eric Seidel.
  40494. nrwt: make TestInput objects printable
  40495. https://bugs.webkit.org/show_bug.cgi?id=63225
  40496. This makes debugging slighlty easier.
  40497. * Scripts/webkitpy/layout_tests/layout_package/test_input.py:
  40498. 2011-06-22 Daniel Bates <dbates@webkit.org>
  40499. Reviewed by Adam Barth.
  40500. test-webkitpy --all errors out because scm_unittest.py can't find module checkout
  40501. https://bugs.webkit.org/show_bug.cgi?id=62943
  40502. Remove "from .checkout import Checkout" from scm_unittest.py since it's included
  40503. by Scripts/webkitpy/common/checkout/__init__.py.
  40504. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
  40505. 2011-06-22 Dominic Cooney <dominicc@chromium.org>
  40506. Reviewed by Mark Rowe.
  40507. Add window.internals to WebKit2's WebKitTestRunner.
  40508. https://bugs.webkit.org/show_bug.cgi?id=61073
  40509. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pxbproj:
  40510. * WebKitTestRunner/Configurations/Base.xcconfig:
  40511. * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  40512. * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  40513. * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  40514. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  40515. (WTR::InjectedBundlePage::didClearWindowForFrame):
  40516. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  40517. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  40518. 2011-06-22 Eric Seidel <eric@webkit.org>
  40519. Reviewed by Adam Barth.
  40520. Make sheriff-bot rollout messages a little nicer
  40521. https://bugs.webkit.org/show_bug.cgi?id=63107
  40522. itertools.chain.from_iterable is new in 2.6,
  40523. use itertools.chain(*list) for 2.5 compat.
  40524. * Scripts/webkitpy/tool/bot/irc_command.py:
  40525. 2011-06-22 Eric Seidel <eric@webkit.org>
  40526. Reviewed by Adam Barth.
  40527. Make sheriff-bot robust against exceptions from commands
  40528. https://bugs.webkit.org/show_bug.cgi?id=63211
  40529. sheriff-bot was acting strange this afternoon.
  40530. We don't know if this will fix the cause, but
  40531. at least it adds some unit tests and catches
  40532. one possible cause.
  40533. * Scripts/webkitpy/tool/bot/sheriffircbot.py:
  40534. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  40535. 2011-06-22 Mark Rowe <mrowe@apple.com>
  40536. Reviewed by David Levin.
  40537. <http://webkit.org/b/63212> TestWebKitAPI Xcode project has bogus settings since r86287
  40538. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Fix the reference to libgtest.a to
  40539. be relative to the built products directory rather than using a hard-coded path. Remove the
  40540. explicit settings of FRAMEWORK_SEARCH_PATHS, HEADER_SEARCH_PATHS and LIBRARY_SEARCH_PATHS
  40541. as they're all unnecessary. If they were necessary they should be set in the .xcconfig file
  40542. rather than in the .xcodeproj directly.
  40543. 2011-06-22 Dirk Pranke <dpranke@chromium.org>
  40544. Reviewed by Ojan Vafai.
  40545. new-run-webkit-tests: remove obsolete port.shut_down_http_server method
  40546. https://bugs.webkit.org/show_bug.cgi?id=59993
  40547. * Scripts/webkitpy/layout_tests/port/base.py:
  40548. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  40549. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  40550. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  40551. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  40552. * Scripts/webkitpy/layout_tests/port/gtk.py:
  40553. * Scripts/webkitpy/layout_tests/port/mac.py:
  40554. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  40555. * Scripts/webkitpy/layout_tests/port/qt.py:
  40556. * Scripts/webkitpy/layout_tests/port/win.py:
  40557. 2011-06-22 Luke Macpherson <macpherson@chromium.org>
  40558. Reviewed by Andreas Kling.
  40559. Move macpherson from contributor list to committer list.
  40560. https://bugs.webkit.org/show_bug.cgi?id=63179
  40561. * Scripts/webkitpy/common/config/committers.py:
  40562. Move macpherson from contributor list to committer list.
  40563. 2011-06-22 David Levin <levin@chromium.org>
  40564. Reviewed by Adam Barth.
  40565. check-webkit-style should detect returning (Own|Ref)Ptr instead of the Pass*Ptr version.
  40566. https://bugs.webkit.org/show_bug.cgi?id=63204
  40567. * Scripts/webkitpy/style/checkers/cpp.py: Added a check for the return value and combined
  40568. with similar code for the parameter checking.
  40569. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Removed pass_ptr checks from
  40570. those done for single lines since they don't make sense in that case (variable decls look like function decls).
  40571. Removed some redundant comments (one of which was slightly wrong).
  40572. Added checks for the new functionality and minor other test changes.
  40573. 2011-06-22 Nate Chapin <japhet@chromium.org>
  40574. Reviewed by Adam Barth.
  40575. Add libsoup to libWebCoreInternals build.
  40576. https://bugs.webkit.org/show_bug.cgi?id=62066
  40577. * GNUmakefile.am:
  40578. 2011-06-22 Dirk Pranke <dpranke@chromium.org>
  40579. Reviewed by Tony Chang.
  40580. nrwt: handle missing httpd cleanly
  40581. https://bugs.webkit.org/show_bug.cgi?id=62027
  40582. We had reverted the change in r89414, so this adds it back in
  40583. (modifying check_sys_deps() in port/base.py to check for an
  40584. installed web server).
  40585. This change then fixes the change in r89414 to stub out the
  40586. check_sys_deps() in the test port so that the unit tests run correctly.
  40587. * Scripts/webkitpy/layout_tests/port/base.py:
  40588. * Scripts/webkitpy/layout_tests/port/test.py:
  40589. 2011-06-22 David Levin <levin@chromium.org>
  40590. Reviewed by Adam Barth.
  40591. check-webkit-style should check for invalid uses of RefPtr/OwnPtr as parameters.
  40592. https://bugs.webkit.org/show_bug.cgi?id=63188
  40593. * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  40594. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.
  40595. 2011-06-22 Tony Chang <tony@chromium.org>
  40596. Reviewed by Ojan Vafai.
  40597. Add a buildbot for testing ENABLE(CSS3_FLEXBOX)
  40598. https://bugs.webkit.org/show_bug.cgi?id=62891
  40599. * BuildSlaveSupport/build.webkit.org-config/config.json:
  40600. 2011-06-22 Dirk Pranke <dpranke@chromium.org>
  40601. Reviewed by Ojan Vafai.
  40602. nrwt: don't look for http lock when running the test port
  40603. https://bugs.webkit.org/show_bug.cgi?id=63158
  40604. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  40605. * Scripts/webkitpy/layout_tests/port/test.py:
  40606. 2011-06-22 Balazs Kelemen <kbalazs@webkit.org>
  40607. Reviewed by Andreas Kling.
  40608. [Qt][WK2] Set up plugin tests
  40609. https://bugs.webkit.org/show_bug.cgi?id=63066
  40610. * WebKitTestRunner/qt/TestControllerQt.cpp:
  40611. (WTR::TestController::initializeTestPluginDirectory):
  40612. Use the QTWEBKIT_PLUGIN_PATH environment variable as the path
  40613. of the test plugin like DRT does.
  40614. 2011-06-22 Eric Seidel <eric@webkit.org>
  40615. Reviewed by Ojan Vafai.
  40616. Make sheriff-bot rollout messages a little nicer
  40617. https://bugs.webkit.org/show_bug.cgi?id=63107
  40618. It annoyed me this afternoon that I had to convert sheriff-bots "r12345" revisions
  40619. into urls myself. So I have now fixed its "preparing" message to include a url.
  40620. I also figured that I should make the messages mention all of the responsible parties
  40621. so that rollouts are never surprises. If you're in the channel and were involved
  40622. in a patch, you will see if someone is using sheriff-bot to rollout a patch.
  40623. As part of doing this I also changed (and tested) _parse_args to fail-fast
  40624. when given invalid args.
  40625. * Scripts/webkitpy/tool/bot/irc_command.py:
  40626. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  40627. * Scripts/webkitpy/tool/bot/sheriff.py:
  40628. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  40629. 2011-06-22 Dirk Pranke <dpranke@chromium.org>
  40630. Reviewed by Tony Chang.
  40631. run-webkit-websocketserver fails to stop websocket server
  40632. https://bugs.webkit.org/show_bug.cgi?id=63123
  40633. There's a ten-character change in new-run-webkit-websocketserver
  40634. that fixes the actual bug, and then we update the code in
  40635. new-run-webkit-httpd to do the actual stop call, and add more tests
  40636. (refactoring the existing test code so that it is shared).
  40637. * Scripts/new-run-webkit-httpd:
  40638. * Scripts/new-run-webkit-websocketserver:
  40639. * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py:
  40640. 2011-06-22 Adam Roben <aroben@apple.com>
  40641. Add links to existing bugs related to failing tests on TestFailures page
  40642. I changed the layout of the page a little to make it easier to read with all the new
  40643. information. Passing/failing revisions have been moved down below the list of tests to be
  40644. closer to the existing bugs and the new bug link. And each set of tests and its relevant
  40645. information is in a light gray box.
  40646. Fixes <http://webkit.org/b/61665> TestFailures page should link to existing bugs when
  40647. possible
  40648. Reviewed by Darin Adler.
  40649. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Bugzilla.js: Added.
  40650. (Bugzilla): This new class represents a single Bugzilla instance.
  40651. (Bugzilla.prototype.quickSearch): Searches Bugzilla using its Quick Search functionality,
  40652. passing the resulting bug titles and URLs to the callback when complete. If called multiple
  40653. times with the same query before the query returns, caches the callbacks so that only one
  40654. query is sent over the wire. When the query completes, all pending callbacks are called.
  40655. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  40656. (#failure-history): Reduce the margin/padding on the top-level list a bit.
  40657. (#failure-history > li): Put each set of tests in a gray box, and indent most information
  40658. inside the box.
  40659. (.test-list): Unindent the list of failing tests so it is visually at the top level.
  40660. (.new-and-existing-bugs): Reduce the space at the bottom of this area so that the bottom of
  40661. each box isn't a big empty space.
  40662. (.existing-bugs-list): Use a smaller text size for existing bugs, since their titles can be
  40663. quite long.
  40664. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
  40665. (addQueryParametersToURL): New function extracted from
  40666. ViewController.prototype._domForNewAndExistingBugs.
  40667. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  40668. (ViewController): Take and store an optional Bugzilla instance.
  40669. (ViewController.prototype._displayBuilder): Give the top-level list an id for styling
  40670. purposes and move the list of failing tests above all other information. Only show bug
  40671. information once we've determined the most-recent passing revision for a set of tests. It's
  40672. not that useful to file a new bug before this information has been determined, and searching
  40673. for existing bugs before we've figured out which tests started failing at the same time
  40674. would end up giving you information about a bunch of unrelated tests.
  40675. (ViewController.prototype._domForNewAndExistingBugs): Renamed from _domForNewBugLink. Now
  40676. returns a DocumentFragment instead of an HTMLParagraphElement. If we don't have a Bugzilla
  40677. instance, just returns an empty DocumentFragment. Starts a search for bugs related to the
  40678. failing tests, and adds links to the bugs when the search completes.
  40679. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Pass a
  40680. Bugzilla instance for bugs.webkit.org to the ViewController.
  40681. 2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
  40682. Reviewed by Martin Robinson.
  40683. [GTK] Apply current view settings to newly created views in GtkLauncher
  40684. https://bugs.webkit.org/show_bug.cgi?id=63142
  40685. * GtkLauncher/main.c:
  40686. (createWebViewCb):
  40687. 2011-06-22 Carlos Garcia Campos <cgarcia@igalia.com>
  40688. Reviewed by Martin Robinson.
  40689. [GTK] Use GOption to parse main arguments in GtkLauncher
  40690. https://bugs.webkit.org/show_bug.cgi?id=63060
  40691. Instead of getting the settings from the view, create a new
  40692. settings object not associated with any view so that we can parse
  40693. the command line arguments before creating the view. It will also
  40694. allows to use the same settings for more than one view if we
  40695. eventually support passing more than one uri from the command
  40696. line.
  40697. * GtkLauncher/main.c:
  40698. (parseOptionEntryCallback): Make this function static. Also use
  40699. g_ascii_strtoll/g_ascii_strtod to parse int/float values instead
  40700. of atoi/atof to provide better error messages. And always fill the
  40701. error struct when the function fails.
  40702. (getOptionEntriesFromWebKitWebSettings): Use an array of
  40703. GOptionEntry structs instead of a GArray, since that is what
  40704. g_option_group_add_entries() expects and the array size doesn't
  40705. change.
  40706. (addWebSettingsGroupToContext): Helper function to add the
  40707. websettings group to the option context.
  40708. (main): Create the option context to parse command line arguments.
  40709. 2011-06-22 Martin Robinson <mrobinson@igalia.com>
  40710. Reviewed by Adam Roben.
  40711. [GTK] Implement pixel dump support for WebKitTestRunner
  40712. https://bugs.webkit.org/show_bug.cgi?id=58242
  40713. * DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Added.
  40714. * GNUmakefile.am: Separate out the ImageDiff bits of the GNUmakefile.
  40715. * Scripts/old-run-webkit-tests: Update to add support for the GTK+ port.
  40716. * WebKitTestRunner/GNUmakefile.am: Added Cairo specific files to the build.
  40717. * WebKitTestRunner/TestInvocation.cpp: Moved this code to the platform-independent
  40718. file so that we can share it across platforms.
  40719. (WTR::TestInvocation::compareActualHashToExpectedAndDumpResults):
  40720. * WebKitTestRunner/TestInvocation.h: Updated method list.
  40721. * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added Cairo implementation.
  40722. * WebKitTestRunner/cg/TestInvocationCG.cpp:
  40723. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected): Updated to use new helper.
  40724. 2011-06-22 Sheriff Bot <webkit.review.bot@gmail.com>
  40725. Unreviewed, rolling out r89414.
  40726. http://trac.webkit.org/changeset/89414
  40727. https://bugs.webkit.org/show_bug.cgi?id=63130
  40728. It broke webkitpy tests (Requested by Ossy on #webkit).
  40729. * Scripts/webkitpy/layout_tests/port/base.py:
  40730. 2011-06-22 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  40731. Reviewed by Dirk Pranke.
  40732. [NRWT] Print error message when there is no httpd present on the system
  40733. https://bugs.webkit.org/show_bug.cgi?id=62027
  40734. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  40735. 2011-06-21 Dirk Pranke <dpranke@chromium.org>
  40736. Unreviewed, build fix.
  40737. Fix crashes in new-run-webkit-tests resulting from the
  40738. change to the http_server logic in r89400. Python 2.5
  40739. on Mac 10.5 has some weird error paths.
  40740. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  40741. * Scripts/webkitpy/common/system/executive.py:
  40742. 2011-06-21 MORITA Hajime <morrita@google.com>
  40743. Unreviewed, rolling out r89401 and r89403.
  40744. http://trac.webkit.org/changeset/89401
  40745. http://trac.webkit.org/changeset/89403
  40746. https://bugs.webkit.org/show_bug.cgi?id=62970
  40747. Breaks mac build and mistakenly enables the spellcheck API
  40748. * Scripts/build-webkit:
  40749. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  40750. 2011-06-21 Kent Tamura <tkent@chromium.org>
  40751. [Mac] Sort Xcode project files.
  40752. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  40753. 2011-06-20 MORITA Hajime <morrita@google.com>
  40754. Reviewed by Kent Tamura.
  40755. Spellcheck API should be build-able.
  40756. https://bugs.webkit.org/show_bug.cgi?id=62970
  40757. * Scripts/build-webkit:
  40758. 2011-06-21 Dirk Pranke <dpranke@chromium.org>
  40759. Reviewed by Tony Chang.
  40760. nrwt: attempt #3 at fixing server startup/shutdown
  40761. https://bugs.webkit.org/show_bug.cgi?id=62829
  40762. Attempt yet again to make starting and stopping servers
  40763. reliable. It turns out that apache has races between when the
  40764. ctl process exists and when it writes/removes the pid file.
  40765. This change accounts for the races.
  40766. * Scripts/new-run-webkit-httpd:
  40767. * Scripts/webkitpy/common/system/executive.py:
  40768. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  40769. * Scripts/webkitpy/layout_tests/port/base.py:
  40770. * Scripts/webkitpy/layout_tests/port/http_server.py:
  40771. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  40772. * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
  40773. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  40774. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  40775. 2011-06-21 Dmitry Lomov <dslomov@google.com>
  40776. Reviewed by Adam Roben.
  40777. https://bugs.webkit.org/show_bug.cgi?id=63080
  40778. Unit-tests step on test-only bot is broken.
  40779. Removing the step until run-api-tests is fixed.
  40780. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  40781. 2011-06-20 Dmitry Lomov <dslomov@google.com>
  40782. Reviewed by David Levin.
  40783. https://bugs.webkit.org/show_bug.cgi?id=63017
  40784. "Unit tests" step on bots should provide more information in case of failure.
  40785. * BuildSlaveSupport/build.webkit.org-config/master.cfg: added --verbose flag to UnitTests step.
  40786. 2011-06-20 Dirk Pranke <dpranke@chromium.org>
  40787. Reviewed by Ojan Vafai.
  40788. new-run-webkit-tests: order shards by name, not number of tests
  40789. https://bugs.webkit.org/show_bug.cgi?id=62753
  40790. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  40791. 2011-06-20 Dirk Pranke <dpranke@chromium.org>
  40792. Reviewed by Ojan Vafai.
  40793. we should only log the test names to the tests_run.txt files during layout_tests
  40794. https://bugs.webkit.org/show_bug.cgi?id=62751
  40795. * Scripts/old-run-webkit-tests:
  40796. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  40797. 2011-06-20 Eric Seidel <eric@webkit.org>
  40798. Reviewed by Adam Barth.
  40799. commit-queue/ews-bots should run run-bindings-tests for every patch
  40800. https://bugs.webkit.org/show_bug.cgi?id=63010
  40801. * Scripts/webkitpy/common/config/ports.py:
  40802. * Scripts/webkitpy/tool/commands/download_unittest.py:
  40803. * Scripts/webkitpy/tool/steps/runtests.py:
  40804. * Scripts/webkitpy/tool/steps/runtests_unittest.py:
  40805. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  40806. 2011-06-20 Chang Shu <cshu@webkit.org>
  40807. Reviewed by Adam Barth.
  40808. fast/js/sputnik/Conformance/10_Execution_Contexts/10.2_Entering_An_Execution_Context/10.2.2_Eval_Code tests fail when showModalDialog isn't supported
  40809. https://bugs.webkit.org/show_bug.cgi?id=53676
  40810. * WebKitTestRunner/TestController.cpp:
  40811. (WTR::TestController::initialize):
  40812. 2011-06-20 Eric Seidel <eric@webkit.org>
  40813. Reviewed by Adam Barth.
  40814. buildbots should run run-bindings-tests
  40815. https://bugs.webkit.org/show_bug.cgi?id=63001
  40816. run-bindings-tests takes 2.4 seconds on my machine, so
  40817. I expect this will not be noticeable on the bots.
  40818. I also removed tiger-specific checks since Tiger is no
  40819. longer a supported platform for webkit.
  40820. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  40821. 2011-06-20 Carlos Garcia Campos <cgarcia@igalia.com>
  40822. Unreviewed. Fix WebKit2 GTK build after r89249.
  40823. * GtkLauncher/main.c:
  40824. (main):
  40825. 2011-06-20 Pavel Feldman <pfeldman@chromium.org>
  40826. Reviewed by Yury Semikhatsky.
  40827. Web Inspector: remove LayoutTestController::setTimelineProfilingEnabled.
  40828. https://bugs.webkit.org/show_bug.cgi?id=62994
  40829. * DumpRenderTree/LayoutTestController.cpp:
  40830. (closeWebInspectorCallback):
  40831. (LayoutTestController::staticFunctions):
  40832. * DumpRenderTree/LayoutTestController.h:
  40833. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  40834. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  40835. * DumpRenderTree/chromium/LayoutTestController.cpp:
  40836. (LayoutTestController::LayoutTestController):
  40837. * DumpRenderTree/chromium/LayoutTestController.h:
  40838. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  40839. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  40840. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  40841. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  40842. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  40843. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  40844. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  40845. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  40846. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  40847. 2011-06-20 Lukasz Slachciak <l.slachciak@samsung.com>
  40848. Reviewed by Martin Robinson.
  40849. [GTK] General mechanism for adjusting WebKitWebSettings in GtkLauncher.
  40850. https://bugs.webkit.org/show_bug.cgi?id=55308
  40851. * GtkLauncher/main.c: Added general mechanism for adjusting WebKitWebSettings.
  40852. (parseOptionEntryCallback): Callback for parsing option entry.
  40853. (getOptionEntriesFromWebKitWebSettings): Basing on the WebKitWebSettings properties prepare
  40854. list of option entries.
  40855. (transformStringToBoolean): Transform function for boolean convertion used by parseOptionEntryCallback.
  40856. (transformStringToInt): Transform function for int convertion used by parseOptionEntryCallback.
  40857. (transformStringToFloat): Transform function for float convertion used by parseOptionEntryCallback.
  40858. (parseAdditionalOptions): Help function parsing additional commandline options.
  40859. (main): Added call to parseAdditionalOptions.
  40860. 2011-06-20 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
  40861. Reviewed by Andreas Kling.
  40862. [Qt] [WK2] Compile error in ActivateFontsQt.cpp on Mac
  40863. https://bugs.webkit.org/show_bug.cgi?id=62869
  40864. Add QFont include to fix "incomlete type QFont" error.
  40865. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  40866. 2011-06-19 Adam Bergkvist <adam.bergkvist@ericsson.com>
  40867. Reviewed by Martin Robinson.
  40868. [GTK] Enable Media Stream feature and make it default on
  40869. https://bugs.webkit.org/show_bug.cgi?id=60394
  40870. * Scripts/build-webkit:
  40871. 2011-06-19 Sheriff Bot <webkit.review.bot@gmail.com>
  40872. Unreviewed, rolling out r89198.
  40873. http://trac.webkit.org/changeset/89198
  40874. https://bugs.webkit.org/show_bug.cgi?id=62953
  40875. Chromium breakage on "Linux Tests" (Requested by senorblanco
  40876. on #webkit).
  40877. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  40878. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  40879. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  40880. 2011-06-18 Daniel Bates <dbates@webkit.org>
  40881. Reviewed by Eric Seidel.
  40882. Git.push_local_commits_to_server() should use passed username and
  40883. password when we don't have cached credentials
  40884. https://bugs.webkit.org/show_bug.cgi?id=62941
  40885. Fixes a issue where Git.push_local_commits_to_server() would always look
  40886. for cached credentials regardless of whether a username and password
  40887. were passed as arguments. Instead, if given both a username and password
  40888. then we shouldn't look for cached credentials (since we were explicitly given
  40889. credentials).
  40890. * Scripts/webkitpy/common/checkout/scm/git.py:
  40891. * Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Added unit tests.
  40892. 2011-06-18 Daniel Bates <dbates@rim.com>
  40893. Rubber-stamped by Eric Seidel.
  40894. Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
  40895. https://bugs.webkit.org/show_bug.cgi?id=62767
  40896. Part 3 of 3
  40897. Remove the command-line option --skip-build now that the master BuildBot has been restarted
  40898. following <http://trac.webkit.org/changeset/89138>.
  40899. Instead, specify --no-build to get analogous functionality.
  40900. * Scripts/run-javascriptcore-tests:
  40901. 2011-06-18 Dirk Pranke <dpranke@chromium.org>
  40902. Reviewed by Tony Chang.
  40903. new-run-webkit-tests: fix test sorting
  40904. https://bugs.webkit.org/show_bug.cgi?id=58691
  40905. This changes the sorting to use a "natural" sort order such that
  40906. foo2.html sorts before foo13.html, and sorts the tests so
  40907. that all the tests in a directory are run before any test in a
  40908. subdirectory.
  40909. This change also adds a split() method to the filesystem since
  40910. that is needed to cluster files into a directory otherwise.
  40911. * Scripts/webkitpy/common/system/filesystem.py:
  40912. * Scripts/webkitpy/common/system/filesystem_mock.py:
  40913. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  40914. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py:
  40915. 2011-06-18 Evan Martin <evan@chromium.org>
  40916. Reviewed by Darin Adler.
  40917. Compiler warning in double->int conversion in TestNetscapePlugIn
  40918. https://bugs.webkit.org/show_bug.cgi?id=51554
  40919. This code is providing a JS API for removing a property by numeric ID.
  40920. We get it from JS as a double, and must convert it to an int before using it.
  40921. Test: LayoutTests/plugins/npruntime/remove-property.html
  40922. * DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeRemoveProperty.cpp:
  40923. (NPRuntimeRemoveProperty::TestObject::invoke):
  40924. 2011-06-18 Patrick Gansterer <paroga@webkit.org>
  40925. Reviewed by Eric Seidel.
  40926. Don't exit webkit-patch when running on Win32 python
  40927. https://bugs.webkit.org/show_bug.cgi?id=55811
  40928. Most of the basic actions work in the meantime,
  40929. so let people play with in on Win32 now.
  40930. * Scripts/webkit-patch:
  40931. 2011-06-18 Alice Boxhall <aboxhall@chromium.org>
  40932. Reviewed by Ojan Vafai.
  40933. Convert json_results_generator.py to output version 4 JSON.
  40934. https://bugs.webkit.org/show_bug.cgi?id=60869
  40935. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  40936. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  40937. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  40938. 2011-06-18 Berend-Jan Wever <skylined@chromium.org>
  40939. Reviewed by Eric Seidel.
  40940. Some names with spaces are incorrectly reported as not containing spaces
  40941. while running prepare-ChangeLog
  40942. https://bugs.webkit.org/show_bug.cgi?id=55572
  40943. * Scripts/VCSUtils.pm: Updated CHANGE_LOG_NAME check for spaces to allow
  40944. non-alphanumeric characters in names.
  40945. 2011-06-18 Michael Saboff <msaboff@apple.com>
  40946. Reviewed by Eric Seidel.
  40947. Enhancement: New Script to Format malloc_history output as tree
  40948. https://bugs.webkit.org/show_bug.cgi?id=56378
  40949. New script to process malloc_history output to tree format.
  40950. * Scripts/malloc-tree: Added.
  40951. 2011-06-17 Dmitry Lomov <dslomov@google.com>
  40952. Reviewed by Daniel Bates.
  40953. https://bugs.webkit.org/show_bug.cgi?id=62918
  40954. Pass configuration to UnitTests step in master.cfg
  40955. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  40956. 2011-06-17 Leandro Pereira <leandro@profusion.mobi>
  40957. Reviewed by Eric Seidel.
  40958. [EFL] Add Evas-based ImageDiff implementation.
  40959. https://bugs.webkit.org/show_bug.cgi?id=61942
  40960. Build system changes will be performed as soon as the complete
  40961. DumpRenderTree implementation is upstreamed.
  40962. * DumpRenderTree/efl/ImageDiff.cpp: Added.
  40963. (pixelFromImageData):
  40964. (differenceImageFromDifferenceBuffer):
  40965. (computeDistanceBetweenPixelComponents):
  40966. (calculatePixelDifference):
  40967. (calculateDifference):
  40968. (getTemporaryFile):
  40969. (printImage):
  40970. (printImageDifferences):
  40971. (resizeEcoreEvasIfNeeded):
  40972. (readImageFromStdin):
  40973. (parseCommandLineOptions):
  40974. (shutdownEfl):
  40975. (abortWithErrorMessage):
  40976. (initEfl):
  40977. (main):
  40978. 2011-06-17 Tony Chang <tony@chromium.org>
  40979. Reviewed by Dirk Pranke.
  40980. [chromium] force rebaseline-chromium-webkit-tests to use the chromium port
  40981. https://bugs.webkit.org/show_bug.cgi?id=62907
  40982. This fixes a bug where the ImageDiff on the user's machine doesn't
  40983. match the logic used on the Chromium buildbots. This has the downside
  40984. of requiring that the Chromium ImageDiff is built, but it turns out
  40985. that even with --tolerance 0, the CG ImageDiff will allow small pixel
  40986. differences through.
  40987. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  40988. 2011-06-17 Brent Fulgham <bfulgham@webkit.org>
  40989. [WinCairo] Unreviewed build correction.
  40990. * DumpRenderTree/win/DumpRenderTreeCairo.vsprops:
  40991. Update WinCairo property sheet to link against the Cairo DLL,
  40992. now that we are using a more recent Cairo build.
  40993. 2011-06-17 Brent Fulgham <bfulgham@webkit.org>
  40994. Reviewed by Brian Weinstein.
  40995. Create a simple example of using the COM-based C++ listeners.
  40996. A new onclick event is attached (via C++) to the WebKit logo
  40997. in the default test pattern displayed on startup. Clicking on
  40998. the logo causes a message box to be displayed.
  40999. https://bugs.webkit.org/show_bug.cgi?id=61885
  41000. * WinLauncher/DOMDefaultImpl.h: Added. Stub implementation of
  41001. the WebScriptObject and DOMEventListener.
  41002. * WinLauncher/WinLauncher.cpp:
  41003. (SimpleEventListener::SimpleEventListener): Example implementation
  41004. of a simple DOM event listener.
  41005. (SimpleEventListener::handleEvent):
  41006. (WinLauncherWebHost::didFinishLoadForFrame): Added implementation
  41007. to bind a C++ method to the 'onclick' event for the WebKit logo.
  41008. (_tWinMain):
  41009. * WinLauncher/WinLauncher.h:
  41010. * WinLauncher/WinLauncher.vcproj: Add new DOMDefaultImpl.h file.
  41011. 2011-06-17 Chang Shu <cshu@webkit.org>
  41012. Reviewed by Andreas Kling.
  41013. [Qt] [WK2] Support undo/redo in MiniBrowser
  41014. https://bugs.webkit.org/show_bug.cgi?id=62809
  41015. * MiniBrowser/qt/BrowserWindow.cpp:
  41016. (BrowserWindow::BrowserWindow):
  41017. 2011-06-17 Daniel Bates <dbates@rim.com>
  41018. Rubber-stamped by Eric Seidel.
  41019. Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
  41020. https://bugs.webkit.org/show_bug.cgi?id=62767
  41021. Part 2 of 3
  41022. Update the BuildBot master.cfg to use the new --no-build run-javascriptcore-tests
  41023. command line option instead of --skip-build.
  41024. We'll remove --skip-build from run-javascriptcore-test in a follow up patch once the
  41025. master buildbot picks up the change.
  41026. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  41027. 2011-06-17 Daniel Bates <dbates@rim.com>
  41028. Rubber-stamped by Eric Seidel.
  41029. Remove run-javascriptcore-tests --skip-build option; Instead add --build/no-build options
  41030. https://bugs.webkit.org/show_bug.cgi?id=62767
  41031. Part 1 of 3
  41032. Towards renaming the option --skip-build to --no-build. Add --build/--no-build options to
  41033. run-javascriptcore-tests. Also, add a remark about these options to the usage message
  41034. printed by run-javascriptcore-tests.
  41035. We'll remove --skip-build in a follow up patch once the master buildbot picks up the changes.
  41036. * Scripts/run-javascriptcore-tests: Additionally, remove unnecessary initialization
  41037. of $showHelp.
  41038. 2011-06-17 Joone Hur <joone.hur@collabora.co.uk>
  41039. Reviewed by Martin Robinson.
  41040. [GTK] Replace GdkRectangle by cairo_rectangle_int_t
  41041. https://bugs.webkit.org/show_bug.cgi?id=60687
  41042. Replace GdkRectangle by cairo_rectangle_int_t.
  41043. * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp: Replace GdkRectangle by cairo_rectangle_int_t.
  41044. (createBitmapContextFromWebView):
  41045. * DumpRenderTree/gtk/TextInputController.cpp: Ditto.
  41046. (firstRectForCharacterRangeCallback):
  41047. 2011-06-16 Dmitry Lomov <dslomov@google.com>
  41048. Reviewed by David Levin.
  41049. https://bugs.webkit.org/show_bug.cgi?id=62603
  41050. Run run-api-tests on bots in debug mode.
  41051. Release mode is disabled due to https://bugs.webkit.org/show_bug.cgi?id=61812.
  41052. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  41053. 2011-06-16 Leandro Pereira <leandro@profusion.mobi>
  41054. Reviewed by Eric Seidel.
  41055. [EFL] DumpRenderTree: Add GCController, PixelDumpSupport and
  41056. WorkQueueItem.
  41057. They will be plugged into the build system once the EFL's DRT is
  41058. fully upstreamed.
  41059. https://bugs.webkit.org/show_bug.cgi?id=61958
  41060. * DumpRenderTree/efl: Added.
  41061. * DumpRenderTree/efl/GCControllerEfl.cpp: Added.
  41062. (GCController::collect):
  41063. (GCController::collectOnAlternateThread):
  41064. (GCController::getJSObjectCount):
  41065. * DumpRenderTree/efl/PixelDumpSupportEfl.cpp: Added.
  41066. (createBitmapContextFromWebView):
  41067. * DumpRenderTree/efl/WorkQueueItemEfl.cpp: Added.
  41068. (LoadItem::invoke):
  41069. (LoadHTMLStringItem::invoke):
  41070. (ReloadItem::invoke):
  41071. (ScriptItem::invoke):
  41072. (BackForwardItem::invoke):
  41073. * DumpRenderTree/efl/WorkQueueItemEfl.h: Added.
  41074. (WorkQueueItem::~WorkQueueItem):
  41075. (LoadItem::LoadItem):
  41076. (LoadHTMLStringItem::LoadHTMLStringItem):
  41077. (ScriptItem::ScriptItem):
  41078. (LoadingScriptItem::LoadingScriptItem):
  41079. (LoadingScriptItem::invoke):
  41080. (NonLoadingScriptItem::NonLoadingScriptItem):
  41081. (NonLoadingScriptItem::invoke):
  41082. (BackForwardItem::BackForwardItem):
  41083. (BackItem::BackItem):
  41084. (ForwardItem::ForwardItem):
  41085. 2011-06-16 Kevin Ollivier <kevino@theolliviers.com>
  41086. [wx] Unreviewed build fix, make sure the waf build checks the webKitBranchBuild
  41087. preference like the perl scripts do.
  41088. * waf/build/build_utils.py:
  41089. * waf/build/settings.py:
  41090. 2011-06-16 Tommy Widenflycht <tommyw@google.com>
  41091. Reviewed by Tony Gentilcore.
  41092. MediaStream API: Runtime enabled features
  41093. https://bugs.webkit.org/show_bug.cgi?id=62798
  41094. Add the WebRuntimeFeatures API for Media Streams and enable the feature by default in DumpRenderTree.
  41095. * DumpRenderTree/chromium/TestShell.cpp:
  41096. (TestShell::TestShell):
  41097. 2011-06-16 Torsten Kurbad <gentoo@tk-webart.de>
  41098. Reviewed by Eric Seidel.
  41099. Add support for sys.platform == 'linux3' by relaxing
  41100. conditional statements and/or extending lookup dicts.
  41101. This way, Linux kernels >=3.0-rc1 get supported in the
  41102. build process.
  41103. https://bugs.webkit.org/show_bug.cgi?id=62730
  41104. * Scripts/webkitpy/common/system/executive.py:
  41105. * Scripts/webkitpy/common/system/file_lock.py:
  41106. * Scripts/webkitpy/common/system/path_unittest.py:
  41107. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  41108. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  41109. * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
  41110. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  41111. * Scripts/webkitpy/layout_tests/port/factory.py:
  41112. * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
  41113. * Scripts/webkitpy/layout_tests/port/qt.py:
  41114. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  41115. 2011-06-16 Sheriff Bot <webkit.review.bot@gmail.com>
  41116. Unreviewed, rolling out r88796.
  41117. http://trac.webkit.org/changeset/88796
  41118. https://bugs.webkit.org/show_bug.cgi?id=62790
  41119. It made fast/dom/nodesFromRect-basic.html time out on Qt,
  41120. 64-bit, debug mode (Requested by Ossy on #webkit).
  41121. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  41122. (LayoutTestController::nodesFromRect):
  41123. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  41124. * DumpRenderTree/qt/PlainTextControllerQt.cpp:
  41125. (PlainTextController::plainText):
  41126. * DumpRenderTree/qt/PlainTextControllerQt.h:
  41127. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41128. Unreviewed, build fix.
  41129. Revert the patches in r88995 and r88999; the http servers don't
  41130. seem to be shutting down reliably.
  41131. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  41132. * Scripts/webkitpy/layout_tests/port/base.py:
  41133. * Scripts/webkitpy/layout_tests/port/http_server.py:
  41134. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  41135. * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  41136. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  41137. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  41138. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41139. Unreviewed, build fix.
  41140. Add some debugging messages to triage problems introduced in
  41141. r88995.
  41142. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  41143. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41144. Reviewed by Tony Chang.
  41145. nrwt: should clean up stale server processes from a previous run
  41146. https://bugs.webkit.org/show_bug.cgi?id=62615
  41147. This change fixes cases where NRWT might start a server and then
  41148. exit, leaving the server still running. Now NRWT should detect
  41149. this case and clean up on the next run, without shutting down
  41150. any processes it didn't start.
  41151. This change also fixes a bug in executive.kill_process on UNIX
  41152. where zombies weren't being handled properly.
  41153. * Scripts/webkitpy/common/system/executive.py:
  41154. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  41155. * Scripts/webkitpy/layout_tests/port/base.py:
  41156. * Scripts/webkitpy/layout_tests/port/http_server.py:
  41157. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  41158. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  41159. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  41160. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41161. Reviewed by Tony Chang.
  41162. nrwt: fix http, websocket server startup, shutdown
  41163. https://bugs.webkit.org/show_bug.cgi?id=62180
  41164. This change refactors all of the server-related code to
  41165. have consistent semantics. It pushes the start()/stop()
  41166. logic into the base class and adds four much smaller routines
  41167. for specialization:
  41168. _prepare_config() - for optionally writing config files etc.
  41169. to disk prior to starting the server
  41170. _remove_stale_log_files()
  41171. _spawn_process() - the actual launch of the subprocess
  41172. _cleanup_after_stop() - and custom cleanup code
  41173. Prior to this change the three server implementations were
  41174. fairly inconsistent, leading to lots of weirdness on the bots
  41175. with servers being left around, etc.
  41176. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  41177. * Scripts/webkitpy/layout_tests/port/http_server.py:
  41178. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  41179. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  41180. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41181. Reviewed by Tony Chang.
  41182. webkitpy: clean up code prior to functional changes for server startup/shutdown
  41183. https://bugs.webkit.org/show_bug.cgi?id=62256
  41184. This patch does a bunch of minor cleanup of the code, but there
  41185. should be no functional changes except that all of the modules
  41186. will now use the same exception type. Other changes include
  41187. removing unused code paths and functions, pushing 'name' and
  41188. 'pid_file' into the base class of the server objects, and using
  41189. the Filesystem object instead of the codecs, tempfile, and
  41190. shutils modules.
  41191. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  41192. * Scripts/webkitpy/layout_tests/port/http_server.py:
  41193. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  41194. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  41195. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41196. Reviewed by Tony Chang.
  41197. webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
  41198. https://bugs.webkit.org/show_bug.cgi?id=62251
  41199. shut_down_http_server() was a total hack that was only used by
  41200. new-run-webkit-httpd, so I've moved the code there and switched
  41201. to using executive.kill_process() for the common case. The
  41202. method itself will be removed in the patch on bug 59993.
  41203. * Scripts/new-run-webkit-httpd:
  41204. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  41205. * Scripts/webkitpy/layout_tests/port/http_server.py:
  41206. * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
  41207. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  41208. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41209. Unreviewed, build fix.
  41210. Fix test-webkitpy failure introduced in r88986.
  41211. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  41212. 2011-06-15 Dirk Pranke <dpranke@chromium.org>
  41213. Reviewed by Eric Seidel.
  41214. NRWT: doesn't support webarchives, has stale skipping logic.
  41215. https://bugs.webkit.org/show_bug.cgi?id=58293
  41216. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  41217. * Scripts/webkitpy/layout_tests/port/base.py:
  41218. * Scripts/webkitpy/layout_tests/port/webkit.py:
  41219. 2011-06-15 Jeremy Orlow <jorlow@webkit.org>
  41220. Change my email to @webkit.org
  41221. * Scripts/webkitpy/common/config/committers.py:
  41222. 2011-06-15 Nikolas Zimmermann <nzimmermann@rim.com>
  41223. Reviewed by David Hyatt.
  41224. CSS 2.1: Support replaced elements with relative intrinsic sizes
  41225. https://bugs.webkit.org/show_bug.cgi?id=15849
  41226. CSS 2.1 failure: html4/replaced-intrinsic-ratio-001
  41227. https://bugs.webkit.org/show_bug.cgi?id=53099
  41228. Recognize *.htm tests in the old & new DRT implementation, needed for the vanilla css2.1 html4 tests.
  41229. * Scripts/old-run-webkit-tests:
  41230. * Scripts/webkitpy/layout_tests/port/test_files.py:
  41231. 2011-06-15 Carlos Garcia Campos <cgarcia@igalia.com>
  41232. Reviewed by Martin Robinson.
  41233. [GTK] Add a statusbar to MiniBrowser
  41234. https://bugs.webkit.org/show_bug.cgi?id=62634
  41235. It shows the url of the current hovered link.
  41236. * MiniBrowser/gtk/BrowserWindow.c:
  41237. (browserWindowConstructed): Create the GtkSatusbar.
  41238. (mouseDidMoveOverElement): Update statusbar text.
  41239. (browserWindowUIClientInit): Add implementation for
  41240. mouseDidMoveOverElement().
  41241. * MiniBrowser/gtk/GNUmakefile.am: Add new files to compilation.
  41242. * MiniBrowser/gtk/WebBundle/WebBundleMain.c: Added.
  41243. (mouseDidMoveOverElement): Pass the url of the current hovered
  41244. link to the UI process.
  41245. (didCreatePage): Set the UI client adding an implementation for
  41246. mouseDidMoveOverElement().
  41247. (WKBundleInitialize):
  41248. * MiniBrowser/gtk/main.c:
  41249. (createWKContextWithInjectedBundle): Create a global context with
  41250. the injected bundle.
  41251. (loadURI): Use the global context.
  41252. (main):
  41253. 2011-06-14 Lucas Forschler <lforschler@apple.com>
  41254. Reviewed by Stephanie Lewis.
  41255. https://bugs.webkit.org/show_bug.cgi?id=62495
  41256. Bug 62495 - combine windows and mac kill-old-processes script
  41257. Add a platform agnostic script. Remove the recently added mac flavor.
  41258. Note: Leaving the windows one alone, since it is currently used by the WebKit bots.
  41259. * BuildSlaveSupport/kill-old-processes: Added.
  41260. * BuildSlaveSupport/mac: Removed.
  41261. * BuildSlaveSupport/mac/kill-old-processes: Removed.
  41262. 2011-06-14 Dirk Pranke <dpranke@chromium.org>
  41263. Reviewed by Tony Chang.
  41264. nrwt: handle worker exceptions cleanly
  41265. https://bugs.webkit.org/show_bug.cgi?id=62614
  41266. This change modifiers new-run-webkit-tests to handle exceptions
  41267. raised by worker threads better, by:
  41268. - capturing the worker's stack and logging it in the manager
  41269. - propagating the worker's exception in the caller correctly
  41270. - attempting to cancel the workers and clean up even when
  41271. we get an unexpected exception
  41272. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  41273. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  41274. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  41275. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  41276. 2011-06-14 Qi Zhang <qi.2.zhang@nokia.com>
  41277. Reviewed by Laszlo Gombos.
  41278. [Qt] fast/dom/HTMLScriptElement/nested-execution.html failed
  41279. https://bugs.webkit.org/show_bug.cgi?id=62227
  41280. QtWebkit does not yet support different CacheModels. This change will
  41281. expose setCacheModel() with a stub implementation, which is enough to pass the LayoutTest.
  41282. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  41283. (LayoutTestController::setCacheModel):
  41284. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  41285. 2011-06-14 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  41286. Reviewed by Andreas Kling.
  41287. [Qt] tst_QWebFrame::overloadedSlots() fails
  41288. https://bugs.webkit.org/show_bug.cgi?id=37319
  41289. Since we don't implictly convert 'document' object to QWebElement
  41290. in metacalls anymore, change the controller to expect QVariantMap instead.
  41291. The method plainText() was updated to use QVariantMap as well to let the bridge
  41292. do the conversion directly for us.
  41293. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  41294. (LayoutTestController::nodesFromRect):
  41295. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  41296. * DumpRenderTree/qt/PlainTextControllerQt.cpp:
  41297. (PlainTextController::plainText):
  41298. * DumpRenderTree/qt/PlainTextControllerQt.h:
  41299. 2011-06-14 Andras Becsi <abecsi@webkit.org>
  41300. Reviewed by Csaba Osztrogonác.
  41301. Remove dead code in DumpRenderTree/TestNetscapePlugIn/main.cpp
  41302. https://bugs.webkit.org/show_bug.cgi?id=62630
  41303. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  41304. (NPP_New): remove dead variable 'forceCarbon'
  41305. 2011-06-13 Hayato Ito <hayato@chromium.org>
  41306. Reviewed by Ojan Vafai.
  41307. [NRWT] Fix a WebKitDriver so that it returns an actual hash value if DRT returns that.
  41308. https://bugs.webkit.org/show_bug.cgi?id=59188
  41309. A current WebKitDriver doesn't try to return an actual hash value if DRT does not return an image.
  41310. WebKitDriver should always return an actual hash value if DRT returns that.
  41311. No tests since I'll add sample reftests to make sure mismatch reftests work later,
  41312. which should be in a separate patch.
  41313. * Scripts/webkitpy/layout_tests/port/webkit.py:
  41314. 2011-06-13 Kent Tamura <tkent@chromium.org>
  41315. [Chromium-win] Fix two wrong assertions exposed by r88757.
  41316. * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  41317. (WebThemeEngineDRTWin::paintTrackbar):
  41318. 2011-06-13 Alexey Proskuryakov <ap@apple.com>
  41319. Added an updated e-mail address for Matt Lilek, to make Bugzilla autocomplete
  41320. and commit queue happy.
  41321. * Scripts/webkitpy/common/config/committers.py:
  41322. 2011-06-13 Chris Rogers <crogers@google.com>
  41323. Unreviewed build fix.
  41324. Build fix to chromium DRT until we can rebaseline some tests
  41325. https://bugs.webkit.org/show_bug.cgi?id=62608
  41326. * DumpRenderTree/chromium/TestShell.cpp:
  41327. (TestShell::TestShell):
  41328. 2011-06-13 Chris Rogers <crogers@google.com>
  41329. Reviewed by Dirk Pranke.
  41330. Add Web Audio support to chromium DRT
  41331. https://bugs.webkit.org/show_bug.cgi?id=62306
  41332. * DumpRenderTree/chromium/LayoutTestController.cpp:
  41333. (LayoutTestController::LayoutTestController):
  41334. (LayoutTestController::reset):
  41335. (LayoutTestController::setEncodedAudioData):
  41336. * DumpRenderTree/chromium/LayoutTestController.h:
  41337. (LayoutTestController::encodedAudioData):
  41338. (LayoutTestController::shouldDumpAsAudio):
  41339. (LayoutTestController::setShouldDumpAsAudio):
  41340. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  41341. (DRTPrinter::handleAudioHeader):
  41342. (TestShellPrinter::handleAudioHeader):
  41343. * DumpRenderTree/chromium/TestEventPrinter.h:
  41344. * DumpRenderTree/chromium/TestShell.cpp:
  41345. (TestShell::TestShell):
  41346. (TestShell::dump):
  41347. 2011-06-13 Jaehun Lim <ljaehun.lim@samsung.com>
  41348. Reviewed by Eric Seidel.
  41349. [EFL] Add load error handler to EWebLauncher
  41350. https://bugs.webkit.org/show_bug.cgi?id=62347
  41351. Add a handler function of "load,error" to EWebLauncher.
  41352. EWebLauncher now displays a simple error page on load errors.
  41353. * EWebLauncher/main.c:
  41354. (on_load_error):
  41355. (browserCreate):
  41356. 2011-06-13 Martin Robinson <mrobinson@igalia.com>
  41357. Reviewed by Eric Seidel.
  41358. [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
  41359. https://bugs.webkit.org/show_bug.cgi?id=62385
  41360. Remove duplicate TestNetscapePlugIn implementation. Having two copies
  41361. of this code makes keeping it in sync much more difficult. The files are
  41362. almost identical and this change ports the X11 changes to main.cpp.
  41363. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  41364. (NPP_New): Do not set the plugin as windowless always. Doing this breaks
  41365. some results on Qt and this seems to be unnecessary for the moment.
  41366. (keyEventToChar): Added this helper which converts a X11 keycode into a char.
  41367. (handleEventX11): Use the handler to properly convert the keycode. Do not print
  41368. adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
  41369. it should not be in the results.
  41370. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed and make it clearer why the
  41371. XP_UNIX block is first by guarding against using a null instance.
  41372. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list add
  41373. the XP_UNIX define for Linux.
  41374. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
  41375. * GNUmakefile.am: Update source list.
  41376. 2011-06-13 Sheriff Bot <webkit.review.bot@gmail.com>
  41377. Unreviewed, rolling out r88671.
  41378. http://trac.webkit.org/changeset/88671
  41379. https://bugs.webkit.org/show_bug.cgi?id=62591
  41380. "didn't work" (Requested by dpranke on #webkit).
  41381. * Scripts/new-run-webkit-httpd:
  41382. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  41383. * Scripts/webkitpy/layout_tests/port/http_server.py:
  41384. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  41385. * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Removed.
  41386. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  41387. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  41388. 2011-06-13 Nate Chapin <japhet@chromium.org>
  41389. Reviewed by Darin Fisher.
  41390. New test method on TestNetscapePlugin for https://bugs.webkit.org/show_bug.cgi?id=61482.
  41391. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  41392. 2011-06-13 Dirk Pranke <dpranke@chromium.org>
  41393. Reviewed by Tony Chang.
  41394. webkitpy: add integration tests for new-run-webkit-httpd, stop calling shut_down_http_server
  41395. https://bugs.webkit.org/show_bug.cgi?id=62251
  41396. shut_down_http_server() was a total hack that was only used by
  41397. new-run-webkit-httpd, so I've moved the code there and switched
  41398. to using executive.kill_process() for the common case. The
  41399. method itself will be removed in the patch on bug 59993.
  41400. * Scripts/new-run-webkit-httpd:
  41401. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  41402. * Scripts/webkitpy/layout_tests/port/http_server.py:
  41403. * Scripts/webkitpy/layout_tests/port/http_server_integrationtest.py: Added.
  41404. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  41405. 2011-06-13 Tony Chang <tony@chromium.org>
  41406. Reviewed by Dimitri Glazkov.
  41407. rename ENABLE_NEW_FLEXBOX to ENABLE_CSS3_FLEXBOX
  41408. https://bugs.webkit.org/show_bug.cgi?id=62578
  41409. * Scripts/build-webkit:
  41410. 2011-06-13 Tony Chang <tony@chromium.org>
  41411. Reviewed by Adam Barth.
  41412. rename ENABLE_FLEXBOX to ENABLE_NEW_FLEXBOX
  41413. https://bugs.webkit.org/show_bug.cgi?id=62545
  41414. * Scripts/build-webkit:
  41415. 2011-06-13 Carlos Garcia Campos <cgarcia@igalia.com>
  41416. Reviewed by Martin Robinson.
  41417. [GTK] Export an API similar to WebKit1
  41418. https://bugs.webkit.org/show_bug.cgi?id=57820
  41419. Build GtkLauncher2 for WebKit2. It's actually the same GtkLauncher
  41420. code, but linking to libwebkit2gtk.
  41421. * GNUmakefile.am:
  41422. * GtkLauncher/main.c:
  41423. (createBrowser):
  41424. (main):
  41425. 2011-06-12 MORITA Hajime <morrita@google.com>
  41426. Unreviewed, rolling out r88625.
  41427. http://trac.webkit.org/changeset/88625
  41428. https://bugs.webkit.org/show_bug.cgi?id=61073
  41429. Breaks SL Webkit2 Tests
  41430. * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  41431. * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  41432. * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  41433. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  41434. (WTR::InjectedBundlePage::didClearWindowForFrame):
  41435. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  41436. 2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  41437. Reviewed by Antonio Gomes.
  41438. [Qt] LayoutTestController needs setTextDirection implementation
  41439. https://bugs.webkit.org/show_bug.cgi?id=62442
  41440. Implements LayoutController.setTextDirection.
  41441. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  41442. (LayoutTestController::setTextDirection):
  41443. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  41444. 2011-06-12 Dominic Cooney <dominicc@chromium.org>
  41445. Reviewed by Hajime Morita.
  41446. Add window.internals to WebKit2's WebKitTestRunner.
  41447. https://bugs.webkit.org/show_bug.cgi?id=61073
  41448. Test: fast/harness/internals-object.html
  41449. * WebKitTestRunner/Configurations/InjectedBundleCFLite.vsprops:
  41450. * WebKitTestRunner/Configurations/InjectedBundleCommon.vsprops:
  41451. * WebKitTestRunner/Configurations/InjectedBundleCoreFoundation.vsprops:
  41452. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  41453. (WTR::InjectedBundlePage::didClearWindowForFrame): initialize window.internals
  41454. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  41455. 2011-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
  41456. Unreviewed, rolling out r88616.
  41457. http://trac.webkit.org/changeset/88616
  41458. https://bugs.webkit.org/show_bug.cgi?id=62517
  41459. It broke editing/text-iterator/findString.html (Requested by
  41460. tonikitoo on #webkit).
  41461. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  41462. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  41463. 2011-06-12 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  41464. Reviewed by Antonio Gomes.
  41465. [Qt] LayoutTestController needs setTextDirection implementation
  41466. https://bugs.webkit.org/show_bug.cgi?id=62442
  41467. Implements LayoutController.setTextDirection.
  41468. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  41469. (LayoutTestController::setTextDirection):
  41470. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  41471. 2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
  41472. Reviewed by Ojan Vafai.
  41473. new-run-webkit-tests: 'images' links on results.html don't work
  41474. https://bugs.webkit.org/show_bug.cgi?id=62194
  41475. Use relative path when generating images-diffs.html
  41476. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  41477. Added _output_testname.
  41478. 2011-06-10 Lucas Forschler <lforschler@apple.com>
  41479. Reviewed by Stephanie Lewis.
  41480. Script to kill old processes on Mac.
  41481. This matches the windows version.
  41482. https://bugs.webkit.org/show_bug.cgi?id=62479
  41483. * BuildSlaveSupport/mac: Added.
  41484. * BuildSlaveSupport/mac/kill-old-processes: Added.
  41485. 2011-06-10 Adam Barth <abarth@webkit.org>
  41486. Reviewed by James Robinson.
  41487. When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
  41488. https://bugs.webkit.org/show_bug.cgi?id=62489
  41489. * Scripts/webkitpy/tool/bot/sheriff.py:
  41490. * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  41491. 2011-06-10 Tony Chang <tony@chromium.org>
  41492. Reviewed by Ojan Vafai.
  41493. add a compile guard ENABLE(FLEXBOX)
  41494. https://bugs.webkit.org/show_bug.cgi?id=62049
  41495. * Scripts/build-webkit:
  41496. 2011-06-10 Mark Rowe <mrowe@apple.com>
  41497. Reviewed by Dimitri Glazkov.
  41498. <rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
  41499. Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
  41500. header file.
  41501. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  41502. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  41503. 2011-06-09 Csaba Osztrogonác <ossy@webkit.org>
  41504. Unreviewed rolling out r88471, because it broke plugin tests on Qt.
  41505. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  41506. (handleEventX11):
  41507. (NPP_GetValue):
  41508. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  41509. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
  41510. (webkit_test_plugin_new_instance):
  41511. (webkit_test_plugin_destroy_instance):
  41512. (webkit_test_plugin_set_window):
  41513. (executeScript):
  41514. (webkit_test_plugin_new_stream):
  41515. (webkit_test_plugin_destroy_stream):
  41516. (webkit_test_plugin_stream_as_file):
  41517. (webkit_test_plugin_write_ready):
  41518. (webkit_test_plugin_write):
  41519. (webkit_test_plugin_print):
  41520. (keyEventToChar):
  41521. (webkit_test_plugin_handle_event):
  41522. (webkit_test_plugin_url_notify):
  41523. (webkit_test_plugin_get_value):
  41524. (webkit_test_plugin_set_value):
  41525. (NP_GetMIMEDescription):
  41526. (NP_Initialize):
  41527. (NP_Shutdown):
  41528. (NP_GetValue):
  41529. * GNUmakefile.am:
  41530. 2011-06-09 Martin Robinson <mrobinson@igalia.com>
  41531. Reviewed by Eric Seidel.
  41532. [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
  41533. https://bugs.webkit.org/show_bug.cgi?id=55603
  41534. Add callbacks to support hasMarkedText and markedRange and also clean up existing
  41535. TextInputController support.
  41536. * DumpRenderTree/gtk/TextInputController.cpp:
  41537. (setMarkedTextCallback): Accept parameters in terms of start and length, instead
  41538. of start and end. This matches the other ports. Do not use GLib style early returns.
  41539. (hasMarkedTextCallback): Added.
  41540. (markedRangeCallback): Added.
  41541. (insertTextCallback): Cleanup as described above.
  41542. (unmarkTextCallback): Cleanup as described above.
  41543. (firstRectForCharacterRangeCallback): Cleanup as described above.
  41544. (selectedRangeCallback): Cleanup as described above.
  41545. 2011-06-09 Dirk Pranke <dpranke@chromium.org>
  41546. Reviewed by Tony Chang.
  41547. nrwt: support webaudio in chromium driver
  41548. https://bugs.webkit.org/show_bug.cgi?id=62226
  41549. * Scripts/webkitpy/layout_tests/port/chromium.py:
  41550. 2011-06-09 Dan Bernstein <mitz@apple.com>
  41551. Reviewed by Anders Carlsson.
  41552. Added a test for Vector::reverse()
  41553. https://bugs.webkit.org/show_bug.cgi?id=62393
  41554. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  41555. * TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
  41556. (TestWebKitAPI::TEST):
  41557. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  41558. 2011-06-09 Martin Robinson <mrobinson@igalia.com>
  41559. Reviewed by Andreas Kling.
  41560. [GTK] [Qt] Eliminate duplicate TestNetscapePlugin implementation
  41561. https://bugs.webkit.org/show_bug.cgi?id=62385
  41562. Remove duplicate TestNetscapePlugIn implementation. Having two copies
  41563. of this code makes keeping it in sync much more difficult. The files are
  41564. almost identical and this change ports the X11 changes to main.cpp.
  41565. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  41566. (keyEventToChar): Added this helper which converts a X11 keycode into a char.
  41567. (handleEventX11): Use the handler to properly convert the keycode. Do not print
  41568. adjustCursorEvent output. The tests currently do not trigger this for Cocoa and thus
  41569. it should not be in the results.
  41570. (NPP_GetValue): Properly handle NPPVpluginNeedsXEmbed.
  41571. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro: Update source list.
  41572. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Removed.
  41573. * GNUmakefile.am: Update source list.
  41574. 2011-06-09 Noel Gordon <noel.gordon@gmail.com>
  41575. Reviewed by Tony Chang.
  41576. Test plugin should support event logging on the windows port.
  41577. https://bugs.webkit.org/show_bug.cgi?id=61721
  41578. The WebKit win port interprets a 0 return from plugin NPP_HandleEvent()
  41579. calls to mean the plugin handled the event.
  41580. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  41581. (handleEventWin): Return 0 for each event on windows.
  41582. 2011-06-09 Chang Shu <cshu@webkit.org>
  41583. Reviewed by Andreas Kling.
  41584. [Qt] [WK2] Many editing tests failed on missing shouldBeginEditingInDOMRange:range printout
  41585. https://bugs.webkit.org/show_bug.cgi?id=62381
  41586. Activate QGraphicsScene and setFocus on QGraphicsItem to make sure the view has the focus.
  41587. QWKPagePrivate::isViewFocused() will check it later.
  41588. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  41589. (WTR::PlatformWebView::PlatformWebView):
  41590. 2011-06-09 Robert Hogan <robert@webkit.org>
  41591. Reviewed by Andreas Kling.
  41592. Teach Qt about window.internals
  41593. https://bugs.webkit.org/show_bug.cgi?id=61074
  41594. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  41595. (WebCore::DumpRenderTree::initJSObjects):
  41596. 2011-06-09 Eric Seidel <eric@webkit.org>
  41597. Reviewed by Adam Barth.
  41598. Disable running layout tests on Mac EWS bots (and fix cr-linux bots to run them again)
  41599. https://bugs.webkit.org/show_bug.cgi?id=62362
  41600. The mac bots are failing inspector tests. We don't know why yet.
  41601. So for now, turning run-webkit-tests off for the mac-ews.
  41602. Also noticed that due to the wrong variable name the cr-linux
  41603. bots weren't running tests!
  41604. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  41605. 2011-06-09 Zoltan Herczeg <zherczeg@inf.u-szeged.hu>
  41606. Reviewed by Csaba Osztrogonac.
  41607. [Qt][WK2] Canvas tests make css2.1 ones failing
  41608. https://bugs.webkit.org/show_bug.cgi?id=53427
  41609. Adding a workaround for this issue by mimicing the behaviour of DumpRenderTree.
  41610. Since the Qt port should eventually go to QRawFont, this issue will be resolved
  41611. in the future. Both clearMemoryCaches() and removeAllApplicationFonts() are
  41612. needed for the workaround.
  41613. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  41614. (WTR::LayoutTestController::platformInitialize):
  41615. 2011-06-09 Mario Sanchez Prada <msanchez@igalia.com>
  41616. Reviewed by Chris Fleizach.
  41617. [GTK] Provide a way in DRT to check the platform name
  41618. https://bugs.webkit.org/show_bug.cgi?id=56855
  41619. Patch for adding 'platformName' static property to DRT's
  41620. LayoutController and provide platform specific implementations.
  41621. In principle, this feature will be only of interest for writing
  41622. accessibility tests, so that's why it's only implemented in the
  41623. Mac, Gtk and Win platforms.
  41624. * DumpRenderTree/LayoutTestController.h: New method platformName().
  41625. * DumpRenderTree/LayoutTestController.cpp:
  41626. (getPlatformNameCallback): New callback for 'platformName'.
  41627. (LayoutTestController::staticValues): New static property.
  41628. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  41629. (LayoutTestController::platformName): Implemented.
  41630. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  41631. (LayoutTestController::platformName): Implemented.
  41632. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  41633. (LayoutTestController::platformName): Implemented.
  41634. 2011-06-08 Mike Lawther <mikelawther@chromium.org>
  41635. Reviewed by James Robinson.
  41636. Add mikelawther to committers.py
  41637. https://bugs.webkit.org/show_bug.cgi?id=62354
  41638. * Scripts/webkitpy/common/config/committers.py:
  41639. 2011-06-08 Kent Tamura <tkent@chromium.org>
  41640. [Chromium] Fix a typo.
  41641. * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
  41642. (WebThemeControlDRTWin::draw):
  41643. 2011-06-08 Kent Tamura <tkent@chromium.org>
  41644. Reviewed by Hajime Morita.
  41645. [Chromium] Support vertical sliders in Windows DRT
  41646. https://bugs.webkit.org/show_bug.cgi?id=62352
  41647. * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
  41648. (WebThemeControlDRTWin::draw):
  41649. Paint VerticalSliderThumbType and VerticalSliderTrackType.
  41650. * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
  41651. Add VerticalSliderTrackType and VerticalSliderThumbType.
  41652. * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  41653. (WebThemeEngineDRTWin::paintTrackbar):
  41654. Convert Windows identifiers to the internal identifiers for vertical sliders.
  41655. 2011-06-08 Ojan Vafai <ojan@chromium.org>
  41656. Reviewed by Tony Chang.
  41657. add a short-flag for --experimental-fully-parallel
  41658. https://bugs.webkit.org/show_bug.cgi?id=62321
  41659. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  41660. 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
  41661. Reviewed by Tony Chang.
  41662. new-run-webkit-tests: don't turn the tree red when there are new passes
  41663. https://bugs.webkit.org/show_bug.cgi?id=62311
  41664. Look for "new passes" instead of "passed unexpectedly" in evaluateCommand
  41665. to match commandComplete.
  41666. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  41667. 2011-06-08 Tom Hudson <tomhudson@google.com>
  41668. Reviewed by Mihai Parparita.
  41669. Allow sorting in RebaselineServer based on 'metric' field in unexpected_results.json
  41670. https://bugs.webkit.org/show_bug.cgi?id=60964
  41671. * Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
  41672. Add 'Sort tests by metric' link.
  41673. * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
  41674. (disableSorting): Activate 'Sort tests by metric' link.
  41675. (enableSorting): Deactivate 'Sort tests by metric' link.
  41676. (selectDirectory): Call enableSorting()/disableSorting() depending
  41677. on currently selected failure type, and sort tests if requested.
  41678. * Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
  41679. New .disabled-control class for deactivated links.
  41680. 2011-06-08 Tom Sepez <tsepez@chromium.org>
  41681. Reviewed by Adam Barth.
  41682. Add web permissions callbacks for mixed content blocking.
  41683. https://bugs.webkit.org/show_bug.cgi?id=61946
  41684. * DumpRenderTree/chromium/LayoutTestController.cpp:
  41685. (LayoutTestController::setAllowDisplayOfInsecureContent):
  41686. (LayoutTestController::setAllowRunningOfInsecureContent):
  41687. (LayoutTestController::overridePreference):
  41688. * DumpRenderTree/chromium/WebPermissions.cpp:
  41689. (WebPermissions::allowDisplayingInsecureContent):
  41690. (WebPermissions::allowRunningInsecureContent):
  41691. (WebPermissions::setDisplayingInsecureContentAllowed):
  41692. (WebPermissions::setRunningInsecureContentAllowed):
  41693. (WebPermissions::reset):
  41694. * DumpRenderTree/chromium/WebPermissions.h:
  41695. 2011-06-08 Dirk Pranke <dpranke@chromium.org>
  41696. Reviewed by Tony Chang.
  41697. webkitpy: fix typo causing us to skip the port unit tests in chromium_linux
  41698. https://bugs.webkit.org/show_bug.cgi?id=62259
  41699. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  41700. 2011-06-08 Ryosuke Niwa <rniwa@webkit.org>
  41701. Reviewed by Tony Chang.
  41702. new-run-webkit-tests: master.cfg errors when nrwt successfully runs test
  41703. https://bugs.webkit.org/show_bug.cgi?id=62303
  41704. Access self.incorrectLayoutLines instead of incorrectLayoutLines in evaluateCommand.
  41705. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  41706. 2011-06-08 Greg Simon <gregsimon@chromium.org>
  41707. Reviewed by Dimitri Glazkov.
  41708. Control Indexeddb backends from LayoutTestController
  41709. https://bugs.webkit.org/show_bug.cgi?id=61000
  41710. * DumpRenderTree/chromium/LayoutTestController.cpp:
  41711. (LayoutTestController::LayoutTestController):
  41712. (LayoutTestController::setOverrideIndexedDBBackingStore):
  41713. (LayoutTestController::clearAllDatabases):
  41714. * DumpRenderTree/chromium/LayoutTestController.h:
  41715. 2011-06-08 Andreas Kling <kling@webkit.org>
  41716. Add Pierre Rossi to contributors list for EZ-CC.
  41717. * Scripts/webkitpy/common/config/committers.py:
  41718. 2011-06-08 Ilya Sherman <isherman@chromium.org>
  41719. Reviewed by Andreas Kling.
  41720. Add Ilya Sherman to list of committers
  41721. https://bugs.webkit.org/show_bug.cgi?id=62270
  41722. * Scripts/webkitpy/common/config/committers.py:
  41723. 2011-06-07 Ryosuke Niwa <rniwa@webkit.org>
  41724. Reviewed by Tony Chang.
  41725. new-run-webkit-tests: Bot master should print useful information on waterfall/console for nrwt
  41726. https://bugs.webkit.org/show_bug.cgi?id=62178
  41727. Added commandComplete and evaluateCommand for NewRunWebKitTests class
  41728. to parse new-run-webkit-tests' results.
  41729. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  41730. 2011-06-07 Dirk Pranke <dpranke@chromium.org>
  41731. Reviewed by Eric Seidel.
  41732. webkitpy: add a popen() call to executive
  41733. https://bugs.webkit.org/show_bug.cgi?id=62179
  41734. This change adds a popen() wrapper call to the Executive object.
  41735. This will allow other webkitpy scripts that currently call
  41736. subprocess directly to use Executive, instead.
  41737. No additional tests are necessary (the existing tests cover the code).
  41738. * Scripts/webkitpy/common/system/executive.py:
  41739. 2011-06-07 Sam Weinig <sam@webkit.org>
  41740. Reviewed by Anders Carlsson.
  41741. Remove repeated IPC traffic from SetRenderTreeSize message
  41742. https://bugs.webkit.org/show_bug.cgi?id=62244
  41743. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  41744. (WTR::InjectedBundlePage::InjectedBundlePage):
  41745. Add stub for didLayoutForFrame.
  41746. 2011-06-07 Dirk Pranke <dpranke@chromium.org>
  41747. Reviewed by Tony Chang.
  41748. rebaseline-chromium-webkit-tests: fix baselining order for linux, linux_x86_64
  41749. https://bugs.webkit.org/show_bug.cgi?id=62241
  41750. * Scripts/webkitpy/layout_tests/port/chromium.py:
  41751. 2011-06-07 Adam Barth <abarth@webkit.org>
  41752. Rubber-stamped by Eric Seidel.
  41753. Enable tests on the mac-ews
  41754. When we bring the mac-ews back up, we're going to try running tests!
  41755. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  41756. 2011-06-07 Dmitry Lomov <dslomov@google.com>
  41757. Reviewed by David Levin.
  41758. https://bugs.webkit.org/show_bug.cgi?id=62215
  41759. Allow comparisons with 0 in LIKELY and UNLIKELY macros.
  41760. * Scripts/webkitpy/style/checkers/cpp.py:
  41761. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  41762. 2011-06-07 Nico Weber <thakis@chromium.org>
  41763. Reviewed by Dimitri Glazkov.
  41764. [chromium] -Wdelete-non-virtual-dtor pass for DumpRenderTree
  41765. https://bugs.webkit.org/show_bug.cgi?id=62210
  41766. The change to TestEventPrinter fixes a latent bug, because
  41767. objects are deleted through the TestEventPrinter type, but none
  41768. of the subclasses have destructors or non-POD members.
  41769. The changes to NotificationPresenter and WebViewHost do _not_ to fix a
  41770. real bug, they just make clang's -Wdelete-non-virtual-dtor happy. As
  41771. discussed at http://codereview.chromium.org/7094005/, we prefer making
  41772. leaf class destructors virtual over making the leaf classes final.
  41773. * DumpRenderTree/chromium/NotificationPresenter.cpp:
  41774. (NotificationPresenter::~NotificationPresenter):
  41775. * DumpRenderTree/chromium/NotificationPresenter.h:
  41776. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  41777. (TestEventPrinter::~TestEventPrinter):
  41778. * DumpRenderTree/chromium/TestEventPrinter.h:
  41779. * DumpRenderTree/chromium/WebViewHost.h:
  41780. 2011-06-06 Ryosuke Niwa <rniwa@webkit.org>
  41781. Reviewed by Dirk Pranke.
  41782. [chromium] Chromium bots on build.webkit.org don't upload results.html
  41783. https://bugs.webkit.org/show_bug.cgi?id=61961
  41784. Don't fix the path on chromium port erroneously.
  41785. * BuildSlaveSupport/test-result-archive:
  41786. 2011-06-06 Martin Robinson <mrobinson@igalia.com>
  41787. Fix the GTK+ build by ensuring that the autogenerated sources
  41788. necessary for libWebCoreInternals are recorded in a predeclared
  41789. variable before assigning to BUILT_SOURCES.
  41790. * GNUmakefile.am: Predeclare libwebcoreinternals_built_sources.
  41791. 2011-06-06 Yong Li <yoli@rim.com>
  41792. Reviewed by Eric Seidel.
  41793. https://bugs.webkit.org/show_bug.cgi?id=62097
  41794. Fix the problem that integral bitfield check incorrectly barked at ?: expressions.
  41795. * Scripts/webkitpy/style/checkers/cpp.py:
  41796. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  41797. 2011-06-06 Xan Lopez <xlopez@igalia.com>
  41798. Reviewed by Martin Robinson.
  41799. [GTK] Enable feature/symbol detection in NWRT/GTK
  41800. https://bugs.webkit.org/show_bug.cgi?id=62136
  41801. Disable feature detection through DRT, since we don't support it,
  41802. and set the libwebcore patch correctly so that symbol detection
  41803. through 'nm' works.
  41804. * Scripts/webkitpy/layout_tests/port/gtk.py:
  41805. 2011-06-06 Shishir Agrawal <shishir@chromium.org>
  41806. Reviewed by Tony Gentilcore.
  41807. Add a "prerender" state for page visibility.
  41808. https://bugs.webkit.org/show_bug.cgi?id=62062
  41809. * DumpRenderTree/chromium/LayoutTestController.cpp:
  41810. (LayoutTestController::setPageVisibility):
  41811. 2011-06-06 Csaba Osztrogonác <ossy@webkit.org>
  41812. [Qt] Implement download feature for QtTestBrowser
  41813. https://bugs.webkit.org/show_bug.cgi?id=61865
  41814. Buildfix for --minimal and CONFIG+=qt_minimal build after r88161.
  41815. * QtTestBrowser/launcherwindow.cpp:
  41816. (LauncherWindow::LauncherWindow):
  41817. * QtTestBrowser/launcherwindow.h:
  41818. 2011-06-06 Barát Tibor <Barat.Tibor@stud.u-szeged.hu>
  41819. Reviewed by Csaba Osztrogonác.
  41820. [Qt] Implement download feature for QtTestBrowser
  41821. https://bugs.webkit.org/show_bug.cgi?id=61865
  41822. * QtTestBrowser/launcherwindow.cpp:
  41823. (LauncherWindow::LauncherWindow):
  41824. (LauncherWindow::downloadRequest):
  41825. (LauncherWindow::fileDownloadFinished):
  41826. * QtTestBrowser/launcherwindow.h:
  41827. 2011-06-04 Dominic Cooney <dominicc@chromium.org>
  41828. Reviewed by Dimitri Glazkov.
  41829. Make DumpRenderTree initialize window.internals.
  41830. https://bugs.webkit.org/show_bug.cgi?id=61076
  41831. * DumpRenderTree/win/DumpRenderTreeCommon.vsprops: link WebCoreTestSupport.
  41832. * DumpRenderTree/win/FrameLoadDelegate.cpp:
  41833. (FrameLoadDelegate::didClearWindowObjectForFrameInStandardWorld):
  41834. 2011-06-06 Alexandru Chiculita <achicu@adobe.com>
  41835. Reviewed by Kent Tamura.
  41836. Add ENABLE_CSS_EXCLUSIONS support for build-webkit script
  41837. https://bugs.webkit.org/show_bug.cgi?id=61628
  41838. * Scripts/build-webkit:
  41839. 2011-06-06 Mihnea Ovidenie <mihnea@adobe.com>
  41840. Reviewed by Kent Tamura.
  41841. Add ENABLE(CSS_REGIONS) guard for CSS Regions support
  41842. https://bugs.webkit.org/show_bug.cgi?id=61631
  41843. * Scripts/build-webkit:
  41844. 2011-06-06 Carlos Garcia Campos <cgarcia@igalia.com>
  41845. Unreviewed. Fix the GTK+ build.
  41846. * GNUmakefile.am: Use javascriptcore_cflags when building libWebCoreInternals.
  41847. 2011-06-05 Alexey Proskuryakov <ap@apple.com>
  41848. Add an e-mail address for Cameron McCormack that matches Bugzilla (so that auto-completion
  41849. works properly).
  41850. * Scripts/webkitpy/common/config/committers.py:
  41851. 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
  41852. [wx] Unreviewed build fix. Update git branch build dir handling to match what other
  41853. WebKit scripts expect, so other scripts work properly with wx.
  41854. * waf/build/build_utils.py:
  41855. * waf/build/settings.py:
  41856. 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
  41857. [wx] Unreviewed build fix. Restore the PPC build and allow users to specify architectures
  41858. to build on Mac.
  41859. * waf/build/settings.py:
  41860. * wx/install-unix-extras:
  41861. 2011-06-04 Kevin Ollivier <kevino@theolliviers.com>
  41862. [wx] Unreviewed build fixes for recent trunk changes.
  41863. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  41864. (LayoutTestController::setTextDirection):
  41865. * waf/build/settings.py:
  41866. 2011-06-04 Martin Robinson <mrobinson@igalia.com>
  41867. Fix the GTK+ build.
  41868. * GNUmakefile.am: Add some missing newline escape.
  41869. 2011-06-03 Martin Robinson <mrobinson@igalia.com>
  41870. Try to fix the GTK+ bulid.
  41871. * GNUmakefile.am: Add JSDOMWrapper.cpp to the libWebCoreInternals
  41872. source list.
  41873. 2011-06-03 Dirk Pranke <dpranke@chromium.org>
  41874. Reviewed by Adam Barth.
  41875. nrwt: should skip chromium test expectation overrides on upstream bots
  41876. https://bugs.webkit.org/show_bug.cgi?id=61888
  41877. * Scripts/webkitpy/layout_tests/port/chromium.py:
  41878. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  41879. 2011-06-03 Dirk Pranke <dpranke@chromium.org>
  41880. Reviewed by Ojan Vafai.
  41881. new-run-webkit-tests: minor logging, code cleanup
  41882. https://bugs.webkit.org/show_bug.cgi?id=62055
  41883. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  41884. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  41885. 2011-06-03 Martin Robinson <mrobinson@igalia.com>
  41886. Try to fix the build failure on the GTK+ 32-bit Release bot.
  41887. * GNUmakefile.am: Add JSInternal.{cpp,h} to the BUILT_SOURCES list.
  41888. 2011-05-31 Martin Robinson <mrobinson@igalia.com>
  41889. Reviewed by Ryosuke Niwa.
  41890. [GTK] Support smart replace for the pasteboard
  41891. https://bugs.webkit.org/show_bug.cgi?id=61734
  41892. Call into the DumpRenderTreeSupportGtk hooks to toggle smart replace.
  41893. This is required to produce consistent test results.
  41894. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  41895. (resetDefaultsToConsistentValues): Set the smart replace setting to on by default.
  41896. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  41897. (LayoutTestController::setSmartInsertDeleteEnabled): Added an implementation of this
  41898. methods which calls into DumpRenderTreeSupportGtk.
  41899. 2011-06-03 Martin Robinson <mrobinson@igalia.com>
  41900. Reviewed by Dimitri Glazkov.
  41901. Teach Gtk build about window.internals
  41902. https://bugs.webkit.org/show_bug.cgi?id=61071
  41903. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  41904. (webViewWindowObjectCleared): Inject the new internals object when the
  41905. window object clears.
  41906. * GNUmakefile.am: Add new source files and includes necessary for window.internals.
  41907. Also do a little bit of cleanup.
  41908. 2011-06-03 Dirk Pranke <dpranke@chromium.org>
  41909. Reviewed by Tony Chang.
  41910. Worker may not be stopped after LT.
  41911. https://bugs.webkit.org/show_bug.cgi?id=61847
  41912. Re-submit a variant of the first fix for this bug. It's possible
  41913. that actually calling cleanup() in the worker threads was taking
  41914. too long and we triggered the assertions in the manager thread.
  41915. I've bumped up the timeout in the manager and added better
  41916. diagnostics. I also cleaned up the cleanup() code a bit because
  41917. there was some unnecessary if-checks.
  41918. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  41919. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  41920. 2011-06-03 Dirk Pranke <dpranke@chromium.org>
  41921. Reviewed by Tony Chang.
  41922. nrwt: fix duplicate logging regression
  41923. https://bugs.webkit.org/show_bug.cgi?id=61981
  41924. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  41925. 2011-06-03 Robert Kroeger <rjkroege@chromium.org>
  41926. Reviewed by Adam Barth.
  41927. Modified addTouchPoint to correctly re-use touchPoint id values starting
  41928. from the lowest not-un-use touchPoint id as is done by the embedder
  41929. APIs. (Fixes BUGCR36415)
  41930. https://bugs.webkit.org/show_bug.cgi?id=62016
  41931. * DumpRenderTree/chromium/EventSender.cpp:
  41932. (EventSender::addTouchPoint):
  41933. 2011-06-03 Cary Clark <caryclark@google.com>
  41934. Reviewed by Eric Seidel.
  41935. Draw DRT scroll bar thumb with CG when WebKit renders with Skia
  41936. https://bugs.webkit.org/show_bug.cgi?id=61534
  41937. Skia on Mac uses Skia to render WebKit, and CG
  41938. to render UI elements. The CG elements need a
  41939. transcribed graphics context that preserves the
  41940. canvas matrix, and the canvas clip.
  41941. The SkiaBitLocker utility class sets up a CGContext
  41942. from the SkCanvas, locks the bitmap's bits, and
  41943. releases the lock when the class goes out of scope.
  41944. The SkiaBitLocker implementation is described by
  41945. this patch:
  41946. http://codereview.chromium.org/7031006/
  41947. When WebKit uses Skia for rendering, the WebCanvas
  41948. is an SkCanvas. Create an equivalent CGContext to
  41949. draw the scrollbar thumb.
  41950. As the Chrome Mac port does not yet use Skia, this
  41951. patch has no effect and requires no tests.
  41952. * DumpRenderTree/chromium/WebThemeEngineDRTMac.mm:
  41953. (WebThemeEngineDRTMac::paintHIThemeScrollbarThumb):
  41954. 2011-06-03 Andras Becsi <abecsi@webkit.org>
  41955. Unreviewed build fix.
  41956. Fix typo.
  41957. * Scripts/old-run-webkit-tests:
  41958. 2011-06-03 Andras Becsi <abecsi@webkit.org>
  41959. Reviewed by Csaba Osztrogonác.
  41960. Print error message when there is no httpd present on the system
  41961. https://bugs.webkit.org/show_bug.cgi?id=61939
  41962. * Scripts/old-run-webkit-tests: Propose to run with --no-httpd.
  41963. * Scripts/webkitperl/httpd.pm:
  41964. 2011-06-03 Mikhail Naganov <mnaganov@chromium.org>
  41965. Reviewed by Yury Semikhatsky.
  41966. Web Inspector: [Chromium] cpu-profiler-profiling layout test is flaky on Linux Debug.
  41967. https://bugs.webkit.org/show_bug.cgi?id=61533
  41968. Skip cpu-profiler-profiling in debug, implement a fast headless alternative.
  41969. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  41970. (DRTDevToolsAgent::setJavaScriptProfilingEnabled):
  41971. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  41972. * DumpRenderTree/chromium/LayoutTestController.cpp:
  41973. (LayoutTestController::LayoutTestController):
  41974. (LayoutTestController::setJavaScriptProfilingEnabled):
  41975. * DumpRenderTree/chromium/LayoutTestController.h:
  41976. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  41977. (LayoutTestController::setJavaScriptProfilingEnabled):
  41978. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  41979. (WTR::LayoutTestController::setJavaScriptProfilingEnabled):
  41980. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  41981. 2011-06-02 Dirk Pranke <dpranke@chromium.org>
  41982. Reviewed by Tony Chang.
  41983. NRWT needs a way to log to a file without including backspaces without needing --verbose
  41984. https://bugs.webkit.org/show_bug.cgi?id=60328
  41985. This change modifies NRWT so that if it can tell if it is
  41986. writing to a terminal, it will overwrite any messages printed
  41987. in the 'one-line-progress' and 'updates' print options, and if
  41988. not (or if --verbose was specified) the messages will be printed
  41989. without backspaces.
  41990. If the overwriting updates are disabled, one-line-progress will
  41991. only print every 10 seconds instead of on every update. This
  41992. ensures that we still get updates once in a while while the
  41993. tests are running, even if we're not in --verbose mode. Note
  41994. that one-line-progress will now still be printed in --verbose,
  41995. since it's useful as long as you're not flooded with the
  41996. updates.
  41997. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  41998. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  41999. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  42000. 2011-06-02 Martin Robinson <mrobinson@igalia.com>
  42001. Reviewed by Gustavo Noronha Silva.
  42002. [GTK] autogen.sh is run twice for each buld on the bots
  42003. https://bugs.webkit.org/show_bug.cgi?id=61951
  42004. * Scripts/webkitdirs.pm: Only check the previous autotools arguments
  42005. for the WebKit project. This prevents build-jsc runs from forcing subsequent
  42006. build-webkit runs to re-rerun autogen.sh.
  42007. 2011-06-02 Sheriff Bot <webkit.review.bot@gmail.com>
  42008. Unreviewed, rolling out r87946.
  42009. http://trac.webkit.org/changeset/87946
  42010. https://bugs.webkit.org/show_bug.cgi?id=61965
  42011. Cause NRWT to break (Requested by abarth|gardener on #webkit).
  42012. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  42013. 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
  42014. Reviewed by Darin Adler.
  42015. Add build logistics and plumbing for window.internals object.
  42016. https://bugs.webkit.org/show_bug.cgi?id=60313
  42017. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  42018. * DumpRenderTree/chromium/TestShell.cpp:
  42019. (TestShell::bindJSObjectsToWindow): Added injection code.
  42020. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  42021. (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
  42022. 2011-06-02 Hao Zheng <zhenghao@chromium.org>
  42023. Reviewed by Dirk Pranke.
  42024. Call cleanup() explicitly at the end of worker.run().
  42025. https://bugs.webkit.org/show_bug.cgi?id=61847
  42026. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  42027. 2011-06-02 Dimitri Glazkov <dglazkov@chromium.org>
  42028. Unreviewed, rolling out r87926.
  42029. http://trac.webkit.org/changeset/87926
  42030. https://bugs.webkit.org/show_bug.cgi?id=60313
  42031. Fails to find WebCoreTestSupport.dylib on bots.
  42032. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  42033. * DumpRenderTree/chromium/TestShell.cpp:
  42034. (TestShell::bindJSObjectsToWindow):
  42035. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  42036. (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
  42037. 2011-05-21 Dimitri Glazkov <dglazkov@chromium.org>
  42038. Reviewed by Darin Adler.
  42039. Add build logistics and plumbing for window.internals object.
  42040. https://bugs.webkit.org/show_bug.cgi?id=60313
  42041. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  42042. * DumpRenderTree/chromium/TestShell.cpp:
  42043. (TestShell::bindJSObjectsToWindow): Added injection code.
  42044. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  42045. (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
  42046. 2011-06-02 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  42047. Reviewed by Eric Seidel.
  42048. Adjust efl coding style to more efl directories
  42049. https://bugs.webkit.org/show_bug.cgi?id=61903
  42050. * Scripts/webkitpy/style/checker.py: Adjust efl coding style to efl directories.
  42051. 2011-06-01 Dirk Pranke <dpranke@chromium.org>
  42052. Reviewed by Tony Chang.
  42053. old-run-webkit-tests: add support for audio files
  42054. https://bugs.webkit.org/show_bug.cgi?id=57992
  42055. * Scripts/old-run-webkit-tests:
  42056. 2011-06-01 Jochen Eisinger <jochen@chromium.org>
  42057. Reviewed by Adam Barth.
  42058. Implement layoutTestController.setImagesAllowed for controlling the respective behavior of the WebPermissionClient
  42059. https://bugs.webkit.org/show_bug.cgi?id=34314
  42060. * DumpRenderTree/DumpRenderTree.gypi:
  42061. * DumpRenderTree/chromium/LayoutTestController.cpp:
  42062. (LayoutTestController::LayoutTestController):
  42063. (LayoutTestController::setImagesAllowed):
  42064. (LayoutTestController::setStorageAllowed):
  42065. * DumpRenderTree/chromium/LayoutTestController.h:
  42066. * DumpRenderTree/chromium/WebPermissions.cpp: Copied from Tools/DumpRenderTree/chromium/WebPermissions.h.
  42067. (WebPermissions::WebPermissions):
  42068. (WebPermissions::~WebPermissions):
  42069. (WebPermissions::allowImages):
  42070. (WebPermissions::allowStorage):
  42071. (WebPermissions::setImagesAllowed):
  42072. (WebPermissions::setStorageAllowed):
  42073. (WebPermissions::reset):
  42074. * DumpRenderTree/chromium/WebPermissions.h:
  42075. 2011-06-01 Noel Gordon <noel.gordon@gmail.com>
  42076. Reviewed by Tony Chang.
  42077. Test plugin should support event logging on the windows port.
  42078. https://bugs.webkit.org/show_bug.cgi?id=61721
  42079. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  42080. (handleEventWin): Well, handle them.
  42081. 2011-06-01 Daniel Cheng <dcheng@chromium.org>
  42082. Reviewed by Tony Chang.
  42083. [chromium] Use correct file name for dragging out images.
  42084. https://bugs.webkit.org/show_bug.cgi?id=24887
  42085. * DumpRenderTree/chromium/EventSender.cpp:
  42086. (EventSender::EventSender):
  42087. (EventSender::dumpFilenameBeingDragged):
  42088. * DumpRenderTree/chromium/EventSender.h:
  42089. 2011-06-01 Dirk Pranke <dpranke@chromium.org>
  42090. Reviewed by Tony Chang.
  42091. nrwt: make webaudio work w/o content-length header
  42092. https://bugs.webkit.org/show_bug.cgi?id=61819
  42093. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  42094. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  42095. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  42096. * Scripts/webkitpy/layout_tests/port/webkit.py:
  42097. 2011-06-01 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
  42098. Reviewed by Andreas Kling.
  42099. [Qt][WK2] Add QGLWidget viewport support to MiniBrowser
  42100. https://bugs.webkit.org/show_bug.cgi?id=61802
  42101. Add command line parameter and menu item to MiniBrowser application
  42102. enabling use of QGLWidget for browser viewport.
  42103. * MiniBrowser/qt/BrowserWindow.cpp:
  42104. (BrowserWindow::BrowserWindow):
  42105. (BrowserWindow::toggleGLViewport):
  42106. * MiniBrowser/qt/BrowserWindow.h:
  42107. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  42108. (MiniBrowserApplication::handleUserOptions):
  42109. * MiniBrowser/qt/MiniBrowserApplication.h:
  42110. (WindowOptions::WindowOptions):
  42111. 2011-06-01 Martin Robinson <mrobinson@igalia.com>
  42112. Reviewed by Xan Lopez.
  42113. Print out autogen arguments when they differ from the last set, to help
  42114. with debugging build issues.
  42115. * Scripts/webkitdirs.pm: Print out previous and current build arguments
  42116. when they differ.
  42117. 2011-06-01 Carlos Garcia Campos <cgarcia@igalia.com>
  42118. Reviewed by Martin Robinson.
  42119. [GTK] run-launcher should run MiniBrowser in WebKit2
  42120. https://bugs.webkit.org/show_bug.cgi?id=61858
  42121. * Scripts/run-launcher: Check whether -2 command line option has
  42122. been passed and run MiniBrowser instead of GtkLauncher.
  42123. 2011-05-31 Hao Zheng <zhenghao@chromium.org>
  42124. Reviewed by Dirk Pranke.
  42125. Fix exception in verbose printing mode.
  42126. https://bugs.webkit.org/show_bug.cgi?id=61723
  42127. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  42128. 2011-05-31 Yong Li <yoli@rim.com>
  42129. Reviewed by Eric Seidel.
  42130. https://bugs.webkit.org/show_bug.cgi?id=54807
  42131. We have been assuming plain bitfields (like "int a : 31") are always signed integers.
  42132. However some compilers can treat them as unsigned. For example, RVCT 4.0 states plain
  42133. bitfields (declared without either signed or unsigned qualifiers) are treats as unsigned.
  42134. http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0348c/Babjddhe.html
  42135. Although we can use "--signed-bitfields" flag to make RVCT 4.0 behave as most other compilers,
  42136. always using "signed"/"unsigned" qualifier to declare integral type bitfields is still a good
  42137. rule we should have in order to make our code independent from compilers and compiler flags.
  42138. * Scripts/webkitpy/style/checkers/cpp.py:
  42139. 2011-05-31 Hironori Bono <hbono@chromium.org>
  42140. Reviewed by Eric Seidel.
  42141. Add a JavaScript function layoutTestController.setTextDirection().
  42142. https://bugs.webkit.org/show_bug.cgi?id=50952
  42143. This change adds a new JavaScript function setTextDirection() to the
  42144. LayoutTestController class of Safari and Chrome to write layout tests
  42145. that changes the text direction of an editable element.
  42146. * DumpRenderTree/LayoutTestController.cpp:
  42147. (setTextDirectionCallback):
  42148. (LayoutTestController::staticFunctions):
  42149. * DumpRenderTree/LayoutTestController.h:
  42150. * DumpRenderTree/chromium/LayoutTestController.cpp:
  42151. (LayoutTestController::LayoutTestController):
  42152. (LayoutTestController::setTextDirection):
  42153. * DumpRenderTree/chromium/LayoutTestController.h:
  42154. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  42155. (LayoutTestController::setTextDirection):
  42156. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  42157. (LayoutTestController::setTextDirection):
  42158. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  42159. (LayoutTestController::setTextDirection):
  42160. 2011-05-31 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
  42161. Reviewed by Simon Hausmann.
  42162. [Qt] User-agent list of Qt test browsers is very outdated
  42163. https://bugs.webkit.org/show_bug.cgi?id=61531
  42164. The user can edit the user-agent manually, so there's no need to have
  42165. a super complete and up to date list, but it's nice to have it
  42166. minimally updated.
  42167. * MiniBrowser/qt/useragentlist.txt:
  42168. * QtTestBrowser/useragentlist.txt:
  42169. 2011-03-30 Martin Robinson <mrobinson@igalia.com>
  42170. Reviewed by Adam Roben.
  42171. [GTK] [WebKit2] Implement a basic WebKitTestRunner
  42172. https://bugs.webkit.org/show_bug.cgi?id=57068
  42173. Add an implementation of WebKitTestRunner for GTK+.
  42174. * Scripts/build-webkittestrunner: Added knowledge of GTK+ TestRunner.
  42175. * Scripts/old-run-webkit-tests: Ditto.
  42176. * Scripts/run-launcher: Ditto.
  42177. * Scripts/webkitdirs.pm: Ditto.
  42178. * WebKitTestRunner/GNUmakefile.am: Added.
  42179. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  42180. * WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp: Added.
  42181. * WebKitTestRunner/InjectedBundle/gtk/InjectedBundleGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  42182. * WebKitTestRunner/InjectedBundle/gtk/LayoutTestControllerGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  42183. * WebKitTestRunner/PlatformWebView.h:
  42184. * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: Added.
  42185. * WebKitTestRunner/gtk/TestControllerGtk.cpp: Added.
  42186. * WebKitTestRunner/gtk/TestInvocationGtk.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  42187. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  42188. * WebKitTestRunner/gtk/main.cpp: Copied from Source/WebKit2/WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp.
  42189. (main): Added.
  42190. 2011-05-31 Dirk Pranke <dpranke@chromium.org>
  42191. Reviewed by Tony Chang.
  42192. new-run-webkit-tests: doesn't wait for children if it gets a ctrl-c
  42193. https://bugs.webkit.org/show_bug.cgi?id=60241
  42194. * Scripts/new-run-webkit-tests:
  42195. 2011-05-31 Eric Seidel <eric@webkit.org>
  42196. Reviewed by David Kilzer.
  42197. webkitpy should create zips with zip -9
  42198. https://bugs.webkit.org/show_bug.cgi?id=61789
  42199. Dave Kilzer suggested we add this to make zips uploaded to bugzilla smaller.
  42200. * Scripts/webkitpy/common/system/workspace.py:
  42201. * Scripts/webkitpy/common/system/workspace_unittest.py:
  42202. 2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  42203. Reviewed by Csaba Osztrogonác.
  42204. [Qt] Implement find feature for QtTestBrowser
  42205. https://bugs.webkit.org/show_bug.cgi?id=61425
  42206. Buildfix for --minimal and CONFIG+=qt_minimal build.
  42207. * QtTestBrowser/launcherwindow.cpp:
  42208. (LauncherWindow::LauncherWindow):
  42209. (LauncherWindow::createChrome):
  42210. * QtTestBrowser/launcherwindow.h:
  42211. 2011-05-31 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  42212. Reviewed by Csaba Osztrogonác.
  42213. [Qt] Implement find feature for QtTestBrowser
  42214. https://bugs.webkit.org/show_bug.cgi?id=61425
  42215. * QtTestBrowser/launcherwindow.cpp:
  42216. (LauncherWindow::LauncherWindow):
  42217. (LauncherWindow::createChrome):
  42218. (LauncherWindow::showFindBar):
  42219. (LauncherWindow::find):
  42220. * QtTestBrowser/launcherwindow.h:
  42221. 2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>
  42222. Reviewed by Martin Robinson.
  42223. [GTK] Implement JavaScript dialogs in MiniBrowser
  42224. https://bugs.webkit.org/show_bug.cgi?id=61725
  42225. * MiniBrowser/gtk/BrowserWindow.c:
  42226. (WKStringGetCString): Helper function to get a UTF-8 c string from
  42227. a WKStringRef.
  42228. (WKURLGetCString): Helper function to get a UTF-8 c string from a
  42229. WKURLRef.
  42230. (browserWindowUpdateURL): Update to use WKURLGetCString.
  42231. (didReceiveTitleForFrame): Update to use WKStringGetCString.
  42232. (createMessageDialog): Create a GtkMessageDialog.
  42233. (runJavaScriptAlert):
  42234. (runJavaScriptConfirm):
  42235. (runJavaScriptPrompt):
  42236. (browserWindowUIClientInit):
  42237. 2011-05-29 Yuta Kitamura <yutak@chromium.org>
  42238. Reviewed by Kent Tamura.
  42239. WebSocket closing handshake
  42240. https://bugs.webkit.org/show_bug.cgi?id=35721
  42241. * Scripts/webkitpy/thirdparty/__init__.py:
  42242. Pull in pywebsocket 0.6b1. We need to update pywebsocket
  42243. to get the right behavior of closing handshake.
  42244. 2011-05-29 Daniel Bates <dbates@rim.com>
  42245. Reviewed by David Kilzer.
  42246. REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
  42247. https://bugs.webkit.org/show_bug.cgi?id=61162
  42248. Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
  42249. that omits a line count. In particular, the chunk range regular expression does
  42250. not match a chunk range line that omits a line count. GNU diff(1) will omit the
  42251. line count in the chunk range if the line count is exactly 1. For example, appending
  42252. a new line to the end of an existing file F that contains exactly one line of text will
  42253. be represented in a diff with a chunk range line that omits the line count for F.
  42254. * Scripts/VCSUtils.pm:
  42255. (parseChunkRange): Added.
  42256. * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
  42257. * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
  42258. - Added unit test "Git: Append new line to the end of an existing file".
  42259. 2011-05-28 Adam Barth <abarth@webkit.org>
  42260. Reviewed by Eric Seidel.
  42261. EWS builds patches that fail to build twice, which seems useless and slows down the bots
  42262. https://bugs.webkit.org/show_bug.cgi?id=55585
  42263. This patch switches all the early warning system bots over to the new
  42264. PatchAnalysisTask-based infrastructure. This patch makes these bots
  42265. more efficient (in the case where patches fail to build) and paves the
  42266. way for running tests on these bots!
  42267. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  42268. * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
  42269. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  42270. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  42271. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  42272. * Scripts/webkitpy/tool/commands/queues.py:
  42273. 2011-05-28 Kenichi Ishibashi <bashi@chromium.org>
  42274. Reviewed by Kent Tamura.
  42275. Add bashi as a committer.
  42276. https://bugs.webkit.org/show_bug.cgi?id=61685
  42277. * Scripts/webkitpy/common/config/committers.py:
  42278. 2011-05-27 Adam Barth <abarth@webkit.org>
  42279. Reviewed by Eric Seidel.
  42280. When checking whether the tree is red, the EWS posts a link to the wrong log
  42281. https://bugs.webkit.org/show_bug.cgi?id=61072
  42282. We need to cache the original script error because that contains the
  42283. failure log we want to upload. If we don't cache that script error,
  42284. self._script_error will get overwritten when we sanity check the clean
  42285. tree (and it also has test failures).
  42286. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  42287. - This testing approach is slightly goofy. We'd like to use
  42288. assertRaisesRegexp, but that's not available until Python 2.7.
  42289. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  42290. 2011-05-27 Jochen Eisinger <jochen@chromium.org>
  42291. Reviewed by Adam Barth.
  42292. Add layoutTestController.setStorageAllowed() to control whether access
  42293. to the localStorage API is enabled via the WebPermissionClient
  42294. https://bugs.webkit.org/show_bug.cgi?id=61581
  42295. * DumpRenderTree/chromium/LayoutTestController.cpp:
  42296. (LayoutTestController::LayoutTestController):
  42297. (LayoutTestController::setStorageAllowed):
  42298. * DumpRenderTree/chromium/LayoutTestController.h:
  42299. * DumpRenderTree/chromium/TestShell.cpp:
  42300. (TestShell::TestShell):
  42301. (TestShell::createNewWindow):
  42302. * DumpRenderTree/chromium/TestShell.h:
  42303. * DumpRenderTree/chromium/WebPermissions.h: Added.
  42304. (WebPermissions::WebPermissions):
  42305. (WebPermissions::allowStorage):
  42306. (WebPermissions::setStorageAllowed):
  42307. (WebPermissions::reset):
  42308. 2011-05-27 Dirk Pranke <dpranke@chromium.org>
  42309. Reviewed by Eric Seidel.
  42310. NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
  42311. https://bugs.webkit.org/show_bug.cgi?id=60326
  42312. This patch removes a lot of the complexity from the
  42313. metered_stream implementation that was unnecessary since there
  42314. was only one caller and the logic could be coordinated better.
  42315. There should be no functional changes in this patch, just code
  42316. getting deleted and cleaned up.
  42317. * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
  42318. * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
  42319. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  42320. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  42321. 2011-05-27 Dirk Pranke <dpranke@chromium.org>
  42322. Reviewed by Eric Seidel.
  42323. NRWT: minor cleanup in printing module
  42324. https://bugs.webkit.org/show_bug.cgi?id=60329
  42325. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  42326. 2011-05-27 Steve Lacey <sjl@chromium.org>
  42327. Reviewed by David Levin.
  42328. Add sjl@chromium.org as a committer.
  42329. https://bugs.webkit.org/show_bug.cgi?id=61672
  42330. * Scripts/webkitpy/common/config/committers.py:
  42331. 2011-05-27 Dirk Pranke <dpranke@chromium.org>
  42332. Reviewed by Adam Barth.
  42333. NRWT: remove --print detailed-progress
  42334. https://bugs.webkit.org/show_bug.cgi?id=60324
  42335. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  42336. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  42337. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  42338. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  42339. 2011-05-27 Dirk Pranke <dpranke@chromium.org>
  42340. Reviewed by Ojan Vafai.
  42341. NRWT: debug messages from the workers are being logged twice
  42342. https://bugs.webkit.org/show_bug.cgi?id=60428
  42343. It looks like when the workers are run in separate processes
  42344. we end up getting two copies of every log message they print.
  42345. This has to do with the multiprocessing module on UNIX cloning
  42346. the log configuration in a way I wasn't expecting, and so two
  42347. log handlers end up getting registered.
  42348. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  42349. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  42350. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  42351. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  42352. 2011-05-27 Adam Roben <aroben@apple.com>
  42353. Always decode tester names from location.hash
  42354. When navigating directly to a tester-specific URL (e.g.,
  42355. <http://build.webkit.org/TestFailures/#/Windows%207%20Release%20(Tests)>), you could end up
  42356. with a URL-encoded tester name in the page, and then the encoded name could make its way
  42357. into Bugzilla bugs. Bad!
  42358. Reviewed by David Kilzer.
  42359. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  42360. (ViewController.prototype.parseHash): Pass the tester name we got from location.hash through
  42361. decodeURIComponent before trying to use it.
  42362. 2011-05-27 Adam Roben <aroben@apple.com>
  42363. Remove testing code that snuck into r87528
  42364. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  42365. (ViewController.prototype._domForNewBugLink): Remove a line I was using for some testing.
  42366. 2011-05-27 Adam Roben <aroben@apple.com>
  42367. Add links to TestFailures to easily file bugs about failing tests
  42368. Fixes <http://webkit.org/b/61636> <rdar://problem/9514886> TestFailures page should have
  42369. links to file bugs for failing tests
  42370. Reviewed by David Kilzer.
  42371. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  42372. (Builder.prototype.resultsPageURL): New helper function to return the URL to results.html
  42373. for a particular build.
  42374. (Builder.prototype._getFailingTests): Use resultsPageURL.
  42375. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  42376. (ViewController.prototype._displayBuilder): Add links to file bugs about each set of
  42377. failures.
  42378. (ViewController.prototype._domForBuildName): Use resultsPageURL.
  42379. (ViewController.prototype._domForNewBugLink): Added. Creates an element that represents the
  42380. new bug link. The bug has a title, description, and URL already filled in for you!
  42381. 2011-05-27 Sheriff Bot <webkit.review.bot@gmail.com>
  42382. Unreviewed, rolling out r87464.
  42383. http://trac.webkit.org/changeset/87464
  42384. https://bugs.webkit.org/show_bug.cgi?id=61643
  42385. client-close/server-close tests are flaky on Chromium Mac and
  42386. Windows (Requested by aklein on #webkit).
  42387. * Scripts/webkitpy/thirdparty/__init__.py:
  42388. 2011-05-27 Alexey Proskuryakov <ap@apple.com>
  42389. Added Douglas Davidson to contributors list for easier CC'ing.
  42390. * Scripts/webkitpy/common/config/committers.py:
  42391. 2011-05-26 Mihai Parparita <mihaip@chromium.org>
  42392. Reviewed by Adam Barth.
  42393. Fix worldID and destinationDomain argument names
  42394. https://bugs.webkit.org/show_bug.cgi?id=61571
  42395. As part of working on r87423, I noticed a couple of inconsistencies in
  42396. argument names:
  42397. - We would use worldId in .h files but worldID in .cpp files.
  42398. Standardize on the latter
  42399. - SecurityOrigin::addOriginAccessWhitelistEntry would take a
  42400. destinationDomains argument, even though the actual parameter was for
  42401. a single domain (renamed to be singular).
  42402. * DumpRenderTree/LayoutTestController.h:
  42403. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  42404. (LayoutTestController::evaluateScriptInIsolatedWorld):
  42405. 2011-05-26 Yuta Kitamura <yutak@chromium.org>
  42406. Reviewed by Kent Tamura.
  42407. WebSocket closing handshake
  42408. https://bugs.webkit.org/show_bug.cgi?id=35721
  42409. * Scripts/webkitpy/thirdparty/__init__.py:
  42410. Pull in pywebsocket 0.6b1. We need to update pywebsocket
  42411. to get the right behavior of closing handshake.
  42412. 2011-05-26 Qi Zhang <qi.2.zhang@nokia.com>
  42413. Reviewed by Andreas Kling.
  42414. WebKitTestRunner needs layoutTestController.setAuthorAndUserStylesEnabled
  42415. https://bugs.webkit.org/show_bug.cgi?id=42676
  42416. Implemented layoutTestController.setAuthorAndUserStylesEnabled for WebKitTestRunner.
  42417. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  42418. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  42419. (WTR::InjectedBundle::beginTesting):
  42420. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  42421. (WTR::LayoutTestController::setAuthorAndUserStylesEnabled):
  42422. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  42423. 2011-05-26 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
  42424. Reviewed by Andreas Kling.
  42425. [Qt] QtTestBrowser "Switch User Agent" dialog is broken
  42426. https://bugs.webkit.org/show_bug.cgi?id=61527
  42427. The setMaximumHeight() call is unecessary and breaks the dialog at
  42428. least on my setup.
  42429. * QtTestBrowser/launcherwindow.cpp:
  42430. (LauncherWindow::showUserAgentDialog):
  42431. 2011-05-02 Robert Hogan <robert@webkit.org>
  42432. Reviewed by Adam Roben.
  42433. [Qt] Allow popup windows from plugins when initiated by a user gesture
  42434. https://bugs.webkit.org/show_bug.cgi?id=41292
  42435. Support parameters introduced in plugin-initiate-popup-window.html
  42436. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  42437. (webkit_test_plugin_new_instance):
  42438. (webkit_test_plugin_handle_event):
  42439. 2011-05-26 Mihai Parparita <mihaip@chromium.org>
  42440. Reviewed by Adam Barth.
  42441. Support cross-origin XMLHttpRequest in isolated worlds
  42442. https://bugs.webkit.org/show_bug.cgi?id=59843
  42443. Expose setIsolatedWorldSecurityOrigin in LayoutTestController.
  42444. * DumpRenderTree/chromium/LayoutTestController.cpp:
  42445. (LayoutTestController::LayoutTestController):
  42446. (LayoutTestController::setIsolatedWorldSecurityOrigin):
  42447. * DumpRenderTree/chromium/LayoutTestController.h:
  42448. 2011-05-25 Brian Weinstein <bweinstein@apple.com>
  42449. Reviewed by Adam Roben.
  42450. WebKit2: Status bar, toolbar, and menu bar checks should be in the injected bundle
  42451. https://bugs.webkit.org/show_bug.cgi?id=61474
  42452. <rdar://problem/9468337>
  42453. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  42454. (WTR::InjectedBundlePage::InjectedBundlePage): Add empty entries in the WKBundlePageUIClient.
  42455. 2011-05-26 Andreas Kling <kling@webkit.org>
  42456. Unreviewed, correct address to webkit-committers mailing list.
  42457. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  42458. 2011-05-25 Adam Roben <aroben@apple.com>
  42459. Don't assume that builds finish in the order they were started
  42460. Fixes <http://webkit.org/b/61464> TestFailures page shows failures from a not-most-recent
  42461. build when one slave is taking a long time to finish a build
  42462. Reviewed by Antti Koivisto.
  42463. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  42464. (Builder.prototype.getMostRecentCompletedBuildNumber): Don't assume that all builds that are
  42465. newer than the oldest in-progress build are also themselves in progress. Just check whether
  42466. each build is actually in progress (as signified by its presence in the currentBuilds set).
  42467. 2011-05-25 Adam Roben <aroben@apple.com>
  42468. Correctly detect cases where only a single test failed/crashed/timed out
  42469. Fixes <http://webkit.org/b/61463> TestFailures page doesn't show testers with only a single
  42470. failing test
  42471. Reviewed by Darin Adler.
  42472. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  42473. (Builder.prototype.getNumberOfFailingTests): Don't require "test cases" to be plural. It
  42474. will be singular when only a single test fails/crashes/times out.
  42475. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  42476. (ViewController.prototype._displayTesters): Only pluralize "test" when more than one test
  42477. failed/crashed/timed out.
  42478. 2011-05-26 Tom Hudson <tomhudson@google.com>
  42479. Reviewed by Tony Chang.
  42480. Add flags to Chromium ImageDiff to write image comparison metrics on
  42481. stdout.
  42482. https://bugs.webkit.org/show_bug.cgi?id=60569
  42483. * DumpRenderTree/chromium/ImageDiff.cpp:
  42484. (Image::createFromStdin): Fix spelling.
  42485. (maxOf3): New function to do 3-way maximum.
  42486. (getRedComponent): Extract red component from ABGR packed encoding.
  42487. (getGreenComponent): Extract green component from ABGR packed encoding.
  42488. (getBlueComponent): Extract blue component from ABGR packed encoding.
  42489. (weightedPercentageDifferent): Determine % of pixels different in two
  42490. images multiplied by intensity difference of each pixel.
  42491. (printHelp): Document new arguments.
  42492. (compareImages): Parameterize.
  42493. (untestedCompareImages): Parameterize.
  42494. (diffImages): Parameterize; write results on stdout if requested.
  42495. (main): Parse new arguments.
  42496. 2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
  42497. Reviewed by Simon Hausmann.
  42498. WebKitTestRunner needs layoutTestController.setPrivateBrowsingEnabled
  42499. https://bugs.webkit.org/show_bug.cgi?id=42697
  42500. Implemented layoutTestController.setPrivateBrowsingEnabled for WebKitTestRunner.
  42501. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  42502. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  42503. (WTR::InjectedBundle::beginTesting):
  42504. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  42505. (WTR::LayoutTestController::setPrivateBrowsingEnabled):
  42506. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  42507. 2011-05-25 Jon Honeycutt <jhoneycutt@apple.com>
  42508. REGRESSION (WebKit2): Crash in Flash on USA Today photo gallery
  42509. https://bugs.webkit.org/show_bug.cgi?id=61428
  42510. <rdar://problem/9457006>
  42511. Reviewed by Adam Roben.
  42512. The crash occurs when Flash posts a message to a window that it
  42513. creates, and in processing the message, it calls NPN_Evaluate to
  42514. evaluate JavaScript that removes the plug-in from the page. Flash then
  42515. crashes when we return to Flash code.
  42516. This test emulates that behavior.
  42517. * DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Added.
  42518. (CallJSThatDestroysPlugin::CallJSThatDestroysPlugin):
  42519. Initialize member vars.
  42520. (CallJSThatDestroysPlugin::~CallJSThatDestroysPlugin):
  42521. Remove our custom property from the message window, and destroy it.
  42522. (CallJSThatDestroysPlugin::NPP_Destroy):
  42523. Set m_isDestroyed, log that the plug-in was destroyed, and notify the
  42524. layout test controller that we're done.
  42525. (wndProc):
  42526. Get the PluginTest object, and call its runTest() function.
  42527. (CallJSThatDestroysPlugin::NPP_New):
  42528. Setup the test: register a class for the message-only window, create
  42529. it, and post a message to it to run the test.
  42530. (CallJSThatDestroysPlugin::runTest):
  42531. Execute JS that removes the plug-in from the page, and if we're not
  42532. destroyed, log a success message.
  42533. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  42534. Add new test to project.
  42535. 2011-05-25 Tony Chang <tony@chromium.org>
  42536. Reviewed by Adam Barth.
  42537. webkitpy's NetworkTransaction shouldn't use mechanize
  42538. https://bugs.webkit.org/show_bug.cgi?id=61450
  42539. mechanize.HTTPError is just an alias for urllib2.HTTPError, so
  42540. use urllib2 directly. Re-add NetworkTransaction to
  42541. test_results_uploader.py (reverting r87124).
  42542. * Scripts/webkitpy/common/net/networktransaction.py:
  42543. * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
  42544. 2011-05-25 Kevin Ollivier <kevino@theolliviers.com>
  42545. [Chromium] Unreviewed build fix. Do not define WTF/JS_EXPORT_PRIVATE to JS_EXPORTDATA
  42546. until the port begins using those export macros.
  42547. * DumpRenderTree/chromium/config.h:
  42548. 2011-05-25 Sheriff Bot <webkit.review.bot@gmail.com>
  42549. Unreviewed, rolling out r87257.
  42550. http://trac.webkit.org/changeset/87257
  42551. https://bugs.webkit.org/show_bug.cgi?id=61457
  42552. This broke layout tests, see bug 61431. (Requested by
  42553. hwennborg on #webkit).
  42554. * DumpRenderTree/chromium/LayoutTestController.cpp:
  42555. (LayoutTestController::LayoutTestController):
  42556. (LayoutTestController::clearAllDatabases):
  42557. * DumpRenderTree/chromium/LayoutTestController.h:
  42558. 2011-05-25 Qi Zhang <qi.2.zhang@nokia.com>
  42559. Reviewed by Andreas Kling.
  42560. [Qt] fast/css/disabled-author-styles.html failed
  42561. https://bugs.webkit.org/show_bug.cgi?id=61438
  42562. Implemented API setAuthorAndUserStylesEnabled in LayoutTestControllerQt.
  42563. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  42564. (WebCore::WebPage::resetSettings):
  42565. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  42566. (LayoutTestController::setAuthorAndUserStylesEnabled):
  42567. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  42568. 2011-05-25 Adam Roben <aroben@apple.com>
  42569. Identify, rather than skip, builds where run-webkit-tests exited early due to too many failures
  42570. Fixes <http://webkit.org/b/61441> TestFailures page should show when run-webkit-tests
  42571. started exiting early due to too many crashes, timeouts, or failures
  42572. Reviewed by David Kilzer.
  42573. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  42574. (Builder.prototype.getNumberOfFailingTests): Rather than returning -1 ("unknown") when
  42575. run-webkit-tests exits early due to too many failures, pass that information in another
  42576. argument to the callback.
  42577. (Builder.prototype.startFetchingBuildHistory): Updated the documentation comment to reflect
  42578. the new structure of the object passed to the callback.
  42579. (Builder.prototype._getFailingTests): Updated to expect a tooManyFailures boolean from
  42580. getNumberOfFailingTests and to pass that along to our own callbacks.
  42581. (Builder.prototype._incorporateBuildHistory): Updated to expect a tooManyFailures boolean
  42582. from _getFailingTests and to store that value in the history object.
  42583. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  42584. (.info): Added.
  42585. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  42586. (ViewController.prototype._displayBuilder): Updated for change in structure to the history
  42587. object and to add a note when run-webkit-tests exited early due to too many failures.
  42588. (ViewController.prototype._displayTesters): Renamed testersAndFailureCounts to
  42589. latestBuildInfos since each entry now contains more than just the tester and failure count.
  42590. Now displays a message for testers where the latest build exited early due to too many
  42591. failures. Updated to expect a tooManyFailures boolean from getNumberOfFailingTests and to
  42592. store that value in latestBuildInfos.
  42593. 2011-05-24 Keishi Hattori <keishi@webkit.org>
  42594. Reviewed by Kent Tamura.
  42595. Disable textfield implementation of <input type=color>. Add INPUT_COLOR feature flag. Add input color sanitizer.
  42596. https://bugs.webkit.org/show_bug.cgi?id=61273
  42597. * Scripts/build-webkit: Added INPUT_COLOR feature flag.
  42598. 2011-05-24 Greg Simon <gregsimon@chromium.org>
  42599. Reviewed by Dimitri Glazkov.
  42600. Control Indexeddb backends from LayoutTestController
  42601. https://bugs.webkit.org/show_bug.cgi?id=61000
  42602. * DumpRenderTree/chromium/LayoutTestController.cpp:
  42603. (LayoutTestController::LayoutTestController):
  42604. (LayoutTestController::setOverrideIndexedDBBackingStore):
  42605. (LayoutTestController::clearAllDatabases):
  42606. * DumpRenderTree/chromium/LayoutTestController.h:
  42607. 2011-05-24 Robert Hogan <robert@webkit.org>
  42608. Reviewed by Ryosuke Niwa.
  42609. [Qt] Fix fast/events/selectstart-by-single-click-with-shift.html
  42610. https://bugs.webkit.org/show_bug.cgi?id=61393
  42611. * DumpRenderTree/qt/EventSenderQt.h:
  42612. * DumpRenderTree/qt/EventSenderQt.cpp:
  42613. (getModifiers): static function for interpreting modifiers
  42614. (EventSender::mouseDown): Respect keyboard modifiers
  42615. (EventSender::keyDown): use new static function
  42616. (EventSender::sendOrQueueEvent): whitespace fix
  42617. 2011-05-24 Jay Civelli <jcivelli@chromium.org>
  42618. Reviewed by Adam Barth.
  42619. Adding MHTML reading support.
  42620. https://bugs.webkit.org/show_bug.cgi?id=7168
  42621. * Scripts/build-webkit:
  42622. * Scripts/old-run-webkit-tests:
  42623. * Scripts/webkitperl/features.pm:
  42624. * Scripts/webkitpy/layout_tests/port/test_files.py:
  42625. * Scripts/webkitpy/layout_tests/port/webkit.py:
  42626. 2011-05-24 Stephen White <senorblanco@chromium.org>
  42627. Reviewed by Kenneth Russell.
  42628. Remove most style checks on Source/ThirdParty/glu, since it doesn't
  42629. follow WebKit style.
  42630. https://bugs.webkit.org/show_bug.cgi?id=61365
  42631. * Scripts/webkitpy/style/checker.py:
  42632. 2011-05-24 Adam Roben <aroben@apple.com>
  42633. Don't allow forcing builds through the build.webkit.org web interface
  42634. Someone has been forcing bogus builds.
  42635. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  42636. 2011-05-24 Qi Zhang <qi.2.zhang@nokia.com>
  42637. Reviewed by Adam Roben.
  42638. WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
  42639. https://bugs.webkit.org/show_bug.cgi?id=42669
  42640. Fixes the regression issue caused by patch 94265. The patch didn't intialize the setting before the
  42641. layouttest starting, it will make the test cases after editing/execCommand/clipboard-access.html failed.
  42642. Because that case changed the setting.
  42643. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  42644. (WTR::InjectedBundle::beginTesting):
  42645. 2011-05-24 Csaba Osztrogonác <ossy@webkit.org>
  42646. Reviewed by Kenneth Rohde Christiansen.
  42647. [ORWT]Make --skipped=only option work with parameters with LayoutTests/ prefix
  42648. https://bugs.webkit.org/show_bug.cgi?id=61052
  42649. * Scripts/old-run-webkit-tests:
  42650. 2011-05-24 Adam Roben <aroben@apple.com>
  42651. Make TestFailures show how many tests are failing on each tester, and omit testers with no failures
  42652. Fixes <http://webkit.org/b/61063> <rdar://problem/9460533> TestFailures page shows testers
  42653. that don't have any failing tests, which isn't useful
  42654. Reviewed by David Kilzer.
  42655. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js:
  42656. (Buildbot.prototype.getTesters): Renamed from getTesterNames. Now returns Builder objects
  42657. instead of name strings.
  42658. (Buildbot.prototype._buildersForNames): Added. Helper function to convert an array of
  42659. builder names into an array of builders.
  42660. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js:
  42661. (Builder.prototype.getMostRecentCompletedBuildNumber): Added. Returns the build number of
  42662. the most recently completed build, or -1 if there is no such build.
  42663. (Builder.prototype.getNumberOfFailingTests): Added. Returns the number of tests that failed
  42664. in the given build, or -1 if the number could not be determined. Some of this code came from
  42665. _getFailingTests.
  42666. (Builder.prototype._getBuildJSON): Added. Code came from _getFailingTests.
  42667. (Builder.prototype._getFailingTests): Changed to use new _getBuildJSON and
  42668. getNumberOfFailingTests functions.
  42669. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:
  42670. (ViewController.prototype._displayTesters): Get the current number of test failures for each
  42671. tester and show it in the list. Omit testers that have no failures at all. We keep the
  42672. testers and failure counts in an array and sort it before displaying the current data, as
  42673. the order in which data will be fetched is unpredictable.
  42674. 2011-05-23 Tony Chang <tony@chromium.org>
  42675. Reviewed by Ojan Vafai.
  42676. [nrwt] don't use NetworkTranslation when uploading results
  42677. https://bugs.webkit.org/show_bug.cgi?id=61315
  42678. This avoids autoinstalling mechanize. It didn't matter anyway
  42679. because test_results_uploader.py wasn't using mechanize to make the
  42680. request so NetworkTransaction::run wasn't doing anything extra
  42681. (it only matters if it catches mechanize.HTTPError).
  42682. * Scripts/webkitpy/layout_tests/layout_package/test_results_uploader.py:
  42683. 2011-05-23 Tony Chang <tony@chromium.org>
  42684. Reviewed by Dirk Pranke.
  42685. [chromium] fix the rebaseline tool to work with Linux GPU failures
  42686. https://bugs.webkit.org/show_bug.cgi?id=61312
  42687. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  42688. 2011-05-23 Darin Adler <darin@apple.com>
  42689. Ignore generated .pyc files in a directory full of python code.
  42690. * Scripts/webkitpy/common/checkout/scm: Added property svn:ignore.
  42691. 2011-05-23 Adam Barth <abarth@webkit.org>
  42692. Reviewed by Eric Seidel.
  42693. sheriffbot should give more details about the failures in IRC
  42694. https://bugs.webkit.org/show_bug.cgi?id=61233
  42695. With this patch, sheriffbot will annonce the set of failing tests,
  42696. which might help folks triage the problem.
  42697. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  42698. * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  42699. 2011-05-23 Sheriff Bot <webkit.review.bot@gmail.com>
  42700. Unreviewed, rolling out r87078.
  42701. http://trac.webkit.org/changeset/87078
  42702. https://bugs.webkit.org/show_bug.cgi?id=61294
  42703. Patch contains errors and seems likely to break a bunch of
  42704. bots (Requested by abarth on #webkit).
  42705. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  42706. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  42707. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  42708. 2011-05-23 Alice Boxhall <aboxhall@chromium.org>
  42709. Reviewed by Ojan Vafai.
  42710. Convert json_results_generator.py to output version 4 JSON.
  42711. https://bugs.webkit.org/show_bug.cgi?id=60869
  42712. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  42713. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  42714. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  42715. 2011-05-23 Patrick Gansterer <paroga@webkit.org>
  42716. Reviewed by Adam Barth.
  42717. Move generation of shell_command from port to executive
  42718. https://bugs.webkit.org/show_bug.cgi?id=61251
  42719. After move it's possible to use the code in other places too.
  42720. * Scripts/webkitpy/common/config/ports.py:
  42721. * Scripts/webkitpy/common/system/executive.py:
  42722. 2011-05-23 Qi Zhang <qi.2.zhang@nokia.com>
  42723. Reviewed by Darin Adler.
  42724. WebKitTestRunner needs layoutTestController.setJavaScriptCanAccessClipboard
  42725. https://bugs.webkit.org/show_bug.cgi?id=42669
  42726. Implement setJavaScriptCanAccessClipboard in WebKitTestRunner.
  42727. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  42728. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  42729. (WTR::LayoutTestController::setJavaScriptCanAccessClipboard):
  42730. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  42731. 2011-05-22 Robert Hogan <robert@webkit.org>
  42732. Reviewed by Kenneth Rohde Christiansen.
  42733. Fix policyDelegate in Qt DRT
  42734. https://bugs.webkit.org/show_bug.cgi?id=61247
  42735. Use the 'policy delegate' implemented in FrameLoaderClient
  42736. for layout tests. The partial implementation in DumpRenderTreeQt
  42737. is redundant, so remove it.
  42738. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  42739. (WebCore::WebPage::acceptNavigationRequest):
  42740. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  42741. (LayoutTestController::waitForPolicyDelegate):
  42742. 2011-05-22 Patrick Gansterer <paroga@webkit.org>
  42743. Reviewed by Darin Adler.
  42744. Use double quotes for filename arguments
  42745. https://bugs.webkit.org/show_bug.cgi?id=61250
  42746. Windows does not support single quotes on the command line,
  42747. so replace them with double quotes.
  42748. * Scripts/prepare-ChangeLog:
  42749. 2011-05-20 Simon Fraser <simon.fraser@apple.com>
  42750. Reviewed by Sam Weinig.
  42751. WebKitTestRunner needs layoutTestController.pauseTransitionAtTimeOnElementWithId
  42752. https://bugs.webkit.org/show_bug.cgi?id=42550
  42753. Implement pauseTransitionAtTimeOnElementWithId in WebKitTestRunner.
  42754. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  42755. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  42756. Copy the code for pausing animations, FIXME comments and all.
  42757. (WTR::LayoutTestController::pauseTransitionAtTimeOnElementWithId):
  42758. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  42759. 2011-05-20 Alok Priyadarshi <alokp@chromium.org>
  42760. Reviewed by Stephen White.
  42761. Adding myself to the committers list.
  42762. * Scripts/webkitpy/common/config/committers.py:
  42763. 2011-05-19 Adam Roben <aroben@apple.com>
  42764. Test that the WebKit2 UI process doesn't crash when starting a download
  42765. Test for <http://webkit.org/b/61142> <rdar://problem/9471680> REGRESSION (r86812): Crash
  42766. (preceded by assertion) in fastMalloc when downloading a file
  42767. Reviewed by Darin Adler.
  42768. * TestWebKitAPI/Tests/WebKit2/18-characters.html: Added.
  42769. * TestWebKitAPI/Tests/WebKit2/DownloadDecideDestinationCrash.cpp: Added.
  42770. (TestWebKitAPI::decidePolicyForNavigationAction): Start a download.
  42771. (TestWebKitAPI::decideDestinationWithSuggestedFilename): Record that the download was
  42772. started, cancel the download, and return a bogus string.
  42773. (TestWebKitAPI::setContextDownloadClient):
  42774. (TestWebKitAPI::setPagePolicyClient):
  42775. Simple helper functions.
  42776. (TestWebKitAPI::TEST): Load 18-characters.html, which should trigger a download thanks to
  42777. our policy client, and run until we know that the download was started. If we haven't
  42778. crashed, we win!
  42779. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  42780. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  42781. * TestWebKitAPI/win/copy-resources.cmd:
  42782. Added new files.
  42783. 2011-05-20 Kent Tamura <tkent@chromium.org>
  42784. Reviewed by Ryosuke Niwa.
  42785. Fix style errors in DumpRenderTree/chromium/.
  42786. https://bugs.webkit.org/show_bug.cgi?id=61172
  42787. * DumpRenderTree/chromium/CppBoundClass.cpp:
  42788. (CppBoundClass::getAsCppVariant):
  42789. (CppBoundClass::bindToJavascript):
  42790. * DumpRenderTree/chromium/CppBoundClass.h:
  42791. (CppBoundClass::GetterCallback::~GetterCallback):
  42792. (CppBoundClass::CppBoundClass):
  42793. (CppBoundClass::Callback::~Callback):
  42794. (CppBoundClass::MemberCallback::MemberCallback):
  42795. (CppBoundClass::MemberCallback::~MemberCallback):
  42796. (CppBoundClass::MemberGetterCallback::MemberGetterCallback):
  42797. (CppBoundClass::MemberGetterCallback::~MemberGetterCallback):
  42798. * DumpRenderTree/chromium/CppVariant.h:
  42799. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  42800. (DRTDevToolsAgent::~DRTDevToolsAgent):
  42801. * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  42802. (DRTDevToolsClient::sendFrontendLoaded):
  42803. * DumpRenderTree/chromium/DRTDevToolsClient.h:
  42804. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  42805. (main):
  42806. * DumpRenderTree/chromium/EventSender.cpp:
  42807. (SavedEvent::SavedEvent):
  42808. (EventSender::EventSender):
  42809. (EventSender::keyDown):
  42810. * DumpRenderTree/chromium/EventSender.h:
  42811. * DumpRenderTree/chromium/ImageDiff.cpp:
  42812. (Image::Image):
  42813. * DumpRenderTree/chromium/LayoutTestController.cpp:
  42814. (LayoutTestController::LayoutTestController):
  42815. (LayoutTestController::WorkQueue::reset):
  42816. (WorkItemBackForward::WorkItemBackForward):
  42817. (WorkItemLoadingScript::WorkItemLoadingScript):
  42818. (WorkItemNonLoadingScript::WorkItemNonLoadingScript):
  42819. (WorkItemLoad::WorkItemLoad):
  42820. (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
  42821. (LayoutTestController::pathToLocalResource):
  42822. * DumpRenderTree/chromium/LayoutTestController.h:
  42823. (LayoutTestController::WorkItem::~WorkItem):
  42824. (LayoutTestController::WorkQueue::WorkQueue):
  42825. * DumpRenderTree/chromium/MockSpellCheck.cpp:
  42826. (MockSpellCheck::MockSpellCheck):
  42827. (MockSpellCheck::~MockSpellCheck):
  42828. * DumpRenderTree/chromium/MockSpellCheck.h:
  42829. * DumpRenderTree/chromium/NotificationPresenter.h:
  42830. (NotificationPresenter::NotificationPresenter):
  42831. * DumpRenderTree/chromium/Task.cpp:
  42832. (WebTask::WebTask):
  42833. * DumpRenderTree/chromium/Task.h:
  42834. (TaskList::TaskList):
  42835. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  42836. (DRTPrinter::DRTPrinter):
  42837. (TestShellPrinter::TestShellPrinter):
  42838. * DumpRenderTree/chromium/TestNavigationController.cpp:
  42839. (TestNavigationEntry::TestNavigationEntry):
  42840. (TestNavigationEntry::~TestNavigationEntry):
  42841. (TestNavigationController::TestNavigationController):
  42842. (TestNavigationController::reload):
  42843. (TestNavigationController::loadEntry):
  42844. (TestNavigationController::didNavigateToEntry):
  42845. * DumpRenderTree/chromium/TestNavigationController.h:
  42846. (TestShellExtraData::TestShellExtraData):
  42847. * DumpRenderTree/chromium/TestShell.cpp:
  42848. (dumpHistoryItem):
  42849. * DumpRenderTree/chromium/TestShell.h:
  42850. (TestParams::TestParams):
  42851. * DumpRenderTree/chromium/TestShellWin.cpp:
  42852. (TestShell::waitTestFinished):
  42853. * DumpRenderTree/chromium/TestWebWorker.h:
  42854. (TestWebWorker::startWorkerContext):
  42855. (TestWebWorker::terminateWorkerContext):
  42856. (TestWebWorker::postMessageToWorkerContext):
  42857. (TestWebWorker::clientDestroyed):
  42858. (TestWebWorker::postMessageToWorkerObject):
  42859. (TestWebWorker::postExceptionToWorkerObject):
  42860. (TestWebWorker::postConsoleMessageToWorkerObject):
  42861. (TestWebWorker::confirmMessageFromWorkerObject):
  42862. (TestWebWorker::reportPendingActivity):
  42863. (TestWebWorker::workerContextClosed):
  42864. (TestWebWorker::~TestWebWorker):
  42865. * DumpRenderTree/chromium/TextInputController.cpp:
  42866. * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
  42867. * DumpRenderTree/chromium/WebThemeEngineDRTMac.h:
  42868. * DumpRenderTree/chromium/WebThemeEngineDRTWin.cpp:
  42869. (WebThemeEngineDRTWin::paintButton):
  42870. (WebThemeEngineDRTWin::paintMenuList):
  42871. (WebThemeEngineDRTWin::paintTrackbar):
  42872. * DumpRenderTree/chromium/WebThemeEngineDRTWin.h:
  42873. (WebThemeEngineDRTWin::WebThemeEngineDRTWin):
  42874. * DumpRenderTree/chromium/WebViewHost.cpp:
  42875. (WebViewHost::navigate):
  42876. (WebViewHost::updateSessionHistory):
  42877. (WebViewHost::paintInvalidatedRegion):
  42878. * DumpRenderTree/chromium/WebViewHost.h:
  42879. 2011-05-19 Dmitry Lomov <dslomov@google.com>
  42880. Reviewed by Adam Roben.
  42881. Detect hangs in run-api-tests
  42882. https://bugs.webkit.org/show_bug.cgi?id=48043
  42883. * Scripts/run-api-tests: Added test timeouts
  42884. 2011-05-19 Dmitry Lomov <dslomov@google.com>
  42885. Reviewed by Adam Roben.
  42886. run-api-tests should run one test per process
  42887. https://bugs.webkit.org/show_bug.cgi?id=61088
  42888. * Scripts/run-api-tests: Resurrecting the previous revison of this file, with fixes to system call under Windows,
  42889. return code, and parsing GTest output format.
  42890. 2011-05-15 Robert Hogan <robert@webkit.org>
  42891. Reviewed by Antonio Gomes.
  42892. [Qt][GTK] plugins/get-url-with-javascript-url.html fails
  42893. https://bugs.webkit.org/show_bug.cgi?id=60834
  42894. Fix unix test plugin for plugins/get-url-with-javascript-url.html
  42895. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  42896. (webkit_test_plugin_new_stream):
  42897. (webkit_test_plugin_write_ready):
  42898. (webkit_test_plugin_write):
  42899. 2011-05-19 Sheriff Bot <webkit.review.bot@gmail.com>
  42900. Unreviewed, rolling out r86869, r86873, r86875, and r86877.
  42901. http://trac.webkit.org/changeset/86869
  42902. http://trac.webkit.org/changeset/86873
  42903. http://trac.webkit.org/changeset/86875
  42904. http://trac.webkit.org/changeset/86877
  42905. https://bugs.webkit.org/show_bug.cgi?id=61139
  42906. broke builds and debug DRT (Requested by rniwa on #webkit).
  42907. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  42908. * DumpRenderTree/chromium/TestShell.cpp:
  42909. (TestShell::bindJSObjectsToWindow):
  42910. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  42911. (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]):
  42912. 2011-05-18 Dimitri Glazkov <dglazkov@chromium.org>
  42913. Reviewed by Darin Adler.
  42914. Add build logistics and plumbing for window.internals object.
  42915. https://bugs.webkit.org/show_bug.cgi?id=60313
  42916. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added linking new WebCoreTestSupport library.
  42917. * DumpRenderTree/chromium/TestShell.cpp:
  42918. (TestShell::bindJSObjectsToWindow): Added injection code.
  42919. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  42920. (-[FrameLoadDelegate didClearWindowObjectInStandardWorldForFrame:]): Ditto.
  42921. 2011-05-19 Zsolt Fehér <h490267@stud.u-szeged.hu>
  42922. Reviewed by Csaba Osztrogonác.
  42923. [Qt] Implement eventSender.scalePageBy
  42924. https://bugs.webkit.org/show_bug.cgi?id=60015
  42925. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  42926. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  42927. * DumpRenderTree/qt/EventSenderQt.cpp:
  42928. (EventSender::scalePageBy):
  42929. * DumpRenderTree/qt/EventSenderQt.h:
  42930. 2011-05-19 Kenichi Ishibashi <bashi@chromium.org>
  42931. Reviewed by Kent Tamura.
  42932. [Chromium] IME candidate window appears wrong position in an iframe
  42933. https://bugs.webkit.org/show_bug.cgi?id=61023
  42934. Call the focused frame's firstRectForCharacterRange() instead of the
  42935. main frame so that DRT behaves as the same as Chromium.
  42936. * DumpRenderTree/chromium/TextInputController.cpp:
  42937. (TextInputController::firstRectForCharacterRange):
  42938. 2011-05-18 Adam Roben <aroben@apple.com>
  42939. Add a new page to build.webkit.org to help find when tests started failing
  42940. The page is accessible at <http://build.webkit.org/TestFailures/>. It is pretty minimalist
  42941. right now, but already shows some useful information. It's somewhat similar to webkit-patch
  42942. failure-reason and sheriffbot, and perhaps can be combined with them eventually. It's a
  42943. little more convenient than either of them, though, because it's all done in the browser
  42944. (and thus it's easy to go directly to the relevant test results).
  42945. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Buildbot.js: Added.
  42946. (Buildbot): This class represents a Buildbot server.
  42947. (Buildbot.prototype.buildURL): Returns the URL for the summary page for a particular build.
  42948. (Buildbot.prototype.builderNamed): Returns a Builder with the given name.
  42949. (Buildbot.prototype.getTesterNames): Fetches the names of all testers and passes them to the
  42950. callback.
  42951. (Buildbot.prototype.parseBuildName): Breaks up a build name into its constituent parts. Must
  42952. be implemented by a derived class that understands this server's build naming scheme.
  42953. (Buildbot.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
  42954. particular build.
  42955. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Builder.js: Added.
  42956. (Builder): This class represents one builder on the buildbot.
  42957. (Builder.prototype.buildURL): Returns the URL for the summary page for a particular build.
  42958. (Builder.prototype.failureDiagnosisTextAndURL): Returns data that provides a little more
  42959. information about a particular test failure.
  42960. (Builder.prototype.startFetchingBuildHistory): Periodically calls the callback with
  42961. information about when tests started failing.
  42962. (Builder.prototype.resultsDirectoryURL): Returns the URL for the results directory for a
  42963. particular build.
  42964. (Builder.prototype._getBuildNames): Fetches the names of all builds and passes them to the
  42965. callback.
  42966. (Builder.prototype._getFailingTests): Fetches the results.html page for the given build and
  42967. extracts all the failing tests listed in it, passing them to the callback.
  42968. (Builder.prototype._incorporateBuildHistory): Gets the failing tests for the specified
  42969. build, merges them into the build history, and calls the callback telling it whether the
  42970. next build should be fetched to provide more information.
  42971. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/TestFailures.css:
  42972. Added. Just some simple styles.
  42973. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js: Added.
  42974. (createDefinitionList): Takes an array of pairs and turns them into a DL element.
  42975. (getResource): Wrapper around XMLHttpRequest.
  42976. (Array.prototype.findFirst): Finds the first element matching the given predicate and
  42977. returns it.
  42978. (Array.prototype.last): Returns the last element of the array.
  42979. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js: Added.
  42980. (ViewController): This class contains the main logic for displaying the page.
  42981. (ViewController.loaded): Just calls through to parseHash.
  42982. (ViewController.parseHash): Either starts analyzing failures on a particular builder, or
  42983. shows the list of all testers so one can be chosen. This function is called when the page
  42984. loads and whenever we get a hashchange event.
  42985. (ViewController._displayBuilder): Asks the builder to fetch build history, and displays it
  42986. as it is fetched. The display ends up grouping tests by when they started failing.
  42987. (ViewController._displayTesters): Gets the list of testers and displays it.
  42988. (ViewController._domForBuildName):
  42989. (ViewController._domForFailedTest):
  42990. Helper functions to create descriptions and links for a particular build or failed test.
  42991. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/WebKitBuildbot.js: Added.
  42992. (WebKitBuildbot): Calls up to the base class constructor with the correct base URL.
  42993. (WebKitBuildbot.prototype.parseBuildName): Parses a build.webkit.org-style build name.
  42994. * BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/index.html: Added. Just
  42995. loads all the files and sets up a ViewController, which does the rest.
  42996. * BuildSlaveSupport/build.webkit.org-config/templates/root.html: Added a link to the new
  42997. page.
  42998. 2011-05-18 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  42999. Reviewed by Csaba Osztrogonác.
  43000. [Qt] Implement layoutTestController.setValueForUser()
  43001. https://bugs.webkit.org/show_bug.cgi?id=60956
  43002. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  43003. (LayoutTestController::setValueForUser):
  43004. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  43005. 2011-05-16 Robert Hogan <robert@webkit.org>
  43006. Reviewed by Kenneth Rohde Christiansen.
  43007. plugins/invalidate_rect.html fails on linux ports
  43008. - Make the unix test netscape plugin recognize the onPaintEvent
  43009. and windowedPlugin parameters.
  43010. https://bugs.webkit.org/show_bug.cgi?id=54051
  43011. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  43012. (handleEventX11):
  43013. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  43014. (LayoutTestController::displayInvalidatedRegion):
  43015. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  43016. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  43017. (webkit_test_plugin_new_instance):
  43018. (webkit_test_plugin_handle_event):
  43019. 2011-05-17 Tony Chang <tony@chromium.org>
  43020. Reviewed by Ojan Vafai.
  43021. [chromium] move Lucid 64 bit results into LayoutTests/platform/chromium-linux
  43022. https://bugs.webkit.org/show_bug.cgi?id=60895
  43023. Update the tools to handle the move. Lucid 32 results now go in
  43024. chromium-linux-x86 and the default platform on Linux is now x86_64.
  43025. * Scripts/webkitpy/layout_tests/deduplicate_tests.py: Default to x86_64
  43026. * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  43027. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py: Default to Lucid
  43028. * Scripts/webkitpy/layout_tests/port/base.py: ditto
  43029. * Scripts/webkitpy/layout_tests/port/chromium_linux.py: Update directory fallback and default to Lucid 64
  43030. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  43031. * Scripts/webkitpy/layout_tests/port/test.py: Update tests to default to x86_64
  43032. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Update bot names.
  43033. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py: Whitespace cleanup.
  43034. 2011-05-17 Adam Roben <aroben@apple.com>
  43035. Make run-api-tests work on Windows when there are spaces in the path
  43036. Fixes <http://webkit.org/b/60954> REGRESSION (r86511): run-api-tests fails if there are
  43037. spaces in the path to TestWebKitAPI.exe
  43038. Reviewed by David Levin.
  43039. * Scripts/run-api-tests:
  43040. (runTestTool): Use the "direct object" form of system() to avoid having the path to
  43041. TestWebKitAPI.exe be split by the shell.
  43042. 2011-05-16 Ian Henderson <ianh@apple.com>
  43043. Reviewed by Joseph Pecoraro.
  43044. Page::goToItem doesn't work while loading is deferred
  43045. https://bugs.webkit.org/show_bug.cgi?id=60412
  43046. Add setDefersLoading and goBack methods to LayoutTestController. We
  43047. need to use goBack() instead of history.back() because the latter goes
  43048. through NavigationScheduler, hence doesn't exhibit the bug.
  43049. * DumpRenderTree/LayoutTestController.cpp:
  43050. (goBackCallback):
  43051. (setDefersLoadingCallback):
  43052. (LayoutTestController::staticFunctions):
  43053. * DumpRenderTree/LayoutTestController.h:
  43054. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  43055. (LayoutTestController::goBack):
  43056. (LayoutTestController::setDefersLoading):
  43057. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  43058. (LayoutTestController::goBack):
  43059. (LayoutTestController::setDefersLoading):
  43060. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  43061. (LayoutTestController::goBack):
  43062. (LayoutTestController::setDefersLoading):
  43063. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  43064. (LayoutTestController::goBack):
  43065. (LayoutTestController::setDefersLoading):
  43066. 2011-05-16 Sam Weinig <sam@webkit.org>
  43067. Reviewed by Anders Carlsson.
  43068. TestWebKitAPI should build with clang if it can
  43069. https://bugs.webkit.org/show_bug.cgi?id=60918
  43070. * TestWebKitAPI/Configurations/CompilerVersion.xcconfig:
  43071. Update CompilerVersion.xcconfig to match others.
  43072. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  43073. Add CompilerVersion.xcconfig to the project.
  43074. * TestWebKitAPI/Tests/WebKit2/FailedLoad.cpp:
  43075. (TestWebKitAPI::didFailProvisionalLoadWithErrorForFrame):
  43076. * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  43077. (TestWebKitAPI::didSameDocumentNavigationForFrame):
  43078. Add some casts to quiet warnings from clang.
  43079. 2011-05-16 Dirk Pranke <dpranke@chromium.org>
  43080. Reviewed by David Levin.
  43081. add dpranke as a reviewer
  43082. https://bugs.webkit.org/show_bug.cgi?id=60919
  43083. * Scripts/webkitpy/common/config/committers.py:
  43084. 2011-05-16 Robert Hogan <robert@webkit.org>
  43085. Reviewed by Anders Carlsson.
  43086. [Gtk] plugins/get-url-notify-with-url-that-fails-to-load.html crashes on buildbot
  43087. https://bugs.webkit.org/show_bug.cgi?id=60838
  43088. The unix test plugin needs to call the test's NPP_URLNotify
  43089. rather than the browsers.
  43090. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  43091. (webkit_test_plugin_url_notify):
  43092. 2011-05-16 Brent Fulgham <bfulgham@webkit.org>
  43093. Rubber-stamped by Adam Roben.
  43094. Adding myself as a reviewer.
  43095. * Scripts/webkitpy/common/config/committers.py:
  43096. 2011-05-16 Sam Weinig <sam@webkit.org>
  43097. Fix typo pointed out by Dave Levin.
  43098. * TestWebKitAPI/PlatformUtilities.h:
  43099. (TestWebKitAPI::Util::assertWKStringEqual):
  43100. Strig -> String.
  43101. 2011-05-16 Sam Weinig <sam@webkit.org>
  43102. Reviewed by David Levin.
  43103. Convert api tester over to using gtest expectations directly
  43104. https://bugs.webkit.org/show_bug.cgi?id=60862
  43105. * TestWebKitAPI/PlatformUtilities.cpp:
  43106. (TestWebKitAPI::Util::toSTD):
  43107. * TestWebKitAPI/PlatformUtilities.h:
  43108. (TestWebKitAPI::Util::assertWKStrigEqual):
  43109. Add convenience macro to compare WK2 strings. Add some overloads of toSTD to make
  43110. the implementation of the macro simpler.
  43111. * TestWebKitAPI/Test.h:
  43112. Remove TEST_ASSERT forwarder.
  43113. [Test changes elided]
  43114. 2011-05-16 David Kilzer <ddkilzer@apple.com>
  43115. <http://webkit.org/b/60913> C++ exceptions should not be enabled when building with llvm-gcc-4.2
  43116. <rdar://problem/9446430>
  43117. Reviewed by Mark Rowe.
  43118. * MiniBrowser/Configurations/Base.xcconfig: Fixed typo.
  43119. * TestWebKitAPI/Configurations/Base.xcconfig: Ditto.
  43120. * WebKitTestRunner/Configurations/Base.xcconfig: Ditto.
  43121. 2011-05-16 Jon Lee <jonlee@apple.com>
  43122. Reviewed by Simon Fraser.
  43123. Can't horizontally scroll iframes and overflow because wheel events are always accepted
  43124. https://bugs.webkit.org/show_bug.cgi?id=60779
  43125. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  43126. (WTR::InjectedBundlePage::InjectedBundlePage): Set new default method to nil.
  43127. 2011-05-16 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
  43128. Reviewed by Csaba Osztrogonác.
  43129. [Qt] Tools.pro misses include(common.pri)
  43130. https://bugs.webkit.org/show_bug.cgi?id=60883
  43131. It includes features.pri, which depends on common.pri (the build is
  43132. not broken today with the default options, but this is the right
  43133. thing to do).
  43134. * Tools.pro:
  43135. 2011-05-15 Dominic Cooney <dominicc@chromium.org>
  43136. Unreviewed: adding myself to committers.py.
  43137. * Scripts/webkitpy/common/config/committers.py:
  43138. 2011-05-15 Daniel Bates <dbates@webkit.org>
  43139. Reviewed by Chris Jerdonek.
  43140. svn-apply can't handle Git diff that only changes executable bit
  43141. https://bugs.webkit.org/show_bug.cgi?id=60848
  43142. Fixes an issue where svn-{apply, unapply} fail to handle a Git diff for a file
  43143. that only has an executable bit change.
  43144. * Scripts/VCSUtils.pm:
  43145. - Modified regex $chunkRangeRegEx to match chunk range with ending text, say: @@ -2,6 +2,18 @@ foo().
  43146. (parseDiff): Modified to count the number of text chunks in the diff. This should also help towards
  43147. fixing <https://bugs.webkit.org/show_bug.cgi?id=29684>.
  43148. * Scripts/svn-apply:
  43149. (patch): Only use standard patch tool if the patch is non-empty and for a text file (i.e. not a binary patch).
  43150. * Scripts/svn-unapply:
  43151. (patch): Ditto.
  43152. * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
  43153. - Updated expected results for test cases to account for numTextChunks.
  43154. - Fixed malformed chunk range in test cases: "Git: simple", and "Git: Git diff followed by SVN diff".
  43155. - Added test case "Git: file that only has an executable bit change".
  43156. * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
  43157. - Updated expected results for test cases to account for numTextChunks.
  43158. 2011-05-15 Sam Weinig <sam@webkit.org>
  43159. Fix windows build.
  43160. * TestWebKitAPI/win/main.cpp:
  43161. (main):
  43162. 2011-05-15 Sam Weinig <sam@webkit.org>
  43163. Reviewed by David Levin.
  43164. Make API tester more gtest friendly
  43165. https://bugs.webkit.org/show_bug.cgi?id=60859
  43166. * Scripts/run-api-tests:
  43167. Numerous changes:
  43168. - Remove logic to run tests one at a time.
  43169. - Remove logic to build up a list of tests, instead just pass --gtest_list_tests to
  43170. the test runner and allow gtest to print it for us.
  43171. - Forward stdout from the test tool to stdout, even in non-verbose runs.
  43172. - Run test tool from the current working directory instead of the root webkit
  43173. directory.
  43174. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  43175. Move plist to be with other bundle sources.
  43176. * TestWebKitAPI/TestsController.cpp:
  43177. (TestWebKitAPI::TestsController::TestsController):
  43178. (TestWebKitAPI::TestsController::run):
  43179. * TestWebKitAPI/TestsController.h:
  43180. * TestWebKitAPI/mac/main.mm:
  43181. Simplify TestController down to a single run function. We should consider removing the class
  43182. entirely at some point.
  43183. 2011-05-15 Sheriff Bot <webkit.review.bot@gmail.com>
  43184. Unreviewed, rolling out r86504.
  43185. http://trac.webkit.org/changeset/86504
  43186. https://bugs.webkit.org/show_bug.cgi?id=60853
  43187. "Broke Qt EventSender in editing/selection tests" (Requested
  43188. by mwenge on #webkit).
  43189. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  43190. (WebCore::WebPage::WebPage):
  43191. (WebCore::DumpRenderTree::DumpRenderTree):
  43192. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  43193. (WebCore::DumpRenderTree::initJSObjects):
  43194. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  43195. (WebCore::DumpRenderTree::eventSender):
  43196. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  43197. (webkit_test_plugin_new_instance):
  43198. (webkit_test_plugin_set_window):
  43199. (webkit_test_plugin_handle_event):
  43200. 2011-05-12 Robert Hogan <robert@webkit.org>
  43201. Reviewed by Benjamin Poulain.
  43202. [Qt] fix http/tests/plugins/plugin-document-has-focus.html
  43203. The support for this test added to the unix test plugin here
  43204. may allow other platforms to pass it (nearly everyone
  43205. skips it). On Qt it required a bit of trickiness with
  43206. the page's EventSender object to get it working fully though,
  43207. so only unskipping Qt here.
  43208. https://bugs.webkit.org/show_bug.cgi?id=60722
  43209. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  43210. (WebCore::WebPage::WebPage):
  43211. (WebCore::WebPage::eventSender):
  43212. (WebCore::DumpRenderTree::DumpRenderTree):
  43213. (WebCore::DumpRenderTree::initJSObjects):
  43214. (WebCore::DumpRenderTree::createWindow):
  43215. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  43216. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  43217. (webkit_test_plugin_new_instance):
  43218. (webkit_test_plugin_set_window):
  43219. (webkit_test_plugin_handle_event):
  43220. 2011-05-14 Arno Renevier <arno@renevier.net>
  43221. Reviewed by Martin Robinson.
  43222. make run-gtk-tests executable
  43223. https://bugs.webkit.org/show_bug.cgi?id=59278
  43224. * Scripts/run-gtk-tests:
  43225. 2011-05-14 Anders Carlsson <andersca@apple.com>
  43226. Reviewed by Kevin Decker.
  43227. NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
  43228. https://bugs.webkit.org/show_bug.cgi?id=60823
  43229. <rdar://problem/9430386>
  43230. Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
  43231. * DumpRenderTree/DumpRenderTree.gypi:
  43232. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  43233. * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
  43234. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
  43235. (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
  43236. (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
  43237. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  43238. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  43239. * GNUmakefile.am:
  43240. 2011-05-14 Sheriff Bot <webkit.review.bot@gmail.com>
  43241. Unreviewed, rolling out r86476.
  43242. http://trac.webkit.org/changeset/86476
  43243. https://bugs.webkit.org/show_bug.cgi?id=60832
  43244. It made plugins/get-url-notify-with-url-that-fails-to-
  43245. load.html crash on GTK (Requested by Ossy on #webkit).
  43246. * DumpRenderTree/DumpRenderTree.gypi:
  43247. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  43248. * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Removed.
  43249. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  43250. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  43251. * GNUmakefile.am:
  43252. 2011-05-13 Anders Carlsson <andersca@apple.com>
  43253. Reviewed by Sam Weinig.
  43254. NPP_URLNotify is not called if a URL passed to NPN_GetURLNotify fails to load
  43255. https://bugs.webkit.org/show_bug.cgi?id=60823
  43256. <rdar://problem/9430386>
  43257. Add test that calls NPN_GetURLNotify on a URL that can't be loaded, and checks if NPP_URLNotify is called.
  43258. * DumpRenderTree/DumpRenderTree.gypi:
  43259. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  43260. * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLNotifyWithURLThatFailsToLoad.cpp: Added.
  43261. (GetURLNotifyWithURLThatFailsToLoad::GetURLNotifyWithURLThatFailsToLoad):
  43262. (GetURLNotifyWithURLThatFailsToLoad::NPP_New):
  43263. (GetURLNotifyWithURLThatFailsToLoad::NPP_URLNotify):
  43264. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  43265. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  43266. * GNUmakefile.am:
  43267. 2011-05-13 Anders Carlsson <andersca@apple.com>
  43268. Build fix.
  43269. * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp:
  43270. 2011-05-13 Anders Carlsson <andersca@apple.com>
  43271. Reviewed by Sam Weinig.
  43272. NPN_GetURL with a javascript: URL doesn't send back the result in the stream
  43273. https://bugs.webkit.org/show_bug.cgi?id=60810
  43274. Add a test that calls NPN_GetURL on a javascript: URL and checks that it gets back the expected result.
  43275. * DumpRenderTree/DumpRenderTree.gypi:
  43276. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  43277. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  43278. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  43279. * GNUmakefile.am:
  43280. Add files.
  43281. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  43282. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  43283. Add new NPN and NPP wrappers and sort them according to the order they appear in npfunctions.h
  43284. * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURL.cpp: Added.
  43285. (GetURLWithJavaScriptURL::GetURLWithJavaScriptURL):
  43286. (GetURLWithJavaScriptURL::NPP_New):
  43287. (GetURLWithJavaScriptURL::NPP_NewStream):
  43288. (GetURLWithJavaScriptURL::NPP_DestroyStream):
  43289. (GetURLWithJavaScriptURL::NPP_WriteReady):
  43290. (GetURLWithJavaScriptURL::NPP_Write):
  43291. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  43292. (NPP_NewStream):
  43293. (NPP_WriteReady):
  43294. (NPP_Write):
  43295. (NPP_URLNotify):
  43296. call the PluginTest NPP wrappers.
  43297. 2011-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
  43298. Unreviewed, rolling out r86447.
  43299. http://trac.webkit.org/changeset/86447
  43300. https://bugs.webkit.org/show_bug.cgi?id=60809
  43301. "Broke some uses of EventSender object on Qt" (Requested by
  43302. mwenge on #webkit).
  43303. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  43304. (WebCore::WebPage::WebPage):
  43305. (WebCore::DumpRenderTree::DumpRenderTree):
  43306. (WebCore::DumpRenderTree::initJSObjects):
  43307. (WebCore::DumpRenderTree::createWindow):
  43308. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  43309. (WebCore::DumpRenderTree::eventSender):
  43310. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  43311. (webkit_test_plugin_new_instance):
  43312. (webkit_test_plugin_set_window):
  43313. (webkit_test_plugin_handle_event):
  43314. 2011-05-13 Robert Hogan <robert@webkit.org>
  43315. Reviewed by Benjamin Poulain.
  43316. [Qt] fix http/tests/plugins/plugin-document-has-focus.html
  43317. The support for this test added to the unix test plugin here
  43318. may allow other platforms to pass it (nearly everyone
  43319. skips it). On Qt it required a bit of trickiness with
  43320. the page's EventSender object to get it working fully though,
  43321. so only unskipping Qt here.
  43322. https://bugs.webkit.org/show_bug.cgi?id=60722
  43323. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  43324. (WebCore::WebPage::WebPage):
  43325. (WebCore::WebPage::eventSender):
  43326. (WebCore::DumpRenderTree::DumpRenderTree):
  43327. (WebCore::DumpRenderTree::initJSObjects):
  43328. (WebCore::DumpRenderTree::createWindow):
  43329. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  43330. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  43331. (webkit_test_plugin_new_instance):
  43332. (webkit_test_plugin_set_window):
  43333. (webkit_test_plugin_handle_event):
  43334. 2011-05-13 Adam Roben <aroben@apple.com>
  43335. Exclude the Leopard NRWT bot from the core builder set
  43336. Fixes <http://webkit.org/b/60392> Leopard Intel Release (NRWT) shouldn't be a core builder
  43337. Reviewed by Darin Adler.
  43338. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  43339. (BuildBot.__init__): Tighten up the Leopard regexp to only allow the non-NRWT Leopard bots
  43340. in the core builder set.
  43341. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  43342. (BuildBotTest.test_builder_name_regexps): Updated to match the current set of builders and
  43343. regexps.
  43344. 2011-05-13 Adam Roben <aroben@apple.com>
  43345. Group all the NRWT bots together
  43346. This also gets the new NRWT bots out of the middle of Apple's bots. Since these new NRWT
  43347. bots are experimental, it seems best not to clutter up the non-experimental bots with
  43348. experimental ones.
  43349. Fixes <http://webkit.org/b/60769> New "(NRWT)" bots are right in the middle of Apple's bots
  43350. on build.webkit.org
  43351. Reviewed by Dan Bernstein.
  43352. * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the "(NRWT)" bots next to the
  43353. Chromium testers, which also use new-run-webkit-tests.
  43354. 2011-05-13 Adam Roben <aroben@apple.com>
  43355. Add a plugin test that dumps the plugin window's rect
  43356. Part of the test for <http://webkit.org/b/60194> <rdar://problem/9383760> REGRESSION
  43357. (r79167): Windowed plugins in Google Reader don't move when the article list is scrolled
  43358. Reviewed by Dan Bernstein.
  43359. * DumpRenderTree/TestNetscapePlugIn/Tests/win/DumpWindowRect.cpp: Added.
  43360. (DumpWindowRect::DumpWindowRect): Just call up to the base class.
  43361. (DumpWindowRect::performWindowGeometryTest): Find our window rect relative to the test
  43362. harness window and log it.
  43363. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added DumpWindowRect.
  43364. 2011-05-13 Adam Roben <aroben@apple.com>
  43365. Move code required for most tests of plugin window geometry into a base class
  43366. WebKit2's asynchronous plugin window positioning makes testing window geometry tricky. By
  43367. having all the trickiness in a shared base class, writing new window geometry tests will be
  43368. much easier.
  43369. Fixes <http://webkit.org/b/60776> It's hard to write tests that check plugin window geometry
  43370. Reviewed by Anders Carlsson.
  43371. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
  43372. (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Changed to inherit from the new
  43373. WindowGeometryTest base class. Most of the code from this class was moved to the new base
  43374. class.
  43375. (WindowRegionIsSetToClipRect::performWindowGeometryTest): Renamed from checkWindowRegion.
  43376. This is called by the base class when it is safe to check the window's geometry. Note that
  43377. the m_didCheckWindowRegion logic was removed completely; it has never been needed and was
  43378. just vestigial code from an earlier version of this test.
  43379. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new
  43380. WindowGeometryTest class.
  43381. * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.cpp: Added. Code came from
  43382. WindowRegionIsSetToClipRect.
  43383. (WindowGeometryTest::finishTest): This is the only change from WindowRegionIsSetToClipRect.
  43384. We now call the new virtual performWindowGeometryTest function instead of checkWindowRegion.
  43385. Subclasses can implement that function to perform their own tests.
  43386. * DumpRenderTree/TestNetscapePlugIn/win/WindowGeometryTest.h: Added.
  43387. 2011-05-13 Zoltan Herczeg <zherczeg@webkit.org>
  43388. Reviewed by Csaba Osztrogonác.
  43389. Missing 2nd #EOF if WebProcess is killed.
  43390. https://bugs.webkit.org/show_bug.cgi?id=60761
  43391. If the WebProcess is killed, only one #EOF is yielded
  43392. by WebKitTestRunner. However, run-webkit-test wait for
  43393. a second #EOF, which signals the finishing of pixel dump.
  43394. Since this never happens, run-webkit-test waits forever.
  43395. * WebKitTestRunner/TestInvocation.cpp:
  43396. (WTR::TestInvocation::dump):
  43397. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  43398. * WebKitTestRunner/TestInvocation.h:
  43399. 2011-05-13 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  43400. Reviewed by Csaba Osztrogonác.
  43401. [NRWT] chromium-linux tests shouldn't run on other platforms
  43402. https://bugs.webkit.org/show_bug.cgi?id=60162
  43403. Remove _tests_for_other_platforms defs because r82753
  43404. implemented it properly in the baseclass in webkit.py.
  43405. * Scripts/webkitpy/layout_tests/port/gtk.py:
  43406. * Scripts/webkitpy/layout_tests/port/qt.py:
  43407. * Scripts/webkitpy/layout_tests/port/win.py:
  43408. 2011-05-12 Ryuan Choi <ryuan.choi@samsung.com>
  43409. Reviewed by Antonio Gomes.
  43410. [EFL] Remove unused option of EWeblauncher
  43411. https://bugs.webkit.org/show_bug.cgi?id=60747
  43412. Remove sudo-workaround option.
  43413. This option is not used and make other option wrong.
  43414. * EWebLauncher/main.c:
  43415. 2011-05-12 Lucas Forschler <lforschler@apple.com>
  43416. Reviewed by Stephanie Lewis.
  43417. Fix config.json to address missing WK2 builder/tester config.
  43418. Fix naming of machines (xserve not macpro)
  43419. * BuildSlaveSupport/build.webkit.org-config/config.json:
  43420. 2011-05-12 Lucas Forschler <lforschler@apple.com>
  43421. Reviewed by Stephanie Lewis.
  43422. Add SnowLeopard Debug builder and Test bot.
  43423. apple-xserve-8 = SL Debug Tester.
  43424. apple-xserve-9 = SL Debug Builder.
  43425. * BuildSlaveSupport/build.webkit.org-config/config.json:
  43426. 2011-05-12 Adam Barth <abarth@webkit.org>
  43427. This patch disables sheriffbot's bug postings. He's just been way too
  43428. spammy recently due to test flakiness.
  43429. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  43430. * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
  43431. 2011-05-11 Brian Weinstein <bweinstein@apple.com>
  43432. Reviewed by Anders Carlsson.
  43433. After relaunching an unresponsive web process, web page stops responding to mouse movement
  43434. https://bugs.webkit.org/show_bug.cgi?id=60669
  43435. <rdar://problem/9409934>
  43436. This test follows the steps needed to reproduce this bug:
  43437. 1) Hang the web process
  43438. 2) While the web process is hung, move the mouse (so WebPageProxy thinks it is processing a mouse move event)
  43439. 3) Kill and restart the WebProcess
  43440. 4) Move the mouse
  43441. We are testing that we receive mouse move events after the WebProcess has restarted.
  43442. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash.cpp: Added.
  43443. (TestWebKitAPI::didFinishLoadForFrame): Set a flag that we finished loading.
  43444. (TestWebKitAPI::processDidBecomeUnresponsive): Kill the web process once we become unresponsive.
  43445. (TestWebKitAPI::processDidCrash): Reload the page when the process crashes, which restarts the web process.
  43446. (TestWebKitAPI::setPageLoaderClient):
  43447. (TestWebKitAPI::TEST):
  43448. * TestWebKitAPI/Tests/WebKit2/MouseMoveAfterCrash_Bundle.cpp: Added.
  43449. (TestWebKitAPI::MouseMoveAfterCrashTest::MouseMoveAfterCrashTest):
  43450. (TestWebKitAPI::MouseMoveAfterCrashTest::didReceiveMessage):
  43451. * TestWebKitAPI/Tests/WebKit2/mouse-move-listener.html: Added.
  43452. * TestWebKitAPI/PlatformWebView.h:
  43453. * TestWebKitAPI/mac/PlatformWebViewMac.mm:
  43454. (TestWebKitAPI::PlatformWebView::simulateMouseMove): Sends the messages that simulate a mouse move.
  43455. * TestWebKitAPI/win/PlatformWebViewWin.cpp:
  43456. (TestWebKitAPI::PlatformWebView::simulateMouseMove): Ditto.
  43457. Add new files.
  43458. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  43459. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  43460. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  43461. * TestWebKitAPI/win/copy-resources.cmd:
  43462. 2011-05-12 Tomasz Morawski <t.morawski@samsung.com>
  43463. Reviewed by Antonio Gomes.
  43464. [EFL] Added initialization/shutdown for ecore_file library
  43465. https://bugs.webkit.org/show_bug.cgi?id=60457
  43466. Added initialization and shuthown for ecore_file library and replaced
  43467. realpath function to ecore_file_realpath.
  43468. * EWebLauncher/main.c:
  43469. (quit):
  43470. (findThemePath):
  43471. (main):
  43472. 2011-05-12 Young Han Lee <joybro@company100.net>
  43473. Reviewed by Kenneth Rohde Christiansen.
  43474. [Qt] Implement layoutTestController.layerTreeAsText()
  43475. https://bugs.webkit.org/show_bug.cgi?id=60367
  43476. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  43477. (LayoutTestController::layerTreeAsText):
  43478. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  43479. 2011-05-11 Eric Seidel <eric@webkit.org>
  43480. Reviewed by David Levin.
  43481. Teach validate-committer-lists how to validate committers bugzilla_email()
  43482. https://bugs.webkit.org/show_bug.cgi?id=60651
  43483. It turns out we currently have 9 committers with invalid values for their
  43484. bugzilla_email field (meaning we don't know what email is their bugzilla account).
  43485. "Alexander Kellett" <lypanov@mac.com>
  43486. "Andre Boule" <aboule@apple.com>
  43487. "Cameron McCormack" <cam@webkit.org>
  43488. "Chris Petersen" <cpetersen@apple.com>
  43489. "Eli Fidler" <eli@staikos.net>
  43490. "Matt Lilek" <webkit@mattlilek.com>
  43491. "Pierre d'Herbemont" <pdherbemont@free.fr>
  43492. "Scott Violet" <sky@chromium.org>
  43493. "Adam Treat" <treat@kde.org>
  43494. Most of those haven't committed in a very long time, so it's not suprising
  43495. that we haven't noticed that their bugzilla emails are bogus.
  43496. * Scripts/validate-committer-lists:
  43497. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  43498. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  43499. 2011-05-11 Dmitry Lomov <dslomov@google.com>
  43500. Reviewed by David Levin.
  43501. https://bugs.webkit.org/show_bug.cgi?id=59561
  43502. Switch TestWebKitAPI to GTest
  43503. Fixes Makefiles and WinCairo build as well
  43504. * Makefile:
  43505. * Scripts/build-api-tests:
  43506. * Scripts/run-api-tests:
  43507. * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  43508. * TestWebKitAPI/Test.h:
  43509. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  43510. * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  43511. (TestWebKitAPI::TEST):
  43512. * TestWebKitAPI/TestsController.cpp:
  43513. (TestWebKitAPI::TestsController::TestsController):
  43514. (TestWebKitAPI::TestsController::dumpTestNames):
  43515. (TestWebKitAPI::TestsController::runTestNamed):
  43516. (TestWebKitAPI::TestsController::runAllTests):
  43517. * TestWebKitAPI/TestsController.h:
  43518. * TestWebKitAPI/mac/main.mm:
  43519. (main):
  43520. 2011-05-11 Eric Seidel <eric@webkit.org>
  43521. Reviewed by Alexey Proskuryakov.
  43522. Add Luke Macpherson to committers.py as a Contributor
  43523. https://bugs.webkit.org/show_bug.cgi?id=60639
  43524. * Scripts/webkitpy/common/config/committers.py:
  43525. 2011-05-11 Noam Rosenthal <noam.rosenthal@nokia.com>
  43526. Reviewed by Kenneth Rohde Christiansen.
  43527. [Texmap][Qt] Upstream texture-mapper changes from Qt's WebKit2 branch
  43528. https://bugs.webkit.org/show_bug.cgi?id=60439
  43529. Patch 4/12: Update the build script to enable 3D rendering by default for Qt.
  43530. * Scripts/build-webkit:
  43531. 2011-05-11 Brian Weinstein <bweinstein@apple.com>
  43532. Reviewed by Adam Roben.
  43533. REGRESSION (r86161): WKPreferences API test failing on Windows
  43534. https://bugs.webkit.org/show_bug.cgi?id=60658
  43535. * TestWebKitAPI/Tests/WebKit2/WKPreferences.cpp:
  43536. (TestWebKitAPI::TEST):
  43537. 2011-05-11 Alice Boxhall <aboxhall@chromium.org>
  43538. Reviewed by Ojan Vafai.
  43539. Modify jsonresults_unittest.py to use a dict format for its test data, and modify jsonresults.py to flatten hierarchical directory structures in input JSON.
  43540. https://bugs.webkit.org/show_bug.cgi?id=60521
  43541. First steps towards making the results JSON all hierarchical.
  43542. * TestResultServer/model/jsonresults.py:
  43543. * TestResultServer/model/jsonresults_unittest.py:
  43544. 2011-05-11 Kevin Ollivier <kevino@theolliviers.com>
  43545. [wx] Build fix, adding new LayoutTestController method stubs.
  43546. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  43547. (LayoutTestController::localStorageDiskUsageForOrigin):
  43548. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  43549. 2011-05-11 Jessie Berlin <jberlin@apple.com>
  43550. Reviewed by Darin Adler.
  43551. [WebKit2] exceededDatabaseQuota function on WKPageUIClient needs to provide information
  43552. about the usage for both the origin overall and the database in question.
  43553. https://bugs.webkit.org/show_bug.cgi?id=60573
  43554. * WebKitTestRunner/TestController.cpp:
  43555. (WTR::exceededDatabaseQuota):
  43556. 2011-05-10 Stephen White <senorblanco@chromium.org>
  43557. Reviewed by David Levin.
  43558. Adding myself as a reviewer.
  43559. https://bugs.webkit.org/show_bug.cgi?id=60587
  43560. * Scripts/webkitpy/common/config/committers.py:
  43561. 2011-05-11 Eric Seidel <eric@webkit.org>
  43562. Reviewed by Csaba Osztrogonác.
  43563. queues.webkit.org should show 1000+ instead of 1000 when we hit the query limit
  43564. https://bugs.webkit.org/show_bug.cgi?id=60614
  43565. AppEngine has a result limit of 1000. We hit that when trying
  43566. to find out how many patches the style-queue (and other queues)
  43567. have passed in the last 30 days. So lets display 1000+ instead
  43568. of 1000 to avoid confusion. (Ossy was asking about this in #webkit tonight.)
  43569. I also made the status pages show "never" instead of just "ago" when we
  43570. haven't seen a pass or boot message in the last 1000 messages.
  43571. * QueueStatusServer/handlers/queuestatus.py:
  43572. * QueueStatusServer/templates/queuestatus.html:
  43573. 2011-05-11 Adam Barth <abarth@webkit.org>
  43574. Reviewed by Eric Seidel.
  43575. sheriffbot shouldn't spam bugs when it can't figure out who to blame
  43576. https://bugs.webkit.org/show_bug.cgi?id=60613
  43577. This patch limits the number of bugs sheriffbot will spam to three.
  43578. Ideally, we'd come up with some smarter huerstics, but hopefully this
  43579. will cut down on the bugmail spam for slow bots.
  43580. * Scripts/webkitpy/tool/commands/sheriffbot.py:
  43581. 2011-05-10 Eric Seidel <eric@webkit.org>
  43582. Reviewed by Adam Barth.
  43583. EWS bots should be robust against test-webkitpy hangs
  43584. https://bugs.webkit.org/show_bug.cgi?id=60579
  43585. Added a killAfterTimeout subroutine, which takes a child_pid
  43586. and timeout, and will setup a watchdog process to kill that child
  43587. after the timeout. killAfterTimeout will waitpid on the child.
  43588. * EWSTools/start-queue.sh:
  43589. 2011-05-10 MORITA Hajime <morrita@google.com>
  43590. Unreviewed, moved myself to the reviewers list.
  43591. * Scripts/webkitpy/common/config/committers.py:
  43592. 2011-05-10 Anton D'Auria <adauria@apple.com>
  43593. Reviewed by David Levin.
  43594. StorageTracker should report actual local storage usage on disk
  43595. https://bugs.webkit.org/show_bug.cgi?id=60558
  43596. * DumpRenderTree/LayoutTestController.cpp:
  43597. (localStorageDiskUsageForOriginCallback):
  43598. (LayoutTestController::staticFunctions):
  43599. * DumpRenderTree/LayoutTestController.h:
  43600. * DumpRenderTree/chromium/LayoutTestController.cpp:
  43601. (LayoutTestController::LayoutTestController):
  43602. (LayoutTestController::localStorageDiskUsageForOrigin):
  43603. * DumpRenderTree/chromium/LayoutTestController.h:
  43604. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  43605. (LayoutTestController::localStorageDiskUsageForOrigin):
  43606. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  43607. (LayoutTestController::localStorageDiskUsageForOrigin):
  43608. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  43609. (LayoutTestController::localStorageDiskUsageForOrigin):
  43610. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  43611. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  43612. (LayoutTestController::localStorageDiskUsageForOrigin):
  43613. 2011-05-10 Anton D'Auria <adauria@apple.com>
  43614. Reviewed by Alexey Proskuryakov.
  43615. Add ApplicationCache API to get disk usage per origin
  43616. https://bugs.webkit.org/show_bug.cgi?id=57127
  43617. Added test that loads two frames with ~15Kb image, checks usage,
  43618. deletes app cache, verifies usage is 0.
  43619. * DumpRenderTree/LayoutTestController.cpp:
  43620. (applicationCacheDiskUsageForOriginCallback):
  43621. (LayoutTestController::staticFunctions):
  43622. * DumpRenderTree/LayoutTestController.h:
  43623. * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
  43624. (LayoutTestController::LayoutTestController):
  43625. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  43626. * DumpRenderTree/chromium/LayoutTestController.h:
  43627. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
  43628. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  43629. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  43630. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  43631. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
  43632. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  43633. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  43634. * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
  43635. (LayoutTestController::applicationCacheDiskUsageForOrigin):
  43636. 2011-05-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
  43637. Unreviewed, adding Rafael Antognolli as a committer.
  43638. * Scripts/webkitpy/common/config/committers.py:
  43639. 2011-05-10 Chris Evans <cevans@chromium.org>
  43640. Reviewed by Adam Barth.
  43641. Add WebCore::Setting to block displaying and/or running insecure content on secure pages
  43642. https://bugs.webkit.org/show_bug.cgi?id=58378
  43643. * DumpRenderTree/chromium/LayoutTestController.cpp:
  43644. (LayoutTestController::LayoutTestController):
  43645. (LayoutTestController::setAllowDisplayOfInsecureContent):
  43646. (LayoutTestController::setAllowRunningOfInsecureContent):
  43647. * DumpRenderTree/chromium/LayoutTestController.h:
  43648. * DumpRenderTree/chromium/WebPreferences.cpp:
  43649. (WebPreferences::reset):
  43650. (WebPreferences::applyTo):
  43651. * DumpRenderTree/chromium/WebPreferences.h:
  43652. Add plumbing for new settings to Chromium DRT.
  43653. 2011-05-10 Enrica Casucci <enrica@apple.com>
  43654. Reviewed by Beth Dakin.
  43655. Added my name to the reviewers list and removed my name from
  43656. to committer-only list.
  43657. * Scripts/webkitpy/common/config/committers.py:
  43658. 2011-05-10 David Levin <levin@chromium.org>
  43659. Reviewed by Shinichiro Hamaji.
  43660. check-webkit-style shouldn't filter the errors using the modified lines for the xml and test expectations checkers.
  43661. https://bugs.webkit.org/show_bug.cgi?id=60466
  43662. * Scripts/webkitpy/style/checker.py: (unrelated) style fix.
  43663. * Scripts/webkitpy/style/checker_unittest.py: Remove the file_path check since
  43664. that property was removed.
  43665. * Scripts/webkitpy/style/checkers/test_expectations.py: Turn off the line
  43666. filtering for errors.
  43667. * Scripts/webkitpy/style/checkers/test_expectations_unittest.py: Add testing to
  43668. verify that the line filtering is turned off.
  43669. * Scripts/webkitpy/style/checkers/xml.py: Turn off the line filtering for errors
  43670. and remove the unused file_path parameter.
  43671. * Scripts/webkitpy/style/checkers/xml_unittest.py: Add testing to verify that the
  43672. line filtering is turned off (and fix test_no_error).
  43673. * Scripts/webkitpy/style/error_handlers.py: Added a way to turn off the filtering
  43674. of errors based on the lines changed in the patch.
  43675. * Scripts/webkitpy/style/error_handlers_unittest.py: Added a test for turning off
  43676. the filtering.
  43677. 2011-05-10 Adam Roben <aroben@apple.com>
  43678. Update some plugin tests to work with WebKit2's asynchronous windowed plugin positioning on Windows
  43679. Fixes <http://webkit.org/b/60442> <rdar://problem/9403200> REGRESSION (r85795):
  43680. platform/win/plugins/window-geometry-initialized-before-set-window.html and
  43681. platform/win/plugins/window-region-is-set-to-clip-rect.html failing on Windows 7 Release
  43682. (WebKit2 Tests)
  43683. Reviewed by Anders Carlsson.
  43684. * DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp:
  43685. (NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Moved some code from here to the new
  43686. WindowedPluginTest::testHarnessWindow function.
  43687. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowGeometryInitializedBeforeSetWindow.cpp:
  43688. (WindowGeometryInitializedBeforeSetWindow::NPP_SetWindow): Only check the window's size, not
  43689. its position. In WebKit2, the position won't have been set yet, so we can't test it. But it
  43690. turns out only the size mattered for <http://webkit.org/b/46716>, which this test was
  43691. created for.
  43692. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowRegionIsSetToClipRect.cpp:
  43693. (WindowRegionIsSetToClipRect::WindowRegionIsSetToClipRect): Converted to be a
  43694. WindowedPluginTest, and initialized new members.
  43695. (WindowRegionIsSetToClipRect::startTest): Make our plugin window visible, and set things up
  43696. to ensure we get a WM_WINDOWPOSCHANGED message about it becoming visible.
  43697. (WindowRegionIsSetToClipRect::finishTest): Check that the window region is what we expect,
  43698. then clean up and tell the test harness we're done.
  43699. (WindowRegionIsSetToClipRect::checkWindowRegion): Moved code to check the window region here
  43700. from NPP_SetWindow. Changed to use the fancy new log() function instead of pluginLog().
  43701. (WindowRegionIsSetToClipRect::showTestHarnessWindowIfNeeded): Show the test harness's window
  43702. if it is hidden. This is needed to ensure we get a WM_WINDOWPOSCHANGED message when our own
  43703. window becomes visible.
  43704. (WindowRegionIsSetToClipRect::hideTestHarnessWindowIfNeeded): Hide the test harness's window
  43705. if it was hidden at the start of the test.
  43706. (WindowRegionIsSetToClipRect::wndProc): When our timer fires, tell the UI process to paint.
  43707. This should cause our window to become visible and our window region to get set. When we get
  43708. a WM_WINDOWPOSCHANGED message, we can finally finish the test.
  43709. (WindowRegionIsSetToClipRect::NPP_GetValue): Return our script object.
  43710. (WindowRegionIsSetToClipRect::ScriptObject::hasMethod): We only have one method:
  43711. "startTest".
  43712. (WindowRegionIsSetToClipRect::ScriptObject::invoke): Call through to the PluginTest object.
  43713. * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.cpp:
  43714. (WindowedPluginTest::testHarnessWindow):
  43715. * DumpRenderTree/TestNetscapePlugIn/win/WindowedPluginTest.h:
  43716. Added this helper function. Code came from NPNInvalidateRectInvalidatesWindow.
  43717. 2011-05-10 Csaba Osztrogonác <ossy@webkit.org>
  43718. Reviewed by Kenneth Rohde Christiansen.
  43719. [Qt] Add new qt-4.8 platform for layout testing
  43720. https://bugs.webkit.org/show_bug.cgi?id=60544
  43721. * Scripts/old-run-webkit-tests:
  43722. * Scripts/webkitdirs.pm:
  43723. 2011-05-09 Sheriff Bot <webkit.review.bot@gmail.com>
  43724. Unreviewed, rolling out r86108.
  43725. http://trac.webkit.org/changeset/86108
  43726. https://bugs.webkit.org/show_bug.cgi?id=60533
  43727. Broke makefile based builds and Cairo (Requested by weinig on
  43728. #webkit).
  43729. * Scripts/build-api-tests:
  43730. * Scripts/run-api-tests:
  43731. * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  43732. * TestWebKitAPI/Test.h:
  43733. (TestWebKitAPI::Test::~Test):
  43734. (TestWebKitAPI::Test::name):
  43735. (TestWebKitAPI::Test::Register::Register):
  43736. (TestWebKitAPI::Test::Register::create):
  43737. (TestWebKitAPI::Test::Test):
  43738. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  43739. * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  43740. (TestWebKitAPI::TEST):
  43741. * TestWebKitAPI/TestsController.cpp:
  43742. (TestWebKitAPI::TestsController::TestsController):
  43743. (TestWebKitAPI::TestsController::dumpTestNames):
  43744. (TestWebKitAPI::TestsController::runTestNamed):
  43745. (TestWebKitAPI::TestsController::testFailed):
  43746. (TestWebKitAPI::TestsController::registerCreateTestFunction):
  43747. * TestWebKitAPI/TestsController.h:
  43748. * TestWebKitAPI/mac/main.mm:
  43749. (main):
  43750. 2011-05-09 Hayato Ito <hayato@chromium.org>
  43751. Reviewed by Ojan Vafai.
  43752. Skip reftests if pixel tests are disabled.
  43753. https://bugs.webkit.org/show_bug.cgi?id=59078
  43754. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  43755. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  43756. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  43757. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
  43758. 2011-05-09 Chang Shu <cshu@webkit.org>
  43759. Reviewed by Kenneth Rohde Christiansen.
  43760. [Qt] DumpRenderTreeQt needs an implementation of unmarkText
  43761. https://bugs.webkit.org/show_bug.cgi?id=60499
  43762. The implementation is similar to gtk.
  43763. * DumpRenderTree/qt/TextInputControllerQt.cpp:
  43764. (TextInputController::unmarkText):
  43765. * DumpRenderTree/qt/TextInputControllerQt.h:
  43766. 2011-05-09 James Robinson <jamesr@chromium.org>
  43767. Reviewed by Eric Seidel.
  43768. [chromium] Teach new-run-webkit-tests to follow symlinks when trying to determine the arch of DumpRenderTree on linux
  43769. https://bugs.webkit.org/show_bug.cgi?id=60520
  43770. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  43771. 2011-05-09 Dmitry Lomov <dslomov@google.com>
  43772. Reviewed by Sam Weinig.
  43773. Switch TestWebKitAPI to GTest
  43774. https://bugs.webkit.org/show_bug.cgi?id=59561
  43775. * Scripts/build-api-tests:
  43776. * Scripts/run-api-tests:
  43777. * TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
  43778. * TestWebKitAPI/Test.h:
  43779. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  43780. * TestWebKitAPI/Tests/WTF/VectorBasic.cpp:
  43781. (TestWebKitAPI::TEST):
  43782. * TestWebKitAPI/TestsController.cpp:
  43783. (TestWebKitAPI::TestsController::TestsController):
  43784. (TestWebKitAPI::TestsController::dumpTestNames):
  43785. (TestWebKitAPI::TestsController::runTestNamed):
  43786. (TestWebKitAPI::TestsController::runAllTests):
  43787. * TestWebKitAPI/TestsController.h:
  43788. * TestWebKitAPI/mac/main.mm:
  43789. (main):
  43790. 2011-05-09 Igor Oliveira <igor.oliveira@openbossa.org>
  43791. Reviewed by Andreas Kling.
  43792. [Qt] DRT eventSender.addTouchPoint method is not setting the start position
  43793. https://bugs.webkit.org/show_bug.cgi?id=60487
  43794. When adding a new touch point, the start position of this point needs to be set.
  43795. * DumpRenderTree/qt/EventSenderQt.cpp:
  43796. (EventSender::addTouchPoint):
  43797. 2011-05-09 Robert Hogan <robert@webkit.org>
  43798. Reviewed by Adam Roben.
  43799. https://bugs.webkit.org/show_bug.cgi?id=57137
  43800. Unskip plugins/embed-prefers-plugins-for-images.html
  43801. Add image/png mime-type to test netscape plugin on Unix.
  43802. * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
  43803. (NP_GetMIMEDescription):
  43804. 2011-05-09 Alice Boxhall <aboxhall@chromium.org>
  43805. Reviewed by Ojan Vafai.
  43806. Pull jsonresults_unittest test cases out into separate test methods.
  43807. https://bugs.webkit.org/show_bug.cgi?id=60418
  43808. * TestResultServer/model/jsonresults_unittest.py:
  43809. 2011-05-09 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  43810. Reviewed by Andreas Kling.
  43811. [Qt] fix fast/dom/Geolocation/window-close-crash.html
  43812. https://bugs.webkit.org/show_bug.cgi?id=60458
  43813. Update all pages with Mock position/error/permission.
  43814. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  43815. (LayoutTestController::setGeolocationPermission):
  43816. (LayoutTestController::setMockGeolocationError):
  43817. (LayoutTestController::setMockGeolocationPosition):
  43818. 2011-05-09 Shishir Agrawal <shishir@chromium.org>
  43819. Reviewed by Tony Gentilcore.
  43820. Implement Page Visibility API.
  43821. https://bugs.webkit.org/show_bug.cgi?id=54181
  43822. * DumpRenderTree/LayoutTestController.cpp:
  43823. (setPageVisibilityCallback):
  43824. (resetPageVisibilityCallback):
  43825. (LayoutTestController::staticFunctions):
  43826. * DumpRenderTree/LayoutTestController.h:
  43827. (LayoutTestController::setPageVisibility):
  43828. (LayoutTestController::resetPageVisibility):
  43829. * DumpRenderTree/chromium/LayoutTestController.cpp:
  43830. (LayoutTestController::LayoutTestController):
  43831. (LayoutTestController::resetPageVisibility):
  43832. (LayoutTestController::setPageVisibility):
  43833. * DumpRenderTree/chromium/LayoutTestController.h:
  43834. 2011-05-07 Adam Barth <abarth@webkit.org>
  43835. Reviewed by Eric Seidel.
  43836. Testing EWS spins on patches with a large number of failures
  43837. https://bugs.webkit.org/show_bug.cgi?id=60441
  43838. In cases where the tree has a small number of persistent failures but a
  43839. patch has a large number of failures, we weren't believing any results.
  43840. That lead to us retrying the patch forever while we waited for
  43841. trustworthy results that would never come.
  43842. This patch loosens the semantics of unexpected_failures to return a
  43843. subset (rather than the exact set) of unexpected failures. In the case
  43844. where the tree has a bounded number of failures and the patch has an
  43845. unbounded number of failures, we can accurately compute such a subset
  43846. and reject the patch.
  43847. * Scripts/webkitpy/tool/bot/expectedfailures.py:
  43848. * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py:
  43849. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  43850. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  43851. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  43852. 2011-05-07 Joe Mason <jmason@rim.com>
  43853. Reviewed by Daniel Bates.
  43854. FrameLoader::isProcessingUserGesture is wrong in dispatchWillPerformClientRedirect
  43855. https://bugs.webkit.org/show_bug.cgi?id=52211
  43856. Dump isUserProcessingGesture in willPerformClientRedirect so that the layout tests can be extended.
  43857. (For the Mac and Chromium ports - other ports don't support dumping user gestures in DRT.)
  43858. * DumpRenderTree/chromium/WebViewHost.cpp:
  43859. (WebViewHost::willPerformClientRedirect):
  43860. (WebViewHost::didStartProvisionalLoad):
  43861. * DumpRenderTree/mac/FrameLoadDelegate.mm:
  43862. (-[FrameLoadDelegate webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:]):
  43863. 2011-05-07 Daniel Bates <dbates@webkit.org>
  43864. Attempt to fix the build; remove some more references to isTiger(), which was removed in changeset 86007
  43865. <http://trac.webkit.org/changeset/86007> (bug #60438).
  43866. * Scripts/old-run-webkit-tests:
  43867. - Removed reference to isTiger() from openDumpTool(), captureSavedCrashLog(), and
  43868. file local variable.
  43869. 2011-05-07 Pratik Solanki <psolanki@apple.com>
  43870. Reviewed by Darin Adler.
  43871. Remove references to Tiger in scripts
  43872. https://bugs.webkit.org/show_bug.cgi?id=60438
  43873. Remove isTiger() and all of the code that depends on it.
  43874. * Scripts/build-webkit:
  43875. * Scripts/ensure-valid-python:
  43876. * Scripts/gdb-safari:
  43877. * Scripts/webkitdirs.pm:
  43878. 2011-05-06 David Grogan <dgrogan@chromium.org>
  43879. Reviewed by Eric Seidel.
  43880. update link to message about mac 64bit git binaries
  43881. https://bugs.webkit.org/show_bug.cgi?id=60411
  43882. The original message implied (correctly, at-the-time) that
  43883. http://code.google.com/p/git-osx-installer/ doesn't provide 64-bit
  43884. binaries. The new message notes that they do. This might prevent someone
  43885. else from spending a few minutes confused.
  43886. * Scripts/webkitpy/common/checkout/scm/git.py:
  43887. 2011-05-06 Dirk Pranke <dpranke@chromium.org>
  43888. Reviewed by Ojan Vafai.
  43889. new-run-webkit-tests: crashes in race with crashing DRT
  43890. https://bugs.webkit.org/show_bug.cgi?id=60238
  43891. This fixes a race where if we wrote the URL to DRT and
  43892. DRT crashed immediately, we could get a broken pipe
  43893. error back during the write() and not handle it correctly,
  43894. causing NRWT to also crash.
  43895. * Scripts/webkitpy/layout_tests/port/server_process.py:
  43896. * Scripts/webkitpy/layout_tests/port/webkit.py:
  43897. 2011-05-06 Adam Barth <abarth@webkit.org>
  43898. Reviewed by Eric Seidel.
  43899. Add a --skip-integrationtests mode to test-webkitpy
  43900. https://bugs.webkit.org/show_bug.cgi?id=60354
  43901. These two test suites account for 2/3 of test-webkitpy's running time
  43902. because they're not actually unit tests. They're integration tests.
  43903. This patch adds the ability to skip integration tests by passing a
  43904. command line argument to test-webkitpy. The buildbots will continue to
  43905. run these integration tests to make sure they don't regress. This
  43906. option is for use by developers when working on parts of the code that
  43907. are well-covered by unit tests.
  43908. * Scripts/webkitpy/common/system/file_lock_integrationtest.py: Copied from Tools/Scripts/webkitpy/common/system/file_lock_unittest.py.
  43909. * Scripts/webkitpy/common/system/file_lock_unittest.py: Removed.
  43910. * Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Copied from Tools/Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py.
  43911. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py: Removed.
  43912. * Scripts/webkitpy/test/main.py:
  43913. 2011-05-06 Adam Barth <abarth@webkit.org>
  43914. Reviewed by Eric Seidel.
  43915. The results.zip generated by the Chromium EWS are too big
  43916. https://bugs.webkit.org/show_bug.cgi?id=60352
  43917. Currently results.zip created by the Chromium EWS bot contain roughly
  43918. 1000 tests that we expect to fail. These test results are not helpful
  43919. to contributors.
  43920. There are several approaches to solving this problem:
  43921. 1) We could be more selective about which files to include in the zip.
  43922. 2) We could ask new-run-webkit-tests not to generate results for
  43923. expected failures.
  43924. 3) We could ask new-run-webkit-tests not to run tests that we expect to
  43925. fail.
  43926. This patch takes approach (3). Currently, we're ignoring the outcome
  43927. of failing tests anyway, so there's not much point in actually running
  43928. them. As a side benefit, this will speed up the test run by about 6%.
  43929. In the future, we might revisit this decision and choose another
  43930. approach.
  43931. * Scripts/webkitpy/common/config/ports.py:
  43932. * Scripts/webkitpy/common/config/ports_unittest.py:
  43933. 2011-05-06 Gabor Rapcsanyi <rgabor@webkit.org>
  43934. Reviewed by Csaba Osztrogonác.
  43935. [Qt] Use qt-arm platform instead of qt-linux on ARM platform.
  43936. * Scripts/old-run-webkit-tests:
  43937. 2011-05-06 Adam Barth <abarth@webkit.org>
  43938. Reviewed by Ojan Vafai.
  43939. Add an option to NRWT to skip failing tests
  43940. https://bugs.webkit.org/show_bug.cgi?id=60295
  43941. This option is similar to the way old-run-webkit-tests works. We're
  43942. planning to use this option on the testing EWS bots because they don't
  43943. use information from failing tests yet.
  43944. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  43945. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  43946. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  43947. 2011-05-04 Philippe Normand <pnormand@igalia.com>
  43948. Reviewed by Dimitri Glazkov.
  43949. Implement LayoutTestController::pseudoShadowId()
  43950. https://bugs.webkit.org/show_bug.cgi?id=60034
  43951. shadowPseudoId support in the various LayoutTestController
  43952. implementations.
  43953. * DumpRenderTree/LayoutTestController.cpp:
  43954. (shadowPseudoIdCallback):
  43955. (LayoutTestController::staticFunctions):
  43956. * DumpRenderTree/LayoutTestController.h:
  43957. * DumpRenderTree/chromium/LayoutTestController.cpp:
  43958. (LayoutTestController::LayoutTestController):
  43959. (LayoutTestController::shadowPseudoId):
  43960. * DumpRenderTree/chromium/LayoutTestController.h:
  43961. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  43962. (LayoutTestController::shadowPseudoId):
  43963. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  43964. (LayoutTestController::shadowPseudoId):
  43965. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  43966. (LayoutTestController::shadowPseudoId):
  43967. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  43968. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  43969. (LayoutTestController::shadowPseudoId):
  43970. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  43971. (LayoutTestController::shadowPseudoId):
  43972. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  43973. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  43974. (WTR::LayoutTestController::shadowPseudoId):
  43975. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  43976. 2011-05-06 Adam Barth <abarth@webkit.org>
  43977. EWS can't reject patches
  43978. https://bugs.webkit.org/show_bug.cgi?id=60345
  43979. We're supposed to use patch.id() for the attachment ID, silly.
  43980. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  43981. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  43982. 2011-05-05 Steve Lacey <sjl@chromium.org>
  43983. Reviewed by Ojan Vafai.
  43984. Fix generation of results html file by passing relative path to scm
  43985. methods.
  43986. Generate diff images for results html file.
  43987. https://bugs.webkit.org/show_bug.cgi?id=60086
  43988. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  43989. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  43990. 2011-05-05 Andy Estes <aestes@apple.com>
  43991. Reviewed by Daniel Bates.
  43992. update-webkit should handle Internal using a different VCS than OpenSource.
  43993. https://bugs.webkit.org/show_bug.cgi?id=60310
  43994. isGit() and isSVN() cache their results, so Internal will always be
  43995. updated using the VCS commands used for OpenSource. If Internal uses a
  43996. different VCS, this will fail. Fix this by calling isGitDirectory() and
  43997. isSVNDirectory() instead, which do not cache their results.
  43998. * Scripts/update-webkit:
  43999. 2011-05-05 Dirk Pranke <dpranke@chromium.org>
  44000. Reviewed by Ojan Vafai.
  44001. nrwt: revamp integration tests incl. tests for servers
  44002. https://bugs.webkit.org/show_bug.cgi?id=59985
  44003. This change adds the ability to run "integration tests" that
  44004. depend on (and affect) the local environment on your machine.
  44005. These tests can be run manually by invoking python on the
  44006. test file in question and passing the '-i' flag, but are
  44007. not run automatically as part of test-webkitpy.
  44008. Integration tests are identified by being methods named as
  44009. "integration_test_*" instead of "test_*", and we use a
  44010. custom TestLoader instead of the default one provided by
  44011. unittest.
  44012. This change also adds a protected "_default_to_apache" method
  44013. to the port object so we can do the right thing when starting
  44014. and stopping web servers with less mechanism.
  44015. * Scripts/webkitpy/layout_tests/port/base.py:
  44016. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  44017. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  44018. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  44019. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  44020. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  44021. 2011-05-05 Adam Roben <aroben@apple.com>
  44022. Robustify DRT's pixel-dumping code against semi-random alpha channel values on Windows
  44023. DRT generates a pixel dump on Windows using the WM_PRINT message. This message (just like
  44024. most of GDI) doesn't write anything meaningful into the alpha channel. In some cases, the
  44025. alpha channel will even get filled with zeros (like when ::GradientFill is used). To
  44026. safeguard against this, we fill the alpha channel with constant full opacity after the
  44027. WM_PRINT message is handled to ensure we end up with an opaque image. (Note that we can't
  44028. just ignore the alpha channel when creating the PNG; Mac's pixel results have an alpha
  44029. channel, and we want to be able to compare Mac and Windows pixel results, so Windows pixel
  44030. results need an alpha channel, too.)
  44031. Fixes <http://webkit.org/b/60300> draws-gradient.html's pixel results can't be correctly
  44032. generated due to alpha channel weirdness
  44033. Reviewed by Sam Weinig.
  44034. * DumpRenderTree/win/PixelDumpSupportWin.cpp:
  44035. (makeAlphaChannelOpaque): Added this helper function to fill a bitmap's alpha channel with
  44036. constant full opacity.
  44037. (createBitmapContextFromWebView): Make the bitmap's alpha channel opaque before wrapping it
  44038. in a CGContext or cairo_surface.
  44039. 2011-05-05 Adam Roben <aroben@apple.com>
  44040. Add support for layoutTestController.dumpAsText(true) to WebKitTestRunner
  44041. Passing true tells the test harness to dump pixels even though we're not dumping a render
  44042. tree.
  44043. Fixes <http://webkit.org/b/60298> Calling layoutTestController.dumpAsText(true) in
  44044. WebKitTestRunner doesn't result in pixel results being generated
  44045. Reviewed by Sam Weinig.
  44046. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpPixels
  44047. argument to dumpAsText.
  44048. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  44049. (WTR::InjectedBundlePage::dump): Updated for dumpAsText change.
  44050. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  44051. (WTR::LayoutTestController::dumpAsText): Store the dumpPixels argument.
  44052. * WebKitTestRunner/InjectedBundle/LayoutTestController.h: Updated for IDL change.
  44053. * WebKitTestRunner/win/InjectedBundle.vcproj: Added .idl files as a convenience for Windows
  44054. developers.
  44055. 2011-05-05 Dirk Pranke <dpranke@chromium.org>
  44056. Reviewed by Ojan Vafai.
  44057. new-run-webkit-tests: merge os, version fields in test config
  44058. https://bugs.webkit.org/show_bug.cgi?id=60004
  44059. This change removes the 'o/s' field from the TestConfiguration
  44060. object, and changes the 'MAC', 'WIN', and 'LINUX' modifiers in
  44061. the expectations file to macros that expand to the version names
  44062. for each platform.
  44063. This means that you can once again put any subset of the
  44064. operating system versions on a single line, e.g.:
  44065. BUGX LEOPARD XP LINUX : fast/html/foo.html = FAIL
  44066. This change will break any existing test_expectations.txt
  44067. file that uses the "OS-VERSION" macros, which are no longer
  44068. needed. It turns out they were never needed, as just VERSION
  44069. by itself was sufficient. The test_expectations.txt file should
  44070. be updated accordingly prior to landing this change.
  44071. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  44072. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  44073. * Scripts/webkitpy/layout_tests/port/base.py:
  44074. 2011-05-05 Tony Chang <tony@chromium.org>
  44075. Reviewed by Adam Barth.
  44076. [chromium] switch from Lucida to free fonts for Hindi and Thai
  44077. https://bugs.webkit.org/show_bug.cgi?id=60287
  44078. The fonts are provided by the ttf-thai-tlwg and ttf-indic-fonts
  44079. packages on Lucid. There are actually multiple Thai fonts in the
  44080. package, so I just picked one.
  44081. * DumpRenderTree/chromium/TestShellGtk.cpp:
  44082. (setupFontconfig):
  44083. 2011-05-05 Tony Chang <tony@chromium.org>
  44084. Reviewed by Ojan Vafai.
  44085. [chromium] google-chrome-64 builds should now fallback to chromium-linux-x86_64 results
  44086. https://bugs.webkit.org/show_bug.cgi?id=60290
  44087. It used to be that google-chrome-32 was hardy32, google-chrome-64 was
  44088. hardy64, chromium-linux was hardy32 and chromium-linux-x86_64 was
  44089. lucid64. Because of that, google-chrome-64 used to skip the
  44090. chromium-linux-x86_64 results since they were more incorrect.
  44091. Now that we're switching to lucid for google-chrome, we want
  44092. google-chrome-64 to fall back to chromium-linux-x86_64.
  44093. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  44094. 2011-05-05 Dirk Pranke <dpranke@chromium.org>
  44095. Reviewed by Ojan Vafai.
  44096. new-run-webkit-tests: merge TestExpectations, TestExpectationsFile classes
  44097. https://bugs.webkit.org/show_bug.cgi?id=60002
  44098. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  44099. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  44100. * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  44101. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  44102. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  44103. * Scripts/webkitpy/style/checkers/test_expectations.py:
  44104. 2011-05-05 Eric Seidel <eric@webkit.org>
  44105. Reviewed by Adam Barth.
  44106. commit-queue should reject patches which fail ewses
  44107. https://bugs.webkit.org/show_bug.cgi?id=47534
  44108. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  44109. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  44110. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  44111. 2011-05-05 Chang Shu <cshu@webkit.org>
  44112. Reviewed by Andreas Kling.
  44113. [Qt][WK2] Support PageGroup in QGraphicsWKView/QWKPage constructors
  44114. https://bugs.webkit.org/show_bug.cgi?id=59638
  44115. 1. Call QGraphicsWKView constructor with pageGroupRef.
  44116. 2. Disable setFontFamily calls as it breaks Qt test fonts.
  44117. * WebKitTestRunner/TestController.cpp:
  44118. (WTR::TestController::resetStateToConsistentValues):
  44119. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  44120. (WTR::WebView::WebView):
  44121. (WTR::PlatformWebView::PlatformWebView):
  44122. 2011-05-05 Joseph Pecoraro <joepeck@webkit.org>
  44123. Reviewed by David Kilzer.
  44124. Add --only-webkit option to build-webkit
  44125. https://bugs.webkit.org/show_bug.cgi?id=60245
  44126. * Scripts/build-webkit: If --only-webkit was specified
  44127. just build the WebKit project, and not its dependencies.
  44128. 2011-05-05 Jeff Miller <jeffm@apple.com>
  44129. Reviewed by Darin Adler.
  44130. Add didNotHandleWheelEvent callback to WKPageUIClient
  44131. https://bugs.webkit.org/show_bug.cgi?id=60203
  44132. * MiniBrowser/gtk/BrowserWindow.c:
  44133. (browserWindowUIClientInit): Stub out didNotHandleWheelEvent callback.
  44134. * MiniBrowser/mac/BrowserWindowController.m:
  44135. (-[BrowserWindowController awakeFromNib]): Stub out didNotHandleWheelEvent callback.
  44136. * MiniBrowser/win/BrowserView.cpp:
  44137. (BrowserView::create): Stub out didNotHandleWheelEvent callback.
  44138. * WebKitTestRunner/TestController.cpp:
  44139. (WTR::TestController::createOtherPage): Stub out didNotHandleWheelEvent callback.
  44140. (WTR::TestController::initialize): Stub out didNotHandleWheelEvent callback.
  44141. 2011-05-04 Eric Seidel <eric@webkit.org>
  44142. Reviewed by Adam Barth.
  44143. Add more missing imports from scm refactor
  44144. https://bugs.webkit.org/show_bug.cgi?id=60239
  44145. * Scripts/webkitpy/common/checkout/scm/git.py:
  44146. * Scripts/webkitpy/common/checkout/scm/svn.py:
  44147. 2011-05-04 Eric Seidel <eric@webkit.org>
  44148. Reviewed by Adam Barth.
  44149. sheriff-bot is having more exception trouble
  44150. https://bugs.webkit.org/show_bug.cgi?id=60233
  44151. A webpage-forced build was causing SB to throw an exception.
  44152. We've long had this bug, but we just didn't notice it until now.
  44153. In debugging this I found we fetch an absurd amount of data now
  44154. that we use buildbot's json (instead of xmlrpc), so I added
  44155. the filter=1 parameter to reduce it a little. That required
  44156. me to handle the case where filter=1 would strip
  44157. result=0 in some cases (it's unclear why it does that).
  44158. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  44159. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  44160. 2011-05-04 Cris Neckar <cdn@chromium.org>
  44161. Unreviewed, Adding Cris Neckar as a committer
  44162. * Scripts/webkitpy/common/config/committers.py:
  44163. 2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>
  44164. Reviewed by Laszlo Gombos.
  44165. [Qt][Wk2][Symbian] Capabilities for Qt MiniBrowser and QtWebProcess on Symbian
  44166. https://bugs.webkit.org/show_bug.cgi?id=59462
  44167. * MiniBrowser/qt/MiniBrowser.pro: Add Symbian OS capabilities to executable. Also enable data paging.
  44168. 2011-05-04 Eric Seidel <eric@webkit.org>
  44169. Reviewed by Adam Barth.
  44170. The testing EWS bots should upload layout-test-results.zip to bugs after failures
  44171. https://bugs.webkit.org/show_bug.cgi?id=60223
  44172. This required sharing a bit of code between the commit-queue
  44173. (which already knew how to do this) and the new EWS testing bots.
  44174. In the process I also cleaned up EWS testing a little and
  44175. removed some dead code from the commit-queue.
  44176. * Scripts/webkitpy/common/config/committervalidator.py:
  44177. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  44178. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  44179. * Scripts/webkitpy/tool/commands/queues.py:
  44180. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  44181. 2011-05-04 James Kozianski <koz@chromium.org>
  44182. Reviewed by Eric Seidel.
  44183. Add method to make a Port able to retrieve TestOutputSets from its builders.
  44184. https://bugs.webkit.org/show_bug.cgi?id=58211
  44185. This will be used in the new rebaseline script - TestOutputs are
  44186. potential new baselines.
  44187. * Scripts/webkitpy/common/config/urls.py:
  44188. * Scripts/webkitpy/layout_tests/port/base.py:
  44189. * Scripts/webkitpy/layout_tests/port/chromium.py:
  44190. * Scripts/webkitpy/layout_tests/port/factory.py:
  44191. * Scripts/webkitpy/layout_tests/port/webkit.py:
  44192. 2011-05-04 Eric Seidel <eric@webkit.org>
  44193. Reviewed by Ojan Vafai.
  44194. sheriff-bot can't parse results.html
  44195. https://bugs.webkit.org/show_bug.cgi?id=60196
  44196. The problem was that the NRWT bots are currently core
  44197. and so sheriff-bot was trying to diagnose failures on
  44198. them. It was trying to parse their results.html file
  44199. and BeautifulSoup was throwing an exception.
  44200. It seems our version of BeautifulSoup was quite old
  44201. and unable to handle <script> tags correctly.
  44202. This moves us to 3.2 which doesn't seem to have this bug.
  44203. * Scripts/webkitpy/thirdparty/BeautifulSoup.py:
  44204. 2011-05-04 Adam Barth <abarth@webkit.org>
  44205. Reviewed by Eric Seidel.
  44206. Make the EWS test logging less verbose
  44207. https://bugs.webkit.org/show_bug.cgi?id=60201
  44208. This should help us generate less than a hundred MB of logs per hour.
  44209. * Scripts/webkitpy/common/config/ports.py:
  44210. * Scripts/webkitpy/common/config/ports_unittest.py:
  44211. 2011-05-04 Tao Bai <michaelbai@chromium.org>
  44212. Reviewed by David Kilzer.
  44213. Populate touch-icon url to FrameLoaderClient
  44214. https://bugs.webkit.org/show_bug.cgi?id=59143
  44215. Disable touch icon by default.
  44216. * Scripts/build-webkit:
  44217. 2011-05-04 Justin Novosad <junov@chromium.org>
  44218. Reviewed by Kenneth Russell.
  44219. [Chromium] Add gpu acceleration flags to DumpRenderTree
  44220. https://bugs.webkit.org/show_bug.cgi?id=60168
  44221. Adding support for command line flags
  44222. enable-accelerated-2d-canvas an
  44223. enable-accelerated-drawing in DumpRenderTree.
  44224. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  44225. (main):
  44226. * DumpRenderTree/chromium/TestShell.cpp:
  44227. (TestShell::TestShell):
  44228. (TestShell::resetWebSettings):
  44229. * DumpRenderTree/chromium/TestShell.h:
  44230. (TestShell::setLegacyAccelerated2dCanvasEnabled):
  44231. (TestShell::setAcceleratedDrawingEnabled):
  44232. * DumpRenderTree/chromium/WebPreferences.cpp:
  44233. (WebPreferences::reset):
  44234. (WebPreferences::applyTo):
  44235. * DumpRenderTree/chromium/WebPreferences.h:
  44236. 2011-05-04 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
  44237. Reviewed by Csaba Osztrogonác.
  44238. [Qt] run-qtwebkit-tests misses exec bit
  44239. https://bugs.webkit.org/show_bug.cgi?id=60188
  44240. Also removing an unecessary import (mostly to let this bugfix goes
  44241. through the system, as this is just a chmod).
  44242. * Scripts/run-qtwebkit-tests:
  44243. 2011-05-04 Adam Barth <abarth@webkit.org>
  44244. Fix import of ircproxy module to actually import the module. I don't
  44245. really understand how this code could have worked before.
  44246. * Scripts/webkitpy/common/host.py:
  44247. 2011-05-04 Siddharth Mathur <siddharth.mathur@nokia.com>
  44248. Reviewed by Andreas Kling.
  44249. [Qt][Wk2][Symbian] Minor UI facelift for MiniBrowser
  44250. https://bugs.webkit.org/show_bug.cgi?id=60172
  44251. * MiniBrowser/qt/BrowserWindow.cpp: Bring in UI layout changes from QtTestBrowser
  44252. (BrowserWindow::BrowserWindow):
  44253. 2011-05-04 Mihai Parparita <mihaip@chromium.org>
  44254. Reviewed by Ojan Vafai.
  44255. [NRWT] --new-baseline should put baselines in the directory specified by --additional-platform-directory
  44256. https://bugs.webkit.org/show_bug.cgi?id=60088
  44257. Makes --new-baseline put new baselines into the first entry in the
  44258. baseline search path, including any additional directories passed in via
  44259. --additional-platform-directory.
  44260. Simplifies baseline_path() by making it return the first entry in the
  44261. baseline search path instead of requiring each port to have an
  44262. implementation (should not result in any behavior change).
  44263. * Scripts/webkitpy/layout_tests/port/base.py:
  44264. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  44265. * Scripts/webkitpy/layout_tests/port/chromium.py:
  44266. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  44267. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  44268. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  44269. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  44270. * Scripts/webkitpy/layout_tests/port/mac.py:
  44271. * Scripts/webkitpy/layout_tests/port/test.py:
  44272. * Scripts/webkitpy/layout_tests/port/webkit.py:
  44273. 2011-05-04 Adam Barth <abarth@webkit.org>
  44274. Reviewed by Eric Seidel.
  44275. Fix circular dependency in webkitpy
  44276. https://bugs.webkit.org/show_bug.cgi?id=60075
  44277. These functions don't belong in bugzilla.py. They only exist there
  44278. because they are old. Really, these functions shouldn't be free
  44279. functions at all, but that's a patch for another day.
  44280. * Scripts/webkitpy/common/checkout/changelog.py:
  44281. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  44282. * Scripts/webkitpy/common/checkout/checkout.py:
  44283. * Scripts/webkitpy/common/config/urls.py:
  44284. * Scripts/webkitpy/common/net/bugzilla/__init__.py:
  44285. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  44286. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  44287. * Scripts/webkitpy/style/checkers/changelog.py:
  44288. * Scripts/webkitpy/tool/bot/irc_command.py:
  44289. * Scripts/webkitpy/tool/bot/sheriff.py:
  44290. * Scripts/webkitpy/tool/commands/upload.py:
  44291. 2011-05-03 Pratik Solanki <psolanki@apple.com>
  44292. Reviewed by Dan Bernstein.
  44293. https://bugs.webkit.org/show_bug.cgi?id=60141
  44294. Remove reference to libWebKitSystemInterfaceTiger.a from build-webkit
  44295. * Scripts/build-webkit:
  44296. 2011-05-03 Mihai Parparita <mihaip@chromium.org>
  44297. Reviewed by Ojan Vafai.
  44298. Update rebaseline queue server to handle hierarchical test results
  44299. https://bugs.webkit.org/show_bug.cgi?id=60063
  44300. Update test result parsing done by the rebaseline queue server to handle
  44301. the hierarchical test result output that is generated as of r85254.
  44302. * RebaselineQueueServer/templates/builder-queue-edit.html:
  44303. 2011-05-03 Eric Seidel <eric@webkit.org>
  44304. Reviewed by Adam Roben.
  44305. webkit-patch post-commits HEAD^.. throws an exception
  44306. https://bugs.webkit.org/show_bug.cgi?id=60027
  44307. * Scripts/webkitpy/common/checkout/scm/git.py:
  44308. 2011-05-03 Luiz Agostini <luiz.agostini@openbossa.org>
  44309. Reviewed by Kenneth Rohde Christiansen.
  44310. [Qt] Layout tests may timeout if loadFinished receives false
  44311. https://bugs.webkit.org/show_bug.cgi?id=60064
  44312. When using layoutTestController.queueLoad(), if QWebPage::loadFinished(bool) receives false
  44313. then the layout test may timout. It happens that QWebPage::loadFinished() receives false when
  44314. a response is ignored, like it should be for 204 responses. It is a problem for creating
  44315. tests for 204 responses for example.
  44316. This change has been tested and it causes no regressions in layout tests.
  44317. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  44318. (LayoutTestController::maybeDump):
  44319. 2011-05-03 Dirk Pranke <dpranke@chromium.org>
  44320. Unreviewed, rolling out r85659.
  44321. http://trac.webkit.org/changeset/85659
  44322. https://bugs.webkit.org/show_bug.cgi?id=59977
  44323. restarting isn't working correctly
  44324. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  44325. * Scripts/webkitpy/layout_tests/port/http_server.py:
  44326. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  44327. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  44328. 2011-05-03 Dirk Pranke <dpranke@chromium.org>
  44329. Reviewed by Ojan Vafai.
  44330. new-run-webkit-tests: fix http server startup/shutdown
  44331. Previous versions of the code had three problems that made startup
  44332. and shutdown flaky. The first is that it would throw exceptions
  44333. if it couldn't delete stale log files, which was overly
  44334. paranoid. The second is that some of the exceptions weren't
  44335. defined properly. The third, and most important, is that it was
  44336. using urllib to check if ports were available, which was leaving
  44337. sockets in a half-closed state, and keeping ports from being
  44338. reused. By switching to raw sockets, we are able to now reliably
  44339. restart.
  44340. This change also switches the code to using Executives to stop
  44341. processes, which will let us delete a bunch of code in the
  44342. port/* implementations and fix a weird layering problem in a
  44343. subsequent patch.
  44344. https://bugs.webkit.org/show_bug.cgi?id=59977
  44345. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  44346. * Scripts/webkitpy/layout_tests/port/http_server.py:
  44347. * Scripts/webkitpy/layout_tests/port/http_server_base.py:
  44348. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  44349. 2011-05-03 Dirk Pranke <dpranke@chromium.org>
  44350. Reviewed by Adam Barth.
  44351. fix failing printing_unittest on win32
  44352. https://bugs.webkit.org/show_bug.cgi?id=59963
  44353. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  44354. 2011-05-03 Adam Roben <aroben@apple.com>
  44355. Fix most strict PassOwnPtr violations on Windows
  44356. Fixes <http://webkit.org/b/60025> Windows should (almost) build with strict PassOwnPtr
  44357. enabled
  44358. Reviewed by Anders Carlsson.
  44359. * WebKitAPITest/Test.h: Use adoptPtr.
  44360. 2011-05-03 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
  44361. Reviewed by Andreas Kling.
  44362. Add myself to the committers list.
  44363. * Scripts/webkitpy/common/config/committers.py:
  44364. 2011-05-03 James Robinson <jamesr@chromium.org>
  44365. Reviewed by Kenneth Russell.
  44366. [chromium] Layout test animations/3d/replace-filling-transform.html failing
  44367. https://bugs.webkit.org/show_bug.cgi?id=59839
  44368. Add animations/3d to the list of tests run in the chromium-gpu configuration since these tests exercise the compositor.
  44369. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  44370. 2011-05-03 Lucas De Marchi <lucas.demarchi@profusion.mobi>
  44371. Unreviewed, rolling out r85471.
  44372. http://trac.webkit.org/changeset/85471
  44373. https://bugs.webkit.org/show_bug.cgi?id=59922
  44374. The rule of thumb in EFL is that you init in all the places
  44375. you use it. So, if in your application you call ecore_evas_*
  44376. functions, you have to call ecore_evas_init() first.
  44377. * EWebLauncher/main.c: always call *_init() functions when you use
  44378. that namespace.
  44379. (quit):
  44380. (main):
  44381. 2011-05-02 Ojan Vafai <ojan@chromium.org>
  44382. Reviewed by Tony Chang.
  44383. remove no longer used method
  44384. https://bugs.webkit.org/show_bug.cgi?id=59981
  44385. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  44386. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  44387. 2011-05-02 Ojan Vafai <ojan@chromium.org>
  44388. Reviewed by Tony Chang.
  44389. add image toggling behavior from old-run-webkit-tests
  44390. https://bugs.webkit.org/show_bug.cgi?id=59978
  44391. Output -diffs.html files. This matches old-run-webkit-tests.
  44392. In theory, we could use data urls in the results.html file, but
  44393. data urls don't currently have access to local files.
  44394. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  44395. 2011-05-02 Tony Chang <tony@chromium.org>
  44396. Reviewed by Ojan Vafai.
  44397. [nrwt] remove some obsolete references to .checksum files
  44398. https://bugs.webkit.org/show_bug.cgi?id=59971
  44399. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  44400. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  44401. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  44402. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  44403. * Scripts/webkitpy/layout_tests/port/test.py:
  44404. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  44405. 2011-05-02 Adam Roben <aroben@apple.com>
  44406. Take advantage of implicit nullptr_t -> PassOwnPtr conversion
  44407. Fixes <http://webkit.org/b/59964> Implicit conversion from std::nullptr_t to PassOwnPtr
  44408. doesn't work, but should
  44409. Reviewed by Adam Barth.
  44410. * DumpRenderTree/chromium/CppBoundClass.h:
  44411. * DumpRenderTree/chromium/WebViewHost.cpp:
  44412. 2011-05-02 Martin Robinson <mrobinson@igalia.com>
  44413. Reviewed by Xan Lopez.
  44414. [GTK] Compiler warning in Tools/MiniBrowser/main.c
  44415. https://bugs.webkit.org/show_bug.cgi?id=59986
  44416. Remove a compiler warning.
  44417. * MiniBrowser/gtk/main.c: Use full array initializers to prevent some compilers
  44418. from complaining.
  44419. 2011-05-02 Adam Barth <abarth@webkit.org>
  44420. Reviewed by Eric Seidel.
  44421. Add runtests_unittest.py
  44422. https://bugs.webkit.org/show_bug.cgi?id=59955
  44423. I forgot to add this file in a previous patch.
  44424. * Scripts/webkitpy/tool/steps/runtests_unittest.py: Added.
  44425. 2011-05-02 Adam Barth <abarth@webkit.org>
  44426. Change the testing EWS to log failures explicitly to avoid an infinite loop.
  44427. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  44428. 2011-05-02 Adrienne Walker <enne@google.com>
  44429. Unreviewed, fix misspelled contributor name.
  44430. * Scripts/webkitpy/common/config/committers.py:
  44431. 2011-05-02 Adam Barth <abarth@webkit.org>
  44432. Reviewed by Eric Seidel.
  44433. cr-linux-ews should run tests
  44434. https://bugs.webkit.org/show_bug.cgi?id=59272
  44435. This patch turns on testing for the cr-linux-ews. Yay!
  44436. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py:
  44437. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  44438. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  44439. * Scripts/webkitpy/tool/steps/runtests.py:
  44440. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  44441. 2011-05-02 Martin Robinson <mrobinson@igalia.com>
  44442. Incorporate a review comment that I mistakenly omitted from my last commit.
  44443. * DumpRenderTree/gtk/EventSender.cpp: Use unsigned here instead of unsigned int.
  44444. 2011-05-02 Adam Barth <abarth@webkit.org>
  44445. Reviewed by Eric Seidel.
  44446. EWS should report the list of unexpected failures
  44447. https://bugs.webkit.org/show_bug.cgi?id=59923
  44448. We cache the results of the first layout test results run on the task
  44449. so the EWS can grab them later. Another option is to include them in
  44450. the exception that's thrown, but this approach seemed slightly more
  44451. aesthetic.
  44452. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  44453. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  44454. 2011-05-02 Adam Barth <abarth@webkit.org>
  44455. Reviewed by Eric Seidel.
  44456. Add base case for a test-running EWS
  44457. https://bugs.webkit.org/show_bug.cgi?id=59920
  44458. Later I will subclass this to run the Chromium Linux EWS.
  44459. * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
  44460. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  44461. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  44462. 2011-05-02 Anders Carlsson <andersca@apple.com>
  44463. Build fix.
  44464. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  44465. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  44466. 2011-05-02 Nico Weber <thakis@chromium.org>
  44467. Reviewed by Mihai Parparita.
  44468. Add --no-webkit2 to the output of "build-webkit -h"
  44469. https://bugs.webkit.org/show_bug.cgi?id=59942
  44470. * Scripts/build-webkit:
  44471. 2011-05-02 Martin Robinson <mrobinson@igalia.com>
  44472. Reviewed by Xan Lopez.
  44473. [GTK] old-run-webkit-tests should disable the Ubuntu overlay scrollbar
  44474. https://bugs.webkit.org/show_bug.cgi?id=59943
  44475. Disable the Ubuntu overlay scrollbar while testing, by injecting the
  44476. LIBOVERLAY_SCROLLBAR=0 environment variable.
  44477. * Scripts/old-run-webkit-tests:
  44478. 2011-05-02 Martin Robinson <mrobinson@igalia.com>
  44479. Reviewed by Eric Seidel.
  44480. [GTK] editing/selection/select-out-of-editable.html failing after r83967
  44481. https://bugs.webkit.org/show_bug.cgi?id=58667
  44482. Do not trigger mouse down events when the EventSender knows that a mouse button is
  44483. already down. These type of situations can confuse Xvfb and cause dragging failures.
  44484. * DumpRenderTree/gtk/EventSender.cpp:
  44485. (mouseDownCallback): Do not trigger another mouse button down event if the mouse button
  44486. is already down. This can interfere with drags in Xvfb.
  44487. 2011-05-02 Zsolt Fehér <h490267@stud.u-szeged.hu>
  44488. Reviewed by Csaba Osztrogonác.
  44489. DRT sideeffect revealed by r71268.
  44490. https://bugs.webkit.org/show_bug.cgi?id=48958
  44491. Reset QWebSettings::ZoomTextOnly attribute before all tests.
  44492. Call setTextSizeMultiplier(1.0) to reset TextZoomFactor and
  44493. PageZoomFactor too. It should be done before resetsettings()
  44494. to guarantee resetting QWebSettings::ZoomTextOnly correctly.
  44495. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  44496. (WebCore::WebPage::resetSettings):
  44497. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  44498. 2011-05-02 Sheriff Bot <webkit.review.bot@gmail.com>
  44499. Unreviewed, rolling out r85469.
  44500. http://trac.webkit.org/changeset/85469
  44501. https://bugs.webkit.org/show_bug.cgi?id=59928
  44502. Broke webkitpy-tests on Windows 7, GTK and Qt. (Requested by
  44503. bbandix on #webkit).
  44504. * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Removed.
  44505. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  44506. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  44507. 2011-05-02 Tomasz Morawski <t.morawski@samsung.com>
  44508. Reviewed by Kenneth Rohde Christiansen.
  44509. Cleanup EFL initialization/shutdown in the EWebLauncher
  44510. https://bugs.webkit.org/show_bug.cgi?id=59922
  44511. Removed ecore_evas_init and edje_init form main function due to they
  44512. are also called in the ewk_init. Moved ewk_shutdown to quit function.
  44513. * EWebLauncher/main.c:
  44514. (quit):
  44515. (main):
  44516. 2011-05-02 Adam Barth <abarth@webkit.org>
  44517. Reviewed by Eric Seidel.
  44518. Add base case for a test-running EWS
  44519. https://bugs.webkit.org/show_bug.cgi?id=59920
  44520. Later I will subclass this to run the Chromium Linux EWS.
  44521. * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py: Added.
  44522. * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
  44523. * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
  44524. 2011-05-02 Adam Barth <abarth@webkit.org>
  44525. Reviewed by Eric Seidel.
  44526. Add the ability to skip python and perl unit tests on EC2
  44527. https://bugs.webkit.org/show_bug.cgi?id=59918
  44528. * Scripts/webkitpy/common/config/ports.py:
  44529. - This is slightly ugly, but it's useful...
  44530. * Scripts/webkitpy/common/config/ports_unittest.py:
  44531. * Scripts/webkitpy/tool/mocktool.py:
  44532. * Scripts/webkitpy/tool/steps/runtests.py:
  44533. 2011-05-02 Adam Barth <abarth@webkit.org>
  44534. Reviewed by Eric Seidel.
  44535. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  44536. 2011-04-29 Kevin Ollivier <kevino@theolliviers.com>
  44537. [wx] Unreviewed build fix, add new directory to the build.
  44538. * waf/build/settings.py:
  44539. 2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
  44540. Reviewed by Martin Robinson.
  44541. [GTK] Implement UI client in minibrowser
  44542. https://bugs.webkit.org/show_bug.cgi?id=58416
  44543. It also allows to open more than one minibrowser window from the
  44544. command line.
  44545. * MiniBrowser/gtk/BrowserWindow.c:
  44546. (browserWindowFinalize):
  44547. (browser_window_init):
  44548. (browserWindowConstructed):
  44549. (createNewPage):
  44550. (showPage):
  44551. (closePage):
  44552. (runJavaScriptAlert):
  44553. (browserWindowUIClientInit):
  44554. * MiniBrowser/gtk/main.c:
  44555. (loadURI):
  44556. (main):
  44557. 2011-04-29 Carlos Garcia Campos <cgarcia@igalia.com>
  44558. Reviewed by Martin Robinson.
  44559. [GTK] Implement page loader client in MiniBrowser
  44560. https://bugs.webkit.org/show_bug.cgi?id=58024
  44561. A new class BrowserWindow has been added to implement the page
  44562. loader client. It makes supporting multiple windows easier. Window
  44563. title and url entry are now updated during the loading process.
  44564. * MiniBrowser/gtk/BrowserWindow.c: Added.
  44565. (activateUriEntryCallback):
  44566. (goBackCallback):
  44567. (goForwardCallback):
  44568. (browserWindowFinalize):
  44569. (browserWindowGetProperty):
  44570. (browserWindowSetProperty):
  44571. (browser_window_init):
  44572. (browserWindowConstructed):
  44573. (browser_window_class_init):
  44574. (browserWindowUpdateTitle):
  44575. (browserWindowSetTitle):
  44576. (browserWindowSetLoadProgress):
  44577. (browserWindowUpdateURL):
  44578. (didStartProvisionalLoadForFrame):
  44579. (didReceiveServerRedirectForProvisionalLoadForFrame):
  44580. (didFailProvisionalLoadWithErrorForFrame):
  44581. (didCommitLoadForFrame):
  44582. (didFinishDocumentLoadForFrame):
  44583. (didFinishLoadForFrame):
  44584. (didFailLoadWithErrorForFrame):
  44585. (didReceiveTitleForFrame):
  44586. (didFirstLayoutForFrame):
  44587. (didFirstVisuallyNonEmptyLayoutForFrame):
  44588. (didRemoveFrameFromHierarchy):
  44589. (didStartProgress):
  44590. (didChangeProgress):
  44591. (didFinishProgress):
  44592. (didBecomeUnresponsive):
  44593. (didBecomeResponsive):
  44594. (browserWindowLoaderClientInit):
  44595. (browser_window_new):
  44596. (browser_window_get_view):
  44597. * MiniBrowser/gtk/BrowserWindow.h: Added.
  44598. * MiniBrowser/gtk/GNUmakefile.am:
  44599. * MiniBrowser/gtk/main.c:
  44600. (createWindow):
  44601. 2011-04-28 Stephanie Lewis <slewis@apple.com>
  44602. Reviewed by Mark Rowe.
  44603. http://bugs.webkit.org/show_bug.cgi?id=59743
  44604. <rdar://problem/9040413> Add an install target for production builds.
  44605. * DumpRenderTree/mac/PerlSupport/Makefile:
  44606. 2011-04-28 Adam Roben <aroben@apple.com>
  44607. Stop and restart ATSServer before each test run on Leopard
  44608. This is to work around an ATSServer leak that eventually causes tests
  44609. to fail.
  44610. Fixes <http://webkit.org/b/51807> <rdar://problem/9273894>
  44611. fast/blockflow/broken-ideograph-[small-caps|font].html sometimes fails on Leopard buildbots
  44612. (due to ATSServer leak)
  44613. Reviewed by Dan Bernstein.
  44614. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  44615. (StopATSServer):
  44616. (StartATSServer):
  44617. Added these new commands to stop and start ATSServer.
  44618. (TestFactory.__init__): Stop and start ATSServer on Leopard before running tests.
  44619. 2011-04-28 Dirk Pranke <dpranke@chromium.org>
  44620. Reviewed by Adam Roben.
  44621. add Leopard NRWT bot to the scheduler
  44622. https://bugs.webkit.org/show_bug.cgi?id=59766
  44623. * BuildSlaveSupport/build.webkit.org-config/config.json:
  44624. 2011-04-28 Sam Weinig <sam@webkit.org>
  44625. Fix WebKitTestRunner build.
  44626. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  44627. The Derived Sources target needs a product name.
  44628. 2011-04-28 Sam Weinig <sam@webkit.org>
  44629. Reviewed by Mark Rowe.
  44630. Add install support for WebKitTestRunner.
  44631. <rdar://problem/9349055>
  44632. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  44633. Add missing CompilerVersion.xcconfig.
  44634. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  44635. * WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:
  44636. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  44637. Add install path and tell it not to skip installation.
  44638. Add missing CompilerVersion.xcconfig.
  44639. 2011-04-28 David Levin <levin@chromium.org>
  44640. Reviewed by Adam Barth.
  44641. Remove IMAGE_RESIZER related code.
  44642. https://bugs.webkit.org/show_bug.cgi?id=59735
  44643. * Scripts/build-webkit:
  44644. 2011-04-28 Sam Weinig <sam@webkit.org>
  44645. Reviewed by Adam Roben.
  44646. Make reading skipped files from additional platform
  44647. directories work in WebKit2 mode.
  44648. * Scripts/old-run-webkit-tests:
  44649. (buildPlatformTestHierarchy): Simplify logic to always use the first
  44650. and last platforms in the build hierarchy as the test hierarchy, and to
  44651. insert the WebKit2 platform in the middle if it exists. Yum.
  44652. 2011-04-28 Adam Barth <abarth@webkit.org>
  44653. Reviewed by Eric Seidel.
  44654. Remove WML
  44655. https://bugs.webkit.org/show_bug.cgi?id=59678
  44656. Remove build system integration and test harness integration for WML.
  44657. * Scripts/build-webkit:
  44658. * Scripts/old-run-webkit-tests:
  44659. * Scripts/webkitperl/features.pm:
  44660. * Scripts/webkitpy/layout_tests/port/webkit.py:
  44661. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  44662. 2011-04-28 Ojan Vafai <ojan@chromium.org>
  44663. Reviewed by Mihai Parparita.
  44664. use a hierarchical data structure to store results json
  44665. https://bugs.webkit.org/show_bug.cgi?id=59736
  44666. Instead of a map from test name to results dict, we now store a hierarchical
  44667. data structure.
  44668. Old: { foo/bar/baz.html: results_dict, foo/bar/baz2.html: results_dict }
  44669. New:
  44670. { foo: {
  44671. bar: {
  44672. baz.html: results_dict,
  44673. baz2.html: results_dict } } }
  44674. This cut ~52% of the size of times_ms.json. I expect it will cut
  44675. 30-40% of full_results.json and unexpected_results.json.
  44676. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  44677. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  44678. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  44679. Using os.sep was just wrong since relative_test_filename canonicalizes separators.
  44680. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  44681. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  44682. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  44683. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  44684. Instead of plumbing through the change to all of the rebaselineserver
  44685. python and JS, just convert to the old format after reading in the json.
  44686. 2011-04-28 Eric Seidel <eric@webkit.org>
  44687. Reviewed by Adam Barth.
  44688. EWS Bubbles should show commit-queue position when patch is in the commit-queue
  44689. https://bugs.webkit.org/show_bug.cgi?id=59744
  44690. Add target="_top" to the bubble links. This was
  44691. forgotten when I moved from using an onclick to a normal link.
  44692. * QueueStatusServer/templates/statusbubble.html:
  44693. 2011-04-28 Eric Seidel <eric@webkit.org>
  44694. Reviewed by Adam Barth.
  44695. EWS bubbles should show "submit to ews" button if they've not been processed
  44696. https://bugs.webkit.org/show_bug.cgi?id=59751
  44697. * QueueStatusServer/handlers/statusbubble.py:
  44698. * QueueStatusServer/handlers/submittoews.py:
  44699. * QueueStatusServer/templates/statusbubble.html:
  44700. * QueueStatusServer/templates/submittoews.html:
  44701. 2011-04-28 Eric Seidel <eric@webkit.org>
  44702. Reviewed by Adam Barth.
  44703. EWS Bubbles should show commit-queue position when patch is in the commit-queue
  44704. https://bugs.webkit.org/show_bug.cgi?id=59744
  44705. This was actually just a 2 line change to statusbubble.py.
  44706. I also cleaned up statusbubble.html a little while I was there
  44707. (the links are now actual <a> tags and have hover).
  44708. * QueueStatusServer/handlers/statusbubble.py:
  44709. * QueueStatusServer/templates/statusbubble.html:
  44710. 2011-04-28 Dirk Pranke <dpranke@chromium.org>
  44711. Reviewed by Eric Seidel.
  44712. add a mac leopard release NRWT bot
  44713. https://bugs.webkit.org/show_bug.cgi?id=59733
  44714. * BuildSlaveSupport/build.webkit.org-config/config.json:
  44715. 2011-04-28 Ojan Vafai <ojan@chromium.org>
  44716. Avoid crashing when running new-run-webkit-tests outside of
  44717. version control.
  44718. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  44719. 2011-04-28 Xan Lopez <xlopez@igalia.com>
  44720. Unreviewed build fix.
  44721. * GNUmakefile.am:
  44722. 2011-04-28 Ojan Vafai <ojan@chromium.org>
  44723. Reviewed by Eric Seidel.
  44724. fix python printing test
  44725. https://bugs.webkit.org/show_bug.cgi?id=59719
  44726. Now that we run scm commands in summarize_results, --verbose prints
  44727. debug logging to stderr.
  44728. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  44729. 2011-04-28 Ojan Vafai <ojan@chromium.org>
  44730. Reviewed by Tony Chang.
  44731. link to tests at a specific revision in the results.html file
  44732. https://bugs.webkit.org/show_bug.cgi?id=59711
  44733. * Scripts/webkitpy/common/checkout/scm.py:
  44734. Add a method to get the head svn revision.
  44735. * Scripts/webkitpy/common/checkout/scm_unittest.py:
  44736. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  44737. Include the svn revision in the results json.
  44738. 2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
  44739. Reviewed by Sam Weinig.
  44740. [GTK] Remove WKURLCreateWithURL()
  44741. https://bugs.webkit.org/show_bug.cgi?id=59691
  44742. Use WKURLCreateWithUTF8CString() instead of WKURLCreateWithURL().
  44743. * MiniBrowser/gtk/main.c:
  44744. (activateUriEntryCallback):
  44745. (main):
  44746. 2011-04-28 Carlos Garcia Campos <cgarcia@igalia.com>
  44747. Reviewed by Martin Robinson.
  44748. [GTK] WKView should be a GtkWidget
  44749. https://bugs.webkit.org/show_bug.cgi?id=59603
  44750. Don't use WKViewGetWindow(), use WKView as a GtkWidget instead.
  44751. * MiniBrowser/gtk/main.c:
  44752. (createWindow):
  44753. (main):
  44754. 2011-04-28 Gabor Rapcsanyi <rgabor@webkit.org>
  44755. Reviewed by Csaba Osztrogonác.
  44756. [Qt] Add ARM specific Skipped list
  44757. https://bugs.webkit.org/show_bug.cgi?id=59680
  44758. * Scripts/old-run-webkit-tests:
  44759. * Scripts/webkitdirs.pm:
  44760. 2011-04-27 Eric Seidel <eric@webkit.org>
  44761. Reviewed by Adam Barth.
  44762. error_log.txt should include PHP errors
  44763. https://bugs.webkit.org/show_bug.cgi?id=59643
  44764. Turns out this was really easy after I finally learned
  44765. enough about PHP to do it...
  44766. I'm adding this in hopes of better tracking down
  44767. our random http failures.
  44768. * Scripts/webkitperl/httpd.pm:
  44769. 2011-04-27 David Levin <levin@chromium.org>
  44770. Reviewed by Adam Barth.
  44771. check-webkit-style should flags spacing errors for braces on the same line.
  44772. https://bugs.webkit.org/show_bug.cgi?id=59665
  44773. * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  44774. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added some tests for the check
  44775. and fixed some test cases to not trigger this error since it isn't what they are verifying.
  44776. 2011-04-27 David Levin <levin@chromium.org>
  44777. Reviewed by Adam Barth.
  44778. check-webkit-style error for spaces after periods in a comment has a bad error
  44779. message and warns about end of line spaces.
  44780. https://bugs.webkit.org/show_bug.cgi?id=59663
  44781. * Scripts/webkitpy/style/checkers/cpp.py: Fix both issues.
  44782. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for spaces at the end of line
  44783. and changed the error messages.
  44784. 2011-04-27 Ojan Vafai <ojan@chromium.org>
  44785. remove assertion now that platform/mac-tiger no longer exists
  44786. https://bugs.webkit.org/show_bug.cgi?id=59660
  44787. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  44788. 2011-04-27 Ojan Vafai <ojan@chromium.org>
  44789. Reviewed by Eric Seidel.
  44790. remove test that didn't make sense
  44791. https://bugs.webkit.org/show_bug.cgi?id=59658
  44792. It was artifically saying the test wasn't expected to pass,
  44793. but the expectations string was empty. The case of unexpected
  44794. passes with a real expectations string is tested later in the
  44795. same test.
  44796. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  44797. 2011-04-27 Sam Weinig <sam@webkit.org>
  44798. Reviewed by Adam Roben.
  44799. WebKit2 needs to notify the client when a plugin fails to initialize
  44800. https://bugs.webkit.org/show_bug.cgi?id=59657
  44801. * MiniBrowser/mac/BrowserWindowController.m:
  44802. (-[BrowserWindowController awakeFromNib]):
  44803. * WebKitTestRunner/TestController.cpp:
  44804. (WTR::TestController::initialize):
  44805. Add stubs.
  44806. 2011-04-26 Sam Weinig <sam@webkit.org>
  44807. Reviewed by David Levin.
  44808. Add a few more missing options to new-run-webkit-tests
  44809. https://bugs.webkit.org/show_bug.cgi?id=59567
  44810. Add support for:
  44811. --threaded
  44812. --gc-between-tests
  44813. --complex-text
  44814. * Scripts/webkitpy/layout_tests/port/webkit.py:
  44815. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  44816. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  44817. 2011-04-27 Mark Rowe <mrowe@apple.com>
  44818. Build fix.
  44819. Fix an OwnPtr-related issue that was missed before the strictness was turned on.
  44820. * WebKitTestRunner/TestController.cpp:
  44821. (WTR::TestController::runTest):
  44822. 2011-04-27 Ojan Vafai <ojan@chromium.org>
  44823. Forgot to upload the new times_ms.json file after splitting
  44824. it out from full_results.json.
  44825. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  44826. 2011-04-27 Ojan Vafai <ojan@chromium.org>
  44827. Fix snafu in generating the JSON for the chromium tests.
  44828. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  44829. 2011-04-27 Ojan Vafai <ojan@chromium.org>
  44830. Fix bad merge. This broke the chromium tests generating JSON files.
  44831. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  44832. 2011-04-27 Mark Rowe <mrowe@apple.com>
  44833. Rubber-stamped by Geoff Garen.
  44834. Don't look for results in a location that no longer exists.
  44835. * Scripts/old-run-webkit-tests:
  44836. 2011-04-27 Adrienne Walker <enne@google.com>
  44837. Unreviewed, add Chrome GPU folks to contributors that I'm tired of manually CCing
  44838. * Scripts/webkitpy/common/config/committers.py:
  44839. 2011-04-22 Ojan Vafai <ojan@chromium.org>
  44840. Reviewed by Tony Chang.
  44841. only include failures in full_results.json
  44842. https://bugs.webkit.org/show_bug.cgi?id=59256
  44843. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  44844. 2011-04-22 Ojan Vafai <ojan@chromium.org>
  44845. Reviewed by Adam Roben.
  44846. move times into their own json file
  44847. https://bugs.webkit.org/show_bug.cgi?id=59239
  44848. The test runtimes are the only case where we need an entry for
  44849. every test that was run, including passing tests. Move them into
  44850. their own json file so we can prune the other json files to only
  44851. include failing tests.
  44852. Use a trie-like data structure to hold the tests to avoid including
  44853. full test paths. This cuts 52% of the filesize. The end result is ~700k
  44854. pre-gzip.
  44855. * Scripts/webkitpy/common/net/resultsjsonparser.py:
  44856. Exclude times from the parsed TestResults.
  44857. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:
  44858. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  44859. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  44860. * Scripts/webkitpy/layout_tests/layout_package/manager.py:
  44861. 2011-04-27 Anders Carlsson <andersca@apple.com>
  44862. More casts and more clang++ build fixes.
  44863. * DumpRenderTree/mac/DumpRenderTree.mm:
  44864. (createWebViewAndOffscreenWindow):
  44865. * TestWebKitAPI/mac/PlatformWebViewMac.mm:
  44866. (TestWebKitAPI::PlatformWebView::PlatformWebView):
  44867. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  44868. (WTR::PlatformWebView::PlatformWebView):
  44869. 2011-04-27 Tony Chang <tony@chromium.org>
  44870. Reviewed by Ojan Vafai.
  44871. lazily autoinstall thirdparty python libraries
  44872. https://bugs.webkit.org/show_bug.cgi?id=55723
  44873. This helps by only having pywebsocket installed when the bots run. It
  44874. doesn't help much for devs since webkit-patch pulls in almost everything.
  44875. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  44876. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  44877. * Scripts/webkitpy/common/net/networktransaction.py:
  44878. * Scripts/webkitpy/common/net/networktransaction_unittest.py:
  44879. * Scripts/webkitpy/common/net/statusserver.py:
  44880. * Scripts/webkitpy/layout_tests/port/websocket_server.py:
  44881. * Scripts/webkitpy/thirdparty/__init__.py: Add an import hook so we can install based on
  44882. the import command rather than just installing everything.
  44883. * Scripts/webkitpy/thirdparty/__init___unittest.py: Added.
  44884. 2011-04-27 Girish Ramakrishnan <girish@forwardbias.in>
  44885. Add my IRC nick.
  44886. * Scripts/webkitpy/common/config/committers.py:
  44887. 2011-04-27 Eric Seidel <eric@webkit.org>
  44888. Reviewed by Mihai Parparita.
  44889. sherrifbot create-bug shouldn't assign bugs to webkit.review.bot
  44890. https://bugs.webkit.org/show_bug.cgi?id=59545
  44891. To do this, I needed a way to look up contributors by irc-name
  44892. (since anyone in #webkit who might use this command may not be a committer).
  44893. To lookup contributors, I had to make Contributor a real object.
  44894. Which led me to redesign parts of committers.py...
  44895. and finally fix one spot in changelog.py where we wanted to be
  44896. looking up contributors and not committers.
  44897. Overall a pretty simple fix, once you wade through the yak-hair.
  44898. This may not prevent *all* possible ways that bugs would get assigned
  44899. to webkit.review.bot. If we don't recognize the requester we will
  44900. go through the previous code path (which shouldn't change the assignee
  44901. on the bug from the default as far as I can tell).
  44902. * Scripts/webkitpy/common/checkout/changelog.py:
  44903. * Scripts/webkitpy/common/config/committers.py:
  44904. * Scripts/webkitpy/common/config/committers_unittest.py:
  44905. * Scripts/webkitpy/tool/bot/irc_command.py:
  44906. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  44907. 2011-04-27 Yi Shen <yi.4.shen@nokia.com>
  44908. Reviewed by Kenneth Rohde Christiansen.
  44909. [Qt] Upstream Symbian platform plugin
  44910. https://bugs.webkit.org/show_bug.cgi?id=58435
  44911. Exempting directory WebKit/qt/symbian/platformplugin from style guide.
  44912. * Scripts/webkitpy/style/checker.py:
  44913. * Scripts/webkitpy/style/checker_unittest.py:
  44914. 2011-04-27 Jeff Miller <jeffm@apple.com>
  44915. Correct my IRC nickname.
  44916. * Scripts/webkitpy/common/config/committers.py:
  44917. 2011-04-27 Lucas De Marchi <lucas.demarchi@profusion.mobi>
  44918. Reviewed by Darin Adler.
  44919. Change the email used on bugzilla
  44920. https://bugs.webkit.org/show_bug.cgi?id=59582
  44921. * Scripts/webkitpy/common/config/committers.py:
  44922. 2011-04-27 James Kozianski <koz@chromium.org>
  44923. Reviewed by Ojan Vafai.
  44924. Extract map from port to builder name.
  44925. https://bugs.webkit.org/show_bug.cgi?id=58301
  44926. * Scripts/webkitpy/layout_tests/port/__init__.py:
  44927. * Scripts/webkitpy/layout_tests/port/builders.py: Added.
  44928. * Scripts/webkitpy/layout_tests/port/builders_unittest.py: Added.
  44929. * Scripts/webkitpy/layout_tests/port/factory.py:
  44930. 2011-04-27 Ryuan Choi <ryuan.choi@samsung.com>
  44931. Reviewed by Martin Robinson.
  44932. [GTK] Add proxy support to GtkLauncher
  44933. https://bugs.webkit.org/show_bug.cgi?id=58852
  44934. Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
  44935. * GNUmakefile.am:
  44936. * GtkLauncher/main.c:
  44937. (main):
  44938. 2011-04-27 Annie Sullivan <sullivan@chromium.org>
  44939. Reviewed by David Levin.
  44940. Adding myself as a Chromium contributor to committers.py.
  44941. https://bugs.webkit.org/show_bug.cgi?id=59576
  44942. * Scripts/webkitpy/common/config/committers.py:
  44943. 2011-04-26 David Grogan <dgrogan@chromium.org>
  44944. Reviewed by David Levin.
  44945. Adding myself to Chromium contributors list in committers.py
  44946. https://bugs.webkit.org/show_bug.cgi?id=59565
  44947. * Scripts/webkitpy/common/config/committers.py:
  44948. 2011-04-26 Chang Shu <cshu@webkit.org>
  44949. Reviewed by Laszlo Gombos.
  44950. WebKitTestRunner needs layoutTestController.addOriginAccessWhitelistEntry
  44951. https://bugs.webkit.org/show_bug.cgi?id=42544
  44952. Also implemented removeOriginAccessWhitelistEntry and resetOriginAccessWhitelists.
  44953. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  44954. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  44955. (WTR::InjectedBundle::beginTesting):
  44956. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  44957. (WTR::LayoutTestController::addOriginAccessWhitelistEntry):
  44958. (WTR::LayoutTestController::removeOriginAccessWhitelistEntry):
  44959. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  44960. 2011-04-26 Chris Fleizach <cfleizach@apple.com>
  44961. Reviewed by Adele Peterson.
  44962. AX: Add more text marker routines to DRT
  44963. https://bugs.webkit.org/show_bug.cgi?id=58949
  44964. Add a few more methods to help test the text marker system, including nextMarker, previousMarker and
  44965. stringForMarkerRange.
  44966. * DumpRenderTree/AccessibilityUIElement.cpp:
  44967. (nextTextMarkerCallback):
  44968. (previousTextMarkerCallback):
  44969. (stringForTextMarkerRangeCallback):
  44970. (AccessibilityUIElement::previousTextMarker):
  44971. (AccessibilityUIElement::nextTextMarker):
  44972. (AccessibilityUIElement::stringForTextMarkerRange):
  44973. (AccessibilityUIElement::getJSClass):
  44974. * DumpRenderTree/AccessibilityUIElement.h:
  44975. * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
  44976. (AccessibilityUIElement::previousTextMarker):
  44977. (AccessibilityUIElement::nextTextMarker):
  44978. (AccessibilityUIElement::stringForTextMarkerRange):
  44979. 2011-04-26 Dan Bernstein <mitz@apple.com>
  44980. Build fix.
  44981. * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig:
  44982. * MiniBrowser/Configurations/CompilerVersion.xcconfig:
  44983. * WebKitTestRunner/Configurations/CompilerVersion.xcconfig:
  44984. 2011-04-26 Kevin Ollivier <kevino@theolliviers.com>
  44985. Rubberstamped by Eric Seidel.
  44986. Enable waf to be used to build other ports
  44987. https://bugs.webkit.org/show_bug.cgi?id=58213
  44988. * Scripts/build-webkit:
  44989. * Scripts/webkitdirs.pm:
  44990. * waf: Added.
  44991. * waf/build: Added.
  44992. * waf/build/build_utils.py: Added.
  44993. * waf/build/settings.py: Added.
  44994. * waf/build/waf_extensions.py: Added.
  44995. * waf/build/wxpresets.py: Added.
  44996. 2011-04-26 Sam Weinig <sam@webkit.org>
  44997. Reviewed by David Hyatt.
  44998. Remove Datagrid from the tree
  44999. https://bugs.webkit.org/show_bug.cgi?id=59543
  45000. * Scripts/build-webkit:
  45001. Remove feature.
  45002. * iExploder/iexploder-1.3.2/htdocs/htmltags.in:
  45003. * iExploder/iexploder-1.7.2/src/html-tags/webkit:
  45004. Remove from fuzzer.
  45005. 2011-04-26 Brent Fulgham <bfulgham@webkit.org>
  45006. Reviewed by Adam Roben.
  45007. Update WinLauncher with command-line arguments to allow the
  45008. transparency to be tested. Use --transparent to create a
  45009. transparent view. Use --desktop to have the view fill the
  45010. desktop area of the screen.
  45011. https://bugs.webkit.org/show_bug.cgi?id=58300
  45012. * WinLauncher/WinLauncher.cpp:
  45013. (usesLayeredWebView): New method to indicate that the
  45014. program is running with layered windows (alpha-blended
  45015. transparent windows).
  45016. (shouldUseFullDesktop): New method to indicate that the
  45017. program is running across the full desktop (less any
  45018. task bars.)
  45019. (resizeSubViews): Layered window mode doesn't have any
  45020. winapi child windows, so this routine is exited early
  45021. for that case.
  45022. (subclassForLayeredWindow): Subclass the window so we can
  45023. override its defaut message loop.
  45024. (computeFullDesktopFrame): Convenience function to get the
  45025. desktop region and update the frame dimensions appropriately.
  45026. (_tWinMain): Updated to accept the new '--transparent' and
  45027. '--desktop' arguments.
  45028. (InitInstance): Modified to exit early for the transparent
  45029. background case. WebKit will construct our primary window (with
  45030. appropriate settings) so we don't need to create one ourselves.
  45031. (WndProc):
  45032. (TransparentWndProc): New message loop for transparent windows,
  45033. since they need special handling to support dragging.
  45034. 2011-04-26 Alexandre MAzari <amazari@igalia.com>
  45035. Reviewed by Xan Lopez.
  45036. [Gtk] Implement LayoutTestController::setPluginsEnabled
  45037. https://bugs.webkit.org/show_bug.cgi?id=59184
  45038. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  45039. (LayoutTestController::setPluginsEnabled):
  45040. 2011-04-26 Chang Shu <cshu@webkit.org>
  45041. Reviewed by Laszlo Gombos.
  45042. WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
  45043. https://bugs.webkit.org/show_bug.cgi?id=57572
  45044. Remove the unnecessary code that updates preference.
  45045. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  45046. (WTR::InjectedBundle::beginTesting):
  45047. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  45048. (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
  45049. 2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
  45050. Reviewed by Eric Seidel.
  45051. [GTK] accessibility/aria-combobox-expected.txt
  45052. https://bugs.webkit.org/show_bug.cgi?id=59399
  45053. Implement isExpanded(), as it's used in the layout test.
  45054. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  45055. (AccessibilityUIElement::isExpanded): Implemented.
  45056. 2011-04-26 Adrienne Walker <enne@google.com>
  45057. Reviewed by Kent Tamura.
  45058. [chromium] Fix memory leak in DRT due to OwnPtr<T*>
  45059. https://bugs.webkit.org/show_bug.cgi?id=59489
  45060. * DumpRenderTree/chromium/WebViewHost.h:
  45061. 2011-04-26 Mario Sanchez Prada <msanchez@igalia.com>
  45062. Reviewed by Eric Seidel.
  45063. [GTK] Implement isChecked in DRT
  45064. https://bugs.webkit.org/show_bug.cgi?id=59385
  45065. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  45066. (AccessibilityUIElement::isChecked): Implemented.
  45067. 2011-04-26 Alejandro G. Castro <alex@igalia.com>
  45068. Unreviewed, rolling out r84949.
  45069. http://trac.webkit.org/changeset/84949
  45070. https://bugs.webkit.org/show_bug.cgi?id=58852
  45071. Broke GTK+ compilation
  45072. * GtkLauncher/main.c:
  45073. (main):
  45074. 2011-04-26 Eric Seidel <eric@webkit.org>
  45075. Reviewed by Mihai Parparita.
  45076. sheriff-bot should have a create-bug command
  45077. https://bugs.webkit.org/show_bug.cgi?id=59491
  45078. This patch has some stderr unittest spew, but I will
  45079. fix it after my live demo.
  45080. * Scripts/webkitpy/tool/bot/irc_command.py:
  45081. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  45082. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  45083. 2011-04-26 Ryuan Choi <ryuan.choi@samsung.com>
  45084. Reviewed by Martin Robinson.
  45085. [GTK] Add proxy support to GtkLauncher
  45086. https://bugs.webkit.org/show_bug.cgi?id=58852
  45087. Add SOUP_TYPE_PROXY_RESOLVER_DEFAULT feature or set SOUP_SESSION_PROXY_URI for developers behind proxy.
  45088. * GtkLauncher/main.c:
  45089. (main):
  45090. 2011-04-26 Dan Bernstein <mitz@apple.com>
  45091. Reviewed by Mark Rowe.
  45092. Choose the compiler based on the Xcode version for Snow Leopard debug builds.
  45093. * DumpRenderTree/mac/Configurations/Base.xcconfig:
  45094. * DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Added.
  45095. * MiniBrowser/Configurations/Base.xcconfig:
  45096. * MiniBrowser/Configurations/CompilerVersion.xcconfig: Added.
  45097. * TestWebKitAPI/Configurations/Base.xcconfig:
  45098. * TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Added.
  45099. * WebKitTestRunner/Configurations/Base.xcconfig:
  45100. * WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Added.
  45101. 2011-04-26 Finnur Thorarinsson <finnur.webkit@gmail.com>
  45102. Reviewed by David Levin.
  45103. Adding myself as a Chromium contributors to committers.py.
  45104. https://bugs.webkit.org/show_bug.cgi?id=59444
  45105. * Scripts/webkitpy/common/config/committers.py:
  45106. 2011-04-26 Adam Barth <abarth@webkit.org>
  45107. Reviewed by Eric Seidel.
  45108. DumpRenderTree/chromium should play nice with strict OwnPtrs
  45109. https://bugs.webkit.org/show_bug.cgi?id=59458
  45110. All these changes are pretty straight forward.
  45111. * DumpRenderTree/chromium/CppBoundClass.cpp:
  45112. (GetterPropertyCallback::GetterPropertyCallback):
  45113. (CppBoundClass::bindGetterCallback):
  45114. * DumpRenderTree/chromium/CppBoundClass.h:
  45115. (CppBoundClass::bindProperty):
  45116. (CppBoundClass::bindFallbackCallback):
  45117. (CppBoundClass::bindFallbackMethod):
  45118. * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  45119. (DRTDevToolsClient::DRTDevToolsClient):
  45120. * DumpRenderTree/chromium/TestEventPrinter.cpp:
  45121. (TestEventPrinter::createDRTPrinter):
  45122. (TestEventPrinter::createTestShellPrinter):
  45123. * DumpRenderTree/chromium/TestEventPrinter.h:
  45124. * DumpRenderTree/chromium/TestShell.cpp:
  45125. (TestShell::TestShell):
  45126. (TestShell::createMainWindow):
  45127. (TestShell::createDRTDevToolsClient):
  45128. * DumpRenderTree/chromium/WebViewHost.cpp:
  45129. (WebViewHost::geolocationClientMock):
  45130. (WebViewHost::speechInputController):
  45131. (WebViewHost::deviceOrientationClientMock):
  45132. (WebViewHost::reset):
  45133. (WebViewHost::navigate):
  45134. (WebViewHost::setPendingExtraData):
  45135. (WebViewHost::canvas):
  45136. * DumpRenderTree/chromium/WebViewHost.h:
  45137. 2011-04-26 Adam Roben <aroben@apple.com>
  45138. Make DRT/win log loading errors the same way DRT/mac does
  45139. Fixes <http://webkit.org/b/59303> [Windows WebKit1 Tests]
  45140. http/tests/misc/will-send-request-returns-null-on-redirect.html failing since r84742
  45141. Reviewed by Alexey Proskuryakov.
  45142. * DumpRenderTree/win/ResourceLoadDelegate.cpp:
  45143. (ResourceLoadDelegate::descriptionSuitableForTestResult): Removed the workaround for
  45144. <rdar://problem/5064234>, which has long since been fixed, and then made this function match
  45145. -[NSError(DRTExtras) _drt_descriptionSuitableForTestResult] more closely.
  45146. 2011-04-26 Dan Bernstein <mitz@apple.com>
  45147. REGRESSION (84876): build-webkit produces an error message
  45148. https://bugs.webkit.org/show_bug.cgi?id=59460
  45149. * Scripts/webkitdirs.pm:
  45150. 2011-04-26 Mihai Parparita <mihaip@chromium.org>
  45151. Reviewed by Eric Seidel.
  45152. Fix timestamp comparison in check-for-weak-vtables-and-externals
  45153. https://bugs.webkit.org/show_bug.cgi?id=59416
  45154. We should only re-run the check-for-weak-vtables-and-externals script
  45155. if the executable is more recent than the last run.
  45156. * Scripts/check-for-weak-vtables-and-externals:
  45157. 2011-04-26 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  45158. Reviewed by Csaba Osztrogonác.
  45159. [Qt] Implement LayoutTestController::setAutofilled
  45160. https://bugs.webkit.org/show_bug.cgi?id=59439
  45161. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  45162. (LayoutTestController::setAutofilled):
  45163. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  45164. 2011-04-25 Dan Bernstein <mitz@apple.com>
  45165. Reviewed by Mark Rowe.
  45166. Teach build-webkit where newer Xcode versions store the application-wide build settings user default.
  45167. * Scripts/webkitdirs.pm:
  45168. 2011-04-25 Sam Weinig <sam@webkit.org>
  45169. Reviewed by Adam Roben.
  45170. Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
  45171. https://bugs.webkit.org/show_bug.cgi?id=56090
  45172. Make LeaksViewer work with versions of browsers that don't support message
  45173. passing of cyclic structures.
  45174. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
  45175. (LeaksParser.this._worker.onmessage):
  45176. (LeaksParser):
  45177. (LeaksParser.prototype.addLeaksFile):
  45178. Use LeaksParserImpl directly if we don't support passing cyclic structures.
  45179. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
  45180. (LeaksParserImpl):
  45181. (LeaksParserImpl.prototype.addLeaksFile):
  45182. (LeaksParserImpl.prototype._incorporateLeaks):
  45183. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
  45184. (onmessage):
  45185. Factor out LeaksParser implementation into LeaksParserImpl.js.
  45186. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
  45187. (workersSupportCyclicStructures):
  45188. Add function to detect if workers support passing cyclic structures.
  45189. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
  45190. Add LeaksParserImpl.js include.
  45191. 2011-04-25 Jeff Miller <jeffm@apple.com>
  45192. Reviewed by Timothy Hatcher.
  45193. Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
  45194. https://bugs.webkit.org/show_bug.cgi?id=59373
  45195. * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.
  45196. 2011-04-25 Andrew Scherkus <scherkus@chromium.org>
  45197. Reviewed by Dimitri Glazkov.
  45198. Adding a few Chromium contributors to committers.py.
  45199. https://bugs.webkit.org/show_bug.cgi?id=59327
  45200. * Scripts/webkitpy/common/config/committers.py:
  45201. 2011-04-23 Dominic Cooney <dominicc@chromium.org>
  45202. Reviewed by Dimitri Glazkov.
  45203. [V8] Nodes in shadow DOM should not be GCed while their hosts are alive
  45204. https://bugs.webkit.org/show_bug.cgi?id=59284
  45205. Chromium DRT over-refcounted the NPObject wrappers it used to
  45206. marshal shadowRoot nodes back to tests (WebBindings::makeNode
  45207. births NPObjects with referenceCount == 1). This masked the GC bug
  45208. 59284 in tests by making shadowRoot nodes live forever.
  45209. * DumpRenderTree/chromium/LayoutTestController.cpp:
  45210. (LayoutTestController::shadowRoot):
  45211. (LayoutTestController::ensureShadowRoot):
  45212. 2011-04-23 Kevin Ollivier <kevino@theolliviers.com>
  45213. [wx] Unreviewed build fixes. Add new methods to wx LayoutTestController,
  45214. and update the URL for downloading waf.
  45215. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  45216. (LayoutTestController::ensureShadowRoot):
  45217. (LayoutTestController::removeShadowRoot):
  45218. * Scripts/webkitdirs.pm:
  45219. 2011-04-22 Sheriff Bot <webkit.review.bot@gmail.com>
  45220. Unreviewed, rolling out r84627.
  45221. http://trac.webkit.org/changeset/84627
  45222. https://bugs.webkit.org/show_bug.cgi?id=59271
  45223. It broke Symbian build (Requested by Ossy on #webkit).
  45224. * Scripts/webkitpy/style/checker.py:
  45225. * Scripts/webkitpy/style/checker_unittest.py:
  45226. 2011-04-22 Dirk Pranke <dpranke@chromium.org>
  45227. Reviewed by Adam Barth.
  45228. rebaseline-chromium-webkit-tests: clean up output
  45229. https://bugs.webkit.org/show_bug.cgi?id=59240
  45230. This change dramatically changes the output the tool provides
  45231. by default. The previous output (more or less) is still there
  45232. in -v / verbose / debug mode, but the default output is
  45233. way terser and more readable. It mostly says which files are
  45234. updated, which are duplicates, and which are not found in an
  45235. archive. Feedback desired :).
  45236. This change also adds a scm.exists() method to the SCM object
  45237. so that we can cleanly figure out what we're doing while
  45238. rebaselining.
  45239. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  45240. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  45241. * Scripts/webkitpy/common/system/filesystem_mock.py:
  45242. * Scripts/webkitpy/common/checkout/scm.py:
  45243. * Scripts/webkitpy/common/checkout/scm_unittest.py:
  45244. 2011-04-22 Ilya Sherman <isherman@chromium.org>
  45245. Reviewed by Alexey Proskuryakov.
  45246. Add Ilya Sherman (isherman@chromium.org) to the list of contributors
  45247. https://bugs.webkit.org/show_bug.cgi?id=59231
  45248. * Scripts/webkitpy/common/config/committers.py:
  45249. 2011-04-22 Yuta Kitamura <yutak@chromium.org>
  45250. Reviewed by Ojan Vafai.
  45251. new-run-webkit-tests: Exception raised when stderr contains binary data
  45252. https://bugs.webkit.org/show_bug.cgi?id=59083
  45253. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  45254. Use write_binary_file() instead of write_text_file().
  45255. 2011-04-22 Chang Shu <cshu@webkit.org>
  45256. Reviewed by Kenneth Rohde Christiansen.
  45257. WebKitTestRunner needs layoutTestController.setFrameFlatteningEnabled
  45258. https://bugs.webkit.org/show_bug.cgi?id=42536
  45259. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  45260. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  45261. (WTR::LayoutTestController::setFrameFlatteningEnabled):
  45262. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  45263. 2011-04-22 Adam Barth <abarth@webkit.org>
  45264. Reviewed by Eric Seidel.
  45265. CommitQueue should remember the expected failures from patch to patch
  45266. https://bugs.webkit.org/show_bug.cgi?id=59253
  45267. Previously, we stored the set of expected failures on the task object,
  45268. which meant the commit-queue forgot about them after each patch. This
  45269. patch moves them to the CommitQueue object so they will have a longer
  45270. lifetime.
  45271. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  45272. * Scripts/webkitpy/tool/bot/patchanalysistask.py:
  45273. * Scripts/webkitpy/tool/commands/queues.py:
  45274. 2011-04-22 Sam Weinig <sam@webkit.org>
  45275. Reviewed by Brian Weinstein.
  45276. WebKit2: Implement JavaScript unresponsiveness timer/callbacks
  45277. https://bugs.webkit.org/show_bug.cgi?id=59248
  45278. Stub out shouldInterruptJavaScript callbacks.
  45279. * MiniBrowser/mac/BrowserWindowController.m:
  45280. (-[BrowserWindowController awakeFromNib]):
  45281. * MiniBrowser/win/BrowserView.cpp:
  45282. (BrowserView::create):
  45283. * WebKitTestRunner/TestController.cpp:
  45284. (WTR::TestController::createOtherPage):
  45285. (WTR::TestController::initialize):
  45286. 2011-04-22 Daniel Bates <dbates@webkit.org>
  45287. Reviewed by Csaba Osztrogonác.
  45288. webkit-patch land hangs if svn prompts for credentials
  45289. https://bugs.webkit.org/show_bug.cgi?id=31500
  45290. Make has_authorization_for_realm() return True only if there exists a credentials file
  45291. that contains either the word "password" or "passtype". We assume that these words don't
  45292. coincide with the actual credential data (e.g. a person's username is "password").
  45293. * Scripts/webkitpy/common/checkout/scm.py:
  45294. * Scripts/webkitpy/common/checkout/scm_unittest.py:
  45295. - Added test cases:
  45296. test_has_authorization_for_realm_using_credentials_with_passtype(),
  45297. test_has_authorization_for_realm_using_credentials_with_password(),
  45298. test_not_have_authorization_for_realm_with_credentials_missing_password_and_passtype()
  45299. - Renamed test_not_have_authorization_for_realm() to test_not_have_authorization_for_realm_when_missing_credentials_file()
  45300. to better describe what it's testing.
  45301. - Repurposed test_has_authorization_for_realm() to take realm and credential data to use
  45302. and return the result of calling has_authorization_for_realm() so that the caller can
  45303. assert the result; Renamed to _test_has_authorization_for_realm_using_credentials() to
  45304. better reflect its new purpose.
  45305. 2011-04-22 Adam Barth <abarth@webkit.org>
  45306. Remove double-negative. (Sorry this was bugging me.)
  45307. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  45308. 2011-04-22 Adam Barth <abarth@webkit.org>
  45309. Reviewed by Eric Seidel.
  45310. Factor LayoutTestResultsReader out of CommitQueue
  45311. https://bugs.webkit.org/show_bug.cgi?id=59244
  45312. This code will be shared with the EWS when they start running tests.
  45313. * Scripts/webkitpy/tool/bot/layouttestresultsreader.py: Added.
  45314. * Scripts/webkitpy/tool/bot/layouttestresultsreader_unittest.py: Added.
  45315. * Scripts/webkitpy/tool/commands/queues.py:
  45316. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  45317. 2011-04-22 Eric Seidel <eric@webkit.org>
  45318. Reviewed by Dimitri Glazkov.
  45319. webkit-patch rebaseline is broken
  45320. https://bugs.webkit.org/show_bug.cgi?id=59207
  45321. My recent changes to how LayoutTestResults.results_from_string
  45322. uncovered a bug in our use of urllib2.
  45323. We now are treating the return value from _fetch_results_html()
  45324. (which returns urllib2.openurl()) as a string. That's incorrect,
  45325. the return value is a file-like object (which auto-converts to a
  45326. string in most cases).
  45327. I've updated our urllib2-using code to correctly call .read() on the
  45328. resulting object before treating it like a string.
  45329. Unfortunately there is no easy way to test this mis-understanding
  45330. of the openurl() semantics.
  45331. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  45332. 2011-04-22 Adam Barth <abarth@webkit.org>
  45333. Reviewed by Eric Seidel.
  45334. Factor PatchAnalysis task out of CommitQueueTask
  45335. https://bugs.webkit.org/show_bug.cgi?id=59220
  45336. This is a first step towards teaching the EWS to run tests.
  45337. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  45338. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  45339. * Scripts/webkitpy/tool/bot/patchanalysistask.py: Added.
  45340. 2011-04-22 Philippe Normand <pnormand@igalia.com>
  45341. Reviewed by Martin Robinson.
  45342. [GTK] DRT: implement eventSender.scalePageBy
  45343. https://bugs.webkit.org/show_bug.cgi?id=59082
  45344. * DumpRenderTree/gtk/EventSender.cpp:
  45345. (scalePageByCallback): scalePageBy() support.
  45346. 2011-04-21 Eric Seidel <eric@webkit.org>
  45347. Reviewed by Adam Barth.
  45348. LayoutTestResults should know how to handle NRWT json files
  45349. https://bugs.webkit.org/show_bug.cgi?id=59168
  45350. LayoutTestResults was originally created to be a parallel
  45351. to existing NRWT architecture for dealing with results files.
  45352. But then it turns out that NRWT has no such architecture. :(
  45353. So this patch writes the necessary code to handle reading
  45354. full_results.json and unexpected_results.json files from
  45355. NRWT layout-test-results directories.
  45356. LayoutTestResults has thus morphed from being ORWT-only to
  45357. supporting both ORWT and NRWT. It's possible at some future
  45358. point that other pieces of the NRWT architecture will learn
  45359. how to read JSON files in which case this can go away.
  45360. This is all done for making it possible for the commit-queue
  45361. to run the tests using NWRT and be able to understand the results
  45362. (for flaky test reporting, etc.)
  45363. * Scripts/webkitpy/common/net/layouttestresults.py:
  45364. * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  45365. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  45366. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  45367. * Scripts/webkitpy/common/net/resultsjsonparser.py: Added.
  45368. * Scripts/webkitpy/common/net/resultsjsonparser_unittest.py: Added.
  45369. 2011-04-22 Yi Shen <yi.4.shen@nokia.com>
  45370. Reviewed by Kenneth Rohde Christiansen.
  45371. [Qt] Upstream Symbian platform plugin
  45372. https://bugs.webkit.org/show_bug.cgi?id=58435
  45373. Exempting directory WebKit/qt/symbian/platformplugin from style guide.
  45374. * Scripts/webkitpy/style/checker.py:
  45375. * Scripts/webkitpy/style/checker_unittest.py:
  45376. 2011-04-22 Balazs Kelemen <kbalazs@webkit.org>
  45377. Reviewed by Csaba Osztrogonác.
  45378. [Qt][WK2] Qt should use the mac-wk2 skipped list
  45379. https://bugs.webkit.org/show_bug.cgi?id=58536
  45380. * Scripts/old-run-webkit-tests:
  45381. 2011-04-21 Tony Chang <tony@chromium.org>
  45382. Reviewed by Mihai Parparita.
  45383. Remove find-mismatched-layout-test-results since it's not needed in a
  45384. checksum free world.
  45385. https://bugs.webkit.org/show_bug.cgi?id=59156
  45386. * Scripts/find-mismatched-layout-test-results: Removed.
  45387. 2011-04-21 Brent Fulgham <bfulgham@webkit.org>
  45388. Reviewed by Martin Robinson.
  45389. Teach build-webkit and update-webkit that the WinCairo port does
  45390. not need the non-redistributable WebKitSupportLibraries.zip file.
  45391. Also append the _Cairo_CFLite label to the build target for the
  45392. default (no argument) case when building with '--wincairo'
  45393. https://bugs.webkit.org/show_bug.cgi?id=58801
  45394. * Scripts/build-webkit: Don't die if WebKitSupportLibraries.zip
  45395. doesn't exist.
  45396. * Scripts/webkitdirs.pm: Append '_Cairo_CFLite' to the default
  45397. 'Release' build target when passed the '--wincairo' flag.
  45398. * Scripts/update-webkit: Don't die if WebKitSupportLibraries.zip
  45399. doesn't exist.
  45400. 2011-04-21 Dirk Pranke <dpranke@chromium.org>
  45401. Reviewed by Eric Seidel.
  45402. new-run-webkit-tests: obsolete old code, part 5: rename message_broker2 to message_broker
  45403. https://bugs.webkit.org/show_bug.cgi?id=58758
  45404. Since worker_mixin is now only used by worker, there's no point
  45405. in having it split across two files.
  45406. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  45407. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  45408. * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Added
  45409. * Scripts/webkitpy/layout_tests/layout_package/message_broker2.py: Removed.
  45410. * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: * Added
  45411. * Scripts/webkitpy/layout_tests/layout_package/message_broker2_unittest.py: Removed.
  45412. 2011-04-21 Dirk Pranke <dpranke@chromium.org>
  45413. Reviewed by Tony Chang.
  45414. new-run-webkit-tests: obsolete old code, part 4: merge worker_mixin into worker
  45415. https://bugs.webkit.org/show_bug.cgi?id=58756
  45416. Since worker_mixin is now only used by worker, there's no point
  45417. in having it split across two files.
  45418. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  45419. * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Removed.
  45420. 2011-04-21 Dirk Pranke <dpranke@chromium.org>
  45421. Reviewed by Tony Chang.
  45422. new-run-webkit-tests: obsolete old code, part 3 - rename test_runner to manager
  45423. https://bugs.webkit.org/show_bug.cgi?id=58754
  45424. test_runner hasn't been a great name for some time, since all of
  45425. the test running is actually done in worker and
  45426. single_test_runner. Rename to manager to match the terminology
  45427. elsewhere.
  45428. * Scripts/webkitpy/layout_tests/layout_package/manager.py: Added.
  45429. * Scripts/webkitpy/layout_tests/layout_package/manager_unittest.py: Added.
  45430. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  45431. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py: Removed.
  45432. * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py: Removed.
  45433. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  45434. 2011-04-21 Dirk Pranke <dpranke@chromium.org>
  45435. Reviewed by Tony Chang.
  45436. new-run-webkit-tests: obsolete old threading code, part 2
  45437. https://bugs.webkit.org/show_bug.cgi?id=58753
  45438. This merges the test_runner2 code back into test_runner since
  45439. there's only a single type of test runner now.
  45440. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45441. * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py: Removed.
  45442. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  45443. 2011-04-21 Maciej Stachowiak <mjs@apple.com>
  45444. Reviewed by Adam Roben.
  45445. Add a feature define to allow <details> and <summary> to be disabled
  45446. https://bugs.webkit.org/show_bug.cgi?id=59118
  45447. <rdar://problem/9257045>
  45448. * Scripts/build-webkit:
  45449. * Tools.pro:
  45450. 2011-04-21 Adam Barth <abarth@webkit.org>
  45451. Reviewed by Eric Seidel.
  45452. webkit-patch upload should assign the bug to you
  45453. https://bugs.webkit.org/show_bug.cgi?id=33699
  45454. This patch only re-assigns the bug if it is currently unassigned. We
  45455. can be more aggressive in the future if people want us to be more
  45456. agressive.
  45457. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  45458. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  45459. * Scripts/webkitpy/tool/mocktool.py:
  45460. * Scripts/webkitpy/tool/steps/postdiff.py:
  45461. 2011-04-21 Ojan Vafai <ojan@chromium.org>
  45462. Reviewed by Tony Chang.
  45463. move json_results.html over to LayoutTests/fast/harness
  45464. https://bugs.webkit.org/show_bug.cgi?id=59154
  45465. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45466. 2011-04-21 Adam Barth <abarth@webkit.org>
  45467. Reviewed by Eric Seidel.
  45468. ValidateChangeLogs doesn't work on SVN
  45469. https://bugs.webkit.org/show_bug.cgi?id=59115
  45470. svn-create-patch lies about the diff in the working copy by moving
  45471. ChangeLog entries to the top of the diff. That's fine on most cases,
  45472. but causes problems for ValidateChangeLogs, which is trying validate
  45473. the where the ChangeLog entry appears.
  45474. I haven't added a test for this change because I couldn't figure out
  45475. how to write one. The issue is more of an integration issue, which
  45476. we're not really set up to test in our unit testing framework. If this
  45477. patch had worked around the output from svn-create-patch, then I could
  45478. have tested that we behave correctly on sample svn-create-patch output,
  45479. but, in this case, I've removed the dependency on svn-create-patch. I
  45480. could test that we behave correctly on "svn diff" output, but we
  45481. already have those tests.
  45482. * Scripts/webkitpy/tool/commands/download_unittest.py:
  45483. * Scripts/webkitpy/tool/mocktool.py:
  45484. * Scripts/webkitpy/tool/steps/validatechangelogs.py:
  45485. 2011-04-21 Tony Chang <tony@chromium.org>
  45486. Reviewed by Ojan Vafai.
  45487. old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
  45488. https://bugs.webkit.org/show_bug.cgi?id=58402
  45489. * Scripts/old-run-webkit-tests: Don't read or write .checksum files.
  45490. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
  45491. * Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
  45492. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  45493. * Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
  45494. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  45495. 2011-04-21 Ojan Vafai <ojan@chromium.org>
  45496. Reviewed by Tony Chang.
  45497. final tests for results.html file
  45498. https://bugs.webkit.org/show_bug.cgi?id=59150
  45499. This gets us close to 100% code coverage. Once this is
  45500. checked in, I'll move this file over to LayoutTests/fast/harness
  45501. and make it a proper layout test.
  45502. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45503. * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
  45504. 2011-04-21 Ojan Vafai <ojan@chromium.org>
  45505. Reviewed by Tony Chang.
  45506. only expand visible rows
  45507. https://bugs.webkit.org/show_bug.cgi?id=59130
  45508. For the chromium port, where there are many expected failures,
  45509. expanding all of them is quite slow. Only expand the visible ones.
  45510. This makes the default case. Also, make the expanding async to
  45511. avoid totally killing the process.
  45512. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45513. * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
  45514. 2011-04-21 Martin Robinson <mrobinson@igalia.com>
  45515. [GTK] DRT: implement eventSender.scalePageBy
  45516. https://bugs.webkit.org/show_bug.cgi?id=59082
  45517. Rolling out r84507 since it broke many GTK+ tests.
  45518. * DumpRenderTree/gtk/EventSender.cpp:
  45519. 2011-04-21 Sam Weinig <sam@webkit.org>
  45520. Reviewed by Simon Fraser.
  45521. Add way to garbage collect between each test when running layout tests
  45522. https://bugs.webkit.org/show_bug.cgi?id=59126
  45523. * DumpRenderTree/mac/DumpRenderTree.mm:
  45524. (initializeGlobalsFromCommandLineOptions):
  45525. (runTest):
  45526. * Scripts/old-run-webkit-tests:
  45527. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  45528. (WTR::InjectedBundle::didReceiveMessage):
  45529. * WebKitTestRunner/TestController.cpp:
  45530. (WTR::TestController::TestController):
  45531. (WTR::TestController::initialize):
  45532. (WTR::TestController::resetStateToConsistentValues):
  45533. * WebKitTestRunner/TestController.h:
  45534. 2011-04-21 Ojan Vafai <ojan@chromium.org>
  45535. Reviewed by Mihai Parparita.
  45536. fix another innocuous JS error in expand/collapseAllExpectations
  45537. https://bugs.webkit.org/show_bug.cgi?id=59122
  45538. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45539. * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:
  45540. 2011-04-20 Ojan Vafai <ojan@chromium.org>
  45541. Reviewed by Tony Chang.
  45542. put unexpected passes into their own table
  45543. https://bugs.webkit.org/show_bug.cgi?id=59016
  45544. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45545. 2011-04-20 Ojan Vafai <ojan@chromium.org>
  45546. Reviewed by Tony Chang.
  45547. initial set of tests for new results.html file
  45548. https://bugs.webkit.org/show_bug.cgi?id=59031
  45549. Also, fix the bugs (mostly innocuous JS errors) the tests found.
  45550. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45551. * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.
  45552. 2011-04-21 Philippe Normand <pnormand@igalia.com>
  45553. Reviewed by Martin Robinson.
  45554. [GTK] missing LayoutTestController::callShouldCloseOnWebView()
  45555. https://bugs.webkit.org/show_bug.cgi?id=59086
  45556. callShouldCloseOnWebView() implementation.
  45557. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  45558. (LayoutTestController::callShouldCloseOnWebView):
  45559. 2011-04-21 Philippe Normand <pnormand@igalia.com>
  45560. Reviewed by Martin Robinson.
  45561. [GTK] DRT: implement eventSender.scalePageBy
  45562. https://bugs.webkit.org/show_bug.cgi?id=59082
  45563. * DumpRenderTree/gtk/EventSender.cpp:
  45564. (scalePageByCallback): scalePageBy() support.
  45565. 2011-04-20 Dominic Cooney <dominicc@chromium.org>
  45566. Reviewed by Dimitri Glazkov.
  45567. layoutTestController can create and destroy shadow DOM
  45568. https://bugs.webkit.org/show_bug.cgi?id=59058
  45569. Chromium, Mac, GTK and Qt DRT; and WK2 test runner.
  45570. * DumpRenderTree/LayoutTestController.cpp:
  45571. (ensureShadowRootCallback):
  45572. (removeShadowRootCallback):
  45573. (LayoutTestController::staticFunctions):
  45574. * DumpRenderTree/LayoutTestController.h:
  45575. * DumpRenderTree/chromium/LayoutTestController.cpp:
  45576. (LayoutTestController::LayoutTestController):
  45577. (LayoutTestController::ensureShadowRoot):
  45578. (LayoutTestController::removeShadowRoot):
  45579. * DumpRenderTree/chromium/LayoutTestController.h:
  45580. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  45581. (LayoutTestController::ensureShadowRoot):
  45582. (LayoutTestController::removeShadowRoot):
  45583. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  45584. (LayoutTestController::shadowRoot):
  45585. (LayoutTestController::ensureShadowRoot):
  45586. (LayoutTestController::removeShadowRoot):
  45587. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  45588. (LayoutTestController::ensureShadowRoot):
  45589. (LayoutTestController::removeShadowRoot):
  45590. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  45591. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  45592. (LayoutTestController::ensureShadowRoot):
  45593. (LayoutTestController::removeShadowRoot):
  45594. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  45595. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  45596. (WTR::LayoutTestController::shadowRoot):
  45597. (WTR::LayoutTestController::ensureShadowRoot):
  45598. (WTR::LayoutTestController::removeShadowRoot):
  45599. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  45600. 2011-04-20 Dirk Pranke <dpranke@chromium.org>
  45601. Reviewed by Eric Seidel.
  45602. new-run-webkit-tests: handle ctrl-c more cleanly
  45603. https://bugs.webkit.org/show_bug.cgi?id=58849
  45604. * Scripts/new-run-webkit-tests:
  45605. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  45606. 2011-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
  45607. Unreviewed, rolling out r84431.
  45608. http://trac.webkit.org/changeset/84431
  45609. https://bugs.webkit.org/show_bug.cgi?id=59061
  45610. Breaks for folks who don't have editbugs (Requested by abarth
  45611. on #webkit).
  45612. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  45613. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  45614. * Scripts/webkitpy/tool/mocktool.py:
  45615. * Scripts/webkitpy/tool/steps/postdiff.py:
  45616. 2011-04-20 Leo Yang <leo.yang@torchmobile.com.cn>
  45617. Unreviewed.
  45618. Adding myself to committers.py.
  45619. * Scripts/webkitpy/common/config/committers.py:
  45620. 2011-04-20 Adam Barth <abarth@webkit.org>
  45621. Reviewed by Eric Seidel.
  45622. webkit-patch upload should assign the bug to you
  45623. https://bugs.webkit.org/show_bug.cgi?id=33699
  45624. This patch only re-assigns the bug if it is currently unassigned. We
  45625. can be more aggressive in the future if people want us to be more
  45626. agressive.
  45627. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  45628. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  45629. * Scripts/webkitpy/tool/mocktool.py:
  45630. * Scripts/webkitpy/tool/steps/postdiff.py:
  45631. 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
  45632. Reviewed by Csaba Osztrogonác.
  45633. Modify builder.html template to allow easy access
  45634. to list more builds on the builder's page.
  45635. https://bugs.webkit.org/show_bug.cgi?id=59008
  45636. * BuildSlaveSupport/build.webkit.org-config/templates/builder.html:
  45637. 2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
  45638. Reviewed by Csaba Osztrogonác.
  45639. Add the default template for builder page.
  45640. https://bugs.webkit.org/show_bug.cgi?id=59008
  45641. * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.
  45642. 2011-04-20 Ojan Vafai <ojan@chromium.org>
  45643. Reviewed by Eric Seidel.
  45644. move page generation into a single function
  45645. https://bugs.webkit.org/show_bug.cgi?id=59027
  45646. Now executing the script doesn't create any state. We should then
  45647. be able to write tests for this by setting custom results data.
  45648. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45649. 2011-04-20 Ojan Vafai <ojan@chromium.org>
  45650. Reviewed by Eric Seidel.
  45651. move global state into a shared object
  45652. https://bugs.webkit.org/show_bug.cgi?id=59023
  45653. This makes the code more testable.
  45654. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45655. 2011-04-20 Ojan Vafai <ojan@chromium.org>
  45656. Reviewed by Tony Chang.
  45657. move global state into a shared object
  45658. https://bugs.webkit.org/show_bug.cgi?id=59023
  45659. This makes the code more testable.
  45660. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45661. 2011-04-20 Ojan Vafai <ojan@chromium.org>
  45662. Reviewed by Eric Seidel.
  45663. add expandAll/collapseAll links
  45664. https://bugs.webkit.org/show_bug.cgi?id=59011
  45665. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45666. 2011-04-20 Kevin Ollivier <kevino@theolliviers.com>
  45667. [wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
  45668. * Scripts/webkitdirs.pm:
  45669. * wx/build/build_utils.py:
  45670. * wx/build/settings.py:
  45671. * wx/install-unix-extras:
  45672. * wx/packaging/build-mac-installer.py:
  45673. * wx/packaging/build-win-installer.py:
  45674. 2011-04-20 Adam Roben <aroben@apple.com>
  45675. Replace old-run-webkit-tests's win-7 platform with win-7sp0
  45676. It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
  45677. version of Windows we cared about, so its results should just go in win. But now that
  45678. Windows 7 SP1 exists (and has different results for some tests), we need a place to store
  45679. results for Windows 7 without SP1 (and older versions of Windows).
  45680. Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
  45681. differences from Windows 7 "SP0"
  45682. Reviewed by David Kilzer.
  45683. * Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
  45684. will just use "win".
  45685. * Scripts/webkitdirs.pm:
  45686. (isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.
  45687. 2011-04-20 Adam Roben <aroben@apple.com>
  45688. Teach webkitdirs::winVersion about build numbers
  45689. The build number isn't currently used, but soon will be.
  45690. As a bonus, winVersion now works on non-Cygwin variants of Perl!
  45691. Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
  45692. SP1
  45693. Reviewed by Anders Carlsson.
  45694. * Scripts/webkitdirs.pm:
  45695. (isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
  45696. (determineWinVersion): Use `cmd /c ver` to get the version number, including the build
  45697. number. Parse the version number into a hash, similar to how osXVersion() works.
  45698. (isWindows7):
  45699. (isWindowsVista):
  45700. (isWindowsXP):
  45701. Updated for changes to winVersion().
  45702. 2011-04-20 W. James MacLean <wjmaclean@chromium.org>
  45703. Reviewed by Kenneth Russell.
  45704. Add support for composite-to-texture to DumpRenderTree.
  45705. https://bugs.webkit.org/show_bug.cgi?id=58675
  45706. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  45707. (main):
  45708. * DumpRenderTree/chromium/TestShell.cpp:
  45709. (TestShell::TestShell):
  45710. (TestShell::resetWebSettings):
  45711. * DumpRenderTree/chromium/TestShell.h:
  45712. (TestShell::setCompositeToTexture):
  45713. * DumpRenderTree/chromium/WebPreferences.cpp:
  45714. (WebPreferences::reset):
  45715. (WebPreferences::applyTo):
  45716. * DumpRenderTree/chromium/WebPreferences.h:
  45717. 2011-04-19 Eric Seidel <eric@webkit.org>
  45718. Reviewed by Adam Barth.
  45719. The commit-queue is confused when non-layout tests fail
  45720. https://bugs.webkit.org/show_bug.cgi?id=58955
  45721. As seen in http://queues.webkit.org/results/8474435
  45722. It fails to create an archive of the layout test results
  45723. and then throws an exception.
  45724. I've fixed this by making it catch the exception as well
  45725. as made it so it never calls that path in the common case.
  45726. I've updated MockFileSystem to understand rmtree's affect on
  45727. directories as well as files.
  45728. * Scripts/webkitpy/common/system/filesystem_mock.py:
  45729. * Scripts/webkitpy/common/system/workspace.py:
  45730. * Scripts/webkitpy/tool/commands/queues.py:
  45731. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  45732. * Scripts/webkitpy/tool/mocktool.py:
  45733. 2011-04-19 Ojan Vafai <ojan@chromium.org>
  45734. Fix check for whether a failure is expected to deal with
  45735. flaky tests and FAIL expectations.
  45736. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45737. 2011-04-19 Ojan Vafai <ojan@chromium.org>
  45738. Reviewed by Eric Seidel.
  45739. don't show missing text results for tests that only dump image results
  45740. https://bugs.webkit.org/show_bug.cgi?id=58931
  45741. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45742. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45743. 2011-04-19 Ojan Vafai <ojan@chromium.org>
  45744. Reviewed by Eric Seidel.
  45745. don't show failures table if there are only new tests
  45746. https://bugs.webkit.org/show_bug.cgi?id=58929
  45747. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45748. 2011-04-19 Ojan Vafai <ojan@chromium.org>
  45749. Reviewed by Eric Seidel.
  45750. don't show failures table if there are only new tests
  45751. https://bugs.webkit.org/show_bug.cgi?id=58929
  45752. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45753. 2011-04-19 Ojan Vafai <ojan@chromium.org>
  45754. Fix unittest failures from http://trac.webkit.org/changeset/84294.
  45755. * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  45756. * Scripts/webkitpy/layout_tests/layout_package/test_runner_unittest.py:
  45757. 2011-04-18 Ojan Vafai <ojan@chromium.org>
  45758. Reviewed by Eric Seidel.
  45759. switch new-run-webkit-tests to using the new results file
  45760. https://bugs.webkit.org/show_bug.cgi?id=58861
  45761. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  45762. * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:
  45763. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45764. 2011-04-19 Renata Hodovan <reni@webkit.org>
  45765. Reviewed by Eric Seidel.
  45766. Move the alignment related macros from Vector.h to new Alignment.h.
  45767. https://bugs.webkit.org/show_bug.cgi?id=56000
  45768. Adding the new file to the forwarding headers of Tools.
  45769. * DumpRenderTree/ForwardingHeaders/wtf/Alignment.h: Added.
  45770. 2011-04-19 Kevin Ollivier <kevino@theolliviers.com>
  45771. [wx] Unreviewed build fix for Win / wx 2.9 wxPython installation.
  45772. * wx/packaging/build-win-installer.py:
  45773. * wx/packaging/wxWebKitInstaller.iss.in:
  45774. 2011-04-19 Adam Roben <aroben@apple.com>
  45775. Skip another accelerated-compositing-sensitive test when accelerated compositing is disabled
  45776. * Scripts/old-run-webkit-tests: Skip media/controls-without-preload.html on Windows when
  45777. accelerated compositing is disabled.
  45778. 2011-04-19 Ojan Vafai <ojan@chromium.org>
  45779. Remove accidentally committed debug code.
  45780. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45781. 2011-04-19 Brent Fulgham <bfulgham@webkit.org>
  45782. Unreviewed build correction.
  45783. Avoid duplicate stub implementation of test routine
  45784. for WinCairo build.
  45785. * WebKitTestRunner/win/TestInvocationWin.cpp: Exclude
  45786. WinCairo from using this stub.
  45787. 2011-04-18 Ojan Vafai <ojan@chromium.org>
  45788. Reviewed by Eric Seidel.
  45789. make results file work with audio and reftests
  45790. https://bugs.webkit.org/show_bug.cgi?id=58860
  45791. Also fix bug with timeout tests and store a bit in the JSON
  45792. for new image tests instead of loading the image result to check if it's there.
  45793. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45794. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45795. 2011-04-19 Jer Noble <jer.noble@apple.com>
  45796. Reviewed by Adam Roben.
  45797. REGRESSION (r84206): 50 tests failing on SnowLeopard Intel Release (WebKit2 Tests) due to extra "supportsFullScreen() == true" output
  45798. https://bugs.webkit.org/show_bug.cgi?id=58890
  45799. Add a layoutTestController flag which controls when full screen callbacks are written to stdout.
  45800. Defaults to false.
  45801. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: Added dumpFullScreenCallbacks().
  45802. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  45803. (WTR::InjectedBundlePage::supportsFullScreen): Only write to stdout if shouldDumpFullScreenCallbacks is set.
  45804. (WTR::InjectedBundlePage::enterFullScreenForElement): Ditto.
  45805. (WTR::InjectedBundlePage::exitFullScreenForElement): Ditto.
  45806. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  45807. (WTR::LayoutTestController::LayoutTestController): Initialize new ivar.
  45808. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  45809. (WTR::LayoutTestController::dumpFullScreenCallbacks): Added.
  45810. (WTR::LayoutTestController::shouldDumpFullScreenCallbacks): Added.
  45811. 2011-04-19 Kristóf Kosztyó <Kosztyo.Kristof@stud.u-szeged.hu>
  45812. Reviewed by Andreas Kling.
  45813. [Qt] fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html fails (DRT sideeffect)
  45814. https://bugs.webkit.org/show_bug.cgi?id=35086
  45815. fast/xmlhttprequest/xmlhttprequest-no-file-access.html caused
  45816. a DRT sideeffect problem, because the resetSettings didn't set
  45817. the default value of LocalContentCanAccessFileUrls.
  45818. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  45819. (WebCore::WebPage::resetSettings):
  45820. 2011-04-18 Zan Dobersek <zandobersek@gmail.com>
  45821. Reviewed by Martin Robinson.
  45822. [GTK] Need support for dumping focus rectangles in pixel results
  45823. https://bugs.webkit.org/show_bug.cgi?id=53647
  45824. Dump the selection rect if it has been requested.
  45825. * DumpRenderTree/gtk/PixelDumpSupportGtk.cpp:
  45826. (createBitmapContextFromWebView):
  45827. 2011-04-18 Eric Seidel <eric@webkit.org>
  45828. Reviewed by Adam Barth.
  45829. test-webkitpy should run the ActiveWorkItems tests
  45830. https://bugs.webkit.org/show_bug.cgi?id=58859
  45831. Also make the unit tests pass. :)
  45832. * QueueStatusServer/model/activeworkitems.py:
  45833. * QueueStatusServer/model/queue.py:
  45834. * QueueStatusServer/model/workitems.py:
  45835. 2011-04-18 Eric Seidel <eric@webkit.org>
  45836. Reviewed by Adam Barth.
  45837. queues.webkit.org should show trailing-days pass counts for queues
  45838. https://bugs.webkit.org/show_bug.cgi?id=58812
  45839. This lets us see if each bot is pulling its own weight or not.
  45840. Before I wrote this patch our suspicious was that one of the
  45841. cq bots was doing most of the work. Turns out they're actually
  45842. pretty even in their recent pass counts.
  45843. * QueueStatusServer/handlers/queuestatus.py:
  45844. * QueueStatusServer/index.yaml:
  45845. * QueueStatusServer/templates/queuestatus.html:
  45846. 2011-04-18 Dirk Pranke <dpranke@chromium.org>
  45847. Reviewed by Eric Seidel.
  45848. new-run-webkit-tests: obsolete old threading code, part 1
  45849. https://bugs.webkit.org/show_bug.cgi?id=58752
  45850. This patch removes support for the 'old-inline' and
  45851. 'old-threads' worker models, and deletes the corresponding code.
  45852. Now that the new code is stable, this stuff is no longer
  45853. necessary.
  45854. * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py: Removed.
  45855. * Scripts/webkitpy/layout_tests/layout_package/message_broker.py: Removed.
  45856. * Scripts/webkitpy/layout_tests/layout_package/message_broker_unittest.py: Removed.
  45857. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45858. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  45859. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  45860. 2011-04-18 Dirk Pranke <dpranke@chromium.org>
  45861. Reviewed by Eric Seidel.
  45862. new-run-webkit-tests: add an --additional-drt-flag option
  45863. https://bugs.webkit.org/show_bug.cgi?id=58680
  45864. NRWT has a bunch of command line flags that exist to pass
  45865. custom flags to DRT, especially on chromium. It would be nice
  45866. if there was a generic mechanism to pass through flags so we
  45867. didn't have all the custom ones.
  45868. * Scripts/webkitpy/layout_tests/port/chromium.py:
  45869. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  45870. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  45871. * Scripts/webkitpy/layout_tests/port/test.py:
  45872. * Scripts/webkitpy/layout_tests/port/webkit.py:
  45873. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  45874. 2011-04-05 Jer Noble <jer.noble@apple.com>
  45875. Reviewed by Sam Weinig.
  45876. WebKit2: WKTR should support WebKit2 full screen APIs
  45877. https://bugs.webkit.org/show_bug.cgi?id=56318
  45878. Respond to enterFullScreenForElement() and exitFullScreenForElement(), allowing
  45879. WKTR to test the LayoutTest/fullscreen/ tests.
  45880. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  45881. (WTR::InjectedBundlePage::InjectedBundlePage): Add support for WKBundlePageFullScreenClient.
  45882. (WTR::InjectedBundlePage::supportsFullScreen): Added.
  45883. (WTR::InjectedBundlePage::enterFullScreenForElement): Added.
  45884. (WTR::InjectedBundlePage::exitFullScreenForElement): Added.
  45885. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  45886. * WebKitTestRunner/TestController.cpp:
  45887. (WTR::TestController::resetStateToConsistentValues): Enable the full screen preference.
  45888. 2011-04-18 Dirk Pranke <dpranke@chromium.org>
  45889. Reviewed by Tony Chang.
  45890. new-run-webkit-tests: remove chromium-specific relpath hack for --results-directory
  45891. https://bugs.webkit.org/show_bug.cgi?id=58388
  45892. * Scripts/webkitpy/layout_tests/port/chromium.py:
  45893. 2011-04-18 Evan Martin <evan@chromium.org>
  45894. Reviewed by Eric Seidel.
  45895. [chromium] expose title direction to webkit client
  45896. https://bugs.webkit.org/show_bug.cgi?id=58823
  45897. * DumpRenderTree/chromium/LayoutTestController.cpp:
  45898. (LayoutTestController::LayoutTestController):
  45899. (LayoutTestController::reset):
  45900. * DumpRenderTree/chromium/LayoutTestController.h:
  45901. (LayoutTestController::setTitleTextDirection):
  45902. Add member and setter to let us stash the title direction at load time.
  45903. * DumpRenderTree/chromium/WebViewHost.cpp:
  45904. (WebViewHost::didReceiveTitle):
  45905. * DumpRenderTree/chromium/WebViewHost.h:
  45906. Adapt to new API; push the title into layoutTestController when we
  45907. receive it.
  45908. 2011-04-18 Dirk Pranke <dpranke@chromium.org>
  45909. Unreviewed.
  45910. Re-land r84112. It was rolled out in r84127 but it didn't need
  45911. to be. Only r84111 actually broke things.
  45912. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  45913. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  45914. 2011-04-18 Dirk Pranke <dpranke@chromium.org>
  45915. Reviewed by Tony Chang.
  45916. new-run-webkit-tests: don't run more processes than necessary
  45917. https://bugs.webkit.org/show_bug.cgi?id=58751
  45918. Previously NRWT would start up 1 process for each processor on
  45919. the machine by default, which was a waste if we were only
  45920. running a few shards of tests.
  45921. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  45922. * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  45923. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  45924. 2011-04-18 Ojan Vafai <ojan@chromium.org>
  45925. Reviewed by Eric Seidel.
  45926. include links to actual.png files for new pixel tests
  45927. https://bugs.webkit.org/show_bug.cgi?id=58831
  45928. Load image elements to confirm whether the files exist.
  45929. Image elements will load without being appended to the DOM.
  45930. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45931. 2011-04-18 Ojan Vafai <ojan@chromium.org>
  45932. Reviewed by Eric Seidel.
  45933. add a zoomed view for pixel results to the new results html file
  45934. https://bugs.webkit.org/show_bug.cgi?id=58827
  45935. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45936. 2011-04-18 Ojan Vafai <ojan@chromium.org>
  45937. Reviewed by Eric Seidel.
  45938. add labels to results html page
  45939. https://bugs.webkit.org/show_bug.cgi?id=58803
  45940. -fix iframe size to be the size of the png results
  45941. -fix a bunch of aesthetic nits
  45942. -fix some incorrectly styled code
  45943. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  45944. 2011-04-18 Chang Shu <cshu@webkit.org>
  45945. Reviewed by Eric Seidel.
  45946. WebKitTestRunner needs layoutTestController.pathToLocalResource
  45947. https://bugs.webkit.org/show_bug.cgi?id=42541
  45948. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  45949. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  45950. * WebKitTestRunner/InjectedBundle/mac/LayoutTestControllerMac.mm:
  45951. (WTR::LayoutTestController::pathToLocalResource):
  45952. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  45953. (WTR::LayoutTestController::pathToLocalResource):
  45954. * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
  45955. (WTR::LayoutTestController::pathToLocalResource):
  45956. 2011-04-18 Timothy Hatcher <timothy@apple.com>
  45957. Make update-webkit-localizable-strings put WebKit/win strings in WebCore
  45958. now that all localized strings in WebKit/win use WEB_UI_STRING.
  45959. https://webkit.org/b/58747
  45960. Reviewed by Dan Bernstein.
  45961. * Scripts/update-webkit-localizable-strings: Remove the code that updated WebKit/win differently.
  45962. 2011-04-18 Patrick Gansterer <paroga@webkit.org>
  45963. Reviewed by Adam Roben.
  45964. [WIN] Use WCHAR instead of TCHAR
  45965. https://bugs.webkit.org/show_bug.cgi?id=58755
  45966. We always use the UNICODE versions of windows functions, so
  45967. the usage of TCHAR makes no sense and mixing them is bad style.
  45968. * WinLauncher/PrintWebUIDelegate.cpp:
  45969. Also fix various style issues (including indentation and removal of ugly C-casts).
  45970. * WinLauncher/WinLauncher.cpp:
  45971. 2011-04-18 Dominic Cooney <dominicc@chromium.org>
  45972. Reviewed by Andreas Kling.
  45973. Add layoutTestController.shadowRoot to Qt DRT.
  45974. https://bugs.webkit.org/show_bug.cgi?id=58759
  45975. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  45976. (LayoutTestController::shadowRoot): Added.
  45977. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  45978. 2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
  45979. Unreviewed, rolling out r84111.
  45980. http://trac.webkit.org/changeset/84111
  45981. https://bugs.webkit.org/show_bug.cgi?id=58771
  45982. Chromium linux layout tests are broken. (Requested by loislo2
  45983. on #webkit).
  45984. * Scripts/webkitpy/layout_tests/port/chromium.py:
  45985. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  45986. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  45987. 2011-04-18 Sheriff Bot <webkit.review.bot@gmail.com>
  45988. Unreviewed, rolling out r84112.
  45989. http://trac.webkit.org/changeset/84112
  45990. https://bugs.webkit.org/show_bug.cgi?id=58770
  45991. Chromium linux layout tests are broken. (Requested by loislo2
  45992. on #webkit).
  45993. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  45994. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  45995. 2011-04-17 Daniel Bates <dbates@webkit.org>
  45996. Reviewed by Eric Seidel and Adam Barth.
  45997. webkit-patch land hangs if svn prompts for credentials
  45998. https://bugs.webkit.org/show_bug.cgi?id=31500
  45999. Prompt for username and password when using git-svn and there aren't cached SVN credentials.
  46000. * Scripts/webkitpy/common/checkout/scm.py:
  46001. - Added mixin class SVNRepository and made both class SVN and Git inherit from it.
  46002. - Moved SVN.has_authorization_for_realm() to class SVNRepository and removed default value
  46003. for argument realm; modified call sites as needed.
  46004. - Modified AuthenticationError constructor to take optional prompt_for_password argument.
  46005. - Modified {SCM, SVN, Git}.commit_with_message() to take optional password argument.
  46006. - Modified Git._commit_on_branch() to take optional username and password argument.
  46007. - Modified Git.push_local_commits_to_server() to take optional username and password
  46008. argument and to call has_authorization_for_realm().
  46009. * Scripts/webkitpy/common/checkout/scm_unittest.py:
  46010. - Modified SVNTest.test_commit_without_authorization() to take dummy realm argument.
  46011. - Modified SVNTest.test_not_have_authorization_for_realm() to pass realm argument to
  46012. SVN.has_authorization_for_realm().
  46013. * Scripts/webkitpy/common/net/credentials.py:
  46014. - Modified Credentials.read_credentials() to call User.prompt_password() instead
  46015. of using getpass.getpass() directly.
  46016. * Scripts/webkitpy/common/system/user.py:
  46017. - Added User.prompt_password().
  46018. * Scripts/webkitpy/tool/steps/commit.py:
  46019. - Modified Commit.run() to prompt for a password if needed.
  46020. 2011-04-17 Dirk Pranke <dpranke@chromium.org>
  46021. Reviewed by Ojan Vafai.
  46022. new-run-webkit-tests: save stderr into the layout-test-results dir
  46023. https://bugs.webkit.org/show_bug.cgi?id=58690
  46024. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  46025. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  46026. 2011-04-17 Dirk Pranke <dpranke@chromium.org>
  46027. Reviewed by Ojan Vafai.
  46028. new-run-webkit-tests: read stderr from chromium DRT separately
  46029. https://bugs.webkit.org/show_bug.cgi?id=58708
  46030. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46031. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  46032. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  46033. 2011-04-17 Patrick Gansterer <paroga@webkit.org>
  46034. Reviewed by Adam Barth.
  46035. Rename PLATFORM(CA) to USE(CA)
  46036. https://bugs.webkit.org/show_bug.cgi?id=58742
  46037. * DumpRenderTree/mac/DumpRenderTree.mm:
  46038. (resetDefaultsToConsistentValues):
  46039. 2011-04-17 Patrick Gansterer <paroga@webkit.org>
  46040. Reviewed by Adam Barth.
  46041. Rename PLATFORM(CG) to USE(CG)
  46042. https://bugs.webkit.org/show_bug.cgi?id=58729
  46043. * DumpRenderTree/PixelDumpSupport.cpp:
  46044. * DumpRenderTree/chromium/WebViewHost.cpp:
  46045. (WebViewHost::paintRect):
  46046. * DumpRenderTree/config.h:
  46047. * DumpRenderTree/win/PixelDumpSupportWin.cpp:
  46048. (createBitmapContextFromWebView):
  46049. * TestWebKitAPI/PlatformWebView.h:
  46050. * WebKitTestRunner/config.h:
  46051. * WebKitTestRunner/win/TestInvocationWin.cpp:
  46052. 2011-04-16 Patrick Gansterer <paroga@webkit.org>
  46053. Reviewed by Eric Seidel.
  46054. Rename PLATFORM(CAIRO) to USE(CAIRO)
  46055. https://bugs.webkit.org/show_bug.cgi?id=55192
  46056. * DumpRenderTree/PixelDumpSupport.cpp:
  46057. * DumpRenderTree/config.h:
  46058. * DumpRenderTree/win/PixelDumpSupportWin.cpp:
  46059. (createBitmapContextFromWebView):
  46060. * WebKitTestRunner/config.h:
  46061. 2011-04-16 Ojan Vafai <ojan@chromium.org>
  46062. Reviewed by Eric Seidel.
  46063. show diffs+test inline in the results page
  46064. https://bugs.webkit.org/show_bug.cgi?id=58723
  46065. Put each row in it's own tbody and sort based on tbodies. That way
  46066. we can append the results to the tbody inline as another table row.
  46067. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46068. 2011-04-16 Ojan Vafai <ojan@chromium.org>
  46069. Reviewed by Eric Seidel.
  46070. handle new tests in the new results html file
  46071. https://bugs.webkit.org/show_bug.cgi?id=58715
  46072. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46073. 2011-04-15 Dirk Pranke <dpranke@chromium.org>
  46074. Reviewed by Ojan Vafai.
  46075. old-run-webkit-tests: save the list of tests actually run to a file
  46076. https://bugs.webkit.org/show_bug.cgi?id=58692
  46077. * Scripts/old-run-webkit-tests:
  46078. 2011-04-15 Dirk Pranke <dpranke@chromium.org>
  46079. Reviewed by Ojan Vafai.
  46080. fix MockFileSystem.abspath() on windows
  46081. https://bugs.webkit.org/show_bug.cgi?id=58713
  46082. The existing code was borked on Windows if a path was passed
  46083. in using a drive letter (e.g., "d:\foo.txt"), and would go
  46084. into an infinite recursive loop. While win paths shouldn't
  46085. normally be passed into the mock filesystem, this just
  46086. bulletproofs things a bit (note that "/foo.txt" is considered
  46087. an absolute path on windows python as well.
  46088. * Scripts/webkitpy/common/system/filesystem_mock.py:
  46089. 2011-04-15 Ojan Vafai <ojan@chromium.org>
  46090. Reviewed by Eric Seidel.
  46091. show stderr files and httpd log files
  46092. https://bugs.webkit.org/show_bug.cgi?id=58714
  46093. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46094. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  46095. 2011-04-15 Shishir Agrawal <shishir@chromium.org>
  46096. Reviewed by James Robinson.
  46097. Add a flag to guard Page Visibility API changes.
  46098. https://bugs.webkit.org/show_bug.cgi?id=58464
  46099. * Scripts/build-webkit:
  46100. 2011-04-15 Chang Shu <cshu@webkit.org>
  46101. Reviewed by Alexey Proskuryakov.
  46102. When a message with url embedded is added to console, the "file:" scheme
  46103. and path should be stripped.
  46104. https://bugs.webkit.org/show_bug.cgi?id=58665
  46105. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  46106. (WTR::lastFileURLPathComponent):
  46107. (WTR::InjectedBundlePage::willAddMessageToConsole):
  46108. 2011-04-15 Jeff Miller <jeffm@apple.com>
  46109. Reviewed by Sam Weinig.
  46110. Add takeFocus callback to WKPageUIClient
  46111. https://bugs.webkit.org/show_bug.cgi?id=58686
  46112. Add empty WKPageUIClient entries for the takeFocus callback in the MiniBrowser and WebKitTestRunner.
  46113. * MiniBrowser/mac/BrowserWindowController.m:
  46114. (-[BrowserWindowController awakeFromNib]): Added empty takeFocus entry.
  46115. * MiniBrowser/win/BrowserView.cpp:
  46116. (BrowserView::create): Added empty takeFocus entry.
  46117. * WebKitTestRunner/TestController.cpp:
  46118. (WTR::TestController::createOtherPage): Added empty takeFocus entry.
  46119. (WTR::TestController::initialize): Added empty takeFocus entry.
  46120. 2011-04-15 Ojan Vafai <ojan@chromium.org>
  46121. Reviewed by Eric Seidel.
  46122. only show pretty-diff/wdiff if they were generated
  46123. https://bugs.webkit.org/show_bug.cgi?id=58682
  46124. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46125. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  46126. * Scripts/webkitpy/layout_tests/port/base.py:
  46127. 2011-04-15 Andreas Kling <kling@webkit.org>
  46128. Reviewed by Antonio Gomes.
  46129. [Qt] DRT: Default custom policy delegate decision should be Ignore.
  46130. If layoutTestController.setCustomPolicyDelegate() is called with only
  46131. one argument, the second ("permissive") should default to false.
  46132. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  46133. 2011-04-15 Ojan Vafai <ojan@chromium.org>
  46134. Reviewed by Eric Seidel.
  46135. fix path to layout test in new results file
  46136. https://bugs.webkit.org/show_bug.cgi?id=58618
  46137. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46138. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  46139. 2011-04-15 Ojan Vafai <ojan@chromium.org>
  46140. Reviewed by Eric Seidel.
  46141. fix sorting in new results file
  46142. https://bugs.webkit.org/show_bug.cgi?id=58616
  46143. -Fix the custom sort to return -1, 0, 1 instead of true/false.
  46144. -Secondary sort by test name when sort values are equal.
  46145. -Sort by test name by default.
  46146. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46147. 2011-04-15 Dmitry Lomov <dslomov@google.com>
  46148. Reviewed by David Levin.
  46149. check-webkit-style shouldn't complain about not including a primary header file
  46150. if none exists
  46151. https://bugs.webkit.org/show_bug.cgi?id=39514
  46152. * Scripts/webkitpy/style/checkers/cpp.py:
  46153. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  46154. 2011-04-15 Eric Seidel <eric@webkit.org>
  46155. Reviewed by Mihai Parparita.
  46156. queues.webkit.org should display when a bot last rebooted
  46157. https://bugs.webkit.org/show_bug.cgi?id=58562
  46158. There is more repeated code here than I would like. I fear
  46159. my django-fu isn't quite up to snuff.
  46160. * QueueStatusServer/handlers/queuestatus.py:
  46161. * QueueStatusServer/templates/queuestatus.html:
  46162. 2011-04-14 Alok Priyadarshi <alokp@chromium.org>
  46163. Reviewed by Adam Barth.
  46164. Remove dependency on chromium skia::PlatformCanvas
  46165. https://bugs.webkit.org/show_bug.cgi?id=57563
  46166. Fixed compile error on Mac when using Core Graphics.
  46167. * DumpRenderTree/chromium/WebViewHost.cpp:
  46168. (WebViewHost::paintRect):
  46169. 2011-04-14 Alok Priyadarshi <alokp@chromium.org>
  46170. Reviewed by James Robinson.
  46171. Remove dependency on chromium skia::PlatformCanvas
  46172. https://bugs.webkit.org/show_bug.cgi?id=57563
  46173. * DumpRenderTree/chromium/TestShell.cpp:
  46174. (makeCanvasOpaque):
  46175. (TestShell::dumpImage):
  46176. * DumpRenderTree/chromium/TestShell.h:
  46177. * DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:
  46178. (WebThemeControlDRTWin::WebThemeControlDRTWin):
  46179. (WebThemeControlDRTWin::draw):
  46180. (WebThemeControlDRTWin::drawTextField):
  46181. (WebThemeControlDRTWin::drawProgressBar):
  46182. * DumpRenderTree/chromium/WebThemeControlDRTWin.h:
  46183. * DumpRenderTree/chromium/WebViewHost.cpp:
  46184. (WebViewHost::canvas):
  46185. * DumpRenderTree/chromium/WebViewHost.h:
  46186. 2011-04-14 Keith Kyzivat <keith.kyzivat@nokia.com>
  46187. Reviewed by Laszlo Gombos.
  46188. [Qt] Add -maximize flag to QtTestBrowser and MiniBrowser
  46189. https://bugs.webkit.org/show_bug.cgi?id=58007
  46190. Adds flag to start the test browsers maximized.
  46191. Symbian started maximized on QtTestBrowser - made MiniBrowser follow
  46192. suit.
  46193. Also fixes some ToggleFullScreen issues so that prior window state is
  46194. restored.
  46195. * MiniBrowser/qt/BrowserWindow.cpp:
  46196. (BrowserWindow::BrowserWindow):
  46197. (BrowserWindow::toggleFullScreenMode):
  46198. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  46199. (MiniBrowserApplication::handleUserOptions):
  46200. * MiniBrowser/qt/MiniBrowserApplication.h:
  46201. (WindowOptions::WindowOptions):
  46202. * QtTestBrowser/launcherwindow.cpp:
  46203. (LauncherWindow::init):
  46204. (LauncherWindow::toggleFullScreenMode):
  46205. * QtTestBrowser/launcherwindow.h:
  46206. (WindowOptions::WindowOptions):
  46207. * QtTestBrowser/main.cpp:
  46208. (LauncherApplication::handleUserOptions):
  46209. 2011-04-14 Ojan Vafai <ojan@chromium.org>
  46210. Reviewed by Eric Seidel.
  46211. add checkbox to only show unexpected results to new results file
  46212. https://bugs.webkit.org/show_bug.cgi?id=58606
  46213. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46214. 2011-04-13 Brent Fulgham <bfulgham@webkit.org>
  46215. Reviewed by Martin Robinson.
  46216. [WinCairo] Implement ImageDiff Logic.
  46217. http://bugs.webkit.org/show_bug.cgi?id=58486
  46218. * DumpRenderTree/win/ImageDiffCairo.cpp: Added.
  46219. (strtof):
  46220. (readFromData):
  46221. (createImageFromStdin):
  46222. (releaseMallocBuffer):
  46223. (createDifferenceImage):
  46224. (imageHasAlpha):
  46225. (writeToData):
  46226. (main):
  46227. * DumpRenderTree/win/ImageDiff.vcproj: Updated for new
  46228. ImageDiffCairo.cpp (excluding from Apple builds).
  46229. * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Use
  46230. new ImageDiffWinCairoCommon.vsprops file.
  46231. * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Use
  46232. new ImageDiffWinCairoCommon.vsprops file.
  46233. * DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops: Added.
  46234. * Scripts/old-run-webkit-tests: Make sure proper executable
  46235. is built and executed for WinCairo port.
  46236. 2011-04-14 Ojan Vafai <ojan@chromium.org>
  46237. Reviewed by Eric Seidel.
  46238. only show expected failure type for ports that use an expectations file
  46239. https://bugs.webkit.org/show_bug.cgi?id=58588
  46240. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46241. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  46242. 2011-04-14 Eric Seidel <eric@webkit.org>
  46243. Reviewed by Adam Barth.
  46244. commit-queue fails to catch IOError when results.html is missing
  46245. https://bugs.webkit.org/show_bug.cgi?id=58589
  46246. * Scripts/webkitpy/tool/commands/queues.py:
  46247. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  46248. 2011-04-14 Kevin Ollivier <kevino@theolliviers.com>
  46249. [wx] Unreviewed build fix for Mac installation script.
  46250. * wx/packaging/build-mac-installer.py:
  46251. 2011-04-14 Ojan Vafai <ojan@chromium.org>
  46252. Reviewed by Tony Chang.
  46253. sort columns in the new json_results.html file
  46254. https://bugs.webkit.org/show_bug.cgi?id=58581
  46255. Also fix padding on TDs and the path to layout tests.
  46256. * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
  46257. 2011-04-14 Eric Seidel <eric@webkit.org>
  46258. Reviewed by Dimitri Glazkov.
  46259. queues.webkit.org should display when a bot last passed a patch
  46260. https://bugs.webkit.org/show_bug.cgi?id=58546
  46261. I am suspicious that some of our commit-queue instances are never
  46262. actually passing anything.
  46263. This will let us know if those bots are never passing patches.
  46264. * QueueStatusServer/handlers/queuestatus.py:
  46265. * QueueStatusServer/index.yaml:
  46266. * QueueStatusServer/templates/queuestatus.html:
  46267. 2011-04-14 Dirk Pranke <dpranke@chromium.org>
  46268. Reviewed by Adam Roben.
  46269. REGRESSION (r83764): webkitpy.layout_tests.port.chromium_win_unittest.ChromiumWinTest.test_default_worker_model fails on apple-windows-13
  46270. https://bugs.webkit.org/show_bug.cgi?id=58545
  46271. Remove platform-specific overrides; the default behavior should
  46272. be working everywhere now, I think.
  46273. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  46274. * Scripts/webkitpy/layout_tests/port/mac.py:
  46275. 2011-04-14 Eric Seidel <eric@webkit.org>
  46276. Reviewed by Adam Barth.
  46277. commit-queues are hitting an exception trying to land when the tree is red
  46278. https://bugs.webkit.org/show_bug.cgi?id=58558
  46279. Just an un-tested (and thus broken) code path from yesterday's changes.
  46280. * Scripts/webkitpy/common/net/layouttestresults.py:
  46281. * Scripts/webkitpy/common/net/layouttestresults_unittest.py:
  46282. * Scripts/webkitpy/tool/commands/queues.py:
  46283. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  46284. 2011-04-14 Kevin Ollivier <kevino@theolliviers.com>
  46285. [wx] Unreviewed build fixes for wxMSW and wx 2.9.1.1.
  46286. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  46287. (LayoutTestController::shadowRoot):
  46288. * wx/build/wxpresets.py:
  46289. 2011-04-14 Victoria Kirst <vrk@google.com>
  46290. Reviewed by James Robinson.
  46291. [chromium] Failing GPU video tests
  46292. https://bugs.webkit.org/show_bug.cgi?id=57926
  46293. Added/updated GPU directory names for rebaseline tool.
  46294. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  46295. 2011-04-13 Daniel Bates <dbates@rim.com>
  46296. Reviewed by Adam Barth.
  46297. Perl unit test removeEOL.pl should print test case name on failure
  46298. https://bugs.webkit.org/show_bug.cgi?id=58513
  46299. * Scripts/webkitperl/VCSUtils_unittest/removeEOL.pl: Pass $title as
  46300. second argument of Test::Simple::ok().
  46301. 2011-04-13 Kent Tamura <tkent@chromium.org>
  46302. Reviewed by Eric Seidel.
  46303. gdb-safari should pass arguments to safari.
  46304. https://bugs.webkit.org/show_bug.cgi?id=58439
  46305. We can do:
  46306. gdb-safari --debug LayoutTests/.../foo.html
  46307. * Scripts/gdb-safari: Passing @ARGV to Safari via gdb --arg.
  46308. 2011-04-13 Dirk Pranke <dpranke@chromium.org>
  46309. Unreviewed, build fix.
  46310. https://bugs.webkit.org/show_bug.cgi?id=52763
  46311. r83799 broke test-webkitpy because it assumed we always have
  46312. access to a real filesystem (we don't during the unit tests).
  46313. Stubbing out the copy for now but we might need a better
  46314. solution at some point.
  46315. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  46316. 2011-04-13 Dirk Pranke <dpranke@chromium.org>
  46317. Reviewed by Tony Chang.
  46318. new-run-webkit-tests --run-singly option is busted
  46319. https://bugs.webkit.org/show_bug.cgi?id=55909
  46320. Python's broken lexical scoping strikes again :(.
  46321. * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  46322. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  46323. 2011-04-13 Ojan Vafai <ojan@chromium.org>
  46324. Reviewed by Eric Seidel.
  46325. generated unexpected_results.html from unexpected_results.json
  46326. https://bugs.webkit.org/show_bug.cgi?id=52763
  46327. Eventually, we'll merge this with results.html and have a single richer results page.
  46328. For now, I just want to get something checked in that we can iterate on.
  46329. * Scripts/webkitpy/layout_tests/layout_package/json_results.html: Added.
  46330. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  46331. 2011-04-13 Eric Seidel <eric@webkit.org>
  46332. Reviewed by Adam Barth.
  46333. Up the failure limit to allow the commit-queue to actually land when the tree is red
  46334. https://bugs.webkit.org/show_bug.cgi?id=58499
  46335. This change increases the --exit-after-N-failures limit used by the commit-queue
  46336. from 1 to 10. This will cause the code added in bug 58494 to actually get
  46337. exercised and the queues should start being able to land when the trees are red.
  46338. When testing I found that test_runtests_leopard_commit_queue_hack_command was the
  46339. only unit test to actually detect this change! Since we don't actually
  46340. run on leopard anymore, I removed the hack code and repurposed the test.
  46341. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  46342. * Scripts/webkitpy/tool/steps/runtests.py:
  46343. * Scripts/webkitpy/tool/steps/steps_unittest.py:
  46344. 2011-04-13 Eric Seidel <eric@webkit.org>
  46345. Reviewed by Adam Barth.
  46346. commit-queue should be able to land when tree is red
  46347. https://bugs.webkit.org/show_bug.cgi?id=58494
  46348. There is some yak hair on my hands, I will admit.
  46349. This change is mostly about adding an ExpectedFailures
  46350. class to track when the bots are red and we should be
  46351. ignoring failures when landing from the commit-queue.
  46352. However, to make intelligent decisions about patches we
  46353. need to know whether the run hit the --exit-after-N-failures limit
  46354. or not. Right now that information is not saved off in results.html
  46355. so we have to pull the information from RunTests.
  46356. I've plumbed the --exit-after-N-failures information into
  46357. LayoutTestResults for now to make the ExpectedFailures code cleaner.
  46358. As a result of adding all these additional calls to delegate.layout_test_results()
  46359. I broke some of our flaky test detection tests and had to re-write them
  46360. to not depend on the number of layout_test_results code.
  46361. At the same time I updated the commit-queue to use the newer filesystem
  46362. API (to allow us to use MockFileSystem) which required further changes
  46363. to the layout tests. Changes were required in either case, since
  46364. we're now calling layout_test_results() in more cases, which previously
  46365. would try and hit the disk (until I moved it to use tool.filesystem).
  46366. I should note that *all* of this code is disabled for now, since our
  46367. --exit-after-N-failures limit is currently 1! (Thus were always in the
  46368. case where we can't actually tell if the layout test results are legit.)
  46369. I will up that limit in a second patch (which may require a couple more unit test tweaks).
  46370. * Scripts/webkitpy/common/net/layouttestresults.py:
  46371. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  46372. * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
  46373. * Scripts/webkitpy/tool/bot/expectedfailures.py: Added.
  46374. * Scripts/webkitpy/tool/bot/expectedfailures_unittest.py: Added.
  46375. * Scripts/webkitpy/tool/commands/queues.py:
  46376. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  46377. * Scripts/webkitpy/tool/commands/queuestest.py:
  46378. * Scripts/webkitpy/tool/steps/runtests.py:
  46379. 2011-04-13 Brent Fulgham <bfulgham@webkit.org>
  46380. Unreviewed build correction.
  46381. * TestWebKitAPI/PlatformWebView.h: Limit include of
  46382. <CoreGraphics/CGGeometry> to PLATFORM(CG) users.
  46383. 2011-04-13 Mihai Parparita <mihaip@chromium.org>
  46384. Reviewed by Eric Seidel.
  46385. [NRWT] Rename --baseline-search-patch to --additional-platform-directory to match ORWT
  46386. https://bugs.webkit.org/show_bug.cgi?id=58489
  46387. r83743 added --additional-platform-directory to old-run-webkit-tests,
  46388. rename the equivalent flag in new-run-webkit-tests to be consistent.
  46389. * Scripts/webkitpy/layout_tests/port/base.py:
  46390. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  46391. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  46392. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  46393. 2011-04-13 Mihai Parparita <mihaip@chromium.org>
  46394. Reviewed by Eric Seidel.
  46395. Rebaseline queue server
  46396. https://bugs.webkit.org/show_bug.cgi?id=57891
  46397. Adds a simple rebaseline queue server (meant to run at
  46398. http://rebaseline-queue.appspot.com/). It presents a list of all (NRWT)
  46399. builders and their failing tests, and allows those tests to be added to
  46400. a per-builer rebaseline queue.
  46401. A subsequent change will add a mode to NRWT (and/or a wrapper script)
  46402. for pulling the tests to be rebaselined from the server and running them
  46403. with --reset-results (the initial use-case is for the GPU hardware bots,
  46404. which do not have checked-in baselines, therefore there is no need for a
  46405. check-in step yet).
  46406. * RebaselineQueueServer/app.yaml: Added.
  46407. * RebaselineQueueServer/handlers/__init__.py: Added.
  46408. * RebaselineQueueServer/handlers/builderqueue.py: Added.
  46409. * RebaselineQueueServer/handlers/pages.py: Added.
  46410. * RebaselineQueueServer/index.yaml: Added.
  46411. * RebaselineQueueServer/main.py: Added.
  46412. * RebaselineQueueServer/model/__init__.py: Added.
  46413. * RebaselineQueueServer/model/queueentry.py: Added.
  46414. * RebaselineQueueServer/static/builder-frame-empty.html: Added.
  46415. * RebaselineQueueServer/static/styles.css: Added.
  46416. * RebaselineQueueServer/templates/builder-picker.html: Added.
  46417. * RebaselineQueueServer/templates/builder-queue-edit.html: Added.
  46418. * RebaselineQueueServer/templates/builder-queue-list.html: Added.
  46419. * RebaselineQueueServer/templates/home.html: Added.
  46420. 2011-04-13 Dirk Pranke <dpranke@chromium.org>
  46421. Reviewed by Mihai Parparita.
  46422. nrwt: enable multiple processes by default on Chromium Win.
  46423. https://bugs.webkit.org/show_bug.cgi?id=55163
  46424. Re-land r79268; it should be more stable now and will hopefully
  46425. work.
  46426. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  46427. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  46428. 2011-04-13 Dirk Pranke <dpranke@chromium.org>
  46429. Reviewed by Ojan Vafai.
  46430. new-run-webkit-tests: configure logging in child processes properly
  46431. https://bugs.webkit.org/show_bug.cgi?id=58296
  46432. Logging propagated properly from manager to worker processes on
  46433. Unix but not on Windows; this fixes that.
  46434. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
  46435. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  46436. 2011-04-13 Dirk Pranke <dpranke@chromium.org>
  46437. Reviewed by Ojan Vafai.
  46438. new-run-webkit-tests: suppress extraneous pretty patch warnings
  46439. https://bugs.webkit.org/show_bug.cgi?id=58295
  46440. NRWT wasn't being careful about when it logged messages from
  46441. PrettyPatch not being available; it should only log during
  46442. check_build(), and be silent otherwise. This was causing us to
  46443. get multiple errors at runtime, which was confusing.
  46444. * Scripts/webkitpy/layout_tests/port/base.py:
  46445. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  46446. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46447. 2011-04-13 Dirk Pranke <dpranke@chromium.org>
  46448. Reviewed by Jian Li.
  46449. add chromium-linux-x86_64 to rebaseline-chromium-webkit-tests
  46450. https://bugs.webkit.org/show_bug.cgi?id=58461
  46451. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  46452. 2011-04-13 Tony Chang <tony@chromium.org>
  46453. Unreviewed, fix NRWT. Stack:
  46454. return super(ChromiumPort, self).results_directory(self)
  46455. TypeError: results_directory() takes exactly 1 argument (2 given)
  46456. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46457. 2011-04-13 Adam Roben <aroben@apple.com>
  46458. Teach ORWT about extra platform-specific directories to be searched before the default ones
  46459. Fixes <http://webkit.org/b/58446> ORWT needs a way to look in a user-specified directory for
  46460. platform-specific results
  46461. Reviewed by Anders Carlsson.
  46462. * Scripts/old-run-webkit-tests:
  46463. (top-level): Added @additionalPlatformDirectories and hooked up
  46464. --additional-platform-directories to populate it.
  46465. (buildPlatformResultHierarchy): Prepend the additional platform directories to the default
  46466. list (after filtering out any of the additional directories that don't exist).
  46467. 2011-04-13 Lucas Forschler <lforschler@apple.com>
  46468. Reviewed by Adam Roben.
  46469. Add the /T command to taskkill.exe.
  46470. This will kill spawned child processes.
  46471. * BuildSlaveSupport/win/kill-old-processes:
  46472. 2011-04-13 Lucas Forschler <lforschler@apple.com>
  46473. Reviewed by Adam Roben.
  46474. Sort kill list alphabeticaly.
  46475. Fixed capitalization on VcBuildHelper.
  46476. * BuildSlaveSupport/win/kill-old-processes:
  46477. 2011-04-13 Lucas Forschler <lforschler@apple.com>
  46478. Reviewed by Adam Roben.
  46479. https://bugs.webkit.org/show_bug.cgi?id=58384
  46480. Update kill-old-processes to include a few new ones.
  46481. * BuildSlaveSupport/win/kill-old-processes:
  46482. 2011-04-13 Gustavo Noronha Silva <gns@gnome.org>
  46483. Reviewed by Martin Robinson.
  46484. [GTK] PluginPackage should check whether a plugin mixes GTK+ 2 and 3 symbols itself
  46485. https://bugs.webkit.org/show_bug.cgi?id=58297
  46486. Do not disable flash specifically when built with GTK+ 3 -
  46487. PluginPackage should do the right thing while loading plugins.
  46488. * GtkLauncher/main.c:
  46489. (main):
  46490. 2011-04-12 Kent Tamura <tkent@chromium.org>
  46491. Reviewed by Dimitri Glazkov.
  46492. [Chromium] Add WebSettings::setValidationMessageTimerMagnification()
  46493. https://bugs.webkit.org/show_bug.cgi?id=57426
  46494. * DumpRenderTree/chromium/WebPreferences.cpp:
  46495. (WebPreferences::applyTo): Disable the validation message timer.
  46496. 2011-04-12 James Kozianski <koz@chromium.org>
  46497. Unreviewed.
  46498. Adding myself to committers.py.
  46499. * Scripts/webkitpy/common/config/committers.py:
  46500. 2011-04-12 Brent Fulgham <bfulgham@webkit.org>
  46501. Unreviewed build correction for WinCairo bot after r83639.
  46502. https://bugs.webkit.org/show_bug.cgi?id=51790
  46503. Correct typo for the new "update-webkit-wincairo-libs" script.
  46504. * Scripts/build-webkit: Incorrectly calling the
  46505. update-webkit-cairo-libs which does not exist.
  46506. 2011-04-12 Alice Liu <alice.liu@apple.com>
  46507. Reviewed by Jon Honeycutt.
  46508. A change that should have been part of http://trac.webkit.org/changeset/83628
  46509. * DumpRenderTree/win/DumpRenderTree.cpp:
  46510. (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
  46511. 2011-04-12 Dirk Pranke <dpranke@chromium.org>
  46512. Reviewed by Tony Chang.
  46513. new-run-webkit-tests: --results-directory is relative to builddir, not $PWD
  46514. https://bugs.webkit.org/show_bug.cgi?id=58272
  46515. NRWT was interpreting the --results-directory cmd line arg as
  46516. relative to the build directory, not the current working
  46517. directory (ORWT uses the latter, which is much more intuitive).
  46518. This patch fixes the base case, but includes an override for
  46519. Chromium that is needed until the bots can be updated.
  46520. * Scripts/webkitpy/layout_tests/port/base.py:
  46521. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  46522. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46523. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  46524. * Scripts/webkitpy/layout_tests/port/test.py:
  46525. * Scripts/webkitpy/layout_tests/port/webkit.py:
  46526. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  46527. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  46528. 2011-04-12 Philippe Normand <pnormand@igalia.com>
  46529. Unreviewed, roll out r83621 as it broke the GTK build.
  46530. [GTK] arguments passed to build-jsc and build-webkit scripts are not taken into account
  46531. https://bugs.webkit.org/show_bug.cgi?id=58333
  46532. * Scripts/build-jsc:
  46533. * Scripts/build-webkit:
  46534. 2011-04-12 Carl Lobo <carllobo@gmail.com> and Brent Fulgham <bfulgham@webkit.org>
  46535. Reviewed by Adam Roben.
  46536. Patch to download the WinCairo dependancies as part of build-webkit.
  46537. https://bugs.webkit.org/show_bug.cgi?id=51790
  46538. This patch downloads the dependancies from
  46539. http://idisk.mac.com/bfulgham-Public/WinCairoRequirements.zip
  46540. checking the modification timestamp etc.
  46541. * Tools/Scripts/build-webkit
  46542. * Tools/Scripts/update-webkit: Modified to understand the --wincairo
  46543. flag, and to update WinCairo dependencies when used.
  46544. * Tools/Scripts/update-webkit-cairo-libs: added
  46545. * Tools/Scripts/update-webkit-dependency: added
  46546. * Tools/Scripts/update-webkit-auxiliary-libs
  46547. 2011-04-12 Jeff Miller <jeffm@apple.com>
  46548. Reviewed by Adam Roben.
  46549. WebKit2: Pressing Tab in Web Inspector's console does not cycle through completion options
  46550. https://bugs.webkit.org/show_bug.cgi?id=56020
  46551. Don't call TranslateMessage() in the MiniBrowser or TestWebKitAPI for key messages destined for a WebKit2 view,
  46552. since WebKit will do this for us. If we didn't do this, TranslateMessage() would be called twice,
  46553. which would generate two characters for every keypress (for example). I didn't bother doing this for
  46554. WebKitTestRunner, since it doesn't get any WM_KEYDOWN events.
  46555. Add new WebKit2/TranslateMessageGeneratesWMChar test to test expected TranslateMessage() behavior.
  46556. * MiniBrowser/win/main.cpp:
  46557. (shouldTranslateMessage): Added.
  46558. (_tWinMain): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
  46559. * TestWebKitAPI/PlatformUtilities.h: Added shouldTranslateMessage() on Windows.
  46560. * TestWebKitAPI/PlatformWebView.h: Added simulateAKeyDown().
  46561. * TestWebKitAPI/Tests/WebKit2/win/TranslateMessageGeneratesWMChar.cpp: Added.
  46562. (TestWebKitAPI::didNotHandleKeyEventCallback): Added.
  46563. (TestWebKitAPI::runAndWatchForWMChar): Added.
  46564. (TestWebKitAPI::TEST): Added.
  46565. * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
  46566. (TestWebKitAPI::Util::run): Don't call TranslateMessage() unless shouldTranslateMessage() says to.
  46567. (TestWebKitAPI::Util::shouldTranslateMessage): Added.
  46568. * TestWebKitAPI/win/PlatformWebViewWin.cpp:
  46569. (TestWebKitAPI::PlatformWebView::simulateAKeyDown): Added.
  46570. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Added TranslateMessageGeneratesWMChar.cpp.
  46571. 2011-04-12 Dirk Pranke <dpranke@chromium.org>
  46572. Reviewed by Tony Chang.
  46573. new-run-webkit-tests: update code to use port.results_directory() instead of options.results_directory
  46574. https://bugs.webkit.org/show_bug.cgi?id=58290
  46575. This is some preliminary refactoring for bug 58272.
  46576. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  46577. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  46578. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  46579. * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  46580. * Scripts/webkitpy/layout_tests/port/test.py:
  46581. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46582. * Scripts/webkitpy/layout_tests/port/base.py:
  46583. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  46584. 2011-04-12 Dirk Pranke <dpranke@chromium.org>
  46585. Reviewed by Eric Seidel.
  46586. webkitpy: fix mock_filesystem abspath to handle relative paths
  46587. and add filesystem.chdir() and filesystem.getcwd() to be able
  46588. to test this and mock it out.
  46589. https://bugs.webkit.org/show_bug.cgi?id=58288
  46590. * Scripts/webkitpy/common/system/filesystem.py:
  46591. * Scripts/webkitpy/common/system/filesystem_mock.py:
  46592. * Scripts/webkitpy/common/system/filesystem_unittest.py:
  46593. 2011-04-12 Alice Liu <alice.liu@apple.com>
  46594. Reviewed by Sam Weinig.
  46595. https://bugs.webkit.org/show_bug.cgi?id=58292
  46596. Provide new setting to allow site icon loading despite disabling automatic image loading in general.
  46597. * DumpRenderTree/mac/DumpRenderTree.mm:
  46598. (resetDefaultsToConsistentValues): Setting should be off for most tests. Reset to false.
  46599. 2011-04-12 Thouraya ANDOLSI <thouraya.andolsi@st.com>
  46600. Reviewed by Eric Seidel.
  46601. [Qt] Enable JIT build for SH4 platforms.
  46602. https://bugs.webkit.org/show_bug.cgi?id=58317
  46603. * DumpRenderTree/qt/DumpRenderTree.pro:
  46604. * QtTestBrowser/QtTestBrowser.pro:
  46605. * Scripts/webkitdirs.pm:
  46606. 2011-04-12 Tony Chang <tony@chromium.org>
  46607. Reviewed by Andreas Kling.
  46608. [Qt] embed checksums in PNGs written by Qt-DRT
  46609. https://bugs.webkit.org/show_bug.cgi?id=58173
  46610. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  46611. (WebCore::DumpRenderTree::dump):
  46612. 2011-04-12 Eric Seidel <eric@webkit.org>
  46613. Reviewed by Adam Barth.
  46614. commit-queue should upload failure diffs when tests fail
  46615. https://bugs.webkit.org/show_bug.cgi?id=58348
  46616. This change was mostly just plumbing. We were already saving
  46617. this information for flaky test reporting. I just made it possible
  46618. for normal failures to report archives as well.
  46619. I did a little abstraction work to try and share some code between
  46620. flakytestreporter.py and this new code. There is still more we could do.
  46621. In making this change I also went through and updated the various
  46622. places we have urls hard-coded in our python and pointed them at
  46623. common.config.urls.
  46624. * Scripts/webkitpy/common/checkout/scm.py:
  46625. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  46626. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  46627. * Scripts/webkitpy/common/net/statusserver.py:
  46628. * Scripts/webkitpy/layout_tests/port/base.py:
  46629. * Scripts/webkitpy/tool/bot/botinfo.py: Added.
  46630. * Scripts/webkitpy/tool/bot/botinfo_unittest.py: Added.
  46631. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  46632. * Scripts/webkitpy/tool/bot/flakytestreporter.py:
  46633. * Scripts/webkitpy/tool/bot/flakytestreporter_unittest.py:
  46634. * Scripts/webkitpy/tool/commands/queues.py:
  46635. 2011-04-12 Daniel Bates <dbates@rim.com>
  46636. Rubber-stamped by Eric Seidel.
  46637. svn-apply and/or patch(1) has trouble applying patches that makes changes to files
  46638. with Windows line endings
  46639. https://bugs.webkit.org/show_bug.cgi?id=53625
  46640. Fixes an issue where a patch made on a SCM checkout on a Unix file system cannot be
  46641. applied to an SCM checkout on a Windows file system and vice-versa.
  46642. This issue manifests itself due to custom SCM settings as well as differences in
  46643. gitattributes support in older versions of Git (e.g. 1.7.0.3). We implement support
  46644. into svn-apply/unapply to compensate for differences in line endings by converting
  46645. the line endings in a patch to match the line endings in the target file (if it exists).
  46646. * Scripts/VCSUtils.pm:
  46647. - Added parseFirstEOL(), which returns the first end-of-line character(s) that appear in the
  46648. content read from the specified file handle. Obviously, this heuristic will not work
  46649. for files with mixed line endings, but I don't envision such files to be the norm. If
  46650. this turns out to be an issue then we can improve the heuristic.
  46651. - Added firstEOLInFile().
  46652. - Modified parsePatch() and parseDiff() to take an optional hash reference to an options hash.
  46653. In particular, added the hash key shouldNotUseIndexPathEOL to control whether to use the line
  46654. endings in the diff instead of the line endings in the target file.
  46655. - Extracted local variable $chunkRangeRegEx from fixChangeLogPatch() so that it can be
  46656. re-used in parseDiff().
  46657. * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl: Modified to pass {shouldNotUseIndexPathEOL => 1}
  46658. to parsePatch() since these unit tests don't create mock files. Instead, created unit tests that use
  46659. mock files in file VCSUtils_unittest/parseDiffWithMockFiles.pl.
  46660. * Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl: Added.
  46661. * Scripts/webkitperl/VCSUtils_unittest/parseFirstEOL.pl: Added.
  46662. 2011-04-12 Sam Weinig <sam@webkit.org>
  46663. Reviewed by Adam Roben.
  46664. REGRESSION (r83550): Multiple http tests crashing in the web process in SQLite beneath CFNetwork on Windows 7 Release (WebKit2 Tests)
  46665. https://bugs.webkit.org/show_bug.cgi?id=58336
  46666. * WebKitTestRunner/TestController.cpp:
  46667. (WTR::TestController::resetStateToConsistentValues):
  46668. Remove cache clearing as that is causing tests to crash on Windows 7.
  46669. 2011-04-11 Sam Weinig <sam@webkit.org>
  46670. Reviewed by Anders Carlsson.
  46671. REGRESSION(r77974): http/tests/security/aboutBlank/security-context-window-open.html is failing
  46672. <rdar://problem/8981346>
  46673. https://bugs.webkit.org/show_bug.cgi?id=54159
  46674. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  46675. (WTR::InjectedBundlePage::InjectedBundlePage):
  46676. (WTR::InjectedBundlePage::decidePolicyForNavigationAction):
  46677. (WTR::InjectedBundlePage::decidePolicyForNewWindowAction):
  46678. (WTR::InjectedBundlePage::decidePolicyForResponse):
  46679. (WTR::InjectedBundlePage::unableToImplementPolicy):
  46680. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
  46681. Add short-circuited policy client which matches WebKit1.
  46682. * WebKitTestRunner/TestController.cpp:
  46683. (WTR::TestController::resetStateToConsistentValues):
  46684. Clear the cache between tests to ensure consistent results.
  46685. 2011-04-11 George Guo <George.Guo@nokia.com>
  46686. Reviewed by Eric Seidel.
  46687. prepare-ChangeLog support email input but -h did not show the option
  46688. https://bugs.webkit.org/show_bug.cgi?id=58164
  46689. Add email option to -h to improve the usability
  46690. * Scripts/prepare-ChangeLog:
  46691. 2011-04-11 Dimitri Glazkov <dglazkov@chromium.org>
  46692. Reviewed by Eric Carlson.
  46693. Rename MediaControls to MediaControlRootElement.
  46694. https://bugs.webkit.org/show_bug.cgi?id=58250
  46695. * Scripts/do-webcore-rename: Documented the renaming.
  46696. 2011-04-11 Sam Weinig <sam@webkit.org>
  46697. Fix Windows build.
  46698. * MiniBrowser/win/BrowserView.cpp:
  46699. (BrowserView::create):
  46700. 2011-04-11 Sam Weinig <sam@webkit.org>
  46701. Reviewed by Anders Carlsson.
  46702. Move focus management out of WebKit via the UIClient
  46703. <rdar://problem/8784068>
  46704. https://bugs.webkit.org/show_bug.cgi?id=58278
  46705. * MiniBrowser/mac/BrowserWindowController.m:
  46706. (-[BrowserWindowController awakeFromNib]):
  46707. * WebKitTestRunner/TestController.cpp:
  46708. (WTR::TestController::createOtherPage):
  46709. (WTR::TestController::initialize):
  46710. Add stubs for new UIClient functions.
  46711. 2011-02-03 Martin Robinson <mrobinson@igalia.com>
  46712. Reviewed by Eric Seidel.
  46713. [GTK] The GTK+ DRT needs an implementation of the PlainTextController
  46714. https://bugs.webkit.org/show_bug.cgi?id=53605
  46715. Add an implementation of the PlainTextController for the GTK+ DRT.
  46716. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  46717. (addControllerToWindow): Added this helper method.
  46718. (webViewWindowObjectCleared): Use the new helper to add EventSender
  46719. and the PlainTextController to the window object.
  46720. * GNUmakefile.am: Added PlainTextController source files.
  46721. * DumpRenderTree/gtk/PlainTextController.cpp: Added. This will rely
  46722. on DumpRenderTreeSupportGtk to convert a JSValueRef into a WebKitDOMRange
  46723. until that functionality exists somewhere in the WebKitGTK+ stack.
  46724. * DumpRenderTree/gtk/PlainTextController.h: Added.
  46725. 2011-04-11 Yael Aharon <yael.aharon@nokia.com>
  46726. Unreviewed.
  46727. Adding my IRC nick.
  46728. * Scripts/webkitpy/common/config/committers.py:
  46729. 2011-04-11 Dirk Pranke <dpranke@chromium.org>
  46730. Reviewed by Adam Roben.
  46731. new-run-webkit-tests: fix crash when running under windows cmd.exe
  46732. https://bugs.webkit.org/show_bug.cgi?id=58197
  46733. We would intermittently crash when running NRWT directly under
  46734. cmd.exe on windows because we were sharing the stdin file
  46735. descriptor between the python process and the http server.
  46736. cmd.exe really didn't like that, and there was no reason to
  46737. share the descriptor, so we now use a PIPE instead.
  46738. * Scripts/webkitpy/layout_tests/port/http_server.py:
  46739. 2011-04-11 Dirk Pranke <dpranke@chromium.org>
  46740. Reviewed by Ojan Vafai.
  46741. new-run-webkit-tests: add unit tests for Port.diff_image()
  46742. https://bugs.webkit.org/show_bug.cgi?id=58196
  46743. Add the unit tests for the fix in bug 58195.
  46744. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  46745. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  46746. * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
  46747. 2011-04-11 Dirk Pranke <dpranke@chromium.org>
  46748. Reviewed by Tony Chang.
  46749. new-run-webkit-tests: implement support for audio, take two
  46750. https://bugs.webkit.org/show_bug.cgi?id=58195
  46751. Attempt to re-land the fix for bug 58101 (which was initially
  46752. landed in r83330, but rolled out). This is the same patch but
  46753. fixes crashes in Port.diff_image() caused by the change for
  46754. empty image files being None instead of ''.
  46755. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  46756. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  46757. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  46758. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  46759. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  46760. * Scripts/webkitpy/layout_tests/port/base.py:
  46761. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46762. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  46763. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  46764. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  46765. * Scripts/webkitpy/layout_tests/port/test.py:
  46766. * Scripts/webkitpy/layout_tests/port/webkit.py:
  46767. 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
  46768. Reviewed by Xan Lopez.
  46769. [GTK] Implement AccessibilityUIElement::{row|column}IndexRange in DRT
  46770. https://bugs.webkit.org/show_bug.cgi?id=57854
  46771. Implement missing features in GTK's DRT.
  46772. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  46773. (indexRangeInTable): New helper function to get the range string
  46774. for the current cell inside the parent table, either from the
  46775. point of view of rows or columns.
  46776. (AccessibilityUIElement::rowIndexRange): Implemented by relying on
  46777. the new helper function indexRangeInTable().
  46778. (AccessibilityUIElement::columnIndexRange): Ditto.
  46779. 2011-04-11 Mario Sanchez Prada <msanchez@igalia.com>
  46780. Reviewed by Chris Fleizach.
  46781. [GTK] Implement AccessibilityUIElement::cellForColumnAndRow in DRT
  46782. https://bugs.webkit.org/show_bug.cgi?id=57826
  46783. Implement missing feature in GTK's DRT.
  46784. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  46785. (AccessibilityUIElement::cellForColumnAndRow): Implemented, by
  46786. relying on the analogous function from the AtkTable interface.
  46787. 2011-04-05 Timothy Hatcher <timothy@apple.com>
  46788. Fix the extract-localizable-strings script errors that started after
  46789. WEB_UI_STRING was added to LocalizedStrings.h in WebCore.
  46790. * Scripts/extract-localizable-strings: Skip LocalizedStrings.h.
  46791. 2011-04-11 Tony Chang <tony@chromium.org>
  46792. Reviewed by Eric Seidel.
  46793. fix crc computation on 64 bit machines
  46794. https://bugs.webkit.org/show_bug.cgi?id=58243
  46795. unsigned long is dependenct on CPU architecture, so use unsigned which is always 32 bits
  46796. * DumpRenderTree/CyclicRedundancyCheck.cpp:
  46797. (makeCrcTable):
  46798. (computeCrc):
  46799. * DumpRenderTree/CyclicRedundancyCheck.h:
  46800. * DumpRenderTree/PixelDumpSupport.cpp:
  46801. (appendIntToVector):
  46802. (convertChecksumToPNGComment):
  46803. 2011-04-10 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
  46804. Reviewed by Eric Seidel.
  46805. Require no undefined symbols during compilation.
  46806. [Qt] [WK2] WebKitTestRunner, QtWebProcess and WTRInjectBundle should fail to compile when there's undefined symbols
  46807. https://bugs.webkit.org/show_bug.cgi?id=54896
  46808. Add -Wl,--no-undefined to catch missing symbols early.
  46809. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  46810. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  46811. 2011-04-10 Kevin Ollivier <kevino@theolliviers.com>
  46812. [wx] Unreviewed build fix. Remove collector dirs from the list of build dirs.
  46813. * wx/build/settings.py:
  46814. 2011-04-10 Kevin Ollivier <kevino@theolliviers.com>
  46815. [wx] Unreviewed build fix. Add Source/JavaScriptCore/heap to the list of directories.
  46816. * wx/build/settings.py:
  46817. 2011-04-10 David Levin <levin@chromium.org>
  46818. Reviewed by Dimitri Glazkov.
  46819. REGRESSION(r83384): Change to chromium.py is resulting in failures of the test framework on linux.
  46820. https://bugs.webkit.org/show_bug.cgi?id=58201
  46821. * Scripts/webkitpy/layout_tests/port/chromium.py: Commented out the assert for now,
  46822. and filed bug 58202.
  46823. 2011-04-09 David Levin <levin@chromium.org>
  46824. Unreviewed, rolling out r83394.
  46825. http://trac.webkit.org/changeset/83394
  46826. https://bugs.webkit.org/show_bug.cgi?id=53625
  46827. Patch was incorrect as noted in the bug.
  46828. * Scripts/svn-apply:
  46829. 2011-04-09 David Levin <levin@chromium.org>
  46830. Reviewed by Adam Barth.
  46831. svn-apply and/or patch(1) has trouble applying patches that makes changes to files with Windows line endings
  46832. https://bugs.webkit.org/show_bug.cgi?id=53625
  46833. * Scripts/svn-apply: Ensure that the portions of patches
  46834. which are for vcproj/vsprops files has DOS line endings.
  46835. 2011-04-09 Dirk Pranke <dpranke@chromium.org>
  46836. Reviewed by Tony Chang.
  46837. It looks like NRWT has not been stopping DRT/TestShell
  46838. instances properly on windows, probably for a long time.
  46839. This would go a long way to explaining why we often have
  46840. processes lying around :)
  46841. https://bugs.webkit.org/show_bug.cgi?id=57807
  46842. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46843. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  46844. 2011-04-09 Keith Kyzivat <keith.kyzivat@nokia.com>
  46845. Reviewed by Laszlo Gombos.
  46846. [Qt] Don't link against fontconfig or X11 if embedded
  46847. https://bugs.webkit.org/show_bug.cgi?id=58104
  46848. * DumpRenderTree/qt/DumpRenderTree.pro: fontconfig !included in embedded
  46849. * QtTestBrowser/QtTestBrowser.pro: ditto
  46850. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: ditto
  46851. * WebKitTestRunner/qt/WebKitTestRunner.pro: ditto
  46852. 2011-04-08 Jon Honeycutt <jhoneycutt@apple.com>
  46853. http/tests/loading/preload-append-scan.php is failing on Windows
  46854. https://bugs.webkit.org/show_bug.cgi?id=58178
  46855. Reviewed by Brian Weinstein.
  46856. * DumpRenderTree/win/DumpRenderTree.cpp:
  46857. (lastPathComponent):
  46858. Use CFURL API to find the last path component, rather than
  46859. PathFindFileName(), because the latter will include the query string.
  46860. 2011-04-08 Jian Li <jianli@chromium.org>
  46861. Unreviewed, rolling out r83327, r83330 since these patches are very
  46862. likely to break chromium webkit mac10.6 builders.
  46863. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  46864. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  46865. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  46866. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  46867. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  46868. * Scripts/webkitpy/layout_tests/port/base.py:
  46869. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46870. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  46871. * Scripts/webkitpy/layout_tests/port/mock_drt.py:
  46872. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  46873. * Scripts/webkitpy/layout_tests/port/test.py:
  46874. * Scripts/webkitpy/layout_tests/port/webkit.py:
  46875. 2011-04-08 Vincent Scheib <scheib@chromium.org>
  46876. Reviewed by Eric Seidel.
  46877. add chromium-gpu-linux-x86_64 to the recognized list of ports
  46878. https://bugs.webkit.org/show_bug.cgi?id=58099
  46879. Add chromium-gpu-linux-x86_64 to fix assert.
  46880. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  46881. 2011-04-08 Alpha Lam <hclam@chromium.org>
  46882. Unreviewed, rolling out r83335.
  46883. http://trac.webkit.org/changeset/83335
  46884. https://bugs.webkit.org/show_bug.cgi?id=53556
  46885. GTK and QT bots are broken
  46886. * Scripts/build-webkit:
  46887. 2011-04-07 Anna Cavender <annacc@chromium.org>
  46888. Reviewed by Eric Carlson.
  46889. Setup ENABLE(TRACK) feature define
  46890. https://bugs.webkit.org/show_bug.cgi?id=53556
  46891. * Scripts/build-webkit:
  46892. 2011-04-08 Dirk Pranke <dpranke@chromium.org>
  46893. Reviewed by Adam Roben.
  46894. new-run-webkit-tests: configure a NRWT test bot for Mac SL
  46895. https://bugs.webkit.org/show_bug.cgi?id=58114
  46896. This change removes the old new-run-webkit-tests entry and
  46897. updates it for a new test-only bot.
  46898. * BuildSlaveSupport/build.webkit.org-config/config.json:
  46899. 2011-04-08 Dominic Cooney <dominicc@google.com>
  46900. Reviewed by Adam Roben.
  46901. Make layoutTestController.shadowRoot return null, not undefined,
  46902. when its argument is invalid.
  46903. https://bugs.webkit.org/show_bug.cgi?id=58121
  46904. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  46905. (LayoutTestController::shadowRoot):
  46906. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  46907. (WTR::LayoutTestController::shadowRoot):
  46908. 2011-04-08 Pere Martir <pere.martir4@gmail.com>
  46909. Reviewed by Adam Roben.
  46910. Locate NSTD.EXE in 64-bit Windows
  46911. https://bugs.webkit.org/show_bug.cgi?id=57847
  46912. * Scripts/old-run-webkit-tests:
  46913. 2011-04-08 Adam Roben <aroben@apple.com>
  46914. Qt build fix
  46915. * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Pull in stdarg.h for va_list.
  46916. 2011-04-07 Adam Roben <aroben@apple.com>
  46917. Test that NPP_SetWindow is passed a null window handle during plugin destruction on non-Mac platforms
  46918. Test for <http://webkit.org/b/47009> WebKit2 needs to call NPP_SetWindow when destroying a
  46919. plugin
  46920. Reviewed by Anders Carlsson.
  46921. * DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
  46922. (pluginLogWithArguments): Moved code to format and log the message here...
  46923. (pluginLog): ...from here.
  46924. * DumpRenderTree/TestNetscapePlugIn/PluginObject.h: Added pluginLogWithArguments.
  46925. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  46926. (PluginTest::log): Added. Calls through to pluginLogWithArguments.
  46927. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added log.
  46928. * DumpRenderTree/TestNetscapePlugIn/Tests/NPPSetWindowCalledDuringDestruction.cpp: Added.
  46929. (NPPSetWindowCalledDuringDestruction::setWillBeDestroyed): Records that destruction is about
  46930. to begin.
  46931. (NPPSetWindowCalledDuringDestruction::NPPSetWindowCalledDuringDestruction): Simple
  46932. constructor.
  46933. (NPPSetWindowCalledDuringDestruction::NPP_GetValue): Creates and returns a ScriptObject that
  46934. can be used to invoke our setWillBeDestroyed function.
  46935. (NPPSetWindowCalledDuringDestruction::NPP_SetWindow): Records what has happened (and logs if
  46936. anything unexpected happens).
  46937. (NPPSetWindowCalledDuringDestruction::NPP_Destroy): On Mac, logs a failure message if
  46938. NPP_SetWindow was called during destruction. On other platforms, logs a failure message if
  46939. NPP_SetWindow was *not* called during destruction.
  46940. (NPPSetWindowCalledDuringDestruction::ScriptObject::hasMethod): Return true for our only
  46941. method, setWillBeDestroyed.
  46942. (NPPSetWindowCalledDuringDestruction::ScriptObject::invoke): Call through to the PluginTest
  46943. object.
  46944. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  46945. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  46946. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  46947. * GNUmakefile.am:
  46948. Added new test.
  46949. * Scripts/old-run-webkit-tests: Skip the new test when using out-of-process plugins with
  46950. WebKit1 on Mac, since it can't work properly due to <http://webkit.org/b/58077>.
  46951. 2011-04-08 Mario Sanchez Prada <msanchez@igalia.com>
  46952. Reviewed by Martin Robinson.
  46953. [GTK] Implement increment() and decrement() functions in DRT's AccessibilityUIElement
  46954. https://bugs.webkit.org/show_bug.cgi?id=58039
  46955. Implement missing functions in GTK's DRT.
  46956. * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
  46957. (AccessibilityUIElement::increment): Implemented.
  46958. (AccessibilityUIElement::decrement): Implemented.
  46959. 2011-04-08 Dominic Cooney <dominicc@google.com>
  46960. Reviewed by Kent Tamura.
  46961. Make WK2 layoutTestController.shadowRoot return undefined, not
  46962. null, when its argument is not an element.
  46963. https://bugs.webkit.org/show_bug.cgi?id=58121
  46964. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  46965. (WTR::LayoutTestController::shadowRoot):
  46966. 2011-04-07 Dirk Pranke <dpranke@chromium.org>
  46967. Reviewed by Mihai Parparita.
  46968. Change reference port for Mac GPU baselines from
  46969. Leopard to SnowLeopard, XP to Win7, and Linux-x86
  46970. to Linux x86-64.
  46971. https://bugs.webkit.org/show_bug.cgi?id=58099
  46972. * Scripts/webkitpy/layout_tests/port/chromium.py:
  46973. 2011-04-07 Andrew Scherkus <scherkus@chromium.org>
  46974. Revert ENABLE_TRACK patch due to compile failures.
  46975. * Scripts/build-webkit:
  46976. 2011-04-07 Tony Chang <tony@chromium.org>
  46977. Reviewed by Eric Seidel.
  46978. update DRT to embed checksums in png files
  46979. https://bugs.webkit.org/show_bug.cgi?id=57871
  46980. We insert the bytes for the comment in printPNG rather than at encode
  46981. time because each platform does its own PNG encoding (either using CG
  46982. or cairo). Putting this in pringPNG avoids having to duplicate this
  46983. code, although it's not as clean as doing it at encoding time.
  46984. We insert the comment right after the IHDR chunk of the PNG.
  46985. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  46986. * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
  46987. (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
  46988. (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
  46989. * DumpRenderTree/CyclicRedundancyCheck.h: Added.
  46990. * DumpRenderTree/PixelDumpSupport.cpp:
  46991. (dumpWebViewAsPixelsAndCompareWithExpected):
  46992. (convertChecksumToPNGComment): Generate the bytes to insert.
  46993. (printPNG): Insert the png comment before the first IDAT section.
  46994. * DumpRenderTree/PixelDumpSupport.h:
  46995. * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
  46996. (printPNG):
  46997. (dumpBitmap):
  46998. * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
  46999. (printPNG):
  47000. (dumpBitmap):
  47001. * DumpRenderTree/win/DumpRenderTree.vcproj:
  47002. * GNUmakefile.am:
  47003. 2011-04-07 Jeff Miller <jeffm@apple.com>
  47004. Reviewed by Adam Roben.
  47005. Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
  47006. https://bugs.webkit.org/show_bug.cgi?id=58058
  47007. * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
  47008. (TestWebKitAPI::TEST): Add tests for WKStringGetLength() and WKStringGetCharactersPtr().
  47009. 2011-04-07 Chang Shu <cshu@webkit.org>
  47010. Reviewed by Darin Adler.
  47011. WebKitTestRunner needs layoutTestController.isPageBoxVisible
  47012. https://bugs.webkit.org/show_bug.cgi?id=42695
  47013. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47014. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47015. (WTR::LayoutTestController::isPageBoxVisible):
  47016. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47017. 2011-04-07 Adam Roben <aroben@apple.com>
  47018. Build fix
  47019. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Added a missing import.
  47020. 2011-04-07 Adam Roben <aroben@apple.com>
  47021. Move ExtractTestResults[AndLeaks]'s summarizing code back from commandComplete() to finished()
  47022. commandComplete() is never called for MasterShellCommands like ExtractTestResults[AndLeaks].
  47023. (Unfortunately the buildbot documentation does not make this clear.) finished() is the only
  47024. hook we have, so we have to do our work there. I added a new addCustomURLs method which can
  47025. be overridden by subclasses to provide extra URLs before we call up to the base class (after
  47026. which adding more URLs is no longer possible).
  47027. Really hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks
  47028. bot results page
  47029. Reviewed by John Sullivan.
  47030. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  47031. (ExtractTestResults.addCustomURLs): Moved code to add the "view results" URL here...
  47032. (ExtractTestResults.finished): ...from here. This replaces commandComplete, since that
  47033. method is never called for MasterShellCommands.
  47034. (ExtractTestResultsAndLeaks.addCustomURLs): Replaced commandComplete (which is never called)
  47035. with this method (which is).
  47036. 2011-04-07 Adam Roben <aroben@apple.com>
  47037. Move ExtractTestResults[AndLeaks]'s summarizing code from finished() to commandComplete()
  47038. This matches how most of our other build steps work, so is good just for improving
  47039. consistency between build steps. It should also make it possible for
  47040. ExtractTestResultsAndLeaks to successfully add a URL to Leaks Viewer. (Previously we were
  47041. trying to do this in finished() after we had called up to the base class, but that was
  47042. apparently too late to add more URLs.)
  47043. Hopefully fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot
  47044. results page
  47045. Reviewed by John Sullivan.
  47046. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  47047. (ExtractTestResults): Added a descriptionDone property so that we don't have to manually
  47048. call setText to get the right text to show up for this step. This matches how most of our
  47049. other build steps work.
  47050. (ExtractTestResults.commandComplete): Replaced our override of finished with this function.
  47051. This is how most of our other build steps work.
  47052. (ExtractTestResultsAndLeaks.commandComplete): Replaced our override of finished with this
  47053. function, to match the base class.
  47054. 2011-04-07 Adam Barth <abarth@webkit.org>
  47055. Reviewed by Maciej Stachowiak.
  47056. webkit-patch shouldn't state the whole working copy when calling check-webkit-style
  47057. https://bugs.webkit.org/show_bug.cgi?id=58022
  47058. Previously, we were ignoring the args variable! This patch fixes the
  47059. regression introduced in http://trac.webkit.org/changeset/82771.
  47060. * Scripts/webkitpy/tool/commands/download_unittest.py:
  47061. * Scripts/webkitpy/tool/mocktool.py:
  47062. * Scripts/webkitpy/tool/steps/checkstyle.py:
  47063. 2011-04-07 Maciej Stachowiak <mjs@apple.com>
  47064. Reviewed by Adam Barth.
  47065. REGRESSION: "webkit-patch land" doesn't work correctly in SVN subdirectories
  47066. https://bugs.webkit.org/show_bug.cgi?id=58017
  47067. * Scripts/webkitpy/common/checkout/scm.py:
  47068. * Scripts/webkitpy/common/checkout/scm_unittest.py:
  47069. 2011-04-06 Chang Shu <cshu@webkit.org>
  47070. Reviewed by Darin Adler.
  47071. WebKitTestRunner needs layoutTestController.pageSizeAndMarginsInPixels
  47072. https://bugs.webkit.org/show_bug.cgi?id=57984
  47073. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47074. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47075. (WTR::LayoutTestController::pageSizeAndMarginsInPixels):
  47076. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47077. 2011-04-06 Chris Rogers <crogers@google.com>
  47078. Reviewed by Tony Chang.
  47079. Add web audio support to DumpRenderTree (mac port)
  47080. https://bugs.webkit.org/show_bug.cgi?id=57969
  47081. * DumpRenderTree/LayoutTestController.cpp:
  47082. (LayoutTestController::LayoutTestController):
  47083. (setEncodedAudioDataCallback):
  47084. (LayoutTestController::staticFunctions):
  47085. * DumpRenderTree/LayoutTestController.h:
  47086. (LayoutTestController::dumpAsAudio):
  47087. (LayoutTestController::setDumpAsAudio):
  47088. (LayoutTestController::encodedAudioData):
  47089. (LayoutTestController::setEncodedAudioData):
  47090. * DumpRenderTree/mac/DumpRenderTree.mm:
  47091. (dumpAudio):
  47092. (dump):
  47093. 2011-04-06 Benjamin Poulain <benjamin.poulain@nokia.com>
  47094. Reviewed by Kenneth Rohde Christiansen.
  47095. [Qt] LayoutTestController needs to implement numberOfPendingGeolocationPermissionRequests
  47096. https://bugs.webkit.org/show_bug.cgi?id=56086
  47097. Add the missing method.
  47098. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  47099. (WebCore::DumpRenderTree::getAllPages): Add a method to return all the pages allocated for the current test.
  47100. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  47101. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  47102. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  47103. 2011-04-06 Dai Mikurube <dmikurube@chromium.org>
  47104. Reviewed by David Levin.
  47105. Add QUOTA build flag for unified quota API
  47106. https://bugs.webkit.org/show_bug.cgi?id=57918
  47107. * Scripts/build-webkit: Added QUOTA build flag
  47108. 2011-04-06 Dirk Pranke <dpranke@chromium.org>
  47109. Reviewed by Tony Chang.
  47110. Adjust the apple webkit port's default timeout to match
  47111. old-run-webkit-tests at 35 seconds.
  47112. https://bugs.webkit.org/show_bug.cgi?id=37738
  47113. * Scripts/webkitpy/layout_tests/port/mac.py:
  47114. 2011-04-06 Scott Cameron <sccameron@rim.com>
  47115. Reviewed by Eric Seidel.
  47116. Remove global variable $httpdPath and replace with the return value of
  47117. getHTTPDPath(). Also remove unnecessary calls to getHTTPDPath().
  47118. https://bugs.webkit.org/show_bug.cgi?id=53499
  47119. * Scripts/run-iexploder-tests:
  47120. * Scripts/webkitperl/httpd.pm:
  47121. 2011-04-06 Kevin Ollivier <kevino@theolliviers.com>
  47122. Reviewed by Darin Adler.
  47123. Make sure JS_EXPORT_PRIVATE is an empty define when we aren't using the export macros.
  47124. https://bugs.webkit.org/show_bug.cgi?id=27551
  47125. * DumpRenderTree/config.h:
  47126. * WebKitAPITest/config.h:
  47127. * WebKitTestRunner/config.h:
  47128. 2011-04-06 Tony Chang <tony@chromium.org>
  47129. Reviewed by Darin Adler.
  47130. teach run-webkit-tests to read checksums from png files
  47131. https://bugs.webkit.org/show_bug.cgi?id=57993
  47132. * Scripts/old-run-webkit-tests: Read the first 2k of a .png if there's
  47133. no .checksum and look for the checksum in there.
  47134. 2011-04-06 David Dorwin <ddorwin@chromium.org>
  47135. Reviewed by David Levin.
  47136. Enable fullscreen layout tests for Chromium
  47137. https://bugs.webkit.org/show_bug.cgi?id=55726
  47138. Make DumpRenderTree always run with fullscreen enabled (equivalent of --enable-fullscreen).
  47139. * DumpRenderTree/chromium/WebPreferences.cpp:
  47140. (WebPreferences::applyTo):
  47141. 2011-04-06 Adam Roben <aroben@apple.com>
  47142. Add a "view leaks" link to builds on SnowLeopard Intel Leaks
  47143. Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page
  47144. Reviewed by David Kilzer.
  47145. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  47146. (ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
  47147. build's results directory here...
  47148. (ExtractTestResults.finished): ...from here.
  47149. (ExtractTestResultsAndLeaks): New class that's used by the leaks builder
  47150. (ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
  47151. leaks" link to point to Leaks Viewer for this build.
  47152. (TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
  47153. but it seemed good to add for consistency with BuildAndTestFactory.
  47154. (BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
  47155. (BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
  47156. that we'll get a "view leaks" link.
  47157. 2011-04-06 Zan Dobersek <zandobersek@gmail.com>
  47158. Reviewed by Eric Seidel.
  47159. [Gtk] plugins/set-status.html fails
  47160. https://bugs.webkit.org/show_bug.cgi?id=57844
  47161. Allow an empty status text to be dumped.
  47162. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  47163. (webViewStatusBarTextChanged):
  47164. 2011-04-06 Chang Shu <cshu@webkit.org>
  47165. Reviewed by Darin Adler.
  47166. WebKitTestRunner needs layoutTestController.pageNumberForElementById
  47167. https://bugs.webkit.org/show_bug.cgi?id=42329
  47168. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47169. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47170. (WTR::LayoutTestController::pageNumberForElementById):
  47171. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47172. 2011-04-06 Sergio Villar Senin <svillar@igalia.com>
  47173. Reviewed by Martin Robinson.
  47174. [GTK] DumpRenderTree: do not try to free NULL SoupURIs
  47175. https://bugs.webkit.org/show_bug.cgi?id=57932
  47176. Some Layout tests have invalid URIs that do not generate valid
  47177. SoupURI instances. Do not try to free those NULL SoupURIs.
  47178. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  47179. (willSendRequestCallback):
  47180. 2011-04-06 Csaba Osztrogonác <ossy@webkit.org>
  47181. Reviewed by Andreas Kling.
  47182. ORWT shouldn't generate diff files for tests without expected files
  47183. https://bugs.webkit.org/show_bug.cgi?id=57846
  47184. * Scripts/old-run-webkit-tests:
  47185. 2011-04-05 Kevin Ollivier <kevino@theolliviers.com>
  47186. [wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch
  47187. to deps.
  47188. * wx/install-unix-extras:
  47189. 2011-04-05 Sheriff Bot <webkit.review.bot@gmail.com>
  47190. Unreviewed, rolling out r82978, r82999, and r83001.
  47191. http://trac.webkit.org/changeset/82978
  47192. http://trac.webkit.org/changeset/82999
  47193. http://trac.webkit.org/changeset/83001
  47194. https://bugs.webkit.org/show_bug.cgi?id=57913
  47195. Does not work in Python 2.5 (Requested by abarth on #webkit).
  47196. * Scripts/webkitpy/common/system/executive.py:
  47197. * Scripts/webkitpy/common/system/executive_unittest.py:
  47198. 2011-04-05 Chang Shu <cshu@webkit.org>
  47199. Reviewed by Darin Adler.
  47200. WebKitTestRunner needs layoutTestController.numberOfPages
  47201. https://bugs.webkit.org/show_bug.cgi?id=42694
  47202. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47203. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47204. (WTR::LayoutTestController::numberOfPages):
  47205. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47206. 2011-04-05 Tony Chang <tony@chromium.org>
  47207. Reviewed by Mihai Parparita.
  47208. [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
  47209. https://bugs.webkit.org/show_bug.cgi?id=57889
  47210. * Scripts/webkitpy/layout_tests/port/chromium.py:
  47211. * Scripts/webkitpy/layout_tests/port/test.py:
  47212. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  47213. 2011-04-05 Adam Barth <abarth@webkit.org>
  47214. Silly with statement, from the future!
  47215. * Scripts/webkitpy/common/system/executive.py:
  47216. 2011-04-05 Adam Barth <abarth@webkit.org>
  47217. Reviewed by Tony Chang.
  47218. Don't use Exception.message because it's deprecated
  47219. https://bugs.webkit.org/show_bug.cgi?id=57892
  47220. Suppress the warning for now. When we move to Python 3, we might need
  47221. to something more dramatic.
  47222. * Scripts/webkitpy/common/system/executive.py:
  47223. 2011-04-05 Mihai Parparita <mihaip@chromium.org>
  47224. Reviewed by Ojan Vafai.
  47225. Add builders.js to dashboard file list
  47226. https://bugs.webkit.org/show_bug.cgi?id=57899
  47227. Add file added by http://crrev.com/80538 to dashboard file list.
  47228. * TestResultServer/handlers/dashboardhandler.py:
  47229. 2011-04-05 MORITA Hajime <morrita@google.com>
  47230. Reviewed by Adam Barth.
  47231. webkit-patch should print git's stderr when git svn dcommit fail
  47232. http://webkit.org/b/57861
  47233. * Scripts/webkitpy/common/checkout/scm.py:
  47234. 2011-04-05 Mihai Parparita <mihaip@chromium.org>
  47235. Reviewed by Tony Chang.
  47236. Add --baseline-search-path to NRWT
  47237. https://bugs.webkit.org/show_bug.cgi?id=56233
  47238. Add NRWT option to specify additional directories to look for baselines
  47239. (will be used by hardware GPU bots which will have local per-bot
  47240. expectations for some tests)
  47241. * Scripts/webkitpy/common/system/filesystem_mock.py:
  47242. * Scripts/webkitpy/layout_tests/port/base.py:
  47243. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  47244. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  47245. 2011-04-05 Adam Roben <aroben@apple.com>
  47246. Strip off /results.html from results URLs before trying to load leaks files from them
  47247. r82734 changed build.webkit.org's "view results" URLs to point straight to the results.html
  47248. files, rather than pointing to the directory that contains them. This is more convenient for
  47249. people browsing build.webkit.org, but confused Leaks Viewer.
  47250. Fixes <http://webkit.org/b/57869> REGRESSION (r82734): Links in Leaks Viewer's Recent Builds
  47251. list don't work
  47252. Reviewed by Joseph Pecoraro.
  47253. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  47254. (RecentBuildsLoader.prototype.start): Strip off "/results.html" from the results URL.
  47255. 2011-04-05 Carol Szabo <carol@webkit.org>
  47256. Unreviewed.
  47257. Updated my info in committers.py
  47258. Scripts\webkitpy\common\config\committers.py
  47259. 2011-04-05 Csaba Osztrogonác <ossy@webkit.org>
  47260. Reviewed by Laszlo Gombos.
  47261. [Qt] Make WebKitLibraries optional for building QtWebKit
  47262. https://bugs.webkit.org/show_bug.cgi?id=57542
  47263. * Scripts/build-webkit:
  47264. 2011-04-05 Chang Shu <cshu@webkit.org>
  47265. Reviewed by Laszlo Gombos.
  47266. [Qt] MiniBrowser defaultUrl does not work
  47267. https://bugs.webkit.org/show_bug.cgi?id=57021
  47268. Match the behavior and coding of MiniBrowser to QtTestBrowser.
  47269. * MiniBrowser/qt/main.cpp:
  47270. (main):
  47271. 2011-04-05 Jade Han <jade.han@nokia.com>
  47272. Reviewed by Laszlo Gombos.
  47273. [Qt] [Symbian] Disable WebKitTestRunner for Symbian
  47274. https://bugs.webkit.org/show_bug.cgi?id=54977
  47275. This change is a preparation to enable building webkit2 for Symbian.
  47276. Bug 57834 is filed to fix and enable WebKitTestRunner for Symbian.
  47277. * Tools.pro:
  47278. 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
  47279. Reviewed by Andreas Kling.
  47280. [Qt] Fix timeoutTimer of MiniBrowser's UrlLoader
  47281. https://bugs.webkit.org/show_bug.cgi?id=57832
  47282. Only QWKPage has loadFinished signal so connect to it instead of BrowserWindow.
  47283. * MiniBrowser/qt/UrlLoader.cpp:
  47284. (UrlLoader::UrlLoader):
  47285. 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
  47286. [Qt] Linux Release minimal build fix after r82919.
  47287. * MiniBrowser/qt/BrowserWindow.cpp:
  47288. (BrowserWindow::loadURLListFromFile):
  47289. * QtTestBrowser/launcherwindow.cpp:
  47290. (LauncherWindow::loadURLListFromFile):
  47291. 2011-04-05 Zoltan Horvath <zoltan@webkit.org>
  47292. Reviewed by Andreas Kling.
  47293. [Qt] Make URL loader accessible from testbrowser's menus
  47294. https://bugs.webkit.org/show_bug.cgi?id=57823
  47295. Add "Load URLs from file" to QtTestBrowser's and to MiniBrowser's menu.
  47296. * MiniBrowser/qt/BrowserWindow.cpp:
  47297. (BrowserWindow::BrowserWindow):
  47298. (BrowserWindow::loadURLListFromFile):
  47299. (BrowserWindow::~BrowserWindow):
  47300. * MiniBrowser/qt/BrowserWindow.h:
  47301. * QtTestBrowser/launcherwindow.cpp:
  47302. (LauncherWindow::LauncherWindow):
  47303. (LauncherWindow::~LauncherWindow):
  47304. (LauncherWindow::createChrome):
  47305. (LauncherWindow::loadURLListFromFile):
  47306. * QtTestBrowser/launcherwindow.h:
  47307. 2011-04-04 Sam Weinig <sam@webkit.org>
  47308. Reviewed by Brian Weinstein.
  47309. Remove duplicate API from WKContext
  47310. <rdar://problem/8727879>
  47311. https://bugs.webkit.org/show_bug.cgi?id=57815
  47312. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  47313. * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Removed.
  47314. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  47315. Remove SendingMessagesToTheWebProcessBeforeItIsValid since the API it was testing is now removed.
  47316. 2011-04-04 Tony Chang <tony@chromium.org>
  47317. Reviewed by Ojan Vafai.
  47318. [chromium] don't write .checksum files if a fallback platform has an embedded checksum
  47319. https://bugs.webkit.org/show_bug.cgi?id=57783
  47320. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  47321. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  47322. 2011-04-04 Kevin Ollivier <kevino@theolliviers.com>
  47323. [wx] Unreviewed build fix, run uninstall when cleaning to remove built files
  47324. from WebKitBuild.
  47325. * Scripts/webkitdirs.pm:
  47326. 2011-04-04 Martin Robinson <mrobinson@igalia.com>
  47327. Reviewed by Gustavo Noronha Silva.
  47328. [GTK] WebGL support
  47329. https://bugs.webkit.org/show_bug.cgi?id=31517
  47330. Add support to the DRT for turning on WebGL when a layout tests requests it.
  47331. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  47332. (LayoutTestController::overridePreference): Allow turning on WebGL from tests.
  47333. 2011-04-04 Chang Shu <cshu@webkit.org>
  47334. Reviewed by Darin Adler.
  47335. WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
  47336. https://bugs.webkit.org/show_bug.cgi?id=57572
  47337. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47338. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47339. (WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
  47340. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47341. 2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com>
  47342. Reviewed by Csaba Osztrogonác.
  47343. [Qt] DumpRenderTree breaks compilation in some uClibc environments
  47344. https://bugs.webkit.org/show_bug.cgi?id=57602
  47345. * DumpRenderTree/qt/main.cpp:
  47346. (get_backtrace):
  47347. 2011-04-04 Kevin Ollivier <kevino@theolliviers.com>
  47348. [wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
  47349. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  47350. (LayoutTestController::shadowRoot):
  47351. 2011-04-04 Pavel Podivilov <podivilov@chromium.org>
  47352. Unreviewed, fix exception in rebaseline tool.
  47353. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  47354. 2011-04-02 Beth Dakin <bdakin@apple.com>
  47355. Rubber-stamped by Geoff Garen.
  47356. For Dan!
  47357. * DumpRenderTree/mac/DumpRenderTree.mm:
  47358. (resetWebViewToConsistentStateBeforeTesting):
  47359. 2011-04-02 Beth Dakin <bdakin@apple.com>
  47360. Rubber-stamped by Geoff Garen.
  47361. Need to reset the scale, much like zoom.
  47362. * DumpRenderTree/mac/DumpRenderTree.mm:
  47363. (resetWebViewToConsistentStateBeforeTesting):
  47364. 2011-04-02 Sam Weinig <sam@webkit.org>
  47365. Reviewed by Beth Dakin.
  47366. https://bugs.webkit.org/show_bug.cgi?id=57605
  47367. Frame::pageScaleFactor() should not affect getBoundingClientRect() or
  47368. getClientRects()
  47369. -and corresponding-
  47370. <rdar://problem/9194541>
  47371. Add DRT support for the scaleWebView SPI.
  47372. * DumpRenderTree/mac/EventSendingController.mm:
  47373. (+[EventSendingController isSelectorExcludedFromWebScript:]):
  47374. (+[EventSendingController webScriptNameForSelector:]):
  47375. (-[EventSendingController scalePageBy:atX:andY:]):
  47376. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  47377. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  47378. (WTR::EventSendingController::scalePageBy):
  47379. * WebKitTestRunner/InjectedBundle/EventSendingController.h:
  47380. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  47381. (WTR::InjectedBundlePage::reset):
  47382. 2011-04-02 Dominic Cooney <dominicc@google.com>
  47383. Reviewed by Martin Robinson.
  47384. Add layoutTestController.shadowRoot to GTK DumpRenderTree.
  47385. https://bugs.webkit.org/show_bug.cgi?id=57551
  47386. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  47387. (LayoutTestController::shadowRoot):
  47388. 2011-04-02 Patrick Gansterer <paroga@webkit.org>
  47389. Reviewed by Eric Seidel.
  47390. Remove AbstractStep._run_script and move script names to ports.py
  47391. https://bugs.webkit.org/show_bug.cgi?id=57704
  47392. Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
  47393. * Scripts/webkitpy/common/config/ports.py:
  47394. * Scripts/webkitpy/tool/commands/download_unittest.py:
  47395. * Scripts/webkitpy/tool/commands/roll_unittest.py:
  47396. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  47397. * Scripts/webkitpy/tool/steps/abstractstep.py:
  47398. * Scripts/webkitpy/tool/steps/checkstyle.py:
  47399. * Scripts/webkitpy/tool/steps/preparechangelog.py:
  47400. * Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
  47401. * Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
  47402. 2011-04-02 Patrick Gansterer <paroga@webkit.org>
  47403. Reviewed by Eric Seidel.
  47404. Emulate shebang on Win32
  47405. https://bugs.webkit.org/show_bug.cgi?id=55927
  47406. Scripts on Windows work only if they are called with the explicit interpreter.
  47407. Read the first line of scripts to detect the correct executable.
  47408. * Scripts/webkitpy/common/config/ports.py:
  47409. * Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
  47410. * Scripts/webkitpy/common/system/executive_unittest.py:
  47411. 2011-04-01 Adam Barth <abarth@webkit.org>
  47412. Reviewed by Eric Seidel.
  47413. apos entities shouldn't show up in ChangeLogs when using webkit-patch
  47414. https://bugs.webkit.org/show_bug.cgi?id=57692
  47415. Previously, we were using BeautifulSoup to process XML from
  47416. bugs.webkit.org, but that's incorrect. We should be using
  47417. BeautifulStoneSoup to process the XML. We were getting the &apos;
  47418. entity wrong because &apos; is an XML entity but not an HTML entity.
  47419. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  47420. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  47421. 2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
  47422. Unreviewed, rolling out r82721.
  47423. http://trac.webkit.org/changeset/82721
  47424. https://bugs.webkit.org/show_bug.cgi?id=57687
  47425. This patch introduced assertion failures on the GTK+ bots.
  47426. (Requested by mrobinson on #webkit).
  47427. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  47428. (LayoutTestController::shadowRoot):
  47429. 2011-04-01 Csaba Osztrogonác <ossy@webkit.org>
  47430. Unreviewed buildfix.
  47431. [Qt][WK2] Build Webkit2 using "-2" option on Qt
  47432. https://bugs.webkit.org/show_bug.cgi?id=55074
  47433. * Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
  47434. (The isWK2() function removes it from @ARGV, but not from @options.)
  47435. 2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
  47436. Reviewed by Csaba Osztrogonác.
  47437. [Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
  47438. https://bugs.webkit.org/show_bug.cgi?id=57666
  47439. * MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
  47440. 2011-04-01 Dirk Pranke <dpranke@chromium.org>
  47441. Reviewed by Adam Barth.
  47442. new-run-webkit-tests: fix feature detection, skipped platform lists on mac
  47443. We apparently never implemented the code to skip tests based on
  47444. what was compiled into DRT. Also, change the logic used to skip
  47445. platform directories to match what old-run-webkit-tests does:
  47446. skip every test not in a directory in the baseline search path.
  47447. https://bugs.webkit.org/show_bug.cgi?id=57662
  47448. * Scripts/webkitpy/layout_tests/port/mac.py:
  47449. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  47450. * Scripts/webkitpy/layout_tests/port/webkit.py:
  47451. 2011-03-29 Mark Rowe <mrowe@apple.com>
  47452. Reviewed by Jon Honeycutt.
  47453. <http://webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
  47454. Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
  47455. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  47456. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  47457. * Scripts/webkitpy/layout_tests/port/mac.py:
  47458. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  47459. 2011-04-01 Chang Shu <cshu@webkit.org>
  47460. Reviewed by Csaba Osztrogonác.
  47461. [Qt][WK2] Build Webkit2 using "-2" option on Qt
  47462. https://bugs.webkit.org/show_bug.cgi?id=55074
  47463. * Scripts/build-webkit:
  47464. 2011-04-01 Dirk Pranke <dpranke@chromium.org>
  47465. Reviewed by Tony Chang.
  47466. new-run-webkit-tests: remove spurious port version override in webkit.py
  47467. base.py provides a default implementation so this is just
  47468. breaking things.
  47469. https://bugs.webkit.org/show_bug.cgi?id=57667
  47470. * Scripts/webkitpy/layout_tests/port/webkit.py:
  47471. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  47472. 2011-04-01 Csaba Osztrogonác <ossy@webkit.org>
  47473. Reviewed by Adam Roben.
  47474. Make view results on waterfall direct link to results.html
  47475. https://bugs.webkit.org/show_bug.cgi?id=57671
  47476. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Add "/results.html" to the URL.
  47477. * Scripts/old-run-webkit-tests: Add links to httpd access and error logs.
  47478. 2011-04-01 Sam Weinig <sam@webkit.org>
  47479. Fix windows build.
  47480. * TestWebKitAPI/Tests/WebKit2/win/HideFindIndicator.cpp:
  47481. (TestWebKitAPI::TEST):
  47482. * TestWebKitAPI/Tests/WebKit2/win/ResizeViewWhileHidden.cpp:
  47483. (TestWebKitAPI::flushMessages):
  47484. 2011-04-01 Sam Weinig <sam@webkit.org>
  47485. Reviewed by Adam Roben.
  47486. Add adoptWK to WKRetainPtr.h
  47487. https://bugs.webkit.org/show_bug.cgi?id=57670
  47488. * TestWebKitAPI/PlatformUtilities.h:
  47489. * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp:
  47490. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp:
  47491. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp:
  47492. * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp:
  47493. * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp:
  47494. * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  47495. * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp:
  47496. * TestWebKitAPI/Tests/WebKit2/RestoreSessionStateContainingFormData.cpp:
  47497. (TestWebKitAPI::createSessionStateContainingFormData):
  47498. * WebKitTestRunner/StringFunctions.h:
  47499. Replace custom versions of adoptWK with the API on in WebKit2/WKRetainPtr.h.
  47500. 2011-04-01 Sam Weinig <sam@webkit.org>
  47501. Reviewed by Adam Roben.
  47502. Fix leak noticed by Adam Roben in LayoutTestController::shadowRoot.
  47503. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47504. (WTR::LayoutTestController::shadowRoot):
  47505. Make judicious use of adoptWK().
  47506. 2011-04-01 Sam Weinig <sam@webkit.org>
  47507. Reviewed by Timothy Hatcher.
  47508. Fix extract-localizable-strings for macro change from UI_STRING -> WEB_UI_STRING.
  47509. * Scripts/extract-localizable-strings:
  47510. 2011-04-01 Anders Carlsson <andersca@apple.com>
  47511. Reviewed by Sam Weinig.
  47512. Shockwave plug-in doesn't accept mouse events
  47513. https://bugs.webkit.org/show_bug.cgi?id=57653
  47514. <rdar://problem/8483273>
  47515. Add a plug-in test.
  47516. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  47517. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  47518. (PluginTest::indicateTestFailure):
  47519. Move code from NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject here.
  47520. (PluginTest::NPN_ConvertPoint):
  47521. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  47522. * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
  47523. (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
  47524. Call indicateTestFailure.
  47525. * DumpRenderTree/TestNetscapePlugIn/Tests/mac: Added.
  47526. * DumpRenderTree/TestNetscapePlugIn/Tests/mac/ConvertPoint.cpp: Added.
  47527. (ConvertPoint::ConvertPoint):
  47528. (ConvertPoint::testConvert):
  47529. (ConvertPoint::NPP_New):
  47530. 2011-04-01 Dominic Cooney <dominicc@google.com>
  47531. Reviewed by Martin Robinson.
  47532. Add layoutTestController.shadowRoot to GTK DumpRenderTree.
  47533. https://bugs.webkit.org/show_bug.cgi?id=57551
  47534. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  47535. (LayoutTestController::shadowRoot):
  47536. 2011-04-01 Sam Weinig <sam@webkit.org>
  47537. Reviewed by Anders Carlsson.
  47538. WebKitTestRunner needs layoutTestController.shadowRoot
  47539. https://bugs.webkit.org/show_bug.cgi?id=57661
  47540. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47541. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47542. (WTR::LayoutTestController::shadowRoot):
  47543. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47544. Implement layoutTestController.shadowRoot for WebKit2.
  47545. 2011-04-01 Chang Shu <cshu@webkit.org>
  47546. Reviewed by Darin Adler.
  47547. WebKitTestRunner needs layoutTestController.setDatabaseQuota
  47548. https://bugs.webkit.org/show_bug.cgi?id=57568
  47549. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47550. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47551. (WTR::LayoutTestController::setDatabaseQuota):
  47552. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47553. 2011-04-01 Dirk Pranke <dpranke@chromium.org>
  47554. Reviewed by Tony Chang.
  47555. This patch completes the cleanup of
  47556. rebaseline-chromium-webkit-tests to work with all of the
  47557. variants of a platform (we can now rebaseline gpu- and non-gpu
  47558. files at the same time).
  47559. When the rebaselining is complete, any lines declared as
  47560. REBASELINE in the expectations file that matches a test that was
  47561. actually rebaselined will be deleted, even if only one of the
  47562. variants was actually rebaselined. This may cause odd problems,
  47563. but is better than where we're at today.
  47564. This change removes the -g flag and deprecates -w. The -g flag is gone
  47565. because GPU baselines are handled just like any other variant.
  47566. The -w flag is deprecated because this tool now only works
  47567. against the canaries, since that's the only place we have a full
  47568. set of bots. It will be trivial to change this to
  47569. build.webkit.org if we decide that's where we want them to be.
  47570. Also, this patch deletes a lot of cruft that is no longer needed
  47571. in the test_expectations code and the port-specific code.
  47572. https://bugs.webkit.org/show_bug.cgi?id=55191
  47573. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  47574. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  47575. * Scripts/webkitpy/layout_tests/port/base.py:
  47576. * Scripts/webkitpy/layout_tests/port/base_unittest.py:
  47577. * Scripts/webkitpy/layout_tests/port/chromium.py:
  47578. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  47579. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  47580. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  47581. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  47582. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  47583. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  47584. * Scripts/webkitpy/layout_tests/port/mac.py:
  47585. * Scripts/webkitpy/layout_tests/port/test.py:
  47586. * Scripts/webkitpy/layout_tests/port/webkit.py:
  47587. * Scripts/webkitpy/layout_tests/port/win.py:
  47588. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  47589. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  47590. 2011-04-01 Dirk Pranke <dpranke@chromium.org>
  47591. Reviewed by Adam Barth.
  47592. rebaseline-chromium-webkit-tests does not work correctly with
  47593. version-specific baselines. This patch updates the tool to use
  47594. all of the version-specific bots on the canaries, and will now
  47595. attempt to rebaseline all of the versions by default, although
  47596. it will not update both GPU and CPU versions.
  47597. Also, it will no longer modify the test_expectations.txt file
  47598. *at all*. You will have to manually delete the REBASELINE lines
  47599. after running the tool and determining that it did what you
  47600. wanted it to do. This should be fixed in a separate bug - see
  47601. webkit bug #55191.
  47602. https://bugs.webkit.org/show_bug.cgi?id=55608
  47603. * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
  47604. * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
  47605. * Scripts/webkitpy/layout_tests/port/chromium.py:
  47606. * Scripts/webkitpy/layout_tests/port/test.py:
  47607. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  47608. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  47609. 2011-03-31 Tony Chang <tony@chromium.org>
  47610. Reviewed by Ojan Vafai.
  47611. [chromium] update the rebaseline tool to know about pngs with checksums
  47612. https://bugs.webkit.org/show_bug.cgi?id=57481
  47613. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py: Skip over .checksum files if the checksum is already in the png
  47614. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:
  47615. 2011-04-01 Adam Roben <aroben@apple.com>
  47616. Retrieve revision numbers from the build's got_revision property in Leaks Viewer
  47617. Previously, we were getting the revision of the first revision that triggered a build.
  47618. Choosing the last revision would have been more accurate. But got_revision is what is used
  47619. everywhere else on build.webkit.org, and should work even when there were no changes that
  47620. triggered a build (e.g., if someone clicked the Force Build button).
  47621. Fixes <http://webkit.org/b/57630> Leaks viewer gets some revision numbers wrong in the
  47622. recent builds list
  47623. Reviewed by Anders Carlsson.
  47624. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  47625. (RecentBuildsLoader.prototype.start): Pull the revision number out of the got_revision
  47626. property, rather than out of the first (i.e., earliest) change in the sourceStamp object.
  47627. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
  47628. (Array.prototype.first): Added this helper function to return the first element in an array
  47629. that matches the given predicate, or null if no such element exists.
  47630. 2011-03-31 Adam Roben <aroben@apple.com>
  47631. Prefer (but don't require) bug URLs to be on their own line when parsing bug numbers from ChangeLogs
  47632. Fixes <http://webkit.org/b/57579> webkit-patch is too strict about bug URL formatting
  47633. Reviewed by Darin Adler.
  47634. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  47635. (parse_bug_id_from_changelog): Fall back to parse_bug_id if we weren't able to find a bug
  47636. URL on its own line.
  47637. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  47638. (BugzillaTest.test_parse_bug_id_from_changelog): Updated expected results for test
  47639. progression, and added a new test that uses a short bug URL while I was at it.
  47640. 2011-04-01 Adam Roben <aroben@apple.com>
  47641. Mark .vcproj/.vsprops/.sln files as being Windows-only
  47642. Fixes <http://webkit.org/b/57489> Mac builders built 82512, but shouldn't have
  47643. Reviewed by Anders Carlsson.
  47644. * Scripts/webkitpy/common/config/build.py:
  47645. (_should_file_trigger_build): Added patterns to mark .vcproj/.vsprops/.sln files and .vcproj
  47646. directories as Windows-only.
  47647. * Scripts/webkitpy/common/config/build_unittest.py:
  47648. (ShoulBuildTest): Added test cases for the above.
  47649. 2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
  47650. Reviewed by Laszlo Gombos.
  47651. [Qt] Build MiniBrowser for Symbian
  47652. https://bugs.webkit.org/show_bug.cgi?id=56319
  47653. Have MiniBrowser reference it's own copy of useragentlist.txt instead
  47654. of copying QtTestBrowser's.
  47655. Remove Tools/MiniBrowser/DerivedSources.pro
  47656. This reduces complexity in the Tools scripts due to Symbian limitations.
  47657. * DerivedSources.pro:
  47658. * MiniBrowser/DerivedSources.pro: Removed.
  47659. * MiniBrowser/MiniBrowser.qrc:
  47660. * MiniBrowser/qt/MiniBrowser.pro:
  47661. * Scripts/webkitdirs.pm:
  47662. 2011-03-31 Chang Shu <cshu@webkit.org>
  47663. Reviewed by Darin Adler.
  47664. WebKitTestRunner needs layoutTestController.clearAllDatabases
  47665. https://bugs.webkit.org/show_bug.cgi?id=42540
  47666. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47667. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  47668. (WTR::InjectedBundle::beginTesting):
  47669. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47670. (WTR::LayoutTestController::clearAllDatabases):
  47671. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47672. 2011-03-31 Chang Shu <cshu@webkit.org>
  47673. Reviewed by Darin Adler.
  47674. WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
  47675. https://bugs.webkit.org/show_bug.cgi?id=42692
  47676. * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
  47677. 2011-03-31 Darin Adler <darin@apple.com>
  47678. Reviewed by Sam Weinig.
  47679. Implement mouseDown, mouseUp, and mouseMoveTo in WebKitTestRunner
  47680. https://bugs.webkit.org/show_bug.cgi?id=57573
  47681. * WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
  47682. Added real definitions for mouseDown, mouseUp, mouseMoveTo and leapForward.
  47683. Removed fake definitions of keyDown and contextClick.
  47684. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  47685. (WTR::operator==): Added. So we can compare two WKPoint structs.
  47686. (WTR::parseModifier): Added.
  47687. (WTR::parseModifierArray): Added.
  47688. (WTR::EventSendingController::EventSendingController): Initialize the
  47689. new data members.
  47690. (WTR::EventSendingController::mouseDown): Added. Calls
  47691. WKBundlePageSimulateMouseDown.
  47692. (WTR::EventSendingController::mouseUp): Added. Calls
  47693. WKBundlePageSimulateMouseUp.
  47694. (WTR::EventSendingController::mouseMoveTo): Added. Calls
  47695. WKBundlePageSimulateMouseMotion.
  47696. (WTR::EventSendingController::leapForward): Added.
  47697. (WTR::EventSendingController::updateClickCount): Added. Used by the
  47698. mouseDown/Up functions to create a click count.
  47699. * WebKitTestRunner/InjectedBundle/EventSendingController.h: Updated
  47700. for the changes above.
  47701. 2011-03-31 Sergio Villar Senin <svillar@igalia.com>
  47702. Reviewed by Martin Robinson.
  47703. [GTK] implement LayoutTestController::setWillSendRequestReturnsNull
  47704. https://bugs.webkit.org/show_bug.cgi?id=57362
  47705. Do not generate DRT output if willSendRequestReturnsNull is set.
  47706. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  47707. (willSendRequestCallback):
  47708. 2011-03-31 Vamshikrishna.Yellenki <vamshi@motorola.com> and Alejandro G. Castro <alex@igalia.com>
  47709. Reviewed by Martin Robinson.
  47710. Implement MiniBrowser for Gtk port.
  47711. https://bugs.webkit.org/show_bug.cgi?id=48512
  47712. Initial implementation of the Gtk MiniBrowser.
  47713. * MiniBrowser/gtk/GNUmakefile.am: Added.
  47714. * MiniBrowser/gtk/main.c: Added.
  47715. (activateUriEntryCallback):
  47716. (destroyCallback):
  47717. (goBackCallback):
  47718. (goForwardCallback):
  47719. (createToolbar):
  47720. (createWebView):
  47721. (createWindow):
  47722. (argumentToURL):
  47723. (main):
  47724. 2011-03-30 Dominic Cooney <dominicc@google.com>
  47725. Reviewed by Dimitri Glazkov.
  47726. Adds layoutTestController.shadowRoot accessor to Mac DRT.
  47727. https://bugs.webkit.org/show_bug.cgi?id=57415
  47728. * DumpRenderTree/LayoutTestController.cpp:
  47729. (shadowRootCallback):
  47730. (LayoutTestController::staticFunctions):
  47731. * DumpRenderTree/LayoutTestController.h:
  47732. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  47733. (LayoutTestController::shadowRoot):
  47734. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  47735. (LayoutTestController::shadowRoot):
  47736. 2011-03-30 Matthew Delaney <mdelaney@apple.com>
  47737. Reviewed by Chris Marrin.
  47738. Update fast/canvas tests to avoid dumping the render tree when possible
  47739. https://bugs.webkit.org/show_bug.cgi?id=57493
  47740. * DumpRenderTree/mac/DumpRenderTree.mm: Make DRT aware of new default values for
  47741. accelerated drawing and accelerated drawing for canvas
  47742. 2011-03-30 Adam Roben <aroben@apple.com>
  47743. Stop ignoring leaks in CGGradientCreateWithColorStops
  47744. Fixes <rdar://problem/7888547>.
  47745. Rubber-stamped by John Sullivan.
  47746. * Scripts/old-run-webkit-tests:
  47747. (countAndPrintLeaks): Removed some code to ignore those leaks.
  47748. 2011-03-30 Timur Iskhodzhanov <timurrrr@google.com>
  47749. Reviewed by Alexey Proskuryakov.
  47750. Add some dynamic annotations to JavaScriptCore/wtf
  47751. https://bugs.webkit.org/show_bug.cgi?id=53747
  47752. By using these annotations we can improve the precision of finding
  47753. WebKit errors using dynamic analysis tools like ThreadSanitizer and Valgrind.
  47754. These annotations don't affect the compiled binaries unless USE(DYNAMIC_ANNOTATIONS) is "1".
  47755. These files don't add new functionality, so don't need extra tests.
  47756. * DumpRenderTree/ForwardingHeaders/wtf/DynamicAnnotations.h: Added.
  47757. 2011-03-30 Steve Falkenburg <sfalken@apple.com>
  47758. Reviewed by Adam Roben.
  47759. Share most vsprops between Release and Production builds in releaseproduction.vsprops
  47760. https://bugs.webkit.org/show_bug.cgi?id=57508
  47761. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
  47762. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops:
  47763. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops:
  47764. * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
  47765. * DumpRenderTree/win/DumpRenderTreeRelease.vsprops:
  47766. * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops:
  47767. * DumpRenderTree/win/ImageDiffProduction.vsprops:
  47768. * DumpRenderTree/win/ImageDiffRelease.vsprops:
  47769. * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops:
  47770. * FindSafari/FindSafariProduction.vsprops:
  47771. * FindSafari/FindSafariRelease.vsprops:
  47772. * FindSafari/FindSafariReleaseCairoCFLite.vsprops:
  47773. * FindSafari/FindSafariReleasePGO.vsprops:
  47774. * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
  47775. * MiniBrowser/Configurations/MiniBrowserRelease.vsprops:
  47776. * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops:
  47777. * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops:
  47778. * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops:
  47779. * WebKitAPITest/WebKitAPITestProduction.vsprops:
  47780. * WebKitAPITest/WebKitAPITestRelease.vsprops:
  47781. * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops:
  47782. * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
  47783. * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops:
  47784. * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops:
  47785. * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
  47786. * WebKitTestRunner/win/InjectedBundleRelease.vsprops:
  47787. * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops:
  47788. * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
  47789. * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops:
  47790. * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops:
  47791. * WinLauncher/WinLauncherProduction.vsprops:
  47792. * WinLauncher/WinLauncherRelease.vsprops:
  47793. * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops:
  47794. * record-memory-win/record-memory-winProduction.vsprops:
  47795. * record-memory-win/record-memory-winRelease.vsprops:
  47796. * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops:
  47797. 2011-03-30 Steve Falkenburg <sfalken@apple.com>
  47798. Reviewed by Adam Roben.
  47799. Update Windows production build logic for new production configurations
  47800. https://bugs.webkit.org/show_bug.cgi?id=57494
  47801. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops:
  47802. * DumpRenderTree/win/DumpRenderTreeProduction.vsprops:
  47803. * DumpRenderTree/win/ImageDiffProduction.vsprops:
  47804. * FindSafari/FindSafariProduction.vsprops:
  47805. * FindSafari/FindSafariReleasePGO.vsprops:
  47806. * MiniBrowser/Configurations/MiniBrowserProduction.vsprops:
  47807. * WebKitAPITest/WebKitAPITestProduction.vsprops:
  47808. * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops:
  47809. * WebKitTestRunner/win/InjectedBundleProduction.vsprops:
  47810. * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops:
  47811. * WinLauncher/WinLauncherProduction.vsprops:
  47812. * record-memory-win/record-memory-winProduction.vsprops:
  47813. 2011-03-30 Robert Hogan <robert@webkit.org>
  47814. Reviewed by Antonio Gomes.
  47815. [Qt] Fix LoadHTMLStringItem::invoke() after r75966
  47816. Unskip http/tests/navigation/go-back-to-error-page.html
  47817. Also add the location of DumpRenderTreeSupportQt.h
  47818. to DRT's include paths.
  47819. https://bugs.webkit.org/show_bug.cgi?id=52614
  47820. * DumpRenderTree/qt/DumpRenderTree.pro:
  47821. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  47822. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  47823. * DumpRenderTree/qt/GCControllerQt.cpp:
  47824. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  47825. (LayoutTestController::queueLoadHTMLString):
  47826. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  47827. * DumpRenderTree/qt/PlainTextControllerQt.cpp:
  47828. * DumpRenderTree/qt/TextInputControllerQt.cpp:
  47829. * DumpRenderTree/qt/WorkQueueItemQt.cpp:
  47830. (LoadAlternateHTMLStringItem::invoke):
  47831. * DumpRenderTree/qt/WorkQueueItemQt.h:
  47832. (LoadAlternateHTMLStringItem::LoadAlternateHTMLStringItem):
  47833. * QtTestBrowser/QtTestBrowser.pro:
  47834. * QtTestBrowser/launcherwindow.h:
  47835. 2011-03-30 Adam Barth <abarth@webkit.org>
  47836. Reviewed by Adam Roben.
  47837. SheriffBot rollouts take too long
  47838. https://bugs.webkit.org/show_bug.cgi?id=57498
  47839. We used to build before landing rollouts via the commit-queue to
  47840. prevent further breakage, but now that our individual commit-queue
  47841. machines are slower, building takes too long. I can't remember the
  47842. last time a rollout broke compile. It seems like just landing the
  47843. patch is the better trade-off.
  47844. * Scripts/webkitpy/tool/bot/commitqueuetask.py:
  47845. * Scripts/webkitpy/tool/commands/queues_unittest.py:
  47846. 2011-03-30 Adam Barth <abarth@webkit.org>
  47847. Remove platform/chromium-mac-snowleopard
  47848. https://bugs.webkit.org/show_bug.cgi?id=57486
  47849. This directory no longer exists, so we can remove it from the fallback
  47850. chain.
  47851. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  47852. 2011-03-30 Steve Falkenburg <sfalken@apple.com>
  47853. Reviewed by Adam Roben.
  47854. Rename Windows configuration Release_LTCG to Production for clarity
  47855. https://bugs.webkit.org/show_bug.cgi?id=57465
  47856. * DumpRenderTree/DumpRenderTree.sln:
  47857. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  47858. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginProduction.vsprops: Copied from Tools/DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops.
  47859. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Removed.
  47860. * DumpRenderTree/win/DumpRenderTree.vcproj:
  47861. * DumpRenderTree/win/DumpRenderTreeProduction.vsprops: Copied from Tools/DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops.
  47862. * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Removed.
  47863. * DumpRenderTree/win/ImageDiff.vcproj:
  47864. * DumpRenderTree/win/ImageDiffProduction.vsprops: Copied from Tools/DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops.
  47865. * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Removed.
  47866. * FindSafari/FindSafari.vcproj:
  47867. * FindSafari/FindSafariProduction.vsprops: Copied from Tools/FindSafari/FindSafariReleaseLTCG.vsprops.
  47868. * FindSafari/FindSafariReleaseLTCG.vsprops: Removed.
  47869. * MiniBrowser/Configurations/MiniBrowserProduction.vsprops: Copied from Tools/MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops.
  47870. * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Removed.
  47871. * MiniBrowser/MiniBrowser.vcproj:
  47872. * Scripts/webkitdirs.pm:
  47873. * TestWebKitAPI/win/TestWebKitAPI.sln:
  47874. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  47875. * TestWebKitAPI/win/TestWebKitAPIGenerated.vcproj:
  47876. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  47877. * WebKitAPITest/WebKitAPITest.vcproj:
  47878. * WebKitAPITest/WebKitAPITestProduction.vsprops: Copied from Tools/WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops.
  47879. * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Removed.
  47880. * WebKitLauncherWin/WebKitLauncherWin.vcproj:
  47881. * WebKitLauncherWin/WebKitLauncherWinProduction.vsprops: Copied from Tools/WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops.
  47882. * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Removed.
  47883. * WebKitTestRunner/WebKitTestRunner.sln:
  47884. * WebKitTestRunner/win/InjectedBundle.vcproj:
  47885. * WebKitTestRunner/win/InjectedBundleGenerated.vcproj:
  47886. * WebKitTestRunner/win/InjectedBundleProduction.vsprops: Copied from Tools/WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops.
  47887. * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Removed.
  47888. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  47889. * WebKitTestRunner/win/WebKitTestRunnerProduction.vsprops: Copied from Tools/WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops.
  47890. * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Removed.
  47891. * WinLauncher/WinLauncher.vcproj:
  47892. * WinLauncher/WinLauncherProduction.vsprops: Copied from Tools/WinLauncher/WinLauncherReleaseLTCG.vsprops.
  47893. * WinLauncher/WinLauncherReleaseLTCG.vsprops: Removed.
  47894. * record-memory-win/record-memory-win.vcproj:
  47895. * record-memory-win/record-memory-winProduction.vsprops: Copied from Tools/record-memory-win/record-memory-winReleaseLTCG.vsprops.
  47896. * record-memory-win/record-memory-winReleaseLTCG.vsprops: Removed.
  47897. 2011-03-30 MORITA Hajime <morrita@google.com>
  47898. Reviewed by Dimitri Glazkov.
  47899. [Chromium] Expose the shadow DOM to DumpRenderTree JS tests.
  47900. https://bugs.webkit.org/show_bug.cgi?id=56573
  47901. Added LayoutTestController.shadowRoot() to Chromium DRT.
  47902. * DumpRenderTree/chromium/LayoutTestController.cpp:
  47903. (LayoutTestController::LayoutTestController):
  47904. (LayoutTestController::shadowRoot):
  47905. * DumpRenderTree/chromium/LayoutTestController.h:
  47906. 2011-03-30 Yuta Kitamura <yutak@chromium.org>
  47907. Reviewed by Kent Tamura.
  47908. [Chromium] DumpRenderTree: Implement LayoutTestController::setPluginsEnabled
  47909. https://bugs.webkit.org/show_bug.cgi?id=57430
  47910. * DumpRenderTree/chromium/LayoutTestController.cpp:
  47911. (LayoutTestController::LayoutTestController):
  47912. (LayoutTestController::setPluginsEnabled):
  47913. * DumpRenderTree/chromium/LayoutTestController.h:
  47914. 2011-03-30 Maciej Stachowiak <mjs@apple.com>
  47915. Reviewed by Adam Barth.
  47916. make webkit-patch upload respect -d
  47917. https://bugs.webkit.org/show_bug.cgi?id=57425
  47918. * Scripts/webkitpy/common/checkout/scm.py:
  47919. * Scripts/webkitpy/tool/steps/commit.py:
  47920. 2011-03-30 Maciej Stachowiak <mjs@apple.com>
  47921. Reviewed by Adam Barth.
  47922. Make "webkit-patch --dry-run --verbose land" log the SVN command it's going to use
  47923. https://bugs.webkit.org/show_bug.cgi?id=57429
  47924. * Scripts/webkitpy/common/checkout/scm.py:
  47925. 2011-03-29 Sheriff Bot <webkit.review.bot@gmail.com>
  47926. Unreviewed, rolling out r82383.
  47927. http://trac.webkit.org/changeset/82383
  47928. https://bugs.webkit.org/show_bug.cgi?id=57417
  47929. "nrwt isn't shutting down cleanly" (Requested by dpranke on
  47930. #webkit).
  47931. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  47932. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  47933. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  47934. 2011-03-29 Kent Tamura <tkent@chromium.org>
  47935. Reviewed by Dimitri Glazkov.
  47936. Make validation message bubble testable
  47937. https://bugs.webkit.org/show_bug.cgi?id=57290
  47938. * DumpRenderTree/mac/DumpRenderTree.mm:
  47939. (createWebViewAndOffscreenWindow): Change a setting so that validation
  47940. bubbles isn't hidden automatically.
  47941. 2011-03-29 Dirk Pranke <dpranke@chromium.org>
  47942. Reviewed by Ojan Vafai.
  47943. new-run-webkit-tests: use 'threads' on win instead of 'old-threads'
  47944. It's a bit unclear whether multiple threads or multiple
  47945. processes will be a better model on windows. This change will
  47946. test threads for now while we're still working out the bugs in
  47947. multiple-processes.
  47948. https://bugs.webkit.org/show_bug.cgi?id=57410
  47949. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  47950. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  47951. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  47952. 2011-03-29 David Levin <levin@chromium.org>
  47953. Reviewed by Shinichiro Hamaji.
  47954. check-webkit-style confused by two ChangeLog entries in a row from same user
  47955. https://bugs.webkit.org/show_bug.cgi?id=57250
  47956. * Scripts/webkitpy/style/checker.py: Add the line should be checked function to ChangeLogChecker.
  47957. * Scripts/webkitpy/style/checker_unittest.py: Fix test due to that new function.
  47958. * Scripts/webkitpy/style/checkers/changelog.py: Made this code aware of what lines were being checked.
  47959. It basically assumes only one ChangeLog entry is being processed because that is the standard case and
  47960. checking more than that would be very messey.
  47961. * Scripts/webkitpy/style/checkers/changelog_unittest.py: Add testing to catch the broken case.
  47962. * Scripts/webkitpy/style/error_handlers.py: Added should_line_be_checked.
  47963. 2011-03-29 Kent Tamura <tkent@chromium.org>
  47964. Reviewed by Dimitri Glazkov.
  47965. [Mac] Enable interactive-validation tests on Mac DRT
  47966. https://bugs.webkit.org/show_bug.cgi?id=57308
  47967. * DumpRenderTree/mac/DumpRenderTree.mm:
  47968. (createWebViewAndOffscreenWindow): Enable the form interactive validation feature.
  47969. 2011-03-29 Chang Shu <cshu@webkit.org>
  47970. Reviewed by Kenneth Rohde Christiansen.
  47971. WebKitTestRunner needs layoutTestController.setAllowUniversalAccessFromFileURLs
  47972. https://bugs.webkit.org/show_bug.cgi?id=42692
  47973. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  47974. (WTR::InjectedBundle::beginTesting):
  47975. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  47976. (WTR::LayoutTestController::setAllowUniversalAccessFromFileURLs):
  47977. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  47978. 2011-03-24 Martin Robinson <mrobinson@igalia.com>
  47979. Reviewed by Xan Lopez.
  47980. [GTK] [DRT] GtkScrolledWindow adds three pixels of padding between the WebView and the scrollbar
  47981. https://bugs.webkit.org/show_bug.cgi?id=57067
  47982. Eliminate extra spacing between the DRT GtkScrolledWindow and the DRT WebView. This
  47983. will allow WebKit1GTK+ and WebKit2GTK+ to share test results. Followup commits will
  47984. update DRT and pixel results as hundreds of results will need to be updated.
  47985. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  47986. (setDefaultsToConsistentStateValuesForTesting): Eliminate spacing on the GtkScrolledWindow
  47987. by overriding the theme RC/CSS files.
  47988. 2011-03-29 Steve Falkenburg <sfalken@apple.com>
  47989. Reviewed by Adam Roben.
  47990. Use per-configuration vsprops in tools projects to avoid WebKitVSPropsRedirectionDir removal by MSVC IDE
  47991. https://bugs.webkit.org/show_bug.cgi?id=57394
  47992. Visual Studio's IDE was removing instances of $(WebKitVSPropsRedirectionDir) from
  47993. InheritedPropertySheet rules in our vcproj files when the vcproj was edited from within
  47994. the IDE. To avoid this, add a separate vsprops file for each project configuration that
  47995. contains the required inherited property sheets.
  47996. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  47997. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebug.vsprops: Added.
  47998. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugAll.vsprops: Added.
  47999. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginDebugCairoCFLite.vsprops: Added.
  48000. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginRelease.vsprops: Added.
  48001. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseCairoCFLite.vsprops: Added.
  48002. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginReleaseLTCG.vsprops: Added.
  48003. * DumpRenderTree/win/DumpRenderTree.vcproj:
  48004. * DumpRenderTree/win/DumpRenderTreeDebug.vsprops: Added.
  48005. * DumpRenderTree/win/DumpRenderTreeDebugAll.vsprops: Added.
  48006. * DumpRenderTree/win/DumpRenderTreeDebugCairoCFLite.vsprops: Added.
  48007. * DumpRenderTree/win/DumpRenderTreeRelease.vsprops: Added.
  48008. * DumpRenderTree/win/DumpRenderTreeReleaseCairoCFLite.vsprops: Added.
  48009. * DumpRenderTree/win/DumpRenderTreeReleaseLTCG.vsprops: Added.
  48010. * DumpRenderTree/win/ImageDiff.vcproj:
  48011. * DumpRenderTree/win/ImageDiffDebug.vsprops: Added.
  48012. * DumpRenderTree/win/ImageDiffDebugAll.vsprops: Added.
  48013. * DumpRenderTree/win/ImageDiffDebugCairoCFLite.vsprops: Added.
  48014. * DumpRenderTree/win/ImageDiffRelease.vsprops: Added.
  48015. * DumpRenderTree/win/ImageDiffReleaseCairoCFLite.vsprops: Added.
  48016. * DumpRenderTree/win/ImageDiffReleaseLTCG.vsprops: Added.
  48017. * FindSafari/FindSafari.vcproj:
  48018. * FindSafari/FindSafariDebug.vsprops: Added.
  48019. * FindSafari/FindSafariDebugAll.vsprops: Added.
  48020. * FindSafari/FindSafariDebugCairoCFLite.vsprops: Added.
  48021. * FindSafari/FindSafariRelease.vsprops: Added.
  48022. * FindSafari/FindSafariReleaseCairoCFLite.vsprops: Added.
  48023. * FindSafari/FindSafariReleaseLTCG.vsprops: Added.
  48024. * FindSafari/FindSafariReleasePGO.vsprops: Added.
  48025. * MiniBrowser/Configurations/MiniBrowserDebug.vsprops: Added.
  48026. * MiniBrowser/Configurations/MiniBrowserDebugAll.vsprops: Added.
  48027. * MiniBrowser/Configurations/MiniBrowserDebugCairoCFLite.vsprops: Added.
  48028. * MiniBrowser/Configurations/MiniBrowserRelease.vsprops: Added.
  48029. * MiniBrowser/Configurations/MiniBrowserReleaseCairoCFLite.vsprops: Added.
  48030. * MiniBrowser/Configurations/MiniBrowserReleaseLTCG.vsprops: Added.
  48031. * MiniBrowser/MiniBrowser.vcproj:
  48032. * WebKitAPITest/WebKitAPITest.vcproj:
  48033. * WebKitAPITest/WebKitAPITestDebug.vsprops: Added.
  48034. * WebKitAPITest/WebKitAPITestDebugAll.vsprops: Added.
  48035. * WebKitAPITest/WebKitAPITestDebugCairoCFLite.vsprops: Added.
  48036. * WebKitAPITest/WebKitAPITestRelease.vsprops: Added.
  48037. * WebKitAPITest/WebKitAPITestReleaseCairoCFLite.vsprops: Added.
  48038. * WebKitAPITest/WebKitAPITestReleaseLTCG.vsprops: Added.
  48039. * WebKitLauncherWin/WebKitLauncherWin.vcproj:
  48040. * WebKitLauncherWin/WebKitLauncherWinDebug.vsprops: Added.
  48041. * WebKitLauncherWin/WebKitLauncherWinDebugAll.vsprops: Added.
  48042. * WebKitLauncherWin/WebKitLauncherWinDebugCairoCFLite.vsprops: Added.
  48043. * WebKitLauncherWin/WebKitLauncherWinRelease.vsprops: Added.
  48044. * WebKitLauncherWin/WebKitLauncherWinReleaseCairoCFLite.vsprops: Added.
  48045. * WebKitLauncherWin/WebKitLauncherWinReleaseLTCG.vsprops: Added.
  48046. * WebKitTestRunner/win/InjectedBundle.vcproj:
  48047. * WebKitTestRunner/win/InjectedBundleDebug.vsprops: Added.
  48048. * WebKitTestRunner/win/InjectedBundleDebugAll.vsprops: Added.
  48049. * WebKitTestRunner/win/InjectedBundleDebugCairoCFLite.vsprops: Added.
  48050. * WebKitTestRunner/win/InjectedBundleRelease.vsprops: Added.
  48051. * WebKitTestRunner/win/InjectedBundleReleaseCairoCFLite.vsprops: Added.
  48052. * WebKitTestRunner/win/InjectedBundleReleaseLTCG.vsprops: Added.
  48053. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  48054. * WebKitTestRunner/win/WebKitTestRunnerDebug.vsprops: Added.
  48055. * WebKitTestRunner/win/WebKitTestRunnerDebugAll.vsprops: Added.
  48056. * WebKitTestRunner/win/WebKitTestRunnerDebugCairoCFLite.vsprops: Added.
  48057. * WebKitTestRunner/win/WebKitTestRunnerRelease.vsprops: Added.
  48058. * WebKitTestRunner/win/WebKitTestRunnerReleaseCairoCFLite.vsprops: Added.
  48059. * WebKitTestRunner/win/WebKitTestRunnerReleaseLTCG.vsprops: Added.
  48060. * WinLauncher/WinLauncher.vcproj:
  48061. * WinLauncher/WinLauncherDebug.vsprops: Added.
  48062. * WinLauncher/WinLauncherDebugAll.vsprops: Added.
  48063. * WinLauncher/WinLauncherDebugCairoCFLite.vsprops: Added.
  48064. * WinLauncher/WinLauncherRelease.vsprops: Added.
  48065. * WinLauncher/WinLauncherReleaseCairoCFLite.vsprops: Added.
  48066. * WinLauncher/WinLauncherReleaseLTCG.vsprops: Added.
  48067. * record-memory-win/record-memory-win.vcproj:
  48068. * record-memory-win/record-memory-winDebug.vsprops: Added.
  48069. * record-memory-win/record-memory-winDebugAll.vsprops: Added.
  48070. * record-memory-win/record-memory-winDebugCairoCFLite.vsprops: Added.
  48071. * record-memory-win/record-memory-winRelease.vsprops: Added.
  48072. * record-memory-win/record-memory-winReleaseCairoCFLite.vsprops: Added.
  48073. * record-memory-win/record-memory-winReleaseLTCG.vsprops: Added.
  48074. 2011-03-29 Adam Barth <abarth@webkit.org>
  48075. Reviewed by Darin Adler.
  48076. test_runner2.py can crash due to undefined variable
  48077. https://bugs.webkit.org/show_bug.cgi?id=57356
  48078. Replace reference to undefined variable with a variable that's actually
  48079. defined. AFAICT, there's no way to test this code.
  48080. * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  48081. 2011-03-29 Tony Chang <tony@chromium.org>
  48082. Reviewed by Eric Seidel.
  48083. cleanup rebaseline-chromium-webkit-tests
  48084. https://bugs.webkit.org/show_bug.cgi?id=57375
  48085. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  48086. - Split _extract_and_add_new_baselines into 3 functions
  48087. - Reduce the amount of line wrapping (the file already has lines
  48088. over 80 col, so may as well try to make the file consistent)
  48089. - Remove unnecessary ()s
  48090. 2011-03-29 Brent Fulgham <bfulgham@webkit.org>
  48091. Reviewed by Adam Roben.
  48092. Make WinCairo a core builder.
  48093. https://bugs.webkit.org/show_bug.cgi?id=57373
  48094. * Scripts/webkitpy/common/net/buildbot/buildbot.py: Add WinCairo.
  48095. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py: Add WinCairo.
  48096. 2011-03-29 Timothy Hatcher <timothy@apple.com>
  48097. Update update-webkit-localizable-strings to understand that WebKit and
  48098. WebKit2 strings go in WebCore.
  48099. Also make extract-localizable-strings optionally use an exclude file. No individual
  48100. warnings are produced about unlocalized strings when there is no exclude file. This
  48101. is needed for WebCore, since there are too many bare strings.
  48102. https://webkit.org/b/57354
  48103. Reviewed by Sam Weinig.
  48104. * Scripts/extract-localizable-strings: Support "-" to mean no exclude file.
  48105. * Scripts/update-webkit-localizable-strings: Update paths to scan WebCore and WebKit2.
  48106. 2011-03-29 Darin Adler <darin@apple.com>
  48107. Reviewed by Adam Roben.
  48108. WebKit2 bundle page needs to offer generated file hooks
  48109. https://bugs.webkit.org/show_bug.cgi?id=57279
  48110. (Land missing part of the original patch after r82289.)
  48111. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  48112. (WTR::InjectedBundlePage::InjectedBundlePage): Added new callbacks.
  48113. 2011-03-29 Tony Chang <tony@chromium.org>
  48114. Reviewed by Ojan Vafai.
  48115. [chromium] NRWT should be able to read checksums from png comments
  48116. https://bugs.webkit.org/show_bug.cgi?id=57280
  48117. * Scripts/read-checksum-from-png: Added. Utility script to read the checksum
  48118. from a file.
  48119. * Scripts/webkitpy/common/system/filesystem.py: Add open_binary_file_for_reading
  48120. * Scripts/webkitpy/common/system/filesystem_mock.py:
  48121. * Scripts/webkitpy/layout_tests/port/base.py: When loading a checksum,
  48122. if the -checksum.txt file doesn't exist, try looking in the png.
  48123. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  48124. * Scripts/webkitpy/layout_tests/port/test.py:
  48125. * Scripts/webkitpy/layout_tests/read_checksum_from_png.py: Added. Scan the first
  48126. 2k for a png comment with the checksum
  48127. * Scripts/webkitpy/layout_tests/read_checksum_from_png_unittest.py: Added.
  48128. 2011-03-29 Philippe Normand <pnormand@igalia.com>
  48129. Rubber-stamped by Gustavo Noronha Silva.
  48130. [GTK] http/tests/uri/username-with-no-hostname.html fails
  48131. https://bugs.webkit.org/show_bug.cgi?id=57325
  48132. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  48133. (willSendRequestCallback): URI host value check done case-insensitively.
  48134. 2011-03-29 Philippe Normand <pnormand@igalia.com>
  48135. Reviewed by Martin Robinson.
  48136. [GTK] http/tests/uri/username-with-no-hostname.html fails
  48137. https://bugs.webkit.org/show_bug.cgi?id=57325
  48138. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  48139. (willSendRequestCallback): Check URI before submitting the request
  48140. to WebCore.
  48141. 2011-03-29 Noel Gordon <noel.gordon@gmail.com>
  48142. Reviewed by Ojan Vafai.
  48143. [chromium] DRT EventSender: remove identity from dragTargetDragEnter() calls
  48144. https://bugs.webkit.org/show_bug.cgi?id=57303
  48145. * DumpRenderTree/chromium/EventSender.cpp:
  48146. (EventSender::doDragDrop):
  48147. (EventSender::beginDragWithFiles):
  48148. 2011-03-29 Zoltan Horvath <zoltan@webkit.org>
  48149. Reviewed by Andreas Kling.
  48150. [Qt] Add -print-loaded-urls option to Qt's MiniBrowser and to QtTestBrowser
  48151. https://bugs.webkit.org/show_bug.cgi?id=57314
  48152. Provide possibility to print loaded urls to the standard output.
  48153. * MiniBrowser/qt/BrowserWindow.cpp:
  48154. (BrowserWindow::BrowserWindow):
  48155. (BrowserWindow::printURL):
  48156. * MiniBrowser/qt/BrowserWindow.h:
  48157. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  48158. (MiniBrowserApplication::handleUserOptions):
  48159. * MiniBrowser/qt/MiniBrowserApplication.h:
  48160. (WindowOptions::WindowOptions):
  48161. * QtTestBrowser/launcherwindow.cpp:
  48162. (LauncherWindow::initializeView):
  48163. (LauncherWindow::printURL):
  48164. (LauncherWindow::cloneWindow):
  48165. * QtTestBrowser/launcherwindow.h:
  48166. (WindowOptions::WindowOptions):
  48167. * QtTestBrowser/main.cpp:
  48168. (LauncherApplication::handleUserOptions):
  48169. 2011-03-29 Gabor Loki <loki@webkit.org>
  48170. Rubber-stamped by Csaba Osztrogonác.
  48171. [Qt] Teach build-jsc how to build JavaScriptCore on Qt
  48172. https://bugs.webkit.org/show_bug.cgi?id=56918
  48173. * Scripts/build-jsc: Remove duplicated --qt options to avoid passing them to qmake.
  48174. 2011-03-28 Gabor Loki <loki@webkit.org>
  48175. Reviewed by Csaba Osztrogonác.
  48176. [Qt] Teach build-jsc how to build JavaScriptCore on Qt
  48177. https://bugs.webkit.org/show_bug.cgi?id=56918
  48178. * Scripts/build-jsc:
  48179. * Scripts/webkitdirs.pm:
  48180. 2011-03-28 Andrew Foster <andrewf@chromium.org>
  48181. Reviewed by Ojan Vafai.
  48182. webkit-patch should be more intelligent about whether a bug applies to a patch
  48183. Create a new function, parse_bug_id_from_changelog() which determines
  48184. that a bug is related to a patch by parsing the output generated from
  48185. prepare-ChangeLog, rather than arbitrarily matching a URL to a bug in
  48186. the description of a patch.
  48187. https://bugs.webkit.org/show_bug.cgi?id=56989
  48188. * Scripts/webkitpy/common/checkout/api.py:
  48189. * Scripts/webkitpy/common/checkout/changelog.py:
  48190. * Scripts/webkitpy/common/net/bugzilla/__init__.py:
  48191. * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
  48192. * Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
  48193. * Scripts/webkitpy/style/checkers/changelog.py:
  48194. * Scripts/webkitpy/tool/commands/upload.py:
  48195. 2011-03-28 Maciej Stachowiak <mjs@apple.com>
  48196. Revert accidentally commited change.
  48197. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  48198. (-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]):
  48199. 2011-03-28 Tony Chang <tony@chromium.org>
  48200. Reviewed by Adam Barth.
  48201. [chromium] have DRT write the png checksum into a png comment
  48202. https://bugs.webkit.org/show_bug.cgi?id=57255
  48203. * DumpRenderTree/chromium/TestShell.cpp:
  48204. (TestShell::dumpImage):
  48205. 2011-03-28 Adele Peterson <adele@apple.com>
  48206. Removing Qt stub, since it doesn't use the same header as the others.
  48207. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  48208. 2011-03-28 Adele Peterson <adele@apple.com>
  48209. Added a few more stubs.
  48210. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  48211. (LayoutTestController::hasGrammarMarker):
  48212. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  48213. (LayoutTestController::hasGrammarMarker):
  48214. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  48215. (LayoutTestController::hasGrammarMarker):
  48216. 2011-03-28 Adele Peterson <adele@apple.com>
  48217. Build fix.
  48218. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  48219. (LayoutTestController::hasGrammarMarker):
  48220. 2011-03-28 Adele Peterson <adele@apple.com>
  48221. Reviewed by Eric Seidel.
  48222. Testing support for <rdar://problem/9112694> REGRESSION (r79411): "Check grammar with spelling" context menu doesn't check as you type
  48223. https://bugs.webkit.org/show_bug.cgi?id=57173
  48224. * DumpRenderTree/LayoutTestController.cpp:
  48225. (hasGrammarMarkerCallback): Added.
  48226. (LayoutTestController::staticFunctions): Added case for hasGrammarMarker.
  48227. * DumpRenderTree/LayoutTestController.h:
  48228. * DumpRenderTree/mac/DumpRenderTree.mm: (createWebViewAndOffscreenWindow): Call setGrammarCheckingEnabled.
  48229. * DumpRenderTree/mac/LayoutTestControllerMac.mm: (LayoutTestController::hasGrammarMarker): Added. Call new hasGrammarMarker method.
  48230. 2011-03-28 Csaba Osztrogonác <ossy@webkit.org>
  48231. Reviewed by Benjamin Poulain.
  48232. [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
  48233. https://bugs.webkit.org/show_bug.cgi?id=57087
  48234. Trivial typo fix after r82082.
  48235. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  48236. (WTR::activateFonts):
  48237. 2011-03-28 Alexis Menard <alexis.menard@openbossa.org>
  48238. Reviewed by Andreas Kling.
  48239. Add myself to the committers list.
  48240. * Scripts/webkitpy/common/config/committers.py:
  48241. 2011-03-28 Simon Fraser <simon.fraser@apple.com>
  48242. Reviewed by Sam Weinig.
  48243. WebKit2 unfortunately uses code from WebKit, so MiniBrowser needs
  48244. to link against WebKit.framework for now.
  48245. * MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj:
  48246. 2011-03-28 Benjamin Poulain <benjamin.poulain@nokia.com>
  48247. Reviewed by Andreas Kling.
  48248. [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
  48249. https://bugs.webkit.org/show_bug.cgi?id=57087
  48250. Disable QT_ASCII_CAST_WARNINGS for applications.
  48251. * DumpRenderTree/qt/DumpRenderTree.pro:
  48252. * DumpRenderTree/qt/ImageDiff.pro:
  48253. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  48254. * MiniBrowser/qt/MiniBrowser.pro:
  48255. * QtTestBrowser/QtTestBrowser.pro:
  48256. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  48257. 2011-03-28 Andreas Kling <kling@webkit.org>
  48258. Reviewed by Kenneth Rohde Christiansen.
  48259. [Qt] QtTestBrowser doesn't reset its window title when opening about:blank
  48260. https://bugs.webkit.org/show_bug.cgi?id=57224
  48261. * QtTestBrowser/mainwindow.cpp:
  48262. (MainWindow::buildUI):
  48263. (MainWindow::onTitleChanged):
  48264. * QtTestBrowser/mainwindow.h:
  48265. 2011-03-27 Jer Noble <jer.noble@apple.com>
  48266. Reviewed by Maciej Stachowiak.
  48267. Full Screen: disable keyboard access by default
  48268. https://bugs.webkit.org/show_bug.cgi?id=56684
  48269. Accept the withKeyboard parameter to supportsFullScreenForElement.
  48270. * DumpRenderTree/mac/UIDelegate.mm:
  48271. (-[UIDelegate webView:supportsFullScreenForElement:withKeyboard:]):
  48272. 2011-03-27 Patrick Gansterer <paroga@webkit.org>
  48273. Reviewed by David Levin.
  48274. check-webkit-style should check ChangeLog for a valid bug number
  48275. https://bugs.webkit.org/show_bug.cgi?id=57184
  48276. * Scripts/webkitpy/style/checker.py:
  48277. * Scripts/webkitpy/style/checker_unittest.py:
  48278. * Scripts/webkitpy/style/checkers/changelog.py: Added.
  48279. * Scripts/webkitpy/style/checkers/changelog_unittest.py: Added.
  48280. 2011-03-27 Benjamin Poulain <benjamin.poulain@nokia.com>
  48281. Reviewed by Andreas Kling.
  48282. [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
  48283. https://bugs.webkit.org/show_bug.cgi?id=57087
  48284. Use explicit conversion for string to avoid depending on the default codec
  48285. installed by the user code.
  48286. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  48287. (WTR::activateFonts):
  48288. 2011-03-26 Maciej Stachowiak <mjs@apple.com>
  48289. Revert inadvertantly committed changes.
  48290. * Scripts/old-run-webkit-tests:
  48291. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  48292. 2011-03-26 Andreas Kling <kling@webkit.org>
  48293. Reviewed by Kenneth Rohde Christiansen.
  48294. [Qt] Show page icons (favicons) in QtTestBrowser location bar.
  48295. https://bugs.webkit.org/show_bug.cgi?id=57162
  48296. * QtTestBrowser/QtTestBrowser.qrc:
  48297. * QtTestBrowser/favicon.png: Added.
  48298. * QtTestBrowser/locationedit.cpp:
  48299. (defaultPageIcon):
  48300. (LocationEdit::LocationEdit):
  48301. (LocationEdit::setPageIcon):
  48302. (LocationEdit::resizeEvent):
  48303. (LocationEdit::updateInternalGeometry):
  48304. * QtTestBrowser/locationedit.h:
  48305. * QtTestBrowser/mainwindow.cpp:
  48306. (MainWindow::buildUI):
  48307. (MainWindow::onIconChanged):
  48308. (MainWindow::onLoadStarted):
  48309. * QtTestBrowser/mainwindow.h:
  48310. 2011-03-23 Martin Robinson <mrobinson@igalia.com>
  48311. Reviewed by Xan Lopez.
  48312. [GTK] Force DumpRenderTree to use 96 DPI
  48313. https://bugs.webkit.org/show_bug.cgi?id=56866
  48314. Make sure that GTK+ is set to use 96 DPI when running tests. This ensures
  48315. broader compatibility with WebKit2 and makes setting font sizes more straightforward.
  48316. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  48317. (initializeGtkFontSettings): Set the screen resolution and GTK+ xft property to 96 DPI.
  48318. (resetDefaultsToConsistentValues):Remove the call which repeatedly set the GDK screen resolution.
  48319. (setDefaultsToConsistentStateValuesForTesting): Update the font sizes to reflect the new DPI.
  48320. 2011-03-25 Andy Estes <aestes@apple.com>
  48321. Reviewed by Adele Peterson.
  48322. REGRESSION (r70748): latest nightly builds kills AC_QuickTime.js
  48323. https://bugs.webkit.org/show_bug.cgi?id=49016
  48324. TestNetscapePlugIn needs to register support for an image MIME type so
  48325. we can test that the embed tag prefers plug-ins to render image MIME
  48326. types.
  48327. * DumpRenderTree/TestNetscapePlugIn/mac/Info.plist: Register image/png.
  48328. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  48329. (NP_GetMIMEDescription): Ditto.
  48330. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc: Ditto.
  48331. 2011-03-25 Jessie Berlin <jberlin@apple.com>
  48332. Reviewed by Sam Weinig.
  48333. WebKit2: Need to be able to set and get the Cookie Storage Policy.
  48334. https://bugs.webkit.org/show_bug.cgi?id=50780
  48335. Add a test for getting and setting the HTTP Cookie Accept Policy in WebKit2.
  48336. The test is named "CookieManager" so that we can eventually exercise more of the
  48337. CookieManager functionality in the test.
  48338. * TestWebKitAPI/Tests/WebKit2/CookieManager.cpp: Added.
  48339. (TestWebKitAPI::didGetTestHTTPCookieAcceptPolicy):
  48340. Assert that the policy returned is equal to the policy set in
  48341. didGetUserHTTPCookieAcceptPolicy, and then restore the user's policy.
  48342. (TestWebKitAPI::didGetUserHTTPCookieAcceptPolicy):
  48343. Set the policy to something different than the user's policy and get the policy again.
  48344. (TestWebKitAPI::didFinishLoadForFrame):
  48345. Get the user's policy so that it can be restored at the end of the test.
  48346. (TestWebKitAPI::TEST):
  48347. Load about:blank so that the Web Process gets instatiated (needed to get the
  48348. CookieManager).
  48349. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  48350. Add CookieManager.cpp.
  48351. 2011-03-24 Kevin Ollivier <kevino@theolliviers.com>
  48352. [wx] Fix the build so that gcc-4.1 and up can be used to build on SnowLeopard.
  48353. * wx/build/settings.py:
  48354. 2011-03-24 Ilya Sherman <isherman@chromium.org>
  48355. Reviewed by Adam Roben.
  48356. Implement layoutTestController.setAutoFilled in DRT on Windows
  48357. https://bugs.webkit.org/show_bug.cgi?id=56828
  48358. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  48359. (LayoutTestController::setAutofilled): Implemented.
  48360. 2011-03-24 Brent Fulgham <bfulgham@webkit.org>
  48361. Unreviewed build correction.
  48362. Correct vsprops file for Debug variant of the CFLite build.
  48363. Disable a CFNETWORK-specific test when building for CFLite.
  48364. * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops:
  48365. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  48366. 2011-03-24 Dirk Pranke <dpranke@chromium.org>
  48367. Reviewed by Adam Barth.
  48368. fix regressions introduced in 81908 - there were a couple of
  48369. code paths that only fired under python 2.5 that I missed.
  48370. Also change a couple of 'python' references to sys.executable
  48371. in order to handle runing test-webkitpy with a binary other than
  48372. something called 'python'.
  48373. https://bugs.webkit.org/show_bug.cgi?id=57063
  48374. * Scripts/webkitpy/layout_tests/port/mac.py:
  48375. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  48376. * Scripts/webkitpy/test/cat.py:
  48377. * Scripts/webkitpy/test/echo.py:
  48378. 2011-03-24 Brent Fulgham <bfulgham@webkit.org>
  48379. Unreviewed build correction.
  48380. Add a stub implementation of the TestInvocation dumping logic.
  48381. Update project files to reflect new file.
  48382. * WebKitTestRunner/cairo: Added.
  48383. * WebKitTestRunner/cairo/TestInvocationCairo.cpp: Added.
  48384. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  48385. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  48386. 2011-03-24 Dirk Pranke <dpranke@chromium.org>
  48387. Reviewed by Tony Chang.
  48388. new-run-webkit-tests: clean up worker model defaults. This
  48389. changes the default behavior to 'threads' instead of
  48390. 'old-threads', and clarifies that chromium-win-* and
  48391. chromium-mac-leopard are exceptions.
  48392. https://bugs.webkit.org/show_bug.cgi?id=56971
  48393. * Scripts/webkitpy/layout_tests/port/base.py:
  48394. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  48395. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  48396. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  48397. * Scripts/webkitpy/layout_tests/port/test.py:
  48398. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  48399. 2011-03-23 Leandro Gracia Gil <leandrogracia@chromium.org>
  48400. Reviewed by Darin Adler.
  48401. Media Stream API: fix the order of the options in build-webkit.
  48402. https://bugs.webkit.org/show_bug.cgi?id=56949
  48403. Fix the order of the options in build-webkit.
  48404. * Scripts/build-webkit:
  48405. 2011-03-23 Adam Klein <adamk@chromium.org>
  48406. Reviewed by Mihai Parparita.
  48407. Add an option to new-run-webkit-httpd to allow overriding the location of LayoutTests directory
  48408. https://bugs.webkit.org/show_bug.cgi?id=56884
  48409. This option will be utilized by Chromium's ui_tests to allow
  48410. referencing js-test-resources from a layout test over HTTP.
  48411. * Scripts/new-run-webkit-httpd:
  48412. Added --layout_tests_dir option.
  48413. * Scripts/webkitpy/layout_tests/port/http_server.py:
  48414. Plumbed through as layout_tests_dir param.
  48415. 2011-03-23 Dirk Pranke <dpranke@chromium.org>
  48416. Reviewed by Mihai Parparita.
  48417. new-run-webkit-tests: run tests in ascending alphabetical order per
  48418. dir. This is a second attempt at the fix; the first attempt, in
  48419. r81597, broke the behavior on the old-inline and old-threads
  48420. worker models.
  48421. https://bugs.webkit.org/show_bug.cgi?id=56760
  48422. * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
  48423. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  48424. * Scripts/webkitpy/layout_tests/port/test.py:
  48425. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  48426. 2011-03-23 Mario Sanchez Prada <msanchez@igalia.com>
  48427. Reviewed by Martin Robinson.
  48428. [GTK] GTK's DRT to ouput detail's string for the 'property-change' signal
  48429. https://bugs.webkit.org/show_bug.cgi?id=56953
  48430. Print the string for the detail of 'property-change' signal.
  48431. * DumpRenderTree/gtk/AccessibilityCallbacks.cpp:
  48432. (axObjectEventListener): Print the detail string.
  48433. 2011-03-23 Yury Semikhatsky <yurys@chromium.org>
  48434. Reviewed by Pavel Feldman.
  48435. [V8] Web Inspector: compile DebuggerScript.js into DebuggerScriptSource.h
  48436. https://bugs.webkit.org/show_bug.cgi?id=56843
  48437. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  48438. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  48439. 2011-03-22 Eric Seidel <eric@webkit.org>
  48440. Reviewed by Adam Barth.
  48441. Teach update-webkit about gyp
  48442. https://bugs.webkit.org/show_bug.cgi?id=56881
  48443. This makes it possible for someone who builds from Xcode
  48444. to just run update-webkit --gyp and have the project files
  48445. generated after update automatically.
  48446. I also added a stand-alone "generate-project-files" script
  48447. wrapping Source/gyp/configure. This makes running gyp simpler
  48448. since most people will not have gyp or Source/gyp in their path.
  48449. * Scripts/build-webkit:
  48450. * Scripts/generate-project-files: Added.
  48451. * Scripts/update-webkit:
  48452. 2011-03-22 Anton D'Auria <adauria@apple.com>
  48453. Reviewed by Alexey Proskuryakov.
  48454. Add +[WebApplicationCache getOriginsWithCache]
  48455. https://bugs.webkit.org/show_bug.cgi?id=56722
  48456. * DumpRenderTree/LayoutTestController.cpp:
  48457. (originsWithApplicationCacheCallback):
  48458. (LayoutTestController::staticFunctions):
  48459. * DumpRenderTree/LayoutTestController.h:
  48460. * DumpRenderTree/chromium/LayoutTestController.cpp: Added stub.
  48461. (LayoutTestController::originsWithApplicationCache):
  48462. * DumpRenderTree/chromium/LayoutTestController.h:
  48463. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Added stub.
  48464. (LayoutTestController::originsWithApplicationCache):
  48465. * DumpRenderTree/mac/LayoutTestControllerMac.mm: Pass array of origin's database identifiers.
  48466. (originsArrayToJS): Helper function for converting array of WebSecurityOrigins to a JS array of origin identifiers.
  48467. (LayoutTestController::originsWithApplicationCache):
  48468. (LayoutTestController::originsWithLocalStorage):
  48469. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Added stub.
  48470. (LayoutTestController::originsWithApplicationCache):
  48471. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  48472. * DumpRenderTree/win/LayoutTestControllerWin.cpp: Added stub.
  48473. (LayoutTestController::originsWithApplicationCache):
  48474. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Added stub.
  48475. (LayoutTestController::originsWithApplicationCache):
  48476. 2011-03-22 Eric Seidel <eric@webkit.org>
  48477. Reviewed by Adam Barth.
  48478. Add support to build-webkit for building with gyp-generated project files
  48479. https://bugs.webkit.org/show_bug.cgi?id=56877
  48480. build-webkit is a cesspool. This change just hacks in --gyp support for Mac.
  48481. Eventually we'll want to support gyp-generated projects in a more general manner.
  48482. * Scripts/build-webkit:
  48483. 2011-03-22 David Kilzer <ddkilzer@apple.com>
  48484. <http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode
  48485. Reviewed by Joseph Pecoraro.
  48486. * Scripts/build-webkit: Updated usage statement to include
  48487. --dsym.
  48488. * Scripts/webkitdirs.pm: Added $generateDsym variable.
  48489. (generateDsym): Added. Call determineGenerateDsym() and
  48490. return $generateDsym.
  48491. (determineGenerateDsym): Added. Parse @ARGV for --dsym and set
  48492. $generateDsym.
  48493. (argumentsForXcode): Added. Returns additional arguments for
  48494. xcodebuild based on command-line switches.
  48495. (XcodeOptions): Updated to include argumentsForXcode() in the
  48496. array returned.
  48497. 2011-03-22 Adam Roben <aroben@apple.com>
  48498. Make Leopard Debug bots and Windows XP Debug (Tests) core builders
  48499. These bots are consistently green again.
  48500. Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
  48501. core builders
  48502. Rubber-stamped by Antti Koivisto.
  48503. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  48504. (BuildBot.__init__): Loosened the regexps for Leopard and Windows.
  48505. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  48506. (BuildBotTest.test_builder_name_regexps): Updated expectations.
  48507. 2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>
  48508. Unreviewed, rolling out r81597.
  48509. http://trac.webkit.org/changeset/81597
  48510. https://bugs.webkit.org/show_bug.cgi?id=56801
  48511. Change results in lots of unexpected flaky on the dashboard.
  48512. (Requested by pfeldman on #webkit).
  48513. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  48514. * Scripts/webkitpy/layout_tests/port/test.py:
  48515. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  48516. 2011-03-21 Sam Weinig <sam@webkit.org>
  48517. Fix failing tests on the WebKit2 bots.
  48518. * WebKitTestRunner/TestController.cpp:
  48519. (WTR::TestController::resetStateToConsistentValues):
  48520. 2011-03-21 Daniel Sievers <sievers@google.com>
  48521. Reviewed by Simon Fraser.
  48522. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
  48523. https://bugs.webkit.org/show_bug.cgi?id=56139
  48524. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  48525. (main):
  48526. * DumpRenderTree/chromium/LayoutTestController.cpp:
  48527. (LayoutTestController::LayoutTestController):
  48528. (LayoutTestController::layerTreeAsText):
  48529. * DumpRenderTree/chromium/LayoutTestController.h:
  48530. (LayoutTestController::setShowDebugLayerTree):
  48531. * DumpRenderTree/chromium/TestShell.cpp:
  48532. (TestShell::runFileTest):
  48533. (TestShell::dump):
  48534. * DumpRenderTree/chromium/TestShell.h:
  48535. (TestParams::TestParams):
  48536. 2011-03-21 Adam Roben <aroben@apple.com>
  48537. Try again to get buildbot to show run-javascriptcore-tests's actual.html as an HTML file
  48538. Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
  48539. output as plain text
  48540. Reviewed by David Kilzer.
  48541. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  48542. (RunJavaScriptCoreTests): List actual.html as one of our log files so it will get uploaded
  48543. to the master.
  48544. (RunJavaScriptCoreTests.commandComplete): Reading the actual.html file here won't work,
  48545. since we're running on the build master, not the slave. Instead, turn the raw source of
  48546. actual.html which the build slave uploaded into an HTML log.
  48547. 2011-03-21 Dirk Pranke <dpranke@chromium.org>
  48548. Reviewed by Mihai Parparita.
  48549. new-run-webkit-tests: run tests in ascending alphabetical order per dir
  48550. https://bugs.webkit.org/show_bug.cgi?id=56760
  48551. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  48552. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  48553. * Scripts/webkitpy/layout_tests/port/test.py:
  48554. 2011-03-21 Leandro Gracia Gil <leandrogracia@chromium.org>
  48555. Reviewed by Steve Block.
  48556. Media Stream API patch 0: adding compilation guards.
  48557. https://bugs.webkit.org/show_bug.cgi?id=56458
  48558. Adding options to enable the media stream API feature in Chromium.
  48559. * Scripts/build-webkit:
  48560. 2011-03-21 Qi Zhang <qi.2.zhang@nokia.com>
  48561. Reviewed by Laszlo Gombos.
  48562. [Qt] Add a command line option to capture stdout and stderr for DumpRenderTree
  48563. https://bugs.webkit.org/show_bug.cgi?id=56323
  48564. Using freopen to redirect STDOUT and STDERR when DumpRenderTree command line provide
  48565. "--stdout" or "--stderr" option.
  48566. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  48567. (WebCore::DumpRenderTree::~DumpRenderTree):
  48568. (WebCore::DumpRenderTree::processArgsLine):
  48569. (WebCore::DumpRenderTree::loadNextTestInStandAloneMode):
  48570. * DumpRenderTree/qt/DumpRenderTreeQt.h:
  48571. (WebCore::DumpRenderTree::setRedirectOutputFileName):
  48572. (WebCore::DumpRenderTree::setRedirectErrorFileName):
  48573. * DumpRenderTree/qt/main.cpp:
  48574. (isOption):
  48575. (takeOptionValue):
  48576. (printUsage):
  48577. (main):
  48578. 2011-03-21 Adam Roben <aroben@apple.com>
  48579. Fix exceptions on the buildbot due to my last change
  48580. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  48581. (RunJavaScriptCoreTests.commandComplete): Catch exceptions due to actual.html not existing.
  48582. 2011-03-21 Adam Roben <aroben@apple.com>
  48583. Teach buildbot to treat run-javascriptcore-tests's actual.html as an HTML file
  48584. Fixes <http://webkit.org/b/56746> build.webkit.org shows run-javascriptcore-tests's HTML
  48585. output as plain text
  48586. Reviewed by Darin Adler.
  48587. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  48588. (RunJavaScriptCoreTests): Removed the logfiles variable, which can only handle plaintext
  48589. logs.
  48590. (RunJavaScriptCoreTests.commandComplete): Use the addHTMLLog method to upload actual.html to
  48591. the build master. This will correctly treat it as HTML.
  48592. 2011-03-20 Bill Budge <bbudge@chromium.org>
  48593. Reviewed by Adam Barth.
  48594. Rename ThreadSafeShared to ThreadSafeRefCounted
  48595. https://bugs.webkit.org/show_bug.cgi?id=56714
  48596. No new tests. Exposes no new functionality.
  48597. * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeRefCounted.h: Copied from DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h.
  48598. * DumpRenderTree/ForwardingHeaders/wtf/ThreadSafeShared.h: Removed.
  48599. * Scripts/do-webcore-rename:
  48600. 2011-03-19 Anton D'Auria <adauria@apple.com>
  48601. Reviewed by Dan Bernstein.
  48602. Add stub to LayoutTestControllerGtk.cpp to fix GTK build
  48603. https://bugs.webkit.org/show_bug.cgi?id=56719
  48604. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: Adding stub.
  48605. (LayoutTestController::clearApplicationCacheForOrigin):
  48606. 2011-03-19 Anton D'Auria <adauria@apple.com>
  48607. Reviewed by Alexey Proskuryakov.
  48608. ApplicationCacheGroup is not obsolete after being deleted via ApplicationCacheStorage::deleteEntriesForOrigin
  48609. https://bugs.webkit.org/show_bug.cgi?id=56415
  48610. * DumpRenderTree/LayoutTestController.cpp:
  48611. (clearApplicationCacheForOriginCallback):
  48612. (LayoutTestController::staticFunctions):
  48613. * DumpRenderTree/LayoutTestController.h:
  48614. * DumpRenderTree/chromium/LayoutTestController.cpp: Adding stubs.
  48615. (LayoutTestController::LayoutTestController):
  48616. (LayoutTestController::clearAllApplicationCaches):
  48617. (LayoutTestController::clearApplicationCacheForOrigin):
  48618. * DumpRenderTree/chromium/LayoutTestController.h:
  48619. * DumpRenderTree/mac/LayoutTestControllerMac.mm: Adding stub.
  48620. (LayoutTestController::clearApplicationCacheForOrigin):
  48621. * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Adding stub.
  48622. (LayoutTestController::clearApplicationCacheForOrigin):
  48623. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  48624. * DumpRenderTree/win/LayoutTestControllerWin.cpp: Adding stub.
  48625. (LayoutTestController::clearApplicationCacheForOrigin):
  48626. * DumpRenderTree/wx/LayoutTestControllerWx.cpp: Adding stub.
  48627. (LayoutTestController::clearApplicationCacheForOrigin):
  48628. 2011-03-18 Dan Bernstein <mitz@apple.com>
  48629. Revised build fix for r81135.
  48630. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  48631. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  48632. 2011-03-18 Adam Roben <aroben@apple.com>
  48633. Windows build fix
  48634. * WebKitTestRunner/config.h: Add a missing #endif.
  48635. 2011-03-18 Andreas Kling <kling@webkit.org>
  48636. Unbreak Qt build after r81494.
  48637. * WebKitTestRunner/qt/TestInvocationQt.cpp:
  48638. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  48639. 2011-03-18 Sam Weinig <sam@webkit.org>
  48640. Fix windows build. This was really Adam Roben's fault. I swear!
  48641. * WebKitTestRunner/config.h:
  48642. 2011-03-18 Sam Weinig <sam@webkit.org>
  48643. Reviewed by Adam Roben.
  48644. Pixel tests don't work in WebKitTestRunner on Windows
  48645. https://bugs.webkit.org/show_bug.cgi?id=56630
  48646. Cross-platformize (Mac and Windows CG) the pixel dumping code in WebKitTestRunner to use WebKit2
  48647. built-in snapshotting instead of using the window server on the Mac.
  48648. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  48649. (WTR::InjectedBundle::InjectedBundle):
  48650. (WTR::InjectedBundle::didReceiveMessage):
  48651. (WTR::InjectedBundle::beginTesting):
  48652. (WTR::InjectedBundle::done):
  48653. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  48654. (WTR::InjectedBundle::setPixelResult):
  48655. (WTR::InjectedBundle::shouldDumpPixels):
  48656. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  48657. (WTR::InjectedBundlePage::dump):
  48658. Take the snapshot in the bundle and send it to the UIProcess for dumping.
  48659. * WebKitTestRunner/TestInvocation.cpp:
  48660. (WTR::TestInvocation::invoke):
  48661. (WTR::TestInvocation::dump):
  48662. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  48663. * WebKitTestRunner/TestInvocation.h:
  48664. * WebKitTestRunner/cg: Added.
  48665. * WebKitTestRunner/cg/TestInvocationCG.cpp: Copied from WebKitTestRunner/mac/TestInvocationMac.mm.
  48666. (WTR::createCGContextFromImage):
  48667. (WTR::computeMD5HashStringForContext):
  48668. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  48669. * WebKitTestRunner/mac/TestInvocationMac.mm: Removed.
  48670. Making pixel dumping code shared for CG ports. Also use the WTF/MD5 instead of platform specific code.
  48671. * WebKitTestRunner/win/TestInvocationWin.cpp:
  48672. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  48673. Keep stub for Cairo build.
  48674. * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Added.
  48675. Add CG configuration.
  48676. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  48677. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  48678. Add new files.
  48679. 2011-03-18 Adam Roben <aroben@apple.com>
  48680. Don't allow Leaks Viewer's vertical scrollbar to cover up long function names
  48681. Rubber-stamped by Simon Fraser.
  48682. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
  48683. (.data-grid .data-container): Use overflow-y:auto instead of the Inspector's default
  48684. overflow-y:overlay so that the scrollbar doesn't overlay the content.
  48685. 2011-03-18 Adam Roben <aroben@apple.com>
  48686. Don't ellipsize long or indented function names in Leaks Viewer
  48687. Fixes <http://webkit.org/b/56037> Leaks viewer needs horizontal
  48688. scrollbar
  48689. Reviewed by Simon Fraser.
  48690. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
  48691. (.data-grid .data-container):
  48692. (.data-grid td > div, .data-grid th > div):
  48693. Allow the contents to extend to the right.
  48694. 2011-03-18 Adam Roben <aroben@apple.com>
  48695. Fix some leaks in DRT seen on the leaks bot
  48696. Fixes <http://webkit.org/b/56638> addURLToRedirectCallback and
  48697. setWillSendRequestClearHeaderCallback in DRT are leaky
  48698. Reviewed by Alexey Proskuryakov.
  48699. * DumpRenderTree/ForwardingHeaders/wtf/OwnArrayPtr.h: Added.
  48700. * DumpRenderTree/LayoutTestController.cpp:
  48701. (addURLToRedirectCallback):
  48702. (setWillSendRequestClearHeaderCallback):
  48703. Use OwnArrayPtr to cause the strings to be deleted.
  48704. 2011-03-18 Adam Roben <aroben@apple.com>
  48705. Fix a NSURLCredential leak seen on the leaks bot
  48706. Fixes <http://webkit.org/b/56637> -[SynchronousLoader
  48707. connection:didReceiveAuthenticationChallenge:] is leaky
  48708. Reviewed by John Sullivan.
  48709. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  48710. (-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]): Use a RetainPtr to
  48711. cause the NSURLCredential to be released.
  48712. 2011-03-18 John Knottenbelt <jknotten@chromium.org>
  48713. Unreviewed.
  48714. Remove unnecessary brackets around my email address.
  48715. * Scripts/webkitpy/common/config/committers.py:
  48716. 2011-03-18 Adam Roben <aroben@apple.com>
  48717. Remove some files I accidentally added in r81454
  48718. * WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
  48719. * WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.
  48720. 2011-03-18 Adam Roben <aroben@apple.com>
  48721. Ignore an NSNumberFormatter leak on SnowLeopard
  48722. * Scripts/old-run-webkit-tests:
  48723. (countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
  48724. getObjectValue:forString:errorDescription:].
  48725. 2011-03-18 Adam Roben <aroben@apple.com>
  48726. Fix a leak beneath LayoutTestController::authenticateSession seen on the bots
  48727. Rubber-stamped by Mark Rowe.
  48728. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  48729. (LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
  48730. released.
  48731. 2011-03-17 Adam Roben <aroben@apple.com>
  48732. Address a review comment I missed in r81445
  48733. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
  48734. (LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
  48735. leaked bytes to speed up searching on long lines.
  48736. 2011-03-17 Adam Roben <aroben@apple.com>
  48737. Mark leaky builds orange, even if all regression tests passed
  48738. Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
  48739. build.webkit.org when all tests pass even though there are still leaks
  48740. Reviewed by Dan Bernstein.
  48741. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  48742. (RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
  48743. be marked orange if this build step generates warnings.
  48744. 2011-03-17 Adam Roben <aroben@apple.com>
  48745. Allow values in Leaks Viewer to be shown as percentages
  48746. Double-clicking on a column will toggle between showing percentages and showing real values.
  48747. Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
  48748. number of leaked bytes in Leaks Viewer
  48749. Reviewed by Joe Pecoraro.
  48750. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
  48751. (LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
  48752. node's totalTime, which is used in calculating percentages.
  48753. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
  48754. (monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
  48755. showing them as percentages.
  48756. 2011-03-17 Adam Roben <aroben@apple.com>
  48757. Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer
  48758. The Self and Total columns now report the number of leaked bytes. The new Calls column shows
  48759. the number of leaked allocations. And the new Average column shows the average number of
  48760. leaked bytes per call.
  48761. Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
  48762. just how many allocations
  48763. Reviewed by Joe Pecoraro.
  48764. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
  48765. (LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
  48766. line and store it with the leak stack.
  48767. (LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
  48768. properties.
  48769. (LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
  48770. property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
  48771. .numberOfCalls now holds the number of leaked allocations.
  48772. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
  48773. (Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
  48774. appear.
  48775. (monkeyPatchInspectorObjects): Format the values as bytes.
  48776. 2011-03-17 Adam Roben <aroben@apple.com>
  48777. Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests
  48778. Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
  48779. regression tests
  48780. Reviewed by James Robinson.
  48781. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  48782. (RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
  48783. is always populated, even when all regression tests pass.
  48784. 2011-03-10 Hayato Ito <hayato@chromium.org>
  48785. Reviewed by Tony Chang.
  48786. Add a check logic for reftests in case that a reftest is marked AS REBASELINE.
  48787. https://bugs.webkit.org/show_bug.cgi?id=56076
  48788. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  48789. 2011-03-17 Adam Roben <aroben@apple.com>
  48790. Skip a compositing-sensitive test when accelerated compositing is disabled
  48791. Reviewed by Sam Weinig.
  48792. * Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
  48793. accelerated compositing is disabled.
  48794. 2011-03-17 Adam Roben <aroben@apple.com>
  48795. Start using PlatformSpecificScheduler for the Mac builders
  48796. The current set of file/directory patterns should work for Mac builders. We may discover
  48797. that there are more files and directories we can exclude from the Mac builds, but they can
  48798. be added later.
  48799. Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds
  48800. Reviewed by Mark Rowe.
  48801. * BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
  48802. PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.
  48803. * Scripts/webkitpy/common/config/build.py:
  48804. (_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
  48805. cleaned up patterns a little bit.
  48806. * Scripts/webkitpy/common/config/build_unittest.py:
  48807. (ShouldBuildTest): Fixed some expected results.
  48808. (ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
  48809. platforms.
  48810. 2011-03-17 Jeff Miller <jeffm@apple.com>
  48811. Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:
  48812. *.mode*
  48813. *.pbxuser
  48814. *.perspective*
  48815. project.xcworkspace
  48816. xcuserdata
  48817. * DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
  48818. * MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
  48819. * TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
  48820. * WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
  48821. * WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.
  48822. 2011-03-17 Adam Roben <aroben@apple.com>
  48823. Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows
  48824. Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
  48825. mac-wk2
  48826. Reviewed by Anders Carlsson.
  48827. * Scripts/old-run-webkit-tests:
  48828. (expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
  48829. directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
  48830. we're running in WebKit2 mode.
  48831. 2011-03-17 Mikhail Naganov <mnaganov@chromium.org>
  48832. Reviewed by Yury Semikhatsky.
  48833. Web Inspector: Clean up Inspector strings.
  48834. https://bugs.webkit.org/show_bug.cgi?id=56557
  48835. Modify the script to deal correctly with "\xNN" escapes, and to
  48836. check strings in Chromium's DevTools.js.
  48837. * Scripts/check-inspector-strings:
  48838. 2011-03-17 Keith Kyzivat <keith.kyzivat@nokia.com>
  48839. Reviewed by Benjamin Poulain.
  48840. Update autoinstall to install mechanize 0.2.4
  48841. https://bugs.webkit.org/show_bug.cgi?id=56499
  48842. Newer versions of mechanize support HTTPS proxies, which is necessary
  48843. for people using webkit-patch behind firewalls.
  48844. * Scripts/webkitpy/common/system/autoinstall.py:
  48845. * Scripts/webkitpy/thirdparty/__init__.py:
  48846. 2011-03-16 Sam Weinig <sam@webkit.org>
  48847. Reviewed by Adam Roben.
  48848. REGRESSION (r81084): media/invalid-media-url-crash.html and editing/execCommand/indent-paragraphs.html failing on WebKit2
  48849. https://bugs.webkit.org/show_bug.cgi?id=56541
  48850. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  48851. (WTR::InjectedBundlePage::willSendRequestForFrame):
  48852. Check for an empty host in addition to a null host. This bug was introduced
  48853. when porting off of the KURL code and onto the WKURLRef version.
  48854. 2011-03-16 Sam Weinig <sam@webkit.org>
  48855. Reviewed by Adam Roben.
  48856. Add Lucas Forschler to the list of WebKit committers.
  48857. * Scripts/webkitpy/common/config/committers.py:
  48858. 2011-03-16 Sam Weinig <sam@webkit.org>
  48859. Reviewed upon and dictated through Adam Roben.
  48860. Escape crashing function names in results.html. This fixes an issue
  48861. when a crash involves a type with templates.
  48862. * Scripts/old-run-webkit-tests:
  48863. 2011-03-16 Daniel Sievers <sievers@google.com>
  48864. Reviewed by James Robinson.
  48865. Add setting to always force compositing mode
  48866. https://bugs.webkit.org/show_bug.cgi?id=56156
  48867. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  48868. (main):
  48869. * DumpRenderTree/chromium/TestShell.cpp:
  48870. (TestShell::TestShell):
  48871. (TestShell::resetWebSettings):
  48872. * DumpRenderTree/chromium/TestShell.h:
  48873. (TestShell::setForceCompositingMode):
  48874. * DumpRenderTree/chromium/WebPreferences.cpp:
  48875. (WebPreferences::reset):
  48876. (WebPreferences::applyTo):
  48877. * DumpRenderTree/chromium/WebPreferences.h:
  48878. 2011-03-15 Hayato Ito <hayato@chromium.org>
  48879. Reviewed by Ojan Vafai.
  48880. Ignore files that will be used by reftests in old-run-webkit-tests.
  48881. https://bugs.webkit.org/show_bug.cgi?id=55936
  48882. * Scripts/old-run-webkit-tests:
  48883. 2011-03-15 Felipe Oliveira da Silva Netto <f.dachshund@gmail.com>
  48884. Reviewed by Adam Roben.
  48885. Function relativeScriptsDir doesn't return the correct relative
  48886. Scripts directory.
  48887. * Scripts/webkitdirs.pm:
  48888. (relativeScriptsDir): Ensure we use the directory that contains
  48889. webkitdirs.pm, not the one that contains the original script that
  48890. was invoked.
  48891. 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
  48892. [wx] Build fixes for long linker commands on Win and method return error, plus a Mac
  48893. fix to link against the Security framework after recent WebKitSystemInterface changes.
  48894. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  48895. (LayoutTestController::originsWithLocalStorage):
  48896. * wx/build/settings.py:
  48897. * wx/build/waf_extensions.py:
  48898. 2011-03-15 Sam Weinig <sam@webkit.org>
  48899. Reviewed by Darin Adler.
  48900. Add script to convert a patch to a prettypatch and show in the default browser
  48901. https://bugs.webkit.org/show_bug.cgi?id=56416
  48902. This can be used either like
  48903. $ svn-create-patch | show-pretty-diff
  48904. or
  48905. $ show-pretty-diff patch.diff
  48906. * Scripts/show-pretty-diff: Added.
  48907. 2011-03-15 Brian Weinstein <bweinstein@apple.com>
  48908. Rubber-stamped by Adam Roben.
  48909. Adding myself as a reviewer.
  48910. * Scripts/webkitpy/common/config/committers.py:
  48911. 2011-03-15 Anders Carlsson <andersca@apple.com>
  48912. Try to fix the Windows build.
  48913. * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp:
  48914. (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
  48915. 2011-03-15 Anders Carlsson <andersca@apple.com>
  48916. Reviewed by Sam Weinig.
  48917. Make sure that NP_Shutdown is always the last NPP function called
  48918. https://bugs.webkit.org/show_bug.cgi?id=56391
  48919. Add a test that times out if an NP_Deallocate object is called after NP_Shutdown.
  48920. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  48921. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  48922. (PluginTest::PluginTest):
  48923. (PluginTest::NP_Shutdown):
  48924. (PluginTest::registerNPShutdownFunction):
  48925. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  48926. * DumpRenderTree/TestNetscapePlugIn/Tests/NPDeallocateCalledBeforeNPShutdown.cpp: Added.
  48927. (NPDeallocateCalledBeforeNPShutdown::NPDeallocateCalledBeforeNPShutdown):
  48928. (NPDeallocateCalledBeforeNPShutdown::TestObject::~TestObject):
  48929. (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::hasProperty):
  48930. (NPDeallocateCalledBeforeNPShutdown::ScriptableObject::getProperty):
  48931. (NPDeallocateCalledBeforeNPShutdown::NPP_New):
  48932. (NPDeallocateCalledBeforeNPShutdown::NPP_GetValue):
  48933. (NPDeallocateCalledBeforeNPShutdown::shutdown):
  48934. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  48935. (NP_Shutdown):
  48936. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  48937. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  48938. * GNUmakefile.am:
  48939. 2011-03-15 Ilya Sherman <isherman@chromium.org>
  48940. Reviewed by Tony Chang.
  48941. Autofilled form elements are assigned fixed background color but not text color
  48942. https://bugs.webkit.org/show_bug.cgi?id=48382
  48943. * DumpRenderTree/LayoutTestController.cpp:
  48944. (setAutofilledCallback): Added.
  48945. (LayoutTestController::staticFunctions):
  48946. * DumpRenderTree/LayoutTestController.h:
  48947. * DumpRenderTree/chromium/LayoutTestController.cpp:
  48948. (LayoutTestController::LayoutTestController):
  48949. (LayoutTestController::setAutofilled): Added.
  48950. * DumpRenderTree/chromium/LayoutTestController.h:
  48951. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  48952. (LayoutTestController::setAutofilled): Added.
  48953. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  48954. (LayoutTestController::setAutofilled): Added.
  48955. (LayoutTestController::setValueForUser): Style tweak.
  48956. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  48957. (LayoutTestController::setAutofilled): Added (stub).
  48958. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  48959. (LayoutTestController::setAutofilled): Added (stub).
  48960. 2011-03-15 Dan Bernstein <mitz@apple.com>
  48961. Build fix after r81135.
  48962. * TestWebKitAPI/Configurations/InjectedBundle.xcconfig:
  48963. 2011-03-15 Dan Bernstein <mitz@apple.com>
  48964. Build fix after r81135.
  48965. * WebKitTestRunner/Configurations/InjectedBundle.xcconfig:
  48966. * WebKitTestRunner/mac/TestControllerMac.mm:
  48967. * WebKitTestRunner/mac/TestInvocationMac.mm:
  48968. * WebKitTestRunner/mac/main.mm:
  48969. 2011-03-15 Balazs Kelemen <kbalazs@webkit.org>
  48970. Reviewed by Adam Barth.
  48971. REGRESSION(80977): breaks Qt ARMv7 Linux Release bot
  48972. https://bugs.webkit.org/show_bug.cgi?id=56349
  48973. * QtTestBrowser/QtTestBrowser.pro: Link against fontconfig
  48974. on platforms where we use it. Copied from DumpRenderTree.pro.
  48975. 2011-03-15 Dan Bernstein <mitz@apple.com>
  48976. Build fix after r81135.
  48977. * DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
  48978. * DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
  48979. 2011-03-15 Kevin Ollivier <kevino@theolliviers.com>
  48980. Reviewed by Darin Adler.
  48981. Introduce WTF_USE_EXPORT_MACROS, which will allow us to put shared library import/export
  48982. info into the headers rather than in export symbol definition files, but disable it on
  48983. all platforms initially so we can deal with port build issues one port at a time.
  48984. https://bugs.webkit.org/show_bug.cgi?id=27551
  48985. * DumpRenderTree/cg/ImageDiffCG.cpp:
  48986. * DumpRenderTree/chromium/config.h:
  48987. * DumpRenderTree/config.h:
  48988. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  48989. * TestWebKitAPI/TestWebKitAPIPrefix.h:
  48990. * WebKitAPITest/HostWindow.cpp:
  48991. * WebKitAPITest/TestsController.cpp:
  48992. * WebKitAPITest/config.h: Added.
  48993. * WebKitAPITest/main.cpp:
  48994. * WebKitAPITest/tests/WebViewDestruction.cpp:
  48995. * WebKitTestRunner/InjectedBundle/Bindings/JSWrapper.cpp:
  48996. * WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
  48997. * WebKitTestRunner/InjectedBundle/GCController.cpp:
  48998. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  48999. * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
  49000. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  49001. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  49002. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  49003. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
  49004. * WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
  49005. * WebKitTestRunner/InjectedBundle/win/ActivateFonts.cpp:
  49006. * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
  49007. * WebKitTestRunner/InjectedBundle/win/LayoutTestControllerWin.cpp:
  49008. * WebKitTestRunner/TestController.cpp:
  49009. * WebKitTestRunner/TestInvocation.cpp:
  49010. * WebKitTestRunner/config.h: Added.
  49011. * WebKitTestRunner/qt/PlatformWebViewQt.cpp:
  49012. * WebKitTestRunner/qt/TestControllerQt.cpp:
  49013. * WebKitTestRunner/qt/TestInvocationQt.cpp:
  49014. * WebKitTestRunner/qt/main.cpp:
  49015. * WebKitTestRunner/win/PlatformWebViewWin.cpp:
  49016. * WebKitTestRunner/win/TestControllerWin.cpp:
  49017. * WebKitTestRunner/win/TestInvocationWin.cpp:
  49018. * WebKitTestRunner/win/main.cpp:
  49019. * wx/build/settings.py:
  49020. 2011-03-15 Hayato Ito <hayato@chromium.org>
  49021. Reviewed by Shinichiro Hamaji.
  49022. [NRWT] Add support for reftests to new-run-webkit-tests.
  49023. https://bugs.webkit.org/show_bug.cgi?id=55457
  49024. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  49025. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  49026. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
  49027. * Scripts/webkitpy/layout_tests/port/base.py:
  49028. * Scripts/webkitpy/layout_tests/port/dryrun.py:
  49029. * Scripts/webkitpy/layout_tests/port/test.py:
  49030. * Scripts/webkitpy/layout_tests/port/test_files.py:
  49031. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  49032. 2011-03-15 Alejandro G. Castro <alex@igalia.com>
  49033. Reviewed by Martin Robinson.
  49034. [GTK] Fix compilation warning after r80892
  49035. https://bugs.webkit.org/show_bug.cgi?id=56302
  49036. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49037. (LayoutTestController::originsWithLocalStorage):
  49038. 2011-03-15 Robert Hogan <robert@webkit.org>
  49039. Reviewed by Adam Barth.
  49040. Document the qmakearg argument, and hint how to build webkit2 on Qt
  49041. https://bugs.webkit.org/show_bug.cgi?id=56326
  49042. * Scripts/build-webkit: add --qmakearg to build-webkit --help
  49043. 2011-03-15 Adam Roben <aroben@apple.com>
  49044. Make Windows 7 Release (Tests) a core builder
  49045. We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
  49046. give it a few more days of greenness first.
  49047. Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
  49048. Reviewed by Sam Weinig.
  49049. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  49050. (BuildBot): Added a regexp to match Windows 7 Release (Tests).
  49051. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  49052. (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
  49053. Updated the core regexps to match the buildbot module. Updated the expected results to match
  49054. the current set of core builders.
  49055. 2011-03-14 Adam Roben <aroben@apple.com>
  49056. Add forgotten file from r81116
  49057. * TestWebKitAPI/Configurations/TestWebKitAPICFNetwork.vsprops: Added.
  49058. 2011-03-14 Sam Weinig <sam@webkit.org>
  49059. Reviewed by Adam Roben.
  49060. about:blank fake responses don't get serialized when sent the UIProcess
  49061. <rdar://problem/9108119>
  49062. https://bugs.webkit.org/show_bug.cgi?id=56357
  49063. * TestWebKitAPI/Tests/WebKit2/AboutBlankLoad.cpp: Added.
  49064. (TestWebKitAPI::decidePolicyForResponse):
  49065. (TestWebKitAPI::TEST):
  49066. Add test that loads of about:blank have a response with a MIMEType of text/html.
  49067. * TestWebKitAPI/PlatformUtilities.h:
  49068. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  49069. (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
  49070. * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
  49071. (TestWebKitAPI::Util::MIMETypeForWKURLResponse):
  49072. Add helper to get the MIMEType from a WKURLResponse.
  49073. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  49074. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  49075. Add new files.
  49076. 2011-03-14 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
  49077. Reviewed by Kenneth Rohde Christiansen.
  49078. [Qt] Command-line options for QGLWidget and WebGL to QtTestBrowser
  49079. https://bugs.webkit.org/show_bug.cgi?id=56006
  49080. * QtTestBrowser/launcherwindow.cpp:
  49081. (LauncherWindow::initializeView):
  49082. * QtTestBrowser/main.cpp:
  49083. (LauncherApplication::handleUserOptions):
  49084. 2011-03-14 James Kozianski <koz@chromium.org>
  49085. Reviewed by Ojan Vafai.
  49086. Add method to make BuildBot return test outputs
  49087. https://bugs.webkit.org/show_bug.cgi?id=54374
  49088. The Builder.latest_cached_build will be used by the new rebaseline
  49089. script to determine the build to use baselines from.
  49090. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  49091. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  49092. 2011-03-14 Adam Roben <aroben@apple.com>
  49093. Test that WKBundlePageCanHandleRequest returns true for empty document URLs
  49094. Reviewed by Sam Weinig.
  49095. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest.cpp: Added.
  49096. (TestWebKitAPI::didReceiveMessageFromInjectedBundle): Store the result of the test.
  49097. (TestWebKitAPI::setInjectedBundleClient): Hook up our callback.
  49098. (TestWebKitAPI::TEST): Register "emptyscheme" as an empty document scheme, load a page to
  49099. ensure the web process is initialized, then ask the bundle to run the test and assert that
  49100. it succeeded.
  49101. * TestWebKitAPI/Tests/WebKit2/CanHandleRequest_Bundle.cpp: Added.
  49102. (TestWebKitAPI::CanHandleRequestTest::CanHandleRequestTest): Just call up to the base class.
  49103. (TestWebKitAPI::canHandleURL): Helper function to test whether WebKit2 claims to be able to
  49104. handle a given URL.
  49105. (TestWebKitAPI::runTest): Check that empty document URLs can be handled (and that an unknown
  49106. URL type cannot be handled).
  49107. (TestWebKitAPI::CanHandleRequestTest::didReceiveMessage): Run the test and return the
  49108. result.
  49109. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  49110. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  49111. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  49112. Added new files to the project.
  49113. 2011-03-14 Sheriff Bot <webkit.review.bot@gmail.com>
  49114. Unreviewed, rolling out r81094.
  49115. http://trac.webkit.org/changeset/81094
  49116. https://bugs.webkit.org/show_bug.cgi?id=56355
  49117. Broke the chromium DRT related build. (Requested by dave_levin
  49118. on #webkit).
  49119. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  49120. (main):
  49121. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49122. (LayoutTestController::LayoutTestController):
  49123. (LayoutTestController::layerTreeAsText):
  49124. * DumpRenderTree/chromium/LayoutTestController.h:
  49125. * DumpRenderTree/chromium/TestShell.cpp:
  49126. (TestShell::runFileTest):
  49127. (TestShell::dump):
  49128. * DumpRenderTree/chromium/TestShell.h:
  49129. (TestParams::TestParams):
  49130. 2011-03-14 Daniel Sievers <sievers@google.com>
  49131. Reviewed by Simon Fraser.
  49132. [Chromium] Make RenderAsTextBehavior and LayerTreeAsTextBehavior tweakable from the DumpRenderTree commandline
  49133. https://bugs.webkit.org/show_bug.cgi?id=56139
  49134. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  49135. (main):
  49136. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49137. (LayoutTestController::LayoutTestController):
  49138. (LayoutTestController::layerTreeAsText):
  49139. * DumpRenderTree/chromium/LayoutTestController.h:
  49140. (LayoutTestController::setShowDebugLayerTree):
  49141. * DumpRenderTree/chromium/TestShell.cpp:
  49142. (TestShell::runFileTest):
  49143. (TestShell::dump):
  49144. * DumpRenderTree/chromium/TestShell.h:
  49145. (TestParams::TestParams):
  49146. 2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
  49147. Reviewed by Adam Roben.
  49148. [Qt][WK2]Unbreak InjectedBundle on Qt
  49149. https://bugs.webkit.org/show_bug.cgi?id=54109
  49150. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  49151. (WTR::InjectedBundlePage::willSendRequestForFrame): Use new WebKit2
  49152. API's instead of KURL to analyze the URL.
  49153. * WebKitTestRunner/StringFunctions.h:
  49154. (WTR::adoptWK): Moved from InjectedBundlePage.cpp to make it available globally
  49155. in the WebKitTestRunner project.
  49156. (WTR::toWK): Use adoptWK.
  49157. (WTR::operator<<): Added helper for printing a WKURL.
  49158. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Do not link
  49159. against WebCore.
  49160. 2011-03-14 Balazs Kelemen <kbalazs@webkit.org>
  49161. Reviewed by Kenneth Rohde Christiansen.
  49162. check-webkit-style falsely should not complain about WebKit2 API headers in the Shared directory
  49163. https://bugs.webkit.org/show_bug.cgi?id=56321
  49164. * Scripts/webkitpy/style/checker.py: Add the patch "Source/WebKit2/Shared/API/c"
  49165. to the list of exceptions for WebKit2 C API headers.
  49166. 2011-03-14 Adam Roben <aroben@apple.com>
  49167. Show the list of recent leaky builds in reverse chronological order
  49168. Previously they were being shown in a deterministic but surprising order based on
  49169. lexicographically sorting the build offsets (-1, -10, -2, -3...).
  49170. Fixes <http://webkit.org/b/56342> Leaks Viewer shows recent builds in a strange order
  49171. Reviewed by Darin Adler.
  49172. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  49173. (RecentBuildsLoader.prototype.start): Sort the builds by revision before passing them to our
  49174. callback.
  49175. 2011-03-14 Adam Roben <aroben@apple.com>
  49176. Show a list of up to 10 recent leaky builds when Leaks Viewer loads
  49177. Fixes <http://webkit.org/b/56043> Leaks Viewer should present a list of recent builds to
  49178. analyze
  49179. Reviewed by David Kilzer and Joe Pecoraro.
  49180. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
  49181. (#url-prompt): Made this a bit taller to make room for the list of builds.
  49182. (#recent-builds-loading-indicator):
  49183. (#recent-builds-list):
  49184. Added styles for the build list and loading indicator.
  49185. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
  49186. (LeaksViewer.loaded): Pass the URL from the query through decodeURIComponent before loading
  49187. it. This will unescape it.
  49188. (LeaksViewer.urlPromptButtonClicked): Moved code from here to _urlChosenFromPrompt.
  49189. (LeaksViewer._didLoadRecentBuilds): Added. Stores the builds and updates the prompt.
  49190. (LeaksViewer._displayURLPrompt): Start loading the recent leaky builds.
  49191. (LeaksViewer._updateURLPrompt): Create a list of the recent leaky builds and add them to the
  49192. prompt UI.
  49193. (LeaksViewer._urlChosenFromPrompt): Added. Code came from urlPromptButtonClicked. This is
  49194. now also used when a recent build is clicked.
  49195. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js: Added.
  49196. (RecentBuildsLoader): Store the callback.
  49197. (RecentBuildsLoader.prototype.start): Load the N most recent builds from the specified
  49198. builder. Find the revision number, leak count, and results URL for each one. Pass the
  49199. resulting info to our callback.
  49200. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
  49201. (range): Added this helper function to return an array containing the integers [0, n).
  49202. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added
  49203. RecentBuildsLoader.js and added text to the prompt UI to show the recent builds.
  49204. 2011-03-14 Mark Rowe <mrowe@apple.com>
  49205. Reviewed by Adam Roben.
  49206. Fix two memory leaks within LayoutTestController's storage support.
  49207. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49208. (LayoutTestController::originsWithLocalStorage): Don't leak the JSStringRef that is returned
  49209. by JSStringCreateWithCFString.
  49210. (LayoutTestController::deleteLocalStorageForOrigin): Don't leak the WebSecurityOrigin that we
  49211. allocate.
  49212. 2011-03-14 Mark Rowe <mrowe@apple.com>
  49213. Reviewed by Oliver Hunt.
  49214. <http://webkit.org/b/56304> REGRESSION(r80892): 100,000+ leaks seen on the build bot
  49215. * DumpRenderTree/LayoutTestController.cpp:
  49216. (LayoutTestController::staticFunctions): Remove duplicate entries.
  49217. 2011-03-14 Alice Liu <alice.liu@apple.com>
  49218. Reviewed by Dan Bernstein.
  49219. DumpRenderTree Perl Support fails to build with ARCHS="i386 x86_64"
  49220. * DumpRenderTree/mac/PerlSupport/Makefile:
  49221. Add whitespace when joining "-arch" with the architectures passed in as arguments.
  49222. 2011-03-14 Daniel Bates <dbates@rim.com>
  49223. https://bugs.webkit.org/show_bug.cgi?id=55438
  49224. Add double quotes around value of -DCMAKE_WINCE_SDK that I inadvertently did not add
  49225. when landing changeset 81041 <http://trac.webkit.org/changeset/81041>.
  49226. * Scripts/build-webkit:
  49227. 2011-03-14 Daniel Bates <dbates@rim.com>
  49228. Reviewed by David Kilzer.
  49229. Cleanup: Separate port-specific implementation details from webkitdirs::buildCMakeProject()
  49230. https://bugs.webkit.org/show_bug.cgi?id=55438
  49231. Separate out the EFL- and WinCE-specific logic from the port-independent logic in
  49232. webkitdirs::buildCMakeProject(). Also, remove redundant code for generating the
  49233. CMake arguments for feature defines.
  49234. * Scripts/build-webkit:
  49235. - Added cMakeArgsFromFeatures() to convert the @features array to CMake arguments.
  49236. - Modified EFL and WinCE-specific building logic to call buildCMakeProjectOrExit().
  49237. - Sorted forward declarations.
  49238. - Initialize $makeArgs with the empty string so as to simplify its use in string operations;
  49239. Modified call sites as needed.
  49240. * Scripts/webkitdirs.pm:
  49241. - Added cleanCMakeGeneratedProject() to clean a CMake build.
  49242. - Added buildCMakeGeneratedProject() to build using generated build system.
  49243. - Added buildCMakeProjectOrExit() which is a facade for building a CMake project.
  49244. - Added generateBuildSystemFromCMakeProject() to generate the build system from
  49245. a CMake project.
  49246. - Removed buildCMakeProject(). This functionality is in buildCMakeProjectOrExit().
  49247. 2011-03-14 John Knottenbelt <jknotten@chromium.org>
  49248. Reviewed by Steve Block.
  49249. Detach Geolocation from Frame when Page destroyed.
  49250. https://bugs.webkit.org/show_bug.cgi?id=52877
  49251. Extend the layout test controller to expose the number of pending
  49252. geolocation requests, so that we can test that the requests have
  49253. been cancelled on page close.
  49254. * DumpRenderTree/LayoutTestController.cpp:
  49255. (numberOfPendingGeolocationPermissionRequestsCallback):
  49256. (LayoutTestController::staticFunctions):
  49257. * DumpRenderTree/LayoutTestController.h:
  49258. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49259. (LayoutTestController::LayoutTestController):
  49260. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49261. * DumpRenderTree/chromium/LayoutTestController.h:
  49262. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49263. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49264. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49265. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49266. * DumpRenderTree/mac/UIDelegate.h:
  49267. * DumpRenderTree/mac/UIDelegate.mm:
  49268. (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  49269. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  49270. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49271. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  49272. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  49273. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49274. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  49275. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49276. 2011-03-14 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  49277. Unreviewed. Modify my email address in committers.py.
  49278. * Scripts/webkitpy/common/config/committers.py:
  49279. 2011-03-13 Joe Wild <joseph.wild@nokia.com>
  49280. Reviewed by Kenneth Rohde Christiansen.
  49281. [Qt] QtLauncher does not load the same set of fonts as the DRT
  49282. https://bugs.webkit.org/show_bug.cgi?id=34959
  49283. This patch adds the option "-use-test-fonts" to the QtTestBrowser.
  49284. When this option is used the webkit fonts are loaded the same
  49285. as they are in DumpRenderTree. This option can be used on
  49286. QtTestBrowser and run-launcher. It can only be used
  49287. on Linux systems with FcInit and is configured as such.
  49288. * QtTestBrowser/launcherwindow.h:
  49289. (WindowOptions::WindowOptions):
  49290. * QtTestBrowser/main.cpp:
  49291. (initWebKitTestFonts):
  49292. (launcherMain):
  49293. (LauncherApplication::handleUserOptions):
  49294. 2011-03-12 Dan Bernstein <mitz@apple.com>
  49295. Reviewed by Mark Rowe.
  49296. <rdar://problem/8995822> Build DumpRenderTree perl support only for the architectures
  49297. DumpRenderTree is being built for.
  49298. * DumpRenderTree/mac/PerlSupport/Makefile:
  49299. 2011-03-12 Dan Bernstein <mitz@apple.com>
  49300. Suggested by Mark Rowe.
  49301. * DumpRenderTree/mac/Configurations/Base.xcconfig: Leave C++ exceptions enabled
  49302. as they were before r80915.
  49303. 2011-03-12 Anders Carlsson <andersca@apple.com>
  49304. Reviewed by Sam Weinig.
  49305. Should be able to download a PDF to the Downloads folder
  49306. https://bugs.webkit.org/show_bug.cgi?id=56256
  49307. * MiniBrowser/mac/BrowserWindowController.m:
  49308. (-[BrowserWindowController awakeFromNib]):
  49309. * WebKitTestRunner/TestController.cpp:
  49310. (WTR::TestController::createOtherPage):
  49311. (WTR::TestController::initialize):
  49312. Update for API changes.
  49313. 2011-03-11 Anton D'Auria <adauria@apple.com>
  49314. Reviewed and landed by Brady Eidson.
  49315. https://bugs.webkit.org/show_bug.cgi?id=51878
  49316. Add WebKit1 API to view and delete local storage
  49317. Added tests that write to LocalStorage, delete one origin, get list of origins with local storage, delete all origins.
  49318. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  49319. * DumpRenderTree/LayoutTestController.cpp:
  49320. (syncLocalStorageCallback):
  49321. (observeStorageTrackerNotificationsCallback):
  49322. (deleteAllLocalStorageCallback):
  49323. (deleteLocalStorageForOriginCallback):
  49324. (originsWithLocalStorageCallback):
  49325. (LayoutTestController::staticFunctions):
  49326. * DumpRenderTree/LayoutTestController.h:
  49327. * DumpRenderTree/StorageTrackerDelegate.h: Added.
  49328. * DumpRenderTree/StorageTrackerDelegate.mm: Added.
  49329. (-[StorageTrackerDelegate init]):
  49330. (-[StorageTrackerDelegate logNotifications:controller:]):
  49331. (-[StorageTrackerDelegate originModified:]):
  49332. (-[StorageTrackerDelegate dealloc]):
  49333. (-[StorageTrackerDelegate setControllerToNotifyDone:]):
  49334. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49335. (LayoutTestController::LayoutTestController):
  49336. (LayoutTestController::deleteAllLocalStorage):
  49337. (LayoutTestController::originsWithLocalStorage):
  49338. (LayoutTestController::deleteLocalStorageForOrigin):
  49339. (observeStorageTrackerNotifications):
  49340. (syncLocalStorage):
  49341. * DumpRenderTree/chromium/LayoutTestController.h:
  49342. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49343. (LayoutTestController::originsWithLocalStorage):
  49344. (LayoutTestController::deleteAllLocalStorage):
  49345. (LayoutTestController::deleteLocalStorageForOrigin):
  49346. (LayoutTestController::observeStorageTrackerNotifications):
  49347. (LayoutTestController::syncLocalStorage):
  49348. * DumpRenderTree/mac/DumpRenderTree.mm:
  49349. (resetDefaultsToConsistentValues):
  49350. (allocateGlobalControllers):
  49351. (releaseGlobalControllers):
  49352. * DumpRenderTree/mac/DumpRenderTreeMac.h:
  49353. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49354. (LayoutTestController::syncLocalStorage):
  49355. (LayoutTestController::observeStorageTrackerNotifications):
  49356. (LayoutTestController::deleteAllLocalStorage):
  49357. (LayoutTestController::originsWithLocalStorage):
  49358. (LayoutTestController::deleteLocalStorageForOrigin):
  49359. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  49360. (LayoutTestController::originsWithLocalStorage):
  49361. (LayoutTestController::deleteAllLocalStorage):
  49362. (LayoutTestController::deleteLocalStorageForOrigin):
  49363. (LayoutTestController::observeStorageTrackerNotifications):
  49364. (LayoutTestController::syncLocalStorage):
  49365. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  49366. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  49367. (LayoutTestController::clearAllApplicationCaches):
  49368. (LayoutTestController::syncLocalStorage):
  49369. (LayoutTestController::observeStorageTrackerNotifications):
  49370. (LayoutTestController::clearAllDatabases):
  49371. (LayoutTestController::deleteAllLocalStorage):
  49372. (LayoutTestController::originsWithLocalStorage):
  49373. (LayoutTestController::deleteLocalStorageForOrigin):
  49374. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  49375. (LayoutTestController::syncLocalStorage):
  49376. (LayoutTestController::observeStorageTrackerNotifications):
  49377. (LayoutTestController::clearAllDatabases):
  49378. (LayoutTestController::deleteAllLocalStorage):
  49379. (LayoutTestController::originsWithLocalStorage):
  49380. (LayoutTestController::deleteLocalStorageForOrigin):
  49381. 2011-03-11 Jessie Berlin <jberlin@apple.com>
  49382. Reviewed by Adam Roben.
  49383. Crash calling WebContext::clearResourceCaches(InMemoryResourceCachesOnly) before the Web
  49384. Process has finished launching.
  49385. https://bugs.webkit.org/show_bug.cgi?id=56208
  49386. * TestWebKitAPI/Tests/WebKit2/SendingMessagesToTheWebProcessBeforeItIsValid.cpp: Added.
  49387. (TestWebKitAPI::TEST):
  49388. Test that calling WKContextClearResourceCaches works with both options when called before
  49389. the Web Process is valid.
  49390. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  49391. Add the new test.
  49392. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  49393. Ditto.
  49394. 2011-03-11 Adam Roben <aroben@apple.com>
  49395. Make it possible to view all leaks from a build at once in Leaks Viewer
  49396. You can now give Leaks Viewer the URL of a build results page (e.g.,
  49397. <http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80847%20(15493)/>), and it
  49398. will load all the leaks files from that build.
  49399. Fixes <http://webkit.org/b/56030> Leaks Viewer: Would like to be able to look at all leaks
  49400. files from a particular build at once, rather than one at a time
  49401. Reviewed by David Kilzer.
  49402. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksLoader.js: Added.
  49403. (LeaksLoader): Initialize our properties.
  49404. (LeaksLoader.prototype.start): If the URL ends in .txt, assume it's a single leaks file and
  49405. load it. Otherwise assume it's a build results page URL and start fetching the leaks files
  49406. from that page.
  49407. (LeaksLoader.prototype._loadLeaksFiles): Tell our client how many leaks files we're loading
  49408. so it can provide feedback. Then load each one and pass it to the client.
  49409. (LeaksLoader.prototype._loadLeaksFromResultsPage): Load the HTML of the results page, parse
  49410. it into a DOM, pull out all the links to leaks files, and load each one.
  49411. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js: Added.
  49412. (LeaksParser): Initialize our worker.
  49413. (LeaksParser.prototype.addLeaksFile): Tell the worker about the leaks file's contents.
  49414. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js: Added.
  49415. This code mostly came from Worker.js.
  49416. (LeaksParserWorker): Initialize our profile.
  49417. (LeaksParserWorker.prototype.addLeaksFile): Parse the leaks file and incorporate it into our
  49418. profile.
  49419. (LeaksParserWorker.prototype._parseLeaks):
  49420. (LeaksParserWorker.prototype._createNode):
  49421. (LeaksParserWorker.prototype._incorporateLeaks):
  49422. Moved these functions here from LeaksViewer. _incorporateLeaks is essentially just a renamed
  49423. version of createProfile which adds to this.profile instead of making a new profile each
  49424. time.
  49425. (onmessage): Parse the file and send back the new profile.
  49426. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
  49427. (#loading-indicator):
  49428. (#spinner):
  49429. (#loading-indicator-label):
  49430. Tweaked styles to accomodate a longer label.
  49431. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
  49432. (LeaksViewer.loaded): Set up a loader and parser.
  49433. (LeaksViewer.get filesLeftToParse):
  49434. (LeaksViewer.set filesLeftToParse):
  49435. Added these simple accessors.
  49436. (LeaksViewer._didCountLeaksFiles): Callback from LeaksLoader. Stores the count.
  49437. (LeaksViewer._didLoadLeaksFile): Callback from LeaksLoader. Passes the file contents off to
  49438. the parser.
  49439. (LeaksViewer._didParseLeaksFile): Callback from LeaksParser. If all files have been parsed,
  49440. tell the ProfilerAgent and mark that we're done loading. (Code came from the old
  49441. _loadLeaksFromURL function).
  49442. (LeaksViewer._loadLeaksFromURL): Now just calls through to the loader.
  49443. (LeaksViewer._loadingIndicatorText): Added. Returns the text that should show up in the
  49444. loading indicator, including the number of files being loaded.
  49445. (LeaksViewer._loadingStatusChanged): Update the loading indicator's label, too.
  49446. (LeaksViewer._updateLoadingIndicatorLabel): Added. Just updates the label!
  49447. (LeaksViewer._updateTitle): Moved code to compute the "Loading" text to
  49448. _loadingIndicatorText.
  49449. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js: Added.
  49450. (getResource): Moved here from LeaksViewer.js.
  49451. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Subsumed by
  49452. LeaksParserWorker.js.
  49453. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added new JS
  49454. files, added a #loading-indicator-label element, and tweaked the prompt wording.
  49455. 2011-03-11 Adam Roben <aroben@apple.com>
  49456. Don't trigger a build when build.webkit.org's HTML files are modified
  49457. Fixes <http://webkit.org/b/56190> Windows bots shouldn't have built r80848/r80851, but did
  49458. Reviewed by Dan Bernstein.
  49459. * Scripts/webkitpy/common/config/build.py:
  49460. (_should_file_trigger_build): Added build.webkit.org's public_html directory to the list of
  49461. directories that shouldn't trigger builds. Re-sorted the list.
  49462. * Scripts/webkitpy/common/config/build_unittest.py:
  49463. (ShouldBuildTest): Added a test to cover the above change.
  49464. 2011-03-11 Adam Roben <aroben@apple.com>
  49465. Roll out r80848
  49466. It was accidentally committed.
  49467. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
  49468. (LeaksViewer._loadLeaksFromURL):
  49469. 2011-03-11 Tony Chang <tony@chromium.org>
  49470. Reviewed by Ojan Vafai.
  49471. kill hung lighttpd processes on the chromium win bot
  49472. https://bugs.webkit.org/show_bug.cgi?id=56152
  49473. Sometimes this process doesn't exit and it holds on to
  49474. a log file that we can't delete or copy, causing the tests
  49475. to go red.
  49476. * BuildSlaveSupport/win/kill-old-processes:
  49477. 2011-03-11 Ilya Sherman <isherman@chromium.org>
  49478. Reviewed by Kent Tamura.
  49479. [Chromium] missing HTMLInputElement::setValueForUser() to tests
  49480. https://bugs.webkit.org/show_bug.cgi?id=55854
  49481. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49482. (LayoutTestController::LayoutTestController):
  49483. (LayoutTestController::setValueForUser): Added.
  49484. * DumpRenderTree/chromium/LayoutTestController.h:
  49485. 2011-03-10 Peter Kasting <pkasting@google.com>
  49486. Reviewed by Dimitri Glazkov.
  49487. Clean up some gross code in TestShellWin.cpp. No functional change.
  49488. https://bugs.webkit.org/show_bug.cgi?id=56048
  49489. * DumpRenderTree/chromium/TestShellWin.cpp:
  49490. (checkLayoutTestSystemDependencies):
  49491. 2011-03-10 Keith Kyzivat <keith.kyzivat@nokia.com>
  49492. Reviewed by Laszlo Gombos.
  49493. [Qt] Buildfix for platforms where X11 is not available (e.g. Symbian)
  49494. * WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
  49495. (WTR::activateFonts): Guard X11-specific code with Q_WS_X11.
  49496. 2011-03-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  49497. Reviewed by Kenneth Rohde Christiansen.
  49498. [EFL] Make single backing store the default for EWebLauncher
  49499. https://bugs.webkit.org/show_bug.cgi?id=55753
  49500. Set single backing store the default for EWebLauncher.
  49501. * EWebLauncher/main.c:
  49502. (main):
  49503. 2011-03-10 Adam Roben <aroben@apple.com>
  49504. Ignore errors from files being held open when creating a test result archive
  49505. Fixes <http://webkit.org/b/55581> Test results don't get uploaded if test-result-archive
  49506. fails to delete the results directory
  49507. Reviewed by Mark Rowe.
  49508. * BuildSlaveSupport/test-result-archive:
  49509. (archiveTestResults): Ignore errno 2 when deleting the results directory, since it can be
  49510. thrown when a process is holding a file open.
  49511. 2011-03-10 Sheriff Bot <webkit.review.bot@gmail.com>
  49512. Unreviewed, rolling out r80701.
  49513. http://trac.webkit.org/changeset/80701
  49514. https://bugs.webkit.org/show_bug.cgi?id=56126
  49515. fast/dom/Geolocation/window-close-crash.html fails on Snow
  49516. Leopard release builds (Requested by mihaip on #webkit).
  49517. * DumpRenderTree/LayoutTestController.cpp:
  49518. (LayoutTestController::staticFunctions):
  49519. * DumpRenderTree/LayoutTestController.h:
  49520. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49521. (LayoutTestController::LayoutTestController):
  49522. * DumpRenderTree/chromium/LayoutTestController.h:
  49523. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49524. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49525. * DumpRenderTree/mac/UIDelegate.h:
  49526. * DumpRenderTree/mac/UIDelegate.mm:
  49527. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  49528. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  49529. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  49530. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  49531. 2011-03-10 Philippe Normand <pnormand@igalia.com>
  49532. Reviewed by Gustavo Noronha Silva.
  49533. [GTK] run-gtk-tests doesn't fail if a test crashes
  49534. https://bugs.webkit.org/show_bug.cgi?id=56089
  49535. * Scripts/run-gtk-tests: gtester -k exits with a 0 exit status
  49536. even if a test crashes. So run the tests individually and if a
  49537. test fails remember its exit code so run-gtk-test fails too, if
  49538. required.
  49539. 2011-01-26 John Knottenbelt <jknotten@chromium.org>
  49540. Reviewed by Dmitry Titov.
  49541. Detach Geolocation from Frame when Page destroyed.
  49542. https://bugs.webkit.org/show_bug.cgi?id=52877
  49543. Extend the layout test controller to expose the number of pending
  49544. geolocation requests, so that we can test that the requests have
  49545. been cancelled on page close.
  49546. * DumpRenderTree/LayoutTestController.cpp:
  49547. (numberOfPendingGeolocationPermissionRequestsCallback):
  49548. (LayoutTestController::staticFunctions):
  49549. * DumpRenderTree/LayoutTestController.h:
  49550. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49551. (LayoutTestController::LayoutTestController):
  49552. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49553. * DumpRenderTree/chromium/LayoutTestController.h:
  49554. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49555. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49556. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49557. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49558. * DumpRenderTree/mac/UIDelegate.h:
  49559. * DumpRenderTree/mac/UIDelegate.mm:
  49560. (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  49561. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  49562. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49563. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  49564. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  49565. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49566. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  49567. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  49568. 2011-03-09 Adam Roben <aroben@apple.com>
  49569. Hide Leaks Viewer's URL prompt by default
  49570. We will show it as needed. I think I left it visible by default by accident after doing some
  49571. testing.
  49572. Fixes <http://webkit.org/b/56031> Leaks Viewer: URL prompt overlay shouldn't appear when a
  49573. URL is passed as a query parameter, but does
  49574. Reviewed by Simon Fraser.
  49575. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
  49576. 2011-03-09 Adam Roben <aroben@apple.com>
  49577. Don't use Element.classList or box-shadow in Leaks Viewer
  49578. They aren't supported by Safari 5. Luckily we have substitutes for them!
  49579. Fixes <http://webkit.org/b/56035> Leaks viewer doesn't work in Safari 5
  49580. Reviewed by Simon Fraser.
  49581. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css:
  49582. (#url-prompt): Use -webkit-box-shadow instead of box-shadow.
  49583. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js:
  49584. (LeaksViewer.urlPromptButtonClicked):
  49585. (LeaksViewer._displayURLPrompt):
  49586. (LeaksViewer._setLoadingIndicatorHidden):
  49587. Use add/removeStyleClass (from utilities.js) instead of Element.classList.
  49588. 2011-03-09 Adam Roben <aroben@apple.com>
  49589. Add a link to the Leaks Viewer tool on the build.webkit.org homepage
  49590. Rubber-stamped by David Kilzer.
  49591. * BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  49592. 2011-03-09 Adam Roben <aroben@apple.com>
  49593. Add a Leaks Viewer tool to build.webkit.org
  49594. This tool parses leaks from the files generated by the leaks bot and displays them in a
  49595. view similar to the Web Inspector's Profiles pane (in fact, it uses the Web Inspector's
  49596. code).
  49597. The URL of the leaks file can be entered in a prompt when the tools is first shown, or can
  49598. be passed to the tool via the "url" query parameter.
  49599. Only one leaks file can be viewed at a time for now. Only the number of leaks, as opposed to
  49600. the number of leaked bytes, is shown. And this tool has made apparent some bugs in the Web
  49601. Inspector's Heavy profile view. But it's still pretty useful as-is.
  49602. Fixes <http://webkit.org/b/56028> Would like a Shark-like tool for viewing leaks from leak bots
  49603. Reviewed by Darin Adler.
  49604. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.css: Added.
  49605. (#url-prompt-container): This is the dark overlay that is shown behind the URL prompt.
  49606. (#url-prompt): This is the prompt itself.
  49607. (#loading-indicator):
  49608. (#loading-indicator > img):
  49609. These show a spinner in the bottom-right when we're loading a leaks file.
  49610. (.percent-time-status-bar-item): Hide the Percent button since we never want to show leaks
  49611. as percentages.
  49612. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksViewer.js: Added.
  49613. (LeaksViewer.loaded): Initialize ourselves and start loading the leaks file (or prompt for a
  49614. URL if one wasn't given to us as a query parameter).
  49615. (LeaksViewer.get loading):
  49616. (LeaksViewer.set loading):
  49617. (LeaksViewer.get url):
  49618. (LeaksViewer.set url):
  49619. Pretty simple accessors.
  49620. (LeaksViewer.urlPromptButtonClicked): Start loading the URL from the prompt and hide the
  49621. prompt.
  49622. (LeaksViewer._displayURLPrompt): Show the prompt and focus the URL input.
  49623. (LeaksViewer._loadLeaksFromURL): Start fetching the leaks file. When we've retrieved the
  49624. file, hand it off to a Web Worker that will parse it into a fake "profile", then hand off
  49625. the profile to the Web Inspector code once it's been created.
  49626. (LeaksViewer._loadingStatusChanged): Update our loading indicator and title.
  49627. (LeaksViewer._setLoadingIndicatorHidden): Simply hide or show the indicator.
  49628. (LeaksViewer._updateTitle): Set our title based on our URL and loading status.
  49629. (getResource): Helper function to fetch a resource via XHR and pass it to a callback.
  49630. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js: Added.
  49631. (WebInspector.UIString): Just a simple implementation since this tool isn't localized.
  49632. (ProfilerAgent.getProfile): Store the callback.
  49633. (ProfilerAgent.profileReady): Call the callback.
  49634. (monkeyPatchInspectorObjects): Fix up WebInspector.ProfileDataGridNode to show the self leak
  49635. count and total leak counts as real values, not percentages or milliseconds.
  49636. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Worker.js: Added.
  49637. (onmessage): Create a profile based on the leaks file and pass it back to our caller.
  49638. (parseLeaks): Extract call stacks out of a leaks file.
  49639. (createNode): Helper function to create a new empty profile node.
  49640. (createProfile): Take the leak stacks and turn them into a fake "profile" for consumption by
  49641. WebInspector.ProfileView.
  49642. * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html: Added.
  49643. 2011-03-09 Dan Bernstein <mitz@apple.com>
  49644. Reviewed by Adam Roben.
  49645. Combine multiple --ignore-tests values
  49646. https://bugs.webkit.org/show_bug.cgi?id=56016
  49647. * Scripts/old-run-webkit-tests:
  49648. 2011-03-08 Kenji Imasaki <imasaki@chromium.org>
  49649. Reviewed by David Levin.
  49650. Adding myself to the committer file.
  49651. * Scripts/webkitpy/common/config/committers.py:
  49652. 2011-03-08 Jessie Berlin <jberlin@apple.com>
  49653. Rubber-stamped by Adam Roben.
  49654. Fix two leaks I introduced into the API tests.
  49655. * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
  49656. (TestWebKitAPI::TEST):
  49657. 2011-03-08 Jessie Berlin <jberlin@apple.com>
  49658. Reviewed by Anders Carlsson.
  49659. Crash in CFNetwork visiting google.com
  49660. https://bugs.webkit.org/show_bug.cgi?id=55958
  49661. Add a test for not trying to copy a null CFURLResponse.
  49662. * TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp: Added.
  49663. (TestWebKitAPI::TEST):
  49664. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  49665. 2011-03-08 Hayato Ito <hayato@chromium.org>
  49666. Reviewed by Ojan Vafai.
  49667. [NRWT] Renamed a FailureWithType class to a ComparisonTestFailure class.
  49668. FailureWithType is a confusing naming because we have removed test_type/* classes in r79840.
  49669. https://bugs.webkit.org/show_bug.cgi?id=55450
  49670. * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
  49671. 2011-03-08 Carlos Garcia Campos <cgarcia@igalia.com>
  49672. Reviewed by Martin Robinson.
  49673. [GTK] Add layoutTestController.setValueForUser() after r80412
  49674. https://bugs.webkit.org/show_bug.cgi?id=55862
  49675. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49676. (LayoutTestController::setValueForUser): Implement setValueForUser()
  49677. 2011-03-08 Patrick Gansterer <paroga@webkit.org>
  49678. Reviewed by Adam Barth.
  49679. Add script_shell_command to WebKitPort
  49680. https://bugs.webkit.org/show_bug.cgi?id=55925
  49681. Add a central place where we generate the shell command from the script name.
  49682. This function will be used later to detect the correct script interpreter on Win32.
  49683. * Scripts/webkitpy/common/config/ports.py:
  49684. * Scripts/webkitpy/layout_tests/port/base.py:
  49685. * Scripts/webkitpy/tool/steps/abstractstep.py:
  49686. * Scripts/webkitpy/tool/steps/preparechangelog.py:
  49687. 2011-03-07 Ojan Vafai <ojan@chromium.org>
  49688. Reviewed by Adam Barth.
  49689. add webkit-patch attach-to-bug for posting to bugzilla from the commandline
  49690. https://bugs.webkit.org/show_bug.cgi?id=55749
  49691. * Scripts/webkitpy/tool/commands/upload.py:
  49692. * Scripts/webkitpy/tool/commands/upload_unittest.py:
  49693. * Scripts/webkitpy/tool/steps/__init__.py:
  49694. * Scripts/webkitpy/tool/steps/attachtobug.py: Added.
  49695. * Scripts/webkitpy/tool/steps/options.py:
  49696. 2011-03-07 Daniel Cheng <dcheng@chromium.org>
  49697. Reviewed by David Levin.
  49698. Add support for DataTransferItems
  49699. https://bugs.webkit.org/show_bug.cgi?id=55115
  49700. Enable data transfer items in DRT.
  49701. * DumpRenderTree/chromium/TestShell.cpp:
  49702. (TestShell::TestShell):
  49703. 2011-03-06 Ojan Vafai <ojan@chromium.org>
  49704. Reviewed by Tony Chang.
  49705. [test dashboard] pull treemap files
  49706. https://bugs.webkit.org/show_bug.cgi?id=55852
  49707. * TestResultServer/handlers/dashboardhandler.py:
  49708. 2011-03-03 Hayato Ito <hayato@chromium.org>
  49709. Reviewed by Mihai Parparita.
  49710. [NRWT] Clear output image file used by DumpRenderTree to make sure the
  49711. previous image should not be used in the ChromiumDriver.
  49712. Also make sure that output image from the ChromiumDriver should be ''
  49713. (empty string) if a test crashes for consistency with the WebKitDriver
  49714. implementation.
  49715. https://bugs.webkit.org/show_bug.cgi?id=55746
  49716. * Scripts/webkitpy/layout_tests/port/chromium.py:
  49717. 2011-03-07 Zan Dobersek <zandobersek@gmail.com>
  49718. Reviewed by Martin Robinson.
  49719. [Gtk] fast/js/navigator-language.html fails locally
  49720. https://bugs.webkit.org/show_bug.cgi?id=55880
  49721. Add LANG variable to the clean environment when running
  49722. old-run-webkit-tests script.
  49723. * Scripts/old-run-webkit-tests:
  49724. 2011-03-07 Tony Chang <tony@chromium.org>
  49725. Reviewed by Mihai Parparita.
  49726. [Chromium] Find .checksum files without .pngs and vice-versa
  49727. https://bugs.webkit.org/show_bug.cgi?id=55236
  49728. * Scripts/find-mismatched-layout-test-results: Added. A script for finding
  49729. mismatched results.
  49730. 2011-03-07 Chris Fleizach <cfleizach@apple.com>
  49731. Reviewed by Beth Dakin.
  49732. AX: WK1 needs to use the ScrollView attachment for AXScrollArea, WK2 should not use this element.
  49733. https://bugs.webkit.org/show_bug.cgi?id=55706
  49734. The rootElement in DRT should point to the scroll view. In WK1, that will be the parent of the rootObject.
  49735. * DumpRenderTree/mac/AccessibilityControllerMac.mm:
  49736. (AccessibilityController::focusedElement):
  49737. Remove FIXME comment about caching the focusedElement. In fact, we shouldn't cache this
  49738. because it could change at any time.
  49739. (AccessibilityController::rootElement):
  49740. 2011-03-07 Sam Weinig <sam@webkit.org>
  49741. Reviewed by Anders Carlsson.
  49742. Add unableToImplementPolicy callback for WebKit2 policy client
  49743. <rdar://problem/9071902>
  49744. https://bugs.webkit.org/show_bug.cgi?id=55884
  49745. * MiniBrowser/mac/BrowserWindowController.m:
  49746. (-[BrowserWindowController awakeFromNib]):
  49747. Update policy client initialization struct for new member.
  49748. 2011-03-07 Sam Weinig <sam@webkit.org>
  49749. Reviewed by Anders Carlsson.
  49750. Replace WebKit2's decidePolicyForMIMEType with decidePolicyForResponse
  49751. https://bugs.webkit.org/show_bug.cgi?id=55827
  49752. * MiniBrowser/mac/BrowserWindowController.m:
  49753. (decidePolicyForResponse):
  49754. (-[BrowserWindowController awakeFromNib]):
  49755. * TestWebKitAPI/Tests/WebKit2/PageLoadBasic.cpp:
  49756. (TestWebKitAPI::decidePolicyForResponse):
  49757. (TestWebKitAPI::TEST):
  49758. Update tools for new name.
  49759. 2011-03-06 Daniel Bates <dbates@rim.com>
  49760. Reviewed by Eric Seidel and David Kilzer.
  49761. Fix misspelled word in build-webkit's checkForJavaSDK() and sort forward declarations
  49762. https://bugs.webkit.org/show_bug.cgi?id=55503
  49763. Fix misspelled word "Dowloads" [sic] in the message printed to standard output
  49764. in checkForJavaSDK().
  49765. Also, remove extraneous space in function prototype for unlinkZeroFiles.
  49766. * Scripts/build-webkit:
  49767. 2011-03-05 Brian Weinstein <bweinstein@apple.com>
  49768. Reviewed by Sam Weinig.
  49769. Fix Web Process crashes caused by https://bugs.webkit.org/show_bug.cgi?id=53919.
  49770. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  49771. (WTR::InjectedBundlePage::willSendRequestForFrame): Retain the WKURLRequestRef returned
  49772. by willSendRequestForFrame. The API expects a retained reference to the URL request.
  49773. 2011-03-05 Ilya Sherman <isherman@chromium.org>
  49774. Reviewed by Darin Adler.
  49775. HTMLInputElement::setValue() should schedule change event when the element is focused
  49776. In service of https://code.google.com/p/chromium/issues/detail?id=42716
  49777. https://bugs.webkit.org/show_bug.cgi?id=53160
  49778. * DumpRenderTree/LayoutTestController.cpp:
  49779. (setValueForUserCallback):
  49780. (LayoutTestController::staticFunctions):
  49781. * DumpRenderTree/LayoutTestController.h:
  49782. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49783. (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  49784. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49785. (LayoutTestController::setValueForUser): Expose HTMLInputElement::setValueForUser() to tests
  49786. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  49787. (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  49788. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  49789. (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  49790. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  49791. (LayoutTestController::setValueForUser): Stubbed out; need real implementation.
  49792. 2011-03-04 Mark Rowe <mrowe@apple.com>
  49793. Reviewed by Alexey Proskuryakov.
  49794. <rdar://problem/9055252> DumpRenderTree is crashing with GuardMalloc
  49795. GuardMalloc does not expect the memory containing its malloc_zone_t to ever be read-only.
  49796. * DumpRenderTree/mac/CheckedMalloc.cpp:
  49797. (protectionOfRegion): Retrieve the protection flags for the VM region containing the given address.
  49798. (makeLargeMallocFailSilently): Save the initial protection flags, temporarily make the region writeable,
  49799. and then restore the initial protection flags when we're done.
  49800. 2011-03-04 Evan Martin <evan@chromium.org>
  49801. Reviewed by Tony Chang.
  49802. [gdb] pretty-print KURL in gdb
  49803. https://bugs.webkit.org/show_bug.cgi?id=55788
  49804. * gdb/webkit.py: extend the pretty-printers to print WTF::CString
  49805. and KURLGooglePrivate. As always, "p/r" can be used to sidestep
  49806. pretty-printing.
  49807. 2011-03-03 Timothy Hatcher <timothy@apple.com>
  49808. Update the tests that use WKPageRunJavaScriptInMainFrame use the WKSerializedScriptValueRef.
  49809. Reviewed by Darin Adler.
  49810. * TestWebKitAPI/JavaScriptTest.cpp:
  49811. (TestWebKitAPI::javaScriptCallback):
  49812. * TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp:
  49813. (TestWebKitAPI::didRunJavaScript):
  49814. * TestWebKitAPI/Tests/WebKit2/PageLoadDidChangeLocationWithinPageForFrame.cpp:
  49815. (TestWebKitAPI::nullJavaScriptCallback):
  49816. * TestWebKitAPI/Tests/WebKit2/PreventEmptyUserAgent.cpp:
  49817. (TestWebKitAPI::didRunJavaScript):
  49818. 2011-03-03 Timothy Hatcher <timothy@apple.com>
  49819. Make run-api-tests show failed if a test fails.
  49820. https://webkit.org/b/55725
  49821. Reviewed by Sam Weinig.
  49822. * Scripts/run-api-tests:
  49823. (runTest): Remove "my" from the nested $result assignment so the
  49824. check outside the condition sees the real result.
  49825. 2011-03-02 MORITA Hajime <morrita@google.com>
  49826. Reviewed by Kent Tamura.
  49827. [Chromium][DRT] WebTask should use webkit_support::TaskAdaptor
  49828. https://bugs.webkit.org/show_bug.cgi?id=55434
  49829. Changed WebTask to be a subclass of webkit_support::TaskAdaptor
  49830. and passed the object webkit_support::PostDelayedTask directly.
  49831. Note that the change keeps postTask() as is because it has a
  49832. semantics taht webkit_support::PostDelayedTask() has; It jumps to
  49833. the main thread.
  49834. * DumpRenderTree/chromium/Task.cpp:
  49835. (postDelayedTask):
  49836. * DumpRenderTree/chromium/Task.h:
  49837. (WebTask::Run):
  49838. 2011-03-03 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  49839. Reviewed by Kenneth Rohde Christiansen.
  49840. [QT] Implement mock client-based geolocation for layout testing
  49841. https://bugs.webkit.org/show_bug.cgi?id=54334
  49842. Implement testing for Client-Based geolocation for QtWebkit.
  49843. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  49844. (WebCore::DumpRenderTree::DumpRenderTree):
  49845. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  49846. (LayoutTestController::reset):
  49847. (LayoutTestController::setGeolocationPermission):
  49848. (LayoutTestController::setMockGeolocationError):
  49849. (LayoutTestController::setMockGeolocationPosition):
  49850. 2011-03-03 Sheriff Bot <webkit.review.bot@gmail.com>
  49851. Unreviewed, rolling out r80237.
  49852. http://trac.webkit.org/changeset/80237
  49853. https://bugs.webkit.org/show_bug.cgi?id=55714
  49854. Windows bots aren't ready to be core (Requested by aroben on
  49855. #webkit).
  49856. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  49857. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  49858. 2011-03-03 Mihai Parparita <mihaip@chromium.org>
  49859. Reviewed by Tony Chang.
  49860. NRWT: AttributeError: TestRunner2 instance has no attribute '_cancel_workers'
  49861. https://bugs.webkit.org/show_bug.cgi?id=55694
  49862. Fixes for interruptions in NRWT:
  49863. - Make TestRunInterruptedException be pickleable correctly (the base
  49864. Exception class defines a __reduce__ that does not include the reason)
  49865. - Fix ordering of returned arguments from TestRunner2._run_tests
  49866. (interrupted and keyboard_interrupted were reversed)
  49867. - Fix cancel_workers callsites (was using old name).
  49868. - In handle_exception re-raise actual exception instance that was thrown
  49869. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  49870. * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  49871. * Scripts/webkitpy/layout_tests/layout_package/worker.py:
  49872. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  49873. 2011-03-03 Qi Zhang <qi.2.zhang@nokia.com>
  49874. Unreviewed.
  49875. Adding myself as a committer.
  49876. * Scripts/webkitpy/common/config/committers.py:
  49877. 2011-03-03 Tony Gentilcore <tonyg@chromium.org>
  49878. Reviewed by Mihai Parparita.
  49879. Teach sheriffbot to answer whois commands
  49880. https://bugs.webkit.org/show_bug.cgi?id=55687
  49881. * Scripts/webkitpy/tool/bot/irc_command.py:
  49882. * Scripts/webkitpy/tool/bot/irc_command_unittest.py:
  49883. * Scripts/webkitpy/tool/bot/sheriffircbot_unittest.py:
  49884. 2011-03-03 Victoria Kirst <vrk@google.com>
  49885. Reviewed by Eric Carlson.
  49886. Enable media tests in chromium-gpu/test_expectations
  49887. https://bugs.webkit.org/show_bug.cgi?id=53608
  49888. Add media folder to the list of GPU test paths.
  49889. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  49890. 2011-03-03 Adam Roben <aroben@apple.com>
  49891. Work around a bug in KURL's parsing of Windows-style absolute file: URLs
  49892. Fixes <http://webkit.org/b/55674> Many tests fail in WebKit2 mode on Windows due to
  49893. incorrect parsing of absolute Windows-style file: URLs
  49894. Reviewed by Tim Hatcher.
  49895. * WebKitTestRunner/TestInvocation.cpp:
  49896. (WTR::createWKURL): Add a "localhost" host to file: URLs we create to work around
  49897. <http://webkit.org/b/55683>.
  49898. 2011-03-03 Tony Chang <tony@chromium.org>
  49899. Reviewed by Dimitri Glazkov.
  49900. [chromium] Run kill-old-processes on the chromium-win bot too
  49901. https://bugs.webkit.org/show_bug.cgi?id=55630
  49902. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  49903. * BuildSlaveSupport/win/kill-old-processes: Add wdiff.exe to the kill list.
  49904. 2011-03-03 Carlos Garcia Campos <cgarcia@igalia.com>
  49905. Reviewed by Martin Robinson.
  49906. [GTK] DRT needs implementation of EventSender.scheduleAsynchronousClick
  49907. https://bugs.webkit.org/show_bug.cgi?id=53960
  49908. * DumpRenderTree/gtk/EventSender.cpp:
  49909. (sendClick):
  49910. (scheduleAsynchronousClickCallback):
  49911. 2011-03-03 Adam Roben <aroben@apple.com>
  49912. Look for Windows-style paths when checking whether a test is an Inspector test
  49913. WTR part of <http://webkit.org/b/55672> <rdar://problem/9080867> All inspector tests time
  49914. out or crash on Windows 7 Release (WebKit2 Tests)
  49915. Reviewed by Darin Adler.
  49916. * WebKitTestRunner/TestInvocation.cpp:
  49917. (WTR::shouldOpenWebInspector): Also look for backslashes, since that's what we'll get on
  49918. Windows.
  49919. 2011-03-03 Adam Roben <aroben@apple.com>
  49920. Make Windows 7 Release (Tests) a core builder
  49921. We can probably make Windows XP Debug (Tests) a core builder, too, but we should probably
  49922. give it a few more days of greenness first.
  49923. Fixes <http://webkit.org/b/55665> Windows 7 Release (Tests) should be a core builder
  49924. Reviewed by Andreas Kling.
  49925. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  49926. (BuildBot): Added a regexp to match Windows 7 Release (Tests).
  49927. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  49928. (BuildBotTest): Updated the list of builders to match the current list on build.webkit.org.
  49929. Updated the core regexps to match the buildbot module. Updated the expected results to match
  49930. the current set of core builders.
  49931. 2011-03-03 Benjamin Poulain <benjamin.poulain@nokia.com>
  49932. Reviewed by Andreas Kling.
  49933. Adding myself as a reviewer.
  49934. * Scripts/webkitpy/common/config/committers.py:
  49935. 2011-03-03 Lukasz Slachciak <l.slachciak@samsung.com>
  49936. Reviewed by Xan Lopez.
  49937. [GTK] Extended application cache database API and added unit tests file.
  49938. https://bugs.webkit.org/show_bug.cgi?id=55335
  49939. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: removed external declaration
  49940. of webkit_application_cache_set_maximum_size due to API exposal.
  49941. 2011-03-02 Ojan Vafai <ojan@chromium.org>
  49942. Reviewed by Adam Barth.
  49943. make webkit-patch upload work for security bugs
  49944. https://bugs.webkit.org/show_bug.cgi?id=55655
  49945. The problem is that we shell out to prepare-ChangeLog,
  49946. which does not authenticate with bugzilla. All it needs from
  49947. bugzilla is the bug title though. We just pass it through from
  49948. webkit-patch instead.
  49949. * Scripts/prepare-ChangeLog:
  49950. * Scripts/webkitpy/common/net/bugzilla/bug.py:
  49951. * Scripts/webkitpy/tool/steps/preparechangelog.py:
  49952. 2011-03-01 Ojan Vafai <ojan@chromium.org>
  49953. Reviewed by Tony Chang.
  49954. [test-dashboard] make gtest JSON match layout-tests JSON
  49955. https://bugs.webkit.org/show_bug.cgi?id=55556
  49956. http://trac.webkit.org/changeset/80090 stopped converting time_ms to t.
  49957. Make this code match.
  49958. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  49959. 2011-03-02 Dirk Pranke <dpranke@chromium.org>
  49960. Reviewed by Tony Chang.
  49961. NRWT - implement Linux Hardy 64-bit port support. This involves
  49962. adding support for non-'x86' architectures and updating the
  49963. "deduplicate_tests" script to correctly understand that
  49964. port.name() is not always equal to basename(port.baseline_path()).
  49965. This change introduces two new port names: 'chromium-linux-x86'
  49966. and 'chromium-linux-x86_64'. Using the prior 'chromium-linux'
  49967. flag will cause the code to determine which one to use at
  49968. runtime, just like we currently do with 'chromium-win'.
  49969. https://bugs.webkit.org/show_bug.cgi?id=55535
  49970. * Scripts/webkitpy/common/system/executive_mock.py:
  49971. Handle 'return_stderr' keyword arg to run_command()
  49972. * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
  49973. * Scripts/webkitpy/layout_tests/deduplicate_tests_unittest.py:
  49974. * Scripts/webkitpy/layout_tests/port/base.py:
  49975. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  49976. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py:
  49977. * Scripts/webkitpy/layout_tests/port/factory.py:
  49978. * Scripts/webkitpy/layout_tests/port/google_chrome.py:
  49979. 2011-03-02 Kevin Ollivier <kevino@theolliviers.com>
  49980. [wx] Build fix, make sure we put the wxWebKit dylib in the right directory and
  49981. update symlinks accordingly.
  49982. * wx/packaging/build-mac-installer.py:
  49983. 2011-03-02 Sheriff Bot <webkit.review.bot@gmail.com>
  49984. Unreviewed, rolling out r80139.
  49985. http://trac.webkit.org/changeset/80139
  49986. https://bugs.webkit.org/show_bug.cgi?id=55620
  49987. failing and crashing tests on Snow Leopard bot (Requested by
  49988. mihaip1 on #webkit).
  49989. * DumpRenderTree/LayoutTestController.cpp:
  49990. (LayoutTestController::staticFunctions):
  49991. * DumpRenderTree/LayoutTestController.h:
  49992. * DumpRenderTree/chromium/LayoutTestController.cpp:
  49993. (LayoutTestController::LayoutTestController):
  49994. * DumpRenderTree/chromium/LayoutTestController.h:
  49995. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  49996. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  49997. * DumpRenderTree/mac/UIDelegate.h:
  49998. * DumpRenderTree/mac/UIDelegate.mm:
  49999. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  50000. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  50001. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  50002. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  50003. 2011-03-02 Adam Roben <aroben@apple.com>
  50004. Wait for force a paint in WebKitTestRunner until we're actually ready to dump the output
  50005. This matches DumpRenderTree on Windows.
  50006. Fixes <http://webkit.org/b/55469> <rdar://problem/9068539> REGRESSION (r79863): Lots of
  50007. dom/html/level2/html/HTMLFrameElement*.html tests crashing in FrameView::paintOverhangAreas
  50008. in WebKit2
  50009. Reviewed by Beth Dakin.
  50010. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50011. (WTR::InjectedBundlePage::dump): Moved code to force a paint here...
  50012. (WTR::InjectedBundlePage::didFinishLoadForFrame): ...from here.
  50013. 2011-03-02 Daniel Cheng <dcheng@chromium.org>
  50014. Reviewed by David Levin.
  50015. Add feature define for data transfer items
  50016. https://bugs.webkit.org/show_bug.cgi?id=55510
  50017. * Scripts/build-webkit:
  50018. 2011-03-02 Adam Roben <aroben@apple.com>
  50019. Look in the new-to-SnowLeopard location for crash logs on SnowLeopard and newer
  50020. ReportCrash saves logs to ~/Library/Logs/CrashReporter on Leopard, but to
  50021. ~/Library/Logs/DiagnosticReports on SnowLeopard. old-run-webkit-tests was only looking in
  50022. the former location, but was getting lucky on some SnowLeopard machines because symlinks
  50023. were being created there pointing into DiagnosticReports. For machines without these
  50024. symlinks, crash logs were not getting captured.
  50025. Fixes <http://webkit.org/b/55607> old-run-webkit-tests doesn't capture crash logs on some
  50026. SnowLeopard machines
  50027. Reviewed by Eric Seidel.
  50028. * Scripts/old-run-webkit-tests:
  50029. (captureSavedCrashLog): Look in ~/Library/Logs/DiagnosticReports on SnowLeopard and newer.
  50030. 2011-03-02 Adam Roben <aroben@apple.com>
  50031. Don't try to capture crash logs on platforms that haven't implemented that feature
  50032. Fixes <http://webkit.org/b/55504> Use of uninitialized value in numeric lt (<) at
  50033. Tools/Scripts/old-run-webkit-tests line 1778 seen on Qt bots after a crash
  50034. Reviewed by Joseph Pecoraro.
  50035. * Scripts/old-run-webkit-tests:
  50036. (captureSavedCrashLog): Bail if we don't have a crash log glob.
  50037. (findNewestFileMatchingGlob): Fix a buggy test for when no paths match the glob. This isn't
  50038. strictly required to fix bug 55504, but seems worthwhile.
  50039. 2011-01-26 John Knottenbelt <jknotten@chromium.org>
  50040. Reviewed by Dmitry Titov.
  50041. Detach Geolocation from Frame when Page destroyed.
  50042. https://bugs.webkit.org/show_bug.cgi?id=52877
  50043. Extend the layout test controller to expose the number of pending
  50044. geolocation requests, so that we can test that the requests have
  50045. been cancelled on page close.
  50046. * DumpRenderTree/LayoutTestController.cpp:
  50047. (numberOfPendingGeolocationPermissionRequestsCallback):
  50048. (LayoutTestController::staticFunctions):
  50049. * DumpRenderTree/LayoutTestController.h:
  50050. * DumpRenderTree/chromium/LayoutTestController.cpp:
  50051. (LayoutTestController::LayoutTestController):
  50052. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  50053. * DumpRenderTree/chromium/LayoutTestController.h:
  50054. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  50055. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  50056. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  50057. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  50058. * DumpRenderTree/mac/UIDelegate.h:
  50059. * DumpRenderTree/mac/UIDelegate.mm:
  50060. (-[UIDelegate numberOfPendingGeolocationPermissionRequests]):
  50061. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  50062. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  50063. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  50064. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  50065. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  50066. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  50067. (LayoutTestController::numberOfPendingGeolocationPermissionRequests):
  50068. 2011-03-01 Kent Tamura <tkent@chromium.org>
  50069. Reviewed by Dimitri Glazkov.
  50070. Assertion fails when a form validation bubble appears
  50071. https://bugs.webkit.org/show_bug.cgi?id=55550
  50072. Test: fast/forms/interactive-validation-attach-assertion.html
  50073. * DumpRenderTree/chromium/WebPreferences.cpp:
  50074. (WebPreferences::applyTo): Enable the interactive validation feature by
  50075. default. This matches to Chromium browser.
  50076. 2011-03-01 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  50077. Reviewed by Kent Tamura.
  50078. Remove efl port style exception of Webcore/JavaScriptCore
  50079. https://bugs.webkit.org/show_bug.cgi?id=55549
  50080. WebCore and JavaScriptCore need to adhere WebKit coding style.
  50081. * Scripts/webkitpy/style/checker.py:
  50082. 2011-03-01 Tony Chang <tony@chromium.org>
  50083. Reviewed by Ojan Vafai.
  50084. [chromium] clean up temp files on chromium-mac builder too
  50085. https://bugs.webkit.org/show_bug.cgi?id=55525
  50086. * BuildSlaveSupport/chromium/remove-crash-logs:
  50087. 2011-02-28 Ojan Vafai <ojan@chromium.org>
  50088. Reviewed by Tony Chang.
  50089. wrap json in a function call to afford cross-domain loading
  50090. https://bugs.webkit.org/show_bug.cgi?id=55353
  50091. Also delete the code that compacts the JSON. It turns out this
  50092. breaks the rebaseline tool and is probably a premature optimization anyways.
  50093. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  50094. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  50095. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  50096. * Scripts/webkitpy/tool/commands/rebaselineserver.py:
  50097. 2011-03-01 Sheriff Bot <webkit.review.bot@gmail.com>
  50098. Unreviewed, rolling out r80079.
  50099. http://trac.webkit.org/changeset/80079
  50100. https://bugs.webkit.org/show_bug.cgi?id=55547
  50101. "Broke the Win debug build?" (Requested by dcheng on #webkit).
  50102. * Scripts/build-webkit:
  50103. 2011-03-01 Mark Rowe <mrowe@apple.com>
  50104. Reviewed by Sam Weinig.
  50105. Update verification scripts to handle WebKit2.
  50106. * Scripts/check-for-global-initializers: Skip object files that use RefCountedLeakChecker.
  50107. * Scripts/check-for-inappropriate-files-in-framework: Add some inappropriate file types for
  50108. WebKit2.
  50109. 2011-03-01 Daniel Cheng <dcheng@chromium.org>
  50110. Reviewed by David Levin.
  50111. Add feature define for data transfer items
  50112. https://bugs.webkit.org/show_bug.cgi?id=55510
  50113. * Scripts/build-webkit:
  50114. 2011-02-23 Joseph Pecoraro <joepeck@webkit.org>
  50115. Reviewed by Timothy Hatcher.
  50116. All Console Messages should be passed to ChromeClients.
  50117. https://bugs.webkit.org/show_bug.cgi?id=54926
  50118. Update DumpRenderTree's UIDelegate to use the new console message delegate.
  50119. * DumpRenderTree/mac/UIDelegate.mm:
  50120. (-[UIDelegate webView:addMessageToConsole:withSource:]):
  50121. 2011-03-01 Dirk Pranke <dpranke@chromium.org>
  50122. Reviewed by Adam Barth.
  50123. Tragically, we stopped running the python unit tests
  50124. on Chromium Win just as I was getting them to be green.
  50125. This patch turns them back on.
  50126. https://bugs.webkit.org/show_bug.cgi?id=55521
  50127. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  50128. 2011-03-01 Dirk Pranke <dpranke@chromium.org>
  50129. Reviewed by Adam Roben.
  50130. Disable
  50131. webkitpy.common.system.executive_unittest.ExecutiveTest.\
  50132. test_kill_all fails on win until it can be properly triaged.
  50133. https://bugs.webkit.org/show_bug.cgi?id=54790
  50134. * Scripts/webkitpy/common/system/executive_unittest.py:
  50135. 2011-03-01 Helder Correia <helder@sencha.com>
  50136. Unreviewed. Add myself to committers.py.
  50137. * Scripts/webkitpy/common/config/committers.py:
  50138. 2011-03-01 Adam Roben <aroben@apple.com>
  50139. Give up if a crash log for the web process is taking too long to be saved on Windows
  50140. This should keep the bots from getting stuck while waiting for a crash log, if writing a
  50141. crash log ever hangs or the UI process for some reason doesn't notice it's finished.
  50142. Fixes <http://webkit.org/b/55499> WebKitTestRunner can hang forever waiting for a crash log
  50143. to be saved for the web process
  50144. Reviewed by Steve Falkenburg.
  50145. * WebKitTestRunner/win/TestControllerWin.cpp:
  50146. (WTR::runRunLoopUntil): Moved code to run the run loop here here from platformRunUntil.
  50147. Generalized the code slightly to handle the optional object to wait on.
  50148. (WTR::TestController::platformRunUntil): Use the new runRunLoopUntil function, and also use
  50149. it (with a timeout) when waiting for a crash log for the web process to be saved. This will
  50150. prevent us from waiting forever.
  50151. 2011-03-01 Adam Roben <aroben@apple.com>
  50152. Give WebKitLauncherWin's PDB file a name different from WebKit's
  50153. WebKitLauncherWin (which builds WebKit.exe) and WebKit (which builds WebKit.dll) were
  50154. fighting over the same PDB file, meaning that one of them was going to lose and not have
  50155. symbols. WebKitLauncherWin's PDB file is now named WebKitLauncherWin.pdb.
  50156. Fixes <http://webkit.org/b/55495> Crashes in WebKit.dll have bad backtraces for some test
  50157. runs (due to missing symbols)
  50158. Reviewed by David Kilzer.
  50159. * WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Use the project name,
  50160. "WebKitLauncherWin", instead of the target name, "WebKit", when naming the PDB file.
  50161. 2011-03-01 Adam Roben <aroben@apple.com>
  50162. Count web process crashes toward the --exit-after-n-crashes-or-timeouts limit
  50163. Fixes <http://webkit.org/b/55492> Web process crashes aren't counted toward the
  50164. --exit-after-n-crashes-or-timeouts limit
  50165. Reviewed by David Kilzer.
  50166. * Scripts/old-run-webkit-tests:
  50167. (stopRunningTestsEarlyIfNeeded): Include web process crashes in the computation, and print
  50168. the number of tests that caused the web process to crash when exiting early.
  50169. 2011-03-01 Adam Roben <aroben@apple.com>
  50170. Save a crash log when the web process crashes
  50171. On Windows, WebKitTestRunner now detects when the web process is crashing and waits to exit
  50172. until it has finished crashing, which guarantees that the crash log will have had time to be
  50173. saved, too. On Mac, we always wait until ReportCrash has exited before capturing the crash
  50174. log, so all we have to do is choose the right crash log out of the CrashReporter directory.
  50175. Fixes <http://webkit.org/b/44121> <rdar://problem/8320759> When the web process crashes and
  50176. a crash log is being saved, WebKitTestRunner thinks the web process has become unresponsive
  50177. Reviewed by Sam Weinig.
  50178. * Scripts/old-run-webkit-tests:
  50179. (testCrashedOrTimedOut): Don't kill WebKitTestRunner when the web process crashes. It will
  50180. kill itself. On Windows, this will cause us to wait until the crash log has been saved. On
  50181. Mac, it should have no effect. Capture saved crash logs for web process crashes, too.
  50182. (captureSavedCrashLog): Added $webProcessCrashed argument. On Mac, look for
  50183. WebProces_*.crash files when the web process crashes.
  50184. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  50185. (WTR::InjectedBundle::initialize): Added an initializationUserData argument. Updated for
  50186. initializePlatformDefaults -> platformInitialize rename. Pass the initializationUserData
  50187. along to platformInitialize.
  50188. * WebKitTestRunner/InjectedBundle/InjectedBundle.h: See above.
  50189. * WebKitTestRunner/InjectedBundle/InjectedBundleMain.cpp:
  50190. (WKBundleInitialize): Pass along the initializationUserData to the InjectedBundle.
  50191. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
  50192. (WTR::InjectedBundle::platformInitialize):
  50193. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
  50194. (WTR::InjectedBundle::platformInitialize):
  50195. Updated function signature.
  50196. * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp:
  50197. (WTR::exceptionFilter): Added. Tells the UI process we're crashing by signaling the
  50198. webProcessCrashingEvent, then lets the crash continue as normal.
  50199. (WTR::InjectedBundle::platformInitialize): Hook up exceptionFilter. Retrieve the name of the
  50200. event we should use to tell the UI process we're crashing from the initializationUserData,
  50201. and get a handle to that event.
  50202. * WebKitTestRunner/TestController.cpp:
  50203. (WTR::TestController::TestController): Initialize new members.
  50204. (WTR::TestController::processDidCrash): Removed unnecessary WKPageRef argument. Changed to
  50205. only print the "#CRASHED - WebProcess" message once, since this can be called more than once
  50206. when a crash log is being saved on Windows. Exit right away if specified. (This is the
  50207. default.)
  50208. * WebKitTestRunner/TestController.h: Added new members.
  50209. * WebKitTestRunner/win/TestControllerWin.cpp:
  50210. (WTR::TestController::platformInitialize): Set up the event the web process will use to tell
  50211. us it's crashing.
  50212. (WTR::TestController::platformRunUntil): Pass MWMO_INPUTAVAILABLE to
  50213. ::MsgWaitForMultipleObjectsEx so we'll process messages that have already been seen by
  50214. ::PeekMessage. (This is unrelated to the bug fix.) Notice when the webProcessCrashingEvent
  50215. has been signaled. When this happens, print the "#CRASHED - WebProcess" message right away
  50216. so the test harness will know the web process has crashed and not try to kill us, then wait
  50217. for the web process to finish crashing so a crash log will have time to be saved.
  50218. (WTR::toWK): Simple hepler function.
  50219. (WTR::TestController::platformInitializeContext): Pass along the name of the event the web
  50220. process should use to tell us it is crashing in the context's initialization user data.
  50221. 2011-03-01 Dimitri Glazkov <dglazkov@chromium.org>
  50222. Reviewed by Tony Gentilcore.
  50223. Move the checks to exclude Python/Perl tests for Chromium Win build to the right place.
  50224. https://bugs.webkit.org/show_bug.cgi?id=55476
  50225. Chromium Win uses BuildAndTestFactory, not TestFactory.
  50226. * BuildSlaveSupport/build.webkit.org-config/master.cfg: Moved to the right place.
  50227. 2011-03-01 Adam Roben <aroben@apple.com>
  50228. Test that the WebKit2 responsiveness timer doesn't fire too early
  50229. Test for <http://webkit.org/b/55417> <rdar://problem/9065287> RunLoop::Timer fires 1000x too
  50230. early on Windows
  50231. Reviewed by Anders Carlsson.
  50232. * TestWebKitAPI/PlatformUtilities.h: Added sleep().
  50233. * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly.cpp: Added.
  50234. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  50235. (TestWebKitAPI::didFinishLoadForFrame):
  50236. (TestWebKitAPI::processDidBecomeUnresponsive):
  50237. (TestWebKitAPI::setInjectedBundleClient):
  50238. (TestWebKitAPI::setPageLoaderClient):
  50239. Simple helper functions.
  50240. (TestWebKitAPI::TEST): Load an HTML file to make sure the web process is initialized. Then
  50241. tell the web process to pause and press the spacebar key. The spacebar keypress should cause
  50242. the responsiveness timer to start, but the web process should unpause before it has a chance
  50243. to fire. Run until the web process has unpaused, and assert that the timer didn't fire.
  50244. * TestWebKitAPI/Tests/WebKit2/ResponsivenessTimerDoesntFireEarly_Bundle.cpp: Added.
  50245. (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::ResponsivenessTimerDoesntFireEarlyTest):
  50246. Call up to the base class.
  50247. (TestWebKitAPI::ResponsivenessTimerDoesntFireEarlyTest::didReceiveMessage): When asked to
  50248. pause, sleep for 0.5 seconds, then send back a message saying we paused.
  50249. * TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
  50250. (TestWebKitAPI::Util::sleep): Added. Calls through to usleep.
  50251. * TestWebKitAPI/win/PlatformUtilitiesWin.cpp:
  50252. (TestWebKitAPI::Util::sleep): Added. Calls through to ::Sleep.
  50253. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  50254. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  50255. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  50256. Added new files.
  50257. 2011-03-01 Andras Becsi <abecsi@webkit.org>
  50258. Reviewed by Csaba Osztrogonác.
  50259. [Qt] Clean up the project files and move common options to WebKit.pri.
  50260. * WebKitTestRunner/qt/WebKitTestRunner.pro: Deduplicate.
  50261. 2011-03-01 Adam Roben <aroben@apple.com>
  50262. Skip another multiprocessing test on Windows
  50263. It is sometimes failing (and may be leaving child Python processes around).
  50264. <http://webkit.org/b/55087> tracks the failure.
  50265. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  50266. (FuncitonTests.test_get__processes): Skip this test on Windows.
  50267. 2011-03-01 Ilya Tikhonovsky <loislo@chromium.org>
  50268. Reviewed by Pavel Feldman.
  50269. Web Inspector: reduce inspector tests flakiness.
  50270. https://bugs.webkit.org/show_bug.cgi?id=55401
  50271. * DumpRenderTree/chromium/TestShell.cpp:
  50272. (TestShell::runFileTest):
  50273. * DumpRenderTree/chromium/WebPreferences.cpp:
  50274. (WebPreferences::reset):
  50275. 2011-02-28 Mihai Parparita <mihaip@chromium.org>
  50276. Reviewed by James Robinson.
  50277. NRWT should still upload results when it exits early due to too many failures
  50278. https://bugs.webkit.org/show_bug.cgi?id=55432
  50279. Only keyboard interrupts should prevent results from being uploaded.
  50280. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  50281. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  50282. 2011-02-28 Alice Liu <alice.liu@apple.com>
  50283. Reviewed by Adam Roben and Gavin Barraclough.
  50284. Test for https://bugs.webkit.org/show_bug.cgi?id=54898
  50285. InjectedBundleNodeHandle dies too early in WKBundleHitTestResultGetNodeHandle.
  50286. * TestWebKitAPI/InjectedBundleController.h:
  50287. (TestWebKitAPI::InjectedBundleController::bundle):
  50288. * TestWebKitAPI/PlatformWebView.h:
  50289. * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle.cpp: Added.
  50290. (TestWebKitAPI::didFinishLoadForFrame):
  50291. (TestWebKitAPI::didReceiveMessageFromInjectedBundle):
  50292. (TestWebKitAPI::setPageLoaderClient):
  50293. (TestWebKitAPI::TEST):
  50294. * TestWebKitAPI/Tests/WebKit2/HitTestResultNodeHandle_Bundle.cpp: Added.
  50295. (TestWebKitAPI::HitTestResultNodeHandleTest::HitTestResultNodeHandleTest):
  50296. (TestWebKitAPI::HitTestResultNodeHandleTest::getContextMenuFromDefaultMenu):
  50297. (TestWebKitAPI::HitTestResultNodeHandleTest::didCreatePage):
  50298. * TestWebKitAPI/mac/PlatformWebViewMac.mm:
  50299. (TestWebKitAPI::PlatformWebView::simulateRightClick):
  50300. * TestWebKitAPI/win/PlatformWebViewWin.cpp:
  50301. (TestWebKitAPI::PlatformWebView::simulateRightClick):
  50302. Added files to:
  50303. * TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  50304. * TestWebKitAPI/win/TestWebKitAPI.vcproj:
  50305. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj:
  50306. 2011-02-28 Adam Roben <aroben@apple.com>
  50307. Start running InjectedBundle API tests on Windows
  50308. A new project, TestWebKitAPIInjectedBundle, builds the injected bundle DLL.
  50309. Fixes <http://webkit.org/b/55420> run-api-tests doesn't run injected bundle tests on Windows
  50310. Reviewed by Darin Adler.
  50311. * TestWebKitAPI/Configurations/TestWebKitAPIDebug.vsprops: Added.
  50312. * TestWebKitAPI/Configurations/TestWebKitAPIDebugAll.vsprops: Added.
  50313. * TestWebKitAPI/Configurations/TestWebKitAPIDebugCairoCFLite.vsprops: Added.
  50314. * TestWebKitAPI/Configurations/TestWebKitAPIRelease.vsprops: Added.
  50315. * TestWebKitAPI/Configurations/TestWebKitAPIReleaseCairoCFLite.vsprops: Added.
  50316. These are just extracted from TestWebKitAPI.vcproj.
  50317. * TestWebKitAPI/Configurations/TestWebKitAPIInjectedBundleCommon.vsprops: Added. Just sets
  50318. up the DLL's filename.
  50319. * TestWebKitAPI/win/PlatformUtilitiesWin.cpp: Fixed DLL name.
  50320. (TestWebKitAPI::Util::createInjectedBundlePath): Changed to use kCFAllocatorNull instead of
  50321. 0 (== kCFAllocatorDefault) so that CF won't try to deallocate our C string.
  50322. * TestWebKitAPI/win/TestWebKitAPI.sln: Added TestWebKitAPIInjectedBundle. Removed the bogus
  50323. "all" configuration.
  50324. * TestWebKitAPI/win/TestWebKitAPI.vcproj: Changed to use the new .vsprops files. Added
  50325. injected bundle tests. Let VS resort things.
  50326. * TestWebKitAPI/win/TestWebKitAPIInjectedBundle.vcproj: Copied from Tools/TestWebKitAPI/win/TestWebKitAPI.vcproj.
  50327. 2011-02-28 Adam Roben <aroben@apple.com>
  50328. Add a test for the paint rect passed via WM_PAINT to windowless plugins
  50329. Test for <http://webkit.org/b/55365> <rdar://problem/9031089> REGRESSION (r79040): WebKit2:
  50330. Large portions of pages with plugins paint black
  50331. Reviewed by Anders Carlsson.
  50332. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  50333. (PluginTest::NPP_HandleEvent):
  50334. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  50335. Added NPP_HandleEvent. Just returns 0 at this level.
  50336. * DumpRenderTree/TestNetscapePlugIn/Tests/win/WindowlessPaintRectCoordinates.cpp: Added.
  50337. (WindowlessPaintRectCoordinates::WindowlessPaintRectCoordinates): Call up to the base class.
  50338. (WindowlessPaintRectCoordinates::NPP_New): Mark ourselves as windowless.
  50339. (WindowlessPaintRectCoordinates::NPP_HandleEvent): Check that the paint rect passed via
  50340. WM_PAINT has the expected coordinates.
  50341. * DumpRenderTree/TestNetscapePlugIn/main.cpp:
  50342. (NPP_HandleEvent): Give the PluginTest a chance to handle the event before doing anything
  50343. else.
  50344. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj: Added new file, let VS
  50345. resort things.
  50346. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50347. (WTR::InjectedBundlePage::didFinishLoadForFrame): Added a call to WKBundlePageForceRepaint.
  50348. This is roughly equivalent to the call to -[WebView displayIfNeeded] in -[FrameLoadDelegate
  50349. webView:didFinishLoadForFrame:] in DumpRenderTree.
  50350. * WebKitTestRunner/win/PlatformWebViewWin.cpp:
  50351. (WTR::PlatformWebView::PlatformWebView): Tell the WKView it's in a window so that plugins
  50352. can start running.
  50353. 2011-02-28 Adam Roben <aroben@apple.com>
  50354. Tell MiniBrowser's WKViews that they're in a window
  50355. Fixes <http://webkit.org/b/55364> Plugins don't work in MiniBrowser on Windows
  50356. Reviewed by Anders Carlsson.
  50357. * MiniBrowser/win/BrowserView.cpp:
  50358. (BrowserView::create): Call WKViewSetIsInWindow after creating the view.
  50359. 2011-02-28 Alexis Menard <alexis.menard@openbossa.org>
  50360. Reviewed by Csaba Osztrogonác.
  50361. The new QML tests require QML_IMPORT_PATH variable to be set in order to
  50362. load the proper plugin.
  50363. * Scripts/run-qtwebkit-tests:
  50364. 2011-02-28 Joone Hur <joone.hur@collabora.co.uk>
  50365. Unreviewed, fix spelling mistake.
  50366. hardware-accelated => hardware-accelerated.
  50367. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  50368. 2011-02-28 Kristian Amlie <kristian.amlie@nokia.com>
  50369. Reviewed by Andreas Kling.
  50370. Made sure that the build-webkit --qmake argument is always respected.
  50371. Previously, it would be respected during the build, but not during
  50372. the early feature detection. The build would also fail if qmake was
  50373. not in your path, even if you specified --qmake with a valid qmake
  50374. binary.
  50375. [Qt] WebKit patches required to work with a modularized version of Qt
  50376. https://bugs.webkit.org/show_bug.cgi?id=53916
  50377. * Scripts/build-webkit:
  50378. * Scripts/webkitdirs.pm:
  50379. 2011-02-27 Ojan Vafai <ojan@chromium.org>
  50380. Fix failing tests from http://trac.webkit.org/changeset/79837.
  50381. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  50382. This was just a mistake that would break if someone tried printing with this configuration.
  50383. * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
  50384. Method signature changed. Didn't notice that this method was being calling in a unittest.
  50385. 2011-02-24 Hayato Ito <hayato@chromium.org>
  50386. Reviewed by Eric Seidel.
  50387. [NRWT] Remove test_types/* classes.
  50388. This is the last patch in the series of efforts which tried to remove test_types classes.
  50389. A single_test_runner module will take over responsibilities of test_type classes.
  50390. From this patch, we won't display statistics per test_type even if a '--verbose' option is given.
  50391. https://bugs.webkit.org/show_bug.cgi?id=55123
  50392. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  50393. * Scripts/webkitpy/layout_tests/layout_package/test_results.py:
  50394. * Scripts/webkitpy/layout_tests/layout_package/test_results_unittest.py:
  50395. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  50396. * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  50397. * Scripts/webkitpy/layout_tests/test_types/__init__.py: Removed.
  50398. * Scripts/webkitpy/layout_tests/test_types/image_diff.py: Removed.
  50399. * Scripts/webkitpy/layout_tests/test_types/test_type_base.py: Removed.
  50400. * Scripts/webkitpy/layout_tests/test_types/test_type_base_unittest.py: Removed.
  50401. * Scripts/webkitpy/layout_tests/test_types/text_diff.py: Removed.
  50402. 2011-02-25 Ojan Vafai <ojan@chromium.org>
  50403. Reviewed by Tony Chang.
  50404. Change results.json format to the one used by unexpected_results.json
  50405. https://bugs.webkit.org/show_bug.cgi?id=52267
  50406. Also add runtimes in milliseconds to the JSON and make the output format more compact.
  50407. Named the file full_results.json to avoid conflicting with the results.json
  50408. file the test-results server currently serves up.
  50409. * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
  50410. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
  50411. * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
  50412. * Scripts/webkitpy/layout_tests/layout_package/printing.py:
  50413. * Scripts/webkitpy/layout_tests/layout_package/result_summary.py:
  50414. * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
  50415. 2011-02-27 Adam Roben <aroben@apple.com>
  50416. Followup fix to r79827
  50417. * DumpRenderTree/win/UIDelegate.cpp:
  50418. (UIDelegate::webViewAddMessageToConsole): Replaced call to urlSuitableForTestResult with
  50419. lastPathComponent. This matches what we did here before r79827, and matches Mac.
  50420. 2011-02-27 Dan Bernstein <mitz@apple.com>
  50421. Reviewed by Adam Roben.
  50422. Make bisect-builds print a trac link for the regression range
  50423. https://bugs.webkit.org/show_bug.cgi?id=55331
  50424. * Scripts/bisect-builds:
  50425. 2011-02-27 Adam Roben <aroben@apple.com>
  50426. Use iswalpha instead of isalpha when dealing with wchar_ts in EditingDelegate
  50427. Fixes <http://webkit.org/b/55062> <rdar://problem/9059907> Crash beneath
  50428. EditingDelegate::checkSpellingOfString when running fast/forms/input-text-maxlength.html or
  50429. fast/forms/input-text-paste-maxlength.html on Windows with full page heap enabled
  50430. Reviewed by Anders Carlsson.
  50431. * DumpRenderTree/win/EditingDelegate.cpp:
  50432. (indexOfFirstWordCharacter):
  50433. (wordLength):
  50434. Use iswalpha instead of isalpha, since TCHAR is really just wchar_t.
  50435. 2011-02-27 Adam Roben <aroben@apple.com>
  50436. Make ResourceLoadDelegate print URLs relative to the main resource on Windows
  50437. This matches Mac. (In fact, the code was ported from Mac!)
  50438. Fixes <http://webkit.org/b/55328> URLs printed by ResourceLoadDelegate on Windows don't
  50439. match Mac
  50440. Reviewed by Anders Carlsson.
  50441. * DumpRenderTree/win/DumpRenderTree.cpp:
  50442. (substringFromIndex): Added. Emulates -[NSString substringFromIndex:].
  50443. (urlSuitableForTestResult): Ported code from -[NSURL(DRTExtras)
  50444. _drt_descriptionSuitableForTestResult].
  50445. (cfStringRefToWString): Moved here from LayoutTestControllerWin.cpp.
  50446. * DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of cfStringRefToWString.
  50447. * DumpRenderTree/win/LayoutTestControllerWin.cpp: Moved cfStringRefToWString to
  50448. DumpRenderTree.cpp.
  50449. 2011-02-27 Adam Roben <aroben@apple.com>
  50450. Change the order of Chang Shu's email addresses so the first one is their Bugzilla username
  50451. This makes Bugzilla autocompletion work correctly.
  50452. * Scripts/webkitpy/common/config/committers.py:
  50453. 2011-02-27 Patrick Gansterer <paroga@webkit.org>
  50454. Reviewed by Andreas Kling.
  50455. [Qt] fast/loader/user-stylesheet-fast-path.html fails
  50456. https://bugs.webkit.org/show_bug.cgi?id=50911
  50457. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  50458. (LayoutTestController::setUserStyleSheetLocation):
  50459. Use QUrl::fromEncoded since the passed string is already encoded.
  50460. 2011-02-27 Adam Roben <aroben@apple.com>
  50461. Ensure $testResultsDirectory is an absolute path before setting up Windows crash log saving
  50462. Windows 7 (and maybe Vista?) launches the post-mortem debugger with a working directory that
  50463. is different from old-run-webkit-test's. Because of this, the path to the crash log file
  50464. (which is relative to $testResultsDirectory) must be an absolute path. See the bug for more
  50465. details.
  50466. Fixes <http://webkit.org/b/55318> Crash logs aren't saved on Windows 7 when a relative
  50467. --results-directory path is used (like on the test slaves)
  50468. Reviewed by Dan Bernstein.
  50469. * Scripts/old-run-webkit-tests: Moved the call to setUpWindowsCrashLogSaving after we've
  50470. made $testResultsDirectory an absolute path.
  50471. 2011-02-26 Dominic Mazzoni <dmazzoni@google.com>
  50472. Reviewed by Adam Barth.
  50473. m_dumpAccessibilityNotifications should be initialized.
  50474. https://bugs.webkit.org/show_bug.cgi?id=54874
  50475. * DumpRenderTree/chromium/AccessibilityController.cpp:
  50476. (AccessibilityController::AccessibilityController):
  50477. 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
  50478. Reviewed by Pavel Feldman.
  50479. DumpRenderTree should reset frame opener between tests.
  50480. https://bugs.webkit.org/show_bug.cgi?id=54874
  50481. Added clearOpener() calls between tests.
  50482. Some tests are using window.open() to change current window location.
  50483. This changes window.opener property whose nullity is checked before
  50484. showing xml viewer.
  50485. * DumpRenderTree/chromium/TestShell.cpp:
  50486. (TestShell::resetTestController):
  50487. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  50488. (resetDefaultsToConsistentValues):
  50489. * DumpRenderTree/mac/DumpRenderTree.mm:
  50490. (resetWebViewToConsistentStateBeforeTesting):
  50491. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  50492. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  50493. * DumpRenderTree/win/DumpRenderTree.cpp:
  50494. (resetWebViewToConsistentStateBeforeTesting):
  50495. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50496. (WTR::InjectedBundlePage::reset):
  50497. 2011-02-26 Yael Aharon <yael.aharon@nokia.com>
  50498. Reviewed by Andreas Kling.
  50499. [Qt] Fix the focus in MiniBrowser.
  50500. https://bugs.webkit.org/show_bug.cgi?id=55288
  50501. Give focus to the web view when a load starts.
  50502. * MiniBrowser/qt/BrowserWindow.cpp:
  50503. (BrowserWindow::urlChanged):
  50504. 2011-02-26 Gyuyoung Kim <gyuyoung.kim@samsung.com>
  50505. Reviewed by Adam Barth.
  50506. [EFL] Add coding style exceptions for EFL port
  50507. https://bugs.webkit.org/show_bug.cgi?id=54733
  50508. The EFL APIs use EFL naming style, which includes both lower-cased and camel-cased,
  50509. underscore-sparated values. But, style checking rule have found parameter_name errors
  50510. in efl directories so far.
  50511. * Scripts/webkitpy/style/checker.py: Add prameter_name rule's exception and efl directories.
  50512. 2011-02-26 David Levin <levin@chromium.org>
  50513. Reviewed by Darin Adler.
  50514. check-webkit-style should check for spaces after periods in comments
  50515. https://bugs.webkit.org/show_bug.cgi?id=55253
  50516. * Scripts/webkitpy/style/checkers/cpp.py: Added the check.
  50517. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests
  50518. and fixed the name of one related test.
  50519. 2011-02-26 Kenneth Rohde Christiansen <kenneth@webkit.org>
  50520. Reviewed by Andreas Kling.
  50521. Make it possible to test the targetdensity-dpi support
  50522. https://bugs.webkit.org/show_bug.cgi?id=55142
  50523. Test the viewport meta tag feature targetdensity-dpi by
  50524. adding extra arguments to dumpConfigurationForViewport
  50525. Add the new arguments to the shared header and all
  50526. implementation.
  50527. * DumpRenderTree/LayoutTestController.cpp:
  50528. (dumpConfigurationForViewportCallback):
  50529. * DumpRenderTree/LayoutTestController.h:
  50530. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  50531. (LayoutTestController::dumpConfigurationForViewport):
  50532. * DumpRenderTree/mac/LayoutTestControllerMac.mm:
  50533. (LayoutTestController::dumpConfigurationForViewport):
  50534. * DumpRenderTree/win/LayoutTestControllerWin.cpp:
  50535. (LayoutTestController::dumpConfigurationForViewport):
  50536. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  50537. (LayoutTestController::dumpConfigurationForViewport):
  50538. * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
  50539. (LayoutTestController::dumpConfigurationForViewport):
  50540. * DumpRenderTree/qt/LayoutTestControllerQt.h:
  50541. 2011-02-26 Sheriff Bot <webkit.review.bot@gmail.com>
  50542. Unreviewed, rolling out r79764.
  50543. http://trac.webkit.org/changeset/79764
  50544. https://bugs.webkit.org/show_bug.cgi?id=55295
  50545. "broke Chromium builds" (Requested by rniwa on #webkit).
  50546. * DumpRenderTree/chromium/TestShell.cpp:
  50547. (TestShell::resetTestController):
  50548. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  50549. (resetDefaultsToConsistentValues):
  50550. * DumpRenderTree/mac/DumpRenderTree.mm:
  50551. (resetWebViewToConsistentStateBeforeTesting):
  50552. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  50553. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  50554. * DumpRenderTree/win/DumpRenderTree.cpp:
  50555. (resetWebViewToConsistentStateBeforeTesting):
  50556. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50557. (WTR::InjectedBundlePage::reset):
  50558. 2011-02-26 Yongjun Zhang <yongjun_zhang@apple.com>
  50559. Reviewed by David Kilzer.
  50560. https://bugs.webkit.org/show_bug.cgi?id=48781
  50561. Add a resource load delegate method to query if WebCore should paint the default broken image for failed images.
  50562. Add a new resource load client method (shouldPaintBrokenImage). WebKit client can decide if WebCore
  50563. should paint the default broken image when an image fails to load or decode.
  50564. * DumpRenderTree/LayoutTestController.cpp:
  50565. (LayoutTestController::LayoutTestController):
  50566. (setShouldPaintBrokenImageCallback):
  50567. (LayoutTestController::staticFunctions):
  50568. (LayoutTestController::setShouldPaintBrokenImage):
  50569. * DumpRenderTree/LayoutTestController.h:
  50570. (LayoutTestController::shouldPaintBrokenImage):
  50571. * DumpRenderTree/mac/ResourceLoadDelegate.mm:
  50572. (-[ResourceLoadDelegate webView:shouldPaintBrokenImageForURL:]):
  50573. 2011-02-26 Vsevolod Vlasov <vsevik@chromium.org>
  50574. Reviewed by Pavel Feldman.
  50575. DumpRenderTree should reset frame opener between tests.
  50576. https://bugs.webkit.org/show_bug.cgi?id=54874
  50577. Added clearOpener() calls between tests.
  50578. Some tests are using window.open() to change current window location.
  50579. This changes window.opener property whose nullity is checked before
  50580. showing xml viewer.
  50581. * DumpRenderTree/chromium/TestShell.cpp:
  50582. (TestShell::resetTestController):
  50583. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  50584. (resetDefaultsToConsistentValues):
  50585. * DumpRenderTree/mac/DumpRenderTree.mm:
  50586. (resetWebViewToConsistentStateBeforeTesting):
  50587. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  50588. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  50589. * DumpRenderTree/win/DumpRenderTree.cpp:
  50590. (resetWebViewToConsistentStateBeforeTesting):
  50591. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50592. (WTR::InjectedBundlePage::reset):
  50593. 2011-02-25 Lukasz Slachciak <l.slachciak@samsung.com>
  50594. Reviewed by Kenneth Rohde Christiansen.
  50595. [EFL] Added EWebLauncher command line option to turn on/off frame flattening
  50596. https://bugs.webkit.org/show_bug.cgi?id=54809
  50597. * EWebLauncher/main.c: Handling -f option added.
  50598. (on_key_down):
  50599. (browserCreate):
  50600. (main):
  50601. 2011-02-25 Sheriff Bot <webkit.review.bot@gmail.com>
  50602. Unreviewed, rolling out r79324.
  50603. http://trac.webkit.org/changeset/79324
  50604. https://bugs.webkit.org/show_bug.cgi?id=55260
  50605. Leopard Debug is once again running out of address space while
  50606. linking (Requested by aroben on #webkit).
  50607. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  50608. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  50609. 2011-02-25 Tony Chang <tony@chromium.org>
  50610. Reviewed by James Robinson.
  50611. Clean up temp files left by crashing DRTs on chromium-win
  50612. https://bugs.webkit.org/show_bug.cgi?id=55182
  50613. * BuildSlaveSupport/build.webkit.org-config/master.cfg:
  50614. * BuildSlaveSupport/chromium/remove-crash-logs: Added.
  50615. 2011-02-25 Adam Roben <aroben@apple.com>
  50616. Double-check that modifying the registry worked
  50617. On Windows Vista/7 with UAC enabled, regtool will fail to modify the registry, but it will
  50618. still return a successful exit code. So we double-check here that the value we tried to
  50619. write to the registry was really written.
  50620. Fixes <http://webkit.org/b/55227> old-run-webkit-tests falsely claims to be saving crash
  50621. logs on Windows Vista/7
  50622. Reviewed by Darin Adler.
  50623. * Scripts/old-run-webkit-tests:
  50624. (writeRegistryString): After trying to write the string value, check that it was really
  50625. written.
  50626. 2011-02-25 Adam Roben <aroben@apple.com>
  50627. Set the 32-bit post-mortem debugger on 64-bit OSes
  50628. The post-mortem debugger is controlled by some registry values in
  50629. HKLM\SOFTWARE\Microsoft\Windows NT\CurrentVersion\AeDebug. On 64-bit OSes, you can either
  50630. set the values in that key, which will be used for 64-bit apps, or in the equivalent key
  50631. under Wow6432Node, which will be used for 32-bit apps. Since DumpRenderTree and
  50632. WebKitTestRunner are 32-bit, we want to use the latter location.
  50633. Fixes <http://webkit.org/b/55225> old-run-webkit-tests sets the post-mortem debugger for
  50634. 64-bit apps, but should set it for 32-bit apps instead
  50635. Reviewed by Darin Adler.
  50636. * Scripts/old-run-webkit-tests:
  50637. (readRegistryString):
  50638. (writeRegistryString):
  50639. Pass --wow32 to regtool so it will get/set values beneath Wow6432Node, which is where
  50640. Windows looks for the post-mortem debugger values when a 32-bit app crashes on a 64-bit OS.
  50641. Passing --wow32 on a 32-bit OS will not have any effect.
  50642. 2011-02-25 Adam Roben <aroben@apple.com>
  50643. Clean up code to set up crash log saving on Windows
  50644. Fixes <http://webkit.org/b/55224> old-run-webkit-test's Windows registry code is ugly
  50645. Reviewed by David Kilzer.
  50646. * Scripts/old-run-webkit-tests:
  50647. (readRegistryString):
  50648. (writeRegistryString):
  50649. Moved code to read strings from and write strings to the registry here...
  50650. (setUpWindowsCrashLogSaving): ...from here.
  50651. 2011-02-25 Adam Roben <aroben@apple.com>
  50652. Work around Cygwin's crash-suppression behavior
  50653. Cygwin calls ::SetErrorMode(SEM_FAILCRITICALERRORS), which any processes it launches will
  50654. inherit. This is bad for testing/debugging, as it causes the post-mortem debugger not to be
  50655. invoked. (Cygwin does this because it makes crashes more UNIX-y.) We reset the error mode
  50656. when our test apps launch to work around Cygwin's behavior.
  50657. Fixes <http://webkit.org/b/55222> Test apps crash silently (without invoking post-mortem
  50658. debugger) when launched from Cygwin 1.7
  50659. Reviewed by Darin Adler.
  50660. * DumpRenderTree/win/DumpRenderTree.cpp:
  50661. (main):
  50662. * TestWebKitAPI/win/main.cpp:
  50663. (main):
  50664. * WebKitAPITest/main.cpp:
  50665. (main):
  50666. * WebKitTestRunner/win/TestControllerWin.cpp:
  50667. (WTR::TestController::platformInitialize):
  50668. Call ::SetErrorMode(0) to undo Cygwin's folly.
  50669. 2011-02-24 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
  50670. Reviewed by Andreas Kling.
  50671. [Qt] Revert the support for QNAM affined to a different thread.
  50672. https://bugs.webkit.org/show_bug.cgi?id=55149
  50673. Qt 4.8 will have QNAM use its own thread internally by default,
  50674. no need to keep this complexity in WebKit.
  50675. This mainly reverts:
  50676. http://trac.webkit.org/changeset/73710
  50677. http://trac.webkit.org/changeset/73712
  50678. * QtTestBrowser/launcherwindow.cpp:
  50679. (LauncherWindow::~LauncherWindow):
  50680. (LauncherWindow::initializeView):
  50681. (LauncherWindow::createChrome):
  50682. * QtTestBrowser/launcherwindow.h:
  50683. (WindowOptions::WindowOptions):
  50684. * QtTestBrowser/webpage.cpp:
  50685. (WebPage::WebPage):
  50686. * QtTestBrowser/webpage.h:
  50687. 2011-02-24 Adam Barth <abarth@webkit.org>
  50688. Reviewed by Eric Seidel.
  50689. Add a script for creating gypi files
  50690. https://bugs.webkit.org/show_bug.cgi?id=55113
  50691. This is a trivial script to create gypi files from the source code in
  50692. the current directory.
  50693. * Scripts/make-gypi: Added.
  50694. 2011-02-24 Sheriff Bot <webkit.review.bot@gmail.com>
  50695. Unreviewed, rolling out r79628.
  50696. http://trac.webkit.org/changeset/79628
  50697. https://bugs.webkit.org/show_bug.cgi?id=55195
  50698. "broke chromium win tests" (Requested by dpranke on #webkit).
  50699. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  50700. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  50701. 2011-02-24 Dirk Pranke <dpranke@chromium.org>
  50702. Reviewed by Mihai Parparita.
  50703. rebaseline-chromium-webkit-tests can't handle GPU variants
  50704. https://bugs.webkit.org/show_bug.cgi?id=55002
  50705. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  50706. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  50707. 2011-02-24 Dirk Pranke <dpranke@chromium.org>
  50708. Reviewed by Mihai Parparita.
  50709. nrwt: log command used to start web server to --verbose
  50710. https://bugs.webkit.org/show_bug.cgi?id=55188
  50711. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  50712. * Scripts/webkitpy/layout_tests/port/http_server.py:
  50713. 2011-02-24 Victoria Kirst <vrk@google.com>
  50714. Reviewed by Mihai Parparita.
  50715. [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
  50716. https://bugs.webkit.org/show_bug.cgi?id=55089
  50717. This adds an alias into the media/ directory so that http/tests/media
  50718. tests can access the media resources when running in an httpd process.
  50719. * Scripts/webkitperl/httpd.pm:
  50720. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  50721. * Scripts/webkitpy/layout_tests/port/http_server.py:
  50722. 2011-02-24 Dirk Pranke <dpranke@chromium.org>
  50723. Reviewed by Mihai Parparita.
  50724. nrwt: enable multiple processes by default on Chromium Win.
  50725. https://bugs.webkit.org/show_bug.cgi?id=55163
  50726. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  50727. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  50728. 2011-02-24 Sam Weinig <sam@webkit.org>
  50729. Attempt to fix Qt.
  50730. * WebKitTestRunner/TestInvocation.cpp:
  50731. 2011-02-24 James Robinson <jamesr@chromium.org>
  50732. Unreviewed, rolling out r79598.
  50733. http://trac.webkit.org/changeset/79598
  50734. https://bugs.webkit.org/show_bug.cgi?id=55089
  50735. Appears to be causing trouble with httpd on windows
  50736. * Scripts/webkitperl/httpd.pm:
  50737. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  50738. * Scripts/webkitpy/layout_tests/port/http_server.py:
  50739. 2011-02-24 Sam Weinig <sam@webkit.org>
  50740. Reviewed by Darin Adler.
  50741. Add basic pixel testing support to WebKitTestRunner
  50742. https://bugs.webkit.org/show_bug.cgi?id=55161
  50743. * Scripts/old-run-webkit-tests:
  50744. Don't print color space information when using WebKitTestRunner since
  50745. we don't need to change the screen.
  50746. * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
  50747. (WTR::InjectedBundle::initialize):
  50748. Add call to initializePlatformDefaults.
  50749. (WTR::InjectedBundle::done):
  50750. Return a dictionary on completion with both the text output and pixel dump override.
  50751. * WebKitTestRunner/InjectedBundle/InjectedBundle.h:
  50752. Add declaration for initializePlatformDefaults.
  50753. * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
  50754. (WTR::LayoutTestController::LayoutTestController):
  50755. (WTR::LayoutTestController::dumpAsText):
  50756. * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
  50757. (WTR::LayoutTestController::shouldDumpPixels):
  50758. Make setting dumpAsText override the dump pixels preference.
  50759. * WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm: Added.
  50760. (WTR::InjectedBundle::initializePlatformDefaults):
  50761. Set platform defaults matching DumpRenderTree.
  50762. * WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp: Added.
  50763. (WTR::InjectedBundle::initializePlatformDefaults):
  50764. * WebKitTestRunner/InjectedBundle/win/InjectedBundleWin.cpp: Added.
  50765. (WTR::InjectedBundle::initializePlatformDefaults):
  50766. Add stubs for initializePlatformDefaults.
  50767. * WebKitTestRunner/TestController.cpp:
  50768. (WTR::TestController::runTest):
  50769. (WTR::TestController::runTestingServerLoop):
  50770. (WTR::TestController::run):
  50771. Parse expected pixel results out of stdin and setup the invocation with it.
  50772. * WebKitTestRunner/TestInvocation.cpp:
  50773. (WTR::TestInvocation::TestInvocation):
  50774. Initialize new members.
  50775. (WTR::TestInvocation::~TestInvocation):
  50776. (WTR::TestInvocation::setIsPixelTest):
  50777. (WTR::sizeWebViewForCurrentTest):
  50778. (WTR::TestInvocation::invoke):
  50779. (WTR::TestInvocation::dump):
  50780. (WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
  50781. * WebKitTestRunner/TestInvocation.h:
  50782. Dump pixels in addition to text by calling dumpPixelsAndCompareWithExpected.
  50783. * WebKitTestRunner/mac/PlatformWebViewMac.mm:
  50784. (WTR::PlatformWebView::PlatformWebView):
  50785. Use -[NSColorSpace genericRGBColorSpace] instead of the main screen color space.
  50786. * WebKitTestRunner/mac/TestInvocationMac.mm: Added.
  50787. (WTR::createCGContextFromPlatformView):
  50788. (WTR::computeMD5HashStringForContext):
  50789. (WTR::dumpBitmap):
  50790. (WTR::forceRepaintFunction):
  50791. (WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
  50792. Add mac specific pixel dumping support. Right now, we always pull pixels
  50793. from the window server.
  50794. * WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  50795. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  50796. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  50797. * WebKitTestRunner/win/InjectedBundle.vcproj:
  50798. * WebKitTestRunner/win/WebKitTestRunner.vcproj:
  50799. Add new files.
  50800. 2011-02-24 Chang Shu <cshu@webkit.org>
  50801. Reviewed by Kenneth Rohde Christiansen.
  50802. [Qt] Launch MiniBrowser if the test run is WebKit2.
  50803. https://bugs.webkit.org/show_bug.cgi?id=55145
  50804. * Scripts/old-run-webkit-tests:
  50805. * Scripts/run-launcher:
  50806. * Scripts/webkitdirs.pm:
  50807. 2011-02-24 Victoria Kirst <vrk@google.com>
  50808. Reviewed by Mihai Parparita.
  50809. [chromium] Move media-file.js and video-test.js back to media/ for UILayoutTests
  50810. https://bugs.webkit.org/show_bug.cgi?id=55089
  50811. This adds an alias into the media/ directory so that http/tests/media
  50812. tests can access the media resources when running in an httpd process.
  50813. * Scripts/webkitperl/httpd.pm:
  50814. * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
  50815. * Scripts/webkitpy/layout_tests/port/http_server.py:
  50816. 2011-02-24 Andrew Wilson <atwilson@chromium.org>
  50817. Unreviewed, rolling out r79570.
  50818. http://trac.webkit.org/changeset/79570
  50819. https://bugs.webkit.org/show_bug.cgi?id=54874
  50820. Breaks chromium build because glue/mocks/mock_web_frame.h/cc
  50821. was not updated
  50822. * DumpRenderTree/chromium/TestShell.cpp:
  50823. (TestShell::resetTestController):
  50824. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  50825. (resetDefaultsToConsistentValues):
  50826. * DumpRenderTree/mac/DumpRenderTree.mm:
  50827. (resetWebViewToConsistentStateBeforeTesting):
  50828. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  50829. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  50830. * DumpRenderTree/win/DumpRenderTree.cpp:
  50831. (resetWebViewToConsistentStateBeforeTesting):
  50832. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50833. (WTR::InjectedBundlePage::reset):
  50834. 2011-02-24 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
  50835. Reviewed by Laszlo Gombos.
  50836. [Qt] add android 2.2 user agent to QtTestBrowser
  50837. https://bugs.webkit.org/show_bug.cgi?id=55085
  50838. Credit to Forrest Hodgkins to find right user-agent which works for youtube.
  50839. * QtTestBrowser/useragentlist.txt:
  50840. 2011-02-24 Adam Roben <aroben@apple.com>
  50841. Change FrameLoadDelegate to support any number of delegates with delayed work to process
  50842. This makes our behavior match Mac more closely, and allows us to remove an incorrect
  50843. assertion that was firing during some tests. (The assertion was claiming that there was
  50844. never more than one delegate with delayed work to process, but that was not the case.)
  50845. Fixes <http://webkit.org/b/55146> Assertion failure in FrameLoadDelegate::locationChangeDone
  50846. when running http/tests/navigation/back-twice-without-commit.html
  50847. Reviewed by Eric Carlson.
  50848. * DumpRenderTree/win/FrameLoadDelegate.cpp:
  50849. (delegatesWithDelayedWork): Added. Returns all FrameLoadDelegates that have delayed work to
  50850. process. A single delegate may appear in this Vector more than once (just as, on Mac, a
  50851. single delegate may have multiple performSelector requests).
  50852. (processWorkTimer): Pass the HWND to ::KillTimer, for pedantic brownie points. Added an
  50853. assertion that the timer firing is the shared process work timer. Instead of using the
  50854. single, global "delegate waiting for timer" delegate, give all delegates that have delayed
  50855. work to process a chance to process their work.
  50856. (FrameLoadDelegate::locationChangeDone): If we don't already have an active timer for
  50857. processing delayed work, create one. Then add ourselves to the delegatesWithDelayedWork
  50858. Vector so our processWork function will be called when the timer fires.
  50859. 2011-02-24 Vsevolod Vlasov <vsevik@chromium.org>
  50860. Reviewed by Alexey Proskuryakov.
  50861. DumpRenderTree should reset frame opener between tests.
  50862. https://bugs.webkit.org/show_bug.cgi?id=54874
  50863. Added clearOpener() calls between tests.
  50864. Some tests are using window.open() to change current window location.
  50865. This changes window.opener property whose nullity is checked before
  50866. showing xml viewer.
  50867. * DumpRenderTree/chromium/TestShell.cpp:
  50868. (TestShell::resetTestController):
  50869. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  50870. (resetDefaultsToConsistentValues):
  50871. * DumpRenderTree/mac/DumpRenderTree.mm:
  50872. (resetWebViewToConsistentStateBeforeTesting):
  50873. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  50874. (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
  50875. * DumpRenderTree/win/DumpRenderTree.cpp:
  50876. (resetWebViewToConsistentStateBeforeTesting):
  50877. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50878. (WTR::InjectedBundlePage::reset):
  50879. 2011-02-24 Adam Roben <aroben@apple.com>
  50880. Don't trigger Windows builds for changes to WebCore.exp.in or the top-level GNUmakefile.am
  50881. Fixes <http://webkit.org/b/55144> Windows builders should not have built r79343 or r79440,
  50882. but did
  50883. Reviewed by Anders Carlsson.
  50884. * Scripts/webkitpy/common/config/build.py:
  50885. (_should_file_trigger_build): Loosened the pattern for GNUmakefile.am to include the
  50886. top-level GNUmakefile.am, and loosened the pattern for .exp files to include WebCore.exp.in.
  50887. * Scripts/webkitpy/common/config/build_unittest.py:
  50888. (ShouldBuildTest): Added some more tests.
  50889. 2011-02-24 Andras Becsi <abecsi@webkit.org>
  50890. Reviewed by Laszlo Gombos.
  50891. [Qt] MinGW build fails to link
  50892. https://bugs.webkit.org/show_bug.cgi?id=55050
  50893. Prepend the libraries of subcomponents instead of appending them
  50894. to fix the library order according to the dependency of the libraries
  50895. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
  50896. * WebKitTestRunner/qt/WebKitTestRunner.pro:
  50897. 2011-02-24 Gabor Loki <loki@webkit.org>
  50898. Reviewed by Csaba Osztrogonác.
  50899. [Qt] Remove ARMv5 Release buildbot.
  50900. Remove ARMv5 Release buildbot, because there is very little difference
  50901. between ARMv5 and ARMv7 Release bots, and there is also very little
  50902. interest in ARMv5 build slave (compared to ARMv7).
  50903. * BuildSlaveSupport/build.webkit.org-config/config.json:
  50904. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  50905. 2011-02-22 Ojan Vafai <ojan@chromium.org>
  50906. Reviewed by Tony Chang.
  50907. fix revision number finding when creating git patches
  50908. https://bugs.webkit.org/show_bug.cgi?id=55024
  50909. HEAD~n does not walk merge commits correctly. git log however does.
  50910. * Scripts/webkitpy/common/checkout/scm.py:
  50911. * Scripts/webkitpy/common/checkout/scm_unittest.py:
  50912. 2011-02-23 Kenneth Russell <kbr@google.com>
  50913. Unreviewed, rolling out r79387.
  50914. https://bugs.webkit.org/show_bug.cgi?id=54885
  50915. Reapply the code changes from r79038 since they weren't the root
  50916. cause of the test timeouts.
  50917. * DumpRenderTree/chromium/WebViewHost.cpp:
  50918. (WebViewHost::reset):
  50919. 2011-02-23 Siddharth Mathur <siddharth.mathur@nokia.com>
  50920. Reviewed by Laszlo Gombos.
  50921. [Qt] Make sure Symbian binary UIDs are unique
  50922. * MiniBrowser/qt/MiniBrowser.pro: Resolve the UID collision with
  50923. QtTestBrowser.pro by changing the UID.
  50924. 2011-02-23 Patrick Gansterer <paroga@webkit.org>
  50925. Reviewed by Darin Adler.
  50926. Rename PLATFORM(CF) to USE(CF)
  50927. https://bugs.webkit.org/show_bug.cgi?id=53540
  50928. * DumpRenderTree/config.h:
  50929. 2011-02-23 Dirk Pranke <dpranke@chromium.org>
  50930. Reviewed by Ojan Vafai.
  50931. nrwt: turn on multiprocessing on chromium_linux, clean up unit tests for worker model defaults
  50932. https://bugs.webkit.org/show_bug.cgi?id=55016
  50933. * Scripts/webkitpy/layout_tests/port/base.py:
  50934. * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
  50935. * Scripts/webkitpy/layout_tests/port/chromium_linux_unittest.py: Added.
  50936. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  50937. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  50938. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  50939. * Scripts/webkitpy/layout_tests/port/mac.py:
  50940. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  50941. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  50942. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  50943. 2011-02-23 Tony Chang <tony@chromium.org>
  50944. Reviewed by Kent Tamura.
  50945. [chromium] DumpRenderTree --check-layout-test-sys-deps leaks 4 temp dirs
  50946. https://bugs.webkit.org/show_bug.cgi?id=55004
  50947. * DumpRenderTree/chromium/DumpRenderTree.cpp:
  50948. (WebKitSupportTestEnvironment::WebKitSupportTestEnvironment):
  50949. (WebKitSupportTestEnvironment::~WebKitSupportTestEnvironment):
  50950. (main): Use a C++ object to ensure that TearDownTestEnvironment
  50951. gets called when --check-layout-test-sys-deps is called
  50952. 2011-02-23 Gopal Raghavan <gopal.1.raghavan@nokia.com>
  50953. Reviewed by Anders Carlsson.
  50954. [Qt] [Qt] check webkit style fails in qt/tests
  50955. https://bugs.webkit.org/show_bug.cgi?id=54998
  50956. check-webkit-style was complaining about missing config.h in WebKit/qt/test/qdeclarativewebview. This patch was originally part of 50222. Reviewer suggested to split and create a separate patch for checker.
  50957. * Scripts/webkitpy/style/checker.py:
  50958. 2011-02-22 Vsevolod Vlasov <vsevik@chromium.org>
  50959. Reviewed by Pavel Feldman.
  50960. DumpRenderTree should dump as text if test path contains "dumpAsText/"
  50961. https://bugs.webkit.org/show_bug.cgi?id=54873
  50962. * DumpRenderTree/chromium/LayoutTestController.h:
  50963. (LayoutTestController::setShouldDumpAsText):
  50964. (LayoutTestController::setShouldGeneratePixelResults):
  50965. * DumpRenderTree/chromium/TestShell.cpp:
  50966. (TestShell::runFileTest):
  50967. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  50968. (shouldDumpAsText):
  50969. (dump):
  50970. (runTest):
  50971. * DumpRenderTree/mac/DumpRenderTree.mm:
  50972. (shouldDumpAsText):
  50973. (runTest):
  50974. * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
  50975. (WebCore::isDumpAsTextTest):
  50976. (WebCore::DumpRenderTree::open):
  50977. * DumpRenderTree/win/DumpRenderTree.cpp:
  50978. (shouldDumpAsText):
  50979. (runTest):
  50980. * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
  50981. (WTR::InjectedBundlePage::dump):
  50982. 2011-02-22 Kenneth Russell <kbr@google.com>
  50983. Reviewed by James Robinson.
  50984. Many tests started timing out on the chrome mac canaries around r79035
  50985. https://bugs.webkit.org/show_bug.cgi?id=54885
  50986. Revert the code changes, but not the Chromium DEPS roll, from
  50987. r79038 to see whether this clears up the timing-out tests. Was not
  50988. able to reproduce the timeouts locally with a Release mode build
  50989. of DRT (on Snow Leopard).
  50990. * DumpRenderTree/chromium/WebViewHost.cpp:
  50991. (WebViewHost::reset):
  50992. 2011-02-22 Dirk Pranke <dpranke@chromium.org>
  50993. Reviewed by James Robinson.
  50994. nrwt: --platform chromium-gpu doesn't work with --worker-model=processes
  50995. https://bugs.webkit.org/show_bug.cgi?id=55009
  50996. * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
  50997. 2011-02-18 Mihai Parparita <mihaip@chromium.org>
  50998. Reviewed by Ojan Vafai.
  50999. Default to 500 for --exit-after-n-failures
  51000. https://bugs.webkit.org/show_bug.cgi?id=54773
  51001. Make 500 the default value for --exit-after-n-failures (ORWT bots
  51002. already default to this as of r75726). Similarly, change the default for
  51003. --exit-after-n-crashes-or-timeouts to 20.
  51004. * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
  51005. 2011-02-02 Martin Robinson <mrobinson@igalia.com>
  51006. Reviewed by Xan Lopez.
  51007. [GTK] DRT needs an implementation of LayoutTestController.setSelectTrailingWhitespace
  51008. https://bugs.webkit.org/show_bug.cgi?id=53603
  51009. Add support for LayoutTestController.setSelectTrailingWhitespace by calling through
  51010. to DumpRenderTreeSupportGtk for this functionality.
  51011. * DumpRenderTree/gtk/DumpRenderTree.cpp:
  51012. (resetDefaultsToConsistentValues): Always call LayoutTestController.setSelectTrailingWhitespace to
  51013. false when reseting values between tests.
  51014. * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
  51015. (LayoutTestController::setSelectTrailingWhitespaceEnabled): Call LayoutTestController.setSelectTrailingWhitespace
  51016. with the appropriate value.
  51017. 2011-02-22 Adam Roben <aroben@apple.com>
  51018. Don't trigger a Windows build when the top-level ChangeLog changes
  51019. r79320 is an example of a change that shouldn't have built on Windows, but did, because of
  51020. this bug.
  51021. Fixes <http://webkit.org/b/54957> Windows bots build when top-level ChangeLog changes, but
  51022. shouldn't
  51023. Reviewed by Anders Carlsson.
  51024. * Scripts/webkitpy/common/config/build.py:
  51025. (_should_file_trigger_build): Modified the ChangeLog pattern to match the top-level
  51026. ChangeLog, and re-sorted it in the list.
  51027. * Scripts/webkitpy/common/config/build_unittest.py:
  51028. (ShouldBuildTest): Added a test that ChangeLogs don't trigger builds.
  51029. 2011-02-22 Sheriff Bot <webkit.review.bot@gmail.com>
  51030. Unreviewed, rolling out r78691.
  51031. http://trac.webkit.org/changeset/78691
  51032. https://bugs.webkit.org/show_bug.cgi?id=54956
  51033. Leopard Debug is successfully building again (Requested by
  51034. aroben on #webkit).
  51035. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  51036. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  51037. 2011-02-22 Ilya Tikhonovsky <loislo@chromium.org>
  51038. Reviewed by Pavel Feldman.
  51039. Web Inspector: flakyness of inspector tests.
  51040. https://bugs.webkit.org/show_bug.cgi?id=54729
  51041. As far as we have the protocol with sequence numbers we can simplify test harness support
  51042. and drop out chomium specific methods.
  51043. * DumpRenderTree/DumpRenderTree.gypi:
  51044. * DumpRenderTree/chromium/DRTDevToolsAgent.cpp:
  51045. (DRTDevToolsAgent::sendMessageToInspectorFrontend):
  51046. (DRTDevToolsAgent::runtimePropertyChanged):
  51047. (DRTDevToolsAgent::asyncCall):
  51048. (DRTDevToolsAgent::call):
  51049. * DumpRenderTree/chromium/DRTDevToolsAgent.h:
  51050. * DumpRenderTree/chromium/DRTDevToolsCallArgs.cpp: Removed.
  51051. * DumpRenderTree/chromium/DRTDevToolsCallArgs.h: Removed.
  51052. * DumpRenderTree/chromium/DRTDevToolsClient.cpp:
  51053. (DRTDevToolsClient::sendMessageToBackend):
  51054. (DRTDevToolsClient::asyncCall):
  51055. (DRTDevToolsClient::call):
  51056. * DumpRenderTree/chromium/DRTDevToolsClient.h:
  51057. 2011-02-22 Andras Becsi <abecsi@webkit.org>
  51058. Reviewed by Laszlo Gombos.
  51059. [Qt] Redesign the build system
  51060. https://bugs.webkit.org/show_bug.cgi?id=51339
  51061. Part 2.
  51062. Build WebCore as a static library, compile the WebKit API and WebKit2 API
  51063. in a final step and link to WebKit2, WebCore and JSC libraries to fix
  51064. linking issues resulting from stripped away symbols.
  51065. * WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro: Remove superfluous includepaths.
  51066. 2011-02-21 Lukasz Slachciak <l.slachciak@samsung.com>
  51067. Reviewed by Antonio Gomes.
  51068. [EFL] Restored spatial navigation option in EWebLauncher since #18662 bug is closed
  51069. https://bugs.webkit.org/show_bug.cgi?id=54806
  51070. * EWebLauncher/main.c:
  51071. (on_key_down): calling ewk_view_setting_spatial_navigation_set when "F12" pressed added.
  51072. 2011-02-21 Dirk Pranke <dpranke@chromium.org>
  51073. Reviewed by Kent Tamura.
  51074. nrwt: revert behavior on 10.5 to "old-threads". It's possible
  51075. that r79062 has introduced a bunch of flakiness, although I
  51076. can't explain why right now. This change should restore the
  51077. old behavior, and then we can look at the build logs to see
  51078. if the tests stop timing out or being flaky.
  51079. https://bugs.webkit.org/show_bug.cgi?id=54925
  51080. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  51081. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  51082. * Scripts/webkitpy/layout_tests/port/mac.py:
  51083. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  51084. 2011-02-21 Dirk Pranke <dpranke@chromium.org>
  51085. Reviewed by Dimitri Glazkov.
  51086. nrwt: fix typo causing us to try and repeatedly shut down the servers
  51087. https://bugs.webkit.org/show_bug.cgi?id=54904
  51088. * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py:
  51089. 2011-02-21 Alejandro G. Castro <alex@igalia.com>
  51090. Reviewed by Csaba Osztrogonác.
  51091. REGRESSION(r79157):
  51092. plugins/get-url-with-javascript-destroying-plugin.html make the
  51093. next test crash
  51094. https://bugs.webkit.org/show_bug.cgi?id=54863
  51095. * GNUmakefile.am:
  51096. 2011-02-20 Dirk Pranke <dpranke@chromium.org>
  51097. Reviewed by Ojan Vafai.
  51098. test-webkitpy: stop skipping a bunch of tests on win32
  51099. https://bugs.webkit.org/show_bug.cgi?id=54788
  51100. * Scripts/webkitpy/common/net/testoutputset_unittest.py:
  51101. * Scripts/webkitpy/test/main.py:
  51102. 2011-02-20 Dirk Pranke <dpranke@chromium.org>
  51103. Reviewed by Ojan Vafai.
  51104. Fix various bugs related to handling of dir separators and real
  51105. vs. fake filesystems that were causing test-webkitpy to fail
  51106. tests on win32. These bugs have a variety of causes but are
  51107. lumped together because they should be easy to review.
  51108. https://bugs.webkit.org/show_bug.cgi?id=54700
  51109. * Scripts/webkitpy/common/net/testoutput.py:
  51110. Here we were using os.path.sep but not escaping it prior to
  51111. using in a regexp, which caused bad things on win32.
  51112. * Scripts/webkitpy/common/net/testoutput_unittest.py:
  51113. Same here.
  51114. * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
  51115. Here we were using the native filesystem instead of the mock
  51116. filesystem, making some tests unnecessarily platform dependent.
  51117. Also we weren't setting the default configuration for the
  51118. TestChromiumWinPort.
  51119. * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py:
  51120. Here we *shouldn't* use os.path.join(), just so the code becomes
  51121. less platform dependent.
  51122. * Scripts/webkitpy/style/checker.py:
  51123. Here we should be using os.path.sep instead of "/"; the tests
  51124. require the native filesystem.
  51125. * Scripts/webkitpy/style/checkers/cpp_unittest.py:
  51126. Here the underlying code is using os.path.sep, so we probably
  51127. should as well.
  51128. * Scripts/webkitpy/style/test_expectations_unittest.py:
  51129. Here we should be using the filesystem hanging of the port
  51130. object (which is the mocked filesystem) rather than the native
  51131. one.
  51132. 2011-02-20 Anders Carlsson <andersca@apple.com>
  51133. Reviewed by Maciej Stachowiak.
  51134. Crash when a plug-in requests a javascript: url that destroys the plug-in
  51135. https://bugs.webkit.org/show_bug.cgi?id=54837
  51136. <rdar://problem/9005475>
  51137. Add new plug-in test.
  51138. * DumpRenderTree/DumpRenderTree.gypi:
  51139. * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  51140. * DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
  51141. (PluginTest::NPN_GetURL):
  51142. * DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
  51143. * DumpRenderTree/TestNetscapePlugIn/Tests/GetURLWithJavaScriptURLDestroyingPlugin.cpp: Added.
  51144. (GetURLWithJavaScriptURLDestroyingPlugin::GetURLWithJavaScriptURLDestroyingPlugin):
  51145. (GetURLWithJavaScriptURLDestroyingPlugin::NPP_New):
  51146. * DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
  51147. * DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  51148. 2011-02-19 Patrick Gansterer <paroga@webkit.org>
  51149. Reviewed by Andreas Kling.
  51150. Make WinCE a core builder
  51151. https://bugs.webkit.org/show_bug.cgi?id=54801
  51152. * Scripts/webkitpy/common/net/buildbot/buildbot.py:
  51153. * Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
  51154. 2011-02-19 Lukasz Slachciak <l.slachciak@samsung.com>
  51155. Reviewed by Andreas Kling.
  51156. Fixed problem with launching EWebLauncher with "run-launcher --efl". Incorrect path referring to non-existing .libs directory ws set.
  51157. https://webkit.org/b/54778
  51158. * Scripts/webkitdirs.pm:
  51159. 2011-02-18 David Levin <levin@chromium.org>
  51160. Reviewed by Eric Seidel.
  51161. check-webkit-style: Misses brace style error when the line with the { has a } in it.
  51162. https://bugs.webkit.org/show_bug.cgi?id=54769
  51163. * Scripts/webkitpy/style/checkers/cpp.py: Fixed the check for the close brace
  51164. to only look after the last open brace, so that the open brace in this line
  51165. "} else {" will still be able to trigger the error.
  51166. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added related unit tests.
  51167. 2011-02-18 Zan Dobersek <zandobersek@gmail.com>
  51168. Reviewed by Martin Robinson.
  51169. [Gtk] Re-enable meter tag support
  51170. https://bugs.webkit.org/show_bug.cgi?id=54762
  51171. Meter tag is supported on the Gtk port, enable it by default.
  51172. * Scripts/build-webkit:
  51173. 2011-02-18 David Levin <levin@chromium.org>
  51174. Reviewed by Eric Seidel.
  51175. check-webkit-style falsely complains about WebKitGTK+ public headers
  51176. https://bugs.webkit.org/show_bug.cgi?id=54650
  51177. * Scripts/webkitpy/style/checker.py: Add some exceptions for the gtk files.
  51178. * Scripts/webkitpy/style/checkers/cpp.py: Restrict the checks for WEBKIT_API
  51179. to the chromium directory (and improved the checks slightly).
  51180. * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added corresponding tests.
  51181. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51182. Reviewed by James Robinson.
  51183. new-run-webkit-tests: enable multiple processes by default on
  51184. mac. This change removes the artificial restrictions we placed
  51185. on the # of child processes we used with the old threading
  51186. model, and switches to the new message-based model and multiple
  51187. processes, where available. If multiple processes are not
  51188. available (Leopard / Python 2.5), then we use the 'inline' model
  51189. instead of the 'old-threads' model on the 'mac' port or one
  51190. process on the 'chromium-mac' port. We need additional testing
  51191. to see if the new 'threads' model works reliably and is worth
  51192. supporting, or if we should just live with things being slightly
  51193. slow.
  51194. https://bugs.webkit.org/show_bug.cgi?id=54596
  51195. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  51196. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  51197. * Scripts/webkitpy/layout_tests/port/mac.py:
  51198. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  51199. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  51200. 2011-02-18 Andrew Wilson <atwilson@chromium.org>
  51201. Unreviewed, rolling out r79047.
  51202. http://trac.webkit.org/changeset/79047
  51203. https://bugs.webkit.org/show_bug.cgi?id=54596
  51204. Broke canary bots - please watch the canaries the next time
  51205. you land this
  51206. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  51207. * Scripts/webkitpy/layout_tests/port/mac.py:
  51208. 2011-02-18 Emil A Eklund <eae@chromium.org>
  51209. Reviewed by Darin Adler.
  51210. Crash in EventHandler::sendContextMenuEventForKey
  51211. https://bugs.webkit.org/show_bug.cgi?id=54495
  51212. Add support for the context menu key (VK_APPS) to EventSender for
  51213. platforms that support the key.
  51214. * DumpRenderTree/chromium/EventSender.cpp:
  51215. (EventSender::keyDown):
  51216. * DumpRenderTree/gtk/EventSender.cpp:
  51217. (keyDownCallback):
  51218. * DumpRenderTree/qt/EventSenderQt.cpp:
  51219. (EventSender::keyDown):
  51220. * DumpRenderTree/win/EventSender.cpp:
  51221. (keyDownCallback):
  51222. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51223. Reviewed by Ojan Vafai.
  51224. new-run-webkit-tests: enable multiple processes by default on mac
  51225. https://bugs.webkit.org/show_bug.cgi?id=54596
  51226. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  51227. * Scripts/webkitpy/layout_tests/port/mac.py:
  51228. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51229. Reviewed by Adam Roben.
  51230. Skip pretty patch unit tests if ruby isn't installed.
  51231. https://bugs.webkit.org/show_bug.cgi?id=54699
  51232. * Scripts/webkitpy/common/prettypatch_unittest.py:
  51233. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51234. Reviewed by Adam Roben.
  51235. Skip mac.test_skipped_file_paths() when running on win32; the
  51236. test has hardcoded '/' directory separators and since it's a
  51237. port-specific test and we have coverage on other ports it's not
  51238. worth it to make the test more generic.
  51239. https://bugs.webkit.org/show_bug.cgi?id=54698
  51240. * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
  51241. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51242. Reviewed by Adam Roben.
  51243. Fix webkitpy.layout_tests.port.config_unittest to work on Win32.
  51244. https://bugs.webkit.org/show_bug.cgi?id=54703
  51245. * Scripts/webkitpy/layout_tests/port/config_unittest.py:
  51246. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51247. Reviewed by Adam Roben.
  51248. Change the default port we're mocking out on win32 when we
  51249. run mock_drt_unittest. Normally we'd default to the
  51250. port-specific default, but that would be "win", which doesn't
  51251. currently work.
  51252. https://bugs.webkit.org/show_bug.cgi?id=54708
  51253. * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
  51254. 2011-02-18 Kenneth Russell <kbr@google.com>
  51255. Reviewed by James Robinson.
  51256. [chromium] Clean up initialization of minimum timer interval
  51257. https://bugs.webkit.org/show_bug.cgi?id=54772
  51258. Use new GetForegroundTabTimerInterval function in webkit_support
  51259. to reset the minimum timer interval before each test.
  51260. * DumpRenderTree/chromium/WebViewHost.cpp:
  51261. (WebViewHost::reset):
  51262. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51263. Reviewed by Adam Roben.
  51264. r78494 fixed the chromium_win unittest failing under win32,
  51265. but not cygwin. This fixes cygwin as well.
  51266. https://bugs.webkit.org/show_bug.cgi?id=54652
  51267. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  51268. 2011-02-18 Dirk Pranke <dpranke@chromium.org>
  51269. Reviewed by Ojan Vafai, Mihai Parparita.
  51270. new-run-webkit-tests: r78522 made it impossible to create a
  51271. 'chromium-win' or 'chromium-mac' port; they would always get the
  51272. version tacked on to the end. It turns out that we actually need
  51273. to be able to create these ports in order for
  51274. rebaseline-chromium-webkit-tests to work correctly given the
  51275. broken coverage of our layout bots. As soon as we get SL and
  51276. Win 7 bots running reliably on the canaries, we can get rid of
  51277. this change. Note that we only need to change the chromium_mac
  51278. and win ports because linux doesn't yet use versions and that
  51279. script doesn't work with non-chromium ports.
  51280. Also, this change fixes a bug where we were using
  51281. "platform/chromium-win-win7" and
  51282. "platform/chromium-mac-snowleopard" as the baseline dirs for
  51283. Win 7 and SL; we should've been using the generic directories
  51284. instead since they are the newest versions of the os's.
  51285. https://bugs.webkit.org/show_bug.cgi?id=54691
  51286. * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
  51287. * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
  51288. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  51289. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  51290. * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
  51291. 2011-02-16 MORITA Hajime <morrita@google.com>
  51292. Reviewed by Kent Tamura.
  51293. [Chromium][DRT] some PostDelayedTask() accesses possibly dangling this pointer.
  51294. http://webkit.org/b/53899
  51295. Replaced static invocation wrappers with MethodTask objects,
  51296. which are removed on WebViewHost destructor.
  51297. * DumpRenderTree/chromium/WebViewHost.cpp:
  51298. (WebViewHost::requestCheckingOfText):
  51299. (WebViewHost::scheduleAnimation):
  51300. (WebViewHost::closeWidgetSoon):
  51301. * DumpRenderTree/chromium/WebViewHost.h:
  51302. (WebViewHost::HostMethodTask::HostMethodTask):
  51303. (WebViewHost::HostMethodTask::runIfValid):
  51304. (WebViewHost::taskList):
  51305. 2011-02-07 Hayato Ito <hayato@chromium.org>
  51306. Reviewed by Ojan Vafai.
  51307. Get rid of code which writes test results from test_type's
  51308. compare_output() method.
  51309. Writing test results now happens in single_test_runner, using
  51310. newly introduced test_result_writer module.
  51311. Subsequent patches will eliminate test_type/* classes.
  51312. https://bugs.webkit.org/show_bug.cgi?id=53908
  51313. * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
  51314. * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py: Added.
  51315. * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
  51316. * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
  51317. * Scripts/webkitpy/layout_tests/test_types/text_diff.py:
  51318. 2011-02-17 Dirk Pranke <dpranke@chromium.org>
  51319. Reviewed by Adam Roben.
  51320. Add blacklist of remaining webkitpy/* modules that fail on
  51321. Win32, so that test-webkitpy will at least run cleanly.
  51322. https://bugs.webkit.org/show_bug.cgi?id=54709
  51323. * Scripts/webkitpy/layout_tests/test/main.py:
  51324. 2011-02-17 Simon Fraser <simon.fraser@apple.com>
  51325. Reviewed by Sam Weinig.
  51326. Set a preference to ensure that scrollbars are in a predictable
  51327. state for DRT.
  51328. * DumpRenderTree/mac/DumpRenderTree.mm:
  51329. (resetDefaultsToConsistentValues):
  51330. 2011-02-17 Dirk Pranke <dpranke@chromium.org>
  51331. Reviewed by Adam Roben.
  51332. test-webkitpy doesn't work with the multiprocessing module on win32
  51333. or cygwin, so we skip it for now.
  51334. https://bugs.webkit.org/show_bug.cgi?id=54520
  51335. * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
  51336. * Scripts/webkitpy/layout_tests/layout_package/run_webkit_tests_unittest.py:
  51337. 2011-02-17 Dirk Pranke <dpranke@chromium.org>
  51338. Reviewed by Adam Roben.
  51339. Fix version, baseline_search_path for chromium-win-win7. Also
  51340. fix chromium_win_unittests, and fix port_testcase.make_port()
  51341. to correctly use the options passed into it and only set
  51342. results_directory() if necessary.
  51343. https://bugs.webkit.org/show_bug.cgi?id=54652
  51344. * Scripts/webkitpy/layout_tests/port/chromium_win.py:
  51345. * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
  51346. * Scripts/webkitpy/layout_tests/port/port_testcase.py:
  51347. 2011-02-17 Dirk Pranke <dpranke@chromium.org>
  51348. Reviewed by Ojan Vafai.
  51349. Fix a hang in new-run-webkit-tests when run with
  51350. --dry-run --worker-model=processes
  51351. https://bugs.webkit.org/show_bug.cgi?id=54595
  51352. * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
  51353. * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
  51354. 2011-02-17 Kevin Ollivier <kevino@theolliviers.com>
  51355. [wx] Build fixes after recent changes.
  51356. * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
  51357. (LayoutTestController::setMinimumTimerInterval):
  51358. * wx/build/settings.py:
  51359. 2011-02-17 Csaba Osztrogonác <ossy@webkit.org>
  51360. Reviewed by Andreas Kling.
  51361. [Qt] ImageDiff sometimes hangs
  51362. https://bugs.webkit.org/show_bug.cgi?id=54641
  51363. * DumpRenderTree/qt/ImageDiff.cpp: Clear actualImage and baselineImage after all comparison.
  51364. (main):
  51365. 2011-02-17 Peter Varga <pvarga@webkit.org>
  51366. Reviewed by Csaba Osztrogonác.
  51367. The run-sunspider --v8-suite doesn't work
  51368. https://bugs.webkit.org/show_bug.cgi?id=54660
  51369. * Scripts/run-sunspider:
  51370. 2011-02-17 Gabor Rapcsanyi <rgabor@webkit.org>
  51371. Reviewed by Csaba Osztrogonác.
  51372. [NRWT] Fix environment setup on Qt port.
  51373. https://bugs.webkit.org/show_bug.cgi?id=54549
  51374. * Scripts/webkitpy/layout_tests/port/qt.py:
  51375. 2011-02-16 Yael Aharon <yael.aharon@nokia.com>
  51376. Reviewed by Andreas Kling.
  51377. [Qt] Enable tiled backing store by default in MiniBrowser.
  51378. https://bugs.webkit.org/show_bug.cgi?id=54581
  51379. Instead of a flag to turn it on, a new flag is defined to turn
  51380. tiled backing store off.
  51381. * MiniBrowser/qt/MiniBrowserApplication.cpp:
  51382. (MiniBrowserApplication::handleUserOptions):
  51383. * MiniBrowser/qt/MiniBrowserApplication.h:
  51384. (WindowOptions::WindowOptions):
  51385. 2011-02-16 Eric Seidel <eric@webkit.org>
  51386. Reviewed by Mihai Parparita.
  51387. flaky test archive uploads are always 22 bytes long
  51388. https://bugs.webkit.org/show_bug.cgi?id=54593
  51389. Speculative fix for the 22-bytes bug.
  51390. * Scripts/webkitpy/tool/bot/flakytestreporter.py:
  51391. 2011-02-16 Anna Cavender <annacc@chromium.org>
  51392. Reviewed by Mihai Parparita.
  51393. http/tests/media should be served over HTTP (not from local file)
  51394. https://bugs.webkit.org/show_bug.cgi?id=54028
  51395. Removed special file:// treatment of http/tests/media
  51396. * Scripts/old-run-webkit-tests:
  51397. * Scripts/webkitpy/layout_tests/port/base.py:
  51398. 2011-02-16 Mihai Parparita <mihaip@chromium.org>
  51399. Reviewed by Ojan Vafai.
  51400. ChangeLog.parse_latest_entry_from_file does not handle rolled over ChangeLogs
  51401. https://bugs.webkit.org/show_bug.cgi?id=54609
  51402. r78737 rolled over ChangeLogs, and webkit-patch complains when landing
  51403. patches such as this one that are the first to add an entry to the
  51404. ChangeLog (since they don't see a second date line to know where the
  51405. entry ends).
  51406. * Scripts/webkitpy/common/checkout/changelog.py:
  51407. * Scripts/webkitpy/common/checkout/changelog_unittest.py:
  51408. == Rolled over to ChangeLog-2011-02-16 ==