vte-alt-meta-confusion.patch 2.4 KB

12345678910111213141516171819202122232425262728293031323334353637383940414243444546474849505152535455565758596061626364656667686970717273
  1. From 180dcc578e13c6096e277fb853e7162db640f207 Mon Sep 17 00:00:00 2001
  2. From: Alexandre Rostovtsev <tetromino@gentoo.org>
  3. Date: Tue, 15 Nov 2011 03:06:40 -0500
  4. Subject: [PATCH] Map both gdk's Meta and Alt to vte's Meta for >=gtk+-3.2.2
  5. compatibility
  6. Also, since VTE_META_MASK is now a mask with multiple bits set, code that
  7. compares gdk key modifiers to VTE_META_MASK by numerical equality is no
  8. longer guaranteed to work. Therefore, for such comparisons a new function,
  9. vte_keymap_fixup_modifiers, is introduced; it ensures that if any bits
  10. matching matching VTE_META_MASK are set, then all are set.
  11. https://bugzilla.gnome.org/show_bug.cgi?id=663779
  12. ---
  13. src/keymap.c | 15 +++++++++++++--
  14. src/keymap.h | 2 +-
  15. 2 files changed, 14 insertions(+), 3 deletions(-)
  16. diff --git a/src/keymap.c b/src/keymap.c
  17. index 9a21669..95b4c5b 100644
  18. --- a/src/keymap.c
  19. +++ b/src/keymap.c
  20. @@ -990,6 +990,17 @@ static const struct _vte_keymap_group {
  21. {GDK_KEY (F35), _vte_keymap_GDK_F35},
  22. };
  23. +/* Restrict modifiers to the specified mask and ensure that VTE_META_MASK,
  24. + * despite being a compound mask, is treated as indivisible. */
  25. +GdkModifierType
  26. +_vte_keymap_fixup_modifiers(GdkModifierType modifiers,
  27. + GdkModifierType mask)
  28. +{
  29. + if (modifiers & VTE_META_MASK)
  30. + modifiers |= VTE_META_MASK;
  31. + return modifiers & mask;
  32. +}
  33. +
  34. /* Map the specified keyval/modifier setup, dependent on the mode, to either
  35. * a literal string or a capability name. */
  36. void
  37. @@ -1104,7 +1115,7 @@ _vte_keymap_map(guint keyval,
  38. } else {
  39. fkey_mode = fkey_default;
  40. }
  41. - modifiers &= (GDK_SHIFT_MASK | GDK_CONTROL_MASK | VTE_META_MASK | VTE_NUMLOCK_MASK);
  42. + modifiers = _vte_keymap_fixup_modifiers(modifiers, GDK_SHIFT_MASK | GDK_CONTROL_MASK | VTE_META_MASK | VTE_NUMLOCK_MASK);
  43. /* Search for the conditions. */
  44. for (i = 0; entries[i].normal_length || entries[i].special[0]; i++)
  45. @@ -1375,7 +1386,7 @@ _vte_keymap_key_add_key_modifiers(guint keyval,
  46. return;
  47. }
  48. - switch (modifiers & significant_modifiers) {
  49. + switch (_vte_keymap_fixup_modifiers(modifiers, significant_modifiers)) {
  50. case 0:
  51. modifier = 0;
  52. break;
  53. diff --git a/src/keymap.h b/src/keymap.h
  54. index 243e22e..21d9b8e 100644
  55. --- a/src/keymap.h
  56. +++ b/src/keymap.h
  57. @@ -27,7 +27,7 @@
  58. G_BEGIN_DECLS
  59. -#define VTE_META_MASK GDK_META_MASK
  60. +#define VTE_META_MASK (GDK_META_MASK | GDK_MOD1_MASK)
  61. #define VTE_NUMLOCK_MASK GDK_MOD2_MASK
  62. /* Map the specified keyval/modifier setup, dependent on the mode, to either
  63. --
  64. 1.7.8.rc3