When viewed with shaders enabled, one side of the wagon is visibly darker than the other. This is probably due to an issue with the model files like a flipped normal.
Ideally, we need some way to convert the B3D files of the mod back into a format that Blender can import properly. This will allow us to fix this issue as well as potentially others that haven't been spotted yet. It would also help with potential art improvements because it would be easy to change the geometry and UV maps instead of being stuck with purely texture changes.
When viewed with shaders enabled, one side of the wagon is visibly darker than the other. This is probably due to an issue with the model files like a flipped normal.
Ideally, we need some way to convert the B3D files of the mod back into a format that Blender can import properly. This will allow us to fix this issue as well as potentially others that haven't been spotted yet. It would also help with potential art improvements because it would be easy to change the geometry and UV maps instead of being stuck with purely texture changes.
I tried using modlib to convert the file, but hit issues. I have posted an issue over on its GitHub: https://github.com/appgurueu/modlib/issues/9
I think it's part of the model because it's not present on the NYC subway trains and it's always the same side of the model, the left side, rather than facing a constant direction like east. Anyway I will have to wait for appguru to fix/upgrade the converter so it's going to take a while unless I try it with other programs.
I think it's part of the model because it's not present on the NYC subway trains and it's always the same side of the model, the left side, rather than facing a constant direction like east. Anyway I will have to wait for appguru to fix/upgrade the converter so it's going to take a while unless I try it with other programs.
Today brings good news: An update to modlib has made the B3D conversion process work correctly for the B3D models in this pack, making it possible to retain smooth shading.
The work in #9 was an improvement in terms of the original improvements by SylverK, however the model lost smooth shading. I also noticed some other minor issues, such as how there are now gaps in the geometry and in the upper left corner of the face of the DM wagon there is now some bad geometry which looks out of place.
It may or may not be useful to use modlib for the rest of the work to improve the TFL S7 stock models to a 'perfect' state, but I will definitely consider using modlib for any future model improvement projects such as NY Subway.
Today brings good news: An update to modlib has made the B3D conversion process work correctly for the B3D models in this pack, making it possible to retain smooth shading.
The work in #9 was an improvement in terms of the original improvements by SylverK, however the model lost smooth shading. I also noticed some other minor issues, such as how there are now gaps in the geometry and in the upper left corner of the face of the DM wagon there is now some bad geometry which looks out of place.
It may or may not be useful to use modlib for the rest of the work to improve the TFL S7 stock models to a 'perfect' state, but I will definitely consider using modlib for any future model improvement projects such as NY Subway.
I’ve started investigating the gaps and missing geometry and am making some experimental changes locally that are yielding some promising results. I’ll create a branch here for review in the next few days.
I’ve started investigating the gaps and missing geometry and am making some experimental changes locally that are yielding some promising results. I’ll create a branch here for review in the next few days.
The latest PR was good work, but there is still this triangle in the corner of the front window that really annoys me, plus some faces could benefit from smooth shading I think.
The latest PR was good work, but there is still this triangle in the corner of the front window that really annoys me, plus some faces could benefit from smooth shading I think.
Are you referring to the gray triangle? If so, I looked at the mesh for that area previously and it is part of the interior ceiling geometry. That is, the ceiling extends down into the window area and that triangle is a side panel the blocks the view into the area between the ceiling and the roof. Unfortunately, that would require some non-trivial adjustments to change. The area around the headlights, however, might be improved by a couple of small tweaks to the mesh, similar to what I did at the top. I might look into that in the near future.
Are you referring to the gray triangle? If so, I looked at the mesh for that area previously and it is part of the interior ceiling geometry. That is, the ceiling extends down into the window area and that triangle is a side panel the blocks the view into the area between the ceiling and the roof. Unfortunately, that would require some non-trivial adjustments to change. The area around the headlights, however, might be improved by a couple of small tweaks to the mesh, similar to what I did at the top. I might look into that in the near future.
When viewed with shaders enabled, one side of the wagon is visibly darker than the other. This is probably due to an issue with the model files like a flipped normal.
Ideally, we need some way to convert the B3D files of the mod back into a format that Blender can import properly. This will allow us to fix this issue as well as potentially others that haven't been spotted yet. It would also help with potential art improvements because it would be easy to change the geometry and UV maps instead of being stuck with purely texture changes.
I tried using modlib to convert the file, but hit issues. I have posted an issue over on its GitHub: https://github.com/appgurueu/modlib/issues/9
i think it's a minetest problem with entities, not sure if it depends of the train.
I think it's part of the model because it's not present on the NYC subway trains and it's always the same side of the model, the left side, rather than facing a constant direction like east. Anyway I will have to wait for appguru to fix/upgrade the converter so it's going to take a while unless I try it with other programs.
Today brings good news: An update to modlib has made the B3D conversion process work correctly for the B3D models in this pack, making it possible to retain smooth shading.
The work in #9 was an improvement in terms of the original improvements by SylverK, however the model lost smooth shading. I also noticed some other minor issues, such as how there are now gaps in the geometry and in the upper left corner of the face of the DM wagon there is now some bad geometry which looks out of place.
It may or may not be useful to use modlib for the rest of the work to improve the TFL S7 stock models to a 'perfect' state, but I will definitely consider using modlib for any future model improvement projects such as NY Subway.
I’ve started investigating the gaps and missing geometry and am making some experimental changes locally that are yielding some promising results. I’ll create a branch here for review in the next few days.
I've submitted PR 11 to address some of the remaining issues.
The latest PR was good work, but there is still this triangle in the corner of the front window that really annoys me, plus some faces could benefit from smooth shading I think.
Are you referring to the gray triangle? If so, I looked at the mesh for that area previously and it is part of the interior ceiling geometry. That is, the ceiling extends down into the window area and that triangle is a side panel the blocks the view into the area between the ceiling and the roof. Unfortunately, that would require some non-trivial adjustments to change. The area around the headlights, however, might be improved by a couple of small tweaks to the mesh, similar to what I did at the top. I might look into that in the near future.
Can we consider this issue resolved?
No, I would leave it here until someone can fix the issues I pointed out. If that never happens, not the end of the world.