#25 When all players sleep to pass the night... Soulful Jazz plays globally

Затворено
отворено пре 4 година од daniel1 · 12 коментара
daniel1 коментирира пре 4 година

As a reward for carrying our beds around with us and dutifully sleeping to keep the monsters at bay....

Much like easter eggs found in FPS games...

As a reward for carrying our beds around with us and dutifully sleeping to keep the monsters at bay.... Much like easter eggs found in FPS games...
DashHyphen2 коментирира пре 4 година

Yes Please

Yes Please
NathanS21 коментирира пре 4 година
Власник

That actually sounds really fun. Where can we find some freely licensed Jazz?

That actually sounds really fun. Where can we find some freely licensed Jazz?
NathanS21 коментирира пре 4 година
Власник

Implemented in 8a03f91aac I am very willing to replace the audio with something a little shorter and more fitting.

Implemented in 8a03f91aac653954d2e7b0b2040d8ed03abf7e6d I am very willing to replace the audio with something a little shorter and more fitting.
NathanS21 коментирира пре 4 година
Власник

If somebody wants to take a stab at making the music play ONLY when ALL players use the bed I'll gladly add it. I have no interest in coding that feature myself.

If somebody wants to take a stab at making the music play ONLY when ALL players use the bed I'll gladly add it. I have no interest in coding that feature myself.
Xachman коментирира пре 4 година

Im taking a stab.

Im taking a stab.
Xachman коментирира пре 4 година

Added PR https://notabug.org/NathanS21/Epic/pulls/48. This seems to do it for me. If I have 3 players in the game the music only plays when all 3 are in bed. No music if only 2 are in bed.

Added PR https://notabug.org/NathanS21/Epic/pulls/48. This seems to do it for me. If I have 3 players in the game the music only plays when all 3 are in bed. No music if only 2 are in bed.
NathanS21 коментирира пре 4 година
Власник

Oooh, this looks very promising. I'll have to figure out how to merge your pull request when I have local changes that haven't been committed. Guess it's time to learn a bit more about Git. :)

Oooh, this looks very promising. I'll have to figure out how to merge your pull request when I have local changes that haven't been committed. Guess it's time to learn a bit more about Git. :)
daniel1 коментирира пре 4 година
Аутор

music is currently borked - sounds like 2 tracks playing 200ms off sync

music is currently borked - sounds like 2 tracks playing 200ms off sync
Xachman коментирира пре 4 година

@NathanS21 in general I put my changes on another branch to keep master clean. I normally use git checkout -b <mybranchname> then commit those changes there. You can merge your branch into master at any time.

@NathanS21 in general I put my changes on another branch to keep master clean. I normally use ***git checkout -b &lt;mybranchname&gt;*** then commit those changes there. You can merge your branch into master at any time.
NathanS21 коментирира пре 4 година
Власник

I think I got it figured out. Also merged your changes.

I think I got it figured out. Also merged your changes.
NathanS21 затворено пре 4 година
Xachman коментирира пре 4 година

@daniel1 I think you are right about this because going back to my debugging printed lines in skip_night printed twice.

@daniel1 I think you are right about this because going back to my debugging printed lines in skip_night printed twice.
Xachman коментирира пре 4 година

@daniel1 I tested this with 3 players and the music only ever played once.

@daniel1 I tested this with 3 players and the music only ever played once.
Пријавите се да се прикључе у овом разговору.
Нема фазе
Нема одговорних
4 учесника
Учитавање...
Откажи
Сачувај
Још нема садржаја.