Would it be possible to start the game synchronously (start /wait GenshinImpact.exe %*, line 53 of launcher.bat)? The current launcher.bat behavior is asynchronous and returns immediately. However, if launcher.bat is called from another script, a synchronous launcher.bat will prevent after game clean-up from occurring prematurely.
Would it be possible to start the game synchronously (<code>start /wait GenshinImpact.exe %*</code>, line 53 of launcher.bat)? The current launcher.bat behavior is asynchronous and returns immediately. However, if launcher.bat is called from another script, a synchronous launcher.bat will prevent after game clean-up from occurring prematurely.
From a scripting perspective I can see how synchronous invocation would make the process monitoring easier. That also keeps a cmd window in the background, which could be used to close the game process in case of crashes within Wine - such as the long URL problem that was only fixed recently.
Regardless I'll wait a few days to receive more opinions on this topic before changing it, just in case there is a catch.
From a scripting perspective I can see how synchronous invocation would make the process monitoring easier. That also keeps a cmd window in the background, which could be used to close the game process in case of crashes within Wine - such as the long URL problem that was only fixed recently.
Regardless I'll wait a few days to receive more opinions on this topic before changing it, just in case there is a catch.
Would it be possible to start the game synchronously (
start /wait GenshinImpact.exe %*
, line 53 of launcher.bat)? The current launcher.bat behavior is asynchronous and returns immediately. However, if launcher.bat is called from another script, a synchronous launcher.bat will prevent after game clean-up from occurring prematurely.From a scripting perspective I can see how synchronous invocation would make the process monitoring easier. That also keeps a cmd window in the background, which could be used to close the game process in case of crashes within Wine - such as the long URL problem that was only fixed recently.
Regardless I'll wait a few days to receive more opinions on this topic before changing it, just in case there is a catch.
0468352