#15 Version 2.1 doesn't build

Closed
opened 6 years ago by mimi89999 · 4 comments

Release 2.1 doesn't build because of lint errors: https://f-droid.org/wiki/page/community.peers.internetradio/lastbuild_3

Release 2.1 doesn't build because of lint errors: https://f-droid.org/wiki/page/community.peers.internetradio/lastbuild_3
zPlus commented 6 years ago
Owner

Thank you very much @mimi89999 for reporting this issue. Unfortunately I'm not sure what is the correct way to proceed from now. As far as I understand, the problem is that some i18n strings do not have a translation. The expected behavior is to fall back to the English version.

Do I have to add these lines to my gradle?

android {
  lintOptions {
    checkReleaseBuilds false
    // Or, if you prefer, you can continue to check for errors in release builds,
      // but continue the build even when errors are found:
      abortOnError false
  }
}

or can you change this error to a warning?

Thank you very much @mimi89999 for reporting this issue. Unfortunately I'm not sure what is the correct way to proceed from now. As far as I understand, the problem is that some i18n strings do not have a translation. The expected behavior is to fall back to the English version. Do I have to add these lines to my gradle? ``` android { lintOptions { checkReleaseBuilds false // Or, if you prefer, you can continue to check for errors in release builds, // but continue the build even when errors are found: abortOnError false } } ``` or can you change this error to a warning?
Michel Le Bihan commented 6 years ago
Poster
@zPlus https://notabug.org/metadb-apps/InternetRadio/pulls/16 is a way...
zPlus commented 6 years ago
Owner

Thank you a lot for your PR! I hope it compiles now. I'll leave this thread open for now.

Thank you a lot for your PR! I hope it compiles now. I'll leave this thread open for now.
Michel Le Bihan commented 6 years ago
Poster

It builds on my machine and should also build on the server now.

It builds on my machine and should also build on the server now.
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.