#10 Grass turned black after killed a snake

Closed
opened 9 months ago by eugeneloza · 19 comments

After killing a snake, suddenly the grass tile turned dark color.

After killing a snake, suddenly the grass tile turned dark color.
eugeneloza commented 9 months ago
Poster

Same again, this time after killing a vase monster in a roguelike dungeon

Same again, this time after killing a vase monster in a roguelike dungeon
eugeneloza commented 9 months ago
Poster

More: the "black" thing is actually "pickable". After pressing Enter "pick up" sound is played and nothing is given, but the black square disappears.

More: the "black" thing is actually "pickable". After pressing Enter "pick up" sound is played and nothing is given, but the black square disappears.
eugeneloza commented 9 months ago
Poster

Hmm... I might guess that this happens when there is no adjacent tile to drop to (this and all valid nearby tiles have interactive items).

Hmm... I might guess that this happens when there is no adjacent tile to drop to (this and all valid nearby tiles have interactive items).
eugeneloza commented 9 months ago
Poster

Unfortunately there we go again (with the latest version)

Unfortunately there we go again (with the latest version)
eugeneloza commented 9 months ago
Poster

Same for bombs

Same for bombs
themightyglider commented 9 months ago
Owner

This is strange. Both bugs should already be fixed. I'll do more investigations on this.

One more question: Did de bomb on the last screenshot explode a few turns later?

This is strange. Both bugs should already be fixed. I'll do more investigations on this. One more question: Did de bomb on the last screenshot explode a few turns later?
eugeneloza commented 9 months ago
Poster

No, the bomb didn't explode and stayed this way "forever" (I didn't try to pick it up).

No, the bomb didn't explode and stayed this way "forever" (I didn't try to pick it up).
themightyglider commented 9 months ago
Owner

Then we have two bugs:

1.) Drop-methode choose invalide locations.

2.) Under rare conditions bombs tiles remain.

The first shouldn't be too difficult to fix but the second one could be really hard to find(encountered this one myself and thought I already fixed it)

Could you remember what happened before you made the screenshot? An explosion?

Then we have two bugs: 1.) Drop-methode choose invalide locations. 2.) Under rare conditions bombs tiles remain. The first shouldn't be too difficult to fix but the second one could be really hard to find(encountered this one myself and thought I already fixed it) Could you remember what happened before you made the screenshot? An explosion?
eugeneloza commented 9 months ago
Poster

Unfortunately I don't remember what happened before. There was some action, maybe, 3-4 enemies, maybe more. I think those bombs below the screenshot are the remains of the battle, but, unfortunately, I can't recall it better.

Unfortunately I don't remember what happened before. There was some action, maybe, 3-4 enemies, maybe more. I think those bombs below the screenshot are the remains of the battle, but, unfortunately, I can't recall it better.
themightyglider commented 9 months ago
Owner

I've checked out the drop-methode today but found nothing. I also tried to reproduce the bug but also failed here. It seems like this bug will be hard to fix. :/ How often does affect you?

PS: I made a little changes to how explosions work. I hope this has finally fixed the "bomb" bug.

I've checked out the drop-methode today but found nothing. I also tried to reproduce the bug but also failed here. It seems like this bug will be hard to fix. :/ How often does affect you? PS: I made a little changes to how explosions work. I hope this has finally fixed the "bomb" bug.
eugeneloza commented 9 months ago
Poster

How often - can't tell for sure, but after the first fixes it's "very rare" - just two cases total in several hours of game.

P.S. also note that in both cases there were actually "other" places to put the drop. So it's not the drop method fails in the overcrowded situation (as in first bugs), but the conditions (not considering a slime statuette or ?mushroom as an obstacle).

How often - can't tell for sure, but after the first fixes it's "very rare" - just two cases total in several hours of game. P.S. also note that in both cases there were actually "other" places to put the drop. So it's not the drop method fails in the overcrowded situation (as in first bugs), but the conditions (not considering a slime statuette or ?mushroom as an obstacle).
themightyglider commented 9 months ago
Owner

I can think of two possible ways to deal with this issue:

1.) If a location has been choosen for a drop the game can do a final check if the location is valid. If not there is no drop. This could lead to lost items in some situations but this was the same problem we had before we changed the drop-methode and it was encountered far more frequently back then.

2.) The render-methode can be changed that it allways draws the first and the last tile on the screen if more tiles are stacked. This would mean a statue (or whatever will) vanish if a item is droped on top and become visible again if this item has been picked up.

I can think of two possible ways to deal with this issue: 1.) If a location has been choosen for a drop the game can do a final check if the location is valid. If not there is no drop. This could lead to lost items in some situations but this was the same problem we had before we changed the drop-methode and it was encountered far more frequently back then. 2.) The render-methode can be changed that it allways draws the first and the last tile on the screen if more tiles are stacked. This would mean a statue (or whatever will) vanish if a item is droped on top and become visible again if this item has been picked up.
eugeneloza commented 9 months ago
Poster

Both look perfectly fine to me. As this is more than rare, then there is actually no need to think of anything fancy. Just that the black background wouldn't appear.

I think both implementations would have advantages of their own - as both increase reliability of the game itself (e.g. error might occur not only on item drop, but in some different (future as the game develops) conditions).

Both look perfectly fine to me. As this is more than rare, then there is actually no need to think of anything fancy. Just that the black background wouldn't appear. I think both implementations would have advantages of their own - as both increase reliability of the game itself (e.g. error might occur not only on item drop, but in some different (future as the game develops) conditions).
themightyglider commented 9 months ago
Owner

Okay I implemented solution 2 with my last commit. If you still have a savegame with a black tile it would be great if you could test it and give me some feedback if the bug is fixed now.

Okay I implemented solution 2 with my last commit. If you still have a savegame with a black tile it would be great if you could test it and give me some feedback if the bug is fixed now.
eugeneloza commented 9 months ago
Poster

Unfortunately I don't have a save, but maybe it's still there, as it was inside a cave (i.e. not respawning). I'll write back shortly.

Unfortunately I don't have a save, but maybe it's still there, as it was inside a cave (i.e. not respawning). I'll write back shortly.
themightyglider commented 9 months ago
Owner

If we can close this issue I will make another bugfix-release.

If we can close this issue I will make another bugfix-release.
eugeneloza commented 9 months ago
Poster

Nope, still there. I've sent you the savegame by e-mail.

P.S. For some reason the bat up there doesn't fly over the water?

Nope, still there. I've sent you the savegame by e-mail. P.S. For some reason the bat up there doesn't fly over the water?
themightyglider commented 9 months ago
Owner

Thanx for the savegame. I've checked it out . The bomb with the black background is a result of another bug and don't affected by my changes.

P.S. The bug who caused this also should be fixed now.

Thanx for the savegame. I've checked it out . The bomb with the black background is a result of another bug and don't affected by my changes. P.S. The bug who caused this also should be fixed now.
eugeneloza commented 4 months ago
Poster

Yep. Never experienced anything like that in a very long run. Closing.

Yep. Never experienced anything like that in a very long run. Closing.
Sign in to join this conversation.
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.