Home Explore Help
Register Sign In
sumpfralle
/
makefilet
Watch 3
Star 0
Fork 1
Files Issues 2 Pull Requests 0
Labels Milestones
New Issue

#35 Path to version file is Makefile-relative

Closed
opened 3 years ago by balkansalat · 1 comments
balkansalat commented 3 years ago

In release.mk#L123 the current version is retrieved by $$(git show "HEAD:$(CURRENT_VERSION_FILE)"). This only works, if make is issued from the root of the repository.

In my case, Makefile lives in a subdir of the repo, so the path $(CURRENT_VERSION_FILE) is relative to that subdir.

In [release.mk#L123](https://notabug.org/sumpfralle/makefilet/src/master/include/release.mk#L123) the current version is retrieved by `$$(git show "HEAD:$(CURRENT_VERSION_FILE)")`. This only works, if `make` is issued from the root of the repository. In my case, `Makefile` lives in a subdir of the repo, so the path `$(CURRENT_VERSION_FILE)` is relative to that subdir.
sumpfralle referenced this issue from a commit 2 years ago
fix(release): handle VERSION indicator files nested below the project root...
sumpfralle commented 2 years ago
Owner

Fixed in ac49a2b9e7.

Fixed in ac49a2b9e7b08204c0ac612b641340f330cac10a.
sumpfralle closed 2 years ago
Sign in to join this conversation.
Labels
Clear labels
No Label
Milestone
Clear milestone
No Milestone
Assignee
Clear assignee
No assignee
2 Participants
Write Preview
Loading...
Cancel
Save
There is no content yet.