#65 Work-on-code flow

Open
opened 8 months ago by fr33domlover · 1 comments

Review this

Review [this](https://git.feneas.org/jaywink/gitpub-notes#commits)
fr33domlover commented 6 months ago
Collaborator

Stuff we're doing differently

We have a Push activity for this, instead of Create. That's because those commits aren't really published by the activity, merely announced, and it's possible for a Push activity to list only a small subset of the commits that were pushed. Force-pushing also allows to push existing commits that were already created in the past.

The side effects of Push don't have anything in common with typical Create, so we didn't see a reason to use the same activity type and cause confusion (technically, everything you publish is a kind of creation e.g. you create an update or create an announcement or create an offer, but we wouldn't want Create to be the only activity type).

(There's Eat and Drink when you eat and drink; and we have Push for when you push ^_^)

Objections to using Push?

Stuff to learn from the flow diagram

  • cloneURI: Property specifying the URI for git-cloning the repo. Possibly the same URI is for pulling, and even for pushing (e.g. authenticated HTTP push). Opened separate issue #62 for this
  • forks: Property linking to a Collection of ID URIs of repos that are forks of this repo. Added this to the spec
  • patchURI: @jaywink, can you explain that one? What would the patch URI for a commit be used for? Where would it come from?
# Stuff we're doing differently We have a `Push` activity for this, instead of `Create`. That's because those commits aren't really published by the activity, merely announced, and it's possible for a Push activity to list only a small subset of the commits that were pushed. Force-pushing also allows to push existing commits that were already created in the past. The side effects of `Push` don't have anything in common with typical `Create`, so we didn't see a reason to use the same activity type and cause confusion (technically, everything you publish is a kind of creation e.g. you create an update or create an announcement or create an offer, but we wouldn't want `Create` to be the only activity type). (There's `Eat` and `Drink` when you eat and drink; and we have `Push` for when you push ^_^) Objections to using `Push`? # Stuff to learn from the flow diagram - `cloneURI`: Property specifying the URI for git-cloning the repo. Possibly the same URI is for pulling, and even for pushing (e.g. authenticated HTTP push). **Opened separate issue #62 for this** - `forks`: Property linking to a `Collection` of ID URIs of repos that are forks of this repo. **Added this to the spec** - `patchURI`: @jaywink, can you explain that one? What would the patch URI for a commit be used for? Where would it come from?
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.