The Libreboot and the osboot project's code is quite similar and having two similar code base instead of one increase maintenance costs.
It would be nice to have osboot be able to reuse libreboot and also enable users to add their own scripts as well (for instance to handle their custom configs).
The advantage of this approach are that:
It can be done incrementally
It can keep existing Libreboot and osboot policies (and so not drive away users and contributors because of that)
It can bring in new users and use cases as users will be able to use their own scripts at least to lbmk. Note that while osbmk uses lbmk's --include-extra-dir, osbmk itself doesnt implement --include-extra-dir yet. Though either lbmk could be taught to handle multiple --include-extra-dir or osbmk could implement --include-extra-dir too later on.
I've tested downloading me_cleaner from osbmk with --include-extra-dir
I've tested downloading u-boot from osbmk with --include-extra-dir
I've tested downloading u-boot from lbmk without --include-extra-dir
So if they work fine these commits could even be merged as-is (as I've tried not to break anything) but they were only made for the download script.
So if this approach is approved by the Libreboot and Osboot projects, we would still need to convert the rest of the code base to really reduce maintenance cost (though half-converted code base would still work fine).
Denis.
Hi,
The Libreboot and the osboot project's code is quite similar and having two similar code base instead of one increase maintenance costs.
It would be nice to have osboot be able to reuse libreboot and also enable users to add their own scripts as well (for instance to handle their custom configs).
The advantage of this approach are that:
* It can be done incrementally
* It can keep existing Libreboot and osboot policies (and so not drive away users and contributors because of that)
* It can bring in new users and use cases as users will be able to use their own scripts at least to lbmk. Note that while osbmk uses lbmk's --include-extra-dir, osbmk itself doesnt implement --include-extra-dir yet. Though either lbmk could be taught to handle multiple --include-extra-dir or osbmk could implement --include-extra-dir too later on.
These changes depends on the following lbmk pull request:
https://notabug.org/libreboot/lbmk/pulls/118
Note that I've done very limited tests:
* I've tested downloading me_cleaner from osbmk with --include-extra-dir
* I've tested downloading u-boot from osbmk with --include-extra-dir
* I've tested downloading u-boot from lbmk without --include-extra-dir
So if they work fine these commits could even be merged as-is (as I've tried not to break anything) but they were only made for the download script.
So if this approach is approved by the Libreboot and Osboot projects, we would still need to convert the rest of the code base to really reduce maintenance cost (though half-converted code base would still work fine).
Denis.
Hi,
The Libreboot and the osboot project's code is quite similar and having two similar code base instead of one increase maintenance costs.
It would be nice to have osboot be able to reuse libreboot and also enable users to add their own scripts as well (for instance to handle their custom configs).
The advantage of this approach are that:
These changes depends on the following lbmk pull request: https://notabug.org/libreboot/lbmk/pulls/118
Note that I've done very limited tests:
So if they work fine these commits could even be merged as-is (as I've tried not to break anything) but they were only made for the download script.
So if this approach is approved by the Libreboot and Osboot projects, we would still need to convert the rest of the code base to really reduce maintenance cost (though half-converted code base would still work fine).
Denis.
nope.