#2 getImp issue with 'getImpXgboost'

Open
opened 1 year ago by madara · 2 comments
madara commented 1 year ago

HI!

using getImpXgboost as getImp method seems raise the following traceback:

'Error in ans[as.numeric(imp$Feature) + 1] <- imp$Gain : NAs are not allowed in subscripted assignments In addition: Warning message: In getImp(cbind(x[, decReg != "Rejected"], xSha), y, ...) : NAs introduced by coercion'

of course, I converted all integer features to numeric,(i tried also to convert dataframe to matrix, but isn't here the problem) but the issue remains the same...what could be the problem? ps. with default 'getImpRfZ'method all works fine;

thanks

HI! using getImpXgboost as getImp method seems raise the following traceback: 'Error in ans[as.numeric(imp$Feature) + 1] <- imp$Gain : NAs are not allowed in subscripted assignments In addition: Warning message: In getImp(cbind(x[, decReg != "Rejected"], xSha), y, ...) : NAs introduced by coercion' of course, I converted all integer features to numeric,(i tried also to convert dataframe to matrix, but isn't here the problem) but the issue remains the same...what could be the problem? ps. with default 'getImpRfZ'method all works fine; thanks
mbq commented 1 year ago
Owner

Thanks for reporting, this is indeed a bug caused by a change in the xgboost package. Fix is on branch issue2 ( dc857ea488), you can install with

devtools::install_git('https://notabug.org/mbq/Boruta',branch='issue2')
Thanks for reporting, this is indeed a bug caused by a change in the xgboost package. Fix is on branch issue2 (https://notabug.org/mbq/Boruta/commit/dc857ea488d1771f39f0bc6ddba600b528daca80), you can install with ``` devtools::install_git('https://notabug.org/mbq/Boruta',branch='issue2') ```
madara commented 1 year ago
Poster

now works great! thanks

now works great! thanks
Sign in to join this conversation.
No Label
No Milestone
No assignee
2 Participants
Loading...
Cancel
Save
There is no content yet.