#354 ./libreboot usage blobs-discover -- broken argument helper function

Open
opened 11 months ago by zyliwax · 1 comments

This function appears to call project_action_helper "arguments" "$project" if the $project variable is not empty, which creates an infinite loop repeating the first line of the ls -A output ("bucts" in the case of 17ec0ae090)

It seems the intent of this function is to provide specific usage help for a given project and a list of projects otherwise. I have pushed a solution which simply removes this problematic line which fixes the invocation without any arguments, but more work is needed to provide project-specific argument usage.

This function appears to call `project_action_helper "arguments" "$project"` if the $project variable is not empty, which creates an infinite loop repeating the first line of the ls -A output ("bucts" in the case of 17ec0ae090) It seems the intent of this function is to provide specific usage help for a given project and a list of projects otherwise. I have pushed a solution which simply removes this problematic line which fixes the invocation without any arguments, but more work is needed to provide project-specific argument usage.
zyliwax commented 9 months ago
Poster

My apologies! I forgot to push my solution to this problem so long ago! Perhaps it's for the better since it's quite possible I unwittingly broke something more critical in the process.

I would like to take another look at this when I can to see if it's still a problem and if the code I wrote rectifies the issue. Watch this space, but not too closely.

My apologies! I forgot to push my solution to this problem so long ago! Perhaps it's for the better since it's quite possible I unwittingly broke something more critical in the process. I would like to take another look at this when I can to see if it's still a problem and if the code I wrote rectifies the issue. Watch this space, but not too closely.
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.