#335 ich9gen: please check arguments

Open
opened 2 years ago by YvanM · 0 comments
YvanM commented 2 years ago

Hi,

Currently, the ich9gen utility does not really check provided arguments. If those are not exactly --macaddress XX:XX:XX:XX:XX:XX:

  • the user does not get a warning
  • the generated file, being used in ROM and then flashed, will prevent the Ethernet card from working (at least on T400 8MB, dmesg says e1000e: NVM Cheksum Is Not Valid)

For example, the below commands:

  • ich9gen --mac-address XX:XX:XX:XX:XX:XX (the one I've done…)
  • ich9gen XX:XX:XX:XX:XX:XX

… will give the same result as running ich9gen without parameter.

Would it be possible to improve ich9gen so that arguments are verified to avoid user mistakes?

Regards, Yvan

Hi, Currently, the ich9gen utility does not really check provided arguments. If those are not **exactly** `--macaddress XX:XX:XX:XX:XX:XX`: - the user does not get a warning - the generated file, being used in ROM and then flashed, will prevent the Ethernet card from working (at least on T400 8MB, dmesg says `e1000e: NVM Cheksum Is Not Valid`) For example, the below commands: - `ich9gen --mac-address XX:XX:XX:XX:XX:XX` (the one I've done…) - `ich9gen XX:XX:XX:XX:XX:XX` … will give the same result as running `ich9gen` without parameter. Would it be possible to improve ich9gen so that arguments are verified to avoid user mistakes? Regards, Yvan
Sign in to join this conversation.
Loading...
Cancel
Save
There is no content yet.